Subject: bug#58963: closed (Re: [bug#58963] [PATCH] gnu: python-funcparserlib: Enable tests.)

From: [email-masked] (GNU bug Tracking System)
Date: Sat, 05 Nov 2022 11:01:04 +0000

Your bug report

#58963: [PATCH] gnu: python-funcparserlib: Enable tests.

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to [email-masked].

-- 
58963: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=58963
GNU Bug Tracking System
Contact [email-masked] with problems

Subject: Re: [bug#58963] [PATCH] gnu: python-funcparserlib: Enable tests.
From: Christopher Baines <[email-masked]>
To: jgart <[email-masked]>
Cc: [email-masked], [email-masked]
Date: Sat, 05 Nov 2022 12:00:29 +0100
List-Id: <debbugs-submit.debbugs.gnu.org>

jgart via Guix-patches via <[email-masked]> writes:

> * gnu/packages/python-xyz.scm (python-funcparserlib): Enable tests.
> [origin]: Use GitHub since it includes the tests unlike PyPi.
> [build-system]: Use pyproject-build-system.
> [arguments]: Run tests.
> [native-inputs]: Add python-poetry-core.
> ---
>  gnu/packages/python-xyz.scm | 25 ++++++++++++++++++-------
>  1 file changed, 18 insertions(+), 7 deletions(-)

Looks good to me, I've pushed to master as
f91713e71b6bc1222c8f5b218dede3dc7e670a3c.

Chris

Subject: [PATCH] gnu: python-funcparserlib: Enable tests.
From: jgart <[email-masked]>
To: [email-masked]
Cc: jgart <[email-masked]>
Date: Wed, 2 Nov 2022 02:03:46 -0500
List-Id: <debbugs-submit.debbugs.gnu.org>

* gnu/packages/python-xyz.scm (python-funcparserlib): Enable tests.
[origin]: Use GitHub since it includes the tests unlike PyPi.
[build-system]: Use pyproject-build-system.
[arguments]: Run tests.
[native-inputs]: Add python-poetry-core.
---
 gnu/packages/python-xyz.scm | 25 ++++++++++++++++++-------
 1 file changed, 18 insertions(+), 7 deletions(-)

diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm
index 1c2f9d7b73..eb5b74c993 100644
--- a/gnu/packages/python-xyz.scm
+++ b/gnu/packages/python-xyz.scm
@@ -25303,14 +25303,25 @@ (define-public python-funcparserlib
     (name "python-funcparserlib")
     (version "1.0.0")
     (source
-     (origin
-       (method url-fetch)
-       (uri (pypi-uri "funcparserlib" version))
-       (sha256
-        (base32 "0swbqf53x7lfnczvi566s1g3nkf5mfrxz7sbpyymricz57a3vlvx"))))
-    (build-system python-build-system)
+      (origin
+        ;; Source tarball on PyPi lacks tests.
+        (method git-fetch)
+        (uri (git-reference
+              (url "https://github.com/vlasovskikh/funcparserlib")
+              (commit version)))
+        (file-name (git-file-name name version))
+        (sha256
+         (base32 "00pswdys5c4hpqpvfcy5zqv30gyjvjvagi12811jizw57hxrm1cs"))))
+    (build-system pyproject-build-system)
     (arguments
-     `(#:tests? #f))              ; no tests in PyPI and no setup.py in GitHub
+     '(#:phases
+       (modify-phases %standard-phases
+         (replace 'check
+           (lambda* (#:key tests? #:allow-other-keys)
+             (when tests?
+               (invoke "python" "-m" "unittest" "discover" "-v")))))))
+    ;; ModuleNotFoundError: No module named 'poetry'
+    (native-inputs (list python-poetry-core))
     (home-page "https://github.com/vlasovskikh/funcparserlib")
     (synopsis
      "Recursive descent parsing library based on functional combinators")
-- 
2.38.1