GNU bug report logs - #58957
[PATCH] Improve Brahmi composition rules.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 58957 in the body.
You can then email your comments to 58957 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: समीर सिंह Sameer Singh
 <lumarzeli30 <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] Improve Brahmi composition rules.
Date: Wed, 2 Nov 2022 08:11:10 +0530

[Message part 1 (text/plain, inline)]

The present composition rules for Brahmi have a bug where the virama is not
composed with the consonants, I have fixed that now. I have also added
support for composing velar and bilabial fricatives in Brahmi.

Please review the patch.
Thanks

[Message part 2 (text/html, inline)]

Message #8 received at 58957 <at> debbugs.gnu.org (full text, mbox):

From: समीर सिंह Sameer Singh
 <lumarzeli30 <at> gmail.com>
To: 58957 <at> debbugs.gnu.org
Subject: Re: bug#58957: [PATCH] Improve Brahmi composition rules.
Date: Wed, 2 Nov 2022 08:14:09 +0530

[Message part 1 (text/plain, inline)]

On Wed, Nov 2, 2022 at 8:12 AM समीर सिंह Sameer Singh <lumarzeli30 <at> gmail.com>
wrote:

> The present composition rules for Brahmi have a bug where the virama is
> not composed with the consonants, I have fixed that now. I have also added
> support for composing velar and bilabial fricatives in Brahmi.
>
> Please review the patch.
> Thanks
>

[Message part 2 (text/html, inline)]

[0001-lisp-language-indian.el-Improve-Brahmi-composition-r.patch (text/x-patch, attachment)]

Message #11 received at 58957 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: समीर सिंह Sameer Singh
 <lumarzeli30 <at> gmail.com>
Cc: 58957 <at> debbugs.gnu.org
Subject: Re: bug#58957: [PATCH] Improve Brahmi composition rules.
Date: Wed, 02 Nov 2022 14:32:08 +0200

> From: समीर सिंह Sameer Singh
>  <lumarzeli30 <at> gmail.com>
> Date: Wed, 2 Nov 2022 08:14:09 +0530
> 
> On Wed, Nov 2, 2022 at 8:12 AM समीर सिंह Sameer Singh <lumarzeli30 <at> gmail.com> wrote:
> 
>  The present composition rules for Brahmi have a bug where the virama is not composed with the
>  consonants, I have fixed that now. I have also added support for composing velar and bilabial fricatives in
>  Brahmi.
> 
>  Please review the patch.

Thanks.

Should we perhaps introduce tests for compositions?  For example, I
guess you found the problems with the current rules by examining the
display of some sequences of characters, so why not add a test that
would make sure we never again break those composable sequences?

Message #14 received at 58957 <at> debbugs.gnu.org (full text, mbox):

From: समीर सिंह Sameer Singh
 <lumarzeli30 <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 58957 <at> debbugs.gnu.org
Subject: Re: bug#58957: [PATCH] Improve Brahmi composition rules.
Date: Wed, 2 Nov 2022 20:27:42 +0530

[Message part 1 (text/plain, inline)]

>
> Should we perhaps introduce tests for compositions?  For example, I
> guess you found the problems with the current rules by examining the
> display of some sequences of characters, so why not add a test that
> would make sure we never again break those composable sequences?


Yes, that would be a good idea.
How should I start? Are there some pre-existing examples that checks for
composition,
or even a manual that describes how to write a test?

Thanks

On Wed, Nov 2, 2022 at 6:02 PM Eli Zaretskii <eliz <at> gnu.org> wrote:

> > From: समीर सिंह Sameer Singh
> >  <lumarzeli30 <at> gmail.com>
> > Date: Wed, 2 Nov 2022 08:14:09 +0530
> >
> > On Wed, Nov 2, 2022 at 8:12 AM समीर सिंह Sameer Singh <
> lumarzeli30 <at> gmail.com> wrote:
> >
> >  The present composition rules for Brahmi have a bug where the virama is
> not composed with the
> >  consonants, I have fixed that now. I have also added support for
> composing velar and bilabial fricatives in
> >  Brahmi.
> >
> >  Please review the patch.
>
> Thanks.
>
> Should we perhaps introduce tests for compositions?  For example, I
> guess you found the problems with the current rules by examining the
> display of some sequences of characters, so why not add a test that
> would make sure we never again break those composable sequences?
>

[Message part 2 (text/html, inline)]

Message #19 received at 58957 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefankangas <at> gmail.com>
To: समीर सिंह Sameer Singh
 <lumarzeli30 <at> gmail.com>
Cc: Eli Zaretskii <eliz <at> gnu.org>, 58957 <at> debbugs.gnu.org
Subject: Re: bug#58957: [PATCH] Improve Brahmi composition rules.
Date: Thu, 24 Nov 2022 11:40:20 -0800

समीर सिंह Sameer Singh <lumarzeli30 <at> gmail.com> writes:

>  Should we perhaps introduce tests for compositions?  For example, I
>  guess you found the problems with the current rules by examining the
>  display of some sequences of characters, so why not add a test that
>  would make sure we never again break those composable sequences?
>
> Yes, that would be a good idea.
> How should I start? Are there some pre-existing examples that checks for
> composition,
> or even a manual that describes how to write a test?

We basically have the code in test/, and the `ert' info manual.
Evaluate this to open it:

    (info "(ert) Top")

Message #24 received at 58957-done <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: समीर सिंह Sameer Singh
 <lumarzeli30 <at> gmail.com>
Cc: 58957-done <at> debbugs.gnu.org
Subject: Re: bug#58957: [PATCH] Improve Brahmi composition rules.
Date: Sun, 11 Dec 2022 12:39:20 +0200

> From: समीर सिंह Sameer Singh
>  <lumarzeli30 <at> gmail.com>
> Date: Wed, 2 Nov 2022 08:14:09 +0530
> 
> On Wed, Nov 2, 2022 at 8:12 AM समीर सिंह Sameer Singh <lumarzeli30 <at> gmail.com> wrote:
> 
>  The present composition rules for Brahmi have a bug where the virama is not composed with the
>  consonants, I have fixed that now. I have also added support for composing velar and bilabial fricatives
>  in Brahmi.
> 
>  Please review the patch.
>  Thanks

Thanks, I installed this on the emacs-29 branch, and I'm closing the
bug.

Message #27 received at 58957-done <at> debbugs.gnu.org (full text, mbox):

From: समीर सिंह Sameer Singh
 <lumarzeli30 <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 58957-done <at> debbugs.gnu.org
Subject: Re: bug#58957: [PATCH] Improve Brahmi composition rules.
Date: Wed, 14 Dec 2022 20:18:57 +0530

[Message part 1 (text/plain, inline)]

Thanks for installing!

Also sorry for not following up on the test idea and also the vertical text
input, I have started college from the past
month and am therefore finding it difficult to manage my time :'( . I
promise to return to them in the near future.

On Sun, Dec 11, 2022 at 4:09 PM Eli Zaretskii <eliz <at> gnu.org> wrote:

> > From: समीर सिंह Sameer Singh
> >  <lumarzeli30 <at> gmail.com>
> > Date: Wed, 2 Nov 2022 08:14:09 +0530
> >
> > On Wed, Nov 2, 2022 at 8:12 AM समीर सिंह Sameer Singh <
> lumarzeli30 <at> gmail.com> wrote:
> >
> >  The present composition rules for Brahmi have a bug where the virama is
> not composed with the
> >  consonants, I have fixed that now. I have also added support for
> composing velar and bilabial fricatives
> >  in Brahmi.
> >
> >  Please review the patch.
> >  Thanks
>
> Thanks, I installed this on the emacs-29 branch, and I'm closing the
> bug.
>

[Message part 2 (text/html, inline)]

Message #30 received at 58957-done <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefankangas <at> gmail.com>
To: समीर सिंह Sameer Singh
 <lumarzeli30 <at> gmail.com>, Eli Zaretskii <eliz <at> gnu.org>
Cc: 58957-done <at> debbugs.gnu.org
Subject: Re: bug#58957: [PATCH] Improve Brahmi composition rules.
Date: Wed, 14 Dec 2022 13:42:41 -0800

समीर सिंह Sameer Singh <lumarzeli30 <at> gmail.com> writes:

> Thanks for installing!
>
> Also sorry for not following up on the test idea and also the vertical text
> input, I have started college from the past
> month and am therefore finding it difficult to manage my time :'( . I
> promise to return to them in the near future.

Thanks for your work on Emacs.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.