GNU bug report logs - #58955
[PATCH] gnu: pd: Update to 0.53-0, unbundle oss and portaudio

Previous Next

Full log

Message #24 received at 58955-done <at> debbugs.gnu.org (full text, mbox):

From: 宋文武 <iyzsong <at> envs.net>
To: Sughosha <Sughosha <at> proton.me>
Cc: 58955-done <at> debbugs.gnu.org, Christopher Baines <mail <at> cbaines.net>
Subject: Re: bug#58955: [PATCH] gnu: pd: Update to 0.53-0, unbundle oss and
 portaudio
Date: Sun, 29 Jan 2023 14:56:57 +0800

Sughosha <Sughosha <at> proton.me> writes:

> Hi Christopher,
>
> Thanks for reviewing the patch.
>
>> From the diff, it looks like oss is being disabled, rather than
>> unbundled. What's the reasoning behind disabling it?
> OSS is not needed since it was superseded by ALSA and it does the job.
> I disabled it because it's not at all used in Guix and also not needed
> as we have ALSA. Sorry for not being accurate in the message.
>> 
>> Adding portaudio as an input seems fine I guess, but it might be good to
>> remove the portaudio files from the source (through a snippet) if there
>> are some there.
> I tried it but autoconf or automake looks for it and gives error, before
> starting building.

Pushed with adjusted commit message, thank you!

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.