From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 01 21:28:45 2022 Received: (at submit) by debbugs.gnu.org; 2 Nov 2022 01:28:45 +0000 Received: from localhost ([127.0.0.1]:44481 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oq2Yf-0001w5-DW for submit@debbugs.gnu.org; Tue, 01 Nov 2022 21:28:45 -0400 Received: from lists.gnu.org ([209.51.188.17]:51092) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oq2Ye-0001vx-A9 for submit@debbugs.gnu.org; Tue, 01 Nov 2022 21:28:44 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oq2Ye-0007W4-0O for guix-patches@gnu.org; Tue, 01 Nov 2022 21:28:44 -0400 Received: from mail-40138.protonmail.ch ([185.70.40.138]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oq2Ya-0003r9-Mc for guix-patches@gnu.org; Tue, 01 Nov 2022 21:28:43 -0400 Date: Wed, 02 Nov 2022 01:28:21 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=proton.me; s=protonmail; t=1667352510; x=1667611710; bh=rkTNLrXuvyjLEu5oTJeqYIomT7Kt0sW0CB8bZ7OADG8=; h=Date:To:From:Subject:Message-ID:Feedback-ID:From:To:Cc:Date: Subject:Reply-To:Feedback-ID:Message-ID:BIMI-Selector; b=fRKHuI4z2tYudfWBoTN0M82UQrhEanJXZzLiEB5OC6xT/a4eNphfXKAk9N3S+Uchq 4hDeHVmPp6isgsJayozzDi+oV0THZnSgW/wEIi9JpiyH2kQ/MymnHW9gXY5/vr727S uf2jjsaDL3vQ4SD+rGvWTf687BkgpKD4fLCGbVZfLv2C5s/XYqwpujvaKjX8Vx3gw1 qNuILnNRDhWlbwKSNDoISzw0EN8IdrKAISBD3WR2YsbLLOl8LX6V1nRJeqALWapWOH 2bXFryDI79F6eESC7aN2xIqbGmsmycuO/rV+iC+6onlhX80X+CmNKEs8LKq6rSsI7y OUosAV1hTbu0A== To: "guix-patches@gnu.org" From: Sughosha Subject: [PATCH] gnu: pd: Update to 0.53-0, unbundle oss and portaudio Message-ID: <1iy1gGLmq4QENuFNQ_0_KrSIcwZ6VL1WHMIRlmbaDs-1OAU8vbTqD139NyBUZaka27bxvFSBERpMqV_imzqOgMWsRFqWvOaMaC_Xs6Vva4k=@proton.me> Feedback-ID: 45211691:user:proton MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=185.70.40.138; envelope-from=Sughosha@proton.me; helo=mail-40138.protonmail.ch X-Spam_score_int: 0 X-Spam_score: -0.1 X-Spam_bar: / X-Spam_report: (-0.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, URI_DOTEDU=1.997 autolearn=no autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) * gnu/packages/music.scm (pd): Update to 0.53-0. [arguments]: Unbundle oss and portaudio. [inputs]: Add portaudio. --- gnu/packages/music.scm | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/gnu/packages/music.scm b/gnu/packages/music.scm index ca400e8..b018c8e 100644 --- a/gnu/packages/music.scm +++ b/gnu/packages/music.scm @@ -2693,24 +2693,26 @@ export.") (define-public pd (package (name "pd") - (version "0.52-2") + (version "0.53-0") (source (origin (method url-fetch) (uri (string-append "http://msp.ucsd.edu/Software/pd-" version ".src.tar.gz")) (sha256 (base32 - "04fcsfgnv2r7g7p8vk9s9n3wba1bx4xgqw5mhwv09xbw9s3gapg9")))) + "01zcgw4bg4r422ikqa0d4s7vpgjjz76scnm4l1msnm35y7pzknns")))) (build-system gnu-build-system) (arguments (let ((wish (string-append "wish" (version-major+minor (package-version tk))))) (list #:tests? #f ; no "check" target #:configure-flags #~(list + "--disable-oss" "--enable-jack" + "--without-local-portaudio" (string-append "--with-wish=3D" (search-input-file %build-inputs (string-append "/bin/" #$wish= )))) @@ -2724,7 +2726,7 @@ export.") (native-inputs (list autoconf automake libtool gettext-minimal pkg-config)) (inputs - (list tk alsa-lib jack-1)) + (list tk alsa-lib jack-1 portaudio)) (home-page "https://puredata.info") (synopsis "Visual programming language for artistic performances") (description -- libgit2 1.4.3 From debbugs-submit-bounces@debbugs.gnu.org Thu Nov 03 13:30:07 2022 Received: (at submit) by debbugs.gnu.org; 3 Nov 2022 17:30:07 +0000 Received: from localhost ([127.0.0.1]:50367 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oqe2Z-0001Kh-0z for submit@debbugs.gnu.org; Thu, 03 Nov 2022 13:30:07 -0400 Received: from lists.gnu.org ([209.51.188.17]:52912) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oqe2X-0001Gw-QH for submit@debbugs.gnu.org; Thu, 03 Nov 2022 13:30:06 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oqe2X-0007vX-LO for guix-patches@gnu.org; Thu, 03 Nov 2022 13:30:05 -0400 Received: from mira.cbaines.net ([2a01:7e00:e000:2f8:fd4d:b5c7:13fb:3d27]) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oqe2W-0003fw-7c for guix-patches@gnu.org; Thu, 03 Nov 2022 13:30:05 -0400 Received: from localhost (93-63-133-243.ip27.fastwebnet.it [93.63.133.243]) by mira.cbaines.net (Postfix) with ESMTPSA id BF2A727BBE9; Thu, 3 Nov 2022 17:30:01 +0000 (GMT) Received: from felis (localhost [127.0.0.1]) by localhost (OpenSMTPD) with ESMTP id 2a2da69a; Thu, 3 Nov 2022 17:30:01 +0000 (UTC) References: <1iy1gGLmq4QENuFNQ_0_KrSIcwZ6VL1WHMIRlmbaDs-1OAU8vbTqD139NyBUZaka27bxvFSBERpMqV_imzqOgMWsRFqWvOaMaC_Xs6Vva4k=@proton.me> User-agent: mu4e 1.8.9; emacs 28.1 From: Christopher Baines To: Sughosha Subject: Re: [bug#58955] [PATCH] gnu: pd: Update to 0.53-0, unbundle oss and portaudio Date: Thu, 03 Nov 2022 18:27:48 +0100 In-reply-to: <1iy1gGLmq4QENuFNQ_0_KrSIcwZ6VL1WHMIRlmbaDs-1OAU8vbTqD139NyBUZaka27bxvFSBERpMqV_imzqOgMWsRFqWvOaMaC_Xs6Vva4k=@proton.me> Message-ID: <87tu3gkktj.fsf@cbaines.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Received-SPF: pass client-ip=2a01:7e00:e000:2f8:fd4d:b5c7:13fb:3d27; envelope-from=mail@cbaines.net; helo=mira.cbaines.net X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: submit Cc: 58955@debbugs.gnu.org, guix-patches@gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Sughosha via Guix-patches via writes: > * gnu/packages/music.scm (pd): Update to 0.53-0. > [arguments]: Unbundle oss and portaudio. > [inputs]: Add portaudio. > --- > gnu/packages/music.scm | 8 +++++--- > 1 file changed, 5 insertions(+), 3 deletions(-) Hey Sughosha, I'm having a bit of trouble matching up the commit message with the changes being made. From=20the diff, it looks like oss is being disabled, rather than unbundled. What's the reasoning behind disabling it? Adding portaudio as an input seems fine I guess, but it might be good to remove the portaudio files from the source (through a snippet) if there are some there. Thanks, Chris --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKlBAEBCgCPFiEEPonu50WOcg2XVOCyXiijOwuE9XcFAmNj+phfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcRHG1haWxAY2Jh aW5lcy5uZXQACgkQXiijOwuE9XepLQ//bRL6CniQiTICBenRwGUJ/k0Glexv3P+7 TNS4dn4toAMBGUb3nDNHKGkfzOoh/VbKZ0IRFJfjDEZ1fCQs8s0CDWrntTS3XlFA ZGNb6ryD8b60s9moE9/Si2SiqrDsPmaKvn7/g9N9G+CFcJpuwMU5U6pgnnN5/2kI dwoasf12CV8BT6YapzLOMBbfmZ+obNJ6Vjyw7PT7UgZQm4A7GRd928owrFpSv/x3 fv2/S2Fb2eOOJQEn/exmO9hYPebHiEMAb4EgVuw+cHLw5b1ZYwCMyUQAG+jD7cbd gLVDp1yJJxqhRh6ve/yPP88OVO7dAkRNXFL78+fgSCXjTEy4kY64kKcYMMRNYgeI /ZZFPD2tph+ie13vev1foSKZMZOa6b03+vH7Sg4oLOayPcAcVLywzLMpeC3C9emR 0zSfdDk5U/y0a/FgUc0THE2qPo8Vrb+u0snmabjRPbrETGASF4gz6zYFEx7Wz4Xk EznTF7KMJ3NVJJ7L6dDLgtLDiNuCLD7kWy8SmEu6jKLBwWS4uwTSECGWj0NqfE1N 3J++uCPtzFdijcSeeC+IUt/u5GlvxdjA9MNRkYmGV+UgdZhSDOAy6iIWFk1ViVTE AxS5e+ykivi+0OzJCY9WyTFGs5XgAyQnxoan/7Q55CFPaTlPLhbEInJmS9M/JzqJ 0R53PSXlSp0= =g/EP -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Thu Nov 03 13:30:11 2022 Received: (at control) by debbugs.gnu.org; 3 Nov 2022 17:30:11 +0000 Received: from localhost ([127.0.0.1]:50370 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oqe2d-0001b4-ES for submit@debbugs.gnu.org; Thu, 03 Nov 2022 13:30:11 -0400 Received: from mira.cbaines.net ([212.71.252.8]:41712) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oqe2b-0001UD-QT for control@debbugs.gnu.org; Thu, 03 Nov 2022 13:30:10 -0400 Received: from localhost (93-63-133-243.ip27.fastwebnet.it [93.63.133.243]) by mira.cbaines.net (Postfix) with ESMTPSA id 4BF2327BBEA for ; Thu, 3 Nov 2022 17:30:09 +0000 (GMT) Received: from localhost (localhost [local]) by localhost (OpenSMTPD) with ESMTPA id 2cc38f09 for ; Thu, 3 Nov 2022 17:30:08 +0000 (UTC) From: Christopher Baines To: control@debbugs.gnu.org Subject: tag 58955 moreinfo Date: Thu, 03 Nov 2022 17:30:08 +0000 Message-ID: <87y1ssj68v.fsf@cbaines.net> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 58955 + moreinfo quit From debbugs-submit-bounces@debbugs.gnu.org Fri Nov 04 09:29:28 2022 Received: (at submit) by debbugs.gnu.org; 4 Nov 2022 13:29:28 +0000 Received: from localhost ([127.0.0.1]:52123 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oqwlE-0004dz-5T for submit@debbugs.gnu.org; Fri, 04 Nov 2022 09:29:28 -0400 Received: from lists.gnu.org ([209.51.188.17]:60146) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oqwlC-0004dr-5J for submit@debbugs.gnu.org; Fri, 04 Nov 2022 09:29:26 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oqwlB-0001VY-WC for guix-patches@gnu.org; Fri, 04 Nov 2022 09:29:26 -0400 Received: from mail-4027.protonmail.ch ([185.70.40.27]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oqwl6-0000wx-Py for guix-patches@gnu.org; Fri, 04 Nov 2022 09:29:25 -0400 Date: Fri, 04 Nov 2022 13:29:14 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=proton.me; s=protonmail; t=1667568557; x=1667827757; bh=fk6fogsQKRMRHtQZiXbYzNTeEUtmnU/d8VCe0U+Q/Dk=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector; b=ZaQWxJ5FOe1HGIt4nBHLHgiMhl/Zs/OgYrulTeUCuKJ9pORSBbw97d05vgTuxS4cl Z8XdYlCMzcjfCQ80m2PBhhVx1v7k/elKOBvtAHzxd57Cq0sGzmNIs2cZVAOduhg4O3 fOEEVRr7W9ztzR3LhnZBxKpFzvwyvxYdr25Uu8E/yu5MKjeWO4bss01L4lrdbxHOL9 7D7nROrfFzhMK08lQgOXNvy3XXKUZcwrZpNlXOvDcFG2rNxSYd9N7hYklYmMdlSDqf /rW//buJeWJFhWlxhAtRBoOFMZdu/FDOIvQ5IlrMjd0g9ibj1L5aWsycIQ13fDr/nA 0A0orEUXWiV+Q== To: Christopher Baines From: Sughosha Subject: Re: [bug#58955] [PATCH] gnu: pd: Update to 0.53-0, unbundle oss and portaudio Message-ID: In-Reply-To: <87tu3gkktj.fsf@cbaines.net> References: <1iy1gGLmq4QENuFNQ_0_KrSIcwZ6VL1WHMIRlmbaDs-1OAU8vbTqD139NyBUZaka27bxvFSBERpMqV_imzqOgMWsRFqWvOaMaC_Xs6Vva4k=@proton.me> <87tu3gkktj.fsf@cbaines.net> Feedback-ID: 45211691:user:proton MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=185.70.40.27; envelope-from=Sughosha@proton.me; helo=mail-4027.protonmail.ch X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit Cc: 58955@debbugs.gnu.org, guix-patches@gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) Hi Christopher, Thanks for reviewing the patch. > From the diff, it looks like oss is being disabled, rather than > unbundled. What's the reasoning behind disabling it? OSS is not needed since it was superseded by ALSA and it does the job. I disabled it because it's not at all used in Guix and also not needed as we have ALSA. Sorry for not being accurate in the message. >=20 > Adding portaudio as an input seems fine I guess, but it might be good to > remove the portaudio files from the source (through a snippet) if there > are some there. I tried it but autoconf or automake looks for it and gives error, before starting building. From debbugs-submit-bounces@debbugs.gnu.org Sun Jan 29 02:03:40 2023 Received: (at 58955-done) by debbugs.gnu.org; 29 Jan 2023 07:03:40 +0000 Received: from localhost ([127.0.0.1]:42124 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pM1j2-0007sX-5M for submit@debbugs.gnu.org; Sun, 29 Jan 2023 02:03:40 -0500 Received: from mail.envs.net ([5.199.136.28]:57294) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pM1iz-0007sN-KP for 58955-done@debbugs.gnu.org; Sun, 29 Jan 2023 02:03:38 -0500 Received: from localhost (mail.envs.net [127.0.0.1]) by mail.envs.net (Postfix) with ESMTP id A9C1538A012B; Sun, 29 Jan 2023 07:03:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=envs.net; s=modoboa; t=1674975813; bh=QzZS6ywRTVkYQviU2CLJXTcgwYblSLVvkSO7tWF0RH0=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=HcyVhoDpsBwQcL5sC7vOB/XvRWcjOg7TztR/zARJgD/oKmRe+tWuGQtty9wx8YwUj pKYw2WO2RW728Fl2exvEBGrsBix56ECvTZcLE+hF1Efi8SSlbDgVvnKuEvZPaVmLuh VMrqX97jsd8vmNtsxLVhB58b/9xihExI+/mKTLyDOAWv3JWEqjSzTwoJ+YM6hnHKqE DsmvMaYnp53IpBhpiHBDUC5pKN/NSE1R+ng+sE7228UNbk1XBwYut7ae4CgtTHLcuW ts80UwQMGbDWqryM+aijH6vdECq7lUf8DIxD0tfmBagOzWZs6k10dUoFpPxZhVZzkq H86ppndP8GckTVP5Pln9dz9milbJO3fXNirswwPWlbItJK2cacPHPDz8KlYcjM9b/i fGkbI9ARLQvtYFP0JBljq6H2VrvjMpWMmJ7ZVav51lpBJnkIgBBRcVrSDpaGIF+6EC lIMo6SHflVV6NZ3QbrpUu1V/hlCAcp43MrprpupCzu5y/bdYrjkmGzUUU5Limh2N9d XudPtpIoz4CvHbkNf3NqzrtnWVqW4b447jijm+u4y7xvzXBJH6SyxwA8cLIOb8dxwy ToILSVgSwdvbQ0vs41mqDzre+TsbelKA9856u8uM0jkukTPhezb83uWpToZlpX6Fkd x4AL+vNrzNYa68LHoMwUUmLg= X-Virus-Scanned: Debian amavisd-new at mail.envs.net Received: from mail.envs.net ([127.0.0.1]) by localhost (mail.envs.net [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id Wdl9_T0tPMe3; Sun, 29 Jan 2023 07:03:28 +0000 (UTC) Received: from localhost (unknown [182.150.116.135]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail.envs.net (Postfix) with ESMTPSA; Sun, 29 Jan 2023 07:03:28 +0000 (UTC) Received: from localhost (localhost [local]) by localhost (OpenSMTPD) with ESMTPA id fd21c946; Sun, 29 Jan 2023 06:56:57 +0000 (UTC) From: =?utf-8?B?5a6L5paH5q2m?= To: Sughosha Subject: Re: bug#58955: [PATCH] gnu: pd: Update to 0.53-0, unbundle oss and portaudio References: <1iy1gGLmq4QENuFNQ_0_KrSIcwZ6VL1WHMIRlmbaDs-1OAU8vbTqD139NyBUZaka27bxvFSBERpMqV_imzqOgMWsRFqWvOaMaC_Xs6Vva4k=@proton.me> <87tu3gkktj.fsf@cbaines.net> Date: Sun, 29 Jan 2023 14:56:57 +0800 In-Reply-To: (Sughosha@proton.me's message of "Fri, 04 Nov 2022 13:29:14 +0000") Message-ID: <878rhlj0au.fsf_-_@envs.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 58955-done Cc: 58955-done@debbugs.gnu.org, Christopher Baines X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Sughosha writes: > Hi Christopher, > > Thanks for reviewing the patch. > >> From the diff, it looks like oss is being disabled, rather than >> unbundled. What's the reasoning behind disabling it? > OSS is not needed since it was superseded by ALSA and it does the job. > I disabled it because it's not at all used in Guix and also not needed > as we have ALSA. Sorry for not being accurate in the message. >> >> Adding portaudio as an input seems fine I guess, but it might be good to >> remove the portaudio files from the source (through a snippet) if there >> are some there. > I tried it but autoconf or automake looks for it and gives error, before > starting building. Pushed with adjusted commit message, thank you! From unknown Mon Jun 23 23:55:32 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sun, 26 Feb 2023 12:24:07 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator