GNU bug report logs - #58951
[PATCH] ; Fix handling of 'not' by 'buffer-match-p'

Previous Next

Full log

View this message in rfc822 format

From: Philip Kaludercic <philipk <at> posteo.net>
To: Dmitry Gutov <dgutov <at> yandex.ru>
Cc: 58951 <at> debbugs.gnu.org
Subject: bug#58951: [PATCH] ; Fix handling of 'not' by 'buffer-match-p'
Date: Tue, 01 Nov 2022 22:18:04 +0000

Dmitry Gutov <dgutov <at> yandex.ru> writes:

> On 01.11.2022 21:36, Philip Kaludercic wrote:
>> I believe this is preferable to fixing `show-paren-predicate', as this
>> is the kind of issue a lot of people could trip over.
>> This patch is based on the patch from bug#58950, but can be
>> back-ported
>> to the previous implementations if there are any issues with that report.
>
> I do agree that (not foo) is more convenient than (not . foo). Though
> the latter would be more regular compared to the rest of the syntax. I
> made just that mistake yesterday.
>
> Let's change 'pcase' to 'pcase-exhaustive', though? So it will signal
> an error on invalid syntax.

Right, that is what I did in bug#58950 and what led me to notice the mistake.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.