From unknown Wed Jun 18 23:07:21 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#58951 <58951@debbugs.gnu.org> To: bug#58951 <58951@debbugs.gnu.org> Subject: Status: [PATCH] ; Fix handling of 'not' by 'buffer-match-p' Reply-To: bug#58951 <58951@debbugs.gnu.org> Date: Thu, 19 Jun 2025 06:07:21 +0000 retitle 58951 [PATCH] ; Fix handling of 'not' by 'buffer-match-p' reassign 58951 emacs submitter 58951 Philip Kaludercic severity 58951 normal tag 58951 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 01 15:36:21 2022 Received: (at submit) by debbugs.gnu.org; 1 Nov 2022 19:36:21 +0000 Received: from localhost ([127.0.0.1]:44267 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1opx3c-0007gZ-Rs for submit@debbugs.gnu.org; Tue, 01 Nov 2022 15:36:21 -0400 Received: from lists.gnu.org ([209.51.188.17]:37354) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1opx3b-0007gR-3Q for submit@debbugs.gnu.org; Tue, 01 Nov 2022 15:36:19 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1opx3a-0006QH-22 for bug-gnu-emacs@gnu.org; Tue, 01 Nov 2022 15:36:18 -0400 Received: from mout02.posteo.de ([185.67.36.66]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1opx3Y-0002Sd-1q for bug-gnu-emacs@gnu.org; Tue, 01 Nov 2022 15:36:17 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 94F10240105 for ; Tue, 1 Nov 2022 20:36:13 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1667331373; bh=f4qTeUVFO/gkHQNodkZGOhCm4Iiwyw9twgMGuk52yhI=; h=From:To:Subject:Autocrypt:Date:From; b=J52qOylNjUKWZ4HpWTqcrXLkTvlDFYURrUmVS1N7Q8va2TifWAbGO+TVhoTPVCcza SQZ8Q7Mhm3BuC2ynMUt0f3/xEuwoAPYU74MVtQ4UoxMsRZ4eLrnrZnw4TMWy1MmpF9 VqTYUlTB0QvXC1efOQn66HaGXzsb7zKTIkKnPGiACzz0KHec2HDBideA57ub5K19xv X8iUx9q97H57ZY61fBoRLyUSv7rWuiTlZAMLLAYpLhyGgoPCDpjrtIu9LQ59o3s2dT Y+A6jhJt6pvEZwtGJRo9MK4DutE/zOvNe1xwk3PmkixDAT8cSi+JfWSFNRGCXNThkY ELc+EMGZ8Hzeg== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4N20cs1Wxhz6tmP for ; Tue, 1 Nov 2022 20:36:13 +0100 (CET) From: Philip Kaludercic To: bug-gnu-emacs@gnu.org Subject: [PATCH] ; Fix handling of 'not' by 'buffer-match-p' Autocrypt: addr=philipk@posteo.net; prefer-encrypt=nopreference; keydata= mDMEYHHqUhYJKwYBBAHaRw8BAQdAp3GdmYJ6tm5McweY6dEvIYIiry+Oz9rU4MH6NHWK0Ee0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiQBBMWCAA4FiEEDM2H44ZoPt9Ms0eHtVrAHPRh1FwFAmBx6lICGwMFCwkIBwIGFQoJ CAsCBBYCAwECHgECF4AACgkQtVrAHPRh1FyTkgEAjlbGPxFchvMbxzAES3r8QLuZgCxeAXunM9gh io0ePtUBALVhh9G6wIoZhl0gUCbQpoN/UJHI08Gm1qDob5zDxnIHuDgEYHHqUhIKKwYBBAGXVQEF AQEHQNcRB+MUimTMqoxxMMUERpOR+Q4b1KgncDZkhrO2ql1tAwEIB4h4BBgWCAAgFiEEDM2H44Zo Pt9Ms0eHtVrAHPRh1FwFAmBx6lICGwwACgkQtVrAHPRh1Fw1JwD/Qo7kvtib8jy7puyWrSv0MeTS g8qIxgoRWJE/KKdkCLEA/jb9b9/g8nnX+UcwHf/4VfKsjExlnND3FrBviXUW6NcB Date: Tue, 01 Nov 2022 19:36:12 +0000 Message-ID: <871qqmeac3.fsf@posteo.net> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Received-SPF: pass client-ip=185.67.36.66; envelope-from=philipk@posteo.net; helo=mout02.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) --=-=-= Content-Type: text/plain Tags: patch In preparing bug#58950 I noticed that the 'not' clause is confusing, and is misused on the place I could find it being used in the core (show-paren-predicate). The current implementation would require a negation to be written as (not . CONDITION) while it is more natural to write (not CONDITION) which is more in line with (and ...) and (or ...). The issue appears to go back to `project--buffer-check', that takes a list of conditions instead of a single one. This means that the above are equivalent. since (not CONDITION) will check each element in the unary list in (not . (CONDITION)). I believe this is preferable to fixing `show-paren-predicate', as this is the kind of issue a lot of people could trip over. This patch is based on the patch from bug#58950, but can be back-ported to the previous implementations if there are any issues with that report. In GNU Emacs 29.0.50 (build 3, x86_64-pc-linux-gnu, GTK+ Version 3.24.30, cairo version 1.16.0) of 2022-10-31 built on heron Repository revision: 462a66e79edcc34ecbeef7cc1604765adfdc038e Repository branch: feature/package+vc System Description: Guix System Configured using: 'configure --with-pgtk --with-imagemagick PKG_CONFIG_PATH=/gnu/store/ssg343s6ldqdwh30136pnawhbgd0cb6i-profile/lib/pkgconfig:/gnu/store/ssg343s6ldqdwh30136pnawhbgd0cb6i-profile/share/pkgconfig' --=-=-= Content-Type: text/patch Content-Disposition: attachment; filename=0001-Fix-handling-of-not-by-buffer-match-p.patch >From cb88a512eacb3ad73c22682c9c794cdc80445f43 Mon Sep 17 00:00:00 2001 From: Philip Kaludercic Date: Tue, 1 Nov 2022 20:27:17 +0100 Subject: [PATCH] ; Fix handling of 'not' by 'buffer-match-p' * lisp/subr.el (buffer-match-p): Look up the cadr instead of the cdr for the negation in 'not'. --- lisp/subr.el | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lisp/subr.el b/lisp/subr.el index b667339db9..0252e66686 100644 --- a/lisp/subr.el +++ b/lisp/subr.el @@ -7023,7 +7023,7 @@ string-lines `(provided-mode-derived-p (buffer-local-value 'major-mode ,buffer-sym) ',mode)) - (`(not . ,cond) + (`(not ,cond) `(not ,(funcall translate cond))) (`(or . ,conds) `(or ,@(mapcar translate conds))) @@ -7045,7 +7045,7 @@ string-lines * `major-mode': the buffer matches if the buffer's major mode is eq to the cons-cell's cdr. Prefer using `derived-mode' instead when both can work. - * `not': the cdr is interpreted as a negation of a condition. + * `not': the cadr is interpreted as a negation of a condition. * `and': the cdr is a list of recursive conditions, that all have to be met. * `or': the cdr is a list of recursive condition, of which at -- 2.38.0 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 01 16:19:19 2022 Received: (at 58951) by debbugs.gnu.org; 1 Nov 2022 20:19:19 +0000 Received: from localhost ([127.0.0.1]:44291 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1opxjC-0000Ia-PC for submit@debbugs.gnu.org; Tue, 01 Nov 2022 16:19:19 -0400 Received: from mout02.posteo.de ([185.67.36.66]:47359) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1opxj9-0000IL-CL for 58951@debbugs.gnu.org; Tue, 01 Nov 2022 16:19:15 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 75F75240104 for <58951@debbugs.gnu.org>; Tue, 1 Nov 2022 21:19:09 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1667333949; bh=ZFuNV6PwDkOCyTxFhKWxdiRgugWB9S4s+TBhpRVLqXo=; h=From:To:Cc:Subject:Autocrypt:Date:From; b=bNv4JLBCRskPGvKPRg5huR6uma6Za+j6XEo4WQZNeatZ0nEz+rVlK3tqWV/qCw1pi Tv8GvstGdgRWRpyV8CaSh+4upEG/9O4U9uCpaS5aEJqPGGqrVXQwTmAgl+EpD6FZMK /CFMfzW9kCFyDQ1VaHlbdFpEYnEIKzhu9Js8Vk1nDut7w2+afYA3zkIeJU+9MklCR1 9rw22qE11lTYQ8DrwUA3ztG4VtfKeVpWCgdsTRXEaisv4oZYjrSmJ+nDC2ustHf2qZ 3I1A3N0CQsEg5teIQ8hBaRLt+oUPi0T2Hd1kPoJxQw4JixLhZZAH/RVZTRgyJ9hTn3 x8giU72FWt9QQ== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4N21ZM70wFz6tn3; Tue, 1 Nov 2022 21:19:07 +0100 (CET) From: Philip Kaludercic To: help-debbugs@gnu.org (GNU bug Tracking System) Subject: Re: bug#58951: Acknowledgement ([PATCH] ; Fix handling of 'not' by 'buffer-match-p') In-Reply-To: (GNU bug Tracking System's message of "Tue, 01 Nov 2022 19:37:02 +0000") References: <871qqmeac3.fsf@posteo.net> Autocrypt: addr=philipk@posteo.net; prefer-encrypt=nopreference; keydata= mDMEYHHqUhYJKwYBBAHaRw8BAQdAp3GdmYJ6tm5McweY6dEvIYIiry+Oz9rU4MH6NHWK0Ee0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiQBBMWCAA4FiEEDM2H44ZoPt9Ms0eHtVrAHPRh1FwFAmBx6lICGwMFCwkIBwIGFQoJ CAsCBBYCAwECHgECF4AACgkQtVrAHPRh1FyTkgEAjlbGPxFchvMbxzAES3r8QLuZgCxeAXunM9gh io0ePtUBALVhh9G6wIoZhl0gUCbQpoN/UJHI08Gm1qDob5zDxnIHuDgEYHHqUhIKKwYBBAGXVQEF AQEHQNcRB+MUimTMqoxxMMUERpOR+Q4b1KgncDZkhrO2ql1tAwEIB4h4BBgWCAAgFiEEDM2H44Zo Pt9Ms0eHtVrAHPRh1FwFAmBx6lICGwwACgkQtVrAHPRh1Fw1JwD/Qo7kvtib8jy7puyWrSv0MeTS g8qIxgoRWJE/KKdkCLEA/jb9b9/g8nnX+UcwHf/4VfKsjExlnND3FrBviXUW6NcB Date: Tue, 01 Nov 2022 20:19:06 +0000 Message-ID: <87pme6cts5.fsf@posteo.net> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 58951 Cc: 58951@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain I forgot to update the documentation in buffers.texi: --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=0001-Fix-handling-of-not-by-buffer-match-p.patch >From 279f9561dd115d707b086efdbc19072fceb7a99f Mon Sep 17 00:00:00 2001 From: Philip Kaludercic Date: Tue, 1 Nov 2022 20:27:17 +0100 Subject: [PATCH] ; Fix handling of 'not' by 'buffer-match-p' * lisp/subr.el (buffer-match-p): Look up the cadr instead of the cdr for the negation in 'not'. * doc/lispref/buffers.texi (Buffer List): Update documentation. --- doc/lispref/buffers.texi | 18 ++++++++---------- lisp/subr.el | 4 ++-- 2 files changed, 10 insertions(+), 12 deletions(-) diff --git a/doc/lispref/buffers.texi b/doc/lispref/buffers.texi index c40e088293..8405e28387 100644 --- a/doc/lispref/buffers.texi +++ b/doc/lispref/buffers.texi @@ -977,17 +977,15 @@ Buffer List A cons-cell @code{(@var{oper} . @var{expr})} where @var{oper} is one of @table @code -@item not -Satisfied if @var{expr} doesn't satisfy @code{buffer-match-p} with +@item (not @var{cond}) +Satisfied if @var{cond} doesn't satisfy @code{buffer-match-p} with the same buffer and @code{arg}. -@item or -Satisfied if @var{expr} is a list and @emph{any} condition in -@var{expr} satisfies @code{buffer-match-p}, with the same buffer and -@code{arg}. -@item and -Satisfied if @var{expr} is a list and @emph{all} conditions in -@var{expr} satisfy @code{buffer-match-p}, with the same buffer and -@code{arg}. +@item (or @var{conds}@dots{}) +Satisfied if and @emph{any} condition in @var{conds} satisfies +@code{buffer-match-p}, with the same buffer and @code{arg}. +@item (and @var{conds}@dots{}) +Satisfied if @emph{all} conditions in @var{conds} satisfy +@code{buffer-match-p}, with the same buffer and @code{arg}. @item derived-mode Satisfied if the buffer's major mode derives from @var{expr}. @item major-mode diff --git a/lisp/subr.el b/lisp/subr.el index b667339db9..0252e66686 100644 --- a/lisp/subr.el +++ b/lisp/subr.el @@ -7023,7 +7023,7 @@ string-lines `(provided-mode-derived-p (buffer-local-value 'major-mode ,buffer-sym) ',mode)) - (`(not . ,cond) + (`(not ,cond) `(not ,(funcall translate cond))) (`(or . ,conds) `(or ,@(mapcar translate conds))) @@ -7045,7 +7045,7 @@ string-lines * `major-mode': the buffer matches if the buffer's major mode is eq to the cons-cell's cdr. Prefer using `derived-mode' instead when both can work. - * `not': the cdr is interpreted as a negation of a condition. + * `not': the cadr is interpreted as a negation of a condition. * `and': the cdr is a list of recursive conditions, that all have to be met. * `or': the cdr is a list of recursive condition, of which at -- 2.38.0 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 01 18:09:21 2022 Received: (at 58951) by debbugs.gnu.org; 1 Nov 2022 22:09:22 +0000 Received: from localhost ([127.0.0.1]:44365 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1opzRh-00034X-KV for submit@debbugs.gnu.org; Tue, 01 Nov 2022 18:09:21 -0400 Received: from mail-wm1-f45.google.com ([209.85.128.45]:39879) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1opzRg-00034K-BH for 58951@debbugs.gnu.org; Tue, 01 Nov 2022 18:09:20 -0400 Received: by mail-wm1-f45.google.com with SMTP id i5-20020a1c3b05000000b003cf47dcd316so170779wma.4 for <58951@debbugs.gnu.org>; Tue, 01 Nov 2022 15:09:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :sender:from:to:cc:subject:date:message-id:reply-to; bh=EL5/uh+2VoJzEhPppBhWE1IfbEUtEIge5c94dOpjSkA=; b=kfqs2VTQu6Sq6ekAO6Qjv+8vL25cyumRcfjCg2SPOJlA76rR1+RMC7/iL4o67k638T wFPJV27GSOixvkVwlJQtYiifh0bjXuDhmXl3kvLKpdFI/aIfZCxvJsqyVRTOHod1le8/ tMF1+2wZL758PdjQhSqBNKZKh+mdxlGkqmyiFcI+jKBWTmx1ijMIH3SPvvrVHCtRgJ1J 67uO93VnOlJvqUJT/+xDm+FnfdxneOY+E0AkGTcF+oifuRfQ2FuDP5UZvy1wVTyIVg22 BW3aCxlu7DTIE3vRfR7SIKrj562QipW2+4Bg2jZN8HpxApcKomVSO8nPv7WhnjvFC47z kXEw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :sender:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=EL5/uh+2VoJzEhPppBhWE1IfbEUtEIge5c94dOpjSkA=; b=gHKaihxtoUzma8unRJT5/ye6d4YYTTAaRAicJuvIzMNkHxpTnQScYflZRrdNoAPGhV nQl6kRvhkfqUcJNwuHT+lvlKhEri5DH0PRCWpAseJdNfjAJmn8JM4WUKJh70KoC8GHDo DSndcq/TUJ6O8Kr09xDUFhZjj8P7ZAtGX+nFxSCBRG2ixXxl1JlI+xOvJDg4yWLB9WYw HZ55+x0+gebxBam2fsKq7/xlDAD3ygqQ13tLiYBKAfl7c13jI98mAOBfjG/ZYWwniyAJ eQic3cxTAEQNeY2xShUXGQA2wN+hZlPUG0Yc+NAWCa1R2h2eCcywRK4pj5+zGJ2J1/On Y4rg== X-Gm-Message-State: ACrzQf3e7cf5bpEAeYpCTx/ItqDyBbYQMrGg533BvOt7nOfW5t4aU2hY tD+uIclPwRMrkNcoC7aWJ3U= X-Google-Smtp-Source: AMsMyM6JZS5fp+QB7uLeaKPcpl82fCH94wwOrCQE6ibnNMcVSKwqb1BkWWkD9VCPzQtu9YCO/4CAPg== X-Received: by 2002:a05:600c:310a:b0:3c6:f9a6:5a7d with SMTP id g10-20020a05600c310a00b003c6f9a65a7dmr23513748wmo.29.1667340554123; Tue, 01 Nov 2022 15:09:14 -0700 (PDT) Received: from [192.168.0.6] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id o17-20020a5d4091000000b0022584c82c80sm11483592wrp.19.2022.11.01.15.09.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 01 Nov 2022 15:09:13 -0700 (PDT) Message-ID: <44629860-db9a-d6f7-8188-e7a5b73ea48e@yandex.ru> Date: Wed, 2 Nov 2022 00:09:11 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: bug#58951: [PATCH] ; Fix handling of 'not' by 'buffer-match-p' Content-Language: en-US To: Philip Kaludercic , 58951@debbugs.gnu.org References: <871qqmeac3.fsf@posteo.net> From: Dmitry Gutov In-Reply-To: <871qqmeac3.fsf@posteo.net> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: 58951 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) On 01.11.2022 21:36, Philip Kaludercic wrote: > I believe this is preferable to fixing `show-paren-predicate', as this > is the kind of issue a lot of people could trip over. > > This patch is based on the patch from bug#58950, but can be back-ported > to the previous implementations if there are any issues with that report. I do agree that (not foo) is more convenient than (not . foo). Though the latter would be more regular compared to the rest of the syntax. I made just that mistake yesterday. Let's change 'pcase' to 'pcase-exhaustive', though? So it will signal an error on invalid syntax. From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 01 18:18:15 2022 Received: (at 58951) by debbugs.gnu.org; 1 Nov 2022 22:18:15 +0000 Received: from localhost ([127.0.0.1]:44375 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1opzaI-0005Tt-Sf for submit@debbugs.gnu.org; Tue, 01 Nov 2022 18:18:15 -0400 Received: from mout01.posteo.de ([185.67.36.65]:49279) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1opzaH-0005Tb-0J for 58951@debbugs.gnu.org; Tue, 01 Nov 2022 18:18:13 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 09067240027 for <58951@debbugs.gnu.org>; Tue, 1 Nov 2022 23:18:06 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1667341087; bh=DqKK1fSA0QDSzCSumuv5pw4RBBFN7CWuAiiO8RKU+48=; h=From:To:Cc:Subject:Autocrypt:Date:From; b=emUIoWC5VeT1U9+2y0s4z4ompncI4L+mXs1QbhLS7/M40UVjz2ZXNVuvcbLMS/Tg1 QOvP0M43mehor7kM5qnBEgJ9UV/TmZ71TNyUY4FhwErHrEASs9BMFRHK3kT32YseYO 9taqZAlcSBgJefKlhXsUX53JqLE0PBu+j7nKVGKvYZwsJjzQbnBYQdYAgJp2kcvzd7 EfUiujElVbH4LJlA+mfcHnxyz3rmfSQnzObf/NDOQxlRysYP8dzhJZCQG4VLQrI9p4 zdSvGW2UCxjr3GEham3fPEyi4sKWDtw+xQBb9VyqSaYaFIzpGzVcpgwew4tqIV+1qo NKHkAgyAz2jFQ== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4N24Cf0zzkz6tmK; Tue, 1 Nov 2022 23:18:05 +0100 (CET) From: Philip Kaludercic To: Dmitry Gutov Subject: Re: bug#58951: [PATCH] ; Fix handling of 'not' by 'buffer-match-p' In-Reply-To: <44629860-db9a-d6f7-8188-e7a5b73ea48e@yandex.ru> (Dmitry Gutov's message of "Wed, 2 Nov 2022 00:09:11 +0200") References: <871qqmeac3.fsf@posteo.net> <44629860-db9a-d6f7-8188-e7a5b73ea48e@yandex.ru> Autocrypt: addr=philipk@posteo.net; prefer-encrypt=nopreference; keydata= mDMEYHHqUhYJKwYBBAHaRw8BAQdAp3GdmYJ6tm5McweY6dEvIYIiry+Oz9rU4MH6NHWK0Ee0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiQBBMWCAA4FiEEDM2H44ZoPt9Ms0eHtVrAHPRh1FwFAmBx6lICGwMFCwkIBwIGFQoJ CAsCBBYCAwECHgECF4AACgkQtVrAHPRh1FyTkgEAjlbGPxFchvMbxzAES3r8QLuZgCxeAXunM9gh io0ePtUBALVhh9G6wIoZhl0gUCbQpoN/UJHI08Gm1qDob5zDxnIHuDgEYHHqUhIKKwYBBAGXVQEF AQEHQNcRB+MUimTMqoxxMMUERpOR+Q4b1KgncDZkhrO2ql1tAwEIB4h4BBgWCAAgFiEEDM2H44Zo Pt9Ms0eHtVrAHPRh1FwFAmBx6lICGwwACgkQtVrAHPRh1Fw1JwD/Qo7kvtib8jy7puyWrSv0MeTS g8qIxgoRWJE/KKdkCLEA/jb9b9/g8nnX+UcwHf/4VfKsjExlnND3FrBviXUW6NcB Date: Tue, 01 Nov 2022 22:18:04 +0000 Message-ID: <87iljyco9v.fsf@posteo.net> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 58951 Cc: 58951@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Dmitry Gutov writes: > On 01.11.2022 21:36, Philip Kaludercic wrote: >> I believe this is preferable to fixing `show-paren-predicate', as this >> is the kind of issue a lot of people could trip over. >> This patch is based on the patch from bug#58950, but can be >> back-ported >> to the previous implementations if there are any issues with that report. > > I do agree that (not foo) is more convenient than (not . foo). Though > the latter would be more regular compared to the rest of the syntax. I > made just that mistake yesterday. > > Let's change 'pcase' to 'pcase-exhaustive', though? So it will signal > an error on invalid syntax. Right, that is what I did in bug#58950 and what led me to notice the mistake. From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 01 18:29:46 2022 Received: (at 58951) by debbugs.gnu.org; 1 Nov 2022 22:29:46 +0000 Received: from localhost ([127.0.0.1]:44391 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1opzlR-0005lF-Sj for submit@debbugs.gnu.org; Tue, 01 Nov 2022 18:29:46 -0400 Received: from mail-wr1-f51.google.com ([209.85.221.51]:41799) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1opzlQ-0005l0-58 for 58951@debbugs.gnu.org; Tue, 01 Nov 2022 18:29:44 -0400 Received: by mail-wr1-f51.google.com with SMTP id w14so22038423wru.8 for <58951@debbugs.gnu.org>; Tue, 01 Nov 2022 15:29:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:from:to:cc:subject:date:message-id:reply-to; bh=CaEGcSN3MAg7auI7VsLTpmjioLbMoEUXL7b4zEC5jj8=; b=Hy9Gaz9klYq5J1w0oyPBkiDqrbispoFB51Jj+FMp7XPUJKZ/m+p6RPA2F/x2cjI9Nq lczXs8M6L+q1KZXlg1gbFx+z6fUs8lqqUqfrq5d1hN31v1Xlo9E1f7sa7pv1a3IC0jhQ d9j0qNCfud69afG8xDwm//WbxTBQURbUK4M2RzJOy9SN1QTjCirjlGuIAKt3tvM83JRl e8XyCyAFOffMKVbJXWhcJOlX8DUuu9S/Vtm737zgwE4Z/sPU7ul2JnMa18gmcXX8FC42 T0MAL804G5fog0/GBS/3dFxIViX0H6ZO2M75Pi0w/zheEJFy8iE7VgI7cz3u9tNAQGX0 5Pyw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=CaEGcSN3MAg7auI7VsLTpmjioLbMoEUXL7b4zEC5jj8=; b=oeYEWrY+fmRnWPdAZ+EYZ8E5g+1buORWiU8HynK+TSv+w55jFd5Nb00PkDjnlVV5IL X86rK1pgdB2B2Gn/2uFrJKJzNCkra6+LNXHr0I/e/3xKzQ21xL3wDZSf59qiNAtkTHJP kQXi6VkY7UQ+Lo3yRtWum722c9dg317Q5Wrheu3JxIDv9NgzyvktM68nF7AkK8iG3PYY SEuR13G4AnP/nTk9816f3DPusCeRzBOUXauYVuBuqdmjvOSt0sFgjBaGwOJGFV41rntf 8tciI4MWCMFc3JnPTbU4s3+FIfo/S1Yx+/EldS0S/u+ekZVJGKEb7OwuUKwqc9cj6yy/ cJPw== X-Gm-Message-State: ACrzQf3y1jKmZYiCgjtxxVFoZOqzb3JtFEL9FnYLpHy0AOg0fLyo6hf4 EFaAMjOz3+84x1yvRAx8wcY= X-Google-Smtp-Source: AMsMyM5TIzIXbEZFGDvzDrZ2dKb//AhDuTy9j/ce/zsFwPrmvJMtBq7b2c6QnsShDHRCiEzidb4obw== X-Received: by 2002:a5d:590d:0:b0:236:4ddd:1869 with SMTP id v13-20020a5d590d000000b002364ddd1869mr12544437wrd.709.1667341778498; Tue, 01 Nov 2022 15:29:38 -0700 (PDT) Received: from [192.168.0.6] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id h17-20020a5d6e11000000b002356c051b9csm11071121wrz.66.2022.11.01.15.29.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 01 Nov 2022 15:29:38 -0700 (PDT) Message-ID: Date: Wed, 2 Nov 2022 00:29:36 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: bug#58951: [PATCH] ; Fix handling of 'not' by 'buffer-match-p' Content-Language: en-US To: Philip Kaludercic References: <871qqmeac3.fsf@posteo.net> <44629860-db9a-d6f7-8188-e7a5b73ea48e@yandex.ru> <87iljyco9v.fsf@posteo.net> From: Dmitry Gutov In-Reply-To: <87iljyco9v.fsf@posteo.net> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: 58951 Cc: 58951@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) On 02.11.2022 00:18, Philip Kaludercic wrote: > Dmitry Gutov writes: > >> On 01.11.2022 21:36, Philip Kaludercic wrote: >>> I believe this is preferable to fixing `show-paren-predicate', as this >>> is the kind of issue a lot of people could trip over. >>> This patch is based on the patch from bug#58950, but can be >>> back-ported >>> to the previous implementations if there are any issues with that report. >> I do agree that (not foo) is more convenient than (not . foo). Though >> the latter would be more regular compared to the rest of the syntax. I >> made just that mistake yesterday. >> >> Let's change 'pcase' to 'pcase-exhaustive', though? So it will signal >> an error on invalid syntax. > Right, that is what I did in bug#58950 and what led me to notice the mistake. Oh, sorry. I didn't review that patch in detail yet. LGTM then. From debbugs-submit-bounces@debbugs.gnu.org Wed Nov 02 08:05:03 2022 Received: (at 58951) by debbugs.gnu.org; 2 Nov 2022 12:05:04 +0000 Received: from localhost ([127.0.0.1]:45063 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oqCUR-00027L-L1 for submit@debbugs.gnu.org; Wed, 02 Nov 2022 08:05:03 -0400 Received: from eggs.gnu.org ([209.51.188.92]:32836) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oqCUP-00026m-Un for 58951@debbugs.gnu.org; Wed, 02 Nov 2022 08:05:02 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oqCUK-0008AK-KU; Wed, 02 Nov 2022 08:04:56 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=PjH7DaWgcWD5L8SivycE1dajf0rifnlsZwD6eOjDJDg=; b=JsJ0Fa2Kmwrz kOntxG/X5LBnNT9x6DS0sCLLIRzCGIm8/UxPvngJYVGVGOYeK2STEe2Kza44VrXlt6mODtqDNjXr5 0nhdxVNq8NJ8h7wOY+Q4zEmRUA9/f4eydgca+HnhvqRGqUnvo0vB7N3AI3hHi1JK6l9K+QxZOSK9R 8cJjQ2A11X+OtUEdPWQry80eDLThOFotFJtK/kK+8uyWVgFseRRITGeVgL7st4tkAT3VYdW8yEAtr Bh1hjZdRQTQ2QpI0KKRLNTgNG5kaNH9+TbGM9/DvcoNJiG2sCcmm6+YKeKNwooWlkmVMp89OrAF8W sZBjxOWR4X296l4hx8qomQ==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oqCUJ-00042e-IH; Wed, 02 Nov 2022 08:04:55 -0400 Date: Wed, 02 Nov 2022 14:04:45 +0200 Message-Id: <83cza5bm02.fsf@gnu.org> From: Eli Zaretskii To: Philip Kaludercic In-Reply-To: <87pme6cts5.fsf@posteo.net> (message from Philip Kaludercic on Tue, 01 Nov 2022 20:19:06 +0000) Subject: Re: bug#58951: Acknowledgement ([PATCH] ; Fix handling of 'not' by 'buffer-match-p') References: <871qqmeac3.fsf@posteo.net> <87pme6cts5.fsf@posteo.net> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 58951 Cc: 58951@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Philip Kaludercic > Date: Tue, 01 Nov 2022 20:19:06 +0000 > > +@item (or @var{conds}@dots{}) > +Satisfied if and @emph{any} condition in @var{conds} satisfies ^^^ That "and" should be deleted. > +@item (and @var{conds}@dots{}) > +Satisfied if @emph{all} conditions in @var{conds} satisfy ^^^^^^^^^^^^^^^^^^^^^ "@emph{all} the conditions" Thanks. From debbugs-submit-bounces@debbugs.gnu.org Sat Dec 31 09:05:32 2022 Received: (at 58951) by debbugs.gnu.org; 31 Dec 2022 14:05:32 +0000 Received: from localhost ([127.0.0.1]:36810 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pBcUO-0000FU-DD for submit@debbugs.gnu.org; Sat, 31 Dec 2022 09:05:32 -0500 Received: from mout01.posteo.de ([185.67.36.65]:37939) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pBcUM-0000FE-OP for 58951@debbugs.gnu.org; Sat, 31 Dec 2022 09:05:31 -0500 Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id C53FE240126 for <58951@debbugs.gnu.org>; Sat, 31 Dec 2022 15:05:22 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1672495524; bh=HGy5wv9302f722GrD7Ui+Qdew5lsn4S0CRUW+m3Kvj8=; h=From:To:Cc:Subject:Date:From; b=hZNtbb9XNHBLgL9z85xaIqqwTbuaEuGyi1UmAtPM3E8+YM+EOgQ0SB/8AHSKtmfVI QtfSTRb49MPoLvqqhxqKNh5kqz3HBKo2mOJvrUQcHY0F5+FuPMc9qH6SR7GVBrQuB2 pi/LSiNv10GU8iLdJtQi1yqICZRwIOEJYivCIVT3E60SK1pOe0lJ73MHJqxwTg3OuM DvCT3DA8vGQhq8jNcoyiTEr9E3pv2nZSAG0trE+9Y7J9uwLEqFVxr8g6qD67lkhMct dQFs4kUIjCR+rgkbyuxC5PPXzGm7yB9WnGNA5S5AIqsiJ9fE2Q0z0eFq0QmunIxNtl ihIv4L064EgBA== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4NkkRP6RwTz9rxN; Sat, 31 Dec 2022 15:05:20 +0100 (CET) From: Philip Kaludercic To: Eli Zaretskii Subject: Re: bug#58951: [PATCH] ; Fix handling of 'not' by 'buffer-match-p' In-Reply-To: <83cza5bm02.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 02 Nov 2022 14:04:45 +0200") References: <871qqmeac3.fsf@posteo.net> <87pme6cts5.fsf@posteo.net> <83cza5bm02.fsf@gnu.org> Date: Sat, 31 Dec 2022 14:05:27 +0000 Message-ID: <875ydr1xeg.fsf_-_@posteo.net> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 58951 Cc: 58951@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Eli Zaretskii writes: >> From: Philip Kaludercic >> Date: Tue, 01 Nov 2022 20:19:06 +0000 >> >> +@item (or @var{conds}@dots{}) >> +Satisfied if and @emph{any} condition in @var{conds} satisfies > ^^^ > That "and" should be deleted. > >> +@item (and @var{conds}@dots{}) >> +Satisfied if @emph{all} conditions in @var{conds} satisfy > ^^^^^^^^^^^^^^^^^^^^^ > "@emph{all} the conditions" > > Thanks. I have applied these changes and will push the fix to the release branch. From debbugs-submit-bounces@debbugs.gnu.org Sat Dec 31 09:05:39 2022 Received: (at control) by debbugs.gnu.org; 31 Dec 2022 14:05:39 +0000 Received: from localhost ([127.0.0.1]:36816 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pBcUV-0000G3-92 for submit@debbugs.gnu.org; Sat, 31 Dec 2022 09:05:39 -0500 Received: from mout02.posteo.de ([185.67.36.66]:35315) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pBcUT-0000FX-S4 for control@debbugs.gnu.org; Sat, 31 Dec 2022 09:05:38 -0500 Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 3CD0C2401A0 for ; Sat, 31 Dec 2022 15:05:32 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1672495532; bh=4ZxNI+EAgfWbPNyO3K5/jq7JhZiNQxUYaUA/PyF1Ltc=; h=Date:To:From:Subject:From; b=F99Da74VUYd7mZKUO2pMaz/g8XiOnqfSer/FNCxD2ZrcwkCwplZ6Xul42hB0T0I5D MuRCBBxLx2xkliS10qNUa8fLZ5KK2ztzyHIgZczQbHFsCPTnQHKAgolHB/kIjTHsNW kWHd15MzBm5hp4OuvLV9Qyet/Nx4gFL5Cay3TayYRj7tuO4rRpt71WnRCHaL7BQIA+ CWGEFWadAvoo9xkX8GKkk5Zh+H9arBUnc4xwnl4WzQ6x+N0XxRCu8aIgezH6v6kH8+ sEKJ9vnt9/L/gOX1DLtSl2sTWHl+eNfgI5alCj8aoyOv0Kc7ezN3+RbEcAhm4036ow Ut5VZ5m5rBHIg== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4NkkRb1dgzz6tmB for ; Sat, 31 Dec 2022 15:05:31 +0100 (CET) Date: Sat, 31 Dec 2022 14:05:37 +0000 Message-Id: <87358v1xe6.fsf@posteo.net> To: control@debbugs.gnu.org From: Philip Kaludercic Subject: control message for bug #58951 X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) close 58951 29.1 quit From debbugs-submit-bounces@debbugs.gnu.org Sat Dec 31 11:26:12 2022 Received: (at 58951) by debbugs.gnu.org; 31 Dec 2022 16:26:12 +0000 Received: from localhost ([127.0.0.1]:39685 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pBegW-00076q-BK for submit@debbugs.gnu.org; Sat, 31 Dec 2022 11:26:12 -0500 Received: from mail157c50.megamailservers.eu ([91.136.10.167]:51494 helo=mail51c50.megamailservers.eu) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pBegT-00076e-61 for 58951@debbugs.gnu.org; Sat, 31 Dec 2022 11:26:11 -0500 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1672503967; bh=y9FKXRYHzroSkv/abCqhD9EPJmNs8WAxyPcC+m5iY8s=; h=From:Subject:Date:Cc:To:From; b=nm04bND+pJZlQqmpcJZLOcd7JSEGIoCbdF+7qh668mei1ntfRksWYMZoamJ8yKcnL 5uk5XvVEC6y91IhJPNCXHYHoVsaRxJucxmYGea/5sWpdx3nYSXjpbZ5iSB4rLIgqnn Sn2BxE+tSKwKq5JqW5eKhWiIEzkhQecxfzbeEeBE= Feedback-ID: mattiase@acm.or Received: from smtpclient.apple (c188-150-171-209.bredband.tele2.se [188.150.171.209]) (authenticated bits=0) by mail51c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id 2BVGQ3p0064812; Sat, 31 Dec 2022 16:26:04 +0000 From: =?utf-8?Q?Mattias_Engdeg=C3=A5rd?= Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.13\)) Subject: bug#58951: [PATCH] ; Fix handling of 'not' by 'buffer-match-p' Message-Id: Date: Sat, 31 Dec 2022 17:26:02 +0100 To: Philip Kaludercic X-Mailer: Apple Mail (2.3654.120.0.1.13) X-CTCH-RefID: str=0001.0A782F20.63B0629F.0014, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Rules: X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-Origin-Country: SE X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 58951 Cc: 58951@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) > (not . CONDITION) >=20 > while it is more natural to write >=20 > (not CONDITION) Shouldn't then the `derived-mode` and `major-mode` operators be changed = in the same way? And shouldn't there be tests? For all of `buffer-match-p`, in fact? From debbugs-submit-bounces@debbugs.gnu.org Sat Dec 31 11:34:21 2022 Received: (at 58951) by debbugs.gnu.org; 31 Dec 2022 16:34:21 +0000 Received: from localhost ([127.0.0.1]:39691 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pBeoP-0007Jb-9N for submit@debbugs.gnu.org; Sat, 31 Dec 2022 11:34:21 -0500 Received: from eggs.gnu.org ([209.51.188.92]:43708) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pBeoN-0007JN-Gm for 58951@debbugs.gnu.org; Sat, 31 Dec 2022 11:34:19 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pBeoI-0007Go-1i; Sat, 31 Dec 2022 11:34:14 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=Gg7LV0f65a4mEWIDwOhGKyJdtq49DIolCOd2qTjymAE=; b=BOcgfsmdNlIuq7+2JyoR WxX7PAkP4TgnjlDxiD7VY8/eAxE1FS373udt3Km15KFwt1Ca6el2M+GzANEKJ0t2hQ+0Tu6xQgXzF +SLnWaGEmpAOvJW+WgWF0VTxajlT5hFs+F9TyEhRsCn4Cd0Q4k2HbNbDTYQ+X+u5kEeLFi3Kvcecl nxK4OJEm459wL44xQjWtOwpsO98pjCmvniYYqGw/X3ovJEIfBGaX9w9vJ8MGc25//vZyJgFNyBh68 +p+CL5eYsLMZf1tDSJ4QN0Z8g5wBY3J9Bds+8xBucKuOXSezKVmo3+qITrXGEUZ6toMAhNMcEB+BU Cntn3/wOt09K8Q==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pBeoH-0001EW-Fw; Sat, 31 Dec 2022 11:34:13 -0500 Date: Sat, 31 Dec 2022 18:34:15 +0200 Message-Id: <83mt734jnc.fsf@gnu.org> From: Eli Zaretskii To: Mattias =?utf-8?Q?Engdeg=C3=A5rd?= In-Reply-To: (message from Mattias =?utf-8?Q?Engdeg=C3=A5rd?= on Sat, 31 Dec 2022 17:26:02 +0100) Subject: Re: bug#58951: [PATCH] ; Fix handling of 'not' by 'buffer-match-p' References: <871qqmeac3.fsf@posteo.net> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 58951 Cc: philipk@posteo.net, 58951@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Cc: 58951@debbugs.gnu.org > From: Mattias Engdegård > Date: Sat, 31 Dec 2022 17:26:02 +0100 > > > (not . CONDITION) > > > > while it is more natural to write > > > > (not CONDITION) > > Shouldn't then the `derived-mode` and `major-mode` operators be changed in the same way? In fact, that change cause errors in timer function of show-paren-mode, so I've reverted it for now. > And shouldn't there be tests? For all of `buffer-match-p`, in fact? Ideally, yes. From unknown Wed Jun 18 23:07:21 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sun, 29 Jan 2023 12:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator