From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 01 13:57:02 2022 Received: (at submit) by debbugs.gnu.org; 1 Nov 2022 17:57:02 +0000 Received: from localhost ([127.0.0.1]:44197 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1opvVW-0005F5-Ik for submit@debbugs.gnu.org; Tue, 01 Nov 2022 13:57:02 -0400 Received: from lists.gnu.org ([209.51.188.17]:34280) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1opvVU-0005Ei-LJ for submit@debbugs.gnu.org; Tue, 01 Nov 2022 13:57:01 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1opvVT-0005Xw-LZ for bug-gnu-emacs@gnu.org; Tue, 01 Nov 2022 13:56:59 -0400 Received: from relay9-d.mail.gandi.net ([2001:4b98:dc4:8::229]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1opvVQ-0000ql-Vk for bug-gnu-emacs@gnu.org; Tue, 01 Nov 2022 13:56:59 -0400 Received: (Authenticated sender: juri@linkov.net) by mail.gandi.net (Postfix) with ESMTPSA id 7DD2DFF80A for ; Tue, 1 Nov 2022 17:56:52 +0000 (UTC) From: Juri Linkov To: bug-gnu-emacs@gnu.org Subject: 29.0.50; Add :noquery to 'make-network-process' used by eglot Organization: LINKOV.NET Date: Tue, 01 Nov 2022 19:45:42 +0200 Message-ID: <865yfyimox.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Received-SPF: pass client-ip=2001:4b98:dc4:8::229; envelope-from=juri@linkov.net; helo=relay9-d.mail.gandi.net X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.6 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.6 (--) --=-=-= Content-Type: text/plain Tags: patch Every time while exiting Emacs, an internal process is displayed and asked whether to exit. Eglot already uses `:noquery t' in two places for `make-process', but can't use the same for `open-network-stream' because it's still unhandled. Here is the patch that adds it: --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=make-network-process-noquery.patch diff --git a/lisp/net/network-stream.el b/lisp/net/network-stream.el index 38a5e14c946..c092fd5f012 100644 --- a/lisp/net/network-stream.el +++ b/lisp/net/network-stream.el @@ -195,6 +195,7 @@ open-network-stream (make-network-process :name name :buffer buffer :host (puny-encode-domain host) :service service :nowait (plist-get parameters :nowait) + :noquery (plist-get parameters :noquery) :tls-parameters (plist-get parameters :tls-parameters) :coding (plist-get parameters :coding)) diff --git a/lisp/progmodes/eglot.el b/lisp/progmodes/eglot.el index 0a0d73eb6d2..204121045a0 100644 --- a/lisp/progmodes/eglot.el +++ b/lisp/progmodes/eglot.el @@ -1200,7 +1200,8 @@ eglot--connect (pcase-let ((`(,connection . ,inferior) (eglot--inferior-bootstrap readable-name - contact))) + contact + '(:noquery t)))) (setq autostart-inferior-process inferior) connection)))) ((stringp (car contact)) --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Wed Nov 02 05:53:59 2022 Received: (at 58948) by debbugs.gnu.org; 2 Nov 2022 09:53:59 +0000 Received: from localhost ([127.0.0.1]:44944 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oqARb-0004lP-9y for submit@debbugs.gnu.org; Wed, 02 Nov 2022 05:53:59 -0400 Received: from mail-wr1-f49.google.com ([209.85.221.49]:43786) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oqARZ-0004l7-UK for 58948@debbugs.gnu.org; Wed, 02 Nov 2022 05:53:58 -0400 Received: by mail-wr1-f49.google.com with SMTP id g12so23678789wrs.10 for <58948@debbugs.gnu.org>; Wed, 02 Nov 2022 02:53:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=FN+TuM/mt0fYH5XiGmueT6JbszG7VuK0dUeSpmw6xAs=; b=hLquC+N0anlszIG9JYq1GYt7je1ANm/BhspwLg8JpdNgjNvftLt83W3rmWGD290yhb Ave3K6GZmNlyT53oYLNpEKNK1jB3uaGVIilu6aD5icfQO1kqQumCWMmw58boYCK/Dej9 upnc6jRjZgcnl/NtFLHFhK/u2hct/Kue8cxypC4fvPLv9cT/xfcqWNf2LjvNK4qhuXv1 7fRNyXbUwgBT4+5hHNcNBSwtkNl5/VjVAntnxF5TQtHqiRLBa5B/arSy64pqme2oGjx+ 8i0RtQtapu9xLcozzEIraVRdTNiUEp7IDN6F0yXIHdCzgmpwKDlgYZJEJRWOSPDMUfIY 2iIQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=FN+TuM/mt0fYH5XiGmueT6JbszG7VuK0dUeSpmw6xAs=; b=Xtu1/uPkcjCGMkG3+r0EJLQnRL/peXPBjhY/o545WYfvHDxbPWm1/zYRBtZ1AbUdtU phYW1aRBMsfVYHPNrVleVxSQ3k6l6nMcGbFQ6EVFkQvKDwsHNQpiHel57UGyXPzyCFIJ ELgMyaROVJTLC+tyU5uR+VvGm4ZU0FXr2isIfITg99i0a+jIq7CojyyjMniwFlrcRpBl uh49xXEwjDdiiaBpZGWGs4sBoi8bW5nfCcPom4AG+lMNZN3MDW+ZE1JAAnCF3P/u5nGA kznfl2lUcDsBFEZ+fnlYVio9xX0DhglO3mUlWo3qLg/3IP/ORC744ohobHWCZZaguRys U27g== X-Gm-Message-State: ACrzQf1BInpXB9fW6RrR3zu9vLOm/bRj+wS85d39/70aslqC/ITDTaQg shO1Sj6QOao6xn6fs1DKN7sn+Ge4FIE= X-Google-Smtp-Source: AMsMyM54ZJRDz5YqcUou8blm1sJei5lKAzJ++wVdlY9uakZ8E4UabzpE4EKUzcA1nH5hnLW8FjEOdQ== X-Received: by 2002:a5d:414c:0:b0:236:b8ba:ebdf with SMTP id c12-20020a5d414c000000b00236b8baebdfmr12526114wrq.415.1667382831681; Wed, 02 Nov 2022 02:53:51 -0700 (PDT) Received: from rltb ([82.66.8.55]) by smtp.gmail.com with ESMTPSA id bi19-20020a05600c3d9300b003c6f3e5ba42sm1426876wmb.46.2022.11.02.02.53.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 02 Nov 2022 02:53:51 -0700 (PDT) From: Robert Pluim To: Juri Linkov Subject: Re: bug#58948: 29.0.50; Add :noquery to 'make-network-process' used by eglot In-Reply-To: <865yfyimox.fsf@mail.linkov.net> (Juri Linkov's message of "Tue, 01 Nov 2022 19:45:42 +0200") References: <865yfyimox.fsf@mail.linkov.net> Date: Wed, 02 Nov 2022 10:53:50 +0100 Message-ID: <87o7tpof69.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 58948 Cc: 58948@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >>>>> On Tue, 01 Nov 2022 19:45:42 +0200, Juri Linkov sai= d: Juri> Tags: patch Juri> Every time while exiting Emacs, an internal process is displayed = and Juri> asked whether to exit. Juri> Eglot already uses `:noquery t' in two places for `make-process', Juri> but can't use the same for `open-network-stream' because it's sti= ll unhandled. Juri> Here is the patch that adds it: I guess this is ok, although it=CA=BCs missing documentation and a commit message :-) I=CA=BCm even tempted to say that unrecognized keyword arguments should just be passed on to `make-network-process' as-is, but that=CA=BCs a bigger and riskier change. Robert --=20 From debbugs-submit-bounces@debbugs.gnu.org Wed Nov 02 14:25:04 2022 Received: (at 58948) by debbugs.gnu.org; 2 Nov 2022 18:25:04 +0000 Received: from localhost ([127.0.0.1]:47161 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oqIQB-00065H-Ii for submit@debbugs.gnu.org; Wed, 02 Nov 2022 14:25:04 -0400 Received: from relay8-d.mail.gandi.net ([217.70.183.201]:55095) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oqIPu-00064P-SN; Wed, 02 Nov 2022 14:25:02 -0400 Received: (Authenticated sender: juri@linkov.net) by mail.gandi.net (Postfix) with ESMTPSA id F17101BF204; Wed, 2 Nov 2022 18:24:37 +0000 (UTC) From: Juri Linkov To: Robert Pluim Subject: Re: bug#58948: 29.0.50; Add :noquery to 'make-network-process' used by eglot In-Reply-To: <87o7tpof69.fsf@gmail.com> (Robert Pluim's message of "Wed, 02 Nov 2022 10:53:50 +0100") Organization: LINKOV.NET References: <865yfyimox.fsf@mail.linkov.net> <87o7tpof69.fsf@gmail.com> Date: Wed, 02 Nov 2022 20:22:52 +0200 Message-ID: <86r0ylxlkz.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 58948 Cc: 58948@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) close 58948 29.0.50 thanks > Juri> Tags: patch > Juri> Every time while exiting Emacs, an internal process is displayed and > Juri> asked whether to exit. > > Juri> Eglot already uses `:noquery t' in two places for `make-process', > Juri> but can't use the same for `open-network-stream' because it's still unhandled. > Juri> Here is the patch that adds it: > > I guess this is ok, although itʼs missing documentation and a commit > message :-) Thanks for reviewing, now pushed with doc changes. > Iʼm even tempted to say that unrecognized keyword arguments should > just be passed on to `make-network-process' as-is, but thatʼs a bigger > and riskier change. Agreed. Maybe then more parameters of make-network-process could be copied to open-network-stream manually one by one. From unknown Mon Aug 18 02:37:11 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Thu, 01 Dec 2022 12:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator