From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 31 21:21:22 2022 Received: (at submit) by debbugs.gnu.org; 1 Nov 2022 01:21:22 +0000 Received: from localhost ([127.0.0.1]:42288 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1opfxy-0000U9-2s for submit@debbugs.gnu.org; Mon, 31 Oct 2022 21:21:22 -0400 Received: from lists.gnu.org ([209.51.188.17]:46032) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1opfxw-0000U1-5b for submit@debbugs.gnu.org; Mon, 31 Oct 2022 21:21:20 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1opfxw-00031d-0O for bug-gnu-emacs@gnu.org; Mon, 31 Oct 2022 21:21:20 -0400 Received: from mail-4317.proton.ch ([185.70.43.17]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1opfxs-0005he-Hj for bug-gnu-emacs@gnu.org; Mon, 31 Oct 2022 21:21:19 -0400 Date: Tue, 01 Nov 2022 01:21:03 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rjt.dev; s=protonmail2; t=1667265671; x=1667524871; bh=7wRBuZ8YU9miQnMC2kutUd0tsrh5kKc3PnwSCHEO6nY=; h=Date:To:From:Subject:Message-ID:Feedback-ID:From:To:Cc:Date: Subject:Reply-To:Feedback-ID:Message-ID:BIMI-Selector; b=vCCPQZGNC9FDcnDzy6TCD6ljnJWPq4Ox1gJDrwwydbVXw03aECHz6EiRfd06RhWsK HUit/Rs5xDYbq+cSNV5obZYE4EkmiQxlnsZtwQKDqtOfX7Gp/6OsN6r6xZY5+6dlAM /NoCCl/g9nTjO04GMRFSwtMDDzqg0ZnErFWTMT3eHTodDXAIooLK0dZ4bg1aUS1jo+ qoAPdBrS/2eBOHoQ6WTsNcpbEF2D/3Ftmn/Spm3R+/7R9k/aX9NCU1ZKCIYNAJUASq SrJJhefhT3R8sPdKsc0JPIoIElbDqbe7xcgwTTmBdjBu/aR1t0kbPDKl8NyLjpxJXG HrO8jtR5WBaEQ== To: "bug-gnu-emacs@gnu.org" From: Randy Taylor Subject: [PATCH] feature/tree-sitter: Add more font lock faces Message-ID: Feedback-ID: 44397038:user:proton MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="b1_xj3bTkZOEAUCaQf3hFJfPzap3EwHUzuh7XzURklE" Received-SPF: pass client-ip=185.70.43.17; envelope-from=dev@rjt.dev; helo=mail-4317.proton.ch X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=0.001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) This is a multi-part message in MIME format. --b1_xj3bTkZOEAUCaQf3hFJfPzap3EwHUzuh7XzURklE Content-Type: multipart/alternative; boundary="b2_xj3bTkZOEAUCaQf3hFJfPzap3EwHUzuh7XzURklE" --b2_xj3bTkZOEAUCaQf3hFJfPzap3EwHUzuh7XzURklE Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: base64 VGhlIGF0dGFjaGVkIHBhdGNoIGFkZHMgdGhlIGZvbGxvd2luZyBmYWNlczoKCi0gZm9udC1sb2Nr LWVzY2FwZS1mYWNlCi0gZm9udC1sb2NrLW51bWJlci1mYWNlCi0gZm9udC1sb2NrLW9wZXJhdG9y LWZhY2UKLSBmb250LWxvY2stcHJvcGVydHktZmFjZQotIGZvbnQtbG9jay1wdW5jdHVhdGlvbi1m YWNlCgpmb250LWxvY2stcHJvcGVydHktZmFjZSBpbmhlcml0cyBmb250LWxvY2stdmFyaWFibGUt bmFtZS1mYWNlIHdoaWNoIG1hdGNoZXMgdGhlIGJlaGF2aW91ciBvZiBjYy1tb2RlIGFuZCBweXRo b24tbW9kZS4KCmZvbnQtbG9jay1lc2NhcGUtZmFjZSBpbmhlcml0cyBub3RoaW5nLiBJbiBweXRo b24tbW9kZSwgaXQgaW5oZXJpdHMgZm9udC1sb2NrLWNvbnN0YW50LWZhY2UsIGJ1dCBub3QgaW4g Y2MtbW9kZS4gRG8gd2Ugd2FudCBpdCB0byBpbmhlcml0IGFueXRoaW5nPwoKSG9wZWZ1bGx5IEkg cHV0IGV2ZXJ5dGhpbmcgaW4gdGhlIHJpZ2h0IHBsYWNlLg== --b2_xj3bTkZOEAUCaQf3hFJfPzap3EwHUzuh7XzURklE Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: base64 PGRpdiBzdHlsZT0iZm9udC1mYW1pbHk6IHRhaG9tYSwgc2Fucy1zZXJpZjsgZm9udC1zaXplOiAx NHB4OyI+VGhlIGF0dGFjaGVkIHBhdGNoIGFkZHMgdGhlIGZvbGxvd2luZyBmYWNlczo8L2Rpdj48 ZGl2IHN0eWxlPSJmb250LWZhbWlseTogdGFob21hLCBzYW5zLXNlcmlmOyBmb250LXNpemU6IDE0 cHg7Ij48dWw+PGxpPjxzcGFuPmZvbnQtbG9jay1lc2NhcGUtZmFjZTwvc3Bhbj48L2xpPjxsaT48 c3Bhbj5mb250LWxvY2stbnVtYmVyLWZhY2U8L3NwYW4+PC9saT48bGk+PHNwYW4+Zm9udC1sb2Nr LW9wZXJhdG9yLWZhY2U8L3NwYW4+PC9saT48bGk+PHNwYW4+Zm9udC1sb2NrLXByb3BlcnR5LWZh Y2U8L3NwYW4+PC9saT48bGk+PHNwYW4+Zm9udC1sb2NrLXB1bmN0dWF0aW9uLWZhY2U8L3NwYW4+ PC9saT48L3VsPjxkaXY+PGJyPjwvZGl2PjxkaXY+Zm9udC1sb2NrLXByb3BlcnR5LWZhY2UgaW5o ZXJpdHMgZm9udC1sb2NrLXZhcmlhYmxlLW5hbWUtZmFjZSB3aGljaCBtYXRjaGVzIHRoZSBiZWhh dmlvdXIgb2YgY2MtbW9kZSBhbmQgcHl0aG9uLW1vZGUuPGJyPjwvZGl2PjxkaXY+PGJyPjwvZGl2 PjxkaXY+Zm9udC1sb2NrLWVzY2FwZS1mYWNlIGluaGVyaXRzIG5vdGhpbmcuIEluIHB5dGhvbi1t b2RlLCBpdCBpbmhlcml0cyBmb250LWxvY2stY29uc3RhbnQtZmFjZSwgYnV0IG5vdCBpbiBjYy1t b2RlLiBEbyB3ZSB3YW50IGl0IHRvIGluaGVyaXQgYW55dGhpbmc/PGJyPjwvZGl2PjxkaXY+PGJy PjwvZGl2PjxkaXY+SG9wZWZ1bGx5IEkgcHV0IGV2ZXJ5dGhpbmcgaW4gdGhlIHJpZ2h0IHBsYWNl Ljxicj48L2Rpdj48L2Rpdj48ZGl2IHN0eWxlPSJmb250LWZhbWlseTogdGFob21hLCBzYW5zLXNl cmlmOyBmb250LXNpemU6IDE0cHg7Ij48YnI+PC9kaXY+DQo8ZGl2IGNsYXNzPSJwcm90b25tYWls X3NpZ25hdHVyZV9ibG9jayBwcm90b25tYWlsX3NpZ25hdHVyZV9ibG9jay1lbXB0eSIgc3R5bGU9 ImZvbnQtZmFtaWx5OiB0YWhvbWEsIHNhbnMtc2VyaWY7IGZvbnQtc2l6ZTogMTRweDsiPg0KICAg IDxkaXYgY2xhc3M9InByb3Rvbm1haWxfc2lnbmF0dXJlX2Jsb2NrLXVzZXIgcHJvdG9ubWFpbF9z aWduYXR1cmVfYmxvY2stZW1wdHkiPjwvZGl2Pg0KICAgIA0KICAgICAgICAgICAgPGRpdiBjbGFz cz0icHJvdG9ubWFpbF9zaWduYXR1cmVfYmxvY2stcHJvdG9uIHByb3Rvbm1haWxfc2lnbmF0dXJl X2Jsb2NrLWVtcHR5Ij4NCiAgICAgICAgDQogICAgICAgICAgICA8L2Rpdj4NCjwvZGl2Pg0K --b2_xj3bTkZOEAUCaQf3hFJfPzap3EwHUzuh7XzURklE-- --b1_xj3bTkZOEAUCaQf3hFJfPzap3EwHUzuh7XzURklE Content-Type: text/x-patch; name=0001-Add-more-font-lock-faces.patch Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename=0001-Add-more-font-lock-faces.patch RnJvbSA4ZjA1YTc0NDc0NDE0M2NlMDVhMGVlZTBhYjhhYzk5MjZiYzVmM2ViIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBSYW5keSBUYXlsb3IgPGRldkByanQuZGV2PgpEYXRlOiBGcmks IDI4IE9jdCAyMDIyIDIyOjM5OjUwIC0wNDAwClN1YmplY3Q6IFtQQVRDSF0gQWRkIG1vcmUgZm9u dC1sb2NrIGZhY2VzCgoqIGxpc3AvZm9udC1sb2NrLmVsIChmb250LWxvY2stZXNjYXBlLWZhY2Us IGZvbnQtbG9jay1udW1iZXItZmFjZSwKZm9udC1sb2NrLW9wZXJhdG9yLWZhY2UsIGZvbnQtbG9j ay1wcm9wZXJ0eS1mYWNlLApmb250LWxvY2stcHVuY3R1YXRpb24tZmFjZSk6IERlZmluZSBuZXcg ZmFjZXMuCiogbGlzcC9jdXMtdGhlbWUuZWwgKGN1c3RvbS10aGVtZS0tbGlzdGVkLWZhY2VzKTog QWRkIHRoZW0gdG8gdGhlIGxpc3QuCiogZG9jL2xpc3ByZWYvbW9kZXMudGV4aSAoRmFjZXMgZm9y IEZvbnQgTG9jayk6IERvY3VtZW50IHRoZW0uCiogZXRjL05FV1M6IE1lbnRpb24gdGhlbS4KLS0t CiBkb2MvbGlzcHJlZi9tb2Rlcy50ZXhpIHwgMjEgKysrKysrKysrKysrKysrKysrKysKIGV0Yy9O RVdTICAgICAgICAgICAgICAgfCAgNSArKysrKwogbGlzcC9jdXMtdGhlbWUuZWwgICAgICB8ICA3 ICsrKysrLS0KIGxpc3AvZm9udC1sb2NrLmVsICAgICAgfCA0NSArKysrKysrKysrKysrKysrKysr KysrKysrKysrKysrKysrKysrKysrKysKIDQgZmlsZXMgY2hhbmdlZCwgNzYgaW5zZXJ0aW9ucygr KSwgMiBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9kb2MvbGlzcHJlZi9tb2Rlcy50ZXhpIGIv ZG9jL2xpc3ByZWYvbW9kZXMudGV4aQppbmRleCBmNTg3MjUyNDIyLi4wMDk1ZDYyMDI2IDEwMDY0 NAotLS0gYS9kb2MvbGlzcHJlZi9tb2Rlcy50ZXhpCisrKyBiL2RvYy9saXNwcmVmL21vZGVzLnRl eGkKQEAgLTM2NTMsNiArMzY1MywyNyBAQCBGYWNlcyBmb3IgRm9udCBMb2NrCiBAaXRlbSBmb250 LWxvY2stbmVnYXRpb24tY2hhci1mYWNlCiBAdmluZGV4IGZvbnQtbG9jay1uZWdhdGlvbi1jaGFy LWZhY2UKIGZvciBlYXNpbHktb3Zlcmxvb2tlZCBuZWdhdGlvbiBjaGFyYWN0ZXJzLgorCitAaXRl bSBmb250LWxvY2stZXNjYXBlLWZhY2UKK0B2aW5kZXggZm9udC1sb2NrLWVzY2FwZS1mYWNlCitm b3IgZXNjYXBlIHNlcXVlbmNlcyBpbiBzdHJpbmdzLgorCitAaXRlbSBmb250LWxvY2stbnVtYmVy LWZhY2UKK0B2aW5kZXggZm9udC1sb2NrLW51bWJlci1mYWNlCitmb3IgbnVtYmVycy4KKworQGl0 ZW0gZm9udC1sb2NrLW9wZXJhdG9yLWZhY2UKK0B2aW5kZXggZm9udC1sb2NrLW9wZXJhdG9yLWZh Y2UKK2ZvciBvcGVyYXRvcnMuCisKK0BpdGVtIGZvbnQtbG9jay1wcm9wZXJ0eS1mYWNlCitAdmlu ZGV4IGZvbnQtbG9jay1wcm9wZXJ0eS1mYWNlCitmb3IgcHJvcGVydGllcywgc3VjaCBhcyBmaWVs ZHMgb2YgYSBzdHJ1Y3Qgb3IgY2xhc3MuCitUaGlzIGZhY2UgaW5oZXJpdHMsIGJ5IGRlZmF1bHQs IGZyb20gQGNvZGV7Zm9udC1sb2NrLXZhcmlhYmxlLW5hbWUtZmFjZX0uCisKK0BpdGVtIGZvbnQt bG9jay1wdW5jdHVhdGlvbi1mYWNlCitAdmluZGV4IGZvbnQtbG9jay1wdW5jdHVhdGlvbi1mYWNl Citmb3IgcHVuY3R1YXRpb24uCiBAZW5kIHRhYmxlCiAKIEBub2RlIFN5bnRhY3RpYyBGb250IExv Y2sKZGlmZiAtLWdpdCBhL2V0Yy9ORVdTIGIvZXRjL05FV1MKaW5kZXggYzVhMTQyYjUwMC4uYjFl MzQyZWZmNiAxMDA2NDQKLS0tIGEvZXRjL05FV1MKKysrIGIvZXRjL05FV1MKQEAgLTczMiw2ICs3 MzIsMTEgQEAgSWYgdGhlIGN1cnJlbnQgYnVmZmVyIGlzIHZpc2l0aW5nIGEgZmlsZSB0aGF0IGlz IGV4ZWN1dGFibGUsIHRoZQogVGhpcyBkZXRlcm1pbmVzIGhvdyBsb25nIHRvIHBhdXNlIEVtYWNz IGFmdGVyIGEgcHJvY2VzcwogZmlsdGVyL3NlbnRpbmVsIGVycm9yIGhhcyBiZWVuIGhhbmRsZWQu CiAKKysrKworKiogTmV3IGZhY2VzIGZvciBmb250LWxvY2suCisnZm9udC1sb2NrLWVzY2FwZS1m YWNlJywgJ2ZvbnQtbG9jay1udW1iZXItZmFjZScsICdmb250LWxvY2stb3BlcmF0b3ItZmFjZScs CisnZm9udC1sb2NrLXByb3BlcnR5LWZhY2UnLCAnZm9udC1sb2NrLXB1bmN0dWF0aW9uLWZhY2Un LgorCiArKysKICoqIE5ldyBmYWNlICd2YXJpYWJsZS1waXRjaC10ZXh0Jy4KIFRoaXMgZmFjZSBp cyBsaWtlICd2YXJpYWJsZS1waXRjaCcgKGZyb20gd2hpY2ggaXQgaW5oZXJpdHMpLCBidXQgaXMK ZGlmZiAtLWdpdCBhL2xpc3AvY3VzLXRoZW1lLmVsIGIvbGlzcC9jdXMtdGhlbWUuZWwKaW5kZXgg OTA2ODBmZjY4Zi4uYTk3N2Q2ODM0YyAxMDA2NDQKLS0tIGEvbGlzcC9jdXMtdGhlbWUuZWwKKysr IGIvbGlzcC9jdXMtdGhlbWUuZWwKQEAgLTY4LDkgKzY4LDEyIEBAIGN1c3RvbS10aGVtZS0tbGlz dGVkLWZhY2VzCiAgIHNoYWRvdyBzZWNvbmRhcnktc2VsZWN0aW9uIHRyYWlsaW5nLXdoaXRlc3Bh Y2UKICAgZm9udC1sb2NrLWJ1aWx0aW4tZmFjZSBmb250LWxvY2stY29tbWVudC1kZWxpbWl0ZXIt ZmFjZQogICBmb250LWxvY2stY29tbWVudC1mYWNlIGZvbnQtbG9jay1jb25zdGFudC1mYWNlCi0g IGZvbnQtbG9jay1kb2MtZmFjZSBmb250LWxvY2stZG9jLW1hcmt1cC1mYWNlIGZvbnQtbG9jay1m dW5jdGlvbi1uYW1lLWZhY2UKKyAgZm9udC1sb2NrLWRvYy1mYWNlIGZvbnQtbG9jay1kb2MtbWFy a3VwLWZhY2UKKyAgZm9udC1sb2NrLWVzY2FwZS1mYWNlIGZvbnQtbG9jay1mdW5jdGlvbi1uYW1l LWZhY2UKICAgZm9udC1sb2NrLWtleXdvcmQtZmFjZSBmb250LWxvY2stbmVnYXRpb24tY2hhci1m YWNlCi0gIGZvbnQtbG9jay1wcmVwcm9jZXNzb3ItZmFjZSBmb250LWxvY2stcmVnZXhwLWdyb3Vw aW5nLWJhY2tzbGFzaAorICBmb250LWxvY2stbnVtYmVyLWZhY2UgZm9udC1sb2NrLW9wZXJhdG9y LWZhY2UKKyAgZm9udC1sb2NrLXByZXByb2Nlc3Nvci1mYWNlIGZvbnQtbG9jay1wcm9wZXJ0eS1m YWNlCisgIGZvbnQtbG9jay1wdW5jdHVhdGlvbi1mYWNlIGZvbnQtbG9jay1yZWdleHAtZ3JvdXBp bmctYmFja3NsYXNoCiAgIGZvbnQtbG9jay1yZWdleHAtZ3JvdXBpbmctY29uc3RydWN0IGZvbnQt bG9jay1zdHJpbmctZmFjZQogICBmb250LWxvY2stdHlwZS1mYWNlIGZvbnQtbG9jay12YXJpYWJs ZS1uYW1lLWZhY2UKICAgZm9udC1sb2NrLXdhcm5pbmctZmFjZSBidXR0b24gbGluayBsaW5rLXZp c2l0ZWQgZnJpbmdlCmRpZmYgLS1naXQgYS9saXNwL2ZvbnQtbG9jay5lbCBiL2xpc3AvZm9udC1s b2NrLmVsCmluZGV4IGI2ZjQxNTA5NjQuLjUxYzBiMTU2ZWUgMTAwNjQ0Ci0tLSBhL2xpc3AvZm9u dC1sb2NrLmVsCisrKyBiL2xpc3AvZm9udC1sb2NrLmVsCkBAIC0zNTksNiArMzU5LDIxIEBAIGZv bnQtbG9jay1uZWdhdGlvbi1jaGFyLWZhY2UKIChkZWZ2YXIgZm9udC1sb2NrLXByZXByb2Nlc3Nv ci1mYWNlCSdmb250LWxvY2stcHJlcHJvY2Vzc29yLWZhY2UKICAgIkZhY2UgbmFtZSB0byB1c2Ug Zm9yIHByZXByb2Nlc3NvciBkaXJlY3RpdmVzLiIpCiAKKyhkZWZ2YXIgZm9udC1sb2NrLWVzY2Fw ZS1mYWNlCQknZm9udC1sb2NrLWVzY2FwZS1mYWNlCisgICJGYWNlIG5hbWUgdG8gdXNlIGZvciBl c2NhcGUgc2VxdWVuY2VzIGluIHN0cmluZ3MuIikKKworKGRlZnZhciBmb250LWxvY2stbnVtYmVy LWZhY2UJCSdmb250LWxvY2stbnVtYmVyLWZhY2UKKyAgIkZhY2UgbmFtZSB0byB1c2UgZm9yIG51 bWJlcnMuIikKKworKGRlZnZhciBmb250LWxvY2stb3BlcmF0b3ItZmFjZQknZm9udC1sb2NrLW9w ZXJhdG9yLWZhY2UKKyAgIkZhY2UgbmFtZSB0byB1c2UgZm9yIG9wZXJhdG9ycy4iKQorCisoZGVm dmFyIGZvbnQtbG9jay1wcm9wZXJ0eS1mYWNlCSdmb250LWxvY2stcHJvcGVydHktZmFjZQorICAi RmFjZSBuYW1lIHRvIHVzZSBmb3IgcHJvcGVydGllcy4iKQorCisoZGVmdmFyIGZvbnQtbG9jay1w dW5jdHVhdGlvbi1mYWNlCSdmb250LWxvY2stcHVuY3R1YXRpb24tZmFjZQorICAiRmFjZSBuYW1l IHRvIHVzZSBmb3IgcHVuY3R1YXRpb24uIikKKwogOzsgRm9udGlmaWNhdGlvbiB2YXJpYWJsZXM6 CiAKIChkZWZ2YXIgZm9udC1sb2NrLWtleXdvcmRzIG5pbApAQCAtMjA3Myw2ICsyMDg4LDM2IEBA IGZvbnQtbG9jay1wcmVwcm9jZXNzb3ItZmFjZQogICAiRm9udCBMb2NrIG1vZGUgZmFjZSB1c2Vk IHRvIGhpZ2hsaWdodCBwcmVwcm9jZXNzb3IgZGlyZWN0aXZlcy4iCiAgIDpncm91cCAnZm9udC1s b2NrLWZhY2VzKQogCisoZGVmZmFjZSBmb250LWxvY2stZXNjYXBlLWZhY2UKKyAgJygodCBuaWwp KQorICAiRm9udCBMb2NrIG1vZGUgZmFjZSB1c2VkIHRvIGhpZ2hsaWdodCBlc2NhcGUgc2VxdWVu Y2VzIGluIHN0cmluZ3MuIgorICA6Z3JvdXAgJ2ZvbnQtbG9jay1mYWNlcworICA6dmVyc2lvbiAi MjkuMSIpCisKKyhkZWZmYWNlIGZvbnQtbG9jay1udW1iZXItZmFjZQorICAnKCh0IG5pbCkpCisg ICJGb250IExvY2sgbW9kZSBmYWNlIHVzZWQgdG8gaGlnaGxpZ2h0IG51bWJlcnMuIgorICA6Z3Jv dXAgJ2ZvbnQtbG9jay1mYWNlcworICA6dmVyc2lvbiAiMjkuMSIpCisKKyhkZWZmYWNlIGZvbnQt bG9jay1vcGVyYXRvci1mYWNlCisgICcoKHQgbmlsKSkKKyAgIkZvbnQgTG9jayBtb2RlIGZhY2Ug dXNlZCB0byBoaWdobGlnaHQgb3BlcmF0b3JzLiIKKyAgOmdyb3VwICdmb250LWxvY2stZmFjZXMK KyAgOnZlcnNpb24gIjI5LjEiKQorCisoZGVmZmFjZSBmb250LWxvY2stcHJvcGVydHktZmFjZQor ICAnKCh0IDppbmhlcml0IGZvbnQtbG9jay12YXJpYWJsZS1uYW1lLWZhY2UpKQorICAiRm9udCBM b2NrIG1vZGUgZmFjZSB1c2VkIHRvIGhpZ2hsaWdodCBwcm9wZXJ0aWVzLiIKKyAgOmdyb3VwICdm b250LWxvY2stZmFjZXMKKyAgOnZlcnNpb24gIjI5LjEiKQorCisoZGVmZmFjZSBmb250LWxvY2st cHVuY3R1YXRpb24tZmFjZQorICAnKCh0IG5pbCkpCisgICJGb250IExvY2sgbW9kZSBmYWNlIHVz ZWQgdG8gaGlnaGxpZ2h0IHB1bmN0dWF0aW9uLiIKKyAgOmdyb3VwICdmb250LWxvY2stZmFjZXMK KyAgOnZlcnNpb24gIjI5LjEiKQorCiAoZGVmZmFjZSBmb250LWxvY2stcmVnZXhwLWdyb3VwaW5n LWJhY2tzbGFzaAogICAnKCh0IDppbmhlcml0IGJvbGQpKQogICAiRm9udCBMb2NrIG1vZGUgZmFj ZSBmb3IgYmFja3NsYXNoZXMgaW4gTGlzcCByZWdleHAgZ3JvdXBpbmcgY29uc3RydWN0cy4iCi0t IAoyLjM4LjEKCg== --b1_xj3bTkZOEAUCaQf3hFJfPzap3EwHUzuh7XzURklE-- From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 31 22:15:00 2022 Received: (at 58940) by debbugs.gnu.org; 1 Nov 2022 02:15:00 +0000 Received: from localhost ([127.0.0.1]:42335 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1opgns-0001oE-1Y for submit@debbugs.gnu.org; Mon, 31 Oct 2022 22:15:00 -0400 Received: from mail-pl1-f176.google.com ([209.85.214.176]:37779) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1opgnq-0001o2-PE for 58940@debbugs.gnu.org; Mon, 31 Oct 2022 22:14:59 -0400 Received: by mail-pl1-f176.google.com with SMTP id d24so12344680pls.4 for <58940@debbugs.gnu.org>; Mon, 31 Oct 2022 19:14:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=Vyt0YEsI3ZNLtZ/m+KIyhZVrwbPt8QEUd2BUncA8liM=; b=m8b487Oc2gqR4fs/kxh+4MxDN038MJEAbvs33TpwlBMNOcjQKNtHz+HYXReafWGo5v sEQ0YJ8F033OL0iFfp/jNAiAfkNx+Qpk9WKQUMtx7vPTJnyogpt6LPPf1mSb44x24TEr zRh7sbPVoYH8Lf3U+qIX9QewcRPVGqZT2q/RdtX63gJ8P/9pclxEFzUuUBRee/CuytY2 19bsqMnY2qIgwEjjLnaYFnEniGuVdaOogCojVjIVJJudIBZAXp/ZSseTQWzvyqER1loA W5m+ZKlGqd+qrztUgFjb8Rea1RQbyvUW2fmvBniwxR+rWL/p+PDiM9wgPJwaN+6SBwav /M4g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Vyt0YEsI3ZNLtZ/m+KIyhZVrwbPt8QEUd2BUncA8liM=; b=S2RklgVx0vRs+Y5yOWkx+M9Jt2LmvVwtphlF8J03NWzNvPHr/UO2nLhsO1rsn07jZc D1yqKBlDA4sIhvpNrZouZ6b80NOobPyfiMig6SRiY81q0dnMU/d9AMR24tpkYm9Frqxx Zh4HdLdr5HtyvKqK9vTSD3xrT88bsgzKTBdkpL5243lOPFAWfK/o5OolbV32IEA1LilP /d8RTSwyUe9nlxzqCv7sxZ8O5/YWPhJIPAH5ciG6KJtmBUe7oi7kd3H8rx405Tc67u// AzEHhFbyT1tQQ1uyMsig0Q6tNavIoYFDgf7QuuVblX7w98SUGPCBXS+CZtfiBs8sOMZ4 rhVQ== X-Gm-Message-State: ACrzQf30FggnQcY1nGcEniGQWdUyqVRuBHyjF3e/YjYsWCAG9G4U1Ho9 aoxKzAi2nfkaCZifk7ikcYU= X-Google-Smtp-Source: AMsMyM5dvYj5NYE69/3fiGXl2hrxiopmShhPGrSr+32fAo5PgK3+l5mhWHy22kGTt27CihrCCHu4Sw== X-Received: by 2002:a17:90b:4d0c:b0:20b:c983:2d85 with SMTP id mw12-20020a17090b4d0c00b0020bc9832d85mr35370813pjb.45.1667268892782; Mon, 31 Oct 2022 19:14:52 -0700 (PDT) Received: from smtpclient.apple (cpe-172-117-161-177.socal.res.rr.com. [172.117.161.177]) by smtp.gmail.com with ESMTPSA id u18-20020a170902e81200b001868d4600b8sm5079462plg.158.2022.10.31.19.14.52 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 31 Oct 2022 19:14:52 -0700 (PDT) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.1\)) Subject: Re: bug#58940: [PATCH] feature/tree-sitter: Add more font lock faces From: Yuan Fu In-Reply-To: Date: Mon, 31 Oct 2022 19:14:51 -0700 Content-Transfer-Encoding: quoted-printable Message-Id: References: To: Randy Taylor X-Mailer: Apple Mail (2.3696.120.41.1.1) X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 58940 Cc: 58940@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > On Oct 31, 2022, at 6:21 PM, Randy Taylor wrote: >=20 > The attached patch adds the following faces: > =E2=80=A2 font-lock-escape-face > =E2=80=A2 font-lock-number-face > =E2=80=A2 font-lock-operator-face > =E2=80=A2 font-lock-property-face > =E2=80=A2 font-lock-punctuation-face >=20 > font-lock-property-face inherits font-lock-variable-name-face which = matches the behaviour of cc-mode and python-mode. >=20 > font-lock-escape-face inherits nothing. In python-mode, it inherits = font-lock-constant-face, but not in cc-mode. Do we want it to inherit = anything? >=20 > Hopefully I put everything in the right place. >=20 > <0001-Add-more-font-lock-faces.patch> Looks good! I would add a bit more explanation/example for = font-lock-property-face and font-lock-punctuation-face. Eg, it=E2=80=99s = not immediately clear to me what does preperty represent (property of an = object as in obj.prop?). And it would be nice to say that = punctuation-face are for commas and parenthesises. Yuan= From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 01 18:54:31 2022 Received: (at 58940) by debbugs.gnu.org; 1 Nov 2022 22:54:31 +0000 Received: from localhost ([127.0.0.1]:44419 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oq09P-0006Np-Jl for submit@debbugs.gnu.org; Tue, 01 Nov 2022 18:54:31 -0400 Received: from mail-wr1-f41.google.com ([209.85.221.41]:42678) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oq09N-0006Nb-D5 for 58940@debbugs.gnu.org; Tue, 01 Nov 2022 18:54:29 -0400 Received: by mail-wr1-f41.google.com with SMTP id cl5so10483876wrb.9 for <58940@debbugs.gnu.org>; Tue, 01 Nov 2022 15:54:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :sender:from:to:cc:subject:date:message-id:reply-to; bh=q4sR0iIncIb26T7rnGB+OAA9ZkCWEO6RQUWIsIOgZ1s=; b=AD98UO4Lwp4hMEdTB1CyE2ft6hfryAJhWIszSn5b5ENZt9PxfF8q+xoBO+blXp09b9 /hu88h/Uzae+/iwN0zgJ4imL7xhtPQzZjdh4cx9LLFZNDzUz8JZolKTg0cIS58WogoTf DM7v9FHsTzT4689A8AAOPi7xElPaZqPO9Wsu/0iOTipIYMCkJWED4khZSFMkNyNBxuYc AZNH26lM5Y2YfoARJVY7UAW3caIEpoLPjL64ZYyPwr/sUph1oJX8b0sicy7YLLnao1kL r36W4ygfLEMMJQjiuoJQ2t10V3XVKzRSAc3toFTlqvDsDmKpH7ttzFyQ3VOi3yOG+2kq z9SA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :sender:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=q4sR0iIncIb26T7rnGB+OAA9ZkCWEO6RQUWIsIOgZ1s=; b=tTr8pWFZr2TE4Z6iIy3OOp2/XCPGUJKl4e0ryR0BBfLlFIcbp1YS7C/3CNA1R3xz95 TAbEpgeHWPPRYUoTwp/qC2Ll59QzQV/I5ekwdZ7gRZ3Yif7CSVi6R3Q/Yj5IqiwWNyV7 SX1XZpJAlNGaTLU+uDrPOWaDHOf1mXF3l0t1SR/ryJ6Nm869kaPXyg9gQ2nKkyKsOZeV 6lBNQRcHb2TZkW51WjbCghYHxBODOPT8vfFyCy2cm/fKAfYIM+MbRAXMSY8l9sy3lzGp aCF72NwmIIUjP9HU1SYGgJKv0hpL0tdq9vKrglI/Oi6Qim0wb0Wqy0fpE1N3vlwJF585 rAtw== X-Gm-Message-State: ACrzQf0arZPNX7gI+V/7uay/ixkfAMepBCaTy15zVNCNX4Rp1DGYfibT LTlOanExmzpqlFstdToPcKM= X-Google-Smtp-Source: AMsMyM7ZFJeV5zdFC1rtzo2k10CVpNgsWOB1ydvLtwdaXbAFbigqq4clrkEaUh0/cu6jRg0dWJmA/A== X-Received: by 2002:a5d:6589:0:b0:236:52af:3b70 with SMTP id q9-20020a5d6589000000b0023652af3b70mr12496213wru.349.1667343263375; Tue, 01 Nov 2022 15:54:23 -0700 (PDT) Received: from [192.168.0.6] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id o5-20020a05600c4fc500b003b477532e66sm1423287wmq.2.2022.11.01.15.54.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 01 Nov 2022 15:54:23 -0700 (PDT) Message-ID: Date: Wed, 2 Nov 2022 00:54:21 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: bug#58940: [PATCH] feature/tree-sitter: Add more font lock faces Content-Language: en-US To: Randy Taylor , 58940@debbugs.gnu.org References: From: Dmitry Gutov In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: 58940 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) On 01.11.2022 03:21, Randy Taylor wrote: > font-lock-escape-face inherits nothing. In python-mode, it inherits > font-lock-constant-face, but not in cc-mode. Do we want it to inherit > anything? It might be a good idea to inherit from font-lock-regexp-grouping-backslash. Or vice versa. From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 01 22:04:27 2022 Received: (at 58940) by debbugs.gnu.org; 2 Nov 2022 02:04:27 +0000 Received: from localhost ([127.0.0.1]:44528 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oq37D-0002ri-0t for submit@debbugs.gnu.org; Tue, 01 Nov 2022 22:04:27 -0400 Received: from mail-4323.proton.ch ([185.70.43.23]:55601) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oq379-0002rT-NT for 58940@debbugs.gnu.org; Tue, 01 Nov 2022 22:04:25 -0400 Date: Wed, 02 Nov 2022 02:04:12 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rjt.dev; s=protonmail2; t=1667354655; x=1667613855; bh=UcO/zHeDAgzORDA951t88Vp+amd/xhwdy1nuq0QBisI=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector; b=X25FTW7dciaE48rQ0aWLls+/xkc9+etT9oXnJYugTFM9Ln0/YGRoxNkgn6RM/D0bS Gdw+PL2tCFiezhM6dkdo43dnoof7yA6ZzxsJ5fhGl973BWLwrwwFM/opm2yITgmytH QXNve1qD+kP5Q+w8LeA63BrAFjHaW9ciduyoQ9xt8Lkd95hDOa7RuQF9PSu+YABqBj WQhLBhYGkE7UKFTnQvMyLJQkXiT8CZaq3taGSmQC/y3SWFTcEAwOtbeK5QWLYMO+Cw o5+ojWKLZclIUACoup2kEkMIh4oX/4ePIyWAzE+Hhfnq5lqdEzCXW0wOPxyQFBvDbx P6Sg8Fee2EagQ== To: Yuan Fu From: Randy Taylor Subject: Re: bug#58940: [PATCH] feature/tree-sitter: Add more font lock faces Message-ID: In-Reply-To: References: Feedback-ID: 44397038:user:proton MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="b1_BGnqwK6nRFguZExTEL9aMkUie0agnT2fWvHCUcd4I" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 58940 Cc: 58940@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) This is a multi-part message in MIME format. --b1_BGnqwK6nRFguZExTEL9aMkUie0agnT2fWvHCUcd4I Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On Monday, October 31st, 2022 at 22:14, Yuan Fu wrote: > Looks good! I would add a bit more explanation/example for font-lock-prop= erty-face and font-lock-punctuation-face. Eg, it=E2=80=99s not immediately = clear to me what does preperty represent (property of an object as in obj.p= rop?). And it would be nice to say that punctuation-face are for commas and= parenthesises. I added explanations (and an example for property) to the documentation. I'm wondering if we want to separate out the punctuation as follows: - font-lock-punctuation-delimiter-face - font-lock-punctuation-bracket-face - font-lock-punctuation-special-face for any punctuation that doesn't fit in the aforementioned categories. These would all inherit from font-lock-punctuation-face. I think it would be more useful than just having font-lock-punctuation-face, since I think most people would style a particular type of punctuation, as opposed to all of it. And in the definition of the highlight queries, they will usually be grouped like above anyway. --b1_BGnqwK6nRFguZExTEL9aMkUie0agnT2fWvHCUcd4I Content-Type: text/x-patch; name=0001-Add-more-font-lock-faces.patch Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename=0001-Add-more-font-lock-faces.patch RnJvbSA4YWI4NTQ1YWYwZGMxM2Q2ZTkwZDYyMDYzNzc3ZjkwYzUzYmVhOTExIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBSYW5keSBUYXlsb3IgPGRldkByanQuZGV2PgpEYXRlOiBGcmks IDI4IE9jdCAyMDIyIDIyOjM5OjUwIC0wNDAwClN1YmplY3Q6IFtQQVRDSF0gQWRkIG1vcmUgZm9u dC1sb2NrIGZhY2VzCgoqIGxpc3AvZm9udC1sb2NrLmVsIChmb250LWxvY2stZXNjYXBlLWZhY2Us IGZvbnQtbG9jay1udW1iZXItZmFjZSwKZm9udC1sb2NrLW9wZXJhdG9yLWZhY2UsIGZvbnQtbG9j ay1wcm9wZXJ0eS1mYWNlLApmb250LWxvY2stcHVuY3R1YXRpb24tZmFjZSk6IERlZmluZSBuZXcg ZmFjZXMuCiogbGlzcC9jdXMtdGhlbWUuZWwgKGN1c3RvbS10aGVtZS0tbGlzdGVkLWZhY2VzKTog QWRkIHRoZW0gdG8gdGhlIGxpc3QuCiogZG9jL2xpc3ByZWYvbW9kZXMudGV4aSAoRmFjZXMgZm9y IEZvbnQgTG9jayk6IERvY3VtZW50IHRoZW0uCiogZXRjL05FV1M6IE1lbnRpb24gdGhlbS4KLS0t CiBkb2MvbGlzcHJlZi9tb2Rlcy50ZXhpIHwgNDAgKysrKysrKysrKysrKysrKysrKysrKysrKysr KysrKysrKysrKwogZXRjL05FV1MgICAgICAgICAgICAgICB8ICA1ICsrKysrCiBsaXNwL2N1cy10 aGVtZS5lbCAgICAgIHwgIDcgKysrKystLQogbGlzcC9mb250LWxvY2suZWwgICAgICB8IDQ1ICsr KysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKwogNCBmaWxlcyBjaGFuZ2Vk LCA5NSBpbnNlcnRpb25zKCspLCAyIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL2RvYy9saXNw cmVmL21vZGVzLnRleGkgYi9kb2MvbGlzcHJlZi9tb2Rlcy50ZXhpCmluZGV4IGQ3Nzg2MzZkNmQu LmQ5OTY0NDYxODkgMTAwNjQ0Ci0tLSBhL2RvYy9saXNwcmVmL21vZGVzLnRleGkKKysrIGIvZG9j L2xpc3ByZWYvbW9kZXMudGV4aQpAQCAtMzY1Myw2ICszNjUzLDQ2IEBAIEZhY2VzIGZvciBGb250 IExvY2sKIEBpdGVtIGZvbnQtbG9jay1uZWdhdGlvbi1jaGFyLWZhY2UKIEB2aW5kZXggZm9udC1s b2NrLW5lZ2F0aW9uLWNoYXItZmFjZQogZm9yIGVhc2lseS1vdmVybG9va2VkIG5lZ2F0aW9uIGNo YXJhY3RlcnMuCisKK0BpdGVtIGZvbnQtbG9jay1lc2NhcGUtZmFjZQorQHZpbmRleCBmb250LWxv Y2stZXNjYXBlLWZhY2UKK2ZvciBlc2NhcGUgc2VxdWVuY2VzIGluIHN0cmluZ3MuCisKK0BpdGVt IGZvbnQtbG9jay1udW1iZXItZmFjZQorQHZpbmRleCBmb250LWxvY2stbnVtYmVyLWZhY2UKK2Zv ciBudW1iZXJzLgorCitAaXRlbSBmb250LWxvY2stb3BlcmF0b3ItZmFjZQorQHZpbmRleCBmb250 LWxvY2stb3BlcmF0b3ItZmFjZQorZm9yIG9wZXJhdG9ycy4KKworQGl0ZW0gZm9udC1sb2NrLXBy b3BlcnR5LWZhY2UKK0B2aW5kZXggZm9udC1sb2NrLXByb3BlcnR5LWZhY2UKK2ZvciBwcm9wZXJ0 aWVzIG9mIGFuIG9iamVjdCwgc3VjaCBhcyB0aGUgZGVjbGFyYXRpb24gYW5kIHVzZSBvZiBmaWVs ZHMKK2luIGEgc3RydWN0LgorVGhpcyBmYWNlIGluaGVyaXRzLCBieSBkZWZhdWx0LCBmcm9tIEBj b2Rle2ZvbnQtbG9jay12YXJpYWJsZS1uYW1lLWZhY2V9LgorCitGb3IgZXhhbXBsZSwKKworQHNt YWxsZXhhbXBsZQordHlwZWRlZiBzdHJ1Y3QKK0B7CisgIGludCBwcm9wOworLy8gICAgXiBwcm9w ZXJ0eQorQH0gb2JqOworCitpbnQgbWFpbigpCitAeworICBvYmogbzsKKyAgby5wcm9wID0gMzsK Ky8vICBeIHByb3BlcnR5CitAfQorQGVuZCBzbWFsbGV4YW1wbGUKKworQGl0ZW0gZm9udC1sb2Nr LXB1bmN0dWF0aW9uLWZhY2UKK0B2aW5kZXggZm9udC1sb2NrLXB1bmN0dWF0aW9uLWZhY2UKK2Zv ciBwdW5jdHVhdGlvbiBzdWNoIGFzIGRlbGltaXRlcnMgKGUuZy4gQGNvZGV7O30sIEBjb2Rlezp9 LCBAY29kZXssfSkKK2FuZCBicmFja2V0cyAoZS5nLiBAY29kZXsoKX0sIEBjb2Rle1tdfSwgQGNv ZGV7QHtAfX0pLgogQGVuZCB0YWJsZQogCiBAbm9kZSBTeW50YWN0aWMgRm9udCBMb2NrCmRpZmYg LS1naXQgYS9ldGMvTkVXUyBiL2V0Yy9ORVdTCmluZGV4IGM1YTE0MmI1MDAuLmIxZTM0MmVmZjYg MTAwNjQ0Ci0tLSBhL2V0Yy9ORVdTCisrKyBiL2V0Yy9ORVdTCkBAIC03MzIsNiArNzMyLDExIEBA IElmIHRoZSBjdXJyZW50IGJ1ZmZlciBpcyB2aXNpdGluZyBhIGZpbGUgdGhhdCBpcyBleGVjdXRh YmxlLCB0aGUKIFRoaXMgZGV0ZXJtaW5lcyBob3cgbG9uZyB0byBwYXVzZSBFbWFjcyBhZnRlciBh IHByb2Nlc3MKIGZpbHRlci9zZW50aW5lbCBlcnJvciBoYXMgYmVlbiBoYW5kbGVkLgogCisrKysK KyoqIE5ldyBmYWNlcyBmb3IgZm9udC1sb2NrLgorJ2ZvbnQtbG9jay1lc2NhcGUtZmFjZScsICdm b250LWxvY2stbnVtYmVyLWZhY2UnLCAnZm9udC1sb2NrLW9wZXJhdG9yLWZhY2UnLAorJ2ZvbnQt bG9jay1wcm9wZXJ0eS1mYWNlJywgJ2ZvbnQtbG9jay1wdW5jdHVhdGlvbi1mYWNlJy4KKwogKysr CiAqKiBOZXcgZmFjZSAndmFyaWFibGUtcGl0Y2gtdGV4dCcuCiBUaGlzIGZhY2UgaXMgbGlrZSAn dmFyaWFibGUtcGl0Y2gnIChmcm9tIHdoaWNoIGl0IGluaGVyaXRzKSwgYnV0IGlzCmRpZmYgLS1n aXQgYS9saXNwL2N1cy10aGVtZS5lbCBiL2xpc3AvY3VzLXRoZW1lLmVsCmluZGV4IDkwNjgwZmY2 OGYuLmE5NzdkNjgzNGMgMTAwNjQ0Ci0tLSBhL2xpc3AvY3VzLXRoZW1lLmVsCisrKyBiL2xpc3Av Y3VzLXRoZW1lLmVsCkBAIC02OCw5ICs2OCwxMiBAQCBjdXN0b20tdGhlbWUtLWxpc3RlZC1mYWNl cwogICBzaGFkb3cgc2Vjb25kYXJ5LXNlbGVjdGlvbiB0cmFpbGluZy13aGl0ZXNwYWNlCiAgIGZv bnQtbG9jay1idWlsdGluLWZhY2UgZm9udC1sb2NrLWNvbW1lbnQtZGVsaW1pdGVyLWZhY2UKICAg Zm9udC1sb2NrLWNvbW1lbnQtZmFjZSBmb250LWxvY2stY29uc3RhbnQtZmFjZQotICBmb250LWxv Y2stZG9jLWZhY2UgZm9udC1sb2NrLWRvYy1tYXJrdXAtZmFjZSBmb250LWxvY2stZnVuY3Rpb24t bmFtZS1mYWNlCisgIGZvbnQtbG9jay1kb2MtZmFjZSBmb250LWxvY2stZG9jLW1hcmt1cC1mYWNl CisgIGZvbnQtbG9jay1lc2NhcGUtZmFjZSBmb250LWxvY2stZnVuY3Rpb24tbmFtZS1mYWNlCiAg IGZvbnQtbG9jay1rZXl3b3JkLWZhY2UgZm9udC1sb2NrLW5lZ2F0aW9uLWNoYXItZmFjZQotICBm b250LWxvY2stcHJlcHJvY2Vzc29yLWZhY2UgZm9udC1sb2NrLXJlZ2V4cC1ncm91cGluZy1iYWNr c2xhc2gKKyAgZm9udC1sb2NrLW51bWJlci1mYWNlIGZvbnQtbG9jay1vcGVyYXRvci1mYWNlCisg IGZvbnQtbG9jay1wcmVwcm9jZXNzb3ItZmFjZSBmb250LWxvY2stcHJvcGVydHktZmFjZQorICBm b250LWxvY2stcHVuY3R1YXRpb24tZmFjZSBmb250LWxvY2stcmVnZXhwLWdyb3VwaW5nLWJhY2tz bGFzaAogICBmb250LWxvY2stcmVnZXhwLWdyb3VwaW5nLWNvbnN0cnVjdCBmb250LWxvY2stc3Ry aW5nLWZhY2UKICAgZm9udC1sb2NrLXR5cGUtZmFjZSBmb250LWxvY2stdmFyaWFibGUtbmFtZS1m YWNlCiAgIGZvbnQtbG9jay13YXJuaW5nLWZhY2UgYnV0dG9uIGxpbmsgbGluay12aXNpdGVkIGZy aW5nZQpkaWZmIC0tZ2l0IGEvbGlzcC9mb250LWxvY2suZWwgYi9saXNwL2ZvbnQtbG9jay5lbApp bmRleCBlODhkYzFkM2I3Li4zODcwYTUxMmJjIDEwMDY0NAotLS0gYS9saXNwL2ZvbnQtbG9jay5l bAorKysgYi9saXNwL2ZvbnQtbG9jay5lbApAQCAtMzU5LDYgKzM1OSwyMSBAQCBmb250LWxvY2st bmVnYXRpb24tY2hhci1mYWNlCiAoZGVmdmFyIGZvbnQtbG9jay1wcmVwcm9jZXNzb3ItZmFjZQkn Zm9udC1sb2NrLXByZXByb2Nlc3Nvci1mYWNlCiAgICJGYWNlIG5hbWUgdG8gdXNlIGZvciBwcmVw cm9jZXNzb3IgZGlyZWN0aXZlcy4iKQogCisoZGVmdmFyIGZvbnQtbG9jay1lc2NhcGUtZmFjZQkJ J2ZvbnQtbG9jay1lc2NhcGUtZmFjZQorICAiRmFjZSBuYW1lIHRvIHVzZSBmb3IgZXNjYXBlIHNl cXVlbmNlcyBpbiBzdHJpbmdzLiIpCisKKyhkZWZ2YXIgZm9udC1sb2NrLW51bWJlci1mYWNlCQkn Zm9udC1sb2NrLW51bWJlci1mYWNlCisgICJGYWNlIG5hbWUgdG8gdXNlIGZvciBudW1iZXJzLiIp CisKKyhkZWZ2YXIgZm9udC1sb2NrLW9wZXJhdG9yLWZhY2UJJ2ZvbnQtbG9jay1vcGVyYXRvci1m YWNlCisgICJGYWNlIG5hbWUgdG8gdXNlIGZvciBvcGVyYXRvcnMuIikKKworKGRlZnZhciBmb250 LWxvY2stcHJvcGVydHktZmFjZQknZm9udC1sb2NrLXByb3BlcnR5LWZhY2UKKyAgIkZhY2UgbmFt ZSB0byB1c2UgZm9yIHByb3BlcnRpZXMuIikKKworKGRlZnZhciBmb250LWxvY2stcHVuY3R1YXRp b24tZmFjZQknZm9udC1sb2NrLXB1bmN0dWF0aW9uLWZhY2UKKyAgIkZhY2UgbmFtZSB0byB1c2Ug Zm9yIHB1bmN0dWF0aW9uLiIpCisKIDs7IEZvbnRpZmljYXRpb24gdmFyaWFibGVzOgogCiAoZGVm dmFyIGZvbnQtbG9jay1rZXl3b3JkcyBuaWwKQEAgLTIwODUsNiArMjEwMCwzNiBAQCBmb250LWxv Y2stcHJlcHJvY2Vzc29yLWZhY2UKICAgIkZvbnQgTG9jayBtb2RlIGZhY2UgdXNlZCB0byBoaWdo bGlnaHQgcHJlcHJvY2Vzc29yIGRpcmVjdGl2ZXMuIgogICA6Z3JvdXAgJ2ZvbnQtbG9jay1mYWNl cykKIAorKGRlZmZhY2UgZm9udC1sb2NrLWVzY2FwZS1mYWNlCisgICcoKHQgbmlsKSkKKyAgIkZv bnQgTG9jayBtb2RlIGZhY2UgdXNlZCB0byBoaWdobGlnaHQgZXNjYXBlIHNlcXVlbmNlcyBpbiBz dHJpbmdzLiIKKyAgOmdyb3VwICdmb250LWxvY2stZmFjZXMKKyAgOnZlcnNpb24gIjI5LjEiKQor CisoZGVmZmFjZSBmb250LWxvY2stbnVtYmVyLWZhY2UKKyAgJygodCBuaWwpKQorICAiRm9udCBM b2NrIG1vZGUgZmFjZSB1c2VkIHRvIGhpZ2hsaWdodCBudW1iZXJzLiIKKyAgOmdyb3VwICdmb250 LWxvY2stZmFjZXMKKyAgOnZlcnNpb24gIjI5LjEiKQorCisoZGVmZmFjZSBmb250LWxvY2stb3Bl cmF0b3ItZmFjZQorICAnKCh0IG5pbCkpCisgICJGb250IExvY2sgbW9kZSBmYWNlIHVzZWQgdG8g aGlnaGxpZ2h0IG9wZXJhdG9ycy4iCisgIDpncm91cCAnZm9udC1sb2NrLWZhY2VzCisgIDp2ZXJz aW9uICIyOS4xIikKKworKGRlZmZhY2UgZm9udC1sb2NrLXByb3BlcnR5LWZhY2UKKyAgJygodCA6 aW5oZXJpdCBmb250LWxvY2stdmFyaWFibGUtbmFtZS1mYWNlKSkKKyAgIkZvbnQgTG9jayBtb2Rl IGZhY2UgdXNlZCB0byBoaWdobGlnaHQgcHJvcGVydGllcy4iCisgIDpncm91cCAnZm9udC1sb2Nr LWZhY2VzCisgIDp2ZXJzaW9uICIyOS4xIikKKworKGRlZmZhY2UgZm9udC1sb2NrLXB1bmN0dWF0 aW9uLWZhY2UKKyAgJygodCBuaWwpKQorICAiRm9udCBMb2NrIG1vZGUgZmFjZSB1c2VkIHRvIGhp Z2hsaWdodCBwdW5jdHVhdGlvbi4iCisgIDpncm91cCAnZm9udC1sb2NrLWZhY2VzCisgIDp2ZXJz aW9uICIyOS4xIikKKwogKGRlZmZhY2UgZm9udC1sb2NrLXJlZ2V4cC1ncm91cGluZy1iYWNrc2xh c2gKICAgJygodCA6aW5oZXJpdCBib2xkKSkKICAgIkZvbnQgTG9jayBtb2RlIGZhY2UgZm9yIGJh Y2tzbGFzaGVzIGluIExpc3AgcmVnZXhwIGdyb3VwaW5nIGNvbnN0cnVjdHMuIgotLSAKMi4zOC4x Cgo= --b1_BGnqwK6nRFguZExTEL9aMkUie0agnT2fWvHCUcd4I-- From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 01 22:30:53 2022 Received: (at 58940) by debbugs.gnu.org; 2 Nov 2022 02:30:53 +0000 Received: from localhost ([127.0.0.1]:44544 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oq3Wn-0003VI-KB for submit@debbugs.gnu.org; Tue, 01 Nov 2022 22:30:53 -0400 Received: from mail-4018.proton.ch ([185.70.40.18]:52861) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oq3Wk-0003V2-Kn for 58940@debbugs.gnu.org; Tue, 01 Nov 2022 22:30:52 -0400 Date: Wed, 02 Nov 2022 02:30:33 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rjt.dev; s=protonmail2; t=1667356243; x=1667615443; bh=FLmmd6Pgaxm5xavUB49y8uOapQTDfcMrsI5Yo6GeEUE=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector; b=E8jwxNx/d/ZmdJIawoY7+N8B2qX67I+wFnucHUZXzXUxaO9NwcSWNcjrk/ZyEsChL 5RExGhfcBYZ0EFZTMNvlm9XkAzkBlt+zvss066x7AqU1WwhoZrOrjZ8Ch/qpGOTsAD s3k5iw3ZZiEZHs5jLJltikprnLvbfza0JMgnvbaJTf6u/7YgVm1CbLNtXa6g1cM6om MjAgHE0Ts8jkmz5aYTr2MU7kM06YgYgkMLJ7ji/qiveVDrtsF10fPoJFEZTkVSSAMW 2j9W2KX1pDUF+Lg9JJdZ4lS093IAlQhSI9oOqUA9hTTTqCVGUNzLPXhx6eH1iy7lah knk0XszgcAeCg== To: Dmitry Gutov From: Randy Taylor Subject: Re: bug#58940: [PATCH] feature/tree-sitter: Add more font lock faces Message-ID: In-Reply-To: References: Feedback-ID: 44397038:user:proton MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 58940 Cc: 58940@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Tuesday, November 1st, 2022 at 18:54, Dmitry Gutov wr= ote: > It might be a good idea to inherit from font-lock-regexp-grouping-backsla= sh. >=20 > Or vice versa. Thanks for the suggestion. It seems like a lot of modes don't do anything s= pecial for escape sequences, so to keep with status quo maybe it shouldn't = inherit anything. From debbugs-submit-bounces@debbugs.gnu.org Wed Nov 02 08:27:21 2022 Received: (at 58940) by debbugs.gnu.org; 2 Nov 2022 12:27:21 +0000 Received: from localhost ([127.0.0.1]:45109 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oqCq0-0002fq-Rc for submit@debbugs.gnu.org; Wed, 02 Nov 2022 08:27:21 -0400 Received: from eggs.gnu.org ([209.51.188.92]:55590) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oqCpy-0002fd-GJ for 58940@debbugs.gnu.org; Wed, 02 Nov 2022 08:27:18 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oqCps-0001ZH-G2; Wed, 02 Nov 2022 08:27:12 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=bMD/CMId9Hb8OcD0XClQgCRZQh/mBxqTIP9m829BNso=; b=ijyTm3/LFFRO df+lqF8ZScQ3wunXXBFnHdShyCqhEF/nWK0pauXO0ZY8ou15SoHI+nWIiGVasyq6GBQO6H+FAvOLY VNuDKSk3iurVScQWTZTNZbfU1z1FqtlIdrwNbkMpQ0JLOzKEegZtdqhSNnBctenB9nlMStZMUiN+H RDqix+HZvXwh8TnQ6ZLCkjhHdWqrRl0UBRVLM+JLa81BpbGetdwItTd6ZW4mF8l20sdLsOiGFM2Es O39lHZzY385l4jkCDpdF3zclW0A5HG1xKw7r7tqbhOzISxP8EncgqrsgLwcyIrGEs+zGcCo04Q4WU F/hB5ctlrac4Zbvc6b5H6A==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oqCpr-0004EQ-S8; Wed, 02 Nov 2022 08:27:12 -0400 Date: Wed, 02 Nov 2022 14:27:01 +0200 Message-Id: <835yfxbkyy.fsf@gnu.org> From: Eli Zaretskii To: Randy Taylor In-Reply-To: (message from Randy Taylor on Wed, 02 Nov 2022 02:04:12 +0000) Subject: Re: bug#58940: [PATCH] feature/tree-sitter: Add more font lock faces References: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 58940 Cc: casouri@gmail.com, 58940@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Cc: 58940@debbugs.gnu.org > Date: Wed, 02 Nov 2022 02:04:12 +0000 > From: Randy Taylor > > I'm wondering if we want to separate out the punctuation as follows: > - font-lock-punctuation-delimiter-face > - font-lock-punctuation-bracket-face > - font-lock-punctuation-special-face for any punctuation that doesn't > fit in the aforementioned categories. The names are too wordy, IMO. If we want the above, I suggest font-lock-delimiter-face font-lock-bracket-face font-lock-misc-punctuation-face From debbugs-submit-bounces@debbugs.gnu.org Wed Nov 02 09:41:57 2022 Received: (at 58940) by debbugs.gnu.org; 2 Nov 2022 13:41:57 +0000 Received: from localhost ([127.0.0.1]:45203 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oqE0C-0004l0-NZ for submit@debbugs.gnu.org; Wed, 02 Nov 2022 09:41:56 -0400 Received: from mail-wr1-f46.google.com ([209.85.221.46]:43544) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oqE08-0004km-No for 58940@debbugs.gnu.org; Wed, 02 Nov 2022 09:41:55 -0400 Received: by mail-wr1-f46.google.com with SMTP id g12so24589114wrs.10 for <58940@debbugs.gnu.org>; Wed, 02 Nov 2022 06:41:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:from:to:cc:subject:date:message-id:reply-to; bh=H3lO79LUTHM2pHxMT2Ct4/03MZqDKv4F0KnA/Pc0FSg=; b=eBApIaoC2Z1H9ChgP7j1SfE00h5DGnI1ZZEIoO1tcPAvSNFymM3O8p+VI3O4TD9D9C bfmyiCC+OYwKvqH46FBVk3oZdKGdHRtQ2V/eDA5o1qMTaLbX16T2nfyaOaB8BpKQsYIC vb5K/8O7qRrHk0Dqoh84dA44oKga8FnT68mOyW/FPzobfxLWpMjlUmDethI8aYsmmPrT g9SzFfqVfl0hH3mEi1iJ9VopHwZKOEPfbZ+2XYN3E1JiwLXYBhDNLdHKEv1Gn31+SFE5 jalH5tZAQX2nTJ2yqB+8VW9H8HrpFd61x7DC4UkpBv1NgcagWvLw0M66NAha1UUjlHE3 P5GQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=H3lO79LUTHM2pHxMT2Ct4/03MZqDKv4F0KnA/Pc0FSg=; b=AJ+ok3JofclgcqD+qB9/qlSlwUFZmCW3uhErxURtMNS4IZBJatpSuEh4i5SXuinMqh L5EQ6oD6A8bWuw/d8gRwyiz9A8rdHJZ5XSFQEu7YFGvtmxW3efwHPYXsQB/yOxX3ksYS oMeKtClScdTGRl7KB6PCTtFJ7I/ssERJ5zWHDxIHb9cpQL84ICF9N8DrKS7IB+98MrbP ZhkjHYQhlfnbpQNVALjuOUYLr6nZyDc38gb6Qi6CKJL5BuwuQVjAx7kkS/wi5sj49R81 elKhlOG9/pvWynnJn9ll0gtFGFzgmH8bjU8VEV0mOCW50HNMHvWSLCn4acANB3KPu3am Ww2Q== X-Gm-Message-State: ACrzQf0Ui5+zMhbdbozfHFcEPsdI5UI4kQEnVSXPgtMmHHQ2Q4lNSxsG I0qkZbdcEgtpvapYbKhLYKY= X-Google-Smtp-Source: AMsMyM5bTOE1gwi5ddsviboHDyoedCQi9uu+yQJWmHZRSX6NQ9vHebWhTYi8bWAatmhZLqSKeBJwEQ== X-Received: by 2002:a5d:4351:0:b0:236:c820:97b8 with SMTP id u17-20020a5d4351000000b00236c82097b8mr11390485wrr.699.1667396506631; Wed, 02 Nov 2022 06:41:46 -0700 (PDT) Received: from [192.168.0.6] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id p2-20020a1c5442000000b003c6c4639ac6sm2115015wmi.34.2022.11.02.06.41.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 02 Nov 2022 06:41:46 -0700 (PDT) Message-ID: <8369bbec-8407-4785-45be-c9df239297b2@yandex.ru> Date: Wed, 2 Nov 2022 15:41:44 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: bug#58940: [PATCH] feature/tree-sitter: Add more font lock faces Content-Language: en-US To: Randy Taylor References: From: Dmitry Gutov In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: 58940 Cc: 58940@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) On 02.11.2022 04:30, Randy Taylor wrote: > On Tuesday, November 1st, 2022 at 18:54, Dmitry Gutov wrote: > >> It might be a good idea to inherit from font-lock-regexp-grouping-backslash. >> >> Or vice versa. > Thanks for the suggestion. It seems like a lot of modes don't do anything special for escape sequences, so to keep with status quo maybe it shouldn't inherit anything. This face has customizations in the default and other themes, so it can be useful to do something with it. It's also inherited from in highlight-escape-sequences (ELPA package). As for modes which don't do anything with escape sequences, the upside is that they won't be affected: no chance to break anything. From debbugs-submit-bounces@debbugs.gnu.org Wed Nov 02 22:30:30 2022 Received: (at 58940) by debbugs.gnu.org; 3 Nov 2022 02:30:30 +0000 Received: from localhost ([127.0.0.1]:47469 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oqPzx-0005sq-Uk for submit@debbugs.gnu.org; Wed, 02 Nov 2022 22:30:30 -0400 Received: from mail-4323.proton.ch ([185.70.43.23]:15967) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oqPzv-0005sf-IM for 58940@debbugs.gnu.org; Wed, 02 Nov 2022 22:30:29 -0400 Date: Thu, 03 Nov 2022 02:30:13 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rjt.dev; s=protonmail2; t=1667442619; x=1667701819; bh=Jtz1k+ZlOlsSFAqQpEa8bPqC28LFo+pldtnSk3W194E=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector; b=v7zL9+bDhvB8Eeggtd17INu4THNCGjKj24kqivUhMIyGM9ktdeJQwjR/RGOIR3sIq 0EYzBZ6fENV0v4N6PTmiikaIDF+4U7RB/t0wTEK6OTjgISX+Iu3SxsYaFDG7NinrGr KvEGsvx9Mde+HINR9wxfQ6Ecg4dtGwB6wnl8KFQBC48UBOZ8QhikFnkBCzhkpM6+6/ H1fSc0cdf18ILUq/EPxdOKzwfjDS4bkFmhBwRo/On5ZkJrgsc+uOwxWtyDaqCIZQIQ ph//QMTJbrVuGfdgtSl+ilM2pmoIE5rJ3O8f36NF5oXf5SblqD3qPOU3gfSSyfCcYc IUo4OU9scEypw== To: Dmitry Gutov From: Randy Taylor Subject: Re: bug#58940: [PATCH] feature/tree-sitter: Add more font lock faces Message-ID: In-Reply-To: <8369bbec-8407-4785-45be-c9df239297b2@yandex.ru> References: <8369bbec-8407-4785-45be-c9df239297b2@yandex.ru> Feedback-ID: 44397038:user:proton MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 58940 Cc: 58940@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Wednesday, November 2nd, 2022 at 09:41, Dmitry Gutov = wrote: > This face has customizations in the default and other themes, so it can > be useful to do something with it. >=20 > It's also inherited from in highlight-escape-sequences (ELPA package). >=20 > As for modes which don't do anything with escape sequences, the upside > is that they won't be affected: no chance to break anything. >=20 Sure, I think it makes sense to inherit it. Modes that don't currently do a= nything with escape sequences will be affected when using tree-sitter howev= er, although it's just bold in this case, so not really a big deal. And the= y could just remove escape sequence highlighting in that case too, if they = want. I'll post an updated patch (with Eli's feedback) sometime tomorrow. From debbugs-submit-bounces@debbugs.gnu.org Fri Nov 04 22:46:51 2022 Received: (at 58940) by debbugs.gnu.org; 5 Nov 2022 02:46:51 +0000 Received: from localhost ([127.0.0.1]:55227 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1or9Cs-0007Ji-Ra for submit@debbugs.gnu.org; Fri, 04 Nov 2022 22:46:51 -0400 Received: from mail-40136.proton.ch ([185.70.40.136]:24769) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1or9Co-0007JR-H3 for 58940@debbugs.gnu.org; Fri, 04 Nov 2022 22:46:49 -0400 Date: Sat, 05 Nov 2022 02:46:30 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rjt.dev; s=protonmail2; t=1667616399; x=1667875599; bh=pfJoBvxJIubSdsus0ozUlTsVlhgc3XA2bxM2992QqyY=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector; b=BxF1sI+k9g4T7JSeY1ZBbJgRL9HXZaPgDzJJIkIQsHFWoCAdaezi8f7U+drMdiRf2 TUiAHN0ck9JkOAWjf9KyovMig1Zd9mtj2COtFEYVKhIqRFG59cBcl3i9jh6ib1cxTm oybQFcF7UxqUnIf7F8miOPM6qonMWDBULNRlrZdd/szFfY3WtbywZFyxwcLU8PFwPC Q7vVYRTYqkeDWx2Kzi5yCjbuAptRVQhecDB6x2RLsHmsy8xUpiUc/1um89Mj8vctak WFo7ny7na9Sjlps/QkF6fvq/xvzAplNT9pU3670AxyJM4iQTd5gKHIpxhb6i1MhFvz pu92xYFUCQ+Rg== To: Eli Zaretskii From: Randy Taylor Subject: Re: bug#58940: [PATCH] feature/tree-sitter: Add more font lock faces Message-ID: <8ZKenedKBW2xqbSe_c0vWmeRbMQYCDlwFNvSMAYx9utQYeOKPHQQ-nKW9Y8nCcKRnFMmsnfonvA_0yixtSArBzVY_PkaNxxGWqhXoHjCZTo=@rjt.dev> In-Reply-To: <835yfxbkyy.fsf@gnu.org> References: <835yfxbkyy.fsf@gnu.org> Feedback-ID: 44397038:user:proton MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="b1_SjTKBmpwcMDAVCeR61okhGoogdqQF4MqEtg2wUJwWgU" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 58940 Cc: casouri@gmail.com, 58940@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) This is a multi-part message in MIME format. --b1_SjTKBmpwcMDAVCeR61okhGoogdqQF4MqEtg2wUJwWgU Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On Wednesday, November 2nd, 2022 at 08:27, Eli Zaretskii wro= te: >=20 > The names are too wordy, IMO. If we want the above, I suggest >=20 > font-lock-delimiter-face > font-lock-bracket-face > font-lock-misc-punctuation-face Sorry for the delay, furniture building took longer than anticipated and desired. New changes: - Finally remembered to add Bug# to commit message. - Made font-lock-escape-face inherit from font-lock-regexp-grouping-backslash per Dmitry's suggestion. - Added font-lock-{bracket,delimiter,misc-punctuation}-faces inheriting from font-lock-punctuation-face. With the use of tree-sitter features for syntax highlighting (i.e. specifying specific highlight capabilities), how do we see punctuation being used? Just a 'punctuation feature that includes everything? --b1_SjTKBmpwcMDAVCeR61okhGoogdqQF4MqEtg2wUJwWgU Content-Type: text/x-patch; name=0001-Add-more-font-lock-faces-Bug-58940.patch Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename=0001-Add-more-font-lock-faces-Bug-58940.patch RnJvbSBlODIzNzk5MDAzNzYyNWIwYzkzN2IxZmE1NDg2YzgxMWM2NGQzZDE2IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBSYW5keSBUYXlsb3IgPGRldkByanQuZGV2PgpEYXRlOiBGcmks IDI4IE9jdCAyMDIyIDIyOjM5OjUwIC0wNDAwClN1YmplY3Q6IFtQQVRDSF0gQWRkIG1vcmUgZm9u dC1sb2NrIGZhY2VzIChCdWcjNTg5NDApCgoqIGxpc3AvZm9udC1sb2NrLmVsIChmb250LWxvY2st YnJhY2tldC1mYWNlLCBmb250LWxvY2stZGVsaW1pdGVyLWZhY2UsCmZvbnQtbG9jay1lc2NhcGUt ZmFjZSwgZm9udC1sb2NrLW51bWJlci1mYWNlLApmb250LWxvY2stbWlzYy1wdW5jdHVhdGlvbi1m YWNlLCBmb250LWxvY2stb3BlcmF0b3ItZmFjZSwKZm9udC1sb2NrLXByb3BlcnR5LWZhY2UsIGZv bnQtbG9jay1wdW5jdHVhdGlvbi1mYWNlKTogRGVmaW5lIG5ldwpmYWNlcy4KKiBsaXNwL2N1cy10 aGVtZS5lbCAoY3VzdG9tLXRoZW1lLS1saXN0ZWQtZmFjZXMpOiBBZGQgdGhlbSB0byB0aGUKbGlz dC4KKiBkb2MvbGlzcHJlZi9tb2Rlcy50ZXhpIChGYWNlcyBmb3IgRm9udCBMb2NrKTogRG9jdW1l bnQgdGhlbS4KKiBldGMvTkVXUzogTWVudGlvbiB0aGVtLgotLS0KIGRvYy9saXNwcmVmL21vZGVz LnRleGkgfCA1NCArKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrCiBldGMvTkVXUyAgICAg ICAgICAgICAgIHwgIDcgKysrKwogbGlzcC9jdXMtdGhlbWUuZWwgICAgICB8IDE2ICsrKysrKy0t LS0KIGxpc3AvZm9udC1sb2NrLmVsICAgICAgfCA3MiArKysrKysrKysrKysrKysrKysrKysrKysr KysrKysrKysrKysrKysrKysKIDQgZmlsZXMgY2hhbmdlZCwgMTQzIGluc2VydGlvbnMoKyksIDYg ZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvZG9jL2xpc3ByZWYvbW9kZXMudGV4aSBiL2RvYy9s aXNwcmVmL21vZGVzLnRleGkKaW5kZXggYzFiMDkyMjQ3Yi4uMjkwYmQ1MDc1ZSAxMDA2NDQKLS0t IGEvZG9jL2xpc3ByZWYvbW9kZXMudGV4aQorKysgYi9kb2MvbGlzcHJlZi9tb2Rlcy50ZXhpCkBA IC0zNjUzLDYgKzM2NTMsNjAgQEAgRmFjZXMgZm9yIEZvbnQgTG9jawogQGl0ZW0gZm9udC1sb2Nr LW5lZ2F0aW9uLWNoYXItZmFjZQogQHZpbmRleCBmb250LWxvY2stbmVnYXRpb24tY2hhci1mYWNl CiBmb3IgZWFzaWx5LW92ZXJsb29rZWQgbmVnYXRpb24gY2hhcmFjdGVycy4KKworQGl0ZW0gZm9u dC1sb2NrLWJyYWNrZXQtZmFjZQorQHZpbmRleCBmb250LWxvY2stYnJhY2tldC1mYWNlCitmb3Ig YnJhY2tldHMgKGUuZy4gQGNvZGV7KCl9LCBAY29kZXtbXX0sIEBjb2Rle0B7QH19KS4KK1RoaXMg ZmFjZSBpbmhlcml0cywgYnkgZGVmYXVsdCwgZnJvbSBAY29kZXtmb250LWxvY2stcHVuY3R1YXRp b24tZmFjZX0uCisKK0BpdGVtIGZvbnQtbG9jay1kZWxpbWl0ZXItZmFjZQorQHZpbmRleCBmb250 LWxvY2stZGVsaW1pdGVyLWZhY2UKK2ZvciBkZWxpbWl0ZXJzIChlLmcuIEBjb2Rlezt9LCBAY29k ZXs6fSwgQGNvZGV7LH0pLgorVGhpcyBmYWNlIGluaGVyaXRzLCBieSBkZWZhdWx0LCBmcm9tIEBj b2Rle2ZvbnQtbG9jay1wdW5jdHVhdGlvbi1mYWNlfS4KKworQGl0ZW0gZm9udC1sb2NrLWVzY2Fw ZS1mYWNlCitAdmluZGV4IGZvbnQtbG9jay1lc2NhcGUtZmFjZQorZm9yIGVzY2FwZSBzZXF1ZW5j ZXMgaW4gc3RyaW5ncy4KK1RoaXMgZmFjZSBpbmhlcml0cywgYnkgZGVmYXVsdCwgZnJvbSBAY29k ZXtmb250LWxvY2stcmVnZXhwLWdyb3VwaW5nLWJhY2tzbGFzaH0uCisKK0BpdGVtIGZvbnQtbG9j ay1udW1iZXItZmFjZQorQHZpbmRleCBmb250LWxvY2stbnVtYmVyLWZhY2UKK2ZvciBudW1iZXJz LgorCitAaXRlbSBmb250LWxvY2stbWlzYy1wdW5jdHVhdGlvbi1mYWNlCitAdmluZGV4IGZvbnQt bG9jay1taXNjLXB1bmN0dWF0aW9uLWZhY2UKK2ZvciBwdW5jdHVhdGlvbiB0aGF0IGlzIG5vdCBh IGJyYWNrZXQgb3IgZGVsaW1pdGVyLgorCitAaXRlbSBmb250LWxvY2stb3BlcmF0b3ItZmFjZQor QHZpbmRleCBmb250LWxvY2stb3BlcmF0b3ItZmFjZQorZm9yIG9wZXJhdG9ycy4KKworQGl0ZW0g Zm9udC1sb2NrLXByb3BlcnR5LWZhY2UKK0B2aW5kZXggZm9udC1sb2NrLXByb3BlcnR5LWZhY2UK K2ZvciBwcm9wZXJ0aWVzIG9mIGFuIG9iamVjdCwgc3VjaCBhcyB0aGUgZGVjbGFyYXRpb24gYW5k IHVzZSBvZiBmaWVsZHMKK2luIGEgc3RydWN0LgorVGhpcyBmYWNlIGluaGVyaXRzLCBieSBkZWZh dWx0LCBmcm9tIEBjb2Rle2ZvbnQtbG9jay12YXJpYWJsZS1uYW1lLWZhY2V9LgorCitGb3IgZXhh bXBsZSwKKworQHNtYWxsZXhhbXBsZQordHlwZWRlZiBzdHJ1Y3QKK0B7CisgIGludCBwcm9wOwor Ly8gICAgXiBwcm9wZXJ0eQorQH0gb2JqOworCitpbnQgbWFpbigpCitAeworICBvYmogbzsKKyAg by5wcm9wID0gMzsKKy8vICBeIHByb3BlcnR5CitAfQorQGVuZCBzbWFsbGV4YW1wbGUKKworQGl0 ZW0gZm9udC1sb2NrLXB1bmN0dWF0aW9uLWZhY2UKK0B2aW5kZXggZm9udC1sb2NrLXB1bmN0dWF0 aW9uLWZhY2UKK2ZvciBwdW5jdHVhdGlvbiBzdWNoIGFzIGJyYWNrZXRzIGFuZCBkZWxpbWl0ZXJz LgogQGVuZCB0YWJsZQogCiBAbm9kZSBTeW50YWN0aWMgRm9udCBMb2NrCmRpZmYgLS1naXQgYS9l dGMvTkVXUyBiL2V0Yy9ORVdTCmluZGV4IGM1YTE0MmI1MDAuLjZjZjkyYmRjY2EgMTAwNjQ0Ci0t LSBhL2V0Yy9ORVdTCisrKyBiL2V0Yy9ORVdTCkBAIC03MzIsNiArNzMyLDEzIEBAIElmIHRoZSBj dXJyZW50IGJ1ZmZlciBpcyB2aXNpdGluZyBhIGZpbGUgdGhhdCBpcyBleGVjdXRhYmxlLCB0aGUK IFRoaXMgZGV0ZXJtaW5lcyBob3cgbG9uZyB0byBwYXVzZSBFbWFjcyBhZnRlciBhIHByb2Nlc3MK IGZpbHRlci9zZW50aW5lbCBlcnJvciBoYXMgYmVlbiBoYW5kbGVkLgogCisrKysKKyoqIE5ldyBm YWNlcyBmb3IgZm9udC1sb2NrLgorJ2ZvbnQtbG9jay1icmFja2V0LWZhY2UnLCAnZm9udC1sb2Nr LWRlbGltaXRlci1mYWNlJywKKydmb250LWxvY2stZXNjYXBlLWZhY2UnLCAnZm9udC1sb2NrLW51 bWJlci1mYWNlJywKKydmb250LWxvY2stbWlzYy1wdW5jdHVhdGlvbi1mYWNlJywgJ2ZvbnQtbG9j ay1vcGVyYXRvci1mYWNlJywKKydmb250LWxvY2stcHJvcGVydHktZmFjZScsICdmb250LWxvY2st cHVuY3R1YXRpb24tZmFjZScuCisKICsrKwogKiogTmV3IGZhY2UgJ3ZhcmlhYmxlLXBpdGNoLXRl eHQnLgogVGhpcyBmYWNlIGlzIGxpa2UgJ3ZhcmlhYmxlLXBpdGNoJyAoZnJvbSB3aGljaCBpdCBp bmhlcml0cyksIGJ1dCBpcwpkaWZmIC0tZ2l0IGEvbGlzcC9jdXMtdGhlbWUuZWwgYi9saXNwL2N1 cy10aGVtZS5lbAppbmRleCA5MDY4MGZmNjhmLi4xZGYyYWI4ZGI3IDEwMDY0NAotLS0gYS9saXNw L2N1cy10aGVtZS5lbAorKysgYi9saXNwL2N1cy10aGVtZS5lbApAQCAtNjYsMTMgKzY2LDE3IEBA IGN1c3RvbS10aGVtZS0tbGlzdGVkLWZhY2VzCiAgIHZhcmlhYmxlLXBpdGNoIGVzY2FwZS1nbHlw aCBob21vZ2x5cGgKICAgbWluaWJ1ZmZlci1wcm9tcHQgaGlnaGxpZ2h0IHJlZ2lvbgogICBzaGFk b3cgc2Vjb25kYXJ5LXNlbGVjdGlvbiB0cmFpbGluZy13aGl0ZXNwYWNlCi0gIGZvbnQtbG9jay1i dWlsdGluLWZhY2UgZm9udC1sb2NrLWNvbW1lbnQtZGVsaW1pdGVyLWZhY2UKLSAgZm9udC1sb2Nr LWNvbW1lbnQtZmFjZSBmb250LWxvY2stY29uc3RhbnQtZmFjZQotICBmb250LWxvY2stZG9jLWZh Y2UgZm9udC1sb2NrLWRvYy1tYXJrdXAtZmFjZSBmb250LWxvY2stZnVuY3Rpb24tbmFtZS1mYWNl CisgIGZvbnQtbG9jay1icmFja2V0LWZhY2UgZm9udC1sb2NrLWJ1aWx0aW4tZmFjZQorICBmb250 LWxvY2stY29tbWVudC1kZWxpbWl0ZXItZmFjZSBmb250LWxvY2stY29tbWVudC1mYWNlCisgIGZv bnQtbG9jay1jb25zdGFudC1mYWNlIGZvbnQtbG9jay1kZWxpbWl0ZXItZmFjZQorICBmb250LWxv Y2stZG9jLWZhY2UgZm9udC1sb2NrLWRvYy1tYXJrdXAtZmFjZQorICBmb250LWxvY2stZXNjYXBl LWZhY2UgZm9udC1sb2NrLWZ1bmN0aW9uLW5hbWUtZmFjZQogICBmb250LWxvY2sta2V5d29yZC1m YWNlIGZvbnQtbG9jay1uZWdhdGlvbi1jaGFyLWZhY2UKLSAgZm9udC1sb2NrLXByZXByb2Nlc3Nv ci1mYWNlIGZvbnQtbG9jay1yZWdleHAtZ3JvdXBpbmctYmFja3NsYXNoCi0gIGZvbnQtbG9jay1y ZWdleHAtZ3JvdXBpbmctY29uc3RydWN0IGZvbnQtbG9jay1zdHJpbmctZmFjZQotICBmb250LWxv Y2stdHlwZS1mYWNlIGZvbnQtbG9jay12YXJpYWJsZS1uYW1lLWZhY2UKKyAgZm9udC1sb2NrLW51 bWJlci1mYWNlIGZvbnQtbG9jay1taXNjLXB1bmN0dWF0aW9uLWZhY2UKKyAgZm9udC1sb2NrLW9w ZXJhdG9yLWZhY2UgZm9udC1sb2NrLXByZXByb2Nlc3Nvci1mYWNlCisgIGZvbnQtbG9jay1wcm9w ZXJ0eS1mYWNlIGZvbnQtbG9jay1wdW5jdHVhdGlvbi1mYWNlCisgIGZvbnQtbG9jay1yZWdleHAt Z3JvdXBpbmctYmFja3NsYXNoIGZvbnQtbG9jay1yZWdleHAtZ3JvdXBpbmctY29uc3RydWN0Cisg IGZvbnQtbG9jay1zdHJpbmctZmFjZSBmb250LWxvY2stdHlwZS1mYWNlIGZvbnQtbG9jay12YXJp YWJsZS1uYW1lLWZhY2UKICAgZm9udC1sb2NrLXdhcm5pbmctZmFjZSBidXR0b24gbGluayBsaW5r LXZpc2l0ZWQgZnJpbmdlCiAgIGhlYWRlci1saW5lIHRvb2x0aXAgbW9kZS1saW5lIG1vZGUtbGlu ZS1idWZmZXItaWQKICAgbW9kZS1saW5lLWVtcGhhc2lzIG1vZGUtbGluZS1oaWdobGlnaHQgbW9k ZS1saW5lLWluYWN0aXZlCmRpZmYgLS1naXQgYS9saXNwL2ZvbnQtbG9jay5lbCBiL2xpc3AvZm9u dC1sb2NrLmVsCmluZGV4IGU4OGRjMWQzYjcuLmI3OWQ1Nzg4NDggMTAwNjQ0Ci0tLSBhL2xpc3Av Zm9udC1sb2NrLmVsCisrKyBiL2xpc3AvZm9udC1sb2NrLmVsCkBAIC0zNTksNiArMzU5LDMwIEBA IGZvbnQtbG9jay1uZWdhdGlvbi1jaGFyLWZhY2UKIChkZWZ2YXIgZm9udC1sb2NrLXByZXByb2Nl c3Nvci1mYWNlCSdmb250LWxvY2stcHJlcHJvY2Vzc29yLWZhY2UKICAgIkZhY2UgbmFtZSB0byB1 c2UgZm9yIHByZXByb2Nlc3NvciBkaXJlY3RpdmVzLiIpCiAKKyhkZWZ2YXIgZm9udC1sb2NrLWJy YWNrZXQtZmFjZQkJJ2ZvbnQtbG9jay1icmFja2V0LWZhY2UKKyAgIkZhY2UgbmFtZSB0byB1c2Ug Zm9yIGJyYWNrZXRzLiIpCisKKyhkZWZ2YXIgZm9udC1sb2NrLWRlbGltaXRlci1mYWNlCSdmb250 LWxvY2stZGVsaW1pdGVyLWZhY2UKKyAgIkZhY2UgbmFtZSB0byB1c2UgZm9yIGRlbGltaXRlcnMu IikKKworKGRlZnZhciBmb250LWxvY2stZXNjYXBlLWZhY2UJCSdmb250LWxvY2stZXNjYXBlLWZh Y2UKKyAgIkZhY2UgbmFtZSB0byB1c2UgZm9yIGVzY2FwZSBzZXF1ZW5jZXMgaW4gc3RyaW5ncy4i KQorCisoZGVmdmFyIGZvbnQtbG9jay1udW1iZXItZmFjZQkJJ2ZvbnQtbG9jay1udW1iZXItZmFj ZQorICAiRmFjZSBuYW1lIHRvIHVzZSBmb3IgbnVtYmVycy4iKQorCisoZGVmdmFyIGZvbnQtbG9j ay1taXNjLXB1bmN0dWF0aW9uLWZhY2UgJ2ZvbnQtbG9jay1taXNjLXB1bmN0dWF0aW9uLWZhY2UK KyAgIkZhY2UgbmFtZSB0byB1c2UgZm9yIG1pc2NlbGxhbmVvdXMgcHVuY3R1YXRpb24uIikKKwor KGRlZnZhciBmb250LWxvY2stb3BlcmF0b3ItZmFjZQknZm9udC1sb2NrLW9wZXJhdG9yLWZhY2UK KyAgIkZhY2UgbmFtZSB0byB1c2UgZm9yIG9wZXJhdG9ycy4iKQorCisoZGVmdmFyIGZvbnQtbG9j ay1wcm9wZXJ0eS1mYWNlCSdmb250LWxvY2stcHJvcGVydHktZmFjZQorICAiRmFjZSBuYW1lIHRv IHVzZSBmb3IgcHJvcGVydGllcy4iKQorCisoZGVmdmFyIGZvbnQtbG9jay1wdW5jdHVhdGlvbi1m YWNlCSdmb250LWxvY2stcHVuY3R1YXRpb24tZmFjZQorICAiRmFjZSBuYW1lIHRvIHVzZSBmb3Ig cHVuY3R1YXRpb24uIikKKwogOzsgRm9udGlmaWNhdGlvbiB2YXJpYWJsZXM6CiAKIChkZWZ2YXIg Zm9udC1sb2NrLWtleXdvcmRzIG5pbApAQCAtMjA4NSw2ICsyMTA5LDU0IEBAIGZvbnQtbG9jay1w cmVwcm9jZXNzb3ItZmFjZQogICAiRm9udCBMb2NrIG1vZGUgZmFjZSB1c2VkIHRvIGhpZ2hsaWdo dCBwcmVwcm9jZXNzb3IgZGlyZWN0aXZlcy4iCiAgIDpncm91cCAnZm9udC1sb2NrLWZhY2VzKQog CisoZGVmZmFjZSBmb250LWxvY2stYnJhY2tldC1mYWNlCisgICcoKHQgOmluaGVyaXQgZm9udC1s b2NrLXB1bmN0dWF0aW9uLWZhY2UpKQorICAiRm9udCBMb2NrIG1vZGUgZmFjZSB1c2VkIHRvIGhp Z2hsaWdodCBicmFja2V0cy4iCisgIDpncm91cCAnZm9udC1sb2NrLWZhY2VzCisgIDp2ZXJzaW9u ICIyOS4xIikKKworKGRlZmZhY2UgZm9udC1sb2NrLWRlbGltaXRlci1mYWNlCisgICcoKHQgOmlu aGVyaXQgZm9udC1sb2NrLXB1bmN0dWF0aW9uLWZhY2UpKQorICAiRm9udCBMb2NrIG1vZGUgZmFj ZSB1c2VkIHRvIGhpZ2hsaWdodCBkZWxpbWl0ZXJzLiIKKyAgOmdyb3VwICdmb250LWxvY2stZmFj ZXMKKyAgOnZlcnNpb24gIjI5LjEiKQorCisoZGVmZmFjZSBmb250LWxvY2stZXNjYXBlLWZhY2UK KyAgJygodCA6aW5oZXJpdCBmb250LWxvY2stcmVnZXhwLWdyb3VwaW5nLWJhY2tzbGFzaCkpCisg ICJGb250IExvY2sgbW9kZSBmYWNlIHVzZWQgdG8gaGlnaGxpZ2h0IGVzY2FwZSBzZXF1ZW5jZXMg aW4gc3RyaW5ncy4iCisgIDpncm91cCAnZm9udC1sb2NrLWZhY2VzCisgIDp2ZXJzaW9uICIyOS4x IikKKworKGRlZmZhY2UgZm9udC1sb2NrLW51bWJlci1mYWNlCisgICcoKHQgbmlsKSkKKyAgIkZv bnQgTG9jayBtb2RlIGZhY2UgdXNlZCB0byBoaWdobGlnaHQgbnVtYmVycy4iCisgIDpncm91cCAn Zm9udC1sb2NrLWZhY2VzCisgIDp2ZXJzaW9uICIyOS4xIikKKworKGRlZmZhY2UgZm9udC1sb2Nr LW1pc2MtcHVuY3R1YXRpb24tZmFjZQorICAnKCh0IDppbmhlcml0IGZvbnQtbG9jay1wdW5jdHVh dGlvbi1mYWNlKSkKKyAgIkZvbnQgTG9jayBtb2RlIGZhY2UgdXNlZCB0byBoaWdobGlnaHQgbWlz Y2VsbGFuZW91cyBwdW5jdHVhdGlvbi4iCisgIDpncm91cCAnZm9udC1sb2NrLWZhY2VzCisgIDp2 ZXJzaW9uICIyOS4xIikKKworKGRlZmZhY2UgZm9udC1sb2NrLW9wZXJhdG9yLWZhY2UKKyAgJygo dCBuaWwpKQorICAiRm9udCBMb2NrIG1vZGUgZmFjZSB1c2VkIHRvIGhpZ2hsaWdodCBvcGVyYXRv cnMuIgorICA6Z3JvdXAgJ2ZvbnQtbG9jay1mYWNlcworICA6dmVyc2lvbiAiMjkuMSIpCisKKyhk ZWZmYWNlIGZvbnQtbG9jay1wcm9wZXJ0eS1mYWNlCisgICcoKHQgOmluaGVyaXQgZm9udC1sb2Nr LXZhcmlhYmxlLW5hbWUtZmFjZSkpCisgICJGb250IExvY2sgbW9kZSBmYWNlIHVzZWQgdG8gaGln aGxpZ2h0IHByb3BlcnRpZXMuIgorICA6Z3JvdXAgJ2ZvbnQtbG9jay1mYWNlcworICA6dmVyc2lv biAiMjkuMSIpCisKKyhkZWZmYWNlIGZvbnQtbG9jay1wdW5jdHVhdGlvbi1mYWNlCisgICcoKHQg bmlsKSkKKyAgIkZvbnQgTG9jayBtb2RlIGZhY2UgdXNlZCB0byBoaWdobGlnaHQgcHVuY3R1YXRp b24uIgorICA6Z3JvdXAgJ2ZvbnQtbG9jay1mYWNlcworICA6dmVyc2lvbiAiMjkuMSIpCisKIChk ZWZmYWNlIGZvbnQtbG9jay1yZWdleHAtZ3JvdXBpbmctYmFja3NsYXNoCiAgICcoKHQgOmluaGVy aXQgYm9sZCkpCiAgICJGb250IExvY2sgbW9kZSBmYWNlIGZvciBiYWNrc2xhc2hlcyBpbiBMaXNw IHJlZ2V4cCBncm91cGluZyBjb25zdHJ1Y3RzLiIKLS0gCjIuMzguMQoK --b1_SjTKBmpwcMDAVCeR61okhGoogdqQF4MqEtg2wUJwWgU-- From debbugs-submit-bounces@debbugs.gnu.org Sat Nov 05 05:24:43 2022 Received: (at 58940) by debbugs.gnu.org; 5 Nov 2022 09:24:43 +0000 Received: from localhost ([127.0.0.1]:55460 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1orFPv-00028R-Fs for submit@debbugs.gnu.org; Sat, 05 Nov 2022 05:24:43 -0400 Received: from eggs.gnu.org ([209.51.188.92]:36394) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1orFPr-00028C-72 for 58940@debbugs.gnu.org; Sat, 05 Nov 2022 05:24:42 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1orFPl-0001Mp-Qj; Sat, 05 Nov 2022 05:24:33 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=W1fBtOrLgoyYUantiNpAFzyHjILBUGnh3c6+WjJLvqQ=; b=QhBLZPfcTP8d LJ2NualeurSarKslwGFsnLWsVnRshlzS7NPxMKb6cB4B50+Yh1d+gCzgzxGKU6GMF4c01hgCIfxi9 8iFvE6Z3sozlA1dI2m2SW/iX+imQNnsOjja8luj6KF0GoXs0y0jw7Oa/86GRRpazQ1jmMhUuxRd4K a9rt3ZgBlT2/516DDGHqJyJhOx0epl6Px02hiiCNAAMqKbElKfemqlglFmTpYyVUqIy6fcUqR4hhG vfYf5sOC5ovwiA1z0SzBYSpaendYLbwU4h+B5xlrIjztQbR3kc+3/OWczd/O6zC6t3oP8LwMtCkEJ HqwVGORXHTyZja2wq3wXIQ==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1orFPl-0005ED-20; Sat, 05 Nov 2022 05:24:33 -0400 Date: Sat, 05 Nov 2022 11:24:29 +0200 Message-Id: <83cza14uuq.fsf@gnu.org> From: Eli Zaretskii To: Randy Taylor In-Reply-To: <8ZKenedKBW2xqbSe_c0vWmeRbMQYCDlwFNvSMAYx9utQYeOKPHQQ-nKW9Y8nCcKRnFMmsnfonvA_0yixtSArBzVY_PkaNxxGWqhXoHjCZTo=@rjt.dev> (message from Randy Taylor on Sat, 05 Nov 2022 02:46:30 +0000) Subject: Re: bug#58940: [PATCH] feature/tree-sitter: Add more font lock faces References: <835yfxbkyy.fsf@gnu.org> <8ZKenedKBW2xqbSe_c0vWmeRbMQYCDlwFNvSMAYx9utQYeOKPHQQ-nKW9Y8nCcKRnFMmsnfonvA_0yixtSArBzVY_PkaNxxGWqhXoHjCZTo=@rjt.dev> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 58940 Cc: casouri@gmail.com, 58940@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Sat, 05 Nov 2022 02:46:30 +0000 > From: Randy Taylor > Cc: casouri@gmail.com, 58940@debbugs.gnu.org > > Sorry for the delay, furniture building took longer than anticipated > and desired. We all have our lives, no need to apologize. > +@item font-lock-delimiter-face > +@vindex font-lock-delimiter-face > +for delimiters (e.g. @code{;}, @code{:}, @code{,}). You need a comma or a @: after "e.g.", to avoid its being interpreted as the end of a sentence. > +@item font-lock-escape-face > +@vindex font-lock-escape-face > +for escape sequences in strings. I suggest an example of an escape sequence here, ideally from 2 or more programming languages. > +@smallexample > +typedef struct > +@{ > + int prop; > +// ^ property > +@} obj; > + > +int main() > +@{ > + obj o; > + o.prop = 3; > +// ^ property > +@} > +@end smallexample Please use @group..@end group here, since the two parts of this can be typeset on separate pages, but we don't want each one of thgem to be broken between pages. > --- a/etc/NEWS > +++ b/etc/NEWS > @@ -732,6 +732,13 @@ If the current buffer is visiting a file that is executable, the > This determines how long to pause Emacs after a process > filter/sentinel error has been handled. > > ++++ > +** New faces for font-lock. > +'font-lock-bracket-face', 'font-lock-delimiter-face', > +'font-lock-escape-face', 'font-lock-number-face', > +'font-lock-misc-punctuation-face', 'font-lock-operator-face', > +'font-lock-property-face', 'font-lock-punctuation-face'. Should this say that they are primarily meant for use with tree-sitter? > +(defvar font-lock-property-face 'font-lock-property-face > + "Face name to use for properties.") This doc string is too concise to be useful. Please add some information from the detailed descriptions above. > +(defface font-lock-bracket-face > + '((t :inherit font-lock-punctuation-face)) It is better to have the parent face font-lock-punctuation-face defined before it is used. Thanks. From debbugs-submit-bounces@debbugs.gnu.org Sat Nov 05 21:01:01 2022 Received: (at 58940) by debbugs.gnu.org; 6 Nov 2022 01:01:01 +0000 Received: from localhost ([127.0.0.1]:58405 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1orU20-0008DB-7p for submit@debbugs.gnu.org; Sat, 05 Nov 2022 21:01:00 -0400 Received: from mail-4022.proton.ch ([185.70.40.22]:29617) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1orU1w-0008Cw-9v for 58940@debbugs.gnu.org; Sat, 05 Nov 2022 21:00:59 -0400 Date: Sun, 06 Nov 2022 01:00:38 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rjt.dev; s=protonmail2; t=1667696449; x=1667955649; bh=MNU68qbO4T32uSNk0HAAjinliQboHtMoY5MGKQbQ8Do=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector; b=XYOLwplJewNl/5uM1dbzgT459XyBUx4FU2rU3zt7PpNBhdEEOl64FNt1mA205nUzL BC9H2fU8G1vD9fjoSHVrghHsGN0NrIh9frol7GdXOuLEu2xbjyFkn4P8przX5kBegY 1Wf5k8M041O+zLzFGkMr5s1TJ0+ugZRwsts37H2Q2b1rRu6tqbhquX1S90dCJXolvv vZuDwW+fMoSwsLC1/bKQ1tZq4cH2W0G4QnptVoMZ9uIGsP9bAtMucDnabWkL//wRrW DbqoQtQKZMzfzr7PgmSxMGiq8kp5fKcpjW6x/nzODxfwahYCbPBHvuH8xNszGGQp6b cAa5dotA4daew== To: Eli Zaretskii From: Randy Taylor Subject: Re: bug#58940: [PATCH] feature/tree-sitter: Add more font lock faces Message-ID: In-Reply-To: <83cza14uuq.fsf@gnu.org> References: <835yfxbkyy.fsf@gnu.org> <8ZKenedKBW2xqbSe_c0vWmeRbMQYCDlwFNvSMAYx9utQYeOKPHQQ-nKW9Y8nCcKRnFMmsnfonvA_0yixtSArBzVY_PkaNxxGWqhXoHjCZTo=@rjt.dev> <83cza14uuq.fsf@gnu.org> Feedback-ID: 44397038:user:proton MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="b1_NY2J7e7waH9ZepdByv6FABdfbRLyWaH3YtHGPGtcA" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 58940 Cc: casouri@gmail.com, 58940@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) This is a multi-part message in MIME format. --b1_NY2J7e7waH9ZepdByv6FABdfbRLyWaH3YtHGPGtcA Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On Saturday, November 5th, 2022 at 05:24, Eli Zaretskii wrot= e: > I suggest an example of an escape sequence here, ideally from 2 or > more programming languages. Example added, but not sure about a second programming language. Isn't it b= asically the same for most programming languages? > It is better to have the parent face font-lock-punctuation-face > defined before it is used. Done. BTW I see that font-lock-regexp-grouping-{backslash,construct} do not have related variables like the rest of the faces. Why is that? --b1_NY2J7e7waH9ZepdByv6FABdfbRLyWaH3YtHGPGtcA Content-Type: text/x-patch; name=0001-Add-more-font-lock-faces-Bug-58940.patch Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename=0001-Add-more-font-lock-faces-Bug-58940.patch RnJvbSBhNDhiNDk0MTM4OTFlOWUyYmUzODllZDY5OTJhNDVkMjA0MDkzY2FkIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBSYW5keSBUYXlsb3IgPGRldkByanQuZGV2PgpEYXRlOiBGcmks IDI4IE9jdCAyMDIyIDIyOjM5OjUwIC0wNDAwClN1YmplY3Q6IFtQQVRDSF0gQWRkIG1vcmUgZm9u dC1sb2NrIGZhY2VzIChCdWcjNTg5NDApCgoqIGxpc3AvZm9udC1sb2NrLmVsIChmb250LWxvY2st YnJhY2tldC1mYWNlLCBmb250LWxvY2stZGVsaW1pdGVyLWZhY2UsCmZvbnQtbG9jay1lc2NhcGUt ZmFjZSwgZm9udC1sb2NrLW51bWJlci1mYWNlLApmb250LWxvY2stbWlzYy1wdW5jdHVhdGlvbi1m YWNlLCBmb250LWxvY2stb3BlcmF0b3ItZmFjZSwKZm9udC1sb2NrLXByb3BlcnR5LWZhY2UsIGZv bnQtbG9jay1wdW5jdHVhdGlvbi1mYWNlKTogRGVmaW5lIG5ldwpmYWNlcy4KKiBsaXNwL2N1cy10 aGVtZS5lbCAoY3VzdG9tLXRoZW1lLS1saXN0ZWQtZmFjZXMpOiBBZGQgdGhlbSB0byB0aGUKbGlz dC4KKiBkb2MvbGlzcHJlZi9tb2Rlcy50ZXhpIChGYWNlcyBmb3IgRm9udCBMb2NrKTogRG9jdW1l bnQgdGhlbS4KKiBldGMvTkVXUzogTWVudGlvbiB0aGVtLgotLS0KIGRvYy9saXNwcmVmL21vZGVz LnRleGkgfCA2NSArKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrCiBldGMvTkVX UyAgICAgICAgICAgICAgIHwgIDggKysrKysKIGxpc3AvY3VzLXRoZW1lLmVsICAgICAgfCAxNiAr KysrKy0tLS0KIGxpc3AvZm9udC1sb2NrLmVsICAgICAgfCA3MyArKysrKysrKysrKysrKysrKysr KysrKysrKysrKysrKysrKysrKysrKysKIDQgZmlsZXMgY2hhbmdlZCwgMTU2IGluc2VydGlvbnMo KyksIDYgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvZG9jL2xpc3ByZWYvbW9kZXMudGV4aSBi L2RvYy9saXNwcmVmL21vZGVzLnRleGkKaW5kZXggYzFiMDkyMjQ3Yi4uM2YzZTcwMzdjZiAxMDA2 NDQKLS0tIGEvZG9jL2xpc3ByZWYvbW9kZXMudGV4aQorKysgYi9kb2MvbGlzcHJlZi9tb2Rlcy50 ZXhpCkBAIC0zNjUzLDYgKzM2NTMsNzEgQEAgRmFjZXMgZm9yIEZvbnQgTG9jawogQGl0ZW0gZm9u dC1sb2NrLW5lZ2F0aW9uLWNoYXItZmFjZQogQHZpbmRleCBmb250LWxvY2stbmVnYXRpb24tY2hh ci1mYWNlCiBmb3IgZWFzaWx5LW92ZXJsb29rZWQgbmVnYXRpb24gY2hhcmFjdGVycy4KKworQGl0 ZW0gZm9udC1sb2NrLWVzY2FwZS1mYWNlCitAdmluZGV4IGZvbnQtbG9jay1lc2NhcGUtZmFjZQor Zm9yIGVzY2FwZSBzZXF1ZW5jZXMgaW4gc3RyaW5ncy4KK1RoaXMgZmFjZSBpbmhlcml0cywgYnkg ZGVmYXVsdCwgZnJvbSBAY29kZXtmb250LWxvY2stcmVnZXhwLWdyb3VwaW5nLWJhY2tzbGFzaH0u CisKK0hlcmUgaXMgYW4gZXhhbXBsZSBpbiBQeXRob24sIHdoZXJlIHRoZSBlc2NhcGUgc2VxdWVu Y2UgQGNvZGV7XG59IGlzIHVzZWQ6CisKK0BzbWFsbGV4YW1wbGUKK0Bncm91cAorcHJpbnQoJ0hl bGxvIHdvcmxkIVxuJykKK0BlbmQgZ3JvdXAKK0BlbmQgc21hbGxleGFtcGxlCisKK0BpdGVtIGZv bnQtbG9jay1udW1iZXItZmFjZQorQHZpbmRleCBmb250LWxvY2stbnVtYmVyLWZhY2UKK2ZvciBu dW1iZXJzLgorCitAaXRlbSBmb250LWxvY2stb3BlcmF0b3ItZmFjZQorQHZpbmRleCBmb250LWxv Y2stb3BlcmF0b3ItZmFjZQorZm9yIG9wZXJhdG9ycy4KKworQGl0ZW0gZm9udC1sb2NrLXByb3Bl cnR5LWZhY2UKK0B2aW5kZXggZm9udC1sb2NrLXByb3BlcnR5LWZhY2UKK2ZvciBwcm9wZXJ0aWVz IG9mIGFuIG9iamVjdCwgc3VjaCBhcyB0aGUgZGVjbGFyYXRpb24gYW5kIHVzZSBvZiBmaWVsZHMK K2luIGEgc3RydWN0LgorVGhpcyBmYWNlIGluaGVyaXRzLCBieSBkZWZhdWx0LCBmcm9tIEBjb2Rl e2ZvbnQtbG9jay12YXJpYWJsZS1uYW1lLWZhY2V9LgorCitGb3IgZXhhbXBsZSwKKworQHNtYWxs ZXhhbXBsZQorQGdyb3VwCit0eXBlZGVmIHN0cnVjdAorQHsKKyAgaW50IHByb3A7CisvLyAgICBe IHByb3BlcnR5CitAfSBvYmo7CisKK2ludCBtYWluKCkKK0B7CisgIG9iaiBvOworICBvLnByb3Ag PSAzOworLy8gIF4gcHJvcGVydHkKK0B9CitAZW5kIGdyb3VwCitAZW5kIHNtYWxsZXhhbXBsZQor CitAaXRlbSBmb250LWxvY2stcHVuY3R1YXRpb24tZmFjZQorQHZpbmRleCBmb250LWxvY2stcHVu Y3R1YXRpb24tZmFjZQorZm9yIHB1bmN0dWF0aW9uIHN1Y2ggYXMgYnJhY2tldHMgYW5kIGRlbGlt aXRlcnMuCisKK0BpdGVtIGZvbnQtbG9jay1icmFja2V0LWZhY2UKK0B2aW5kZXggZm9udC1sb2Nr LWJyYWNrZXQtZmFjZQorZm9yIGJyYWNrZXRzIChlLmcuLCBAY29kZXsoKX0sIEBjb2Rle1tdfSwg QGNvZGV7QHtAfX0pLgorVGhpcyBmYWNlIGluaGVyaXRzLCBieSBkZWZhdWx0LCBmcm9tIEBjb2Rl e2ZvbnQtbG9jay1wdW5jdHVhdGlvbi1mYWNlfS4KKworQGl0ZW0gZm9udC1sb2NrLWRlbGltaXRl ci1mYWNlCitAdmluZGV4IGZvbnQtbG9jay1kZWxpbWl0ZXItZmFjZQorZm9yIGRlbGltaXRlcnMg KGUuZy4sIEBjb2Rlezt9LCBAY29kZXs6fSwgQGNvZGV7LH0pLgorVGhpcyBmYWNlIGluaGVyaXRz LCBieSBkZWZhdWx0LCBmcm9tIEBjb2Rle2ZvbnQtbG9jay1wdW5jdHVhdGlvbi1mYWNlfS4KKwor QGl0ZW0gZm9udC1sb2NrLW1pc2MtcHVuY3R1YXRpb24tZmFjZQorQHZpbmRleCBmb250LWxvY2st bWlzYy1wdW5jdHVhdGlvbi1mYWNlCitmb3IgcHVuY3R1YXRpb24gdGhhdCBpcyBub3QgYSBicmFj a2V0IG9yIGRlbGltaXRlci4KK1RoaXMgZmFjZSBpbmhlcml0cywgYnkgZGVmYXVsdCwgZnJvbSBA Y29kZXtmb250LWxvY2stcHVuY3R1YXRpb24tZmFjZX0uCiBAZW5kIHRhYmxlCiAKIEBub2RlIFN5 bnRhY3RpYyBGb250IExvY2sKZGlmZiAtLWdpdCBhL2V0Yy9ORVdTIGIvZXRjL05FV1MKaW5kZXgg YzVhMTQyYjUwMC4uNzRmMTk0ODU2OSAxMDA2NDQKLS0tIGEvZXRjL05FV1MKKysrIGIvZXRjL05F V1MKQEAgLTczMiw2ICs3MzIsMTQgQEAgSWYgdGhlIGN1cnJlbnQgYnVmZmVyIGlzIHZpc2l0aW5n IGEgZmlsZSB0aGF0IGlzIGV4ZWN1dGFibGUsIHRoZQogVGhpcyBkZXRlcm1pbmVzIGhvdyBsb25n IHRvIHBhdXNlIEVtYWNzIGFmdGVyIGEgcHJvY2VzcwogZmlsdGVyL3NlbnRpbmVsIGVycm9yIGhh cyBiZWVuIGhhbmRsZWQuCiAKKysrKworKiogTmV3IGZhY2VzIGZvciBmb250LWxvY2suCitUaGVz ZSBmYWNlcyBhcmUgcHJpbWFyaWx5IG1lYW50IGZvciB1c2Ugd2l0aCB0cmVlLXNpdHRlci4gVGhl eSBhcmU6CisnZm9udC1sb2NrLWJyYWNrZXQtZmFjZScsICdmb250LWxvY2stZGVsaW1pdGVyLWZh Y2UnLAorJ2ZvbnQtbG9jay1lc2NhcGUtZmFjZScsICdmb250LWxvY2stbnVtYmVyLWZhY2UnLAor J2ZvbnQtbG9jay1taXNjLXB1bmN0dWF0aW9uLWZhY2UnLCAnZm9udC1sb2NrLW9wZXJhdG9yLWZh Y2UnLAorJ2ZvbnQtbG9jay1wcm9wZXJ0eS1mYWNlJywgJ2ZvbnQtbG9jay1wdW5jdHVhdGlvbi1m YWNlJy4KKwogKysrCiAqKiBOZXcgZmFjZSAndmFyaWFibGUtcGl0Y2gtdGV4dCcuCiBUaGlzIGZh Y2UgaXMgbGlrZSAndmFyaWFibGUtcGl0Y2gnIChmcm9tIHdoaWNoIGl0IGluaGVyaXRzKSwgYnV0 IGlzCmRpZmYgLS1naXQgYS9saXNwL2N1cy10aGVtZS5lbCBiL2xpc3AvY3VzLXRoZW1lLmVsCmlu ZGV4IDkwNjgwZmY2OGYuLjFkZjJhYjhkYjcgMTAwNjQ0Ci0tLSBhL2xpc3AvY3VzLXRoZW1lLmVs CisrKyBiL2xpc3AvY3VzLXRoZW1lLmVsCkBAIC02NiwxMyArNjYsMTcgQEAgY3VzdG9tLXRoZW1l LS1saXN0ZWQtZmFjZXMKICAgdmFyaWFibGUtcGl0Y2ggZXNjYXBlLWdseXBoIGhvbW9nbHlwaAog ICBtaW5pYnVmZmVyLXByb21wdCBoaWdobGlnaHQgcmVnaW9uCiAgIHNoYWRvdyBzZWNvbmRhcnkt c2VsZWN0aW9uIHRyYWlsaW5nLXdoaXRlc3BhY2UKLSAgZm9udC1sb2NrLWJ1aWx0aW4tZmFjZSBm b250LWxvY2stY29tbWVudC1kZWxpbWl0ZXItZmFjZQotICBmb250LWxvY2stY29tbWVudC1mYWNl IGZvbnQtbG9jay1jb25zdGFudC1mYWNlCi0gIGZvbnQtbG9jay1kb2MtZmFjZSBmb250LWxvY2st ZG9jLW1hcmt1cC1mYWNlIGZvbnQtbG9jay1mdW5jdGlvbi1uYW1lLWZhY2UKKyAgZm9udC1sb2Nr LWJyYWNrZXQtZmFjZSBmb250LWxvY2stYnVpbHRpbi1mYWNlCisgIGZvbnQtbG9jay1jb21tZW50 LWRlbGltaXRlci1mYWNlIGZvbnQtbG9jay1jb21tZW50LWZhY2UKKyAgZm9udC1sb2NrLWNvbnN0 YW50LWZhY2UgZm9udC1sb2NrLWRlbGltaXRlci1mYWNlCisgIGZvbnQtbG9jay1kb2MtZmFjZSBm b250LWxvY2stZG9jLW1hcmt1cC1mYWNlCisgIGZvbnQtbG9jay1lc2NhcGUtZmFjZSBmb250LWxv Y2stZnVuY3Rpb24tbmFtZS1mYWNlCiAgIGZvbnQtbG9jay1rZXl3b3JkLWZhY2UgZm9udC1sb2Nr LW5lZ2F0aW9uLWNoYXItZmFjZQotICBmb250LWxvY2stcHJlcHJvY2Vzc29yLWZhY2UgZm9udC1s b2NrLXJlZ2V4cC1ncm91cGluZy1iYWNrc2xhc2gKLSAgZm9udC1sb2NrLXJlZ2V4cC1ncm91cGlu Zy1jb25zdHJ1Y3QgZm9udC1sb2NrLXN0cmluZy1mYWNlCi0gIGZvbnQtbG9jay10eXBlLWZhY2Ug Zm9udC1sb2NrLXZhcmlhYmxlLW5hbWUtZmFjZQorICBmb250LWxvY2stbnVtYmVyLWZhY2UgZm9u dC1sb2NrLW1pc2MtcHVuY3R1YXRpb24tZmFjZQorICBmb250LWxvY2stb3BlcmF0b3ItZmFjZSBm b250LWxvY2stcHJlcHJvY2Vzc29yLWZhY2UKKyAgZm9udC1sb2NrLXByb3BlcnR5LWZhY2UgZm9u dC1sb2NrLXB1bmN0dWF0aW9uLWZhY2UKKyAgZm9udC1sb2NrLXJlZ2V4cC1ncm91cGluZy1iYWNr c2xhc2ggZm9udC1sb2NrLXJlZ2V4cC1ncm91cGluZy1jb25zdHJ1Y3QKKyAgZm9udC1sb2NrLXN0 cmluZy1mYWNlIGZvbnQtbG9jay10eXBlLWZhY2UgZm9udC1sb2NrLXZhcmlhYmxlLW5hbWUtZmFj ZQogICBmb250LWxvY2std2FybmluZy1mYWNlIGJ1dHRvbiBsaW5rIGxpbmstdmlzaXRlZCBmcmlu Z2UKICAgaGVhZGVyLWxpbmUgdG9vbHRpcCBtb2RlLWxpbmUgbW9kZS1saW5lLWJ1ZmZlci1pZAog ICBtb2RlLWxpbmUtZW1waGFzaXMgbW9kZS1saW5lLWhpZ2hsaWdodCBtb2RlLWxpbmUtaW5hY3Rp dmUKZGlmZiAtLWdpdCBhL2xpc3AvZm9udC1sb2NrLmVsIGIvbGlzcC9mb250LWxvY2suZWwKaW5k ZXggZTg4ZGMxZDNiNy4uNmUyODRkZDNlNSAxMDA2NDQKLS0tIGEvbGlzcC9mb250LWxvY2suZWwK KysrIGIvbGlzcC9mb250LWxvY2suZWwKQEAgLTM1OSw2ICszNTksMzAgQEAgZm9udC1sb2NrLW5l Z2F0aW9uLWNoYXItZmFjZQogKGRlZnZhciBmb250LWxvY2stcHJlcHJvY2Vzc29yLWZhY2UJJ2Zv bnQtbG9jay1wcmVwcm9jZXNzb3ItZmFjZQogICAiRmFjZSBuYW1lIHRvIHVzZSBmb3IgcHJlcHJv Y2Vzc29yIGRpcmVjdGl2ZXMuIikKIAorKGRlZnZhciBmb250LWxvY2stZXNjYXBlLWZhY2UJCSdm b250LWxvY2stZXNjYXBlLWZhY2UKKyAgIkZhY2UgbmFtZSB0byB1c2UgZm9yIGVzY2FwZSBzZXF1 ZW5jZXMgaW4gc3RyaW5ncy4iKQorCisoZGVmdmFyIGZvbnQtbG9jay1udW1iZXItZmFjZQkJJ2Zv bnQtbG9jay1udW1iZXItZmFjZQorICAiRmFjZSBuYW1lIHRvIHVzZSBmb3IgbnVtYmVycy4iKQor CisoZGVmdmFyIGZvbnQtbG9jay1vcGVyYXRvci1mYWNlCSdmb250LWxvY2stb3BlcmF0b3ItZmFj ZQorICAiRmFjZSBuYW1lIHRvIHVzZSBmb3Igb3BlcmF0b3JzLiIpCisKKyhkZWZ2YXIgZm9udC1s b2NrLXByb3BlcnR5LWZhY2UJJ2ZvbnQtbG9jay1wcm9wZXJ0eS1mYWNlCisgICJGYWNlIG5hbWUg dG8gdXNlIGZvciBwcm9wZXJ0aWVzLiIpCisKKyhkZWZ2YXIgZm9udC1sb2NrLXB1bmN0dWF0aW9u LWZhY2UJJ2ZvbnQtbG9jay1wdW5jdHVhdGlvbi1mYWNlCisgICJGYWNlIG5hbWUgdG8gdXNlIGZv ciBwdW5jdHVhdGlvbi4iKQorCisoZGVmdmFyIGZvbnQtbG9jay1icmFja2V0LWZhY2UJCSdmb250 LWxvY2stYnJhY2tldC1mYWNlCisgICJGYWNlIG5hbWUgdG8gdXNlIGZvciBicmFja2V0cy4iKQor CisoZGVmdmFyIGZvbnQtbG9jay1kZWxpbWl0ZXItZmFjZQknZm9udC1sb2NrLWRlbGltaXRlci1m YWNlCisgICJGYWNlIG5hbWUgdG8gdXNlIGZvciBkZWxpbWl0ZXJzLiIpCisKKyhkZWZ2YXIgZm9u dC1sb2NrLW1pc2MtcHVuY3R1YXRpb24tZmFjZSAnZm9udC1sb2NrLW1pc2MtcHVuY3R1YXRpb24t ZmFjZQorICAiRmFjZSBuYW1lIHRvIHVzZSBmb3IgbWlzY2VsbGFuZW91cyBwdW5jdHVhdGlvbi4i KQorCiA7OyBGb250aWZpY2F0aW9uIHZhcmlhYmxlczoKIAogKGRlZnZhciBmb250LWxvY2sta2V5 d29yZHMgbmlsCkBAIC0yMDk1LDYgKzIxMTksNTUgQEAgZm9udC1sb2NrLXJlZ2V4cC1ncm91cGlu Zy1jb25zdHJ1Y3QKICAgIkZvbnQgTG9jayBtb2RlIGZhY2UgdXNlZCB0byBoaWdobGlnaHQgZ3Jv dXBpbmcgY29uc3RydWN0cyBpbiBMaXNwIHJlZ2V4cHMuIgogICA6Z3JvdXAgJ2ZvbnQtbG9jay1m YWNlcykKIAorKGRlZmZhY2UgZm9udC1sb2NrLWVzY2FwZS1mYWNlCisgICcoKHQgOmluaGVyaXQg Zm9udC1sb2NrLXJlZ2V4cC1ncm91cGluZy1iYWNrc2xhc2gpKQorICAiRm9udCBMb2NrIG1vZGUg ZmFjZSB1c2VkIHRvIGhpZ2hsaWdodCBlc2NhcGUgc2VxdWVuY2VzIGluIHN0cmluZ3MuIgorICA6 Z3JvdXAgJ2ZvbnQtbG9jay1mYWNlcworICA6dmVyc2lvbiAiMjkuMSIpCisKKyhkZWZmYWNlIGZv bnQtbG9jay1udW1iZXItZmFjZQorICAnKCh0IG5pbCkpCisgICJGb250IExvY2sgbW9kZSBmYWNl IHVzZWQgdG8gaGlnaGxpZ2h0IG51bWJlcnMuIgorICA6Z3JvdXAgJ2ZvbnQtbG9jay1mYWNlcwor ICA6dmVyc2lvbiAiMjkuMSIpCisKKyhkZWZmYWNlIGZvbnQtbG9jay1vcGVyYXRvci1mYWNlCisg ICcoKHQgbmlsKSkKKyAgIkZvbnQgTG9jayBtb2RlIGZhY2UgdXNlZCB0byBoaWdobGlnaHQgb3Bl cmF0b3JzLiIKKyAgOmdyb3VwICdmb250LWxvY2stZmFjZXMKKyAgOnZlcnNpb24gIjI5LjEiKQor CisoZGVmZmFjZSBmb250LWxvY2stcHJvcGVydHktZmFjZQorICAnKCh0IDppbmhlcml0IGZvbnQt bG9jay12YXJpYWJsZS1uYW1lLWZhY2UpKQorICAiRm9udCBMb2NrIG1vZGUgZmFjZSB1c2VkIHRv IGhpZ2hsaWdodCBwcm9wZXJ0aWVzIG9mIGFuIG9iamVjdCwgc3VjaAorYXMgdGhlIGRlY2xhcmF0 aW9uIGFuZCB1c2Ugb2YgZmllbGRzIGluIGEgc3RydWN0LiIKKyAgOmdyb3VwICdmb250LWxvY2st ZmFjZXMKKyAgOnZlcnNpb24gIjI5LjEiKQorCisoZGVmZmFjZSBmb250LWxvY2stcHVuY3R1YXRp b24tZmFjZQorICAnKCh0IG5pbCkpCisgICJGb250IExvY2sgbW9kZSBmYWNlIHVzZWQgdG8gaGln aGxpZ2h0IHB1bmN0dWF0aW9uLiIKKyAgOmdyb3VwICdmb250LWxvY2stZmFjZXMKKyAgOnZlcnNp b24gIjI5LjEiKQorCisoZGVmZmFjZSBmb250LWxvY2stYnJhY2tldC1mYWNlCisgICcoKHQgOmlu aGVyaXQgZm9udC1sb2NrLXB1bmN0dWF0aW9uLWZhY2UpKQorICAiRm9udCBMb2NrIG1vZGUgZmFj ZSB1c2VkIHRvIGhpZ2hsaWdodCBicmFja2V0cy4iCisgIDpncm91cCAnZm9udC1sb2NrLWZhY2Vz CisgIDp2ZXJzaW9uICIyOS4xIikKKworKGRlZmZhY2UgZm9udC1sb2NrLWRlbGltaXRlci1mYWNl CisgICcoKHQgOmluaGVyaXQgZm9udC1sb2NrLXB1bmN0dWF0aW9uLWZhY2UpKQorICAiRm9udCBM b2NrIG1vZGUgZmFjZSB1c2VkIHRvIGhpZ2hsaWdodCBkZWxpbWl0ZXJzLiIKKyAgOmdyb3VwICdm b250LWxvY2stZmFjZXMKKyAgOnZlcnNpb24gIjI5LjEiKQorCisoZGVmZmFjZSBmb250LWxvY2st bWlzYy1wdW5jdHVhdGlvbi1mYWNlCisgICcoKHQgOmluaGVyaXQgZm9udC1sb2NrLXB1bmN0dWF0 aW9uLWZhY2UpKQorICAiRm9udCBMb2NrIG1vZGUgZmFjZSB1c2VkIHRvIGhpZ2hsaWdodCBtaXNj ZWxsYW5lb3VzIHB1bmN0dWF0aW9uLiIKKyAgOmdyb3VwICdmb250LWxvY2stZmFjZXMKKyAgOnZl cnNpb24gIjI5LjEiKQorCiA7OyBFbmQgb2YgQ29sb3IgZXRjLiBzdXBwb3J0LgogDAogOzs7IE1l bnUgc3VwcG9ydC4KLS0gCjIuMzguMQoK --b1_NY2J7e7waH9ZepdByv6FABdfbRLyWaH3YtHGPGtcA-- From debbugs-submit-bounces@debbugs.gnu.org Sun Nov 06 01:15:25 2022 Received: (at 58940) by debbugs.gnu.org; 6 Nov 2022 06:15:25 +0000 Received: from localhost ([127.0.0.1]:58557 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1orYwG-0007iJ-L4 for submit@debbugs.gnu.org; Sun, 06 Nov 2022 01:15:24 -0500 Received: from eggs.gnu.org ([209.51.188.92]:33772) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1orYwF-0007i7-3t for 58940@debbugs.gnu.org; Sun, 06 Nov 2022 01:15:23 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1orYw9-0007Bh-Fk; Sun, 06 Nov 2022 01:15:17 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=Ti33YeHHX4OqLZeJCmEzrL3TftsF1vde8mJ02fwtIOA=; b=lj5a3IPRxv03 iyPPBo9g0ls1BGLYUatr5YhDKsNihQpQ0C+Y1Nb7L2QsNT72NQwPH3KJvT0vO5x7G59E0M+maCbXh 3OgXgvF1mTZeSnXpdKBaqpX4QU9UEHqnxhNHtKZaOrBVzyMjkYT0SFThbwWu/IQ1DIXMQr6l+CtrR 3HTcE7YQ5VpVeloon3Nb3uwd/R6X7PHaHjc1aYJumnjO0zJn5ocUIru8RurGwR3c/47uGGzDMDXhF 6Ep4vXATZ3QGe7ryvuOVJSfy7JuyUYzoaKRKkmSuO8zdtGSD9Jwuzsknjdz8+BWAhHGcUok5oSOyy FjfmwMQB4FQHJOHemiH64w==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1orYw6-0004mk-Gj; Sun, 06 Nov 2022 01:15:17 -0500 Date: Sun, 06 Nov 2022 08:14:56 +0200 Message-Id: <83cza038yn.fsf@gnu.org> From: Eli Zaretskii To: Randy Taylor , Stefan Monnier In-Reply-To: (message from Randy Taylor on Sun, 06 Nov 2022 01:00:38 +0000) Subject: Re: bug#58940: [PATCH] feature/tree-sitter: Add more font lock faces References: <835yfxbkyy.fsf@gnu.org> <8ZKenedKBW2xqbSe_c0vWmeRbMQYCDlwFNvSMAYx9utQYeOKPHQQ-nKW9Y8nCcKRnFMmsnfonvA_0yixtSArBzVY_PkaNxxGWqhXoHjCZTo=@rjt.dev> <83cza14uuq.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 58940 Cc: casouri@gmail.com, 58940@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Sun, 06 Nov 2022 01:00:38 +0000 > From: Randy Taylor > Cc: casouri@gmail.com, 58940@debbugs.gnu.org > > BTW I see that font-lock-regexp-grouping-{backslash,construct} > do not have related variables like the rest of the faces. Why is that? No idea. I didn't even know we had those faces until I've read your patch. Stefan, any idea why those faces don't have variables? From debbugs-submit-bounces@debbugs.gnu.org Sun Nov 06 03:23:18 2022 Received: (at 58940) by debbugs.gnu.org; 6 Nov 2022 08:23:18 +0000 Received: from localhost ([127.0.0.1]:58631 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oraw1-0002NZ-Nj for submit@debbugs.gnu.org; Sun, 06 Nov 2022 03:23:18 -0500 Received: from eggs.gnu.org ([209.51.188.92]:54004) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oraw0-0002NM-Kn for 58940@debbugs.gnu.org; Sun, 06 Nov 2022 03:23:17 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oravn-00072Z-V0; Sun, 06 Nov 2022 03:23:10 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=7btKf2Q6eeV7HtZrGhxsztPBCL0EQf1yMrbr2H52pK4=; b=LZ7/rHPyuz3D sYh4Qp8OMljllauVVHVDrFQYa0wsAHiMPRJiSyqAdRAd2BXpjWUc+8xTYJl/+qHxCnlBNq2KEAKGK Jri8JaxInupFe3VwLBUiffm1lRWY0wNB2cMwOc0I/wbQiLZkaZArPgQdlkzvJzFC7Vr69Ha+pOUqg FjszdU2oEomIwO8HYbIym+KmhHV1bw13qd2uWmd7RFb/B57dmPs4jFLeHUBHCraBLPgY0x2QzIRUN CaumDV5JucT+zPssp4EvJPRKay+Oyy1XM2Zawz5M1h38OokPaOikrHELI0ecE3iGtaDkYgrOGz/+D S2wdDoyG9SSKoN4mzyXkeA==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oravm-0002h3-Uf; Sun, 06 Nov 2022 03:23:03 -0500 Date: Sun, 06 Nov 2022 10:22:45 +0200 Message-Id: <83v8ns1oh6.fsf@gnu.org> From: Eli Zaretskii To: Randy Taylor In-Reply-To: (message from Randy Taylor on Sun, 06 Nov 2022 01:00:38 +0000) Subject: Re: bug#58940: [PATCH] feature/tree-sitter: Add more font lock faces References: <835yfxbkyy.fsf@gnu.org> <8ZKenedKBW2xqbSe_c0vWmeRbMQYCDlwFNvSMAYx9utQYeOKPHQQ-nKW9Y8nCcKRnFMmsnfonvA_0yixtSArBzVY_PkaNxxGWqhXoHjCZTo=@rjt.dev> <83cza14uuq.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 58940 Cc: casouri@gmail.com, 58940@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Sun, 06 Nov 2022 01:00:38 +0000 > From: Randy Taylor > Cc: casouri@gmail.com, 58940@debbugs.gnu.org > > On Saturday, November 5th, 2022 at 05:24, Eli Zaretskii wrote: > > > I suggest an example of an escape sequence here, ideally from 2 or > > more programming languages. > > Example added, but not sure about a second programming language. Isn't it basically the same for most programming languages? Maybe one example is enough, thanks. > +(defface font-lock-property-face > + '((t :inherit font-lock-variable-name-face)) > + "Font Lock mode face used to highlight properties of an object, such > +as the declaration and use of fields in a struct." The first line of a doc string should be a single complete sentence. I suggest to have the detailed description be separate sentences after the first one. Otherwise, LGTM, thanks. From debbugs-submit-bounces@debbugs.gnu.org Sun Nov 06 09:05:12 2022 Received: (at 58940) by debbugs.gnu.org; 6 Nov 2022 14:05:12 +0000 Received: from localhost ([127.0.0.1]:58990 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1orgGu-0007Eq-DJ for submit@debbugs.gnu.org; Sun, 06 Nov 2022 09:05:12 -0500 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:36142) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1orgGt-0007Eb-9C for 58940@debbugs.gnu.org; Sun, 06 Nov 2022 09:05:11 -0500 Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 46222100189; Sun, 6 Nov 2022 09:05:05 -0500 (EST) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 3CA2B1000EF; Sun, 6 Nov 2022 09:05:03 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1667743503; bh=kr6Ypi49Pxmx3L1zzYkgc//o2+q//5gB1eWH8fuuhXM=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=gDqEqAO6auLBKwV5kynOxrF+CeMU9XGKaau/loSgCKpKfuZARktM99fTvQOpvPC4E tukuYSeg4me3VPMLkfZZ2LVVrgAK4dXFLiFzp+AbfQtmV93i8wqouKBNPSuwaCoWbe 1aSJBezj8f37J1rLewrWzlEdPLhxmfuzn7AbbHdVYx60sq+ZIeftM/H6gR2gkCqXFW aiBkfJF9gCDeB82vsduzURCr2bBQBe9eNoRwsyOa/hJKRuPuAubt8L3lVGO7B9Pn5F IypgFiqgRBKO3nfFblKhuNEBL7bXjxhhS/nvlRSlBGuN1tYsXUy15NubnyUNZpqp5t Uz0id7+Y/O4PA== Received: from pastel (unknown [104.247.241.157]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 002611208AC; Sun, 6 Nov 2022 09:05:02 -0500 (EST) From: Stefan Monnier To: Eli Zaretskii Subject: Re: bug#58940: [PATCH] feature/tree-sitter: Add more font lock faces In-Reply-To: <83cza038yn.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 06 Nov 2022 08:14:56 +0200") Message-ID: References: <835yfxbkyy.fsf@gnu.org> <8ZKenedKBW2xqbSe_c0vWmeRbMQYCDlwFNvSMAYx9utQYeOKPHQQ-nKW9Y8nCcKRnFMmsnfonvA_0yixtSArBzVY_PkaNxxGWqhXoHjCZTo=@rjt.dev> <83cza14uuq.fsf@gnu.org> <83cza038yn.fsf@gnu.org> Date: Sun, 06 Nov 2022 09:05:01 -0500 User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL 0.083 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 58940 Cc: Randy Taylor , casouri@gmail.com, 58940@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) >> BTW I see that font-lock-regexp-grouping-{backslash,construct} >> do not have related variables like the rest of the faces. Why is that? > > No idea. I didn't even know we had those faces until I've read your > patch. > > Stefan, any idea why those faces don't have variables? Not really, no. But AFAIK the "variable associated with a face" is an old idiosyncrasy of `font-lock.el` that's never been explained nor justified. It was used at some point for customization purposes (to tweak the face buffer-locally) but we introduced the face-remapping facility as a better replacement for that hack, so faces should not need accompanying vars since Emacs-23. I suspect that's part of the reason. Ideally, we'd phase out those old `font-lock-*-face` variables rather than introduce new ones. I think the only thing they bring nowadays is confusion. Stefan From debbugs-submit-bounces@debbugs.gnu.org Sun Nov 06 11:44:06 2022 Received: (at 58940) by debbugs.gnu.org; 6 Nov 2022 16:44:06 +0000 Received: from localhost ([127.0.0.1]:60500 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1orikf-0001J7-UV for submit@debbugs.gnu.org; Sun, 06 Nov 2022 11:44:06 -0500 Received: from mail-4323.proton.ch ([185.70.43.23]:62067) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1orikc-0001IT-UT for 58940@debbugs.gnu.org; Sun, 06 Nov 2022 11:44:04 -0500 Date: Sun, 06 Nov 2022 16:43:42 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rjt.dev; s=protonmail2; t=1667753036; x=1668012236; bh=m3SPTPV45u/Equp1OcGUxKvyn1UKx1e8Jan3maGIq+g=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector; b=hK9Ifrito2IMUIGjG/O20PUFqgXsdm7e09Xa9diEcL/aQ1YxbXNdLbRorAQZP3REK pNGnleOvWRkmJ5Dz1mSLPNdhwZKGDbzDobvPw4X+0+CvNKhd5+qSvzuIHFJfDDR9YL HTYPwHm+aOo2Mp5gEPCp3xvcZuPSM++hpAIjiIJP32N/c9dD9MzeSDYut9nAvC98Q9 Xy85vlteSuR0iEcBpPwfbTpTiyN2hfvJc0RcBVc1yp4+rK3eKnn/xPcycgnE9I4920 gM93iYOrlxdSUE9sofpDAoseSp09wh1laZehqyEn13jDXXZO4iSG6qne8Wf3zfR8kq YjZhmC0kO/RYw== To: Stefan Monnier From: Randy Taylor Subject: Re: bug#58940: [PATCH] feature/tree-sitter: Add more font lock faces Message-ID: In-Reply-To: References: <835yfxbkyy.fsf@gnu.org> <8ZKenedKBW2xqbSe_c0vWmeRbMQYCDlwFNvSMAYx9utQYeOKPHQQ-nKW9Y8nCcKRnFMmsnfonvA_0yixtSArBzVY_PkaNxxGWqhXoHjCZTo=@rjt.dev> <83cza14uuq.fsf@gnu.org> <83cza038yn.fsf@gnu.org> Feedback-ID: 44397038:user:proton MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 58940 Cc: Eli Zaretskii , casouri@gmail.com, 58940@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Sunday, November 6th, 2022 at 09:05, Stefan Monnier wrote: >=20 > >> BTW I see that font-lock-regexp-grouping-{backslash,construct} >=20 > > > do not have related variables like the rest of the faces. Why is that= ? > >=20 > > No idea. I didn't even know we had those faces until I've read your > > patch. > >=20 > > Stefan, any idea why those faces don't have variables? >=20 >=20 > Not really, no. But AFAIK the "variable associated with a face" is an > old idiosyncrasy of `font-lock.el` that's never been explained > nor justified. It was used at some point for customization purposes (to > tweak the face buffer-locally) but we introduced the face-remapping > facility as a better replacement for that hack, so faces should not need > accompanying vars since Emacs-23. >=20 > I suspect that's part of the reason. Ideally, we'd phase out those old > `font-lock-*-face` variables rather than introduce new ones. > I think the only thing they bring nowadays is confusion. > Thanks, I'll remove them in the next patch. I was following 1bfbb2b706db6a7ca9420b27d22a737deccdd5b0 for inspiration, h= ence why I included them. From debbugs-submit-bounces@debbugs.gnu.org Sun Nov 06 12:02:38 2022 Received: (at 58940) by debbugs.gnu.org; 6 Nov 2022 17:02:38 +0000 Received: from localhost ([127.0.0.1]:60513 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1orj2b-0001nr-FV for submit@debbugs.gnu.org; Sun, 06 Nov 2022 12:02:38 -0500 Received: from mail-4317.proton.ch ([185.70.43.17]:52955) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1orj2X-0001nY-8b for 58940@debbugs.gnu.org; Sun, 06 Nov 2022 12:02:35 -0500 Date: Sun, 06 Nov 2022 17:02:13 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rjt.dev; s=protonmail2; t=1667754145; x=1668013345; bh=/eARvWuiK4jfQbTH6ZIRvO07oimW0nrwkO2q1exjDMM=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector; b=pVglhtCpTjoCnpfHxpdiP+4Vv1j/OsPM7uzB8teYDgNuOFLJeAu85DIwhIXWdMl6W U18e5Gg8K2os/aGnTcG3c5IR3WNEtxXFBq23l0u+6n+ioIgP8DzG+Ou9KsWfLFnZCW D8UPPHhsXsew43ffOcmGs9UDk5qL9Va+iKL6SM7H0+fq/B8SCZzK5k1HXk1p5yuSKf 7s47z9G8jaEgGTF6+j20gqSNBtYr3GatHYezlCTY93uL6OrytznlK4wlihNaEqOuel XO6aMluhEmUwMJNUgFFB5teVdMHsttC1ZwGyZqdlR9hE/nMP6XzB9IOQGNoZI3gOnc cLn+bs4g+ONdw== To: Eli Zaretskii From: Randy Taylor Subject: Re: bug#58940: [PATCH] feature/tree-sitter: Add more font lock faces Message-ID: In-Reply-To: <83v8ns1oh6.fsf@gnu.org> References: <835yfxbkyy.fsf@gnu.org> <8ZKenedKBW2xqbSe_c0vWmeRbMQYCDlwFNvSMAYx9utQYeOKPHQQ-nKW9Y8nCcKRnFMmsnfonvA_0yixtSArBzVY_PkaNxxGWqhXoHjCZTo=@rjt.dev> <83cza14uuq.fsf@gnu.org> <83v8ns1oh6.fsf@gnu.org> Feedback-ID: 44397038:user:proton MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="b1_cEsCEcYHyRXbJheQpKsic68ffmwKCeOdHEHZwWqjAvI" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 58940 Cc: casouri@gmail.com, 58940@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) This is a multi-part message in MIME format. --b1_cEsCEcYHyRXbJheQpKsic68ffmwKCeOdHEHZwWqjAvI Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On Sunday, November 6th, 2022 at 03:22, Eli Zaretskii wrote: >=20 > > +(defface font-lock-property-face > > + '((t :inherit font-lock-variable-name-face)) > > + "Font Lock mode face used to highlight properties of an object, such > > +as the declaration and use of fields in a struct." >=20 >=20 > The first line of a doc string should be a single complete sentence. >=20 > I suggest to have the detailed description be separate sentences > after the first one. >=20 I wonder if that detailed description is really necessary anymore? Before t= he doc string read "...highlight properties". Now it reads "...highlight pr= operties of an object." - perhaps that's enough? Regardless, I separated th= e detailed description out to its own sentence. I also removed the variables. --b1_cEsCEcYHyRXbJheQpKsic68ffmwKCeOdHEHZwWqjAvI Content-Type: text/x-patch; name=0001-Add-more-font-lock-faces-Bug-58940.patch Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename=0001-Add-more-font-lock-faces-Bug-58940.patch RnJvbSBkNjk3YjI4NGNiMTc4NzJiMjBkZWMwMmQ2OTI5YjA0ODA3OTFmN2MxIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBSYW5keSBUYXlsb3IgPGRldkByanQuZGV2PgpEYXRlOiBGcmks IDI4IE9jdCAyMDIyIDIyOjM5OjUwIC0wNDAwClN1YmplY3Q6IFtQQVRDSF0gQWRkIG1vcmUgZm9u dC1sb2NrIGZhY2VzIChCdWcjNTg5NDApCgoqIGxpc3AvZm9udC1sb2NrLmVsIChmb250LWxvY2st YnJhY2tldC1mYWNlLCBmb250LWxvY2stZGVsaW1pdGVyLWZhY2UsCmZvbnQtbG9jay1lc2NhcGUt ZmFjZSwgZm9udC1sb2NrLW51bWJlci1mYWNlLApmb250LWxvY2stbWlzYy1wdW5jdHVhdGlvbi1m YWNlLCBmb250LWxvY2stb3BlcmF0b3ItZmFjZSwKZm9udC1sb2NrLXByb3BlcnR5LWZhY2UsIGZv bnQtbG9jay1wdW5jdHVhdGlvbi1mYWNlKTogRGVmaW5lIG5ldwpmYWNlcy4KKiBsaXNwL2N1cy10 aGVtZS5lbCAoY3VzdG9tLXRoZW1lLS1saXN0ZWQtZmFjZXMpOiBBZGQgdGhlbSB0byB0aGUKbGlz dC4KKiBkb2MvbGlzcHJlZi9tb2Rlcy50ZXhpIChGYWNlcyBmb3IgRm9udCBMb2NrKTogRG9jdW1l bnQgdGhlbS4KKiBldGMvTkVXUzogTWVudGlvbiB0aGVtLgotLS0KIGRvYy9saXNwcmVmL21vZGVz LnRleGkgfCA2NSArKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysKIGV0 Yy9ORVdTICAgICAgICAgICAgICAgfCAgOCArKysrKysKIGxpc3AvY3VzLXRoZW1lLmVsICAgICAg fCAxNiArKysrKysrLS0tLQogbGlzcC9mb250LWxvY2suZWwgICAgICB8IDQ5ICsrKysrKysrKysr KysrKysrKysrKysrKysrKysrKysKIDQgZmlsZXMgY2hhbmdlZCwgMTMyIGluc2VydGlvbnMoKyks IDYgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvZG9jL2xpc3ByZWYvbW9kZXMudGV4aSBiL2Rv Yy9saXNwcmVmL21vZGVzLnRleGkKaW5kZXggYzFiMDkyMjQ3Yi4uM2YzZTcwMzdjZiAxMDA2NDQK LS0tIGEvZG9jL2xpc3ByZWYvbW9kZXMudGV4aQorKysgYi9kb2MvbGlzcHJlZi9tb2Rlcy50ZXhp CkBAIC0zNjUzLDYgKzM2NTMsNzEgQEAgRmFjZXMgZm9yIEZvbnQgTG9jawogQGl0ZW0gZm9udC1s b2NrLW5lZ2F0aW9uLWNoYXItZmFjZQogQHZpbmRleCBmb250LWxvY2stbmVnYXRpb24tY2hhci1m YWNlCiBmb3IgZWFzaWx5LW92ZXJsb29rZWQgbmVnYXRpb24gY2hhcmFjdGVycy4KKworQGl0ZW0g Zm9udC1sb2NrLWVzY2FwZS1mYWNlCitAdmluZGV4IGZvbnQtbG9jay1lc2NhcGUtZmFjZQorZm9y IGVzY2FwZSBzZXF1ZW5jZXMgaW4gc3RyaW5ncy4KK1RoaXMgZmFjZSBpbmhlcml0cywgYnkgZGVm YXVsdCwgZnJvbSBAY29kZXtmb250LWxvY2stcmVnZXhwLWdyb3VwaW5nLWJhY2tzbGFzaH0uCisK K0hlcmUgaXMgYW4gZXhhbXBsZSBpbiBQeXRob24sIHdoZXJlIHRoZSBlc2NhcGUgc2VxdWVuY2Ug QGNvZGV7XG59IGlzIHVzZWQ6CisKK0BzbWFsbGV4YW1wbGUKK0Bncm91cAorcHJpbnQoJ0hlbGxv IHdvcmxkIVxuJykKK0BlbmQgZ3JvdXAKK0BlbmQgc21hbGxleGFtcGxlCisKK0BpdGVtIGZvbnQt bG9jay1udW1iZXItZmFjZQorQHZpbmRleCBmb250LWxvY2stbnVtYmVyLWZhY2UKK2ZvciBudW1i ZXJzLgorCitAaXRlbSBmb250LWxvY2stb3BlcmF0b3ItZmFjZQorQHZpbmRleCBmb250LWxvY2st b3BlcmF0b3ItZmFjZQorZm9yIG9wZXJhdG9ycy4KKworQGl0ZW0gZm9udC1sb2NrLXByb3BlcnR5 LWZhY2UKK0B2aW5kZXggZm9udC1sb2NrLXByb3BlcnR5LWZhY2UKK2ZvciBwcm9wZXJ0aWVzIG9m IGFuIG9iamVjdCwgc3VjaCBhcyB0aGUgZGVjbGFyYXRpb24gYW5kIHVzZSBvZiBmaWVsZHMKK2lu IGEgc3RydWN0LgorVGhpcyBmYWNlIGluaGVyaXRzLCBieSBkZWZhdWx0LCBmcm9tIEBjb2Rle2Zv bnQtbG9jay12YXJpYWJsZS1uYW1lLWZhY2V9LgorCitGb3IgZXhhbXBsZSwKKworQHNtYWxsZXhh bXBsZQorQGdyb3VwCit0eXBlZGVmIHN0cnVjdAorQHsKKyAgaW50IHByb3A7CisvLyAgICBeIHBy b3BlcnR5CitAfSBvYmo7CisKK2ludCBtYWluKCkKK0B7CisgIG9iaiBvOworICBvLnByb3AgPSAz OworLy8gIF4gcHJvcGVydHkKK0B9CitAZW5kIGdyb3VwCitAZW5kIHNtYWxsZXhhbXBsZQorCitA aXRlbSBmb250LWxvY2stcHVuY3R1YXRpb24tZmFjZQorQHZpbmRleCBmb250LWxvY2stcHVuY3R1 YXRpb24tZmFjZQorZm9yIHB1bmN0dWF0aW9uIHN1Y2ggYXMgYnJhY2tldHMgYW5kIGRlbGltaXRl cnMuCisKK0BpdGVtIGZvbnQtbG9jay1icmFja2V0LWZhY2UKK0B2aW5kZXggZm9udC1sb2NrLWJy YWNrZXQtZmFjZQorZm9yIGJyYWNrZXRzIChlLmcuLCBAY29kZXsoKX0sIEBjb2Rle1tdfSwgQGNv ZGV7QHtAfX0pLgorVGhpcyBmYWNlIGluaGVyaXRzLCBieSBkZWZhdWx0LCBmcm9tIEBjb2Rle2Zv bnQtbG9jay1wdW5jdHVhdGlvbi1mYWNlfS4KKworQGl0ZW0gZm9udC1sb2NrLWRlbGltaXRlci1m YWNlCitAdmluZGV4IGZvbnQtbG9jay1kZWxpbWl0ZXItZmFjZQorZm9yIGRlbGltaXRlcnMgKGUu Zy4sIEBjb2Rlezt9LCBAY29kZXs6fSwgQGNvZGV7LH0pLgorVGhpcyBmYWNlIGluaGVyaXRzLCBi eSBkZWZhdWx0LCBmcm9tIEBjb2Rle2ZvbnQtbG9jay1wdW5jdHVhdGlvbi1mYWNlfS4KKworQGl0 ZW0gZm9udC1sb2NrLW1pc2MtcHVuY3R1YXRpb24tZmFjZQorQHZpbmRleCBmb250LWxvY2stbWlz Yy1wdW5jdHVhdGlvbi1mYWNlCitmb3IgcHVuY3R1YXRpb24gdGhhdCBpcyBub3QgYSBicmFja2V0 IG9yIGRlbGltaXRlci4KK1RoaXMgZmFjZSBpbmhlcml0cywgYnkgZGVmYXVsdCwgZnJvbSBAY29k ZXtmb250LWxvY2stcHVuY3R1YXRpb24tZmFjZX0uCiBAZW5kIHRhYmxlCiAKIEBub2RlIFN5bnRh Y3RpYyBGb250IExvY2sKZGlmZiAtLWdpdCBhL2V0Yy9ORVdTIGIvZXRjL05FV1MKaW5kZXggYzVh MTQyYjUwMC4uNzRmMTk0ODU2OSAxMDA2NDQKLS0tIGEvZXRjL05FV1MKKysrIGIvZXRjL05FV1MK QEAgLTczMiw2ICs3MzIsMTQgQEAgSWYgdGhlIGN1cnJlbnQgYnVmZmVyIGlzIHZpc2l0aW5nIGEg ZmlsZSB0aGF0IGlzIGV4ZWN1dGFibGUsIHRoZQogVGhpcyBkZXRlcm1pbmVzIGhvdyBsb25nIHRv IHBhdXNlIEVtYWNzIGFmdGVyIGEgcHJvY2VzcwogZmlsdGVyL3NlbnRpbmVsIGVycm9yIGhhcyBi ZWVuIGhhbmRsZWQuCiAKKysrKworKiogTmV3IGZhY2VzIGZvciBmb250LWxvY2suCitUaGVzZSBm YWNlcyBhcmUgcHJpbWFyaWx5IG1lYW50IGZvciB1c2Ugd2l0aCB0cmVlLXNpdHRlci4gVGhleSBh cmU6CisnZm9udC1sb2NrLWJyYWNrZXQtZmFjZScsICdmb250LWxvY2stZGVsaW1pdGVyLWZhY2Un LAorJ2ZvbnQtbG9jay1lc2NhcGUtZmFjZScsICdmb250LWxvY2stbnVtYmVyLWZhY2UnLAorJ2Zv bnQtbG9jay1taXNjLXB1bmN0dWF0aW9uLWZhY2UnLCAnZm9udC1sb2NrLW9wZXJhdG9yLWZhY2Un LAorJ2ZvbnQtbG9jay1wcm9wZXJ0eS1mYWNlJywgJ2ZvbnQtbG9jay1wdW5jdHVhdGlvbi1mYWNl Jy4KKwogKysrCiAqKiBOZXcgZmFjZSAndmFyaWFibGUtcGl0Y2gtdGV4dCcuCiBUaGlzIGZhY2Ug aXMgbGlrZSAndmFyaWFibGUtcGl0Y2gnIChmcm9tIHdoaWNoIGl0IGluaGVyaXRzKSwgYnV0IGlz CmRpZmYgLS1naXQgYS9saXNwL2N1cy10aGVtZS5lbCBiL2xpc3AvY3VzLXRoZW1lLmVsCmluZGV4 IDkwNjgwZmY2OGYuLjFkZjJhYjhkYjcgMTAwNjQ0Ci0tLSBhL2xpc3AvY3VzLXRoZW1lLmVsCisr KyBiL2xpc3AvY3VzLXRoZW1lLmVsCkBAIC02NiwxMyArNjYsMTcgQEAgY3VzdG9tLXRoZW1lLS1s aXN0ZWQtZmFjZXMKICAgdmFyaWFibGUtcGl0Y2ggZXNjYXBlLWdseXBoIGhvbW9nbHlwaAogICBt aW5pYnVmZmVyLXByb21wdCBoaWdobGlnaHQgcmVnaW9uCiAgIHNoYWRvdyBzZWNvbmRhcnktc2Vs ZWN0aW9uIHRyYWlsaW5nLXdoaXRlc3BhY2UKLSAgZm9udC1sb2NrLWJ1aWx0aW4tZmFjZSBmb250 LWxvY2stY29tbWVudC1kZWxpbWl0ZXItZmFjZQotICBmb250LWxvY2stY29tbWVudC1mYWNlIGZv bnQtbG9jay1jb25zdGFudC1mYWNlCi0gIGZvbnQtbG9jay1kb2MtZmFjZSBmb250LWxvY2stZG9j LW1hcmt1cC1mYWNlIGZvbnQtbG9jay1mdW5jdGlvbi1uYW1lLWZhY2UKKyAgZm9udC1sb2NrLWJy YWNrZXQtZmFjZSBmb250LWxvY2stYnVpbHRpbi1mYWNlCisgIGZvbnQtbG9jay1jb21tZW50LWRl bGltaXRlci1mYWNlIGZvbnQtbG9jay1jb21tZW50LWZhY2UKKyAgZm9udC1sb2NrLWNvbnN0YW50 LWZhY2UgZm9udC1sb2NrLWRlbGltaXRlci1mYWNlCisgIGZvbnQtbG9jay1kb2MtZmFjZSBmb250 LWxvY2stZG9jLW1hcmt1cC1mYWNlCisgIGZvbnQtbG9jay1lc2NhcGUtZmFjZSBmb250LWxvY2st ZnVuY3Rpb24tbmFtZS1mYWNlCiAgIGZvbnQtbG9jay1rZXl3b3JkLWZhY2UgZm9udC1sb2NrLW5l Z2F0aW9uLWNoYXItZmFjZQotICBmb250LWxvY2stcHJlcHJvY2Vzc29yLWZhY2UgZm9udC1sb2Nr LXJlZ2V4cC1ncm91cGluZy1iYWNrc2xhc2gKLSAgZm9udC1sb2NrLXJlZ2V4cC1ncm91cGluZy1j b25zdHJ1Y3QgZm9udC1sb2NrLXN0cmluZy1mYWNlCi0gIGZvbnQtbG9jay10eXBlLWZhY2UgZm9u dC1sb2NrLXZhcmlhYmxlLW5hbWUtZmFjZQorICBmb250LWxvY2stbnVtYmVyLWZhY2UgZm9udC1s b2NrLW1pc2MtcHVuY3R1YXRpb24tZmFjZQorICBmb250LWxvY2stb3BlcmF0b3ItZmFjZSBmb250 LWxvY2stcHJlcHJvY2Vzc29yLWZhY2UKKyAgZm9udC1sb2NrLXByb3BlcnR5LWZhY2UgZm9udC1s b2NrLXB1bmN0dWF0aW9uLWZhY2UKKyAgZm9udC1sb2NrLXJlZ2V4cC1ncm91cGluZy1iYWNrc2xh c2ggZm9udC1sb2NrLXJlZ2V4cC1ncm91cGluZy1jb25zdHJ1Y3QKKyAgZm9udC1sb2NrLXN0cmlu Zy1mYWNlIGZvbnQtbG9jay10eXBlLWZhY2UgZm9udC1sb2NrLXZhcmlhYmxlLW5hbWUtZmFjZQog ICBmb250LWxvY2std2FybmluZy1mYWNlIGJ1dHRvbiBsaW5rIGxpbmstdmlzaXRlZCBmcmluZ2UK ICAgaGVhZGVyLWxpbmUgdG9vbHRpcCBtb2RlLWxpbmUgbW9kZS1saW5lLWJ1ZmZlci1pZAogICBt b2RlLWxpbmUtZW1waGFzaXMgbW9kZS1saW5lLWhpZ2hsaWdodCBtb2RlLWxpbmUtaW5hY3RpdmUK ZGlmZiAtLWdpdCBhL2xpc3AvZm9udC1sb2NrLmVsIGIvbGlzcC9mb250LWxvY2suZWwKaW5kZXgg ZTg4ZGMxZDNiNy4uYmFlYWZlY2YxNiAxMDA2NDQKLS0tIGEvbGlzcC9mb250LWxvY2suZWwKKysr IGIvbGlzcC9mb250LWxvY2suZWwKQEAgLTIwOTUsNiArMjA5NSw1NSBAQCBmb250LWxvY2stcmVn ZXhwLWdyb3VwaW5nLWNvbnN0cnVjdAogICAiRm9udCBMb2NrIG1vZGUgZmFjZSB1c2VkIHRvIGhp Z2hsaWdodCBncm91cGluZyBjb25zdHJ1Y3RzIGluIExpc3AgcmVnZXhwcy4iCiAgIDpncm91cCAn Zm9udC1sb2NrLWZhY2VzKQogCisoZGVmZmFjZSBmb250LWxvY2stZXNjYXBlLWZhY2UKKyAgJygo dCA6aW5oZXJpdCBmb250LWxvY2stcmVnZXhwLWdyb3VwaW5nLWJhY2tzbGFzaCkpCisgICJGb250 IExvY2sgbW9kZSBmYWNlIHVzZWQgdG8gaGlnaGxpZ2h0IGVzY2FwZSBzZXF1ZW5jZXMgaW4gc3Ry aW5ncy4iCisgIDpncm91cCAnZm9udC1sb2NrLWZhY2VzCisgIDp2ZXJzaW9uICIyOS4xIikKKwor KGRlZmZhY2UgZm9udC1sb2NrLW51bWJlci1mYWNlCisgICcoKHQgbmlsKSkKKyAgIkZvbnQgTG9j ayBtb2RlIGZhY2UgdXNlZCB0byBoaWdobGlnaHQgbnVtYmVycy4iCisgIDpncm91cCAnZm9udC1s b2NrLWZhY2VzCisgIDp2ZXJzaW9uICIyOS4xIikKKworKGRlZmZhY2UgZm9udC1sb2NrLW9wZXJh dG9yLWZhY2UKKyAgJygodCBuaWwpKQorICAiRm9udCBMb2NrIG1vZGUgZmFjZSB1c2VkIHRvIGhp Z2hsaWdodCBvcGVyYXRvcnMuIgorICA6Z3JvdXAgJ2ZvbnQtbG9jay1mYWNlcworICA6dmVyc2lv biAiMjkuMSIpCisKKyhkZWZmYWNlIGZvbnQtbG9jay1wcm9wZXJ0eS1mYWNlCisgICcoKHQgOmlu aGVyaXQgZm9udC1sb2NrLXZhcmlhYmxlLW5hbWUtZmFjZSkpCisgICJGb250IExvY2sgbW9kZSBm YWNlIHVzZWQgdG8gaGlnaGxpZ2h0IHByb3BlcnRpZXMgb2YgYW4gb2JqZWN0LgorRm9yIGV4YW1w bGUsIHRoZSBkZWNsYXJhdGlvbiBhbmQgdXNlIG9mIGZpZWxkcyBpbiBhIHN0cnVjdC4iCisgIDpn cm91cCAnZm9udC1sb2NrLWZhY2VzCisgIDp2ZXJzaW9uICIyOS4xIikKKworKGRlZmZhY2UgZm9u dC1sb2NrLXB1bmN0dWF0aW9uLWZhY2UKKyAgJygodCBuaWwpKQorICAiRm9udCBMb2NrIG1vZGUg ZmFjZSB1c2VkIHRvIGhpZ2hsaWdodCBwdW5jdHVhdGlvbi4iCisgIDpncm91cCAnZm9udC1sb2Nr LWZhY2VzCisgIDp2ZXJzaW9uICIyOS4xIikKKworKGRlZmZhY2UgZm9udC1sb2NrLWJyYWNrZXQt ZmFjZQorICAnKCh0IDppbmhlcml0IGZvbnQtbG9jay1wdW5jdHVhdGlvbi1mYWNlKSkKKyAgIkZv bnQgTG9jayBtb2RlIGZhY2UgdXNlZCB0byBoaWdobGlnaHQgYnJhY2tldHMuIgorICA6Z3JvdXAg J2ZvbnQtbG9jay1mYWNlcworICA6dmVyc2lvbiAiMjkuMSIpCisKKyhkZWZmYWNlIGZvbnQtbG9j ay1kZWxpbWl0ZXItZmFjZQorICAnKCh0IDppbmhlcml0IGZvbnQtbG9jay1wdW5jdHVhdGlvbi1m YWNlKSkKKyAgIkZvbnQgTG9jayBtb2RlIGZhY2UgdXNlZCB0byBoaWdobGlnaHQgZGVsaW1pdGVy cy4iCisgIDpncm91cCAnZm9udC1sb2NrLWZhY2VzCisgIDp2ZXJzaW9uICIyOS4xIikKKworKGRl ZmZhY2UgZm9udC1sb2NrLW1pc2MtcHVuY3R1YXRpb24tZmFjZQorICAnKCh0IDppbmhlcml0IGZv bnQtbG9jay1wdW5jdHVhdGlvbi1mYWNlKSkKKyAgIkZvbnQgTG9jayBtb2RlIGZhY2UgdXNlZCB0 byBoaWdobGlnaHQgbWlzY2VsbGFuZW91cyBwdW5jdHVhdGlvbi4iCisgIDpncm91cCAnZm9udC1s b2NrLWZhY2VzCisgIDp2ZXJzaW9uICIyOS4xIikKKwogOzsgRW5kIG9mIENvbG9yIGV0Yy4gc3Vw cG9ydC4KIAwKIDs7OyBNZW51IHN1cHBvcnQuCi0tIAoyLjM4LjEKCg== --b1_cEsCEcYHyRXbJheQpKsic68ffmwKCeOdHEHZwWqjAvI-- From debbugs-submit-bounces@debbugs.gnu.org Sun Nov 06 14:24:31 2022 Received: (at 58940) by debbugs.gnu.org; 6 Nov 2022 19:24:31 +0000 Received: from localhost ([127.0.0.1]:60639 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1orlFv-0007XZ-MO for submit@debbugs.gnu.org; Sun, 06 Nov 2022 14:24:31 -0500 Received: from mail-oi1-f172.google.com ([209.85.167.172]:44962) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1orlFs-0007XK-2U for 58940@debbugs.gnu.org; Sun, 06 Nov 2022 14:24:30 -0500 Received: by mail-oi1-f172.google.com with SMTP id n83so10204139oif.11 for <58940@debbugs.gnu.org>; Sun, 06 Nov 2022 11:24:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=y1MW4Iw9UZrxaOSpEPUbI7Ke//+eA8OrEOiR9TwYR+0=; b=IrhJVyolJ+br1mDx6UDoCf/PhSPRXOfeEfbbb9s0YyxIh9LZZWPn4C/exLc/xCBLV3 uGB9B3cOcR/guKUS1j39V1DakpYgrSmuPrSl7ziZbCv+9jsACQpEDQ6eBeYDVcWG/CZX Lcq2CtjzZ+p/V2HtSFQox+zqDd2tnDqas1lg8Z7ENqRugnCCwoOrY7bHFikYaV/IUkWb L4fXw6igjTtCcqpp1qCv0MTYypv8dNWZgcrcgf18AqIJvW2mIlSpsVJv1K2pptUKml2P SwNSodBG5vMutOi0hHiWtwPQtTUozlDfqIKlSzecRHLShgcH2/S1PFPrVl0NQyxN3zD7 XVtQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=y1MW4Iw9UZrxaOSpEPUbI7Ke//+eA8OrEOiR9TwYR+0=; b=6/uw8UsFTQSqpo+bSIDOLQ3U5zXOjevKu3/KenmQhacEGrZ39IyPPNfUCl0K8nr3Nv FxbvPxER2YnY2h/cbMbYXVwTBSFy4akjnWhhUz0JTq4h24TnlgSNGzz6Clra4KLkTOwe mr1msMO7MjOXgUApvCkAPkiWQaQSHwHiof/mI4f0fX1PoRwYzxOEN2eyIOagplSdtCGp 7BzLcIA7ngKIr9KwViJiPROuyoVLW9JpkvGnPkq4XAKjmXAfftakUZACh6qUUGRFZj3M dl0RPoFnHhxLD9Texf1tUc9JGliAGxIlY5V1dJ6S5xFNMv5+wIQ5qjL5a7XgIAsBak1q Ydbw== X-Gm-Message-State: ACrzQf3ICcVPwZjzNlJIcsNrPbb1/3/TH7B0oKymyPZq7SrySVVNAbc1 y4rv9BHNfhT9SZeDNhEwWNdod+6zN7HBedhOVX8= X-Google-Smtp-Source: AMsMyM46oQkCqSPGl6oQsVMJov1SQb3j0S8kMytd/Y3MfpW/BIPNQ87WGMNfJTqkO1BCgT3ubG8J4grerNRI0civ3to= X-Received: by 2002:a05:6808:1186:b0:353:b77a:a481 with SMTP id j6-20020a056808118600b00353b77aa481mr33874865oil.199.1667762662452; Sun, 06 Nov 2022 11:24:22 -0800 (PST) MIME-Version: 1.0 References: <835yfxbkyy.fsf@gnu.org> <8ZKenedKBW2xqbSe_c0vWmeRbMQYCDlwFNvSMAYx9utQYeOKPHQQ-nKW9Y8nCcKRnFMmsnfonvA_0yixtSArBzVY_PkaNxxGWqhXoHjCZTo=@rjt.dev> <83cza14uuq.fsf@gnu.org> <83cza038yn.fsf@gnu.org> In-Reply-To: From: Stefan Kangas Date: Sun, 6 Nov 2022 20:24:10 +0100 Message-ID: Subject: Re: bug#58940: [PATCH] feature/tree-sitter: Add more font lock faces To: Stefan Monnier Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 58940 Cc: Randy Taylor , Eli Zaretskii , casouri@gmail.com, 58940@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > I suspect that's part of the reason. Ideally, we'd phase out those old > `font-lock-*-face` variables rather than introduce new ones. > I think the only thing they bring nowadays is confusion. Would it be worth it to make them obsolete? From debbugs-submit-bounces@debbugs.gnu.org Sun Nov 06 20:33:29 2022 Received: (at 58940) by debbugs.gnu.org; 7 Nov 2022 01:33:29 +0000 Received: from localhost ([127.0.0.1]:60969 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1orr0z-0008L0-GH for submit@debbugs.gnu.org; Sun, 06 Nov 2022 20:33:29 -0500 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:11048) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1orr0y-0008Ko-6U for 58940@debbugs.gnu.org; Sun, 06 Nov 2022 20:33:28 -0500 Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id A469D100189; Sun, 6 Nov 2022 20:33:22 -0500 (EST) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 117AF1000EF; Sun, 6 Nov 2022 20:33:21 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1667784801; bh=BGLnGaqBF83AlGTJkw10UJNZ7xCN0PY1I+KJiQHsAA0=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=fH/mf3JRbHhoKq4HYkSZtWGTF8ugl5SHobkqPvO1ZaEpFH/HH6OG2RkOtP+iarW7h g9oqmg88FoRpoJlESqETJZHv9ulT+T94qv1SlrccNPt3hxZ9gtVn7C78NMaPtUwUWH 40nMSSOmxzkdg/YiZzbCI3jkp3Fxl9lo83ruvQQRJd2Ib4Cp63clKzMJWx7R2TUQWc sfLb4xd1xKBjnCXC5mWm2zyBb8soM2sMfd6iaKBMhN/n51AHZj3kTlNOKaco77Y5js w+3pCVKC30AYxOXAVfL1Ht7xoBAIWBC5s7cb2bp9HTSBJoi5pxsC4pH1IsQ0axPTSj oYaFDqzqZuLKA== Received: from pastel (unknown [104.247.241.157]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id AED4612101E; Sun, 6 Nov 2022 20:33:20 -0500 (EST) From: Stefan Monnier To: Stefan Kangas Subject: Re: bug#58940: [PATCH] feature/tree-sitter: Add more font lock faces In-Reply-To: (Stefan Kangas's message of "Sun, 6 Nov 2022 20:24:10 +0100") Message-ID: References: <835yfxbkyy.fsf@gnu.org> <8ZKenedKBW2xqbSe_c0vWmeRbMQYCDlwFNvSMAYx9utQYeOKPHQQ-nKW9Y8nCcKRnFMmsnfonvA_0yixtSArBzVY_PkaNxxGWqhXoHjCZTo=@rjt.dev> <83cza14uuq.fsf@gnu.org> <83cza038yn.fsf@gnu.org> Date: Sun, 06 Nov 2022 20:33:18 -0500 User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL 0.166 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 58940 Cc: Randy Taylor , Eli Zaretskii , casouri@gmail.com, 58940@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) >> I suspect that's part of the reason. Ideally, we'd phase out those old >> `font-lock-*-face` variables rather than introduce new ones. >> I think the only thing they bring nowadays is confusion. > Would it be worth it to make them obsolete? I'd be in favor, yes. Note that most uses are within the `-font-lock-keywords` variables where they're invisible to the byte-compiler, so users/maintainers won't get to see very many warnings. Maybe we could tweak `font-lock-compile-keywords` to emit further warnings, but that will trigger at run-time rather than compile-time :-( Stefan From debbugs-submit-bounces@debbugs.gnu.org Sun Nov 06 22:31:49 2022 Received: (at 58940) by debbugs.gnu.org; 7 Nov 2022 03:31:49 +0000 Received: from localhost ([127.0.0.1]:32822 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1orsrV-0002s3-CE for submit@debbugs.gnu.org; Sun, 06 Nov 2022 22:31:49 -0500 Received: from eggs.gnu.org ([209.51.188.92]:36360) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1orsrT-0002rp-SB for 58940@debbugs.gnu.org; Sun, 06 Nov 2022 22:31:48 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1orsrO-00074w-JT; Sun, 06 Nov 2022 22:31:42 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=jmdj0UtSdU8W/Ta+o4xQmOS/ZE5Ia5pTxR4b1JEm8xY=; b=KrOJpajRC7T1 PbIdqdTuQjBiR7U2ziVZOo8xdiy5/Jq9LaNBUFkwarQvdjMI8IJ5DDiVQZtG2/F0MQPEO4AHvBfR6 MBPn9YiOa40U61LFqqTtSiz/AncHzKTPbCV6aZLtiDQve4/b6tDFIOWrbWVotZr+8CqJvUVivPsAP /ym9JXcx6mia1+OA5lFEk/B7GsD+3iXxrgNxuzkWhN5NuMWl6Mrbp0sHmRQcly9v/wHAHWqrgn3U2 bEGxDjfbGC5//73trpJda7hqGUiT+ShVM1Dgc1wKIaVaT6i73HNzIaYeEPRRyGlXouWRvuCoAGPs4 GOtFz9euqI5Ip4KvWGedLg==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1orsrN-0002mT-RY; Sun, 06 Nov 2022 22:31:42 -0500 Date: Mon, 07 Nov 2022 05:31:26 +0200 Message-Id: <83k047zbht.fsf@gnu.org> From: Eli Zaretskii To: Stefan Monnier In-Reply-To: (message from Stefan Monnier on Sun, 06 Nov 2022 20:33:18 -0500) Subject: Re: bug#58940: [PATCH] feature/tree-sitter: Add more font lock faces References: <835yfxbkyy.fsf@gnu.org> <8ZKenedKBW2xqbSe_c0vWmeRbMQYCDlwFNvSMAYx9utQYeOKPHQQ-nKW9Y8nCcKRnFMmsnfonvA_0yixtSArBzVY_PkaNxxGWqhXoHjCZTo=@rjt.dev> <83cza14uuq.fsf@gnu.org> <83cza038yn.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 58940 Cc: dev@rjt.dev, casouri@gmail.com, stefankangas@gmail.com, 58940@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Stefan Monnier > Cc: Eli Zaretskii , Randy Taylor , > casouri@gmail.com, 58940@debbugs.gnu.org > Date: Sun, 06 Nov 2022 20:33:18 -0500 > > >> I suspect that's part of the reason. Ideally, we'd phase out those old > >> `font-lock-*-face` variables rather than introduce new ones. > >> I think the only thing they bring nowadays is confusion. > > Would it be worth it to make them obsolete? > > I'd be in favor, yes. I wouldn't. There's gobs of code out there which will suddenly get warnings. For what purpose? Those variables cause no harm whatsoever. We shouldn't be too eager to obsolete things that cause us no harm. From debbugs-submit-bounces@debbugs.gnu.org Wed Nov 09 21:47:41 2022 Received: (at 58940) by debbugs.gnu.org; 10 Nov 2022 02:47:41 +0000 Received: from localhost ([127.0.0.1]:41490 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1osxbR-0002bK-Ho for submit@debbugs.gnu.org; Wed, 09 Nov 2022 21:47:41 -0500 Received: from mail-4022.proton.ch ([185.70.40.22]:42051) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1osxbO-0002ad-2E for 58940@debbugs.gnu.org; Wed, 09 Nov 2022 21:47:39 -0500 Date: Thu, 10 Nov 2022 02:47:20 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rjt.dev; s=protonmail2; t=1668048451; x=1668307651; bh=7wy/D9Is1Xxa0g3F7/nWIrSR0PVMK0LcJ3oq2VPZePk=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector; b=cHoTK4/sOsJWKnMqRfqVaVt2FyHI/l5kjOFST1BPEYrZTP4vxyLY5QRd1jbXLyFzD m6ujlf+e0j3reT7ITBH/LejT0pYwwjDDGr5BphzFtvv2c6+UIGXEmXxOcKxC/w3eOf OSrrvLxPIYT070NfTEkSMQNxd3jbSSWLejK01/uKbvnBfJS+wtKPCtSYT7hJ7i+ihz JWHpadtAL9LbA86yn6+kEEaRlp2ozlPLFL2LiHFGNQrQe0AvP1HnHGoJLk8291Cfgr 0a9UBwLBPMNJFGNjO50qGFxD3KVwRYO6Ur22D3Oa/OAyiNl3coxoxNu8nORnZTHTkp cv9SA1v8Q8hvQ== To: casouri@gmail.com From: Randy Taylor Subject: Re: bug#58940: [PATCH] feature/tree-sitter: Add more font lock faces Message-ID: In-Reply-To: References: <835yfxbkyy.fsf@gnu.org> <8ZKenedKBW2xqbSe_c0vWmeRbMQYCDlwFNvSMAYx9utQYeOKPHQQ-nKW9Y8nCcKRnFMmsnfonvA_0yixtSArBzVY_PkaNxxGWqhXoHjCZTo=@rjt.dev> <83cza14uuq.fsf@gnu.org> <83v8ns1oh6.fsf@gnu.org> Feedback-ID: 44397038:user:proton MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 58940 Cc: Eli Zaretskii , 58940@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Sunday, November 6th, 2022 at 12:02, Randy Taylor wrote: >=20 > I wonder if that detailed description is really necessary anymore? Before= the doc string read "...highlight properties". Now it reads "...highlight = properties of an object." - perhaps that's enough? Regardless, I separated = the detailed description out to its own sentence. >=20 > I also removed the variables. Yuan, any further comments? If not, would you or someone else be able to pu= sh the patch? Thanks. From debbugs-submit-bounces@debbugs.gnu.org Wed Nov 09 22:59:41 2022 Received: (at 58940) by debbugs.gnu.org; 10 Nov 2022 03:59:41 +0000 Received: from localhost ([127.0.0.1]:41545 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1osyj7-0004Qz-0m for submit@debbugs.gnu.org; Wed, 09 Nov 2022 22:59:41 -0500 Received: from mail-pj1-f50.google.com ([209.85.216.50]:37418) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1osyj4-0004Ql-SX for 58940@debbugs.gnu.org; Wed, 09 Nov 2022 22:59:39 -0500 Received: by mail-pj1-f50.google.com with SMTP id d59-20020a17090a6f4100b00213202d77e1so3720427pjk.2 for <58940@debbugs.gnu.org>; Wed, 09 Nov 2022 19:59:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=4zXfn34pyWX8emhsSP+fqjgxz/jFRYvyS8Tbf2drbm8=; b=gm3VEu6PMGo626dQkWRSl+7mcakpc34Dw3qJxYFaP1y9Nrx6Moao8wRBM/RhzA4ctG 7f0nS0HqLW5eAPWVaxlm8tupxE/rL8YJOAOyAYtKAMhFvXzisTtFe8geuLiPmXYrVTxb PuSB/77yiNKWYwuU49hmezLZ+spBtUWzruX0eJMPwt2YnMw2mCrb50oh++L5wQQgbPVB 56D7mskRiPseA3Qs6gw0XYVz+jDS11Kx+OFsO5uRaertyAbr59m4+q4p5TEd8iEidXMv xF2EYinTvsZzm6ze1wE4GYDyeURNuZE2d3TaU7lOxf0qoaGLMg9wAd422F0JPkKsSdS6 FdlQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=4zXfn34pyWX8emhsSP+fqjgxz/jFRYvyS8Tbf2drbm8=; b=FjIa6Dxmiizl1zcjWMliXlXZW++WYlRSxVlSTd3iTki9pPorSP08cXhgZgRXpb3kko YiFxmcVMD7/RvWEcRoUEjn9879/Jr+2Xwx5s9C+m8ce1Y5lV4cwOzfIkYfALkdZoyQo1 BvXQy7Xi3paGICiiARjNy3C6/oKqs4HH7hUAUp32CbUnbfpaM+yltqb809E9Ete420RG x6kRBu98arXZGdsR9ZDAeFKAbrpG9JF+V+MnlJsdwZdi3HmTYAK5+uc+HSEZXcp2+mIK QsZoJv556OYt+j1gkxGs5Xro21hW191Vgi0/7cohtyoJ+7teCUn1Uzod/gXda2mlGDud Xt5A== X-Gm-Message-State: ACrzQf0dJPCXLyhRcddQXZSwC/K0N0uMwTgT7053T0nXtHW9Uos0OUCf wxangsQaI4Ujh1LefsHQZI4= X-Google-Smtp-Source: AMsMyM7mu+gzbPqByishT2H2qHLXvntH6HXus4pgSf0IorrmZ2JJXGvJWdN+EjqWzqdYbouK8lNBEA== X-Received: by 2002:a17:90b:33d0:b0:213:137b:1343 with SMTP id lk16-20020a17090b33d000b00213137b1343mr65213763pjb.128.1668052772790; Wed, 09 Nov 2022 19:59:32 -0800 (PST) Received: from smtpclient.apple (cpe-172-117-161-177.socal.res.rr.com. [172.117.161.177]) by smtp.gmail.com with ESMTPSA id j4-20020a170903028400b001871f532cf9sm9857599plr.286.2022.11.09.19.59.31 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 09 Nov 2022 19:59:32 -0800 (PST) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.1\)) Subject: Re: bug#58940: [PATCH] feature/tree-sitter: Add more font lock faces From: Yuan Fu In-Reply-To: Date: Wed, 9 Nov 2022 19:59:30 -0800 Content-Transfer-Encoding: quoted-printable Message-Id: References: <835yfxbkyy.fsf@gnu.org> <8ZKenedKBW2xqbSe_c0vWmeRbMQYCDlwFNvSMAYx9utQYeOKPHQQ-nKW9Y8nCcKRnFMmsnfonvA_0yixtSArBzVY_PkaNxxGWqhXoHjCZTo=@rjt.dev> <83cza14uuq.fsf@gnu.org> <83v8ns1oh6.fsf@gnu.org> To: Randy Taylor X-Mailer: Apple Mail (2.3696.120.41.1.1) X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 58940 Cc: Eli Zaretskii , 58940@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > On Nov 9, 2022, at 6:47 PM, Randy Taylor wrote: >=20 > On Sunday, November 6th, 2022 at 12:02, Randy Taylor = wrote: >>=20 >> I wonder if that detailed description is really necessary anymore? = Before the doc string read "...highlight properties". Now it reads = "...highlight properties of an object." - perhaps that's enough? = Regardless, I separated the detailed description out to its own = sentence. >>=20 >> I also removed the variables. >=20 > Yuan, any further comments? If not, would you or someone else be able = to push the patch? >=20 > Thanks. I don=E2=80=99t have much to say, since this is not really about = tree-sitter. I=E2=80=99ll wait for other folks to decide & push ;-) Yuan= From debbugs-submit-bounces@debbugs.gnu.org Thu Nov 10 06:06:12 2022 Received: (at 58940-done) by debbugs.gnu.org; 10 Nov 2022 11:06:12 +0000 Received: from localhost ([127.0.0.1]:42114 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ot5Ns-0002fB-Ki for submit@debbugs.gnu.org; Thu, 10 Nov 2022 06:06:12 -0500 Received: from eggs.gnu.org ([209.51.188.92]:46322) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ot5Nr-0002f1-Qy for 58940-done@debbugs.gnu.org; Thu, 10 Nov 2022 06:06:12 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ot5Ni-00027P-U2; Thu, 10 Nov 2022 06:06:06 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=Ek52TkQ5sXEPubmG//HwLrRUtAcqe73bUNGSeqodzRg=; b=cgsl/aYwWlq10sxp694z xblCa7L4Tx5QqxlYG3pp9pEsWBNpXl4YnYv4ALmfCLbTuWSSzW7m0ph/MO2n8TDVVobWCSfne4VnH vTpHvzZDLmvK5XriotFu4W9HV7LwkQ5x/LX6CGmconChFvcHPBdC3lCJ7LI0Vkm2ShBrMb0lhJvlV p+htzTs6hWDFqskqREYB0iaroWsfLf8W/9RoKO2amgjrv7PFwJMHwrZJ9n6q7mwLoEtul+mr0TjtA 6st5IryLGL0O2G3/GVj/5Fi/6CBrAizsU0Z3UFXG66wgMdz6AM+8u5NHtg3gxmOhrsNOMTyYIxa7h NHNJXFz6yp0lcA==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ot5Nh-0003F6-F9; Thu, 10 Nov 2022 06:06:02 -0500 Date: Thu, 10 Nov 2022 13:06:01 +0200 Message-Id: <831qqbrrvq.fsf@gnu.org> From: Eli Zaretskii To: Yuan Fu In-Reply-To: (message from Yuan Fu on Wed, 9 Nov 2022 19:59:30 -0800) Subject: Re: bug#58940: [PATCH] feature/tree-sitter: Add more font lock faces References: <835yfxbkyy.fsf@gnu.org> <8ZKenedKBW2xqbSe_c0vWmeRbMQYCDlwFNvSMAYx9utQYeOKPHQQ-nKW9Y8nCcKRnFMmsnfonvA_0yixtSArBzVY_PkaNxxGWqhXoHjCZTo=@rjt.dev> <83cza14uuq.fsf@gnu.org> <83v8ns1oh6.fsf@gnu.org> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 58940-done Cc: dev@rjt.dev, 58940-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Yuan Fu > Date: Wed, 9 Nov 2022 19:59:30 -0800 > Cc: Eli Zaretskii , > 58940@debbugs.gnu.org > > > Yuan, any further comments? If not, would you or someone else be able to push the patch? > > > > Thanks. > > I don’t have much to say, since this is not really about tree-sitter. I’ll wait for other folks to decide & push ;-) I installed it, thanks. From unknown Tue Jun 17 22:28:40 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Thu, 08 Dec 2022 12:24:08 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator