From unknown Sun Jun 22 08:05:01 2025 X-Loop: help-debbugs@gnu.org Subject: bug#58909: 29.0.50; [WIP PATCH] Deleting the last frame of an emacsclient doesn't ask to save Resent-From: Jim Porter Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 30 Oct 2022 22:30:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 58909 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: 58909@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.16671689917048 (code B ref -1); Sun, 30 Oct 2022 22:30:02 +0000 Received: (at submit) by debbugs.gnu.org; 30 Oct 2022 22:29:51 +0000 Received: from localhost ([127.0.0.1]:39162 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1opGoQ-0001pb-WA for submit@debbugs.gnu.org; Sun, 30 Oct 2022 18:29:51 -0400 Received: from lists.gnu.org ([209.51.188.17]:59302) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1opGoP-0001pU-PA for submit@debbugs.gnu.org; Sun, 30 Oct 2022 18:29:50 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1opGoP-0000lj-Ib for bug-gnu-emacs@gnu.org; Sun, 30 Oct 2022 18:29:49 -0400 Received: from mail-pf1-x42c.google.com ([2607:f8b0:4864:20::42c]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1opGoB-0007Ez-Da for bug-gnu-emacs@gnu.org; Sun, 30 Oct 2022 18:29:48 -0400 Received: by mail-pf1-x42c.google.com with SMTP id 17so4950421pfv.4 for ; Sun, 30 Oct 2022 15:29:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:content-language:subject:from:mime-version:date:message-id:from :to:cc:subject:date:message-id:reply-to; bh=zoFjE22cTW3xXdPpEKheAg3I4NRX/U2nL4kwI3hBraw=; b=aPjwZeLpw8AuW8VAvHMUOq9aOKAe9pgd/WyOdEtzWs+QixyskoPp9JCzbI6JZJ/N8o gIBtcD7oPGMRZF4feokANwI0F816U8PNfHek2FGMulg2ckqx5O+eTHRGwd+HX0YGdwi0 IMJBL8RT2EBRocR9j8y0vhDRznNz0QkpiZ15ATHr2fT9GOnyrOc5Q1juwxrMQPPoZf2B 9JvYbX+UtC3TKmdO7HWAK3X5F6DyAlria9WZfSbc5Scm2WAcJVVduAUbb+4z7UugZ337 T1cjGH3MvN1temLXqXwYemr7Lq7gt3C9mP2tnXxtyr/alUu0pYNeXRGys8isPjic1azp P4rw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:content-language:subject:from:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=zoFjE22cTW3xXdPpEKheAg3I4NRX/U2nL4kwI3hBraw=; b=NH7AqygdGcGRaAu/IDk1ZpbKneTd1aZVsTpdIFtxFwvaminauhDqu4+9+d4KhgQ0Vh X8RZwXkEPFC7x5/FCY0S+HRvBFlzfLgPQU7g7tNEBBVq5VszHNAOdy5yKt1Obn5PQQez /n4y7YRKY6yKPZD1L0Tth5WxbVWyHWWQmMaleDFfKhzdThUBGHJFZIGpwaxilFhr8184 Qd9UUbeKzlXhMpY2yOw9Udunwe5mOc+zkTFJt/l+h+4dCqFHmDQ/VPpWDiVNkkWbHfAS IhjwlL9nMKJK7M7yhNHmUEgk74cEKrKUAYnl0hoJ5tZfGfVYs8X1aWTolz9iazTmMwGH NQVw== X-Gm-Message-State: ACrzQf1HE/C5BlXcFtoz+xIn3jSc0qdCnd6Yw5ZgSQhyXnrZdxW+92Xw oShzoAxi3bKRJcs92lB/rqv3dFVWso4= X-Google-Smtp-Source: AMsMyM78N0GwUhq8wJYqSOZVxpLGgMJcOPuKeWERVmM6mU6inlZ8jzm87fzqE+oYRXYtWmb5uPL+fA== X-Received: by 2002:aa7:92c8:0:b0:56b:d0b8:10f0 with SMTP id k8-20020aa792c8000000b0056bd0b810f0mr11121702pfa.46.1667168972358; Sun, 30 Oct 2022 15:29:32 -0700 (PDT) Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id t189-20020a6281c6000000b005668b26ade0sm3090566pfd.136.2022.10.30.15.29.31 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 30 Oct 2022 15:29:31 -0700 (PDT) Content-Type: multipart/mixed; boundary="------------0BvVna6Ty8GhOfAUnAobIOnu" Message-ID: <9a70f868-ca50-52fc-af3e-23813af104f2@gmail.com> Date: Sun, 30 Oct 2022 15:29:30 -0700 MIME-Version: 1.0 From: Jim Porter X-Mozilla-News-Host: news://news://news.gmane.io:119 Content-Language: en-US Received-SPF: pass client-ip=2607:f8b0:4864:20::42c; envelope-from=jporterbugs@gmail.com; helo=mail-pf1-x42c.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) This is a multi-part message in MIME format. --------------0BvVna6Ty8GhOfAUnAobIOnu Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit (Note: this is tangentially related to bug#51993, but it happens regardless of whether 'server-stop-automatically' is enabled.) In most cases when you do something to exit an Emacs client, it prompts you to save buffers associated with that client. For example: $ emacs -Q -f server-start $ emacsclient -c foo.txt ;; type some random characters C-x # ;; or... C-x C-c In both cases, Emacs will ask to save foo.txt, though the prompts will be slightly different. That's good, since whatever invoked "emacsclient -c foo.txt" is likely waiting for the user to have saved that file. However, if you use 'C-x 5 0' instead, that terminates the Emacs client, but *doesn't* prompt to save foo.txt. I think it should prompt in this case too: all three of 'C-x #', 'C-x C-c', and 'C-x 5 0' have the effect (in this simple case) of deleting the Emacs client and returning to the calling process. (A user who wanted to bail out of an Emacs client without saving should use 'sever-edit-abort' instead.) Attached is a WIP patch to do this. It's WIP because it will need to have some special handling for the 'server-stop-automatically' case so that it doesn't prompt twice in some cases. I also changed how 'delete-frame' calls 'delete-frame-functions'. Hopefully the change I made is correct; I'm hesitant to change low-level code like that, but I think it's the right thing to do for this case at least. (Maybe that change should be called out in NEWS?) Ultimately, it might make sense to merge this bug with bug#51993, but the discussion in that bug is already pretty long, and I think it would just confuse matters to add even more tangents to that discussion. --------------0BvVna6Ty8GhOfAUnAobIOnu Content-Type: text/plain; charset=UTF-8; name="0001-When-deleting-the-last-frame-of-an-Emacs-client-ask-.patch" Content-Disposition: attachment; filename*0="0001-When-deleting-the-last-frame-of-an-Emacs-client-ask-.pa"; filename*1="tch" Content-Transfer-Encoding: base64 RnJvbSA4NzBkOTk1NDA0ODNkMzkxNzQ4NjAxOTA4NzJkN2U2MWYyMjA1ZmFkIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKaW0gUG9ydGVyIDxqcG9ydGVyYnVnc0BnbWFpbC5j b20+CkRhdGU6IFNhdCwgMjkgT2N0IDIwMjIgMjA6NDA6NDkgLTA3MDAKU3ViamVjdDogW1BB VENIXSBXaGVuIGRlbGV0aW5nIHRoZSBsYXN0IGZyYW1lIG9mIGFuIEVtYWNzIGNsaWVudCwg YXNrIHRvIHNhdmUKCiogc3JjL2ZyYW1lLmMgKGRlbGV0ZV9mcmFtZSk6IENhbGwgJ2RlbGV0 ZS1mcmFtZS1mdW5jdGlvbnMnIHdpdGgKJ2NhbGwyJyBpbnN0ZWFkIG9mICdzYWZlX2NhbGwy JyB0byBhbGxvdyBob29rcyB0byBxdWl0LCBjYW5jZWxsaW5nIHRoZQpmcmFtZSdzIGRlbGV0 aW9uLgoKKiBsaXNwL3NlcnZlci5lbCAoc2VydmVyLXNhdmUtc29tZS1idWZmZXJzKTogTmV3 IGZ1bmN0aW9uLi4uCihzZXJ2ZXItaGFuZGxlLWRlbGV0ZS1mcmFtZSwgc2VydmVyLXNhdmUt YnVmZmVycy1raWxsLXRlcm1pbmFsKToKLi4uIHVzZSBpdC4KLS0tCiBsaXNwL3NlcnZlci5l bCB8IDMxICsrKysrKysrKysrKysrKysrKystLS0tLS0tLS0tLS0KIHNyYy9mcmFtZS5jICAg IHwgIDIgKy0KIDIgZmlsZXMgY2hhbmdlZCwgMjAgaW5zZXJ0aW9ucygrKSwgMTMgZGVsZXRp b25zKC0pCgpkaWZmIC0tZ2l0IGEvbGlzcC9zZXJ2ZXIuZWwgYi9saXNwL3NlcnZlci5lbApp bmRleCA5MGQ5N2MxNTM4Li5kZTRjNjM3Y2FhIDEwMDY0NAotLS0gYS9saXNwL3NlcnZlci5l bAorKysgYi9saXNwL3NlcnZlci5lbApAQCAtNDc5LDYgKzQ3OSwyMCBAQCBzZXJ2ZXItdW5z ZWxlY3QtZGlzcGxheQogICAgICAgKHdoZW4gKGJ1ZmZlci1saXZlLXAgYnVmZmVyKQogCShr aWxsLWJ1ZmZlciBidWZmZXIpKSkpKQogCisoZGVmdW4gc2VydmVyLXNhdmUtc29tZS1idWZm ZXJzIChwcm9jICZvcHRpb25hbCBhcmcpCisgICJTYXZlIG1vZGlmaWVkIGZpbGUtdmlzaXRp bmcgYnVmZmVycyBmcm9tIHRoZSBlbWFjc2NsaWVudCBmaWxlIGxpc3QuCitQUk9DIGlzIHRo ZSBlbWFjc2NsaWVudCBwcm9jZXNzLiAgSWYgQVJHIGlzIG5vbi1uaWwsIHNhdmUgYWxsCit3 aXRoIG5vIHF1ZXN0aW9ucy4iCisgIChsZXQgKChidWZmZXJzIChwcm9jZXNzLWdldCBwcm9j ICdidWZmZXJzKSkpCisgICAgKHNhdmUtc29tZS1idWZmZXJzCisgICAgIGFyZyAoaWYgYnVm ZmVycworICAgICAgICAgICAgIDs7IE9ubHkgZmlsZXMgZnJvbSBlbWFjc2NsaWVudCBmaWxl IGxpc3QuCisgICAgICAgICAgICAgKGxhbWJkYSAoKSAobWVtcSAoY3VycmVudC1idWZmZXIp IGJ1ZmZlcnMpKQorICAgICAgICAgICA7OyBJZiB0aGVyZSdzIG5vIGVtYWNzY2xpZW50IGZp bGUgbGlzdDogZG9uJ3Qgb3ZlcnJpZGUKKyAgICAgICAgICAgOzsgYHNhdmUtc29tZS1idWZm ZXJzLWRlZmF1bHQtcHJlZGljYXRlJyAodW5sZXNzIEFSRyBpcworICAgICAgICAgICA7OyBu b24tbmlsKS4KKyAgICAgICAgICAgKGFuZCBhcmcgdCkpKSkpCisKIChkZWZ1biBzZXJ2ZXIt aGFuZGxlLWRlbGV0ZS1mcmFtZSAoZnJhbWUpCiAgICJEZWxldGUgdGhlIGNsaWVudCBjb25u ZWN0aW9uIHdoZW4gdGhlIGVtYWNzY2xpZW50IGZyYW1lIGlzIGRlbGV0ZWQuCiBcKFRvIGJl IHVzZWQgZnJvbSBgZGVsZXRlLWZyYW1lLWZ1bmN0aW9ucycuKSIKQEAgLTQ5Miw3ICs1MDYs OSBAQCBzZXJ2ZXItaGFuZGxlLWRlbGV0ZS1mcmFtZQogICAgICAgICAgICAgICAgICAgICAg ICAgICAgIChlcSBwcm9jIChmcmFtZS1wYXJhbWV0ZXIgZiAnY2xpZW50KSkpKQogICAgICAg ICAgICAgICAgICAgICAgKGZyYW1lLWxpc3QpKSkpCiAgICAgICAoc2VydmVyLWxvZyAoZm9y bWF0ICJzZXJ2ZXItaGFuZGxlLWRlbGV0ZS1mcmFtZSwgZnJhbWUgJXMiIGZyYW1lKSBwcm9j KQotICAgICAgKHNlcnZlci1kZWxldGUtY2xpZW50IHByb2MgJ25vZnJhbWUpKSkpIDsgTGV0 IGRlbGV0ZS1mcmFtZSBkZWxldGUgdGhlIGZyYW1lIGxhdGVyLgorICAgICAgKHNlcnZlci1z YXZlLXNvbWUtYnVmZmVycyBwcm9jKSkKKyAgICAgIDs7IExldCBkZWxldGUtZnJhbWUgZGVs ZXRlIHRoZSBmcmFtZSBsYXRlci4KKyAgICAgIChzZXJ2ZXItZGVsZXRlLWNsaWVudCBwcm9j ICdub2ZyYW1lKSkpCiAKIChkZWZ1biBzZXJ2ZXItaGFuZGxlLXN1c3BlbmQtdHR5ICh0ZXJt aW5hbCkKICAgIk5vdGlmeSB0aGUgY2xpZW50IHByb2Nlc3MgdGhhdCBpdHMgdHR5IGRldmlj ZSBpcyBzdXNwZW5kZWQuIgpAQCAtMTc1MiwxNyArMTc2OCw4IEBAIHNlcnZlci1zYXZlLWJ1 ZmZlcnMta2lsbC10ZXJtaW5hbAogCSAgICAgICA7OyBJZiB3ZSdyZSB0aGUgbGFzdCBmcmFt ZSBzdGFuZGluZywga2lsbCBFbWFjcy4KIAkgICAgICAgKHNhdmUtYnVmZmVycy1raWxsLWVt YWNzIGFyZykpKQogCSAgICAoKHByb2Nlc3NwIHByb2MpCi0JICAgICAobGV0ICgoYnVmZmVy cyAocHJvY2Vzcy1nZXQgcHJvYyAnYnVmZmVycykpKQotCSAgICAgICAoc2F2ZS1zb21lLWJ1 ZmZlcnMKLQkgICAgICAgIGFyZyAoaWYgYnVmZmVycwotICAgICAgICAgICAgICAgICAgICAg ICAgOzsgT25seSBmaWxlcyBmcm9tIGVtYWNzY2xpZW50IGZpbGUgbGlzdC4KLQkJICAgICAg ICAobGFtYmRhICgpIChtZW1xIChjdXJyZW50LWJ1ZmZlcikgYnVmZmVycykpCi0gICAgICAg ICAgICAgICAgICAgICAgOzsgTm8gZW1hY3NjbGllbnQgZmlsZSBsaXN0OiBkb24ndCBvdmVy cmlkZQotICAgICAgICAgICAgICAgICAgICAgIDs7IGBzYXZlLXNvbWUtYnVmZmVycy1kZWZh dWx0LXByZWRpY2F0ZScgKHVubGVzcwotICAgICAgICAgICAgICAgICAgICAgIDs7IEFSRyBp cyBub24tbmlsKSwgc2luY2Ugd2UncmUgbm90IGtpbGxpbmcKLSAgICAgICAgICAgICAgICAg ICAgICA7OyBFbWFjcyAodW5saWtlIGBzYXZlLWJ1ZmZlcnMta2lsbC1lbWFjcycpLgotCQkg ICAgICAoYW5kIGFyZyB0KSkpCi0JICAgICAgIChzZXJ2ZXItZGVsZXRlLWNsaWVudCBwcm9j KSkpCisgICAgICAgICAgICAgKHNlcnZlci1zYXZlLXNvbWUtYnVmZmVycyBwcm9jIGFyZykK KwkgICAgIChzZXJ2ZXItZGVsZXRlLWNsaWVudCBwcm9jKSkKIAkgICAgKHQgKGVycm9yICJJ bnZhbGlkIGNsaWVudCBmcmFtZSIpKSkpKSkKIAogKGRlZnVuIHNlcnZlci1zdG9wLWF1dG9t YXRpY2FsbHktLWhhbmRsZS1kZWxldGUtZnJhbWUgKGZyYW1lKQpkaWZmIC0tZ2l0IGEvc3Jj L2ZyYW1lLmMgYi9zcmMvZnJhbWUuYwppbmRleCBmMDc2YTViYTU0Li44YTg1ZDVhNDAwIDEw MDY0NAotLS0gYS9zcmMvZnJhbWUuYworKysgYi9zcmMvZnJhbWUuYwpAQCAtMjAzNyw3ICsy MDM3LDcgQEAgZGVsZXRlX2ZyYW1lIChMaXNwX09iamVjdCBmcmFtZSwgTGlzcF9PYmplY3Qg Zm9yY2UpCiAgICAgICB4X2NsaXBib2FyZF9tYW5hZ2VyX3NhdmVfZnJhbWUgKGZyYW1lKTsK ICNlbmRpZgogCi0gICAgICBzYWZlX2NhbGwyIChRcnVuX2hvb2tfd2l0aF9hcmdzLCBRZGVs ZXRlX2ZyYW1lX2Z1bmN0aW9ucywgZnJhbWUpOworICAgICAgY2FsbDIgKFFydW5faG9va193 aXRoX2FyZ3MsIFFkZWxldGVfZnJhbWVfZnVuY3Rpb25zLCBmcmFtZSk7CiAgICAgfQogCiAg IC8qIGRlbGV0ZV9mcmFtZV9mdW5jdGlvbnMgbWF5IGhhdmUgZGVsZXRlZCBhbnkgZnJhbWUs IGluY2x1ZGluZyB0aGlzCi0tIAoyLjI1LjEKCg== --------------0BvVna6Ty8GhOfAUnAobIOnu-- From unknown Sun Jun 22 08:05:01 2025 X-Loop: help-debbugs@gnu.org Subject: bug#58909: 29.0.50; [WIP PATCH] Deleting the last frame of an emacsclient doesn't ask to save Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 31 Oct 2022 12:45:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58909 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Jim Porter Cc: 58909@debbugs.gnu.org Received: via spool by 58909-submit@debbugs.gnu.org id=B58909.166722028418549 (code B ref 58909); Mon, 31 Oct 2022 12:45:02 +0000 Received: (at 58909) by debbugs.gnu.org; 31 Oct 2022 12:44:44 +0000 Received: from localhost ([127.0.0.1]:39721 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1opU9k-0004p7-A2 for submit@debbugs.gnu.org; Mon, 31 Oct 2022 08:44:44 -0400 Received: from eggs.gnu.org ([209.51.188.92]:59048) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1opU9i-0004ou-Gg for 58909@debbugs.gnu.org; Mon, 31 Oct 2022 08:44:42 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1opU9d-0008BM-7t; Mon, 31 Oct 2022 08:44:37 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=qtef3QX1WyjwM4LBArarc2s82WljPdyuBkU5Fr5TDkM=; b=Yj7ck1jrgbBK 4q2Revwy0Oj+TLvohjeUlcqd1eExrBL0r9ZBr3dgDUfsyUnKfPOQ6fj27t2LHuE18PRbmpGjfNY3U cjXyAcyflXTM5DENV8tVPDqxtu6meaccoatV0/hZvqWg9lq08FMWhjXAXPyL/ckM3EsFBq4xw5CqQ f446olHCarv6R+iDA1qsysInBqSAa2ysmoKlUlrrBQgGlMeTvAG21vH4nNq8zRpdYqU5W7bTjRQyf qQBoO+7BpgKveBqCFe1dNCM+EW7azLM/xkhiM66goz1vtgAPLnALJg2zC2rUlScfeBHLIL9i4JYCY EyZO+ks6X4xRApCVlqDCzg==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1opU9c-0003Ne-Nt; Mon, 31 Oct 2022 08:44:37 -0400 Date: Mon, 31 Oct 2022 14:44:21 +0200 Message-Id: <83zgdcduxm.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: <9a70f868-ca50-52fc-af3e-23813af104f2@gmail.com> (message from Jim Porter on Sun, 30 Oct 2022 15:29:30 -0700) References: <9a70f868-ca50-52fc-af3e-23813af104f2@gmail.com> X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Sun, 30 Oct 2022 15:29:30 -0700 > From: Jim Porter > > $ emacs -Q -f server-start > $ emacsclient -c foo.txt > > ;; type some random characters > > C-x # > ;; or... > C-x C-c > > In both cases, Emacs will ask to save foo.txt, though the prompts will > be slightly different. That's good, since whatever invoked "emacsclient > -c foo.txt" is likely waiting for the user to have saved that file. > > However, if you use 'C-x 5 0' instead, that terminates the Emacs client, > but *doesn't* prompt to save foo.txt. I think it should prompt in this > case too: all three of 'C-x #', 'C-x C-c', and 'C-x 5 0' have the effect > (in this simple case) of deleting the Emacs client and returning to the > calling process. (A user who wanted to bail out of an Emacs client > without saving should use 'sever-edit-abort' instead.) I'm uneasy with this incompatible behavior change. I can think of some legitimate use cases where "C-x 5 0" should not prompt, e.g., if the user intends to keep editing the file, and no application is waiting for the client to finish. Why break such flows? Deleting a frame does no harm as long as Emacs is still up and running after that, so IMO forcing the user to answer such a prompt could be an annoyance. Thanks. From unknown Sun Jun 22 08:05:01 2025 X-Loop: help-debbugs@gnu.org Subject: bug#58909: 29.0.50; [WIP PATCH] Deleting the last frame of an emacsclient doesn't ask to save Resent-From: Jim Porter Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 31 Oct 2022 17:38:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58909 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Eli Zaretskii Cc: 58909@debbugs.gnu.org Received: via spool by 58909-submit@debbugs.gnu.org id=B58909.166723782616941 (code B ref 58909); Mon, 31 Oct 2022 17:38:02 +0000 Received: (at 58909) by debbugs.gnu.org; 31 Oct 2022 17:37:06 +0000 Received: from localhost ([127.0.0.1]:41682 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1opYif-0004PA-On for submit@debbugs.gnu.org; Mon, 31 Oct 2022 13:37:06 -0400 Received: from mail-pl1-f169.google.com ([209.85.214.169]:33513) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1opYid-0004Oh-Fv for 58909@debbugs.gnu.org; Mon, 31 Oct 2022 13:37:03 -0400 Received: by mail-pl1-f169.google.com with SMTP id 4so11409806pli.0 for <58909@debbugs.gnu.org>; Mon, 31 Oct 2022 10:37:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to; bh=jyythNiSKCKeyj/ttJNpNlqge63u+Bon7x88GkLNTt4=; b=Eeha9xDq2bQtUKmjywgpJ2ram7o1SGXJlouPb0C528DzAVBld6Pxpmig6ZbMXuoSh9 7J2HH+chu4lIAbZNVbrJzcSLU/aTfY1UQigWq0DU82YY7wblnKKVcIdN8fINQyVInj3f 9GPRpAta4LyxlTkKeno+HcqQkWFMjv7uJGTTn59ZER1o/7OfMf1s7n1o4dqWwVKemE+d x+FfyUnkOHTBhIN1chne1yZ9vdPBIuBiYQG7aw9yenXmaBzW3qeDYIX4bemXwSifbHPI irMSF0oL2kI2EkcBLg6JvknZZ6K10i9zu34rdfoV0Sq+5/szddFD7opyMdj4W68XoeOr 6s2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=jyythNiSKCKeyj/ttJNpNlqge63u+Bon7x88GkLNTt4=; b=5+9/ITACjGk0UoedE2xkVlRK8nkFHSJByYotBxBsnbGpDDbO2tZd00wNv6P/P+iEAn U+ydDBJMnibyTpQfe8j8smPucSacGex33ZUsVfv97npTOL1SgWc4MF8X0Z/CAKRfzTe+ ZMgYAVwN863mj1APp1cROZFeojbR4eu2/Pzyy/fVQKK6+kbxEjpZHyMrBs7b6pE0/JGA uTkuewCkCfK/ZlfyWI4odO9gelHqVZZlvnmCxkePZaH+hoW2xjQ4YCbb0q+1solfi7na rWovR7Km3X12uHfLxRhBTNliOvVFfidAQFymQbd71hZlGUxU+aV6XRA6HSgabNg999cF hD8w== X-Gm-Message-State: ACrzQf0H/Z2PKC3Nezv0m/yNh0MNSwJPdEUmNA3JGptdSpxK5wqL/sdd 19X1XL0xW7tckthj385CzqQ= X-Google-Smtp-Source: AMsMyM4hVyDXRTqm7IrAQG329/zxmgOHOn2+0FjOah2vjbXluTyc/7bUxGiRAAAtjJwf/Z00F/mVNg== X-Received: by 2002:a17:902:ec81:b0:187:1dbd:b86c with SMTP id x1-20020a170902ec8100b001871dbdb86cmr7492938plg.172.1667237817550; Mon, 31 Oct 2022 10:36:57 -0700 (PDT) Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id p23-20020a63c157000000b0046fd180640asm1522097pgi.24.2022.10.31.10.36.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 31 Oct 2022 10:36:56 -0700 (PDT) Message-ID: Date: Mon, 31 Oct 2022 10:36:57 -0700 MIME-Version: 1.0 Content-Language: en-US References: <9a70f868-ca50-52fc-af3e-23813af104f2@gmail.com> <83zgdcduxm.fsf@gnu.org> From: Jim Porter In-Reply-To: <83zgdcduxm.fsf@gnu.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 10/31/2022 5:44 AM, Eli Zaretskii wrote: > I'm uneasy with this incompatible behavior change. I can think of > some legitimate use cases where "C-x 5 0" should not prompt, e.g., if > the user intends to keep editing the file, and no application is > waiting for the client to finish. Why break such flows? Maybe we should add an option like 'server-save-before-deleting-last-frame', in case users prefer the old behavior? I had originally planned to add an option like this for the same reason you mention, but I didn't want to be too aggressive with adding extra options if they aren't really needed. Since you mentioned it too though, I think this should at least have an option. Alternately, we could add a keybinding for 'server-edit-abort'. Then users could easily use that command to support this flow. That has the benefit that it's a command which is explicitly for saying, "I'm done with this file and don't want to save it," though it does break users' muscle memory. Still another possibility would be to prompt only when closing a frame by clicking the "X" on the frame's title bar. When using a non-client/server Emacs, doing this prompts the user to save when closing the last frame. ('C-x 5 0' in this case would just error out, since it refuses to delete the last frame.) That's because clicking the X calls 'handle-delete-frame' which calls 'save-buffers-kill-emacs' in that case. Then clicking the "X" would behave similarly when deleting the last frame of a client and deleting the last frame overall. I think I prefer one of the first two though. > Deleting a frame does no harm as long as Emacs is still up and running > after that, so IMO forcing the user to answer such a prompt could be > an annoyance. I think it does about the same amount of harm as pressing 'C-x C-c' in an emacs client. Since my patch only affects the case when there's a single frame for the client, both 'C-x C-c' and 'C-x 5 0' would do the same thing (aside from prompting): they close the current frame and terminate the client connection. From unknown Sun Jun 22 08:05:01 2025 X-Loop: help-debbugs@gnu.org Subject: bug#58909: 29.0.50; [WIP PATCH] Deleting the last frame of an emacsclient doesn't ask to save Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 31 Oct 2022 18:26:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58909 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Jim Porter Cc: 58909@debbugs.gnu.org Received: via spool by 58909-submit@debbugs.gnu.org id=B58909.166724075322986 (code B ref 58909); Mon, 31 Oct 2022 18:26:01 +0000 Received: (at 58909) by debbugs.gnu.org; 31 Oct 2022 18:25:53 +0000 Received: from localhost ([127.0.0.1]:41747 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1opZTt-0005yf-GR for submit@debbugs.gnu.org; Mon, 31 Oct 2022 14:25:53 -0400 Received: from eggs.gnu.org ([209.51.188.92]:54410) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1opZTm-0005yM-2O for 58909@debbugs.gnu.org; Mon, 31 Oct 2022 14:25:52 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1opZTf-0002sC-QO; Mon, 31 Oct 2022 14:25:39 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=rwHMhxLKK+Q3O0xN9cWkl8KtHdkvHTyT/aR4NCe0Alw=; b=LVPkjS+nsBc3/lZhokMv 4EEjZTvXWsw6JoULQ2ONc9dV/a86Z7k7T9TlQ5apCTFo3rfXFkNzQEoLh0f3Qf7g8YwDpN5qfOoE+ klBuvHM6MU5AVUj058y36aZVDkmK0fLkSmBJfxyB0ijqDOMy32tqPxw1l+MJX+SZ2VmZlJyF7r5Ye eoTdyXFPjnX4YnN4MriIsF3M3D2k+SNuN+lSjhJQylFlbr/ruw01qQOWf39uyGY+ilz5JGCHXNh3z WLDCaxjC7WukekKdQWxhY0cvmgPeLEzgsOVeRdFd5Z7eMuook/0hrTlgHKnUuDhOMdnK27yXlJEUB P4mUlI7xZZneHA==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1opZTe-0001Jr-Qg; Mon, 31 Oct 2022 14:25:39 -0400 Date: Mon, 31 Oct 2022 20:25:24 +0200 Message-Id: <83bkpretpn.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: (message from Jim Porter on Mon, 31 Oct 2022 10:36:57 -0700) References: <9a70f868-ca50-52fc-af3e-23813af104f2@gmail.com> <83zgdcduxm.fsf@gnu.org> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Mon, 31 Oct 2022 10:36:57 -0700 > Cc: 58909@debbugs.gnu.org > From: Jim Porter > > On 10/31/2022 5:44 AM, Eli Zaretskii wrote: > > I'm uneasy with this incompatible behavior change. I can think of > > some legitimate use cases where "C-x 5 0" should not prompt, e.g., if > > the user intends to keep editing the file, and no application is > > waiting for the client to finish. Why break such flows? > > Maybe we should add an option like > 'server-save-before-deleting-last-frame', in case users prefer the old > behavior? I tend to think we shouldn't change the behavior here, not at all. Not even as an option. I see no problem here that we must solve. > Alternately, we could add a keybinding for 'server-edit-abort'. Users who need this can easily make a binding for them. There's no need to have such a binding by default. > Still another possibility would be to prompt only when closing a frame > by clicking the "X" on the frame's title bar. When using a > non-client/server Emacs, doing this prompts the user to save when > closing the last frame. ('C-x 5 0' in this case would just error out, > since it refuses to delete the last frame.) That's because clicking the > X calls 'handle-delete-frame' which calls 'save-buffers-kill-emacs' in > that case. Then clicking the "X" would behave similarly when deleting > the last frame of a client and deleting the last frame overall. But "last frame of a client" ≠ "the last frame". So I see no reason for a similar behavior. > > Deleting a frame does no harm as long as Emacs is still up and running > > after that, so IMO forcing the user to answer such a prompt could be > > an annoyance. > > I think it does about the same amount of harm as pressing 'C-x C-c' in > an emacs client. How can you say that? "C-x C-c" kills the entire terminal, whereas "C-x 5 0" kills just one frame! > Since my patch only affects the case when there's a single frame for > the client, both 'C-x C-c' and 'C-x 5 0' would do the same thing > (aside from prompting): they close the current frame and terminate > the client connection. I disagree, sorry. We are talking about maybe a minor inconvenience in a pretty special use case. It is unjustified to change long-time behavior for such weak reasons. From unknown Sun Jun 22 08:05:01 2025 X-Loop: help-debbugs@gnu.org Subject: bug#58909: 29.0.50; [WIP PATCH] Deleting the last frame of an emacsclient doesn't ask to save Resent-From: Jim Porter Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 31 Oct 2022 19:29:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58909 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Eli Zaretskii Cc: 58909@debbugs.gnu.org Received: via spool by 58909-submit@debbugs.gnu.org id=B58909.166724451329297 (code B ref 58909); Mon, 31 Oct 2022 19:29:02 +0000 Received: (at 58909) by debbugs.gnu.org; 31 Oct 2022 19:28:33 +0000 Received: from localhost ([127.0.0.1]:41848 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1opaSX-0007cS-0u for submit@debbugs.gnu.org; Mon, 31 Oct 2022 15:28:33 -0400 Received: from mail-pl1-f169.google.com ([209.85.214.169]:47069) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1opaSV-0007cD-W2 for 58909@debbugs.gnu.org; Mon, 31 Oct 2022 15:28:32 -0400 Received: by mail-pl1-f169.google.com with SMTP id l2so11608740pld.13 for <58909@debbugs.gnu.org>; Mon, 31 Oct 2022 12:28:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:from:references:cc:to:content-language:subject :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=/GcB5dj7k+O8SfGujkqjZWgf4rd2Kw1aQumggnlKGmo=; b=Hokj4FZCX8TOnaBPNQkPkB0qtvxFh9+Wt6X0OEZQ1QCNzr+nJDvIGLOmgV3YxP9C7i Hzg5wXITmjBu+nj9+U5psVbbValov4kdXsZLIBxLOZRmRs3vS626ifChmWpY8ScW3ZlB V6UAl30SqYyx3qxpziY35A8rY2AFW1ZgsTy91g1xfV9v9s1/dvDHzoIGrk1NIQNA58SZ BP2vT8qha+0TuBHw9Kfal4LdyX7+H1L9Vo/G/P1WQunxoAEAjilu6MANZBQ47+VWA3j2 ++15Hpr0rkplPU0naPhCIy0jFwc0tfMtUHz1PRYWgQjrTgIKftnSgvh1PXXj5ZNNwmSz +FNw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:from:references:cc:to:content-language:subject :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=/GcB5dj7k+O8SfGujkqjZWgf4rd2Kw1aQumggnlKGmo=; b=lr8b6gDtlQuL2dV2BxSqR33PCzjenSYBEIyFVXeHAHyKEaB3Rga76KMLykO8WSa6Kh vTJGrUqLGwcF8zaBRjQlr9H/C00fHt5xng+0NfD0+WBqyu5SOq3ZA25KLf5WM3TZeW5t zjjozmVrb1AI4ckBdSlrtQwKPoDc1opg8qvWfMP6zPgq7yPGoblzqD8w8BVO5J0cOFmN sfkN+Wr2ippZAqrpHmiFf9msMy/BlUZdJeVSHWKRkHTqD/ldvFuPfChS2+Y281U51HTX VWKTkntcmFfruw45PZIy/0pQRsyuoLYg2kjVZmmkUkYVvC1zxeI0G5mb3qEH5MIeX3ea PsHA== X-Gm-Message-State: ACrzQf1ZEMIhJkPPSBMoHxmJIFKvv2NY7EwUYa1lWTu0Ue2CEPQkbpD4 xwu5jIUHDeTZ6TDkBENuBOyALZbcDOo= X-Google-Smtp-Source: AMsMyM5hXU7+yf3O3di8UfDsH0p7ts0OLH3VMLh/dqr33skwkoSaI8uC7Iko4VQW+dWZah6IRfTC7Q== X-Received: by 2002:a17:902:ab5d:b0:186:bb2e:85a4 with SMTP id ij29-20020a170902ab5d00b00186bb2e85a4mr15794294plb.135.1667244505920; Mon, 31 Oct 2022 12:28:25 -0700 (PDT) Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id ig14-20020a17090b154e00b00213a9e1f863sm4585272pjb.4.2022.10.31.12.28.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 31 Oct 2022 12:28:24 -0700 (PDT) Content-Type: multipart/mixed; boundary="------------FL9Lr4PDX1xN3K0OHPQNtji0" Message-ID: <53238b5b-3e0a-3dfe-eeba-f37cafa81f50@gmail.com> Date: Mon, 31 Oct 2022 12:28:23 -0700 MIME-Version: 1.0 Content-Language: en-US References: <9a70f868-ca50-52fc-af3e-23813af104f2@gmail.com> <83zgdcduxm.fsf@gnu.org> From: Jim Porter In-Reply-To: <83zgdcduxm.fsf@gnu.org> X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) This is a multi-part message in MIME format. --------------FL9Lr4PDX1xN3K0OHPQNtji0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 10/31/2022 5:44 AM, Eli Zaretskii wrote: >> Date: Sun, 30 Oct 2022 15:29:30 -0700 >> From: Jim Porter >> >> However, if you use 'C-x 5 0' instead, that terminates the Emacs client, >> but *doesn't* prompt to save foo.txt. I think it should prompt in this >> case too: all three of 'C-x #', 'C-x C-c', and 'C-x 5 0' have the effect >> (in this simple case) of deleting the Emacs client and returning to the >> calling process. (A user who wanted to bail out of an Emacs client >> without saving should use 'sever-edit-abort' instead.) > > I'm uneasy with this incompatible behavior change. I can think of > some legitimate use cases where "C-x 5 0" should not prompt, e.g., if > the user intends to keep editing the file, and no application is > waiting for the client to finish. Why break such flows? After thinking about this some more, I realized that I didn't properly address this part of your message. If no application is waiting for the client to finish, then the user hopefully used "--no-wait" when starting emacsclient. We could avoid prompting in that case.[1] If an application *is* waiting for the client to finish, then "--no-wait" would be unset. In that case, prompting the user has some value. See the attached patch. (I changed the code to only prompt when deleting the last frame of a *non-nowait* client.) [1] Currently, 'C-x C-c' from a nowait frame prompts via 'save-some-buffers' (so long as there's another frame; see 'server-save-buffers-kill-terminal'). Maybe we could avoid prompting then too? After prompting, it just calls 'delete-frame', so it's very similar to 'C-x 5 0' in this scenario... Still, as you say, it's probably good to be careful about making incompatible changes here. --------------FL9Lr4PDX1xN3K0OHPQNtji0 Content-Type: text/plain; charset=UTF-8; name="0001-When-deleting-the-last-frame-of-an-Emacs-client-ask-.patch" Content-Disposition: attachment; filename*0="0001-When-deleting-the-last-frame-of-an-Emacs-client-ask-.pa"; filename*1="tch" Content-Transfer-Encoding: base64 RnJvbSA2OGI5ZjQxNjg1MjU2ODcwZjM0MDllYTQ2ODk3MWVlMGI2NGNmMTM2IE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKaW0gUG9ydGVyIDxqcG9ydGVyYnVnc0BnbWFpbC5j b20+CkRhdGU6IFNhdCwgMjkgT2N0IDIwMjIgMjA6NDA6NDkgLTA3MDAKU3ViamVjdDogW1BB VENIXSBXaGVuIGRlbGV0aW5nIHRoZSBsYXN0IGZyYW1lIG9mIGFuIEVtYWNzIGNsaWVudCwg YXNrIHRvIHNhdmUKCiogc3JjL2ZyYW1lLmMgKGRlbGV0ZV9mcmFtZSk6IENhbGwgJ2RlbGV0 ZS1mcmFtZS1mdW5jdGlvbnMnIHdpdGgKJ2NhbGwyJyBpbnN0ZWFkIG9mICdzYWZlX2NhbGwy JyB0byBhbGxvdyBob29rcyB0byBxdWl0LCBjYW5jZWxsaW5nIHRoZQpmcmFtZSdzIGRlbGV0 aW9uLgoKKiBsaXNwL3NlcnZlci5lbCAoc2VydmVyLXNhdmUtc29tZS1idWZmZXJzKTogTmV3 IGZ1bmN0aW9uLi4uCihzZXJ2ZXItaGFuZGxlLWRlbGV0ZS1mcmFtZSwgc2VydmVyLXNhdmUt YnVmZmVycy1raWxsLXRlcm1pbmFsKToKLi4uIHVzZSBpdC4KLS0tCiBsaXNwL3NlcnZlci5l bCB8IDMzICsrKysrKysrKysrKysrKysrKysrLS0tLS0tLS0tLS0tLQogc3JjL2ZyYW1lLmMg ICAgfCAgMiArLQogMiBmaWxlcyBjaGFuZ2VkLCAyMSBpbnNlcnRpb25zKCspLCAxNCBkZWxl dGlvbnMoLSkKCmRpZmYgLS1naXQgYS9saXNwL3NlcnZlci5lbCBiL2xpc3Avc2VydmVyLmVs CmluZGV4IDkwZDk3YzE1MzguLmYwNGY5OTM0MjYgMTAwNjQ0Ci0tLSBhL2xpc3Avc2VydmVy LmVsCisrKyBiL2xpc3Avc2VydmVyLmVsCkBAIC00NzksMTIgKzQ3OSwyNiBAQCBzZXJ2ZXIt dW5zZWxlY3QtZGlzcGxheQogICAgICAgKHdoZW4gKGJ1ZmZlci1saXZlLXAgYnVmZmVyKQog CShraWxsLWJ1ZmZlciBidWZmZXIpKSkpKQogCisoZGVmdW4gc2VydmVyLXNhdmUtc29tZS1i dWZmZXJzIChwcm9jICZvcHRpb25hbCBhcmcpCisgICJTYXZlIG1vZGlmaWVkIGZpbGUtdmlz aXRpbmcgYnVmZmVycyBmcm9tIHRoZSBlbWFjc2NsaWVudCBmaWxlIGxpc3QuCitQUk9DIGlz IHRoZSBlbWFjc2NsaWVudCBwcm9jZXNzLiAgSWYgQVJHIGlzIG5vbi1uaWwsIHNhdmUgYWxs Cit3aXRoIG5vIHF1ZXN0aW9ucy4iCisgIChsZXQgKChidWZmZXJzIChwcm9jZXNzLWdldCBw cm9jICdidWZmZXJzKSkpCisgICAgKHNhdmUtc29tZS1idWZmZXJzCisgICAgIGFyZyAoaWYg YnVmZmVycworICAgICAgICAgICAgIDs7IE9ubHkgZmlsZXMgZnJvbSBlbWFjc2NsaWVudCBm aWxlIGxpc3QuCisgICAgICAgICAgICAgKGxhbWJkYSAoKSAobWVtcSAoY3VycmVudC1idWZm ZXIpIGJ1ZmZlcnMpKQorICAgICAgICAgICA7OyBJZiB0aGVyZSdzIG5vIGVtYWNzY2xpZW50 IGZpbGUgbGlzdDogZG9uJ3Qgb3ZlcnJpZGUKKyAgICAgICAgICAgOzsgYHNhdmUtc29tZS1i dWZmZXJzLWRlZmF1bHQtcHJlZGljYXRlJyAodW5sZXNzIEFSRyBpcworICAgICAgICAgICA7 OyBub24tbmlsKS4KKyAgICAgICAgICAgKGFuZCBhcmcgdCkpKSkpCisKIChkZWZ1biBzZXJ2 ZXItaGFuZGxlLWRlbGV0ZS1mcmFtZSAoZnJhbWUpCiAgICJEZWxldGUgdGhlIGNsaWVudCBj b25uZWN0aW9uIHdoZW4gdGhlIGVtYWNzY2xpZW50IGZyYW1lIGlzIGRlbGV0ZWQuCiBcKFRv IGJlIHVzZWQgZnJvbSBgZGVsZXRlLWZyYW1lLWZ1bmN0aW9ucycuKSIKICAgKGxldCAoKHBy b2MgKGZyYW1lLXBhcmFtZXRlciBmcmFtZSAnY2xpZW50KSkpCiAgICAgKHdoZW4gKGFuZCAo ZnJhbWUtbGl2ZS1wIGZyYW1lKQotCSAgICAgICBwcm9jCisJICAgICAgIChwcm9jZXNzcCBw cm9jKQogCSAgICAgICA7OyBTZWUgaWYgdGhpcyBpcyB0aGUgbGFzdCBmcmFtZSBmb3IgdGhp cyBjbGllbnQuCiAgICAgICAgICAgICAgICAobm90IChzZXEtc29tZQogICAgICAgICAgICAg ICAgICAgICAgKGxhbWJkYSAoZikKQEAgLTQ5Miw3ICs1MDYsOSBAQCBzZXJ2ZXItaGFuZGxl LWRlbGV0ZS1mcmFtZQogICAgICAgICAgICAgICAgICAgICAgICAgICAgIChlcSBwcm9jIChm cmFtZS1wYXJhbWV0ZXIgZiAnY2xpZW50KSkpKQogICAgICAgICAgICAgICAgICAgICAgKGZy YW1lLWxpc3QpKSkpCiAgICAgICAoc2VydmVyLWxvZyAoZm9ybWF0ICJzZXJ2ZXItaGFuZGxl LWRlbGV0ZS1mcmFtZSwgZnJhbWUgJXMiIGZyYW1lKSBwcm9jKQotICAgICAgKHNlcnZlci1k ZWxldGUtY2xpZW50IHByb2MgJ25vZnJhbWUpKSkpIDsgTGV0IGRlbGV0ZS1mcmFtZSBkZWxl dGUgdGhlIGZyYW1lIGxhdGVyLgorICAgICAgKHNlcnZlci1zYXZlLXNvbWUtYnVmZmVycyBw cm9jKSkKKyAgICAgIDs7IExldCBkZWxldGUtZnJhbWUgZGVsZXRlIHRoZSBmcmFtZSBsYXRl ci4KKyAgICAgIChzZXJ2ZXItZGVsZXRlLWNsaWVudCBwcm9jICdub2ZyYW1lKSkpCiAKIChk ZWZ1biBzZXJ2ZXItaGFuZGxlLXN1c3BlbmQtdHR5ICh0ZXJtaW5hbCkKICAgIk5vdGlmeSB0 aGUgY2xpZW50IHByb2Nlc3MgdGhhdCBpdHMgdHR5IGRldmljZSBpcyBzdXNwZW5kZWQuIgpA QCAtMTc1MiwxNyArMTc2OCw4IEBAIHNlcnZlci1zYXZlLWJ1ZmZlcnMta2lsbC10ZXJtaW5h bAogCSAgICAgICA7OyBJZiB3ZSdyZSB0aGUgbGFzdCBmcmFtZSBzdGFuZGluZywga2lsbCBF bWFjcy4KIAkgICAgICAgKHNhdmUtYnVmZmVycy1raWxsLWVtYWNzIGFyZykpKQogCSAgICAo KHByb2Nlc3NwIHByb2MpCi0JICAgICAobGV0ICgoYnVmZmVycyAocHJvY2Vzcy1nZXQgcHJv YyAnYnVmZmVycykpKQotCSAgICAgICAoc2F2ZS1zb21lLWJ1ZmZlcnMKLQkgICAgICAgIGFy ZyAoaWYgYnVmZmVycwotICAgICAgICAgICAgICAgICAgICAgICAgOzsgT25seSBmaWxlcyBm cm9tIGVtYWNzY2xpZW50IGZpbGUgbGlzdC4KLQkJICAgICAgICAobGFtYmRhICgpIChtZW1x IChjdXJyZW50LWJ1ZmZlcikgYnVmZmVycykpCi0gICAgICAgICAgICAgICAgICAgICAgOzsg Tm8gZW1hY3NjbGllbnQgZmlsZSBsaXN0OiBkb24ndCBvdmVycmlkZQotICAgICAgICAgICAg ICAgICAgICAgIDs7IGBzYXZlLXNvbWUtYnVmZmVycy1kZWZhdWx0LXByZWRpY2F0ZScgKHVu bGVzcwotICAgICAgICAgICAgICAgICAgICAgIDs7IEFSRyBpcyBub24tbmlsKSwgc2luY2Ug d2UncmUgbm90IGtpbGxpbmcKLSAgICAgICAgICAgICAgICAgICAgICA7OyBFbWFjcyAodW5s aWtlIGBzYXZlLWJ1ZmZlcnMta2lsbC1lbWFjcycpLgotCQkgICAgICAoYW5kIGFyZyB0KSkp Ci0JICAgICAgIChzZXJ2ZXItZGVsZXRlLWNsaWVudCBwcm9jKSkpCisgICAgICAgICAgICAg KHNlcnZlci1zYXZlLXNvbWUtYnVmZmVycyBwcm9jIGFyZykKKwkgICAgIChzZXJ2ZXItZGVs ZXRlLWNsaWVudCBwcm9jKSkKIAkgICAgKHQgKGVycm9yICJJbnZhbGlkIGNsaWVudCBmcmFt ZSIpKSkpKSkKIAogKGRlZnVuIHNlcnZlci1zdG9wLWF1dG9tYXRpY2FsbHktLWhhbmRsZS1k ZWxldGUtZnJhbWUgKGZyYW1lKQpkaWZmIC0tZ2l0IGEvc3JjL2ZyYW1lLmMgYi9zcmMvZnJh bWUuYwppbmRleCBmMDc2YTViYTU0Li44YTg1ZDVhNDAwIDEwMDY0NAotLS0gYS9zcmMvZnJh bWUuYworKysgYi9zcmMvZnJhbWUuYwpAQCAtMjAzNyw3ICsyMDM3LDcgQEAgZGVsZXRlX2Zy YW1lIChMaXNwX09iamVjdCBmcmFtZSwgTGlzcF9PYmplY3QgZm9yY2UpCiAgICAgICB4X2Ns aXBib2FyZF9tYW5hZ2VyX3NhdmVfZnJhbWUgKGZyYW1lKTsKICNlbmRpZgogCi0gICAgICBz YWZlX2NhbGwyIChRcnVuX2hvb2tfd2l0aF9hcmdzLCBRZGVsZXRlX2ZyYW1lX2Z1bmN0aW9u cywgZnJhbWUpOworICAgICAgY2FsbDIgKFFydW5faG9va193aXRoX2FyZ3MsIFFkZWxldGVf ZnJhbWVfZnVuY3Rpb25zLCBmcmFtZSk7CiAgICAgfQogCiAgIC8qIGRlbGV0ZV9mcmFtZV9m dW5jdGlvbnMgbWF5IGhhdmUgZGVsZXRlZCBhbnkgZnJhbWUsIGluY2x1ZGluZyB0aGlzCi0t IAoyLjI1LjEKCg== --------------FL9Lr4PDX1xN3K0OHPQNtji0-- From unknown Sun Jun 22 08:05:01 2025 X-Loop: help-debbugs@gnu.org Subject: bug#58909: 29.0.50; [WIP PATCH] Deleting the last frame of an emacsclient doesn't ask to save Resent-From: Jim Porter Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 31 Oct 2022 19:39:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58909 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Eli Zaretskii Cc: 58909@debbugs.gnu.org Received: via spool by 58909-submit@debbugs.gnu.org id=B58909.166724509530451 (code B ref 58909); Mon, 31 Oct 2022 19:39:02 +0000 Received: (at 58909) by debbugs.gnu.org; 31 Oct 2022 19:38:15 +0000 Received: from localhost ([127.0.0.1]:41858 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1opabu-0007v5-Mj for submit@debbugs.gnu.org; Mon, 31 Oct 2022 15:38:14 -0400 Received: from mail-pl1-f171.google.com ([209.85.214.171]:42738) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1opabs-0007uo-6R for 58909@debbugs.gnu.org; Mon, 31 Oct 2022 15:38:13 -0400 Received: by mail-pl1-f171.google.com with SMTP id c24so11642317pls.9 for <58909@debbugs.gnu.org>; Mon, 31 Oct 2022 12:38:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:subject:from:mime-version:date:message-id:from:to:cc:subject :date:message-id:reply-to; bh=5qX9UmbV8LXc+CSlZxfUjriv1ilOhsQTVE0RD0sqgZE=; b=hKbDfZzrLgG5wtTp4Y+p4uznNL4knH5TaZwhMn2ay04Miq0w/+W8gxPNNB5WCamaAS Iz231aCp7ZhkpLF9TVfFEaFnmWbX7tD0a29O3O/2kNhpho9KgwA0Yf/0RE4b1uxbgKgM ql0tZLrDi5sQSo/Rj/7aWXbYgWQNmxnU26v4+3bg3PQookZCFJX55NyloxpB/+daush6 /U7w9Hc3d2o7Evh7XeK27UmJdB4Lm8Q/ZL1P7dRwsDcgpn98K/c6v1db3YGXeD0blfwd ewBXmJhGQmCvwncEVinXSH5t9RzvnmzXNEpRYqSTWkz1GklN+lo0m7OueXsxJUr/xf5Z DpCg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:subject:from:mime-version:date:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=5qX9UmbV8LXc+CSlZxfUjriv1ilOhsQTVE0RD0sqgZE=; b=gwFkssnIUVwQPpfeUZc8OYRSSWJ/AB6emu6t29pHaAlBgZTbsv7zpp6zvlnNSkf9DG VZACzHHSDIJUCAEUWIiW3nvjCQMr37I/OhSFFaU4uBWmEzdNbstGKArPjhli8VvD4PSr me6mfx1kH3o6qUFyFSFjdI5anu2shXNjyak91CFd2hzhEgl11DK9WVXUJq2oqu5nN4El UvJnHeXxInnEAd61fnywnJKDgEWE3ta7nVlHxMfZ/c08Vc9xkU01dyh4mF/TIHUDTPyB e+ow1vw3f2IXlm7c0qupkOyt0rA2XeumvrPQAxaX4KY8U5ixCaVRvo1n9Dn+QPIbbPnt bJ5A== X-Gm-Message-State: ACrzQf2yRpSRO20hmi0S0MG65KqZeorZ84AoBCa+f8FyU2iY+IFN+20L kJ3hI4rL66qvRDuBILFiJHA= X-Google-Smtp-Source: AMsMyM6Z0E0ZdXsLbeRruvNygQli3F37kIwuUMOgg3lGI1SwX6EEafQaWtSzQfhJ2AmoN+AxVF2Bxg== X-Received: by 2002:a17:902:b402:b0:179:e5b0:96d3 with SMTP id x2-20020a170902b40200b00179e5b096d3mr15668406plr.142.1667245086385; Mon, 31 Oct 2022 12:38:06 -0700 (PDT) Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id s6-20020a170902ea0600b001872999f58esm1604705plg.189.2022.10.31.12.38.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 31 Oct 2022 12:38:05 -0700 (PDT) Message-ID: Date: Mon, 31 Oct 2022 12:38:04 -0700 MIME-Version: 1.0 From: Jim Porter References: <9a70f868-ca50-52fc-af3e-23813af104f2@gmail.com> <83zgdcduxm.fsf@gnu.org> <83bkpretpn.fsf@gnu.org> Content-Language: en-US In-Reply-To: <83bkpretpn.fsf@gnu.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 10/31/2022 11:25 AM, Eli Zaretskii wrote: >> I think it does about the same amount of harm as pressing 'C-x C-c' in >> an emacs client. > > How can you say that? "C-x C-c" kills the entire terminal, whereas > "C-x 5 0" kills just one frame! When there's only one frame left for the client, 'C-x 5 0' *also* kills the entire terminal. That's the only case I want to add a prompt to. I agree that if you're only killing a frame, there's no sense in prompting. But when killing a frame gets upgraded into killing the entire terminal, it then has the same end result as having pressed 'C-x C-c'. Shouldn't Emacs then ask the user about what to do before killing the terminal? Of course, 'C-x C-c' also has the effect of killing any other frames for that client, but that that doesn't apply there's only one frame. Still, 'C-x C-c' still prompts in that case too. My understanding is that it does so because when an application is waiting for the emacsclient to finish, you can't go back from killing the terminal/client; you *can* (usually) go back if you're only killing a frame. See my other message about this too: we could make sure Emacs only prompts the user when deleting a frame if doing so would kill a terminal that's actually waiting for some files to be saved. If the client was invoked with "--no-wait", we could just silently delete the frame: there's no application waiting for a file. From unknown Sun Jun 22 08:05:01 2025 X-Loop: help-debbugs@gnu.org Subject: bug#58909: 29.0.50; [WIP PATCH] Deleting the last frame of an emacsclient doesn't ask to save Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 31 Oct 2022 19:44:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58909 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Jim Porter Cc: 58909@debbugs.gnu.org Received: via spool by 58909-submit@debbugs.gnu.org id=B58909.166724543131450 (code B ref 58909); Mon, 31 Oct 2022 19:44:02 +0000 Received: (at 58909) by debbugs.gnu.org; 31 Oct 2022 19:43:51 +0000 Received: from localhost ([127.0.0.1]:41863 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1opahL-0008BC-Eg for submit@debbugs.gnu.org; Mon, 31 Oct 2022 15:43:51 -0400 Received: from eggs.gnu.org ([209.51.188.92]:52102) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1opahF-0008Aa-Q3 for 58909@debbugs.gnu.org; Mon, 31 Oct 2022 15:43:49 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1opahA-0005BW-Hb; Mon, 31 Oct 2022 15:43:40 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=fOv9kEdE6LIqaOMC6m4D3/tOb7szVTsgvRweqmbs+o0=; b=rT6s9RpuaBAQ BzOIrtc3qsz49T27bearmeoEXPh9DgpTUD0R1FbPFHkc/HvfewZW2pkD5tCKT7HddY8CjpmAxJh3B maFcouey/+mFX653B+kz3iJSZeSVESlDTRdO4KCUgenITIaxqCtUmetHNqY4fZxXLTBFQjRgJ7dDx c34/cnZhvt+qbff1Ua4lp4bVN6/zQxTG2mAkzH4lytZZS2EUUCUUPJk+Oi7x6cann6qbodeDFm/FS XvIsDCS3TprMJwGBpUmWSWsgVdI5uyV1p5+TKxi6WwkiqvxZjd+NkOFIbuoq2ElNtodjw7FrN2SWi NwM9T6eDLwkuuTnr0IOuww==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1opah9-00042H-G8; Mon, 31 Oct 2022 15:43:40 -0400 Date: Mon, 31 Oct 2022 21:43:24 +0200 Message-Id: <838rkveq3n.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: <53238b5b-3e0a-3dfe-eeba-f37cafa81f50@gmail.com> (message from Jim Porter on Mon, 31 Oct 2022 12:28:23 -0700) References: <9a70f868-ca50-52fc-af3e-23813af104f2@gmail.com> <83zgdcduxm.fsf@gnu.org> <53238b5b-3e0a-3dfe-eeba-f37cafa81f50@gmail.com> X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Mon, 31 Oct 2022 12:28:23 -0700 > Cc: 58909@debbugs.gnu.org > From: Jim Porter > > > I'm uneasy with this incompatible behavior change. I can think of > > some legitimate use cases where "C-x 5 0" should not prompt, e.g., if > > the user intends to keep editing the file, and no application is > > waiting for the client to finish. Why break such flows? > > After thinking about this some more, I realized that I didn't properly > address this part of your message. If no application is waiting for the > client to finish, then the user hopefully used "--no-wait" when starting > emacsclient. No, I meant that the user invoked emacsclient from the shell prompt, for example. As opposed to some application invoking emacsclient via $EDITOR or similar. From unknown Sun Jun 22 08:05:01 2025 X-Loop: help-debbugs@gnu.org Subject: bug#58909: 29.0.50; [WIP PATCH] Deleting the last frame of an emacsclient doesn't ask to save Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 31 Oct 2022 19:53:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58909 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Jim Porter Cc: 58909@debbugs.gnu.org Received: via spool by 58909-submit@debbugs.gnu.org id=B58909.1667245954872 (code B ref 58909); Mon, 31 Oct 2022 19:53:01 +0000 Received: (at 58909) by debbugs.gnu.org; 31 Oct 2022 19:52:34 +0000 Received: from localhost ([127.0.0.1]:41868 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1opapm-0000Dz-ET for submit@debbugs.gnu.org; Mon, 31 Oct 2022 15:52:34 -0400 Received: from eggs.gnu.org ([209.51.188.92]:35218) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1opapl-0000Dc-Hy for 58909@debbugs.gnu.org; Mon, 31 Oct 2022 15:52:34 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1opapg-0000T9-An; Mon, 31 Oct 2022 15:52:28 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=v6CAKstmXy1RZvlNm8W5QT/1JtqXjylQioojQYPteSY=; b=HQ//AqfPWtIe yuNyd2fRr29p7yc0rVmhq1AwfPFXWoK/EVjYcOeVT8KNL0zLh+Zm8/nSUXsGvofX3XoqwixKck6oz CxUaW1LB5aC69l/zOCAwp8Q6d24QWq4SoTXifG0D2MxgN67dgFpMNj0dkNKbmjUXnAOCraqJhy69p yqar46OkaSqlyF7l4Dwyw+8BugNd90obstUq/hUMz+294pnCtWbdm146iqASC6upUFMgyIv3A3M2M +sLuJ4/x2qU+JQsvVhs39R3iu8/yHBpYhXeeI/o3yi4mwr0FTx47Hel3HNQTA9kW21GYjsVyCgUkn PldqBJbOIWOHuNVQJ/dKCg==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1opapf-0004sJ-9w; Mon, 31 Oct 2022 15:52:28 -0400 Date: Mon, 31 Oct 2022 21:52:12 +0200 Message-Id: <837d0fepoz.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: (message from Jim Porter on Mon, 31 Oct 2022 12:38:04 -0700) References: <9a70f868-ca50-52fc-af3e-23813af104f2@gmail.com> <83zgdcduxm.fsf@gnu.org> <83bkpretpn.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Mon, 31 Oct 2022 12:38:04 -0700 > From: Jim Porter > Cc: 58909@debbugs.gnu.org > > On 10/31/2022 11:25 AM, Eli Zaretskii wrote: > >> I think it does about the same amount of harm as pressing 'C-x C-c' in > >> an emacs client. > > > > How can you say that? "C-x C-c" kills the entire terminal, whereas > > "C-x 5 0" kills just one frame! > > When there's only one frame left for the client, 'C-x 5 0' *also* kills > the entire terminal. But "C-x 5 0" doesn't have the same significance as "C-x C-c". They are different in the non-client use, and they are different in the client use. That someone could perceive them as very similar because some aspects of what they do are the same doesn't mean they are similar enough to behave the same wrt the prompt to save. > Of course, 'C-x C-c' also has the effect of killing any other frames for > that client, but that that doesn't apply there's only one frame. It would (or at least could) be possible to reason that way. But it could be argued that forcing the user to distinguish between the last "C-x 5 0" and any other is bad UI. When I type "C-x 5 0" I don't want to expect different behavior depending on how many frames the current client has. "C-x 5 0" means "delete this frame", no more, no less. > Still, > 'C-x C-c' still prompts in that case too. My understanding is that it > does so because when an application is waiting for the emacsclient to > finish, you can't go back from killing the terminal/client; you *can* > (usually) go back if you're only killing a frame. My interpretation of why "C-x C-c" prompts is that it does the same as when you use it from a non-client frame. We want the same UX in both cases. "C-x 5 0" should IMO likewise produce the same behavior in both cases. > See my other message about this too: we could make sure Emacs only > prompts the user when deleting a frame if doing so would kill a terminal > that's actually waiting for some files to be saved. If the client was > invoked with "--no-wait", we could just silently delete the frame: > there's no application waiting for a file. This has the same problem, IMO: it changes long-time behavior of client frames in incompatible ways. I don't think it's right, since the reasons for these changes are rather weak. From unknown Sun Jun 22 08:05:01 2025 X-Loop: help-debbugs@gnu.org Subject: bug#58909: 29.0.50; [WIP PATCH] Deleting the last frame of an emacsclient doesn't ask to save Resent-From: Jim Porter Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 31 Oct 2022 20:03:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58909 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Eli Zaretskii Cc: 58909@debbugs.gnu.org Received: via spool by 58909-submit@debbugs.gnu.org id=B58909.16672465262012 (code B ref 58909); Mon, 31 Oct 2022 20:03:01 +0000 Received: (at 58909) by debbugs.gnu.org; 31 Oct 2022 20:02:06 +0000 Received: from localhost ([127.0.0.1]:41872 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1opayz-0000WN-Kp for submit@debbugs.gnu.org; Mon, 31 Oct 2022 16:02:05 -0400 Received: from mail-pl1-f180.google.com ([209.85.214.180]:35358) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1opayx-0000Vr-AD for 58909@debbugs.gnu.org; Mon, 31 Oct 2022 16:02:03 -0400 Received: by mail-pl1-f180.google.com with SMTP id y4so11716884plb.2 for <58909@debbugs.gnu.org>; Mon, 31 Oct 2022 13:02:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to; bh=tJGDBpx1zGrhFsFhbOzDEZmEZmDdHrcq9tN30PQ3IAo=; b=KC4avW09XPWyK+65K5pxrTPXY8RdGoW3oJ+W0mCmEhqnQMvOErj9JTQ0l/zU2tCEYJ I8STQIffNljP1B2p9Smb/oa+03DHl7K68X/68S7EDvZR8E8HQYvNz3JB0f4gQrFyrCjf ixQR8XewOw3MPeINSRIqKkYwQ/iA+mqExEwzFWMvY33JJgmE5qrWbPuwsBQRKW0C3oY5 S9yXeUjj2/dMdjcViGnmJzZkncjBrpNkPk+2L36KdquviBM50iJUJpC68gNFuQ8X+OMN /Njl4PHv6O/a5Ares+gCU2Krlfzq6qipbXODBebAu1kU47nWeTu+U6lHoeU1aePVHhLb qcpw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=tJGDBpx1zGrhFsFhbOzDEZmEZmDdHrcq9tN30PQ3IAo=; b=zyQoarKKgT5pfYI+iFvoiKmgEmMTisuLuYcaTc8+1B2OLGZrkxjhM7A7ZIeh3cf2WV CZr4pSysQf+1DmvUZtwTSL+9GFvJRLIbi/lMRFCemz//yn+cHBlwvghYz8iIasYU/qI/ As3QhTWcGKt6wtVhuJMsvr3Uuc/3WzCM1HgUeKjlzPpjg64GnI51oRIIHUxp8IYQve5d O3JEFZsguRtiyJ7DEA+w368/4fjoHa3WVeO/ujTQuReqFXqWL14J3SrD5ISDzlbcwMly jkJ9ADm2jjytsEbtbz0Tb47JTu2Rw7JHn0JeRnubd3r6cv80OoO9tSX+40MvFCj2jhmB Eu1g== X-Gm-Message-State: ACrzQf1InOoMm9bQ2Qzd7KsA5zwr969v2rcUQ9IR01EAi0RJxdnO/ylA d3fLCH6twk4hkfq8E+c0UsmR9XFhug4= X-Google-Smtp-Source: AMsMyM6oZ9QxB0P6wURrUALC7pbIapGxajmSCzduUAT6hdOcjG49CAigTJA6bQ8zyVTb/w8N+/2QMQ== X-Received: by 2002:a17:902:8ec8:b0:186:9c32:79c8 with SMTP id x8-20020a1709028ec800b001869c3279c8mr16250828plo.105.1667246517379; Mon, 31 Oct 2022 13:01:57 -0700 (PDT) Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id 68-20020a17090a09ca00b0021134a19ae2sm4548058pjo.50.2022.10.31.13.01.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 31 Oct 2022 13:01:56 -0700 (PDT) Message-ID: <7de45884-b4c9-4a4c-777c-5db17b3bacca@gmail.com> Date: Mon, 31 Oct 2022 13:01:55 -0700 MIME-Version: 1.0 Content-Language: en-US References: <9a70f868-ca50-52fc-af3e-23813af104f2@gmail.com> <83zgdcduxm.fsf@gnu.org> <53238b5b-3e0a-3dfe-eeba-f37cafa81f50@gmail.com> <838rkveq3n.fsf@gnu.org> From: Jim Porter In-Reply-To: <838rkveq3n.fsf@gnu.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 10/31/2022 12:43 PM, Eli Zaretskii wrote: >> Date: Mon, 31 Oct 2022 12:28:23 -0700 >> Cc: 58909@debbugs.gnu.org >> From: Jim Porter >> >>> I'm uneasy with this incompatible behavior change. I can think of >>> some legitimate use cases where "C-x 5 0" should not prompt, e.g., if >>> the user intends to keep editing the file, and no application is >>> waiting for the client to finish. Why break such flows? >> >> After thinking about this some more, I realized that I didn't properly >> address this part of your message. If no application is waiting for the >> client to finish, then the user hopefully used "--no-wait" when starting >> emacsclient. > > No, I meant that the user invoked emacsclient from the shell prompt, > for example. As opposed to some application invoking emacsclient via > $EDITOR or similar. If a user simply typed "emacsclient file.txt", that would visit file.txt in an existing frame (if possible), so that frame wouldn't be associated with the emacsclient process the user just started. Pressing 'C-x 5 0' wouldn't need to prompt then: it's not deleting the last frame associated with that client, so the code in 'server-handle-delete-frame' doesn't apply. (Note: It's possible that the frame in question is the last frame of some *other* client though.) A user might instead type "emacsclient -c file.txt" (or use "-t", etc) to create an all-new frame. In that case, my patch would prompt. But if the user is already typing "emacsclient -c file.txt", then "emacsclient -nc foo.txt" is just one more character, and it would make it explicit that the client isn't waiting around for file.txt. Then my patch would *not* prompt. From unknown Sun Jun 22 08:05:01 2025 X-Loop: help-debbugs@gnu.org Subject: bug#58909: 29.0.50; [WIP PATCH] Deleting the last frame of an emacsclient doesn't ask to save Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 31 Oct 2022 20:23:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58909 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Jim Porter Cc: 58909@debbugs.gnu.org Received: via spool by 58909-submit@debbugs.gnu.org id=B58909.16672477503909 (code B ref 58909); Mon, 31 Oct 2022 20:23:02 +0000 Received: (at 58909) by debbugs.gnu.org; 31 Oct 2022 20:22:30 +0000 Received: from localhost ([127.0.0.1]:41900 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1opbIj-00010z-SW for submit@debbugs.gnu.org; Mon, 31 Oct 2022 16:22:30 -0400 Received: from eggs.gnu.org ([209.51.188.92]:57652) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1opbIi-00010k-0Y for 58909@debbugs.gnu.org; Mon, 31 Oct 2022 16:22:28 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1opbIb-0003SP-ED; Mon, 31 Oct 2022 16:22:21 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=5YV/1gr9Oo/noJngEW1QPH0aBEUfnaPe2Bfs6Fjftic=; b=jwTLSBgFgvdI CbBMYhR0SCooVXoF2OIbOnMwS9MGZYskO/xGGGOSbSPiNU7g/HGzOTg3h5+AjFYSEXN9NquhRwwkh gGTinPGrDE/mnZMjtekA5hCLsdj/RVZrsYttOtyVgyqq/nz6cYkfwycqHD9d1cWYabaVtiovyLvAW BLSxeJwAykCXy7cNRh7vGpUuETnlobZbXSZ0ZraGy9Kx3HnCgGOoNC6tKj0qozuXIBKfxL0jLLu87 c0It/a5DcKvm2jSr4kl/T02KyJzcu+fiq+hAq0r+2ChBZFmdkJtRumL1XgnKEY8Gh7IcZpWmYls9Z QCo5DZ7vXxrXuuHa29qBWA==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1opbIC-0005VM-Nd; Mon, 31 Oct 2022 16:22:06 -0400 Date: Mon, 31 Oct 2022 22:21:42 +0200 Message-Id: <835yfzeobt.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: <7de45884-b4c9-4a4c-777c-5db17b3bacca@gmail.com> (message from Jim Porter on Mon, 31 Oct 2022 13:01:55 -0700) References: <9a70f868-ca50-52fc-af3e-23813af104f2@gmail.com> <83zgdcduxm.fsf@gnu.org> <53238b5b-3e0a-3dfe-eeba-f37cafa81f50@gmail.com> <838rkveq3n.fsf@gnu.org> <7de45884-b4c9-4a4c-777c-5db17b3bacca@gmail.com> X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Mon, 31 Oct 2022 13:01:55 -0700 > Cc: 58909@debbugs.gnu.org > From: Jim Porter > > A user might instead type "emacsclient -c file.txt" (or use "-t", etc) > to create an all-new frame. In that case, my patch would prompt. But if > the user is already typing "emacsclient -c file.txt", then "emacsclient > -nc foo.txt" is just one more character, and it would make it explicit > that the client isn't waiting around for file.txt. Then my patch would > *not* prompt. Yes, this new behavior can be worked around, in more than one way. But people get annoyed by changes which invalidate their muscle memory of many years. So we must in each case like this to have a very good reason for such changes, otherwise people would rightfully conclude that our decisions are more-or-less are arbitrary and basically prefer someone's workflows over those of others. I'm sorry, but past behavior gets more weight in such situations, just because it was here first. From unknown Sun Jun 22 08:05:01 2025 X-Loop: help-debbugs@gnu.org Subject: bug#58909: 29.0.50; [WIP PATCH] Deleting the last frame of an emacsclient doesn't ask to save Resent-From: Jim Porter Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 31 Oct 2022 20:29:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58909 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Eli Zaretskii Cc: 58909@debbugs.gnu.org Received: via spool by 58909-submit@debbugs.gnu.org id=B58909.16672480924460 (code B ref 58909); Mon, 31 Oct 2022 20:29:01 +0000 Received: (at 58909) by debbugs.gnu.org; 31 Oct 2022 20:28:12 +0000 Received: from localhost ([127.0.0.1]:41910 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1opbOF-00019s-OD for submit@debbugs.gnu.org; Mon, 31 Oct 2022 16:28:12 -0400 Received: from mail-pj1-f49.google.com ([209.85.216.49]:40521) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1opbOD-00019c-NS for 58909@debbugs.gnu.org; Mon, 31 Oct 2022 16:28:10 -0400 Received: by mail-pj1-f49.google.com with SMTP id r61-20020a17090a43c300b00212f4e9cccdso16928172pjg.5 for <58909@debbugs.gnu.org>; Mon, 31 Oct 2022 13:28:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to; bh=+MmfvQpWNEMKRg5JSy+UwnpkwThKMShKGipjktS1shY=; b=OW3SH8fluJZAv1ExidRUSwcQbF7U0dscbiXfag9/68eNX/joOv3VsXsFe3TxAhlYvU ZVanVnXi1Fmfu0ULhvn6/Ev0VRPLg97ZIOqPR44HyWYXpmrRI5HQ6mHpqWDdgeXgXzgd EAxTT6M8sm8Zp0dpmldwZZtRqgF3ELyGiDBFAU/F9IiqwE3Xs0F+rv9GNFlCWVxbbTj2 rhIh2pgu8KhjWbiDb8FyrvfaYgLpnfYKjFGm4RKI6fnmlZevxnv/7ymzMXrv6H9qXt82 OYV0ySHSJn+IQ34jG6rjeETAe4KrwRYyY4trvseWoCHds5jJA1QAPmqJbo7yL9Tz8ZYl Zvmg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=+MmfvQpWNEMKRg5JSy+UwnpkwThKMShKGipjktS1shY=; b=8McDeBuC6CfwuB0ORZ05r3M002wAkv07jxINF7SbglT6HwQE73ptsgBb8hg3eQi2Gt D3tO4Xq8Ysoz9VDMGJZ5jkGEu0NyhTo2qLwlaekOOqiMsuRsNxEEElMGgjqd/U57YJ3E 8NH5VGTru/mQcDqn+QcDN2f4hYa9TuN2z/AZBQwbNS//Zbjd1HIZ9z/5ZjbBg/5smF+g h140bo1fojth41F+Fh/+NG6+xZ0Fe4yEuseh6pyiAG40B+LI/Ea+sQ9T0SDZGvgGSHj/ 90bbeuG4qD8JAohoVsPdtX874HuBL4DKFTYktZCmT3lx+K0u11xAUpo0rItuIGBZ1LaF I85w== X-Gm-Message-State: ACrzQf0NXNjFmMhv+lVZfDLB9xu0IdaDDyPcx4Kmv9hfNyNSXC4aZUuL V+Bx6zEQklQtQAr96lhv8XI= X-Google-Smtp-Source: AMsMyM5CxS1sT2LEHB5HSXcjF6AWf5QXpmUo0eaj4IxsuE174i/reXAWHf06n/PM7SVpsOZDkH8Z0Q== X-Received: by 2002:a17:902:d2d0:b0:186:9e90:699 with SMTP id n16-20020a170902d2d000b001869e900699mr16241472plc.172.1667248083736; Mon, 31 Oct 2022 13:28:03 -0700 (PDT) Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id 17-20020a17090a19d100b002036006d65bsm4606935pjj.39.2022.10.31.13.28.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 31 Oct 2022 13:28:03 -0700 (PDT) Message-ID: Date: Mon, 31 Oct 2022 13:28:01 -0700 MIME-Version: 1.0 Content-Language: en-US References: <9a70f868-ca50-52fc-af3e-23813af104f2@gmail.com> <83zgdcduxm.fsf@gnu.org> <83bkpretpn.fsf@gnu.org> <837d0fepoz.fsf@gnu.org> From: Jim Porter In-Reply-To: <837d0fepoz.fsf@gnu.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 10/31/2022 12:52 PM, Eli Zaretskii wrote: >> Date: Mon, 31 Oct 2022 12:38:04 -0700 >> From: Jim Porter >> Cc: 58909@debbugs.gnu.org >> >> Still, >> 'C-x C-c' still prompts in that case too. My understanding is that it >> does so because when an application is waiting for the emacsclient to >> finish, you can't go back from killing the terminal/client; you *can* >> (usually) go back if you're only killing a frame. > > My interpretation of why "C-x C-c" prompts is that it does the same as > when you use it from a non-client frame. We want the same UX in both > cases. "C-x 5 0" should IMO likewise produce the same behavior in > both cases. That's actually my goal too: I'd like to ensure that the UX for a client frame is as similar as possible as for a non-client frame. Since we disagree on what that similarity should be, I guess that means we have different mental models for some part of this. If it helps, I'll try to explain how I think of it. From a client frame, 'C-x C-c' prompts to save all the file-buffers associated with that client, and then kills the client, which kills the frames for that client. That's similar to 'C-x C-c' in a non-client setting: it kills *all* frames and prompts to save *all* file-buffers. So I see the client as a "sub" Emacs: it owns some frames and (partially) owns some buffers. Commands on the client then work on that subset, and only that subset. Since frames can only be owned by a single client, in my mind frame commands also work within that client's subset. For frame-deletion, non-client Emacs lets you kill a single frame via 'C-x 5 0' or clicking the X in the frame's title bar. However, if it's the last frame, then: C-x 5 0 -> Error: "Attempt to delete the sole visible or iconified frame" Clicking X -> Call 'save-buffers-kill-emacs' (see 'handle-delete-frame') To me, that would mean that the matching UX for a client with a single frame (but possibly other frames for Emacs overall) is: C-x 5 0 -> Error Clicking X -> Call 'save-buffers-kill-terminal' Signaling an error for 'C-x 5 0' seems excessively strict to me, so calling 'save-buffers-kill-terminal' in both cases seemed like a good compromise to me. Instead of getting an error, the user gets a prompt, but can still proceed with killing that frame if they're sure. From unknown Sun Jun 22 08:05:01 2025 X-Loop: help-debbugs@gnu.org Subject: bug#58909: 29.0.50; [WIP PATCH] Deleting the last frame of an emacsclient doesn't ask to save Resent-From: Jim Porter Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 31 Oct 2022 21:07:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58909 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Eli Zaretskii Cc: 58909@debbugs.gnu.org Received: via spool by 58909-submit@debbugs.gnu.org id=B58909.16672503868767 (code B ref 58909); Mon, 31 Oct 2022 21:07:02 +0000 Received: (at 58909) by debbugs.gnu.org; 31 Oct 2022 21:06:26 +0000 Received: from localhost ([127.0.0.1]:42045 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1opbzG-0002HL-4L for submit@debbugs.gnu.org; Mon, 31 Oct 2022 17:06:26 -0400 Received: from mail-pl1-f179.google.com ([209.85.214.179]:34726) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1opbzD-0002H6-Ko for 58909@debbugs.gnu.org; Mon, 31 Oct 2022 17:06:24 -0400 Received: by mail-pl1-f179.google.com with SMTP id v17so8810943plo.1 for <58909@debbugs.gnu.org>; Mon, 31 Oct 2022 14:06:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to; bh=3ms3Ghlmjhv3m2dpWu/ilR/zgusZqOXJ6N8fusKh3cw=; b=I2OPz2VVt7yAhpoidri8ytEGNN7oU2+8J+0UMQcLfal/27mEFl5p9Ws6ueuFmSlp5G 7PZpAwh9MyndjT3mGoumsVThXAVTiAWT6XoVqzydLCuswNwRcAfnRUT46GJCDY0lW5Sn BzpbwmNdd0kFk8J0heTF+kFmnhs7jgp0w5DR5nXNoJEtT3YH/ZUUbmhxwfh+JerUdu27 FBIuc/yXmbkXhxNxhCS7sF3QursUbrTC2kHIE/6j3gEnp7yx/1U9A048ScNOPiJ2OeRB syVcnx1TQvwk5GfRfAyxis797lb4lSGZD/6o1Gj0gTRJ0Z9H845J0L6Nn+d4kBglpuYk VHUA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=3ms3Ghlmjhv3m2dpWu/ilR/zgusZqOXJ6N8fusKh3cw=; b=V9MxQ3nRtJ2sDLmZjNBb21MCHBrFLqs+5vEcIn1bRCU98yMWfsxlb7XDAv7/ufhqIH Ou3v1a51FsJMbQkOeideWrBhiGEwcsVrWON816PzTqXMNL7/Bz7QRzJGXGalseEkTXlc UmR1QeXARa1cMnV1mUbQ+h7iOWVAQUfWHZ2AFxNICiYp6+EpFk/aUn/uTgmurs8enTUh mnhgmXtlXL7kVjdIdDwVlnxDcEozzYLZluJF+HKQMWVSV0EpB+Wiyj0GFDhcRiXkNwQe qVydRYG8qCr4LQOxVXDX0cXjL1qnGZDc6wPpb/rMfZR2lrNow4PmqayoDfdJE4rNFDbz r5Lw== X-Gm-Message-State: ACrzQf3PKSquitUyK/+ymmkdLizrBjFnMCKgoaHkgXvyld5qQPIA9+54 RtelxN9bWjph4o583hdsRYk= X-Google-Smtp-Source: AMsMyM7C9bBshHQ8HhVrHzuEDGRZeLS3cKktVwbHjLrAWqtIWz73DRddPK/DS7G8rb2XRVHOlRANhg== X-Received: by 2002:a17:903:240a:b0:183:6555:7a89 with SMTP id e10-20020a170903240a00b0018365557a89mr16044100plo.68.1667250377749; Mon, 31 Oct 2022 14:06:17 -0700 (PDT) Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id s67-20020a625e46000000b00560cdb3784bsm5045142pfb.60.2022.10.31.14.06.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 31 Oct 2022 14:06:16 -0700 (PDT) Message-ID: <7694fcf2-8982-9099-5eb8-39835d049847@gmail.com> Date: Mon, 31 Oct 2022 14:06:16 -0700 MIME-Version: 1.0 Content-Language: en-US References: <9a70f868-ca50-52fc-af3e-23813af104f2@gmail.com> <83zgdcduxm.fsf@gnu.org> <53238b5b-3e0a-3dfe-eeba-f37cafa81f50@gmail.com> <838rkveq3n.fsf@gnu.org> <7de45884-b4c9-4a4c-777c-5db17b3bacca@gmail.com> <835yfzeobt.fsf@gnu.org> From: Jim Porter In-Reply-To: <835yfzeobt.fsf@gnu.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 10/31/2022 1:21 PM, Eli Zaretskii wrote: >> Date: Mon, 31 Oct 2022 13:01:55 -0700 >> Cc: 58909@debbugs.gnu.org >> From: Jim Porter >> >> A user might instead type "emacsclient -c file.txt" (or use "-t", etc) >> to create an all-new frame. In that case, my patch would prompt. But if >> the user is already typing "emacsclient -c file.txt", then "emacsclient >> -nc foo.txt" is just one more character, and it would make it explicit >> that the client isn't waiting around for file.txt. Then my patch would >> *not* prompt. > > Yes, this new behavior can be worked around, in more than one way. > But people get annoyed by changes which invalidate their muscle memory > of many years. So we must in each case like this to have a very good > reason for such changes, otherwise people would rightfully conclude > that our decisions are more-or-less are arbitrary and basically prefer > someone's workflows over those of others. I can definitely understand that position. It's an aspect of Emacs that I know I appreciate very much. Emacs has been around for a long time, and hopefully will be around for a lot longer. I'm not sure I have a great sense of how to balance Emacs' history with ensuring that the next decade (and more!) of Emacs is on the best footing possible. In any case, unless my other recent messages have convinced you otherwise, what do you think of the following: 1) For now, just make the change in my patch to 'delete-frame' in src/frame.c to allow hooks in 'delete-frame-functions' to quit out of frame deletion. That way, users who want the rest of the behavior in my patch can just replace 'server-handle-delete-frame' with their own Elisp function. This change isn't entirely without risk, since it could cause some hooks to go from silently signaling an error to making it impossible to delete frames, but I'm not sure that will come up in practice (and if it does, the hooks can be fixed easily enough). 2) After the Emacs 29 branch is cut, maybe (emphasis on maybe) discuss the changes to prompting on emacs-devel, and possibly even commit it to the master branch with the caveat that if it causes problems for anyone, we back it out. Obviously not everyone follows emacs-devel, but this would give people a chance to provide feedback, positive or negative. From unknown Sun Jun 22 08:05:01 2025 X-Loop: help-debbugs@gnu.org Subject: bug#58909: 29.0.50; [WIP PATCH] Deleting the last frame of an emacsclient doesn't ask to save Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 01 Nov 2022 06:18:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58909 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Jim Porter Cc: 58909@debbugs.gnu.org Received: via spool by 58909-submit@debbugs.gnu.org id=B58909.166728344730567 (code B ref 58909); Tue, 01 Nov 2022 06:18:01 +0000 Received: (at 58909) by debbugs.gnu.org; 1 Nov 2022 06:17:27 +0000 Received: from localhost ([127.0.0.1]:42513 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1opkaU-0007wx-UR for submit@debbugs.gnu.org; Tue, 01 Nov 2022 02:17:27 -0400 Received: from eggs.gnu.org ([209.51.188.92]:53068) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1opkaT-0007wk-MC for 58909@debbugs.gnu.org; Tue, 01 Nov 2022 02:17:25 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1opkaO-00075j-8G; Tue, 01 Nov 2022 02:17:20 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=U37Xu2NVqu5RsHjXyjJ3Y5y2RpJnksUbN/PMjf52Y4g=; b=dUjj5wWGsl3x pU8FjEmxRH6MhmVO7zmGAfU7r2kIhSjggdIhcHPUsa96WCIwi17Lqeh8AnSb5yaq1ZH9VzxBvQGv6 S6Xk6VXJ7hvN7Fkc7IXXktF8ZHZKirTW8CL0t3hEGrBZKe3sQZsGG8CsyfAj5Uj0TgJm8yMb6ia7R hVsNbZbsW74kRwb+O0AP6HTkl2R/bDYSxMnenRtkep9C+F+VNliG0VUHj75bf/oUZ93jyqhACDEa0 aRTL2uUExcIHnX9Mf8jMojE0oKPk9APhb+o/XPT1NgKkHXRTrtnJ/9vSOCd8BsQFBRxZfcfRYXHKC Fc0oVtppDFEKOidWM8fPWg==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1opkaN-0007BM-IB; Tue, 01 Nov 2022 02:17:19 -0400 Date: Tue, 01 Nov 2022 08:17:06 +0200 Message-Id: <8335b3dwrh.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: (message from Jim Porter on Mon, 31 Oct 2022 13:28:01 -0700) References: <9a70f868-ca50-52fc-af3e-23813af104f2@gmail.com> <83zgdcduxm.fsf@gnu.org> <83bkpretpn.fsf@gnu.org> <837d0fepoz.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Mon, 31 Oct 2022 13:28:01 -0700 > Cc: 58909@debbugs.gnu.org > From: Jim Porter > > > My interpretation of why "C-x C-c" prompts is that it does the same as > > when you use it from a non-client frame. We want the same UX in both > > cases. "C-x 5 0" should IMO likewise produce the same behavior in > > both cases. > > That's actually my goal too: I'd like to ensure that the UX for a client > frame is as similar as possible as for a non-client frame. Since we > disagree on what that similarity should be, I guess that means we have > different mental models for some part of this. If it helps, I'll try to > explain how I think of it. Thanks. Our notions of "similarity" are different. For me, it's the immediate effect of the command; for you, it's what happens in Emacs under the hood, in particular how many other "similar" frames remain. From unknown Sun Jun 22 08:05:01 2025 X-Loop: help-debbugs@gnu.org Subject: bug#58909: 29.0.50; [WIP PATCH] Deleting the last frame of an emacsclient doesn't ask to save Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 01 Nov 2022 06:40:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58909 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Jim Porter Cc: 58909@debbugs.gnu.org Received: via spool by 58909-submit@debbugs.gnu.org id=B58909.166728479232601 (code B ref 58909); Tue, 01 Nov 2022 06:40:01 +0000 Received: (at 58909) by debbugs.gnu.org; 1 Nov 2022 06:39:52 +0000 Received: from localhost ([127.0.0.1]:42526 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1opkw9-0008Th-BN for submit@debbugs.gnu.org; Tue, 01 Nov 2022 02:39:52 -0400 Received: from eggs.gnu.org ([209.51.188.92]:51610) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1opkw7-0008TU-KG for 58909@debbugs.gnu.org; Tue, 01 Nov 2022 02:39:47 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1opkw1-00070j-6W; Tue, 01 Nov 2022 02:39:41 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=XUI3bjSQ1JbVaAiD2rebCxFgHj0+bnr8TpPIh7afavA=; b=QhfFpPUlI7AA GOEL/TBs6i4go5X54fl0150ylQAB6XidRFXwjuoUea2i0eDEpm8li8yPCgnZ6J+wi6cESZwAwzPPu 0eSA/h1v/Dani2Wa5jP1/RTWxLwPj8EGi9hFbq7EYSVSAKy5qMCCl0Zvyt+5V5/zA9Ytn5k8ZeXG1 LJa/c94YHgwIoATyHD2bgpAMQExmlcxQniRONjhj4YAlsTMcvSvLtVFBeA6ACE5Z61g01zBN3g4dv t/GYejI1k9UKrxV0f+4hNVQiVXhEH8nDTPwMRVZsx9isiwViz6VI+lVVHdpjFtDZQxBjeYv5HzRaz RKLAT6wZI/YYhU/PZgNgOQ==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1opkvz-0006Ap-En; Tue, 01 Nov 2022 02:39:39 -0400 Date: Tue, 01 Nov 2022 08:39:25 +0200 Message-Id: <83y1svch5u.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: <7694fcf2-8982-9099-5eb8-39835d049847@gmail.com> (message from Jim Porter on Mon, 31 Oct 2022 14:06:16 -0700) References: <9a70f868-ca50-52fc-af3e-23813af104f2@gmail.com> <83zgdcduxm.fsf@gnu.org> <53238b5b-3e0a-3dfe-eeba-f37cafa81f50@gmail.com> <838rkveq3n.fsf@gnu.org> <7de45884-b4c9-4a4c-777c-5db17b3bacca@gmail.com> <835yfzeobt.fsf@gnu.org> <7694fcf2-8982-9099-5eb8-39835d049847@gmail.com> X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Mon, 31 Oct 2022 14:06:16 -0700 > Cc: 58909@debbugs.gnu.org > From: Jim Porter > > 1) For now, just make the change in my patch to 'delete-frame' in > src/frame.c to allow hooks in 'delete-frame-functions' to quit out of > frame deletion. That way, users who want the rest of the behavior in my > patch can just replace 'server-handle-delete-frame' with their own Elisp > function. This change isn't entirely without risk, since it could cause > some hooks to go from silently signaling an error to making it > impossible to delete frames, but I'm not sure that will come up in > practice (and if it does, the hooks can be fixed easily enough). I don't see how this would serve well the use case you want to enable. We are talking about prompting the user to save unsaved buffers, yes? So adding a hook in server-delete-client sounds like a much better solution to me, as it doesn't affect the (much more general) delete-frame in any way. > 2) After the Emacs 29 branch is cut, maybe (emphasis on maybe) discuss > the changes to prompting on emacs-devel, and possibly even commit it to > the master branch with the caveat that if it causes problems for anyone, > we back it out. Obviously not everyone follows emacs-devel, but this > would give people a chance to provide feedback, positive or negative. You can start the discussion now, from my POV. But if having a hook in server-delete-client is good enough, I don't see why we would need to discuss an actual behavior change. (And the proviso of backing out changes doesn't work in this project, IME: people get defensive about their changes, and perceive reverting them as personal insult. So we do that only in very extreme cases.) From unknown Sun Jun 22 08:05:01 2025 X-Loop: help-debbugs@gnu.org Subject: bug#58909: 29.0.50; [WIP PATCH] Deleting the last frame of an emacsclient doesn't ask to save Resent-From: Jim Porter Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 01 Nov 2022 16:12:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58909 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Eli Zaretskii Cc: 58909@debbugs.gnu.org Received: via spool by 58909-submit@debbugs.gnu.org id=B58909.16673191101088 (code B ref 58909); Tue, 01 Nov 2022 16:12:01 +0000 Received: (at 58909) by debbugs.gnu.org; 1 Nov 2022 16:11:50 +0000 Received: from localhost ([127.0.0.1]:44067 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1optrh-0000HU-Eb for submit@debbugs.gnu.org; Tue, 01 Nov 2022 12:11:49 -0400 Received: from mail-pf1-f178.google.com ([209.85.210.178]:40866) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1optrf-0000HG-Ac for 58909@debbugs.gnu.org; Tue, 01 Nov 2022 12:11:47 -0400 Received: by mail-pf1-f178.google.com with SMTP id y13so13880443pfp.7 for <58909@debbugs.gnu.org>; Tue, 01 Nov 2022 09:11:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to; bh=utqA4ISbWGl45yR/IPhYCYfp1heNQLwY17UMC4oTTj0=; b=NndV+GTAYAplRmjx5kJlm22tbqUb/kexg7gnCPlFFVsB6TwTnmnIKVYW3ECwkqn8SB nDVDa4LmRIIMFHmWp8Ga+Z+fP8HycSuXcB/EZI90iG0vGvgScj+0zxE2OJF//jlTKxPB T7wS/d5KEzeS8Pq2BKX2LIUcVJQabGw0/3uv7CG1L6dq8c6skOlf0de2Xoz0B7x59Nn5 s7LlsDys4VLnF/uAl1DGvypmCS5FHB/AP4cdB2fFWiAWOjqXqUmwPlWqeeshlalUVcBX +w1xLqbsPd5cixlbWIlomfmI6v5eeBXRUNnwS0m5GDTjMe6pgOB2n9OaaxXc4wVHRmsr U6gw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=utqA4ISbWGl45yR/IPhYCYfp1heNQLwY17UMC4oTTj0=; b=C0kl1185SYHnKMh+/btbw9jIQPkMdpDcI+8q4XrSXaBtvHBZsXgHpdeOJyIL/Cv/v6 o+nfwXLFs8YNIOpwn/6UEJVAFl/FVnVYDW8WTa67NtfNdg+QjCYwP2hDpLHegGd5E6Zx 9nC+Hh9By9V3EPHar6jWu5hJmx2yTI9OGOncud1oQy3jkBWlaPOwl9np9Uv8uchHzTo1 q/MOFrqA6Db36ELmG4CkMZeMyoT1iXS+lbizZj9t1M0SRNMM+oXthATK20dvAubQ4A0i vRLZv4ejNxW0PI7YdYGs2X51RhyEsbEpM41xQEbfNPUcf9TO+qkpBNzB+th7S4HAT1FX 93wQ== X-Gm-Message-State: ACrzQf0kE20UOLg57XKTFcHXcVIVfIZjid01Z+7CzM1mJZPpC5+1xgEB S9qDLbBUBZR0TOP/aiPA7FfMWnWumw8= X-Google-Smtp-Source: AMsMyM5R+a8MY0hMr8I036AQqF+20mDhmEfqV2yIGEkiMEXmU44MX7AkQXcWYtUqRHnkHBbtV8JfNw== X-Received: by 2002:a63:7252:0:b0:46f:9763:7355 with SMTP id c18-20020a637252000000b0046f97637355mr14090383pgn.542.1667319101428; Tue, 01 Nov 2022 09:11:41 -0700 (PDT) Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id m12-20020a170902db0c00b0018725c2fc46sm3604399plx.303.2022.11.01.09.11.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 01 Nov 2022 09:11:40 -0700 (PDT) Message-ID: Date: Tue, 1 Nov 2022 09:11:40 -0700 MIME-Version: 1.0 Content-Language: en-US References: <9a70f868-ca50-52fc-af3e-23813af104f2@gmail.com> <83zgdcduxm.fsf@gnu.org> <53238b5b-3e0a-3dfe-eeba-f37cafa81f50@gmail.com> <838rkveq3n.fsf@gnu.org> <7de45884-b4c9-4a4c-777c-5db17b3bacca@gmail.com> <835yfzeobt.fsf@gnu.org> <7694fcf2-8982-9099-5eb8-39835d049847@gmail.com> <83y1svch5u.fsf@gnu.org> From: Jim Porter In-Reply-To: <83y1svch5u.fsf@gnu.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 10/31/2022 11:39 PM, Eli Zaretskii wrote: >> Date: Mon, 31 Oct 2022 14:06:16 -0700 >> Cc: 58909@debbugs.gnu.org >> From: Jim Porter >> >> 1) For now, just make the change in my patch to 'delete-frame' in >> src/frame.c to allow hooks in 'delete-frame-functions' to quit out of >> frame deletion. That way, users who want the rest of the behavior in my >> patch can just replace 'server-handle-delete-frame' with their own Elisp >> function. This change isn't entirely without risk, since it could cause >> some hooks to go from silently signaling an error to making it >> impossible to delete frames, but I'm not sure that will come up in >> practice (and if it does, the hooks can be fixed easily enough). > > I don't see how this would serve well the use case you want to enable. > We are talking about prompting the user to save unsaved buffers, yes? > So adding a hook in server-delete-client sounds like a much better > solution to me, as it doesn't affect the (much more general) > delete-frame in any way. I think a hook on 'server-delete-client' could work well. It'd make it easier to write hooks that run at the right time compared to using other existing hooks. In fact, I had a similar idea for bug#51993[1]. In that case I ended up adding 2 hooks to 'server-delete-client', but that was just to work around a strange bug I saw in testing; I could probably fix that in a better way with some more effort so that we only need one new hook. However, I'm not sure how to do this in a complete way without tweaking 'delete-frame-functions'. Deleting a frame can cause Emacs to delete the client if that was the last frame for the client; that's long-established behavior, so we shouldn't change it. But that poses a problem. If 1) I delete a frame, 2) it calls 'server-delete-client', and 3) some 'server-delete-client-hook' prompts me, then I might try to quit out via C-g. Without my change to how 'delete-frame-functions' are run, then C-g would only quit out of 'server-delete-client', but would still delete the frame. At least for some emacsclient use cases, that could be a problem. For example, suppose I have a system called "remotehost" with an "emacs --daemon" instance and EDITOR="emacsclient -c": me@localhost $ ssh -X remotehost ... me@remotehost $ git commit ;; emacsclient starts and creates a new frame on my local display. ;; Start editing the git commit message. ;; Get distracted, do some other stuff... ;; ... finish up the other stuff, click "X" on the emacsclient frame. Save file /home/me/src/project/.git/COMMIT_EDITMSG? ;; Realize, "Oh yeah! I forgot to finish this commit message." C-g Without the 'delete-frame-functions' change, I'd now be left with no Emacs frames on my localhost, but the emacsclient is still running. That would be inconvenient, since I'd have to do more work to fix the situation. The best way I can think of would be to start another emacsclient locally, do the edits to COMMIT_EDITMSG, and then 'C-x #' to finish editing. It'd be a lot nicer if 'C-g' stopped the frame from getting deleted. (Incidentally, that's how it would work in a regular, non-client/server Emacs. Clicking "X" on the last frame actually calls 'save-buffer-kill-emacs' instead of 'delete-frame', and you can 'C-g' out of that to keep the frame open.) > You can start the discussion now, from my POV. But if having a hook > in server-delete-client is good enough, I don't see why we would need > to discuss an actual behavior change. Yeah, let's finish up the discussion here, and if I have any open questions that could use a wider audience, I'll post to emacs-devel afterwards. [1] https://lists.gnu.org/archive/html/bug-gnu-emacs/2022-10/msg00908.html From unknown Sun Jun 22 08:05:01 2025 X-Loop: help-debbugs@gnu.org Subject: bug#58909: 29.0.50; [WIP PATCH] Deleting the last frame of an emacsclient doesn't ask to save Resent-From: Jim Porter Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 01 Nov 2022 22:40:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58909 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Eli Zaretskii Cc: 58909@debbugs.gnu.org Received: via spool by 58909-submit@debbugs.gnu.org id=B58909.166734238023132 (code B ref 58909); Tue, 01 Nov 2022 22:40:02 +0000 Received: (at 58909) by debbugs.gnu.org; 1 Nov 2022 22:39:40 +0000 Received: from localhost ([127.0.0.1]:44404 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1opzv2-000612-6J for submit@debbugs.gnu.org; Tue, 01 Nov 2022 18:39:40 -0400 Received: from mail-pj1-f48.google.com ([209.85.216.48]:55127) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1opzv0-00060i-Hv for 58909@debbugs.gnu.org; Tue, 01 Nov 2022 18:39:38 -0400 Received: by mail-pj1-f48.google.com with SMTP id h14so14547599pjv.4 for <58909@debbugs.gnu.org>; Tue, 01 Nov 2022 15:39:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:references:cc:to:from:content-language:subject :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=evKgme73iBkIjVn+nCEu7uKELc/ETaLpi2Mxs6Wg7ng=; b=OmQr5PnGz4omaq3CdsRNHKixWMYSDQrZKU2u6cXi0N9PuRxwmr7kZSsBOTrwG6Pnio LbhQIJOMmbVl2FoSNsEHzNv9lAt3fiGmkmk+3OdHuCddrgLB9FYh9xa7Kje2awcI8QaS z3e2E30WUH/2HygT5qqBmcxPHihL8ed+ZD4cNSsb0iqpvNK6Pko9iBOkf6ZkGz8kVOCU /6sNBgNa9Eur1tnw6AuuLMenfJugerVnNsrV9hQcX2+CFIQR85LnR4XmqHBuZNIoUxl8 OVPcyq5d4C8bSCgC1Zzn/Ml1Z6ODqGLO7PPRgmgGoVAMC2Ehn7nl0MkSVrsFm93n1Eo+ I32g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:references:cc:to:from:content-language:subject :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=evKgme73iBkIjVn+nCEu7uKELc/ETaLpi2Mxs6Wg7ng=; b=fv1u908UvSenvOOvHMHHboX8pkILMZ8cxb1c2fOZDx94PISby/zIvJryoAPerR9mYB nW6gb/Jc3kJsQ2URMB6dWTjShRjtq5MDfTguixKHpgwAdRkE2s2wyES5LsoqxtPnxRyB 3I5eX0RIzQ9Ou+OFhRIZpFU+J76uQ4Sn9w+N8urVGI+fswMWv3KmENLv2ZwKE/vLWbRy lUq7xq8H1mQfgyPN0S6eTu6gyHFX2eqk6ymizdu27WeIyldxEkPcks3aF5xDK5UZqqku pWokpyXxlEU8WJazRdTUnzO7bJLgcNc7TpxXzPjBWWa4UfnUGRGvjsX0SOubm017ivze ll4w== X-Gm-Message-State: ACrzQf1BW68w0EgtEycovf+K77e3o59w4deTwAsUILEboPjOe77N/gdf OYveCJZ/aSq4NQCMEl8OtOY= X-Google-Smtp-Source: AMsMyM6/ukysvZ+eSH2mF1GfVoXKoNOW0veDUSeIqrDKRFOt7NX6XtuvhHpxG912OJnIlWEki7u8EA== X-Received: by 2002:a17:902:9a07:b0:178:8024:1393 with SMTP id v7-20020a1709029a0700b0017880241393mr21705300plp.128.1667342372428; Tue, 01 Nov 2022 15:39:32 -0700 (PDT) Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id a19-20020aa79713000000b0056b3c863950sm7062897pfg.8.2022.11.01.15.39.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 01 Nov 2022 15:39:31 -0700 (PDT) Content-Type: multipart/mixed; boundary="------------Rbi4e1m0rLHYKzgxzaYbA2os" Message-ID: <0dc07894-dfa1-01f6-87c4-9e02bfcaf0dc@gmail.com> Date: Tue, 1 Nov 2022 15:39:29 -0700 MIME-Version: 1.0 Content-Language: en-US From: Jim Porter References: <9a70f868-ca50-52fc-af3e-23813af104f2@gmail.com> <83zgdcduxm.fsf@gnu.org> <53238b5b-3e0a-3dfe-eeba-f37cafa81f50@gmail.com> <838rkveq3n.fsf@gnu.org> <7de45884-b4c9-4a4c-777c-5db17b3bacca@gmail.com> <835yfzeobt.fsf@gnu.org> <7694fcf2-8982-9099-5eb8-39835d049847@gmail.com> <83y1svch5u.fsf@gnu.org> In-Reply-To: X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) This is a multi-part message in MIME format. --------------Rbi4e1m0rLHYKzgxzaYbA2os Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 11/1/2022 9:11 AM, Jim Porter wrote: > However, I'm not sure how to do this in a complete way without tweaking > 'delete-frame-functions'. ... Attached is a (hopefully) safer version of my change to 'delete-frame'. In this patch, a hook can only cancel frame deletion if FORCE is non-nil. This way, if there were ever some bug with a hook, you (or some code) can still force-delete the frame. This would probably still need a NEWS entry, but I'm personally less worried about this change compared to my previous revision. What do you think? --------------Rbi4e1m0rLHYKzgxzaYbA2os Content-Type: text/plain; charset=UTF-8; name="0001-Let-delete-frame-functions-quit-out-of-frame-deletio.patch" Content-Disposition: attachment; filename*0="0001-Let-delete-frame-functions-quit-out-of-frame-deletio.pa"; filename*1="tch" Content-Transfer-Encoding: base64 RnJvbSBlYTdhNmZmNTQxY2NmYWU0NzRmMzJmZmExZGVkZDM2NjdlZGU2M2I3IE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKaW0gUG9ydGVyIDxqcG9ydGVyYnVnc0BnbWFpbC5j b20+CkRhdGU6IFR1ZSwgMSBOb3YgMjAyMiAxNToyODoxOCAtMDcwMApTdWJqZWN0OiBbUEFU Q0hdIExldCAnZGVsZXRlLWZyYW1lLWZ1bmN0aW9ucycgcXVpdCBvdXQgb2YgZnJhbWUgZGVs ZXRpb24gaWYKIEZPUkNFIGlzIG5pbAoKKiBzcmMvZnJhbWUuYyAoZGVsZXRlX2ZyYW1lKTog V2hlbiBGT1JDRSBpcyBuaWwsIGNhbGwKJ2RlbGV0ZS1mcmFtZS1mdW5jdGlvbnMnIHdpdGgg J2NhbGwyJyBpbnN0ZWFkIG9mICdzYWZlX2NhbGwyJyB0byBhbGxvdwpob29rcyB0byBxdWl0 IG91dC4KLS0tCiBzcmMvZnJhbWUuYyB8IDYgKysrKystCiAxIGZpbGUgY2hhbmdlZCwgNSBp bnNlcnRpb25zKCspLCAxIGRlbGV0aW9uKC0pCgpkaWZmIC0tZ2l0IGEvc3JjL2ZyYW1lLmMg Yi9zcmMvZnJhbWUuYwppbmRleCBmMDc2YTViYTU0Li45NzIyZWZhNTA1IDEwMDY0NAotLS0g YS9zcmMvZnJhbWUuYworKysgYi9zcmMvZnJhbWUuYwpAQCAtMjAzNyw3ICsyMDM3LDExIEBA IGRlbGV0ZV9mcmFtZSAoTGlzcF9PYmplY3QgZnJhbWUsIExpc3BfT2JqZWN0IGZvcmNlKQog ICAgICAgeF9jbGlwYm9hcmRfbWFuYWdlcl9zYXZlX2ZyYW1lIChmcmFtZSk7CiAjZW5kaWYK IAotICAgICAgc2FmZV9jYWxsMiAoUXJ1bl9ob29rX3dpdGhfYXJncywgUWRlbGV0ZV9mcmFt ZV9mdW5jdGlvbnMsIGZyYW1lKTsKKyAgICAgIC8qIElmIEZPUkNFIGlzIG5pbCwgYWxsb3cg aG9va3MgdG8gcXVpdCBvdXQgb2YgZnJhbWUgZGVsZXRpb24uICAqLworICAgICAgaWYgKE5J TFAgKGZvcmNlKSkKKwljYWxsMiAoUXJ1bl9ob29rX3dpdGhfYXJncywgUWRlbGV0ZV9mcmFt ZV9mdW5jdGlvbnMsIGZyYW1lKTsKKyAgICAgIGVsc2UKKwlzYWZlX2NhbGwyIChRcnVuX2hv b2tfd2l0aF9hcmdzLCBRZGVsZXRlX2ZyYW1lX2Z1bmN0aW9ucywgZnJhbWUpOwogICAgIH0K IAogICAvKiBkZWxldGVfZnJhbWVfZnVuY3Rpb25zIG1heSBoYXZlIGRlbGV0ZWQgYW55IGZy YW1lLCBpbmNsdWRpbmcgdGhpcwotLSAKMi4yNS4xCgo= --------------Rbi4e1m0rLHYKzgxzaYbA2os-- From unknown Sun Jun 22 08:05:01 2025 X-Loop: help-debbugs@gnu.org Subject: bug#58909: 29.0.50; [WIP PATCH] Deleting the last frame of an emacsclient doesn't ask to save Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 02 Nov 2022 12:17:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58909 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Jim Porter Cc: 58909@debbugs.gnu.org Received: via spool by 58909-submit@debbugs.gnu.org id=B58909.16673913829205 (code B ref 58909); Wed, 02 Nov 2022 12:17:01 +0000 Received: (at 58909) by debbugs.gnu.org; 2 Nov 2022 12:16:22 +0000 Received: from localhost ([127.0.0.1]:45078 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oqCfO-0002OP-12 for submit@debbugs.gnu.org; Wed, 02 Nov 2022 08:16:22 -0400 Received: from eggs.gnu.org ([209.51.188.92]:38032) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oqCfM-0002OE-RA for 58909@debbugs.gnu.org; Wed, 02 Nov 2022 08:16:21 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oqCfH-0005Jp-Iv; Wed, 02 Nov 2022 08:16:15 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=7ti80OOSr5mCm4wZDvWv6jL42Z9d6Yqu7yQLFAmREnM=; b=FGdsBeiqK0VC BzCGnIOS/pOh6kekqbwRGD831T0gf0JLTvzsJcZjRtkDqWBzXA2Tci4ozkRyd04WnDbtvbQ41B+mN uDWAlIyx66WDd+Lsa55aAdo9KrjM7Ki9/LnCj8+1eAjOqw54ac9jWitRPMViAzYFVazPJSu9nAhUG kc1RVdtTHSw+hpKXcSB3EWwUEw9I+OfeQ1vElmR2buT6zseueQOad7J334RCMEv1IC+603PhD+szk H8Xf0tzRlyjPnYgfCNKhjeMO36X8Q8adlYKnmdK7a3LmtdXdkLmnK/1zN6F+a4aWTeVeH4LPnS7Ci R4+Xja41OWIt68QcxfnI3A==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oqCfG-0002tF-Eh; Wed, 02 Nov 2022 08:16:14 -0400 Date: Wed, 02 Nov 2022 14:16:04 +0200 Message-Id: <83bkppblh7.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: <0dc07894-dfa1-01f6-87c4-9e02bfcaf0dc@gmail.com> (message from Jim Porter on Tue, 1 Nov 2022 15:39:29 -0700) References: <9a70f868-ca50-52fc-af3e-23813af104f2@gmail.com> <83zgdcduxm.fsf@gnu.org> <53238b5b-3e0a-3dfe-eeba-f37cafa81f50@gmail.com> <838rkveq3n.fsf@gnu.org> <7de45884-b4c9-4a4c-777c-5db17b3bacca@gmail.com> <835yfzeobt.fsf@gnu.org> <7694fcf2-8982-9099-5eb8-39835d049847@gmail.com> <83y1svch5u.fsf@gnu.org> <0dc07894-dfa1-01f6-87c4-9e02bfcaf0dc@gmail.com> X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Tue, 1 Nov 2022 15:39:29 -0700 > From: Jim Porter > Cc: 58909@debbugs.gnu.org > > Attached is a (hopefully) safer version of my change to 'delete-frame'. > In this patch, a hook can only cancel frame deletion if FORCE is > non-nil. This way, if there were ever some bug with a hook, you (or some > code) can still force-delete the frame. Sorry, but I still don't like this. We currently call this hook via safe_call because we don't want to let the hook prevent the deletion of the frame. I prefer to solve this in server.el, not in lower-level primitives. From unknown Sun Jun 22 08:05:01 2025 X-Loop: help-debbugs@gnu.org Subject: bug#58909: 29.0.50; [WIP PATCH] Deleting the last frame of an emacsclient doesn't ask to save Resent-From: Jim Porter Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 02 Nov 2022 16:38:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58909 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Eli Zaretskii Cc: 58909@debbugs.gnu.org Received: via spool by 58909-submit@debbugs.gnu.org id=B58909.166740703112977 (code B ref 58909); Wed, 02 Nov 2022 16:38:01 +0000 Received: (at 58909) by debbugs.gnu.org; 2 Nov 2022 16:37:11 +0000 Received: from localhost ([127.0.0.1]:47059 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oqGjn-0003NF-1Q for submit@debbugs.gnu.org; Wed, 02 Nov 2022 12:37:11 -0400 Received: from mail-pf1-f180.google.com ([209.85.210.180]:42526) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oqGjb-0003Mb-4P for 58909@debbugs.gnu.org; Wed, 02 Nov 2022 12:37:10 -0400 Received: by mail-pf1-f180.google.com with SMTP id b185so16887426pfb.9 for <58909@debbugs.gnu.org>; Wed, 02 Nov 2022 09:36:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:from:references:cc:to:content-language:subject :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=OdGdMGsxUq4SsLsIYqyLT8dKQaaPZOE7kXidScdWJmk=; b=FriPQCSHLaOwEZ3AHMAeCbRbDBuLB+DfNs6R5TuyB8vpN/RSy0J3RlgFkTsypKRP47 qZfGei5N0bLZCUCuRoHS25KIvYVXjotdMCfq0zF6HO4cDgSexFFVrNht1eOOOyWCCqF6 vzRFzzlIhb5S2YVkArX4SNzpmXhiGWypA7BFiDixRrYY9VVXNAw6fPo/MGEDipGRH3+6 mcc6suFZmve3gugyFJHe6SZpEtHbcbDpgTCXhNZCXHRLcOS6VI3zCEuuM5z8CkF1mBJU c9VFhv2u3r0hDHknbyFsZUatSxIPN0LAiYjTv91+1R309+X2dTYgTc35pTZcQuPrbNlG FTLw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:from:references:cc:to:content-language:subject :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=OdGdMGsxUq4SsLsIYqyLT8dKQaaPZOE7kXidScdWJmk=; b=diX0tIQvKOuAJE8swMlhIlPmwj26MKEBHanNEuM06w/DRN2bX+eH2+XKQ42Fs4Z4Lt d8/LIB8zEpJVQMnxH3p18X+fRadlnpFHBLTyDIw1K5HHcy/jrgWKcOYz9XUKj4eVhq5Y HSXCCH8JniE5rRilf9gWk/jSMIHMKQp2D/oXbBxSlSocIUOE5SY9vxPTw/RoobGXcDrI 4SiwtDaVeUPCICxIrcd/u8yCEl+3gux+u3aiYHRg3OaqWq1rqzmHYoFa/94+m8/vnQV6 BIXI79oRhd/ELe+X4ihvYPIY8BYrI4pm7fLNIEK+5/8a/qPi3tcRcn0XO21CrSaTWNwO NaLg== X-Gm-Message-State: ACrzQf17xh5Kbt4E4rNwh8C43obbEOBNvbyLprBwcADOnqL2PxKKHaGJ H/EGCnYZ3a5kBYgEG8UIxUqUJRMARCs= X-Google-Smtp-Source: AMsMyM62mkdZCnPBafWPmM3UeTAnG7cDrmuEvD/anzQ7A4OYmhY1mbZuAc1C5hDr5K89IgKyREroeA== X-Received: by 2002:a63:ff5a:0:b0:42c:61f:b81 with SMTP id s26-20020a63ff5a000000b0042c061f0b81mr22490091pgk.254.1667407012924; Wed, 02 Nov 2022 09:36:52 -0700 (PDT) Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id z184-20020a6233c1000000b0056c47a5c34dsm8667502pfz.122.2022.11.02.09.36.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 02 Nov 2022 09:36:51 -0700 (PDT) Content-Type: multipart/mixed; boundary="------------qlARUBNhtTsCxdvPZv0SDD6R" Message-ID: Date: Wed, 2 Nov 2022 09:36:52 -0700 MIME-Version: 1.0 Content-Language: en-US References: <9a70f868-ca50-52fc-af3e-23813af104f2@gmail.com> <83zgdcduxm.fsf@gnu.org> <53238b5b-3e0a-3dfe-eeba-f37cafa81f50@gmail.com> <838rkveq3n.fsf@gnu.org> <7de45884-b4c9-4a4c-777c-5db17b3bacca@gmail.com> <835yfzeobt.fsf@gnu.org> <7694fcf2-8982-9099-5eb8-39835d049847@gmail.com> <83y1svch5u.fsf@gnu.org> <0dc07894-dfa1-01f6-87c4-9e02bfcaf0dc@gmail.com> <83bkppblh7.fsf@gnu.org> From: Jim Porter In-Reply-To: <83bkppblh7.fsf@gnu.org> X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) This is a multi-part message in MIME format. --------------qlARUBNhtTsCxdvPZv0SDD6R Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 11/2/2022 5:16 AM, Eli Zaretskii wrote: >> Date: Tue, 1 Nov 2022 15:39:29 -0700 >> From: Jim Porter >> Cc: 58909@debbugs.gnu.org >> >> Attached is a (hopefully) safer version of my change to 'delete-frame'. >> In this patch, a hook can only cancel frame deletion if FORCE is >> non-nil. This way, if there were ever some bug with a hook, you (or some >> code) can still force-delete the frame. > > Sorry, but I still don't like this. We currently call this hook via > safe_call because we don't want to let the hook prevent the deletion > of the frame. > > I prefer to solve this in server.el, not in lower-level primitives. Hm, ok. That means I'd need to make sure 'C-x 5 0' calls something other than 'delete-frame', so that I could add a prompt to it that can prevent deletion of the frame. Two questions then: 1. If 'delete-frame' is a lower-level primitive, should 'C-x 5 0' call it directly, or should there be a higher-level function for it to call? If we had some higher-level function, then user-level commands could call that, but low-level code could still use 'delete-frame'. This user-level command would then be able to run some hook that can prevent deletion of the frame. 2. Since server.el has a minor mode (unsurprisingly named 'server-mode'), maybe one option is to do command remapping. If we remap 'delete-frame' to some new 'server-delete-frame' when 'server-mode' is active, then this should work. See attached for a quick sketch of how this would look. What do you think about one of these? --------------qlARUBNhtTsCxdvPZv0SDD6R Content-Type: text/plain; charset=UTF-8; name="0001-WIP-Try-using-a-keymap-for-server-mode.patch" Content-Disposition: attachment; filename="0001-WIP-Try-using-a-keymap-for-server-mode.patch" Content-Transfer-Encoding: base64 RnJvbSAyY2U5OTRkZTEyNGI3NjA5MDg5OTIzMDkwMjAxY2JiNzdmYTAzNWJjIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKaW0gUG9ydGVyIDxqcG9ydGVyYnVnc0BnbWFpbC5j b20+CkRhdGU6IFdlZCwgMiBOb3YgMjAyMiAwOToyMjo0MyAtMDcwMApTdWJqZWN0OiBbUEFU Q0hdIFtXSVBdIFRyeSB1c2luZyBhIGtleW1hcCBmb3Igc2VydmVyLW1vZGUKCi0tLQogbGlz cC9zZXJ2ZXIuZWwgfCAxNyArKysrKysrKysrKysrKysrKwogMSBmaWxlIGNoYW5nZWQsIDE3 IGluc2VydGlvbnMoKykKCmRpZmYgLS1naXQgYS9saXNwL3NlcnZlci5lbCBiL2xpc3Avc2Vy dmVyLmVsCmluZGV4IDkwZDk3YzE1MzguLmM4ZjkwNzIwZjcgMTAwNjQ0Ci0tLSBhL2xpc3Av c2VydmVyLmVsCisrKyBiL2xpc3Avc2VydmVyLmVsCkBAIC03OTYsNiArNzk2LDE4IEBAIHNl cnZlci1ydW5uaW5nLXAKIAl0KQogICAgIChmaWxlLWVycm9yIG5pbCkpKQogCisoZGVmdmFy LWtleW1hcCBzZXJ2ZXIta2V5bWFwCisgICI8cmVtYXA+IDxkZWxldGUtZnJhbWU+IiAjJ3Nl cnZlci1kZWxldGUtZnJhbWUKKyAgOzsgRklYTUU6IEFkZCAnQy14ICMnIHRvIHRoaXMga2V5 bWFwIGluc3RlYWQgb2YgZG9pbmcgaXQgZ2xvYmFsbHk/CisgICkKKworKGRlZnVuIHNlcnZl ci1kZWxldGUtZnJhbWUgKCkKKyAgIkZJWE1FOiBUaGlzIGZ1bmN0aW9uIGlzIGp1c3QgYSBx dWljayB0ZXN0IGltcGxlbWVudGF0aW9uIHRvCitvdmVycmlkZSBgZGVsZXRlLWZyYW1lJy4i CisgIChpbnRlcmFjdGl2ZSkKKyAgKHNhdmUtc29tZS1idWZmZXJzKQorICAoZGVsZXRlLWZy YW1lKSkKKwogOzs7IyMjYXV0b2xvYWQKIChkZWZpbmUtbWlub3ItbW9kZSBzZXJ2ZXItbW9k ZQogICAiVG9nZ2xlIFNlcnZlciBtb2RlLgpAQCAtODA1LDYgKzgxNywxMSBAQCBzZXJ2ZXIt bW9kZQogYHNlcnZlci1zdGFydCcgZm9yIGRldGFpbHMuIgogICA6Z2xvYmFsIHQKICAgOnZl cnNpb24gIjIyLjEiCisgIDs7IEZJWE1FOiBUbyBzdGFydCBhIHNlcnZlciwgeW91IGNhbiBj YWxsIGBzZXJ2ZXItbW9kZScgb3IKKyAgOzsgYHNlcnZlci1zdGFydCcuICBUaGUgbGF0dGVy IGRvZXNuJ3QgYWN0aXZhdGUgdGhlIG1pbm9yIG1vZGUuICBUbworICA7OyB1c2UgdGhpcyBr ZXltYXAsIHdlJ2QgbmVlZCB0byBtYWtlIHN1cmUgd2UgYWx3YXlzIGFjdGl2YXRlIHRoZQor ICA7OyBtaW5vciBtb2RlLgorICA6a2V5bWFwIHNlcnZlci1rZXltYXAKICAgOzsgRml4bWU6 IFNob3VsZCB0aGlzIGNoZWNrIGZvciBhbiBleGlzdGluZyBzZXJ2ZXIgc29ja2V0IGFuZCBk bwogICA7OyBub3RoaW5nIGlmIHRoZXJlIGlzIG9uZSAoZm9yIG11bHRpcGxlIEVtYWNzIHNl c3Npb25zKT8KICAgKHNlcnZlci1zdGFydCAobm90IHNlcnZlci1tb2RlKSkpCi0tIAoyLjI1 LjEKCg== --------------qlARUBNhtTsCxdvPZv0SDD6R-- From unknown Sun Jun 22 08:05:01 2025 X-Loop: help-debbugs@gnu.org Subject: bug#58909: 29.0.50; [WIP PATCH] Deleting the last frame of an emacsclient doesn't ask to save Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 02 Nov 2022 17:13:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58909 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Jim Porter Cc: 58909@debbugs.gnu.org Received: via spool by 58909-submit@debbugs.gnu.org id=B58909.166740913516408 (code B ref 58909); Wed, 02 Nov 2022 17:13:02 +0000 Received: (at 58909) by debbugs.gnu.org; 2 Nov 2022 17:12:15 +0000 Received: from localhost ([127.0.0.1]:47097 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oqHHj-0004Ga-A3 for submit@debbugs.gnu.org; Wed, 02 Nov 2022 13:12:15 -0400 Received: from eggs.gnu.org ([209.51.188.92]:46014) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oqHHh-0004GM-8l for 58909@debbugs.gnu.org; Wed, 02 Nov 2022 13:12:13 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oqHHb-0007UT-9p; Wed, 02 Nov 2022 13:12:07 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=VyLQ5Yovt0Lz6Vl2eqWW9sevLuwIRmSpGCd/BQyFCEU=; b=J3fmgpNZV/eK jMbD1AD6sdFIaodOcTnAJLiH263QxcQA9mtAnKpKkblE7w+Ex52YYOCOJzA3xpCjJtEUG25vmAWhu dS5HuCCHOzXON9tCr17JnIkBUKesZtk/k6bbqk6XCQ9bJzHK1nOqIQKcIHzlZEpGL6rNqdBRmex/5 F46fvEpAVukeueJN8yZDyrOfc52/WhfoFouqNI/eUqPk+FDivyU2zoXFQdW8Ai7BybtHvxDQRcOEB X+FPQLN/7yHqy6kgPBmG3dU2NKpmGlKoggDmpuh5IbV3ZKrsq6GpKjxhqjkTYrW79V7Kl5Gy7Ltqy H8E9gXY8w6hB5d0xWgsJ4g==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oqHHa-0007Pt-P6; Wed, 02 Nov 2022 13:12:07 -0400 Date: Wed, 02 Nov 2022 19:11:57 +0200 Message-Id: <83a6599t7m.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: (message from Jim Porter on Wed, 2 Nov 2022 09:36:52 -0700) References: <9a70f868-ca50-52fc-af3e-23813af104f2@gmail.com> <83zgdcduxm.fsf@gnu.org> <53238b5b-3e0a-3dfe-eeba-f37cafa81f50@gmail.com> <838rkveq3n.fsf@gnu.org> <7de45884-b4c9-4a4c-777c-5db17b3bacca@gmail.com> <835yfzeobt.fsf@gnu.org> <7694fcf2-8982-9099-5eb8-39835d049847@gmail.com> <83y1svch5u.fsf@gnu.org> <0dc07894-dfa1-01f6-87c4-9e02bfcaf0dc@gmail.com> <83bkppblh7.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Wed, 2 Nov 2022 09:36:52 -0700 > Cc: 58909@debbugs.gnu.org > From: Jim Porter > > > Sorry, but I still don't like this. We currently call this hook via > > safe_call because we don't want to let the hook prevent the deletion > > of the frame. > > > > I prefer to solve this in server.el, not in lower-level primitives. > > Hm, ok. That means I'd need to make sure 'C-x 5 0' calls something other > than 'delete-frame', so that I could add a prompt to it that can prevent > deletion of the frame. Why? delete-frame eventually calls a function from server.el, doesn't it? We've been through that already. Why cannot you do this inside that server.el function? If that's because you want to support the C-g case, then don't: that is a separate problem. You wanted to give the user the opportunity to save the buffers, and that doesn't require any support for C-g. Besides, if the user types C-g when presented with the save-buffers prompt, how do you know that the user intends to abort deletion of the frame, and not break out of the saving operation? And finally, even if the user does want to prevent the deletion of the frame, and fails in doing that, how is that a catastrophe? Emacs is still running and the unsaved buffers are still in the session. I really don't see why we need to jump through any hoops for such a simple situation. > 1. If 'delete-frame' is a lower-level primitive, should 'C-x 5 0' call > it directly, or should there be a higher-level function for it to call? > If we had some higher-level function, then user-level commands could > call that, but low-level code could still use 'delete-frame'. This > user-level command would then be able to run some hook that can prevent > deletion of the frame. > > 2. Since server.el has a minor mode (unsurprisingly named > 'server-mode'), maybe one option is to do command remapping. If we remap > 'delete-frame' to some new 'server-delete-frame' when 'server-mode' is > active, then this should work. See attached for a quick sketch of how > this would look. > > What do you think about one of these? Waaaay too complicated for such a simple problem. Please, let's just prompt the user from server-delete-client (and do that under some opt-in option), and be done with that. From unknown Sun Jun 22 08:05:01 2025 X-Loop: help-debbugs@gnu.org Subject: bug#58909: 29.0.50; [WIP PATCH] Deleting the last frame of an emacsclient doesn't ask to save Resent-From: Jim Porter Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 02 Nov 2022 18:18:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58909 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Eli Zaretskii Cc: 58909@debbugs.gnu.org Received: via spool by 58909-submit@debbugs.gnu.org id=B58909.166741302722677 (code B ref 58909); Wed, 02 Nov 2022 18:18:02 +0000 Received: (at 58909) by debbugs.gnu.org; 2 Nov 2022 18:17:07 +0000 Received: from localhost ([127.0.0.1]:47157 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oqIIV-0005tg-Dl for submit@debbugs.gnu.org; Wed, 02 Nov 2022 14:17:07 -0400 Received: from mail-pl1-f171.google.com ([209.85.214.171]:34721) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oqIIU-0005t9-Bm for 58909@debbugs.gnu.org; Wed, 02 Nov 2022 14:17:06 -0400 Received: by mail-pl1-f171.google.com with SMTP id v17so14326054plo.1 for <58909@debbugs.gnu.org>; Wed, 02 Nov 2022 11:17:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to; bh=tpfwQvHI9HGkbcmKzDCWNhdjjwCE5SeHppSFvADlrlQ=; b=G6QY88kSP+7S5k/Vev8wvfVwjOjCQ9sYLQkk4Sqx2grPIRP+BW63f3YQykYVO0SyJy hLhlDT5QBvsBHh8w5ACLmdWaYoThfcqaXqvChSOP7JjTkg8c788ErkSvVMDelZNvChB+ /qkqWdoOQ6CUFf6l2wnalL6RoPe1RnDtr/hCiWnpaE0U5JOhfY+ukEW75cRWSKYOTC4d DCTDrxIayRvqpULMBdbVbW8igph4Pu9ECsOCmRbL/gPp+H1PUq/aWn/AJsMXXFwxJAMh MIV0nLHvS9mLHN3IoCT5/ukOwRLp8nkuE4AnN1ug5amtWI/KSbodFZUbu82anRKE44G1 Q5gA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=tpfwQvHI9HGkbcmKzDCWNhdjjwCE5SeHppSFvADlrlQ=; b=shUQnPMe1ZgCUfO980RHEsjmfB+7XKsjjda+07w18N80V+90Dni53m40nTJ9u6Xfly ElFdgCCmgOPbRe6/JNqUINToo3roHaFT/96+4okjGUBMNdVgjObrVRuC4BPOeJzyQJOU +Lv4pXITnCZrXlU+wdXJmNoudBIdNwUsBVJe2LPyIJXy0DJyYfE1KJeRafcyDtgeMW1x P6pob50GPW8Q0I1FiT0opKx5TK2hG+RJI9QzXJZ3gxfVezOUwqA5YD2w+1Crg3fbb7hS NmLRRUIga66C7WwceJ+v+XKvOExEp4NAL5tQ5S7Q7mI2reDTPTDqfNMZOfvWWbkYuY3S dsNg== X-Gm-Message-State: ACrzQf1VUZ9uzh/HK7iZTqXQ8yJ8rcPXvFX8wQjX6ISOS0xJCSlxz/2n MDYp9ybjLZim8EgVPLYeq944olHORFU= X-Google-Smtp-Source: AMsMyM6tTyuQHdK7MgMJH9EYpprfVbkncfzrJ2rAOYF6nWaSNM62isPO6c2SSiP3876EBbRWehx0RQ== X-Received: by 2002:a17:90a:f198:b0:212:c3cf:b8f4 with SMTP id bv24-20020a17090af19800b00212c3cfb8f4mr27392318pjb.49.1667413020463; Wed, 02 Nov 2022 11:17:00 -0700 (PDT) Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id 11-20020a63134b000000b0043ae1797e2bsm7770378pgt.63.2022.11.02.11.16.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 02 Nov 2022 11:16:59 -0700 (PDT) Message-ID: <39e03350-2783-fa90-5d66-26e47abe100d@gmail.com> Date: Wed, 2 Nov 2022 11:17:00 -0700 MIME-Version: 1.0 Content-Language: en-US References: <9a70f868-ca50-52fc-af3e-23813af104f2@gmail.com> <83zgdcduxm.fsf@gnu.org> <53238b5b-3e0a-3dfe-eeba-f37cafa81f50@gmail.com> <838rkveq3n.fsf@gnu.org> <7de45884-b4c9-4a4c-777c-5db17b3bacca@gmail.com> <835yfzeobt.fsf@gnu.org> <7694fcf2-8982-9099-5eb8-39835d049847@gmail.com> <83y1svch5u.fsf@gnu.org> <0dc07894-dfa1-01f6-87c4-9e02bfcaf0dc@gmail.com> <83bkppblh7.fsf@gnu.org> <83a6599t7m.fsf@gnu.org> From: Jim Porter In-Reply-To: <83a6599t7m.fsf@gnu.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) First, I just wanted to say thanks for your patience with this. I think this discussion has gone on a lot longer than either of us intended. I want to emphasize that while I'm not flexible in how my Emacs configuration works, I *am* flexible in what actually gets committed to Emacs proper. If you think my changes belong in Emacs, then I'll do the necessary work to get them in a merge-able state; if not, I can just apply them to my local configuration. Thanks again. On 11/2/2022 10:11 AM, Eli Zaretskii wrote: >> Date: Wed, 2 Nov 2022 09:36:52 -0700 >> Cc: 58909@debbugs.gnu.org >> From: Jim Porter >> >> Hm, ok. That means I'd need to make sure 'C-x 5 0' calls something other >> than 'delete-frame', so that I could add a prompt to it that can prevent >> deletion of the frame. > > Why? delete-frame eventually calls a function from server.el, doesn't > it? We've been through that already. Why cannot you do this inside > that server.el function? > > If that's because you want to support the C-g case, then don't: that > is a separate problem. Yeah, this subthread about 'delete-frame' was just to support the C-g case. Aside from that, I think doing this inside 'server-delete-client' would be fine. However, at least for this bug, adding a hook that runs in 'server-delete-client' doesn't add anything that 'delete-frame-functions' doesn't already allow. ('server-delete-client' is called from a hook in 'delete-frame-functions' in this case anyway.) > Waaaay too complicated for such a simple problem. Please, let's just > prompt the user from server-delete-client (and do that under some > opt-in option), and be done with that. If you mean adding a defcustom, I thought we'd agreed not to do that (see the beginning of your message here[1]). I'm fine with that; if I have to write a hook to fix the issue I saw in the original message, I don't mind. (Of course, I'm happy to upstream my code if there's interest, but if not, that's ok too.) Instead, my goal was just to provide the bare minimum of changes to Emacs to enable a user to modify this to their liking without relying too heavily on 'advice-add'. :) Would it make sense (possibly in a separate bug) to at least make sure that the 'server-mode' minor mode is always active when the server is running? The server.el code sometimes uses 'server-mode' and sometimes uses 'server-start', with the end result being that the minor mode may or may not be active depending on the way the server was started. That seems like a bug all on its own. If just this part were fixed, it would go 95% of the way to make it easy for me to make Emacs work just the way I like, and without having to make any major changes to Emacs itself. This change could be as simple as renaming 'server-start' to 'server--start', and then have a new 'server-start' that activates the minor mode. [1] https://lists.gnu.org/archive/html/bug-gnu-emacs/2022-10/msg02642.html From unknown Sun Jun 22 08:05:01 2025 X-Loop: help-debbugs@gnu.org Subject: bug#58909: 29.0.50; [WIP PATCH] Deleting the last frame of an emacsclient doesn't ask to save Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 02 Nov 2022 18:43:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58909 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Jim Porter Cc: 58909@debbugs.gnu.org Received: via spool by 58909-submit@debbugs.gnu.org id=B58909.16674145601136 (code B ref 58909); Wed, 02 Nov 2022 18:43:01 +0000 Received: (at 58909) by debbugs.gnu.org; 2 Nov 2022 18:42:40 +0000 Received: from localhost ([127.0.0.1]:47194 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oqIhE-0000IG-5s for submit@debbugs.gnu.org; Wed, 02 Nov 2022 14:42:40 -0400 Received: from eggs.gnu.org ([209.51.188.92]:41492) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oqIhB-0000Hx-T0 for 58909@debbugs.gnu.org; Wed, 02 Nov 2022 14:42:38 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oqIh4-0004HM-K2; Wed, 02 Nov 2022 14:42:31 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=djRMnNovpkfchA62lsXr2J61dwt0+5kuycFAOnMC/ag=; b=PxqyWU8ZAwYT QZMl5PL/WJR7D3yN9ZIIuTSEE/QzDDhP7Flm1djUTHJDMSdksV8IPd5Te72AwYv4ooMG1tNSbvXRj VigzhMl0qNb7MhNNDeN6eTBjpcyq0KuZrZtscqM32j8DJBIePzJIK2dE8gVr2PhxJpElc3jb1tw9M kxCwSLLbsV4S53zKn1f3kFQtah/qsyN+VKi6G+6uzP6+Fhp4NhmWVaVXT/3yrtkjiYPQqgupMcEB9 xtv3VHGnZ8zhioKFBCskzZ283h+dCOC6oqlOuLwsaWY7lEvbTTSuSmsjrRiqVnfSt1Y+cn34f8i3o lTmUojrfgmYUR6QJ2X9YJw==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oqIh3-0007Pe-Qj; Wed, 02 Nov 2022 14:42:30 -0400 Date: Wed, 02 Nov 2022 20:42:20 +0200 Message-Id: <835yfx9p0z.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: <39e03350-2783-fa90-5d66-26e47abe100d@gmail.com> (message from Jim Porter on Wed, 2 Nov 2022 11:17:00 -0700) References: <9a70f868-ca50-52fc-af3e-23813af104f2@gmail.com> <83zgdcduxm.fsf@gnu.org> <53238b5b-3e0a-3dfe-eeba-f37cafa81f50@gmail.com> <838rkveq3n.fsf@gnu.org> <7de45884-b4c9-4a4c-777c-5db17b3bacca@gmail.com> <835yfzeobt.fsf@gnu.org> <7694fcf2-8982-9099-5eb8-39835d049847@gmail.com> <83y1svch5u.fsf@gnu.org> <0dc07894-dfa1-01f6-87c4-9e02bfcaf0dc@gmail.com> <83bkppblh7.fsf@gnu.org> <83a6599t7m.fsf@gnu.org> <39e03350-2783-fa90-5d66-26e47abe100d@gmail.com> X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Wed, 2 Nov 2022 11:17:00 -0700 > Cc: 58909@debbugs.gnu.org > From: Jim Porter > > > If that's because you want to support the C-g case, then don't: that > > is a separate problem. > > Yeah, this subthread about 'delete-frame' was just to support the C-g > case. Aside from that, I think doing this inside 'server-delete-client' > would be fine. However, at least for this bug, adding a hook that runs > in 'server-delete-client' doesn't add anything that > 'delete-frame-functions' doesn't already allow. ('server-delete-client' > is called from a hook in 'delete-frame-functions' in this case anyway.) We cannot have behavior specific to server.el coded outside of server.el. So I don't think I understand what you are saying here. My suggestion is not to add a hook, it is to add a prompt for the user when the last client frame is deleted, and do it optionally. > > Waaaay too complicated for such a simple problem. Please, let's just > > prompt the user from server-delete-client (and do that under some > > opt-in option), and be done with that. > > If you mean adding a defcustom, I thought we'd agreed not to do that > (see the beginning of your message here[1]). Yes, but you keep pushing... > Would it make sense (possibly in a separate bug) to at least make sure > that the 'server-mode' minor mode is always active when the server is > running? The server.el code sometimes uses 'server-mode' and sometimes > uses 'server-start', with the end result being that the minor mode may > or may not be active depending on the way the server was started. That > seems like a bug all on its own. Maybe it's a bug, but then it's really old. I'm not sure I understand the purpose of this minor mode, and we ourselves start the server in the daemon mode by a direct call to server-start. Also, server-start is a command, and many users (myself included) invoke it interactively. Why is it important to have the mode turned on? What can a mode do that we cannot do without a mode? From unknown Sun Jun 22 08:05:01 2025 X-Loop: help-debbugs@gnu.org Subject: bug#58909: 29.0.50; [WIP PATCH] Deleting the last frame of an emacsclient doesn't ask to save Resent-From: Jim Porter Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 02 Nov 2022 19:17:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58909 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Eli Zaretskii Cc: 58909@debbugs.gnu.org Received: via spool by 58909-submit@debbugs.gnu.org id=B58909.16674166004385 (code B ref 58909); Wed, 02 Nov 2022 19:17:02 +0000 Received: (at 58909) by debbugs.gnu.org; 2 Nov 2022 19:16:40 +0000 Received: from localhost ([127.0.0.1]:47205 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oqJE7-00018f-GE for submit@debbugs.gnu.org; Wed, 02 Nov 2022 15:16:40 -0400 Received: from mail-pg1-f172.google.com ([209.85.215.172]:41642) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oqJE3-00018P-N5 for 58909@debbugs.gnu.org; Wed, 02 Nov 2022 15:16:38 -0400 Received: by mail-pg1-f172.google.com with SMTP id q71so17061608pgq.8 for <58909@debbugs.gnu.org>; Wed, 02 Nov 2022 12:16:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:from:references:cc:to:content-language:subject :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=RKbl+a7G9pDemKl8f4rVoIrrxXLc+iQpmPBJs5GkcWE=; b=kcL1tTUnknv+Z8h3vDkvcdJzWYnhAhaFBkE31VWvggui6udDi39AqjROeslFk9kzdN oLmtufUiotcSEnFryvinCeo6M79uSKFZtLHMdkYplch7XkNRH+Nz+cho078QM2c2QNu3 PDfvouYY8kbbyU5zqDqo7GsMGcE59gxN3fZoEkdNzl/JTPf8xLKfQbGa1U9d6JaKtZa4 dxbi9gemtLoBEeod/vsB00v/jygJURTz8s7eDdyI6U7EoWlFxuWg3mjE5UBoOu0W1tV5 mqn5Y82d905N2gd7vDikEUjuJBjxRmgIZUnLa7OOZd3cPQQRY4Je9+4pM+FAV9ecRg2q pabQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:from:references:cc:to:content-language:subject :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=RKbl+a7G9pDemKl8f4rVoIrrxXLc+iQpmPBJs5GkcWE=; b=O6pWO6Gay3GW1ZGyuBt7QeQXuUc73L9dPvuakLyBXobc5tQa9fn3vy2agIvzagjCwN nRZx7sU+n8EZFCmvJckPWwclMguVWrMoumUYjHZm6LozryNYe4aXwryxR4GEWdSjpZFE I+EqJvLf4H6jGcvMdDS3lOBPUwYlGNLTbc6Bt0Zt2otsouvc5N57sFMVmswnEgnnowR6 9dhyMRBJPnuTRcP1WjdTCGciH4Nvsn7oprsQ6etvR+ydP/xwKero086LdYgRNaxQiPqL njB8zg9B7GG5sksiF2JUC6CMfYMe9azItFlMvHrMnT03OLQWi23JEK/6gio/zOM/2hbv aXLw== X-Gm-Message-State: ACrzQf1ukUVlqx2x+4y5IKXEGuo1J3wYGcNZfKvFWMApxId56dCWRKnl wJ9fAYuZX0JLVFz4i65uKgc= X-Google-Smtp-Source: AMsMyM4oGOH31CZR5CBeCbV3eogNtxsTLnqfNMWKmAtLr28RWwQmW9yFT09xp+mGECNKOY7uOzfxZw== X-Received: by 2002:aa7:9624:0:b0:56c:8c13:27bf with SMTP id r4-20020aa79624000000b0056c8c1327bfmr26883680pfg.20.1667416589649; Wed, 02 Nov 2022 12:16:29 -0700 (PDT) Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id jc13-20020a17090325cd00b0017f7e0f4a4esm8666465plb.35.2022.11.02.12.16.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 02 Nov 2022 12:16:28 -0700 (PDT) Content-Type: multipart/mixed; boundary="------------bpnISdrr0zmHqJcaC0uzVk0o" Message-ID: <3d5bc685-889f-f406-0979-10f61db5d1a7@gmail.com> Date: Wed, 2 Nov 2022 12:16:30 -0700 MIME-Version: 1.0 Content-Language: en-US References: <9a70f868-ca50-52fc-af3e-23813af104f2@gmail.com> <83zgdcduxm.fsf@gnu.org> <53238b5b-3e0a-3dfe-eeba-f37cafa81f50@gmail.com> <838rkveq3n.fsf@gnu.org> <7de45884-b4c9-4a4c-777c-5db17b3bacca@gmail.com> <835yfzeobt.fsf@gnu.org> <7694fcf2-8982-9099-5eb8-39835d049847@gmail.com> <83y1svch5u.fsf@gnu.org> <0dc07894-dfa1-01f6-87c4-9e02bfcaf0dc@gmail.com> <83bkppblh7.fsf@gnu.org> <83a6599t7m.fsf@gnu.org> <39e03350-2783-fa90-5d66-26e47abe100d@gmail.com> <835yfx9p0z.fsf@gnu.org> From: Jim Porter In-Reply-To: <835yfx9p0z.fsf@gnu.org> X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) This is a multi-part message in MIME format. --------------bpnISdrr0zmHqJcaC0uzVk0o Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 11/2/2022 11:42 AM, Eli Zaretskii wrote: >> Date: Wed, 2 Nov 2022 11:17:00 -0700 >> Cc: 58909@debbugs.gnu.org >> From: Jim Porter >> >>> If that's because you want to support the C-g case, then don't: that >>> is a separate problem. >> >> Yeah, this subthread about 'delete-frame' was just to support the C-g >> case. Aside from that, I think doing this inside 'server-delete-client' >> would be fine. However, at least for this bug, adding a hook that runs >> in 'server-delete-client' doesn't add anything that >> 'delete-frame-functions' doesn't already allow. ('server-delete-client' >> is called from a hook in 'delete-frame-functions' in this case anyway.) > > We cannot have behavior specific to server.el coded outside of > server.el. So I don't think I understand what you are saying here. > My suggestion is not to add a hook, it is to add a prompt for the user > when the last client frame is deleted, and do it optionally. I just meant that the existing 'delete-frame-functions' hook lets me do what I want by writing a hook in my local configuration (except for the C-g issue). I agree that for any changes to Emacs, the changes should be in server.el as much as possible. >> If you mean adding a defcustom, I thought we'd agreed not to do that >> (see the beginning of your message here[1]). > > Yes, but you keep pushing... Sorry if I seem pushy. I really am open to different solutions here, and I just want to present some various options I see to make it possible/easy to adjust the behavior of server.el. My goal is really just to offer what improvements I can to Emacs; if they don't belong, that's ok. I can just use them locally. In short, consider my messages/patches as just an offer to help. > I'm not sure I understand the purpose of this minor mode, and we > ourselves start the server in the daemon mode by a direct call to > server-start. Also, server-start is a command, and many users (myself > included) invoke it interactively. > > Why is it important to have the mode turned on? What can a mode do > that we cannot do without a mode? If starting the server activates a minor mode, then Emacs can use a minor-mode keymap for server-mode. That would make it easy for users to add keybindings that only take effect when the server is running. In my case, I could locally remap 'delete-frame' to some new function when the server is running, and then I could make that function do exactly what I want. Other users might want to add other keybindings to this keymap (maybe one for 'server-edit-abort'). In fact, for my purposes, even just having daemon mode call '(server-mode 1)' instead of '(server-start)' would be a good improvement. There are other ways to do this, but having a minor mode makes it easier. I attached a quick patch that shows the changes I'd make so that users could have a 'sever-mode-keymap' to add to; if you think any of these changes are too risky, I don't mind removing them. If you think *all* of them are too risky, that's ok too. I can just do something equivalent in my local config. --------------bpnISdrr0zmHqJcaC0uzVk0o Content-Type: text/plain; charset=UTF-8; name="0001-WIP-Try-using-a-keymap-for-server-mode.patch" Content-Disposition: attachment; filename="0001-WIP-Try-using-a-keymap-for-server-mode.patch" Content-Transfer-Encoding: base64 RnJvbSAwZTYzOGU0YjE0ODFlNjBiNmQ4MjExYjE1ZDU1ZDNmZGU2MjkxYjMxIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKaW0gUG9ydGVyIDxqcG9ydGVyYnVnc0BnbWFpbC5j b20+CkRhdGU6IFdlZCwgMiBOb3YgMjAyMiAwOToyMjo0MyAtMDcwMApTdWJqZWN0OiBbUEFU Q0hdIFtXSVBdIFRyeSB1c2luZyBhIGtleW1hcCBmb3Igc2VydmVyLW1vZGUKCi0tLQogbGlz cC9mcmFtZS5lbCAgIHwgNiArKysrKy0KIGxpc3Avc2VydmVyLmVsICB8IDUgKysrKysKIGxp c3Avc3RhcnR1cC5lbCB8IDIgKy0KIDMgZmlsZXMgY2hhbmdlZCwgMTEgaW5zZXJ0aW9ucygr KSwgMiBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9saXNwL2ZyYW1lLmVsIGIvbGlzcC9m cmFtZS5lbAppbmRleCA0MDBmOGE0NGVlLi5mMTg4ODYyM2U0IDEwMDY0NAotLS0gYS9saXNw L2ZyYW1lLmVsCisrKyBiL2xpc3AvZnJhbWUuZWwKQEAgLTEyOCw3ICsxMjgsMTEgQEAgaGFu ZGxlLWRlbGV0ZS1mcmFtZQogICAgICAgICAgICAgICAgICAgICAgICAobm90IChmcmFtZS1w YXJlbnQgZnJhbWUtMSkpCiAgICAgICAgICAgICAgICAgICAgICAgIChub3QgKGZyYW1lLXBh cmFtZXRlciBmcmFtZS0xICdkZWxldGUtYmVmb3JlKSkpCiAgICAgICAgICAgICAgICh0aHJv dyAnb3RoZXItZnJhbWUgdCkpKSkKLQkoZGVsZXRlLWZyYW1lIGZyYW1lIHQpCisgICAgICAg IDs7IE5PVEU6IFRoaXMgY2hhbmdlIGlzIG9wdGlvbmFsLiAgSWYgeW91IHRoaW5rIGl0IGFk ZHMgdG9vCisgICAgICAgIDs7IG11Y2ggY29tcGxleGl0eSwgbGV0J3MgcmVtb3ZlIGl0Lgor ICAgICAgICAoZnVuY2FsbCAob3IgKGNvbW1hbmQtcmVtYXBwaW5nICMnZGVsZXRlLWZyYW1l KQorICAgICAgICAgICAgICAgICAgICAgIydkZWxldGUtZnJhbWUpCisgICAgICAgICAgICAg ICAgIHQpCiAgICAgICA7OyBHaWxkZWFAeC5vcmcgc2F5cyBpdCBpcyBvayB0byBhc2sgcXVl c3Rpb25zIGJlZm9yZSB0ZXJtaW5hdGluZy4KICAgICAgIChzYXZlLWJ1ZmZlcnMta2lsbC1l bWFjcykpKSkKIApkaWZmIC0tZ2l0IGEvbGlzcC9zZXJ2ZXIuZWwgYi9saXNwL3NlcnZlci5l bAppbmRleCA5MGQ5N2MxNTM4Li5hZWM2Njc3ZjFkIDEwMDY0NAotLS0gYS9saXNwL3NlcnZl ci5lbAorKysgYi9saXNwL3NlcnZlci5lbApAQCAtNzk2LDYgKzc5NiwxMCBAQCBzZXJ2ZXIt cnVubmluZy1wCiAJdCkKICAgICAoZmlsZS1lcnJvciBuaWwpKSkKIAorOzsgTk9URTogVGhp cyBjaGFuZ2UgaXMgb3B0aW9uYWwsIGJ1dCBpdCBtYWtlcyBpdCBlYXNpZXIgZm9yIHVzZXJz IHRvCis7OyBhZGQga2V5YmluZGluZ3MgZm9yIGBzZXJ2ZXItbW9kZScuCisoZGVmdmFyLWtl eW1hcCBzZXJ2ZXItbW9kZS1rZXltYXApCisKIDs7OyMjI2F1dG9sb2FkCiAoZGVmaW5lLW1p bm9yLW1vZGUgc2VydmVyLW1vZGUKICAgIlRvZ2dsZSBTZXJ2ZXIgbW9kZS4KQEAgLTgwNSw2 ICs4MDksNyBAQCBzZXJ2ZXItbW9kZQogYHNlcnZlci1zdGFydCcgZm9yIGRldGFpbHMuIgog ICA6Z2xvYmFsIHQKICAgOnZlcnNpb24gIjIyLjEiCisgIDprZXltYXAgc2VydmVyLW1vZGUt a2V5bWFwCiAgIDs7IEZpeG1lOiBTaG91bGQgdGhpcyBjaGVjayBmb3IgYW4gZXhpc3Rpbmcg c2VydmVyIHNvY2tldCBhbmQgZG8KICAgOzsgbm90aGluZyBpZiB0aGVyZSBpcyBvbmUgKGZv ciBtdWx0aXBsZSBFbWFjcyBzZXNzaW9ucyk/CiAgIChzZXJ2ZXItc3RhcnQgKG5vdCBzZXJ2 ZXItbW9kZSkpKQpkaWZmIC0tZ2l0IGEvbGlzcC9zdGFydHVwLmVsIGIvbGlzcC9zdGFydHVw LmVsCmluZGV4IDcwMjY3ZmM4NTcuLmE0OTRlNDJkMjUgMTAwNjQ0Ci0tLSBhL2xpc3Avc3Rh cnR1cC5lbAorKysgYi9saXNwL3N0YXJ0dXAuZWwKQEAgLTE2MDQsNyArMTYwNCw3IEBAIGNv bW1hbmQtbGluZQogICAobGV0ICgoZG4gKGRhZW1vbnApKSkKICAgICAod2hlbiBkbgogICAg ICAgKHdoZW4gKHN0cmluZ3AgZG4pIChzZXRxIHNlcnZlci1uYW1lIGRuKSkKLSAgICAgIChz ZXJ2ZXItc3RhcnQpCisgICAgICAoc2VydmVyLW1vZGUgMSkKICAgICAgIChpZiBzZXJ2ZXIt cHJvY2VzcwogCSAgKGRhZW1vbi1pbml0aWFsaXplZCkKIAkoaWYgKHN0cmluZ3AgZG4pCi0t IAoyLjI1LjEKCg== --------------bpnISdrr0zmHqJcaC0uzVk0o-- From unknown Sun Jun 22 08:05:01 2025 X-Loop: help-debbugs@gnu.org Subject: bug#58909: 29.0.50; [WIP PATCH] Deleting the last frame of an emacsclient doesn't ask to save Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 02 Nov 2022 19:24:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58909 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Jim Porter Cc: 58909@debbugs.gnu.org Received: via spool by 58909-submit@debbugs.gnu.org id=B58909.16674170135008 (code B ref 58909); Wed, 02 Nov 2022 19:24:01 +0000 Received: (at 58909) by debbugs.gnu.org; 2 Nov 2022 19:23:33 +0000 Received: from localhost ([127.0.0.1]:47210 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oqJKm-0001Ii-L1 for submit@debbugs.gnu.org; Wed, 02 Nov 2022 15:23:32 -0400 Received: from eggs.gnu.org ([209.51.188.92]:42374) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oqJKk-0001IT-7y for 58909@debbugs.gnu.org; Wed, 02 Nov 2022 15:23:30 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oqJKe-0001QH-NL; Wed, 02 Nov 2022 15:23:24 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=GoKU3CxUDtUOehc3CIcCzpqXs1Y2Vy+hdG4kE/NWVEQ=; b=E3oN/G+CZMZM gwUoYe42EobFQheBkFWcaQ079+W7DcG9X10hpvCYI31nvcQlTn/R6TH44YvCuGYFYXS4BMpExkjvW zh1I/bpEhFm1w22cvPcq5G4v4ue8g0Y3/3Am/5yjCb8OxSJNJrVVoCtMu1nulU7LfQZDbf8zeobsM 2P/qCvbEUuMynpZ4HslPxZrA2o2Kdl9+Qm/mzvwc1YEL2LqzYQcd9Fp0SEDgO50pJNXQHnP9EcN3M wMsuky5a/Z6EZu/n8EiYYOOkhb+UhCUU/OjaBjcKtyAI3y5QtUyq8N4baVn3ONN1xA7pWuLO3b64u GkzywJguOTlEU3ODw6sLlg==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oqJKe-0006bD-6c; Wed, 02 Nov 2022 15:23:24 -0400 Date: Wed, 02 Nov 2022 21:23:15 +0200 Message-Id: <831qql9n4s.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: <3d5bc685-889f-f406-0979-10f61db5d1a7@gmail.com> (message from Jim Porter on Wed, 2 Nov 2022 12:16:30 -0700) References: <9a70f868-ca50-52fc-af3e-23813af104f2@gmail.com> <83zgdcduxm.fsf@gnu.org> <53238b5b-3e0a-3dfe-eeba-f37cafa81f50@gmail.com> <838rkveq3n.fsf@gnu.org> <7de45884-b4c9-4a4c-777c-5db17b3bacca@gmail.com> <835yfzeobt.fsf@gnu.org> <7694fcf2-8982-9099-5eb8-39835d049847@gmail.com> <83y1svch5u.fsf@gnu.org> <0dc07894-dfa1-01f6-87c4-9e02bfcaf0dc@gmail.com> <83bkppblh7.fsf@gnu.org> <83a6599t7m.fsf@gnu.org> <39e03350-2783-fa90-5d66-26e47abe100d@gmail.com> <835yfx9p0z.fsf@gnu.org> <3d5bc685-889f-f406-0979-10f61db5d1a7@gmail.com> X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Wed, 2 Nov 2022 12:16:30 -0700 > Cc: 58909@debbugs.gnu.org > From: Jim Porter > > >> If you mean adding a defcustom, I thought we'd agreed not to do that > >> (see the beginning of your message here[1]). > > > > Yes, but you keep pushing... > > Sorry if I seem pushy. I really am open to different solutions here, and > I just want to present some various options I see to make it > possible/easy to adjust the behavior of server.el. My goal is really > just to offer what improvements I can to Emacs; if they don't belong, > that's ok. I can just use them locally. > > In short, consider my messages/patches as just an offer to help. Isn't the last suggestion, of having an optional prompt in server-delete-client, good enough? > > Why is it important to have the mode turned on? What can a mode do > > that we cannot do without a mode? > > If starting the server activates a minor mode, then Emacs can use a > minor-mode keymap for server-mode. That would make it easy for users to > add keybindings that only take effect when the server is running. In my > case, I could locally remap 'delete-frame' to some new function when the > server is running, and then I could make that function do exactly what I > want. Other users might want to add other keybindings to this keymap > (maybe one for 'server-edit-abort'). > > In fact, for my purposes, even just having daemon mode call > '(server-mode 1)' instead of '(server-start)' would be a good improvement. I'm fine with doing that, but we must also make sure this mode is turned on when users invoke server-start interactively. From unknown Sun Jun 22 08:05:01 2025 X-Loop: help-debbugs@gnu.org Subject: bug#58909: 29.0.50; [WIP PATCH] Deleting the last frame of an emacsclient doesn't ask to save Resent-From: Jim Porter Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 02 Nov 2022 19:59:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58909 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Eli Zaretskii Cc: 58909@debbugs.gnu.org Received: via spool by 58909-submit@debbugs.gnu.org id=B58909.16674190848246 (code B ref 58909); Wed, 02 Nov 2022 19:59:02 +0000 Received: (at 58909) by debbugs.gnu.org; 2 Nov 2022 19:58:04 +0000 Received: from localhost ([127.0.0.1]:47228 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oqJsB-00028w-Vt for submit@debbugs.gnu.org; Wed, 02 Nov 2022 15:58:04 -0400 Received: from mail-pf1-f178.google.com ([209.85.210.178]:42973) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oqJsA-00028S-H3 for 58909@debbugs.gnu.org; Wed, 02 Nov 2022 15:58:02 -0400 Received: by mail-pf1-f178.google.com with SMTP id b185so17361168pfb.9 for <58909@debbugs.gnu.org>; Wed, 02 Nov 2022 12:58:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to; bh=bovSnHUPXKeA/WxOtwZEBld7aRIBzYG8dPaGBgHP7Co=; b=LT5kHsHzSYSAvwxZPNARgO22rDcaATdza42Oc283ymhDfzMTGucCIiLUXMeAHG0nct Jjc/v0pBq0D3xVTUANIS38C3syTJj3RgzN4V4CNL1C3WNwY9BpVKbcIP8IuR91IKG5NA zuxh/L4PdgqGcjhA8NEX8d3KIdu555GA0SU9nSs/nNci9t584Q6Gfa62G8JvjETYFJja OYpBta3xFdCDju+uPYDuhoXMmA4WoxMVAs2iWseN5GKiFeHEVcXnA63mff7ZhyrqOtjV uxXXaz5wR8OHffTCLunsh6673P/sGGZAzR0TRW00HYSVOsqtq7VMpREgT7t3ipbLgS4B 1I2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=bovSnHUPXKeA/WxOtwZEBld7aRIBzYG8dPaGBgHP7Co=; b=eEmfjjOx3cuZSKtNiTbgjiYbN3IH71hSXrU02+13TAU482xmlRMesuVlpubAEMTzFb NajuT4uh/raaB5moziXYzgYwrhv9tTQl9HQmPtoS7Xm+0gJyY6N1gttCxIsyqxH3tR6W u4ErpjdcqDf5jX91hsBs6cU+7JmTDwbgyBGyd7c2oYkjweq4DjG8k99rtdzQT333bsRh C/P2qErRQUq0gFU9NVpKL+hEDgdl6CAmlgNEQR3067f1/87SZjZtgxVpD3zCLlWkqAX+ FIMfQjraqq8uC0JSNpS/Uc8YhgG+TiUoT56u12FFKsVgYUDjX1iZqDMWoy1iB12Vqwzz 1nFg== X-Gm-Message-State: ACrzQf34ksAUYbxtrePS61MDAWt0EgKNF+PPo7+rnJpF9VZae2oejVPT AKdmZV9Hc0zawrEwg6cDung= X-Google-Smtp-Source: AMsMyM7baB9RtZ6wrA1/4f4e96cBdDRHiCkLbkOvZ/G5wuGt9igl1WbWGIHnC1es0jItCwgSDzCUpA== X-Received: by 2002:a63:66c3:0:b0:470:8fd:7bae with SMTP id a186-20020a6366c3000000b0047008fd7baemr4243183pgc.277.1667419076621; Wed, 02 Nov 2022 12:57:56 -0700 (PDT) Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id oj5-20020a17090b4d8500b001df264610c4sm3546042pjb.0.2022.11.02.12.57.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 02 Nov 2022 12:57:55 -0700 (PDT) Message-ID: Date: Wed, 2 Nov 2022 12:57:57 -0700 MIME-Version: 1.0 Content-Language: en-US References: <9a70f868-ca50-52fc-af3e-23813af104f2@gmail.com> <83zgdcduxm.fsf@gnu.org> <53238b5b-3e0a-3dfe-eeba-f37cafa81f50@gmail.com> <838rkveq3n.fsf@gnu.org> <7de45884-b4c9-4a4c-777c-5db17b3bacca@gmail.com> <835yfzeobt.fsf@gnu.org> <7694fcf2-8982-9099-5eb8-39835d049847@gmail.com> <83y1svch5u.fsf@gnu.org> <0dc07894-dfa1-01f6-87c4-9e02bfcaf0dc@gmail.com> <83bkppblh7.fsf@gnu.org> <83a6599t7m.fsf@gnu.org> <39e03350-2783-fa90-5d66-26e47abe100d@gmail.com> <835yfx9p0z.fsf@gnu.org> <3d5bc685-889f-f406-0979-10f61db5d1a7@gmail.com> <831qql9n4s.fsf@gnu.org> From: Jim Porter In-Reply-To: <831qql9n4s.fsf@gnu.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 11/2/2022 12:23 PM, Eli Zaretskii wrote: > Isn't the last suggestion, of having an optional prompt in > server-delete-client, good enough? 'server-delete-client' is called in a bunch of spots, so at minimum, I'd want to be extra-careful that prompting doesn't break one of those cases. It would also be nice if I could fix the C-g issue, at least in my local configuration. Still, I'll take a look at doing this if you think it would be good to add to Emacs. (If you think it's not needed, I really don't mind leaving the code as-is.) >>> Why is it important to have the mode turned on? What can a mode do >>> that we cannot do without a mode? >> >> If starting the server activates a minor mode, then Emacs can use a >> minor-mode keymap for server-mode. [snip] > > I'm fine with doing that, but we must also make sure this mode is > turned on when users invoke server-start interactively. I think that makes sense, and it should be fairly straightforward. I'll work on a patch for this. Thanks again for the extensive feedback. From unknown Sun Jun 22 08:05:01 2025 X-Loop: help-debbugs@gnu.org Subject: bug#58909: 29.0.50; [WIP PATCH] Deleting the last frame of an emacsclient doesn't ask to save Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 02 Nov 2022 20:10:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58909 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Jim Porter Cc: 58909@debbugs.gnu.org Received: via spool by 58909-submit@debbugs.gnu.org id=B58909.16674197789309 (code B ref 58909); Wed, 02 Nov 2022 20:10:02 +0000 Received: (at 58909) by debbugs.gnu.org; 2 Nov 2022 20:09:38 +0000 Received: from localhost ([127.0.0.1]:47233 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oqK3O-0002Q4-96 for submit@debbugs.gnu.org; Wed, 02 Nov 2022 16:09:38 -0400 Received: from eggs.gnu.org ([209.51.188.92]:34754) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oqK3M-0002Ps-GJ for 58909@debbugs.gnu.org; Wed, 02 Nov 2022 16:09:36 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oqK3H-000710-3l; Wed, 02 Nov 2022 16:09:31 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=2sw2JucS+x8Hwe2bj7LXmohDjOL3C3RChC+FV4rYl8M=; b=gOKZJFZUtdLR ycfu8EH3Oq9WHM2EcpPTUtuvO29GuPDGaGZze5ofsb5HnOriQUdpLevm/bLuOhqn684EheHSKiP1V Nl/VhZXZ5y+BykxJjXujm7C25LQKZKvCmzdbydEcIFgdLekbDAkW1hWcKI71eQOfVLYD42OKJWabg 4oykJD3J2CYzCnBj1yxJRenOMYvTTxXehb/g7gTEa9RbiS1CxyfVqehi7+zgeI2Vag7E7lgefSR0y Km6cuEWuxSsvycjKevF3j1NOo+JKN7NCCj5R8r3YAGPruWSQfLVp7A5Z2ofC3zpQuvbj6kwrqlsvo ZmyXAu+eFdQ5QkOrVKVelw==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oqK3G-0000xU-K0; Wed, 02 Nov 2022 16:09:30 -0400 Date: Wed, 02 Nov 2022 22:09:21 +0200 Message-Id: <83zgd986fi.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: (message from Jim Porter on Wed, 2 Nov 2022 12:57:57 -0700) References: <9a70f868-ca50-52fc-af3e-23813af104f2@gmail.com> <83zgdcduxm.fsf@gnu.org> <53238b5b-3e0a-3dfe-eeba-f37cafa81f50@gmail.com> <838rkveq3n.fsf@gnu.org> <7de45884-b4c9-4a4c-777c-5db17b3bacca@gmail.com> <835yfzeobt.fsf@gnu.org> <7694fcf2-8982-9099-5eb8-39835d049847@gmail.com> <83y1svch5u.fsf@gnu.org> <0dc07894-dfa1-01f6-87c4-9e02bfcaf0dc@gmail.com> <83bkppblh7.fsf@gnu.org> <83a6599t7m.fsf@gnu.org> <39e03350-2783-fa90-5d66-26e47abe100d@gmail.com> <835yfx9p0z.fsf@gnu.org> <3d5bc685-889f-f406-0979-10f61db5d1a7@gmail.com> <831qql9n4s.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Wed, 2 Nov 2022 12:57:57 -0700 > Cc: 58909@debbugs.gnu.org > From: Jim Porter > > On 11/2/2022 12:23 PM, Eli Zaretskii wrote: > > Isn't the last suggestion, of having an optional prompt in > > server-delete-client, good enough? > > 'server-delete-client' is called in a bunch of spots, so at minimum, I'd > want to be extra-careful that prompting doesn't break one of those > cases. Sorry, I meant server-handle-delete-frame. > It would also be nice if I could fix the C-g issue, at least in my > local configuration. You could rebind "C-x 5 0" to a different command, and do whatever you want there. > Still, I'll take a look at doing this if you think it would be good to > add to Emacs. (If you think it's not needed, I really don't mind leaving > the code as-is.) I thought my opinions on this were clear from the very beginning... > >> If starting the server activates a minor mode, then Emacs can use a > >> minor-mode keymap for server-mode. [snip] > > > > I'm fine with doing that, but we must also make sure this mode is > > turned on when users invoke server-start interactively. > > I think that makes sense, and it should be fairly straightforward. I'll > work on a patch for this. Thanks. From unknown Sun Jun 22 08:05:01 2025 X-Loop: help-debbugs@gnu.org Subject: bug#58909: 29.0.50; [PATCH] Deleting the last frame of an emacsclient doesn't ask to save Resent-From: Jim Porter Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 02 Nov 2022 22:10:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58909 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Eli Zaretskii Cc: 58909@debbugs.gnu.org Received: via spool by 58909-submit@debbugs.gnu.org id=B58909.166742697020482 (code B ref 58909); Wed, 02 Nov 2022 22:10:02 +0000 Received: (at 58909) by debbugs.gnu.org; 2 Nov 2022 22:09:30 +0000 Received: from localhost ([127.0.0.1]:47318 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oqLvO-0005KH-0n for submit@debbugs.gnu.org; Wed, 02 Nov 2022 18:09:30 -0400 Received: from mail-pg1-f175.google.com ([209.85.215.175]:36428) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oqLvM-0005K3-B5 for 58909@debbugs.gnu.org; Wed, 02 Nov 2022 18:09:28 -0400 Received: by mail-pg1-f175.google.com with SMTP id s196so56730pgs.3 for <58909@debbugs.gnu.org>; Wed, 02 Nov 2022 15:09:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:from:references:cc:to:content-language:subject :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=rGF4ODj0ocSm/hbp196Vxx+0SnlRFaN7h4+yOd3ybQU=; b=hLCeAsEG60qUejnjuKftPUHKnOhS7XoFliibK18Kv4evjXufx4oe2sT4dlU7jqFDAA 5qLnEpDAIN+7jaIEK1qB8qZ118oZ0HAgZeBuVPnmuM4sH3o6lxkmjgtP7mQUElNnVkHb e6gFljRmjReW/Li7+X6jKR5Uq1IiryQL+NCf6n5/yO0eUtw4+TmdeCN+YDLxjSgiN4jf 1cl7Tozf0uuhWonl+RFuwTaTwpfG9KgN3gJ5e1NwQVnIDtoGQyYA2I+DOGpzQrSD5UGO ERERCUr0kwRU2FfGwAKq0FPpquQDDYBLeZ8Rp00nbaStsBK6l0VcuQ2Y/u+inerpglvr mE/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:from:references:cc:to:content-language:subject :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=rGF4ODj0ocSm/hbp196Vxx+0SnlRFaN7h4+yOd3ybQU=; b=RBSYKz9uglruqTaNkF5IpKhJoiYLGC08SNKAMksXUgMUtirt/kDEv5zTkhqRx7ABVr 4a22YXGJ00nhAbeGqeuI0Pphv8p5h5TOKcFvgPCB+tBaMhXNrQShjyiuUM2UtX5UsmMh hzY0eF4ubii9uD0VyxO7s1sT1tb92umjzphyMzFDqBWdmEkFsjaWE2x0BNRn116qyZot z+zwDUrXyRsHHx4kZLtl60FbgSZrVQpPlCM1+Cs4VCN4/sbgJ1gl1aavtx2y/fe9+lK4 1pjRtNTzRGj3A2i2jYIkwicnQQajKjwzc/4IxCbv6oELAHZxC0peUGBtR7Lrnt70ztBa uAaw== X-Gm-Message-State: ACrzQf0sR8V2FnJ/huEroJSQk+0UMXlkzfkmO4AJL04SD94LxVCVIcqM +8jtDGFpZh2qPccJ9HGiwic= X-Google-Smtp-Source: AMsMyM4llpUw+Fr+l+xBEHiiKra3ET/VclyNemVZwwUCMqSi2YtK1hoUjo9udfRylN8YD4kQ+c5d1g== X-Received: by 2002:a05:6a00:1905:b0:566:2a02:e1a1 with SMTP id y5-20020a056a00190500b005662a02e1a1mr27538881pfi.1.1667426962208; Wed, 02 Nov 2022 15:09:22 -0700 (PDT) Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id p66-20020a625b45000000b0053e38ac0ff4sm8957943pfb.115.2022.11.02.15.09.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 02 Nov 2022 15:09:21 -0700 (PDT) Content-Type: multipart/mixed; boundary="------------MdGdMLhnpGeLoiJ7JGAOQlcC" Message-ID: <1e0f9cc1-03ed-9eea-c6cb-56248607dfe3@gmail.com> Date: Wed, 2 Nov 2022 15:09:21 -0700 MIME-Version: 1.0 Content-Language: en-US References: <9a70f868-ca50-52fc-af3e-23813af104f2@gmail.com> <83zgdcduxm.fsf@gnu.org> <53238b5b-3e0a-3dfe-eeba-f37cafa81f50@gmail.com> <838rkveq3n.fsf@gnu.org> <7de45884-b4c9-4a4c-777c-5db17b3bacca@gmail.com> <835yfzeobt.fsf@gnu.org> <7694fcf2-8982-9099-5eb8-39835d049847@gmail.com> <83y1svch5u.fsf@gnu.org> <0dc07894-dfa1-01f6-87c4-9e02bfcaf0dc@gmail.com> <83bkppblh7.fsf@gnu.org> <83a6599t7m.fsf@gnu.org> <39e03350-2783-fa90-5d66-26e47abe100d@gmail.com> <835yfx9p0z.fsf@gnu.org> <3d5bc685-889f-f406-0979-10f61db5d1a7@gmail.com> <831qql9n4s.fsf@gnu.org> <83zgd986fi.fsf@gnu.org> From: Jim Porter In-Reply-To: <83zgd986fi.fsf@gnu.org> X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) This is a multi-part message in MIME format. --------------MdGdMLhnpGeLoiJ7JGAOQlcC Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 11/2/2022 1:09 PM, Eli Zaretskii wrote: >> 'server-delete-client' is called in a bunch of spots, so at minimum, I'd >> want to be extra-careful that prompting doesn't break one of those >> cases. > > Sorry, I meant server-handle-delete-frame. Oh, ok. That would be easy then. But since your preference was to just leave things as they are, let's not make this change. I can adjust things locally without it. >>>> If starting the server activates a minor mode, then Emacs can use a >>>> minor-mode keymap for server-mode. [snip] >>> >>> I'm fine with doing that, but we must also make sure this mode is >>> turned on when users invoke server-start interactively. >> >> I think that makes sense, and it should be fairly straightforward. I'll >> work on a patch for this. > > Thanks. Ok, here's a patch for that. It just sets the 'server-mode' variable (and 'global-minor-modes' to be polite) inside 'server-start'. It would probably be more elegant if we could make 'server-start' just call '(server-mode)' (instead of the other way around like it is now), but I think it would be hard to do that while staying 100% compatible. Does this seem ok? --------------MdGdMLhnpGeLoiJ7JGAOQlcC Content-Type: text/plain; charset=UTF-8; name="0001-Enable-disable-server-mode-when-starting-stopping-th.patch" Content-Disposition: attachment; filename*0="0001-Enable-disable-server-mode-when-starting-stopping-th.pa"; filename*1="tch" Content-Transfer-Encoding: base64 RnJvbSA2ODdmMmFiNDgwM2M0MWY2YTMzMjgwMDQ4MjQzYjA5NjI4MTZkMmI1IE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKaW0gUG9ydGVyIDxqcG9ydGVyYnVnc0BnbWFpbC5j b20+CkRhdGU6IFdlZCwgMiBOb3YgMjAyMiAwOToyMjo0MyAtMDcwMApTdWJqZWN0OiBbUEFU Q0hdIEVuYWJsZS9kaXNhYmxlICdzZXJ2ZXItbW9kZScgd2hlbiBzdGFydGluZy9zdG9wcGlu ZyB0aGUKIHNlcnZlcgoKKiBsaXNwL3NlcnZlci5lbCAoc2VydmVyLW1vZGUta2V5bWFwKTog TmV3IGtleW1hcC4uLgooc2VydmVyLW1vZGUpOiAuLi4gdXNlIGl0Lgooc2VydmVyLXN0YXJ0 KTogVXBkYXRlIHRoZSAnc2VydmVyLW1vZGUnIHZhcmlhYmxlIChhbmQgc3luYyB0bwonZ2xv YmFsLW1pbm9yLW1vZGVzJykgd2hlbiBzdGFydGluZy9zdG9wcGluZyB0aGUgc2VydmVyLgot LS0KIGxpc3Avc2VydmVyLmVsIHwgMTIgKysrKysrKysrKy0tCiAxIGZpbGUgY2hhbmdlZCwg MTAgaW5zZXJ0aW9ucygrKSwgMiBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9saXNwL3Nl cnZlci5lbCBiL2xpc3Avc2VydmVyLmVsCmluZGV4IDkwZDk3YzE1MzguLjE4NTQ4MTg2YjEg MTAwNjQ0Ci0tLSBhL2xpc3Avc2VydmVyLmVsCisrKyBiL2xpc3Avc2VydmVyLmVsCkBAIC02 NzAsNyArNjcwLDYgQEAgc2VydmVyLXN0YXJ0CiAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgIi90bXAvIikKICAgICAgICAgICAgICAgICAgKGlnbm9yZS1lcnJvcnMKICAgICAgICAg ICAgICAgICAgICAoZGVsZXRlLWRpcmVjdG9yeSAoZmlsZS1uYW1lLWRpcmVjdG9yeSBzZXJ2 ZXItZmlsZSkpKSkpKQotICAgICAgICAgKHNldHEgc2VydmVyLW1vZGUgbmlsKSA7OyBhbHJl YWR5IHNldCBieSB0aGUgbWlub3IgbW9kZSBjb2RlCiAgICAgICAgICAoZGlzcGxheS13YXJu aW5nCiAgICAgICAgICAgJ3NlcnZlcgogICAgICAgICAgIChjb25jYXQgIlVuYWJsZSB0byBz dGFydCB0aGUgRW1hY3Mgc2VydmVyLlxuIgpAQCAtNjg4LDcgKzY4Nyw5IEBAIHNlcnZlci1z dGFydAogICAgICAgKGlmIGxlYXZlLWRlYWQKIAkgIChwcm9nbgogCSAgICAodW5sZXNzIChl cSB0IGxlYXZlLWRlYWQpIChzZXJ2ZXItbG9nIChtZXNzYWdlICJTZXJ2ZXIgc3RvcHBlZCIp KSkKLQkgICAgKHNldHEgc2VydmVyLXByb2Nlc3MgbmlsKSkKKyAgICAgICAgICAgIChzZXRx IHNlcnZlci1tb2RlIG5pbAorICAgICAgICAgICAgICAgICAgZ2xvYmFsLW1pbm9yLW1vZGVz IChkZWxxICdzZXJ2ZXItbW9kZSBnbG9iYWwtbWlub3ItbW9kZXMpCisgICAgICAgICAgICAg ICAgICBzZXJ2ZXItcHJvY2VzcyBuaWwpKQogCTs7IE1ha2Ugc3VyZSB0aGVyZSBpcyBhIHNh ZmUgZGlyZWN0b3J5IGluIHdoaWNoIHRvIHBsYWNlIHRoZSBzb2NrZXQuCiAJKHNlcnZlci1l bnN1cmUtc2FmZS1kaXIgc2VydmVyLWRpcikKIAkod2hlbiBzZXJ2ZXItcHJvY2VzcwpAQCAt NzI4LDYgKzcyOSw4IEBAIHNlcnZlci1zdGFydAogCQkJICAgICAgIDpwbGlzdCAnKDphdXRo ZW50aWNhdGVkIHQpKSkpKQogCSAgKHVubGVzcyBzZXJ2ZXItcHJvY2VzcyAoZXJyb3IgIkNv dWxkIG5vdCBzdGFydCBzZXJ2ZXIgcHJvY2VzcyIpKQogCSAgKHByb2Nlc3MtcHV0IHNlcnZl ci1wcm9jZXNzIDpzZXJ2ZXItZmlsZSBzZXJ2ZXItZmlsZSkKKyAgICAgICAgICAoc2V0cSBz ZXJ2ZXItbW9kZSB0KQorICAgICAgICAgIChwdXNoICdzZXJ2ZXItbW9kZSBnbG9iYWwtbWlu b3ItbW9kZXMpCiAJICAod2hlbiBzZXJ2ZXItdXNlLXRjcAogCSAgICAobGV0ICgoYXV0aC1r ZXkgKHNlcnZlci1nZXQtYXV0aC1rZXkpKSkKIAkgICAgICAocHJvY2Vzcy1wdXQgc2VydmVy LXByb2Nlc3MgOmF1dGgta2V5IGF1dGgta2V5KQpAQCAtNzk2LDYgKzc5OSwxMCBAQCBzZXJ2 ZXItcnVubmluZy1wCiAJdCkKICAgICAoZmlsZS1lcnJvciBuaWwpKSkKIAorOzsgVGhpcyBr ZXltYXAgaXMgZW1wdHksIGJ1dCBhbGxvd3MgdXNlcnMgdG8gZGVmaW5lIGtleWJpbmRpbmdz IHRvIHVzZQorOzsgd2hlbiBgc2VydmVyLW1vZGUnIGlzIGFjdGl2ZS4KKyhkZWZ2YXIta2V5 bWFwIHNlcnZlci1tb2RlLWtleW1hcCkKKwogOzs7IyMjYXV0b2xvYWQKIChkZWZpbmUtbWlu b3ItbW9kZSBzZXJ2ZXItbW9kZQogICAiVG9nZ2xlIFNlcnZlciBtb2RlLgpAQCAtODA1LDYg KzgxMiw3IEBAIHNlcnZlci1tb2RlCiBgc2VydmVyLXN0YXJ0JyBmb3IgZGV0YWlscy4iCiAg IDpnbG9iYWwgdAogICA6dmVyc2lvbiAiMjIuMSIKKyAgOmtleW1hcCBzZXJ2ZXItbW9kZS1r ZXltYXAKICAgOzsgRml4bWU6IFNob3VsZCB0aGlzIGNoZWNrIGZvciBhbiBleGlzdGluZyBz ZXJ2ZXIgc29ja2V0IGFuZCBkbwogICA7OyBub3RoaW5nIGlmIHRoZXJlIGlzIG9uZSAoZm9y IG11bHRpcGxlIEVtYWNzIHNlc3Npb25zKT8KICAgKHNlcnZlci1zdGFydCAobm90IHNlcnZl ci1tb2RlKSkpCi0tIAoyLjI1LjEKCg== --------------MdGdMLhnpGeLoiJ7JGAOQlcC-- From unknown Sun Jun 22 08:05:01 2025 X-Loop: help-debbugs@gnu.org Subject: bug#58909: 29.0.50; [PATCH] Deleting the last frame of an emacsclient doesn't ask to save Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 03 Nov 2022 06:26:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58909 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Jim Porter Cc: 58909@debbugs.gnu.org Received: via spool by 58909-submit@debbugs.gnu.org id=B58909.166745674814420 (code B ref 58909); Thu, 03 Nov 2022 06:26:02 +0000 Received: (at 58909) by debbugs.gnu.org; 3 Nov 2022 06:25:48 +0000 Received: from localhost ([127.0.0.1]:47620 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oqTfg-0003kV-0i for submit@debbugs.gnu.org; Thu, 03 Nov 2022 02:25:48 -0400 Received: from eggs.gnu.org ([209.51.188.92]:53442) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oqTfe-0003kJ-DV for 58909@debbugs.gnu.org; Thu, 03 Nov 2022 02:25:46 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oqTfZ-0000Td-6m; Thu, 03 Nov 2022 02:25:41 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=n+mFryrloSe2zbRgSw57A+U7jfabiQU7V+ZT0hmbXbA=; b=gmEaoEJcm4sM svT6PQohCPF3skS6Zv3oqDWj6RTz9HfBoAtyZKvZbHtnA5JX+TIkjU+KpgOiHZuk88uyBPvC2DEVD CqHelajRgYuiH/1GNwP5RNWzVD6/+YTnTh+JwMC4zfeol7C1PhwHVEW+5P/2nWatZx1u/7+2ooaha nkS4WC2zuy4XOMXQC6oe4Ww1rVyHD9+sCR32j8QiTYqc0m2unMG4V92SCieffpw/e69dQGvFokUwO HHDef7jC4D0EElHx9Ed5++kVwU9/O80JlddP1fiMy4qbp/d83fFTneDXZfqRj2NQjXhQ+xs8et7FC Sj3ItbxIXutUssYenjAtDA==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oqTfX-0007Uo-KB; Thu, 03 Nov 2022 02:25:40 -0400 Date: Thu, 03 Nov 2022 08:25:32 +0200 Message-Id: <83sfj08sgz.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: <1e0f9cc1-03ed-9eea-c6cb-56248607dfe3@gmail.com> (message from Jim Porter on Wed, 2 Nov 2022 15:09:21 -0700) References: <9a70f868-ca50-52fc-af3e-23813af104f2@gmail.com> <83zgdcduxm.fsf@gnu.org> <53238b5b-3e0a-3dfe-eeba-f37cafa81f50@gmail.com> <838rkveq3n.fsf@gnu.org> <7de45884-b4c9-4a4c-777c-5db17b3bacca@gmail.com> <835yfzeobt.fsf@gnu.org> <7694fcf2-8982-9099-5eb8-39835d049847@gmail.com> <83y1svch5u.fsf@gnu.org> <0dc07894-dfa1-01f6-87c4-9e02bfcaf0dc@gmail.com> <83bkppblh7.fsf@gnu.org> <83a6599t7m.fsf@gnu.org> <39e03350-2783-fa90-5d66-26e47abe100d@gmail.com> <835yfx9p0z.fsf@gnu.org> <3d5bc685-889f-f406-0979-10f61db5d1a7@gmail.com> <831qql9n4s.fsf@gnu.org> <83zgd986fi.fsf@gnu.org> <1e0f9cc1-03ed-9eea-c6cb-56248607dfe3@gmail.com> X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Wed, 2 Nov 2022 15:09:21 -0700 > Cc: 58909@debbugs.gnu.org > From: Jim Porter > > >>> I'm fine with doing that, but we must also make sure this mode is > >>> turned on when users invoke server-start interactively. > >> > >> I think that makes sense, and it should be fairly straightforward. I'll > >> work on a patch for this. > > > > Thanks. > > Ok, here's a patch for that. It just sets the 'server-mode' variable > (and 'global-minor-modes' to be polite) inside 'server-start'. It would > probably be more elegant if we could make 'server-start' just call > '(server-mode)' (instead of the other way around like it is now), but I > think it would be hard to do that while staying 100% compatible. Does > this seem ok? Yes, but let's wait for a few days before installing to give people chance to chime in. Thanks. From unknown Sun Jun 22 08:05:01 2025 X-Loop: help-debbugs@gnu.org Subject: bug#58909: 29.0.50; [PATCH] Deleting the last frame of an emacsclient doesn't ask to save Resent-From: Jim Porter Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 06 Nov 2022 20:25:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58909 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Eli Zaretskii Cc: 58909@debbugs.gnu.org Received: via spool by 58909-submit@debbugs.gnu.org id=B58909.16677662512373 (code B ref 58909); Sun, 06 Nov 2022 20:25:01 +0000 Received: (at 58909) by debbugs.gnu.org; 6 Nov 2022 20:24:11 +0000 Received: from localhost ([127.0.0.1]:60725 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ormBe-0000cD-2i for submit@debbugs.gnu.org; Sun, 06 Nov 2022 15:24:11 -0500 Received: from mail-pl1-f177.google.com ([209.85.214.177]:45674) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ormBb-0000br-6M for 58909@debbugs.gnu.org; Sun, 06 Nov 2022 15:24:09 -0500 Received: by mail-pl1-f177.google.com with SMTP id u6so9342609plq.12 for <58909@debbugs.gnu.org>; Sun, 06 Nov 2022 12:24:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:from:references:cc:to:content-language:subject :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=pvQP/sYp8RY2Q/SCtP2XDyP8SpeEW0SJy5GSJrWAxB8=; b=mlGVZIxCFwoshUCe56OqTdwLBxv9bQw3FCJKOZ+oMO4ljSYPrOdA33dRQZaSwDyKPq 9PM/Lfx8A7JZ7kHG8MjG1ao/Ae+6OZ42qkqit7RlY2t3K96lN1u+ksiDAGMc/Q0vsCx2 RkuARr09xQ8asi6EneGNG+8jE4e9ItI+/f8R9u3C/H2YCvj7fchL4Hzre7SuvcHXUkeV cGUwH95w1By1wUykqp/yrAckDo1nMqGovyf7UwjYEeWDjj4T6Q1ojv/bLeLFiZ8PJ/xK TtuToCWrElp6xk1D+xFTbVmbkDqLg9P/O7d4+0n0CFRy3DwXnbNUc3zCd57U0Z1svtD2 1guQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:from:references:cc:to:content-language:subject :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=pvQP/sYp8RY2Q/SCtP2XDyP8SpeEW0SJy5GSJrWAxB8=; b=RpSHYIss+Gn9o2RDJb8cbkBYMCQ+mvP2COfUmepTw2hTxXVPeEaQ1SN5cQ3ee7vJYI KNplO7F5JU34dSq3gjcit6keVr69cnPyM9+bDndYmZc6/rTZYY2OqsarwPl30kYptdW7 7pG8X+O/ri/jLlEdOq6WLFIT9jcqhl8ryCoPs8RUAd3xu3CkjzdKBJOIvs8yJvU92eSS JC1vrRMJwaVKNuVc1lQM25SMKdbpktrbUJGEmYDaV8Go478ZPLx6GUwA1vdtjF93Owc5 /nJ5X0MnHXf5boBQ2gEaNaanycK4sjLcQ0ut9lVQ1bQB+k+hkg9TuYy7I1sTsA9gwuaj K6AA== X-Gm-Message-State: ACrzQf36MC5RaloOujb0WFCuoqrig6gT7jk+S6qDtOTzT8Wh9vRhDC6t nC1uJjZU3J171L5e0DtQR98= X-Google-Smtp-Source: AMsMyM7ofB4bBDZlPaakOTeY4lQ3LANzqmTD3bRw8DAcJ3qmbLjEvrvSf6RuF90FP/4AalDN3JXO+w== X-Received: by 2002:a17:90a:ac03:b0:213:9515:c41f with SMTP id o3-20020a17090aac0300b002139515c41fmr50620426pjq.171.1667766240931; Sun, 06 Nov 2022 12:24:00 -0800 (PST) Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id i13-20020a170902c94d00b00172e19c5f8bsm3515030pla.168.2022.11.06.12.23.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 06 Nov 2022 12:24:00 -0800 (PST) Content-Type: multipart/mixed; boundary="------------sIvWWUcE4KmndGntSsKbphrm" Message-ID: Date: Sun, 6 Nov 2022 12:23:58 -0800 MIME-Version: 1.0 Content-Language: en-US References: <9a70f868-ca50-52fc-af3e-23813af104f2@gmail.com> <83zgdcduxm.fsf@gnu.org> <53238b5b-3e0a-3dfe-eeba-f37cafa81f50@gmail.com> <838rkveq3n.fsf@gnu.org> <7de45884-b4c9-4a4c-777c-5db17b3bacca@gmail.com> <835yfzeobt.fsf@gnu.org> <7694fcf2-8982-9099-5eb8-39835d049847@gmail.com> <83y1svch5u.fsf@gnu.org> <0dc07894-dfa1-01f6-87c4-9e02bfcaf0dc@gmail.com> <83bkppblh7.fsf@gnu.org> <83a6599t7m.fsf@gnu.org> <39e03350-2783-fa90-5d66-26e47abe100d@gmail.com> <835yfx9p0z.fsf@gnu.org> <3d5bc685-889f-f406-0979-10f61db5d1a7@gmail.com> <831qql9n4s.fsf@gnu.org> <83zgd986fi.fsf@gnu.org> <1e0f9cc1-03ed-9eea-c6cb-56248607dfe3@gmail.com> <83sfj08sgz.fsf@gnu.org> From: Jim Porter In-Reply-To: <83sfj08sgz.fsf@gnu.org> X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) This is a multi-part message in MIME format. --------------sIvWWUcE4KmndGntSsKbphrm Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 11/2/2022 11:25 PM, Eli Zaretskii wrote: >> Date: Wed, 2 Nov 2022 15:09:21 -0700 >> Cc: 58909@debbugs.gnu.org >> From: Jim Porter >> >> Ok, here's a patch for that. It just sets the 'server-mode' variable >> (and 'global-minor-modes' to be polite) inside 'server-start'. It would >> probably be more elegant if we could make 'server-start' just call >> '(server-mode)' (instead of the other way around like it is now), but I >> think it would be hard to do that while staying 100% compatible. Does >> this seem ok? > > Yes, but let's wait for a few days before installing to give people > chance to chime in. Sounds good to me. In the meantime, I added some regression tests for my change (see the first attached patch). I'll take a look at adding some more tests for server.el code too (in another bug#, though). I also attached a second patch to show an idea I had: since the first patch adds a minor-mode keymap for 'server-mode' (and ensures that the mode is activated whenever the server is running), we could get rid of the server-specific logic from lisp/files.el. Instead of mapping 'C-x C-c' to 'save-buffers-kill-terminal' all the time, Emacs could map it to 'save-buffers-kill-emacs' by default. Then, when the server is running, remap 'save-buffers-kill-emacs' to 'save-buffers-kill-terminal'. Given that the old code already works, I'm not sure this change is worth the risk (it would be very bad if I made a mistake and broke the ability to exit Emacs). Still, I *think* this should work just the same as the old code, and it helps keep server-specific code inside server.el. I don't have any strong opinions on whether this second patch should get merged (I'm totally fine with throwing it out), but I wanted to show off at least one theoretical benefit of the new keymap. --------------sIvWWUcE4KmndGntSsKbphrm Content-Type: text/plain; charset=UTF-8; name="0001-Enable-disable-server-mode-when-starting-stopping-th.patch" Content-Disposition: attachment; filename*0="0001-Enable-disable-server-mode-when-starting-stopping-th.pa"; filename*1="tch" Content-Transfer-Encoding: base64 RnJvbSAyNGE1MWYwODBmMGU3OTBiMDY4MWExNzQ1ZmQzMmY3ZDk2NzQzN2UxIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKaW0gUG9ydGVyIDxqcG9ydGVyYnVnc0BnbWFpbC5j b20+CkRhdGU6IFdlZCwgMiBOb3YgMjAyMiAwOToyMjo0MyAtMDcwMApTdWJqZWN0OiBbUEFU Q0ggMS8yXSBFbmFibGUvZGlzYWJsZSAnc2VydmVyLW1vZGUnIHdoZW4gc3RhcnRpbmcvc3Rv cHBpbmcgdGhlCiBzZXJ2ZXIKCiogbGlzcC9zZXJ2ZXIuZWwgKHNlcnZlci1tb2RlLW1hcCk6 IE5ldyBrZXltYXAuLi4KKHNlcnZlci1tb2RlKTogLi4uIHVzZSBpdC4KKHNlcnZlci1zdGFy dCk6IFVwZGF0ZSB0aGUgJ3NlcnZlci1tb2RlJyB2YXJpYWJsZSAoYW5kIHN5bmMgdG8KJ2ds b2JhbC1taW5vci1tb2RlcycpIHdoZW4gc3RhcnRpbmcvc3RvcHBpbmcgdGhlIHNlcnZlci4K CiogdGVzdC9saXNwL3NlcnZlci10ZXN0cy5lbDogTmV3IGZpbGUuCi0tLQogbGlzcC9zZXJ2 ZXIuZWwgICAgICAgICAgICB8IDEyICsrKysrKysrKystLQogdGVzdC9saXNwL3NlcnZlci10 ZXN0cy5lbCB8IDQxICsrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKwog MiBmaWxlcyBjaGFuZ2VkLCA1MSBpbnNlcnRpb25zKCspLCAyIGRlbGV0aW9ucygtKQogY3Jl YXRlIG1vZGUgMTAwNjQ0IHRlc3QvbGlzcC9zZXJ2ZXItdGVzdHMuZWwKCmRpZmYgLS1naXQg YS9saXNwL3NlcnZlci5lbCBiL2xpc3Avc2VydmVyLmVsCmluZGV4IDkwZDk3YzE1MzguLjU1 Mzg5MGNlMjkgMTAwNjQ0Ci0tLSBhL2xpc3Avc2VydmVyLmVsCisrKyBiL2xpc3Avc2VydmVy LmVsCkBAIC02NzAsNyArNjcwLDYgQEAgc2VydmVyLXN0YXJ0CiAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgIi90bXAvIikKICAgICAgICAgICAgICAgICAgKGlnbm9yZS1lcnJvcnMK ICAgICAgICAgICAgICAgICAgICAoZGVsZXRlLWRpcmVjdG9yeSAoZmlsZS1uYW1lLWRpcmVj dG9yeSBzZXJ2ZXItZmlsZSkpKSkpKQotICAgICAgICAgKHNldHEgc2VydmVyLW1vZGUgbmls KSA7OyBhbHJlYWR5IHNldCBieSB0aGUgbWlub3IgbW9kZSBjb2RlCiAgICAgICAgICAoZGlz cGxheS13YXJuaW5nCiAgICAgICAgICAgJ3NlcnZlcgogICAgICAgICAgIChjb25jYXQgIlVu YWJsZSB0byBzdGFydCB0aGUgRW1hY3Mgc2VydmVyLlxuIgpAQCAtNjg4LDcgKzY4Nyw5IEBA IHNlcnZlci1zdGFydAogICAgICAgKGlmIGxlYXZlLWRlYWQKIAkgIChwcm9nbgogCSAgICAo dW5sZXNzIChlcSB0IGxlYXZlLWRlYWQpIChzZXJ2ZXItbG9nIChtZXNzYWdlICJTZXJ2ZXIg c3RvcHBlZCIpKSkKLQkgICAgKHNldHEgc2VydmVyLXByb2Nlc3MgbmlsKSkKKyAgICAgICAg ICAgIChzZXRxIHNlcnZlci1tb2RlIG5pbAorICAgICAgICAgICAgICAgICAgZ2xvYmFsLW1p bm9yLW1vZGVzIChkZWxxICdzZXJ2ZXItbW9kZSBnbG9iYWwtbWlub3ItbW9kZXMpCisgICAg ICAgICAgICAgICAgICBzZXJ2ZXItcHJvY2VzcyBuaWwpKQogCTs7IE1ha2Ugc3VyZSB0aGVy ZSBpcyBhIHNhZmUgZGlyZWN0b3J5IGluIHdoaWNoIHRvIHBsYWNlIHRoZSBzb2NrZXQuCiAJ KHNlcnZlci1lbnN1cmUtc2FmZS1kaXIgc2VydmVyLWRpcikKIAkod2hlbiBzZXJ2ZXItcHJv Y2VzcwpAQCAtNzI4LDYgKzcyOSw4IEBAIHNlcnZlci1zdGFydAogCQkJICAgICAgIDpwbGlz dCAnKDphdXRoZW50aWNhdGVkIHQpKSkpKQogCSAgKHVubGVzcyBzZXJ2ZXItcHJvY2VzcyAo ZXJyb3IgIkNvdWxkIG5vdCBzdGFydCBzZXJ2ZXIgcHJvY2VzcyIpKQogCSAgKHByb2Nlc3Mt cHV0IHNlcnZlci1wcm9jZXNzIDpzZXJ2ZXItZmlsZSBzZXJ2ZXItZmlsZSkKKyAgICAgICAg ICAoc2V0cSBzZXJ2ZXItbW9kZSB0KQorICAgICAgICAgIChwdXNoICdzZXJ2ZXItbW9kZSBn bG9iYWwtbWlub3ItbW9kZXMpCiAJICAod2hlbiBzZXJ2ZXItdXNlLXRjcAogCSAgICAobGV0 ICgoYXV0aC1rZXkgKHNlcnZlci1nZXQtYXV0aC1rZXkpKSkKIAkgICAgICAocHJvY2Vzcy1w dXQgc2VydmVyLXByb2Nlc3MgOmF1dGgta2V5IGF1dGgta2V5KQpAQCAtNzk2LDYgKzc5OSwx MCBAQCBzZXJ2ZXItcnVubmluZy1wCiAJdCkKICAgICAoZmlsZS1lcnJvciBuaWwpKSkKIAor OzsgVGhpcyBrZXltYXAgaXMgZW1wdHksIGJ1dCBhbGxvd3MgdXNlcnMgdG8gZGVmaW5lIGtl eWJpbmRpbmdzIHRvIHVzZQorOzsgd2hlbiBgc2VydmVyLW1vZGUnIGlzIGFjdGl2ZS4KKyhk ZWZ2YXIta2V5bWFwIHNlcnZlci1tb2RlLW1hcCkKKwogOzs7IyMjYXV0b2xvYWQKIChkZWZp bmUtbWlub3ItbW9kZSBzZXJ2ZXItbW9kZQogICAiVG9nZ2xlIFNlcnZlciBtb2RlLgpAQCAt ODA1LDYgKzgxMiw3IEBAIHNlcnZlci1tb2RlCiBgc2VydmVyLXN0YXJ0JyBmb3IgZGV0YWls cy4iCiAgIDpnbG9iYWwgdAogICA6dmVyc2lvbiAiMjIuMSIKKyAgOmtleW1hcCBzZXJ2ZXIt bW9kZS1tYXAKICAgOzsgRml4bWU6IFNob3VsZCB0aGlzIGNoZWNrIGZvciBhbiBleGlzdGlu ZyBzZXJ2ZXIgc29ja2V0IGFuZCBkbwogICA7OyBub3RoaW5nIGlmIHRoZXJlIGlzIG9uZSAo Zm9yIG11bHRpcGxlIEVtYWNzIHNlc3Npb25zKT8KICAgKHNlcnZlci1zdGFydCAobm90IHNl cnZlci1tb2RlKSkpCmRpZmYgLS1naXQgYS90ZXN0L2xpc3Avc2VydmVyLXRlc3RzLmVsIGIv dGVzdC9saXNwL3NlcnZlci10ZXN0cy5lbApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAw MDAwMDAwMDAwLi4zNTFiOGVmOGQxCi0tLSAvZGV2L251bGwKKysrIGIvdGVzdC9saXNwL3Nl cnZlci10ZXN0cy5lbApAQCAtMCwwICsxLDQxIEBACis7Ozsgc2VydmVyLXRlc3RzLmVsIC0t LSBFbWFjcyBzZXJ2ZXIgdGVzdCBzdWl0ZSAgLSotIGxleGljYWwtYmluZGluZzp0IC0qLQor Cis7OyBDb3B5cmlnaHQgKEMpIDIwMjIgRnJlZSBTb2Z0d2FyZSBGb3VuZGF0aW9uLCBJbmMu CisKKzs7IFRoaXMgZmlsZSBpcyBwYXJ0IG9mIEdOVSBFbWFjcy4KKworOzsgR05VIEVtYWNz IGlzIGZyZWUgc29mdHdhcmU6IHlvdSBjYW4gcmVkaXN0cmlidXRlIGl0IGFuZC9vciBtb2Rp ZnkKKzs7IGl0IHVuZGVyIHRoZSB0ZXJtcyBvZiB0aGUgR05VIEdlbmVyYWwgUHVibGljIExp Y2Vuc2UgYXMgcHVibGlzaGVkIGJ5Cis7OyB0aGUgRnJlZSBTb2Z0d2FyZSBGb3VuZGF0aW9u LCBlaXRoZXIgdmVyc2lvbiAzIG9mIHRoZSBMaWNlbnNlLCBvcgorOzsgKGF0IHlvdXIgb3B0 aW9uKSBhbnkgbGF0ZXIgdmVyc2lvbi4KKworOzsgR05VIEVtYWNzIGlzIGRpc3RyaWJ1dGVk IGluIHRoZSBob3BlIHRoYXQgaXQgd2lsbCBiZSB1c2VmdWwsCis7OyBidXQgV0lUSE9VVCBB TlkgV0FSUkFOVFk7IHdpdGhvdXQgZXZlbiB0aGUgaW1wbGllZCB3YXJyYW50eSBvZgorOzsg TUVSQ0hBTlRBQklMSVRZIG9yIEZJVE5FU1MgRk9SIEEgUEFSVElDVUxBUiBQVVJQT1NFLiAg U2VlIHRoZQorOzsgR05VIEdlbmVyYWwgUHVibGljIExpY2Vuc2UgZm9yIG1vcmUgZGV0YWls cy4KKworOzsgWW91IHNob3VsZCBoYXZlIHJlY2VpdmVkIGEgY29weSBvZiB0aGUgR05VIEdl bmVyYWwgUHVibGljIExpY2Vuc2UKKzs7IGFsb25nIHdpdGggR05VIEVtYWNzLiAgSWYgbm90 LCBzZWUgPGh0dHBzOi8vd3d3LmdudS5vcmcvbGljZW5zZXMvPi4KKworOzs7IENvZGU6CisK KyhyZXF1aXJlICdlcnQpCisocmVxdWlyZSAnc2VydmVyKQorCis7OzsgVGVzdHM6CisKKyhl cnQtZGVmdGVzdCBzZXJ2ZXItdGVzdC9zZXJ2ZXItc3RhcnQtc2V0cy1taW5vci1tb2RlICgp CisgICJFbnN1cmUgdGhhdCBjYWxsaW5nIGBzZXJ2ZXItc3RhcnQnIGFsc28gc2V0cyBgc2Vy dmVyLW1vZGUnIHByb3Blcmx5LiIKKyAgKHNlcnZlci1zdGFydCkKKyAgKHVud2luZC1wcm90 ZWN0CisgICAgICAocHJvZ24KKyAgICAgICAgOzsgTWFrZSBzdXJlIHN0YXJ0aW5nIHRoZSBz ZXJ2ZXIgYWN0aXZhdGVzIHRoZSBtaW5vciBtb2RlLgorICAgICAgICAoc2hvdWxkIChlcSBz ZXJ2ZXItbW9kZSB0KSkKKyAgICAgICAgKHNob3VsZCAobWVtcSAnc2VydmVyLW1vZGUgZ2xv YmFsLW1pbm9yLW1vZGVzKSkpCisgICAgOzsgQWx3YXlzIHN0b3AgdGhlIHNlcnZlciwgZXZl biBpZiB0aGUgYWJvdmUgY2hlY2tzIGZhaWwuCisgICAgKHNlcnZlci1zdGFydCB0KSkKKyAg OzsgTWFrZSBzdXJlIHN0b3BwaW5nIHRoZSBzZXJ2ZXIgZGVhY3RpdmF0ZXMgdGhlIG1pbm9y IG1vZGUuCisgIChzaG91bGQgKGVxIHNlcnZlci1tb2RlIG5pbCkpCisgIChzaG91bGQtbm90 IChtZW1xICdzZXJ2ZXItbW9kZSBnbG9iYWwtbWlub3ItbW9kZXMpKSkKKworOzs7IHNlcnZl ci10ZXN0cy5lbCBlbmRzIGhlcmUKLS0gCjIuMjUuMQoK --------------sIvWWUcE4KmndGntSsKbphrm Content-Type: text/plain; charset=UTF-8; name="0002-IDEA-Take-advantage-of-new-server-mode-map-to-handle.patch" Content-Disposition: attachment; filename*0="0002-IDEA-Take-advantage-of-new-server-mode-map-to-handle.pa"; filename*1="tch" Content-Transfer-Encoding: base64 RnJvbSBkNGQwOGFlYzBiMDY2OWUxMTFiZWYyNjEzNzc1MDIwZjI0YWI5NTYyIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKaW0gUG9ydGVyIDxqcG9ydGVyYnVnc0BnbWFpbC5j b20+CkRhdGU6IFN1biwgNiBOb3YgMjAyMiAxMjowNTo0NSAtMDgwMApTdWJqZWN0OiBbUEFU Q0ggMi8yXSBbSURFQV0gVGFrZSBhZHZhbnRhZ2Ugb2YgbmV3ICdzZXJ2ZXItbW9kZS1tYXAn IHRvIGhhbmRsZQogcmVtYXBwaW5nICdDLXggQy1jJwoKLS0tCiBkb2MvZW1hY3MvZW50ZXJp bmcudGV4aSB8ICA2ICsrKy0tLQogZG9jL2xpc3ByZWYvb3MudGV4aSAgICAgfCAyMCArKysr KysrKysrLS0tLS0tLS0tLQogbGlzcC9maWxlcy5lbCAgICAgICAgICAgfCAxNiArLS0tLS0t LS0tLS0tLS0tCiBsaXNwL2hlbHAuZWwgICAgICAgICAgICB8ICAyICstCiBsaXNwL21lbnUt YmFyLmVsICAgICAgICB8ICAyICstCiBsaXNwL3NlcnZlci5lbCAgICAgICAgICB8IDIwICsr KysrKysrKysrKysrKysrLS0tCiBsaXNwL3N0YXJ0dXAuZWwgICAgICAgICB8ICAyICstCiBs aXNwL3R1dG9yaWFsLmVsICAgICAgICB8ICAyICstCiA4IGZpbGVzIGNoYW5nZWQsIDM1IGlu c2VydGlvbnMoKyksIDM1IGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL2RvYy9lbWFjcy9l bnRlcmluZy50ZXhpIGIvZG9jL2VtYWNzL2VudGVyaW5nLnRleGkKaW5kZXggNjA2OWRhMDM4 MC4uNzZlNWJmY2EwZiAxMDA2NDQKLS0tIGEvZG9jL2VtYWNzL2VudGVyaW5nLnRleGkKKysr IGIvZG9jL2VtYWNzL2VudGVyaW5nLnRleGkKQEAgLTk4LDE2ICs5OCwxNiBAQCBFeGl0aW5n CiAKIEB0YWJsZSBAa2JkCiBAaXRlbSBDLXggQy1jCi1LaWxsIEVtYWNzIChAY29kZXtzYXZl LWJ1ZmZlcnMta2lsbC10ZXJtaW5hbH0pLgorS2lsbCBFbWFjcyAoQGNvZGV7c2F2ZS1idWZm ZXJzLWtpbGwtZW1hY3N9KS4KIEBpdGVtIEMtegogT24gYSB0ZXh0IHRlcm1pbmFsLCBzdXNw ZW5kIEVtYWNzOyBvbiBhIGdyYXBoaWNhbCBkaXNwbGF5LAogaWNvbmlmeSAob3IgYGBtaW5p bWl6ZScnKSB0aGUgc2VsZWN0ZWQgZnJhbWUgKEBjb2Rle3N1c3BlbmQtZnJhbWV9KS4KIEBl bmQgdGFibGUKIAogQGtpbmRleCBDLXggQy1jCi1AZmluZGV4IHNhdmUtYnVmZmVycy1raWxs LXRlcm1pbmFsCitAZmluZGV4IHNhdmUtYnVmZmVycy1raWxsLWVtYWNzCiAgIEBkZm57S2ls bGluZ30gRW1hY3MgbWVhbnMgdGVybWluYXRpbmcgdGhlIEVtYWNzIHByb2dyYW0uICBUbyBk bwotdGhpcywgdHlwZSBAa2Jke0MteCBDLWN9IChAY29kZXtzYXZlLWJ1ZmZlcnMta2lsbC10 ZXJtaW5hbH0pLiAgQQordGhpcywgdHlwZSBAa2Jke0MteCBDLWN9IChAY29kZXtzYXZlLWJ1 ZmZlcnMta2lsbC1lbWFjc30pLiAgQQogdHdvLWNoYXJhY3RlciBrZXkgc2VxdWVuY2UgaXMg dXNlZCB0byBtYWtlIGl0IGhhcmRlciB0byB0eXBlIGJ5CiBhY2NpZGVudC4gIElmIHRoZXJl IGFyZSBhbnkgbW9kaWZpZWQgZmlsZS12aXNpdGluZyBidWZmZXJzIHdoZW4geW91CiB0eXBl IEBrYmR7Qy14IEMtY30sIEVtYWNzIGZpcnN0IG9mZmVycyB0byBzYXZlIHRoZXNlIGJ1ZmZl cnMuICBJZiB5b3UKZGlmZiAtLWdpdCBhL2RvYy9saXNwcmVmL29zLnRleGkgYi9kb2MvbGlz cHJlZi9vcy50ZXhpCmluZGV4IDNlMTZhYzBlYjQuLmZjYWQ0NDllMGMgMTAwNjQ0Ci0tLSBh L2RvYy9saXNwcmVmL29zLnRleGkKKysrIGIvZG9jL2xpc3ByZWYvb3MudGV4aQpAQCAtNzI1 LDEyICs3MjUsMTIgQEAgS2lsbGluZyBFbWFjcwogQGNpbmRleCBTSUdJTlQKIEBjaW5kZXgg b3BlcmF0aW5nIHN5c3RlbSBzaWduYWwKICAgVGhlIEBjb2Rle2tpbGwtZW1hY3N9IGZ1bmN0 aW9uIGlzIG5vcm1hbGx5IGNhbGxlZCB2aWEgdGhlCi1oaWdoZXItbGV2ZWwgY29tbWFuZCBA a2Jke0MteCBDLWN9Ci0oQGNvZGV7c2F2ZS1idWZmZXJzLWtpbGwtdGVybWluYWx9KS4gIEB4 cmVme0V4aXRpbmcsLCwgZW1hY3MsIFRoZSBHTlUKLUVtYWNzIE1hbnVhbH0uICBJdCBpcyBh bHNvIGNhbGxlZCBhdXRvbWF0aWNhbGx5IGlmIEVtYWNzIHJlY2VpdmVzIGEKLUBjb2Rle1NJ R1RFUk19IG9yIEBjb2Rle1NJR0hVUH0gb3BlcmF0aW5nIHN5c3RlbSBzaWduYWwgKGUuZy4s IHdoZW4gdGhlCi1jb250cm9sbGluZyB0ZXJtaW5hbCBpcyBkaXNjb25uZWN0ZWQpLCBvciBp ZiBpdCByZWNlaXZlcyBhCi1AY29kZXtTSUdJTlR9IHNpZ25hbCB3aGlsZSBydW5uaW5nIGlu IGJhdGNoIG1vZGUgKEBweHJlZntCYXRjaCBNb2RlfSkuCitoaWdoZXItbGV2ZWwgY29tbWFu ZCBAa2Jke0MteCBDLWN9IChAY29kZXtzYXZlLWJ1ZmZlcnMta2lsbC1lbWFjc30pLgorQHhy ZWZ7RXhpdGluZywsLCBlbWFjcywgVGhlIEdOVSBFbWFjcyBNYW51YWx9LiAgSXQgaXMgYWxz byBjYWxsZWQKK2F1dG9tYXRpY2FsbHkgaWYgRW1hY3MgcmVjZWl2ZXMgYSBAY29kZXtTSUdU RVJNfSBvciBAY29kZXtTSUdIVVB9CitvcGVyYXRpbmcgc3lzdGVtIHNpZ25hbCAoZS5nLiwg d2hlbiB0aGUgY29udHJvbGxpbmcgdGVybWluYWwgaXMKK2Rpc2Nvbm5lY3RlZCksIG9yIGlm IGl0IHJlY2VpdmVzIGEgQGNvZGV7U0lHSU5UfSBzaWduYWwgd2hpbGUgcnVubmluZworaW4g YmF0Y2ggbW9kZSAoQHB4cmVme0JhdGNoIE1vZGV9KS4KIAogQGRlZnZhciBraWxsLWVtYWNz LWhvb2sKIFRoaXMgbm9ybWFsIGhvb2sgaXMgcnVuIGJ5IEBjb2Rle2tpbGwtZW1hY3N9LCBi ZWZvcmUgaXQga2lsbHMgRW1hY3MuCkBAIC03NDUsMTIgKzc0NSwxMiBAQCBLaWxsaW5nIEVt YWNzCiAgIFdoZW4gRW1hY3MgaXMga2lsbGVkLCBhbGwgdGhlIGluZm9ybWF0aW9uIGluIHRo ZSBFbWFjcyBwcm9jZXNzLAogYXNpZGUgZnJvbSBmaWxlcyB0aGF0IGhhdmUgYmVlbiBzYXZl ZCwgaXMgbG9zdC4gIEJlY2F1c2Uga2lsbGluZyBFbWFjcwogaW5hZHZlcnRlbnRseSBjYW4g bG9zZSBhIGxvdCBvZiB3b3JrLCB0aGUKLUBjb2Rle3NhdmUtYnVmZmVycy1raWxsLXRlcm1p bmFsfSBjb21tYW5kIHF1ZXJpZXMgZm9yIGNvbmZpcm1hdGlvbiBpZgoteW91IGhhdmUgYnVm ZmVycyB0aGF0IG5lZWQgc2F2aW5nIG9yIHN1YnByb2Nlc3NlcyB0aGF0IGFyZSBydW5uaW5n LgotSXQgYWxzbyBydW5zIHRoZSBhYm5vcm1hbCBob29rIEBjb2Rle2tpbGwtZW1hY3MtcXVl cnktZnVuY3Rpb25zfToKK0Bjb2Rle3NhdmUtYnVmZmVycy1raWxsLWVtYWNzfSBjb21tYW5k IHF1ZXJpZXMgZm9yIGNvbmZpcm1hdGlvbiBpZiB5b3UKK2hhdmUgYnVmZmVycyB0aGF0IG5l ZWQgc2F2aW5nIG9yIHN1YnByb2Nlc3NlcyB0aGF0IGFyZSBydW5uaW5nLiAgSXQKK2Fsc28g cnVucyB0aGUgYWJub3JtYWwgaG9vayBAY29kZXtraWxsLWVtYWNzLXF1ZXJ5LWZ1bmN0aW9u c306CiAKIEBkZWZvcHQga2lsbC1lbWFjcy1xdWVyeS1mdW5jdGlvbnMKLVdoZW4gQGNvZGV7 c2F2ZS1idWZmZXJzLWtpbGwtdGVybWluYWx9IGlzIGtpbGxpbmcgRW1hY3MsIGl0IGNhbGxz IHRoZQorV2hlbiBAY29kZXtzYXZlLWJ1ZmZlcnMta2lsbC1lbWFjc30gaXMga2lsbGluZyBF bWFjcywgaXQgY2FsbHMgdGhlCiBmdW5jdGlvbnMgaW4gdGhpcyBob29rLCBhZnRlciBhc2tp bmcgdGhlIHN0YW5kYXJkIHF1ZXN0aW9ucyBhbmQgYmVmb3JlCiBjYWxsaW5nIEBjb2Rle2tp bGwtZW1hY3N9LiAgVGhlIGZ1bmN0aW9ucyBhcmUgY2FsbGVkIGluIG9yZGVyIG9mCiBhcHBl YXJhbmNlLCB3aXRoIG5vIGFyZ3VtZW50cy4gIEVhY2ggZnVuY3Rpb24gY2FuIGFzayBmb3Ig YWRkaXRpb25hbApkaWZmIC0tZ2l0IGEvbGlzcC9maWxlcy5lbCBiL2xpc3AvZmlsZXMuZWwK aW5kZXggYTI4MjUzMjI1OC4uOWY4OGEzZTY0NiAxMDA2NDQKLS0tIGEvbGlzcC9maWxlcy5l bAorKysgYi9saXNwL2ZpbGVzLmVsCkBAIC04MDcyLDIwICs4MDcyLDYgQEAgc2F2ZS1idWZm ZXJzLWtpbGwtZW1hY3MKICAgICAgICAgIChmdW5jYWxsIGNvbmZpcm0gIlJlYWxseSBleGl0 IEVtYWNzPyAiKSkKICAgICAgKGtpbGwtZW1hY3MgbmlsIHJlc3RhcnQpKSkpCiAKLShkZWZ1 biBzYXZlLWJ1ZmZlcnMta2lsbC10ZXJtaW5hbCAoJm9wdGlvbmFsIGFyZykKLSAgIk9mZmVy IHRvIHNhdmUgZWFjaCBidWZmZXIsIHRoZW4ga2lsbCB0aGUgY3VycmVudCBjb25uZWN0aW9u LgotSWYgdGhlIGN1cnJlbnQgZnJhbWUgaGFzIG5vIGNsaWVudCwga2lsbCBFbWFjcyBpdHNl bGYgdXNpbmcKLWBzYXZlLWJ1ZmZlcnMta2lsbC1lbWFjcycuCi0KLVdpdGggcHJlZml4IEFS Rywgc2lsZW50bHkgc2F2ZSBhbGwgZmlsZS12aXNpdGluZyBidWZmZXJzLCB0aGVuIGtpbGwu Ci0KLUlmIGVtYWNzY2xpZW50IHdhcyBzdGFydGVkIHdpdGggYSBsaXN0IG9mIGZpbGUgbmFt ZXMgdG8gZWRpdCwgdGhlbgotb25seSB0aGVzZSBmaWxlcyB3aWxsIGJlIGFza2VkIHRvIGJl IHNhdmVkLiIKLSAgKGludGVyYWN0aXZlICJQIikKLSAgKGlmIChmcmFtZS1wYXJhbWV0ZXIg bmlsICdjbGllbnQpCi0gICAgICAoc2VydmVyLXNhdmUtYnVmZmVycy1raWxsLXRlcm1pbmFs IGFyZykKLSAgICAoc2F2ZS1idWZmZXJzLWtpbGwtZW1hY3MgYXJnKSkpCi0KIChkZWZ1biBy ZXN0YXJ0LWVtYWNzICgpCiAgICJLaWxsIHRoZSBjdXJyZW50IEVtYWNzIHByb2Nlc3MgYW5k IHN0YXJ0IGEgbmV3IG9uZS4KIFRoaXMgZ29lcyB0aHJvdWdoIHRoZSBzYW1lIHNodXRkb3du IHByb2NlZHVyZSBhcwpAQCAtODcwMCw3ICs4Njg2LDcgQEAgY3RsLXgtbWFwCiAoZGVmaW5l LWtleSBjdGwteC1tYXAgImkiICdpbnNlcnQtZmlsZSkKIChkZWZpbmUta2V5IGVzYy1tYXAg In4iICdub3QtbW9kaWZpZWQpCiAoZGVmaW5lLWtleSBjdGwteC1tYXAgIlxDLWQiICdsaXN0 LWRpcmVjdG9yeSkKLShkZWZpbmUta2V5IGN0bC14LW1hcCAiXEMtYyIgJ3NhdmUtYnVmZmVy cy1raWxsLXRlcm1pbmFsKQorKGRlZmluZS1rZXkgY3RsLXgtbWFwICJcQy1jIiAnc2F2ZS1i dWZmZXJzLWtpbGwtZW1hY3MpCiAoZGVmaW5lLWtleSBjdGwteC1tYXAgIlxDLXEiICdyZWFk LW9ubHktbW9kZSkKIAogKGRlZmluZS1rZXkgY3RsLXgtNC1tYXAgImYiICdmaW5kLWZpbGUt b3RoZXItd2luZG93KQpkaWZmIC0tZ2l0IGEvbGlzcC9oZWxwLmVsIGIvbGlzcC9oZWxwLmVs CmluZGV4IGIyNWE4Y2UyOTkuLjQxZjY1NDk2NWQgMTAwNjQ0Ci0tLSBhL2xpc3AvaGVscC5l bAorKysgYi9saXNwL2hlbHAuZWwKQEAgLTEzMCw3ICsxMzAsNyBAQCBoZWxwLWJ1dHRvbi1j YWNoZQogCiAoZGVmdmFyIGhlbHAtcXVpY2stc2VjdGlvbnMKICAgJygoIkZpbGUiCi0gICAg IChzYXZlLWJ1ZmZlcnMta2lsbC10ZXJtaW5hbCAuICJleGl0IikKKyAgICAgKHNhdmUtYnVm ZmVycy1raWxsLWVtYWNzIC4gImV4aXQiKQogICAgICAoZmluZC1maWxlIC4gImZpbmQiKQog ICAgICAod3JpdGUtZmlsZSAuICJ3cml0ZSIpCiAgICAgIChzYXZlLWJ1ZmZlciAuICJzYXZl IikKZGlmZiAtLWdpdCBhL2xpc3AvbWVudS1iYXIuZWwgYi9saXNwL21lbnUtYmFyLmVsCmlu ZGV4IDg0OWUwZjc3MjMuLjRlNzQ2YzM0ODMgMTAwNjQ0Ci0tLSBhL2xpc3AvbWVudS1iYXIu ZWwKKysrIGIvbGlzcC9tZW51LWJhci5lbApAQCAtODQsNyArODQsNyBAQCBtZW51LWJhci1m aWxlLW1lbnUKIAogICAgIDs7IFRoZSAiRmlsZSIgbWVudSBpdGVtcwogICAgIChiaW5kaW5n cy0tZGVmaW5lLWtleSBtZW51IFtleGl0LWVtYWNzXQotICAgICAgJyhtZW51LWl0ZW0gIlF1 aXQiIHNhdmUtYnVmZmVycy1raWxsLXRlcm1pbmFsCisgICAgICAnKG1lbnUtaXRlbSAiUXVp dCIgc2F2ZS1idWZmZXJzLWtpbGwtZW1hY3MKICAgICAgICAgICAgICAgICAgIDpoZWxwICJT YXZlIHVuc2F2ZWQgYnVmZmVycywgdGhlbiBleGl0IikpCiAKICAgICAoYmluZGluZ3MtLWRl ZmluZS1rZXkgbWVudSBbc2VwYXJhdG9yLWV4aXRdCmRpZmYgLS1naXQgYS9saXNwL3NlcnZl ci5lbCBiL2xpc3Avc2VydmVyLmVsCmluZGV4IDU1Mzg5MGNlMjkuLmFmNzlmYTA0NmYgMTAw NjQ0Ci0tLSBhL2xpc3Avc2VydmVyLmVsCisrKyBiL2xpc3Avc2VydmVyLmVsCkBAIC03OTks OSArNzk5LDggQEAgc2VydmVyLXJ1bm5pbmctcAogCXQpCiAgICAgKGZpbGUtZXJyb3Igbmls KSkpCiAKLTs7IFRoaXMga2V5bWFwIGlzIGVtcHR5LCBidXQgYWxsb3dzIHVzZXJzIHRvIGRl ZmluZSBrZXliaW5kaW5ncyB0byB1c2UKLTs7IHdoZW4gYHNlcnZlci1tb2RlJyBpcyBhY3Rp dmUuCi0oZGVmdmFyLWtleW1hcCBzZXJ2ZXItbW9kZS1tYXApCisoZGVmdmFyLWtleW1hcCBz ZXJ2ZXItbW9kZS1tYXAKKyAgIjxyZW1hcD4gPHNhdmUtYnVmZmVycy1raWxsLWVtYWNzPiIg IydzYXZlLWJ1ZmZlcnMta2lsbC10ZXJtaW5hbCkKIAogOzs7IyMjYXV0b2xvYWQKIChkZWZp bmUtbWlub3ItbW9kZSBzZXJ2ZXItbW9kZQpAQCAtMTc3Myw2ICsxNzcyLDIxIEBAIHNlcnZl ci1zYXZlLWJ1ZmZlcnMta2lsbC10ZXJtaW5hbAogCSAgICAgICAoc2VydmVyLWRlbGV0ZS1j bGllbnQgcHJvYykpKQogCSAgICAodCAoZXJyb3IgIkludmFsaWQgY2xpZW50IGZyYW1lIikp KSkpKQogCis7OzsjIyNhdXRvbG9hZAorKGRlZnVuIHNhdmUtYnVmZmVycy1raWxsLXRlcm1p bmFsICgmb3B0aW9uYWwgYXJnKQorICAiT2ZmZXIgdG8gc2F2ZSBlYWNoIGJ1ZmZlciwgdGhl biBraWxsIHRoZSBjdXJyZW50IGNvbm5lY3Rpb24uCitJZiB0aGUgY3VycmVudCBmcmFtZSBo YXMgbm8gY2xpZW50LCBraWxsIEVtYWNzIGl0c2VsZiB1c2luZworYHNhdmUtYnVmZmVycy1r aWxsLWVtYWNzJy4KKworV2l0aCBwcmVmaXggQVJHLCBzaWxlbnRseSBzYXZlIGFsbCBmaWxl LXZpc2l0aW5nIGJ1ZmZlcnMsIHRoZW4ga2lsbC4KKworSWYgZW1hY3NjbGllbnQgd2FzIHN0 YXJ0ZWQgd2l0aCBhIGxpc3Qgb2YgZmlsZSBuYW1lcyB0byBlZGl0LCB0aGVuCitvbmx5IHRo ZXNlIGZpbGVzIHdpbGwgYmUgYXNrZWQgdG8gYmUgc2F2ZWQuIgorICAoaW50ZXJhY3RpdmUg IlAiKQorICAoaWYgKGZyYW1lLXBhcmFtZXRlciBuaWwgJ2NsaWVudCkKKyAgICAgIChzZXJ2 ZXItc2F2ZS1idWZmZXJzLWtpbGwtdGVybWluYWwgYXJnKQorICAgIChzYXZlLWJ1ZmZlcnMt a2lsbC1lbWFjcyBhcmcpKSkKKwogKGRlZnVuIHNlcnZlci1zdG9wLWF1dG9tYXRpY2FsbHkt LWhhbmRsZS1kZWxldGUtZnJhbWUgKGZyYW1lKQogICAiSGFuZGxlIGRlbGV0aW9uIG9mIEZS QU1FIHdoZW4gYHNlcnZlci1zdG9wLWF1dG9tYXRpY2FsbHknIGlzIHVzZWQuIgogICAod2hl biBzZXJ2ZXItc3RvcC1hdXRvbWF0aWNhbGx5CmRpZmYgLS1naXQgYS9saXNwL3N0YXJ0dXAu ZWwgYi9saXNwL3N0YXJ0dXAuZWwKaW5kZXggNzAyNjdmYzg1Ny4uMmQzOGY5OTg1MCAxMDA2 NDQKLS0tIGEvbGlzcC9zdGFydHVwLmVsCisrKyBiL2xpc3Avc3RhcnR1cC5lbApAQCAtMjMw OCw3ICsyMzA4LDcgQEAgbm9ybWFsLW5vLW1vdXNlLXN0YXJ0dXAtc2NyZWVuCiAgICAgICAg ICAgICAgICAgICAgJ2FjdGlvbiAobGFtYmRhIChfYnV0dG9uKSAodmlldy1vcmRlci1tYW51 YWxzKSkKICAgICAgICAgICAgICAgICAgICAnZm9sbG93LWxpbmsgdCkKICAgICAoaW5zZXJ0 IChzdWJzdGl0dXRlLWNvbW1hbmQta2V5cwotICAgICAgICAgICAgICJcdCAgIFxcW3ZpZXct b3JkZXItbWFudWFsc11cdEV4aXQgRW1hY3NcdCAgIFxcW3NhdmUtYnVmZmVycy1raWxsLXRl cm1pbmFsXSIpKSkKKyAgICAgICAgICAgICAiXHQgICBcXFt2aWV3LW9yZGVyLW1hbnVhbHNd XHRFeGl0IEVtYWNzXHQgICBcXFtzYXZlLWJ1ZmZlcnMta2lsbC1lbWFjc10iKSkpCiAKICAg OzsgU2F5IGhvdyB0byB1c2UgdGhlIG1lbnUgYmFyIHdpdGggdGhlIGtleWJvYXJkLgogICAo aW5zZXJ0ICJcbiIpCmRpZmYgLS1naXQgYS9saXNwL3R1dG9yaWFsLmVsIGIvbGlzcC90dXRv cmlhbC5lbAppbmRleCAyYzc4N2FlNTU5Li5iYTNhNTUwNWMyIDEwMDY0NAotLS0gYS9saXNw L3R1dG9yaWFsLmVsCisrKyBiL2xpc3AvdHV0b3JpYWwuZWwKQEAgLTIwOSw3ICsyMDksNyBA QCB0dXRvcmlhbC0tZGVmYXVsdC1rZXlzCiAgICAgICAgICAgIGAoKEVTQy1wcmVmaXggWzI3 XSkKICAgICAgICAgICAgICAoQ29udHJvbC1YLXByZWZpeCBbP1xDLXhdKQogICAgICAgICAg ICAgIChtb2RlLXNwZWNpZmljLWNvbW1hbmQtcHJlZml4IFs/XEMtY10pCi0gICAgICAgICAg ICAgKHNhdmUtYnVmZmVycy1raWxsLXRlcm1pbmFsIFs/XEMteCA/XEMtY10pCisgICAgICAg ICAgICAgKHNhdmUtYnVmZmVycy1raWxsLWVtYWNzIFs/XEMteCA/XEMtY10pCiAKICAgICAg ICAgICAgICA7OyAqIFNVTU1BUlkKICAgICAgICAgICAgICAoc2Nyb2xsLXVwLWNvbW1hbmQg Wz9cQy12XSkKLS0gCjIuMjUuMQoK --------------sIvWWUcE4KmndGntSsKbphrm-- From unknown Sun Jun 22 08:05:01 2025 X-Loop: help-debbugs@gnu.org Subject: bug#58909: 29.0.50; [PATCH] Deleting the last frame of an emacsclient doesn't ask to save Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 08 Nov 2022 14:48:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58909 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Jim Porter Cc: 58909@debbugs.gnu.org Received: via spool by 58909-submit@debbugs.gnu.org id=B58909.16679188489133 (code B ref 58909); Tue, 08 Nov 2022 14:48:01 +0000 Received: (at 58909) by debbugs.gnu.org; 8 Nov 2022 14:47:28 +0000 Received: from localhost ([127.0.0.1]:36750 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1osPst-0002NF-Pn for submit@debbugs.gnu.org; Tue, 08 Nov 2022 09:47:28 -0500 Received: from eggs.gnu.org ([209.51.188.92]:36050) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1osPss-0002N1-2A for 58909@debbugs.gnu.org; Tue, 08 Nov 2022 09:47:26 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1osPsm-0006yt-6X; Tue, 08 Nov 2022 09:47:20 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=HJ+sHDCUHKkAAvzqxVd+TVnABcS67/YWAppmOiHyjDo=; b=MdfCEuBc3UBh JXzNLazs6E/YtuPkZW9R4plG/sHaXBVFFzWCbne4v0MhZaM/jnbAs9FsZDuLIVa0icnQQXTa4r2XY d7OM5PjUe5L+0JxA7nworWQycxgW+HCJps01MN8AZYZzUbhWqioqrCeSDK4/AYMHRcUrD6cf2dDa8 kGeplkxtrWsPtb3qczZI2WjX9MIrbrPWnJEUqKgGGZJJCBeelvdi3xx51rFS2akMVFTK2580qiYv6 QJykS209R3gTinYjO/Q7971nolEkN+DYuPcZ2c5dwnR4xolUT9ZyF73M7AHdNwBR8lZDcYmgV+q1y XTg7rQ9CzxJYdriwcS7MZg==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1osPsh-0004bt-OR; Tue, 08 Nov 2022 09:47:18 -0500 Date: Tue, 08 Nov 2022 16:47:02 +0200 Message-Id: <83fsety049.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: (message from Jim Porter on Sun, 6 Nov 2022 12:23:58 -0800) References: <9a70f868-ca50-52fc-af3e-23813af104f2@gmail.com> <83zgdcduxm.fsf@gnu.org> <53238b5b-3e0a-3dfe-eeba-f37cafa81f50@gmail.com> <838rkveq3n.fsf@gnu.org> <7de45884-b4c9-4a4c-777c-5db17b3bacca@gmail.com> <835yfzeobt.fsf@gnu.org> <7694fcf2-8982-9099-5eb8-39835d049847@gmail.com> <83y1svch5u.fsf@gnu.org> <0dc07894-dfa1-01f6-87c4-9e02bfcaf0dc@gmail.com> <83bkppblh7.fsf@gnu.org> <83a6599t7m.fsf@gnu.org> <39e03350-2783-fa90-5d66-26e47abe100d@gmail.com> <835yfx9p0z.fsf@gnu.org> <3d5bc685-889f-f406-0979-10f61db5d1a7@gmail.com> <831qql9n4s.fsf@gnu.org> <83zgd986fi.fsf@gnu.org> <1e0f9cc1-03ed-9eea-c6cb-56248607dfe3@gmail.com> <83sfj08sgz.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Sun, 6 Nov 2022 12:23:58 -0800 > Cc: 58909@debbugs.gnu.org > From: Jim Porter > > I also attached a second patch to show an idea I had: since the first > patch adds a minor-mode keymap for 'server-mode' (and ensures that the > mode is activated whenever the server is running), we could get rid of > the server-specific logic from lisp/files.el. Instead of mapping 'C-x > C-c' to 'save-buffers-kill-terminal' all the time, Emacs could map it to > 'save-buffers-kill-emacs' by default. Then, when the server is running, > remap 'save-buffers-kill-emacs' to 'save-buffers-kill-terminal'. This means a different binding for "C-x C-c" depending on situation, and the binding to save-buffers-kill-terminal depending on a minor mode. Previously, "C-x C-c" would do its job regardless of the mode. I'm not sure this is for the best. I'd be interested to hear from others, if anyone has an opinion. From unknown Sun Jun 22 08:05:01 2025 X-Loop: help-debbugs@gnu.org Subject: bug#58909: 29.0.50; [PATCH] Deleting the last frame of an emacsclient doesn't ask to save Resent-From: Robert Pluim Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 08 Nov 2022 15:09:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58909 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Eli Zaretskii Cc: Jim Porter , 58909@debbugs.gnu.org Received: via spool by 58909-submit@debbugs.gnu.org id=B58909.166792009812314 (code B ref 58909); Tue, 08 Nov 2022 15:09:01 +0000 Received: (at 58909) by debbugs.gnu.org; 8 Nov 2022 15:08:18 +0000 Received: from localhost ([127.0.0.1]:37954 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1osQD3-0003CY-PO for submit@debbugs.gnu.org; Tue, 08 Nov 2022 10:08:18 -0500 Received: from mail-wr1-f53.google.com ([209.85.221.53]:37393) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1osQCy-0003CH-7h for 58909@debbugs.gnu.org; Tue, 08 Nov 2022 10:08:16 -0500 Received: by mail-wr1-f53.google.com with SMTP id bs21so21454605wrb.4 for <58909@debbugs.gnu.org>; Tue, 08 Nov 2022 07:08:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=z2DH1EWFWl6lmgLxdFGfDS8TBvjyoknZDRScNqlUQZk=; b=KoBIKJeEB1x6d0CEfcWTC+LYkEt1UbAioETryGQIURjB3zU5uQN0Bq3L+iaDpS09QQ iy3NT4ziDVzCCJWpDPSM3ILM9XAXqFBYvnzdOFef/RTONMEFbkRVg23xF/Dv8C+pYGgJ BZGM8LOOwFbySM+KUouVq5zlVgo5BZAO5P2/gMQhHZfwYRpABQsqCToddt3Nb2dUiD8Z jRSA+jxVubwmyZik8xwwGtmMWa/4jiaaKiYtfXswl0lptD9lz2S+o4oR6RNauC3XhB1q b7O4lNATZRL8ndUZwdi/fbYz5BKwyJOtYlWp+r6JZ+PKofwYrBSwXqcYmFXIs2aPkHdj j6WA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=z2DH1EWFWl6lmgLxdFGfDS8TBvjyoknZDRScNqlUQZk=; b=nUng1shnYKfjuDliNePbjC9MT8loAPsPYg9FDLrTxTsSkhi0S1fa7yt4l4tyjwR2Or QAmuONEg66215rJGOWrl81UtNWyjPoZLuc+prlLrU5Mry/m8JDssOaijN9xBuPbsZLdq e7Zt9M5bAkoShPa+BOva05ko7eqO75awfLZ2mXf8vetAzeM93r63RLhoinHKLDAkbuHi AbzglALvcp+vAiv+4z52G0cCrvaGNMgS7ApigJ0NqTQiK1jhgU6QG2/LmqEzNJ7Pnw6f Efeg+8z41yIiwDasFTVLWlyXizm0A62dL9u9ZeRRsCKJbPFkhICH3yIbcChiYJFZmxGu OM7Q== X-Gm-Message-State: ACrzQf2w8m6CqKTeXpUr51cdKtyW8kahbuNY4EFx8LhPM5//kFg5491M OrzBT9aXT7eJ3zScAeQ3rQXIDm4vBsM= X-Google-Smtp-Source: AMsMyM4K6Nc05NinHHinNgMhb8/yve+P9Kz6ItcfFRKJcjxZScLRmKZUdwFYCOtgjMsWHNKdTyCfug== X-Received: by 2002:a5d:4572:0:b0:236:ccbe:3513 with SMTP id a18-20020a5d4572000000b00236ccbe3513mr31398522wrc.497.1667920085782; Tue, 08 Nov 2022 07:08:05 -0800 (PST) Received: from rltb ([82.66.8.55]) by smtp.gmail.com with ESMTPSA id c2-20020a5d4f02000000b002366553eca7sm10371675wru.83.2022.11.08.07.08.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Nov 2022 07:08:04 -0800 (PST) From: Robert Pluim In-Reply-To: <83fsety049.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 08 Nov 2022 16:47:02 +0200") References: <9a70f868-ca50-52fc-af3e-23813af104f2@gmail.com> <838rkveq3n.fsf@gnu.org> <7de45884-b4c9-4a4c-777c-5db17b3bacca@gmail.com> <835yfzeobt.fsf@gnu.org> <7694fcf2-8982-9099-5eb8-39835d049847@gmail.com> <83y1svch5u.fsf@gnu.org> <0dc07894-dfa1-01f6-87c4-9e02bfcaf0dc@gmail.com> <83bkppblh7.fsf@gnu.org> <83a6599t7m.fsf@gnu.org> <39e03350-2783-fa90-5d66-26e47abe100d@gmail.com> <835yfx9p0z.fsf@gnu.org> <3d5bc685-889f-f406-0979-10f61db5d1a7@gmail.com> <831qql9n4s.fsf@gnu.org> <83zgd986fi.fsf@gnu.org> <1e0f9cc1-03ed-9eea-c6cb-56248607dfe3@gmail.com> <83sfj08sgz.fsf@gnu.org> <83fsety049.fsf@gnu.org> Date: Tue, 08 Nov 2022 16:08:04 +0100 Message-ID: <878rklh4bv.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >>>>> On Tue, 08 Nov 2022 16:47:02 +0200, Eli Zaretskii said: >> Date: Sun, 6 Nov 2022 12:23:58 -0800 >> Cc: 58909@debbugs.gnu.org >> From: Jim Porter >>=20 >> I also attached a second patch to show an idea I had: since the firs= t=20 >> patch adds a minor-mode keymap for 'server-mode' (and ensures that t= he=20 >> mode is activated whenever the server is running), we could get rid = of=20 >> the server-specific logic from lisp/files.el. Instead of mapping 'C-= x=20 >> C-c' to 'save-buffers-kill-terminal' all the time, Emacs could map i= t to=20 >> 'save-buffers-kill-emacs' by default. Then, when the server is runni= ng,=20 >> remap 'save-buffers-kill-emacs' to 'save-buffers-kill-terminal'. Eli> This means a different binding for "C-x C-c" depending on situatio= n, Eli> and the binding to save-buffers-kill-terminal depending on a minor Eli> mode. Previously, "C-x C-c" would do its job regardless of the mo= de. Eli> I'm not sure this is for the best. I'd be interested to hear from Eli> others, if anyone has an opinion. Rules of Emacs: 1. If it works, don=CA=BCt change it 2. See Rule 1 3. No, really, see Rule 1 I honestly don=CA=BCt see what benefit the minor mode would bring here (and it might just bring new and 'interesting' bugs). Robert --=20 From unknown Sun Jun 22 08:05:01 2025 X-Loop: help-debbugs@gnu.org Subject: bug#58909: 29.0.50; [PATCH] Deleting the last frame of an emacsclient doesn't ask to save Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 08 Nov 2022 15:14:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58909 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Robert Pluim Cc: jporterbugs@gmail.com, 58909@debbugs.gnu.org Received: via spool by 58909-submit@debbugs.gnu.org id=B58909.166792041512812 (code B ref 58909); Tue, 08 Nov 2022 15:14:01 +0000 Received: (at 58909) by debbugs.gnu.org; 8 Nov 2022 15:13:35 +0000 Received: from localhost ([127.0.0.1]:37981 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1osQIA-0003Ka-TP for submit@debbugs.gnu.org; Tue, 08 Nov 2022 10:13:35 -0500 Received: from eggs.gnu.org ([209.51.188.92]:45106) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1osQI8-0003KL-F0 for 58909@debbugs.gnu.org; Tue, 08 Nov 2022 10:13:33 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1osQHw-000618-0l; Tue, 08 Nov 2022 10:13:27 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=oi6b64A+6qUrsQwzeNoZ6Kvj1gniUWEzMThXfY9OVpE=; b=fLgEMMQx4P1TjaL148Aj bUwY/eRGe9jlpYyV2UWLmBXoRpR+xZqepzCSSNKKnKnjeLTz2AFCQv8FutHW2KPJ/+qhyRJIAHB3M dFXyeDRGmi5zc3TQSHn3/tryHbixU25sRKKmaEirnPyn5TCofwtmREDjdd/RZOqejNN8/rApl/lba j3CjI9PyIjBvIZK89H/ZA3vF9CAatzoVdGQyNtK2kXjblD+0Fk3sciYyjxIflJV1/lOyqFlDIzBvH 97rrGfBDYS4dpLAYuoirm/RjEeV41UCtMLk+NOo6WOm35wtXhD83qAEGOh0teIRQvBckP3pbmZQ9/ w7L4sihikztbNg==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1osQHq-0004cr-E3; Tue, 08 Nov 2022 10:13:19 -0500 Date: Tue, 08 Nov 2022 17:13:02 +0200 Message-Id: <83edudxywx.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: <878rklh4bv.fsf@gmail.com> (message from Robert Pluim on Tue, 08 Nov 2022 16:08:04 +0100) References: <9a70f868-ca50-52fc-af3e-23813af104f2@gmail.com> <838rkveq3n.fsf@gnu.org> <7de45884-b4c9-4a4c-777c-5db17b3bacca@gmail.com> <835yfzeobt.fsf@gnu.org> <7694fcf2-8982-9099-5eb8-39835d049847@gmail.com> <83y1svch5u.fsf@gnu.org> <0dc07894-dfa1-01f6-87c4-9e02bfcaf0dc@gmail.com> <83bkppblh7.fsf@gnu.org> <83a6599t7m.fsf@gnu.org> <39e03350-2783-fa90-5d66-26e47abe100d@gmail.com> <835yfx9p0z.fsf@gnu.org> <3d5bc685-889f-f406-0979-10f61db5d1a7@gmail.com> <831qql9n4s.fsf@gnu.org> <83zgd986fi.fsf@gnu.org> <1e0f9cc1-03ed-9eea-c6cb-56248607dfe3@gmail.com> <83sfj08sgz.fsf@gnu.org> <83fsety049.fsf@gnu.org> <878rklh4bv.fsf@gmail.com> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Robert Pluim > Cc: Jim Porter , 58909@debbugs.gnu.org > Date: Tue, 08 Nov 2022 16:08:04 +0100 > > I honestly donʼt see what benefit the minor mode would bring here (and > it might just bring new and 'interesting' bugs). The minor mode already exists, and has been with us for many years. From unknown Sun Jun 22 08:05:01 2025 X-Loop: help-debbugs@gnu.org Subject: bug#58909: 29.0.50; [PATCH] Deleting the last frame of an emacsclient doesn't ask to save Resent-From: Robert Pluim Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 08 Nov 2022 15:30:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58909 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Eli Zaretskii Cc: jporterbugs@gmail.com, 58909@debbugs.gnu.org Received: via spool by 58909-submit@debbugs.gnu.org id=B58909.166792136614306 (code B ref 58909); Tue, 08 Nov 2022 15:30:03 +0000 Received: (at 58909) by debbugs.gnu.org; 8 Nov 2022 15:29:26 +0000 Received: from localhost ([127.0.0.1]:38017 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1osQXW-0003if-Cm for submit@debbugs.gnu.org; Tue, 08 Nov 2022 10:29:26 -0500 Received: from mail-wr1-f49.google.com ([209.85.221.49]:35805) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1osQXU-0003iS-Gm for 58909@debbugs.gnu.org; Tue, 08 Nov 2022 10:29:25 -0500 Received: by mail-wr1-f49.google.com with SMTP id l14so21577440wrw.2 for <58909@debbugs.gnu.org>; Tue, 08 Nov 2022 07:29:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=nhpjZsBWhgmgTpR05tbJ6LKQpcISkuKWUgp1lDVPx6M=; b=GsNpQson5T2NlCtLd++KOoilM3D0tkL2QQtCRR/hTxxp81BsxMlB/HtQpF0itvegfp GgnzrUfFqJ6F0ciD/pvsmFgX3CjQ4ID5LwfpQBsTg/l/seLVZdlgW3W5ZmTrMy71aiDT P8j6aIlbrFW+ZST3alsyCngKMQB22qO4I06T7B7dCTMR3iUfsL4Z1wowmemZP1VmCuAM eZgUvulugGH4IOPs83kPb1LskI9sr+kRhTC0L0DG3VMb2SxBsuwukGooiuftll6HtGiG TAevING2IBuJaquMlYDtL2puhLWzQ+G16cO3INNUvJae1heORHPEp5e497C7eKiiSwr6 Wqlw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=nhpjZsBWhgmgTpR05tbJ6LKQpcISkuKWUgp1lDVPx6M=; b=01UYv3uJZYDW2UST2LpeHwcOVxcRaXshMNNGvZCpsNMZPY8HwJtyjn9KdO45rJYzwm wsP0+LUZcD8dn0chHIbwrCI3uXntznrVP9px5YJ1+jfHdRDRL2L16Hdula5Mzg0SJITA kLwHClosva98T36cB3sOejE2nt37WgOza7Akpv3t+IakYdXpdiEuhQMnmQJmUNcKfD7q ez6woNbfUGPoD/nHQmLWCbJ7HCAUkHFSTu7N3HQKTJoSfb8gaxya/0Ami8XGCWu2kg/G 1PtLEQAM/faPA4nevpaF9PtwbadE6RsjqPjR1yLEJX5AmIQ8Khs5iCtS782ZAex9r/qd 6eWQ== X-Gm-Message-State: ACrzQf0ihM/Nerbi/Jl3KrqOuGCgRJ9JBLINbl7uwl8BvxSPK3EXpy6Q gGnij2fU+kb9NEiz+hsrCMhjDyHJ4zw= X-Google-Smtp-Source: AMsMyM7W541KSsBO+qxF6EnathdkTZ0GI4zvLYGeKdB4oeI4Bweq7jKAk7pA0tEGndknJHT17v+E3g== X-Received: by 2002:adf:9c87:0:b0:232:a0fb:ea5f with SMTP id d7-20020adf9c87000000b00232a0fbea5fmr36050162wre.473.1667921358201; Tue, 08 Nov 2022 07:29:18 -0800 (PST) Received: from rltb ([82.66.8.55]) by smtp.gmail.com with ESMTPSA id n17-20020a05600c4f9100b003c701c12a17sm15884406wmq.12.2022.11.08.07.29.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Nov 2022 07:29:17 -0800 (PST) From: Robert Pluim In-Reply-To: <83edudxywx.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 08 Nov 2022 17:13:02 +0200") References: <9a70f868-ca50-52fc-af3e-23813af104f2@gmail.com> <835yfzeobt.fsf@gnu.org> <7694fcf2-8982-9099-5eb8-39835d049847@gmail.com> <83y1svch5u.fsf@gnu.org> <0dc07894-dfa1-01f6-87c4-9e02bfcaf0dc@gmail.com> <83bkppblh7.fsf@gnu.org> <83a6599t7m.fsf@gnu.org> <39e03350-2783-fa90-5d66-26e47abe100d@gmail.com> <835yfx9p0z.fsf@gnu.org> <3d5bc685-889f-f406-0979-10f61db5d1a7@gmail.com> <831qql9n4s.fsf@gnu.org> <83zgd986fi.fsf@gnu.org> <1e0f9cc1-03ed-9eea-c6cb-56248607dfe3@gmail.com> <83sfj08sgz.fsf@gnu.org> <83fsety049.fsf@gnu.org> <878rklh4bv.fsf@gmail.com> <83edudxywx.fsf@gnu.org> Date: Tue, 08 Nov 2022 16:29:17 +0100 Message-ID: <874jv9h3ci.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >>>>> On Tue, 08 Nov 2022 17:13:02 +0200, Eli Zaretskii said: >> From: Robert Pluim >> Cc: Jim Porter , 58909@debbugs.gnu.org >> Date: Tue, 08 Nov 2022 16:08:04 +0100 >>=20 >> I honestly don=CA=BCt see what benefit the minor mode would bring he= re (and >> it might just bring new and 'interesting' bugs). Eli> The minor mode already exists, and has been with us for many years. OK. I don=CA=BCt see what benefit the *use* of the minor mode in this way brings :-) Robert --=20 From unknown Sun Jun 22 08:05:01 2025 X-Loop: help-debbugs@gnu.org Subject: bug#58909: 29.0.50; [PATCH] Deleting the last frame of an emacsclient doesn't ask to save Resent-From: Jim Porter Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 08 Nov 2022 16:53:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58909 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Robert Pluim , Eli Zaretskii Cc: 58909@debbugs.gnu.org Received: via spool by 58909-submit@debbugs.gnu.org id=B58909.166792633821998 (code B ref 58909); Tue, 08 Nov 2022 16:53:01 +0000 Received: (at 58909) by debbugs.gnu.org; 8 Nov 2022 16:52:18 +0000 Received: from localhost ([127.0.0.1]:38070 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1osRph-0005ik-Tb for submit@debbugs.gnu.org; Tue, 08 Nov 2022 11:52:18 -0500 Received: from mail-pg1-f182.google.com ([209.85.215.182]:46761) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1osRpg-0005iX-6o for 58909@debbugs.gnu.org; Tue, 08 Nov 2022 11:52:16 -0500 Received: by mail-pg1-f182.google.com with SMTP id 78so13863077pgb.13 for <58909@debbugs.gnu.org>; Tue, 08 Nov 2022 08:52:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to; bh=n93+/JZjMbQNgXIXXepNrY2DYiWqTKe5C7dkC5x5uD0=; b=NZqlffBVMTwQuAGOhfvFNWY0g+315JBYLrHfQ6eKLgGdABltrCzRdaH+ez8qryyEEe 2bT6QahTMtgMdnNLaZGhvHwySqlmW/12iO23yp30LbZwn0Hpn4KvdY42ns0esXYkW6bx MdMNAngZQ6JojOwhaU481NuVhr+9USq4FRxQDHD9jbKHxXnM3h+8cCVz0GZjHe+3LG58 rpVnk1ET2dxZrFDFaD/HooDYZ3qQN1jHbv9SIZywxy6L755enD/AS7rn8sJ5BgloK8EY tJMuaBYvjMxax8kel8WZaI1x3p8ZKwdVgmXFlPR6i33wMSydYlTI1T7WHU5dMsufhbON FsJw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=n93+/JZjMbQNgXIXXepNrY2DYiWqTKe5C7dkC5x5uD0=; b=RR0pPpSWdoA+SmRxYNrTm+0/hgFEB7GEpouyfj8p8J1KLuCTUdYs/f1v7dJB5Op4/G Fpqu6p9J69hdDYkumxxSpGN6PFgbYlIDtzdhqKHb5jMkJ9qXZj7ljTeL5rO56YPdJ/vM 6lGnVtTqhrCU4EwQ5OjPpLVxzNg5iUXaiC6dxuVkA1gOM3YYHKcrASmWO5gUIPQL1Ano dnV2nrgSjD4tB4/NXfkJq1T2a46ts4w7blgCPS+Hr4vFLL5fk9JlO4fpFBIXbeklctfh voH9dfLuDfHitsYMUG8w47y66Y4eTSJhdSlaClQS/clND8sOI9ZG6hkcpAKsaZx6scAO eGwQ== X-Gm-Message-State: ACrzQf2fOv0inY2bYKuIIPmtdgCnBhJ/PmnYvHmTMzg8299f4acquLUo vOJE3GYbuwUvVV2ou7zogGc= X-Google-Smtp-Source: AMsMyM5AxtCzorykhR/7g1QgUzZy/RCn1OvRe+zG9MYGb09TkzUENDb4Hd2eYIUCb1Fhqblq9iGDiQ== X-Received: by 2002:a63:5b1b:0:b0:46f:4b56:ecba with SMTP id p27-20020a635b1b000000b0046f4b56ecbamr1007967pgb.422.1667926330402; Tue, 08 Nov 2022 08:52:10 -0800 (PST) Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id o3-20020a170902d4c300b00186b55e3cd6sm7238967plg.133.2022.11.08.08.52.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 08 Nov 2022 08:52:09 -0800 (PST) Message-ID: Date: Tue, 8 Nov 2022 08:52:10 -0800 MIME-Version: 1.0 Content-Language: en-US References: <9a70f868-ca50-52fc-af3e-23813af104f2@gmail.com> <835yfzeobt.fsf@gnu.org> <7694fcf2-8982-9099-5eb8-39835d049847@gmail.com> <83y1svch5u.fsf@gnu.org> <0dc07894-dfa1-01f6-87c4-9e02bfcaf0dc@gmail.com> <83bkppblh7.fsf@gnu.org> <83a6599t7m.fsf@gnu.org> <39e03350-2783-fa90-5d66-26e47abe100d@gmail.com> <835yfx9p0z.fsf@gnu.org> <3d5bc685-889f-f406-0979-10f61db5d1a7@gmail.com> <831qql9n4s.fsf@gnu.org> <83zgd986fi.fsf@gnu.org> <1e0f9cc1-03ed-9eea-c6cb-56248607dfe3@gmail.com> <83sfj08sgz.fsf@gnu.org> <83fsety049.fsf@gnu.org> <878rklh4bv.fsf@gmail.com> <83edudxywx.fsf@gnu.org> <874jv9h3ci.fsf@gmail.com> From: Jim Porter In-Reply-To: <874jv9h3ci.fsf@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 11/8/2022 7:29 AM, Robert Pluim wrote: > OK. I donʼt see what benefit the *use* of the minor mode in this way > brings :-) The actual change that I'd like to merge is just to make the minor mode activate/deactivate consistently, whereas previously it would activate in some situations where you start the Emacs server, but not others. I'd classify that as "not working". Having the minor mode makes it easier for third-party code (user configs or packages) to define key bindings that are only active when the server is running. That's useful to me, since I don't *always* use the Emacs server. As for the change to how 'C-x C-c' is bound, I don't have any strong opinion on merging it. It's probably more risk than it's worth, and if we were to merge it, I'd prefer to do so after cutting the 29 branch, since then there'd be more time to find any bugs.[1] However, since the only real benefit is to clean up some dependencies in the code, I'm not sure it's worth the effort. [1] I'd also want to have regression tests for all of that. From unknown Sun Jun 22 08:05:01 2025 X-Loop: help-debbugs@gnu.org Subject: bug#58909: 29.0.50; [PATCH] Deleting the last frame of an emacsclient doesn't ask to save Resent-From: Robert Pluim Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 09 Nov 2022 10:07:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58909 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Jim Porter Cc: Eli Zaretskii , 58909@debbugs.gnu.org Received: via spool by 58909-submit@debbugs.gnu.org id=B58909.16679883777353 (code B ref 58909); Wed, 09 Nov 2022 10:07:01 +0000 Received: (at 58909) by debbugs.gnu.org; 9 Nov 2022 10:06:17 +0000 Received: from localhost ([127.0.0.1]:39094 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oshyK-0001uX-UG for submit@debbugs.gnu.org; Wed, 09 Nov 2022 05:06:17 -0500 Received: from mail-wr1-f48.google.com ([209.85.221.48]:38466) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oshyJ-0001uK-UP for 58909@debbugs.gnu.org; Wed, 09 Nov 2022 05:06:16 -0500 Received: by mail-wr1-f48.google.com with SMTP id a14so24973295wru.5 for <58909@debbugs.gnu.org>; Wed, 09 Nov 2022 02:06:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=lPysdg+sfzv99Y8ItrW2T3lPMQ+AohqAZ3bkNuS919Q=; b=REGMB6Iy9sVIR+yx7p3c11KVvxzANU99JRgKHy9tvuF6HUoR9qATPA3Ssq7HZsfAYL Qtee+4b78W3oaF6vasSRUsHqSaMQJpH9cbLJksJAYM3vDxN4hxUpsdQLNlC6Ni0sY/J6 LirLr14Yp606vO1M2BzMSwjtoPUuitwrR/5ZY0+raRFXF8cHXFBPQRdhB40G6Nku80+w Vum4O99uqk0bkOZvnhexPHPXW0Kds3grhTruI5dhKUdd0rOomNbsS7LWJ/28VCfVUQUm nT6zZ/hHX2zX+N8uMGtq2GpDvj5nBJeN5TnDUCNl1Zi+4ttiwjiB3GrF+LMFEd5dLF7U VNdg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=lPysdg+sfzv99Y8ItrW2T3lPMQ+AohqAZ3bkNuS919Q=; b=KQ5g15M89jNrZOFbvuPvpZmG4IVVkNr9CfFc6TpmlEg8gc/4Ty+pMf/ppt0ple7q7U lAvkdk22t4pO6yyvXTZRmWaqu6nWTo2UZI6pgtIKGVZyzSD9dZnnu0bS901V14vnO4Ba 5jEvPhscl6HIEN5ipCXpUlvVkYe5MXpRrjHjOVoUicTiGffAb502q6YHrE36l56VgH0r p/YmjONnUm8Koo7jB5sMgQSKyToTVltYwniUgQYBcOH4YUQczTCdt8oGpI40NH7ayxwB m1HBld3/K2WPNk6Z8HLrmR9k9B9T1TUhE/bft/u70+SBQ9ruqyR7bXC9//9kwAQyjfwJ fArg== X-Gm-Message-State: ACrzQf2rg3CLauedeI//k9/FVmzPdURi3UiFU6/1AGvrmmBTAio1EnWO wPmKkbDolJWJo11nvP4UzHdQfzKYjJk= X-Google-Smtp-Source: AMsMyM674QXw0a+iLB4mmi1ddL+o0Mi6BccVq2ILtWYxbZ6ijgiWTtd3Up8q3yIrkV1cM0jPyz43qQ== X-Received: by 2002:a5d:590d:0:b0:236:4ddd:1869 with SMTP id v13-20020a5d590d000000b002364ddd1869mr36742756wrd.709.1667988369489; Wed, 09 Nov 2022 02:06:09 -0800 (PST) Received: from rltb ([82.66.8.55]) by smtp.gmail.com with ESMTPSA id bo13-20020a056000068d00b00236644228besm12790207wrb.40.2022.11.09.02.06.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Nov 2022 02:06:08 -0800 (PST) From: Robert Pluim In-Reply-To: (Jim Porter's message of "Tue, 8 Nov 2022 08:52:10 -0800") References: <9a70f868-ca50-52fc-af3e-23813af104f2@gmail.com> <83y1svch5u.fsf@gnu.org> <0dc07894-dfa1-01f6-87c4-9e02bfcaf0dc@gmail.com> <83bkppblh7.fsf@gnu.org> <83a6599t7m.fsf@gnu.org> <39e03350-2783-fa90-5d66-26e47abe100d@gmail.com> <835yfx9p0z.fsf@gnu.org> <3d5bc685-889f-f406-0979-10f61db5d1a7@gmail.com> <831qql9n4s.fsf@gnu.org> <83zgd986fi.fsf@gnu.org> <1e0f9cc1-03ed-9eea-c6cb-56248607dfe3@gmail.com> <83sfj08sgz.fsf@gnu.org> <83fsety049.fsf@gnu.org> <878rklh4bv.fsf@gmail.com> <83edudxywx.fsf@gnu.org> <874jv9h3ci.fsf@gmail.com> Date: Wed, 09 Nov 2022 11:06:08 +0100 Message-ID: <87zgd0fnn3.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >>>>> On Tue, 8 Nov 2022 08:52:10 -0800, Jim Porter = said: Jim> On 11/8/2022 7:29 AM, Robert Pluim wrote: >> OK. I don=CA=BCt see what benefit the *use* of the minor mode in thi= s way >> brings :-) Jim> The actual change that I'd like to merge is just to make the minor Jim> mode activate/deactivate consistently, whereas previously it would Jim> activate in some situations where you start the Emacs server, but = not Jim> others. I'd classify that as "not working". That sounds good Jim> Having the minor mode makes it easier for third-party code (user Jim> configs or packages) to define key bindings that are only active w= hen Jim> the server is running. That's useful to me, since I don't *always*= use Jim> the Emacs server. as does this Jim> As for the change to how 'C-x C-c' is bound, I don't have any stro= ng Jim> opinion on merging it. It's probably more risk than it's worth, an= d if Jim> we were to merge it, I'd prefer to do so after cutting the 29 bran= ch, Jim> since then there'd be more time to find any bugs.[1] However, since Jim> the only real benefit is to clean up some dependencies in the code, Jim> I'm not sure it's worth the effort. I think it would be too risky a change. Robert --=20 From unknown Sun Jun 22 08:05:01 2025 X-Loop: help-debbugs@gnu.org Subject: bug#58909: 29.0.50; [PATCH] Deleting the last frame of an emacsclient doesn't ask to save Resent-From: Jim Porter Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 17 Nov 2022 05:18:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58909 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Robert Pluim Cc: Eli Zaretskii , 58909@debbugs.gnu.org Received: via spool by 58909-submit@debbugs.gnu.org id=B58909.16686622766885 (code B ref 58909); Thu, 17 Nov 2022 05:18:03 +0000 Received: (at 58909) by debbugs.gnu.org; 17 Nov 2022 05:17:56 +0000 Received: from localhost ([127.0.0.1]:58770 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ovXHf-0001mz-Su for submit@debbugs.gnu.org; Thu, 17 Nov 2022 00:17:56 -0500 Received: from mail-pf1-f181.google.com ([209.85.210.181]:41680) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ovXHe-0001ml-7R for 58909@debbugs.gnu.org; Thu, 17 Nov 2022 00:17:54 -0500 Received: by mail-pf1-f181.google.com with SMTP id 130so705139pfu.8 for <58909@debbugs.gnu.org>; Wed, 16 Nov 2022 21:17:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to; bh=Ho+5rI5qbgyODVFOWc6nK0thO5agJqrx08CdYqAz/ts=; b=XdW6Ow5gp2SBlCBkVPa93B5IeKOkzkhxj3HE4YqTuStjmNuqxN0hiaXOrUQLMZWkt2 /Ta5Z++ZL7CVgAIXwvBOw5akyyEX1SHCWCiDsN2GVV35oacB3owdlC4jaxA/dUn0QAbJ PE0AB0OwFr1HNq1ctpubwDSpKBKIMLSh39OqH3A+JeHWM0eJyCnE6ciL2WF1QMSmjDZy 135DXoLekuJCVEa9Bf/GuBfNe0Vm1ud2b/VKZYp7qoVkGLQ8zrIF5/SuZ072aHIblTmq KR4IO+MDBJpP9s0UmFtDJ2ek/R5Xx9r3ie5i4uw3dXEEwiCQQwhwVmNU7SgLZNoTOGeF DPiA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Ho+5rI5qbgyODVFOWc6nK0thO5agJqrx08CdYqAz/ts=; b=2cXua/SvB7Y/6d/LVlgMpAQm+fjvTFJUEfrfLrzd4OBRgH549XHSd/Z6EDtW98RAh7 /JvunssPsuf9MS6lMgrXjg3cHb2roYtZjUgslYq5YX0HFX2yPbqJn+mNjmpHFi9KpSjp 4UIFEyOMCSX893h4vIHgT2U1pY1rwU4MbRHVcHx6D7e5Zj2gpD2ZKD5LgWW5CTXZtosh renyCj+UaO5+zFL2nhuHGaScsgtTQIrQ4fQFdmAsEfjDVvUK/rLcCtRgOGPIBeu9/9N0 Zk9HKiZuXE/Sy+evKw6Jl80XKwP7UE2txo8zk3miktOQ7CmVPSrGHDme2gNI5KfSUeY9 XdRQ== X-Gm-Message-State: ANoB5pn7dRl/Nob8G1TA7N0B2KbRJ/TfyGQd5TwbzWGGXuQdpa0K7zCV 6aIuPdqKcSbDD9EuXYNJQDc= X-Google-Smtp-Source: AA0mqf6Xyxjc3QkDSCT6o5OVAzEQmGfXleFpw2V1H/Iw5joRiIajDi+jOekl+1ECrq9yrRwZdGeYpg== X-Received: by 2002:a63:ce43:0:b0:46e:d2da:8ea6 with SMTP id r3-20020a63ce43000000b0046ed2da8ea6mr654931pgi.208.1668662268177; Wed, 16 Nov 2022 21:17:48 -0800 (PST) Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id b23-20020a17090a101700b00213ee5a12c9sm2571656pja.55.2022.11.16.21.17.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 16 Nov 2022 21:17:47 -0800 (PST) Message-ID: <40a63deb-f7f2-b715-98f2-4537ef8427c8@gmail.com> Date: Wed, 16 Nov 2022 21:17:44 -0800 MIME-Version: 1.0 References: <9a70f868-ca50-52fc-af3e-23813af104f2@gmail.com> <83y1svch5u.fsf@gnu.org> <0dc07894-dfa1-01f6-87c4-9e02bfcaf0dc@gmail.com> <83bkppblh7.fsf@gnu.org> <83a6599t7m.fsf@gnu.org> <39e03350-2783-fa90-5d66-26e47abe100d@gmail.com> <835yfx9p0z.fsf@gnu.org> <3d5bc685-889f-f406-0979-10f61db5d1a7@gmail.com> <831qql9n4s.fsf@gnu.org> <83zgd986fi.fsf@gnu.org> <1e0f9cc1-03ed-9eea-c6cb-56248607dfe3@gmail.com> <83sfj08sgz.fsf@gnu.org> <83fsety049.fsf@gnu.org> <878rklh4bv.fsf@gmail.com> <83edudxywx.fsf@gnu.org> <874jv9h3ci.fsf@gmail.com> <87zgd0fnn3.fsf@gmail.com> Content-Language: en-US From: Jim Porter In-Reply-To: <87zgd0fnn3.fsf@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 11/9/2022 2:06 AM, Robert Pluim wrote: > That sounds good [snip] > as does this [snip] > I think it would be too risky a change. Thanks. I agree with all that. Since there haven't been any further comments in the past week, I've merged just the first patch (to make 'server-mode' (de)activate at the right times) as 0147e1ed831151dddac65727886d5a70bbab9f02. From unknown Sun Jun 22 08:05:01 2025 X-Loop: help-debbugs@gnu.org Subject: bug#58909: 29.0.50; [WIP PATCH] Deleting the last frame of an emacsclient doesn't ask to save Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 07 Sep 2023 21:04:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58909 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Jim Porter Cc: 58909@debbugs.gnu.org, Robert Pluim , Eli Zaretskii Received: via spool by 58909-submit@debbugs.gnu.org id=B58909.169412063629119 (code B ref 58909); Thu, 07 Sep 2023 21:04:02 +0000 Received: (at 58909) by debbugs.gnu.org; 7 Sep 2023 21:03:56 +0000 Received: from localhost ([127.0.0.1]:41505 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qeMAL-0007ZX-Vc for submit@debbugs.gnu.org; Thu, 07 Sep 2023 17:03:56 -0400 Received: from mail-lf1-x130.google.com ([2a00:1450:4864:20::130]:56753) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qeMAG-0007ZG-Jo for 58909@debbugs.gnu.org; Thu, 07 Sep 2023 17:03:53 -0400 Received: by mail-lf1-x130.google.com with SMTP id 2adb3069b0e04-50098cc8967so2249191e87.1 for <58909@debbugs.gnu.org>; Thu, 07 Sep 2023 14:03:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1694120620; x=1694725420; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:from:to:cc:subject:date:message-id:reply-to; bh=Zf3kpBiIUFilOwycO9/JdsUqMTONNITMr6GPCy7axkE=; b=WdKsQlOntUV+GnBbZwXJcf2uU1xNUwWUVI2Pj2e8o8y+UCcuu2TcarDdqavmAnUrY7 DNdZGXCgAPKFTN2PPE+6AH4W3be+eQVbUO3a3PJSfwY4RAtyvYIM0794YSdTAF++hvcZ SwbQB62h1Q3TpJcvvnogV8u3oirdwpmplWxROxFIf5mPZizeA0gNzTdnN9MkChkMbGXS 7Q+GZ8tzY5Iw0Exz6bF5XnWLyOAyNbahoEck4OjzyqtkYpAwgoi0zMSu6hAJnf2Vcf8y fURYcmYjja+Gaj6P/Z6lClilt9hYAsEzRzw2jCo0f/BGVZt183XzC3QfIrBecUNxDhkh VYVg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694120620; x=1694725420; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Zf3kpBiIUFilOwycO9/JdsUqMTONNITMr6GPCy7axkE=; b=Fi8Xd97LaYcoIVKsGMuPm2grYYPGUSK8UJfrD4g+MO7xoCjCHLwgeDfbk/qIvml5ur ib413CdXS4Lq3jHqp7eQkCiW+a5TSmLrrtry6BcLmYmVDykVlSiwDOKuYHhnn3uGsHM4 mSLd7tlPK7gQJ7s6OUxO8bHzNROXKJWt92HSt4pWH7gZznp5xOMzCbQJLmlUyDyJMUBi vFQR+BPybYDCSMLHsWSbuHMH9CPX8Fef/yiEXNVNFr88J/aVHTmkWbpdGfJy5mZxWNVT MQGSmTW/Fy2+/pBlTVo0AAqme9c3f2xv24Xb33X++2CqevTnQ3tqzxX95D1wgi5Msx85 Obvg== X-Gm-Message-State: AOJu0YwLzdIksJgVxELtjFzJD9UEgiyBLj2wX9P7yEuyAK1QDivDppX3 uTlI8KX7JmrhciyoNiUmASS+mhNV84AqLRQpaRA= X-Google-Smtp-Source: AGHT+IFGJvZ0P3kpu3rJJAxOG7Db+aBTOm0sCjiBH+d5jWa16Taenl1PCHZWPPa7pGb0NofTfsfdoUNM55yxrFG448A= X-Received: by 2002:a05:6512:1321:b0:4fa:ad2d:6c58 with SMTP id x33-20020a056512132100b004faad2d6c58mr379594lfu.61.1694120619571; Thu, 07 Sep 2023 14:03:39 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Thu, 7 Sep 2023 14:03:39 -0700 From: Stefan Kangas In-Reply-To: <40a63deb-f7f2-b715-98f2-4537ef8427c8@gmail.com> (Jim Porter's message of "Wed, 16 Nov 2022 21:17:44 -0800") References: <9a70f868-ca50-52fc-af3e-23813af104f2@gmail.com> <0dc07894-dfa1-01f6-87c4-9e02bfcaf0dc@gmail.com> <83bkppblh7.fsf@gnu.org> <83a6599t7m.fsf@gnu.org> <39e03350-2783-fa90-5d66-26e47abe100d@gmail.com> <835yfx9p0z.fsf@gnu.org> <3d5bc685-889f-f406-0979-10f61db5d1a7@gmail.com> <831qql9n4s.fsf@gnu.org> <83zgd986fi.fsf@gnu.org> <1e0f9cc1-03ed-9eea-c6cb-56248607dfe3@gmail.com> <83sfj08sgz.fsf@gnu.org> <83fsety049.fsf@gnu.org> <878rklh4bv.fsf@gmail.com> <83edudxywx.fsf@gnu.org> <874jv9h3ci.fsf@gmail.com> <87zgd0fnn3.fsf@gmail.com> <40a63deb-f7f2-b715-98f2-4537ef8427c8@gmail.com> MIME-Version: 1.0 Date: Thu, 7 Sep 2023 14:03:39 -0700 Message-ID: Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Jim Porter writes: > On 11/9/2022 2:06 AM, Robert Pluim wrote: >> That sounds good > [snip] >> as does this > [snip] >> I think it would be too risky a change. > > Thanks. I agree with all that. > > Since there haven't been any further comments in the past week, I've merged just the first patch (to make > 'server-mode' (de)activate at the right times) as 0147e1ed831151dddac65727886d5a70bbab9f02. This was a long thread. From skimming it, it's not clear to me if there's anything left to do here? From unknown Sun Jun 22 08:05:01 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Jim Porter Subject: bug#58909: closed (Re: bug#58909: 29.0.50; [WIP PATCH] Deleting the last frame of an emacsclient doesn't ask to save) Message-ID: References: <2f658f54-84f3-979e-b239-293a741c8ba2@gmail.com> <9a70f868-ca50-52fc-af3e-23813af104f2@gmail.com> X-Gnu-PR-Message: they-closed 58909 X-Gnu-PR-Package: emacs X-Gnu-PR-Keywords: patch Reply-To: 58909@debbugs.gnu.org Date: Fri, 08 Sep 2023 01:22:01 +0000 Content-Type: multipart/mixed; boundary="----------=_1694136121-12342-1" This is a multi-part message in MIME format... ------------=_1694136121-12342-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #58909: 29.0.50; [WIP PATCH] Deleting the last frame of an emacsclient does= n't ask to save which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 58909@debbugs.gnu.org. --=20 58909: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D58909 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1694136121-12342-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 58909-done) by debbugs.gnu.org; 8 Sep 2023 01:21:45 +0000 Received: from localhost ([127.0.0.1]:41789 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qeQBs-0003Cc-Iy for submit@debbugs.gnu.org; Thu, 07 Sep 2023 21:21:44 -0400 Received: from mail-pl1-x636.google.com ([2607:f8b0:4864:20::636]:42052) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qeQBr-0003CQ-EB for 58909-done@debbugs.gnu.org; Thu, 07 Sep 2023 21:21:43 -0400 Received: by mail-pl1-x636.google.com with SMTP id d9443c01a7336-1c0bae4da38so11024115ad.0 for <58909-done@debbugs.gnu.org>; Thu, 07 Sep 2023 18:21:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1694136095; x=1694740895; darn=debbugs.gnu.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to; bh=ugeUUuXJyaCiDjMPJImNOOewC8fiaWip1IcYQCkvHQc=; b=Bxc6gtGY7xA8JGxN+fA+ADzWPLLzTsDbjwYaVRu9jUv8fOd8ulC6KKal5fupwqb9Dv tlTtU/FflOuAPeRJr5/DypXIOhWSU+7N7vqAKEuqrUOoFEg9/9jg/IDQ85EPMyApM2/E mtiUu6g9Kw6NGdtiaJWf14FEgX5uEQoruSQir6w7AMUNVssc7eRWAms9VDU6fJKZCN9e HMhtP79m5R+EF9KGKm2vgBN8rDKZSFOdWMdy0pXpZ4bck1Qzb+7JHI6ZVmsf6/Cfz+vo av5R1a8mDmtxRHp01SMt1aCxNTSkAim9pZ6KZcDySuiEcGsZsATn7PqyIpZXtv5ehN4q jdIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694136095; x=1694740895; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ugeUUuXJyaCiDjMPJImNOOewC8fiaWip1IcYQCkvHQc=; b=pDbWZ4KETTcNG4Yr4bh8fX35K9vaks6UH4Z+h1ywqzDIw6d9iwm7xj8miT8FgAevrO 2DT69IUBOKQBEpgwQpLpsgNbODF2GOVMM8bM9/QZFrqbnHRA6ghNxwx2wJ+zfh6E3vyO Wajs6yFhxLKnp0XvUgnuNSR5Y/TTKcVyHEuTsyIYX2Zz7Cy775kwd0s4MLOsyfyrJGjP JY7hFtjivJxGLuvAT3+mrxLrciQ7Uk8ptN2u5GaQdXmQlj64TtnPj9c7wjVEVCpeRmoX R+Q/Y4dMae0Of3X0XFiT+vtk2qJ6O/luMxHEqpE+VAgzcC5kavNZz8QbZeTHT5B/JPE4 ckhA== X-Gm-Message-State: AOJu0YwBj2bY46NnCZCxoRa5rozAQ4dES3wPBol6AE2/Neop9pV38omf 6ffrpqrFNVZiHogALsY3XdA= X-Google-Smtp-Source: AGHT+IGymaqfoIZinDvjom2VdWh+Wnz5gGdOfHBPNedsK5ovmyrrMB2QjG733a8DJX58yecF+mHMhA== X-Received: by 2002:a17:902:d48a:b0:1c1:fc5c:b31b with SMTP id c10-20020a170902d48a00b001c1fc5cb31bmr1619914plg.9.1694136095492; Thu, 07 Sep 2023 18:21:35 -0700 (PDT) Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id j10-20020a170902c3ca00b001b8b2a6c4a4sm355819plj.172.2023.09.07.18.21.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 07 Sep 2023 18:21:34 -0700 (PDT) Message-ID: <2f658f54-84f3-979e-b239-293a741c8ba2@gmail.com> Date: Thu, 7 Sep 2023 18:21:34 -0700 MIME-Version: 1.0 Subject: Re: bug#58909: 29.0.50; [WIP PATCH] Deleting the last frame of an emacsclient doesn't ask to save Content-Language: en-US To: Stefan Kangas References: <9a70f868-ca50-52fc-af3e-23813af104f2@gmail.com> <0dc07894-dfa1-01f6-87c4-9e02bfcaf0dc@gmail.com> <83bkppblh7.fsf@gnu.org> <83a6599t7m.fsf@gnu.org> <39e03350-2783-fa90-5d66-26e47abe100d@gmail.com> <835yfx9p0z.fsf@gnu.org> <3d5bc685-889f-f406-0979-10f61db5d1a7@gmail.com> <831qql9n4s.fsf@gnu.org> <83zgd986fi.fsf@gnu.org> <1e0f9cc1-03ed-9eea-c6cb-56248607dfe3@gmail.com> <83sfj08sgz.fsf@gnu.org> <83fsety049.fsf@gnu.org> <878rklh4bv.fsf@gmail.com> <83edudxywx.fsf@gnu.org> <874jv9h3ci.fsf@gmail.com> <87zgd0fnn3.fsf@gmail.com> <40a63deb-f7f2-b715-98f2-4537ef8427c8@gmail.com> From: Jim Porter In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 58909-done Cc: 58909-done@debbugs.gnu.org, Eli Zaretskii , Robert Pluim X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 9/7/2023 2:03 PM, Stefan Kangas wrote: > Jim Porter writes: > >> On 11/9/2022 2:06 AM, Robert Pluim wrote: >>> That sounds good >> [snip] >>> as does this >> [snip] >>> I think it would be too risky a change. >> >> Thanks. I agree with all that. >> >> Since there haven't been any further comments in the past week, I've merged just the first patch (to make >> 'server-mode' (de)activate at the right times) as 0147e1ed831151dddac65727886d5a70bbab9f02. > > This was a long thread. From skimming it, it's not clear to me if > there's anything left to do here? Yeah, I'd say we're done here; I just forgot to close the bug at the time. Closing this now. ------------=_1694136121-12342-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 30 Oct 2022 22:29:51 +0000 Received: from localhost ([127.0.0.1]:39162 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1opGoQ-0001pb-WA for submit@debbugs.gnu.org; Sun, 30 Oct 2022 18:29:51 -0400 Received: from lists.gnu.org ([209.51.188.17]:59302) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1opGoP-0001pU-PA for submit@debbugs.gnu.org; Sun, 30 Oct 2022 18:29:50 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1opGoP-0000lj-Ib for bug-gnu-emacs@gnu.org; Sun, 30 Oct 2022 18:29:49 -0400 Received: from mail-pf1-x42c.google.com ([2607:f8b0:4864:20::42c]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1opGoB-0007Ez-Da for bug-gnu-emacs@gnu.org; Sun, 30 Oct 2022 18:29:48 -0400 Received: by mail-pf1-x42c.google.com with SMTP id 17so4950421pfv.4 for ; Sun, 30 Oct 2022 15:29:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:content-language:subject:from:mime-version:date:message-id:from :to:cc:subject:date:message-id:reply-to; bh=zoFjE22cTW3xXdPpEKheAg3I4NRX/U2nL4kwI3hBraw=; b=aPjwZeLpw8AuW8VAvHMUOq9aOKAe9pgd/WyOdEtzWs+QixyskoPp9JCzbI6JZJ/N8o gIBtcD7oPGMRZF4feokANwI0F816U8PNfHek2FGMulg2ckqx5O+eTHRGwd+HX0YGdwi0 IMJBL8RT2EBRocR9j8y0vhDRznNz0QkpiZ15ATHr2fT9GOnyrOc5Q1juwxrMQPPoZf2B 9JvYbX+UtC3TKmdO7HWAK3X5F6DyAlria9WZfSbc5Scm2WAcJVVduAUbb+4z7UugZ337 T1cjGH3MvN1temLXqXwYemr7Lq7gt3C9mP2tnXxtyr/alUu0pYNeXRGys8isPjic1azp P4rw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:content-language:subject:from:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=zoFjE22cTW3xXdPpEKheAg3I4NRX/U2nL4kwI3hBraw=; b=NH7AqygdGcGRaAu/IDk1ZpbKneTd1aZVsTpdIFtxFwvaminauhDqu4+9+d4KhgQ0Vh X8RZwXkEPFC7x5/FCY0S+HRvBFlzfLgPQU7g7tNEBBVq5VszHNAOdy5yKt1Obn5PQQez /n4y7YRKY6yKPZD1L0Tth5WxbVWyHWWQmMaleDFfKhzdThUBGHJFZIGpwaxilFhr8184 Qd9UUbeKzlXhMpY2yOw9Udunwe5mOc+zkTFJt/l+h+4dCqFHmDQ/VPpWDiVNkkWbHfAS IhjwlL9nMKJK7M7yhNHmUEgk74cEKrKUAYnl0hoJ5tZfGfVYs8X1aWTolz9iazTmMwGH NQVw== X-Gm-Message-State: ACrzQf1HE/C5BlXcFtoz+xIn3jSc0qdCnd6Yw5ZgSQhyXnrZdxW+92Xw oShzoAxi3bKRJcs92lB/rqv3dFVWso4= X-Google-Smtp-Source: AMsMyM78N0GwUhq8wJYqSOZVxpLGgMJcOPuKeWERVmM6mU6inlZ8jzm87fzqE+oYRXYtWmb5uPL+fA== X-Received: by 2002:aa7:92c8:0:b0:56b:d0b8:10f0 with SMTP id k8-20020aa792c8000000b0056bd0b810f0mr11121702pfa.46.1667168972358; Sun, 30 Oct 2022 15:29:32 -0700 (PDT) Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id t189-20020a6281c6000000b005668b26ade0sm3090566pfd.136.2022.10.30.15.29.31 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 30 Oct 2022 15:29:31 -0700 (PDT) Content-Type: multipart/mixed; boundary="------------0BvVna6Ty8GhOfAUnAobIOnu" Message-ID: <9a70f868-ca50-52fc-af3e-23813af104f2@gmail.com> Date: Sun, 30 Oct 2022 15:29:30 -0700 MIME-Version: 1.0 From: Jim Porter Subject: 29.0.50; [WIP PATCH] Deleting the last frame of an emacsclient doesn't ask to save X-Mozilla-News-Host: news://news://news.gmane.io:119 Content-Language: en-US To: bug-gnu-emacs@gnu.org Received-SPF: pass client-ip=2607:f8b0:4864:20::42c; envelope-from=jporterbugs@gmail.com; helo=mail-pf1-x42c.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) This is a multi-part message in MIME format. --------------0BvVna6Ty8GhOfAUnAobIOnu Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit (Note: this is tangentially related to bug#51993, but it happens regardless of whether 'server-stop-automatically' is enabled.) In most cases when you do something to exit an Emacs client, it prompts you to save buffers associated with that client. For example: $ emacs -Q -f server-start $ emacsclient -c foo.txt ;; type some random characters C-x # ;; or... C-x C-c In both cases, Emacs will ask to save foo.txt, though the prompts will be slightly different. That's good, since whatever invoked "emacsclient -c foo.txt" is likely waiting for the user to have saved that file. However, if you use 'C-x 5 0' instead, that terminates the Emacs client, but *doesn't* prompt to save foo.txt. I think it should prompt in this case too: all three of 'C-x #', 'C-x C-c', and 'C-x 5 0' have the effect (in this simple case) of deleting the Emacs client and returning to the calling process. (A user who wanted to bail out of an Emacs client without saving should use 'sever-edit-abort' instead.) Attached is a WIP patch to do this. It's WIP because it will need to have some special handling for the 'server-stop-automatically' case so that it doesn't prompt twice in some cases. I also changed how 'delete-frame' calls 'delete-frame-functions'. Hopefully the change I made is correct; I'm hesitant to change low-level code like that, but I think it's the right thing to do for this case at least. (Maybe that change should be called out in NEWS?) Ultimately, it might make sense to merge this bug with bug#51993, but the discussion in that bug is already pretty long, and I think it would just confuse matters to add even more tangents to that discussion. --------------0BvVna6Ty8GhOfAUnAobIOnu Content-Type: text/plain; charset=UTF-8; name="0001-When-deleting-the-last-frame-of-an-Emacs-client-ask-.patch" Content-Disposition: attachment; filename*0="0001-When-deleting-the-last-frame-of-an-Emacs-client-ask-.pa"; filename*1="tch" Content-Transfer-Encoding: base64 RnJvbSA4NzBkOTk1NDA0ODNkMzkxNzQ4NjAxOTA4NzJkN2U2MWYyMjA1ZmFkIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKaW0gUG9ydGVyIDxqcG9ydGVyYnVnc0BnbWFpbC5j b20+CkRhdGU6IFNhdCwgMjkgT2N0IDIwMjIgMjA6NDA6NDkgLTA3MDAKU3ViamVjdDogW1BB VENIXSBXaGVuIGRlbGV0aW5nIHRoZSBsYXN0IGZyYW1lIG9mIGFuIEVtYWNzIGNsaWVudCwg YXNrIHRvIHNhdmUKCiogc3JjL2ZyYW1lLmMgKGRlbGV0ZV9mcmFtZSk6IENhbGwgJ2RlbGV0 ZS1mcmFtZS1mdW5jdGlvbnMnIHdpdGgKJ2NhbGwyJyBpbnN0ZWFkIG9mICdzYWZlX2NhbGwy JyB0byBhbGxvdyBob29rcyB0byBxdWl0LCBjYW5jZWxsaW5nIHRoZQpmcmFtZSdzIGRlbGV0 aW9uLgoKKiBsaXNwL3NlcnZlci5lbCAoc2VydmVyLXNhdmUtc29tZS1idWZmZXJzKTogTmV3 IGZ1bmN0aW9uLi4uCihzZXJ2ZXItaGFuZGxlLWRlbGV0ZS1mcmFtZSwgc2VydmVyLXNhdmUt YnVmZmVycy1raWxsLXRlcm1pbmFsKToKLi4uIHVzZSBpdC4KLS0tCiBsaXNwL3NlcnZlci5l bCB8IDMxICsrKysrKysrKysrKysrKysrKystLS0tLS0tLS0tLS0KIHNyYy9mcmFtZS5jICAg IHwgIDIgKy0KIDIgZmlsZXMgY2hhbmdlZCwgMjAgaW5zZXJ0aW9ucygrKSwgMTMgZGVsZXRp b25zKC0pCgpkaWZmIC0tZ2l0IGEvbGlzcC9zZXJ2ZXIuZWwgYi9saXNwL3NlcnZlci5lbApp bmRleCA5MGQ5N2MxNTM4Li5kZTRjNjM3Y2FhIDEwMDY0NAotLS0gYS9saXNwL3NlcnZlci5l bAorKysgYi9saXNwL3NlcnZlci5lbApAQCAtNDc5LDYgKzQ3OSwyMCBAQCBzZXJ2ZXItdW5z ZWxlY3QtZGlzcGxheQogICAgICAgKHdoZW4gKGJ1ZmZlci1saXZlLXAgYnVmZmVyKQogCShr aWxsLWJ1ZmZlciBidWZmZXIpKSkpKQogCisoZGVmdW4gc2VydmVyLXNhdmUtc29tZS1idWZm ZXJzIChwcm9jICZvcHRpb25hbCBhcmcpCisgICJTYXZlIG1vZGlmaWVkIGZpbGUtdmlzaXRp bmcgYnVmZmVycyBmcm9tIHRoZSBlbWFjc2NsaWVudCBmaWxlIGxpc3QuCitQUk9DIGlzIHRo ZSBlbWFjc2NsaWVudCBwcm9jZXNzLiAgSWYgQVJHIGlzIG5vbi1uaWwsIHNhdmUgYWxsCit3 aXRoIG5vIHF1ZXN0aW9ucy4iCisgIChsZXQgKChidWZmZXJzIChwcm9jZXNzLWdldCBwcm9j ICdidWZmZXJzKSkpCisgICAgKHNhdmUtc29tZS1idWZmZXJzCisgICAgIGFyZyAoaWYgYnVm ZmVycworICAgICAgICAgICAgIDs7IE9ubHkgZmlsZXMgZnJvbSBlbWFjc2NsaWVudCBmaWxl IGxpc3QuCisgICAgICAgICAgICAgKGxhbWJkYSAoKSAobWVtcSAoY3VycmVudC1idWZmZXIp IGJ1ZmZlcnMpKQorICAgICAgICAgICA7OyBJZiB0aGVyZSdzIG5vIGVtYWNzY2xpZW50IGZp bGUgbGlzdDogZG9uJ3Qgb3ZlcnJpZGUKKyAgICAgICAgICAgOzsgYHNhdmUtc29tZS1idWZm ZXJzLWRlZmF1bHQtcHJlZGljYXRlJyAodW5sZXNzIEFSRyBpcworICAgICAgICAgICA7OyBu b24tbmlsKS4KKyAgICAgICAgICAgKGFuZCBhcmcgdCkpKSkpCisKIChkZWZ1biBzZXJ2ZXIt aGFuZGxlLWRlbGV0ZS1mcmFtZSAoZnJhbWUpCiAgICJEZWxldGUgdGhlIGNsaWVudCBjb25u ZWN0aW9uIHdoZW4gdGhlIGVtYWNzY2xpZW50IGZyYW1lIGlzIGRlbGV0ZWQuCiBcKFRvIGJl IHVzZWQgZnJvbSBgZGVsZXRlLWZyYW1lLWZ1bmN0aW9ucycuKSIKQEAgLTQ5Miw3ICs1MDYs OSBAQCBzZXJ2ZXItaGFuZGxlLWRlbGV0ZS1mcmFtZQogICAgICAgICAgICAgICAgICAgICAg ICAgICAgIChlcSBwcm9jIChmcmFtZS1wYXJhbWV0ZXIgZiAnY2xpZW50KSkpKQogICAgICAg ICAgICAgICAgICAgICAgKGZyYW1lLWxpc3QpKSkpCiAgICAgICAoc2VydmVyLWxvZyAoZm9y bWF0ICJzZXJ2ZXItaGFuZGxlLWRlbGV0ZS1mcmFtZSwgZnJhbWUgJXMiIGZyYW1lKSBwcm9j KQotICAgICAgKHNlcnZlci1kZWxldGUtY2xpZW50IHByb2MgJ25vZnJhbWUpKSkpIDsgTGV0 IGRlbGV0ZS1mcmFtZSBkZWxldGUgdGhlIGZyYW1lIGxhdGVyLgorICAgICAgKHNlcnZlci1z YXZlLXNvbWUtYnVmZmVycyBwcm9jKSkKKyAgICAgIDs7IExldCBkZWxldGUtZnJhbWUgZGVs ZXRlIHRoZSBmcmFtZSBsYXRlci4KKyAgICAgIChzZXJ2ZXItZGVsZXRlLWNsaWVudCBwcm9j ICdub2ZyYW1lKSkpCiAKIChkZWZ1biBzZXJ2ZXItaGFuZGxlLXN1c3BlbmQtdHR5ICh0ZXJt aW5hbCkKICAgIk5vdGlmeSB0aGUgY2xpZW50IHByb2Nlc3MgdGhhdCBpdHMgdHR5IGRldmlj ZSBpcyBzdXNwZW5kZWQuIgpAQCAtMTc1MiwxNyArMTc2OCw4IEBAIHNlcnZlci1zYXZlLWJ1 ZmZlcnMta2lsbC10ZXJtaW5hbAogCSAgICAgICA7OyBJZiB3ZSdyZSB0aGUgbGFzdCBmcmFt ZSBzdGFuZGluZywga2lsbCBFbWFjcy4KIAkgICAgICAgKHNhdmUtYnVmZmVycy1raWxsLWVt YWNzIGFyZykpKQogCSAgICAoKHByb2Nlc3NwIHByb2MpCi0JICAgICAobGV0ICgoYnVmZmVy cyAocHJvY2Vzcy1nZXQgcHJvYyAnYnVmZmVycykpKQotCSAgICAgICAoc2F2ZS1zb21lLWJ1 ZmZlcnMKLQkgICAgICAgIGFyZyAoaWYgYnVmZmVycwotICAgICAgICAgICAgICAgICAgICAg ICAgOzsgT25seSBmaWxlcyBmcm9tIGVtYWNzY2xpZW50IGZpbGUgbGlzdC4KLQkJICAgICAg ICAobGFtYmRhICgpIChtZW1xIChjdXJyZW50LWJ1ZmZlcikgYnVmZmVycykpCi0gICAgICAg ICAgICAgICAgICAgICAgOzsgTm8gZW1hY3NjbGllbnQgZmlsZSBsaXN0OiBkb24ndCBvdmVy cmlkZQotICAgICAgICAgICAgICAgICAgICAgIDs7IGBzYXZlLXNvbWUtYnVmZmVycy1kZWZh dWx0LXByZWRpY2F0ZScgKHVubGVzcwotICAgICAgICAgICAgICAgICAgICAgIDs7IEFSRyBp cyBub24tbmlsKSwgc2luY2Ugd2UncmUgbm90IGtpbGxpbmcKLSAgICAgICAgICAgICAgICAg ICAgICA7OyBFbWFjcyAodW5saWtlIGBzYXZlLWJ1ZmZlcnMta2lsbC1lbWFjcycpLgotCQkg ICAgICAoYW5kIGFyZyB0KSkpCi0JICAgICAgIChzZXJ2ZXItZGVsZXRlLWNsaWVudCBwcm9j KSkpCisgICAgICAgICAgICAgKHNlcnZlci1zYXZlLXNvbWUtYnVmZmVycyBwcm9jIGFyZykK KwkgICAgIChzZXJ2ZXItZGVsZXRlLWNsaWVudCBwcm9jKSkKIAkgICAgKHQgKGVycm9yICJJ bnZhbGlkIGNsaWVudCBmcmFtZSIpKSkpKSkKIAogKGRlZnVuIHNlcnZlci1zdG9wLWF1dG9t YXRpY2FsbHktLWhhbmRsZS1kZWxldGUtZnJhbWUgKGZyYW1lKQpkaWZmIC0tZ2l0IGEvc3Jj L2ZyYW1lLmMgYi9zcmMvZnJhbWUuYwppbmRleCBmMDc2YTViYTU0Li44YTg1ZDVhNDAwIDEw MDY0NAotLS0gYS9zcmMvZnJhbWUuYworKysgYi9zcmMvZnJhbWUuYwpAQCAtMjAzNyw3ICsy MDM3LDcgQEAgZGVsZXRlX2ZyYW1lIChMaXNwX09iamVjdCBmcmFtZSwgTGlzcF9PYmplY3Qg Zm9yY2UpCiAgICAgICB4X2NsaXBib2FyZF9tYW5hZ2VyX3NhdmVfZnJhbWUgKGZyYW1lKTsK ICNlbmRpZgogCi0gICAgICBzYWZlX2NhbGwyIChRcnVuX2hvb2tfd2l0aF9hcmdzLCBRZGVs ZXRlX2ZyYW1lX2Z1bmN0aW9ucywgZnJhbWUpOworICAgICAgY2FsbDIgKFFydW5faG9va193 aXRoX2FyZ3MsIFFkZWxldGVfZnJhbWVfZnVuY3Rpb25zLCBmcmFtZSk7CiAgICAgfQogCiAg IC8qIGRlbGV0ZV9mcmFtZV9mdW5jdGlvbnMgbWF5IGhhdmUgZGVsZXRlZCBhbnkgZnJhbWUs IGluY2x1ZGluZyB0aGlzCi0tIAoyLjI1LjEKCg== --------------0BvVna6Ty8GhOfAUnAobIOnu-- ------------=_1694136121-12342-1--