GNU bug report logs - #58901
[PATCH] gnu: luajit: Update to commit 6c4826.

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#58901: closed ([PATCH] gnu: luajit: Update to commit 6c4826.)
Date: Mon, 14 Nov 2022 11:24:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Mon, 14 Nov 2022 12:23:40 +0100
with message-id <874jv1rd8j.fsf <at> gnu.org>
and subject line Re: bug#58901: [PATCH] gnu: luajit: Update to commit 6c4826.
has caused the debbugs.gnu.org bug report #58901,
regarding [PATCH] gnu: luajit: Update to commit 6c4826.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
58901: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=58901
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Leo Nikkilä <hello <at> lnikki.la>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: luajit: Update to commit 6c4826.
Date: Sun, 30 Oct 2022 21:19:53 +0200

Greetings, attached is a patch to update luajit to commit
6c4826f12c4d33b8b978004bc681eb1eef2be977.

My motivation for doing this was to get Neovim to build on aarch64-linux
again, which has been failing for a while due to incompatibilities with
the 2.1.0-beta3 release:

- https://ci.guix.gnu.org/build/1558481/details
- https://github.com/neovim/neovim/issues/15146#issuecomment-884154715

The 2.1.0-beta3 release is from 2017, and now quite dated.

Unfortunately there hasn't been a tagged release in a long time, and
dependents have resorted to various commits of the 2.1.0 branch. I chose
this particular commit from Nixpkgs:

- https://github.com/NixOS/nixpkgs/blob/3fa15c357033b1c7bdb88f34c1fb9f6427b4754c/pkgs/development/interpreters/luajit/2.1.nix

In addition to fixing the Neovim build, this also fixes a vulnerability
that has been reported in the luajit 2.1.0-beta3 release and patched in
the development tree:

- https://nvd.nist.gov/vuln/detail/CVE-2020-24372
- https://github.com/LuaJIT/LuaJIT/issues/603

I was also able to remove the luajit patch for a missing ldconfig, this
behaviour has been fixed in upstream since January 2020:

- https://github.com/LuaJIT/LuaJIT/commit/18c9cf7d3788a8f7408df45df92fc4ae3bcc0d80

Here's what `guix refresh' has to say about luajit:

    $ guix refresh --list-dependent luajit
    Building the following 42 packages would ensure 62 dependent packages are rebuilt: arcan-wayland <at> 0.5.5.2-1.b4dd1fb xarcan <at> 0.5.4-1.8e6ee02 arcan-sdl <at> 0.5.5.2-1.b4dd1fb sysbench <at> 1.0.20 knot-resolver <at> 5.4.4 edi <at> 0.8.0 rage <at> 0.4.0 ephoto <at> 1.6.0 enlightenment <at> 0.25.4 terminology <at> 1.12.1 evisum <at> 0.6.0 econnman <at> 1.1 epour <at> 0.7.0 jami <at> 20220825.0828.c10f01f pinentry-efl <at> 1.2.0 instead <at> 3.3.5 love-nuklear <at> 2.6.1 mrrescue <at> 1.02e tome4 <at> 1.7.4 solarus-quest-editor <at> 1.6.5 naev <at> 0.9.4 mrg <at> 0.1.4 uftrace <at> 0.11 bpftrace <at> 0.15.0 rspamd <at> 3.2 hexchat <at> 2.16.1 minetest-unified-inventory <at> 2021-12-26 minetest-worldedit <at> 1.3 minetest-ethereal <at> 1.29-0.7670c1d minetest-throwing-arrows <at> 1.1-0.059cc89 minetest-basic-trains <at> 1.0.1 minetest-mesecons <at> 1.2.1-63.27c3c51 minetest-homedecor-modpack <at> 2022-05-18 minetest-coloredwood <at> 2021-04-14-1 minetest-technic <at> 2022-02-06 minetest-mobs-animal <at> 2021-11-14 obs-wlrobs <at> 1.0 obs-spectralizer <at> 1.3.3 obs-websocket <at> 4.9.1 eovim <at> 0.2.0 luakit <at> 2.3 nginx-lua-module <at> 0.10.16

I've tested this update by successfully building the dependent packages
on x86_64-linux and aarch64-linux, except for nginx-lua-module and
obs-websocket which have been failing on CI as well due to build errors
unrelated to luajit.

[Message part 3 (message/rfc822, inline)]

From: Ludovic Courtès <ludo <at> gnu.org>
To: Leo Nikkilä <hello <at> lnikki.la>
Cc: 58901-done <at> debbugs.gnu.org
Subject: Re: bug#58901: [PATCH] gnu: luajit: Update to commit 6c4826.
Date: Mon, 14 Nov 2022 12:23:40 +0100

Hi,

Leo Nikkilä <hello <at> lnikki.la> skribis:

> Greetings, attached is a patch to update luajit to commit
> 6c4826f12c4d33b8b978004bc681eb1eef2be977.
>
> My motivation for doing this was to get Neovim to build on aarch64-linux
> again, which has been failing for a while due to incompatibilities with
> the 2.1.0-beta3 release:
>
> - https://ci.guix.gnu.org/build/1558481/details
> - https://github.com/neovim/neovim/issues/15146#issuecomment-884154715
>
> The 2.1.0-beta3 release is from 2017, and now quite dated.
>
> Unfortunately there hasn't been a tagged release in a long time, and
> dependents have resorted to various commits of the 2.1.0 branch. I chose
> this particular commit from Nixpkgs:
>
> - https://github.com/NixOS/nixpkgs/blob/3fa15c357033b1c7bdb88f34c1fb9f6427b4754c/pkgs/development/interpreters/luajit/2.1.nix
>
> In addition to fixing the Neovim build, this also fixes a vulnerability
> that has been reported in the luajit 2.1.0-beta3 release and patched in
> the development tree:
>
> - https://nvd.nist.gov/vuln/detail/CVE-2020-24372
> - https://github.com/LuaJIT/LuaJIT/issues/603
>
> I was also able to remove the luajit patch for a missing ldconfig, this
> behaviour has been fixed in upstream since January 2020:
>
> - https://github.com/LuaJIT/LuaJIT/commit/18c9cf7d3788a8f7408df45df92fc4ae3bcc0d80

That makes a lot of sense.  Finally applied, thanks!

Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.