Subject: bug#58892: closed (Re: bug#58892: 29.0.50; [PATCH] eglot-manual: Open the local info documentation)

From: [email-masked] (GNU bug Tracking System)
Date: Fri, 11 Nov 2022 13:06:02 +0000

Your bug report

#58892: 29.0.50; [PATCH] eglot-manual: Open the local info documentation

which was filed against the emacs package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to [email-masked].

-- 
58892: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=58892
GNU Bug Tracking System
Contact [email-masked] with problems

Subject: Re: bug#58892: 29.0.50; [PATCH] eglot-manual: Open the local info documentation
From: Stefan Kangas <[email-masked]>
To: João Távora <[email-masked]>
Cc: [email-masked], Eli Zaretskii <[email-masked]>, Felician Nemeth <[email-masked]>, [email-masked], [email-masked]
Date: Fri, 11 Nov 2022 05:05:28 -0800
List-Id: <debbugs-submit.debbugs.gnu.org>

João Távora <[email-masked]> writes:

> On Sun, Oct 30, 2022 at 2:02 PM Eli Zaretskii <[email-masked]> wrote:
>
>  > Currently, Eglot has a menu item that opens
>  > https://github.com/joaotavora/eglot#readme.  I think opening that URL
>  > doesn't make sense anymore since eglot.texi is the primary source of the
>  > documentation.   Is it OK then to remove this menu item?
>
>  Fine by me, but please wait for João to chime in.
>
> Yes, it's fine. Show a patch and or push directly if you have permissions.

Now done, see commit c64d94c849.

Subject: 29.0.50; [PATCH] eglot-manual: Open the local info documentation
From: Felician Nemeth <[email-masked]>
To: [email-masked]
Date: Sun, 30 Oct 2022 10:05:25 +0100
List-Id: <debbugs-submit.debbugs.gnu.org>

Eglot now has a beautiful documentation in info format.  This patch
let the user open it from Eglot's menu.

BTW, the menu is the mode-line and I think it cannot be accessed using
only the keyboard.  Would it make sense to put this menu in the "Tools"
part of the menu-bar as well?

Thanks.

>From 2877c7ef6832b7f1bc3f3cfd46d8701dafa0af43 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Felici=C3=A1n=20N=C3=A9meth?= <[email-masked]>
Date: Sun, 30 Oct 2022 09:51:46 +0100
Subject: [PATCH] eglot-manual: Open the local info documentation

* lisp/progmodes/eglot.el (eglot-manual): Open the local info
documentation instead of the on-line version.
---
 lisp/progmodes/eglot.el | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/lisp/progmodes/eglot.el b/lisp/progmodes/eglot.el
index c587061837..1d67f37e34 100644
--- a/lisp/progmodes/eglot.el
+++ b/lisp/progmodes/eglot.el
@@ -1823,8 +1823,8 @@ eglot--mouse-call
                                            (call-interactively what)
                                            (force-mode-line-update t))))))
 
-(defun eglot-manual () "Open on-line documentation."
-  (interactive) (browse-url "https://github.com/joaotavora/eglot#readme"))
+(defun eglot-manual () "Open documentation."
+  (interactive) (info "(eglot)"))
 
 (easy-menu-define eglot-menu nil "Eglot"
   `("Eglot"
-- 
2.30.2