GNU bug report logs - #58877
29.0.50; [PATCH] When killing Emacs from a client frame with no other frames, Emacs shows a useless error prompt

Previous Next

Full log

Message #17 received at 58877 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Jim Porter <jporterbugs <at> gmail.com>
Cc: 58877 <at> debbugs.gnu.org
Subject: Re: bug#58877: 29.0.50; [PATCH] When killing Emacs from a client
 frame with no other frames, Emacs shows a useless error prompt
Date: Thu, 24 Nov 2022 13:51:13 +0200

> Date: Mon, 21 Nov 2022 21:06:31 -0800
> From: Jim Porter <jporterbugs <at> gmail.com>
> Cc: 58877 <at> debbugs.gnu.org
> 
> On 10/30/2022 2:14 PM, Jim Porter wrote:
> > Thanks for taking a look. I had hesitated to make any big changes to 
> > this code since it doesn't have regression tests...
> Since server.el could probably use more tests anyway, I added a few ERT 
> tests covering the most common use cases (see the first patch), and then 
> added another test for the second patch. The test in the second patch is 
> pretty indirect, but that's because it's testing something that normally 
> happens when killing Emacs; it'd be hard to kill the current Emacs 
> instance and still be able to check test results!

This is fine with me, but please fix the typo before installing:

> +(defun server-stop (&optional noframe)
> +  "If this Emacs process has a server communication subprocess, stop it.
> +If the server is running in some other Emac process (see
                                          ^^^^

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.