From unknown Sat Jun 14 04:55:23 2025 X-Loop: help-debbugs@gnu.org Subject: bug#58877: 29.0.50; [PATCH] When killing Emacs from a client frame with no other frames, Emacs shows a useless error prompt Resent-From: Jim Porter Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 29 Oct 2022 21:34:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 58877 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: 58877@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.16670792345247 (code B ref -1); Sat, 29 Oct 2022 21:34:02 +0000 Received: (at submit) by debbugs.gnu.org; 29 Oct 2022 21:33:54 +0000 Received: from localhost ([127.0.0.1]:36792 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ootSj-0001MY-IW for submit@debbugs.gnu.org; Sat, 29 Oct 2022 17:33:53 -0400 Received: from lists.gnu.org ([209.51.188.17]:56464) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ootSe-0001MO-WB for submit@debbugs.gnu.org; Sat, 29 Oct 2022 17:33:52 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ootSe-0001gD-Os for bug-gnu-emacs@gnu.org; Sat, 29 Oct 2022 17:33:48 -0400 Received: from mail-pj1-x1031.google.com ([2607:f8b0:4864:20::1031]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ootSc-0004Bm-T2 for bug-gnu-emacs@gnu.org; Sat, 29 Oct 2022 17:33:48 -0400 Received: by mail-pj1-x1031.google.com with SMTP id f5-20020a17090a4a8500b002131bb59d61so10017808pjh.1 for ; Sat, 29 Oct 2022 14:33:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:subject:from:content-language:mime-version:date:message-id:from :to:cc:subject:date:message-id:reply-to; bh=my1eDXVALNFtbiLgxJsoJBBbXLtiOKXfz2dGAoZgBY4=; b=WmKa9zIRg/tPeoLhbOGvfHnR8PoSOx693HzruOl678UJN90Whxtj7gAdLExm1ZL/RE qAFgqOHnORyhLst7f+JEbzozAYbLB7Q3qrpwuP/t+iO4iPzAQ5cbGz/3wVdKkL2SgUzM xCYw6IJfN9rTWszkEg32KZEYsu0vrQq3cQUoHsiQ9X+flj25/gceREnUB2+SQ/sx1yEF b0hY3Bh/wcLhiX/wB5/Bghwm3jukjHe5Cz5kJM8QyGGjeWPUkEp0kpPgR5yz2auoPifz R/OVu9JToiY9IXXXgzjvc6t8ueVNKEApv41kcYlgwDwaO4SeC7F0SBQuZSDihHou5Rhv xSmg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:subject:from:content-language:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=my1eDXVALNFtbiLgxJsoJBBbXLtiOKXfz2dGAoZgBY4=; b=UFCALDOhV0CYrThBRCwsRY3Xdlkwf9EM/3M0yLab/v69Wp+Fz836YgczyNDKreDPpN Gcf6+d7RK+emmLhDuypQ9BqdanXgxviIhBPNFE+KGVEyta6JHkqRpNgB8jzjGDktAPNT N7dRCxLh5Ptkv/zTf6rdz7XiIljkeZAYJ13dDFV/pYKaeAX4p9d1fzP5LmnfLZ1YMPl0 +hO1t4Zq4WIj4woaJ+MiSx6DOcplW0JQZhSFoEptQ4fEMbR5+EqpcOmZ9H6b+ujpyAL1 lkcg8F7L+eD30zwMkp2tuQcL6DeWZinMeNuFTWW+R/TalSyU05+h9lXCrGxv2744eV1E 4Ong== X-Gm-Message-State: ACrzQf3laDeQbpDG6BLcvf0JquXbBz+18njF4m12pueJeAfa+yDdMAw7 sAJiADcn1d+5/ZFEM1i9BFHz6RcOYEI= X-Google-Smtp-Source: AMsMyM63h0ZZDZK+r8NhqjOQhlWhxowjJT8z0qhGT7s26yMj6fxMWnkz1rzw45AF199+c54Pf7bm1w== X-Received: by 2002:a17:903:2596:b0:186:a395:c4bd with SMTP id jb22-20020a170903259600b00186a395c4bdmr6345194plb.60.1667079224713; Sat, 29 Oct 2022 14:33:44 -0700 (PDT) Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id u10-20020a170902714a00b001730a1af0fbsm1728318plm.23.2022.10.29.14.33.43 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 29 Oct 2022 14:33:43 -0700 (PDT) Content-Type: multipart/mixed; boundary="------------m0GquRHHJ48pym6nKNABktgY" Message-ID: <8121efd5-77c3-0682-ce0f-6be9375dadd8@gmail.com> Date: Sat, 29 Oct 2022 14:33:42 -0700 MIME-Version: 1.0 X-Mozilla-News-Host: news://news.gmane.io:119 Content-Language: en-US From: Jim Porter Received-SPF: pass client-ip=2607:f8b0:4864:20::1031; envelope-from=jporterbugs@gmail.com; helo=mail-pj1-x1031.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) This is a multi-part message in MIME format. --------------m0GquRHHJ48pym6nKNABktgY Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit (Note: I originally mentioned this in bug#51993, but it's only somewhat-related to that bug. To make things easier to follow, I pulled this part out into a separate bug.) To see this in action: $ emacs -Q -f server-start $ emacsclient -c foo.txt ;; From the first (non-client) frame: C-x 5 0 ;; delete-frame ;; From the second (client) frame: M-x kill-emacs ;; Emacs prompts: Error (error Attempt to delete the sole visible or iconified frame); continue? (y or n) Pressing "y" will properly kill Emacs, but there's no real use for the warning in this case. It happens because 'server-force-stop' (indirectly) tries to delete the last (client) frame before killing Emacs, meaning that Emacs would have zero frames for a bit. Since 'server-force-stop's docstring says, "This function is meant to be called from `kill-emacs-hook'," it should be safe to have 'server-force-stop' avoid deleting any frames: they'll just get deleted when Emacs is actually killed. Attached is a patch to do this. Note that I named the new argument "noframe" because that matches the existing code in server.el (see 'server-delete-client'). It's a bit of a misnomer though, and maybe "keep-frames" would be better... --------------m0GquRHHJ48pym6nKNABktgY Content-Type: text/plain; charset=UTF-8; name="0001-Don-t-explicitly-delete-client-frames-when-killing-E.patch" Content-Disposition: attachment; filename*0="0001-Don-t-explicitly-delete-client-frames-when-killing-E.pa"; filename*1="tch" Content-Transfer-Encoding: base64 RnJvbSA1MjI1NzRjZTY5ZTNjMTk4YTQwYjU3ZTJlMjExZTE0NTYyMzM0ZjMzIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKaW0gUG9ydGVyIDxqcG9ydGVyYnVnc0BnbWFpbC5j b20+CkRhdGU6IEZyaSwgMTkgTm92IDIwMjEgMjA6MTQ6MzMgLTA4MDAKU3ViamVjdDogW1BB VENIXSBEb24ndCBleHBsaWNpdGx5IGRlbGV0ZSBjbGllbnQgZnJhbWVzIHdoZW4ga2lsbGlu ZyBFbWFjcwogYW55d2F5CgpUaGlzIGVsaW1pbmF0ZXMgYSB1c2VsZXNzIGVycm9yIHByb21w dCB3aGVuIGtpbGxpbmcgRW1hY3MgZnJvbSBhCmNsaWVudCBmcmFtZSB3aGVuIHRoZXJlIGFy ZSBubyBvdGhlciBmcmFtZXMuCgoqIGxpc3Avc2VydmVyLmVsIChzZXJ2ZXItc3RhcnQpOiBB ZGQgTk9GUkFNRSBhcmd1bWVudCB0byBhdm9pZApkZWxldGluZyBmcmFtZXMuCihzZXJ2ZXIt Zm9yY2Utc3RvcCk6IFBhc3MgJ25vZnJhbWUnIHRvICdzZXJ2ZXItc3RvcCcuCi0tLQogbGlz cC9zZXJ2ZXIuZWwgfCAxMSArKysrKysrKy0tLQogMSBmaWxlIGNoYW5nZWQsIDggaW5zZXJ0 aW9ucygrKSwgMyBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9saXNwL3NlcnZlci5lbCBi L2xpc3Avc2VydmVyLmVsCmluZGV4IDkwZDk3YzE1MzguLjJiNzIxM2I4OTAgMTAwNjQ0Ci0t LSBhL2xpc3Avc2VydmVyLmVsCisrKyBiL2xpc3Avc2VydmVyLmVsCkBAIC02MTEsNyArNjEx LDcgQEAgc2VydmVyLWdldC1hdXRoLWtleQogICAgIChzZXJ2ZXItZ2VuZXJhdGUta2V5KSkp CiAKIDs7OyMjI2F1dG9sb2FkCi0oZGVmdW4gc2VydmVyLXN0YXJ0ICgmb3B0aW9uYWwgbGVh dmUtZGVhZCBpbmhpYml0LXByb21wdCkKKyhkZWZ1biBzZXJ2ZXItc3RhcnQgKCZvcHRpb25h bCBsZWF2ZS1kZWFkIGluaGliaXQtcHJvbXB0IG5vZnJhbWUpCiAgICJBbGxvdyB0aGlzIEVt YWNzIHByb2Nlc3MgdG8gYmUgYSBzZXJ2ZXIgZm9yIGNsaWVudCBwcm9jZXNzZXMuCiBUaGlz IHN0YXJ0cyBhIHNlcnZlciBjb21tdW5pY2F0aW9ucyBzdWJwcm9jZXNzIHRocm91Z2ggd2hp Y2ggY2xpZW50CiBcImVkaXRvcnNcIiBjYW4gc2VuZCB5b3VyIGVkaXRpbmcgY29tbWFuZHMg dG8gdGhpcyBFbWFjcyBqb2IuCkBAIC02MjUsNiArNjI1LDExIEBAIHNlcnZlci1zdGFydAog cnVubmluZywgYXNrIHRoZSB1c2VyIGZvciBjb25maXJtYXRpb24gZmlyc3QsIHVubGVzcyBv cHRpb25hbAogYXJndW1lbnQgSU5ISUJJVC1QUk9NUFQgaXMgbm9uLW5pbC4KIAorSWYgTk9G UkFNRSBpcyBub24tbmlsLCBkb24ndCBkZWxldGUgYW55IGV4aXN0aW5nIGZyYW1lcworYXNz b2NpYXRlZCB3aXRoIGEgY2xpZW50IHByb2Nlc3MuICBUaGlzIGlzIHVzZWZ1bCwgZm9yIGV4 YW1wbGUsCit3aGVuIGtpbGxpbmcgRW1hY3MsIGluIHdoaWNoIGNhc2UgdGhlIGZyYW1lcyB3 aWxsIGdldCBkZWxldGVkCithbnl3YXkuCisKIFRvIGZvcmNlLXN0YXJ0IGEgc2VydmVyLCBk byBcXFtzZXJ2ZXItZm9yY2UtZGVsZXRlXSBhbmQgdGhlbgogXFxbc2VydmVyLXN0YXJ0XS4K IApAQCAtNjgzLDcgKzY4OCw3IEBAIHNlcnZlci1zdGFydAogICAgICAgICAgKHNldHEgbGVh dmUtZGVhZCB0KSkpCiAgICAgICA7OyBJZiB0aGlzIEVtYWNzIGFscmVhZHkgaGFkIGEgc2Vy dmVyLCBjbGVhciBvdXQgYXNzb2NpYXRlZCBzdGF0dXMuCiAgICAgICAod2hpbGUgc2VydmVy LWNsaWVudHMKLQkoc2VydmVyLWRlbGV0ZS1jbGllbnQgKGNhciBzZXJ2ZXItY2xpZW50cykp KQorCShzZXJ2ZXItZGVsZXRlLWNsaWVudCAoY2FyIHNlcnZlci1jbGllbnRzKSBub2ZyYW1l KSkKICAgICAgIDs7IE5vdyBhbnkgcHJldmlvdXMgc2VydmVyIGlzIHByb3Blcmx5IHN0b3Bw ZWQuCiAgICAgICAoaWYgbGVhdmUtZGVhZAogCSAgKHByb2duCkBAIC03NDIsNyArNzQ3LDcg QEAgc2VydmVyLXN0YXJ0CiAoZGVmdW4gc2VydmVyLWZvcmNlLXN0b3AgKCkKICAgIktpbGwg YWxsIGNvbm5lY3Rpb25zIHRvIHRoZSBjdXJyZW50IHNlcnZlci4KIFRoaXMgZnVuY3Rpb24g aXMgbWVhbnQgdG8gYmUgY2FsbGVkIGZyb20gYGtpbGwtZW1hY3MtaG9vaycuIgotICAoc2Vy dmVyLXN0YXJ0IHQgdCkpCisgIChzZXJ2ZXItc3RhcnQgdCB0ICdub2ZyYW1lKSkKIAogOzs7 IyMjYXV0b2xvYWQKIChkZWZ1biBzZXJ2ZXItZm9yY2UtZGVsZXRlICgmb3B0aW9uYWwgbmFt ZSkKLS0gCjIuMjUuMQoK --------------m0GquRHHJ48pym6nKNABktgY-- From unknown Sat Jun 14 04:55:23 2025 X-Loop: help-debbugs@gnu.org Subject: bug#58877: 29.0.50; [PATCH] When killing Emacs from a client frame with no other frames, Emacs shows a useless error prompt Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 30 Oct 2022 06:16:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58877 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Jim Porter Cc: 58877@debbugs.gnu.org Received: via spool by 58877-submit@debbugs.gnu.org id=B58877.166711051128573 (code B ref 58877); Sun, 30 Oct 2022 06:16:02 +0000 Received: (at 58877) by debbugs.gnu.org; 30 Oct 2022 06:15:11 +0000 Received: from localhost ([127.0.0.1]:37157 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1op1bD-0007Qm-85 for submit@debbugs.gnu.org; Sun, 30 Oct 2022 02:15:11 -0400 Received: from eggs.gnu.org ([209.51.188.92]:55450) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1op1bB-0007QV-0u for 58877@debbugs.gnu.org; Sun, 30 Oct 2022 02:15:10 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1op1b5-0005GG-N3; Sun, 30 Oct 2022 02:15:03 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=ANpmIS4GP0IQ91wFU235CurnmR5oyPWCRe5L6e+zQq0=; b=YBc33OhJnqZG 9Auqw+58wrbq0aYqNU/isv3f4GwOe8eUFx4MmLyDSgfh/LJFksasLp1h3ZnoKXQEj4zbgX4JCCcbF zFEpPJm9aXf+CBPVjQfpa3fvSLmk76GJFgofHFmN67/TzU1bMzI97X8iCZ63+EbmalGzw9hri0LlN SoeyZx1Hoj48QNE1Bq+kVvuC1m5isLqXb2bfyU056L+g7wQN/tkjSquuIw47nX3FOc/L0nxbRqnkk S+GkAIFEQKwDpjlPmBrGnFf/mVTRQj4vCh75O0U9Da5TxDfObXQPPxAdXrqmA1mJffAKQPZyljTl0 WUZMJeEFzx1JYGQ8mDs/3A==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1op1b5-0005cb-1o; Sun, 30 Oct 2022 02:15:03 -0400 Date: Sun, 30 Oct 2022 08:14:44 +0200 Message-Id: <83a65dhm7f.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: <8121efd5-77c3-0682-ce0f-6be9375dadd8@gmail.com> (message from Jim Porter on Sat, 29 Oct 2022 14:33:42 -0700) References: <8121efd5-77c3-0682-ce0f-6be9375dadd8@gmail.com> X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Sat, 29 Oct 2022 14:33:42 -0700 > From: Jim Porter > > Attached is a patch to do this. Note that I named the new argument > "noframe" because that matches the existing code in server.el (see > 'server-delete-client'). It's a bit of a misnomer though, and maybe > "keep-frames" would be better... Hmm... it doesn't look very elegant to add to server-start an extra argument whose purpose is to affect server-delete-client. Can we do this in some more elegant way? For example, how about making most of the code in server-start an internal function with an additional argument, and then have server-start and server-force-stop call that internal function? At the very least the new argument to server-start shouldn't be advertised, I think, since it's entirely for internal use by us. Thanks. From unknown Sat Jun 14 04:55:23 2025 X-Loop: help-debbugs@gnu.org Subject: bug#58877: 29.0.50; [PATCH] When killing Emacs from a client frame with no other frames, Emacs shows a useless error prompt Resent-From: Jim Porter Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 30 Oct 2022 21:16:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58877 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Eli Zaretskii Cc: 58877@debbugs.gnu.org Received: via spool by 58877-submit@debbugs.gnu.org id=B58877.166716451132271 (code B ref 58877); Sun, 30 Oct 2022 21:16:02 +0000 Received: (at 58877) by debbugs.gnu.org; 30 Oct 2022 21:15:11 +0000 Received: from localhost ([127.0.0.1]:39083 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1opFeA-0008OQ-Ct for submit@debbugs.gnu.org; Sun, 30 Oct 2022 17:15:11 -0400 Received: from mail-pj1-f43.google.com ([209.85.216.43]:38500) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1opFe8-0008OC-0J for 58877@debbugs.gnu.org; Sun, 30 Oct 2022 17:15:08 -0400 Received: by mail-pj1-f43.google.com with SMTP id l22-20020a17090a3f1600b00212fbbcfb78so14268919pjc.3 for <58877@debbugs.gnu.org>; Sun, 30 Oct 2022 14:15:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:from:references:cc:to:content-language:subject :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=JrgU9dWAska7YI67clceWpiroACmd4YnljJZfnZpspk=; b=egb7cM2HdiVHA5O7jgrJnFhS4iTwt2XBDTviPmluRGjQ6LFHT96Ysf+YLTjWBpMfep V401zTVivqq9iWts+eDuNHbT+TLpZojX+iMjNn92124LXwoDq+MdO6ugrxrIwONk7Rcc R9p5jHlQ/Sb4WN4llOH+LEAa8424L2GIliotYqAzpTNQs1wf3Uli2UYSEm0oS3WZYP0W UFn6dqOvlsj13dCNc+nX6TP+P53D70wunbqwCQnmXDfYTwimrLoAoKbFRlshkpVb6vMs RS1i+pXp4HBUm515qhQCIvTUU5yKwTIC4h2RP8Xr+zLK0oSACsYbTMOQuNK86Kml8vZZ 6Y4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:from:references:cc:to:content-language:subject :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=JrgU9dWAska7YI67clceWpiroACmd4YnljJZfnZpspk=; b=yWaRMvQP7czYEXTqkD+iSA0OT2xUMcM6CzkCuXnuz00U7tgLqwTqMkwU8Suhtwz1/B uBa+Ngmzu1J20A7M0hF6RZTSRYjm7707Wgrhr78X/YMXReK/UJotJZJymMnpo8buwx0z uZam/YZ73ihnbWBXjgkGuKKLALTgQKlBSF8zDxeWzqsychthmbJ5/yUfNmrDJDX30D4v rVSPGjtcEKCKesorHOh0Ljp1y/Am0v4BQxlIFV2uaIZfV1aa6Z6011DabWr1tlTMnV2m EswnYtA5slwfM8oiLL18t8FTuTlx8yeD3YP3O/PIgg6fWi3sD2FGp8ZHLxoM6vAYxR3T 1o9w== X-Gm-Message-State: ACrzQf1y8+tMErhZ3G7bveszhKg4o/1OUsAUQh0UiXCwvKcEBGkrDAPB 8VkY6+O4G/FlcxGG6HdTUHY= X-Google-Smtp-Source: AMsMyM71SVsutuPdBCa3LyQVmf1/bul2QkaqkU8iZ+oA5QlP0UDUaSHg0I7gJYkIGHGpHepA3G9nVg== X-Received: by 2002:a17:902:ec8e:b0:186:de89:7f66 with SMTP id x14-20020a170902ec8e00b00186de897f66mr11024261plg.160.1667164501909; Sun, 30 Oct 2022 14:15:01 -0700 (PDT) Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id pj14-20020a17090b4f4e00b00212cf2fe8c3sm21275853pjb.1.2022.10.30.14.14.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 30 Oct 2022 14:15:00 -0700 (PDT) Content-Type: multipart/mixed; boundary="------------3GBLHKzCHc5luDdDPtaJENk9" Message-ID: <13835614-c593-ba2d-5373-a9950f6f3dab@gmail.com> Date: Sun, 30 Oct 2022 14:14:59 -0700 MIME-Version: 1.0 Content-Language: en-US References: <8121efd5-77c3-0682-ce0f-6be9375dadd8@gmail.com> <83a65dhm7f.fsf@gnu.org> From: Jim Porter In-Reply-To: <83a65dhm7f.fsf@gnu.org> X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) This is a multi-part message in MIME format. --------------3GBLHKzCHc5luDdDPtaJENk9 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 10/29/2022 11:14 PM, Eli Zaretskii wrote: >> Date: Sat, 29 Oct 2022 14:33:42 -0700 >> From: Jim Porter >> >> Attached is a patch to do this. Note that I named the new argument >> "noframe" because that matches the existing code in server.el (see >> 'server-delete-client'). It's a bit of a misnomer though, and maybe >> "keep-frames" would be better... > > Hmm... it doesn't look very elegant to add to server-start an extra > argument whose purpose is to affect server-delete-client. Can we do > this in some more elegant way? For example, how about making most of > the code in server-start an internal function with an additional > argument, and then have server-start and server-force-stop call that > internal function? At the very least the new argument to server-start > shouldn't be advertised, I think, since it's entirely for internal use > by us. Thanks for taking a look. I had hesitated to make any big changes to this code since it doesn't have regression tests, but I think the attached patch should be more elegant while retaining the flow of the code as much as possible. Do you know of a good way to write regression tests for this code? I couldn't find any existing tests that start/stop Emacs processes in a way that I could use for testing this. It seems like we'd need to be able to start a new Emacs process and then be able to send arbitrary key combinations to it to drive it... Back to the patch itself though: one small functional change I made was that I slightly changed how 'server-ensure-safe-dir' is called in 'server-start'. (I only mention this because this code looks to be security-related, so I think it should have extra attention.) It used to check the 'server-dir', defined as: (if server-use-tcp server-auth-dir server-socket-dir) Now, it checks the directory of the server *file*. The file is defined as: (expand-file-name server-name server-dir) This could be different if 'server-name' (a defcustom) contains a slash. I think the new code is actually safer, since it checks the proper directory even if a user customized 'server-name' to have a slash or '..' or whatever. Still, I thought this change deserved a mention so that I don't inadvertently open a security hole. --------------3GBLHKzCHc5luDdDPtaJENk9 Content-Type: text/plain; charset=UTF-8; name="0001-Don-t-explicitly-delete-client-frames-when-killing-E.patch" Content-Disposition: attachment; filename*0="0001-Don-t-explicitly-delete-client-frames-when-killing-E.pa"; filename*1="tch" Content-Transfer-Encoding: base64 RnJvbSA1NGVlMjU2YWRhYWQ1M2EzODcxMmNhMTk0YmQ5ZTFiYThiMDBhMzk3IE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKaW0gUG9ydGVyIDxqcG9ydGVyYnVnc0BnbWFpbC5j b20+CkRhdGU6IEZyaSwgMTkgTm92IDIwMjEgMjA6MTQ6MzMgLTA4MDAKU3ViamVjdDogW1BB VENIXSBEb24ndCBleHBsaWNpdGx5IGRlbGV0ZSBjbGllbnQgZnJhbWVzIHdoZW4ga2lsbGlu ZyBFbWFjcwogYW55d2F5CgpUaGlzIGVsaW1pbmF0ZXMgYSB1c2VsZXNzIGVycm9yIHByb21w dCB3aGVuIGtpbGxpbmcgRW1hY3MgZnJvbSBhCmNsaWVudCBmcmFtZSB3aGVuIHRoZXJlIGFy ZSBubyBvdGhlciBmcmFtZXMgKGJ1ZyM1ODg3NykuCgoqIGxpc3Avc2VydmVyLmVsIChzZXJ2 ZXItcnVubmluZy1leHRlcm5hbCk6IE5ldyBlcnJvci4KKHNlcnZlci0tZmlsZS1uYW1lKTog TmV3IGZ1bmN0aW9uLi4uCihzZXJ2ZXItZXZhbC1hdCk6IC4uLiB1c2UgaXQuCihzZXJ2ZXIt c3RhcnQpOiBGYWN0b3Igb3V0IHNlcnZlciBzdG9wcGluZyBjb2RlIGludG8uLi4KKHNlcnZl ci1zdG9wKTogLi4uIGhlcmUuCihzZXJ2ZXItZm9yY2Utc3RvcCk6IFVzZSAnc2VydmVyLXN0 b3AnLCBhbmQgdGVsbCBpdCBub3QgdG8gZGVsZXRlCmZyYW1lcy4KLS0tCiBsaXNwL3NlcnZl ci5lbCB8IDEzMiArKysrKysrKysrKysrKysrKysrKysrKysrKysrKy0tLS0tLS0tLS0tLS0t LS0tLS0tCiAxIGZpbGUgY2hhbmdlZCwgNzggaW5zZXJ0aW9ucygrKSwgNTQgZGVsZXRpb25z KC0pCgpkaWZmIC0tZ2l0IGEvbGlzcC9zZXJ2ZXIuZWwgYi9saXNwL3NlcnZlci5lbAppbmRl eCA5MGQ5N2MxNTM4Li4wOTVkZTA2Y2Y5IDEwMDY0NAotLS0gYS9saXNwL3NlcnZlci5lbAor KysgYi9saXNwL3NlcnZlci5lbApAQCAtMjg3LDYgKzI4Nyw4IEBAIHNlcnZlci1zb2NrZXQt ZGlyCiAgICJUaGUgZGlyZWN0b3J5IGluIHdoaWNoIHRvIHBsYWNlIHRoZSBzZXJ2ZXIgc29j a2V0LgogSWYgbG9jYWwgc29ja2V0cyBhcmUgbm90IHN1cHBvcnRlZCwgdGhpcyBpcyBuaWwu IikKIAorKGRlZmluZS1lcnJvciAnc2VydmVyLXJ1bm5pbmctZXh0ZXJuYWwgIkV4dGVybmFs IHNlcnZlciBydW5uaW5nIikKKwogKGRlZnVuIHNlcnZlci1jbGllbnRzLXdpdGggKHByb3Bl cnR5IHZhbHVlKQogICAiUmV0dXJuIGEgbGlzdCBvZiBjbGllbnRzIHdpdGggUFJPUEVSVFkg c2V0IHRvIFZBTFVFLiIKICAgKGxldCAocmVzdWx0KQpAQCAtNjEwLDYgKzYxMiw1OSBAQCBz ZXJ2ZXItZ2V0LWF1dGgta2V5CiAgICAgICAoZXJyb3IgIlRoZSBrZXkgYCVzJyBpcyBpbnZh bGlkIiBzZXJ2ZXItYXV0aC1rZXkpKQogICAgIChzZXJ2ZXItZ2VuZXJhdGUta2V5KSkpCiAK KyhkZWZzdWJzdCBzZXJ2ZXItLWZpbGUtbmFtZSAoKQorICAiUmV0dXJuIHRoZSBmaWxlIG5h bWUgdG8gdXNlIGZvciB0aGUgc2VydmVyIHNvY2tldC4iCisgIChsZXQgKChzZXJ2ZXItZGly IChpZiBzZXJ2ZXItdXNlLXRjcCBzZXJ2ZXItYXV0aC1kaXIgc2VydmVyLXNvY2tldC1kaXIp KSkKKyAgICAoZXhwYW5kLWZpbGUtbmFtZSBzZXJ2ZXItbmFtZSBzZXJ2ZXItZGlyKSkpCisK KyhkZWZ1biBzZXJ2ZXItc3RvcCAoJm9wdGlvbmFsIG5vZnJhbWUpCisgICJJZiB0aGlzIEVt YWNzIHByb2Nlc3MgaGFzIGEgc2VydmVyIGNvbW11bmljYXRpb24gc3VicHJvY2Vzcywgc3Rv cCBpdC4KK0lmIHRoZSBzZXJ2ZXIgaXMgcnVubmluZyBpbiBzb21lIG90aGVyIEVtYWMgcHJv Y2VzcyAoc2VlCitgc2VydmVyLXJ1bm5pbmctcCcpLCBzaWduYWwgYSBgc2VydmVyLXJ1bm5p bmctZXh0ZXJuYWwnIGVycm9yLgorCitJZiBOT0ZSQU1FIGlzIG5vbi1uaWwsIGRvbid0IGRl bGV0ZSBhbnkgZXhpc3RpbmcgZnJhbWVzCithc3NvY2lhdGVkIHdpdGggYSBjbGllbnQgcHJv Y2Vzcy4gIFRoaXMgaXMgdXNlZnVsLCBmb3IgZXhhbXBsZSwKK3doZW4ga2lsbGluZyBFbWFj cywgaW4gd2hpY2ggY2FzZSB0aGUgZnJhbWVzIHdpbGwgZ2V0IGRlbGV0ZWQKK2FueXdheS4i CisgIChsZXQgKChzZXJ2ZXItZmlsZSAoc2VydmVyLS1maWxlLW5hbWUpKSkKKyAgICAod2hl biBzZXJ2ZXItcHJvY2VzcworICAgICAgOzsgS2lsbCBpdCBkZWFkIQorICAgICAgKGlnbm9y ZS1lcnJvcnMgKGRlbGV0ZS1wcm9jZXNzIHNlcnZlci1wcm9jZXNzKSkKKyAgICAgICh1bmxl c3Mgbm9mcmFtZQorICAgICAgICAoc2VydmVyLWxvZyAobWVzc2FnZSAiU2VydmVyIHN0b3Bw ZWQiKSkpCisgICAgICAoc2V0cSBzZXJ2ZXItcHJvY2VzcyBuaWwpKQorICAgICh1bndpbmQt cHJvdGVjdAorICAgICAgICA7OyBDaGVjayB0byBzZWUgaWYgYW4gdW5pbml0aWFsaXplZCBl eHRlcm5hbCBzb2NrZXQgaGFzIGJlZW4KKyAgICAgICAgOzsgcGFzc2VkIGluLiAgSWYgdGhh dCBpcyB0aGUgY2FzZSwgc2tpcCBjaGVja2luZworICAgICAgICA7OyBgc2VydmVyLXJ1bm5p bmctcCcgYXMgdGhpcyB3aWxsIHJldHVybiB0aGUgd3JvbmcgcmVzdWx0LgorICAgICAgICAo aWYgKGFuZCBpbnRlcm5hbC0tZGFlbW9uLXNvY2tuYW1lCisgICAgICAgICAgICAgICAgIChu b3Qgc2VydmVyLS1leHRlcm5hbC1zb2NrZXQtaW5pdGlhbGl6ZWQpKQorICAgICAgICAgICAg KHNldHEgc2VydmVyLS1leHRlcm5hbC1zb2NrZXQtaW5pdGlhbGl6ZWQgdCkKKyAgICAgICAg ICA7OyBEZWxldGUgdGhlIHNvY2tldCBmaWxlcyBtYWRlIGJ5IHByZXZpb3VzIHNlcnZlcgor ICAgICAgICAgIDs7IGludm9jYXRpb25zLgorICAgICAgICAgIChpZiAobm90IChlcSB0IChz ZXJ2ZXItcnVubmluZy1wIHNlcnZlci1uYW1lKSkpCisgICAgICAgICAgICAgIDs7IFJlbW92 ZSBhbnkgbGVmdG92ZXIgc29ja2V0IG9yIGF1dGhlbnRpY2F0aW9uIGZpbGUuCisgICAgICAg ICAgICAgIChpZ25vcmUtZXJyb3JzCisgICAgICAgICAgICAgICAgKGxldCAoZGVsZXRlLWJ5 LW1vdmluZy10by10cmFzaCkKKyAgICAgICAgICAgICAgICAgIChkZWxldGUtZmlsZSBzZXJ2 ZXItZmlsZSkKKyAgICAgICAgICAgICAgICAgIDs7IEFsc28gZGVsZXRlIHRoZSBkaXJlY3Rv cnkgdGhhdCB0aGUgc2VydmVyIGZpbGUgd2FzCisgICAgICAgICAgICAgICAgICA7OyBjcmVh dGVkIGluIC0tIGJ1dCBvbmx5IGluIC90bXAgKHNlZSBidWcjNDQ2NDQpLgorICAgICAgICAg ICAgICAgICAgOzsgVGhlcmUgbWF5IGJlIG90aGVyIHNlcnZlcnMgcnVubmluZywgdG9vLCBz byB0aGlzIG1heQorICAgICAgICAgICAgICAgICAgOzsgZmFpbC4KKyAgICAgICAgICAgICAg ICAgICh3aGVuIChlcXVhbCAoZmlsZS1uYW1lLWRpcmVjdG9yeQorICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAoZGlyZWN0b3J5LWZpbGUtbmFtZQorICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgKGZpbGUtbmFtZS1kaXJlY3Rvcnkgc2VydmVyLWZpbGUpKSkK KyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAiL3RtcC8iKQorICAgICAgICAgICAg ICAgICAgICAoaWdub3JlLWVycm9ycworICAgICAgICAgICAgICAgICAgICAgIChkZWxldGUt ZGlyZWN0b3J5IChmaWxlLW5hbWUtZGlyZWN0b3J5IHNlcnZlci1maWxlKSkpKSkpCisgICAg ICAgICAgICAoc2V0cSBzZXJ2ZXItbW9kZSBuaWwpIDs7IGFscmVhZHkgc2V0IGJ5IHRoZSBt aW5vciBtb2RlIGNvZGUKKyAgICAgICAgICAgIChzaWduYWwgJ3NlcnZlci1ydW5uaW5nLWV4 dGVybmFsCisgICAgICAgICAgICAgICAgICAgIChsaXN0IChmb3JtYXQgIlRoZXJlIGlzIGFu IGV4aXN0aW5nIEVtYWNzIHNlcnZlciwgbmFtZWQgJVMuIgorICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgIHNlcnZlci1uYW1lKSkpKSkKKyAgICAgIDs7IElmIHRoaXMgRW1h Y3MgYWxyZWFkeSBoYWQgYSBzZXJ2ZXIsIGNsZWFyIG91dCBhc3NvY2lhdGVkIHN0YXR1cy4K KyAgICAgICh3aGlsZSBzZXJ2ZXItY2xpZW50cworICAgICAgICAoc2VydmVyLWRlbGV0ZS1j bGllbnQgKGNhciBzZXJ2ZXItY2xpZW50cykgbm9mcmFtZSkpKSkpCisKIDs7OyMjI2F1dG9s b2FkCiAoZGVmdW4gc2VydmVyLXN0YXJ0ICgmb3B0aW9uYWwgbGVhdmUtZGVhZCBpbmhpYml0 LXByb21wdCkKICAgIkFsbG93IHRoaXMgRW1hY3MgcHJvY2VzcyB0byBiZSBhIHNlcnZlciBm b3IgY2xpZW50IHByb2Nlc3Nlcy4KQEAgLTY0Myw1NSArNjk4LDI1IEBAIHNlcnZlci1zdGFy dAogCSAgICAgKGluaGliaXQtcHJvbXB0IHQpCiAJICAgICAodCAoeWVzLW9yLW5vLXAKIAkJ ICJUaGUgY3VycmVudCBzZXJ2ZXIgc3RpbGwgaGFzIGNsaWVudHM7IGRlbGV0ZSB0aGVtPyAi KSkpKQotICAgIChsZXQqICgoc2VydmVyLWRpciAoaWYgc2VydmVyLXVzZS10Y3Agc2VydmVy LWF1dGgtZGlyIHNlcnZlci1zb2NrZXQtZGlyKSkKLQkgICAoc2VydmVyLWZpbGUgKGV4cGFu ZC1maWxlLW5hbWUgc2VydmVyLW5hbWUgc2VydmVyLWRpcikpKQotICAgICAgKHdoZW4gc2Vy dmVyLXByb2Nlc3MKLQk7OyBraWxsIGl0IGRlYWQhCi0JKGlnbm9yZS1lcnJvcnMgKGRlbGV0 ZS1wcm9jZXNzIHNlcnZlci1wcm9jZXNzKSkpCi0gICAgICA7OyBDaGVjayB0byBzZWUgaWYg YW4gdW5pbml0aWFsaXplZCBleHRlcm5hbCBzb2NrZXQgaGFzIGJlZW4KLSAgICAgIDs7IHBh c3NlZCBpbiwgaWYgdGhhdCBpcyB0aGUgY2FzZSwgc2tpcCBjaGVja2luZwotICAgICAgOzsg YHNlcnZlci1ydW5uaW5nLXAnIGFzIHRoaXMgd2lsbCByZXR1cm4gdGhlIHdyb25nIHJlc3Vs dC4KLSAgICAgIChpZiAoYW5kIGludGVybmFsLS1kYWVtb24tc29ja25hbWUKLSAgICAgICAg ICAgICAgIChub3Qgc2VydmVyLS1leHRlcm5hbC1zb2NrZXQtaW5pdGlhbGl6ZWQpKQotICAg ICAgICAgIChzZXRxIHNlcnZlci0tZXh0ZXJuYWwtc29ja2V0LWluaXRpYWxpemVkIHQpCi0g ICAgICAgIDs7IERlbGV0ZSB0aGUgc29ja2V0IGZpbGVzIG1hZGUgYnkgcHJldmlvdXMgc2Vy dmVyIGludm9jYXRpb25zLgotICAgICAgICAoaWYgKG5vdCAoZXEgdCAoc2VydmVyLXJ1bm5p bmctcCBzZXJ2ZXItbmFtZSkpKQotICAgICAgICAgICA7OyBSZW1vdmUgYW55IGxlZnRvdmVy IHNvY2tldCBvciBhdXRoZW50aWNhdGlvbiBmaWxlLgotICAgICAgICAgICAoaWdub3JlLWVy cm9ycwotICAgICAgICAgICAgIChsZXQgKGRlbGV0ZS1ieS1tb3ZpbmctdG8tdHJhc2gpCi0g ICAgICAgICAgICAgICAoZGVsZXRlLWZpbGUgc2VydmVyLWZpbGUpCi0gICAgICAgICAgICAg ICA7OyBBbHNvIGRlbGV0ZSB0aGUgZGlyZWN0b3J5IHRoYXQgdGhlIHNlcnZlciBmaWxlIHdh cwotICAgICAgICAgICAgICAgOzsgY3JlYXRlZCBpbiAtLSBidXQgb25seSBpbiAvdG1wIChz ZWUgYnVnIzQ0NjQ0KS4KLSAgICAgICAgICAgICAgIDs7IFRoZXJlIG1heSBiZSBvdGhlciBz ZXJ2ZXJzIHJ1bm5pbmcsIHRvbywgc28gdGhpcyBtYXkKLSAgICAgICAgICAgICAgIDs7IGZh aWwuCi0gICAgICAgICAgICAgICAod2hlbiAoZXF1YWwgKGZpbGUtbmFtZS1kaXJlY3RvcnkK LSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgKGRpcmVjdG9yeS1maWxlLW5hbWUKLSAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgIChmaWxlLW5hbWUtZGlyZWN0b3J5IHNlcnZl ci1maWxlKSkpCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAgIi90bXAvIikKLSAgICAg ICAgICAgICAgICAgKGlnbm9yZS1lcnJvcnMKLSAgICAgICAgICAgICAgICAgICAoZGVsZXRl LWRpcmVjdG9yeSAoZmlsZS1uYW1lLWRpcmVjdG9yeSBzZXJ2ZXItZmlsZSkpKSkpKQotICAg ICAgICAgKHNldHEgc2VydmVyLW1vZGUgbmlsKSA7OyBhbHJlYWR5IHNldCBieSB0aGUgbWlu b3IgbW9kZSBjb2RlCi0gICAgICAgICAoZGlzcGxheS13YXJuaW5nCi0gICAgICAgICAgJ3Nl cnZlcgotICAgICAgICAgIChjb25jYXQgIlVuYWJsZSB0byBzdGFydCB0aGUgRW1hY3Mgc2Vy dmVyLlxuIgotICAgICAgICAgICAgICAgICAgKGZvcm1hdCAiVGhlcmUgaXMgYW4gZXhpc3Rp bmcgRW1hY3Mgc2VydmVyLCBuYW1lZCAlUy5cbiIKLSAgICAgICAgICAgICAgICAgICAgICAg ICAgc2VydmVyLW5hbWUpCi0gICAgICAgICAgICAgICAgICAoc3Vic3RpdHV0ZS1jb21tYW5k LWtleXMKLSAgICAgICAgICAgICAgICAgICAgIlRvIHN0YXJ0IHRoZSBzZXJ2ZXIgaW4gdGhp cyBFbWFjcyBwcm9jZXNzLCBzdG9wIHRoZSBleGlzdGluZworICAgIDs7IElmIGEgc2VydmVy IGlzIGFscmVhZHkgcnVubmluZywgdHJ5IHRvIHN0b3AgaXQuCisgICAgKGNvbmRpdGlvbi1j YXNlIGVycgorICAgICAgICAoc2VydmVyLXN0b3ApCisgICAgICAoc2VydmVyLXJ1bm5pbmct ZXh0ZXJuYWwKKyAgICAgICAoZGlzcGxheS13YXJuaW5nCisgICAgICAgICdzZXJ2ZXIKKyAg ICAgICAgKGNvbmNhdCAiVW5hYmxlIHRvIHN0YXJ0IHRoZSBFbWFjcyBzZXJ2ZXIuXG4iCisg ICAgICAgICAgICAgICAgKGNhZHIgZXJyKQorICAgICAgICAgICAgICAgIChzdWJzdGl0dXRl LWNvbW1hbmQta2V5cworICAgICAgICAgICAgICAgICAiXG5UbyBzdGFydCB0aGUgc2VydmVy IGluIHRoaXMgRW1hY3MgcHJvY2Vzcywgc3RvcCB0aGUgZXhpc3RpbmcKIHNlcnZlciBvciBj YWxsIGBcXFtzZXJ2ZXItZm9yY2UtZGVsZXRlXScgdG8gZm9yY2libHkgZGlzY29ubmVjdCBp dC4iKSkKLSAgICAgICAgICA6d2FybmluZykKLSAgICAgICAgIChzZXRxIGxlYXZlLWRlYWQg dCkpKQotICAgICAgOzsgSWYgdGhpcyBFbWFjcyBhbHJlYWR5IGhhZCBhIHNlcnZlciwgY2xl YXIgb3V0IGFzc29jaWF0ZWQgc3RhdHVzLgotICAgICAgKHdoaWxlIHNlcnZlci1jbGllbnRz Ci0JKHNlcnZlci1kZWxldGUtY2xpZW50IChjYXIgc2VydmVyLWNsaWVudHMpKSkKLSAgICAg IDs7IE5vdyBhbnkgcHJldmlvdXMgc2VydmVyIGlzIHByb3Blcmx5IHN0b3BwZWQuCi0gICAg ICAoaWYgbGVhdmUtZGVhZAotCSAgKHByb2duCi0JICAgICh1bmxlc3MgKGVxIHQgbGVhdmUt ZGVhZCkgKHNlcnZlci1sb2cgKG1lc3NhZ2UgIlNlcnZlciBzdG9wcGVkIikpKQotCSAgICAo c2V0cSBzZXJ2ZXItcHJvY2VzcyBuaWwpKQotCTs7IE1ha2Ugc3VyZSB0aGVyZSBpcyBhIHNh ZmUgZGlyZWN0b3J5IGluIHdoaWNoIHRvIHBsYWNlIHRoZSBzb2NrZXQuCi0JKHNlcnZlci1l bnN1cmUtc2FmZS1kaXIgc2VydmVyLWRpcikKLQkod2hlbiBzZXJ2ZXItcHJvY2VzcworICAg ICAgICA6d2FybmluZykKKyAgICAgICAoc2V0cSBsZWF2ZS1kZWFkIHQpKSkKKyAgICA7OyBO b3cgYW55IHByZXZpb3VzIHNlcnZlciBpcyBwcm9wZXJseSBzdG9wcGVkLgorICAgICh1bmxl c3MgbGVhdmUtZGVhZAorICAgICAgKGxldCAoKHNlcnZlci1maWxlIChzZXJ2ZXItLWZpbGUt bmFtZSkpKQorICAgICAgICA7OyBNYWtlIHN1cmUgdGhlcmUgaXMgYSBzYWZlIGRpcmVjdG9y eSBpbiB3aGljaCB0byBwbGFjZSB0aGUgc29ja2V0LgorICAgICAgICAoc2VydmVyLWVuc3Vy ZS1zYWZlLWRpciAoZmlsZS1uYW1lLWRpcmVjdG9yeSBzZXJ2ZXItZmlsZSkpCisgICAgICAg ICh3aGVuIHNlcnZlci1wcm9jZXNzCiAJICAoc2VydmVyLWxvZyAobWVzc2FnZSAiUmVzdGFy dGluZyBzZXJ2ZXIiKSkpCiAgICAgICAgICh3aXRoLWZpbGUtbW9kZXMgP1w3MDAKIAkgIChh ZGQtaG9vayAnc3VzcGVuZC10dHktZnVuY3Rpb25zICMnc2VydmVyLWhhbmRsZS1zdXNwZW5k LXR0eSkKQEAgLTc0Miw3ICs3NjcsNyBAQCBzZXJ2ZXItc3RhcnQKIChkZWZ1biBzZXJ2ZXIt Zm9yY2Utc3RvcCAoKQogICAiS2lsbCBhbGwgY29ubmVjdGlvbnMgdG8gdGhlIGN1cnJlbnQg c2VydmVyLgogVGhpcyBmdW5jdGlvbiBpcyBtZWFudCB0byBiZSBjYWxsZWQgZnJvbSBga2ls bC1lbWFjcy1ob29rJy4iCi0gIChzZXJ2ZXItc3RhcnQgdCB0KSkKKyAgKGlnbm9yZS1lcnJv cnMgKHNlcnZlci1zdG9wICdub2ZyYW1lKSkpCiAKIDs7OyMjI2F1dG9sb2FkCiAoZGVmdW4g c2VydmVyLWZvcmNlLWRlbGV0ZSAoJm9wdGlvbmFsIG5hbWUpCkBAIC0xODU4LDExICsxODgz LDEwIEBAIHNlcnZlci1ldmFsLWF0CiBjYW5ub3QgY29udGFjdCB0aGUgc3BlY2lmaWVkIHNl cnZlci4gIEZvciBleGFtcGxlOgogICAoc2VydmVyLWV2YWwtYXQgXCJzZXJ2ZXJcIiBcXD0n KGVtYWNzLXBpZCkpCiByZXR1cm5zIHRoZSBwcm9jZXNzIElEIG9mIHRoZSBFbWFjcyBpbnN0 YW5jZSBydW5uaW5nIFwic2VydmVyXCIuIgotICAobGV0KiAoKHNlcnZlci1kaXIgKGlmIHNl cnZlci11c2UtdGNwIHNlcnZlci1hdXRoLWRpciBzZXJ2ZXItc29ja2V0LWRpcikpCi0JIChz ZXJ2ZXItZmlsZSAoZXhwYW5kLWZpbGUtbmFtZSBzZXJ2ZXIgc2VydmVyLWRpcikpCi0JIChj b2Rpbmctc3lzdGVtLWZvci1yZWFkICdiaW5hcnkpCi0JIChjb2Rpbmctc3lzdGVtLWZvci13 cml0ZSAnYmluYXJ5KQotCSBhZGRyZXNzIHBvcnQgc2VjcmV0IHByb2Nlc3MpCisgIChsZXQg KChzZXJ2ZXItZmlsZSAoc2VydmVyLS1maWxlLW5hbWUpKQorICAgICAgICAoY29kaW5nLXN5 c3RlbS1mb3ItcmVhZCAnYmluYXJ5KQorICAgICAgICAoY29kaW5nLXN5c3RlbS1mb3Itd3Jp dGUgJ2JpbmFyeSkKKyAgICAgICAgYWRkcmVzcyBwb3J0IHNlY3JldCBwcm9jZXNzKQogICAg ICh1bmxlc3MgKGZpbGUtZXhpc3RzLXAgc2VydmVyLWZpbGUpCiAgICAgICAoZXJyb3IgIk5v IHN1Y2ggc2VydmVyOiAlcyIgc2VydmVyKSkKICAgICAod2l0aC10ZW1wLWJ1ZmZlcgotLSAK Mi4yNS4xCgo= --------------3GBLHKzCHc5luDdDPtaJENk9-- From unknown Sat Jun 14 04:55:23 2025 X-Loop: help-debbugs@gnu.org Subject: bug#58877: 29.0.50; [PATCH] When killing Emacs from a client frame with no other frames, Emacs shows a useless error prompt Resent-From: Jim Porter Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 22 Nov 2022 05:07:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58877 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Eli Zaretskii Cc: 58877@debbugs.gnu.org Received: via spool by 58877-submit@debbugs.gnu.org id=B58877.166909360415173 (code B ref 58877); Tue, 22 Nov 2022 05:07:02 +0000 Received: (at 58877) by debbugs.gnu.org; 22 Nov 2022 05:06:44 +0000 Received: from localhost ([127.0.0.1]:49401 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oxLUZ-0003wf-0h for submit@debbugs.gnu.org; Tue, 22 Nov 2022 00:06:44 -0500 Received: from mail-pj1-f44.google.com ([209.85.216.44]:33312) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oxLUU-0003wN-Pg for 58877@debbugs.gnu.org; Tue, 22 Nov 2022 00:06:41 -0500 Received: by mail-pj1-f44.google.com with SMTP id v3-20020a17090ac90300b00218441ac0f6so752420pjt.0 for <58877@debbugs.gnu.org>; Mon, 21 Nov 2022 21:06:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:references:cc:to:from:content-language:subject :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=61g/oIPWGGPoV6nfKmZbQc5O4E2lLn4E+S2lMAG1LN8=; b=CA3Bh7YxyIe85f1+R9GhQ+GJQcHvs70IcO0+h1OuJbviBNN4QkwI62padHVexXqarI L2Ef73mQRVmrxjPpdsKy9erLPwp9zqJLVoDz3l4LbVWSN1KnqPggVvJR68ECZAai4i+g 3a/G/+eYrakMOpTEVh0sOn71GVwxslOun7DD3jCrvHKY4c+YPBIlSbnP9wTIEJAP3ItY K4h24frgwRVZW6nWVfXGHmnTXh4ae+8CFZAGSd5ELiRG+Mk3EXS8WeMZQwmfsjx8+BFu GzgllgCpfIvCniG8TZSC9zAnJs1Rx15BPbEu3ZduGZywFf9iJIXRegiyuzFTidGwiNng iz5g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:references:cc:to:from:content-language:subject :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=61g/oIPWGGPoV6nfKmZbQc5O4E2lLn4E+S2lMAG1LN8=; b=XNHk2GBoEjZhPpdaEKNlhvHic1hm82vuhijm+BMFYlgSXML+wSNmENYvprcLpVOJXV 61F54IkEnFU+v5w7KAHgQEXnCILeh59SBGeI+aNytw7RWDqbyl7PpVDM1nq/IufdQPhS dELRnOKkJmUA8ug5pGbGFwRhBBugAxsNapocwTthQVrCOsK4+Ee6+agJW15WLx/Gt39c 9MyjJhQTIOEq0UXM8g7dw65Xtz493E6lmzTvYJMFH71ZRC9w6b3Nk7dnoN3WRfNI91oD HZ/aWGPffdvMOSH3+3NIgxmCQ50woPsaBJXAJABHTDkAnkBz06LVcVayPsYMEdvX7ysU w1Lg== X-Gm-Message-State: ANoB5plYIcC/8CCSko19tBMjSkSuC7l8iu007E8wdzt/UybzBTcfRZ6T hDunfmfW+4PJ/LxQHKqYyJk= X-Google-Smtp-Source: AA0mqf4rkQRpGJTjH/K3dP6vamzm9nDrDS6ztezMtAYVpRM1tvkCShFJ8Kbxs54ZA1NZu9qCtQMIfw== X-Received: by 2002:a17:902:8548:b0:186:8398:350 with SMTP id d8-20020a170902854800b0018683980350mr2462179plo.6.1669093592526; Mon, 21 Nov 2022 21:06:32 -0800 (PST) Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id qe13-20020a17090b4f8d00b001df264610c4sm1082454pjb.0.2022.11.21.21.06.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 21 Nov 2022 21:06:31 -0800 (PST) Content-Type: multipart/mixed; boundary="------------z7oWeiBpibEA4Yba0Cs0BPCi" Message-ID: Date: Mon, 21 Nov 2022 21:06:31 -0800 MIME-Version: 1.0 Content-Language: en-US From: Jim Porter References: <8121efd5-77c3-0682-ce0f-6be9375dadd8@gmail.com> <83a65dhm7f.fsf@gnu.org> <13835614-c593-ba2d-5373-a9950f6f3dab@gmail.com> In-Reply-To: <13835614-c593-ba2d-5373-a9950f6f3dab@gmail.com> X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) This is a multi-part message in MIME format. --------------z7oWeiBpibEA4Yba0Cs0BPCi Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 10/30/2022 2:14 PM, Jim Porter wrote: > Thanks for taking a look. I had hesitated to make any big changes to > this code since it doesn't have regression tests... Since server.el could probably use more tests anyway, I added a few ERT tests covering the most common use cases (see the first patch), and then added another test for the second patch. The test in the second patch is pretty indirect, but that's because it's testing something that normally happens when killing Emacs; it'd be hard to kill the current Emacs instance and still be able to check test results! --------------z7oWeiBpibEA4Yba0Cs0BPCi Content-Type: text/plain; charset=UTF-8; name="0001-Add-more-tests-for-the-Emacs-server.patch" Content-Disposition: attachment; filename="0001-Add-more-tests-for-the-Emacs-server.patch" Content-Transfer-Encoding: base64 RnJvbSAzMzk2NjFlNGYyODc2YWRlZjhmMjFkODljNGUzYzA5ZTVlOGRmMDUzIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKaW0gUG9ydGVyIDxqcG9ydGVyYnVnc0BnbWFpbC5j b20+CkRhdGU6IFNhdCwgMTkgTm92IDIwMjIgMjI6MjY6NDUgLTA4MDAKU3ViamVjdDogW1BB VENIIDEvMl0gOyBBZGQgbW9yZSB0ZXN0cyBmb3IgdGhlIEVtYWNzIHNlcnZlcgoKKiB0ZXN0 L2xpc3Avc2VydmVyLXRlc3RzLmVsIChzZXJ2ZXItdGVzdHMvZW1hY3MtY2xpZW50KQooc2Vy dmVyLXRlc3RzL21heC13YWl0LXRpbWUpOiBOZXcgY29uc3RhbnRzLgooc2VydmVyLXRlc3Rz L3N0YXJ0LWVtYWNzY2xpZW50KTogTmV3IGZ1bmN0aW9uLgooc2VydmVyLXRlc3RzL3dpdGgt c2VydmVyLCBzZXJ2ZXItdGVzdHMvd2FpdC11bnRpbCk6IE5ldyBtYWNyb3MuCihzZXJ2ZXIt dGVzdHMvdmFyaWFibGUpOiBOZXcgdmFyaWFibGUuCihzZXJ2ZXItdGVzdC9zZXJ2ZXItc3Rh cnQtc2V0cy1taW5vci1tb2RlKTogUmVuYW1lIHRvLi4uCihzZXJ2ZXItdGVzdHMvc2VydmVy LXN0YXJ0L3NldHMtbWlub3ItbW9kZSk6IC4uLiB0aGlzLgooc2VydmVyLXRlc3RzL3NlcnZl ci1zdGFydC9zdG9wLXByb21wdC13aXRoLWNsaWVudCkKKHNlcnZlci10ZXN0cy9zZXJ2ZXIt c3RhcnQvbm8tc3RvcC1wcm9tcHQtd2l0aG91dC1jbGllbnQpCihzZXJ2ZXItdGVzdHMvZW1h Y3NjbGllbnQvc2VydmVyLWVkaXQpCihzZXJ2ZXItdGVzdHMvZW1hY3NjbGllbnQvY3JlYXRl LWZyYW1lLCBzZXJ2ZXItdGVzdC9lbWFjc2NsaWVudC9ldmFsKToKTmV3IHRlc3RzLgoKKiB0 ZXN0L2xpYi1zcmMvZW1hY3NjbGllbnQtdGVzdHMuZWw6IE1lbnRpb24gdGhlIGFib3ZlIGZp bGUuCi0tLQogdGVzdC9saWItc3JjL2VtYWNzY2xpZW50LXRlc3RzLmVsIHwgICA0ICstCiB0 ZXN0L2xpc3Avc2VydmVyLXRlc3RzLmVsICAgICAgICAgfCAxMTEgKysrKysrKysrKysrKysr KysrKysrKysrKysrLS0tCiAyIGZpbGVzIGNoYW5nZWQsIDEwNSBpbnNlcnRpb25zKCspLCAx MCBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS90ZXN0L2xpYi1zcmMvZW1hY3NjbGllbnQt dGVzdHMuZWwgYi90ZXN0L2xpYi1zcmMvZW1hY3NjbGllbnQtdGVzdHMuZWwKaW5kZXggMTMw MmZiZTMwYy4uMGZhM2M2ZmFjZiAxMDA2NDQKLS0tIGEvdGVzdC9saWItc3JjL2VtYWNzY2xp ZW50LXRlc3RzLmVsCisrKyBiL3Rlc3QvbGliLXNyYy9lbWFjc2NsaWVudC10ZXN0cy5lbApA QCAtMTksNyArMTksOSBAQAogCiA7OzsgQ29tbWVudGFyeToKIAotOzsKKzs7IFRlc3RzIGZv ciB0aGUgZW1hY3NjbGllbnQgZXhlY3V0YWJsZS4gIEZvciB0ZXN0cyBpbnZvbHZpbmcgdGhl Cis7OyBpbnRlcmFjdGlvbiBiZXR3ZWVuIGVtYWNzY2xpZW50IGFuZCBhbiBFbWFjcyBzZXJ2 ZXIsIHNlZQorOzsgdGVzdC9saXNwL3NlcnZlci10ZXN0cy5lbC4KIAogOzs7IENvZGU6CiAK ZGlmZiAtLWdpdCBhL3Rlc3QvbGlzcC9zZXJ2ZXItdGVzdHMuZWwgYi90ZXN0L2xpc3Avc2Vy dmVyLXRlc3RzLmVsCmluZGV4IDM1MWI4ZWY4ZDEuLjQ4ZWYxMTA5NDMgMTAwNjQ0Ci0tLSBh L3Rlc3QvbGlzcC9zZXJ2ZXItdGVzdHMuZWwKKysrIGIvdGVzdC9saXNwL3NlcnZlci10ZXN0 cy5lbApAQCAtMjIsMjAgKzIyLDExMyBAQAogKHJlcXVpcmUgJ2VydCkKIChyZXF1aXJlICdz ZXJ2ZXIpCiAKKyhkZWZjb25zdCBzZXJ2ZXItdGVzdHMvZW1hY3NjbGllbnQKKyAgKGlmIGlu c3RhbGxhdGlvbi1kaXJlY3RvcnkKKyAgICAgIChleHBhbmQtZmlsZS1uYW1lICJsaWItc3Jj L2VtYWNzY2xpZW50IiBpbnN0YWxsYXRpb24tZGlyZWN0b3J5KQorICAgICJlbWFjc2NsaWVu dCIpCisgICJUaGUgZW1hY3NjbGllbnQgYmluYXJ5IHRvIHRlc3QuIikKKworKGRlZnVuIHNl cnZlci10ZXN0cy9zdGFydC1lbWFjc2NsaWVudCAoJnJlc3QgYXJncykKKyAgIlJ1biBlbWFj c2NsaWVudCwgcGFzc2luZyBBUkdTIGFzIGFyZ3VtZW50cyB0byBpdC4iCisgIChsZXQgKChz b2NrZXQtbmFtZSAocHJvY2Vzcy1nZXQgc2VydmVyLXByb2Nlc3MgOnNlcnZlci1maWxlKSkp CisgICAgKG1ha2UtcHJvY2VzcworICAgICA6bmFtZSBzZXJ2ZXItdGVzdHMvZW1hY3NjbGll bnQKKyAgICAgOmNvbW1hbmQgKGFwcGVuZCAobGlzdCBzZXJ2ZXItdGVzdHMvZW1hY3NjbGll bnQKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAiLS1zb2NrZXQtbmFtZSIgc29ja2V0 LW5hbWUpCisgICAgICAgICAgICAgICAgICAgICAgYXJncykpKSkKKworKGRlZm1hY3JvIHNl cnZlci10ZXN0cy93aXRoLXNlcnZlciAoJnJlc3QgYm9keSkKKyAgIlN0YXJ0IHRoZSBFbWFj cyBzZXJ2ZXIsIGV2YWx1YXRlIEJPRFksIGFuZCB0aGVuIHN0b3AgdGhlIHNlcnZlci4iCisg IChkZWNsYXJlIChpbmRlbnQgMCkpCisgIGAocHJvZ24KKyAgICAgKHNlcnZlci1zdGFydCkK KyAgICAgKHVud2luZC1wcm90ZWN0CisgICAgICAgICAocHJvZ24gKHNob3VsZCAocHJvY2Vz c3Agc2VydmVyLXByb2Nlc3MpKQorICAgICAgICAgICAgICAgICxAYm9keSkKKyAgICAgICAo bGV0ICgoaW5oaWJpdC1tZXNzYWdlIHQpKQorICAgICAgICAgKHNlcnZlci1zdGFydCB0IHQp KQorICAgICAgIChzaG91bGQgKG51bGwgc2VydmVyLXByb2Nlc3MpKQorICAgICAgIChzaG91 bGQgKG51bGwgc2VydmVyLWNsaWVudHMpKSkpKQorCisoZGVmY29uc3Qgc2VydmVyLXRlc3Rz L21heC13YWl0LXRpbWUgNQorICAiVGhlIG1heGltdW0gdGltZSB0byB3YWl0IGluIGBzZXJ2 ZXItdGVzdHMvd2FpdC11bnRpbCcsIGluIHNlY29uZHMuIikKKworKGRlZm1hY3JvIHNlcnZl ci10ZXN0cy93YWl0LXVudGlsIChmb3JtKQorICAiV2FpdCB1bnRpbCBGT1JNIGlzIG5vbi1u aWwsIHRpbWluZyBvdXQgYW5kIGZhaWxpbmcgaWYgaXQgdGFrZXMgdG9vIGxvbmcuIgorICBg KGxldCAoKHN0YXJ0IChjdXJyZW50LXRpbWUpKSkKKyAgICAod2hpbGUgKG5vdCAsZm9ybSkK KyAgICAgICh3aGVuICg+IChmbG9hdC10aW1lICh0aW1lLXNpbmNlIHN0YXJ0KSkKKyAgICAg ICAgICAgICAgIHNlcnZlci10ZXN0cy9tYXgtd2FpdC10aW1lKQorICAgICAgICAoZXJ0LWZh aWwgKGZvcm1hdCAidGltZWQgb3V0IHdhaXRpbmcgZm9yICVTIHRvIGJlIG5vbi1uaWwiICcs Zm9ybSkpKQorICAgICAgKHNpdC1mb3IgMC4xKSkpKQorCisoZGVmdmFyIHNlcnZlci10ZXN0 cy92YXJpYWJsZSBuaWwpCisKIDs7OyBUZXN0czoKIAotKGVydC1kZWZ0ZXN0IHNlcnZlci10 ZXN0L3NlcnZlci1zdGFydC1zZXRzLW1pbm9yLW1vZGUgKCkKKyhlcnQtZGVmdGVzdCBzZXJ2 ZXItdGVzdHMvc2VydmVyLXN0YXJ0L3NldHMtbWlub3ItbW9kZSAoKQogICAiRW5zdXJlIHRo YXQgY2FsbGluZyBgc2VydmVyLXN0YXJ0JyBhbHNvIHNldHMgYHNlcnZlci1tb2RlJyBwcm9w ZXJseS4iCi0gIChzZXJ2ZXItc3RhcnQpCi0gICh1bndpbmQtcHJvdGVjdAotICAgICAgKHBy b2duCi0gICAgICAgIDs7IE1ha2Ugc3VyZSBzdGFydGluZyB0aGUgc2VydmVyIGFjdGl2YXRl cyB0aGUgbWlub3IgbW9kZS4KLSAgICAgICAgKHNob3VsZCAoZXEgc2VydmVyLW1vZGUgdCkp Ci0gICAgICAgIChzaG91bGQgKG1lbXEgJ3NlcnZlci1tb2RlIGdsb2JhbC1taW5vci1tb2Rl cykpKQotICAgIDs7IEFsd2F5cyBzdG9wIHRoZSBzZXJ2ZXIsIGV2ZW4gaWYgdGhlIGFib3Zl IGNoZWNrcyBmYWlsLgotICAgIChzZXJ2ZXItc3RhcnQgdCkpCisgIChzZXJ2ZXItdGVzdHMv d2l0aC1zZXJ2ZXIKKyAgICA7OyBNYWtlIHN1cmUgc3RhcnRpbmcgdGhlIHNlcnZlciBhY3Rp dmF0ZXMgdGhlIG1pbm9yIG1vZGUuCisgICAgKHNob3VsZCAoZXEgc2VydmVyLW1vZGUgdCkp CisgICAgKHNob3VsZCAobWVtcSAnc2VydmVyLW1vZGUgZ2xvYmFsLW1pbm9yLW1vZGVzKSkp CiAgIDs7IE1ha2Ugc3VyZSBzdG9wcGluZyB0aGUgc2VydmVyIGRlYWN0aXZhdGVzIHRoZSBt aW5vciBtb2RlLgogICAoc2hvdWxkIChlcSBzZXJ2ZXItbW9kZSBuaWwpKQogICAoc2hvdWxk LW5vdCAobWVtcSAnc2VydmVyLW1vZGUgZ2xvYmFsLW1pbm9yLW1vZGVzKSkpCiAKKyhlcnQt ZGVmdGVzdCBzZXJ2ZXItdGVzdHMvc2VydmVyLXN0YXJ0L3N0b3AtcHJvbXB0LXdpdGgtY2xp ZW50ICgpCisgICJFbnN1cmUgdGhhdCBzdG9wcGluZyB0aGUgc2VydmVyIHByb21wdHMgd2hl biB0aGVyZSBhcmUgY2xpZW50cy4iCisgIChzZXJ2ZXItdGVzdHMvd2l0aC1zZXJ2ZXIKKyAg ICAobGV0ICgoeWVzLW9yLW5vLXAtY2FsbGVkIG5pbCkKKyAgICAgICAgICAoZW1hY3NjbGll bnQgKHNlcnZlci10ZXN0cy9zdGFydC1lbWFjc2NsaWVudCAiLWMiKSkpCisgICAgICAoc2Vy dmVyLXRlc3RzL3dhaXQtdW50aWwgKGxlbmd0aD0gKGZyYW1lLWxpc3QpIDIpKQorICAgICAg KGNsLWxldGYgKCgoc3ltYm9sLWZ1bmN0aW9uICd5ZXMtb3Itbm8tcCkKKyAgICAgICAgICAg ICAgICAgKGxhbWJkYSAoX3Byb21wdCkKKyAgICAgICAgICAgICAgICAgICAoc2V0cSB5ZXMt b3Itbm8tcC1jYWxsZWQgdCkpKSkKKyAgICAgICAgKHNlcnZlci1zdGFydCB0KQorICAgICAg ICAoc2hvdWxkIHllcy1vci1uby1wLWNhbGxlZCkpCisgICAgICAoc2VydmVyLXRlc3RzL3dh aXQtdW50aWwgKGVxIChwcm9jZXNzLXN0YXR1cyBlbWFjc2NsaWVudCkgJ2V4aXQpKSkpKQor CisoZXJ0LWRlZnRlc3Qgc2VydmVyLXRlc3RzL3NlcnZlci1zdGFydC9uby1zdG9wLXByb21w dC13aXRob3V0LWNsaWVudCAoKQorICAiRW5zdXJlIHRoYXQgc3RvcHBpbmcgdGhlIHNlcnZl ciBkb2Vzbid0IHByb21wdCB3aGVuIHRoZXJlIGFyZSBubyBjbGllbnRzLiIKKyAgKHNlcnZl ci10ZXN0cy93aXRoLXNlcnZlcgorICAgIChsZXQgKCh5ZXMtb3Itbm8tcC1jYWxsZWQgbmls KSkKKyAgICAgIChjbC1sZXRmICgoKHN5bWJvbC1mdW5jdGlvbiAneWVzLW9yLW5vLXApCisg ICAgICAgICAgICAgICAgIChsYW1iZGEgKF9wcm9tcHQpCisgICAgICAgICAgICAgICAgICAg KHNldHEgeWVzLW9yLW5vLXAtY2FsbGVkIHQpKSkpCisgICAgICAgIChsZXQgKChpbmhpYml0 LW1lc3NhZ2UgdCkpCisgICAgICAgICAgKHNlcnZlci1zdGFydCB0KSkKKyAgICAgICAgKHNo b3VsZC1ub3QgeWVzLW9yLW5vLXAtY2FsbGVkKSkpKSkKKworKGVydC1kZWZ0ZXN0IHNlcnZl ci10ZXN0cy9lbWFjc2NsaWVudC9zZXJ2ZXItZWRpdCAoKQorICAiVGVzdCB0aGF0IGNhbGxp bmcgYHNlcnZlci1lZGl0JyBmcm9tIGEgY2xpZW50IGJ1ZmZlciBleGl0cyB0aGUgY2xpZW50 LiIKKyAgKHNlcnZlci10ZXN0cy93aXRoLXNlcnZlcgorICAgIChsZXQgKChlbWFjc2NsaWVu dCAoc2VydmVyLXRlc3RzL3N0YXJ0LWVtYWNzY2xpZW50ICJmaWxlLnR4dCIpKSkKKyAgICAg IChzZXJ2ZXItdGVzdHMvd2FpdC11bnRpbCAoZ2V0LWJ1ZmZlciAiZmlsZS50eHQiKSkKKyAg ICAgIChzaG91bGQgKGVxIChwcm9jZXNzLXN0YXR1cyBlbWFjc2NsaWVudCkgJ3J1bikpCisg ICAgICAoc2hvdWxkIChsZW5ndGg9IHNlcnZlci1jbGllbnRzIDEpKQorICAgICAgKHdpdGgt Y3VycmVudC1idWZmZXIgImZpbGUudHh0IgorICAgICAgICAoc2VydmVyLWVkaXQpKQorICAg ICAgKHNlcnZlci10ZXN0cy93YWl0LXVudGlsIChlcSAocHJvY2Vzcy1zdGF0dXMgZW1hY3Nj bGllbnQpICdleGl0KSkpKSkKKworKGVydC1kZWZ0ZXN0IHNlcnZlci10ZXN0cy9lbWFjc2Ns aWVudC9jcmVhdGUtZnJhbWUgKCkKKyAgIlRlc3QgdGhhdCBcImVtYWNzY2xpZW50IC1jXCIg Y3JlYXRlcyBhIGZyYW1lLiIKKyAgKHNlcnZlci10ZXN0cy93aXRoLXNlcnZlcgorICAgIChs ZXQgKChlbWFjc2NsaWVudCAoc2VydmVyLXRlc3RzL3N0YXJ0LWVtYWNzY2xpZW50ICItYyIp KSkKKyAgICAgIChzZXJ2ZXItdGVzdHMvd2FpdC11bnRpbCAobGVuZ3RoPSAoZnJhbWUtbGlz dCkgMikpCisgICAgICAoc2hvdWxkIChlcSAocHJvY2Vzcy1zdGF0dXMgZW1hY3NjbGllbnQp ICdydW4pKQorICAgICAgKHNob3VsZCAobGVuZ3RoPSBzZXJ2ZXItY2xpZW50cyAxKSkKKyAg ICAgIChzaG91bGQgKGVxIChmcmFtZS1wYXJhbWV0ZXIgKGNhciAoZnJhbWUtbGlzdCkpICdj bGllbnQpCisgICAgICAgICAgICAgICAgICAoY2FyIHNlcnZlci1jbGllbnRzKSkpKSkKKyAg OzsgVGhlIGNsaWVudCBmcmFtZSBzaG91bGQgZ28gYXdheSBhZnRlciB0aGUgc2VydmVyIHN0 b3BzLgorICAoc2hvdWxkIChsZW5ndGg9IChmcmFtZS1saXN0KSAxKSkpCisKKyhlcnQtZGVm dGVzdCBzZXJ2ZXItdGVzdHMvZW1hY3NjbGllbnQvZXZhbCAoKQorICAiVGVzdCB0aGF0IFwi ZW1hY3NjbGllbnQgLS1ldmFsXCIgd29ya3MgY29ycmVjdGx5LiIKKyAgKHNlcnZlci10ZXN0 cy93aXRoLXNlcnZlcgorICAgIChsZXQgKCh2YWx1ZSAocmFuZG9tKSkpCisgICAgICAoc2Vy dmVyLXRlc3RzL3N0YXJ0LWVtYWNzY2xpZW50CisgICAgICAgIi0tZXZhbCIgKGZvcm1hdCAi KHNldHEgc2VydmVyLXRlc3RzL3ZhcmlhYmxlICVkKSIgdmFsdWUpKQorICAgICAgKHNlcnZl ci10ZXN0cy93YWl0LXVudGlsIChlcSBzZXJ2ZXItdGVzdHMvdmFyaWFibGUgdmFsdWUpKSkp KQorCiA7Ozsgc2VydmVyLXRlc3RzLmVsIGVuZHMgaGVyZQotLSAKMi4yNS4xCgo= --------------z7oWeiBpibEA4Yba0Cs0BPCi Content-Type: text/plain; charset=UTF-8; name="0002-Don-t-explicitly-delete-client-frames-when-killing-E.patch" Content-Disposition: attachment; filename*0="0002-Don-t-explicitly-delete-client-frames-when-killing-E.pa"; filename*1="tch" Content-Transfer-Encoding: base64 RnJvbSBlYzhiYWYxNTk1YTI3ZWYwYWE5YTkwZGVhMjMwYWY0NDQxOWU5ODdlIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKaW0gUG9ydGVyIDxqcG9ydGVyYnVnc0BnbWFpbC5j b20+CkRhdGU6IE1vbiwgMjEgTm92IDIwMjIgMTE6NDc6MDggLTA4MDAKU3ViamVjdDogW1BB VENIIDIvMl0gRG9uJ3QgZXhwbGljaXRseSBkZWxldGUgY2xpZW50IGZyYW1lcyB3aGVuIGtp bGxpbmcgRW1hY3MKIGFueXdheQoKVGhpcyBlbGltaW5hdGVzIGEgdXNlbGVzcyBlcnJvciBw cm9tcHQgd2hlbiBraWxsaW5nIEVtYWNzIGZyb20gYQpjbGllbnQgZnJhbWUgd2hlbiB0aGVy ZSBhcmUgbm8gb3RoZXIgZnJhbWVzIChidWcjNTg4NzcpLgoKKiBsaXNwL3NlcnZlci5lbCAo c2VydmVyLXJ1bm5pbmctZXh0ZXJuYWwpOiBOZXcgZXJyb3IuCihzZXJ2ZXItLWZpbGUtbmFt ZSk6IE5ldyBmdW5jdGlvbi4uLgooc2VydmVyLWV2YWwtYXQpOiAuLi4gdXNlIGl0Lgooc2Vy dmVyLXN0YXJ0KTogRmFjdG9yIG91dCBzZXJ2ZXIgc3RvcHBpbmcgY29kZSBpbnRvLi4uCihz ZXJ2ZXItc3RvcCk6IC4uLiBoZXJlLgooc2VydmVyLWZvcmNlLXN0b3ApOiBVc2UgJ3NlcnZl ci1zdG9wJywgYW5kIHRlbGwgaXQgbm90IHRvIGRlbGV0ZQpmcmFtZXMuCgoqIHRlc3QvbGlz cC9zZXJ2ZXItdGVzdHMuZWwKKHNlcnZlci10ZXN0cy9zZXJ2ZXItZm9yY2Utc3RvcC9rZWVw cy1mcmFtZXMpOiBOZXcgdGVzdC4KLS0tCiBsaXNwL3NlcnZlci5lbCAgICAgICAgICAgIHwg MTMwICsrKysrKysrKysrKysrKysrKysrKystLS0tLS0tLS0tLS0tLS0tCiB0ZXN0L2xpc3Av c2VydmVyLXRlc3RzLmVsIHwgIDM1ICsrKysrKysrKysKIDIgZmlsZXMgY2hhbmdlZCwgMTEy IGluc2VydGlvbnMoKyksIDUzIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL2xpc3Avc2Vy dmVyLmVsIGIvbGlzcC9zZXJ2ZXIuZWwKaW5kZXggNTUzODkwY2UyOS4uNmRiMzNmYWRiMSAx MDA2NDQKLS0tIGEvbGlzcC9zZXJ2ZXIuZWwKKysrIGIvbGlzcC9zZXJ2ZXIuZWwKQEAgLTI4 Nyw2ICsyODcsOCBAQCBzZXJ2ZXItc29ja2V0LWRpcgogICAiVGhlIGRpcmVjdG9yeSBpbiB3 aGljaCB0byBwbGFjZSB0aGUgc2VydmVyIHNvY2tldC4KIElmIGxvY2FsIHNvY2tldHMgYXJl IG5vdCBzdXBwb3J0ZWQsIHRoaXMgaXMgbmlsLiIpCiAKKyhkZWZpbmUtZXJyb3IgJ3NlcnZl ci1ydW5uaW5nLWV4dGVybmFsICJFeHRlcm5hbCBzZXJ2ZXIgcnVubmluZyIpCisKIChkZWZ1 biBzZXJ2ZXItY2xpZW50cy13aXRoIChwcm9wZXJ0eSB2YWx1ZSkKICAgIlJldHVybiBhIGxp c3Qgb2YgY2xpZW50cyB3aXRoIFBST1BFUlRZIHNldCB0byBWQUxVRS4iCiAgIChsZXQgKHJl c3VsdCkKQEAgLTYxMCw2ICs2MTIsNTQgQEAgc2VydmVyLWdldC1hdXRoLWtleQogICAgICAg KGVycm9yICJUaGUga2V5IGAlcycgaXMgaW52YWxpZCIgc2VydmVyLWF1dGgta2V5KSkKICAg ICAoc2VydmVyLWdlbmVyYXRlLWtleSkpKQogCisoZGVmc3Vic3Qgc2VydmVyLS1maWxlLW5h bWUgKCkKKyAgIlJldHVybiB0aGUgZmlsZSBuYW1lIHRvIHVzZSBmb3IgdGhlIHNlcnZlciBz b2NrZXQuIgorICAobGV0ICgoc2VydmVyLWRpciAoaWYgc2VydmVyLXVzZS10Y3Agc2VydmVy LWF1dGgtZGlyIHNlcnZlci1zb2NrZXQtZGlyKSkpCisgICAgKGV4cGFuZC1maWxlLW5hbWUg c2VydmVyLW5hbWUgc2VydmVyLWRpcikpKQorCisoZGVmdW4gc2VydmVyLXN0b3AgKCZvcHRp b25hbCBub2ZyYW1lKQorICAiSWYgdGhpcyBFbWFjcyBwcm9jZXNzIGhhcyBhIHNlcnZlciBj b21tdW5pY2F0aW9uIHN1YnByb2Nlc3MsIHN0b3AgaXQuCitJZiB0aGUgc2VydmVyIGlzIHJ1 bm5pbmcgaW4gc29tZSBvdGhlciBFbWFjIHByb2Nlc3MgKHNlZQorYHNlcnZlci1ydW5uaW5n LXAnKSwgc2lnbmFsIGEgYHNlcnZlci1ydW5uaW5nLWV4dGVybmFsJyBlcnJvci4KKworSWYg Tk9GUkFNRSBpcyBub24tbmlsLCBkb24ndCBkZWxldGUgYW55IGV4aXN0aW5nIGZyYW1lcwor YXNzb2NpYXRlZCB3aXRoIGEgY2xpZW50IHByb2Nlc3MuICBUaGlzIGlzIHVzZWZ1bCwgZm9y IGV4YW1wbGUsCit3aGVuIGtpbGxpbmcgRW1hY3MsIGluIHdoaWNoIGNhc2UgdGhlIGZyYW1l cyB3aWxsIGdldCBkZWxldGVkCithbnl3YXkuIgorICAobGV0ICgoc2VydmVyLWZpbGUgKHNl cnZlci0tZmlsZS1uYW1lKSkpCisgICAgKHdoZW4gc2VydmVyLXByb2Nlc3MKKyAgICAgIDs7 IEtpbGwgaXQgZGVhZCEKKyAgICAgIChpZ25vcmUtZXJyb3JzIChkZWxldGUtcHJvY2VzcyBz ZXJ2ZXItcHJvY2VzcykpCisgICAgICAodW5sZXNzIG5vZnJhbWUKKyAgICAgICAgKHNlcnZl ci1sb2cgKG1lc3NhZ2UgIlNlcnZlciBzdG9wcGVkIikpKQorICAgICAgKHNldHEgc2VydmVy LXByb2Nlc3MgbmlsCisgICAgICAgICAgICBzZXJ2ZXItbW9kZSBuaWwKKyAgICAgICAgICAg IGdsb2JhbC1taW5vci1tb2RlcyAoZGVscSAnc2VydmVyLW1vZGUgZ2xvYmFsLW1pbm9yLW1v ZGVzKSkpCisgICAgKHVud2luZC1wcm90ZWN0CisgICAgICAgIDs7IERlbGV0ZSB0aGUgc29j a2V0IGZpbGVzIG1hZGUgYnkgcHJldmlvdXMgc2VydmVyCisgICAgICAgIDs7IGludm9jYXRp b25zLgorICAgICAgICAoaWYgKG5vdCAoZXEgdCAoc2VydmVyLXJ1bm5pbmctcCBzZXJ2ZXIt bmFtZSkpKQorICAgICAgICAgICAgOzsgUmVtb3ZlIGFueSBsZWZ0b3ZlciBzb2NrZXQgb3Ig YXV0aGVudGljYXRpb24gZmlsZS4KKyAgICAgICAgICAgIChpZ25vcmUtZXJyb3JzCisgICAg ICAgICAgICAgIChsZXQgKGRlbGV0ZS1ieS1tb3ZpbmctdG8tdHJhc2gpCisgICAgICAgICAg ICAgICAgKGRlbGV0ZS1maWxlIHNlcnZlci1maWxlKQorICAgICAgICAgICAgICAgIDs7IEFs c28gZGVsZXRlIHRoZSBkaXJlY3RvcnkgdGhhdCB0aGUgc2VydmVyIGZpbGUgd2FzCisgICAg ICAgICAgICAgICAgOzsgY3JlYXRlZCBpbiAtLSBidXQgb25seSBpbiAvdG1wIChzZWUgYnVn IzQ0NjQ0KS4KKyAgICAgICAgICAgICAgICA7OyBUaGVyZSBtYXkgYmUgb3RoZXIgc2VydmVy cyBydW5uaW5nLCB0b28sIHNvIHRoaXMgbWF5CisgICAgICAgICAgICAgICAgOzsgZmFpbC4K KyAgICAgICAgICAgICAgICAod2hlbiAoZXF1YWwgKGZpbGUtbmFtZS1kaXJlY3RvcnkKKyAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgIChkaXJlY3RvcnktZmlsZS1uYW1lCisgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgKGZpbGUtbmFtZS1kaXJlY3Rvcnkgc2VydmVy LWZpbGUpKSkKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIi90bXAvIikKKyAgICAg ICAgICAgICAgICAgIChpZ25vcmUtZXJyb3JzCisgICAgICAgICAgICAgICAgICAgIChkZWxl dGUtZGlyZWN0b3J5IChmaWxlLW5hbWUtZGlyZWN0b3J5IHNlcnZlci1maWxlKSkpKSkpCisg ICAgICAgICAgICAoc2lnbmFsICdzZXJ2ZXItcnVubmluZy1leHRlcm5hbAorICAgICAgICAg ICAgICAgICAgICAobGlzdCAoZm9ybWF0ICJUaGVyZSBpcyBhbiBleGlzdGluZyBFbWFjcyBz ZXJ2ZXIsIG5hbWVkICVTIgorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHNl cnZlci1uYW1lKSkpKQorICAgICAgOzsgSWYgdGhpcyBFbWFjcyBhbHJlYWR5IGhhZCBhIHNl cnZlciwgY2xlYXIgb3V0IGFzc29jaWF0ZWQgc3RhdHVzLgorICAgICAgKHdoaWxlIHNlcnZl ci1jbGllbnRzCisgICAgICAgIChzZXJ2ZXItZGVsZXRlLWNsaWVudCAoY2FyIHNlcnZlci1j bGllbnRzKSBub2ZyYW1lKSkpKSkKKwogOzs7IyMjYXV0b2xvYWQKIChkZWZ1biBzZXJ2ZXIt c3RhcnQgKCZvcHRpb25hbCBsZWF2ZS1kZWFkIGluaGliaXQtcHJvbXB0KQogICAiQWxsb3cg dGhpcyBFbWFjcyBwcm9jZXNzIHRvIGJlIGEgc2VydmVyIGZvciBjbGllbnQgcHJvY2Vzc2Vz LgpAQCAtNjQzLDU1ICs2OTMsMzAgQEAgc2VydmVyLXN0YXJ0CiAJICAgICAoaW5oaWJpdC1w cm9tcHQgdCkKIAkgICAgICh0ICh5ZXMtb3Itbm8tcAogCQkgIlRoZSBjdXJyZW50IHNlcnZl ciBzdGlsbCBoYXMgY2xpZW50czsgZGVsZXRlIHRoZW0/ICIpKSkpCi0gICAgKGxldCogKChz ZXJ2ZXItZGlyIChpZiBzZXJ2ZXItdXNlLXRjcCBzZXJ2ZXItYXV0aC1kaXIgc2VydmVyLXNv Y2tldC1kaXIpKQotCSAgIChzZXJ2ZXItZmlsZSAoZXhwYW5kLWZpbGUtbmFtZSBzZXJ2ZXIt bmFtZSBzZXJ2ZXItZGlyKSkpCi0gICAgICAod2hlbiBzZXJ2ZXItcHJvY2VzcwotCTs7IGtp bGwgaXQgZGVhZCEKLQkoaWdub3JlLWVycm9ycyAoZGVsZXRlLXByb2Nlc3Mgc2VydmVyLXBy b2Nlc3MpKSkKLSAgICAgIDs7IENoZWNrIHRvIHNlZSBpZiBhbiB1bmluaXRpYWxpemVkIGV4 dGVybmFsIHNvY2tldCBoYXMgYmVlbgotICAgICAgOzsgcGFzc2VkIGluLCBpZiB0aGF0IGlz IHRoZSBjYXNlLCBza2lwIGNoZWNraW5nCi0gICAgICA7OyBgc2VydmVyLXJ1bm5pbmctcCcg YXMgdGhpcyB3aWxsIHJldHVybiB0aGUgd3JvbmcgcmVzdWx0LgotICAgICAgKGlmIChhbmQg aW50ZXJuYWwtLWRhZW1vbi1zb2NrbmFtZQotICAgICAgICAgICAgICAgKG5vdCBzZXJ2ZXIt LWV4dGVybmFsLXNvY2tldC1pbml0aWFsaXplZCkpCi0gICAgICAgICAgKHNldHEgc2VydmVy LS1leHRlcm5hbC1zb2NrZXQtaW5pdGlhbGl6ZWQgdCkKLSAgICAgICAgOzsgRGVsZXRlIHRo ZSBzb2NrZXQgZmlsZXMgbWFkZSBieSBwcmV2aW91cyBzZXJ2ZXIgaW52b2NhdGlvbnMuCi0g ICAgICAgIChpZiAobm90IChlcSB0IChzZXJ2ZXItcnVubmluZy1wIHNlcnZlci1uYW1lKSkp Ci0gICAgICAgICAgIDs7IFJlbW92ZSBhbnkgbGVmdG92ZXIgc29ja2V0IG9yIGF1dGhlbnRp Y2F0aW9uIGZpbGUuCi0gICAgICAgICAgIChpZ25vcmUtZXJyb3JzCi0gICAgICAgICAgICAg KGxldCAoZGVsZXRlLWJ5LW1vdmluZy10by10cmFzaCkKLSAgICAgICAgICAgICAgIChkZWxl dGUtZmlsZSBzZXJ2ZXItZmlsZSkKLSAgICAgICAgICAgICAgIDs7IEFsc28gZGVsZXRlIHRo ZSBkaXJlY3RvcnkgdGhhdCB0aGUgc2VydmVyIGZpbGUgd2FzCi0gICAgICAgICAgICAgICA7 OyBjcmVhdGVkIGluIC0tIGJ1dCBvbmx5IGluIC90bXAgKHNlZSBidWcjNDQ2NDQpLgotICAg ICAgICAgICAgICAgOzsgVGhlcmUgbWF5IGJlIG90aGVyIHNlcnZlcnMgcnVubmluZywgdG9v LCBzbyB0aGlzIG1heQotICAgICAgICAgICAgICAgOzsgZmFpbC4KLSAgICAgICAgICAgICAg ICh3aGVuIChlcXVhbCAoZmlsZS1uYW1lLWRpcmVjdG9yeQotICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAoZGlyZWN0b3J5LWZpbGUtbmFtZQotICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgKGZpbGUtbmFtZS1kaXJlY3Rvcnkgc2VydmVyLWZpbGUpKSkKLSAgICAgICAg ICAgICAgICAgICAgICAgICAgICAiL3RtcC8iKQotICAgICAgICAgICAgICAgICAoaWdub3Jl LWVycm9ycwotICAgICAgICAgICAgICAgICAgIChkZWxldGUtZGlyZWN0b3J5IChmaWxlLW5h bWUtZGlyZWN0b3J5IHNlcnZlci1maWxlKSkpKSkpCi0gICAgICAgICAoZGlzcGxheS13YXJu aW5nCi0gICAgICAgICAgJ3NlcnZlcgotICAgICAgICAgIChjb25jYXQgIlVuYWJsZSB0byBz dGFydCB0aGUgRW1hY3Mgc2VydmVyLlxuIgotICAgICAgICAgICAgICAgICAgKGZvcm1hdCAi VGhlcmUgaXMgYW4gZXhpc3RpbmcgRW1hY3Mgc2VydmVyLCBuYW1lZCAlUy5cbiIKLSAgICAg ICAgICAgICAgICAgICAgICAgICAgc2VydmVyLW5hbWUpCi0gICAgICAgICAgICAgICAgICAo c3Vic3RpdHV0ZS1jb21tYW5kLWtleXMKLSAgICAgICAgICAgICAgICAgICAgIlRvIHN0YXJ0 IHRoZSBzZXJ2ZXIgaW4gdGhpcyBFbWFjcyBwcm9jZXNzLCBzdG9wIHRoZSBleGlzdGluZwot c2VydmVyIG9yIGNhbGwgYFxcW3NlcnZlci1mb3JjZS1kZWxldGVdJyB0byBmb3JjaWJseSBk aXNjb25uZWN0IGl0LiIpKQotICAgICAgICAgIDp3YXJuaW5nKQotICAgICAgICAgKHNldHEg bGVhdmUtZGVhZCB0KSkpCi0gICAgICA7OyBJZiB0aGlzIEVtYWNzIGFscmVhZHkgaGFkIGEg c2VydmVyLCBjbGVhciBvdXQgYXNzb2NpYXRlZCBzdGF0dXMuCi0gICAgICAod2hpbGUgc2Vy dmVyLWNsaWVudHMKLQkoc2VydmVyLWRlbGV0ZS1jbGllbnQgKGNhciBzZXJ2ZXItY2xpZW50 cykpKQorICAgIDs7IElmIGEgc2VydmVyIGlzIGFscmVhZHkgcnVubmluZywgdHJ5IHRvIHN0 b3AgaXQuCisgICAgKGNvbmRpdGlvbi1jYXNlIGVycgorICAgICAgICA7OyBDaGVjayB0byBz ZWUgaWYgYW4gdW5pbml0aWFsaXplZCBleHRlcm5hbCBzb2NrZXQgaGFzIGJlZW4KKyAgICAg ICAgOzsgcGFzc2VkIGluLiAgSWYgdGhhdCBpcyB0aGUgY2FzZSwgZG9uJ3QgdHJ5IHRvIHN0 b3AgdGhlCisgICAgICAgIDs7IHNlcnZlci4gIChgc2VydmVyLXN0b3AnIGNoZWNrcyBgc2Vy dmVyLXJ1bm5pbmctcCcsIHdoaWNoCisgICAgICAgIDs7IHdvdWxkIHJldHVybiB0aGUgd3Jv bmcgcmVzdWx0KS4KKyAgICAgICAgKGlmIChhbmQgaW50ZXJuYWwtLWRhZW1vbi1zb2NrbmFt ZQorICAgICAgICAgICAgICAgICAobm90IHNlcnZlci0tZXh0ZXJuYWwtc29ja2V0LWluaXRp YWxpemVkKSkKKyAgICAgICAgICAgIChzZXRxIHNlcnZlci0tZXh0ZXJuYWwtc29ja2V0LWlu aXRpYWxpemVkIHQpCisgICAgICAgICAgKHNlcnZlci1zdG9wKSkKKyAgICAgIChzZXJ2ZXIt cnVubmluZy1leHRlcm5hbAorICAgICAgIChkaXNwbGF5LXdhcm5pbmcKKyAgICAgICAgJ3Nl cnZlcgorICAgICAgICAoY29uY2F0ICJVbmFibGUgdG8gc3RhcnQgdGhlIEVtYWNzIHNlcnZl ci5cbiIKKyAgICAgICAgICAgICAgICAoY2FkciBlcnIpCisgICAgICAgICAgICAgICAgKHN1 YnN0aXR1dGUtY29tbWFuZC1rZXlzCisgICAgICAgICAgICAgICAgICJcblRvIHN0YXJ0IHRo ZSBzZXJ2ZXIgaW4gdGhpcyBFbWFjcyBwcm9jZXNzLCBzdG9wIHRoZSBleGlzdGluZ3NlcnZl ciBvciBjYWxsIGBcXFtzZXJ2ZXItZm9yY2UtZGVsZXRlXScgdG8gZm9yY2libHkgZGlzY29u bmVjdCBpdC4iKSkKKyAgICAgICAgOndhcm5pbmcpCisgICAgICAgKHNldHEgbGVhdmUtZGVh ZCB0KSkpCiAgICAgICA7OyBOb3cgYW55IHByZXZpb3VzIHNlcnZlciBpcyBwcm9wZXJseSBz dG9wcGVkLgotICAgICAgKGlmIGxlYXZlLWRlYWQKLQkgIChwcm9nbgotCSAgICAodW5sZXNz IChlcSB0IGxlYXZlLWRlYWQpIChzZXJ2ZXItbG9nIChtZXNzYWdlICJTZXJ2ZXIgc3RvcHBl ZCIpKSkKLSAgICAgICAgICAgIChzZXRxIHNlcnZlci1tb2RlIG5pbAotICAgICAgICAgICAg ICAgICAgZ2xvYmFsLW1pbm9yLW1vZGVzIChkZWxxICdzZXJ2ZXItbW9kZSBnbG9iYWwtbWlu b3ItbW9kZXMpCi0gICAgICAgICAgICAgICAgICBzZXJ2ZXItcHJvY2VzcyBuaWwpKQorICAg ICh1bmxlc3MgbGVhdmUtZGVhZAorICAgICAgKGxldCAoKHNlcnZlci1maWxlIChzZXJ2ZXIt LWZpbGUtbmFtZSkpKQogCTs7IE1ha2Ugc3VyZSB0aGVyZSBpcyBhIHNhZmUgZGlyZWN0b3J5 IGluIHdoaWNoIHRvIHBsYWNlIHRoZSBzb2NrZXQuCi0JKHNlcnZlci1lbnN1cmUtc2FmZS1k aXIgc2VydmVyLWRpcikKKwkoc2VydmVyLWVuc3VyZS1zYWZlLWRpciAoZmlsZS1uYW1lLWRp cmVjdG9yeSBzZXJ2ZXItZmlsZSkpCiAJKHdoZW4gc2VydmVyLXByb2Nlc3MKIAkgIChzZXJ2 ZXItbG9nIChtZXNzYWdlICJSZXN0YXJ0aW5nIHNlcnZlciIpKSkKICAgICAgICAgKHdpdGgt ZmlsZS1tb2RlcyA/XDcwMApAQCAtNzQ1LDcgKzc3MCw3IEBAIHNlcnZlci1zdGFydAogKGRl ZnVuIHNlcnZlci1mb3JjZS1zdG9wICgpCiAgICJLaWxsIGFsbCBjb25uZWN0aW9ucyB0byB0 aGUgY3VycmVudCBzZXJ2ZXIuCiBUaGlzIGZ1bmN0aW9uIGlzIG1lYW50IHRvIGJlIGNhbGxl ZCBmcm9tIGBraWxsLWVtYWNzLWhvb2snLiIKLSAgKHNlcnZlci1zdGFydCB0IHQpKQorICAo aWdub3JlLWVycm9ycyAoc2VydmVyLXN0b3AgJ25vZnJhbWUpKSkKIAogOzs7IyMjYXV0b2xv YWQKIChkZWZ1biBzZXJ2ZXItZm9yY2UtZGVsZXRlICgmb3B0aW9uYWwgbmFtZSkKQEAgLTE4 NjYsMTEgKzE4OTEsMTAgQEAgc2VydmVyLWV2YWwtYXQKIGNhbm5vdCBjb250YWN0IHRoZSBz cGVjaWZpZWQgc2VydmVyLiAgRm9yIGV4YW1wbGU6CiAgIChzZXJ2ZXItZXZhbC1hdCBcInNl cnZlclwiIFxcPScoZW1hY3MtcGlkKSkKIHJldHVybnMgdGhlIHByb2Nlc3MgSUQgb2YgdGhl IEVtYWNzIGluc3RhbmNlIHJ1bm5pbmcgXCJzZXJ2ZXJcIi4iCi0gIChsZXQqICgoc2VydmVy LWRpciAoaWYgc2VydmVyLXVzZS10Y3Agc2VydmVyLWF1dGgtZGlyIHNlcnZlci1zb2NrZXQt ZGlyKSkKLQkgKHNlcnZlci1maWxlIChleHBhbmQtZmlsZS1uYW1lIHNlcnZlciBzZXJ2ZXIt ZGlyKSkKLQkgKGNvZGluZy1zeXN0ZW0tZm9yLXJlYWQgJ2JpbmFyeSkKLQkgKGNvZGluZy1z eXN0ZW0tZm9yLXdyaXRlICdiaW5hcnkpCi0JIGFkZHJlc3MgcG9ydCBzZWNyZXQgcHJvY2Vz cykKKyAgKGxldCAoKHNlcnZlci1maWxlIChzZXJ2ZXItLWZpbGUtbmFtZSkpCisgICAgICAg IChjb2Rpbmctc3lzdGVtLWZvci1yZWFkICdiaW5hcnkpCisgICAgICAgIChjb2Rpbmctc3lz dGVtLWZvci13cml0ZSAnYmluYXJ5KQorICAgICAgICBhZGRyZXNzIHBvcnQgc2VjcmV0IHBy b2Nlc3MpCiAgICAgKHVubGVzcyAoZmlsZS1leGlzdHMtcCBzZXJ2ZXItZmlsZSkKICAgICAg IChlcnJvciAiTm8gc3VjaCBzZXJ2ZXI6ICVzIiBzZXJ2ZXIpKQogICAgICh3aXRoLXRlbXAt YnVmZmVyCmRpZmYgLS1naXQgYS90ZXN0L2xpc3Avc2VydmVyLXRlc3RzLmVsIGIvdGVzdC9s aXNwL3NlcnZlci10ZXN0cy5lbAppbmRleCA0OGVmMTEwOTQzLi4zNzBjZjg2MTQ4IDEwMDY0 NAotLS0gYS90ZXN0L2xpc3Avc2VydmVyLXRlc3RzLmVsCisrKyBiL3Rlc3QvbGlzcC9zZXJ2 ZXItdGVzdHMuZWwKQEAgLTEzMSw0ICsxMzEsMzkgQEAgc2VydmVyLXRlc3RzL2VtYWNzY2xp ZW50L2V2YWwKICAgICAgICAiLS1ldmFsIiAoZm9ybWF0ICIoc2V0cSBzZXJ2ZXItdGVzdHMv dmFyaWFibGUgJWQpIiB2YWx1ZSkpCiAgICAgICAoc2VydmVyLXRlc3RzL3dhaXQtdW50aWwg KGVxIHNlcnZlci10ZXN0cy92YXJpYWJsZSB2YWx1ZSkpKSkpCiAKKyhlcnQtZGVmdGVzdCBz ZXJ2ZXItdGVzdHMvc2VydmVyLWZvcmNlLXN0b3Ava2VlcHMtZnJhbWVzICgpCisgICJFbnN1 cmUgdGhhdCBgc2VydmVyLWZvcmNlLXN0b3AnIGRvZXNuJ3QgZGVsZXRlIGZyYW1lcy4gIFNl ZSBidWcjNTg4NzcuCitOb3RlOiBzaW5jZSB0aGF0IGJ1ZyBpcyBhYm91dCBhIGJlaGF2aW9y IHdoZW4ga2lsbGluZyBFbWFjcywgdGhpcwordGVzdCBpcyBzb21ld2hhdCBpbmRpcmVjdC4g KEtpbGxpbmcgdGhlIGN1cnJlbnQgRW1hY3MgaW5zdGFuY2UKK3dvdWxkIG1ha2UgaXQgaGFy ZCB0byBjaGVjayB0ZXN0IHJlc3VsdHMhKSAgSW5zdGVhZCwgaXQgb25seQordGVzdHMgdGhh dCBgc2VydmVyLWZvcmNlLXN0b3AnIGRvZXNuJ3QgZGVsZXRlIGZyYW1lcyAoYW5kIGV2ZW4K K3RoZW4sIHJlcXVpcmVzIGEgZmV3IHRyaWNrcyB0byBydW4gYXMgYSByZWdyZXNzaW9uIHRl c3QpLiAgU28KK2xvbmcgYXMgdGhpcyB3b3JrcywgdGhlIHByb2JsZW0gaW4gYnVnIzU4ODc3 IHNob3VsZG4ndCBvY2N1ci4iCisgIChsZXQgKHRlcm1pbmFsKQorICAgICh1bndpbmQtcHJv dGVjdAorICAgICAgICAoc2VydmVyLXRlc3RzL3dpdGgtc2VydmVyCisgICAgICAgICAgKGxl dCAoKGVtYWNzY2xpZW50IChzZXJ2ZXItdGVzdHMvc3RhcnQtZW1hY3NjbGllbnQgIi1jIikp KQorICAgICAgICAgICAgKHNlcnZlci10ZXN0cy93YWl0LXVudGlsIChsZW5ndGg9IChmcmFt ZS1saXN0KSAyKSkKKyAgICAgICAgICAgIChzaG91bGQgKGVxIChwcm9jZXNzLXN0YXR1cyBl bWFjc2NsaWVudCkgJ3J1bikpCisKKyAgICAgICAgICAgIDs7IERvbid0IGRlbGV0ZSB0aGUg dGVybWluYWwgZm9yIHRoZSBjbGllbnQ7IHRoYXQgd291bGQKKyAgICAgICAgICAgIDs7IGtp bGwgaXRzIGZyYW1lIGltbWVkaWF0ZWx5IHRvby4gIChUaGlzIGlzIG9ubHkgYW4gaXNzdWUK KyAgICAgICAgICAgIDs7IHdoZW4gcnVubmluZyB0aGVzZSB0ZXN0cyB2aWEgdGhlIGNvbW1h bmQgbGluZTsKKyAgICAgICAgICAgIDs7IG5vcm1hbGx5LCBpbiBhbiBpbnRlcmFjdGl2ZSBz ZXNzaW9uLCB3ZSBkb24ndCBuZWVkIHRvCisgICAgICAgICAgICA7OyB3b3JyeSBhYm91dCB0 aGlzLiAgQnV0IHNpbmNlIHdlIHdhbnQgdG8gY2hlY2sgdGhhdAorICAgICAgICAgICAgOzsg YHNlcnZlci1mb3JjZS1zdG9wJyBkb2Vzbid0IGRlbGV0ZSBmcmFtZXMgdW5kZXIgbm9ybWFs CisgICAgICAgICAgICA7OyBjaXJjdW1zdGFuY2VzLCB3ZSBuZWVkIHRvIGJ5cGFzcyB0ZXJt aW5hbCBkZWxldGlvbgorICAgICAgICAgICAgOzsgaGVyZS4pCisgICAgICAgICAgICAoc2V0 cSB0ZXJtaW5hbCAocHJvY2Vzcy1nZXQgKGNhciBzZXJ2ZXItY2xpZW50cykgJ3Rlcm1pbmFs KSkKKyAgICAgICAgICAgIChwcm9jZXNzLXB1dCAoY2FyIHNlcnZlci1jbGllbnRzKSAnbm8t ZGVsZXRlLXRlcm1pbmFsIHQpCisKKyAgICAgICAgICAgIChzZXJ2ZXItZm9yY2Utc3RvcCkp CisgICAgICAgICAgOzsgRW5zdXJlIHdlIGRpZG4ndCBkZWxldGUgdGhlIGZyYW1lLgorICAg ICAgICAgIChzaG91bGQgKGxlbmd0aD0gKGZyYW1lLWxpc3QpIDIpKSkKKyAgICAgIDs7IENs ZWFuIHVwIGFmdGVyIG91cnNlbHZlcyBhbmQgZGVsZXRlIHRoZSB0ZXJtaW5hbC4KKyAgICAg ICh3aGVuIChhbmQgdGVybWluYWwKKyAgICAgICAgICAgICAgICAgKGVxICh0ZXJtaW5hbC1s aXZlLXAgdGVybWluYWwpIHQpCisgICAgICAgICAgICAgICAgIChub3QgKGVxIHN5c3RlbS10 eXBlICd3aW5kb3dzLW50KSkpCisgICAgICAgIChkZWxldGUtdGVybWluYWwgdGVybWluYWwp KSkpKQorCiA7Ozsgc2VydmVyLXRlc3RzLmVsIGVuZHMgaGVyZQotLSAKMi4yNS4xCgo= --------------z7oWeiBpibEA4Yba0Cs0BPCi-- From unknown Sat Jun 14 04:55:23 2025 X-Loop: help-debbugs@gnu.org Subject: bug#58877: 29.0.50; [PATCH] When killing Emacs from a client frame with no other frames, Emacs shows a useless error prompt Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 24 Nov 2022 11:51:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58877 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Jim Porter Cc: 58877@debbugs.gnu.org Received: via spool by 58877-submit@debbugs.gnu.org id=B58877.1669290660978 (code B ref 58877); Thu, 24 Nov 2022 11:51:01 +0000 Received: (at 58877) by debbugs.gnu.org; 24 Nov 2022 11:51:00 +0000 Received: from localhost ([127.0.0.1]:57563 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oyAku-0000Fi-DH for submit@debbugs.gnu.org; Thu, 24 Nov 2022 06:51:00 -0500 Received: from eggs.gnu.org ([209.51.188.92]:42886) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oyAkt-0000FT-1J for 58877@debbugs.gnu.org; Thu, 24 Nov 2022 06:50:59 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oyAkn-00051V-O8; Thu, 24 Nov 2022 06:50:53 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=jvYKj2WE3W3HZgS2eYyzg2yhQBPj1XXdqshod3bUUig=; b=ZvGP6debpJJk h273xqS1VFV9JZYwiNwZy4G0220uyghMAuwEgikGTHr8bdxDnuA+sv10VkhzAbTsIH+6Uhj0/X3Ot werwLsYC8qBDbW8mV4uCs/aY0gFHMTUl1xSGi7X6GJiBL1KmCelVoXQ9upvZB8Xr2DZFU2u7T6Kwo avJUfzfDDp0S9LsycsfkK8QTt30ufzCaYyBDJdXtXcM/+jdzhBAB4u6yBc9RMiPcT4oijtJhmvuFZ +HI4Z13XkJOfLvnDzI2D29uuwZPD9zVFLIez33w+6dYI0eBtyl/Ys1ef0AUqhUW6k//1AicI1nMNl NlFPHtJfVNSbmLNEcxRLiw==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oyAkn-0004CA-6f; Thu, 24 Nov 2022 06:50:53 -0500 Date: Thu, 24 Nov 2022 13:51:13 +0200 Message-Id: <83k03kwoy6.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: (message from Jim Porter on Mon, 21 Nov 2022 21:06:31 -0800) References: <8121efd5-77c3-0682-ce0f-6be9375dadd8@gmail.com> <83a65dhm7f.fsf@gnu.org> <13835614-c593-ba2d-5373-a9950f6f3dab@gmail.com> X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Mon, 21 Nov 2022 21:06:31 -0800 > From: Jim Porter > Cc: 58877@debbugs.gnu.org > > On 10/30/2022 2:14 PM, Jim Porter wrote: > > Thanks for taking a look. I had hesitated to make any big changes to > > this code since it doesn't have regression tests... > Since server.el could probably use more tests anyway, I added a few ERT > tests covering the most common use cases (see the first patch), and then > added another test for the second patch. The test in the second patch is > pretty indirect, but that's because it's testing something that normally > happens when killing Emacs; it'd be hard to kill the current Emacs > instance and still be able to check test results! This is fine with me, but please fix the typo before installing: > +(defun server-stop (&optional noframe) > + "If this Emacs process has a server communication subprocess, stop it. > +If the server is running in some other Emac process (see ^^^^ From unknown Sat Jun 14 04:55:23 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Jim Porter Subject: bug#58877: closed (Re: bug#58877: 29.0.50; [PATCH] When killing Emacs from a client frame with no other frames, Emacs shows a useless error prompt) Message-ID: References: <8121efd5-77c3-0682-ce0f-6be9375dadd8@gmail.com> X-Gnu-PR-Message: they-closed 58877 X-Gnu-PR-Package: emacs X-Gnu-PR-Keywords: patch Reply-To: 58877@debbugs.gnu.org Date: Fri, 25 Nov 2022 01:37:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1669340222-12070-1" This is a multi-part message in MIME format... ------------=_1669340222-12070-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #58877: 29.0.50; [PATCH] When killing Emacs from a client frame with no oth= er frames, Emacs shows a useless error prompt which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 58877@debbugs.gnu.org. --=20 58877: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D58877 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1669340222-12070-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 58877-done) by debbugs.gnu.org; 25 Nov 2022 01:36:21 +0000 Received: from localhost ([127.0.0.1]:60952 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oyNdd-00037O-HB for submit@debbugs.gnu.org; Thu, 24 Nov 2022 20:36:21 -0500 Received: from mail-pg1-f182.google.com ([209.85.215.182]:38587) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oyNdb-000379-3Z for 58877-done@debbugs.gnu.org; Thu, 24 Nov 2022 20:36:19 -0500 Received: by mail-pg1-f182.google.com with SMTP id 130so2746375pgc.5 for <58877-done@debbugs.gnu.org>; Thu, 24 Nov 2022 17:36:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to; bh=WOe+Vonor3IgTolu68bE29osR67FxTlbwoCuilf/vxk=; b=W4uwDSprnqM1eHXzSDeuKkZrHT7Plm1lOAxjTkUGP8nCK/TGb/mE0Uz7tr6rXylktM lVEob0EFWZkPF5U/3W6c/kOyTum5nHqu5dazKIyQNOgClibecz4axVS3n9+vzG/brE1w pCN2OVe/XmW5qpVIUxW9oJtK7KzVnWTLe8hQMxI8kJqEQ6lAuzEhKQ3z2WlRHM7Paef9 YJWxxvs3OjaOvsboJuRB9tVjWxAlYE03n0Shhk+CgBgmGWuhyRomYzmV0nvDh6YpBQjl poB1lekx7upjlbenvnnsP9FsoRL/omtJnLz+p342D3QWHsAjscsmcHYQelBnVaN3aaSI 7jcw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=WOe+Vonor3IgTolu68bE29osR67FxTlbwoCuilf/vxk=; b=sqp7+gDCo2AifzcnaYkHfK1jAw1SHUn+0YEib1OeglOEIh8Sb5d1uy0wWLM7KPjoMZ Z5B/U1wesMgoiZbH4QNwJDl4lUghJF68pg1MlV9rOKpaI3Jb/FKJt4cdriZi2dEwV2mE L+9ySANiOac9mGcJHx3M4NYOIpyPH3Dku4eTiBRUpCbN7DsZvfQ22jrLmPk7gnUSHrX4 u140aCcS0ZjFaZ5E3v0R7HSQ713jujZy7UMP4Ze5MekzwQ55m7LWJ9haVEg6fhHtMMyu jzoW2Bgh61DTQEJ8FusVcF/ctozYzrOC3bRwPR1xB7ItMfGMccSea2ukXEz6xzQByLeH 6jlA== X-Gm-Message-State: ANoB5pnsSQtffLWJZM8vK6K14Mp8xh6OL8yj0JTh12zXWsdH/SrwUkKm 1jaOVtURRCet533s+Hrcw3llC0DsS5c= X-Google-Smtp-Source: AA0mqf4dc8LbSCzA+WgPDotyYuahZv9ZkheCwwEJpbM+vF06gD6NdIJ0st+EPDD6qnFeM6wBQXS8iA== X-Received: by 2002:aa7:8b56:0:b0:56c:6f8:fe14 with SMTP id i22-20020aa78b56000000b0056c06f8fe14mr37584517pfd.75.1669340173161; Thu, 24 Nov 2022 17:36:13 -0800 (PST) Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id h8-20020a170902f54800b00189618fc2d8sm869707plf.242.2022.11.24.17.36.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 24 Nov 2022 17:36:12 -0800 (PST) Message-ID: Date: Thu, 24 Nov 2022 17:36:11 -0800 MIME-Version: 1.0 Subject: Re: bug#58877: 29.0.50; [PATCH] When killing Emacs from a client frame with no other frames, Emacs shows a useless error prompt Content-Language: en-US To: Eli Zaretskii References: <8121efd5-77c3-0682-ce0f-6be9375dadd8@gmail.com> <83a65dhm7f.fsf@gnu.org> <13835614-c593-ba2d-5373-a9950f6f3dab@gmail.com> <83k03kwoy6.fsf@gnu.org> From: Jim Porter In-Reply-To: <83k03kwoy6.fsf@gnu.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 58877-done Cc: 58877-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 11/24/2022 3:51 AM, Eli Zaretskii wrote: >> Date: Mon, 21 Nov 2022 21:06:31 -0800 >> From: Jim Porter >> Cc: 58877@debbugs.gnu.org >> >> Since server.el could probably use more tests anyway, I added a few ERT >> tests covering the most common use cases (see the first patch), and then >> added another test for the second patch. The test in the second patch is >> pretty indirect, but that's because it's testing something that normally >> happens when killing Emacs; it'd be hard to kill the current Emacs >> instance and still be able to check test results! > > This is fine with me, but please fix the typo before installing: Whoops! Good catch, thanks. Merged as 28c444f72a9843ce335032db1fa0f484dfeb4833 with the typo fixed. Closing this now. ------------=_1669340222-12070-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 29 Oct 2022 21:33:54 +0000 Received: from localhost ([127.0.0.1]:36792 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ootSj-0001MY-IW for submit@debbugs.gnu.org; Sat, 29 Oct 2022 17:33:53 -0400 Received: from lists.gnu.org ([209.51.188.17]:56464) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ootSe-0001MO-WB for submit@debbugs.gnu.org; Sat, 29 Oct 2022 17:33:52 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ootSe-0001gD-Os for bug-gnu-emacs@gnu.org; Sat, 29 Oct 2022 17:33:48 -0400 Received: from mail-pj1-x1031.google.com ([2607:f8b0:4864:20::1031]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ootSc-0004Bm-T2 for bug-gnu-emacs@gnu.org; Sat, 29 Oct 2022 17:33:48 -0400 Received: by mail-pj1-x1031.google.com with SMTP id f5-20020a17090a4a8500b002131bb59d61so10017808pjh.1 for ; Sat, 29 Oct 2022 14:33:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:subject:from:content-language:mime-version:date:message-id:from :to:cc:subject:date:message-id:reply-to; bh=my1eDXVALNFtbiLgxJsoJBBbXLtiOKXfz2dGAoZgBY4=; b=WmKa9zIRg/tPeoLhbOGvfHnR8PoSOx693HzruOl678UJN90Whxtj7gAdLExm1ZL/RE qAFgqOHnORyhLst7f+JEbzozAYbLB7Q3qrpwuP/t+iO4iPzAQ5cbGz/3wVdKkL2SgUzM xCYw6IJfN9rTWszkEg32KZEYsu0vrQq3cQUoHsiQ9X+flj25/gceREnUB2+SQ/sx1yEF b0hY3Bh/wcLhiX/wB5/Bghwm3jukjHe5Cz5kJM8QyGGjeWPUkEp0kpPgR5yz2auoPifz R/OVu9JToiY9IXXXgzjvc6t8ueVNKEApv41kcYlgwDwaO4SeC7F0SBQuZSDihHou5Rhv xSmg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:subject:from:content-language:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=my1eDXVALNFtbiLgxJsoJBBbXLtiOKXfz2dGAoZgBY4=; b=UFCALDOhV0CYrThBRCwsRY3Xdlkwf9EM/3M0yLab/v69Wp+Fz836YgczyNDKreDPpN Gcf6+d7RK+emmLhDuypQ9BqdanXgxviIhBPNFE+KGVEyta6JHkqRpNgB8jzjGDktAPNT N7dRCxLh5Ptkv/zTf6rdz7XiIljkeZAYJ13dDFV/pYKaeAX4p9d1fzP5LmnfLZ1YMPl0 +hO1t4Zq4WIj4woaJ+MiSx6DOcplW0JQZhSFoEptQ4fEMbR5+EqpcOmZ9H6b+ujpyAL1 lkcg8F7L+eD30zwMkp2tuQcL6DeWZinMeNuFTWW+R/TalSyU05+h9lXCrGxv2744eV1E 4Ong== X-Gm-Message-State: ACrzQf3laDeQbpDG6BLcvf0JquXbBz+18njF4m12pueJeAfa+yDdMAw7 sAJiADcn1d+5/ZFEM1i9BFHz6RcOYEI= X-Google-Smtp-Source: AMsMyM63h0ZZDZK+r8NhqjOQhlWhxowjJT8z0qhGT7s26yMj6fxMWnkz1rzw45AF199+c54Pf7bm1w== X-Received: by 2002:a17:903:2596:b0:186:a395:c4bd with SMTP id jb22-20020a170903259600b00186a395c4bdmr6345194plb.60.1667079224713; Sat, 29 Oct 2022 14:33:44 -0700 (PDT) Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id u10-20020a170902714a00b001730a1af0fbsm1728318plm.23.2022.10.29.14.33.43 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 29 Oct 2022 14:33:43 -0700 (PDT) Content-Type: multipart/mixed; boundary="------------m0GquRHHJ48pym6nKNABktgY" Message-ID: <8121efd5-77c3-0682-ce0f-6be9375dadd8@gmail.com> Date: Sat, 29 Oct 2022 14:33:42 -0700 MIME-Version: 1.0 X-Mozilla-News-Host: news://news.gmane.io:119 Content-Language: en-US From: Jim Porter Subject: 29.0.50; [PATCH] When killing Emacs from a client frame with no other frames, Emacs shows a useless error prompt To: bug-gnu-emacs@gnu.org Received-SPF: pass client-ip=2607:f8b0:4864:20::1031; envelope-from=jporterbugs@gmail.com; helo=mail-pj1-x1031.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) This is a multi-part message in MIME format. --------------m0GquRHHJ48pym6nKNABktgY Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit (Note: I originally mentioned this in bug#51993, but it's only somewhat-related to that bug. To make things easier to follow, I pulled this part out into a separate bug.) To see this in action: $ emacs -Q -f server-start $ emacsclient -c foo.txt ;; From the first (non-client) frame: C-x 5 0 ;; delete-frame ;; From the second (client) frame: M-x kill-emacs ;; Emacs prompts: Error (error Attempt to delete the sole visible or iconified frame); continue? (y or n) Pressing "y" will properly kill Emacs, but there's no real use for the warning in this case. It happens because 'server-force-stop' (indirectly) tries to delete the last (client) frame before killing Emacs, meaning that Emacs would have zero frames for a bit. Since 'server-force-stop's docstring says, "This function is meant to be called from `kill-emacs-hook'," it should be safe to have 'server-force-stop' avoid deleting any frames: they'll just get deleted when Emacs is actually killed. Attached is a patch to do this. Note that I named the new argument "noframe" because that matches the existing code in server.el (see 'server-delete-client'). It's a bit of a misnomer though, and maybe "keep-frames" would be better... --------------m0GquRHHJ48pym6nKNABktgY Content-Type: text/plain; charset=UTF-8; name="0001-Don-t-explicitly-delete-client-frames-when-killing-E.patch" Content-Disposition: attachment; filename*0="0001-Don-t-explicitly-delete-client-frames-when-killing-E.pa"; filename*1="tch" Content-Transfer-Encoding: base64 RnJvbSA1MjI1NzRjZTY5ZTNjMTk4YTQwYjU3ZTJlMjExZTE0NTYyMzM0ZjMzIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKaW0gUG9ydGVyIDxqcG9ydGVyYnVnc0BnbWFpbC5j b20+CkRhdGU6IEZyaSwgMTkgTm92IDIwMjEgMjA6MTQ6MzMgLTA4MDAKU3ViamVjdDogW1BB VENIXSBEb24ndCBleHBsaWNpdGx5IGRlbGV0ZSBjbGllbnQgZnJhbWVzIHdoZW4ga2lsbGlu ZyBFbWFjcwogYW55d2F5CgpUaGlzIGVsaW1pbmF0ZXMgYSB1c2VsZXNzIGVycm9yIHByb21w dCB3aGVuIGtpbGxpbmcgRW1hY3MgZnJvbSBhCmNsaWVudCBmcmFtZSB3aGVuIHRoZXJlIGFy ZSBubyBvdGhlciBmcmFtZXMuCgoqIGxpc3Avc2VydmVyLmVsIChzZXJ2ZXItc3RhcnQpOiBB ZGQgTk9GUkFNRSBhcmd1bWVudCB0byBhdm9pZApkZWxldGluZyBmcmFtZXMuCihzZXJ2ZXIt Zm9yY2Utc3RvcCk6IFBhc3MgJ25vZnJhbWUnIHRvICdzZXJ2ZXItc3RvcCcuCi0tLQogbGlz cC9zZXJ2ZXIuZWwgfCAxMSArKysrKysrKy0tLQogMSBmaWxlIGNoYW5nZWQsIDggaW5zZXJ0 aW9ucygrKSwgMyBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9saXNwL3NlcnZlci5lbCBi L2xpc3Avc2VydmVyLmVsCmluZGV4IDkwZDk3YzE1MzguLjJiNzIxM2I4OTAgMTAwNjQ0Ci0t LSBhL2xpc3Avc2VydmVyLmVsCisrKyBiL2xpc3Avc2VydmVyLmVsCkBAIC02MTEsNyArNjEx LDcgQEAgc2VydmVyLWdldC1hdXRoLWtleQogICAgIChzZXJ2ZXItZ2VuZXJhdGUta2V5KSkp CiAKIDs7OyMjI2F1dG9sb2FkCi0oZGVmdW4gc2VydmVyLXN0YXJ0ICgmb3B0aW9uYWwgbGVh dmUtZGVhZCBpbmhpYml0LXByb21wdCkKKyhkZWZ1biBzZXJ2ZXItc3RhcnQgKCZvcHRpb25h bCBsZWF2ZS1kZWFkIGluaGliaXQtcHJvbXB0IG5vZnJhbWUpCiAgICJBbGxvdyB0aGlzIEVt YWNzIHByb2Nlc3MgdG8gYmUgYSBzZXJ2ZXIgZm9yIGNsaWVudCBwcm9jZXNzZXMuCiBUaGlz IHN0YXJ0cyBhIHNlcnZlciBjb21tdW5pY2F0aW9ucyBzdWJwcm9jZXNzIHRocm91Z2ggd2hp Y2ggY2xpZW50CiBcImVkaXRvcnNcIiBjYW4gc2VuZCB5b3VyIGVkaXRpbmcgY29tbWFuZHMg dG8gdGhpcyBFbWFjcyBqb2IuCkBAIC02MjUsNiArNjI1LDExIEBAIHNlcnZlci1zdGFydAog cnVubmluZywgYXNrIHRoZSB1c2VyIGZvciBjb25maXJtYXRpb24gZmlyc3QsIHVubGVzcyBv cHRpb25hbAogYXJndW1lbnQgSU5ISUJJVC1QUk9NUFQgaXMgbm9uLW5pbC4KIAorSWYgTk9G UkFNRSBpcyBub24tbmlsLCBkb24ndCBkZWxldGUgYW55IGV4aXN0aW5nIGZyYW1lcworYXNz b2NpYXRlZCB3aXRoIGEgY2xpZW50IHByb2Nlc3MuICBUaGlzIGlzIHVzZWZ1bCwgZm9yIGV4 YW1wbGUsCit3aGVuIGtpbGxpbmcgRW1hY3MsIGluIHdoaWNoIGNhc2UgdGhlIGZyYW1lcyB3 aWxsIGdldCBkZWxldGVkCithbnl3YXkuCisKIFRvIGZvcmNlLXN0YXJ0IGEgc2VydmVyLCBk byBcXFtzZXJ2ZXItZm9yY2UtZGVsZXRlXSBhbmQgdGhlbgogXFxbc2VydmVyLXN0YXJ0XS4K IApAQCAtNjgzLDcgKzY4OCw3IEBAIHNlcnZlci1zdGFydAogICAgICAgICAgKHNldHEgbGVh dmUtZGVhZCB0KSkpCiAgICAgICA7OyBJZiB0aGlzIEVtYWNzIGFscmVhZHkgaGFkIGEgc2Vy dmVyLCBjbGVhciBvdXQgYXNzb2NpYXRlZCBzdGF0dXMuCiAgICAgICAod2hpbGUgc2VydmVy LWNsaWVudHMKLQkoc2VydmVyLWRlbGV0ZS1jbGllbnQgKGNhciBzZXJ2ZXItY2xpZW50cykp KQorCShzZXJ2ZXItZGVsZXRlLWNsaWVudCAoY2FyIHNlcnZlci1jbGllbnRzKSBub2ZyYW1l KSkKICAgICAgIDs7IE5vdyBhbnkgcHJldmlvdXMgc2VydmVyIGlzIHByb3Blcmx5IHN0b3Bw ZWQuCiAgICAgICAoaWYgbGVhdmUtZGVhZAogCSAgKHByb2duCkBAIC03NDIsNyArNzQ3LDcg QEAgc2VydmVyLXN0YXJ0CiAoZGVmdW4gc2VydmVyLWZvcmNlLXN0b3AgKCkKICAgIktpbGwg YWxsIGNvbm5lY3Rpb25zIHRvIHRoZSBjdXJyZW50IHNlcnZlci4KIFRoaXMgZnVuY3Rpb24g aXMgbWVhbnQgdG8gYmUgY2FsbGVkIGZyb20gYGtpbGwtZW1hY3MtaG9vaycuIgotICAoc2Vy dmVyLXN0YXJ0IHQgdCkpCisgIChzZXJ2ZXItc3RhcnQgdCB0ICdub2ZyYW1lKSkKIAogOzs7 IyMjYXV0b2xvYWQKIChkZWZ1biBzZXJ2ZXItZm9yY2UtZGVsZXRlICgmb3B0aW9uYWwgbmFt ZSkKLS0gCjIuMjUuMQoK --------------m0GquRHHJ48pym6nKNABktgY-- ------------=_1669340222-12070-1-- From unknown Sat Jun 14 04:55:23 2025 X-Loop: help-debbugs@gnu.org Subject: bug#58877: 29.0.50; [PATCH] When killing Emacs from a client frame with no other frames, Emacs shows a useless error prompt Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 25 Nov 2022 13:26:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58877 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Jim Porter Cc: 58877@debbugs.gnu.org Received: via spool by 58877-submit@debbugs.gnu.org id=B58877.16693827245495 (code B ref 58877); Fri, 25 Nov 2022 13:26:01 +0000 Received: (at 58877) by debbugs.gnu.org; 25 Nov 2022 13:25:24 +0000 Received: from localhost ([127.0.0.1]:33851 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oyYho-0001QY-1l for submit@debbugs.gnu.org; Fri, 25 Nov 2022 08:25:24 -0500 Received: from eggs.gnu.org ([209.51.188.92]:46030) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oyYhk-0001QG-7j for 58877@debbugs.gnu.org; Fri, 25 Nov 2022 08:25:22 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oyYhf-0001CM-08; Fri, 25 Nov 2022 08:25:15 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=JXKjMLJ4/WUbYAcio/0gTHumJsGMDuXuWsGUWI9tl/Y=; b=UwdfYuqrWa/J p3ibDsw7pXc+fkpWow+y+FtabS11E7r/qh37HflmMpoMjpN12pHQyAJskSy+Bq3W6rqmZO8ZCAgFr oWAwXSqCS4L0RF+cP7IipxSANDOMP3aZ3C7U2CVzlJn1/msa5oTk3j26kL6DSMAjur2z2TGTh4Bs1 oquRU4oGImtPuxnkgKF6OalDGviDVfWhJlAJCkVqufjlaXSiJRfYCNIeDpwQKqICmfJbxNgWg+/dC p1sg4cmexi3zUtd/kQmaOAe42VzwMN/pSA0byDyr1eox19LB06Ssg0lTwl19Wuia5VKU8SLwU6lct 2a+lKIpkXBDp5J9Ut2J/SA==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oyYhe-0007Nk-6B; Fri, 25 Nov 2022 08:25:14 -0500 Date: Fri, 25 Nov 2022 15:25:36 +0200 Message-Id: <83a64fupwv.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: (message from Jim Porter on Thu, 24 Nov 2022 17:36:11 -0800) References: <8121efd5-77c3-0682-ce0f-6be9375dadd8@gmail.com> <83a65dhm7f.fsf@gnu.org> <13835614-c593-ba2d-5373-a9950f6f3dab@gmail.com> <83k03kwoy6.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Thu, 24 Nov 2022 17:36:11 -0800 > Cc: 58877-done@debbugs.gnu.org > From: Jim Porter > > Merged as 28c444f72a9843ce335032db1fa0f484dfeb4833 with the typo fixed. Thanks. Are the tests supposed to be portable? Here on MS-Windows 5 tests fail: 5 unexpected results: FAILED server-tests/emacsclient/create-frame FAILED server-tests/emacsclient/eval FAILED server-tests/emacsclient/server-edit FAILED server-tests/server-force-stop/keeps-frames FAILED server-tests/server-start/stop-prompt-with-client All of them fail due to some timeout: Test server-tests/emacsclient/create-frame backtrace: signal(ert-test-failed ("timed out waiting for (length= (frame-list) ert-fail("timed out waiting for (length= (frame-list) 2) to ...") so this sounds like some fundamental issue common to all those tests. On GNU/Linux all the tests pass. Let me know if you want me to investigate something. From unknown Sat Jun 14 04:55:23 2025 X-Loop: help-debbugs@gnu.org Subject: bug#58877: 29.0.50; [PATCH] When killing Emacs from a client frame with no other frames, Emacs shows a useless error prompt Resent-From: Jim Porter Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 25 Nov 2022 19:32:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58877 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Eli Zaretskii Cc: 58877@debbugs.gnu.org Received: via spool by 58877-submit@debbugs.gnu.org id=B58877.16694046774282 (code B ref 58877); Fri, 25 Nov 2022 19:32:01 +0000 Received: (at 58877) by debbugs.gnu.org; 25 Nov 2022 19:31:17 +0000 Received: from localhost ([127.0.0.1]:37192 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oyePs-00016z-IE for submit@debbugs.gnu.org; Fri, 25 Nov 2022 14:31:17 -0500 Received: from mail-pj1-f43.google.com ([209.85.216.43]:37432) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oyePp-00016k-4Q for 58877@debbugs.gnu.org; Fri, 25 Nov 2022 14:31:14 -0500 Received: by mail-pj1-f43.google.com with SMTP id k2-20020a17090a4c8200b002187cce2f92so8508920pjh.2 for <58877@debbugs.gnu.org>; Fri, 25 Nov 2022 11:31:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:from:references:cc:to:content-language:subject :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=KRsY6Crv/Js2LNKxAegtrhC4Dr6YdpZTOnP4rFv48lM=; b=BYZGKRaqROX/F2nZIDZ8tuagomB17c7Mq33LCKq0jXB1qYfLHd69gww6iGUY5N7X2m VLM/2CNvSxLqidZ+6k0Vx10OjNZfsp8JHAcxKUO3N9ZiBB5/VAYLwUjdtj9eZEsZKR4H a2hoaIivsrRGMK+Ye4Ea2kULiwbEmLRrr/JOchjvqYjHfK4PubI+GQ5W74og9RwcZs5j xQWkajm7j5ufe0p7Y8EmvS76TVv2IovNJUN7LF/ran1rjsOvIK4yNyR82VavhDioaW6D 83KXxrJy2xwLORpLNttLH/QblkPD1o4ZFmSh5Joz0Le+wZfQH5Rta/CSzMvH/7ly2+9n leRw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:from:references:cc:to:content-language:subject :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=KRsY6Crv/Js2LNKxAegtrhC4Dr6YdpZTOnP4rFv48lM=; b=sEIMZiMRgJ7j6sPEhLAC4JZYFxOjtIsDyTgz70H4Y+1YC5mqynSggXAln+4StpHtT3 ze925osbs7MlWkaxUjPx9kT7NGbN/xxHD7ab65PATMov/KFNg+ih8frSwk+sdTfAfePn pgekxKAonQLwVBxjCJKTvdJHEpDs6JSxgHggHRsZO4dyX6dMVP+Nxsld53xtT31vChUO ej+0WfHUlr9jskT4FzaT59oQ19xtF7YkyhbOvcSg08kkB6eVz4zCgTsxmU8OiP6iuT/j +qHTUCUra7hxnII7CTif6Mhxmct5XKAE7DlnAWSChmJFDxJtK6MDlZsmeLCQDav9OIMK nq1Q== X-Gm-Message-State: ANoB5pm+McumE8afJbKAwktTsWozRVS+A+sixibJu16IHD3Ljmo08nvs AODV2FSjYhMUMtGe/dur9fg06D7EZlY= X-Google-Smtp-Source: AA0mqf42lSZpBEEa2THVF6HyVy8oOF0U1LOI7ZpsJhomlNwL+Nz4lVypmthF3Ev2E/QBn8eyT6sg2g== X-Received: by 2002:a17:902:cf4b:b0:186:7a1d:b6ee with SMTP id e11-20020a170902cf4b00b001867a1db6eemr25126645plg.67.1669404667259; Fri, 25 Nov 2022 11:31:07 -0800 (PST) Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id om10-20020a17090b3a8a00b001fde655225fsm14952546pjb.2.2022.11.25.11.31.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 25 Nov 2022 11:31:06 -0800 (PST) Content-Type: multipart/mixed; boundary="------------2yi49WyIFL298QduVoXs699W" Message-ID: Date: Fri, 25 Nov 2022 11:31:07 -0800 MIME-Version: 1.0 Content-Language: en-US References: <8121efd5-77c3-0682-ce0f-6be9375dadd8@gmail.com> <83a65dhm7f.fsf@gnu.org> <13835614-c593-ba2d-5373-a9950f6f3dab@gmail.com> <83k03kwoy6.fsf@gnu.org> <83a64fupwv.fsf@gnu.org> From: Jim Porter In-Reply-To: <83a64fupwv.fsf@gnu.org> X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) This is a multi-part message in MIME format. --------------2yi49WyIFL298QduVoXs699W Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 11/25/2022 5:25 AM, Eli Zaretskii wrote: > Are the tests supposed to be portable? In theory, they should be. Apparently they aren't in practice. > All of them fail due to some timeout: > > Test server-tests/emacsclient/create-frame backtrace: > signal(ert-test-failed ("timed out waiting for (length= (frame-list) > ert-fail("timed out waiting for (length= (frame-list) 2) to ...") > > so this sounds like some fundamental issue common to all those tests. Hm, it looks like the emacsclient may not be starting up correctly. Could you try the attached patch? I doubt this will fix the tests, but hopefully you'll get some more-useful error messages. --------------2yi49WyIFL298QduVoXs699W Content-Type: text/plain; charset=UTF-8; name="0001-Improve-robustness-of-server.el-tests.patch" Content-Disposition: attachment; filename="0001-Improve-robustness-of-server.el-tests.patch" Content-Transfer-Encoding: base64 RnJvbSAwY2Q1MDY2NjU5NDI0NTVlNTk1YzdmNjBhZDY0M2IwYzBjOTg2NGNkIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKaW0gUG9ydGVyIDxqcG9ydGVyYnVnc0BnbWFpbC5j b20+CkRhdGU6IEZyaSwgMjUgTm92IDIwMjIgMTE6MTM6MDYgLTA4MDAKU3ViamVjdDogW1BB VENIXSBJbXByb3ZlIHJvYnVzdG5lc3Mgb2Ygc2VydmVyLmVsIHRlc3RzCgoqIHRlc3QvbGlz cC9zZXJ2ZXItdGVzdHMuZWwgKHNlcnZlci10ZXN0cy9zdGFydC1lbWFjc2NsaWVudCk6IFJl bmFtZQp0by4uLgooc2VydmVyLXRlc3RzL3N0YXJ0LWNsaWVudCk6IC4uLiB0aGlzLCBhbmQg c2V0IHRoZSBwcm9jZXNzJ3MgYnVmZmVyLgooc2VydmVyLXRlc3RzL3dpdGgtc2VydmVyKTog T3ZlcnJpZGUgJ3NlcnZlci1uYW1lJyBzbyB3ZSBkb24ndApjb25mbGljdCB3aXRoICJyZWFs IiBFbWFjcyBzZXJ2ZXJzLgooc2VydmVyLXRlc3RzL3dpdGgtY2xpZW50KTogTmV3IG1hY3Jv Li4uCihzZXJ2ZXItdGVzdHMvc2VydmVyLXN0YXJ0L3N0b3AtcHJvbXB0LXdpdGgtY2xpZW50 KQooc2VydmVyLXRlc3RzL2VtYWNzY2xpZW50L3NlcnZlci1lZGl0KQooc2VydmVyLXRlc3Rz L2VtYWNzY2xpZW50L2NyZWF0ZS1mcmFtZSkKKHNlcnZlci10ZXN0cy9lbWFjc2NsaWVudC9j cmVhdGUtZnJhbWUpOiAuLi4gdXNlIGl0Lgooc2VydmVyLXRlc3RzL3NlcnZlci1zdGFydC9z dG9wLXByb21wdC13aXRoLWNsaWVudCk6IFNpbXBsaWZ5LgotLS0KIHRlc3QvbGlzcC9zZXJ2 ZXItdGVzdHMuZWwgfCAxMTYgKysrKysrKysrKysrKysrKysrKysrKystLS0tLS0tLS0tLS0t LS0KIDEgZmlsZSBjaGFuZ2VkLCA3MSBpbnNlcnRpb25zKCspLCA0NSBkZWxldGlvbnMoLSkK CmRpZmYgLS1naXQgYS90ZXN0L2xpc3Avc2VydmVyLXRlc3RzLmVsIGIvdGVzdC9saXNwL3Nl cnZlci10ZXN0cy5lbAppbmRleCAzNzBjZjg2MTQ4Li41MmM1YWQzZGIxIDEwMDY0NAotLS0g YS90ZXN0L2xpc3Avc2VydmVyLXRlc3RzLmVsCisrKyBiL3Rlc3QvbGlzcC9zZXJ2ZXItdGVz dHMuZWwKQEAgLTIyLDE3ICsyMiwzMSBAQAogKHJlcXVpcmUgJ2VydCkKIChyZXF1aXJlICdz ZXJ2ZXIpCiAKKyhkZWZjb25zdCBzZXJ2ZXItdGVzdHMvbWF4LXdhaXQtdGltZSA1CisgICJU aGUgbWF4aW11bSB0aW1lIHRvIHdhaXQgaW4gYHNlcnZlci10ZXN0cy93YWl0LXVudGlsJywg aW4gc2Vjb25kcy4iKQorCiAoZGVmY29uc3Qgc2VydmVyLXRlc3RzL2VtYWNzY2xpZW50CiAg IChpZiBpbnN0YWxsYXRpb24tZGlyZWN0b3J5CiAgICAgICAoZXhwYW5kLWZpbGUtbmFtZSAi bGliLXNyYy9lbWFjc2NsaWVudCIgaW5zdGFsbGF0aW9uLWRpcmVjdG9yeSkKICAgICAiZW1h Y3NjbGllbnQiKQogICAiVGhlIGVtYWNzY2xpZW50IGJpbmFyeSB0byB0ZXN0LiIpCiAKLShk ZWZ1biBzZXJ2ZXItdGVzdHMvc3RhcnQtZW1hY3NjbGllbnQgKCZyZXN0IGFyZ3MpCisoZGVm bWFjcm8gc2VydmVyLXRlc3RzL3dhaXQtdW50aWwgKGZvcm0pCisgICJXYWl0IHVudGlsIEZP Uk0gaXMgbm9uLW5pbCwgdGltaW5nIG91dCBhbmQgZmFpbGluZyBpZiBpdCB0YWtlcyB0b28g bG9uZy4iCisgIGAobGV0ICgoc3RhcnQgKGN1cnJlbnQtdGltZSkpKQorICAgICh3aGlsZSAo bm90ICxmb3JtKQorICAgICAgKHdoZW4gKD4gKGZsb2F0LXRpbWUgKHRpbWUtc2luY2Ugc3Rh cnQpKQorICAgICAgICAgICAgICAgc2VydmVyLXRlc3RzL21heC13YWl0LXRpbWUpCisgICAg ICAgIChlcnQtZmFpbCAoZm9ybWF0ICJ0aW1lZCBvdXQgd2FpdGluZyBmb3IgJVMgdG8gYmUg bm9uLW5pbCIgJyxmb3JtKSkpCisgICAgICAoc2l0LWZvciAwLjEpKSkpCisKKyhkZWZ1biBz ZXJ2ZXItdGVzdHMvc3RhcnQtY2xpZW50IChhcmdzKQogICAiUnVuIGVtYWNzY2xpZW50LCBw YXNzaW5nIEFSR1MgYXMgYXJndW1lbnRzIHRvIGl0LiIKLSAgKGxldCAoKHNvY2tldC1uYW1l IChwcm9jZXNzLWdldCBzZXJ2ZXItcHJvY2VzcyA6c2VydmVyLWZpbGUpKSkKKyAgKGxldCAo KHNvY2tldC1uYW1lIChwcm9jZXNzLWdldCBzZXJ2ZXItcHJvY2VzcyA6c2VydmVyLWZpbGUp KQorICAgICAgICAoYnVmZmVyIChnZW5lcmF0ZS1uZXctYnVmZmVyICJlbWFjc2NsaWVudCIp KSkKICAgICAobWFrZS1wcm9jZXNzCiAgICAgIDpuYW1lIHNlcnZlci10ZXN0cy9lbWFjc2Ns aWVudAorICAgICA6YnVmZmVyIGJ1ZmZlcgogICAgICA6Y29tbWFuZCAoYXBwZW5kIChsaXN0 IHNlcnZlci10ZXN0cy9lbWFjc2NsaWVudAogICAgICAgICAgICAgICAgICAgICAgICAgICAg ICItLXNvY2tldC1uYW1lIiBzb2NrZXQtbmFtZSkKICAgICAgICAgICAgICAgICAgICAgICBh cmdzKSkpKQpAQCAtNDAsNyArNTQsOSBAQCBzZXJ2ZXItdGVzdHMvc3RhcnQtZW1hY3NjbGll bnQKIChkZWZtYWNybyBzZXJ2ZXItdGVzdHMvd2l0aC1zZXJ2ZXIgKCZyZXN0IGJvZHkpCiAg ICJTdGFydCB0aGUgRW1hY3Mgc2VydmVyLCBldmFsdWF0ZSBCT0RZLCBhbmQgdGhlbiBzdG9w IHRoZSBzZXJ2ZXIuIgogICAoZGVjbGFyZSAoaW5kZW50IDApKQotICBgKHByb2duCisgIDs7 IE92ZXJyaWRlIHRoZSBgc2VydmVyLW5hbWUnIHNvIHRoYXQgdGhlc2UgdGVzdHMgZG9uJ3Qg aW50ZXJmZXJlCisgIDs7IHdpdGggYW55IGV4aXN0aW5nIEVtYWNzIHNlcnZlcnMgb24gdGhl IHN5c3RlbS4KKyAgYChsZXQgKChzZXJ2ZXItbmFtZSAic2VydmVyLXRlc3RzLS1zZXJ2ZXIi KSkKICAgICAgKHNlcnZlci1zdGFydCkKICAgICAgKHVud2luZC1wcm90ZWN0CiAgICAgICAg ICAocHJvZ24gKHNob3VsZCAocHJvY2Vzc3Agc2VydmVyLXByb2Nlc3MpKQpAQCAtNTAsMTcg KzY2LDI4IEBAIHNlcnZlci10ZXN0cy93aXRoLXNlcnZlcgogICAgICAgIChzaG91bGQgKG51 bGwgc2VydmVyLXByb2Nlc3MpKQogICAgICAgIChzaG91bGQgKG51bGwgc2VydmVyLWNsaWVu dHMpKSkpKQogCi0oZGVmY29uc3Qgc2VydmVyLXRlc3RzL21heC13YWl0LXRpbWUgNQotICAi VGhlIG1heGltdW0gdGltZSB0byB3YWl0IGluIGBzZXJ2ZXItdGVzdHMvd2FpdC11bnRpbCcs IGluIHNlY29uZHMuIikKLQotKGRlZm1hY3JvIHNlcnZlci10ZXN0cy93YWl0LXVudGlsIChm b3JtKQotICAiV2FpdCB1bnRpbCBGT1JNIGlzIG5vbi1uaWwsIHRpbWluZyBvdXQgYW5kIGZh aWxpbmcgaWYgaXQgdGFrZXMgdG9vIGxvbmcuIgotICBgKGxldCAoKHN0YXJ0IChjdXJyZW50 LXRpbWUpKSkKLSAgICAod2hpbGUgKG5vdCAsZm9ybSkKLSAgICAgICh3aGVuICg+IChmbG9h dC10aW1lICh0aW1lLXNpbmNlIHN0YXJ0KSkKLSAgICAgICAgICAgICAgIHNlcnZlci10ZXN0 cy9tYXgtd2FpdC10aW1lKQotICAgICAgICAoZXJ0LWZhaWwgKGZvcm1hdCAidGltZWQgb3V0 IHdhaXRpbmcgZm9yICVTIHRvIGJlIG5vbi1uaWwiICcsZm9ybSkpKQotICAgICAgKHNpdC1m b3IgMC4xKSkpKQorKGRlZm1hY3JvIHNlcnZlci10ZXN0cy93aXRoLWNsaWVudCAoY2xpZW50 LXN5bWJvbCBhcmdzIGV4aXQtc3RhdHVzICZyZXN0IGJvZHkpCisgICJTdGFydCBhbiBFbWFj cyBjbGllbnQgd2l0aCBBUkdTIGFuZCBldmFsdWF0ZSBCT0RZLgorVGhpcyBiaW5kcyB0aGUg Y2xpZW50IHByb2Nlc3MgdG8gQ0xJRU5ULVNZTUJPTC4gIElmIEVYSVQtU1RBVFVTIGlzCitu b24tbmlsLCB0aGVuIGFmdGVyIEJPRFkgaXMgZXZhbHVhdGVkLCBtYWtlIHN1cmUgdGhlIGNs aWVudAorcHJvY2VzcydzIHN0YXR1cyBtYXRjaGVzIGl0LiIKKyAgKGRlY2xhcmUgKGluZGVu dCAzKSkKKyAgKGxldCAoKGV4aXQtc3RhdHVzLXN5bWJvbCAobWFrZS1zeW1ib2wgImV4aXQt c3RhdHVzIikpCisgICAgICAgIChzdGFydGluZy1jbGllbnQtY291bnQtc3ltYm9sIChtYWtl LXN5bWJvbCAic3RhcnRpbmctY2xpZW50LWNvdW50IikpKQorICAgIGAobGV0ICgoLHN0YXJ0 aW5nLWNsaWVudC1jb3VudC1zeW1ib2wgKGxlbmd0aCBzZXJ2ZXItY2xpZW50cykpCisgICAg ICAgICAgICgsZXhpdC1zdGF0dXMtc3ltYm9sICxleGl0LXN0YXR1cykKKyAgICAgICAgICAg KCxjbGllbnQtc3ltYm9sIChzZXJ2ZXItdGVzdHMvc3RhcnQtY2xpZW50ICxhcmdzKSkpCisg ICAgICAgKGVydC1pbmZvICgod2l0aC1jdXJyZW50LWJ1ZmZlciAocHJvY2Vzcy1idWZmZXIg LGNsaWVudC1zeW1ib2wpCisgICAgICAgICAgICAgICAgICAgIChidWZmZXItc3RyaW5nKSkK KyAgICAgICAgICAgICAgICAgIDpwcmVmaXggIk91dHB1dDogIikKKyAgICAgICAgIChzZXJ2 ZXItdGVzdHMvd2FpdC11bnRpbAorICAgICAgICAgIChvciAoPSAobGVuZ3RoIHNlcnZlci1j bGllbnRzKQorICAgICAgICAgICAgICAgICAoMSsgLHN0YXJ0aW5nLWNsaWVudC1jb3VudC1z eW1ib2wpKQorICAgICAgICAgICAgICAoZXEgKHByb2Nlc3Mtc3RhdHVzICxjbGllbnQtc3lt Ym9sKSAsZXhpdC1zdGF0dXMtc3ltYm9sKSkpCisgICAgICAgICAsQGJvZHkKKyAgICAgICAg ICh3aGVuICxleGl0LXN0YXR1cy1zeW1ib2wKKyAgICAgICAgICAgKHNlcnZlci10ZXN0cy93 YWl0LXVudGlsIChlcSAocHJvY2Vzcy1zdGF0dXMgLGNsaWVudC1zeW1ib2wpCisgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgLGV4aXQtc3RhdHVzLXN5bWJvbCkp KSkpKSkKIAogKGRlZnZhciBzZXJ2ZXItdGVzdHMvdmFyaWFibGUgbmlsKQogCkBAIC03OSw1 NyArMTA2LDU1IEBAIHNlcnZlci10ZXN0cy9zZXJ2ZXItc3RhcnQvc2V0cy1taW5vci1tb2Rl CiAoZXJ0LWRlZnRlc3Qgc2VydmVyLXRlc3RzL3NlcnZlci1zdGFydC9zdG9wLXByb21wdC13 aXRoLWNsaWVudCAoKQogICAiRW5zdXJlIHRoYXQgc3RvcHBpbmcgdGhlIHNlcnZlciBwcm9t cHRzIHdoZW4gdGhlcmUgYXJlIGNsaWVudHMuIgogICAoc2VydmVyLXRlc3RzL3dpdGgtc2Vy dmVyCi0gICAgKGxldCAoKHllcy1vci1uby1wLWNhbGxlZCBuaWwpCi0gICAgICAgICAgKGVt YWNzY2xpZW50IChzZXJ2ZXItdGVzdHMvc3RhcnQtZW1hY3NjbGllbnQgIi1jIikpKQotICAg ICAgKHNlcnZlci10ZXN0cy93YWl0LXVudGlsIChsZW5ndGg9IChmcmFtZS1saXN0KSAyKSkK LSAgICAgIChjbC1sZXRmICgoKHN5bWJvbC1mdW5jdGlvbiAneWVzLW9yLW5vLXApCi0gICAg ICAgICAgICAgICAgIChsYW1iZGEgKF9wcm9tcHQpCi0gICAgICAgICAgICAgICAgICAgKHNl dHEgeWVzLW9yLW5vLXAtY2FsbGVkIHQpKSkpCisgICAgKHNlcnZlci10ZXN0cy93aXRoLWNs aWVudCBlbWFjc2NsaWVudCAnKCItYyIpICdleGl0CisgICAgICAoc2hvdWxkIChsZW5ndGg9 IChmcmFtZS1saXN0KSAyKSkKKyAgICAgIChjbC1sZXRmKiAoKHllcy1vci1uby1wLWNhbGxl ZCBuaWwpCisgICAgICAgICAgICAgICAgICgoc3ltYm9sLWZ1bmN0aW9uICd5ZXMtb3Itbm8t cCkKKyAgICAgICAgICAgICAgICAgIChsYW1iZGEgKF9wcm9tcHQpCisgICAgICAgICAgICAg ICAgICAgIChzZXRxIHllcy1vci1uby1wLWNhbGxlZCB0KSkpKQogICAgICAgICAoc2VydmVy LXN0YXJ0IHQpCi0gICAgICAgIChzaG91bGQgeWVzLW9yLW5vLXAtY2FsbGVkKSkKLSAgICAg IChzZXJ2ZXItdGVzdHMvd2FpdC11bnRpbCAoZXEgKHByb2Nlc3Mtc3RhdHVzIGVtYWNzY2xp ZW50KSAnZXhpdCkpKSkpCisgICAgICAgIChzaG91bGQgeWVzLW9yLW5vLXAtY2FsbGVkKSkp KSkKIAogKGVydC1kZWZ0ZXN0IHNlcnZlci10ZXN0cy9zZXJ2ZXItc3RhcnQvbm8tc3RvcC1w cm9tcHQtd2l0aG91dC1jbGllbnQgKCkKICAgIkVuc3VyZSB0aGF0IHN0b3BwaW5nIHRoZSBz ZXJ2ZXIgZG9lc24ndCBwcm9tcHQgd2hlbiB0aGVyZSBhcmUgbm8gY2xpZW50cy4iCiAgIChz ZXJ2ZXItdGVzdHMvd2l0aC1zZXJ2ZXIKLSAgICAobGV0ICgoeWVzLW9yLW5vLXAtY2FsbGVk IG5pbCkpCi0gICAgICAoY2wtbGV0ZiAoKChzeW1ib2wtZnVuY3Rpb24gJ3llcy1vci1uby1w KQotICAgICAgICAgICAgICAgICAobGFtYmRhIChfcHJvbXB0KQotICAgICAgICAgICAgICAg ICAgIChzZXRxIHllcy1vci1uby1wLWNhbGxlZCB0KSkpKQotICAgICAgICAobGV0ICgoaW5o aWJpdC1tZXNzYWdlIHQpKQotICAgICAgICAgIChzZXJ2ZXItc3RhcnQgdCkpCi0gICAgICAg IChzaG91bGQtbm90IHllcy1vci1uby1wLWNhbGxlZCkpKSkpCisgICAgKGNsLWxldGYqICgo aW5oaWJpdC1tZXNzYWdlIHQpCisgICAgICAgICAgICAgICAoeWVzLW9yLW5vLXAtY2FsbGVk IG5pbCkKKyAgICAgICAgICAgICAgICgoc3ltYm9sLWZ1bmN0aW9uICd5ZXMtb3Itbm8tcCkK KyAgICAgICAgICAgICAgICAobGFtYmRhIChfcHJvbXB0KQorICAgICAgICAgICAgICAgICAg KHNldHEgeWVzLW9yLW5vLXAtY2FsbGVkIHQpKSkpCisgICAgICAoc2VydmVyLXN0YXJ0IHQp CisgICAgICAoc2hvdWxkLW5vdCB5ZXMtb3Itbm8tcC1jYWxsZWQpKSkpCiAKIChlcnQtZGVm dGVzdCBzZXJ2ZXItdGVzdHMvZW1hY3NjbGllbnQvc2VydmVyLWVkaXQgKCkKICAgIlRlc3Qg dGhhdCBjYWxsaW5nIGBzZXJ2ZXItZWRpdCcgZnJvbSBhIGNsaWVudCBidWZmZXIgZXhpdHMg dGhlIGNsaWVudC4iCiAgIChzZXJ2ZXItdGVzdHMvd2l0aC1zZXJ2ZXIKLSAgICAobGV0ICgo ZW1hY3NjbGllbnQgKHNlcnZlci10ZXN0cy9zdGFydC1lbWFjc2NsaWVudCAiZmlsZS50eHQi KSkpCisgICAgKHNlcnZlci10ZXN0cy93aXRoLWNsaWVudCBlbWFjc2NsaWVudCAnKCJmaWxl LnR4dCIpICdleGl0CiAgICAgICAoc2VydmVyLXRlc3RzL3dhaXQtdW50aWwgKGdldC1idWZm ZXIgImZpbGUudHh0IikpCiAgICAgICAoc2hvdWxkIChlcSAocHJvY2Vzcy1zdGF0dXMgZW1h Y3NjbGllbnQpICdydW4pKQotICAgICAgKHNob3VsZCAobGVuZ3RoPSBzZXJ2ZXItY2xpZW50 cyAxKSkKICAgICAgICh3aXRoLWN1cnJlbnQtYnVmZmVyICJmaWxlLnR4dCIKLSAgICAgICAg KHNlcnZlci1lZGl0KSkKLSAgICAgIChzZXJ2ZXItdGVzdHMvd2FpdC11bnRpbCAoZXEgKHBy b2Nlc3Mtc3RhdHVzIGVtYWNzY2xpZW50KSAnZXhpdCkpKSkpCisgICAgICAgIChzZXJ2ZXIt ZWRpdCkpKSkpCiAKIChlcnQtZGVmdGVzdCBzZXJ2ZXItdGVzdHMvZW1hY3NjbGllbnQvY3Jl YXRlLWZyYW1lICgpCiAgICJUZXN0IHRoYXQgXCJlbWFjc2NsaWVudCAtY1wiIGNyZWF0ZXMg YSBmcmFtZS4iCi0gIChzZXJ2ZXItdGVzdHMvd2l0aC1zZXJ2ZXIKLSAgICAobGV0ICgoZW1h Y3NjbGllbnQgKHNlcnZlci10ZXN0cy9zdGFydC1lbWFjc2NsaWVudCAiLWMiKSkpCi0gICAg ICAoc2VydmVyLXRlc3RzL3dhaXQtdW50aWwgKGxlbmd0aD0gKGZyYW1lLWxpc3QpIDIpKQor ICAobGV0ICgoc3RhcnRpbmctZnJhbWUtY291bnQgKGxlbmd0aCAoZnJhbWUtbGlzdCkpKSkK KyAgICAoc2VydmVyLXRlc3RzL3dpdGgtc2VydmVyCisgICAgICAoc2VydmVyLXRlc3RzL3dp dGgtY2xpZW50IGVtYWNzY2xpZW50ICcoIi1jIikgbmlsCisgICAgICAoc2hvdWxkIChsZW5n dGg9IChmcmFtZS1saXN0KSAoMSsgc3RhcnRpbmctZnJhbWUtY291bnQpKSkKICAgICAgIChz aG91bGQgKGVxIChwcm9jZXNzLXN0YXR1cyBlbWFjc2NsaWVudCkgJ3J1bikpCi0gICAgICAo c2hvdWxkIChsZW5ndGg9IHNlcnZlci1jbGllbnRzIDEpKQogICAgICAgKHNob3VsZCAoZXEg KGZyYW1lLXBhcmFtZXRlciAoY2FyIChmcmFtZS1saXN0KSkgJ2NsaWVudCkKICAgICAgICAg ICAgICAgICAgIChjYXIgc2VydmVyLWNsaWVudHMpKSkpKQogICA7OyBUaGUgY2xpZW50IGZy YW1lIHNob3VsZCBnbyBhd2F5IGFmdGVyIHRoZSBzZXJ2ZXIgc3RvcHMuCi0gIChzaG91bGQg KGxlbmd0aD0gKGZyYW1lLWxpc3QpIDEpKSkKKyAgICAoc2hvdWxkIChsZW5ndGg9IChmcmFt ZS1saXN0KSBzdGFydGluZy1mcmFtZS1jb3VudCkpKSkKIAogKGVydC1kZWZ0ZXN0IHNlcnZl ci10ZXN0cy9lbWFjc2NsaWVudC9ldmFsICgpCiAgICJUZXN0IHRoYXQgXCJlbWFjc2NsaWVu dCAtLWV2YWxcIiB3b3JrcyBjb3JyZWN0bHkuIgogICAoc2VydmVyLXRlc3RzL3dpdGgtc2Vy dmVyCiAgICAgKGxldCAoKHZhbHVlIChyYW5kb20pKSkKLSAgICAgIChzZXJ2ZXItdGVzdHMv c3RhcnQtZW1hY3NjbGllbnQKLSAgICAgICAiLS1ldmFsIiAoZm9ybWF0ICIoc2V0cSBzZXJ2 ZXItdGVzdHMvdmFyaWFibGUgJWQpIiB2YWx1ZSkpCi0gICAgICAoc2VydmVyLXRlc3RzL3dh aXQtdW50aWwgKGVxIHNlcnZlci10ZXN0cy92YXJpYWJsZSB2YWx1ZSkpKSkpCisgICAgICAo c2VydmVyLXRlc3RzL3dpdGgtY2xpZW50IGVtYWNzY2xpZW50CisgICAgICAgICAgKGxpc3Qg Ii0tZXZhbCIgKGZvcm1hdCAiKHNldHEgc2VydmVyLXRlc3RzL3ZhcmlhYmxlICVkKSIgdmFs dWUpKQorICAgICAgICAgICdleGl0CisgICAgICAgIChzaG91bGQgKD0gc2VydmVyLXRlc3Rz L3ZhcmlhYmxlIHZhbHVlKSkpKSkpCiAKIChlcnQtZGVmdGVzdCBzZXJ2ZXItdGVzdHMvc2Vy dmVyLWZvcmNlLXN0b3Ava2VlcHMtZnJhbWVzICgpCiAgICJFbnN1cmUgdGhhdCBgc2VydmVy LWZvcmNlLXN0b3AnIGRvZXNuJ3QgZGVsZXRlIGZyYW1lcy4gIFNlZSBidWcjNTg4NzcuCkBA IC0xMzksMTIgKzE2NCwxMyBAQCBzZXJ2ZXItdGVzdHMvc2VydmVyLWZvcmNlLXN0b3Ava2Vl cHMtZnJhbWVzCiB0ZXN0cyB0aGF0IGBzZXJ2ZXItZm9yY2Utc3RvcCcgZG9lc24ndCBkZWxl dGUgZnJhbWVzIChhbmQgZXZlbgogdGhlbiwgcmVxdWlyZXMgYSBmZXcgdHJpY2tzIHRvIHJ1 biBhcyBhIHJlZ3Jlc3Npb24gdGVzdCkuICBTbwogbG9uZyBhcyB0aGlzIHdvcmtzLCB0aGUg cHJvYmxlbSBpbiBidWcjNTg4Nzcgc2hvdWxkbid0IG9jY3VyLiIKLSAgKGxldCAodGVybWlu YWwpCisgIChsZXQgKChzdGFydGluZy1mcmFtZS1jb3VudCAobGVuZ3RoIChmcmFtZS1saXN0 KSkpCisgICAgICAgIHRlcm1pbmFsKQogICAgICh1bndpbmQtcHJvdGVjdAogICAgICAgICAo c2VydmVyLXRlc3RzL3dpdGgtc2VydmVyCi0gICAgICAgICAgKGxldCAoKGVtYWNzY2xpZW50 IChzZXJ2ZXItdGVzdHMvc3RhcnQtZW1hY3NjbGllbnQgIi1jIikpKQotICAgICAgICAgICAg KHNlcnZlci10ZXN0cy93YWl0LXVudGlsIChsZW5ndGg9IChmcmFtZS1saXN0KSAyKSkKKyAg ICAgICAgICAoc2VydmVyLXRlc3RzL3dpdGgtY2xpZW50IGVtYWNzY2xpZW50ICcoIi1jIikg J2V4aXQKICAgICAgICAgICAgIChzaG91bGQgKGVxIChwcm9jZXNzLXN0YXR1cyBlbWFjc2Ns aWVudCkgJ3J1bikpCisgICAgICAgICAgICAoc2hvdWxkIChsZW5ndGg9IChmcmFtZS1saXN0 KSAoMSsgc3RhcnRpbmctZnJhbWUtY291bnQpKSkKIAogICAgICAgICAgICAgOzsgRG9uJ3Qg ZGVsZXRlIHRoZSB0ZXJtaW5hbCBmb3IgdGhlIGNsaWVudDsgdGhhdCB3b3VsZAogICAgICAg ICAgICAgOzsga2lsbCBpdHMgZnJhbWUgaW1tZWRpYXRlbHkgdG9vLiAgKFRoaXMgaXMgb25s eSBhbiBpc3N1ZQpAQCAtMTU5LDcgKzE4NSw3IEBAIHNlcnZlci10ZXN0cy9zZXJ2ZXItZm9y Y2Utc3RvcC9rZWVwcy1mcmFtZXMKIAogICAgICAgICAgICAgKHNlcnZlci1mb3JjZS1zdG9w KSkKICAgICAgICAgICA7OyBFbnN1cmUgd2UgZGlkbid0IGRlbGV0ZSB0aGUgZnJhbWUuCi0g ICAgICAgICAgKHNob3VsZCAobGVuZ3RoPSAoZnJhbWUtbGlzdCkgMikpKQorICAgICAgICAg IChzaG91bGQgKGxlbmd0aD0gKGZyYW1lLWxpc3QpICgxKyBzdGFydGluZy1mcmFtZS1jb3Vu dCkpKSkKICAgICAgIDs7IENsZWFuIHVwIGFmdGVyIG91cnNlbHZlcyBhbmQgZGVsZXRlIHRo ZSB0ZXJtaW5hbC4KICAgICAgICh3aGVuIChhbmQgdGVybWluYWwKICAgICAgICAgICAgICAg ICAgKGVxICh0ZXJtaW5hbC1saXZlLXAgdGVybWluYWwpIHQpCi0tIAoyLjI1LjEKCg== --------------2yi49WyIFL298QduVoXs699W-- From unknown Sat Jun 14 04:55:23 2025 X-Loop: help-debbugs@gnu.org Subject: bug#58877: 29.0.50; [PATCH] When killing Emacs from a client frame with no other frames, Emacs shows a useless error prompt Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 25 Nov 2022 20:19:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58877 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Jim Porter Cc: 58877@debbugs.gnu.org Received: via spool by 58877-submit@debbugs.gnu.org id=B58877.16694075238891 (code B ref 58877); Fri, 25 Nov 2022 20:19:02 +0000 Received: (at 58877) by debbugs.gnu.org; 25 Nov 2022 20:18:43 +0000 Received: from localhost ([127.0.0.1]:37270 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oyf9m-0002JK-Op for submit@debbugs.gnu.org; Fri, 25 Nov 2022 15:18:43 -0500 Received: from eggs.gnu.org ([209.51.188.92]:53000) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oyf9j-0002J6-5Q for 58877@debbugs.gnu.org; Fri, 25 Nov 2022 15:18:40 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oyf9d-0004yK-Ul; Fri, 25 Nov 2022 15:18:33 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=bDMh6Vt/0LtNNnBrP3jrXXChBfHcPrb+hYLJpntNDQU=; b=EetR370p/y5d xYV/Yf3joty+jIh9+6nE5FaNgiV8ITuQfoO14qhT+ebFM9Z5CL6z+dQYlmuaUC7tmSXDnLwH3kmnF l4P1zJReXWNfwfazQaoYo+ZuMWeKMcdU2P/x/ZbQoThWX0ok6K6ADhwhvvg9D++DTG/mXb5IYoT13 0rDyqJxk5STJpnx8NQE2IC3LIEvjaA8QLjpX5Xt4jeFcc47GNVQ+EMBLNuvtqEEKX2Xhd2LY5KNfi zNvD1tfl8+CPe/1V2PgdP1K1i3PWiN66/mDqSO0vVacp5ANep2jUhNvFZE/hAEj4gPsmgfN5sBsCV wIMgF7aCAj/65PFz8ZaJ5w==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oyf9d-0005zF-ED; Fri, 25 Nov 2022 15:18:33 -0500 Date: Fri, 25 Nov 2022 22:18:56 +0200 Message-Id: <83wn7iu6rz.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: (message from Jim Porter on Fri, 25 Nov 2022 11:31:07 -0800) References: <8121efd5-77c3-0682-ce0f-6be9375dadd8@gmail.com> <83a65dhm7f.fsf@gnu.org> <13835614-c593-ba2d-5373-a9950f6f3dab@gmail.com> <83k03kwoy6.fsf@gnu.org> <83a64fupwv.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Fri, 25 Nov 2022 11:31:07 -0800 > Cc: 58877@debbugs.gnu.org > From: Jim Porter > > Hm, it looks like the emacsclient may not be starting up correctly. > Could you try the attached patch? I doubt this will fix the tests, but > hopefully you'll get some more-useful error messages. Here are the failure info from each failed test after this patch: Test server-tests/emacsclient/create-frame condition: Output: (ert-test-failed "timed out waiting for (or (= (length server-clients) (1+ starting-client-count)) (eq (process-status emacsclient) exit-status)) to be non-nil") FAILED 1/7 server-tests/emacsclient/create-frame (5.062500 sec) at lisp/server-tests.el:138 Test server-tests/emacsclient/eval condition: Output: (wrong-type-argument number-or-marker-p nil) FAILED 2/7 server-tests/emacsclient/eval (0.109375 sec) at lisp/server-tests.el:150 Test server-tests/emacsclient/server-edit condition: Output: (ert-test-failed "timed out waiting for (get-buffer \"file.txt\") to be non-nil") FAILED 3/7 server-tests/emacsclient/server-edit (5.156250 sec) at lisp/server-tests.el:129 Test server-tests/server-force-stop/keeps-frames condition: Output: (ert-test-failed ((should (eq (process-status emacsclient) 'run)) :form (eq exit run) :value nil)) FAILED 4/7 server-tests/server-force-stop/keeps-frames (0.109375 sec) at lisp/server-tests.el:159 Test server-tests/server-start/stop-prompt-with-client condition: Output: (ert-test-failed ((should (length= (frame-list) 2)) :form (length= (#) 2) :value nil)) FAILED 7/7 server-tests/server-start/stop-prompt-with-client (0.125000 sec) at lisp/server-tests.el:106 From unknown Sat Jun 14 04:55:23 2025 X-Loop: help-debbugs@gnu.org Subject: bug#58877: 29.0.50; [PATCH] When killing Emacs from a client frame with no other frames, Emacs shows a useless error prompt Resent-From: Jim Porter Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 25 Nov 2022 20:58:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58877 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Eli Zaretskii Cc: 58877@debbugs.gnu.org Received: via spool by 58877-submit@debbugs.gnu.org id=B58877.166940987112537 (code B ref 58877); Fri, 25 Nov 2022 20:58:01 +0000 Received: (at 58877) by debbugs.gnu.org; 25 Nov 2022 20:57:51 +0000 Received: from localhost ([127.0.0.1]:37317 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oyfle-0003G8-9e for submit@debbugs.gnu.org; Fri, 25 Nov 2022 15:57:51 -0500 Received: from mail-pl1-f172.google.com ([209.85.214.172]:45888) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oyflZ-0003Fs-VQ for 58877@debbugs.gnu.org; Fri, 25 Nov 2022 15:57:48 -0500 Received: by mail-pl1-f172.google.com with SMTP id w23so4916080ply.12 for <58877@debbugs.gnu.org>; Fri, 25 Nov 2022 12:57:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:from:references:cc:to:content-language:subject :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=t7iZAINPoDGyrME9G3LepnuRwVL3q68DL2qYBzUW3BI=; b=Au6b8KNcmwcDL1hg+GeKEDZbVIGiKrvo7ycQJhdIm5dc/zxb27M7EaKAm63nSNNaB6 p17mFoLcqov3MUchaLfjHK7sv+xDx6RHdkxyPP5xv0D9JhkGW+Zy+8IqN3RNuSlpsQGq Gq0i66eSB4xClBwHb1C4R3Who8g+4giS0an1yDi1lGW36A6NONzcwtLoooDNLfKxihg4 jqAp5mgUW3+lZNq0B/qPI27KCZeZzSczI3J8GPG7P9L0u5Tg67+Fhb2l0X3LessQUIVj c3K4svsGn5nrQvwYTmcnF99oqQ5UYNBN3yIQuIdNqJFfYFGh9dwAZtM1bl07q6oHDetE 9UBg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:from:references:cc:to:content-language:subject :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=t7iZAINPoDGyrME9G3LepnuRwVL3q68DL2qYBzUW3BI=; b=m7S7ytw+6Mdq6LIpN44KwNqZ9NLpeW8LSUW2TFblXsSNQDG5ZID2CWh4D5eEYfdiAM te437Gluh61TDLqXxisKkC/3yb6F8YPY/nSB+SLIKx/JjOJiBJlkogMItI4/kMmGxI0i htswSVRf1viSbuBIKmqizwjAqv19yj0Km8sDoeJg+/2fJo7/pdkmMP2WtDMZzpm7U0RQ vP+PCM7NATKJQuMu/SXjF+3+8qKTCqYmgrqggI92fOIP2voaQpyLuetkTTm731msC93H jv8F7gJLsPiNEYZOoqNtMZQloXO1m7T4kkUAl4oYx28cxKH6j/VBs1S+IPMYt+QFqHqU nkdA== X-Gm-Message-State: ANoB5pn526gtsor2pshwll51S6Qlrj4slHZY0OxO0fodKw628UUIkTRB nRG74Auv8y7HFTW3SEu7fXs= X-Google-Smtp-Source: AA0mqf4dEFu7OHFFiZfGMdbKIkp37Ro+RjWugQWebgmy5RpDKxbfQp3oabhM9fHEWM4OQLW3YLp1Ag== X-Received: by 2002:a17:90a:b285:b0:216:ab1b:98d0 with SMTP id c5-20020a17090ab28500b00216ab1b98d0mr48378858pjr.67.1669409859880; Fri, 25 Nov 2022 12:57:39 -0800 (PST) Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id c27-20020a631c5b000000b004582e25a595sm2978011pgm.41.2022.11.25.12.57.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 25 Nov 2022 12:57:38 -0800 (PST) Content-Type: multipart/mixed; boundary="------------nk9HKawX5D0prOKEgKyhkebe" Message-ID: Date: Fri, 25 Nov 2022 12:57:37 -0800 MIME-Version: 1.0 Content-Language: en-US References: <8121efd5-77c3-0682-ce0f-6be9375dadd8@gmail.com> <83a65dhm7f.fsf@gnu.org> <13835614-c593-ba2d-5373-a9950f6f3dab@gmail.com> <83k03kwoy6.fsf@gnu.org> <83a64fupwv.fsf@gnu.org> <83wn7iu6rz.fsf@gnu.org> From: Jim Porter In-Reply-To: <83wn7iu6rz.fsf@gnu.org> X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) This is a multi-part message in MIME format. --------------nk9HKawX5D0prOKEgKyhkebe Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 11/25/2022 12:18 PM, Eli Zaretskii wrote: >> Date: Fri, 25 Nov 2022 11:31:07 -0800 >> Cc: 58877@debbugs.gnu.org >> From: Jim Porter >> >> Hm, it looks like the emacsclient may not be starting up correctly. >> Could you try the attached patch? I doubt this will fix the tests, but >> hopefully you'll get some more-useful error messages. > > Here are the failure info from each failed test after this patch: > > Test server-tests/emacsclient/create-frame condition: > Output: > (ert-test-failed "timed out waiting for (or (= (length server-clients) (1+ starting-client-count)) (eq (process-status emacsclient) exit-status)) to be non-nil") > FAILED 1/7 server-tests/emacsclient/create-frame (5.062500 sec) at lisp/server-tests.el:138 Oops, sorry about that. I didn't realize until now that 'ert-info' computes its message immediately, rather than at the time of printing the info.[1] I've added a bit of code to ert.el to support this case, which will hopefully produce better output. I also added the server.el logs to the output of test failures. Note that they'll print the environment variables of the client, so it's probably worth skimming over them before posting just in case there are any secrets in there. [1] Maybe there's a better way to do this, but it should at least work for the time being. I'm open to alternatives here so that these tests are as informative as possible when they fail. --------------nk9HKawX5D0prOKEgKyhkebe Content-Type: text/plain; charset=UTF-8; name="0001-Improve-robustness-of-server.el-tests.patch" Content-Disposition: attachment; filename="0001-Improve-robustness-of-server.el-tests.patch" Content-Transfer-Encoding: base64 RnJvbSA3YTM0YjMxYzE3Yjk1NjMwNTFjNTRkMGZkNzI4OWI0NGY5ZTM2ZjEyIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKaW0gUG9ydGVyIDxqcG9ydGVyYnVnc0BnbWFpbC5j b20+CkRhdGU6IEZyaSwgMjUgTm92IDIwMjIgMTE6MTM6MDYgLTA4MDAKU3ViamVjdDogW1BB VENIXSBJbXByb3ZlIHJvYnVzdG5lc3Mgb2Ygc2VydmVyLmVsIHRlc3RzCgoqIGxpc3AvZW1h Y3MtbGlzcC9lcnQuZWwgKGVydC0taW5zZXJ0LWluZm9zKTogQWxsb3cgJ21lc3NhZ2UnIHRv IGJlIGEKZnVuY3Rpb24gdGhhdCBpcyBjYWxsZWQgd2hlbiBpbnNlcnRpbmcgdGhlIGluZm8u CihlcnQtaW5mbyk6IFVwZGF0ZSBkb2NzdHJpbmcgdG8gZGVzY3JpYmUgdXNpbmcgYSBmdW5j dGlvbiBmb3IKTUVTU0FHRS1GT1JNLgoKKiBsaXNwL3NlcnZlci5lbCAoc2VydmVyLXN0YXJ0 KTogTG9nIHdoZW4gdGhlIHNlcnZlciBpcyBzdGFydGluZy4KCiogdGVzdC9saXNwL3NlcnZl ci10ZXN0cy5lbCAoc2VydmVyLXRlc3RzL3N0YXJ0LWVtYWNzY2xpZW50KTogUmVuYW1lCnRv Li4uCihzZXJ2ZXItdGVzdHMvc3RhcnQtY2xpZW50KTogLi4uIHRoaXMsIGFuZCBzZXQgdGhl IHByb2Nlc3MncyBidWZmZXIuCihzZXJ2ZXItdGVzdHMvd2l0aC1zZXJ2ZXIpOiBPdmVycmlk ZSAnc2VydmVyLW5hbWUnIHNvIHdlIGRvbid0CmNvbmZsaWN0IHdpdGggInJlYWwiIEVtYWNz IHNlcnZlcnMuCihzZXJ2ZXItdGVzdHMvd2l0aC1jbGllbnQpOiBOZXcgbWFjcm8uLi4KKHNl cnZlci10ZXN0cy9zZXJ2ZXItc3RhcnQvc3RvcC1wcm9tcHQtd2l0aC1jbGllbnQpCihzZXJ2 ZXItdGVzdHMvZW1hY3NjbGllbnQvc2VydmVyLWVkaXQpCihzZXJ2ZXItdGVzdHMvZW1hY3Nj bGllbnQvY3JlYXRlLWZyYW1lKQooc2VydmVyLXRlc3RzL2VtYWNzY2xpZW50L2NyZWF0ZS1m cmFtZSk6IC4uLiB1c2UgaXQuCihzZXJ2ZXItdGVzdHMvc2VydmVyLXN0YXJ0L3N0b3AtcHJv bXB0LXdpdGgtY2xpZW50KTogU2ltcGxpZnkuCi0tLQogbGlzcC9lbWFjcy1saXNwL2VydC5l bCAgICB8ICAgOSArKy0KIGxpc3Avc2VydmVyLmVsICAgICAgICAgICAgfCAgIDEgKwogdGVz dC9saXNwL3NlcnZlci10ZXN0cy5lbCB8IDEzOCArKysrKysrKysrKysrKysrKysrKysrKy0t LS0tLS0tLS0tLS0tLQogMyBmaWxlcyBjaGFuZ2VkLCA5MyBpbnNlcnRpb25zKCspLCA1NSBk ZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9saXNwL2VtYWNzLWxpc3AvZXJ0LmVsIGIvbGlz cC9lbWFjcy1saXNwL2VydC5lbAppbmRleCBjMjVhZGUyMmQ2Li42N2NiZTYyNTM4IDEwMDY0 NAotLS0gYS9saXNwL2VtYWNzLWxpc3AvZXJ0LmVsCisrKyBiL2xpc3AvZW1hY3MtbGlzcC9l cnQuZWwKQEAgLTY3Myw4ICs2NzMsMTEgQEAgZXJ0LWluZm8KIAogVG8gYmUgdXNlZCB3aXRo aW4gRVJUIHRlc3RzLiAgTUVTU0FHRS1GT1JNIHNob3VsZCBldmFsdWF0ZSB0byBhCiBzdHJp bmcgdGhhdCB3aWxsIGJlIGRpc3BsYXllZCB0b2dldGhlciB3aXRoIHRoZSB0ZXN0IHJlc3Vs dCBpZgotdGhlIHRlc3QgZmFpbHMuICBQUkVGSVgtRk9STSBzaG91bGQgZXZhbHVhdGUgdG8g YSBzdHJpbmcgYXMgd2VsbAotYW5kIGlzIGRpc3BsYXllZCBpbiBmcm9udCBvZiB0aGUgdmFs dWUgb2YgTUVTU0FHRS1GT1JNLiIKK3RoZSB0ZXN0IGZhaWxzLiAgTUVTU0FHRS1GT1JNIGNh biBhbHNvIGV2YWx1YXRlIHRvIGEgZnVuY3Rpb247IGluCit0aGlzIGNhc2UsIGl0IHdpbGwg YmUgY2FsbGVkIHdoZW4gZGlzcGxheWluZyB0aGUgaW5mby4KKworUFJFRklYLUZPUk0gc2hv dWxkIGV2YWx1YXRlIHRvIGEgc3RyaW5nIGFzIHdlbGwgYW5kIGlzIGRpc3BsYXllZAoraW4g ZnJvbnQgb2YgdGhlIHZhbHVlIG9mIE1FU1NBR0UtRk9STS4iCiAgIChkZWNsYXJlIChkZWJ1 ZyAoKGZvcm0gJnJlc3QgW3NleHAgZm9ybV0pIGJvZHkpKQogCSAgIChpbmRlbnQgMSkpCiAg IGAobGV0ICgoZXJ0LS1pbmZvcyAoY29ucyAoY29ucyAscHJlZml4LWZvcm0gLG1lc3NhZ2Ut Zm9ybSkgZXJ0LS1pbmZvcykpKQpAQCAtMTM1Miw2ICsxMzU1LDggQEAgZXJ0LS1pbnNlcnQt aW5mb3MKICAgICAgICAgICAgIChlbmQgbmlsKSkKICAgICAgICAgKHVud2luZC1wcm90ZWN0 CiAgICAgICAgICAgICAocHJvZ24KKyAgICAgICAgICAgICAgKHdoZW4gKGZ1bmN0aW9ucCBt ZXNzYWdlKQorICAgICAgICAgICAgICAgIChzZXRxIG1lc3NhZ2UgKGZ1bmNhbGwgbWVzc2Fn ZSkpKQogICAgICAgICAgICAgICAoaW5zZXJ0IG1lc3NhZ2UgIlxuIikKICAgICAgICAgICAg ICAgKHNldHEgZW5kIChwb2ludC1tYXJrZXIpKQogICAgICAgICAgICAgICAoZ290by1jaGFy IGJlZ2luKQpkaWZmIC0tZ2l0IGEvbGlzcC9zZXJ2ZXIuZWwgYi9saXNwL3NlcnZlci5lbApp bmRleCBiZWI0Njg1M2I3Li4yMTAyZjg1NjliIDEwMDY0NAotLS0gYS9saXNwL3NlcnZlci5l bAorKysgYi9saXNwL3NlcnZlci5lbApAQCAtNzU2LDYgKzc1Niw3IEBAIHNlcnZlci1zdGFy dAogCQkJICAgICAgIDpzZXJ2aWNlIHNlcnZlci1maWxlCiAJCQkgICAgICAgOnBsaXN0ICco OmF1dGhlbnRpY2F0ZWQgdCkpKSkpCiAJICAodW5sZXNzIHNlcnZlci1wcm9jZXNzIChlcnJv ciAiQ291bGQgbm90IHN0YXJ0IHNlcnZlciBwcm9jZXNzIikpCisgICAgICAgICAgKHNlcnZl ci1sb2cgIlN0YXJ0aW5nIHNlcnZlciIpCiAJICAocHJvY2Vzcy1wdXQgc2VydmVyLXByb2Nl c3MgOnNlcnZlci1maWxlIHNlcnZlci1maWxlKQogICAgICAgICAgIChzZXRxIHNlcnZlci1t b2RlIHQpCiAgICAgICAgICAgKHB1c2ggJ3NlcnZlci1tb2RlIGdsb2JhbC1taW5vci1tb2Rl cykKZGlmZiAtLWdpdCBhL3Rlc3QvbGlzcC9zZXJ2ZXItdGVzdHMuZWwgYi90ZXN0L2xpc3Av c2VydmVyLXRlc3RzLmVsCmluZGV4IDM3MGNmODYxNDguLmJiMDdmNjljMjggMTAwNjQ0Ci0t LSBhL3Rlc3QvbGlzcC9zZXJ2ZXItdGVzdHMuZWwKKysrIGIvdGVzdC9saXNwL3NlcnZlci10 ZXN0cy5lbApAQCAtMjIsMTcgKzIyLDMxIEBACiAocmVxdWlyZSAnZXJ0KQogKHJlcXVpcmUg J3NlcnZlcikKIAorKGRlZmNvbnN0IHNlcnZlci10ZXN0cy9tYXgtd2FpdC10aW1lIDUKKyAg IlRoZSBtYXhpbXVtIHRpbWUgdG8gd2FpdCBpbiBgc2VydmVyLXRlc3RzL3dhaXQtdW50aWwn LCBpbiBzZWNvbmRzLiIpCisKIChkZWZjb25zdCBzZXJ2ZXItdGVzdHMvZW1hY3NjbGllbnQK ICAgKGlmIGluc3RhbGxhdGlvbi1kaXJlY3RvcnkKICAgICAgIChleHBhbmQtZmlsZS1uYW1l ICJsaWItc3JjL2VtYWNzY2xpZW50IiBpbnN0YWxsYXRpb24tZGlyZWN0b3J5KQogICAgICJl bWFjc2NsaWVudCIpCiAgICJUaGUgZW1hY3NjbGllbnQgYmluYXJ5IHRvIHRlc3QuIikKIAot KGRlZnVuIHNlcnZlci10ZXN0cy9zdGFydC1lbWFjc2NsaWVudCAoJnJlc3QgYXJncykKKyhk ZWZtYWNybyBzZXJ2ZXItdGVzdHMvd2FpdC11bnRpbCAoZm9ybSkKKyAgIldhaXQgdW50aWwg Rk9STSBpcyBub24tbmlsLCB0aW1pbmcgb3V0IGFuZCBmYWlsaW5nIGlmIGl0IHRha2VzIHRv byBsb25nLiIKKyAgYChsZXQgKChzdGFydCAoY3VycmVudC10aW1lKSkpCisgICAgKHdoaWxl IChub3QgLGZvcm0pCisgICAgICAod2hlbiAoPiAoZmxvYXQtdGltZSAodGltZS1zaW5jZSBz dGFydCkpCisgICAgICAgICAgICAgICBzZXJ2ZXItdGVzdHMvbWF4LXdhaXQtdGltZSkKKyAg ICAgICAgKGVydC1mYWlsIChmb3JtYXQgInRpbWVkIG91dCB3YWl0aW5nIGZvciAlUyB0byBi ZSBub24tbmlsIiAnLGZvcm0pKSkKKyAgICAgIChzaXQtZm9yIDAuMSkpKSkKKworKGRlZnVu IHNlcnZlci10ZXN0cy9zdGFydC1jbGllbnQgKGFyZ3MpCiAgICJSdW4gZW1hY3NjbGllbnQs IHBhc3NpbmcgQVJHUyBhcyBhcmd1bWVudHMgdG8gaXQuIgotICAobGV0ICgoc29ja2V0LW5h bWUgKHByb2Nlc3MtZ2V0IHNlcnZlci1wcm9jZXNzIDpzZXJ2ZXItZmlsZSkpKQorICAobGV0 ICgoc29ja2V0LW5hbWUgKHByb2Nlc3MtZ2V0IHNlcnZlci1wcm9jZXNzIDpzZXJ2ZXItZmls ZSkpCisgICAgICAgIChidWZmZXIgKGdlbmVyYXRlLW5ldy1idWZmZXIgImVtYWNzY2xpZW50 IikpKQogICAgIChtYWtlLXByb2Nlc3MKICAgICAgOm5hbWUgc2VydmVyLXRlc3RzL2VtYWNz Y2xpZW50CisgICAgIDpidWZmZXIgYnVmZmVyCiAgICAgIDpjb21tYW5kIChhcHBlbmQgKGxp c3Qgc2VydmVyLXRlc3RzL2VtYWNzY2xpZW50CiAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgIi0tc29ja2V0LW5hbWUiIHNvY2tldC1uYW1lKQogICAgICAgICAgICAgICAgICAgICAg IGFyZ3MpKSkpCkBAIC00MCwyNyArNTQsNDYgQEAgc2VydmVyLXRlc3RzL3N0YXJ0LWVtYWNz Y2xpZW50CiAoZGVmbWFjcm8gc2VydmVyLXRlc3RzL3dpdGgtc2VydmVyICgmcmVzdCBib2R5 KQogICAiU3RhcnQgdGhlIEVtYWNzIHNlcnZlciwgZXZhbHVhdGUgQk9EWSwgYW5kIHRoZW4g c3RvcCB0aGUgc2VydmVyLiIKICAgKGRlY2xhcmUgKGluZGVudCAwKSkKLSAgYChwcm9nbgor ICA7OyBPdmVycmlkZSB0aGUgYHNlcnZlci1uYW1lJyBzbyB0aGF0IHRoZXNlIHRlc3RzIGRv bid0IGludGVyZmVyZQorICA7OyB3aXRoIGFueSBleGlzdGluZyBFbWFjcyBzZXJ2ZXJzIG9u IHRoZSBzeXN0ZW0uCisgIGAobGV0ICgoc2VydmVyLW5hbWUgInNlcnZlci10ZXN0cy0tc2Vy dmVyIikKKyAgICAgICAgIChzZXJ2ZXItbG9nIHQpKQogICAgICAoc2VydmVyLXN0YXJ0KQot ICAgICAodW53aW5kLXByb3RlY3QKLSAgICAgICAgIChwcm9nbiAoc2hvdWxkIChwcm9jZXNz cCBzZXJ2ZXItcHJvY2VzcykpCi0gICAgICAgICAgICAgICAgLEBib2R5KQotICAgICAgIChs ZXQgKChpbmhpYml0LW1lc3NhZ2UgdCkpCi0gICAgICAgICAoc2VydmVyLXN0YXJ0IHQgdCkp Ci0gICAgICAgKHNob3VsZCAobnVsbCBzZXJ2ZXItcHJvY2VzcykpCi0gICAgICAgKHNob3Vs ZCAobnVsbCBzZXJ2ZXItY2xpZW50cykpKSkpCi0KLShkZWZjb25zdCBzZXJ2ZXItdGVzdHMv bWF4LXdhaXQtdGltZSA1Ci0gICJUaGUgbWF4aW11bSB0aW1lIHRvIHdhaXQgaW4gYHNlcnZl ci10ZXN0cy93YWl0LXVudGlsJywgaW4gc2Vjb25kcy4iKQotCi0oZGVmbWFjcm8gc2VydmVy LXRlc3RzL3dhaXQtdW50aWwgKGZvcm0pCi0gICJXYWl0IHVudGlsIEZPUk0gaXMgbm9uLW5p bCwgdGltaW5nIG91dCBhbmQgZmFpbGluZyBpZiBpdCB0YWtlcyB0b28gbG9uZy4iCi0gIGAo bGV0ICgoc3RhcnQgKGN1cnJlbnQtdGltZSkpKQotICAgICh3aGlsZSAobm90ICxmb3JtKQot ICAgICAgKHdoZW4gKD4gKGZsb2F0LXRpbWUgKHRpbWUtc2luY2Ugc3RhcnQpKQotICAgICAg ICAgICAgICAgc2VydmVyLXRlc3RzL21heC13YWl0LXRpbWUpCi0gICAgICAgIChlcnQtZmFp bCAoZm9ybWF0ICJ0aW1lZCBvdXQgd2FpdGluZyBmb3IgJVMgdG8gYmUgbm9uLW5pbCIgJyxm b3JtKSkpCi0gICAgICAoc2l0LWZvciAwLjEpKSkpCisgICAgIChlcnQtaW5mbyAoKGxhbWJk YSAoKQorICAgICAgICAgICAgICAgICAgKHdpdGgtY3VycmVudC1idWZmZXIgKGdldC1idWZm ZXItY3JlYXRlIHNlcnZlci1idWZmZXIpCisgICAgICAgICAgICAgICAgICAgIChidWZmZXIt c3RyaW5nKSkpCisgICAgICAgICAgICAgICAgOnByZWZpeCAiU2VydmVyIGxvZ3M6ICIpCisg ICAgICAgKHVud2luZC1wcm90ZWN0CisgICAgICAgICAgIChwcm9nbiAoc2hvdWxkIChwcm9j ZXNzcCBzZXJ2ZXItcHJvY2VzcykpCisgICAgICAgICAgICAgICAgICAsQGJvZHkpCisgICAg ICAgICAobGV0ICgoaW5oaWJpdC1tZXNzYWdlIHQpKQorICAgICAgICAgICAoc2VydmVyLXN0 YXJ0IHQgdCkpCisgICAgICAgICAoc2hvdWxkIChudWxsIHNlcnZlci1wcm9jZXNzKSkKKyAg ICAgICAgIChzaG91bGQgKG51bGwgc2VydmVyLWNsaWVudHMpKSkpKSkKKworKGRlZm1hY3Jv IHNlcnZlci10ZXN0cy93aXRoLWNsaWVudCAoY2xpZW50LXN5bWJvbCBhcmdzIGV4aXQtc3Rh dHVzICZyZXN0IGJvZHkpCisgICJTdGFydCBhbiBFbWFjcyBjbGllbnQgd2l0aCBBUkdTIGFu ZCBldmFsdWF0ZSBCT0RZLgorVGhpcyBiaW5kcyB0aGUgY2xpZW50IHByb2Nlc3MgdG8gQ0xJ RU5ULVNZTUJPTC4gIElmIEVYSVQtU1RBVFVTIGlzCitub24tbmlsLCB0aGVuIGFmdGVyIEJP RFkgaXMgZXZhbHVhdGVkLCBtYWtlIHN1cmUgdGhlIGNsaWVudAorcHJvY2VzcydzIHN0YXR1 cyBtYXRjaGVzIGl0LiIKKyAgKGRlY2xhcmUgKGluZGVudCAzKSkKKyAgKGxldCAoKGV4aXQt c3RhdHVzLXN5bWJvbCAobWFrZS1zeW1ib2wgImV4aXQtc3RhdHVzIikpCisgICAgICAgIChz dGFydGluZy1jbGllbnQtY291bnQtc3ltYm9sIChtYWtlLXN5bWJvbCAic3RhcnRpbmctY2xp ZW50LWNvdW50IikpKQorICAgIGAobGV0ICgoLHN0YXJ0aW5nLWNsaWVudC1jb3VudC1zeW1i b2wgKGxlbmd0aCBzZXJ2ZXItY2xpZW50cykpCisgICAgICAgICAgICgsZXhpdC1zdGF0dXMt c3ltYm9sICxleGl0LXN0YXR1cykKKyAgICAgICAgICAgKCxjbGllbnQtc3ltYm9sIChzZXJ2 ZXItdGVzdHMvc3RhcnQtY2xpZW50ICxhcmdzKSkpCisgICAgICAgKGVydC1pbmZvICgobGFt YmRhICgpCisgICAgICAgICAgICAgICAgICAgICh3aXRoLWN1cnJlbnQtYnVmZmVyIChwcm9j ZXNzLWJ1ZmZlciAsY2xpZW50LXN5bWJvbCkKKyAgICAgICAgICAgICAgICAgICAgICAoYnVm ZmVyLXN0cmluZykpKQorICAgICAgICAgICAgICAgICAgOnByZWZpeCAiQ2xpZW50IG91dHB1 dDogIikKKyAgICAgICAgIChzZXJ2ZXItdGVzdHMvd2FpdC11bnRpbAorICAgICAgICAgIChv ciAoPSAobGVuZ3RoIHNlcnZlci1jbGllbnRzKQorICAgICAgICAgICAgICAgICAoMSsgLHN0 YXJ0aW5nLWNsaWVudC1jb3VudC1zeW1ib2wpKQorICAgICAgICAgICAgICAoZXEgKHByb2Nl c3Mtc3RhdHVzICxjbGllbnQtc3ltYm9sKSAsZXhpdC1zdGF0dXMtc3ltYm9sKSkpCisgICAg ICAgICAsQGJvZHkKKyAgICAgICAgICh3aGVuICxleGl0LXN0YXR1cy1zeW1ib2wKKyAgICAg ICAgICAgKHNlcnZlci10ZXN0cy93YWl0LXVudGlsIChlcSAocHJvY2Vzcy1zdGF0dXMgLGNs aWVudC1zeW1ib2wpCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg LGV4aXQtc3RhdHVzLXN5bWJvbCkpKSkpKSkKIAogKGRlZnZhciBzZXJ2ZXItdGVzdHMvdmFy aWFibGUgbmlsKQogCkBAIC03OSw1NyArMTEyLDU1IEBAIHNlcnZlci10ZXN0cy9zZXJ2ZXIt c3RhcnQvc2V0cy1taW5vci1tb2RlCiAoZXJ0LWRlZnRlc3Qgc2VydmVyLXRlc3RzL3NlcnZl ci1zdGFydC9zdG9wLXByb21wdC13aXRoLWNsaWVudCAoKQogICAiRW5zdXJlIHRoYXQgc3Rv cHBpbmcgdGhlIHNlcnZlciBwcm9tcHRzIHdoZW4gdGhlcmUgYXJlIGNsaWVudHMuIgogICAo c2VydmVyLXRlc3RzL3dpdGgtc2VydmVyCi0gICAgKGxldCAoKHllcy1vci1uby1wLWNhbGxl ZCBuaWwpCi0gICAgICAgICAgKGVtYWNzY2xpZW50IChzZXJ2ZXItdGVzdHMvc3RhcnQtZW1h Y3NjbGllbnQgIi1jIikpKQotICAgICAgKHNlcnZlci10ZXN0cy93YWl0LXVudGlsIChsZW5n dGg9IChmcmFtZS1saXN0KSAyKSkKLSAgICAgIChjbC1sZXRmICgoKHN5bWJvbC1mdW5jdGlv biAneWVzLW9yLW5vLXApCi0gICAgICAgICAgICAgICAgIChsYW1iZGEgKF9wcm9tcHQpCi0g ICAgICAgICAgICAgICAgICAgKHNldHEgeWVzLW9yLW5vLXAtY2FsbGVkIHQpKSkpCisgICAg KHNlcnZlci10ZXN0cy93aXRoLWNsaWVudCBlbWFjc2NsaWVudCAnKCItYyIpICdleGl0Cisg ICAgICAoc2hvdWxkIChsZW5ndGg9IChmcmFtZS1saXN0KSAyKSkKKyAgICAgIChjbC1sZXRm KiAoKHllcy1vci1uby1wLWNhbGxlZCBuaWwpCisgICAgICAgICAgICAgICAgICgoc3ltYm9s LWZ1bmN0aW9uICd5ZXMtb3Itbm8tcCkKKyAgICAgICAgICAgICAgICAgIChsYW1iZGEgKF9w cm9tcHQpCisgICAgICAgICAgICAgICAgICAgIChzZXRxIHllcy1vci1uby1wLWNhbGxlZCB0 KSkpKQogICAgICAgICAoc2VydmVyLXN0YXJ0IHQpCi0gICAgICAgIChzaG91bGQgeWVzLW9y LW5vLXAtY2FsbGVkKSkKLSAgICAgIChzZXJ2ZXItdGVzdHMvd2FpdC11bnRpbCAoZXEgKHBy b2Nlc3Mtc3RhdHVzIGVtYWNzY2xpZW50KSAnZXhpdCkpKSkpCisgICAgICAgIChzaG91bGQg eWVzLW9yLW5vLXAtY2FsbGVkKSkpKSkKIAogKGVydC1kZWZ0ZXN0IHNlcnZlci10ZXN0cy9z ZXJ2ZXItc3RhcnQvbm8tc3RvcC1wcm9tcHQtd2l0aG91dC1jbGllbnQgKCkKICAgIkVuc3Vy ZSB0aGF0IHN0b3BwaW5nIHRoZSBzZXJ2ZXIgZG9lc24ndCBwcm9tcHQgd2hlbiB0aGVyZSBh cmUgbm8gY2xpZW50cy4iCiAgIChzZXJ2ZXItdGVzdHMvd2l0aC1zZXJ2ZXIKLSAgICAobGV0 ICgoeWVzLW9yLW5vLXAtY2FsbGVkIG5pbCkpCi0gICAgICAoY2wtbGV0ZiAoKChzeW1ib2wt ZnVuY3Rpb24gJ3llcy1vci1uby1wKQotICAgICAgICAgICAgICAgICAobGFtYmRhIChfcHJv bXB0KQotICAgICAgICAgICAgICAgICAgIChzZXRxIHllcy1vci1uby1wLWNhbGxlZCB0KSkp KQotICAgICAgICAobGV0ICgoaW5oaWJpdC1tZXNzYWdlIHQpKQotICAgICAgICAgIChzZXJ2 ZXItc3RhcnQgdCkpCi0gICAgICAgIChzaG91bGQtbm90IHllcy1vci1uby1wLWNhbGxlZCkp KSkpCisgICAgKGNsLWxldGYqICgoaW5oaWJpdC1tZXNzYWdlIHQpCisgICAgICAgICAgICAg ICAoeWVzLW9yLW5vLXAtY2FsbGVkIG5pbCkKKyAgICAgICAgICAgICAgICgoc3ltYm9sLWZ1 bmN0aW9uICd5ZXMtb3Itbm8tcCkKKyAgICAgICAgICAgICAgICAobGFtYmRhIChfcHJvbXB0 KQorICAgICAgICAgICAgICAgICAgKHNldHEgeWVzLW9yLW5vLXAtY2FsbGVkIHQpKSkpCisg ICAgICAoc2VydmVyLXN0YXJ0IHQpCisgICAgICAoc2hvdWxkLW5vdCB5ZXMtb3Itbm8tcC1j YWxsZWQpKSkpCiAKIChlcnQtZGVmdGVzdCBzZXJ2ZXItdGVzdHMvZW1hY3NjbGllbnQvc2Vy dmVyLWVkaXQgKCkKICAgIlRlc3QgdGhhdCBjYWxsaW5nIGBzZXJ2ZXItZWRpdCcgZnJvbSBh IGNsaWVudCBidWZmZXIgZXhpdHMgdGhlIGNsaWVudC4iCiAgIChzZXJ2ZXItdGVzdHMvd2l0 aC1zZXJ2ZXIKLSAgICAobGV0ICgoZW1hY3NjbGllbnQgKHNlcnZlci10ZXN0cy9zdGFydC1l bWFjc2NsaWVudCAiZmlsZS50eHQiKSkpCisgICAgKHNlcnZlci10ZXN0cy93aXRoLWNsaWVu dCBlbWFjc2NsaWVudCAnKCJmaWxlLnR4dCIpICdleGl0CiAgICAgICAoc2VydmVyLXRlc3Rz L3dhaXQtdW50aWwgKGdldC1idWZmZXIgImZpbGUudHh0IikpCiAgICAgICAoc2hvdWxkIChl cSAocHJvY2Vzcy1zdGF0dXMgZW1hY3NjbGllbnQpICdydW4pKQotICAgICAgKHNob3VsZCAo bGVuZ3RoPSBzZXJ2ZXItY2xpZW50cyAxKSkKICAgICAgICh3aXRoLWN1cnJlbnQtYnVmZmVy ICJmaWxlLnR4dCIKLSAgICAgICAgKHNlcnZlci1lZGl0KSkKLSAgICAgIChzZXJ2ZXItdGVz dHMvd2FpdC11bnRpbCAoZXEgKHByb2Nlc3Mtc3RhdHVzIGVtYWNzY2xpZW50KSAnZXhpdCkp KSkpCisgICAgICAgIChzZXJ2ZXItZWRpdCkpKSkpCiAKIChlcnQtZGVmdGVzdCBzZXJ2ZXIt dGVzdHMvZW1hY3NjbGllbnQvY3JlYXRlLWZyYW1lICgpCiAgICJUZXN0IHRoYXQgXCJlbWFj c2NsaWVudCAtY1wiIGNyZWF0ZXMgYSBmcmFtZS4iCi0gIChzZXJ2ZXItdGVzdHMvd2l0aC1z ZXJ2ZXIKLSAgICAobGV0ICgoZW1hY3NjbGllbnQgKHNlcnZlci10ZXN0cy9zdGFydC1lbWFj c2NsaWVudCAiLWMiKSkpCi0gICAgICAoc2VydmVyLXRlc3RzL3dhaXQtdW50aWwgKGxlbmd0 aD0gKGZyYW1lLWxpc3QpIDIpKQorICAobGV0ICgoc3RhcnRpbmctZnJhbWUtY291bnQgKGxl bmd0aCAoZnJhbWUtbGlzdCkpKSkKKyAgICAoc2VydmVyLXRlc3RzL3dpdGgtc2VydmVyCisg ICAgICAoc2VydmVyLXRlc3RzL3dpdGgtY2xpZW50IGVtYWNzY2xpZW50ICcoIi1jIikgbmls CisgICAgICAoc2hvdWxkIChsZW5ndGg9IChmcmFtZS1saXN0KSAoMSsgc3RhcnRpbmctZnJh bWUtY291bnQpKSkKICAgICAgIChzaG91bGQgKGVxIChwcm9jZXNzLXN0YXR1cyBlbWFjc2Ns aWVudCkgJ3J1bikpCi0gICAgICAoc2hvdWxkIChsZW5ndGg9IHNlcnZlci1jbGllbnRzIDEp KQogICAgICAgKHNob3VsZCAoZXEgKGZyYW1lLXBhcmFtZXRlciAoY2FyIChmcmFtZS1saXN0 KSkgJ2NsaWVudCkKICAgICAgICAgICAgICAgICAgIChjYXIgc2VydmVyLWNsaWVudHMpKSkp KQogICA7OyBUaGUgY2xpZW50IGZyYW1lIHNob3VsZCBnbyBhd2F5IGFmdGVyIHRoZSBzZXJ2 ZXIgc3RvcHMuCi0gIChzaG91bGQgKGxlbmd0aD0gKGZyYW1lLWxpc3QpIDEpKSkKKyAgICAo c2hvdWxkIChsZW5ndGg9IChmcmFtZS1saXN0KSBzdGFydGluZy1mcmFtZS1jb3VudCkpKSkK IAogKGVydC1kZWZ0ZXN0IHNlcnZlci10ZXN0cy9lbWFjc2NsaWVudC9ldmFsICgpCiAgICJU ZXN0IHRoYXQgXCJlbWFjc2NsaWVudCAtLWV2YWxcIiB3b3JrcyBjb3JyZWN0bHkuIgogICAo c2VydmVyLXRlc3RzL3dpdGgtc2VydmVyCiAgICAgKGxldCAoKHZhbHVlIChyYW5kb20pKSkK LSAgICAgIChzZXJ2ZXItdGVzdHMvc3RhcnQtZW1hY3NjbGllbnQKLSAgICAgICAiLS1ldmFs IiAoZm9ybWF0ICIoc2V0cSBzZXJ2ZXItdGVzdHMvdmFyaWFibGUgJWQpIiB2YWx1ZSkpCi0g ICAgICAoc2VydmVyLXRlc3RzL3dhaXQtdW50aWwgKGVxIHNlcnZlci10ZXN0cy92YXJpYWJs ZSB2YWx1ZSkpKSkpCisgICAgICAoc2VydmVyLXRlc3RzL3dpdGgtY2xpZW50IGVtYWNzY2xp ZW50CisgICAgICAgICAgKGxpc3QgIi0tZXZhbCIgKGZvcm1hdCAiKHNldHEgc2VydmVyLXRl c3RzL3ZhcmlhYmxlICVkKSIgdmFsdWUpKQorICAgICAgICAgICdleGl0CisgICAgICAgIChz aG91bGQgKD0gc2VydmVyLXRlc3RzL3ZhcmlhYmxlIHZhbHVlKSkpKSkpCiAKIChlcnQtZGVm dGVzdCBzZXJ2ZXItdGVzdHMvc2VydmVyLWZvcmNlLXN0b3Ava2VlcHMtZnJhbWVzICgpCiAg ICJFbnN1cmUgdGhhdCBgc2VydmVyLWZvcmNlLXN0b3AnIGRvZXNuJ3QgZGVsZXRlIGZyYW1l cy4gIFNlZSBidWcjNTg4NzcuCkBAIC0xMzksMTIgKzE3MCwxMyBAQCBzZXJ2ZXItdGVzdHMv c2VydmVyLWZvcmNlLXN0b3Ava2VlcHMtZnJhbWVzCiB0ZXN0cyB0aGF0IGBzZXJ2ZXItZm9y Y2Utc3RvcCcgZG9lc24ndCBkZWxldGUgZnJhbWVzIChhbmQgZXZlbgogdGhlbiwgcmVxdWly ZXMgYSBmZXcgdHJpY2tzIHRvIHJ1biBhcyBhIHJlZ3Jlc3Npb24gdGVzdCkuICBTbwogbG9u ZyBhcyB0aGlzIHdvcmtzLCB0aGUgcHJvYmxlbSBpbiBidWcjNTg4Nzcgc2hvdWxkbid0IG9j Y3VyLiIKLSAgKGxldCAodGVybWluYWwpCisgIChsZXQgKChzdGFydGluZy1mcmFtZS1jb3Vu dCAobGVuZ3RoIChmcmFtZS1saXN0KSkpCisgICAgICAgIHRlcm1pbmFsKQogICAgICh1bndp bmQtcHJvdGVjdAogICAgICAgICAoc2VydmVyLXRlc3RzL3dpdGgtc2VydmVyCi0gICAgICAg ICAgKGxldCAoKGVtYWNzY2xpZW50IChzZXJ2ZXItdGVzdHMvc3RhcnQtZW1hY3NjbGllbnQg Ii1jIikpKQotICAgICAgICAgICAgKHNlcnZlci10ZXN0cy93YWl0LXVudGlsIChsZW5ndGg9 IChmcmFtZS1saXN0KSAyKSkKKyAgICAgICAgICAoc2VydmVyLXRlc3RzL3dpdGgtY2xpZW50 IGVtYWNzY2xpZW50ICcoIi1jIikgJ2V4aXQKICAgICAgICAgICAgIChzaG91bGQgKGVxIChw cm9jZXNzLXN0YXR1cyBlbWFjc2NsaWVudCkgJ3J1bikpCisgICAgICAgICAgICAoc2hvdWxk IChsZW5ndGg9IChmcmFtZS1saXN0KSAoMSsgc3RhcnRpbmctZnJhbWUtY291bnQpKSkKIAog ICAgICAgICAgICAgOzsgRG9uJ3QgZGVsZXRlIHRoZSB0ZXJtaW5hbCBmb3IgdGhlIGNsaWVu dDsgdGhhdCB3b3VsZAogICAgICAgICAgICAgOzsga2lsbCBpdHMgZnJhbWUgaW1tZWRpYXRl bHkgdG9vLiAgKFRoaXMgaXMgb25seSBhbiBpc3N1ZQpAQCAtMTU5LDcgKzE5MSw3IEBAIHNl cnZlci10ZXN0cy9zZXJ2ZXItZm9yY2Utc3RvcC9rZWVwcy1mcmFtZXMKIAogICAgICAgICAg ICAgKHNlcnZlci1mb3JjZS1zdG9wKSkKICAgICAgICAgICA7OyBFbnN1cmUgd2UgZGlkbid0 IGRlbGV0ZSB0aGUgZnJhbWUuCi0gICAgICAgICAgKHNob3VsZCAobGVuZ3RoPSAoZnJhbWUt bGlzdCkgMikpKQorICAgICAgICAgIChzaG91bGQgKGxlbmd0aD0gKGZyYW1lLWxpc3QpICgx KyBzdGFydGluZy1mcmFtZS1jb3VudCkpKSkKICAgICAgIDs7IENsZWFuIHVwIGFmdGVyIG91 cnNlbHZlcyBhbmQgZGVsZXRlIHRoZSB0ZXJtaW5hbC4KICAgICAgICh3aGVuIChhbmQgdGVy bWluYWwKICAgICAgICAgICAgICAgICAgKGVxICh0ZXJtaW5hbC1saXZlLXAgdGVybWluYWwp IHQpCi0tIAoyLjI1LjEKCg== --------------nk9HKawX5D0prOKEgKyhkebe-- From unknown Sat Jun 14 04:55:23 2025 X-Loop: help-debbugs@gnu.org Subject: bug#58877: 29.0.50; [PATCH] When killing Emacs from a client frame with no other frames, Emacs shows a useless error prompt Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 26 Nov 2022 14:44:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58877 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Jim Porter Cc: 58877@debbugs.gnu.org Received: via spool by 58877-submit@debbugs.gnu.org id=B58877.166947382121511 (code B ref 58877); Sat, 26 Nov 2022 14:44:02 +0000 Received: (at 58877) by debbugs.gnu.org; 26 Nov 2022 14:43:41 +0000 Received: from localhost ([127.0.0.1]:38345 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oywP6-0005at-MZ for submit@debbugs.gnu.org; Sat, 26 Nov 2022 09:43:40 -0500 Received: from eggs.gnu.org ([209.51.188.92]:50126) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oywP4-0005ag-Fl for 58877@debbugs.gnu.org; Sat, 26 Nov 2022 09:43:39 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oywOz-0006ez-5G; Sat, 26 Nov 2022 09:43:33 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=NNHmu2qZTBzFQkgz04mHjlWtmpVbFOw4GAbxtY/ifHU=; b=kFqNPhHuVuwK J7be9OJjXgZ3RNxK+Z68e+CaTawYFozKrhNNC6KxoxzbtwS/sb1mJt6tkCO/HN/sRd82+boRky6zx IF0vTm1qtCEO8Pg8SWoWUfvqjrIPGW8mt5mgU3N3eyV6zm2b7D4xfGIf0Z3odKCd/xoiabd63ylo1 sMeXamFX49eI2AhZyiCc2knD68YzP5G5qwYv9aMpSbu1nuthIuOrrH+XxCYwxcq/U3SLcoSviptVz Y+sjBAAlu4h7JqCAWzqpTR33fXwLCYCdueRPlK3w27Xvw9LEh8TknjsrjtOzGcgm9UEWaYasOa8TI HAxvQ4Yyu9HUo8/XlaZdUg==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oywOy-00039K-LO; Sat, 26 Nov 2022 09:43:32 -0500 Date: Sat, 26 Nov 2022 16:43:57 +0200 Message-Id: <83ilj1srma.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: (message from Jim Porter on Fri, 25 Nov 2022 12:57:37 -0800) References: <8121efd5-77c3-0682-ce0f-6be9375dadd8@gmail.com> <83a65dhm7f.fsf@gnu.org> <13835614-c593-ba2d-5373-a9950f6f3dab@gmail.com> <83k03kwoy6.fsf@gnu.org> <83a64fupwv.fsf@gnu.org> <83wn7iu6rz.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Fri, 25 Nov 2022 12:57:37 -0800 > Cc: 58877@debbugs.gnu.org > From: Jim Porter > > >> Hm, it looks like the emacsclient may not be starting up correctly. > >> Could you try the attached patch? I doubt this will fix the tests, but > >> hopefully you'll get some more-useful error messages. > > > > Here are the failure info from each failed test after this patch: > > > > Test server-tests/emacsclient/create-frame condition: > > Output: > > (ert-test-failed "timed out waiting for (or (= (length server-clients) (1+ starting-client-count)) (eq (process-status emacsclient) exit-status)) to be non-nil") > > FAILED 1/7 server-tests/emacsclient/create-frame (5.062500 sec) at lisp/server-tests.el:138 > > Oops, sorry about that. I didn't realize until now that 'ert-info' > computes its message immediately, rather than at the time of printing > the info.[1] I've added a bit of code to ert.el to support this case, > which will hopefully produce better output. Never mind, I think I know what's the cause of the problem: I have my production session of Emacs running on the system ,and it already has the server started. So a plain call to server-start fails. I think you need to modify the tests to ensure the server file is created in a temporary directory. And keep in mind that the variable which affects that is different depending on whether server-use-tcp is or isn't non-nil. From unknown Sat Jun 14 04:55:23 2025 X-Loop: help-debbugs@gnu.org Subject: bug#58877: 29.0.50; [PATCH] When killing Emacs from a client frame with no other frames, Emacs shows a useless error prompt Resent-From: Jim Porter Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 26 Nov 2022 19:05:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58877 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Eli Zaretskii Cc: 58877@debbugs.gnu.org Received: via spool by 58877-submit@debbugs.gnu.org id=B58877.166948949814753 (code B ref 58877); Sat, 26 Nov 2022 19:05:01 +0000 Received: (at 58877) by debbugs.gnu.org; 26 Nov 2022 19:04:58 +0000 Received: from localhost ([127.0.0.1]:41441 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oz0Tx-0003pt-9n for submit@debbugs.gnu.org; Sat, 26 Nov 2022 14:04:58 -0500 Received: from mail-pj1-f42.google.com ([209.85.216.42]:36810) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oz0Tu-0003pn-5p for 58877@debbugs.gnu.org; Sat, 26 Nov 2022 14:04:56 -0500 Received: by mail-pj1-f42.google.com with SMTP id a22-20020a17090a6d9600b0021896eb5554so10397836pjk.1 for <58877@debbugs.gnu.org>; Sat, 26 Nov 2022 11:04:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:from:references:cc:to:content-language:subject :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=dkBJX9IyNAsSbMJ19WayFRPFjusFUbIK6NDvClxgME0=; b=BP00rtbtpfFG4y15wCNLX60V1ByenWhCS8LvP35sj+LMKu5KpYkzpNnTQMsrMlayL0 HUzpKHEnV3MkRyV+JEvIUB0tiOug6OzSMMQAwS+j5pIXIffk7FnKMk1WdSgBQNT6N9SE skd2+/cB7qkyFPMVN5v9iCHQEX32eQnEBh0B+9aQdzBLYqKHzVWzlW2zrTUBOsGGzcxl 2YKKKOASmEghFbVy2pRGmWaX/gkQrfP43AyVMVXFdie4qKNcHWjm00l35m3SPkSK77qH TbCb+O4U9QcNqkvHNpYmdGMnGC6U78HT/jN+zDjXWs1sgIeqLvlo2Yx2bfRCJSZLtmBX nPhA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:from:references:cc:to:content-language:subject :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=dkBJX9IyNAsSbMJ19WayFRPFjusFUbIK6NDvClxgME0=; b=MqmIGcDjAUvoT5o6pTHXkKbfMk2xdyJIr67c3KLBhatGhiMzDLX+GhhqpCkD5LY8n4 kuvkw9S8WUgqb3mFsq5pMrxSR6qwh9V+3MRWvs1R3rzIxF7Lco2BRV6gPmxBQs2fu5Rt x0kSue1l4g8dU65+WDsMnyx+k0vcneZ7y+TjpmBHsIdOQQCEZsYf43LhDSgauT7qba1p vPM0LE9pD0CnmkYp7+rmkiA2srzGF92yuDLNhqZAt7vzRwnnac5b55Iax2z2ga/+pzPT 2nnO+QBPus+PQvueZ0tUQQWB3gsAodp+rIihUxGLc27/f+jouYB0sgbdFM2T1vS8Gx9r 7VMA== X-Gm-Message-State: ANoB5pmzndq4qgQllr3ETkLC8L20aYzCjxb6Yj+ygqXMnnSsDHKdjSW0 7204DzGdErOedmHmF26gpIQ= X-Google-Smtp-Source: AA0mqf6sRlZBukaQ9pVklUeWDHEVcoNcBAOsP18wJnHer98WQPpAR1EbH4MTHa56YZ6tIcshSDi98g== X-Received: by 2002:a17:90b:1282:b0:214:1804:d96b with SMTP id fw2-20020a17090b128200b002141804d96bmr45678362pjb.90.1669489488062; Sat, 26 Nov 2022 11:04:48 -0800 (PST) Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id r1-20020a635141000000b0046feb2754e5sm4293825pgl.28.2022.11.26.11.04.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 26 Nov 2022 11:04:46 -0800 (PST) Content-Type: multipart/mixed; boundary="------------nbOFHUZelf0JSqm0JfI0QuBO" Message-ID: Date: Sat, 26 Nov 2022 11:04:48 -0800 MIME-Version: 1.0 Content-Language: en-US References: <8121efd5-77c3-0682-ce0f-6be9375dadd8@gmail.com> <83a65dhm7f.fsf@gnu.org> <13835614-c593-ba2d-5373-a9950f6f3dab@gmail.com> <83k03kwoy6.fsf@gnu.org> <83a64fupwv.fsf@gnu.org> <83wn7iu6rz.fsf@gnu.org> <83ilj1srma.fsf@gnu.org> From: Jim Porter In-Reply-To: <83ilj1srma.fsf@gnu.org> X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) This is a multi-part message in MIME format. --------------nbOFHUZelf0JSqm0JfI0QuBO Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 11/26/2022 6:43 AM, Eli Zaretskii wrote: > Never mind, I think I know what's the cause of the problem: I have my > production session of Emacs running on the system ,and it already has the > server started. So a plain call to server-start fails. > > I think you need to modify the tests to ensure the server file is created in > a temporary directory. And keep in mind that the variable which affects > that is different depending on whether server-use-tcp is or isn't non-nil. Hm, I'm surprised the tests failed again for you then. Both of the patches I posted to fix the tests set the 'server-name' to a (hopefully) unique value. Still, I think it's a good idea to use a temporary directory to hold the server file, so here's a patch that does that. I've tried this patch with a production Emacs server running at the same time in several different configurations (with 'server-use-tcp' on and off, and with --daemon), and the tests all pass locally for me on GNU/Linux. --------------nbOFHUZelf0JSqm0JfI0QuBO Content-Type: text/plain; charset=UTF-8; name="0001-Improve-robustness-of-server.el-tests.patch" Content-Disposition: attachment; filename="0001-Improve-robustness-of-server.el-tests.patch" Content-Transfer-Encoding: base64 RnJvbSA3MWM2OTlmYWI0MTJkYTRjNDY1NzRkYTVkNjNkYzhhZWFkY2E4NzEyIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKaW0gUG9ydGVyIDxqcG9ydGVyYnVnc0BnbWFpbC5j b20+CkRhdGU6IEZyaSwgMjUgTm92IDIwMjIgMTE6MTM6MDYgLTA4MDAKU3ViamVjdDogW1BB VENIXSBJbXByb3ZlIHJvYnVzdG5lc3Mgb2Ygc2VydmVyLmVsIHRlc3RzCgoqIGxpc3AvZW1h Y3MtbGlzcC9lcnQuZWwgKGVydC0taW5zZXJ0LWluZm9zKTogQWxsb3cgJ21lc3NhZ2UnIHRv IGJlIGEKZnVuY3Rpb24gdGhhdCBpcyBjYWxsZWQgd2hlbiBpbnNlcnRpbmcgdGhlIGluZm8u CihlcnQtaW5mbyk6IFVwZGF0ZSBkb2NzdHJpbmcgdG8gZGVzY3JpYmUgdXNpbmcgYSBmdW5j dGlvbiBmb3IKTUVTU0FHRS1GT1JNLgoKKiBsaXNwL3NlcnZlci5lbCAoc2VydmVyLXN0YXJ0 KTogTG9nIHdoZW4gdGhlIHNlcnZlciBpcyBzdGFydGluZy4KCiogdGVzdC9saXNwL3NlcnZl ci10ZXN0cy5lbCAoc2VydmVyLXRlc3RzL3N0YXJ0LWVtYWNzY2xpZW50KTogUmVuYW1lCnRv Li4uCihzZXJ2ZXItdGVzdHMvc3RhcnQtY2xpZW50KTogLi4uIHRoaXMsIGFuZCBzZXQgdGhl IHByb2Nlc3MncyBidWZmZXIuCihzZXJ2ZXItdGVzdHMvd2l0aC1zZXJ2ZXIpOiBQdXQgdGhl IHNlcnZlciBmaWxlIGluIGEgdGVtcG9yYXJ5CmRpcmVjdG9yeSBzbyB3ZSBkb24ndCBjb25m bGljdCB3aXRoIHJlYWwgRW1hY3Mgc2VydmVycy4KKHNlcnZlci10ZXN0cy93aXRoLWNsaWVu dCk6IE5ldyBtYWNyby4uLgooc2VydmVyLXRlc3RzL3NlcnZlci1zdGFydC9zdG9wLXByb21w dC13aXRoLWNsaWVudCkKKHNlcnZlci10ZXN0cy9lbWFjc2NsaWVudC9zZXJ2ZXItZWRpdCkK KHNlcnZlci10ZXN0cy9lbWFjc2NsaWVudC9jcmVhdGUtZnJhbWUpCihzZXJ2ZXItdGVzdHMv ZW1hY3NjbGllbnQvY3JlYXRlLWZyYW1lKTogLi4uIHVzZSBpdC4KKHNlcnZlci10ZXN0cy9z ZXJ2ZXItc3RhcnQvc3RvcC1wcm9tcHQtd2l0aC1jbGllbnQpOiBTaW1wbGlmeS4KLS0tCiBs aXNwL2VtYWNzLWxpc3AvZXJ0LmVsICAgIHwgICA5ICsrLQogbGlzcC9zZXJ2ZXIuZWwgICAg ICAgICAgICB8ICAgMSArCiB0ZXN0L2xpc3Avc2VydmVyLXRlc3RzLmVsIHwgMTQyICsrKysr KysrKysrKysrKysrKysrKysrKy0tLS0tLS0tLS0tLS0tCiAzIGZpbGVzIGNoYW5nZWQsIDk3 IGluc2VydGlvbnMoKyksIDU1IGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL2xpc3AvZW1h Y3MtbGlzcC9lcnQuZWwgYi9saXNwL2VtYWNzLWxpc3AvZXJ0LmVsCmluZGV4IGMyNWFkZTIy ZDYuLjY3Y2JlNjI1MzggMTAwNjQ0Ci0tLSBhL2xpc3AvZW1hY3MtbGlzcC9lcnQuZWwKKysr IGIvbGlzcC9lbWFjcy1saXNwL2VydC5lbApAQCAtNjczLDggKzY3MywxMSBAQCBlcnQtaW5m bwogCiBUbyBiZSB1c2VkIHdpdGhpbiBFUlQgdGVzdHMuICBNRVNTQUdFLUZPUk0gc2hvdWxk IGV2YWx1YXRlIHRvIGEKIHN0cmluZyB0aGF0IHdpbGwgYmUgZGlzcGxheWVkIHRvZ2V0aGVy IHdpdGggdGhlIHRlc3QgcmVzdWx0IGlmCi10aGUgdGVzdCBmYWlscy4gIFBSRUZJWC1GT1JN IHNob3VsZCBldmFsdWF0ZSB0byBhIHN0cmluZyBhcyB3ZWxsCi1hbmQgaXMgZGlzcGxheWVk IGluIGZyb250IG9mIHRoZSB2YWx1ZSBvZiBNRVNTQUdFLUZPUk0uIgordGhlIHRlc3QgZmFp bHMuICBNRVNTQUdFLUZPUk0gY2FuIGFsc28gZXZhbHVhdGUgdG8gYSBmdW5jdGlvbjsgaW4K K3RoaXMgY2FzZSwgaXQgd2lsbCBiZSBjYWxsZWQgd2hlbiBkaXNwbGF5aW5nIHRoZSBpbmZv LgorCitQUkVGSVgtRk9STSBzaG91bGQgZXZhbHVhdGUgdG8gYSBzdHJpbmcgYXMgd2VsbCBh bmQgaXMgZGlzcGxheWVkCitpbiBmcm9udCBvZiB0aGUgdmFsdWUgb2YgTUVTU0FHRS1GT1JN LiIKICAgKGRlY2xhcmUgKGRlYnVnICgoZm9ybSAmcmVzdCBbc2V4cCBmb3JtXSkgYm9keSkp CiAJICAgKGluZGVudCAxKSkKICAgYChsZXQgKChlcnQtLWluZm9zIChjb25zIChjb25zICxw cmVmaXgtZm9ybSAsbWVzc2FnZS1mb3JtKSBlcnQtLWluZm9zKSkpCkBAIC0xMzUyLDYgKzEz NTUsOCBAQCBlcnQtLWluc2VydC1pbmZvcwogICAgICAgICAgICAgKGVuZCBuaWwpKQogICAg ICAgICAodW53aW5kLXByb3RlY3QKICAgICAgICAgICAgIChwcm9nbgorICAgICAgICAgICAg ICAod2hlbiAoZnVuY3Rpb25wIG1lc3NhZ2UpCisgICAgICAgICAgICAgICAgKHNldHEgbWVz c2FnZSAoZnVuY2FsbCBtZXNzYWdlKSkpCiAgICAgICAgICAgICAgIChpbnNlcnQgbWVzc2Fn ZSAiXG4iKQogICAgICAgICAgICAgICAoc2V0cSBlbmQgKHBvaW50LW1hcmtlcikpCiAgICAg ICAgICAgICAgIChnb3RvLWNoYXIgYmVnaW4pCmRpZmYgLS1naXQgYS9saXNwL3NlcnZlci5l bCBiL2xpc3Avc2VydmVyLmVsCmluZGV4IGJlYjQ2ODUzYjcuLjIxMDJmODU2OWIgMTAwNjQ0 Ci0tLSBhL2xpc3Avc2VydmVyLmVsCisrKyBiL2xpc3Avc2VydmVyLmVsCkBAIC03NTYsNiAr NzU2LDcgQEAgc2VydmVyLXN0YXJ0CiAJCQkgICAgICAgOnNlcnZpY2Ugc2VydmVyLWZpbGUK IAkJCSAgICAgICA6cGxpc3QgJyg6YXV0aGVudGljYXRlZCB0KSkpKSkKIAkgICh1bmxlc3Mg c2VydmVyLXByb2Nlc3MgKGVycm9yICJDb3VsZCBub3Qgc3RhcnQgc2VydmVyIHByb2Nlc3Mi KSkKKyAgICAgICAgICAoc2VydmVyLWxvZyAiU3RhcnRpbmcgc2VydmVyIikKIAkgIChwcm9j ZXNzLXB1dCBzZXJ2ZXItcHJvY2VzcyA6c2VydmVyLWZpbGUgc2VydmVyLWZpbGUpCiAgICAg ICAgICAgKHNldHEgc2VydmVyLW1vZGUgdCkKICAgICAgICAgICAocHVzaCAnc2VydmVyLW1v ZGUgZ2xvYmFsLW1pbm9yLW1vZGVzKQpkaWZmIC0tZ2l0IGEvdGVzdC9saXNwL3NlcnZlci10 ZXN0cy5lbCBiL3Rlc3QvbGlzcC9zZXJ2ZXItdGVzdHMuZWwKaW5kZXggMzcwY2Y4NjE0OC4u NGQ3NGI3N2ZkZiAxMDA2NDQKLS0tIGEvdGVzdC9saXNwL3NlcnZlci10ZXN0cy5lbAorKysg Yi90ZXN0L2xpc3Avc2VydmVyLXRlc3RzLmVsCkBAIC0yMiwxNyArMjIsMzEgQEAKIChyZXF1 aXJlICdlcnQpCiAocmVxdWlyZSAnc2VydmVyKQogCisoZGVmY29uc3Qgc2VydmVyLXRlc3Rz L21heC13YWl0LXRpbWUgNQorICAiVGhlIG1heGltdW0gdGltZSB0byB3YWl0IGluIGBzZXJ2 ZXItdGVzdHMvd2FpdC11bnRpbCcsIGluIHNlY29uZHMuIikKKwogKGRlZmNvbnN0IHNlcnZl ci10ZXN0cy9lbWFjc2NsaWVudAogICAoaWYgaW5zdGFsbGF0aW9uLWRpcmVjdG9yeQogICAg ICAgKGV4cGFuZC1maWxlLW5hbWUgImxpYi1zcmMvZW1hY3NjbGllbnQiIGluc3RhbGxhdGlv bi1kaXJlY3RvcnkpCiAgICAgImVtYWNzY2xpZW50IikKICAgIlRoZSBlbWFjc2NsaWVudCBi aW5hcnkgdG8gdGVzdC4iKQogCi0oZGVmdW4gc2VydmVyLXRlc3RzL3N0YXJ0LWVtYWNzY2xp ZW50ICgmcmVzdCBhcmdzKQorKGRlZm1hY3JvIHNlcnZlci10ZXN0cy93YWl0LXVudGlsIChm b3JtKQorICAiV2FpdCB1bnRpbCBGT1JNIGlzIG5vbi1uaWwsIHRpbWluZyBvdXQgYW5kIGZh aWxpbmcgaWYgaXQgdGFrZXMgdG9vIGxvbmcuIgorICBgKGxldCAoKHN0YXJ0IChjdXJyZW50 LXRpbWUpKSkKKyAgICAod2hpbGUgKG5vdCAsZm9ybSkKKyAgICAgICh3aGVuICg+IChmbG9h dC10aW1lICh0aW1lLXNpbmNlIHN0YXJ0KSkKKyAgICAgICAgICAgICAgIHNlcnZlci10ZXN0 cy9tYXgtd2FpdC10aW1lKQorICAgICAgICAoZXJ0LWZhaWwgKGZvcm1hdCAidGltZWQgb3V0 IHdhaXRpbmcgZm9yICVTIHRvIGJlIG5vbi1uaWwiICcsZm9ybSkpKQorICAgICAgKHNpdC1m b3IgMC4xKSkpKQorCisoZGVmdW4gc2VydmVyLXRlc3RzL3N0YXJ0LWNsaWVudCAoYXJncykK ICAgIlJ1biBlbWFjc2NsaWVudCwgcGFzc2luZyBBUkdTIGFzIGFyZ3VtZW50cyB0byBpdC4i Ci0gIChsZXQgKChzb2NrZXQtbmFtZSAocHJvY2Vzcy1nZXQgc2VydmVyLXByb2Nlc3MgOnNl cnZlci1maWxlKSkpCisgIChsZXQgKChzb2NrZXQtbmFtZSAocHJvY2Vzcy1nZXQgc2VydmVy LXByb2Nlc3MgOnNlcnZlci1maWxlKSkKKyAgICAgICAgKGJ1ZmZlciAoZ2VuZXJhdGUtbmV3 LWJ1ZmZlciAiZW1hY3NjbGllbnQiKSkpCiAgICAgKG1ha2UtcHJvY2VzcwogICAgICA6bmFt ZSBzZXJ2ZXItdGVzdHMvZW1hY3NjbGllbnQKKyAgICAgOmJ1ZmZlciBidWZmZXIKICAgICAg OmNvbW1hbmQgKGFwcGVuZCAobGlzdCBzZXJ2ZXItdGVzdHMvZW1hY3NjbGllbnQKICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAiLS1zb2NrZXQtbmFtZSIgc29ja2V0LW5hbWUpCiAg ICAgICAgICAgICAgICAgICAgICAgYXJncykpKSkKQEAgLTQwLDI3ICs1NCw1MCBAQCBzZXJ2 ZXItdGVzdHMvc3RhcnQtZW1hY3NjbGllbnQKIChkZWZtYWNybyBzZXJ2ZXItdGVzdHMvd2l0 aC1zZXJ2ZXIgKCZyZXN0IGJvZHkpCiAgICJTdGFydCB0aGUgRW1hY3Mgc2VydmVyLCBldmFs dWF0ZSBCT0RZLCBhbmQgdGhlbiBzdG9wIHRoZSBzZXJ2ZXIuIgogICAoZGVjbGFyZSAoaW5k ZW50IDApKQotICBgKHByb2duCisgIDs7IE92ZXJyaWRlIHRoZSBgc2VydmVyLW5hbWUnIHNv IHRoYXQgdGhlc2UgdGVzdHMgZG9uJ3QgaW50ZXJmZXJlCisgIDs7IHdpdGggYW55IGV4aXN0 aW5nIEVtYWNzIHNlcnZlcnMgb24gdGhlIHN5c3RlbS4KKyAgYChsZXQqICgodGVtcG9yYXJ5 LWZpbGUtZGlyZWN0b3J5IChmaWxlLW5hbWUtYXMtZGlyZWN0b3J5CisgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgKG1ha2UtdGVtcC1maWxlICJzZXJ2ZXItdGVzdHMi IHQpKSkKKyAgICAgICAgICAoc2VydmVyLW5hbWUgKGV4cGFuZC1maWxlLW5hbWUKKyAgICAg ICAgICAgICAgICAgICAgICAgICJ0ZXN0LXNlcnZlciIgdGVtcG9yYXJ5LWZpbGUtZGlyZWN0 b3J5KSkKKyAgICAgICAgICAoc2VydmVyLWxvZyB0KSkKICAgICAgKHNlcnZlci1zdGFydCkK LSAgICAgKHVud2luZC1wcm90ZWN0Ci0gICAgICAgICAocHJvZ24gKHNob3VsZCAocHJvY2Vz c3Agc2VydmVyLXByb2Nlc3MpKQotICAgICAgICAgICAgICAgICxAYm9keSkKLSAgICAgICAo bGV0ICgoaW5oaWJpdC1tZXNzYWdlIHQpKQotICAgICAgICAgKHNlcnZlci1zdGFydCB0IHQp KQotICAgICAgIChzaG91bGQgKG51bGwgc2VydmVyLXByb2Nlc3MpKQotICAgICAgIChzaG91 bGQgKG51bGwgc2VydmVyLWNsaWVudHMpKSkpKQotCi0oZGVmY29uc3Qgc2VydmVyLXRlc3Rz L21heC13YWl0LXRpbWUgNQotICAiVGhlIG1heGltdW0gdGltZSB0byB3YWl0IGluIGBzZXJ2 ZXItdGVzdHMvd2FpdC11bnRpbCcsIGluIHNlY29uZHMuIikKLQotKGRlZm1hY3JvIHNlcnZl ci10ZXN0cy93YWl0LXVudGlsIChmb3JtKQotICAiV2FpdCB1bnRpbCBGT1JNIGlzIG5vbi1u aWwsIHRpbWluZyBvdXQgYW5kIGZhaWxpbmcgaWYgaXQgdGFrZXMgdG9vIGxvbmcuIgotICBg KGxldCAoKHN0YXJ0IChjdXJyZW50LXRpbWUpKSkKLSAgICAod2hpbGUgKG5vdCAsZm9ybSkK LSAgICAgICh3aGVuICg+IChmbG9hdC10aW1lICh0aW1lLXNpbmNlIHN0YXJ0KSkKLSAgICAg ICAgICAgICAgIHNlcnZlci10ZXN0cy9tYXgtd2FpdC10aW1lKQotICAgICAgICAoZXJ0LWZh aWwgKGZvcm1hdCAidGltZWQgb3V0IHdhaXRpbmcgZm9yICVTIHRvIGJlIG5vbi1uaWwiICcs Zm9ybSkpKQotICAgICAgKHNpdC1mb3IgMC4xKSkpKQorICAgICAoZXJ0LWluZm8gKChsYW1i ZGEgKCkKKyAgICAgICAgICAgICAgICAgICh3aXRoLWN1cnJlbnQtYnVmZmVyIChnZXQtYnVm ZmVyLWNyZWF0ZSBzZXJ2ZXItYnVmZmVyKQorICAgICAgICAgICAgICAgICAgICAoYnVmZmVy LXN0cmluZykpKQorICAgICAgICAgICAgICAgIDpwcmVmaXggIlNlcnZlciBsb2dzOiAiKQor ICAgICAgICh1bndpbmQtcHJvdGVjdAorICAgICAgICAgICAocHJvZ24gKHNob3VsZCAocHJv Y2Vzc3Agc2VydmVyLXByb2Nlc3MpKQorICAgICAgICAgICAgICAgICAgLEBib2R5KQorICAg ICAgICAgKGxldCAoKGluaGliaXQtbWVzc2FnZSB0KSkKKyAgICAgICAgICAgKHNlcnZlci1z dGFydCB0IHQpKQorICAgICAgICAgKGRlbGV0ZS1kaXJlY3RvcnkgdGVtcG9yYXJ5LWZpbGUt ZGlyZWN0b3J5IHQpCisgICAgICAgICAoc2hvdWxkIChudWxsIHNlcnZlci1wcm9jZXNzKSkK KyAgICAgICAgIChzaG91bGQgKG51bGwgc2VydmVyLWNsaWVudHMpKSkpKSkKKworKGRlZm1h Y3JvIHNlcnZlci10ZXN0cy93aXRoLWNsaWVudCAoY2xpZW50LXN5bWJvbCBhcmdzIGV4aXQt c3RhdHVzICZyZXN0IGJvZHkpCisgICJTdGFydCBhbiBFbWFjcyBjbGllbnQgd2l0aCBBUkdT IGFuZCBldmFsdWF0ZSBCT0RZLgorVGhpcyBiaW5kcyB0aGUgY2xpZW50IHByb2Nlc3MgdG8g Q0xJRU5ULVNZTUJPTC4gIElmIEVYSVQtU1RBVFVTIGlzCitub24tbmlsLCB0aGVuIGFmdGVy IEJPRFkgaXMgZXZhbHVhdGVkLCBtYWtlIHN1cmUgdGhlIGNsaWVudAorcHJvY2VzcydzIHN0 YXR1cyBtYXRjaGVzIGl0LiIKKyAgKGRlY2xhcmUgKGluZGVudCAzKSkKKyAgKGxldCAoKGV4 aXQtc3RhdHVzLXN5bWJvbCAobWFrZS1zeW1ib2wgImV4aXQtc3RhdHVzIikpCisgICAgICAg IChzdGFydGluZy1jbGllbnQtY291bnQtc3ltYm9sIChtYWtlLXN5bWJvbCAic3RhcnRpbmct Y2xpZW50LWNvdW50IikpKQorICAgIGAobGV0ICgoLHN0YXJ0aW5nLWNsaWVudC1jb3VudC1z eW1ib2wgKGxlbmd0aCBzZXJ2ZXItY2xpZW50cykpCisgICAgICAgICAgICgsZXhpdC1zdGF0 dXMtc3ltYm9sICxleGl0LXN0YXR1cykKKyAgICAgICAgICAgKCxjbGllbnQtc3ltYm9sIChz ZXJ2ZXItdGVzdHMvc3RhcnQtY2xpZW50ICxhcmdzKSkpCisgICAgICAgKGVydC1pbmZvICgo bGFtYmRhICgpCisgICAgICAgICAgICAgICAgICAgICh3aXRoLWN1cnJlbnQtYnVmZmVyIChw cm9jZXNzLWJ1ZmZlciAsY2xpZW50LXN5bWJvbCkKKyAgICAgICAgICAgICAgICAgICAgICAo YnVmZmVyLXN0cmluZykpKQorICAgICAgICAgICAgICAgICAgOnByZWZpeCAiQ2xpZW50IG91 dHB1dDogIikKKyAgICAgICAgIChzZXJ2ZXItdGVzdHMvd2FpdC11bnRpbAorICAgICAgICAg IChvciAoPSAobGVuZ3RoIHNlcnZlci1jbGllbnRzKQorICAgICAgICAgICAgICAgICAoMSsg LHN0YXJ0aW5nLWNsaWVudC1jb3VudC1zeW1ib2wpKQorICAgICAgICAgICAgICAoZXEgKHBy b2Nlc3Mtc3RhdHVzICxjbGllbnQtc3ltYm9sKSAsZXhpdC1zdGF0dXMtc3ltYm9sKSkpCisg ICAgICAgICAsQGJvZHkKKyAgICAgICAgICh3aGVuICxleGl0LXN0YXR1cy1zeW1ib2wKKyAg ICAgICAgICAgKHNlcnZlci10ZXN0cy93YWl0LXVudGlsIChlcSAocHJvY2Vzcy1zdGF0dXMg LGNsaWVudC1zeW1ib2wpCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgLGV4aXQtc3RhdHVzLXN5bWJvbCkpKSkpKSkKIAogKGRlZnZhciBzZXJ2ZXItdGVzdHMv dmFyaWFibGUgbmlsKQogCkBAIC03OSw1NyArMTE2LDU1IEBAIHNlcnZlci10ZXN0cy9zZXJ2 ZXItc3RhcnQvc2V0cy1taW5vci1tb2RlCiAoZXJ0LWRlZnRlc3Qgc2VydmVyLXRlc3RzL3Nl cnZlci1zdGFydC9zdG9wLXByb21wdC13aXRoLWNsaWVudCAoKQogICAiRW5zdXJlIHRoYXQg c3RvcHBpbmcgdGhlIHNlcnZlciBwcm9tcHRzIHdoZW4gdGhlcmUgYXJlIGNsaWVudHMuIgog ICAoc2VydmVyLXRlc3RzL3dpdGgtc2VydmVyCi0gICAgKGxldCAoKHllcy1vci1uby1wLWNh bGxlZCBuaWwpCi0gICAgICAgICAgKGVtYWNzY2xpZW50IChzZXJ2ZXItdGVzdHMvc3RhcnQt ZW1hY3NjbGllbnQgIi1jIikpKQotICAgICAgKHNlcnZlci10ZXN0cy93YWl0LXVudGlsIChs ZW5ndGg9IChmcmFtZS1saXN0KSAyKSkKLSAgICAgIChjbC1sZXRmICgoKHN5bWJvbC1mdW5j dGlvbiAneWVzLW9yLW5vLXApCi0gICAgICAgICAgICAgICAgIChsYW1iZGEgKF9wcm9tcHQp Ci0gICAgICAgICAgICAgICAgICAgKHNldHEgeWVzLW9yLW5vLXAtY2FsbGVkIHQpKSkpCisg ICAgKHNlcnZlci10ZXN0cy93aXRoLWNsaWVudCBlbWFjc2NsaWVudCAnKCItYyIpICdleGl0 CisgICAgICAoc2hvdWxkIChsZW5ndGg9IChmcmFtZS1saXN0KSAyKSkKKyAgICAgIChjbC1s ZXRmKiAoKHllcy1vci1uby1wLWNhbGxlZCBuaWwpCisgICAgICAgICAgICAgICAgICgoc3lt Ym9sLWZ1bmN0aW9uICd5ZXMtb3Itbm8tcCkKKyAgICAgICAgICAgICAgICAgIChsYW1iZGEg KF9wcm9tcHQpCisgICAgICAgICAgICAgICAgICAgIChzZXRxIHllcy1vci1uby1wLWNhbGxl ZCB0KSkpKQogICAgICAgICAoc2VydmVyLXN0YXJ0IHQpCi0gICAgICAgIChzaG91bGQgeWVz LW9yLW5vLXAtY2FsbGVkKSkKLSAgICAgIChzZXJ2ZXItdGVzdHMvd2FpdC11bnRpbCAoZXEg KHByb2Nlc3Mtc3RhdHVzIGVtYWNzY2xpZW50KSAnZXhpdCkpKSkpCisgICAgICAgIChzaG91 bGQgeWVzLW9yLW5vLXAtY2FsbGVkKSkpKSkKIAogKGVydC1kZWZ0ZXN0IHNlcnZlci10ZXN0 cy9zZXJ2ZXItc3RhcnQvbm8tc3RvcC1wcm9tcHQtd2l0aG91dC1jbGllbnQgKCkKICAgIkVu c3VyZSB0aGF0IHN0b3BwaW5nIHRoZSBzZXJ2ZXIgZG9lc24ndCBwcm9tcHQgd2hlbiB0aGVy ZSBhcmUgbm8gY2xpZW50cy4iCiAgIChzZXJ2ZXItdGVzdHMvd2l0aC1zZXJ2ZXIKLSAgICAo bGV0ICgoeWVzLW9yLW5vLXAtY2FsbGVkIG5pbCkpCi0gICAgICAoY2wtbGV0ZiAoKChzeW1i b2wtZnVuY3Rpb24gJ3llcy1vci1uby1wKQotICAgICAgICAgICAgICAgICAobGFtYmRhIChf cHJvbXB0KQotICAgICAgICAgICAgICAgICAgIChzZXRxIHllcy1vci1uby1wLWNhbGxlZCB0 KSkpKQotICAgICAgICAobGV0ICgoaW5oaWJpdC1tZXNzYWdlIHQpKQotICAgICAgICAgIChz ZXJ2ZXItc3RhcnQgdCkpCi0gICAgICAgIChzaG91bGQtbm90IHllcy1vci1uby1wLWNhbGxl ZCkpKSkpCisgICAgKGNsLWxldGYqICgoaW5oaWJpdC1tZXNzYWdlIHQpCisgICAgICAgICAg ICAgICAoeWVzLW9yLW5vLXAtY2FsbGVkIG5pbCkKKyAgICAgICAgICAgICAgICgoc3ltYm9s LWZ1bmN0aW9uICd5ZXMtb3Itbm8tcCkKKyAgICAgICAgICAgICAgICAobGFtYmRhIChfcHJv bXB0KQorICAgICAgICAgICAgICAgICAgKHNldHEgeWVzLW9yLW5vLXAtY2FsbGVkIHQpKSkp CisgICAgICAoc2VydmVyLXN0YXJ0IHQpCisgICAgICAoc2hvdWxkLW5vdCB5ZXMtb3Itbm8t cC1jYWxsZWQpKSkpCiAKIChlcnQtZGVmdGVzdCBzZXJ2ZXItdGVzdHMvZW1hY3NjbGllbnQv c2VydmVyLWVkaXQgKCkKICAgIlRlc3QgdGhhdCBjYWxsaW5nIGBzZXJ2ZXItZWRpdCcgZnJv bSBhIGNsaWVudCBidWZmZXIgZXhpdHMgdGhlIGNsaWVudC4iCiAgIChzZXJ2ZXItdGVzdHMv d2l0aC1zZXJ2ZXIKLSAgICAobGV0ICgoZW1hY3NjbGllbnQgKHNlcnZlci10ZXN0cy9zdGFy dC1lbWFjc2NsaWVudCAiZmlsZS50eHQiKSkpCisgICAgKHNlcnZlci10ZXN0cy93aXRoLWNs aWVudCBlbWFjc2NsaWVudCAnKCJmaWxlLnR4dCIpICdleGl0CiAgICAgICAoc2VydmVyLXRl c3RzL3dhaXQtdW50aWwgKGdldC1idWZmZXIgImZpbGUudHh0IikpCiAgICAgICAoc2hvdWxk IChlcSAocHJvY2Vzcy1zdGF0dXMgZW1hY3NjbGllbnQpICdydW4pKQotICAgICAgKHNob3Vs ZCAobGVuZ3RoPSBzZXJ2ZXItY2xpZW50cyAxKSkKICAgICAgICh3aXRoLWN1cnJlbnQtYnVm ZmVyICJmaWxlLnR4dCIKLSAgICAgICAgKHNlcnZlci1lZGl0KSkKLSAgICAgIChzZXJ2ZXIt dGVzdHMvd2FpdC11bnRpbCAoZXEgKHByb2Nlc3Mtc3RhdHVzIGVtYWNzY2xpZW50KSAnZXhp dCkpKSkpCisgICAgICAgIChzZXJ2ZXItZWRpdCkpKSkpCiAKIChlcnQtZGVmdGVzdCBzZXJ2 ZXItdGVzdHMvZW1hY3NjbGllbnQvY3JlYXRlLWZyYW1lICgpCiAgICJUZXN0IHRoYXQgXCJl bWFjc2NsaWVudCAtY1wiIGNyZWF0ZXMgYSBmcmFtZS4iCi0gIChzZXJ2ZXItdGVzdHMvd2l0 aC1zZXJ2ZXIKLSAgICAobGV0ICgoZW1hY3NjbGllbnQgKHNlcnZlci10ZXN0cy9zdGFydC1l bWFjc2NsaWVudCAiLWMiKSkpCi0gICAgICAoc2VydmVyLXRlc3RzL3dhaXQtdW50aWwgKGxl bmd0aD0gKGZyYW1lLWxpc3QpIDIpKQorICAobGV0ICgoc3RhcnRpbmctZnJhbWUtY291bnQg KGxlbmd0aCAoZnJhbWUtbGlzdCkpKSkKKyAgICAoc2VydmVyLXRlc3RzL3dpdGgtc2VydmVy CisgICAgICAoc2VydmVyLXRlc3RzL3dpdGgtY2xpZW50IGVtYWNzY2xpZW50ICcoIi1jIikg bmlsCisgICAgICAoc2hvdWxkIChsZW5ndGg9IChmcmFtZS1saXN0KSAoMSsgc3RhcnRpbmct ZnJhbWUtY291bnQpKSkKICAgICAgIChzaG91bGQgKGVxIChwcm9jZXNzLXN0YXR1cyBlbWFj c2NsaWVudCkgJ3J1bikpCi0gICAgICAoc2hvdWxkIChsZW5ndGg9IHNlcnZlci1jbGllbnRz IDEpKQogICAgICAgKHNob3VsZCAoZXEgKGZyYW1lLXBhcmFtZXRlciAoY2FyIChmcmFtZS1s aXN0KSkgJ2NsaWVudCkKICAgICAgICAgICAgICAgICAgIChjYXIgc2VydmVyLWNsaWVudHMp KSkpKQogICA7OyBUaGUgY2xpZW50IGZyYW1lIHNob3VsZCBnbyBhd2F5IGFmdGVyIHRoZSBz ZXJ2ZXIgc3RvcHMuCi0gIChzaG91bGQgKGxlbmd0aD0gKGZyYW1lLWxpc3QpIDEpKSkKKyAg ICAoc2hvdWxkIChsZW5ndGg9IChmcmFtZS1saXN0KSBzdGFydGluZy1mcmFtZS1jb3VudCkp KSkKIAogKGVydC1kZWZ0ZXN0IHNlcnZlci10ZXN0cy9lbWFjc2NsaWVudC9ldmFsICgpCiAg ICJUZXN0IHRoYXQgXCJlbWFjc2NsaWVudCAtLWV2YWxcIiB3b3JrcyBjb3JyZWN0bHkuIgog ICAoc2VydmVyLXRlc3RzL3dpdGgtc2VydmVyCiAgICAgKGxldCAoKHZhbHVlIChyYW5kb20p KSkKLSAgICAgIChzZXJ2ZXItdGVzdHMvc3RhcnQtZW1hY3NjbGllbnQKLSAgICAgICAiLS1l dmFsIiAoZm9ybWF0ICIoc2V0cSBzZXJ2ZXItdGVzdHMvdmFyaWFibGUgJWQpIiB2YWx1ZSkp Ci0gICAgICAoc2VydmVyLXRlc3RzL3dhaXQtdW50aWwgKGVxIHNlcnZlci10ZXN0cy92YXJp YWJsZSB2YWx1ZSkpKSkpCisgICAgICAoc2VydmVyLXRlc3RzL3dpdGgtY2xpZW50IGVtYWNz Y2xpZW50CisgICAgICAgICAgKGxpc3QgIi0tZXZhbCIgKGZvcm1hdCAiKHNldHEgc2VydmVy LXRlc3RzL3ZhcmlhYmxlICVkKSIgdmFsdWUpKQorICAgICAgICAgICdleGl0CisgICAgICAg IChzaG91bGQgKD0gc2VydmVyLXRlc3RzL3ZhcmlhYmxlIHZhbHVlKSkpKSkpCiAKIChlcnQt ZGVmdGVzdCBzZXJ2ZXItdGVzdHMvc2VydmVyLWZvcmNlLXN0b3Ava2VlcHMtZnJhbWVzICgp CiAgICJFbnN1cmUgdGhhdCBgc2VydmVyLWZvcmNlLXN0b3AnIGRvZXNuJ3QgZGVsZXRlIGZy YW1lcy4gIFNlZSBidWcjNTg4NzcuCkBAIC0xMzksMTIgKzE3NCwxMyBAQCBzZXJ2ZXItdGVz dHMvc2VydmVyLWZvcmNlLXN0b3Ava2VlcHMtZnJhbWVzCiB0ZXN0cyB0aGF0IGBzZXJ2ZXIt Zm9yY2Utc3RvcCcgZG9lc24ndCBkZWxldGUgZnJhbWVzIChhbmQgZXZlbgogdGhlbiwgcmVx dWlyZXMgYSBmZXcgdHJpY2tzIHRvIHJ1biBhcyBhIHJlZ3Jlc3Npb24gdGVzdCkuICBTbwog bG9uZyBhcyB0aGlzIHdvcmtzLCB0aGUgcHJvYmxlbSBpbiBidWcjNTg4Nzcgc2hvdWxkbid0 IG9jY3VyLiIKLSAgKGxldCAodGVybWluYWwpCisgIChsZXQgKChzdGFydGluZy1mcmFtZS1j b3VudCAobGVuZ3RoIChmcmFtZS1saXN0KSkpCisgICAgICAgIHRlcm1pbmFsKQogICAgICh1 bndpbmQtcHJvdGVjdAogICAgICAgICAoc2VydmVyLXRlc3RzL3dpdGgtc2VydmVyCi0gICAg ICAgICAgKGxldCAoKGVtYWNzY2xpZW50IChzZXJ2ZXItdGVzdHMvc3RhcnQtZW1hY3NjbGll bnQgIi1jIikpKQotICAgICAgICAgICAgKHNlcnZlci10ZXN0cy93YWl0LXVudGlsIChsZW5n dGg9IChmcmFtZS1saXN0KSAyKSkKKyAgICAgICAgICAoc2VydmVyLXRlc3RzL3dpdGgtY2xp ZW50IGVtYWNzY2xpZW50ICcoIi1jIikgJ2V4aXQKICAgICAgICAgICAgIChzaG91bGQgKGVx IChwcm9jZXNzLXN0YXR1cyBlbWFjc2NsaWVudCkgJ3J1bikpCisgICAgICAgICAgICAoc2hv dWxkIChsZW5ndGg9IChmcmFtZS1saXN0KSAoMSsgc3RhcnRpbmctZnJhbWUtY291bnQpKSkK IAogICAgICAgICAgICAgOzsgRG9uJ3QgZGVsZXRlIHRoZSB0ZXJtaW5hbCBmb3IgdGhlIGNs aWVudDsgdGhhdCB3b3VsZAogICAgICAgICAgICAgOzsga2lsbCBpdHMgZnJhbWUgaW1tZWRp YXRlbHkgdG9vLiAgKFRoaXMgaXMgb25seSBhbiBpc3N1ZQpAQCAtMTU5LDcgKzE5NSw3IEBA IHNlcnZlci10ZXN0cy9zZXJ2ZXItZm9yY2Utc3RvcC9rZWVwcy1mcmFtZXMKIAogICAgICAg ICAgICAgKHNlcnZlci1mb3JjZS1zdG9wKSkKICAgICAgICAgICA7OyBFbnN1cmUgd2UgZGlk bid0IGRlbGV0ZSB0aGUgZnJhbWUuCi0gICAgICAgICAgKHNob3VsZCAobGVuZ3RoPSAoZnJh bWUtbGlzdCkgMikpKQorICAgICAgICAgIChzaG91bGQgKGxlbmd0aD0gKGZyYW1lLWxpc3Qp ICgxKyBzdGFydGluZy1mcmFtZS1jb3VudCkpKSkKICAgICAgIDs7IENsZWFuIHVwIGFmdGVy IG91cnNlbHZlcyBhbmQgZGVsZXRlIHRoZSB0ZXJtaW5hbC4KICAgICAgICh3aGVuIChhbmQg dGVybWluYWwKICAgICAgICAgICAgICAgICAgKGVxICh0ZXJtaW5hbC1saXZlLXAgdGVybWlu YWwpIHQpCi0tIAoyLjI1LjEKCg== --------------nbOFHUZelf0JSqm0JfI0QuBO-- From unknown Sat Jun 14 04:55:23 2025 X-Loop: help-debbugs@gnu.org Subject: bug#58877: 29.0.50; [PATCH] When killing Emacs from a client frame with no other frames, Emacs shows a useless error prompt Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 26 Nov 2022 19:46:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58877 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Jim Porter Cc: 58877@debbugs.gnu.org Received: via spool by 58877-submit@debbugs.gnu.org id=B58877.166949190524861 (code B ref 58877); Sat, 26 Nov 2022 19:46:02 +0000 Received: (at 58877) by debbugs.gnu.org; 26 Nov 2022 19:45:05 +0000 Received: from localhost ([127.0.0.1]:41492 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oz16m-0006Sv-La for submit@debbugs.gnu.org; Sat, 26 Nov 2022 14:45:04 -0500 Received: from eggs.gnu.org ([209.51.188.92]:43732) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oz16k-0006SF-8x for 58877@debbugs.gnu.org; Sat, 26 Nov 2022 14:45:02 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oz16e-0007f0-Ut; Sat, 26 Nov 2022 14:44:56 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=n5VsdGjLoYtasJftUQrzXotQxwj9FcZ8IiOuZhcTUg0=; b=Vx0/KBkF9fTC 26h4Cb5uVUcB9ull1FF6I01QpVdjdFNTwt/fjR90z6OfVPbA29QFGeS3Kxx3RrHB3GPckhnjidgXo 6G3ALRxgAlEMQFzyENvEzlgWbxufdhcapjhK/B0cU3QZHtwdpQn/js1vbR72bPW9Ne+waWyfkdRRI JFySmkJRnln7IlUwvFJwdqeFGhYVsr3eYW/ab6oQVzPWcRZyLgeiODx1XaWhTszeDirTdtmFIdZcv LDOvp9xbVRhLlQudTSvffgp2a6IdeUzwv/Tkj0VV3V6wzfbMEf6WTfP1GmM2XJ6P0n8lN8JlYCoY2 OWe8at05UgGgobP87pjMVw==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oz16c-0005LI-Aj; Sat, 26 Nov 2022 14:44:54 -0500 Date: Sat, 26 Nov 2022 21:45:19 +0200 Message-Id: <83v8n1qz3k.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: (message from Jim Porter on Sat, 26 Nov 2022 11:04:48 -0800) References: <8121efd5-77c3-0682-ce0f-6be9375dadd8@gmail.com> <83a65dhm7f.fsf@gnu.org> <13835614-c593-ba2d-5373-a9950f6f3dab@gmail.com> <83k03kwoy6.fsf@gnu.org> <83a64fupwv.fsf@gnu.org> <83wn7iu6rz.fsf@gnu.org> <83ilj1srma.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Sat, 26 Nov 2022 11:04:48 -0800 > Cc: 58877@debbugs.gnu.org > From: Jim Porter > > > I think you need to modify the tests to ensure the server file is created in > > a temporary directory. And keep in mind that the variable which affects > > that is different depending on whether server-use-tcp is or isn't non-nil. > > Hm, I'm surprised the tests failed again for you then. Both of the > patches I posted to fix the tests set the 'server-name' to a (hopefully) > unique value. > > Still, I think it's a good idea to use a temporary directory to hold the > server file, so here's a patch that does that. I've tried this patch > with a production Emacs server running at the same time in several > different configurations (with 'server-use-tcp' on and off, and with > --daemon), and the tests all pass locally for me on GNU/Linux. Still fails, and here's why: Client output: d:\gnu\git\emacs\trunk\lib-src\emacsclient.exe: unrecognized option '--socket-name' Try 'd:\gnu\git\emacs\trunk\lib-src\emacsclient.exe --help' for more information Process d:/gnu/git/emacs/trunk/lib-src/emacsclient exited abnormally with code 1 There's no --socket-name switch on MS-Windows; you need to use --server-file instead. If I change server-tests/start-client to use --server-file, the next problem rears its ugly head: Client output: *ERROR*: Not using an ASCII terminal now; cannot make a new ASCII frame Process d:/gnu/git/emacs/trunk/lib-src/emacsclient exited abnormally with code 1 This is because emacsclient on Windows cannot create new terminal frames, only new GUI frames, unless Emacs was started as "emacs -nw". Why do these tests need TTY frames? Btw, with the above changes, only 3 tests fail: 3 unexpected results: FAILED server-tests/emacsclient/create-frame FAILED server-tests/server-force-stop/keeps-frames FAILED server-tests/server-start/stop-prompt-with-client So this is progress, thanks. From unknown Sat Jun 14 04:55:23 2025 X-Loop: help-debbugs@gnu.org Subject: bug#58877: 29.0.50; [PATCH] When killing Emacs from a client frame with no other frames, Emacs shows a useless error prompt Resent-From: Jim Porter Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 26 Nov 2022 20:19:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58877 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Eli Zaretskii Cc: 58877@debbugs.gnu.org Received: via spool by 58877-submit@debbugs.gnu.org id=B58877.166949389026116 (code B ref 58877); Sat, 26 Nov 2022 20:19:02 +0000 Received: (at 58877) by debbugs.gnu.org; 26 Nov 2022 20:18:10 +0000 Received: from localhost ([127.0.0.1]:41533 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oz1co-0006nA-0y for submit@debbugs.gnu.org; Sat, 26 Nov 2022 15:18:10 -0500 Received: from mail-pf1-f170.google.com ([209.85.210.170]:37583) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oz1cl-0006mk-0V for 58877@debbugs.gnu.org; Sat, 26 Nov 2022 15:18:08 -0500 Received: by mail-pf1-f170.google.com with SMTP id a16so6544155pfg.4 for <58877@debbugs.gnu.org>; Sat, 26 Nov 2022 12:18:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to; bh=gmYbM9tfS/BxCHw6cBFJuTd8q2oD5m03tezcWQlwmDI=; b=NH4PLHzwjH8i0ZHp/1YMzPdQfNGO+/5JJ2vnydliR/PvD+da/RJzfOwTqu1EnYMZFF 9qcuct/IiKDCVR2fDS8XeWTq0rrhvk9tcqIVF8bPAhknRjdf6BZoBRC91fKsHE1VtLOC tshqwKbeR/CNbw5wcStrMhmkEPY/DILwIIaa4hO6y1s1zR8WvFDFyuHog0TKKV4GBSRn 2KMtOzHrAoRjhSFVH6Duxs74Sf8ZJ/62fWBEUggbKCo5lUYfYpcIcpNt1HKcji6K4PyH D9H2ZiLiCTDbJXGRNFjG17WckwGqc7TF6sdPmGSHrAVW99oXZ0dSHFBBAcIcj42UVR++ NoeA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=gmYbM9tfS/BxCHw6cBFJuTd8q2oD5m03tezcWQlwmDI=; b=o2yqd6tWbqzlr3KQGWCcso9KIp/FS2BcUGl4nn/nGI7bHeOQJS8dUoXy4KwdLoeRRz GEw2TeUCSDHkS7n1ete7Ub1n5oYWwKj5Tcj3g8nPqAm2C7VGRqCP1iy2wr88aGo1vxWi T0Ziahjr3puThTfYfd/WORgv51yuwBj0SGdExwmJt0/1DLn8FK7re5ZUFHO5BTA3YtmT xIqiBaMAupsmNedjfDXTZCpQlO9QfnV8dk/bNE/y7EmcQQyfvEPAqRExvPq6OOio52ip lC2Mkr36WslH8zDW9yuK3XS85xDv4CIMUOnALeEfDww9gX2XW5brwwMSVSHpuTd9EVXi Bdew== X-Gm-Message-State: ANoB5pnHYh17cRqPGqYNeQUmmeoZdeBzyphctzoiEFiFCL9zALXBekwb bEgZ2n1ry6aPBbggdV6SsWc= X-Google-Smtp-Source: AA0mqf7tDFrCyXY7B/kha4QhakeSxSTPEppHjSEdAzbxk5un3T+fSQeD2POEtNN9EADG1aEGyjv6IQ== X-Received: by 2002:aa7:988b:0:b0:574:c00f:7df4 with SMTP id r11-20020aa7988b000000b00574c00f7df4mr8528332pfl.49.1669493881246; Sat, 26 Nov 2022 12:18:01 -0800 (PST) Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id 126-20020a621784000000b0056bb0357f5bsm5064911pfx.192.2022.11.26.12.18.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 26 Nov 2022 12:18:00 -0800 (PST) Message-ID: <2be2d630-f4da-16f9-5afc-9f6561a9995a@gmail.com> Date: Sat, 26 Nov 2022 12:17:59 -0800 MIME-Version: 1.0 Content-Language: en-US References: <8121efd5-77c3-0682-ce0f-6be9375dadd8@gmail.com> <83a65dhm7f.fsf@gnu.org> <13835614-c593-ba2d-5373-a9950f6f3dab@gmail.com> <83k03kwoy6.fsf@gnu.org> <83a64fupwv.fsf@gnu.org> <83wn7iu6rz.fsf@gnu.org> <83ilj1srma.fsf@gnu.org> <83v8n1qz3k.fsf@gnu.org> From: Jim Porter In-Reply-To: <83v8n1qz3k.fsf@gnu.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 11/26/2022 11:45 AM, Eli Zaretskii wrote: >> Date: Sat, 26 Nov 2022 11:04:48 -0800 >> Cc: 58877@debbugs.gnu.org >> From: Jim Porter >> >>> I think you need to modify the tests to ensure the server file is created in >>> a temporary directory. And keep in mind that the variable which affects >>> that is different depending on whether server-use-tcp is or isn't non-nil. >> >> Hm, I'm surprised the tests failed again for you then. Both of the >> patches I posted to fix the tests set the 'server-name' to a (hopefully) >> unique value. >> >> Still, I think it's a good idea to use a temporary directory to hold the >> server file, so here's a patch that does that. I've tried this patch >> with a production Emacs server running at the same time in several >> different configurations (with 'server-use-tcp' on and off, and with >> --daemon), and the tests all pass locally for me on GNU/Linux. > > Still fails, and here's why: > > Client output: d:\gnu\git\emacs\trunk\lib-src\emacsclient.exe: unrecognized option '--socket-name' > Try 'd:\gnu\git\emacs\trunk\lib-src\emacsclient.exe --help' for more information > > Process d:/gnu/git/emacs/trunk/lib-src/emacsclient exited abnormally with code 1 > > There's no --socket-name switch on MS-Windows; you need to use --server-file > instead. Ah ha, that explains it. I didn't realize that distinction. > If I change server-tests/start-client to use --server-file, the next problem > rears its ugly head: > > Client output: *ERROR*: Not using an ASCII terminal now; cannot make a new ASCII frame > > Process d:/gnu/git/emacs/trunk/lib-src/emacsclient exited abnormally with code 1 > > This is because emacsclient on Windows cannot create new terminal frames, > only new GUI frames, unless Emacs was started as "emacs -nw". > > Why do these tests need TTY frames? The test code just calls "emacsclient -c", and they should be happy with any kind of frame, TTY or GUI. I guess that by running in batch mode, Emacs will try to create TTY frames, but that fails on MS Windows? > Btw, with the above changes, only 3 tests fail: > > 3 unexpected results: > FAILED server-tests/emacsclient/create-frame > FAILED server-tests/server-force-stop/keeps-frames > FAILED server-tests/server-start/stop-prompt-with-client > > So this is progress, thanks. All these tests involve creating client frames, so that makes sense. I'm not sure how to coax Emacs into creating GUI frames on MS Windows for these tests though. Still, I don't think these failures are a sign of anything broken exactly; it's just the combination of MS Windows' limitations with trying to create frames in an Emacs batch session. Unless you have an idea for how to fix that (I've got no clue, unfortunately), how about just skipping these tests on MS Windows, with a comment explaining what the limitation is? From unknown Sat Jun 14 04:55:23 2025 X-Loop: help-debbugs@gnu.org Subject: bug#58877: 29.0.50; [PATCH] When killing Emacs from a client frame with no other frames, Emacs shows a useless error prompt Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 26 Nov 2022 20:36:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58877 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Jim Porter Cc: 58877@debbugs.gnu.org Received: via spool by 58877-submit@debbugs.gnu.org id=B58877.166949494226750 (code B ref 58877); Sat, 26 Nov 2022 20:36:01 +0000 Received: (at 58877) by debbugs.gnu.org; 26 Nov 2022 20:35:42 +0000 Received: from localhost ([127.0.0.1]:41548 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oz1tm-0006xO-DS for submit@debbugs.gnu.org; Sat, 26 Nov 2022 15:35:42 -0500 Received: from eggs.gnu.org ([209.51.188.92]:34014) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oz1ti-0006xI-4z for 58877@debbugs.gnu.org; Sat, 26 Nov 2022 15:35:41 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oz1tc-0006ir-0J; Sat, 26 Nov 2022 15:35:32 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=QOF76dJOHnGCAm+9ogstrIWiYg3pjSli9HJRZ2kgw9A=; b=SFnsGxSpPwIA 2VSkvL3xu5CIQqov1ufMW7HKioV69+L8AoyaDDWlYBbXXBYn9aoDvVBTD77e3DmrDiIiCocA3IhxN 8VReVQ7I8hd6+G30d+5W74QhSm7HM50KzImvklldF1X2zCt4VdEMW06E3ScLbGpF0hikTIJSiA+SZ ZnxkFYJTXeSHDNNhI/M2bya0RPW9QqjW0/3E7iiWUI9gNkGGJTxzxQ3vbUhAjjV9lUKHVBmfzoPl3 nu+wajiewFyymaneh4PdhU3PJ4h7Xldny1HP92lCTiPQ9kWHzElofglq52JbH3ybxG4mperOWzsGO ZFDr/wm6Hxnyzr/ejVsV7A==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oz1tb-00059s-FU; Sat, 26 Nov 2022 15:35:31 -0500 Date: Sat, 26 Nov 2022 22:35:57 +0200 Message-Id: <83r0xpqwr6.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: <2be2d630-f4da-16f9-5afc-9f6561a9995a@gmail.com> (message from Jim Porter on Sat, 26 Nov 2022 12:17:59 -0800) References: <8121efd5-77c3-0682-ce0f-6be9375dadd8@gmail.com> <83a65dhm7f.fsf@gnu.org> <13835614-c593-ba2d-5373-a9950f6f3dab@gmail.com> <83k03kwoy6.fsf@gnu.org> <83a64fupwv.fsf@gnu.org> <83wn7iu6rz.fsf@gnu.org> <83ilj1srma.fsf@gnu.org> <83v8n1qz3k.fsf@gnu.org> <2be2d630-f4da-16f9-5afc-9f6561a9995a@gmail.com> X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Sat, 26 Nov 2022 12:17:59 -0800 > Cc: 58877@debbugs.gnu.org > From: Jim Porter > > > Client output: *ERROR*: Not using an ASCII terminal now; cannot make a new ASCII frame > > > > Process d:/gnu/git/emacs/trunk/lib-src/emacsclient exited abnormally with code 1 > > > > This is because emacsclient on Windows cannot create new terminal frames, > > only new GUI frames, unless Emacs was started as "emacs -nw". > > > > Why do these tests need TTY frames? > > The test code just calls "emacsclient -c", and they should be happy with > any kind of frame, TTY or GUI. I guess that by running in batch mode, > Emacs will try to create TTY frames, but that fails on MS Windows? I guess. And I'm not prepared to spend time trying to make emacsclient work with a batch-mode server on MS-Windows. > > Btw, with the above changes, only 3 tests fail: > > > > 3 unexpected results: > > FAILED server-tests/emacsclient/create-frame > > FAILED server-tests/server-force-stop/keeps-frames > > FAILED server-tests/server-start/stop-prompt-with-client > > > > So this is progress, thanks. > > All these tests involve creating client frames, so that makes sense. I'm > not sure how to coax Emacs into creating GUI frames on MS Windows for > these tests though. Still, I don't think these failures are a sign of > anything broken exactly; it's just the combination of MS Windows' > limitations with trying to create frames in an Emacs batch session. > > Unless you have an idea for how to fix that (I've got no clue, > unfortunately), how about just skipping these tests on MS Windows, with > a comment explaining what the limitation is? Fine with me, thanks. From unknown Sat Jun 14 04:55:23 2025 X-Loop: help-debbugs@gnu.org Subject: bug#58877: 29.0.50; [PATCH] When killing Emacs from a client frame with no other frames, Emacs shows a useless error prompt Resent-From: Jim Porter Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 26 Nov 2022 21:45:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58877 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Eli Zaretskii Cc: 58877@debbugs.gnu.org Received: via spool by 58877-submit@debbugs.gnu.org id=B58877.166949910129118 (code B ref 58877); Sat, 26 Nov 2022 21:45:02 +0000 Received: (at 58877) by debbugs.gnu.org; 26 Nov 2022 21:45:01 +0000 Received: from localhost ([127.0.0.1]:41604 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oz2yq-0007Za-KH for submit@debbugs.gnu.org; Sat, 26 Nov 2022 16:45:00 -0500 Received: from mail-pg1-f176.google.com ([209.85.215.176]:35405) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oz2yo-0007ZU-Mj for 58877@debbugs.gnu.org; Sat, 26 Nov 2022 16:44:59 -0500 Received: by mail-pg1-f176.google.com with SMTP id f3so6688514pgc.2 for <58877@debbugs.gnu.org>; Sat, 26 Nov 2022 13:44:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to; bh=r8vjRd3sqv5c6bLWNKqSJwKba3dMxzdlc2xEe2nL/gM=; b=OXi58zSF+fL8nTiUYQXomkcjbeiCYEUEagEyYJUrrdTZKKlz1keW/sbM6k68r6/gsg DaOx0Ep3eE00Lw/oKjnEojVypkm/DD5ftvfFWlTeYv8kimyE0MZOHfnUYRjApDdjpXJ7 +xkk5k7cHfOlAc0as2Fzyq45qofvcBlKL4QYmRhsH5S/zvQyICE6wOaMrVVu9eHpVAuO A2t/ts1ZDSIooljStGSeGHxvIM6byuqUr5H7jiuRoah9Vlz8hbBTGM39eQq0dHpSaCNX enQ7wQkRkqk+ppIHgpIi+rNxE0VINmnXCFQTY0YoI9P3sMH0Oaxq/YpjFYT76fV4ZS13 zP/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=r8vjRd3sqv5c6bLWNKqSJwKba3dMxzdlc2xEe2nL/gM=; b=p24FJO6WPY3LScA+MxsonFu9vDq04Xsq1SjF0hk4a000qsMBTxcdGSBVasXNCWgQZ3 Un/OZHvokqtQhd/ZsLz6CZ8lTpXWrTvIMAk4cn7zBth42Ee+cBqqD2xw/mpfI5MJa9kR SC7ZiedoWiNUIW16sLkQaCSU1I1cSLgCx4aeu4OotvnFq0Ph58BHS7V6VAyhEqCaIOf1 7M0EdHLGB6OS42KWXOHUHCKcSVdeuc2UkMCz5XX4g1cGb9sq6/RziZsezfJ6CPi4yOa/ uoSKGUyicZjRQGHK56Jw6ew0hovUnBMwysEqiMZ+XtXnj7Shb6USzVbeA625oY5VMRkK PQpw== X-Gm-Message-State: ANoB5pnZ3l6LtPiZcr1l+G7tT6dzoUsLyPDchwBZUPEnEGW73eH4K2kW 1rhOb11u1vhoGoBj6BuCvmL6OfEQCgA= X-Google-Smtp-Source: AA0mqf5zEBzaIwIhkCw2TylCJBcFV+OCPdfK7SyC5oGczuRNFY1Y3jvJI0LpGK8cpc9cptdJ42Ox9Q== X-Received: by 2002:aa7:9245:0:b0:571:3fb3:9b5f with SMTP id 5-20020aa79245000000b005713fb39b5fmr45846250pfp.86.1669499092577; Sat, 26 Nov 2022 13:44:52 -0800 (PST) Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id s28-20020aa78bdc000000b0056bcb102e7bsm5171689pfd.68.2022.11.26.13.44.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 26 Nov 2022 13:44:51 -0800 (PST) Message-ID: Date: Sat, 26 Nov 2022 13:44:50 -0800 MIME-Version: 1.0 Content-Language: en-US References: <8121efd5-77c3-0682-ce0f-6be9375dadd8@gmail.com> <83a65dhm7f.fsf@gnu.org> <13835614-c593-ba2d-5373-a9950f6f3dab@gmail.com> <83k03kwoy6.fsf@gnu.org> <83a64fupwv.fsf@gnu.org> <83wn7iu6rz.fsf@gnu.org> <83ilj1srma.fsf@gnu.org> <83v8n1qz3k.fsf@gnu.org> <2be2d630-f4da-16f9-5afc-9f6561a9995a@gmail.com> <83r0xpqwr6.fsf@gnu.org> From: Jim Porter In-Reply-To: <83r0xpqwr6.fsf@gnu.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 11/26/2022 12:35 PM, Eli Zaretskii wrote: >> Date: Sat, 26 Nov 2022 12:17:59 -0800 >> Cc: 58877@debbugs.gnu.org >> From: Jim Porter >> >> Unless you have an idea for how to fix that (I've got no clue, >> unfortunately), how about just skipping these tests on MS Windows, with >> a comment explaining what the limitation is? > > Fine with me, thanks. Thanks. I've merged the fixes for the tests as 14d54212ea46dbd8c950c9852318597e0e47908d. If you see any other issues, just let me know. From unknown Sat Jun 14 04:55:23 2025 X-Loop: help-debbugs@gnu.org Subject: bug#58877: 29.0.50; [PATCH] When killing Emacs from a client frame with no other frames, Emacs shows a useless error prompt Resent-From: Jim Porter Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 28 Nov 2022 01:29:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58877 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Eli Zaretskii Cc: 58877@debbugs.gnu.org Received: via spool by 58877-submit@debbugs.gnu.org id=B58877.166959893120495 (code B ref 58877); Mon, 28 Nov 2022 01:29:01 +0000 Received: (at 58877) by debbugs.gnu.org; 28 Nov 2022 01:28:51 +0000 Received: from localhost ([127.0.0.1]:45295 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ozSx1-0005KV-Co for submit@debbugs.gnu.org; Sun, 27 Nov 2022 20:28:51 -0500 Received: from mail-pg1-f175.google.com ([209.85.215.175]:41774) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ozSwz-0005KP-7P for 58877@debbugs.gnu.org; Sun, 27 Nov 2022 20:28:49 -0500 Received: by mail-pg1-f175.google.com with SMTP id q71so8617614pgq.8 for <58877@debbugs.gnu.org>; Sun, 27 Nov 2022 17:28:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:references:cc:to:from:content-language:subject :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=MQuEdajQXaR8WC6WOKo5Yp5LXiR43+e664xuWcNjsZs=; b=hdG+vXjzNAyQYwocGXIeGj9WJJYKbMJuF1rB4c6wqJsgaAdAPcQFL6aFDZ3GkJYsT8 V3Yymv902sP6nUC6dR3TLAEezT1vnHxdt4CeulP9P6bFbUqS1TLePkL9FIOw5BijgMZ/ xkbyceUNr98Gcsaerknrzyi93z2GQucUmzSqin3hqTNMoN5KGJuhXeek/kyvL/0k8eOG ja2R1LwXr3nndU9KJhVNNZci5dnpaZ+7JxRMdCBkEGxg5JBd3PL/tyjHjtRgdS/7qa3+ Mg/UEOXBAxuH0B0qvGee2Il/jp1KY/65cfk+tkGdAziJ9W8XFjWzJbcD24/uEFYK7lqD 8zVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:references:cc:to:from:content-language:subject :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=MQuEdajQXaR8WC6WOKo5Yp5LXiR43+e664xuWcNjsZs=; b=ht/Zhku4o7qmLrHgLfmutp39o6Sb19LoLVztz3mJI6Z2khynTxuVq+uKOdv9EhcBRK UtknmMJM9QCTmiohrCzi7W2HDwHBAZ8ASLn4Cu00hDUkKTHcTWaWrDzo0IT37vNW2vSq lb+9dnodG0RcMqNJFG+XDAZMJRM7vJT9Yx5hqNutSJY/ik0qrOjvIY5MuL9FnuyV+VcK 5IAXB0Dz3L1vTmO8J8vpvA/k9PqgTEfs8neHjSfrfRztEpxhIwt2Lwi1VjMw7GrMd5WL fc9KyXa4crvkPySj+RGge8gAuFsMebnEoF5POBc2zUeTzW6H/jyX050R/RjvWGGcrK0/ XgtA== X-Gm-Message-State: ANoB5pmAQzex6n0cFMW24g6YUGgS/4d4J6iGbivWbi5QznRLYNlZXLWC hXzjG4dURGsnBzYHMoj0MJs= X-Google-Smtp-Source: AA0mqf4L+/iwzOS0W5Jn2DYh6rPZ9ueG8toluSbPXEE3W+nQ+Lhg1gCfTLfQj7R6fluxBLysSnLDcw== X-Received: by 2002:a63:fa41:0:b0:476:e84c:ab65 with SMTP id g1-20020a63fa41000000b00476e84cab65mr26727698pgk.513.1669598923229; Sun, 27 Nov 2022 17:28:43 -0800 (PST) Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id 17-20020a170902e9d100b0018544ad1e8esm7407115plk.238.2022.11.27.17.28.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 27 Nov 2022 17:28:42 -0800 (PST) Content-Type: multipart/mixed; boundary="------------rCu4dtq0AeEu0M8vJUh4mjwg" Message-ID: <393cb671-cfab-8e7e-6229-b59a1e376e1b@gmail.com> Date: Sun, 27 Nov 2022 17:28:41 -0800 MIME-Version: 1.0 Content-Language: en-US From: Jim Porter References: <8121efd5-77c3-0682-ce0f-6be9375dadd8@gmail.com> <83a65dhm7f.fsf@gnu.org> <13835614-c593-ba2d-5373-a9950f6f3dab@gmail.com> <83k03kwoy6.fsf@gnu.org> <83a64fupwv.fsf@gnu.org> <83wn7iu6rz.fsf@gnu.org> <83ilj1srma.fsf@gnu.org> <83v8n1qz3k.fsf@gnu.org> <2be2d630-f4da-16f9-5afc-9f6561a9995a@gmail.com> <83r0xpqwr6.fsf@gnu.org> In-Reply-To: X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) This is a multi-part message in MIME format. --------------rCu4dtq0AeEu0M8vJUh4mjwg Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 11/26/2022 1:44 PM, Jim Porter wrote: > On 11/26/2022 12:35 PM, Eli Zaretskii wrote: >>> Date: Sat, 26 Nov 2022 12:17:59 -0800 >>> Cc: 58877@debbugs.gnu.org >>> From: Jim Porter >>> >>> Unless you have an idea for how to fix that (I've got no clue, >>> unfortunately), how about just skipping these tests on MS Windows, with >>> a comment explaining what the limitation is? >> >> Fine with me, thanks. > > Thanks. I've merged the fixes for the tests as > 14d54212ea46dbd8c950c9852318597e0e47908d. If you see any other issues, > just let me know. Here's one tiny followup fix. Currently on master, if you restart the Emacs server, it emits a "Server stopped" message. That's not right, and it should do what it used to: emit a "Restarting server" message. Here's a fix. --------------rCu4dtq0AeEu0M8vJUh4mjwg Content-Type: text/plain; charset=UTF-8; name="0001-Don-t-emit-a-Server-stopped-message-when-restarting-.patch" Content-Disposition: attachment; filename*0="0001-Don-t-emit-a-Server-stopped-message-when-restarting-.pa"; filename*1="tch" Content-Transfer-Encoding: base64 RnJvbSAxNzI0ZjIzZjNkOGIzYmVmMThiY2Q5N2UyZjg5MmU5NDNmMDNjMGRhIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKaW0gUG9ydGVyIDxqcG9ydGVyYnVnc0BnbWFpbC5j b20+CkRhdGU6IFN1biwgMjcgTm92IDIwMjIgMTc6MjI6NDkgLTA4MDAKU3ViamVjdDogW1BB VENIXSA7IERvbid0IGVtaXQgYSAiU2VydmVyIHN0b3BwZWQiIG1lc3NhZ2Ugd2hlbiByZXN0 YXJ0aW5nIHRoZQogRW1hY3Mgc2VydmVyCgoqIGxpc3Avc2VydmVyLmVsIChzZXJ2ZXItc3Rv cCk6IFJldHVybiBub24tbmlsIHdoZW4gd2UgYWN0dWFsbHkgc3RvcAp0aGUgc2VydmVyLiAg RG9uJ3QgbWVzc2FnZSBhYm91dCBzdG9wcGluZyB0aGUgc2VydmVyIGhlcmUgKGJ1dCBkbyBs b2cKaXQpLgooc2VydmVyLXN0YXJ0KTogRW1pdCB0aGUgYXBwcm9wcmlhdGUgbWVzc2FnZSBh Ym91dCBzdG9wcGluZyBvcgpyZXN0YXJ0aW5nIHRoZSBzZXJ2ZXIuCi0tLQogbGlzcC9zZXJ2 ZXIuZWwgfCAyMiArKysrKysrKysrKystLS0tLS0tLS0tCiAxIGZpbGUgY2hhbmdlZCwgMTIg aW5zZXJ0aW9ucygrKSwgMTAgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvbGlzcC9zZXJ2 ZXIuZWwgYi9saXNwL3NlcnZlci5lbAppbmRleCAyMTAyZjg1NjliLi4xYjAyN2Y4OGNlIDEw MDY0NAotLS0gYS9saXNwL3NlcnZlci5lbAorKysgYi9saXNwL3NlcnZlci5lbApAQCAtNjE5 LDIwICs2MTksMjIgQEAgc2VydmVyLS1maWxlLW5hbWUKIAogKGRlZnVuIHNlcnZlci1zdG9w ICgmb3B0aW9uYWwgbm9mcmFtZSkKICAgIklmIHRoaXMgRW1hY3MgcHJvY2VzcyBoYXMgYSBz ZXJ2ZXIgY29tbXVuaWNhdGlvbiBzdWJwcm9jZXNzLCBzdG9wIGl0LgotSWYgdGhlIHNlcnZl ciBpcyBydW5uaW5nIGluIHNvbWUgb3RoZXIgRW1hY3MgcHJvY2VzcyAoc2VlCitJZiB0aGlz IGFjdHVhbGx5IHN0b3BwZWQgdGhlIHNlcnZlciwgcmV0dXJuIG5vbi1uaWwuICBJZiB0aGUK K3NlcnZlciBpcyBydW5uaW5nIGluIHNvbWUgb3RoZXIgRW1hY3MgcHJvY2VzcyAoc2VlCiBg c2VydmVyLXJ1bm5pbmctcCcpLCBzaWduYWwgYSBgc2VydmVyLXJ1bm5pbmctZXh0ZXJuYWwn IGVycm9yLgogCiBJZiBOT0ZSQU1FIGlzIG5vbi1uaWwsIGRvbid0IGRlbGV0ZSBhbnkgZXhp c3RpbmcgZnJhbWVzCiBhc3NvY2lhdGVkIHdpdGggYSBjbGllbnQgcHJvY2Vzcy4gIFRoaXMg aXMgdXNlZnVsLCBmb3IgZXhhbXBsZSwKIHdoZW4ga2lsbGluZyBFbWFjcywgaW4gd2hpY2gg Y2FzZSB0aGUgZnJhbWVzIHdpbGwgZ2V0IGRlbGV0ZWQKIGFueXdheS4iCi0gIChsZXQgKChz ZXJ2ZXItZmlsZSAoc2VydmVyLS1maWxlLW5hbWUpKSkKKyAgKGxldCAoKHNlcnZlci1maWxl IChzZXJ2ZXItLWZpbGUtbmFtZSkpCisgICAgICAgIHN0b3BwZWQtcCkKICAgICAod2hlbiBz ZXJ2ZXItcHJvY2VzcwogICAgICAgOzsgS2lsbCBpdCBkZWFkIQogICAgICAgKGlnbm9yZS1l cnJvcnMgKGRlbGV0ZS1wcm9jZXNzIHNlcnZlci1wcm9jZXNzKSkKLSAgICAgICh1bmxlc3Mg bm9mcmFtZQotICAgICAgICAoc2VydmVyLWxvZyAobWVzc2FnZSAiU2VydmVyIHN0b3BwZWQi KSkpCi0gICAgICAoc2V0cSBzZXJ2ZXItcHJvY2VzcyBuaWwKKyAgICAgIChzZXJ2ZXItbG9n ICJTdG9wcGVkIHNlcnZlciIpCisgICAgICAoc2V0cSBzdG9wcGVkLXAgdAorICAgICAgICAg ICAgc2VydmVyLXByb2Nlc3MgbmlsCiAgICAgICAgICAgICBzZXJ2ZXItbW9kZSBuaWwKICAg ICAgICAgICAgIGdsb2JhbC1taW5vci1tb2RlcyAoZGVscSAnc2VydmVyLW1vZGUgZ2xvYmFs LW1pbm9yLW1vZGVzKSkpCiAgICAgKHVud2luZC1wcm90ZWN0CkBAIC02NTgsNyArNjYwLDgg QEAgc2VydmVyLXN0b3AKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBzZXJ2 ZXItbmFtZSkpKSkKICAgICAgIDs7IElmIHRoaXMgRW1hY3MgYWxyZWFkeSBoYWQgYSBzZXJ2 ZXIsIGNsZWFyIG91dCBhc3NvY2lhdGVkIHN0YXR1cy4KICAgICAgICh3aGlsZSBzZXJ2ZXIt Y2xpZW50cwotICAgICAgICAoc2VydmVyLWRlbGV0ZS1jbGllbnQgKGNhciBzZXJ2ZXItY2xp ZW50cykgbm9mcmFtZSkpKSkpCisgICAgICAgIChzZXJ2ZXItZGVsZXRlLWNsaWVudCAoY2Fy IHNlcnZlci1jbGllbnRzKSBub2ZyYW1lKSkpCisgICAgc3RvcHBlZC1wKSkKIAogOzs7IyMj YXV0b2xvYWQKIChkZWZ1biBzZXJ2ZXItc3RhcnQgKCZvcHRpb25hbCBsZWF2ZS1kZWFkIGlu aGliaXQtcHJvbXB0KQpAQCAtNzAyLDcgKzcwNSw4IEBAIHNlcnZlci1zdGFydAogICAgICAg ICAoaWYgKGFuZCBpbnRlcm5hbC0tZGFlbW9uLXNvY2tuYW1lCiAgICAgICAgICAgICAgICAg IChub3Qgc2VydmVyLS1leHRlcm5hbC1zb2NrZXQtaW5pdGlhbGl6ZWQpKQogICAgICAgICAg ICAgKHNldHEgc2VydmVyLS1leHRlcm5hbC1zb2NrZXQtaW5pdGlhbGl6ZWQgdCkKLSAgICAg ICAgICAoc2VydmVyLXN0b3ApKQorICAgICAgICAgICh3aGVuIChzZXJ2ZXItc3RvcCkKKyAg ICAgICAgICAgIChtZXNzYWdlIChpZiBsZWF2ZS1kZWFkICJTdG9wcGVkIHNlcnZlciIgIlJl c3RhcnRpbmcgc2VydmVyIikpKSkKICAgICAgIChzZXJ2ZXItcnVubmluZy1leHRlcm5hbAog ICAgICAgIChkaXNwbGF5LXdhcm5pbmcKICAgICAgICAgJ3NlcnZlcgpAQCAtNzE3LDggKzcy MSw2IEBAIHNlcnZlci1zdGFydAogICAgICAgKGxldCAoKHNlcnZlci1maWxlIChzZXJ2ZXIt LWZpbGUtbmFtZSkpKQogCTs7IE1ha2Ugc3VyZSB0aGVyZSBpcyBhIHNhZmUgZGlyZWN0b3J5 IGluIHdoaWNoIHRvIHBsYWNlIHRoZSBzb2NrZXQuCiAJKHNlcnZlci1lbnN1cmUtc2FmZS1k aXIgKGZpbGUtbmFtZS1kaXJlY3Rvcnkgc2VydmVyLWZpbGUpKQotCSh3aGVuIHNlcnZlci1w cm9jZXNzCi0JICAoc2VydmVyLWxvZyAobWVzc2FnZSAiUmVzdGFydGluZyBzZXJ2ZXIiKSkp CiAgICAgICAgICh3aXRoLWZpbGUtbW9kZXMgP1w3MDAKIAkgIChhZGQtaG9vayAnc3VzcGVu ZC10dHktZnVuY3Rpb25zICMnc2VydmVyLWhhbmRsZS1zdXNwZW5kLXR0eSkKIAkgIChhZGQt aG9vayAnZGVsZXRlLWZyYW1lLWZ1bmN0aW9ucyAjJ3NlcnZlci1oYW5kbGUtZGVsZXRlLWZy YW1lKQpAQCAtNzU2LDcgKzc1OCw3IEBAIHNlcnZlci1zdGFydAogCQkJICAgICAgIDpzZXJ2 aWNlIHNlcnZlci1maWxlCiAJCQkgICAgICAgOnBsaXN0ICcoOmF1dGhlbnRpY2F0ZWQgdCkp KSkpCiAJICAodW5sZXNzIHNlcnZlci1wcm9jZXNzIChlcnJvciAiQ291bGQgbm90IHN0YXJ0 IHNlcnZlciBwcm9jZXNzIikpCi0gICAgICAgICAgKHNlcnZlci1sb2cgIlN0YXJ0aW5nIHNl cnZlciIpCisgICAgICAgICAgKHNlcnZlci1sb2cgIlN0YXJ0ZWQgc2VydmVyIikKIAkgIChw cm9jZXNzLXB1dCBzZXJ2ZXItcHJvY2VzcyA6c2VydmVyLWZpbGUgc2VydmVyLWZpbGUpCiAg ICAgICAgICAgKHNldHEgc2VydmVyLW1vZGUgdCkKICAgICAgICAgICAocHVzaCAnc2VydmVy LW1vZGUgZ2xvYmFsLW1pbm9yLW1vZGVzKQotLSAKMi4yNS4xCgo= --------------rCu4dtq0AeEu0M8vJUh4mjwg-- From unknown Sat Jun 14 04:55:23 2025 X-Loop: help-debbugs@gnu.org Subject: bug#58877: 29.0.50; [PATCH] When killing Emacs from a client frame with no other frames, Emacs shows a useless error prompt Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 28 Nov 2022 03:32:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58877 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Jim Porter Cc: 58877@debbugs.gnu.org Received: via spool by 58877-submit@debbugs.gnu.org id=B58877.166960626724435 (code B ref 58877); Mon, 28 Nov 2022 03:32:01 +0000 Received: (at 58877) by debbugs.gnu.org; 28 Nov 2022 03:31:07 +0000 Received: from localhost ([127.0.0.1]:45794 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ozUrK-0006M3-Ll for submit@debbugs.gnu.org; Sun, 27 Nov 2022 22:31:06 -0500 Received: from eggs.gnu.org ([209.51.188.92]:56852) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ozUrI-0006Lf-G0 for 58877@debbugs.gnu.org; Sun, 27 Nov 2022 22:31:05 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ozUrC-0005Q2-01; Sun, 27 Nov 2022 22:30:58 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=9QiSm2K61+KXJYk/Jmwhd6LsIUfjM/aI/QSr+IJ5AUQ=; b=rhik0qdJlnrt jtKFUeqGZdOVNtzlUtz4l06HpQCtzlipe//80pm5jRK4b4FDIn8dlSDNeqTxII3oHi0MkufR110AT s95P2RmPNaHspGApRzbY8Zw0cdTFlh7BvAENGvDOoW+E6b4Z78KtEVsattM1EkurCfSXBsGIDdSAS /oawFc2GWLBp1PfvKKxqaGRvq63PB8oUPWeb4H4meIfmoZ/crgUJuKViyDxfXBWhm7WHip2nG52oN P8JkUZXaNEzbQUzxbsi+D5XrePd262WrtVdzEfpInn/JCgFBDZzYHPvlnZkkvCuGiEnOqqMKqovn5 TWVqEuzAltLTz2xvHbnVSw==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ozUrB-0007Y5-5u; Sun, 27 Nov 2022 22:30:57 -0500 Date: Mon, 28 Nov 2022 05:31:26 +0200 Message-Id: <834jujpxf5.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: <393cb671-cfab-8e7e-6229-b59a1e376e1b@gmail.com> (message from Jim Porter on Sun, 27 Nov 2022 17:28:41 -0800) References: <8121efd5-77c3-0682-ce0f-6be9375dadd8@gmail.com> <83a65dhm7f.fsf@gnu.org> <13835614-c593-ba2d-5373-a9950f6f3dab@gmail.com> <83k03kwoy6.fsf@gnu.org> <83a64fupwv.fsf@gnu.org> <83wn7iu6rz.fsf@gnu.org> <83ilj1srma.fsf@gnu.org> <83v8n1qz3k.fsf@gnu.org> <2be2d630-f4da-16f9-5afc-9f6561a9995a@gmail.com> <83r0xpqwr6.fsf@gnu.org> <393cb671-cfab-8e7e-6229-b59a1e376e1b@gmail.com> X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Sun, 27 Nov 2022 17:28:41 -0800 > From: Jim Porter > Cc: 58877@debbugs.gnu.org > > > Thanks. I've merged the fixes for the tests as > > 14d54212ea46dbd8c950c9852318597e0e47908d. If you see any other issues, > > just let me know. > > Here's one tiny followup fix. Currently on master, if you restart the > Emacs server, it emits a "Server stopped" message. That's not right, and > it should do what it used to: emit a "Restarting server" message. Here's > a fix. Thanks, please install. From unknown Sat Jun 14 04:55:23 2025 X-Loop: help-debbugs@gnu.org Subject: bug#58877: 29.0.50; [PATCH] When killing Emacs from a client frame with no other frames, Emacs shows a useless error prompt Resent-From: Jim Porter Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 28 Nov 2022 06:28:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58877 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Eli Zaretskii Cc: 58877@debbugs.gnu.org Received: via spool by 58877-submit@debbugs.gnu.org id=B58877.166961687130879 (code B ref 58877); Mon, 28 Nov 2022 06:28:02 +0000 Received: (at 58877) by debbugs.gnu.org; 28 Nov 2022 06:27:51 +0000 Received: from localhost ([127.0.0.1]:46577 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ozXcN-00081z-1Y for submit@debbugs.gnu.org; Mon, 28 Nov 2022 01:27:51 -0500 Received: from mail-pg1-f172.google.com ([209.85.215.172]:46789) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ozXcL-00081r-BZ for 58877@debbugs.gnu.org; Mon, 28 Nov 2022 01:27:49 -0500 Received: by mail-pg1-f172.google.com with SMTP id 62so9043611pgb.13 for <58877@debbugs.gnu.org>; Sun, 27 Nov 2022 22:27:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to; bh=8QAdEYLVnRx2ia4nFXMUSifXB9n329wIVFhsTTtOUQM=; b=PBNKcFJKw/DxZyWjYB2MDp/WZFpRhpmphz7A8AbEVFs+ovED3TJ8ozQKoYHz/jPTg9 m9ohMf8PFqiMo3ah87EE0tF1KMercsq+AiF3wVMIA5C7TM3ijvm1iFnNejkyJ9TdC/fR 8aDTVVtDYUb7lNtvgljCMZ24kYwNYZ/zNNccHD9YCrhj9Z9i0SXjLtiACqpmXr5Y/iFi XIbYYkOO/O1kJctvvuZ91nAgiWB+jn5YNP6wL2E98iLcO9/26zTus+GnlVOdyiBHlNd+ 0GMNFjBEI3AvJ42Dln1Y7yRtDwRtAmdz7Pb5izXsaxWOUL0qhAzybA4Ke2zrzOaFqeX7 6ivA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=8QAdEYLVnRx2ia4nFXMUSifXB9n329wIVFhsTTtOUQM=; b=TT3ldhm+gHMFN5dy8OXRU1KeYaBTyP2DLEdYmfb9ckBbNIFH7ZGoV0OzMl6hWH0VoI ApgOKHouNtHgs1X6GCWQhPhn8PHE/raPam6E1kngW82jYRSk2yIRVwKeV9bjpUx3OC2w fnEyjkYdlFQnlA3MF9AyK9PVRl2ipvRg3zc5lW+4W7OIcgOOMy7TXl/Yu/JDgBCoi/ZD K9KWVpIfz9qiCWRmuRluI416ZlRdxQKqv6OdyPtqwe41hg+ShtZvSpBEF07zFUj/IAAV llYn3qenbramcMC5R0M9zuFPf+Kudlhb8y5Sv+AjuH6xZ0FQO/NMZRcHk+DHapOccbtE p3qA== X-Gm-Message-State: ANoB5pncZfmLPM101TyMYfm9JjD5J3Yw6/5GxYOsubLTL2IKVbniJdFK LdptMFTymBmqsf5wZzkPH9KOe9Nle24= X-Google-Smtp-Source: AA0mqf69T8O8tBdafObnSCRXc/zOqR/qLpXKRSydc1YBXIR97DWJctVFewiUT3putnZQLT94NND6Ng== X-Received: by 2002:a63:5014:0:b0:477:2ac3:1b1f with SMTP id e20-20020a635014000000b004772ac31b1fmr41387908pgb.146.1669616863395; Sun, 27 Nov 2022 22:27:43 -0800 (PST) Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id x129-20020a628687000000b0056baebf23e7sm7415559pfd.141.2022.11.27.22.27.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 27 Nov 2022 22:27:42 -0800 (PST) Message-ID: <72a153be-b2cf-9899-d102-f16fff370270@gmail.com> Date: Sun, 27 Nov 2022 22:27:40 -0800 MIME-Version: 1.0 Content-Language: en-US References: <8121efd5-77c3-0682-ce0f-6be9375dadd8@gmail.com> <83a65dhm7f.fsf@gnu.org> <13835614-c593-ba2d-5373-a9950f6f3dab@gmail.com> <83k03kwoy6.fsf@gnu.org> <83a64fupwv.fsf@gnu.org> <83wn7iu6rz.fsf@gnu.org> <83ilj1srma.fsf@gnu.org> <83v8n1qz3k.fsf@gnu.org> <2be2d630-f4da-16f9-5afc-9f6561a9995a@gmail.com> <83r0xpqwr6.fsf@gnu.org> <393cb671-cfab-8e7e-6229-b59a1e376e1b@gmail.com> <834jujpxf5.fsf@gnu.org> From: Jim Porter In-Reply-To: <834jujpxf5.fsf@gnu.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 11/27/2022 7:31 PM, Eli Zaretskii wrote: >> Date: Sun, 27 Nov 2022 17:28:41 -0800 >> From: Jim Porter >> Cc: 58877@debbugs.gnu.org >> >> Here's one tiny followup fix. Currently on master, if you restart the >> Emacs server, it emits a "Server stopped" message. That's not right, and >> it should do what it used to: emit a "Restarting server" message. Here's >> a fix. > > Thanks, please install. Thanks for taking a look. Merged as a85ff22300736212e38f43cc7d56e8e3d4ae1203.