GNU bug report logs - #58866
tab-line tab order is not preserved by desktop when customizing tab-line-tabs-function

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 58866 in the body.
You can then email your comments to 58866 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: João Guerra <joca.bt <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: tab-line tab order is not preserved by desktop when customizing
 tab-line-tabs-function
Date: Sat, 29 Oct 2022 15:06:24 +0200

desktop is restoring the tab-line tab order on application reload when
using the default tab-line-tabs-function. When using a custom
tab-line-tabs-function the order is not being preserved. (I suspect it
could be due to how I want my tabs to behave.)

Example:

(let ((old-tabs nil))
  (defun tl-tabs ()
    (let ((new-tabs (seq-filter (lambda (buffer)
                                  (or (eq buffer (current-buffer))
                                      (buffer-file-name buffer)))
                                (buffer-list))))
      (setq old-tabs (append (seq-intersection old-tabs new-tabs)
                             (seq-difference new-tabs old-tabs))))))

(setq tab-line-tabs-function #'tl-tabs)

This makes the tab-line show all file visiting buffers in all windows
+ the current window buffer, preserving their order.

Is desktop supposed to preserve the tab order for user customizations?

Message #8 received at 58866 <at> debbugs.gnu.org (full text, mbox):

From: Juri Linkov <juri <at> linkov.net>
To: João Guerra <joca.bt <at> gmail.com>
Cc: 58866 <at> debbugs.gnu.org
Subject: Re: bug#58866: tab-line tab order is not preserved by desktop when
 customizing tab-line-tabs-function
Date: Sat, 29 Oct 2022 20:48:34 +0300

tags 58866 notabug
close 58866 29.0.50
thanks

> desktop is restoring the tab-line tab order on application reload when
> using the default tab-line-tabs-function. When using a custom
> tab-line-tabs-function the order is not being preserved. (I suspect it
> could be due to how I want my tabs to behave.)
>
> Is desktop supposed to preserve the tab order for user customizations?

Desktop preserves the window buffer order, so the order for the default
tab-line-tabs-function is preserved in consequence.

Since you customized tab-line-tabs-function to another order
in 'old-tabs', you need also to save your variable 'old-tabs' in
your desktop.  Please look in desktop.el what hooks can you use
to serialize your variable with buffer objects to save it with
buffer names as strings.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.