GNU bug report logs - #58834
[PATCH 0/3] Fix some scripts in compression packages when cross-compiling

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 58834 in the body.
You can then email your comments to 58834 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Christopher Baines <mail <at> cbaines.net>
To: guix-patches <at> gnu.org
Subject: [PATCH 0/3] Fix some scripts in compression packages when
 cross-compiling
Date: Fri, 28 Oct 2022 13:18:45 +0100

[Message part 1 (text/plain, inline)]

I noticed these are broken on the Hurd.

Christopher Baines (3):
  gnu: gzip: Fix script interpreters when cross-compiling.
  gnu: xz: Fix script interpreters when cross-compiling.
  gnu: bzip2: Fix script interpreters when cross-compiling.

 gnu/packages/compression.scm | 13 +++++++++++++
 1 file changed, 13 insertions(+)

-- 
2.37.3

[signature.asc (application/pgp-signature, inline)]

Message #8 received at 58834 <at> debbugs.gnu.org (full text, mbox):

From: Christopher Baines <mail <at> cbaines.net>
To: 58834 <at> debbugs.gnu.org
Subject: [PATCH 1/3] gnu: gzip: Fix script interpreters when cross-compiling.
Date: Fri, 28 Oct 2022 13:29:34 +0100

Add bash-minimal as an input fixes the interpreters for various scripts (like
zcat and zless) when cross-compiling.

* gnu/packages/compression.scm (gzip)[inputs]: Add bash-minimal when cross
compiling.
---
 gnu/packages/compression.scm | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/gnu/packages/compression.scm b/gnu/packages/compression.scm
index f2bf5c443c..b3a678480d 100644
--- a/gnu/packages/compression.scm
+++ b/gnu/packages/compression.scm
@@ -70,6 +70,7 @@ (define-module (gnu packages compression)
   #:use-module (gnu packages autotools)
   #:use-module (gnu packages backup)
   #:use-module (gnu packages base)
+  #:use-module (gnu packages bash)
   #:use-module (gnu packages benchmark)
   #:use-module (gnu packages boost)
   #:use-module (gnu packages check)
@@ -281,6 +282,10 @@ (define-public gzip
                (string-append "exec " (assoc-ref outputs "out")
                               "/bin/gzip")))
             #t)))))
+   (inputs
+    `(,@(if (%current-target-system)
+            `(("bash" ,bash-minimal))
+            '())))
    (description
     "GNU Gzip provides data compression and decompression utilities; the
 typical extension is \".gz\".  Unlike the \"zip\" format, it compresses a single
-- 
2.37.3

Message #11 received at 58834 <at> debbugs.gnu.org (full text, mbox):

From: Christopher Baines <mail <at> cbaines.net>
To: 58834 <at> debbugs.gnu.org
Subject: [PATCH 2/3] gnu: xz: Fix script interpreters when cross-compiling.
Date: Fri, 28 Oct 2022 13:29:35 +0100

Add bash-minimal as an input fixes the interpreters for various scripts (like
xzgrep and xzless) when cross-compiling.

* gnu/packages/compression.scm (xz)[inputs]: Add bash-minimal when cross
compiling.
---
 gnu/packages/compression.scm | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/gnu/packages/compression.scm b/gnu/packages/compression.scm
index b3a678480d..672d5119be 100644
--- a/gnu/packages/compression.scm
+++ b/gnu/packages/compression.scm
@@ -529,6 +529,10 @@ (define-public xz
                 (("^old_library='liblzma.a'") "old_library=''"))
               #t))))))
    (outputs '("out" "static"))
+   (inputs
+    `(,@(if (%current-target-system)
+            `(("bash" ,bash-minimal))
+            '())))
    (synopsis "General-purpose data compression")
    (description
     "XZ Utils is free general-purpose data compression software with high
-- 
2.37.3

Message #14 received at 58834 <at> debbugs.gnu.org (full text, mbox):

From: Christopher Baines <mail <at> cbaines.net>
To: 58834 <at> debbugs.gnu.org
Subject: [PATCH 3/3] gnu: bzip2: Fix script interpreters when cross-compiling.
Date: Fri, 28 Oct 2022 13:29:36 +0100

Add bash-minimal as an input fixes the interpreters for various scripts (like
bzdiff and bzgrep) when cross-compiling.

* gnu/packages/compression.scm (bzip2)[inputs]: Add bash-minimal when cross
compiling.
---
 gnu/packages/compression.scm | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/gnu/packages/compression.scm b/gnu/packages/compression.scm
index 672d5119be..857722ef4a 100644
--- a/gnu/packages/compression.scm
+++ b/gnu/packages/compression.scm
@@ -394,6 +394,10 @@ (define-public bzip2
        ,@(if (%current-target-system)
              '(#:tests? #f)
              '())))
+    (inputs
+     `(,@(if (%current-target-system)
+             `(("bash" ,bash-minimal))
+             '())))
     (outputs '("out" "static"))
     (synopsis "High-quality data compression program")
     (description
-- 
2.37.3

Message #19 received at 58834-done <at> debbugs.gnu.org (full text, mbox):

From: Christopher Baines <mail <at> cbaines.net>
To: Christopher Baines <mail <at> cbaines.net>
Cc: 58834-done <at> debbugs.gnu.org
Subject: Re: [bug#58834] [PATCH 0/3] Fix some scripts in compression
 packages when cross-compiling
Date: Sat, 29 Oct 2022 09:41:41 +0100

[Message part 1 (text/plain, inline)]

Christopher Baines <mail <at> cbaines.net> writes:

> [[PGP Signed Part:Undecided]]
> I noticed these are broken on the Hurd.
>
> Christopher Baines (3):
>   gnu: gzip: Fix script interpreters when cross-compiling.
>   gnu: xz: Fix script interpreters when cross-compiling.
>   gnu: bzip2: Fix script interpreters when cross-compiling.
>
>  gnu/packages/compression.scm | 13 +++++++++++++
>  1 file changed, 13 insertions(+)

I've gone ahead and pushed these changes now as
e4fcb6d1b3ca7346123deb14f10b724b15ff06b1.

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.