From debbugs-submit-bounces@debbugs.gnu.org Thu Oct 27 17:01:21 2022 Received: (at submit) by debbugs.gnu.org; 27 Oct 2022 21:01:21 +0000 Received: from localhost ([127.0.0.1]:59463 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ooA08-0002ow-21 for submit@debbugs.gnu.org; Thu, 27 Oct 2022 17:01:21 -0400 Received: from lists.gnu.org ([209.51.188.17]:51950) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ooA05-0002oo-9n for submit@debbugs.gnu.org; Thu, 27 Oct 2022 17:01:18 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ooA05-0005cP-2D for bug-gnu-emacs@gnu.org; Thu, 27 Oct 2022 17:01:17 -0400 Received: from mail-oa1-x2b.google.com ([2001:4860:4864:20::2b]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ooA03-0000xi-4F for bug-gnu-emacs@gnu.org; Thu, 27 Oct 2022 17:01:16 -0400 Received: by mail-oa1-x2b.google.com with SMTP id 586e51a60fabf-13ae8117023so3906141fac.9 for ; Thu, 27 Oct 2022 14:01:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:to:subject:message-id:date:mime-version :from:from:to:cc:subject:date:message-id:reply-to; bh=8svUJsihmfIF71R24KXmmq0UFMozbQg/VvooG29kY0g=; b=ofJOl/3qxUlern1kVZ8dFDhblTVWzdSYejFoGd+i/1iLZN4QhW5aEyVRaPXDypao6G FVyo5GfqPS2frxEV7K2JT/XcGvLAIY/YndX86idrZHQIxEd91N4+J/1ZVhF67gYGI/k0 W82ErOpd+b6+AP3mkSECJUKv8szAcXPPxtyCb6+WKrBFBKD5MsarNHMWQp8Q/44YerKe b7q0GfBCVxQ/cH+3rSBh8UGo9ZMEjRpw7wI4W7kheO9iIl4VjTT3F4wHasx9KtNpUE27 oqFglqmkRgVI3SbMnPHupYoyM2DVfM5NorIjrlv36+CO58zuPox3/JBJighQ1As1nx/D 9f9w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:to:subject:message-id:date:mime-version :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=8svUJsihmfIF71R24KXmmq0UFMozbQg/VvooG29kY0g=; b=17Y13S4A07RQeBJKkZL+7+Kre9y9j7WIL9OGf+/X8xOWooi+3dK3/aqskL8tJhgPwL TM0z/ssZ8GzFH8dSOJdik92DErpzbJXKjE6uucpzKmJlqg5txVxvUUrYwD8HjOougRs7 Jbfz28o4Bzu7brL0DaaBV6RdclQLbqrXXmNhY6WphqBiBZXTxVV65lu6nXerKbZUc0Dm 0Yp8Fsa7or2Ku/3z9QOFdbe8Ezz6rvhHPQymNFfQKM8cOIq0o4uX9Uy3mTCDU3pHq9Fg 33N4tfceequcND70FcxgUiCPlNBLlffmHg+kjELiNY6HhxRF2KA+pXVIWR7rea1GDl0R aItw== X-Gm-Message-State: ACrzQf2iGD16Q1FwmTkggoQwl7jiL/KE+rnxiYjUcpwgBa1VhdVAWLxE om5Qq13bdMFIq+n5apRM1KpIbj4DSe5Sv/VgZ1x3/ooL X-Google-Smtp-Source: AMsMyM7uGgOp8+aZu5vywnxppY1vmu38vDRiMRedrLlvClhOtlBe344JLXveSqqFZunkpTdvUkXHsw3kH44/pFety9s= X-Received: by 2002:a05:6870:d79a:b0:136:50d7:faa9 with SMTP id bd26-20020a056870d79a00b0013650d7faa9mr6488251oab.92.1666904473312; Thu, 27 Oct 2022 14:01:13 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Thu, 27 Oct 2022 14:01:12 -0700 From: Stefan Kangas X-Debbugs-CC: Yuan Fu X-Hashcash: 1:20:221027:bug-gnu-emacs@gnu.org::7xYyYieEM2sBZCZw:0aAP MIME-Version: 1.0 Date: Thu, 27 Oct 2022 14:01:12 -0700 Message-ID: Subject: feature/tree-sitter doesn't build without tree-sitter To: bug-gnu-emacs@gnu.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=2001:4860:4864:20::2b; envelope-from=stefankangas@gmail.com; helo=mail-oa1-x2b.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) This system does not have tree-sitter installed. The feature/tree-sitter branch doesn't seem to build without it. I ran the following command: ./autogen.sh && ./configure && make -k -j8 bootstrap In the compilation log, I see the following relevant parts, but let me know if you need anything else: checking for tree-sitter >=3D 0.0... no [...] Does Emacs use -ltree-sitter? no [...] In end of data: treesit.el:1285:23: Warning: the function =E2=80=98treesit-query-expand=E2= =80=99 is not known to be defined. treesit.el:1226:14: Warning: the function =E2=80=98treesit-node-check=E2=80= =99 is not known to be defined. treesit.el:1135:25: Warning: the function =E2=80=98treesit-language-available-p=E2=80=99 is not known to be defined. treesit.el:993:19: Warning: the function =E2=80=98treesit-search-forward=E2= =80=99 is not known to be defined. treesit.el:551:23: Warning: the function =E2=80=98treesit-query-language=E2= =80=99 is not known to be defined. treesit.el:507:24: Warning: the function =E2=80=98treesit-query-compile=E2= =80=99 is not known to be defined. treesit.el:505:17: Warning: the function =E2=80=98treesit-compiled-query-p= =E2=80=99 is not known to be defined. treesit.el:498:18: Warning: the function =E2=80=98treesit-query-p=E2=80=99 = is not known to be defined. treesit.el:308:8: Warning: the function =E2=80=98treesit-query-capture=E2= =80=99 is not known to be defined. treesit.el:298:6: Warning: the function =E2=80=98treesit-node-field-name-for-child=E2=80=99 is not known to be defi= ned. treesit.el:290:24: Warning: the function =E2=80=98treesit-node-prev-sibling= =E2=80=99 is not known to be defined. treesit.el:284:19: Warning: the function =E2=80=98treesit-node-child-count= =E2=80=99 is not known to be defined. treesit.el:252:13: Warning: the function =E2=80=98treesit-node-end=E2=80=99= is not known to be defined. treesit.el:251:13: Warning: the function =E2=80=98treesit-node-start=E2=80= =99 is not known to be defined. treesit.el:240:20: Warning: the function =E2=80=98treesit-node-next-sibling= =E2=80=99 is not known to be defined. treesit.el:226:29: Warning: the function =E2=80=98treesit-parser-list=E2=80= =99 is not known to be defined. treesit.el:209:28: Warning: the function =E2=80=98treesit-node-parent=E2=80= =99 is not known to be defined. treesit.el:208:26: Warning: the function =E2=80=98treesit-node-type=E2=80= =99 is not known to be defined. treesit.el:198:6: Warning: the function =E2=80=98treesit-node-descendant-for-range=E2=80=99 is not known to be defi= ned. treesit.el:174:32: Warning: the function =E2=80=98treesit-node-child=E2=80= =99 is not known to be defined. treesit.el:171:12: Warning: the function =E2=80=98treesit-node-eq=E2=80=99 = is not known to be defined. treesit.el:165:26: Warning: the function =E2=80=98treesit-node-first-child-for-pos=E2=80=99 is not known to be defin= ed. treesit.el:137:4: Warning: the function =E2=80=98treesit-parser-language=E2= =80=99 is not known to be defined. treesit.el:133:5: Warning: the function =E2=80=98treesit-node-parser=E2=80= =99 is not known to be defined. treesit.el:132:4: Warning: the function =E2=80=98treesit-parser-buffer=E2= =80=99 is not known to be defined. treesit.el:119:4: Warning: the function =E2=80=98treesit-parser-included-ranges=E2=80=99 is not known to be defined= . treesit.el:111:12: Warning: the function =E2=80=98treesit-parser-p=E2=80=99= is not known to be defined. treesit.el:107:4: Warning: the function =E2=80=98treesit-parser-set-included-ranges=E2=80=99 is not known to be def= ined. treesit.el:90:7: Warning: the function =E2=80=98treesit-parser-create=E2=80= =99 is not known to be defined. treesit.el:89:6: Warning: the function =E2=80=98treesit-parser-root-node=E2= =80=99 is not known to be defined. [...] In toplevel form: cedet/semantic/wisent/python.el:30:2: Error: Symbol=E2=80=99s function definition is void: treesit-query-p make[4]: *** [Makefile:332: cedet/semantic/wisent/python.elc] Error 1 [...] In toplevel form: org/ob-python.el:33:2: Error: Symbol=E2=80=99s function definition is void: treesit-query-p make[4]: *** [Makefile:332: org/ob-python.elc] Error 1 [...] In end of data: progmodes/python.el:5489:29: Warning: the function =E2=80=98treesit-node-parent=E2=80=99 is not known to be defined. progmodes/python.el:5387:17: Warning: the function =E2=80=98treesit-induce-sparse-tree=E2=80=99 is not known to be defined. progmodes/python.el:5354:33: Warning: the function =E2=80=98treesit-node-start=E2=80=99 is not known to be defined. progmodes/python.el:5350:20: Warning: the function =E2=80=98treesit-node-child-by-field-name=E2=80=99 is not known to be defin= ed. progmodes/python.el:5344:24: Warning: the function =E2=80=98treesit-node-ty= pe=E2=80=99 is not known to be defined. [...] In toplevel form: progmodes/ts-mode.el:29:2: Error: Symbol=E2=80=99s function definition is void: treesit-query-p make[4]: *** [Makefile:332: progmodes/ts-mode.elc] Error 1 [...] In toplevel form: textmodes/mhtml-mode.el:29:2: Error: Symbol=E2=80=99s function definition i= s void: treesit-query-p make[4]: *** [Makefile:332: textmodes/mhtml-mode.elc] Error 1 [...] ELC progmodes/js.elc In end of data: progmodes/js.el:3879:6: Warning: the function =E2=80=98treesit-parser-creat= e=E2=80=99 is not known to be defined. progmodes/js.el:3794:17: Warning: the function =E2=80=98treesit-induce-sparse-tree=E2=80=99 is not known to be defined. progmodes/js.el:3766:30: Warning: the function =E2=80=98treesit-search-subtree=E2=80=99 is not known to be defined. progmodes/js.el:3717:29: Warning: the function =E2=80=98treesit-node-parent= =E2=80=99 is not known to be defined. progmodes/js.el:3714:25: Warning: the function =E2=80=98treesit-node-child-by-field-name=E2=80=99 is not known to be defin= ed. progmodes/js.el:3699:20: Warning: the function =E2=80=98treesit-node-next-sibling=E2=80=99 is not known to be defined. progmodes/js.el:3696:33: Warning: the function =E2=80=98treesit-node-end=E2= =80=99 is not known to be defined. progmodes/js.el:3693:19: Warning: the function =E2=80=98treesit-node-type= =E2=80=99 is not known to be defined. progmodes/js.el:3691:17: Warning: the function =E2=80=98treesit-node-child= =E2=80=99 is not known to be defined. progmodes/js.el:3412:9: Warning: the function =E2=80=98treesit-node-start= =E2=80=99 is not known to be defined. make[4]: Target 'compile-targets' not remade because of errors. make[4]: Leaving directory '/home/skangas/wip/emacs/lisp' make[3]: *** [Makefile:366: compile-main] Error 2 make[3]: Target 'all' not remade because of errors. make[3]: Leaving directory '/home/skangas/wip/emacs/lisp' make[2]: *** [Makefile:531: lisp] Error 2 make[2]: Target 'actual-all' not remade because of errors. make[2]: Leaving directory '/home/skangas/wip/emacs' make[1]: *** [Makefile:1253: actual-bootstrap] Error 2 make[1]: Leaving directory '/home/skangas/wip/emacs' make[1]: Entering directory '/home/skangas/wip/emacs' *** *** "make bootstrap" failed with exit status 2. [...] make[1]: *** [Makefile:413: advice-on-failure] Error 2 make[1]: Leaving directory '/home/skangas/wip/emacs' make: *** [Makefile:1236: bootstrap] Error 2 In GNU Emacs 29.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.34, cairo version 1.16.0) of 2022-10-25 built on joffe Repository revision: 9bfe00dda6b59d9b93eb7a825f6e0868afa1cca3 Repository branch: master Windowing system distributor 'The X.Org Foundation', version 11.0.12101004 System Description: Debian GNU/Linux bookworm/sid From debbugs-submit-bounces@debbugs.gnu.org Thu Oct 27 18:59:22 2022 Received: (at 58823) by debbugs.gnu.org; 27 Oct 2022 22:59:22 +0000 Received: from localhost ([127.0.0.1]:59684 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ooBqM-00063w-Jn for submit@debbugs.gnu.org; Thu, 27 Oct 2022 18:59:22 -0400 Received: from mail-pj1-f54.google.com ([209.85.216.54]:37698) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ooBqL-00063k-2J for 58823@debbugs.gnu.org; Thu, 27 Oct 2022 18:59:21 -0400 Received: by mail-pj1-f54.google.com with SMTP id d59-20020a17090a6f4100b00213202d77e1so8141428pjk.2 for <58823@debbugs.gnu.org>; Thu, 27 Oct 2022 15:59:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=r4eD5bwZlT60SvKVrpSBbyc6al7b1OubFDmJ9w1R4b8=; b=FpC04zoyfmf6bydU/+AugppaKBr0ia+K7X3x/LCPs5PODBBfJZk+YnsFobL4FEvz+p bFxseCMzeMS01eKNcHo5g9lxYk0bjULqzv4+atpKeGG+ae0ttP+xNi7PYpLJtkcDK742 gxVZuxjAV0Oo4Sf/QmXMdn0QoVigWeQV4ml/tKUMegQbLc7HZzVqijeTVs2Majb1DDCO PfLUBW32MEx60s3p8UUtkQYo3am0pwpV/kQnD6tZ08HAV3AvMPP2WspC2wz7c/rPccsQ P4YqfoMQCj4XuUBp10Bb6R6xPOlzPDt+F8TmLRXDxJpOuCBIwCIdNZi7fnuylS55GSWY d+hA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=r4eD5bwZlT60SvKVrpSBbyc6al7b1OubFDmJ9w1R4b8=; b=Pi4fe1S3e8XWt7Cw1Jpr+NPewfOn+xPbPdKL5jNSk3/KJKIB5xqKk/wqjvB4EOcrbD MOWsfvGZ/7sS2n/74jyIiaDxBNzKH40XZ/NUtEBEsDX4DRzO12FZ98z5nquwk309gcUy z/By0jaqkDMiFyz4QY1DbsaSFOdlcmt/38UWdVdYKIHo4zoRLcy0DwqgTLm8iYHJSgRS E8GS6CodbnkM6i14kr1rusNrbWFmKFstWy9iLV3gI1ijTxHAmvb/C4/PEVYNf4yaLCIs uOgZZdP3xYObmRWaXZelNVLVFGp3vafxANy6MG6GdHpJM1/ZWNhG8ziNrdF08viZcA41 NebA== X-Gm-Message-State: ACrzQf3oA7wVK6sISn/fEOExw62F1Pv8BDrDZc1XmzbrFzBmfYf5AAF2 E3AtPqI5TvYwLG1IK2oKeeE= X-Google-Smtp-Source: AMsMyM6xeniPBsrMT9K5+2d+zvC+F8X77q6NiipS6S1m/+TZ2Uhkh0HgsSSIxExiMowb4ys68pCLcw== X-Received: by 2002:a17:902:f60b:b0:178:6a49:d4e3 with SMTP id n11-20020a170902f60b00b001786a49d4e3mr52199183plg.75.1666911555195; Thu, 27 Oct 2022 15:59:15 -0700 (PDT) Received: from smtpclient.apple ([137.110.46.209]) by smtp.gmail.com with ESMTPSA id h5-20020a170902680500b0017a04542a45sm1664795plk.159.2022.10.27.15.59.14 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 27 Oct 2022 15:59:14 -0700 (PDT) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.1\)) Subject: Re: bug#58823: feature/tree-sitter doesn't build without tree-sitter From: Yuan Fu In-Reply-To: Date: Thu, 27 Oct 2022 15:59:14 -0700 Content-Transfer-Encoding: quoted-printable Message-Id: <0E9E7626-1FDC-4CC5-BDDB-36CC91DBF26B@gmail.com> References: To: Stefan Kangas X-Mailer: Apple Mail (2.3696.120.41.1.1) X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 58823 Cc: 58823@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > On Oct 27, 2022, at 2:01 PM, Stefan Kangas = wrote: >=20 > This system does not have tree-sitter installed. The > feature/tree-sitter branch doesn't seem to build without it. Oh, right, the lisp code has to prepare for the case where tree-sitter = is not compiled. Should we declare-function for all the functions in = treesit.c? And all tree-sitter code called by other lisp files should be = guarded by treesit-available-p. I can fix that. Thanks! Yuan= From debbugs-submit-bounces@debbugs.gnu.org Fri Oct 28 01:46:49 2022 Received: (at 58823) by debbugs.gnu.org; 28 Oct 2022 05:46:49 +0000 Received: from localhost ([127.0.0.1]:60003 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ooICe-0001Qs-Nm for submit@debbugs.gnu.org; Fri, 28 Oct 2022 01:46:49 -0400 Received: from eggs.gnu.org ([209.51.188.92]:40744) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ooICZ-0001Qb-5z for 58823@debbugs.gnu.org; Fri, 28 Oct 2022 01:46:46 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ooICT-0006RS-QI; Fri, 28 Oct 2022 01:46:37 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=MoQsIKnQYkHnEUK7nD94612q3Rp0YoGfpB8bRBiJEGo=; b=eN0oRPUUng2s k+jdR/sUATAUTx5wlokqsDlJc6mlnIRAvsr1m/PxTF8GYNShDgTpDd7SaSuud43XQU42R/u/Q9NOG wJq5RorHM2dTLHlc5r64sFF+GagrLJmNs1jLjXYyh+wqxaHA1D7HM7qleZd7OpQ0p+fINiuTxACVt HU2Cnp30wWugAdM1k876tPRmX7iF7xwOmYO11T7mb5s5qVLIYuWOoPhP/QCQo3YkZ7TciCXYKiPRz 7AqvHN57HOLdz8Qat+n5VvMd5x3nNFrUZz7ECo3wzUpk7H56OXGr+m5tDTw7zjPn0hyLjOww5E6d3 SPNkiGmYAbdw1riEpXI/ug==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ooICS-0005IH-TQ; Fri, 28 Oct 2022 01:46:37 -0400 Date: Fri, 28 Oct 2022 08:46:32 +0300 Message-Id: <8335b8lcuf.fsf@gnu.org> From: Eli Zaretskii To: Yuan Fu In-Reply-To: <0E9E7626-1FDC-4CC5-BDDB-36CC91DBF26B@gmail.com> (message from Yuan Fu on Thu, 27 Oct 2022 15:59:14 -0700) Subject: Re: bug#58823: feature/tree-sitter doesn't build without tree-sitter References: <0E9E7626-1FDC-4CC5-BDDB-36CC91DBF26B@gmail.com> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 58823 Cc: 58823@debbugs.gnu.org, stefankangas@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Cc: 58823@debbugs.gnu.org > From: Yuan Fu > Date: Thu, 27 Oct 2022 15:59:14 -0700 > > > On Oct 27, 2022, at 2:01 PM, Stefan Kangas wrote: > > > > This system does not have tree-sitter installed. The > > feature/tree-sitter branch doesn't seem to build without it. > > Oh, right, the lisp code has to prepare for the case where tree-sitter is not compiled. Should we declare-function for all the functions in treesit.c? Yes. > And all tree-sitter code called by other lisp files should be guarded by treesit-available-p. I can fix that. Yes, thanks. From debbugs-submit-bounces@debbugs.gnu.org Fri Oct 28 19:48:16 2022 Received: (at 58823) by debbugs.gnu.org; 28 Oct 2022 23:48:16 +0000 Received: from localhost ([127.0.0.1]:34511 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ooZ5E-0006qG-1I for submit@debbugs.gnu.org; Fri, 28 Oct 2022 19:48:16 -0400 Received: from mail-pf1-f173.google.com ([209.85.210.173]:33399) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ooZ59-0006pZ-Am for 58823@debbugs.gnu.org; Fri, 28 Oct 2022 19:48:14 -0400 Received: by mail-pf1-f173.google.com with SMTP id m6so6089031pfb.0 for <58823@debbugs.gnu.org>; Fri, 28 Oct 2022 16:48:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=ZZvapbuFqZL9sRVgywiue11j9uS+QMQVQP6UtUvEai8=; b=eP6j2MVGJiyod5Z9OaStd3bpu5giLKx1ZdHc2iGUQVXkJSrWjJVXqcL0hTOw/ShgIV HFEZYtO1cICHX+kO1Mah/BMahVdgok8SQhiS4ZwUTl9n5TPMQ0qMsxDC6lO80IRockng rf6+zNt/o9G+HTjDWrfaJmoN0lvNXxC53n3L5xXPTqpZ1GqL6mODNcrFn+493cj6u5Rc nGIgH/S/1ioAkkBxmVHK/fk8EUBivgAujYZHkIiJHo7n35KSx89nnI77rEokM4mGQycy wqtBrRSaHAcD8pyF7WI3xqy+kOTZ9JLcUBcRX0mtq5sJduUQPAOMgN5f90rYu2esLxmj EfgQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ZZvapbuFqZL9sRVgywiue11j9uS+QMQVQP6UtUvEai8=; b=sgCYC9eifhJ3az/lhYVfm4lWzMdkU0FkBtbXkeFRy9HshqlPekB6JTP+8QygW8Q01B X6p4hYFSp/i4s4pKImgHi8y6uk9V9WP3zOr8fZoobdcp7Q7O4FTpM8U/7GFOXHz0pF11 9EkrMym7AsFV8KIQAAWHcMVKkSx7BxBtCxz3z8cU98RuFBXSKL7SuhVZJZO7rTWUano1 A/jl09Z24R+eYiJhsreGKKp4QfZlQf0eE7DnGMuVA08D42fgD/8SASGwgfE7N0QvJX71 NASjegCl3wuy6We6UMnKwVA7wL4mQGYaBNKFRzeEthgXWBJot80rSiamO3QPvxNWVG+d MC4Q== X-Gm-Message-State: ACrzQf2UhdkuwMWGsglPWYciORViGoLdxCIYMI7XtYH/GbsE0bBn1+kv cPVKzHq88d5oo8ngRo3Pxhk= X-Google-Smtp-Source: AMsMyM4Yc/ukAzQ4yn7KudpVfySgvjUckUNHy5djGVkXgsqeEMXbVylZLYidiKaCYJ4oMrS6Lh/xtg== X-Received: by 2002:a63:1450:0:b0:439:3806:9b91 with SMTP id 16-20020a631450000000b0043938069b91mr1774189pgu.407.1667000885239; Fri, 28 Oct 2022 16:48:05 -0700 (PDT) Received: from smtpclient.apple (cpe-172-117-161-177.socal.res.rr.com. [172.117.161.177]) by smtp.gmail.com with ESMTPSA id a4-20020a1709027d8400b00186fd3951f7sm5721plm.211.2022.10.28.16.48.04 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 28 Oct 2022 16:48:04 -0700 (PDT) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.1\)) Subject: Re: bug#58823: feature/tree-sitter doesn't build without tree-sitter From: Yuan Fu In-Reply-To: <8335b8lcuf.fsf@gnu.org> Date: Fri, 28 Oct 2022 16:48:03 -0700 Content-Transfer-Encoding: quoted-printable Message-Id: <1E6DB549-425F-4BFC-B5FF-F278B78387A4@gmail.com> References: <0E9E7626-1FDC-4CC5-BDDB-36CC91DBF26B@gmail.com> <8335b8lcuf.fsf@gnu.org> To: Eli Zaretskii X-Mailer: Apple Mail (2.3696.120.41.1.1) X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 58823 Cc: 58823@debbugs.gnu.org, stefankangas@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > On Oct 27, 2022, at 10:46 PM, Eli Zaretskii wrote: >=20 >> Cc: 58823@debbugs.gnu.org >> From: Yuan Fu >> Date: Thu, 27 Oct 2022 15:59:14 -0700 >>=20 >>> On Oct 27, 2022, at 2:01 PM, Stefan Kangas = wrote: >>>=20 >>> This system does not have tree-sitter installed. The >>> feature/tree-sitter branch doesn't seem to build without it. >>=20 >> Oh, right, the lisp code has to prepare for the case where = tree-sitter is not compiled. Should we declare-function for all the = functions in treesit.c? >=20 > Yes. >=20 >> And all tree-sitter code called by other lisp files should be guarded = by treesit-available-p. I can fix that. >=20 > Yes, thanks. Now done. Yuan= From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 22 02:34:49 2022 Received: (at control) by debbugs.gnu.org; 22 Nov 2022 07:34:49 +0000 Received: from localhost ([127.0.0.1]:49557 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oxNnt-0007pQ-Jo for submit@debbugs.gnu.org; Tue, 22 Nov 2022 02:34:49 -0500 Received: from mail-pj1-f53.google.com ([209.85.216.53]:44885) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oxNnr-0007pB-VI for control@debbugs.gnu.org; Tue, 22 Nov 2022 02:34:48 -0500 Received: by mail-pj1-f53.google.com with SMTP id b1-20020a17090a7ac100b00213fde52d49so13619965pjl.3 for ; Mon, 21 Nov 2022 23:34:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:date:message-id:subject:mime-version:content-transfer-encoding :from:from:to:cc:subject:date:message-id:reply-to; bh=5FjAi6xIhjmJ7fSM7RdxAZm6zMnfx4HyceDahQut6vo=; b=SnPKV4fp/VN57AIZeG9Z8g2yL5WB37FMn5OMlOmV6xuoldATeHlb/2QwMyeSAzmQsJ TxxunzX9jPEleSjpxmt80D2CcnFOB8DTjg/0XS1GOkmTnvjX8bbFIeBWfsNcyLw8v87N ByH2+7zNTfUwe6Queyz9aRR98/RrtaaqRv0AiEcN9zF+TzcFSamQRx+1D1FQpssy32od VDHWX6Cmk6y14fkdgO3ukx5VdAhUNqftjzCqTA/A8REzXs3uQAXH3akCEEOdjaBxRJen /mNDKwchiJvRtA6t98hTo4IfBjMjyIk47/chr2uo3l2IOuj86RzYdpsLRESkbh34u7BN vHHg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:date:message-id:subject:mime-version:content-transfer-encoding :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=5FjAi6xIhjmJ7fSM7RdxAZm6zMnfx4HyceDahQut6vo=; b=KTsxLs28qvldnACeEp5JL+IzgFs8Vd+7Kgsaputap/xyEYNs1BzCmlfm4NWEJj9Ei7 i623k925U5gt4LVhYFmkGhygI8ogAYDCJqP7tv9VKj/lpHi4a0/we5ZETXWiNeCc2rnN GkSD1sWClF04JpNsiq3nwExgQIbICmwAVmtsoMm2dfMRkJYWBUWQkqUF3itbb0b8kIwS jKN3T91jjWtUCb5nqDFaoCrMjLElyMgSHDDaclYHwi+ywa+rQKmQzjveyk35/cZ1Dhm8 kZT2JhMBPeJubPZZvZG7z6DY7Zm3oPrp/H2ZGeKLdKB9FNbwAnjfQeQN3Bdys5ufcq1o PFKQ== X-Gm-Message-State: ANoB5pk4wsO4or+54ldWFcPh5D8aQ5ZoK64sHx1fy9HL8w6+1YI0Ppke 9f56mn5SLhzsFTIRrwUJy/jmqqF9Zane4A== X-Google-Smtp-Source: AA0mqf6Cvkj7RPIH8vz0nMsg7gMbn+QfJQ6Sgc/Yuik91Fyw9erwYZZQLw8pkkQu/zRH5rmp4F6Pww== X-Received: by 2002:a17:902:f313:b0:17d:a81a:5dc2 with SMTP id c19-20020a170902f31300b0017da81a5dc2mr3169539ple.90.1669102482137; Mon, 21 Nov 2022 23:34:42 -0800 (PST) Received: from smtpclient.apple (cpe-172-117-161-177.socal.res.rr.com. [172.117.161.177]) by smtp.gmail.com with ESMTPSA id f6-20020a170902684600b001892af9472esm2632349pln.261.2022.11.21.23.34.41 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 21 Nov 2022 23:34:41 -0800 (PST) From: Yuan Fu Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.1\)) Subject: control message for bug #58823 Message-Id: <25387D51-F94A-48BC-96E3-42A15A82D20A@gmail.com> Date: Mon, 21 Nov 2022 23:34:40 -0800 To: control@debbugs.gnu.org X-Mailer: Apple Mail (2.3696.120.41.1.1) X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) close 58823 29.1 quit From unknown Sat Jun 21 05:00:58 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Tue, 20 Dec 2022 12:24:06 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator