GNU bug report logs - #58820
[PATCH] Calculate age cutoff at n-th midnight instead of n*24h mark

Previous Next

Full log

View this message in rfc822 format

From: Eric Abrahamsen <eric <at> ericabrahamsen.net>
To: Stefan Kangas <stefankangas <at> gmail.com>
Cc: 58820 <at> debbugs.gnu.org, Łukasz Stelmach <stlman <at> poczta.fm>
Subject: bug#58820: [PATCH] Calculate age cutoff at n-th midnight instead of n*24h mark
Date: Wed, 11 Oct 2023 07:57:24 -0700

Eric Abrahamsen <eric <at> ericabrahamsen.net> writes:

> Stefan Kangas <stefankangas <at> gmail.com> writes:
>
>> Łukasz Stelmach <stlman <at> poczta.fm> writes:
>>
>>> * lisp/gnus/gnus-sum.el (gnus-summary-limit-to-age): Calculate cutoff to
>>> point to n-th past midnight (1st is 00:00 today).  This way messages sent
>>> between n*24h mark and the next midnight will be excluded (or included
>>> if limitting to younger messages), which seems more intuitive when users
>>> are asked to enter age in days.
>>
>> Eric, do you have any comments on this patch?  Thanks in advance.
>
> Hi!
>
> I do think this a reasonable change, thanks to Łukasz for the report.
> I'd like to apply the attached, which is mostly Łukasz's code with the
> addition of a simplification of the argument reading.
>
> I've also changed the docstring a bit, as I found the original change a
> little hard to understand. However, this might not be any better!
>
> WDYT?

I feel fairly okay about this patch, so will apply tomorrow unless
anyone complains.

Thanks,
Eric

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.