From unknown Sat Aug 09 15:56:11 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#58813 <58813@debbugs.gnu.org> To: bug#58813 <58813@debbugs.gnu.org> Subject: Status: can't substitute etc/teams.scm command as doc suggests Reply-To: bug#58813 <58813@debbugs.gnu.org> Date: Sat, 09 Aug 2025 22:56:11 +0000 retitle 58813 can't substitute etc/teams.scm command as doc suggests reassign 58813 guix submitter 58813 Maxim Cournoyer severity 58813 normal thanks From debbugs-submit-bounces@debbugs.gnu.org Wed Oct 26 23:50:26 2022 Received: (at submit) by debbugs.gnu.org; 27 Oct 2022 03:50:26 +0000 Received: from localhost ([127.0.0.1]:55694 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ontuU-00025t-AO for submit@debbugs.gnu.org; Wed, 26 Oct 2022 23:50:26 -0400 Received: from lists.gnu.org ([209.51.188.17]:40580) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ontuQ-00025j-N9 for submit@debbugs.gnu.org; Wed, 26 Oct 2022 23:50:25 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ontuQ-0005Ex-6l for bug-guix@gnu.org; Wed, 26 Oct 2022 23:50:22 -0400 Received: from mail-qt1-x833.google.com ([2607:f8b0:4864:20::833]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ontuL-00012K-BO for bug-guix@gnu.org; Wed, 26 Oct 2022 23:50:21 -0400 Received: by mail-qt1-x833.google.com with SMTP id g16so328185qtu.2 for ; Wed, 26 Oct 2022 20:50:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:message-id:date:subject:to:from:from:to:cc:subject :date:message-id:reply-to; bh=MI1jcVwa/65L2vYinNuzPk6PGGqSQ0ViVLsCN7hSUSk=; b=llmPhZB4G/H7mlxG3ftnE8wI08KauOhyRK1XL6Wh9hXiiUmiXGM+UUKLvSrL5/uDAo TJt3zUzBg1/XlRiEgoTGiczRV64M3M2kJXlALEmG91Ut6a8w34AGTlbf2URxpOdAXMrv puCodbCbvLxMNnI7SPRnXArYnrC1zXDWDZ+lGfr7LdGMdGWEiB1K3sGSJZmJxx6lWlEy tXec8GFItXhWMPc4g4W9FJ4kDVnGiRZTZE2u68vLki5MnndK8kZKgTF7t0orZWzNaoL5 AyG8m53QnLJJXHMV4ultjkrGtzuEPMh815kM0+Cpn6G/qfl39f/V0TURM58KCzFcQiMZ mQNw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:message-id:date:subject:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=MI1jcVwa/65L2vYinNuzPk6PGGqSQ0ViVLsCN7hSUSk=; b=tttD68rNKDYvkqXzNDyWDZ/pviW5aAlt2kxub8b7Ni7tNW9WNP8JIk4sdcocqmrFn/ bJiX2mCCQ5afF3Oqd+rd4yhmmayUYxPx6hh5utuszRgcPfKfaxYaVeDtixBseqdf+LUq uiQTJaIQndEdyKEtlw6jLS2uLk0cSQHaJ8Lp6aAJ/XI4XnTk5j7mD2xCJCjtSo/HtlUJ o2YMjptGvVnN21k2/SeXZ7xs29tswuwJPM/KWvOqskXWg9izr6S6bZuVsklATNugGXX6 pbQwbL7eBVbT4VVxSTqmB/b1c2mTdvTdfWIEH1ARou3WslUPN6KEo/DhUmBMhVjRbwKI /NAQ== X-Gm-Message-State: ACrzQf36DUKtH7rol6EekotpjSAcCfsBWKwOcteFKYx4i2Mw11E3VAFh Kyb42ZgJNWn4W+PFW22RsPNgNN4hu7A= X-Google-Smtp-Source: AMsMyM5eh4V/GpHKZIA/+1dzDwqO2Wt5gF6N3Ptehgpm8Du5K/J056SzH9Vs1a8Zh5dDqCw9mUAd7Q== X-Received: by 2002:a05:622a:1911:b0:3a4:f16c:6969 with SMTP id w17-20020a05622a191100b003a4f16c6969mr4639420qtc.449.1666842615629; Wed, 26 Oct 2022 20:50:15 -0700 (PDT) Received: from hurd (dsl-152-21.b2b2c.ca. [66.158.152.21]) by smtp.gmail.com with ESMTPSA id bs10-20020ac86f0a000000b0035ce8965045sm281054qtb.42.2022.10.26.20.50.14 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 26 Oct 2022 20:50:15 -0700 (PDT) From: Maxim Cournoyer To: bug-guix Subject: can't substitute etc/teams.scm command as doc suggests Date: Wed, 26 Oct 2022 23:50:14 -0400 Message-ID: <87r0yuq615.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=2607:f8b0:4864:20::833; envelope-from=maxim.cournoyer@gmail.com; helo=mail-qt1-x833.google.com X-Spam_score_int: -10 X-Spam_score: -1.1 X-Spam_bar: - X-Spam_report: (-1.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, FREEMAIL_REPLY=1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-Spam-Score: -0.3 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) Hi, Today, I tried; --8<---------------cut here---------------start------------->8--- $ git send-email --to=guix-patches@gnu.org \ $(./etc/teams.scm cc-members origin/master HEAD) 0000-cover-letter.patch fatal: ambiguous argument 'some.email@redacted.com"': unknown revision or path not in the working tree. Use '--' to separate paths from revisions, like this: 'git [...] -- [...]' format-patch -o /tmp/pFSRbRNNoU --add-header="X-Debbugs-Cc: redacted@gmail.com" --add-header="X-Debbugs-Cc: redacted@email" [...]: command returned error: 128 $ ./etc/teams.scm cc-members origin/master HEAD --add-header="X-Debbugs-Cc: redacted@email" --add-header="X-Debbugs-Cc: redacted@email" ... --8<---------------cut here---------------end--------------->8--- You can see the command fails; this is because when using Bash command substitution $(), the quotes in the result are not interpreted and are thus part of the value (literals), which then gets split on white space. As a quick hacky fix, I tried removing the space and double quotes like: modified etc/teams.scm.in @@ -514,7 +514,7 @@ (define (cc . teams) "Return arguments for `git send-email' to notify the members of the given TEAMS when a patch is received by Debbugs." (format #true - "~{--add-header=\"X-Debbugs-Cc: ~a\"~^ ~}" + "~{--add-header=X-Debbugs-Cc:~a~^ ~}" (map person-email (delete-duplicates (append-map team-members teams) equal?)))) and sent a patch with that command: git send-email --to=guix-patches@gnu.org \ $(./etc/teams.scm cc-members origin/master HEAD 0000-cover-letter.patch It created https://issues.guix.gnu.org/58812 with it, but I don't see any of the X-Debbugs-Cc headers. Mmmh. -- Thanks, Maxim From debbugs-submit-bounces@debbugs.gnu.org Thu Oct 27 02:08:55 2022 Received: (at 58813) by debbugs.gnu.org; 27 Oct 2022 06:08:55 +0000 Received: from localhost ([127.0.0.1]:55959 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1onw4M-0005xr-KT for submit@debbugs.gnu.org; Thu, 27 Oct 2022 02:08:55 -0400 Received: from mail-ej1-f68.google.com ([209.85.218.68]:46012) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1onw4I-0005xd-Vq for 58813@debbugs.gnu.org; Thu, 27 Oct 2022 02:08:45 -0400 Received: by mail-ej1-f68.google.com with SMTP id sc25so1592250ejc.12 for <58813@debbugs.gnu.org>; Wed, 26 Oct 2022 23:08:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:to:from:subject:message-id:from:to:cc:subject:date :message-id:reply-to; bh=CBNaPD2ILKGLb1DMKgv3l8JEKthUKCvMqRH0326VCPE=; b=cxlzH0w/cIMFuQM6rsOZoZkJgfXmG9tQ2PI4RJFdbf16fpL/QinF7ibkMfbbgbi4rc JApppm0EcqENnUeXKGHfuwnhSul+R3FgQ2frKnkeGcF8KHPKmbXYc4I9wQyCtmfTAIKz qQIJPy0ErfFXvcOSyGqM7o+DEQ557CO0ySSRU/q+Z/ObaA0CR1lA4IB+icirKJT1UjTK wG4qnsbmSwtXqBbnUvIrsqF02GqFpU+/HJVw0brB29HIGubofDfT3pQr119xvIlqUuHx T0k7FpOCxv7NKN5QZdWCUwFchSdcEOwxoSqMBidkWYSGGoNY+Bmm9PRAMb0uqjrMDIys sHdg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:to:from:subject:message-id:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=CBNaPD2ILKGLb1DMKgv3l8JEKthUKCvMqRH0326VCPE=; b=jMAVXIi+jpRuDMHwk9nvOAakYHtvcDp7akSJMYM9TFONK8eYdj2P8JPUfKhYOUgI7+ WO5ofDHFZ5J9liKPGOQLYBoEagkvCMmxgkDzq1J+gUiWRtnUwQqQY/XxukoXDkYJzO5W nQeTrnYvi4RWjmCys5MuBaeH9mYBEU2oyx0HnYJLSToU/3+Q5dCbZS0ASfaSKp9d4AsP cEoi7TU2MzIM6+HrFjkCyHbn9xVR0RBYQfb9lRCnP87ZeMjJM9bzDSkjZko8tz/wIxHD Ra02Pe0ZZRGVje6/FKI9Vt35nrLelBxDVQzW2KvyxRXb3mbXiEHF7gwLOIfBI/yNIK+W vj3g== X-Gm-Message-State: ACrzQf2LP6vGR/mDDvuELE1KmFBthccMLf5S2LkkfBGHN2nq96yG6C0A Dnlfc2+eesMH+sApvc/GCOs= X-Google-Smtp-Source: AMsMyM43G+e3npsn1nde5sAGd9B3H44FOSVRfRile4Zp0eLS11NC/IgWK1/tXvdNFY7u09oGm1Ly9w== X-Received: by 2002:a17:907:7f25:b0:7aa:acf9:c07e with SMTP id qf37-20020a1709077f2500b007aaacf9c07emr14242126ejc.280.1666850917054; Wed, 26 Oct 2022 23:08:37 -0700 (PDT) Received: from lumine.fritz.box (85-127-52-93.dsl.dynamic.surfer.at. [85.127.52.93]) by smtp.gmail.com with ESMTPSA id d2-20020a170906304200b0073ddb2eff27sm239322ejd.167.2022.10.26.23.08.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 26 Oct 2022 23:08:36 -0700 (PDT) Message-ID: <05f449076bd7fd65f3cd301cbed4101490b3b2db.camel@gmail.com> Subject: Re: can't substitute etc/teams.scm command as doc suggests From: Liliana Marie Prikler To: Maxim Cournoyer , 58813@debbugs.gnu.org Date: Thu, 27 Oct 2022 08:08:35 +0200 In-Reply-To: <87r0yuq615.fsf@gmail.com> References: <87r0yuq615.fsf@gmail.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.0 MIME-Version: 1.0 X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 58813 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Am Mittwoch, dem 26.10.2022 um 23:50 -0400 schrieb Maxim Cournoyer: > Hi, >=20 > Today, I tried; >=20 > --8<---------------cut here---------------start------------->8--- > $ git send-email --to=3Dguix-patches@gnu.org=C2=A0\ > =C2=A0 $(./etc/teams.scm cc-members origin/master HEAD) 0000-cover- > letter.patch > fatal: ambiguous argument 'some.email@redacted.com"': unknown > revision or path not in the working tree. > Use '--' to separate paths from revisions, like this: > 'git [...] -- [...]' > format-patch -o /tmp/pFSRbRNNoU --add-header=3D"X-Debbugs-Cc: > redacted@gmail.com" --add-header=3D"X-Debbugs-Cc: redacted@email" > [...]: command returned error: 128 >=20 > $ ./etc/teams.scm cc-members origin/master HEAD > --add-header=3D"X-Debbugs-Cc: redacted@email" --add-header=3D"X-Debbugs- > Cc: redacted@email" ... > --8<---------------cut here---------------end--------------->8--- >=20 > You can see the command fails; this is because when using Bash > command substitution $(), the quotes in the result are not > interpreted and are thus part of the value (literals), which then > gets split on white space. >=20 > As a quick hacky fix,=C2=A0 I tried removing the space and double quotes > like: >=20 > modified=C2=A0=C2=A0 etc/teams.scm.in > @@ -514,7 +514,7 @@ (define (cc . teams) > =C2=A0=C2=A0 "Return arguments for `git send-email' to notify the members= of > the given > =C2=A0TEAMS when a patch is received by Debbugs." > =C2=A0=C2=A0 (format #true > -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 "~{--add-header= =3D\"X-Debbugs-Cc: ~a\"~^ ~}" > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 "~{--add-header= =3DX-Debbugs-Cc:~a~^ ~}" > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (map person-= email > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0 (delete-duplicates (append-map team-members teams) > equal?)))) >=20 > and sent a patch with that command: >=20 > git send-email --to=3Dguix-patches@gnu.org=C2=A0\ > =C2=A0 $(./etc/teams.scm cc-members origin/master HEAD 0000-cover- > letter.patch >=20 > It created https://issues.guix.gnu.org/58812=C2=A0with it, but I don't se= e > any of the X-Debbugs-Cc headers.=C2=A0 Mmmh. Note that the existing etc/teams also assumes there are no funny characters in the quote. So it's susceptible to good ol' bobby tables. Could we, instead of outputting a command, make it so that we can pass an already formatted patch and etc/teams rewrites it? Cheers From debbugs-submit-bounces@debbugs.gnu.org Thu Oct 27 08:40:41 2022 Received: (at 58813) by debbugs.gnu.org; 27 Oct 2022 12:40:42 +0000 Received: from localhost ([127.0.0.1]:56382 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oo2Bd-0001On-95 for submit@debbugs.gnu.org; Thu, 27 Oct 2022 08:40:41 -0400 Received: from mail-qk1-f172.google.com ([209.85.222.172]:39543) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oo2Bb-0001OV-FE for 58813@debbugs.gnu.org; Thu, 27 Oct 2022 08:40:40 -0400 Received: by mail-qk1-f172.google.com with SMTP id a5so731172qkl.6 for <58813@debbugs.gnu.org>; Thu, 27 Oct 2022 05:40:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to; bh=XT5FifNczEIWivKzwh6wsfKcvey/mhrPFRE8rMoQ/C0=; b=FDaEAMTaqSji2JQ+iA7AtntUgZtVwq5/Mb/sYcJMLCNkGzD2BX6KORqNYP4h2sTIf7 40URG9HtbqsVZDYU74Fewwmj4z8dcUbHSQ/NE6T8LgZBL9X+CsttvUpKGhgF+06imvGZ 9mmOE34OZe8W0wr77ft/hsv9LuAXuWGJHZPZbJWT4qOiMMlWrNBgNgehjBEUHD2CBt5+ cKAVQTBlNKDrOEcchQAbKRPTVxWh93XTCgHkwPyuqFx8oGNYwpmGaQDjCu5UWvGyK2jP 8id8SR+FYXTza+ifEZ8fHVvWSWdCdARbgwbO+SPSvbnIkVtozCWdjIJ/hpnKG5GuAjmQ metg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=XT5FifNczEIWivKzwh6wsfKcvey/mhrPFRE8rMoQ/C0=; b=rE1wkPFOKOn16pY3eqcC9XiBJXVmRcPhynP7P9M74pBgfY0jhFKEwq8mp68Z5yN5eB kAhuH49PjvC31ZLlfBFEanB3rLdZF6kPEP3QBsjD6BF/4FTl7wzul8tZIq87dHBcDyyy icaFGJy0LyEvMzQ3VxRDSzzQp++cBy998F78D4ZJfq9rkfN235aFO6+HA6TkKqcaO+k9 1VtaXMpjsAloHsicEGyQwvlSRCpy4I+Wdv1kTHeYVtdvHL8l8kqhSIvW6MJxKpKb3Q7T POoZvVG/uXo2Qxg1VI0I84LCMKfrlle4yv/Z/pOurTZpxM10bcS9ibEXi7uwDU+XTV15 uNIQ== X-Gm-Message-State: ACrzQf0DBLHxDw2hgwnl9uKJBxBVi285MPdDQY/DFCUgdyhgiDleo5PQ muaXWjSf6IpX3PqeHfq4h4IXWZWBhI8= X-Google-Smtp-Source: AMsMyM6xUvTIOSibifW/WVd5QXxIGIFDkAgtiWDurcLhwCZUs5Ol9fHnATgmdiydth8DiBQvETOwBA== X-Received: by 2002:a05:620a:15fb:b0:6f9:ab6a:439a with SMTP id p27-20020a05620a15fb00b006f9ab6a439amr4380868qkm.231.1666874433652; Thu, 27 Oct 2022 05:40:33 -0700 (PDT) Received: from hurd (dsl-152-179.b2b2c.ca. [66.158.152.179]) by smtp.gmail.com with ESMTPSA id j8-20020a05620a288800b006fa00941e9dsm226394qkp.136.2022.10.27.05.40.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 27 Oct 2022 05:40:33 -0700 (PDT) From: Maxim Cournoyer To: Liliana Marie Prikler Subject: Re: can't substitute etc/teams.scm command as doc suggests References: <87r0yuq615.fsf@gmail.com> <05f449076bd7fd65f3cd301cbed4101490b3b2db.camel@gmail.com> Date: Thu, 27 Oct 2022 08:40:31 -0400 In-Reply-To: <05f449076bd7fd65f3cd301cbed4101490b3b2db.camel@gmail.com> (Liliana Marie Prikler's message of "Thu, 27 Oct 2022 08:08:35 +0200") Message-ID: <87lep1qw1s.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 58813 Cc: 58813@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi, Liliana Marie Prikler writes: > Am Mittwoch, dem 26.10.2022 um 23:50 -0400 schrieb Maxim Cournoyer: >> Hi, >>=20 >> Today, I tried; >>=20 >> --8<---------------cut here---------------start------------->8--- >> $ git send-email --to=3Dguix-patches@gnu.org=C2=A0\ >> =C2=A0 $(./etc/teams.scm cc-members origin/master HEAD) 0000-cover- >> letter.patch >> fatal: ambiguous argument 'some.email@redacted.com"': unknown >> revision or path not in the working tree. >> Use '--' to separate paths from revisions, like this: >> 'git [...] -- [...]' >> format-patch -o /tmp/pFSRbRNNoU --add-header=3D"X-Debbugs-Cc: >> redacted@gmail.com" --add-header=3D"X-Debbugs-Cc: redacted@email" >> [...]: command returned error: 128 >>=20 >> $ ./etc/teams.scm cc-members origin/master HEAD >> --add-header=3D"X-Debbugs-Cc: redacted@email" --add-header=3D"X-Debbugs- >> Cc: redacted@email" ... >> --8<---------------cut here---------------end--------------->8--- >>=20 >> You can see the command fails; this is because when using Bash >> command substitution $(), the quotes in the result are not >> interpreted and are thus part of the value (literals), which then >> gets split on white space. >>=20 >> As a quick hacky fix,=C2=A0 I tried removing the space and double quotes >> like: >>=20 >> modified=C2=A0=C2=A0 etc/teams.scm.in >> @@ -514,7 +514,7 @@ (define (cc . teams) >> =C2=A0=C2=A0 "Return arguments for `git send-email' to notify the member= s of >> the given >> =C2=A0TEAMS when a patch is received by Debbugs." >> =C2=A0=C2=A0 (format #true >> -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 "~{--add-header= =3D\"X-Debbugs-Cc: ~a\"~^ ~}" >> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 "~{--add-header= =3DX-Debbugs-Cc:~a~^ ~}" >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (map person= -email >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0 (delete-duplicates (append-map team-members teams) >> equal?)))) >>=20 >> and sent a patch with that command: >>=20 >> git send-email --to=3Dguix-patches@gnu.org=C2=A0\ >> =C2=A0 $(./etc/teams.scm cc-members origin/master HEAD 0000-cover- >> letter.patch >>=20 >> It created https://issues.guix.gnu.org/58812=C2=A0with it, but I don't s= ee >> any of the X-Debbugs-Cc headers.=C2=A0 Mmmh. > Note that the existing etc/teams also assumes there are no funny > characters in the quote. So it's susceptible to good ol' bobby tables. > > Could we, instead of outputting a command, make it so that we can pass > an already formatted patch and etc/teams rewrites it? The solution suggested to me in #bash would be to turn etc/teams.scm into a git wrapper, that could invoke git with all the arguments at once (allowing people to pass arguments themselves). I'm told the git completion could be hooked to such script so that users can still enjoy git tab-completion when using etc/teams.scm, although I haven't researched how that'd all work. A similar idea proposed by selckin on #git would be to have our etc/teams.scm script receive the complete git command, and append the args to it itself (and invoke it), like so: ./etc/teams.scm cc mentors -- git send-email --to XXX@debbugs.gnu.org *.pat= ch --=20 Thanks, Maxim From debbugs-submit-bounces@debbugs.gnu.org Thu Oct 27 12:28:04 2022 Received: (at 58813) by debbugs.gnu.org; 27 Oct 2022 16:28:04 +0000 Received: from localhost ([127.0.0.1]:59104 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oo5jf-0001rg-JP for submit@debbugs.gnu.org; Thu, 27 Oct 2022 12:28:04 -0400 Received: from mail-ej1-f67.google.com ([209.85.218.67]:44896) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oo5jd-0001rB-2V for 58813@debbugs.gnu.org; Thu, 27 Oct 2022 12:28:02 -0400 Received: by mail-ej1-f67.google.com with SMTP id n12so6121154eja.11 for <58813@debbugs.gnu.org>; Thu, 27 Oct 2022 09:28:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=ZzXKUu1ypD0q1tSSeZ1cZI/PQ+kzH+I6IJ47IWiCiZA=; b=NY03T1jwnHOlBNtaOi2bvek+xaqp5FYTPzFNJtfgN3SztYoiZw4xK4V9HzFNTK7YTI JmsygY0jpUvnb2/lmTy5yas3PaOmalzGqkdV18O6g0f2oRslchv2Ylofxa6qs0tEo/BS 2qEzSLzBji9vR4wd6OqZ3GHo1wWlnBnUj7kaqOfjQtKxUa3nA+BA8dujFQtbzLatWI4I H63yxmFKc/jZmrpO725qZ7F9euysa6zWrC6TuubMf47LNNJiPvsrUfKby/tGVNZMlROA rYPcWCBheagJ/WBdntz/BSdaamhOA+tllxuvpi6xzUqpCBuZe68F7Y9tZ+rnvBZ7hPZn u38g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=ZzXKUu1ypD0q1tSSeZ1cZI/PQ+kzH+I6IJ47IWiCiZA=; b=5N3prfgcohI4qEY7jB2KtOfN8vXlfHSHwWoNi4AytrPYz7ovh4GV9yuksJT/OIp6la w0jAI6vDOxEOF8eccKh9387N7kJ8gkykjWT7Xxoj8242ecyE6NQj8z6rRva02vqs+JLV pdLlV8iCbK/J0cZ4jgX15N2yjnPu4G4dOFT+UF/8ZYxtwyj6ZmzvD7b+VNpXYmdYhFg7 D8l4RjQCOkKQ9cse8oLcRVheO0/Eijf3xZusYnMdkbtAy4TOHIXD2Oz9Jd/bbImbXAn2 ftJtN8ryejsvg9yBdeENFckgJ0SBJ5mV88UmlVFi4BBlx7gWDyHhmuJGsbIUYNyekVlQ avmg== X-Gm-Message-State: ACrzQf1RfM6pB1RTRxDeMynhYoAdJ6CXLciPJEOx/4KqzrF2NBzev60C edn3bFU7vVALqnV/uyZ3Jp0= X-Google-Smtp-Source: AMsMyM7OgPcgpraEYXp7GgfKcPk3XDZ68ACsx4qBs0c1YcwOdlUl0WCnEEqkC+OR2sJ9+KT3H70NwQ== X-Received: by 2002:a17:907:c27:b0:791:81f2:f2b1 with SMTP id ga39-20020a1709070c2700b0079181f2f2b1mr43239918ejc.436.1666888073845; Thu, 27 Oct 2022 09:27:53 -0700 (PDT) Received: from lumine.fritz.box (85-127-52-93.dsl.dynamic.surfer.at. [85.127.52.93]) by smtp.gmail.com with ESMTPSA id g10-20020a17090604ca00b0078d46aa3b82sm1023155eja.21.2022.10.27.09.27.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 27 Oct 2022 09:27:53 -0700 (PDT) Message-ID: <1af5b004bf08bdb954dd7f924b6aa1dbb563c075.camel@gmail.com> Subject: Re: can't substitute etc/teams.scm command as doc suggests From: Liliana Marie Prikler To: Maxim Cournoyer Date: Thu, 27 Oct 2022 18:27:51 +0200 In-Reply-To: <87lep1qw1s.fsf@gmail.com> References: <87r0yuq615.fsf@gmail.com> <05f449076bd7fd65f3cd301cbed4101490b3b2db.camel@gmail.com> <87lep1qw1s.fsf@gmail.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.0 MIME-Version: 1.0 X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 58813 Cc: 58813@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Am Donnerstag, dem 27.10.2022 um 08:40 -0400 schrieb Maxim Cournoyer: > Hi, >=20 > Liliana Marie Prikler writes: >=20 > > Am Mittwoch, dem 26.10.2022 um 23:50 -0400 schrieb Maxim Cournoyer: > > > Hi, > > >=20 > > > Today, I tried; > > >=20 > > > --8<---------------cut here---------------start------------->8--- > > > $ git send-email --to=3Dguix-patches@gnu.org=C2=A0\ > > > =C2=A0 $(./etc/teams.scm cc-members origin/master HEAD) 0000-cover- > > > letter.patch > > > fatal: ambiguous argument 'some.email@redacted.com"': unknown > > > revision or path not in the working tree. > > > Use '--' to separate paths from revisions, like this: > > > 'git [...] -- [...]' > > > format-patch -o /tmp/pFSRbRNNoU --add-header=3D"X-Debbugs-Cc: > > > redacted@gmail.com" --add-header=3D"X-Debbugs-Cc: redacted@email" > > > [...]: command returned error: 128 > > >=20 > > > $ ./etc/teams.scm cc-members origin/master HEAD > > > --add-header=3D"X-Debbugs-Cc: redacted@email" --add-header=3D"X- > > > Debbugs- > > > Cc: redacted@email" ... > > > --8<---------------cut here---------------end--------------->8--- > > >=20 > > > You can see the command fails; this is because when using Bash > > > command substitution $(), the quotes in the result are not > > > interpreted and are thus part of the value (literals), which then > > > gets split on white space. > > >=20 > > > As a quick hacky fix,=C2=A0 I tried removing the space and double > > > quotes > > > like: > > >=20 > > > modified=C2=A0=C2=A0 etc/teams.scm.in > > > @@ -514,7 +514,7 @@ (define (cc . teams) > > > =C2=A0=C2=A0 "Return arguments for `git send-email' to notify the mem= bers > > > of > > > the given > > > =C2=A0TEAMS when a patch is received by Debbugs." > > > =C2=A0=C2=A0 (format #true > > > -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 "~{--add-head= er=3D\"X-Debbugs-Cc: ~a\"~^ ~}" > > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 "~{--add-head= er=3DX-Debbugs-Cc:~a~^ ~}" > > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (map per= son-email > > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0 (delete-duplicates (append-map team-members > > > teams) > > > equal?)))) > > >=20 > > > and sent a patch with that command: > > >=20 > > > git send-email --to=3Dguix-patches@gnu.org=C2=A0\ > > > =C2=A0 $(./etc/teams.scm cc-members origin/master HEAD 0000-cover- > > > letter.patch > > >=20 > > > It created https://issues.guix.gnu.org/58812=C2=A0with it, but I don'= t > > > see > > > any of the X-Debbugs-Cc headers.=C2=A0 Mmmh. > > Note that the existing etc/teams also assumes there are no funny > > characters in the quote.=C2=A0 So it's susceptible to good ol' bobby > > tables. > >=20 > > Could we, instead of outputting a command, make it so that we can > > pass > > an already formatted patch and etc/teams rewrites it? >=20 > The solution suggested to me in #bash would be to turn etc/teams.scm > into a git wrapper, that could invoke git with all the arguments at > once (allowing people to pass arguments themselves).=C2=A0 I'm told the > git completion could be hooked to such script so that users can still > enjoy git tab-completion when using etc/teams.scm, although I haven't > researched how that'd all work. >=20 > A similar idea proposed by selckin on #git would be to have our > etc/teams.scm script receive the complete git command, and append the > args to it itself (and invoke it), like so: >=20 > ./etc/teams.scm cc mentors -- git send-email --to > XXX@debbugs.gnu.org=C2=A0*.patch I think we should go with the former and implement a proper "guix send- email" ;) From debbugs-submit-bounces@debbugs.gnu.org Thu Jan 05 12:03:53 2023 Received: (at 58813) by debbugs.gnu.org; 5 Jan 2023 17:03:53 +0000 Received: from localhost ([127.0.0.1]:52699 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pDTei-0006mv-Ry for submit@debbugs.gnu.org; Thu, 05 Jan 2023 12:03:53 -0500 Received: from mail-yw1-f170.google.com ([209.85.128.170]:41881) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pDTeh-0006mh-6k for 58813@debbugs.gnu.org; Thu, 05 Jan 2023 12:03:51 -0500 Received: by mail-yw1-f170.google.com with SMTP id 00721157ae682-4a2f8ad29d5so185039217b3.8 for <58813@debbugs.gnu.org>; Thu, 05 Jan 2023 09:03:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:cc:to:from:from:to:cc :subject:date:message-id:reply-to; bh=kCBSQnWxm6NoBZwZyM5MIPZK4olJFFrUdTnclIDcaBI=; b=hGC1dmfJcG7YU1rOJlDwJwtdJ7uq8Fn++cZWooHdn3PFe+PC5zm9d2nxwLjb9Kt8BT BJjb8fD3s4hM6l1XnD5gUrXUHWRNcNNrT+IVlHml+oWAJgZhDzOI8nf9oAAfY2/lSPcv 5aVwCXnO9bUHsufbw+kNvqn7XQeFDoOiPoYg0Bojgsq4+FRKyW7jNuPqFAWxWA5M+gum RyKeyx6tYIQj2rQsu5CQ71outnittYI9BjZyG+PDYVPX3l9/wSCawHlhpZd9YnAeYG6U fQkgZZrSkNfLFSnIH2phIh/BEV3cXizXw2By+cUjAWtvJpm8NB6EzWangFwZMBdI28LH /l/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:cc:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=kCBSQnWxm6NoBZwZyM5MIPZK4olJFFrUdTnclIDcaBI=; b=a8qzHxx6IJQBUYsT9TyfygI5wTpa4hm99drdT8nbgEpeKDUz116x/TPAd7dvR72M+e wbsBYFDnp3oVCY023NVpTOypqJhzPyteOODpyHLDDQgZ4ETQUeFHvKGW51BNSoM+Kk/0 9uWkBe89f66ehK5HkUMKoTiaqIrZkQbDBC4l6k3dk3OuRPcXSd5BU7ZIrWsydyA4z61T Yw4GfGJIK9WkkHQ77IPj1G07SJv9lf/MUMeSKpNzkrtQNJIg761CxEucCbfp5xMZD+Il YU3jFEV5D5SWxOCP1r59a3o5Ncn3TuGC3Wy6NKwCNa7KmHExPpVFUlbpNSvyQST+k2uz TgRA== X-Gm-Message-State: AFqh2koAwGBP2c5e66Yf1ItQUpriDuu5OeIoYSocaOYzno0vwIQqqy3+ Cm+dOpgqq3jOTJPzXQLzXL0= X-Google-Smtp-Source: AMrXdXvLETjSQSkm/OpSZIASFERnBzQ5S/QjEbJuUKZMN9MmcJ1Cxwri75njEl9M450dWE3+7RA8Gw== X-Received: by 2002:a81:7154:0:b0:392:b6a9:da2 with SMTP id m81-20020a817154000000b00392b6a90da2mr58026890ywc.37.1672938225476; Thu, 05 Jan 2023 09:03:45 -0800 (PST) Received: from hurd (dsl-10-134-143.b2b2c.ca. [72.10.134.143]) by smtp.gmail.com with ESMTPSA id l8-20020a37f908000000b006fcab4da037sm25693450qkj.39.2023.01.05.09.03.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Jan 2023 09:03:45 -0800 (PST) From: Maxim Cournoyer To: Simon Tournier Subject: Re: Bogus =?utf-8?Q?=E2=80=98etc=2Fteams=2Escm=E2=80=99?= usage recommendations? References: <87a62z6yl7.fsf@gnu.org> <86fscp6uk7.fsf@gmail.com> Date: Thu, 05 Jan 2023 12:03:44 -0500 In-Reply-To: <86fscp6uk7.fsf@gmail.com> (Simon Tournier's message of "Thu, 05 Jan 2023 13:21:28 +0100") Message-ID: <87wn60oqvj.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 58813 Cc: guix-devel@gnu.org, Ludovic =?utf-8?Q?Court=C3=A8s?= , 58813@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) +CC 58813@debbugs.gnu.org Hi, Simon Tournier writes: > Hi Ludo, > > On Tue, 03 Jan 2023 at 23:29, Ludovic Court=C3=A8s wrote: > >> The manual recommends this (info "(guix) Teams"): >> >> git send-email --to ISSUE_NUMBER@debbugs.gnu.org $(./etc/teams.scm cc = mentors) *.patch >> >> where: >> >> --8<---------------cut here---------------start------------->8--- >> =CE=BB ./etc/teams.scm cc mentors >> --add-header=3D"X-Debbugs-Cc: rg@raghavgururajan.name" >> --add-header=3D"X-Debbugs-Cc: zimon.toutoune@gmail.com" =E2=80=A6 >> --8<---------------cut here---------------end--------------->8--- >> >> I believe this cannot work because the shell will split words on each >> whitespace; IOW, the double quotes above do not have the desired effect. > Well, IIUC, this part is tracked by #58813 [1]. > > 1: Indeed (CC'd). I thought about not using whitespace in the generated output, but I'm not sure if Debbugs or email clients in general would care, plus it's a dirty fix. With the recent patman integration merged (though do apply #60576 as a fixup commit), I'm tempted to remove the mentions of git send-email $(etc/teams.scm cc-members ...) and replace that by 'Further automation of git send-email and etc/teams.scm is possible via the patman package'. What do you think? --=20 Thanks, Maxim From debbugs-submit-bounces@debbugs.gnu.org Thu Jan 05 12:08:49 2023 Received: (at 58813) by debbugs.gnu.org; 5 Jan 2023 17:08:49 +0000 Received: from localhost ([127.0.0.1]:52733 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pDTjV-0006vh-Dm for submit@debbugs.gnu.org; Thu, 05 Jan 2023 12:08:49 -0500 Received: from mail-yw1-f169.google.com ([209.85.128.169]:45636) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pDTjT-0006vV-RK for 58813@debbugs.gnu.org; Thu, 05 Jan 2023 12:08:48 -0500 Received: by mail-yw1-f169.google.com with SMTP id 00721157ae682-46d4840b51fso466778927b3.12 for <58813@debbugs.gnu.org>; Thu, 05 Jan 2023 09:08:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:user-agent:message-id :references:date:in-reply-to:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to; bh=kCBSQnWxm6NoBZwZyM5MIPZK4olJFFrUdTnclIDcaBI=; b=IF3WLiZLQEsgTorQoP48V4x9Bhs+sTX9vK84lJxvAAKebVu3g1HOijXgidBxhCyobd Att/kLJJ5L9JqDslqk20/j/LlJ7iS3YMqnrtI8ce7dglHd2H2FnBPgDWF+ht4Kg1oAAm jNMgVPl8M+RAk/qxXgO9XKFUFnKFn9h2l9aJ+hoTHTwiwLDc1y4PrekC/ddIXL3U/AeF 3ZjgKPYPlWyoZLXzJdeijqu3cAvkTtuwFo6PCfIaSGcKBIDU2/Nlk5iwQMPaX+0wrlPK z/3vetQROuttKW8ay64ZEUpfBvwJkIo1OisEDfi0cYp1/N2jyqMTvSgwpVaYaCzh6XNH VOgw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:user-agent:message-id :references:date:in-reply-to:subject:cc:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=kCBSQnWxm6NoBZwZyM5MIPZK4olJFFrUdTnclIDcaBI=; b=RjE2jogd5fHYksYFTdDwy19GezxhHNgFBHAtd3wmHlIsHXPwiOwFxFNjlSbRxFlJHs vYI77D7d/HZyfXkA/hRW1K/9+QPximBXt6uuOOXFtJjoF0QGttzo9wRgF9dgln4dIYg+ Cqefmgr++XTsrlE5E7PCsedClan76hr4jY7AzD1yjnp1oiex15bg+AXSugDM2yNTdWU6 aAulZ3POSOEgrslj2HBvRfqYzPctxQ43FX5JvvqAG6jhmTpgVGZnR4mbQ5dw12PNdp20 myxwxjy4UyZxhUd14zmDzFkvWeDvBXANud3GYZmE60+kQeBhbStmTE/O3MPFP41cJN2F LDbg== X-Gm-Message-State: AFqh2krRu26ZZBzJqOL4I1KWwLuXNSkRL04b+gW9R075XzOYukFEW7BM GfDEeQGGmJctao2nDXJcZu+Ss9HShh4tZoE+ X-Google-Smtp-Source: AMrXdXt3eGjSf4+QnTYRO6t6YlC2qSC7m8O1vNh5xTpB5srBnyaT74op6HBqkD8vDRs6x7nK7UCAwg== X-Received: by 2002:a81:a20a:0:b0:3cb:4fdd:4ae4 with SMTP id w10-20020a81a20a000000b003cb4fdd4ae4mr1790640ywg.35.1672938522262; Thu, 05 Jan 2023 09:08:42 -0800 (PST) Received: from hurd (dsl-10-134-143.b2b2c.ca. [72.10.134.143]) by smtp.gmail.com with ESMTPSA id bs32-20020a05620a472000b007049f19c736sm26049287qkb.7.2023.01.05.09.08.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Jan 2023 09:08:41 -0800 (PST) From: Maxim Cournoyer To: Simon Tournier Subject: Re: Bogus =?utf-8?Q?=E2=80=98etc=2Fteams=2Escm=E2=80=99?= usage recommendations? In-Reply-To: <86fscp6uk7.fsf@gmail.com> (Simon Tournier's message of "Thu, 05 Jan 2023 13:21:28 +0100") Date: Thu, 05 Jan 2023 12:03:44 -0500 References: <87a62z6yl7.fsf@gnu.org> <86fscp6uk7.fsf@gmail.com> Message-ID: <87tu14oqna.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 58813 Cc: guix-devel@gnu.org, Ludovic =?utf-8?Q?Court=C3=A8s?= , 58813@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) +CC 58813@debbugs.gnu.org Hi, Simon Tournier writes: > Hi Ludo, > > On Tue, 03 Jan 2023 at 23:29, Ludovic Court=C3=A8s wrote: > >> The manual recommends this (info "(guix) Teams"): >> >> git send-email --to ISSUE_NUMBER@debbugs.gnu.org $(./etc/teams.scm cc = mentors) *.patch >> >> where: >> >> --8<---------------cut here---------------start------------->8--- >> =CE=BB ./etc/teams.scm cc mentors >> --add-header=3D"X-Debbugs-Cc: rg@raghavgururajan.name" >> --add-header=3D"X-Debbugs-Cc: zimon.toutoune@gmail.com" =E2=80=A6 >> --8<---------------cut here---------------end--------------->8--- >> >> I believe this cannot work because the shell will split words on each >> whitespace; IOW, the double quotes above do not have the desired effect. > Well, IIUC, this part is tracked by #58813 [1]. > > 1: Indeed (CC'd). I thought about not using whitespace in the generated output, but I'm not sure if Debbugs or email clients in general would care, plus it's a dirty fix. With the recent patman integration merged (though do apply #60576 as a fixup commit), I'm tempted to remove the mentions of git send-email $(etc/teams.scm cc-members ...) and replace that by 'Further automation of git send-email and etc/teams.scm is possible via the patman package'. What do you think? --=20 Thanks, Maxim From debbugs-submit-bounces@debbugs.gnu.org Mon Jan 09 12:23:38 2023 Received: (at 58813) by debbugs.gnu.org; 9 Jan 2023 17:23:38 +0000 Received: from localhost ([127.0.0.1]:38077 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pEvs2-0003uP-BV for submit@debbugs.gnu.org; Mon, 09 Jan 2023 12:23:38 -0500 Received: from eggs.gnu.org ([209.51.188.92]:42780) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pEvs0-0003uB-8a for 58813@debbugs.gnu.org; Mon, 09 Jan 2023 12:23:36 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pEvru-0000fs-TA; Mon, 09 Jan 2023 12:23:30 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=282gf1vSdtUOs6YAn7qs1Oih/jC0Bsjjbjj3Nr9w/lY=; b=NOJPKf1FkyTaMW6EYg+O hagLW826P/ZEHrUHElCWG1Tm2OWGBAEvwxdtPpqT5XpQGQ2au7PQ5S79OQdkGPKwvjXkheHWLAmBU gk+HwAuqRsOnIEnPbHnce0aU2BTcUo02h4fhnkrx16s0REgppwKJ31mKJ53yQFzbJT7rMZ882f+TG z4hTR5kOpfX87LFWdbenK3qRDJIFjEnwhJ1Mo6WAIJz36tMqy0IKZHDyuUF9tbrFvuAdkUMWd41eH uE35dE9kf9ePKoyaNlcwGMaD30BBmrf3JDq2se61hOWyKE5cwDJDWkKE4l22ttN1jvMliILqa1eBz cUXCbBNjwPYCqw==; Received: from [2001:660:6102:320:e120:2c8f:8909:cdfe] (helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pEvru-0005z3-60; Mon, 09 Jan 2023 12:23:30 -0500 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Maxim Cournoyer Subject: Re: bug#58813: can't substitute etc/teams.scm command as doc suggests References: <87a62z6yl7.fsf@gnu.org> <86fscp6uk7.fsf@gmail.com> <87tu14oqna.fsf@gmail.com> Date: Mon, 09 Jan 2023 18:23:28 +0100 In-Reply-To: <87tu14oqna.fsf@gmail.com> (Maxim Cournoyer's message of "Thu, 05 Jan 2023 12:03:44 -0500") Message-ID: <87v8lfpqpb.fsf_-_@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 58813 Cc: guix-devel@gnu.org, 58813@debbugs.gnu.org, Simon Tournier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi, Maxim Cournoyer skribis: > Simon Tournier writes: > >> Hi Ludo, >> >> On Tue, 03 Jan 2023 at 23:29, Ludovic Court=C3=A8s wrote: >> >>> The manual recommends this (info "(guix) Teams"): >>> >>> git send-email --to ISSUE_NUMBER@debbugs.gnu.org $(./etc/teams.scm cc= mentors) *.patch >>> >>> where: >>> >>> --8<---------------cut here---------------start------------->8--- >>> =CE=BB ./etc/teams.scm cc mentors >>> --add-header=3D"X-Debbugs-Cc: rg@raghavgururajan.name" >>> --add-header=3D"X-Debbugs-Cc: zimon.toutoune@gmail.com" =E2=80=A6 >>> --8<---------------cut here---------------end--------------->8--- >>> >>> I believe this cannot work because the shell will split words on each >>> whitespace; IOW, the double quotes above do not have the desired effect. > >> Well, IIUC, this part is tracked by #58813 [1]. >> >> 1: > > Indeed (CC'd). > > I thought about not using whitespace in the generated output, but I'm > not sure if Debbugs or email clients in general would care, plus it's a > dirty fix. Right. How about just outputting a line like: X-Debbugs-Cc: maxim@example.org, ludo@example.org that people would paste in their cover letter? How do Linux=E2=80=99s scripts work? > With the recent patman integration merged (though do apply #60576 as a > fixup commit), I'm tempted to remove the mentions of git send-email > $(etc/teams.scm cc-members ...) and replace that by 'Further automation > of git send-email and etc/teams.scm is possible via the patman package'. > > What do you think? This is the first time I hear about patman. :-) The =E2=80=9CSubmitting Patches=E2=80=9D section mentions =E2=80=98git send= -email=E2=80=99; I don=E2=80=99t think this is about to change, is it? Thanks, Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Mon Jan 09 15:52:22 2023 Received: (at 58813) by debbugs.gnu.org; 9 Jan 2023 20:52:22 +0000 Received: from localhost ([127.0.0.1]:38318 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pEz81-0001Lp-UJ for submit@debbugs.gnu.org; Mon, 09 Jan 2023 15:52:22 -0500 Received: from mail-qv1-f51.google.com ([209.85.219.51]:35371) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pEz80-0001LZ-0n for 58813@debbugs.gnu.org; Mon, 09 Jan 2023 15:52:20 -0500 Received: by mail-qv1-f51.google.com with SMTP id i12so7105224qvs.2 for <58813@debbugs.gnu.org>; Mon, 09 Jan 2023 12:52:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to; bh=P2opFA/IkV1659OcLvjrKE7YNGNUk5IPEEcP5uSzqco=; b=Ll9jqOhIRWeZoeL9wslt0Mou3mCcUgZ72zCu1zEeJjhV++DrgTxddziXGjcHVOkX5A dZMkCzXhzcTEgQWC4ge5zSVDVrrwt/5hpzPPwEAY8h4fjjWmBFdrQvdYCegrA81teZjH hAeq2dq8CLjbgd0LcTJbc8RDg6YrF7DziWNIJ1N8GWG4qImZShqs1P1nV0j74QAPiZiO /3mbQ28HW+zMBgg7K+AjfU/1m+3LyzLr61rfBxRTMAba5kYkTV9wFIGm29eW3GCxPx5v MXhJsQ5qArqN8Wks8Mcy8ujTen73vM/zrTHcb5x4JcIAU9bA4Lb8ivV7lOGSW5W8XRsz /rxg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=P2opFA/IkV1659OcLvjrKE7YNGNUk5IPEEcP5uSzqco=; b=N8QtDXz5XsplGNECZQNm3nkaYcUA6g94w0625/ghZ1IXuvE7hIyfi6tflggMmoU1ue IBMgi1gmUivqgBEdC/96wmHNAu9rHFwWYhwNaH98PaWHlVr4AvwD/Kf3r2prG0vL42U6 y3kQnIVW/XLWOwiuFwpfurf+7zyzhdWN07KihRWtFU+ccdV6am8RwraeXCJp5n0HziaV +oBaN6LJeIk1gGxIhbWxr33P80dkOYP6ByQJPdDwKSstY8dEkBYjKdqobK2I5xg8tj1q mZ/dp3KDr7JHs+plhciDWDQI7r37qS8D/kaNMH7fLh/wvh0lmxEqsMv3utCWvkIB3WjB rVRw== X-Gm-Message-State: AFqh2ko/oWCSO5e6Uvzg6ReISa2Pq+vLdakx8UZOisDXnvf5tSv7XJvt 8PBC1JeF4WShEKtSkGZeBs9Y3y3etByhcQ== X-Google-Smtp-Source: AMrXdXuQXxSvmympp1R1cynQ0GRBUEWLyH7VHV/eauxJWVliK87uqGQaQRqjkCXN7zH4CKGSB5VMBg== X-Received: by 2002:a05:6214:2b90:b0:532:2c0e:412a with SMTP id kr16-20020a0562142b9000b005322c0e412amr10063216qvb.52.1673297534248; Mon, 09 Jan 2023 12:52:14 -0800 (PST) Received: from hurd (dsl-157-228.b2b2c.ca. [66.158.157.228]) by smtp.gmail.com with ESMTPSA id k2-20020a05620a414200b006faaf6dc55asm6042830qko.22.2023.01.09.12.52.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Jan 2023 12:52:13 -0800 (PST) From: Maxim Cournoyer To: Ludovic =?utf-8?Q?Court=C3=A8s?= Subject: Re: bug#58813: can't substitute etc/teams.scm command as doc suggests References: <87a62z6yl7.fsf@gnu.org> <86fscp6uk7.fsf@gmail.com> <87tu14oqna.fsf@gmail.com> <87v8lfpqpb.fsf_-_@gnu.org> Date: Mon, 09 Jan 2023 15:52:12 -0500 In-Reply-To: <87v8lfpqpb.fsf_-_@gnu.org> ("Ludovic =?utf-8?Q?Court=C3=A8s?= =?utf-8?Q?=22's?= message of "Mon, 09 Jan 2023 18:23:28 +0100") Message-ID: <87358jmnwj.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 58813 Cc: guix-devel@gnu.org, 58813@debbugs.gnu.org, Simon Tournier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Ludovic, Ludovic Court=C3=A8s writes: > Hi, > > Maxim Cournoyer skribis: > >> Simon Tournier writes: >> >>> Hi Ludo, >>> >>> On Tue, 03 Jan 2023 at 23:29, Ludovic Court=C3=A8s wrote: >>> >>>> The manual recommends this (info "(guix) Teams"): >>>> >>>> git send-email --to ISSUE_NUMBER@debbugs.gnu.org $(./etc/teams.scm c= c mentors) *.patch >>>> >>>> where: >>>> >>>> --8<---------------cut here---------------start------------->8--- >>>> =CE=BB ./etc/teams.scm cc mentors >>>> --add-header=3D"X-Debbugs-Cc: rg@raghavgururajan.name" >>>> --add-header=3D"X-Debbugs-Cc: zimon.toutoune@gmail.com" =E2=80=A6 >>>> --8<---------------cut here---------------end--------------->8--- >>>> >>>> I believe this cannot work because the shell will split words on each >>>> whitespace; IOW, the double quotes above do not have the desired effec= t. >> >>> Well, IIUC, this part is tracked by #58813 [1]. >>> >>> 1: >> >> Indeed (CC'd). >> >> I thought about not using whitespace in the generated output, but I'm >> not sure if Debbugs or email clients in general would care, plus it's a >> dirty fix. > > Right. > > How about just outputting a line like: > > X-Debbugs-Cc: maxim@example.org, ludo@example.org > > that people would paste in their cover letter? Yes, that's better. > How do Linux=E2=80=99s scripts work? I think the scripts just print stuff at the terminal and expect the user to copy paste. Patman can be used to provide automation on top of that. >> With the recent patman integration merged (though do apply #60576 as a >> fixup commit), I'm tempted to remove the mentions of git send-email >> $(etc/teams.scm cc-members ...) and replace that by 'Further automation >> of git send-email and etc/teams.scm is possible via the patman package'. >> >> What do you think? > > This is the first time I hear about patman. :-) > > The =E2=80=9CSubmitting Patches=E2=80=9D section mentions =E2=80=98git se= nd-email=E2=80=99; I don=E2=80=99t > think this is about to change, is it? It wouldn't change; patman would be hinted at briefly with a reference to its documentation (info '(u-boot) Patman patch manager' from the u-boot-documentation package) as a nice way to stay organize with submissions and automate a few things on top of git send-email. --=20 Thanks, Maxim From debbugs-submit-bounces@debbugs.gnu.org Wed Jan 11 11:11:48 2023 Received: (at 58813) by debbugs.gnu.org; 11 Jan 2023 16:11:48 +0000 Received: from localhost ([127.0.0.1]:43618 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pFdhc-0001fU-K9 for submit@debbugs.gnu.org; Wed, 11 Jan 2023 11:11:48 -0500 Received: from mail-wm1-f46.google.com ([209.85.128.46]:39665) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pFdhY-0001eq-Uo for 58813@debbugs.gnu.org; Wed, 11 Jan 2023 11:11:47 -0500 Received: by mail-wm1-f46.google.com with SMTP id p3-20020a05600c1d8300b003d9ee5f125bso8254217wms.4 for <58813@debbugs.gnu.org>; Wed, 11 Jan 2023 08:11:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=9TmWk+don3RdsLGVS//m7Z5Rfljr/UKPoSpOXU0fpsQ=; b=mhpa2/ILeQYzrsE3Q5wKac9wZripPaQN4HdslY1A1ZCVJIgdZKg2e3ShncEsaxh+aS AkBb0yBiBlLMykaT4fjCVOMAENaek2Yks7ce6wmc7xcVlYlygdnSXL0t3o+AUQ4wRpXh a/K62YaqAgNf3BzG+4hSeiICWnqAb7EAFD3t4wVFUEd/iC3T7fQ8ZUNFDSyCOUkVqSEg iUgLZpgP9XQlsObF91XWb0oVZVJZ8DS0daLVwWJ1Yij3EQgbikKko/y4juLrIDk+UKA3 dQu1HGd8ecIfjLCsUpmEVFfRem72dwDKmrB77C5yxKTyuUrsFqiexGxqcif3OtRaQW41 TEoA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=9TmWk+don3RdsLGVS//m7Z5Rfljr/UKPoSpOXU0fpsQ=; b=Wdwa56KINiGC+g65+/wdauT2OlHJKQt39/tibSTVDj5w3D/RdqrLo4Gp8AMV8UqFAD Bs5bdzXtTJBtvdUZkd158cXhFlnFpnJ81uQpz27wM+LwA/oLys3sZqzXxa4MebpBEIHP Bry8/cM6mx4faVPj8C5v12T9OAU7ZdmsYUhSKHXzx7FCg+EBBOBpmrLCKZT9E7p1/Xzb MzoHzVYU1s9Vp4X19k5692TM/k6X14fDTYBohlFXwbKU5M+7WG/3WIEp9bYQq0qtqtB+ es6YayAJMmHr3ruAP/ZpLd+S+pa+GRXSRGxZ3S9k134eiI/JSv/cW+Z1ly1bSBrTbITu Rugg== X-Gm-Message-State: AFqh2koFpxJEC5+q1UdXz33IV27AXqPAltvj2bOp7YD33Pa8AaT34RGN 1zkktLPx+CcpsmFzPgGyqacpv1E5TDc= X-Google-Smtp-Source: AMrXdXuyv6Il1WSRObUBIyJ0C7F9AsGw6Y7v0x/a3HUUij5PXEgBRjYr8Cks0CmCLNzbi6E7jGIN/A== X-Received: by 2002:a05:600c:3b9f:b0:3d3:3c93:af55 with SMTP id n31-20020a05600c3b9f00b003d33c93af55mr13291655wms.3.1673453499400; Wed, 11 Jan 2023 08:11:39 -0800 (PST) Received: from lili ([2a01:e0a:59b:9120:65d2:2476:f637:db1e]) by smtp.gmail.com with ESMTPSA id u13-20020a05600c19cd00b003c6f1732f65sm25617181wmq.38.2023.01.11.08.11.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 Jan 2023 08:11:39 -0800 (PST) From: Simon Tournier To: Maxim Cournoyer , Ludovic =?utf-8?Q?Court?= =?utf-8?Q?=C3=A8s?= Subject: Re: bug#58813: can't substitute etc/teams.scm command as doc suggests In-Reply-To: <87358jmnwj.fsf@gmail.com> References: <87a62z6yl7.fsf@gnu.org> <86fscp6uk7.fsf@gmail.com> <87tu14oqna.fsf@gmail.com> <87v8lfpqpb.fsf_-_@gnu.org> <87358jmnwj.fsf@gmail.com> Date: Wed, 11 Jan 2023 16:20:01 +0100 Message-ID: <865ydd5c9q.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 58813 Cc: guix-devel@gnu.org, 58813@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi, On Mon, 09 Jan 2023 at 15:52, Maxim Cournoyer w= rote: > It wouldn't change; patman would be hinted at briefly with a reference > to its documentation (info '(u-boot) Patman patch manager' from the > u-boot-documentation package) as a nice way to stay organize with > submissions and automate a few things on top of git send-email. Is it possible to read online patman documentation? I am not able to find one. Moreover, it could ease the adoption if a minimal sample of such configuration is provided. A minimal out of the box configuration as starter. On my side, if I have to do more than just click to read documentation, then I give up. And then, if I have to parse lengthy documentation, then it depends on my motivation but it is also possible that I give up=E2=80=93the well-known RTFM trap. In other words, I am lazy. :-) Cheers, simon From debbugs-submit-bounces@debbugs.gnu.org Wed Jan 11 22:01:06 2023 Received: (at 58813) by debbugs.gnu.org; 12 Jan 2023 03:01:06 +0000 Received: from localhost ([127.0.0.1]:44308 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pFnpx-0004ki-NT for submit@debbugs.gnu.org; Wed, 11 Jan 2023 22:01:06 -0500 Received: from mail-qt1-f178.google.com ([209.85.160.178]:38648) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pFnps-0004k4-Pu for 58813@debbugs.gnu.org; Wed, 11 Jan 2023 22:01:04 -0500 Received: by mail-qt1-f178.google.com with SMTP id z12so15485627qtv.5 for <58813@debbugs.gnu.org>; Wed, 11 Jan 2023 19:01:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:newsgroups:from:from:to :cc:subject:date:message-id:reply-to; bh=HiyTa9M3LYHzQOBVF8gdbEVM7PrBXUocC4Sco2czboI=; b=aKI+VoTtI0Kc675ocMzhiNtw//j5vyAkxndQV8KPURNJmO59X0A06V6pKqXTnKADjK 7HqE4FLCsd3l+p/0k1SgyvXmLuqwQ3fs/ZY9QRF9qzKNhP3zx6Ktxqn6ZMvPC3FpAac7 VqhG5m12u02and7Uuoty7JAG65/dUbEedQUXaLyguN2RycvAgQNFaqDMSm6xKvA0mLAu spjCFdrOWg2bjt8Sorf2DMQi9XRkZgegSCn9ygXC4IXZH5Ku6+hOPMwT6Q2dEB48Fffn Q5B7s3u9J6U7aq++UtD3RUkMkLM3wVgFIqJzxWwv+4jhh9hUhSYkiWy1k8XTF6OCaD8s 4UCA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:newsgroups:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=HiyTa9M3LYHzQOBVF8gdbEVM7PrBXUocC4Sco2czboI=; b=fW/jBSdXz5s8OWFtM8oRhw1IhOJl9ezte36Ammx8Y25Bm7wzjoeCbf0Hf7gJBbfwjc VEeSNxumskPKtHDDt3X/Bu8y3SGVSB2vosI7h52+qXsqIfD2Lt8rVjt8unvrmAHcsd0T csbf+o1XZBNTqhwyXq61lOhxT4nUg1OnT9NwV+3Jqo77XrxxRROtG2sRrmQA45x1naLx cwQacTFRJtX33L87WcwJiAUVuGjwm0jyJ202fgbYdfF4860jDVCMQGyUfXL5PP/Xg7Bb gcxGv5s2SnGzNpsvMShDt1Tt23ztK68Yjz7zOMv3ATdb0kiq6qbB2ToWe+lX/aMcxsIR 6Adw== X-Gm-Message-State: AFqh2kq+6fX1IDnGHJccBg/kuOpx90pxgtiXmkxZNuHf9HIXHqGekvpw 4DBwIWH6FODH1/jGi11AboZVduJkuQsY7bqR X-Google-Smtp-Source: AMrXdXvvqYHi0Z2whNkqBNfKMaR9oYCmn+X4XiNmx/JG2xMHe54JDswy2WsEqadR6EE7sLMkdIVYwg== X-Received: by 2002:a05:622a:4108:b0:3a5:1680:4cd0 with SMTP id cc8-20020a05622a410800b003a516804cd0mr103315041qtb.7.1673492455172; Wed, 11 Jan 2023 19:00:55 -0800 (PST) Received: from hurd (dsl-159-79.b2b2c.ca. [66.158.159.79]) by smtp.gmail.com with ESMTPSA id x30-20020a05620a0b5e00b00705cef9b84asm3530209qkg.131.2023.01.11.19.00.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 Jan 2023 19:00:54 -0800 (PST) From: Maxim Cournoyer Newsgroups: To: Simon Tournier Subject: Re: bug#58813: can't substitute etc/teams.scm command as doc suggests References: <87a62z6yl7.fsf@gnu.org> <86fscp6uk7.fsf@gmail.com> <87tu14oqna.fsf@gmail.com> <87v8lfpqpb.fsf_-_@gnu.org> <87358jmnwj.fsf@gmail.com> <865ydd5c9q.fsf@gmail.com> Date: Wed, 11 Jan 2023 22:00:53 -0500 In-Reply-To: <865ydd5c9q.fsf@gmail.com> (Simon Tournier's message of "Wed, 11 Jan 2023 16:20:01 +0100") Message-ID: <87fscgh2xm.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 58813 Cc: guix-devel@gnu.org, Ludovic =?utf-8?Q?Court=C3=A8s?= , 58813@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Simon, Simon Tournier writes: > Hi, > > On Mon, 09 Jan 2023 at 15:52, Maxim Cournoyer = wrote: > >> It wouldn't change; patman would be hinted at briefly with a reference >> to its documentation (info '(u-boot) Patman patch manager' from the >> u-boot-documentation package) as a nice way to stay organize with >> submissions and automate a few things on top of git send-email. > > Is it possible to read online patman documentation? I am not able to > find one. It's developed as part of U-Boot and available at https://u-boot.readthedocs.io/en/latest/develop/patman.html. It's generated from the same sources as the info manual from u-boot-documentation referenced above. > Moreover, it could ease the adoption if a minimal sample of > such configuration is provided. A minimal out of the box configuration > as starter. No configuration is required other than the .patman file already checked in Guix. > On my side, if I have to do more than just click to read documentation, > then I give up. And then, if I have to parse lengthy documentation, > then it depends on my motivation but it is also possible that I give > up=E2=80=93the well-known RTFM trap. In other words, I am lazy. :-) The 'Patman patch manager' section is relatively compact; I read it from the comfort of Emacs ;-). There's also some alternative short text available as 'patman -H' if you are in a hurry. --=20 Thanks, Maxim From debbugs-submit-bounces@debbugs.gnu.org Thu Jan 12 12:47:01 2023 Received: (at 58813) by debbugs.gnu.org; 12 Jan 2023 17:47:01 +0000 Received: from localhost ([127.0.0.1]:48519 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pG1fJ-0002lP-2Y for submit@debbugs.gnu.org; Thu, 12 Jan 2023 12:47:01 -0500 Received: from mail-wr1-f52.google.com ([209.85.221.52]:42708) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pG1fH-0002l1-J3 for 58813@debbugs.gnu.org; Thu, 12 Jan 2023 12:47:00 -0500 Received: by mail-wr1-f52.google.com with SMTP id k8so4355660wrc.9 for <58813@debbugs.gnu.org>; Thu, 12 Jan 2023 09:46:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=J91RTdtPrcBFUQCgmdlGo0E/TFqNunM4ktLbtZgKObA=; b=YIW/IeQ8kKqXEgHk9t76zWmk9HOCv67ZdIl/DytKHKjvMxvON86+takSbhexdjMQu3 6Ek2F45uZw1GLomKxpEH0re1zR91IF1e1JlWjQ2QCU7TxRFfmJim8AFR2W8KiJ56+XEs S5IH0losEcKFpyevP0ZHN855pWSHQKB4Ax1V86TnzoYV++OVwS9oWrSvYQ8zRxxpgJq2 EQKR/jJ/FkUvFV+4x/FikQYhyWOHR1o+8nnrvW8xVbzDAvsc2TKhUQKqOrWDe6Rm9DjX W2sPHq9996K1PVUpgjbqsWIiByO7BQdJSgc/19ItN9ZT0De/Gf+8HEsobjmJcCPT+lpy mOng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=J91RTdtPrcBFUQCgmdlGo0E/TFqNunM4ktLbtZgKObA=; b=h/kIj95PyrcYnKu5jimK4z5dLzrudD57rxf8wZj18F3ezwxKVb3TG37Q/tpIgXk6+O uNt9LQPxMwC8Uob7ypKqIPJwQTD+LfPHnOfVvHvpgI2GEuscQZSwoYYsBDuHCGfoBFrA Znf7DW5rz+qW0iDYfxms1dyDEhzkM5XSopcIF82c8sW5EitcxBbsjUK7Rl+AyXhOl9fu HfwrHTaVEwDadx8scZxRef7Y51DDjwUETolpiQ6pwbTscTNaJioc7ExfqU2lFljfPOD8 Q3eT1OoUlMSlXE5oav88ZZ6+wWBJpBb5QBBdxaUypTj3guJqXSfECfHoIL4uBxy0soLl HhPg== X-Gm-Message-State: AFqh2kqYkVGUk+30kZ6pWEvAqV5uLprwIYLR3J+qK6O5Xu1IH3/HOVx6 Bwan7OK6Hg7Qedi+52tBFR9yNEbwx5o= X-Google-Smtp-Source: AMrXdXssV7sCI6u81JUERKdq2VLrdX1bTBHC0xp/x6k7TLfKCb6rPKBJIwcLaH+U4atFcTIj/9LWVA== X-Received: by 2002:adf:ce09:0:b0:2bd:c6ce:7bf8 with SMTP id p9-20020adfce09000000b002bdc6ce7bf8mr795152wrn.5.1673545613561; Thu, 12 Jan 2023 09:46:53 -0800 (PST) Received: from pfiuh07 ([193.48.40.241]) by smtp.gmail.com with ESMTPSA id x14-20020a1c7c0e000000b003d9f15efcd5sm13424172wmc.6.2023.01.12.09.46.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Jan 2023 09:46:53 -0800 (PST) From: Simon Tournier To: Maxim Cournoyer Subject: Re: bug#58813: can't substitute etc/teams.scm command as doc suggests In-Reply-To: <87fscgh2xm.fsf@gmail.com> References: <87a62z6yl7.fsf@gnu.org> <86fscp6uk7.fsf@gmail.com> <87tu14oqna.fsf@gmail.com> <87v8lfpqpb.fsf_-_@gnu.org> <87358jmnwj.fsf@gmail.com> <865ydd5c9q.fsf@gmail.com> <87fscgh2xm.fsf@gmail.com> Date: Thu, 12 Jan 2023 14:31:05 +0100 Message-ID: <87fscfyj52.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 1.1 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Hi Maxim, On mer., 11 janv. 2023 at 22:00, Maxim Cournoyer wrote: > It's developed as part of U-Boot and available at > https://u-boot.readthedocs.io/en/latest/develop/patman.html. It's > generated from the same sources as the info manual from > u-boot-documentation [...] Content analysis details: (1.1 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [209.85.221.52 listed in list.dnswl.org] 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (zimon.toutoune[at]gmail.com) 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [209.85.221.52 listed in wl.mailspike.net] -0.0 SPF_PASS SPF: sender matches SPF record 1.1 DATE_IN_PAST_03_06 Date: is 3 to 6 hours before Received: date X-Debbugs-Envelope-To: 58813 Cc: guix-devel@gnu.org, Ludovic =?utf-8?Q?Court=C3=A8s?= , 58813@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.1 (/) Hi Maxim, On mer., 11 janv. 2023 at 22:00, Maxim Cournoyer wrote: > It's developed as part of U-Boot and available at > https://u-boot.readthedocs.io/en/latest/develop/patman.html. It's > generated from the same sources as the info manual from > u-boot-documentation referenced above. Oh thanks! I do not know why I did not found it when using my favorite search engine. :-) >> On my side, if I have to do more than just click to read documentation, >> then I give up. And then, if I have to parse lengthy documentation, >> then it depends on my motivation but it is also possible that I give >> up=E2=80=93the well-known RTFM trap. In other words, I am lazy. :-) > > The 'Patman patch manager' section is relatively compact; I read it from > the comfort of Emacs ;-). There's also some alternative short text > available as 'patman -H' if you are in a hurry. Well, I still think that examples about how to use it are worth and will help for adoption. :-) For instance, this section of the manual [1] describes how to use git-format-patch and git-send-email with details applied to Guix examples. It appears to me better than just pointing [2] and [3]. ;-) 1: 2: 3: Cheers, simon From debbugs-submit-bounces@debbugs.gnu.org Sat Feb 25 22:55:38 2023 Received: (at 58813) by debbugs.gnu.org; 26 Feb 2023 03:55:38 +0000 Received: from localhost ([127.0.0.1]:42058 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pW88P-0003m3-Ux for submit@debbugs.gnu.org; Sat, 25 Feb 2023 22:55:38 -0500 Received: from mail-qt1-f182.google.com ([209.85.160.182]:36832) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pW88N-0003ln-3p for 58813@debbugs.gnu.org; Sat, 25 Feb 2023 22:55:35 -0500 Received: by mail-qt1-f182.google.com with SMTP id l13so3539354qtv.3 for <58813@debbugs.gnu.org>; Sat, 25 Feb 2023 19:55:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=1gUfnvvnbmdlYW3f/WlStTGuQbsvHdpDk5Mj407OUog=; b=mem+rYpqjw9o4jbXp0s1soBPgdi8h1GCu50Au6u7KYL8OkwmA49B7MVDt3ZUn0HLKg fxV/sjHFGKbee1iKdE7MympQdFVDlX6Qtohnz0NiirrmAqBuDA7bNDipM9Z+UPvz+6Hf g4iE/soPcJBGlALNOBQOvJlbiie1XCaNHFL1lqkR928q4C5rc1+4I3IbJdE7i/utihDR v18VZIbWS8e70VuTdbY8HB7VZUIgvYM1gGb9lX+O9sSfUv48zIwYDeoihQCouzre5zwT jyrnjXgwTWnCxf/z6GpzfX3Kh28NUR1lEZpjPyTfABvZINbMzSDjHjpmgpefUaaYZsxG GNnw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=1gUfnvvnbmdlYW3f/WlStTGuQbsvHdpDk5Mj407OUog=; b=z+GJPlFZ5rVavDna0IlbHaAzjkElAo17a8IL70aqK99RbonusgVc68cZ5HZNQOYGMg eAg/ZC6I3NjXKmQ5vhc8I/r2OTSrQOQ/HOyUS4zaYnZc3rX/KsfFwV6HzQzT3T8Osjra Jh7YS+Ch7u/yBIOQyWw7YXRwFNU02Gec2f+tG1ALp7Ja1Ev35g07XXN3GJkpFMK+73Lh 9gwT8+ubxRlYHB+MSkmmNV5AEEJff4qgXNts8biKKKXlC87b+qNWcqDySakhRWt+4oDN 5lABo1WFVptcob5n4tR7Vsmywil1KMIA11OrZV/IpJfvaX+OyfZT6G7YsQBNjE+7WATy MI3w== X-Gm-Message-State: AO0yUKU2soyIeNGtYBYlO1tIRpHw46YX9esTj8kRh3WiOwUpMMa4vju+ e4suGk5bmRmyYeQCrw8riVWoHPAO8g20bNZG X-Google-Smtp-Source: AK7set/lq2/8Fs8teFbRUh6VwmcAd+HFm7GzsnTapxZG5JxILES/mWWB/2lWXaf+tWLjrMwV73wWww== X-Received: by 2002:ac8:59d5:0:b0:3bf:bbaf:5c82 with SMTP id f21-20020ac859d5000000b003bfbbaf5c82mr9074470qtf.21.1677383729104; Sat, 25 Feb 2023 19:55:29 -0800 (PST) Received: from localhost.localdomain (dsl-141-27.b2b2c.ca. [66.158.141.27]) by smtp.gmail.com with ESMTPSA id z134-20020a37658c000000b007423c011937sm2354511qkb.91.2023.02.25.19.55.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 25 Feb 2023 19:55:28 -0800 (PST) From: Maxim Cournoyer To: 58813@debbugs.gnu.org Subject: [PATCH] doc: Document how to use Patman for patches submission. Date: Sat, 25 Feb 2023 22:55:14 -0500 Message-Id: <20230226035515.16214-1-maxim.cournoyer@gmail.com> X-Mailer: git-send-email 2.39.1 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 58813 Cc: ludo@gnu.org, liliana.prikler@gmail.com, Maxim Cournoyer , zimon.toutoune@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Fixes . * doc/contributing.texi (Sending a Patch Series): Mention Patman. Adjust the examples to no longer showcase broken command substitutions. Add a section about how to use Patman, with examples. --- doc/contributing.texi | 119 ++++++++++++++++++++++++++++++++++++++---- doc/guix.texi | 2 +- 2 files changed, 110 insertions(+), 11 deletions(-) diff --git a/doc/contributing.texi b/doc/contributing.texi index c436bc4a31..2a12dffefe 100644 --- a/doc/contributing.texi +++ b/doc/contributing.texi @@ -1416,12 +1416,19 @@ git config --local sendemail.thread no @cindex @code{git format-patch} @unnumberedsubsubsec Single Patches -@anchor{Single Patches} -The @command{git send-email} command is the best way to send both single -patches and patch series (@pxref{Multiple Patches}) to the Guix mailing -list. Sending patches as email attachments may make them difficult to -review in some mail clients, and @command{git diff} does not store commit -metadata. +@cindex patman patch manager +@cindex patch management, via patman +@anchor{Single Patches} The @command{git send-email} command is the best +way to send both single patches and patch series (@pxref{Multiple +Patches}) to the Guix mailing list. Sending patches as email +attachments may make them difficult to review in some mail clients, and +@command{git diff} does not store commit metadata. If you want +something a bit higher level than @command{git send-email} to organize +your patch submissions and take care of its various options for you, you +may want to try the @command{patman} command, from the eponymous +package. Patman's help can be accessed via @samp{patman -H} or as an +Info manual after installing the @code{u-boot-documentation} package +(@pxref{Patman patch manager,,,u-boot,The U-Boot Documentation}). @quotation Note The @command{git send-email} command is provided by the @code{send-email} @@ -1521,7 +1528,7 @@ that we can send the rest of the patches to. @example $ git send-email outgoing/0000-cover-letter.patch -a \ --to=guix-patches@@gnu.org \ - $(etc/teams.scm cc-members ...) + --cc=team-member1@@example.org --cc=team-member2@@example.org ... $ rm outgoing/0000-cover-letter.patch # we don't want to resend it! @end example @@ -1535,7 +1542,7 @@ can send the actual patches to the newly-created issue address. @example $ git send-email outgoing/*.patch \ --to=@var{ISSUE_NUMBER}@@debbugs.gnu.org \ - $(etc/teams.scm cc-members ...) + --cc=team-member1@@example.org --cc=team-member2@@example.org ... $ rm -rf outgoing # we don't need these anymore @end example @@ -1578,18 +1585,110 @@ You can run the following command to have the @code{Mentors} team put in CC of a patch series: @example -$ git send-email --to @var{ISSUE_NUMBER}@@debbugs.gnu.org $(./etc/teams.scm cc mentors) *.patch +$ ./etc/teams.scm cc mentors @end example +then note the @var{output} of the script. + +@example +$ git send-email --to @var{ISSUE_NUMBER}@@debbugs.gnu.org @var{output} *.patch +@end example + +Taking care to manually splice the @var{output} of the +@file{etc/teams.scm} script into the command. + The appropriate team or teams can also be inferred from the modified files. For instance, if you want to send the two latest commits of the current Git repository to review, you can run: @example $ guix shell -D guix -[env]$ git send-email --to @var{ISSUE_NUMBER}@@debbugs.gnu.org $(./etc/teams.scm cc-members HEAD~2 HEAD) *.patch +[env]$ git send-email --to @var{ISSUE_NUMBER}@@debbugs.gnu.org @var{output} *.patch @end example +@cindex patman, usage example +As manually stitching the output of the @file{etc/teams.scm} script in +the @command{git send-email} command can get tedious; you may prefer to +use Patman to automate this for you. Its necessary basic configuration +is already found at the root of the Guix repository, in the +@file{.patman} file. Another useful bit to have is a default +destination for the @command{git send-email} command. You can specify +it in your repository-local Guix @file{.git/config} file with: + +@example +[sendemail] + to = guix-patches@@gnu.org +@end example + +To send a long series to Debbugs, the patches can be written to the +current directory with: + +@example +patman -n +@end example + +The first patch should then be sent using @samp{git send-email +0000-cover-letter.patch}, as explained earlier (@pxref{Multiple +Patches}). + +After Debbugs has issued a unique bug email in reply to that initial +patch submission, e.g. @email{NNNNN@@debbugs.gnu.org}, you can save this +information into the top commit of your patch series (it doesn't matter +which, but it's more convenient to amend it later when it's at the top) +like so, via the Patman-specific @code{Series-to} git message tag: + +@example +gnu: Add foo. + +* gnu/packages/dummy.scm: Add foo. + +Series-to: NNNNN@@debbugs.gnu.org +@end example + +You can then send your series to that address with the right people +automatically added in CC by simply issuing: + +@example +patman +@end example + +After addressing the first round of review comments, you can annotate a +v2 patch series by adding these Patman-specific git message tags: + +@example +gnu: Add foo. + +* gnu/packages/dummy.scm: Add foo. + +Series-to: NNNNN@@debbugs.gnu.org +Series-version: 2 +Series-changes: 2 +- Factorized X into Y and Z + +@end example + +The @command{patman} command will then take care to automate the right +@code{git send-email} command and produce patch annotations useful for +the reviewers. + +After the review is complete, if you are the one merging your own +changes, you should take care to strip any Patman git message tags. +This can be done by writing the patches to the current directory with: + +@example +patman -n +@end example + +and then applying them to the main branch with: + +@example +git am *.patch +@end example + +For more information, run @samp{patman -H} or read its info manual, +which can be installed with the @code{u-boot-documentation} package +(@pxref{Patman patch manager,,,u-boot,The U-Boot Documentation}). + @node Tracking Bugs and Patches @section Tracking Bugs and Patches diff --git a/doc/guix.texi b/doc/guix.texi index a7ef00f421..5a4900d7cf 100644 --- a/doc/guix.texi +++ b/doc/guix.texi @@ -49,7 +49,7 @@ Copyright @copyright{} 2017 humanitiesNerd@* Copyright @copyright{} 2017, 2021 Christine Lemmer-Webber@* Copyright @copyright{} 2017, 2018, 2019, 2020, 2021, 2022 Marius Bakke@* Copyright @copyright{} 2017, 2019, 2020, 2022 Hartmut Goebel@* -Copyright @copyright{} 2017, 2019, 2020, 2021, 2022 Maxim Cournoyer@* +Copyright @copyright{} 2017, 2019, 2020, 2021, 2022, 2023 Maxim Cournoyer@* Copyright @copyright{} 2017–2022 Tobias Geerinckx-Rice@* Copyright @copyright{} 2017 George Clemmer@* Copyright @copyright{} 2017 Andy Wingo@* base-commit: 9a2cf9ef0a9ece9aa0dcb24a31fe0c313d06988f -- 2.39.1 From debbugs-submit-bounces@debbugs.gnu.org Sun Feb 26 03:25:22 2023 Received: (at 58813) by debbugs.gnu.org; 26 Feb 2023 08:25:22 +0000 Received: from localhost ([127.0.0.1]:42256 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pWCLR-00057R-Qq for submit@debbugs.gnu.org; Sun, 26 Feb 2023 03:25:22 -0500 Received: from mail-ed1-f66.google.com ([209.85.208.66]:36835) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pWCLQ-000577-JY for 58813@debbugs.gnu.org; Sun, 26 Feb 2023 03:25:20 -0500 Received: by mail-ed1-f66.google.com with SMTP id da10so13933744edb.3 for <58813@debbugs.gnu.org>; Sun, 26 Feb 2023 00:25:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=m8mLapr2E4uXADkCozMD6HmXLvlLpgonhXg7v5VSNFQ=; b=ZZWJZOxL5yqeZxY1+OuOL1J6twCSTmIImWTfF4JsmRiuOJ3kkS+0rEzOFuMoNq2h2A 70UxfHk31O7QoaIQjacFp66nmqJ46RThXTQbLyWT2tfisAAmfcfBC0/ISVofhQzcXBJU 7M5hr6+4iiPER9s0V3Hsx6jma1akEtX7/Lm3e0wJ/+VmroME5mz+Y7XWRwHNoDtts7eZ jdAPELqJ+47X9NVM5eYEnSr1A9g/TpTPE8k5qRGb6YbEBaiMMD2V+/YfpcjTj9sXe2uA lHHzlLVGXXIryPjzQG2bbQUvPfd6tDTq2CEu5iL8KDml8uDKfUcTpf7oHUqLGAjjcymE 36Eg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=m8mLapr2E4uXADkCozMD6HmXLvlLpgonhXg7v5VSNFQ=; b=joYmWa3CNKIoyOuNEb1BR3PD0pQUymegP9bb2pUWgdKmi1xppKqOXPQ1uVXMkLrkns YKxYMNr14TUpALrme7qlJhLv9Uti5xp7inAkE1ITPex8dPKNzYtqMS/jlb8K66fn1ooa bjTU3WYfHFS5dmIjQM4QU5RcGQQOBRuljkbqi3REhiEvrt1RKZpYV8CXe0OWfNrhrIY3 J0cMKb3NhehhBNFIMHGuxsHOEvjYsc06wqSdGV9V60vkLYbA8Igds87VJpGIp3tlU9v4 tZxG2UU/LGccuWm1AnsE3ciB0sq7f8nk+7NtikJK3DDmpi2iDCgtPWS36IN7Pq6gtbse WDHA== X-Gm-Message-State: AO0yUKXVZHYdXtbpUJTo33kZuxwQtxW6we6P3gJhnl4IEpfUZbVFjYZR aIJlX52VR5upfpchPnpFchg= X-Google-Smtp-Source: AK7set+fcsy8otJqQoJpcYncllZ338XfLHmqZFZMBBqapIx9nOdxZKlcuicEva1/uehpbqNLNUPEHw== X-Received: by 2002:a50:ee1a:0:b0:4ad:7c6c:5386 with SMTP id g26-20020a50ee1a000000b004ad7c6c5386mr20218162eds.30.1677399914403; Sun, 26 Feb 2023 00:25:14 -0800 (PST) Received: from lumine.fritz.box (85-127-52-93.dsl.dynamic.surfer.at. [85.127.52.93]) by smtp.gmail.com with ESMTPSA id u30-20020a50d51e000000b004af58e57db5sm1682455edi.5.2023.02.26.00.25.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 26 Feb 2023 00:25:13 -0800 (PST) Message-ID: <5b282ea05ffb7599aa9ccbc396904c2d352dac30.camel@gmail.com> Subject: Re: [PATCH] doc: Document how to use Patman for patches submission. From: Liliana Marie Prikler To: Maxim Cournoyer , 58813@debbugs.gnu.org Date: Sun, 26 Feb 2023 09:25:12 +0100 In-Reply-To: <20230226035515.16214-1-maxim.cournoyer@gmail.com> References: <20230226035515.16214-1-maxim.cournoyer@gmail.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.0 MIME-Version: 1.0 X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 58813 Cc: ludo@gnu.org, zimon.toutoune@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Am Samstag, dem 25.02.2023 um 22:55 -0500 schrieb Maxim Cournoyer: > Fixes . >=20 > * doc/contributing.texi (Sending a Patch Series): Mention Patman.=C2=A0 > Adjust the examples to no longer showcase broken command > substitutions.=C2=A0 Add a section about how to use Patman, with examples= . It looks like 61797 addresses the broken command =E2=80=93 I'd still like t= he patman changes, but perhaps we can reduce the impact? Cheers From debbugs-submit-bounces@debbugs.gnu.org Sun Feb 26 12:11:42 2023 Received: (at 58813) by debbugs.gnu.org; 26 Feb 2023 17:11:42 +0000 Received: from localhost ([127.0.0.1]:44984 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pWKYo-0005tG-HD for submit@debbugs.gnu.org; Sun, 26 Feb 2023 12:11:42 -0500 Received: from mail-qv1-f44.google.com ([209.85.219.44]:35516) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pWKYl-0005t1-S4 for 58813@debbugs.gnu.org; Sun, 26 Feb 2023 12:11:41 -0500 Received: by mail-qv1-f44.google.com with SMTP id ff4so3034479qvb.2 for <58813@debbugs.gnu.org>; Sun, 26 Feb 2023 09:11:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to; bh=5+mArOnUKrqOpEPiGR9w2M8D4aYPA003EBzsTlgjmjE=; b=ZYKhNeRRV6A0n51+onz9CGFKSUdfh6NARbv0TTaOVgNjJI2bPRduchDxhU4LITbOCa +cKOxW9G2sD/RpkGE5/tYhAXDb2DVeRLtphqokej0Dzvof/x26xV34Eq2lUD1mVEjxQb oz2JFKTXDK+CNrRli7jXGzthM+NbR9vLPAPdfQEOPZXO2RnYyZqKPfqWnhGWrurdYxcM 1dE/ptDu0vpEygm8xxDPtosHINbRsDUDYw2HkH4SeYIEZKJfXfI9Nrf6xW0keHotnrXh 8liDKuH5veOt5Sc+hNhIX6eQx+cqC+Ebp3MfqLMlI1jiEsjaRT4E0kG0uiVWL2XjV3lR cF4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=5+mArOnUKrqOpEPiGR9w2M8D4aYPA003EBzsTlgjmjE=; b=7rUr0gVu0NIbedk6qxPuoBdti0S03BaX22E22yj7MVQD9hMU2+zFCh5ch5olHkNXhd kw9gIRBIUIUXAiHSNCaQ8vQj1+N67irzTkxzr+SwSqvUud3H5bB3U/iJc1Sdj1f2AskH BzYOkR3tG6sQnCKGcoFaloLPivsUB/3VRmm98xjqt29m9/c38EfsNVrrekEH7VH22ltt E6sjKbEeSSAlS5v4K/DLPDCc+bu81dwhbQ8pmJlttpN1iWX7ALEecsKAbXzwJDaWOOlF RCvbvnUlAwNnPXBFtZsPU2TVS7cSzd8cbGLgKxEGhUPmYcTKkGCTl8obvA4HMwIU9/T/ 5Fwg== X-Gm-Message-State: AO0yUKUew+O1VUTMjP8Md9Ouy/KUUfG071h4gUgEU6gX/ot+QRrh7LAA F+rNyyyJyUZfBLhpY4fJm0g= X-Google-Smtp-Source: AK7set+8LBHUg75+tl8FccjLbWbD+SWY3yfjgmgx8vbDJnHNCvuV6tniyhPjYJipdM5VSPInwVdZwg== X-Received: by 2002:a05:6214:e44:b0:56e:b1c8:381b with SMTP id o4-20020a0562140e4400b0056eb1c8381bmr42456628qvc.31.1677431494009; Sun, 26 Feb 2023 09:11:34 -0800 (PST) Received: from hurd (dsl-156-86.b2b2c.ca. [66.158.156.86]) by smtp.gmail.com with ESMTPSA id bs17-20020a05620a471100b00706b09b16fasm3366386qkb.11.2023.02.26.09.11.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 26 Feb 2023 09:11:33 -0800 (PST) From: Maxim Cournoyer To: Liliana Marie Prikler Subject: Re: bug#58813: [PATCH] doc: Document how to use Patman for patches submission. References: <20230226035515.16214-1-maxim.cournoyer@gmail.com> <5b282ea05ffb7599aa9ccbc396904c2d352dac30.camel@gmail.com> Date: Sun, 26 Feb 2023 12:11:32 -0500 In-Reply-To: <5b282ea05ffb7599aa9ccbc396904c2d352dac30.camel@gmail.com> (Liliana Marie Prikler's message of "Sun, 26 Feb 2023 09:25:12 +0100") Message-ID: <87bklgcpx7.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 58813 Cc: ludo@gnu.org, 58813@debbugs.gnu.org, zimon.toutoune@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Liliana, Liliana Marie Prikler writes: > Am Samstag, dem 25.02.2023 um 22:55 -0500 schrieb Maxim Cournoyer: >> Fixes . >>=20 >> * doc/contributing.texi (Sending a Patch Series): Mention Patman.=C2=A0 >> Adjust the examples to no longer showcase broken command >> substitutions.=C2=A0 Add a section about how to use Patman, with example= s. > It looks like 61797 addresses the broken command =E2=80=93 I'd still like= the > patman changes, but perhaps we can reduce the impact? It seems Tobias realized that change wouldn't be sufficient to fix the underlying problem, and closed it. --=20 Thanks, Maxim From debbugs-submit-bounces@debbugs.gnu.org Sun Feb 26 19:45:55 2023 Received: (at submit) by debbugs.gnu.org; 27 Feb 2023 00:45:55 +0000 Received: from localhost ([127.0.0.1]:45428 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pWReN-0006Nb-AY for submit@debbugs.gnu.org; Sun, 26 Feb 2023 19:45:55 -0500 Received: from lists.gnu.org ([209.51.188.17]:60728) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pWReJ-0006NS-IJ for submit@debbugs.gnu.org; Sun, 26 Feb 2023 19:45:51 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pWReJ-0005xV-8A for bug-guix@gnu.org; Sun, 26 Feb 2023 19:45:51 -0500 Received: from tobias.gr ([2a02:c205:2020:6054::1]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pWReH-0006m7-2h; Sun, 26 Feb 2023 19:45:50 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; s=2018; bh=6b9p+mcb8oscW P0tCnnPZquKTsX40I0TvrLyJFxqT/8=; h=references:in-reply-to:subject:cc: to:from:date; d=tobias.gr; b=a2w2O8+ZgJrnlYBE1BFqJ0NBpBgFeMsNmLPI4bmUE xQdDOmS+4OzjbgCdp5q/uLDj4Pa4YcofAdfU4AAkWaGZWorMJ1ENBb9kXWmLTPSsofRYc7 gX/swDz5rNWB0EBCl3ChYnLkDSM7UGAUH7P3Qg87Hg72Cr+FSBjHXlDRLuaSivmEhjt6EI DAWhadcnO7OtW0/YOvbcIHJwho0Y1qNAea6by/bX1DavM82dNSpNqX18O1lSUbKDcj0kXj D8pa3miJoi+4wnTNraglfeaQatp78TlKt87vRXCyFSLZz3clvW5+iMdjwXucY+0ru6ppzA eRpiJeUvdPwa0VlmiQSSA== Received: by submission.tobias.gr (OpenSMTPD) with ESMTPSA id dd72c4dd (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Mon, 27 Feb 2023 00:45:43 +0000 (UTC) Date: Mon, 27 Feb 2023 00:45:44 +0000 From: Tobias Geerinckx-Rice To: bug-guix@gnu.org, Maxim Cournoyer , Liliana Marie Prikler Subject: =?US-ASCII?Q?Re=3A_bug=2358813=3A_=5BPATCH=5D_doc=3A_Document_ho?= =?US-ASCII?Q?w_to_use_Patman_for_patches_submission=2E?= In-Reply-To: <87bklgcpx7.fsf@gmail.com> References: <20230226035515.16214-1-maxim.cournoyer@gmail.com> <5b282ea05ffb7599aa9ccbc396904c2d352dac30.camel@gmail.com> <87bklgcpx7.fsf@gmail.com> Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Autocrypt: addr=me@tobias.gr; prefer-encrypt=mutual; keydata= mQINBFVks2ABEACjGBPhWf/qx0L9OhEIrAFTimo5dHa1FLy0AHaHvxmwYSIdJmERYGiNle1rcOvw cFRtu8KJUsrs27Vgoso3qHJpghVitUUf0v3ZuXQT9kfuQLz1Y8pyMzHwVFMLiJVj4Z3y7CJk+xyZ cpSAMbyPINbFVEhsK+z+8ojVGuaiucZkib6b67ySG6Pp1bon8xVvosj71ZRjfXh1t4X8laWO7fQq itT9lmc6DxbE/4vIhR+Vb2MblaA+DyHoNHGGao89h4CO99lfzWzsux41DnEG9d317sJRQTig6Wja EKHXZRA9FbfogD4SDa2uQYCpTJpsVjAyZyu2fuJ+t0zJJ+Ai9qDY87P6hOyd+/n8Eh2Y4TbxJiDo XUT72XY/RfPH1qrMIP3EI/NNL4LQeGG1n+625k3OVWcRVXG2vRrB6qurLmGkLEmjXWCFD9cCRGfH LeajLm9sM+t/nZPZ3btetcmK9tM2EwivyLUNhrTk73UUnI4CSAzdO2cISqo9zSMtFgj2alqd2fOR s7CKfEn+5PquruDbp/Ej7dOOrjgWSCXLDDYXRrtaKrLz/dhqq5ftFYi9tUTTQecFotM08fPtu+Kw JMP2ySHCkUqp0GvrUCeSRPAJZsmJrd535y+LlRhnqb0mbG4dgMa8A6xhkFYugnqldy/q7kX1EmRI 686N7bA6fh1MCQARAQABtCRUb2JpYXMgR2VlcmluY2t4LVJpY2UgPG1lQHRvYmlhcy5ncj6JAlIE EwEKADwCHgECF4ACGQECGwMWIQT1vFU0w28Ah7OdNu8cncT+udt8SwUCXpe0rAYLCQgHCgQFFQoJ CAsFFgMCAQAACgkQHJ3E/rnbfEu5IhAAk+0BW/twLmx1xMmeXn+I7Ne6SG3++0TRBduEaGWV3n59 lX6XPZUQdAPpS4uy0H+c90Owkw+aWUEwfyOWphrxZRtR2cCOP/3Pxj3Vgtz5RkY4u27lMj15jqa/ p7l2l256ZKJOegr9TvOWtkhMp5lxeVHT6f/44Kv/r/8mMCgSnLXYrEWPE462xI+mIJOanHLJb6No f2xLRCvXoLLp7Yejjv1dwOO71R9PMRhtNy46pZM1ylQ++UTkeSocJw4aNtiu0DHOkX9AlNBkutIx x07RpO+MqJKlzzLeQiC/fE5+dR2itRONopwXAqN3MuT7MonQo5XifBn+VK8i9xZWTXZDkWItWtCC 8oIj4zwxwFWiTmMwwSbI3Wdd/11Zw3CLc4Gd0M6NVgvAnuErQXSgr4lrWhZcncvi4L6EJTc9AUSa 8UWPF+S9t+CHTukpJmcYnsccMkOBhT7OZlmWBsylrYK/JTRWqgWSHWdSKmOuLK+MGDneOZEHkEcf jeXRWvmG7MSU5tE/p7NDLIg9vkvhQV9b0q4OtY65uNWbRe2QRJaYMDcYUAeSZzivRa8VaoVen6tb FvH44zpCxubn23ABl9YIzwvJC++r+H2qLdLpy0cfITiZadZ74Ae0aosNw7XARS6OY+A03BfXyPiI 2oW0jf/PdH9sh2mQrQxIQJ5cZz6Z3X20MFRvYmlhcyBHZWVyaW5ja3gtUmljZSAodG9iaWFzLmdy KSA8bWVAdG9iaWFzLmdyPokCNgQwAQoAIBYhBPW8VTTDbwCHs5027xydxP6523xLBQJZUuJkAh0g AAoJEBydxP6523xLwEoP/iaVWdICefmaZ+bkdUg6hwTKxSPlYdLoaCxYI5V2NnZYXG0dy47E7WJP 4EmTDldcne4UG5NyCgXPSMZDNMqcddEMNbmlssTcLKyu6R/VvTcuL3pEhNoLzm9t2IHR/YGAHJIc pyfmJ3amGSlsbo6s6Vv+mbrJTRPIDpLUst/PDoGYihcSKTxoIw8RtNAy+FAliIdJ8ZuPA3BTxQei sQzgWJo68UInvnFp4juq0zupNDqKddemI8kZCRK/fFPBDD71nqiSJjx2tvbjkTiPU9gmTp7Nulgj ZATZIt0pUhn87w15ItzrsiEjTYCMTmHY5wnvyLarFKZLzQjgUJfsbv4WRJRnX0/EEJWMvMtSdtXL fjwTLrSGAr4vh13PMfE6uVkGkeCV/8BfGJqRE4zkI+QOVILw6VSAP6sdtGSGb52bcCuPj7p9zGIB IuKFudT+DzUb5uV2jbahSjJ8X4Ak/ruG2Hv3iICZawDpHV1JDNgY910KNi5T6gFrjFA2G6aiXDCO SlToLPnPBYH85UVOsp2VykE9AREKS7a7o76cibjwBNN+4xJqJRxhs9YH4JKzE3w/ptVnx49QFBGc pjPkzMTs7DtanD8iqL4J6afnycv9KqIlNJONaMHvzxeunV7QCsoF6DdusZJKFMexiDBaOFUmGFFS XfzK2oNjknx1QApyTPvh Received-SPF: pass client-ip=2a02:c205:2020:6054::1; envelope-from=me@tobias.gr; helo=tobias.gr X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.6 (-) X-Debbugs-Envelope-To: submit Cc: ludo@gnu.org, 58813@debbugs.gnu.org, zimon.toutoune@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.6 (--) Hi, > teams=2Escm I closed the bug-that-didn't-fix, but that still leaves a git-specific com= mand that doesn't actually facilitate git=2E=C2=B9 I guess salvaging 'teams=2Escm cc' into a generic 'Cc:' header generator m= akes some sense? Without the $() use case=2E Otherwise: shall we simply remove it? Kind regards, T G-R Sent on the go=2E Excuse or enjoy my brevity=2E 1: Code golfing bash snippets that make it 'work' doesn't count, but it's = fun=2E From debbugs-submit-bounces@debbugs.gnu.org Mon Feb 27 11:43:55 2023 Received: (at 58813) by debbugs.gnu.org; 27 Feb 2023 16:43:56 +0000 Received: from localhost ([127.0.0.1]:48665 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pWgbT-0005WD-Ks for submit@debbugs.gnu.org; Mon, 27 Feb 2023 11:43:55 -0500 Received: from mail-qt1-f171.google.com ([209.85.160.171]:38648) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pWgbS-0005Vs-0S for 58813@debbugs.gnu.org; Mon, 27 Feb 2023 11:43:54 -0500 Received: by mail-qt1-f171.google.com with SMTP id c18so7326733qte.5 for <58813@debbugs.gnu.org>; Mon, 27 Feb 2023 08:43:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to; bh=nnbH3PMmtkpu0JbtC0075TKaMd/vm5Ql8WyyOvhSsX4=; b=MetJCOXSRH+mkdZLBbJ+NpeOBMIRnNMgjCUUSq3YXCe/LywptU8jsVjlr27kDhO/Sv 31XsiRe8ACXsrVMc7evK50ytqvHOoOIo1e6nOjdwy4i5VwWZkplbV5m33wQwaNfvmHWU g/SV+b9Z/mf/vtphxwJwRaSQyrDnF3YO0OZLt5Q57lWe9fwtBmD/i6Toyc1vt1GC3gQD RFVV5VlFwpA1GuROZRuJXBf32NMM+oxgtfcJDwhueVFREK+beaBJTweBIoa/4dONby8k x+X0ThRms9jnIBwVo0Zjcq9g9Seqpak4RdRGwpjzm7YSORMX3Wlv1BF8iWwFTgwFBo+4 5/hw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=nnbH3PMmtkpu0JbtC0075TKaMd/vm5Ql8WyyOvhSsX4=; b=odAfyX6JcTkwlyakSIUscRHC0AjJZZYFQzhsW1qxxDiDvIGKovf9cBJZ+0tSLhdAJS I6XxskBxtDiG8tysMf7muWKUQQKyQVrUoOV6STAcYk7w4aexJNf34i0eJ74ZGrzUKfDV aeyllolxc9vpMZuukNuUXRKsUHBciRo4V3R+2sGVzvikyXV5ZwA4yKa651E7GHyxOEZh AchtaaTQTrNibCc+vecDUZ2YEp1e34Yub8PaFKvSc+686yR5u5m/eAcJZUXORpNoVhwu d+oLjWn19Yyxueo9wEWlXjWS1BA9MRzY+kEkw7BapYyX56hhkCGx62esklLJial7MMu7 UpgA== X-Gm-Message-State: AO0yUKWiolIueEM3SegC+wvH6X5i3nd1VLkmKvWk/Gm9k0ogKJ3oFfhI An4+Vuz7gRZ//G5Ah6J4xPc= X-Google-Smtp-Source: AK7set8NukNirPYQuTwrIocvWQGnbV0aLke6oIw2VOv/K0kpNcYsKt4X+fxncyUjISTZdcAXjlL+EQ== X-Received: by 2002:a05:622a:1306:b0:3bf:a9bf:9523 with SMTP id v6-20020a05622a130600b003bfa9bf9523mr18213225qtk.17.1677516228509; Mon, 27 Feb 2023 08:43:48 -0800 (PST) Received: from hurd (dsl-156-86.b2b2c.ca. [66.158.156.86]) by smtp.gmail.com with ESMTPSA id s184-20020a372cc1000000b0073bb00eb0besm5190071qkh.22.2023.02.27.08.43.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Feb 2023 08:43:48 -0800 (PST) From: Maxim Cournoyer To: Tobias Geerinckx-Rice Subject: Re: bug#58813: [PATCH] doc: Document how to use Patman for patches submission. References: <20230226035515.16214-1-maxim.cournoyer@gmail.com> <5b282ea05ffb7599aa9ccbc396904c2d352dac30.camel@gmail.com> <87bklgcpx7.fsf@gmail.com> Date: Mon, 27 Feb 2023 11:43:47 -0500 In-Reply-To: (Tobias Geerinckx-Rice's message of "Mon, 27 Feb 2023 00:45:44 +0000") Message-ID: <877cw3kqik.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 58813 Cc: ludo@gnu.org, Liliana Marie Prikler , 58813@debbugs.gnu.org, zimon.toutoune@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hello, Tobias Geerinckx-Rice writes: > Hi, > >> teams.scm > > I closed the bug-that-didn't-fix, but that still leaves a git-specific > command that doesn't actually facilitate git.=C2=B9 > > I guess salvaging 'teams.scm cc' into a generic 'Cc:' header generator > makes some sense? Without the $() use case. > > Otherwise: shall we simply remove it? I think I'd leave it; people can still use it to manually copy-paste its output into their command. That's not great, but it's better than nothing. --=20 Thanks, Maxim From debbugs-submit-bounces@debbugs.gnu.org Fri Mar 03 04:54:24 2023 Received: (at 58813) by debbugs.gnu.org; 3 Mar 2023 09:54:24 +0000 Received: from localhost ([127.0.0.1]:59661 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pY27M-00061n-FI for submit@debbugs.gnu.org; Fri, 03 Mar 2023 04:54:24 -0500 Received: from eggs.gnu.org ([209.51.188.92]:55528) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pY27K-00061a-UY for 58813@debbugs.gnu.org; Fri, 03 Mar 2023 04:54:23 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pY27F-00012x-CW; Fri, 03 Mar 2023 04:54:17 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=xjc1/D/Rc28yvc9JZ6QXcQzzV39PCsrO3H3vyhUvhvw=; b=beqxdJu/zQ86BTO6qLkz r+X7ro7+Giftt9BIm4ufsUSdBMhOZAUT2LitLRL+v9+Egwdywh3+aqZTK9v4/NmNyO/3aTVCzetlR XEdBQcqYWs4jXwb/xCNIGZzQX2gndQlCw1rAL2wt9tpP7OYgXjpf77d2EWo41bgjKgiIXBTjRHUIQ +Y6f3JXJtzKObJj8NDdciTIsL94olCHd8DJAexAGJGrrif3BxBkIU46zQXbhZhAqvSfUUPxvsqL4V GYUb2od34iWnmU55u19mpjlOutw62VUeb82qV//ThC5AAPTeP77920NJwtIKfvhs5MvybpCp3BCOG Gddr0udIifgHBg==; Received: from [2001:660:6102:320:e120:2c8f:8909:cdfe] (helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pY27E-0007OM-OI; Fri, 03 Mar 2023 04:54:16 -0500 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Maxim Cournoyer Subject: Re: [PATCH] doc: Document how to use Patman for patches submission. References: <20230226035515.16214-1-maxim.cournoyer@gmail.com> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: Tridi 13 =?utf-8?Q?Vent=C3=B4se?= an 231 de la =?utf-8?Q?R=C3=A9volution=2C?= jour de la Fumeterre X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Fri, 03 Mar 2023 10:54:14 +0100 In-Reply-To: <20230226035515.16214-1-maxim.cournoyer@gmail.com> (Maxim Cournoyer's message of "Sat, 25 Feb 2023 22:55:14 -0500") Message-ID: <87y1oeyxbt.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 58813 Cc: liliana.prikler@gmail.com, 58813@debbugs.gnu.org, zimon.toutoune@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi, Maxim Cournoyer skribis: > Fixes . It=E2=80=99s only tangentially related, no? > * doc/contributing.texi (Sending a Patch Series): Mention Patman. Adjust= the > examples to no longer showcase broken command substitutions. Add a secti= on > about how to use Patman, with examples. I=E2=80=99m not convinced we=E2=80=99d want to advocate for yet another too= l. I feel like this would make patch submission guidelines even more complex, or at least look more complex. Also, how many of the ~40 committers would be able to provide guidance with patman? That shouldn=E2=80=99t be the only criterion, but it certainl= y is an important one. Thanks, Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Fri Mar 03 12:26:20 2023 Received: (at 58813) by debbugs.gnu.org; 3 Mar 2023 17:26:20 +0000 Received: from localhost ([127.0.0.1]:33876 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pY9Ai-0000cE-8Y for submit@debbugs.gnu.org; Fri, 03 Mar 2023 12:26:20 -0500 Received: from mail-ed1-f68.google.com ([209.85.208.68]:40524) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pY9Af-0000bz-Rs for 58813@debbugs.gnu.org; Fri, 03 Mar 2023 12:26:18 -0500 Received: by mail-ed1-f68.google.com with SMTP id i34so13203365eda.7 for <58813@debbugs.gnu.org>; Fri, 03 Mar 2023 09:26:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1677864371; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=pEIFyhzo5ZQp9SAVEqduZw3l/HJknAo2Wm/YJWsxHLw=; b=ol3YuUb4RrJvYhFNeNs7nEET2G6jAqh5SLhQ7f3o3iCN+FgqXdSQME60dM5/4KGP+p 5uICk0m6Xt7kzExeemx06xwaPGb2ZFN2dEtoE97f6o1Z+ziDtSFt1dDuqQa/nnAV6I8l iR5SMLCKX3ykYKNiulFJs6woUnPR5ii70L4qNVe5U7azX5tgUT6OAYfSixwt3yRuHxCm lIKsn3Gd7kDu9RG0R/N+/bQ2LWlkP1HaTaK25iudB0hAOZQNiNCp2Ybl+hOgHJ/6aDbi iZCHVS36Gm44eS0RO90OqeGkLXP/LGkgCZcHWLFoLhuEL+xjvhS2Cvddaxr9+GqNeVvu aQXQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1677864371; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=pEIFyhzo5ZQp9SAVEqduZw3l/HJknAo2Wm/YJWsxHLw=; b=V1hmieDMs8xIp6udrtttHV714EGpjaA5nVhiypfbtZ/0E2W8Ez+Vm9Y8zDJkiClBRc c+pnlzFljqrVJMfbXGr8x4XXANqvVqzUPTK8AApxpeA6fFS768MxaIiSfehGFbcJucE1 NamKV272Trxa52TnO3sMASTy1ow77uW4onR+ywz/hZF5N3TQ0FHuUtyquuhsxbNfQEV4 +3HVLKaM4xkoigbhnUiyQWdBxU3UDoTmgkbs8FGMXw8+HzEv2uRijjuEyGCoGFsN8bTe 6sHMUBDSpdffh+QuwLmimuV4aI7RU9hoUBOneS3ZbmpOjbmbdv3N37Ym5CECXTJUOgjR lcaw== X-Gm-Message-State: AO0yUKW3fIra8Oke3K5e5CRftgd3s06ZabDPja96h6SLDFItCsu+E2s1 ntKj4HokE2ienuWpuYkvN3E= X-Google-Smtp-Source: AK7set+15F+AI1XnScP3pDlrDUfhE7t4uqmc4k3Anr+8CRlPFyNLUQOhoNm5v5uyC6HEHp62+8mq4Q== X-Received: by 2002:a17:907:7f13:b0:884:3174:119d with SMTP id qf19-20020a1709077f1300b008843174119dmr2916314ejc.14.1677864371642; Fri, 03 Mar 2023 09:26:11 -0800 (PST) Received: from lumine.fritz.box (85-127-52-93.dsl.dynamic.surfer.at. [85.127.52.93]) by smtp.gmail.com with ESMTPSA id t19-20020a170906065300b008be996c1630sm1160490ejb.39.2023.03.03.09.26.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Mar 2023 09:26:11 -0800 (PST) Message-ID: Subject: Re: [PATCH] doc: Document how to use Patman for patches submission. From: Liliana Marie Prikler To: Ludovic =?ISO-8859-1?Q?Court=E8s?= , Maxim Cournoyer Date: Fri, 03 Mar 2023 18:26:09 +0100 In-Reply-To: <87y1oeyxbt.fsf@gnu.org> References: <20230226035515.16214-1-maxim.cournoyer@gmail.com> <87y1oeyxbt.fsf@gnu.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.0 MIME-Version: 1.0 X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 58813 Cc: 58813@debbugs.gnu.org, zimon.toutoune@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Am Freitag, dem 03.03.2023 um 10:54 +0100 schrieb Ludovic Court=C3=A8s: > Hi, >=20 > Maxim Cournoyer skribis: >=20 > > Fixes . >=20 > It=E2=80=99s only tangentially related, no? >=20 > > * doc/contributing.texi (Sending a Patch Series): Mention Patman.=C2=A0 > > Adjust the examples to no longer showcase broken command > > substitutions.=C2=A0 Add a section about how to use Patman, with > > examples. >=20 > I=E2=80=99m not convinced we=E2=80=99d want to advocate for yet another t= ool.=C2=A0 I feel > like this would make patch submission guidelines even more complex, > or at least look more complex. I do think it'd be fine to have more options (in a "use what you find convenient" way), but as-is this patch replaces one imperfect tool with one where: > [H]ow many of the ~40 committers would be able to provide guidance > with patman?=C2=A0=C2=A0 I'm not one of them :( > That shouldn=E2=80=99t be the only criterion, but it certainly is an > important one. I think an important criterion should be what aspiring committers can expect when they follow the advice as written. Compare and contrast 'guix style', where committers often have to point out its flaws. Cheers From debbugs-submit-bounces@debbugs.gnu.org Mon Mar 06 09:54:00 2023 Received: (at 58813) by debbugs.gnu.org; 6 Mar 2023 14:54:00 +0000 Received: from localhost ([127.0.0.1]:41795 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pZCDw-0008Do-4z for submit@debbugs.gnu.org; Mon, 06 Mar 2023 09:54:00 -0500 Received: from eggs.gnu.org ([209.51.188.92]:51450) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pZCDt-0008Da-UR for 58813@debbugs.gnu.org; Mon, 06 Mar 2023 09:53:58 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pZCDo-0001BJ-IB; Mon, 06 Mar 2023 09:53:52 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=rO6vFlN6TzCapTiBby5jdvGfiUj9rMYgDP1zgrJqgXI=; b=PdqqDgFZaNPQFrBQAzKM cUOPdwpBRoDGATDaP//2NLA7waOITN9V6DSiO3tLxOqff7PSwG8rLBMKdPSptWvlWezo81XzbGvQY ma30CTbN70SvdQGQCA5lXqZzRJwmNGycaLcM/0A/J0/ZPxF+/zQ7YzhTdMtrG1WTrXR3+6husCpYx Lf2+sqwD2EYXnYRAe6s9U+0p+QIfVyjcJjqXJWVSqeEcGLadxUbRMV1nKMCQPbR5DI6kTzD6FLNKd Lt88C6ByfOE3m918uO8hvwKt4EyoQQ0M1Gc09lvp8wD7N019OINn9RW6hdAF6CC/7W2dijj8+VhhV Y+27Tik+8LPFzw==; Received: from [2001:660:6102:320:e120:2c8f:8909:cdfe] (helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pZCDo-0003Ny-1o; Mon, 06 Mar 2023 09:53:52 -0500 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Liliana Marie Prikler Subject: =?utf-8?B?4oCYZ3VpeCBzdHlsZeKAmQ==?= flaws References: <20230226035515.16214-1-maxim.cournoyer@gmail.com> <87y1oeyxbt.fsf@gnu.org> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: Sextidi 16 =?utf-8?Q?Vent=C3=B4se?= an 231 de la =?utf-8?Q?R=C3=A9volution=2C?= jour de =?utf-8?Q?l'=C3=89pinard?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Mon, 06 Mar 2023 15:53:49 +0100 In-Reply-To: (Liliana Marie Prikler's message of "Fri, 03 Mar 2023 18:26:09 +0100") Message-ID: <87bkl6aq2q.fsf_-_@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 58813 Cc: 58813@debbugs.gnu.org, Maxim Cournoyer , zimon.toutoune@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Liliana Marie Prikler skribis: > Compare and contrast > 'guix style', where committers often have to point out its flaws. Hi! Drifting off-topic, but: I=E2=80=99d really like people to report spec= ific issues to bug-guix so we can act on them and reach the point where the tool=E2=80=99s output is good 99% of the time. Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Mon Mar 06 12:42:09 2023 Received: (at 58813) by debbugs.gnu.org; 6 Mar 2023 17:42:10 +0000 Received: from localhost ([127.0.0.1]:43566 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pZEqf-00079t-Kh for submit@debbugs.gnu.org; Mon, 06 Mar 2023 12:42:09 -0500 Received: from mail-qt1-f172.google.com ([209.85.160.172]:41659) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pZEqe-00079h-3I for 58813@debbugs.gnu.org; Mon, 06 Mar 2023 12:42:08 -0500 Received: by mail-qt1-f172.google.com with SMTP id c3so11441160qtc.8 for <58813@debbugs.gnu.org>; Mon, 06 Mar 2023 09:42:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1678124522; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to; bh=MpBKpu1m0TclBNKLlR2CdPS9PY1gPNVFr/kCDirkGGk=; b=An4HUvs/aYEgKPVqax9ZBO+F/iGO5tZsedD5qpZ5B8f+9zS2qK357/O2vtaIxOeMad HHZkOx00cZMylDy5B97Ai/0laZ85kWk+04Ta2Y07L6mBqXswvVd5fyFNcTWEXVLTF/oq TGUgk7OJ/v3TzmZNJBUTJGqJULGeE5Oo6T3WhljW3dcRyriwsbDZ0+bod3D7TaorvEYT /uXY3DDmPdOuy6K5E8DEUFml2X3v4O5TxMzBhXuLuumE7/2uWq+KBSXlZqgR9kWBK43V Jk4z00+WzRS9NBjnuXtqukW96lhql2HRAbwY46t8Mi6zr6zaMJ5jDZ3l3D62Mwv9PIjD 2UPg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678124522; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=MpBKpu1m0TclBNKLlR2CdPS9PY1gPNVFr/kCDirkGGk=; b=x+h5RkZ1y5z92oTQ2XufBj2fvkg0EgYqXz2T3ULmpSfRHKbBD08ewqN4qMEDfAKxQo p+OajaZ4IKQ5//NKoVCcWs1v3UmmrVe5DRXvL/wZfs4FdSQliOodOxTSZjBJFBcEVoaT PnYU2VkAhMIUadUGXdU1NeIcq9bK3kBDPwYoxfd7VHv7Yf5k9xmFKaMF0fCSRvb4PBv2 HaGncZKXUHZs1hvTj93OhSRM0D4vUHbzy1wd2zhw0hT34pMmdlKoaJQc5u9PZ6ePbbjr mOQgE5X6AK426NdeQv0Ow29PEbvu0KHACnzJ6iEB0RWxrDT2b6wLXL/Hy+q9FkJCx2LD L9Lw== X-Gm-Message-State: AO0yUKUs9Pj2ny7IjmbHpSsyGaSXkuj9YGzJuT+3I7bcxyHQPrnI7nYo sEZ1Q3Fr1zY/0VKG5us0vt4= X-Google-Smtp-Source: AK7set8kayAAl38L8CBmDqhariBSYsu3ttQM0V7zYJbRKOX1Z3z0bcYYAehFZGhb7gXDJlRPaKlQ7Q== X-Received: by 2002:ac8:58ce:0:b0:3bf:a061:6cb1 with SMTP id u14-20020ac858ce000000b003bfa0616cb1mr20774758qta.46.1678124522363; Mon, 06 Mar 2023 09:42:02 -0800 (PST) Received: from hurd (dsl-149-144.b2b2c.ca. [66.158.149.144]) by smtp.gmail.com with ESMTPSA id f5-20020ac81345000000b003b9b41a32b7sm7869392qtj.81.2023.03.06.09.42.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Mar 2023 09:42:01 -0800 (PST) From: Maxim Cournoyer To: Ludovic =?utf-8?Q?Court=C3=A8s?= Subject: Re: =?utf-8?B?4oCYZ3VpeCBzdHlsZeKAmQ==?= flaws References: <20230226035515.16214-1-maxim.cournoyer@gmail.com> <87y1oeyxbt.fsf@gnu.org> <87bkl6aq2q.fsf_-_@gnu.org> Date: Mon, 06 Mar 2023 12:42:00 -0500 In-Reply-To: <87bkl6aq2q.fsf_-_@gnu.org> ("Ludovic =?utf-8?Q?Court=C3=A8s?= =?utf-8?Q?=22's?= message of "Mon, 06 Mar 2023 15:53:49 +0100") Message-ID: <87a60p22vr.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 58813 Cc: Liliana Marie Prikler , 58813@debbugs.gnu.org, zimon.toutoune@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Ludo, Ludovic Court=C3=A8s writes: > Liliana Marie Prikler skribis: > >> Compare and contrast >> 'guix style', where committers often have to point out its flaws. > > Hi! Drifting off-topic, but: I=E2=80=99d really like people to report sp= ecific > issues to bug-guix so we can act on them and reach the point where the > tool=E2=80=99s output is good 99% of the time. See #61013 :-). --=20 Thanks, Maxim From debbugs-submit-bounces@debbugs.gnu.org Mon Mar 06 20:07:17 2023 Received: (at 58813) by debbugs.gnu.org; 7 Mar 2023 01:07:17 +0000 Received: from localhost ([127.0.0.1]:44028 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pZLnQ-0006Vr-T1 for submit@debbugs.gnu.org; Mon, 06 Mar 2023 20:07:17 -0500 Received: from mail-qt1-f178.google.com ([209.85.160.178]:40930) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pZLnP-0006Vd-2g for 58813@debbugs.gnu.org; Mon, 06 Mar 2023 20:07:15 -0500 Received: by mail-qt1-f178.google.com with SMTP id h19so12837935qtk.7 for <58813@debbugs.gnu.org>; Mon, 06 Mar 2023 17:07:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1678151229; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to; bh=Lnx4k+tT0HPc0EKVa9ALB8KE3Ur3ypXwjJc5js29BaY=; b=nzXQb02ioN/bInLMHVKfcqLPHyX3g3xO5zO4x3xCoxutP17q6V2UDT1XXt0wsBo9Ot qL9BjyBNGc+cgVszx/r2bY15WDY0FAC/A9kYNa8tl3cfpyL2dNGkkTUtplBY1OJzQBfl lsv+Y3JM/anOUSGrkE4jizHW1v9jdFjHMqa6GwBbxR+utFNbJnvgkB45JIAsrfb3oaMJ 3JMIIG1eq+1GNRaMobvp+QUEPjjIIjb5aLACiJz9nG12wceldi76n6R5YaEMBCiy1bdV nVJVZqFfYNHPVV9z5UCRNVSnYF5BEyR1kNQxCGc31GvoR1l4gfHBZgnZp9THGIcPB4Fl L+hw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678151229; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=Lnx4k+tT0HPc0EKVa9ALB8KE3Ur3ypXwjJc5js29BaY=; b=sBvxQA4vq+fvj+p0xJWmEdtJtvSB+dzyUrkLJfubNGjRqW8zOt5Js9DjyRzZ7Lb6m+ n4ze/Mt3FREiuttJQCzYpO+eMptCDkYWzJCsK6YveLNwzT4uNtrdjA1C8J1K3PPI3Yrl pycfztUe7pV1e1PEgU/T93vmABDZst6zmZUI8VTK+dqm6zQ9g67jrTR6y/nkz/TwIvta 63E7xltfUtlCT+51gT2lGbEQ2Wdxv9o1VDHbN6a3Pi2E9EadHmLTiRgWqZkik2+TB0Un oTWdHV7o1URG+PkggDMDV646sIpCGQOKHIiQ/fUrSf5uqoIsUtfU42sbaljafvPgUQ9W 204w== X-Gm-Message-State: AO0yUKWrP78fepVu3nxXsNK2kJVNRdF4tv+Ytir3bJfKdrJTVKvRFmQP 040EOL2Qswil5nowumSjErc= X-Google-Smtp-Source: AK7set+m48UQVYBPOxKU7KtddAjrMF5q2B/cP8PrBwzfMFqXrH1iD5xPGxtFpdL962UAi1+z/6XTuw== X-Received: by 2002:a05:622a:1106:b0:3bd:1835:b001 with SMTP id e6-20020a05622a110600b003bd1835b001mr21844339qty.20.1678151229425; Mon, 06 Mar 2023 17:07:09 -0800 (PST) Received: from hurd ([2607:fad8:4:3::1000]) by smtp.gmail.com with ESMTPSA id bl14-20020a05620a1a8e00b00706bc44fda8sm8431519qkb.79.2023.03.06.17.07.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Mar 2023 17:07:08 -0800 (PST) From: Maxim Cournoyer To: Ludovic =?utf-8?Q?Court=C3=A8s?= Subject: Re: [PATCH] doc: Document how to use Patman for patches submission. References: <20230226035515.16214-1-maxim.cournoyer@gmail.com> <87y1oeyxbt.fsf@gnu.org> Date: Mon, 06 Mar 2023 20:07:07 -0500 In-Reply-To: <87y1oeyxbt.fsf@gnu.org> ("Ludovic =?utf-8?Q?Court=C3=A8s=22'?= =?utf-8?Q?s?= message of "Fri, 03 Mar 2023 10:54:14 +0100") Message-ID: <87fsahz7wk.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 58813 Cc: liliana.prikler@gmail.com, 58813@debbugs.gnu.org, zimon.toutoune@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Ludovic, Ludovic Court=C3=A8s writes: > Hi, > > Maxim Cournoyer skribis: > >> Fixes . > > It=E2=80=99s only tangentially related, no? It's not totally a tangent, because it removes examples which do not work, and replace them with ones that do work, and recommend a tool that can do what the previous shell command substitution failed to do correctly (due to shell parsing rules). >> * doc/contributing.texi (Sending a Patch Series): Mention Patman. Adjus= t the >> examples to no longer showcase broken command substitutions. Add a sect= ion >> about how to use Patman, with examples. > > I=E2=80=99m not convinced we=E2=80=99d want to advocate for yet another t= ool. I feel > like this would make patch submission guidelines even more complex, or > at least look more complex. > > Also, how many of the ~40 committers would be able to provide guidance > with patman? That shouldn=E2=80=99t be the only criterion, but it certai= nly is > an important one. Since it's just documented as another tool on top, I don't think this matters too much (it can be adopted or not). It's also a very simple tool, which is more often than not invoked as simply 'patman' or 'patman -n' (for dry-run). I've also discovered about '--cc-cmd', which could be used with the recently introduced get-maintainer mode (which was added for patman support); it can be used like this: --8<---------------cut here---------------start------------->8--- git send-email --cc-cmd=3D'etc/teams.scm get-maintainer' --dry-run -1 --8<---------------cut here---------------end--------------->8--- It does the same thing as the copy/pasting of the output of --8<---------------cut here---------------start------------->8--- etc/teams.scm cc-members HEAD^ HEAD --8<---------------cut here---------------end--------------->8--- To the git send-email command, but with one difference: it uses '--cc' for the email addresses instead of the nicer --add-header=3D"X-Debbugs-Cc: mail@example.org" ones. The later is best because when initially sending the message to Debbugs, there's no bug # known yet, and the receivers would be left to guess and perhaps even reply erroneously to guix-patches@gnu.org and create a new ticket. For this reason, I'm toying with the idea of contributing a "--x-cmd" option to git send-email, which would be a script that outputs arbitrary git send-email options to add to its command line. To be continued... --=20 Thanks, Maxim From debbugs-submit-bounces@debbugs.gnu.org Tue Mar 07 06:35:37 2023 Received: (at 58813) by debbugs.gnu.org; 7 Mar 2023 11:35:37 +0000 Received: from localhost ([127.0.0.1]:44693 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pZVbU-0006Pr-LL for submit@debbugs.gnu.org; Tue, 07 Mar 2023 06:35:37 -0500 Received: from mail-wm1-f50.google.com ([209.85.128.50]:46732) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pZVbR-0006Pc-P6 for 58813@debbugs.gnu.org; Tue, 07 Mar 2023 06:35:34 -0500 Received: by mail-wm1-f50.google.com with SMTP id l7-20020a05600c1d0700b003eb5e6d906bso6977427wms.5 for <58813@debbugs.gnu.org>; Tue, 07 Mar 2023 03:35:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1678188927; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=l8jFFFH3vagAVYZSJp5vTEh6HYZLfa/hKI7ogF/IZlU=; b=cDdiAqCu010YOx1dPVJu3nVDA6Me92TImZ20WZTK9fPYiqXnXjGQAwHBCWwZT4mu7v gbqDWFON023FcnFC5O3Gw7LVV77ZONdJFhmSH4zQMZ/F5GXzIEXHyGrrszdlo6HGrZD+ aFgVM5tKdpouETV0wNw6hm6zlVVZ5+shiRhlGRgX506TA0IVOuvmkpEBZb+tTgdwkPXH O3W8c57nSaIn1k5omEVte/CfPA5ItUMu2JIBAW7c3eyNUbPZ+suLtQLfHgQ/UPwkFXM1 yebj7q1eS9JWO+XbMna/yiQHYpE6ws0O4/ukLOFRdj0yE1PjG5E2ExzWyezDny9/MPX2 n4zA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678188927; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=l8jFFFH3vagAVYZSJp5vTEh6HYZLfa/hKI7ogF/IZlU=; b=g+DaHDFwD6ravo5yCA4KPXTU8ygNeKSDsjfwdg9Rov1JHukc4YSbIuYH4FeXxrjoQ7 uyE5wnzNX5sTPXvepxSOHb1AwJkZVEVt+nUGC33C9yg05Ssf/iJKLK7aUv3HF2laMuIz HRfOTU5win6GPvXZFE9LjUub8Ps/58YGSA3Hg0leZUTTToKqKH13DPu/iQwi91eeQ2u2 4R2vIbUvVVzj2JmR9mtq1siZuz2Awv8CcDc1+jF7Va4rzvt+szKsgU4iIGuqkOf0/iUj jg9xqpUDeyICAfpI5z7AD3U6OrCG0Jn6ReoTzZYURD85+TI9ysE/HdF2obGq6FFGGeIX sK0A== X-Gm-Message-State: AO0yUKXTTiM9bXco4uZgSAKtzlPnv0p2Zo3a8/jgkn/2M9+udehRhMyt wqzs6FUP9X7NgJ2VLSfiuaSkgF/xGhA= X-Google-Smtp-Source: AK7set+VXHUpusnf6CdPt8bOy1FfXUaqd0QtaLletmXIWSPz3gVRzmW1wZhDTouLjK73PFBg59lxwA== X-Received: by 2002:a05:600c:3b8b:b0:3e8:7ca3:8424 with SMTP id n11-20020a05600c3b8b00b003e87ca38424mr11064579wms.1.1678188927419; Tue, 07 Mar 2023 03:35:27 -0800 (PST) Received: from localhost.localdomain ([2a01:e0a:59b:9120:65d2:2476:f637:db1e]) by smtp.gmail.com with ESMTPSA id q14-20020a05600c46ce00b003daffc2ecdesm17360151wmo.13.2023.03.07.03.35.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Mar 2023 03:35:27 -0800 (PST) From: Simon Tournier To: 58813@debbugs.gnu.org Subject: [PATCH v2] doc: Document how to use Patman for patches submission. Date: Tue, 7 Mar 2023 12:35:24 +0100 Message-Id: <20230307113524.901320-1-zimon.toutoune@gmail.com> X-Mailer: git-send-email 2.38.1 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 58813 Cc: ludo@gnu.org, liliana.prikler@gmail.com, maxim.cournoyer@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) From: Maxim Cournoyer Fixes . * doc/contributing.texi (Sending a Patch Series): Adjust the examples to no longer showcase broken command substitutions. (Patch management using patman): New section about how to use Patman, with examples. --- doc/contributing.texi | 111 ++++++++++++++++++++++++++++++++++++++++-- doc/guix.texi | 2 +- 2 files changed, 108 insertions(+), 5 deletions(-) Hi, My proposal is to have Patch management using patman as a dedicated section. This way, we keep the submission guidelines simple using good ol' git-send-email. And by being a dedicated section, it acts as the Perfect Setup: that's a tool very handy for doing the patch management task. WDYT? Cheers, simon diff --git a/doc/contributing.texi b/doc/contributing.texi index 61c05c2489..197f9719ba 100644 --- a/doc/contributing.texi +++ b/doc/contributing.texi @@ -1531,7 +1531,7 @@ that we can send the rest of the patches to. @example $ git send-email outgoing/0000-cover-letter.patch -a \ --to=guix-patches@@gnu.org \ - $(etc/teams.scm cc-members ...) + --cc=team-member1@@example.org --cc=team-member2@@example.org ... $ rm outgoing/0000-cover-letter.patch # we don't want to resend it! @end example @@ -1545,7 +1545,7 @@ can send the actual patches to the newly-created issue address. @example $ git send-email outgoing/*.patch \ --to=@var{ISSUE_NUMBER}@@debbugs.gnu.org \ - $(etc/teams.scm cc-members ...) + --cc=team-member1@@example.org --cc=team-member2@@example.org ... $ rm -rf outgoing # we don't need these anymore @end example @@ -1588,18 +1588,121 @@ You can run the following command to have the @code{Mentors} team put in CC of a patch series: @example -$ git send-email --to @var{ISSUE_NUMBER}@@debbugs.gnu.org $(./etc/teams.scm cc mentors) *.patch +$ ./etc/teams.scm cc mentors @end example +then note the @var{output} of the script. + +@example +$ git send-email --to @var{ISSUE_NUMBER}@@debbugs.gnu.org @var{output} *.patch +@end example + +Taking care to manually splice the @var{output} of the +@file{etc/teams.scm} script into the command. + The appropriate team or teams can also be inferred from the modified files. For instance, if you want to send the two latest commits of the current Git repository to review, you can run: @example $ guix shell -D guix -[env]$ git send-email --to @var{ISSUE_NUMBER}@@debbugs.gnu.org $(./etc/teams.scm cc-members HEAD~2 HEAD) *.patch +[env]$ git send-email --to @var{ISSUE_NUMBER}@@debbugs.gnu.org @var{output} *.patch +@end example + +@node Patch management using @command{patman} +@subsection Patch management using @command{patman} +@cindex patman patch manager +@cindex patch management, via patman + +If you want something a bit higher level than @command{git send-email} +to organize your patch submissions and take care of its various options +for you, you may want to try the @command{patman} command, from the +eponymous package. Patman's help can be accessed via @samp{patman -H} +or as an Info manual after installing the @code{u-boot-documentation} +package (@pxref{Patman patch manager,,,u-boot,The U-Boot +Documentation}). + +As manually stitching the output of the @file{etc/teams.scm} script in +the @command{git send-email} command can get tedious; you may prefer to +use Patman to automate this for you. Its necessary basic configuration +is already found at the root of the Guix repository, in the +@file{.patman} file. Another useful bit to have is a default +destination for the @command{git send-email} command. You can specify +it in your repository-local Guix @file{.git/config} file with: + +@example +[sendemail] + to = guix-patches@@gnu.org +@end example + +To send a long series to Debbugs, the patches can be written to the +current directory with: + +@example +patman -n +@end example + +The first patch should then be sent using @samp{git send-email +0000-cover-letter.patch}, as explained earlier (@pxref{Multiple +Patches}). + +After Debbugs has issued a unique bug email in reply to that initial +patch submission, e.g. @email{NNNNN@@debbugs.gnu.org}, you can save this +information into the top commit of your patch series (it doesn't matter +which, but it's more convenient to amend it later when it's at the top) +like so, via the Patman-specific @code{Series-to} git message tag: + +@example +gnu: Add foo. + +* gnu/packages/dummy.scm: Add foo. + +Series-to: NNNNN@@debbugs.gnu.org @end example +You can then send your series to that address with the right people +automatically added in CC by simply issuing: + +@example +patman +@end example + +After addressing the first round of review comments, you can annotate a +v2 patch series by adding these Patman-specific git message tags: + +@example +gnu: Add foo. + +* gnu/packages/dummy.scm: Add foo. + +Series-to: NNNNN@@debbugs.gnu.org +Series-version: 2 +Series-changes: 2 +- Factorized X into Y and Z +@end example + +The @command{patman} command will then take care to automate the right +@code{git send-email} command and produce patch annotations useful for +the reviewers. + +After the review is complete, if you are the one merging your own +changes, you should take care to strip any Patman git message tags. +This can be done by writing the patches to the current directory with: + +@example +patman -n +@end example + +and then applying them to the main branch with: + +@example +git am *.patch +@end example + +For more information, run @samp{patman -H} or read its info manual, +which can be installed with the @code{u-boot-documentation} package +(@pxref{Patman patch manager,,,u-boot,The U-Boot Documentation}). + @node Tracking Bugs and Patches @section Tracking Bugs and Patches diff --git a/doc/guix.texi b/doc/guix.texi index 6671ba9305..1fe03df3b7 100644 --- a/doc/guix.texi +++ b/doc/guix.texi @@ -49,7 +49,7 @@ Copyright @copyright{} 2017 humanitiesNerd@* Copyright @copyright{} 2017, 2021 Christine Lemmer-Webber@* Copyright @copyright{} 2017, 2018, 2019, 2020, 2021, 2022 Marius Bakke@* Copyright @copyright{} 2017, 2019, 2020, 2022 Hartmut Goebel@* -Copyright @copyright{} 2017, 2019, 2020, 2021, 2022 Maxim Cournoyer@* +Copyright @copyright{} 2017, 2019, 2020, 2021, 2022, 2023 Maxim Cournoyer@* Copyright @copyright{} 2017–2022 Tobias Geerinckx-Rice@* Copyright @copyright{} 2017 George Clemmer@* Copyright @copyright{} 2017 Andy Wingo@* base-commit: 26e9725c54df48eda8282e6716a7581a7755f8f9 -- 2.38.1 From debbugs-submit-bounces@debbugs.gnu.org Tue Mar 07 11:46:42 2023 Received: (at 58813) by debbugs.gnu.org; 7 Mar 2023 16:46:42 +0000 Received: from localhost ([127.0.0.1]:47091 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pZaSY-0003EV-43 for submit@debbugs.gnu.org; Tue, 07 Mar 2023 11:46:42 -0500 Received: from mail-qt1-f182.google.com ([209.85.160.182]:43574) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pZaSX-0003EI-4y for 58813@debbugs.gnu.org; Tue, 07 Mar 2023 11:46:41 -0500 Received: by mail-qt1-f182.google.com with SMTP id cf14so14981383qtb.10 for <58813@debbugs.gnu.org>; Tue, 07 Mar 2023 08:46:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1678207595; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=bTcaGrAh9wRcgqIcxWQ2VyjNaxzQw0fXx4snSQACmQA=; b=H5sFMjowCJz2wLC8RnchNtqLerNyT/JXXNIjvwsej4ShB1DLNs4LthY4zmukREzaMz Q42dBSDgIHlvwXEo7aIRSfs3OrjI21Ms5+M5qWXGcOMpRXN92b8T3YAYQiyiS5ABB64a 9M1P8TtSC0TgfadNVZz1TQJVvbw0L9b7s1NcEnUW5HkLmppG7PYxS53eOvN2WyPHOXZY 76qp+zkrpxkIRwXaIaTbSSfVAGbqCWvjuvspgD+Xms6XKLlj9vUUDpWD7qENtiKnUEVv i7wG7ERsdjXRO2ppbvhs3Tx+VZU4L4NviAFBQYn734i6ru8v/BP3zIKKBcfbgdfheB+g NKLA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678207595; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=bTcaGrAh9wRcgqIcxWQ2VyjNaxzQw0fXx4snSQACmQA=; b=lgfp+O/pOfHbQz8qlcClhU3h/cOy+9ec9TAi2IFr1AudX9N1ujvX+J6S3MDk+oDnVp 2oXT2O6f9TC8LMahTZnSxIQEDYePYPNAzihYxK2t7ZWpofDxXhSbWy4FmFwedx5HPnus Ikgo10fBYvMmiUoPk6btv7TwCfk2Vu96XL239ToNnm3ME3MvSLxczJWBOGYIP0sBHe/e /RG3ygbQjgMmoYDg+ZQMQNDPwc1HEWTnkqzJ+X2Q+YQ+0GdU17yKZUjEKKSOiQc7qvns fEWrF5dLrIRba6nK2TAhQkFcg9NRr+JBi48kmFo33D/Vh3MwCcNlQ07n7ujvjR80tqqf BuUg== X-Gm-Message-State: AO0yUKXB2l5Wf2MXK3ySeUuUxLcqvbt0rbsJOBWw71aDo+aclWfgybdd gSbNob32DiPBrxCjM+dCuTA= X-Google-Smtp-Source: AK7set9S58fZ5XY2petye6yHeXH5a/k+sV7wfTWqCXTOKJUcFH8ZspgX9Q8uojrQ1ePM+VD0SPtkpQ== X-Received: by 2002:a05:622a:64c:b0:3b6:3577:2fe7 with SMTP id a12-20020a05622a064c00b003b635772fe7mr24922749qtb.49.1678207595148; Tue, 07 Mar 2023 08:46:35 -0800 (PST) Received: from hurd ([2607:fad8:4:3::1000]) by smtp.gmail.com with ESMTPSA id r25-20020ac87959000000b003bfc1f49ad1sm9778150qtt.87.2023.03.07.08.46.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Mar 2023 08:46:34 -0800 (PST) From: Maxim Cournoyer To: Simon Tournier Subject: Re: [PATCH v2] doc: Document how to use Patman for patches submission. References: <20230307113524.901320-1-zimon.toutoune@gmail.com> Date: Tue, 07 Mar 2023 11:46:33 -0500 In-Reply-To: <20230307113524.901320-1-zimon.toutoune@gmail.com> (Simon Tournier's message of "Tue, 7 Mar 2023 12:35:24 +0100") Message-ID: <877cvsy0eu.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 58813 Cc: ludo@gnu.org, liliana.prikler@gmail.com, 58813@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Simon, Simon Tournier writes: > From: Maxim Cournoyer > > Fixes . > > * doc/contributing.texi (Sending a Patch Series): Adjust the examples to no > longer showcase broken command substitutions. > (Patch management using patman): New section about how to use Patman, with > examples. > --- > doc/contributing.texi | 111 ++++++++++++++++++++++++++++++++++++++++-- > doc/guix.texi | 2 +- > 2 files changed, 108 insertions(+), 5 deletions(-) > > Hi, > > My proposal is to have Patch management using patman as a dedicated section. > This way, we keep the submission guidelines simple using good ol' > git-send-email. And by being a dedicated section, it acts as the Perfect > Setup: that's a tool very handy for doing the patch management task. > > WDYT? Based on the other replies gathered so far, it seems there's little excitement to learn yet another tool for patch management, so I think I'll pursue the '--x-cmd' idea I already wrote about here, which would allow integration directly with 'git send-email'. -- Thanks, Maxim From debbugs-submit-bounces@debbugs.gnu.org Tue Mar 07 16:10:04 2023 Received: (at 58813) by debbugs.gnu.org; 7 Mar 2023 21:10:04 +0000 Received: from localhost ([127.0.0.1]:47283 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pZeZP-0001jj-M7 for submit@debbugs.gnu.org; Tue, 07 Mar 2023 16:10:04 -0500 Received: from mail-wm1-f53.google.com ([209.85.128.53]:55053) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pZeZH-0001iz-AQ for 58813@debbugs.gnu.org; Tue, 07 Mar 2023 16:10:01 -0500 Received: by mail-wm1-f53.google.com with SMTP id p26so8651777wmc.4 for <58813@debbugs.gnu.org>; Tue, 07 Mar 2023 13:09:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1678223389; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=dpuXHRPijWSgS1Y0eKg60eiGDITx70qn3qOZLEPwjGU=; b=HtJKX+b2BCXpTp2uztjJHpiuOAKXvt99zAaVFHjB7EChAWs9fWiycWKRZGovTxOj0W owRDBFRi6AOL+qiWFDzT1qeYHzASWFSMeekfjK4yVvBoZJgV0wbcfDyS8Jwb+MxEJngj ZYiNTs6BdHbpE42QhnZhzi9CfgZZFaxKW9EkgC/S6lJQFKNqzW04i7/xdeiX5cvtfTk/ yF0KG66HP8ZEPr7fOw+J10Id3xukW/D1mcmWEeUoWAPCxlKgLw9K/wcV3RN1pCJJ/c9c fPHa9aDfBDytozTeV2g1T62WIKKGMFh13vXf+XDnzusX0qbXvQXGyZ6/gYlQy3RRcujA hDUA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678223389; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=dpuXHRPijWSgS1Y0eKg60eiGDITx70qn3qOZLEPwjGU=; b=5MfllR1XvsXHRNFQ5MOdB0mAKT4CgAjdUr5629nPbBZ56FWq/na6NIYvYlvz4TbRSc 7nj+9jfyDT6FQhzyPEKmgGlyMqba1KC48+61Q0q7tr3ilY3R4v/avxIul4OqL0QLfnu8 Lhlmibs2QRxt8qDwlJ9at9BKjVzfdzv4i8d+Y0ppHaZ+ti0BgWXztsnVxCWMcIR44fiC GU3+8rOEtJoDzjBYjbKn5AwNNd5b7GVZp8ro1CtmYfM5a/0k1alLM7jJ/5xU8bf7xaZy o1oHZArBiqXCsk9u3DPm+sSEqUVUaZ8ksrCSnfYt4ya8rrac2eDppd19FpZZwtfe3SMm 1fag== X-Gm-Message-State: AO0yUKV1FTGvJ1QwzIT8lb0vXw9Ute0e2FNUO+hQNzAbRghwZPyppdyZ 8JZuqJTKBcehO+/MJH8vuQeRlz3WpiY= X-Google-Smtp-Source: AK7set8nsDntxBC+nzcM7FwS3QQOvJ4egO5jI2AOsxb9obz/rp5rzTGPKMSyqYmdQkRpkpoTklFFVA== X-Received: by 2002:a05:600c:1c84:b0:3e7:534a:694e with SMTP id k4-20020a05600c1c8400b003e7534a694emr324775wms.3.1678223389309; Tue, 07 Mar 2023 13:09:49 -0800 (PST) Received: from lili ([2a01:e0a:59b:9120:65d2:2476:f637:db1e]) by smtp.gmail.com with ESMTPSA id l26-20020a05600c1d1a00b003e20970175dsm19883886wms.32.2023.03.07.13.09.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Mar 2023 13:09:49 -0800 (PST) From: Simon Tournier To: Maxim Cournoyer Subject: Re: bug#58813: [PATCH v2] doc: Document how to use Patman for patches submission. In-Reply-To: <877cvsy0eu.fsf@gmail.com> References: <20230307113524.901320-1-zimon.toutoune@gmail.com> <877cvsy0eu.fsf@gmail.com> Date: Tue, 07 Mar 2023 18:39:00 +0100 Message-ID: <86sfega2bv.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 1.1 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Hi, On Tue, 07 Mar 2023 at 11:46, Maxim Cournoyer wrote: >> My proposal is to have Patch management using patman as a dedicated section. >> This way, we keep the submission guidelines simple using good ol' >> git-send-email. And by being a dedicated section [...] Content analysis details: (1.1 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (zimon.toutoune[at]gmail.com) 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record 1.1 DATE_IN_PAST_03_06 Date: is 3 to 6 hours before Received: date -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [209.85.128.53 listed in wl.mailspike.net] -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [209.85.128.53 listed in list.dnswl.org] X-Debbugs-Envelope-To: 58813 Cc: ludo@gnu.org, liliana.prikler@gmail.com, 58813@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.1 (/) Hi, On Tue, 07 Mar 2023 at 11:46, Maxim Cournoyer w= rote: >> My proposal is to have Patch management using patman as a dedicated sect= ion. >> This way, we keep the submission guidelines simple using good ol' >> git-send-email. And by being a dedicated section, it acts as the Perfect >> Setup: that's a tool very handy for doing the patch management task. > Based on the other replies gathered so far, it seems there's little > excitement to learn yet another tool for patch management, so I think > I'll pursue the '--x-cmd' idea I already wrote about here, which would > allow integration directly with 'git send-email'. Well, from my point of view, it is not exclusive. :-) Let say I do not use the tools =E2=80=99info=E2=80=99 and =E2=80=99man=E2= =80=99, but the manual has a section dedicated to it [1]. Let say I am not excited by LaTex/TeX with Guix, but the manual has a section dedicated to it [2]. And the =E2=80=9CPerfect Setup=E2=80=9D is about Emacs and links to Magit, = other tools that we could ask. Maybe I am not excited by them. Etc. Anyway. I still think this documentation for configuring =E2=80=99patman=E2=80=99 a= bout =E2=80=9CPatch management=E2=80=9D is helpful. I think it could be part of the manual. I= f not for reasons I am missing, at least this documentation should be included in the Cookbook. And from my point of view, if we say that [1,2] fits the manual, then this dedicated section about =E2=80=9CPatch management=E2=80=9D also fits t= he manual. If this dedicated section about =E2=80=9CPatch management=E2=80=9D also doe= s not fit the manual, then [1,2] neither. :-) 1: 2: Cheers, simon From debbugs-submit-bounces@debbugs.gnu.org Wed Mar 08 00:29:52 2023 Received: (at 58813) by debbugs.gnu.org; 8 Mar 2023 05:29:52 +0000 Received: from localhost ([127.0.0.1]:47653 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pZmN5-0005Oo-Rl for submit@debbugs.gnu.org; Wed, 08 Mar 2023 00:29:52 -0500 Received: from mail-wm1-f67.google.com ([209.85.128.67]:34304) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pZmN3-0005OY-GH for 58813@debbugs.gnu.org; Wed, 08 Mar 2023 00:29:50 -0500 Received: by mail-wm1-f67.google.com with SMTP id o38-20020a05600c512600b003e8320d1c11so1519399wms.1 for <58813@debbugs.gnu.org>; Tue, 07 Mar 2023 21:29:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1678253383; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=IJS7xJ9BK663PTUcp7SNzZxI+sfkAMZag+pFMWs+zgQ=; b=fi1i2oNaJ8JmDA6TiLVfF20+g+YgOu2txvrgHKw+XFdILtD8rfUI/YHqL/Tsf5ocHg sKjE2dHzeahtG3cWkXFS7XnFKOzy3XhsQC0LoTCl4sy7gRA230kQUjQJbtZ8o8mjzoW7 shYIpiZYMxkz+G7INiRuPYZ0ecgRm/2oh2NP1JKDobDvropLjjpiEg43wpu4dFJNC5XI XFUlJVRKgsCyuz1NAIg85nAdY+3V7Ij3fWpeLvSqCPoOa7/ci9MHzZCfw5diqTpiV2T0 hWpoY1/50v83l4pPenAoQT2P1y/5LjJENw1piMx8fGERbhf6Br12N2u44rqoIdmIIrnT 5VKQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678253383; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=IJS7xJ9BK663PTUcp7SNzZxI+sfkAMZag+pFMWs+zgQ=; b=V35usNPUrTN9wjuMYnBMY0GhSnMbs2OVSE6vvLWOmA7wcKTKdNnpcR1rZEkoz8jFGT UKK34gOOknguSre6Ccv54nlIja6I51klSrtD5F6eCQ0gOiTV6XCqsGCjamXhaW7wGD/Q SDQSDRdjYAA0sSt+Yf+FtVGJdQMaVoXQM/cJD6HQBeOs/ycpQypfKgFWMVDAkuzrCTeC P3gLfSyZv/+OyYeAHePVondUxY5G2yHClFYf115dtRv5ZERIDOyHFbhLrs6EhqYsOnOz gecwFmZBW0PgNT2FScTRqMssBUw48t3oE2Y8kuhcGb4HqkI+84dic7sVdRX/b/2Xna9S ygfQ== X-Gm-Message-State: AO0yUKXtXQcqTJf0t1lsbHI6P4CXoRlH5ODyB4mlXcWTi+glRUHZUrmV l+ElmnVkjrPM4Gz6Y3Lam7Y= X-Google-Smtp-Source: AK7set8t2VlyyLLNb701YInVfnUCJocblhoVgbEwloNi5FHOEBO4fYa+l3KfzNmh17xD9/b78nakAA== X-Received: by 2002:a05:600c:3153:b0:3ea:f73e:9d8c with SMTP id h19-20020a05600c315300b003eaf73e9d8cmr15249307wmo.16.1678253383490; Tue, 07 Mar 2023 21:29:43 -0800 (PST) Received: from lumine.fritz.box (85-127-52-93.dsl.dynamic.surfer.at. [85.127.52.93]) by smtp.gmail.com with ESMTPSA id l8-20020a05600c4f0800b003b47b80cec3sm20888627wmq.42.2023.03.07.21.29.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Mar 2023 21:29:42 -0800 (PST) Message-ID: Subject: Re: bug#58813: [PATCH v2] doc: Document how to use Patman for patches submission. From: Liliana Marie Prikler To: Simon Tournier , Maxim Cournoyer Date: Wed, 08 Mar 2023 06:29:41 +0100 In-Reply-To: <86sfega2bv.fsf@gmail.com> References: <20230307113524.901320-1-zimon.toutoune@gmail.com> <877cvsy0eu.fsf@gmail.com> <86sfega2bv.fsf@gmail.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.0 MIME-Version: 1.0 X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 58813 Cc: ludo@gnu.org, 58813@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi, Am Dienstag, dem 07.03.2023 um 18:39 +0100 schrieb Simon Tournier: > I still think this documentation for configuring =E2=80=99patman=E2=80=99= about > =E2=80=9CPatch management=E2=80=9D is helpful.=C2=A0 I think it could be = part of the > manual.=C2=A0 If not for reasons I am missing, at least this documentatio= n > should be included in the Cookbook. There are two discussions here: 1. Should we "mandate" the use of patman? 2. Should we describe how to use patman for submitting patches to Guix? I think most agree with the latter, but disagree with the former.=20 Thus, whatever steps you add for the use with patman must be easily enough replicated by people not using it, or else we risk low adoption of best practices. > And from my point of view, if we say that [1,2] fits the manual, then > this dedicated section about =E2=80=9CPatch management=E2=80=9D also fits= the manual. > If this dedicated section about =E2=80=9CPatch management=E2=80=9D also d= oes not fit > the manual, then [1,2] neither. :-) >=20 > 1: > 2: > I think [2] is distinct here in that it discusses Guix-specific quirks when using TeX. Cheers From debbugs-submit-bounces@debbugs.gnu.org Wed Mar 08 04:22:13 2023 Received: (at 58813) by debbugs.gnu.org; 8 Mar 2023 09:22:13 +0000 Received: from localhost ([127.0.0.1]:47800 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pZpzw-00036W-TZ for submit@debbugs.gnu.org; Wed, 08 Mar 2023 04:22:13 -0500 Received: from mail-wr1-f44.google.com ([209.85.221.44]:34503) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pZpzu-00036I-U5 for 58813@debbugs.gnu.org; Wed, 08 Mar 2023 04:22:11 -0500 Received: by mail-wr1-f44.google.com with SMTP id r18so14678685wrx.1 for <58813@debbugs.gnu.org>; Wed, 08 Mar 2023 01:22:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1678267325; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=tldhxCOjVrwpOcmdqiHLwcXNvjKw7HfWPQh1oWBZU0g=; b=oEs8p08gWkePtTeBThrfX0g8q1o3s6JGz9y3+TOjHF6i3bDwFIplLzQoJPvcIWwMO5 gnMIdbUe+e+GtgJYcQE0poRp61BgIkyUlsXmyQ4E3NylQZe9O4csGwzgdZoSHL6uHHq9 YptIxT7itw8n01NalCeOCaciNXSOvR/hQL0Exr1I2VytQ7m3kWohDSZpkvJRz5v02gPY SjRttzCo1OGjXzZ80jH84cn4K+39xDXr/4CP3BUCHt2YCk+yAiVrZJzrnko5/fSU6+ZS vLWXaM19mbNf0mH6mLGWMgyEfa9Lu9/2Lu3V+cMDryJINRgZKK6Fiw1ie23rxDG3SVeV 5Wgg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678267325; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=tldhxCOjVrwpOcmdqiHLwcXNvjKw7HfWPQh1oWBZU0g=; b=Cz1XojakVY9+wSsVG+oboDy6cCG4YTdFU5ENLBe/fbws1ZY0SsJaRvE+ambUw2HRYO vtxGdU+sRJ9mHnKZuReRO1b0OlBxkMpoXeEkoK5Ou3cbS6Kl/jlRALvJ6pJpIlarMFzW 8p+0p4wFlm764EuRKrxTQVl5XmJdRTMWUNqXyzTXz/tuZF9gv+kmdaBJVJOHrLXB6k83 XgZ/jhrpyZJn00LLHakroy652VvktkGb0T904VALA7qRrxk/y2g6occFJgxRCb/ejhlt kJ6kZVzURjZJx4/XlRoxTkOUj7YO9JB+dR/CGySJe3C5Rx0GrnvlHh38+WGejh9IOebY GnjA== X-Gm-Message-State: AO0yUKVHWhTQYuLe4cBmy5ZcFrj5ts7CyLfuMkbdLok6Jpn96diAkZFM I46j4JDDVZVEkTCcgGcfqLUp+Yjt/nE= X-Google-Smtp-Source: AK7set8v7PhvLs+WumxqDPPnOx/iqTd6ZFw01Xa6T7guWaFyxsolpfxYZYuuBT2IDa1EAmUm0r9dMw== X-Received: by 2002:adf:f80a:0:b0:2c7:1210:fe61 with SMTP id s10-20020adff80a000000b002c71210fe61mr8878323wrp.3.1678267324886; Wed, 08 Mar 2023 01:22:04 -0800 (PST) Received: from lili ([2a01:e0a:59b:9120:65d2:2476:f637:db1e]) by smtp.gmail.com with ESMTPSA id b3-20020a5d40c3000000b002ce37d2464csm10931396wrq.83.2023.03.08.01.22.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Mar 2023 01:22:04 -0800 (PST) From: Simon Tournier To: Liliana Marie Prikler , Maxim Cournoyer Subject: Re: bug#58813: [PATCH v2] doc: Document how to use Patman for patches submission. In-Reply-To: References: <20230307113524.901320-1-zimon.toutoune@gmail.com> <877cvsy0eu.fsf@gmail.com> <86sfega2bv.fsf@gmail.com> Date: Wed, 08 Mar 2023 09:47:01 +0100 Message-ID: <865ybbaauy.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 58813 Cc: ludo@gnu.org, 58813@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Liliana, On Wed, 08 Mar 2023 at 06:29, Liliana Marie Prikler wrote: > Am Dienstag, dem 07.03.2023 um 18:39 +0100 schrieb Simon Tournier: >> I still think this documentation for configuring =E2=80=99patman=E2=80= =99 about >> =E2=80=9CPatch management=E2=80=9D is helpful.=C2=A0 I think it could be= part of the >> manual.=C2=A0 If not for reasons I am missing, at least this documentati= on >> should be included in the Cookbook. > > There are two discussions here: > > 1. Should we "mandate" the use of patman? > 2. Should we describe how to use patman for submitting patches to Guix? > > I think most agree with the latter, but disagree with the former.=20 > Thus, whatever steps you add for the use with patman must be easily > enough replicated by people not using it, or else we risk low adoption > of best practices. Well, I am not sure to understand =E2=80=9Cmandate=E2=80=9D. There is many= tools that appears in the Guix manual that are not =E2=80=9Cmandatory=E2=80=9D but just recommendations. For instance, Emacs, emacs-geiser, emacs-debbugs, etc. And even Git is not mandatory, maybe some people prefer Dulwich (pure-Python implementation) or maybe others use =E2=80=99gix=E2=80=99 (pur= e-Rust implementation). It would be fun to deal with Guix patches using gix. ;-) So, I read =E2=80=9Cmandate=E2=80=9D as recommend, hoping that I am not mis= sing the meaning you put behind the quoted mandate. :-) About #1, I understand and I agree that the manual cannot recommend all the tools on Earth and we have to make choices in order to keep it clear, especially when newcomers is facing in the front of how to deal with patches. That=E2=80=99s why I also proposed to move this dedicated section about =E2= =80=9CPatch management using patman=E2=80=9D to the cookbook. :-) It somehow answers #= 1 and the item #2 is almost done. Well, I do not have a strong opinion. On a side note, because I am lazy, if there is no pre-configuration that I can adapt, I will not try patman. Cheers, simon From debbugs-submit-bounces@debbugs.gnu.org Wed Mar 08 11:26:49 2023 Received: (at 58813) by debbugs.gnu.org; 8 Mar 2023 16:26:49 +0000 Received: from localhost ([127.0.0.1]:50035 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pZwcr-0000i3-FQ for submit@debbugs.gnu.org; Wed, 08 Mar 2023 11:26:49 -0500 Received: from mail-qv1-f54.google.com ([209.85.219.54]:37801) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pZwcp-0000hq-KK for 58813@debbugs.gnu.org; Wed, 08 Mar 2023 11:26:47 -0500 Received: by mail-qv1-f54.google.com with SMTP id y3so11439198qvn.4 for <58813@debbugs.gnu.org>; Wed, 08 Mar 2023 08:26:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1678292802; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to; bh=VL8iHeiGDqMbKc6ehDaRN2oJoymSHHvsLZIeJD+aabI=; b=CA7mcdfQwZnHepAu6A8kSlq4B90Khg1uVYoN2uxUtbMs/0Gahkc+GDqfnFbAWRLCMt h+Z6juV33wM2WZkP+5fqa71uxpDgkIH9mwD9485pg24UBfgbw90DPcOb0jgntamQMo1J iwW1AAIzzWMoDVlhWsP9IqbHHQMtntq5XRFGMe/I0FoadYf7RdfsJbz+5AC5eQuLpTYi yKbznfYvYHGYtUplGUy1cYS5jlIMASlPyMvmE/jkQDI1rNiz5t6hek0eNmpWSJfE7Zz4 SZEqSsmmBZpm0+rQDoYP2JzGjkWmoTqsaeK76sJz3Vvjz824qyD/TMby8K5rKx6fVLhQ 3I7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678292802; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=VL8iHeiGDqMbKc6ehDaRN2oJoymSHHvsLZIeJD+aabI=; b=783CTQQy/W2k7jXKwI8qu08jplQFnDvId2FDAh9PR+cAfWVsFMBfiOhRh+J36CskRy 3TjVH5H1j5vEH7zvpDFWe/fXZBq6guqWKILqGA6Q3ji8Ln6qHl/RABEyrU4+GKwuskOW mfLNwOKkZeFqpzWLa8pwiwOhm9ESedgWcjG1iV9isPZLb0QZ05e7Z3vhuAy8TpAeSkxl 3iSclGvY8AeWnJ4acPrI4wamo/oK9rRCwdZBMztIHs91LgGCbqqQgSgmrf+a8h5rWohj VWs2LDHV7WkWakIuZN6AavKx8B9EZ2wzd6ltO9eHlkmvHNnOgQvAhApeU02tNSG2XrDY AY2g== X-Gm-Message-State: AO0yUKV7IbETkwco8CAYj1st2JfxdkMGyOWPnWbVw9PgKO2s0hDm0wW8 ZfOPnC2I+26N8oCIxaNCia5RJS48ZxjHRQ== X-Google-Smtp-Source: AK7set+5cEXNqv2rh5mWNMglBohY3scbyD4ZbmjMyzVYcKOVnDqIyi2wN7J9M1xRpjX33pouTMUlEQ== X-Received: by 2002:ad4:5cc9:0:b0:56e:a6c6:445c with SMTP id iu9-20020ad45cc9000000b0056ea6c6445cmr35883561qvb.43.1678292801835; Wed, 08 Mar 2023 08:26:41 -0800 (PST) Received: from hurd ([2607:fad8:4:3::1000]) by smtp.gmail.com with ESMTPSA id d79-20020ae9ef52000000b007296805f607sm11759740qkg.17.2023.03.08.08.26.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Mar 2023 08:26:41 -0800 (PST) From: Maxim Cournoyer To: Simon Tournier Subject: Re: bug#58813: [PATCH v2] doc: Document how to use Patman for patches submission. References: <20230307113524.901320-1-zimon.toutoune@gmail.com> <877cvsy0eu.fsf@gmail.com> <86sfega2bv.fsf@gmail.com> <865ybbaauy.fsf@gmail.com> Date: Wed, 08 Mar 2023 11:26:39 -0500 In-Reply-To: <865ybbaauy.fsf@gmail.com> (Simon Tournier's message of "Wed, 08 Mar 2023 09:47:01 +0100") Message-ID: <87jzzrus3k.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 58813 Cc: ludo@gnu.org, Liliana Marie Prikler , 58813@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Simon, Simon Tournier writes: > Hi Liliana, > > On Wed, 08 Mar 2023 at 06:29, Liliana Marie Prikler wrote: >> Am Dienstag, dem 07.03.2023 um 18:39 +0100 schrieb Simon Tournier: > >>> I still think this documentation for configuring =E2=80=99patman=E2=80= =99 about >>> =E2=80=9CPatch management=E2=80=9D is helpful.=C2=A0 I think it could b= e part of the >>> manual.=C2=A0 If not for reasons I am missing, at least this documentat= ion >>> should be included in the Cookbook. >> >> There are two discussions here: >> >> 1. Should we "mandate" the use of patman? I don't think this was ever in the discussion. The patch series I sent only hinted at a tool that can provide some further automation. It's not mandated (as in, required) at all. git send-email works just fine when manually pasting the output of 'etc/teams.scm cc-members the.patch', and will continue to even if we mention the tool 'patman' in conjunction. [...] > Well, I do not have a strong opinion. On a side note, because I am > lazy, if there is no pre-configuration that I can adapt, I will not try > patman. It's already there; see the .patman file at the root of the repo. There's really not much to patman, it's a simple tool that does what it does well (and already exists). --=20 Thanks, Maxim From debbugs-submit-bounces@debbugs.gnu.org Wed Mar 08 12:05:39 2023 Received: (at 58813) by debbugs.gnu.org; 8 Mar 2023 17:05:39 +0000 Received: from localhost ([127.0.0.1]:50094 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pZxEQ-0001qA-Uw for submit@debbugs.gnu.org; Wed, 08 Mar 2023 12:05:39 -0500 Received: from mail-lf1-f53.google.com ([209.85.167.53]:41697) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pZxEO-0001ph-VP for 58813@debbugs.gnu.org; Wed, 08 Mar 2023 12:05:37 -0500 Received: by mail-lf1-f53.google.com with SMTP id d36so19056888lfv.8 for <58813@debbugs.gnu.org>; Wed, 08 Mar 2023 09:05:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1678295131; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=utTDp+6nRLzNOOhZ9qdCHSQeeB/8uvXt6hm7dAP2xR0=; b=PC2Hpd3VL3yYoandxK3lT88xL36zThaT81iKkDnyl1gf8WJ+nQSdCeV71gwvUInM0t attltAQ/MMvVNktasdFyJqBzK3zoiMODiBAVfD+rPLSgRGcQ3hKcRr8uJN59oABTzSSE Mp8+3iyJsxXlQh1s90aSRAxXP2Lye72K7HnAtkEvAaoG3f+kb0amKTNFNL/H805uTNzq SCNyzvp90te/k7RUNKC7nYStCjEja9dR0IB5JuKDdYyCFevH+m6GC8Jz9ObwtU53C1Bf 623kXPVrycgA7guDkcpw6gWyNt08orLzgfcnmuifcktFs4EJ4LMYeQveLmsQrIWKjUJz jGag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678295131; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=utTDp+6nRLzNOOhZ9qdCHSQeeB/8uvXt6hm7dAP2xR0=; b=lr4B2A+digAeRnVlxS1ffXJRSKAW8esD67iOPErOzowDpQfesUqKPAe60TgNsIEPIs RpB9yvhvT6felNnkHotCxOCeC1GgjoqSfLHGU+3OAIwC3mxOq2aWRG1eb9rZrPZpPWAQ Xrmb6ND3GCnK7zxUZyQQWBbLj/2qVzFJFPwa7WIEjT1GUT5JfsxO0wbf8335cCuVNXU6 hj3cKAfzTMIMuEB428/JyOYvcd02WP7KOoCk4CGPF6A7MvmmUcXEPpNY58S7+FqbcIvi aOvzUTSviyxYQe0+LbbFmXX0uVR0W4S4M6LCHCycoT0VJHFt5q0wWdrj+JNDrIg20yer tL3A== X-Gm-Message-State: AO0yUKW3tv2PpbsnIW0dzHZWN4huXOiB2Lwqmo9CFr59D4kfV+1lES+W qitMYXYLFvsHV6UVt9klSr5BT8swYbU7tfJ7oxM= X-Google-Smtp-Source: AK7set8q6vB84NEmlUqd6PTf/bG9+YfZq1LY8W5kFar0CUCILAlGdsuWAJThrWY9o5n2KLmitVfLD+wGL5ib0eYDG4E= X-Received: by 2002:ac2:4a88:0:b0:4e8:f7f:c8f8 with SMTP id l8-20020ac24a88000000b004e80f7fc8f8mr2847961lfp.2.1678295130814; Wed, 08 Mar 2023 09:05:30 -0800 (PST) MIME-Version: 1.0 References: <20230307113524.901320-1-zimon.toutoune@gmail.com> <877cvsy0eu.fsf@gmail.com> <86sfega2bv.fsf@gmail.com> <865ybbaauy.fsf@gmail.com> <87jzzrus3k.fsf@gmail.com> In-Reply-To: <87jzzrus3k.fsf@gmail.com> From: Simon Tournier Date: Wed, 8 Mar 2023 18:05:18 +0100 Message-ID: Subject: Re: bug#58813: [PATCH v2] doc: Document how to use Patman for patches submission. To: Maxim Cournoyer Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 58813 Cc: ludo@gnu.org, Liliana Marie Prikler , 58813@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Maxim, On Wed, 8 Mar 2023 at 17:26, Maxim Cournoyer wrote: > > Well, I do not have a strong opinion. On a side note, because I am > > lazy, if there is no pre-configuration that I can adapt, I will not try > > patman. > > It's already there; see the .patman file at the root of the repo. > There's really not much to patman, it's a simple tool that does what it > does well (and already exists). Yeah not much, still (1) someone needs to be aware of this not much and (2) I find a value with the (not much) example of usage. Anyway. I understand if there is no consensus for the manual, so if you do not bother, I will adapt the patch for the Cookbook. Cheers, simon From debbugs-submit-bounces@debbugs.gnu.org Fri Mar 10 04:01:19 2023 Received: (at 58813) by debbugs.gnu.org; 10 Mar 2023 09:01:19 +0000 Received: from localhost ([127.0.0.1]:53677 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1paYco-0008Ig-O9 for submit@debbugs.gnu.org; Fri, 10 Mar 2023 04:01:19 -0500 Received: from eggs.gnu.org ([209.51.188.92]:46384) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1paYcn-0008IT-76 for 58813@debbugs.gnu.org; Fri, 10 Mar 2023 04:01:17 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1paYch-0000Sp-UD; Fri, 10 Mar 2023 04:01:11 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=faOViiYr0YZOHfdKmmzBTBpB0i3Gh8NwemwwalWQqr8=; b=FUgkd80CNmsADHCzBrCt 6ZQkttXmEZjlOPMV8v6DEJsNJx20u0mKgvpvYjgSkwF0MwMcuk5df/LDT/3lct7iOOVwUKhy8Si0e F2irUd/AlbSBETL4OraHKAnpEwM832S1k0+HM0oJ7TT8TzzEuf1fXxbzy3Oh3zISL26du9SHjlZ3A 3OuUZ+fXvBbdUTk+AL7ujfTWINBclJbgMKV6e5/uFHlWns6ZaSGri49wi4cY1fRF0OAFmMgJonlZk H4IDMkNxvcn17mpcH3d9M+JaCkg5J9JFEb8xvs4Hbarq4O3e0fEZsdmwrxqpQHJkPJoTaOR8M8OUm fH5ZZCFOqUCzEA==; Received: from [193.50.110.253] (helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1paYch-0006xB-Cc; Fri, 10 Mar 2023 04:01:11 -0500 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Maxim Cournoyer Subject: Re: [PATCH] doc: Document how to use Patman for patches submission. References: <20230226035515.16214-1-maxim.cournoyer@gmail.com> <87y1oeyxbt.fsf@gnu.org> <87fsahz7wk.fsf@gmail.com> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: =?utf-8?Q?D=C3=A9cadi?= 20 =?utf-8?Q?Vent=C3=B4se?= an 231 de la =?utf-8?Q?R=C3=A9volution=2C?= jour du Cordeau X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Fri, 10 Mar 2023 10:01:09 +0100 In-Reply-To: <87fsahz7wk.fsf@gmail.com> (Maxim Cournoyer's message of "Mon, 06 Mar 2023 20:07:07 -0500") Message-ID: <87jzzp9e0a.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 58813 Cc: liliana.prikler@gmail.com, 58813@debbugs.gnu.org, zimon.toutoune@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi, Maxim Cournoyer skribis: > I've also discovered about '--cc-cmd', which could be used with the > recently introduced get-maintainer mode (which was added for patman > support); it can be used like this: > > git send-email --cc-cmd=3D'etc/teams.scm get-maintainer' --dry-run -1 Nice! But yeah, would be nicer if it could use X-Debbugs-Cc. Perhaps we can still change the manual to recommend that followed by =E2=80=9Csed -i *.patch -es/^Cc/X-Debbugs-Cc/=E2=80=9D? Very low-tech but better than the status quo. WDYT? > For this reason, I'm toying with the idea of contributing a "--x-cmd" > option to git send-email, which would be a script that outputs arbitrary > git send-email options to add to its command line. That=E2=80=99d be perfect! Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Fri Mar 10 09:07:57 2023 Received: (at 58813) by debbugs.gnu.org; 10 Mar 2023 14:07:57 +0000 Received: from localhost ([127.0.0.1]:54119 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1padPZ-0002lA-7s for submit@debbugs.gnu.org; Fri, 10 Mar 2023 09:07:57 -0500 Received: from mail-yb1-f170.google.com ([209.85.219.170]:37666) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1padPX-0002kw-Oi for 58813@debbugs.gnu.org; Fri, 10 Mar 2023 09:07:56 -0500 Received: by mail-yb1-f170.google.com with SMTP id k199so5374615ybf.4 for <58813@debbugs.gnu.org>; Fri, 10 Mar 2023 06:07:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1678457270; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to; bh=GThHM5I4tWeFqlrMHFcZo58F6L7VwPOmqjsI/ban5+0=; b=KKsiTCLRcfof1AlR16aCmoMDzS1QPUcxqzIjSu2ULVmxhLsT1L43ZbpETXcX9P7Bdc FCa9uCpQbTUp1w9R8q4l024qAjCYzILCMX4d5z/n50NyoSuO8FyVVLeLqeGjtpZylLNi SJj7E9Nz4qTM2b+kSBKEb8jVb/utb5c1+WRI6mABrEtA8VIvLyWMkMksipnyMiFZRli3 TVxQtb+kCFGeQIFpDENl8MMckn/fi7FCyv6hxyy3jDHl6rzNktMncSsnV5Lrd1Vv+wSi z2PwA+jqNvFqwRezDWcQzsVvk/yHhfqa2aH98AHxUurjOmvW2mzvjFGs6GYhlhsJH82d 3Z3w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678457270; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=GThHM5I4tWeFqlrMHFcZo58F6L7VwPOmqjsI/ban5+0=; b=7fk3n++3TTxN8FCTecJDYj5qbeFIdOdubkc9acAdG+rcQ2mSC1rKFkyvPSI/smsoro WobX+9gm2b4+zZJvt3ayBV2X5UsZkuY6fMZ3fMs25bqIa4soagmh86/kPfuB2n168Gxc 9iEN1WbBeuvZPXwR3cGVxOtxL6KczBmR6M1WDQE9Su4MMGaUYNmHaQj/LSH9YLzIYCk1 VqnOsZabwDXPGHA+wJ0np8O0j0fcHBZSCCB8pxe56zi7DhKk5wLMf06fdbx+nSHpA6jK bFzTeTyeC4UGbAnG5zX9/d+2fARSJZyg+n1qNe3ccHKlFi2ViMLRiuMiAe/O3L3zpcfv n3XA== X-Gm-Message-State: AO0yUKUpimhyc7YHP+2VxRyAWPWfwtC6IGfwvxMjJk5Ondc2g8j+sujM gBfeQtE1OAF05Kim7fWbLuA= X-Google-Smtp-Source: AK7set9hpNl8fH66rCAR2nc9tfAMM+ULR8eE2pkiqS5kRd8o0CTOmawqJLod9R2xj9Zyka0MsMSb7w== X-Received: by 2002:a05:6902:d2:b0:b2e:efb2:b4c4 with SMTP id i18-20020a05690200d200b00b2eefb2b4c4mr2389298ybs.3.1678457269967; Fri, 10 Mar 2023 06:07:49 -0800 (PST) Received: from hurd ([2607:fad8:4:3::1000]) by smtp.gmail.com with ESMTPSA id m17-20020ae9e011000000b007422fa6376bsm1353960qkk.77.2023.03.10.06.07.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Mar 2023 06:07:49 -0800 (PST) From: Maxim Cournoyer To: Ludovic =?utf-8?Q?Court=C3=A8s?= Subject: Re: [PATCH] doc: Document how to use Patman for patches submission. References: <20230226035515.16214-1-maxim.cournoyer@gmail.com> <87y1oeyxbt.fsf@gnu.org> <87fsahz7wk.fsf@gmail.com> <87jzzp9e0a.fsf@gnu.org> Date: Fri, 10 Mar 2023 09:07:48 -0500 In-Reply-To: <87jzzp9e0a.fsf@gnu.org> ("Ludovic =?utf-8?Q?Court=C3=A8s=22'?= =?utf-8?Q?s?= message of "Fri, 10 Mar 2023 10:01:09 +0100") Message-ID: <878rg4snrf.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 58813 Cc: liliana.prikler@gmail.com, 58813@debbugs.gnu.org, zimon.toutoune@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Ludo, Ludovic Court=C3=A8s writes: > Hi, > > Maxim Cournoyer skribis: > >> I've also discovered about '--cc-cmd', which could be used with the >> recently introduced get-maintainer mode (which was added for patman >> support); it can be used like this: >> >> git send-email --cc-cmd=3D'etc/teams.scm get-maintainer' --dry-run -1 > > Nice! But yeah, would be nicer if it could use X-Debbugs-Cc. > > Perhaps we can still change the manual to recommend that followed by > =E2=80=9Csed -i *.patch -es/^Cc/X-Debbugs-Cc/=E2=80=9D? > > Very low-tech but better than the status quo. WDYT? > >> For this reason, I'm toying with the idea of contributing a "--x-cmd" >> option to git send-email, which would be a script that outputs arbitrary >> git send-email options to add to its command line. > > That=E2=80=99d be perfect! Good, I haven't gotten any feedback from the #git folks, so I guess I'll forge ahead and see what comments they have about the implementation. It might be some time before I can hack on this. To be continued! --=20 Thanks, Maxim From debbugs-submit-bounces@debbugs.gnu.org Sun Apr 23 12:04:32 2023 Received: (at 58813) by debbugs.gnu.org; 23 Apr 2023 16:04:32 +0000 Received: from localhost ([127.0.0.1]:46806 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pqcCW-0004g5-4S for submit@debbugs.gnu.org; Sun, 23 Apr 2023 12:04:32 -0400 Received: from mail-qk1-f169.google.com ([209.85.222.169]:51573) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pqcCR-0004ff-4C for 58813@debbugs.gnu.org; Sun, 23 Apr 2023 12:04:30 -0400 Received: by mail-qk1-f169.google.com with SMTP id af79cd13be357-74de7635180so383358985a.3 for <58813@debbugs.gnu.org>; Sun, 23 Apr 2023 09:04:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1682265861; x=1684857861; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=XNWpOAh8YdWGrkIoRJf04zxkhAsM//GwqkR2ASbWtWk=; b=eVw08/LNTayntNMDbODpS4csOOt/j8vWZiEQyLCNiyRxx352cs2WSicVxI6FLP1T8I fHQQzKOSXh/jLFyCZUtXls6idkAnLdsI7gt2QRD/vs/ttBCrlU626r7WVo8j1pyvkR/x YhWogbkJKFjI4jggSYXiYBsTsewThMSpqP3+M1P89Zl33/SsqdkOwpB5Tg93whNRuLLq bfn3LuwRmcNDpm6X+9K55wVVsOh/iAgOiVl0CVB+oWCnflhYt3JQzHkZclbogHnev4Df 0YcFyeYzarLNJoFL5AcIRWtDZBBJc9OJlLQsQkr9DCH2F3snK8o2KrRp25kQBhreX4vb wv6w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682265861; x=1684857861; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=XNWpOAh8YdWGrkIoRJf04zxkhAsM//GwqkR2ASbWtWk=; b=h7CR0VI9mJvdmDKGC3ZqfJicBAT6RU97wIwJW+TbmjmxltSDi3FzuKoyz8BHJQx4Y9 /R773EKTq8+ucDhDtUfah2I0Md0KhgF20FmEkSEGoJ4wQrdzmbmVmErEv+1m+eO3Bp9J PW6xQzgVndzB/Yc/ezy5bmValRjNu4PjVEv/A5Y1ka1hcuhzuByZQH9Zx7BAQsY+U02w RswnyHSsUibGj4nu0umWC/8XztmTgu+m1JeM+uY7ZFAfI/5dh3iopLDgBsHqI40Inzdd 0+LmJkEl27hH26rq0GYIGSjWpgjZoPSHdwRAI2R8JlGedquI2TkJmaE78rmedL0FsTYn Sa2g== X-Gm-Message-State: AAQBX9dmDIM32FIgGEMHIBrvMm70AzJPEJG8qGmfa06Vj6IawaM7d8p7 6TM4FHURl8dRIUKUgB/kTRiwrIa62kBsFg== X-Google-Smtp-Source: AKy350ag9AWU5l+vPIqRJW63VWyGcs9vEHtbvuQBX3tmFX0bt01UcVimZecfLRLt5pyhO5W2TPKzlQ== X-Received: by 2002:ac8:7f05:0:b0:3ef:3fcd:3c1c with SMTP id f5-20020ac87f05000000b003ef3fcd3c1cmr16968525qtk.63.1682265861005; Sun, 23 Apr 2023 09:04:21 -0700 (PDT) Received: from localhost.localdomain (dsl-141-20.b2b2c.ca. [66.158.141.20]) by smtp.gmail.com with ESMTPSA id d13-20020a05622a15cd00b003ef48392649sm2957469qty.4.2023.04.23.09.04.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 23 Apr 2023 09:04:20 -0700 (PDT) From: Maxim Cournoyer To: 58813@debbugs.gnu.org Subject: [PATCH 0/5] Fix teams.scm by use of a new --header-cmd git send-email option. Date: Sun, 23 Apr 2023 12:04:10 -0400 Message-Id: X-Mailer: git-send-email 2.39.2 In-Reply-To: <878rg4snrf.fsf@gmail.com> References: <878rg4snrf.fsf@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 58813 Cc: ludo@gnu.org, liliana.prikler@gmail.com, Maxim Cournoyer , zimon.toutoune@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hello, This adds a brand new '--header-cmd' option, to git send-email, which can then be used to fix the issues reported against teams.scm in https://issues.guix.gnu.org/58813. The configuration of Git is also automated, which should make everyone's life easier (and helps keeping the doc focused). Thanks, Maxim Cournoyer (5): gnu: git: Apply patch adding the --header-cmd feature. teams: Add 'cc-members-header-cmd' action. teams: Add a configure-git action. teams: Add a 'cc-mentors-header-cmd' action. doc: Simplify contributing section by automating git configuration. doc/contributing.texi | 102 +++++------- doc/guix.texi | 2 +- etc/git/gitconfig | 15 ++ etc/teams.scm.in | 39 ++++- gnu/local.mk | 1 + gnu/packages/patches/git-header-cmd.patch | 180 ++++++++++++++++++++++ gnu/packages/version-control.scm | 3 +- 7 files changed, 267 insertions(+), 75 deletions(-) create mode 100644 gnu/packages/patches/git-header-cmd.patch base-commit: 5b545763ed9b8a3fade7f756d543819fc090953f -- 2.39.2 From debbugs-submit-bounces@debbugs.gnu.org Sun Apr 23 12:04:35 2023 Received: (at 58813) by debbugs.gnu.org; 23 Apr 2023 16:04:36 +0000 Received: from localhost ([127.0.0.1]:46811 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pqcCZ-0004gQ-GV for submit@debbugs.gnu.org; Sun, 23 Apr 2023 12:04:35 -0400 Received: from mail-qt1-f181.google.com ([209.85.160.181]:61707) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pqcCW-0004fp-Kx for 58813@debbugs.gnu.org; Sun, 23 Apr 2023 12:04:33 -0400 Received: by mail-qt1-f181.google.com with SMTP id d75a77b69052e-3ef657f5702so15238961cf.3 for <58813@debbugs.gnu.org>; Sun, 23 Apr 2023 09:04:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1682265867; x=1684857867; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=cIhYiIUaQDph7ac25C7KgmtaG8U7VaxgDQchW0D5RXE=; b=oGVZ2/DO40otP+Cz7ecHht/mOW+4xy3r2V357XEY2qEwePChscuUJWeld/aSeZJ4tv LCPA9RFowq5S10C/QSS6eOednnEb3OrVCkdlXVLOwy0VmmGqYYtbYiZnn7v9rYASmjQI 33WAVRlF2inGhJC+arlmaSiBUpZV55i/ZONvHVzyCPsAcdMRPaJ5+ji/RzKGAJ/o/74N H1BKiiFPVhaxV1UaTr3Nay5ZjU43F0lxkn/nmAaN8QH/NFHpSfgw+ghBKwIuTq7KuDfM rLru4AT4kghSirZX0HzOZsg0DtJ7Vlp/eDVjosV8dH/Mpw8MI27uH8cb+zkGaB46dVV8 HiWw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682265867; x=1684857867; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=cIhYiIUaQDph7ac25C7KgmtaG8U7VaxgDQchW0D5RXE=; b=I+ipvZruZp+PnCC/L7bJNvVM3ecNKXTp24nUq7Rx7hRFfVA2e1eZAAaqGkqhrsh8cX Jsb4nhu6g4dGOO0elqGEP3vDrBxL55sTfvlKyPitMSgrJWnso4K8z3DlLMBscWwg+8ta IlTgn+Otj/z1cdHAzuywnvdGkXOCuOdu2yx+SuLWPcZzBmVhwTa2xFlEEWAc9OYKQTpV hd71c+cvooxlSGCP6vcs0BPbqy0mqgkLUg1fGdo9bGa1ozRLV6P+FChOvJQh2SKyzH99 F6QEIudSti9n/AXQR42pHP8CQ1FDNzEF+qiu3oAJQ0fNKTuk10jGWiEP6nnjF0ORGwhA MmZw== X-Gm-Message-State: AAQBX9dA1yDhQXGz2ioSccgDFE+/2NLWuN3CP6WrEvYLBn8kB1R/GkS5 OSWVkygh1wFOPlYTnvYAMqOc/1ey/yewQw== X-Google-Smtp-Source: AKy350aReC9DUriTIefvR4W8U1DT1ofGKSCsK7vcnEh8dj/ywrmGq6p6FmdNVZnRYeeMLAvcp4yPNw== X-Received: by 2002:a05:622a:184:b0:3ef:4a6c:f9d2 with SMTP id s4-20020a05622a018400b003ef4a6cf9d2mr18545831qtw.60.1682265866981; Sun, 23 Apr 2023 09:04:26 -0700 (PDT) Received: from localhost.localdomain (dsl-141-20.b2b2c.ca. [66.158.141.20]) by smtp.gmail.com with ESMTPSA id d13-20020a05622a15cd00b003ef48392649sm2957469qty.4.2023.04.23.09.04.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 23 Apr 2023 09:04:26 -0700 (PDT) From: Maxim Cournoyer To: 58813@debbugs.gnu.org Subject: [PATCH 2/5] teams: Add 'cc-members-header-cmd' action. Date: Sun, 23 Apr 2023 12:04:12 -0400 Message-Id: <2c8e1e7fe43d6460f3cc4c2b77d649e109030eb3.1682265703.git.maxim.cournoyer@gmail.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <878rg4snrf.fsf@gmail.com> References: <878rg4snrf.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 58813 Cc: ludo@gnu.org, liliana.prikler@gmail.com, Maxim Cournoyer , zimon.toutoune@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) * etc/teams.scm.in (patch->teams): New procedure. (main): Use it. Add a new "cc-members-header-cmd" command; document it. --- etc/teams.scm.in | 20 +++++++++++++++----- 1 file changed, 15 insertions(+), 5 deletions(-) diff --git a/etc/teams.scm.in b/etc/teams.scm.in index 37a3c8e191..408db8b7d5 100644 --- a/etc/teams.scm.in +++ b/etc/teams.scm.in @@ -5,7 +5,7 @@ ;;; GNU Guix --- Functional package management for GNU ;;; Copyright © 2022, 2023 Ricardo Wurmus ;;; Copyright © 2022 Mathieu Othacehe -;;; Copyright © 2022 Maxim Cournoyer +;;; Copyright © 2022, 2023 Maxim Cournoyer ;;; ;;; This file is part of GNU Guix. ;;; @@ -696,6 +696,12 @@ (define (git-patch->revisions file) (rev-start (string-append rev-end "^"))) (list rev-start rev-end))) +(define (patch->teams patch-file) + "Return the name of the teams in scope for the changes in PATCH-FILE." + (map (compose symbol->string team-id) + (find-team-by-scope (apply diff-revisions + (git-patch->revisions patch-file))))) + (define (main . args) (match args @@ -708,11 +714,13 @@ (define (main . args) (("cc-members" rev-start rev-end) (apply cc (find-team-by-scope (diff-revisions rev-start rev-end)))) + (("cc-members-header-cmd" patch-file) + (for-each (lambda (team-name) + (list-members (find-team team-name) (current-output-port) + "X-Debbugs-Cc: ")) + (patch->teams patch-file))) (("get-maintainer" patch-file) - (apply main "list-members" - (map (compose symbol->string team-id) - (find-team-by-scope (apply diff-revisions - (git-patch->revisions patch-file)))))) + (apply main "list-members" (patch->teams patch-file))) (("list-teams" . args) (list-teams)) (("list-members" . team-names) @@ -729,6 +737,8 @@ (define (main . args) get git send-email flags for cc-ing cc-members | patch cc teams related to files changed between revisions or in a patch file + cc-members-header-cmd + cc-members variant for use with 'git send-email --header-cmd' list-teams list teams and their members list-members -- 2.39.2 From debbugs-submit-bounces@debbugs.gnu.org Sun Apr 23 12:04:36 2023 Received: (at 58813) by debbugs.gnu.org; 23 Apr 2023 16:04:36 +0000 Received: from localhost ([127.0.0.1]:46813 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pqcCZ-0004ga-VK for submit@debbugs.gnu.org; Sun, 23 Apr 2023 12:04:36 -0400 Received: from mail-qk1-f171.google.com ([209.85.222.171]:53504) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pqcCX-0004fs-VJ for 58813@debbugs.gnu.org; Sun, 23 Apr 2023 12:04:34 -0400 Received: by mail-qk1-f171.google.com with SMTP id af79cd13be357-74d0dbd7c58so185958685a.3 for <58813@debbugs.gnu.org>; Sun, 23 Apr 2023 09:04:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1682265868; x=1684857868; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=kJDmkWu3xALL2xacbcHD5XH9gNpO9hwjHiSE5yacL+c=; b=mrStn5G6Q2uY4MEreAaGYc69YS9wwbVzuXVhXBgY5492R8v+4wMhP+GM/OipI7xKPI jWHJb6PYnIrLoeyJ5zBFc2iKeL2WZnvOjhAfOrBJear5RfUfh1lEUdc6nH/IRIMOV9// b0jobNZClPQ5miO2oXHpKHjrND9BAa9xQOaS8lhfSsVd9GPbG5NFFj3N1LAXwj37QHXM utkCecMtzgc1kPY88KSmj9dkAKIYEWMVsbnzAdKkjvYi49QywfajgGkSBjw//pyOxufi y58PMmNlUBxFgJmpnhSZY97Wv3pez6OMihAuthCpaJQWu2CglPUKs2Ru8vWNcdVr3yau 1ODA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682265868; x=1684857868; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=kJDmkWu3xALL2xacbcHD5XH9gNpO9hwjHiSE5yacL+c=; b=NnuN54UkgOqU/rek3kLOF5fNZh16+Efnjzkf5S2cqwnqzzbhsKgvji+qDqL+dik4b0 K+wJoK560gERT8+V4zDCPE35AMsuAUj6ri4uFK0zHR5O1DSV8J8kHVyU/la3ug/O+S1i PZ9cBDhdZy0Z2pVcmTDPolTCW9/jmL79DE23UiXD0YLhM3EFSvRL/UzmEVR/fLGvV8Qd dO2DuhxsNo8zVdVRkamw1wINB/iD647H/XUhBM3TMg0Y+Q60Y9e3FKBYlsjPFNzrnT7W 7HBz+tIaTpWC3nutchKtF+OQw8A1C5p4CB7I6WwaKmJAgjRNQiZo2qmXDk+u+T8Lu+nF wGoA== X-Gm-Message-State: AAQBX9ewEjExNxfzScpgDu3ASl0VWb6o+ESc+KyoI0W0vZfNMR1Kt0m/ Ub7oSYZrbtUxYbr054iF7AiLFpfdtwlo6w== X-Google-Smtp-Source: AKy350YW9SAmL8X3fozbB9LmnWq3tmgq/Tk6v5oBqHA1Uk9lT7OeaStTnfuEKwwP+NESopBLU0i4gA== X-Received: by 2002:a05:622a:606:b0:3ef:2db1:6e67 with SMTP id z6-20020a05622a060600b003ef2db16e67mr15118778qta.17.1682265868169; Sun, 23 Apr 2023 09:04:28 -0700 (PDT) Received: from localhost.localdomain (dsl-141-20.b2b2c.ca. [66.158.141.20]) by smtp.gmail.com with ESMTPSA id d13-20020a05622a15cd00b003ef48392649sm2957469qty.4.2023.04.23.09.04.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 23 Apr 2023 09:04:27 -0700 (PDT) From: Maxim Cournoyer To: 58813@debbugs.gnu.org Subject: [PATCH 3/5] teams: Add a configure-git action. Date: Sun, 23 Apr 2023 12:04:13 -0400 Message-Id: X-Mailer: git-send-email 2.39.2 In-Reply-To: <878rg4snrf.fsf@gmail.com> References: <878rg4snrf.fsf@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 58813 Cc: ludo@gnu.org, liliana.prikler@gmail.com, Maxim Cournoyer , zimon.toutoune@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) * etc/git/gitconfig: Augment configuration template with useful options to allow for auto-configuration. * etc/teams.scm.in (configure-git): New procedure. (main): Register it and add documentation. --- etc/git/gitconfig | 15 +++++++++++++++ etc/teams.scm.in | 12 +++++++++++- 2 files changed, 26 insertions(+), 1 deletion(-) diff --git a/etc/git/gitconfig b/etc/git/gitconfig index c9ebdc8fa8..0b6984a05f 100644 --- a/etc/git/gitconfig +++ b/etc/git/gitconfig @@ -1,5 +1,20 @@ +[commit] + gpgsign = true + [diff "scheme"] xfuncname = "^(\\(define.*)$" [diff "texinfo"] xfuncname = "^@node[[:space:]]+([^,]+).*$" + +[format] + useAutoBase = true + thread = shallow + +[pull] + rebase = true + +[sendemail] + to = guix-patches@gnu.org + headerCmd = etc/teams.scm cc-members-header-cmd + thread = no diff --git a/etc/teams.scm.in b/etc/teams.scm.in index 408db8b7d5..8203446446 100644 --- a/etc/teams.scm.in +++ b/etc/teams.scm.in @@ -36,8 +36,9 @@ (ice-9 regex) (ice-9 match) (ice-9 rdelim) + (git) (guix ui) - (git)) + (guix build utils)) (define-record-type (make-team id name description members scope) @@ -702,6 +703,11 @@ (define (patch->teams patch-file) (find-team-by-scope (apply diff-revisions (git-patch->revisions patch-file))))) +(define (configure-git) + "Automate the required Git configurations for the Guix project." + (invoke "git" "config" "include.path" "../etc/git/gitconfig") + (copy-file "etc/git/pre-push" ".git/hooks/pre-push")) + (define (main . args) (match args @@ -719,6 +725,8 @@ (define (main . args) (list-members (find-team team-name) (current-output-port) "X-Debbugs-Cc: ")) (patch->teams patch-file))) + (("configure-git") + (configure-git)) (("get-maintainer" patch-file) (apply main "list-members" (patch->teams patch-file))) (("list-teams" . args) @@ -739,6 +747,8 @@ (define (main . args) cc teams related to files changed between revisions or in a patch file cc-members-header-cmd cc-members variant for use with 'git send-email --header-cmd' + configure-git + automatically configure your Git checkout for Guix list-teams list teams and their members list-members -- 2.39.2 From debbugs-submit-bounces@debbugs.gnu.org Sun Apr 23 12:04:46 2023 Received: (at 58813) by debbugs.gnu.org; 23 Apr 2023 16:04:46 +0000 Received: from localhost ([127.0.0.1]:46816 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pqcCg-0004h4-FY for submit@debbugs.gnu.org; Sun, 23 Apr 2023 12:04:45 -0400 Received: from mail-qk1-f182.google.com ([209.85.222.182]:62964) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pqcCZ-0004fu-7Q for 58813@debbugs.gnu.org; Sun, 23 Apr 2023 12:04:35 -0400 Received: by mail-qk1-f182.google.com with SMTP id af79cd13be357-74ab718c344so1017810085a.1 for <58813@debbugs.gnu.org>; Sun, 23 Apr 2023 09:04:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1682265869; x=1684857869; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=6j0LccblGpRARDcLpCH9zGXjPuxY/tSlEvFkadEFhvg=; b=pjBmP10jWlrhHDkkr2/O5gqDWzuZI7bST51m9WCJsLC1XxfolbRzx90/IIhU/Jp3Ek XISU/pYWjUKS0ue/Xna1R7AXPpwxksAwOYJqWrGmt4V4EoQFGoWxsNJxtONSKNHpcYCx O+Fi7piw6WxfGBhINKOodawze5kWOOYUnvocRBwnKNNII86CVzs3UFDQ9qaoGJPn2Pxo gYlU3NnxSecwPuXsd5V2ZOmg6zkRw58rce9nZdEeHLIMMIRN/i3Lqvd5FXL1e5ZkKpnm Ex7XBaiNtC9Qj0/9LGVmAdu0rDveIfcOWtivj4Ed6UXuFTANJuTckfN7JvBUpQ4tkBK5 l/Lg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682265869; x=1684857869; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=6j0LccblGpRARDcLpCH9zGXjPuxY/tSlEvFkadEFhvg=; b=HFvFd+JD72iLvkh+r+R2SFSMR7kZmX2IKrSFTqmIlX2SgKyDa+l2fP2FeCdJ9bkQyM N4oGUldk1CDSmtHZP8squjHr/yTJfo9IeVp4jItxEbbx3tVoqrf9I6I38eJJRXaTeFB8 HXUsBBKZSwLlrE5b+aLoPrgn26OqgeR88GCcPZxgX9t/sZ6r0MCleevfU80WFRGtDiqQ dSTnachkixRaW1Y/mZucXuU1iPeNmSc7REuETz1SHKK3+gteMGCkAR7f7KpLheS9WRgp U3huiu5GtfrcA4kIe/jk5uITn8+8FILEv+FyVu7vmJWvjeDHJ1rZQlGwnfVpQQ56QaGP hwdQ== X-Gm-Message-State: AAQBX9eREI2a8Ok7pfbEbWfU5cDSTYSyOvUHTU3+DnXaefmix+cm1Jky iS5ck30PTZQd2/2PfMJ8AonQ/2/5KwyATw== X-Google-Smtp-Source: AKy350bzxIcRyNkEwIfogmIvSJWJIYCGPYeBdwj+RQ4Lv/MBxVJciNAm8aKpP8DsTK4+ZZl80TVSvQ== X-Received: by 2002:ac8:5b87:0:b0:3e6:970e:a3f6 with SMTP id a7-20020ac85b87000000b003e6970ea3f6mr20170408qta.11.1682265869482; Sun, 23 Apr 2023 09:04:29 -0700 (PDT) Received: from localhost.localdomain (dsl-141-20.b2b2c.ca. [66.158.141.20]) by smtp.gmail.com with ESMTPSA id d13-20020a05622a15cd00b003ef48392649sm2957469qty.4.2023.04.23.09.04.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 23 Apr 2023 09:04:29 -0700 (PDT) From: Maxim Cournoyer To: 58813@debbugs.gnu.org Subject: [PATCH 4/5] teams: Add a 'cc-mentors-header-cmd' action. Date: Sun, 23 Apr 2023 12:04:14 -0400 Message-Id: <9c8ad422c50f78b52f257551774b4feee0ed199c.1682265703.git.maxim.cournoyer@gmail.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <878rg4snrf.fsf@gmail.com> References: <878rg4snrf.fsf@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 58813 Cc: ludo@gnu.org, liliana.prikler@gmail.com, Maxim Cournoyer , zimon.toutoune@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) * etc/teams.scm.in (main): Register a new "cc-mentors-header-cmd" action. Document it. --- etc/teams.scm.in | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/etc/teams.scm.in b/etc/teams.scm.in index 8203446446..50ac7f043f 100644 --- a/etc/teams.scm.in +++ b/etc/teams.scm.in @@ -725,6 +725,9 @@ (define (main . args) (list-members (find-team team-name) (current-output-port) "X-Debbugs-Cc: ")) (patch->teams patch-file))) + (("cc-mentors-header-cmd" patch-file) + (list-members (find-team "mentors") (current-output-port) + "X-Debbugs-Cc: ")) (("configure-git") (configure-git)) (("get-maintainer" patch-file) @@ -743,10 +746,12 @@ (define (main . args) Commands: cc get git send-email flags for cc-ing - cc-members | patch + cc-members | cc teams related to files changed between revisions or in a patch file cc-members-header-cmd cc-members variant for use with 'git send-email --header-cmd' + cc-mentors-header-cmd + command to use with 'git send-email --header-cmd' to notify mentors configure-git automatically configure your git for Guix list-teams -- 2.39.2 From debbugs-submit-bounces@debbugs.gnu.org Sun Apr 23 12:04:46 2023 Received: (at 58813) by debbugs.gnu.org; 23 Apr 2023 16:04:46 +0000 Received: from localhost ([127.0.0.1]:46818 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pqcCj-0004h9-W8 for submit@debbugs.gnu.org; Sun, 23 Apr 2023 12:04:46 -0400 Received: from mail-qt1-f177.google.com ([209.85.160.177]:59902) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pqcCV-0004fl-Hu for 58813@debbugs.gnu.org; Sun, 23 Apr 2023 12:04:37 -0400 Received: by mail-qt1-f177.google.com with SMTP id d75a77b69052e-3f0596e2c00so1482091cf.3 for <58813@debbugs.gnu.org>; Sun, 23 Apr 2023 09:04:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1682265866; x=1684857866; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=3/nTDL5epv8LH7Zhp/PfgpNw44gpnaIU3KvJ9LYeRzs=; b=mk9Hi7c0WE/P2GN+WrmBVKgDF6HUS8CKADukuGo1GkgshYycutX6KrZNZoN6bYNXeJ nfCjMsFPmANs6yo3SWnSwMKxv8rTP17nTndI0Eh0AVXblz4FcbNmdUPu0ww7SbpfYp7N kS3LnrO5NWqTxPEOQ/+lLuzXzo9NQ00TTEWak33BciTKVce7WRcRJ/TchUohKHNgOVPU c7ooUiRHB7M8mCiy0MPFPZSENiCjwSkNPZzc7ufknL0APDfmM6ts00EAqQFWhrqba+7b 061y2HDYlQi0R0U87eWSaQqDXr5jc1DZEBHCSRBe8DMvjOV2cOb6tM/a+x9lCscsH8qd n9nw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682265866; x=1684857866; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=3/nTDL5epv8LH7Zhp/PfgpNw44gpnaIU3KvJ9LYeRzs=; b=bAhLnuYXbyAtbw+f2/4qcigwEGXh7FzeVFQAanXPCm0D9LRNhlj89biWqqBXfwsHPd TtsepZl5oulugKn1emt4R7ZErtetv+gawRaWwEBhvkHFcAaqgaAbFA6n3NQrW39H+cnI 8SnLlOFfuhibAlB4PPhTMdDR0Lw3XNEGrrhjvxCRegKF3QMx1JFHvkWLSaBqpCUMaV2H JrEcHEe/t3fkrT7KPBxhxDPuFN5hPu4q9HQwUySUuXBLC1PRstJDfKM3ScQL0YmZnnV2 x5Jc3foPLj6irwoo0kJ9Q0TLAzgSgjGztFcM3zbirkEYPOyCrd4pG3cnSNwZS3Zygkyo +vnw== X-Gm-Message-State: AAQBX9fYlTlmHkf32yvok7M43UcHJ2VZ48TIBlO7iXLXz3dKzeswQ4h+ F9WWgsRj0d/+ev4eb5IpSsP54u2EhuT6+g== X-Google-Smtp-Source: AKy350akq3PpdFRKEl+nLbhYnesDjpW6YmGpi1NvQp4ZNGzTHcnnmY4FIeRTmGlTsloEKbXk1/bzdA== X-Received: by 2002:ac8:5cd1:0:b0:3ef:231c:cee7 with SMTP id s17-20020ac85cd1000000b003ef231ccee7mr19893101qta.7.1682265865755; Sun, 23 Apr 2023 09:04:25 -0700 (PDT) Received: from localhost.localdomain (dsl-141-20.b2b2c.ca. [66.158.141.20]) by smtp.gmail.com with ESMTPSA id d13-20020a05622a15cd00b003ef48392649sm2957469qty.4.2023.04.23.09.04.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 23 Apr 2023 09:04:25 -0700 (PDT) From: Maxim Cournoyer To: 58813@debbugs.gnu.org Subject: [PATCH 1/5] gnu: git: Apply patch adding the --header-cmd feature. Date: Sun, 23 Apr 2023 12:04:11 -0400 Message-Id: <2899162d279cdd940bc91459b38ff1e2c3f4f0ec.1682265703.git.maxim.cournoyer@gmail.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <878rg4snrf.fsf@gmail.com> References: <878rg4snrf.fsf@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 58813 Cc: ludo@gnu.org, liliana.prikler@gmail.com, Maxim Cournoyer , zimon.toutoune@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) In preparation to fix . * gnu/packages/patches/git-header-cmd.patch: New file. * gnu/local.mk (dist_patch_DATA): Register it. * gnu/packages/version-control.scm (git) [source]: Apply patch. --- gnu/local.mk | 1 + gnu/packages/patches/git-header-cmd.patch | 180 ++++++++++++++++++++++ gnu/packages/version-control.scm | 3 +- 3 files changed, 183 insertions(+), 1 deletion(-) create mode 100644 gnu/packages/patches/git-header-cmd.patch diff --git a/gnu/local.mk b/gnu/local.mk index b631fa6d5a..d7c7ca48e7 100644 --- a/gnu/local.mk +++ b/gnu/local.mk @@ -1209,6 +1209,7 @@ dist_patch_DATA = \ %D%/packages/patches/gemmi-fix-sajson-types.patch \ %D%/packages/patches/genimage-mke2fs-test.patch \ %D%/packages/patches/geoclue-config.patch \ + %D%/packages/patches/git-header-cmd.patch \ %D%/packages/patches/ghc-8.0-fall-back-to-madv_dontneed.patch \ %D%/packages/patches/ghc-9.2-glibc-2.33-link-order.patch \ %D%/packages/patches/ghc-testsuite-dlopen-pie.patch \ diff --git a/gnu/packages/patches/git-header-cmd.patch b/gnu/packages/patches/git-header-cmd.patch new file mode 100644 index 0000000000..fdd34fe4a4 --- /dev/null +++ b/gnu/packages/patches/git-header-cmd.patch @@ -0,0 +1,180 @@ +Add a '--header-cmd' to git send-email. + +Upstream status can be tracked at: +https://lore.kernel.org/git/20230423122744.4865-1-maxim.cournoyer@gmail.com/T/#t + +diff --git a/Documentation/config/sendemail.txt b/Documentation/config/sendemail.txt +index 51da7088a8..3d0f516520 100644 +--- a/Documentation/config/sendemail.txt ++++ b/Documentation/config/sendemail.txt +@@ -58,6 +58,7 @@ sendemail.annotate:: + sendemail.bcc:: + sendemail.cc:: + sendemail.ccCmd:: ++sendemail.headerCmd:: + sendemail.chainReplyTo:: + sendemail.envelopeSender:: + sendemail.from:: +diff --git a/Documentation/git-send-email.txt b/Documentation/git-send-email.txt +index b0f438ec99..354c0d06db 100644 +--- a/Documentation/git-send-email.txt ++++ b/Documentation/git-send-email.txt +@@ -320,6 +320,11 @@ Automating + Output of this command must be single email address per line. + Default is the value of `sendemail.ccCmd` configuration value. + ++--header-cmd=:: ++ Specify a command to execute once per patch file which should ++ generate arbitrary, patch file specific header entries. ++ Default is the value of `sendemail.headerCmd` configuration value. ++ + --[no-]chain-reply-to:: + If this is set, each email will be sent as a reply to the previous + email sent. If disabled with "--no-chain-reply-to", all emails after +diff --git a/git-send-email.perl b/git-send-email.perl +index fd8cd0d46f..676dd83d89 100755 +--- a/git-send-email.perl ++++ b/git-send-email.perl +@@ -2,6 +2,7 @@ + # + # Copyright 2002,2005 Greg Kroah-Hartman + # Copyright 2005 Ryan Anderson ++# Copyright 2023 Maxim Cournoyer + # + # GPL v2 (See COPYING) + # +@@ -87,8 +88,9 @@ sub usage { + + Automating: + --identity * Use the sendemail. options. +- --to-cmd * Email To: via ` \$patch_path` +- --cc-cmd * Email Cc: via ` \$patch_path` ++ --to-cmd * Email To: via ` \$patch_path`. ++ --cc-cmd * Email Cc: via ` \$patch_path`. ++ --header-cmd * Add headers via ` \$patch_path`. + --suppress-cc * author, self, sob, cc, cccmd, body, bodycc, misc-by, all. + --[no-]cc-cover * Email Cc: addresses in the cover letter. + --[no-]to-cover * Email To: addresses in the cover letter. +@@ -269,7 +271,7 @@ sub do_edit { + # Variables with corresponding config settings + my ($suppress_from, $signed_off_by_cc); + my ($cover_cc, $cover_to); +-my ($to_cmd, $cc_cmd); ++my ($to_cmd, $cc_cmd, $header_cmd); + my ($smtp_server, $smtp_server_port, @smtp_server_options); + my ($smtp_authuser, $smtp_encryption, $smtp_ssl_cert_path); + my ($batch_size, $relogin_delay); +@@ -318,6 +320,7 @@ sub do_edit { + "tocmd" => \$to_cmd, + "cc" => \@config_cc, + "cccmd" => \$cc_cmd, ++ "headercmd" => \$header_cmd, + "aliasfiletype" => \$aliasfiletype, + "bcc" => \@config_bcc, + "suppresscc" => \@suppress_cc, +@@ -519,6 +522,7 @@ sub config_regexp { + "compose" => \$compose, + "quiet" => \$quiet, + "cc-cmd=s" => \$cc_cmd, ++ "header-cmd=s" => \$header_cmd, + "suppress-from!" => \$suppress_from, + "no-suppress-from" => sub {$suppress_from = 0}, + "suppress-cc=s" => \@suppress_cc, +@@ -1776,6 +1780,9 @@ sub process_file { + push(@header, $_); + } + } ++ # Add computed headers, if applicable. ++ push @header, execute_cmd("header-cmd", $header_cmd, $t) ++ if defined $header_cmd; + # Now parse the header + foreach(@header) { + if (/^From /) { +@@ -2006,15 +2013,30 @@ sub process_file { + } + } + ++# Execute a command (e.g., $x_cmd) and return its output lines as an ++# array. ++sub execute_cmd { ++ my ($prefix, $cmd, $file) = @_; ++ my @lines = (); ++ open my $fh, "-|", "$cmd \Q$file\E" ++ or die sprintf(__("(%s) Could not execute '%s'"), $prefix, $cmd); ++ while (my $line = <$fh>) { ++ last if $line =~ /^$/; ++ push @lines, $line; ++ } ++ close $fh ++ or die sprintf(__("(%s) failed to close pipe to '%s'"), $prefix, $cmd); ++ return @lines; ++} ++ + # Execute a command (e.g. $to_cmd) to get a list of email addresses + # and return a results array + sub recipients_cmd { + my ($prefix, $what, $cmd, $file) = @_; +- ++ my @lines = (); + my @addresses = (); +- open my $fh, "-|", "$cmd \Q$file\E" +- or die sprintf(__("(%s) Could not execute '%s'"), $prefix, $cmd); +- while (my $address = <$fh>) { ++ @lines = execute_cmd($prefix, $cmd, $file); ++ for my $address (@lines) { + $address =~ s/^\s*//g; + $address =~ s/\s*$//g; + $address = sanitize_address($address); +@@ -2023,8 +2045,6 @@ sub recipients_cmd { + printf(__("(%s) Adding %s: %s from: '%s'\n"), + $prefix, $what, $address, $cmd) unless $quiet; + } +- close $fh +- or die sprintf(__("(%s) failed to close pipe to '%s'"), $prefix, $cmd); + return @addresses; + } + +diff --git a/t/t9001-send-email.sh b/t/t9001-send-email.sh +index 0de83b5d2b..3393725107 100755 +--- a/t/t9001-send-email.sh ++++ b/t/t9001-send-email.sh +@@ -374,13 +374,16 @@ test_expect_success $PREREQ,!AUTOIDENT 'broken implicit ident aborts send-email' + ) + ' + +-test_expect_success $PREREQ 'setup tocmd and cccmd scripts' ' ++test_expect_success $PREREQ 'setup cmd scripts' ' + write_script tocmd-sed <<-\EOF && + sed -n -e "s/^tocmd--//p" "$1" + EOF +- write_script cccmd-sed <<-\EOF ++ write_script cccmd-sed <<-\EOF && + sed -n -e "s/^cccmd--//p" "$1" + EOF ++ write_script headercmd-sed <<-\EOF ++ sed -n -e "s/^headercmd--//p" "$1" ++ EOF + ' + + test_expect_success $PREREQ 'tocmd works' ' +@@ -410,6 +413,20 @@ test_expect_success $PREREQ 'cccmd works' ' + grep "^ cccmd@example.com" msgtxt1 + ' + ++test_expect_success $PREREQ 'headercmd works' ' ++ clean_fake_sendmail && ++ cp $patches headercmd.patch && ++ echo "headercmd--X-Debbugs-CC: dummy@example.com" >>headercmd.patch && ++ git send-email \ ++ --from="Example " \ ++ --to=nobody@example.com \ ++ --header-cmd=./headercmd-sed \ ++ --smtp-server="$(pwd)/fake.sendmail" \ ++ headercmd.patch \ ++ && ++ grep "^X-Debbugs-CC: dummy@example.com" msgtxt1 ++' ++ + test_expect_success $PREREQ 'reject long lines' ' + z8=zzzzzzzz && + z64=$z8$z8$z8$z8$z8$z8$z8$z8 && diff --git a/gnu/packages/version-control.scm b/gnu/packages/version-control.scm index 302f7c90ad..d5d88b99ed 100644 --- a/gnu/packages/version-control.scm +++ b/gnu/packages/version-control.scm @@ -232,7 +232,8 @@ (define-public git version ".tar.xz")) (sha256 (base32 - "1mpjvhyw8mv2q941xny4d0gw3mb6b4bqaqbh73jd8b1v6zqpaps7")))) + "1mpjvhyw8mv2q941xny4d0gw3mb6b4bqaqbh73jd8b1v6zqpaps7")) + (patches (search-patches "git-header-cmd.patch")))) (build-system gnu-build-system) (native-inputs `(("native-perl" ,perl) -- 2.39.2 From debbugs-submit-bounces@debbugs.gnu.org Sun Apr 23 12:04:47 2023 Received: (at 58813) by debbugs.gnu.org; 23 Apr 2023 16:04:47 +0000 Received: from localhost ([127.0.0.1]:46820 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pqcCk-0004hH-Nu for submit@debbugs.gnu.org; Sun, 23 Apr 2023 12:04:47 -0400 Received: from mail-qt1-f175.google.com ([209.85.160.175]:50633) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pqcCa-0004g1-KJ for 58813@debbugs.gnu.org; Sun, 23 Apr 2023 12:04:37 -0400 Received: by mail-qt1-f175.google.com with SMTP id d75a77b69052e-3ef588dcf7aso33405751cf.1 for <58813@debbugs.gnu.org>; Sun, 23 Apr 2023 09:04:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1682265871; x=1684857871; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Ib1xfOp9MuqQvZDLhRJP8AChmjvj3X995tTjsXJcjTY=; b=mF6jOamxznfIgBb0qy7IvxX59gWMrv6vhw0UxFU/4x0hUvSX820ymQnEnjqn0yfGRj bYRGHIGyzj1r6ZokoUcDYUVNCHgaA4hfPyOgFQrEmoJgezYDrYyE3ILAznlr9ZCC7Mah tr3C/Sfv/KOEUR7eAj56plqA+ZNSFWReUzDBCG4RX7Re7np1vyZhkAZKQnZR7dJh5fSy el9knIVvMEb/qnLz8rKH/pJ7PabJlZOz8M9aB31mTMxG5gRW0RwAKCVibPhsmWSPKvAe 5RWkX+qsluxxGuguvQD4YQk7G/ItOd6aZwcWx7HZrQUl72bRZVCbOUkLdbv9lLnp7xgZ A4UQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682265871; x=1684857871; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Ib1xfOp9MuqQvZDLhRJP8AChmjvj3X995tTjsXJcjTY=; b=E8B68YvOD16z2IfcC/lvq54uMiHyln+q3sPyY+XndGqgwVq8fqj/wBtkX5F90H770i SQuxNxkgU5vn0Qw2aJLwDn5SFSMuPnRQBIMBnHt4LMp05UEEWrAymYibtL4IV36fE7yX Z0ht2xSxLVyDYPlClO2wAOKdzc20Wx/e5D/dBoHMBhg6LRswDygufTuDP9v4IBL+ozoO FrTeyx/seyjWbCVDkpjtFy1np4639kScrVNuYlF+2duY2q9srHHk0IAcInNp60CBnIWw R1G2h+ySQ+3TnsNBbgB1rskX6+dVzG41BNL+9n7uf6DnbqYRaaYFiez7gKmrlrFyscR1 gBKQ== X-Gm-Message-State: AAQBX9drENErp7A7YzTGgKctEn6d/GUhFvwa469Dlqh8K1Ycb6dCY/As ew2wlagA4HtVzrwPozSbUkPfMAdck4a+LQ== X-Google-Smtp-Source: AKy350aP4jeIXQGcZDRti2bjrZ9qf7Z0TXtrkdFYU1uEETD5yMsWjWDtqCY68QSYvI4gWrwFy6GmKA== X-Received: by 2002:a05:622a:1301:b0:3ef:68ea:e253 with SMTP id v1-20020a05622a130100b003ef68eae253mr7470494qtk.19.1682265870934; Sun, 23 Apr 2023 09:04:30 -0700 (PDT) Received: from localhost.localdomain (dsl-141-20.b2b2c.ca. [66.158.141.20]) by smtp.gmail.com with ESMTPSA id d13-20020a05622a15cd00b003ef48392649sm2957469qty.4.2023.04.23.09.04.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 23 Apr 2023 09:04:30 -0700 (PDT) From: Maxim Cournoyer To: 58813@debbugs.gnu.org Subject: [PATCH 5/5] doc: Simplify contributing section by automating git configuration. Date: Sun, 23 Apr 2023 12:04:15 -0400 Message-Id: X-Mailer: git-send-email 2.39.2 In-Reply-To: <878rg4snrf.fsf@gmail.com> References: <878rg4snrf.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 58813 Cc: ludo@gnu.org, liliana.prikler@gmail.com, Maxim Cournoyer , zimon.toutoune@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Fixes . Instead of documenting all the fine details of Git configuration, invite users to configure their checkout with 'etc/teams configure-git'. No longer suggests to splice the output of etc/teams.scm commands into the 'git send-email' command line; this is now transparently handled by the Git configuration. * doc/contributing.texi (Configuring Git): Move configuration setup to 'etc/teams.scm configure-git'. (Sending a Patch Series): Do not specify options configured as default by the above. Prefer long option names, for explicitness. (Teams): Rewrite the examples to use --header-cmd. (Commit Access): Refer to the Configuring Git section instead of detailing manual steps. --- doc/contributing.texi | 102 +++++++++++++++--------------------------- doc/guix.texi | 2 +- 2 files changed, 37 insertions(+), 67 deletions(-) diff --git a/doc/contributing.texi b/doc/contributing.texi index 73d1cd2648..fb72238487 100644 --- a/doc/contributing.texi +++ b/doc/contributing.texi @@ -1395,27 +1395,11 @@ Configuring Git use @command{git config --local}, or edit @file{.git/config} in the repository instead of @file{~/.gitconfig}. -We provide some default settings in @file{etc/git/gitconfig} which -modify how patches are generated, making them easier to read and apply. -These settings can be applied by manually copying them to -@file{.git/config} in your checkout, or by telling Git to include the -whole file: +To configure automatically your local Git checkout to use the +recommended settings and hooks, run the following command once: @example -git config --local include.path ../etc/git/gitconfig -@end example - -From then on, any changes to @file{etc/git/gitconfig} would -automatically take effect. - -Since the first patch in a series must be sent separately -(@pxref{Sending a Patch Series}), it can also be helpful to tell -@command{git format-patch} to handle the e-mail threading instead of -@command{git send-email}: - -@example -git config --local format.thread shallow -git config --local sendemail.thread no +etc/teams.scm configure-git @end example @node Sending a Patch Series @@ -1439,10 +1423,12 @@ Sending a Patch Series The following command will create a patch email from the latest commit, open it in your @var{EDITOR} or @var{VISUAL} for editing, and send it to -the Guix mailing list to be reviewed and merged: +the Guix mailing list to be reviewed and merged. Assuming you have +already configured Git according to @xref{Configuring Git}, you can +simply use: @example -$ git send-email -1 -a --base=auto --to=guix-patches@@gnu.org +$ git send-email --annotate -1 @end example @quotation Tip @@ -1453,31 +1439,26 @@ Sending a Patch Series @url{https://git.savannah.gnu.org/cgit/guix.git}. @example -git send-email -1 -a --base=auto \ - --subject-prefix='PATCH core-updates' \ - --to=guix-patches@@gnu.org +git send-email --annotate --subject-prefix='PATCH core-updates' -1 @end example @end quotation The patch email contains a three-dash separator line after the commit message. You may ``annotate'' the patch with explanatory text by adding it under this line. If you do not wish to annotate the email, you may -drop the @option{-a} flag (which is short for @option{--annotate}). - -The @option{--base=auto} flag automatically adds a note at the bottom -of the patch of the commit it was based on, making it easier for -maintainers to rebase and merge your patch. +drop the @option{--annotate} option. If you need to send a revised patch, don't resend it like this or send a ``fix'' patch to be applied on top of the last one; instead, use -@command{git commit -a} or @url{https://git-rebase.io, @command{git rebase}} -to modify the commit, and use the @email{@var{ISSUE_NUMBER}@@debbugs.gnu.org} -address and the @option{-v} flag with @command{git send-email}. +@command{git commit --amend} or @url{https://git-rebase.io, +@command{git rebase}} to modify the commit, and use the +@email{@var{ISSUE_NUMBER}@@debbugs.gnu.org} address and the @option{-v} +flag with @command{git send-email}. @example -$ git commit -a -$ git send-email -1 -a --base=auto -v@var{REVISION} \ - --to=@var{ISSUE_NUMBER}@@debbugs.gnu.org +$ git commit --amend +$ git send-email --annotate -v@var{REVISION} \ + --to=@var{ISSUE_NUMBER}@@debbugs.gnu.org -1 @end example @quotation Note @@ -1494,14 +1475,14 @@ Sending a Patch Series @unnumberedsubsubsec Notifying Teams @anchor{Notifying Teams} @cindex teams -The @file{etc/teams.scm} script may be used to notify all those who -may be interested in your patch of its existence (@pxref{Teams}). -Use @command{etc/teams.scm list-teams} to display all the teams, -decide which team(s) your patch relates to, and use -@command{etc/teams.scm cc} to output various @command{git send-email} -flags which will notify the appropriate team members, or use -@command{etc/teams.scm cc-members} to detect the appropriate teams -automatically. +If your git checkout has been correctly configured (@pxref{Configuring +Git}), the @command{git send-email} command will automatically notify +the appropriate team members, based on the scope of your changes. This +relies on the @file{etc/teams.scm} script, which can also be invoked +manually if you do not use the preferred @command{git send-email} +command to submit patches. To list the available actions of the script, +you can invoke it via the @command{etc/teams.scm help} command. For +more information regarding teams, see @xref{Teams}. @unnumberedsubsubsec Multiple Patches @anchor{Multiple Patches} @@ -1528,9 +1509,7 @@ Sending a Patch Series that we can send the rest of the patches to. @example -$ git send-email outgoing/0000-cover-letter.patch -a \ - --to=guix-patches@@gnu.org \ - $(etc/teams.scm cc-members ...) +$ git send-email outgoing/0000-cover-letter.patch --annotate $ rm outgoing/0000-cover-letter.patch # we don't want to resend it! @end example @@ -1542,9 +1521,7 @@ Sending a Patch Series can send the actual patches to the newly-created issue address. @example -$ git send-email outgoing/*.patch \ - --to=@var{ISSUE_NUMBER}@@debbugs.gnu.org \ - $(etc/teams.scm cc-members ...) +$ git send-email outgoing/*.patch --to=@var{ISSUE_NUMBER}@@debbugs.gnu.org $ rm -rf outgoing # we don't need these anymore @end example @@ -1553,14 +1530,13 @@ Sending a Patch Series the patchset. @example -$ git send-email -@var{NUMBER_COMMITS} \ - -v@var{REVISION} --base=auto \ +$ git send-email -@var{NUMBER_COMMITS} -v@var{REVISION} \ --to @var{ISSUE_NUMBER}@@debbugs.gnu.org @end example -If need be, you may use @option{--cover-letter -a} to send another cover -letter, e.g. for explaining what's changed since the last revision, and -these changes are necessary. +If need be, you may use @option{--cover-letter --annotate} to send +another cover letter, e.g. for explaining what's changed since the last +revision, and these changes are necessary. @node Teams @subsection Teams @@ -1587,7 +1563,8 @@ Teams CC of a patch series: @example -$ git send-email --to @var{ISSUE_NUMBER}@@debbugs.gnu.org $(./etc/teams.scm cc mentors) *.patch +$ git send-email --to @var{ISSUE_NUMBER}@@debbugs.gnu.org \ + --header-cmd='etc/teams.scm cc-mentors-header-cmd' *.patch @end example The appropriate team or teams can also be inferred from the modified @@ -1596,7 +1573,7 @@ Teams @example $ guix shell -D guix -[env]$ git send-email --to @var{ISSUE_NUMBER}@@debbugs.gnu.org $(./etc/teams.scm cc-members HEAD~2 HEAD) *.patch +[env]$ git send-email --to @var{ISSUE_NUMBER}@@debbugs.gnu.org -2 @end example @node Tracking Bugs and Patches @@ -1831,16 +1808,9 @@ Commit Access make authenticate @end example -You can prevent yourself from accidentally pushing unsigned or signed -with the wrong key commits to Savannah by using the pre-push Git hook -located at @file{etc/git/pre-push}: - -@example -cp etc/git/pre-push .git/hooks/pre-push -@end example - -It additionally calls @code{make check-channel-news} to be sure -@file{news.scm} file is correct. +To avoid accidentally pushing unsigned or signed with the wrong key +commits to Savannah, make sure to configure Git according to +@xref{Configuring Git}. @subsection Commit Policy diff --git a/doc/guix.texi b/doc/guix.texi index 9997aeb86e..e5f6c7e831 100644 --- a/doc/guix.texi +++ b/doc/guix.texi @@ -49,7 +49,7 @@ Copyright @copyright{} 2017, 2021 Christine Lemmer-Webber@* Copyright @copyright{} 2017, 2018, 2019, 2020, 2021, 2022 Marius Bakke@* Copyright @copyright{} 2017, 2019, 2020, 2022 Hartmut Goebel@* -Copyright @copyright{} 2017, 2019, 2020, 2021, 2022 Maxim Cournoyer@* +Copyright @copyright{} 2017, 2019, 2020, 2021, 2022, 2023 Maxim Cournoyer@* Copyright @copyright{} 2017–2022 Tobias Geerinckx-Rice@* Copyright @copyright{} 2017 George Clemmer@* Copyright @copyright{} 2017 Andy Wingo@* -- 2.39.2 From debbugs-submit-bounces@debbugs.gnu.org Sun Apr 23 13:00:24 2023 Received: (at 58813) by debbugs.gnu.org; 23 Apr 2023 17:00:24 +0000 Received: from localhost ([127.0.0.1]:46865 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pqd4a-0000WA-A3 for submit@debbugs.gnu.org; Sun, 23 Apr 2023 13:00:24 -0400 Received: from mail-ej1-f66.google.com ([209.85.218.66]:50569) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pqd4Y-0000Vt-3D for 58813@debbugs.gnu.org; Sun, 23 Apr 2023 13:00:22 -0400 Received: by mail-ej1-f66.google.com with SMTP id a640c23a62f3a-94f109b1808so632585266b.1 for <58813@debbugs.gnu.org>; Sun, 23 Apr 2023 10:00:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1682269216; x=1684861216; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=OuY+Vt+8ePhTyAU/OiYRoRL0T6mJbT3SkAujp1pwYCA=; b=GUMP/fxI8xiCi0WUYUcMMGKLw9oI+59SRgSF7zJcOz8MNLbM6/sHSIoHeQ301hD+fo qNJ07Tzwm3sV/qxkLVlBVB2qg2Yncvmivd6RopN2PmKFOCMwmq9sBT1D6/eyVMkmNJV/ rF39GNlKw5Ww3WEU/b4RZCOIetyuBCEH1uytzVxF6rdy9xiB0L4UdPKYafAkIKPSIqpt gKhQ2ua1skDOkpCV7WIdt50BBnnw4Aq05p8PqhCyTE3xLh6IFqghx2tY4tFsdQV+8HCQ rBsTa0v5joyqtxKgoOmRHF+brEd4fHnS8d7sUpYsVZ3URAQAEGHH67zea3yapW0KjiGO v/Tw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682269216; x=1684861216; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=OuY+Vt+8ePhTyAU/OiYRoRL0T6mJbT3SkAujp1pwYCA=; b=BzuaeCWxAT5Y6aM9dwc9ljy34BSVNdm9IcNjm8Ev0L5hIvv+JJwhR6R713iqSLP5yT 8qR/RKGDGS97V6CXjMF6K3jaoR6csuBvbIoovymiiUzGuNXmtEd7ONXeuOwqMEf30mF7 h0KFUxhOMMC3tiOSjPIO97HLx9I8obXWWQW475FzNS9MeSE+6TKZMSreB/9+j84wFwh0 L4/PlA45YD6x5d/wighT3lHwT1N4RiErjI6FJggwpqGnSCsf0aeFYdV542uG7G/4HTtF fc1VHFIOBMBF4wagijYdm0oz7bwYKW9QBUV0PQlcIpPgrA0mdGTUY2L8VjFVzoxyNnQ5 f3vg== X-Gm-Message-State: AAQBX9d4VBhXeH7ipXYNm0/wm/8DFlqbxwxPvxa54t8pSawEu0tsdsKc HUrabJLZcTgCqhoGcBASe5w= X-Google-Smtp-Source: AKy350Y8SNuW7Ijf5ff52Pw2QDw7eUl7zFmyMoYJdzBoy35dRsyp6MRZSeWpNChsSL/wAQmaYZOSgA== X-Received: by 2002:a17:907:914e:b0:94f:2efa:a3eb with SMTP id l14-20020a170907914e00b0094f2efaa3ebmr6713681ejs.33.1682269215796; Sun, 23 Apr 2023 10:00:15 -0700 (PDT) Received: from lumine.fritz.box (85-127-52-93.dsl.dynamic.surfer.at. [85.127.52.93]) by smtp.gmail.com with ESMTPSA id bp23-20020a170907919700b0094f44bdf7acsm4625086ejb.57.2023.04.23.10.00.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 23 Apr 2023 10:00:15 -0700 (PDT) Message-ID: Subject: Re: [PATCH 1/5] gnu: git: Apply patch adding the --header-cmd feature. From: Liliana Marie Prikler To: Maxim Cournoyer , 58813@debbugs.gnu.org Date: Sun, 23 Apr 2023 19:00:12 +0200 In-Reply-To: <2899162d279cdd940bc91459b38ff1e2c3f4f0ec.1682265703.git.maxim.cournoyer@gmail.com> References: <878rg4snrf.fsf@gmail.com> <2899162d279cdd940bc91459b38ff1e2c3f4f0ec.1682265703.git.maxim.cournoyer@gmail.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.4 MIME-Version: 1.0 X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 58813 Cc: ludo@gnu.org, zimon.toutoune@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Am Sonntag, dem 23.04.2023 um 12:04 -0400 schrieb Maxim Cournoyer: > In preparation to fix . >=20 > * gnu/packages/patches/git-header-cmd.patch: New file. > * gnu/local.mk (dist_patch_DATA): Register it. > * gnu/packages/version-control.scm (git) [source]: Apply patch. > --- Don't forget to also send this patch to git proper. I'm sure that other distros will have a use for it. Cheers From debbugs-submit-bounces@debbugs.gnu.org Sun Apr 23 13:03:54 2023 Received: (at 58813) by debbugs.gnu.org; 23 Apr 2023 17:03:54 +0000 Received: from localhost ([127.0.0.1]:46875 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pqd7y-0000br-An for submit@debbugs.gnu.org; Sun, 23 Apr 2023 13:03:54 -0400 Received: from mail-ej1-f68.google.com ([209.85.218.68]:48375) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pqd7w-0000bE-9I for 58813@debbugs.gnu.org; Sun, 23 Apr 2023 13:03:52 -0400 Received: by mail-ej1-f68.google.com with SMTP id a640c23a62f3a-9536df4b907so637421966b.0 for <58813@debbugs.gnu.org>; Sun, 23 Apr 2023 10:03:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1682269426; x=1684861426; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=DYSJ3clO9be48+I3BYtcYETfyezJUMRSOxaRmBfukA0=; b=ifWUVrCbXJ/LzgUvuZr/gqxCfpYKUrD0tk0foZwHLceJTvfbz0SBCp8xl4AGqt3r1s g4GVHDkaN9VmOq1XMKwiKwot/uNGVoUgj8epNmIJL0s5gtbD5xGzvvjnMbPPWdSkB4Vl /kUm12XCRtsnXC+ysgJoKZPy6m8kpx7dL4cu7PP2d8EAgNEfxi9aVrmJ/DQS9541SJP+ ET4VyroYy+14b1jsBUTz0hN+tYpkIpYFdnedo2EI49Bd+3wks0GWgYnVLwP05WKUN9pp S+elC5EqNLvMb3mA4grCVxzi9BzlEpXcW2cs7YrEKwNi449JpjbP2N78wZcOzorAfYmf O1aw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682269426; x=1684861426; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=DYSJ3clO9be48+I3BYtcYETfyezJUMRSOxaRmBfukA0=; b=CO+m0bt/Jq7AKEaO/LC8LQVrF9O1ortwDBRUrOog6CiRd/AWsqTiQgnyBUxgahhHcs z9re5CRHM1wXdgs8RMGuoiDWH9fcodgtIuM+XXnebHE+aPtZxdSBQeLNka4T413GcNSA 2dYHFFb5AhoiN629CLRYp0WFNh4N1i5ZxCkhSPlUc6+rUiGwDLbFAu3/j+2Onu3ciLxQ A9HIYheKSpxUNGfvMPfsXdyn3Ks6e3KBINkQqAbFYbT8M6ZWDcEf+/AVgWTQDbslfHvr 8w1Jj/T6UEJs+iWsQaCZE4LuLuTyWcrwB8Xylj9/hH3BfPw2lsma15V+TWRPVv6JBwb0 tb7A== X-Gm-Message-State: AAQBX9d3KiI9K/lichhXtxHO9C7RllIzhp4UoLI+IPBL7eJa66vfbAar i3Gqqej7XqZc5bMKQWb2T/fttRttN9/wBg== X-Google-Smtp-Source: AKy350byf/qGK01YfyrApsYLXc6LPAJZqkpfl5rCFWnBFN4h6HaYawtKEBK8xhdpliE79tCJLg7BSQ== X-Received: by 2002:a17:906:7f88:b0:94f:17b7:c4b8 with SMTP id f8-20020a1709067f8800b0094f17b7c4b8mr7684988ejr.19.1682269426504; Sun, 23 Apr 2023 10:03:46 -0700 (PDT) Received: from lumine.fritz.box (85-127-52-93.dsl.dynamic.surfer.at. [85.127.52.93]) by smtp.gmail.com with ESMTPSA id a8-20020a170906670800b0094f257e3e05sm4547622ejp.168.2023.04.23.10.03.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 23 Apr 2023 10:03:46 -0700 (PDT) Message-ID: <5b9af4fa77a89c6a4b169dc464f414b1a4166d60.camel@gmail.com> Subject: Re: [PATCH 3/5] teams: Add a configure-git action. From: Liliana Marie Prikler To: Maxim Cournoyer , 58813@debbugs.gnu.org Date: Sun, 23 Apr 2023 19:03:45 +0200 In-Reply-To: References: <878rg4snrf.fsf@gmail.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.4 MIME-Version: 1.0 X-Spam-Score: 1.3 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Am Sonntag, dem 23.04.2023 um 12:04 -0400 schrieb Maxim Cournoyer: > * etc/git/gitconfig: Augment configuration template with useful > options to > allow for auto-configuration. > * etc/teams.scm.in ( [...] Content analysis details: (1.3 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (liliana.prikler[at]gmail.com) 1.3 RCVD_IN_VALIDITY_RPBL RBL: Relay in Validity RPBL, https://senderscore.org/blocklistlookup/ [209.85.218.68 listed in bl.score.senderscore.com] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record 0.0 RCVD_IN_MSPIKE_H3 RBL: Good reputation (+3) [209.85.218.68 listed in wl.mailspike.net] -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [209.85.218.68 listed in list.dnswl.org] 0.0 RCVD_IN_MSPIKE_WL Mailspike good senders X-Debbugs-Envelope-To: 58813 Cc: ludo@gnu.org, zimon.toutoune@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.3 (/) Am Sonntag, dem 23.04.2023 um 12:04 -0400 schrieb Maxim Cournoyer: > * etc/git/gitconfig: Augment configuration template with useful > options to > allow for auto-configuration. > * etc/teams.scm.in (configure-git): New procedure. > (main): Register it and add documentation. I think configure-git is somewhat out of scope inside teams.scm. We do already tell people to set up their push hooks, so we probably ought to solve this via documentation (or a separate dedicated script) as well. Otherwise LGTM. Cheers From debbugs-submit-bounces@debbugs.gnu.org Sun Apr 23 20:47:08 2023 Received: (at 58813) by debbugs.gnu.org; 24 Apr 2023 00:47:09 +0000 Received: from localhost ([127.0.0.1]:47140 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pqkMG-0007g7-LI for submit@debbugs.gnu.org; Sun, 23 Apr 2023 20:47:08 -0400 Received: from mail-qv1-f47.google.com ([209.85.219.47]:50214) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pqkME-0007fg-TU for 58813@debbugs.gnu.org; Sun, 23 Apr 2023 20:47:07 -0400 Received: by mail-qv1-f47.google.com with SMTP id 6a1803df08f44-5ef465a52e8so40095556d6.0 for <58813@debbugs.gnu.org>; Sun, 23 Apr 2023 17:47:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1682297221; x=1684889221; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=HnEDFvIcfEZjtKiER5TL6bbQO8NQGMJf7e6wsxKD7Yo=; b=LILLQVdUmMI+jOa+MB7vBiaFCWYFpCNP9gPU867w5nGwDZUnfvD5V8TXKGjDutb4Wg ICi/Ph97Z4D52DxKHrf1Q4DT+8+BODMYteSvaWtD63tm9IkjCU0iiRABcCVGvv7olAtz Fru/+AK+j0qf92Dp9dIMGbJAd5Y1oHbnob0gH9YXjJSpU+JjSb8ySlzYqd1EvZWYEkj5 Y5diZpoKAyHWRJGzUb8qoB3l83p6L7cOfkXKyg47OBgUxbnOekjYwHVou+CWYog6raMc jyp0j4DTfADOO0BRG+yz2i9ruvM7+oy3BAlocTjA1xIoW+h8RStk+9qRLdZty9LjcCeV 4bzQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682297221; x=1684889221; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=HnEDFvIcfEZjtKiER5TL6bbQO8NQGMJf7e6wsxKD7Yo=; b=h/Oay4ipF64R1MjejagProIzWp2YbshuxsDJkV8VLuVacadPnWxtR98RpE7vJ7V0X9 N2EUugeTZ9YV8yajQNO4DTYzh8qTYsKevbDYphNgE/92wok73pQ39x6xTRlIkb/JqIGK 5ZUQAt63Mkl4KnK6eFxqCiMi4Wb2wzVhVrdmRxmCaQw1OnrOVgtTaxt0/Yms6tQhFu9V q0uBS6373qYFqEmIeve51qQf7hmuju0HLR3jENyqN9o/YgXpHChz+9BrNeEEnnU9M5cA oTVj+KEp92EGINMmi858dU0Z9jRFajk6LRC5Tfben+jJOdUPNgYQfBmGqXaujYCWSRfC Cisw== X-Gm-Message-State: AAQBX9fPEKJo2oEB6Wa+4A1QqeK5bE7JbNC6h8RFGMdCwW1ivazrphl4 e1k4YFArfQ2UsSP9/bpGP7I= X-Google-Smtp-Source: AKy350ahgcDzuKqxsb7MHaXXF0dCJ2KB/bc9ZuTt2iLnv2xaJE1hKHqoJUsOTCYKhaFdTclbHVAMhg== X-Received: by 2002:a05:6214:1c4a:b0:5ea:922:bea9 with SMTP id if10-20020a0562141c4a00b005ea0922bea9mr23647358qvb.14.1682297221115; Sun, 23 Apr 2023 17:47:01 -0700 (PDT) Received: from hurd (dsl-141-20.b2b2c.ca. [66.158.141.20]) by smtp.gmail.com with ESMTPSA id r13-20020ac8424d000000b003df7d7bbc8csm3171241qtm.75.2023.04.23.17.47.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 23 Apr 2023 17:47:00 -0700 (PDT) From: Maxim Cournoyer To: Liliana Marie Prikler Subject: Re: [PATCH 1/5] gnu: git: Apply patch adding the --header-cmd feature. References: <878rg4snrf.fsf@gmail.com> <2899162d279cdd940bc91459b38ff1e2c3f4f0ec.1682265703.git.maxim.cournoyer@gmail.com> Date: Sun, 23 Apr 2023 20:46:59 -0400 In-Reply-To: (Liliana Marie Prikler's message of "Sun, 23 Apr 2023 19:00:12 +0200") Message-ID: <87fs8qumws.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 58813 Cc: ludo@gnu.org, 58813@debbugs.gnu.org, zimon.toutoune@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Liliana, Liliana Marie Prikler writes: > Am Sonntag, dem 23.04.2023 um 12:04 -0400 schrieb Maxim Cournoyer: >> In preparation to fix . >> >> * gnu/packages/patches/git-header-cmd.patch: New file. >> * gnu/local.mk (dist_patch_DATA): Register it. >> * gnu/packages/version-control.scm (git) [source]: Apply patch. >> --- > Don't forget to also send this patch to git proper. I'm sure that > other distros will have a use for it. Already the case (see the top comment in the patch itself) :-). -- Thanks, Maxim From debbugs-submit-bounces@debbugs.gnu.org Sun Apr 23 20:59:52 2023 Received: (at 58813) by debbugs.gnu.org; 24 Apr 2023 00:59:52 +0000 Received: from localhost ([127.0.0.1]:47157 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pqkYa-0008CP-BA for submit@debbugs.gnu.org; Sun, 23 Apr 2023 20:59:52 -0400 Received: from mail-qk1-f172.google.com ([209.85.222.172]:62616) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pqkYX-0008CC-U1 for 58813@debbugs.gnu.org; Sun, 23 Apr 2023 20:59:50 -0400 Received: by mail-qk1-f172.google.com with SMTP id af79cd13be357-74dd7f52f18so1091161985a.0 for <58813@debbugs.gnu.org>; Sun, 23 Apr 2023 17:59:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1682297984; x=1684889984; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=dedZEzpVV3Fzy4LACNNRYiAIhiGJfdYMcTU07Uabslg=; b=buFpjQkXB3xCad+tIBcErkaTxzHDoswy6cua1S4zh8wTm3fgv4TFguSbJEK8lqwCn3 qYKbkHGNiv1UKwYWDvuI9KkI7wZDCDjL1pY4hepftZtHLB1CGpGBY3h1vQjATvyTuW1i BEpIatB3jriLb8LDespVORUXtqxgLK4cnpKLlrItjxp2xZbvN92XNbg4plD7wnEnOc7U tV5tgED9W7vukxXQVIkcYUulg1d0V5W6pFUNV/ooHAw6LHgRLvJvn4a+K1+kqNNFBHoa GCBNP1e1WgXzY6nYetQ6rMzRLyOjplbJLK5t3zvepkWhcoO7tEO8CoKeo73582qp4xRU WnNw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682297984; x=1684889984; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=dedZEzpVV3Fzy4LACNNRYiAIhiGJfdYMcTU07Uabslg=; b=lwzv1imV2MgJl5ht/oVJUpu8xKkIlehmPggvubG8e7nUmsUET0QjxQl2pDrc+1IfhM BXvtYqo4cOMrEzFxhjr6EC43LyIbsKkZbsuM0yGiM+otABZapDZ62kAaRCW5Bc7iJWCC EF8LUAlI3LeTf/p1RRXlaB+1PFiUyxV9ubhw58Go4dtgdkWkMG01to7sjDkkVoM9UKRI HCNnb3yBUdP8hWj1JSUg4qXq5/V8mkKDfKl5npn3njI5r4PQJMeMKHnhD+mDiDCP5gU1 O2DTGzOO9OMB9NHpvW5Fe9fl9E4paEkqmA+J2eeKDYgsFnda1IOYH1yuo4ag/mKi0KW8 XdYA== X-Gm-Message-State: AAQBX9dIKk5r/R5jEkl24ZAJ31eXtsP+kUKMLTMgBnTc4ZcIpJ2w27Ql vSpMS+RpV7XfGMN1A6ohYsY= X-Google-Smtp-Source: AKy350ZRFz4b9URGyKJy8SPueW/NeO4z0WSpO2m0LTk0Ezk34tHKsmqbmTZmP2LYbs3rjp/t3boXgA== X-Received: by 2002:a05:622a:1355:b0:3ef:2a5:ee78 with SMTP id w21-20020a05622a135500b003ef02a5ee78mr20502473qtk.10.1682297983923; Sun, 23 Apr 2023 17:59:43 -0700 (PDT) Received: from hurd (dsl-141-20.b2b2c.ca. [66.158.141.20]) by smtp.gmail.com with ESMTPSA id f3-20020ac81343000000b003e3921077d9sm3190344qtj.38.2023.04.23.17.59.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 23 Apr 2023 17:59:43 -0700 (PDT) From: Maxim Cournoyer To: Liliana Marie Prikler Subject: Re: [PATCH 3/5] teams: Add a configure-git action. References: <878rg4snrf.fsf@gmail.com> <5b9af4fa77a89c6a4b169dc464f414b1a4166d60.camel@gmail.com> Date: Sun, 23 Apr 2023 20:59:42 -0400 In-Reply-To: <5b9af4fa77a89c6a4b169dc464f414b1a4166d60.camel@gmail.com> (Liliana Marie Prikler's message of "Sun, 23 Apr 2023 19:03:45 +0200") Message-ID: <87bkjeumbl.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 58813 Cc: ludo@gnu.org, 58813@debbugs.gnu.org, zimon.toutoune@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Liliana, Liliana Marie Prikler writes: > Am Sonntag, dem 23.04.2023 um 12:04 -0400 schrieb Maxim Cournoyer: >> * etc/git/gitconfig: Augment configuration template with useful >> options to >> allow for auto-configuration. >> * etc/teams.scm.in (configure-git): New procedure. >> (main): Register it and add documentation. > I think configure-git is somewhat out of scope inside teams.scm. We do > already tell people to set up their push hooks, so we probably ought to > solve this via documentation (or a separate dedicated script) as well. You're right that it feels a bit out of place. The other idea I had was to add it as a Makefile target. This one would have the benefit of being smart about when to re-run the command (if the gitconfig or pre-push files changed). Would that fit better? > Otherwise LGTM. OK! Thanks for weighing in. -- Thanks, Maxim From debbugs-submit-bounces@debbugs.gnu.org Sun Apr 23 22:29:41 2023 Received: (at 58813) by debbugs.gnu.org; 24 Apr 2023 02:29:41 +0000 Received: from localhost ([127.0.0.1]:47249 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pqlxV-0002NB-Fu for submit@debbugs.gnu.org; Sun, 23 Apr 2023 22:29:41 -0400 Received: from mail-qv1-f46.google.com ([209.85.219.46]:58566) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pqlxS-0002Mj-Vm for 58813@debbugs.gnu.org; Sun, 23 Apr 2023 22:29:39 -0400 Received: by mail-qv1-f46.google.com with SMTP id 6a1803df08f44-5ef524eaca1so16744046d6.0 for <58813@debbugs.gnu.org>; Sun, 23 Apr 2023 19:29:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1682303373; x=1684895373; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=J6HcZ4nkYp52LB/d0+8e12iUEyX294OI44GpjhEra+8=; b=NZcNN8yGAMVTCupMpk22csWHDy0s+aTi1QKTnuJRV5atbHwQ5AAKUTQ/JlTo9bjMiC Nsxznw9rSPpAQmrfm4aa3vEIoWLd+c1sMHPQlseTzSVzlXrmhIyQokvLO4S/ntJamG/B IgC2jvsCmFfmYJPVckntIttTAULAXJ77duPG8dE8fSk5wUW8pT6PG9TFKaON3r8/dQGd qN9ce1OgxinBpwvs+xrbareO/2tlJwc3yDuAv0AFD8v+z1XxTFH3pj1gNKaaLUuM59Vc UVnm9D02BML2M4Ld9nCXw58Hr9jt+BPEXxpD5YpTLy+VF8KyJm/KochSDEiFIVxV49Cv clpA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682303373; x=1684895373; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=J6HcZ4nkYp52LB/d0+8e12iUEyX294OI44GpjhEra+8=; b=kgKffx4N+6A8xP9nD9wqIZIP5AtoNmyATPgH5fhT/4dVVjnRuOJMpmN98HOoHWygCi FZsds5c97PITVbVHIJbfzYX8gWMRiUd8H3fx1jENqsvnOoPeEG6JJVyAjlcKJOEsLkON BdQ347yb1oiimFicLJOq8c14IU1dVr9FIa2sVBNAaWu048f0vMYcA4dXySrszzEEsowu S3Qt/WYCYyHHeWXJa9G9TW9OwHnom+2pVb/d3sIVRIHw0RXWOIHLgqBNiJzoDMVPy9oJ sKrnaHvEwNmP7ATHCzDhoVkwgqIB20qNzGrTsk850tHyB2jeLLUq4Uy+QZ5Kd6blcL48 YT2A== X-Gm-Message-State: AAQBX9dO6tVHNhkMZz2BxGQgIsqTQdmaoiZi/q5IVx+gkgldsXLo6TqY Cpr+DnQadYV6Ii+atJAxX0oBScNwidw= X-Google-Smtp-Source: AKy350bxpgkUPlXz4UKo8fq71/7fdaSeBFRXkNQLHhqoyIvGtGkq6NyHcsHvyVJDrnrPtUMHP/w86A== X-Received: by 2002:a05:6214:301a:b0:5b4:89b4:1af8 with SMTP id ke26-20020a056214301a00b005b489b41af8mr20674847qvb.16.1682303372795; Sun, 23 Apr 2023 19:29:32 -0700 (PDT) Received: from localhost.localdomain (dsl-141-20.b2b2c.ca. [66.158.141.20]) by smtp.gmail.com with ESMTPSA id a4-20020a0ce384000000b005ef658e65b8sm2986472qvl.121.2023.04.23.19.29.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 23 Apr 2023 19:29:32 -0700 (PDT) From: Maxim Cournoyer To: 58813@debbugs.gnu.org Subject: [PATCH v2 0/5] Fix teams.scm by use of a new --header-cmd git send-email option. Date: Sun, 23 Apr 2023 22:29:22 -0400 Message-Id: X-Mailer: git-send-email 2.39.2 In-Reply-To: <5b9af4fa77a89c6a4b169dc464f414b1a4166d60.camel@gmail.com> References: <5b9af4fa77a89c6a4b169dc464f414b1a4166d60.camel@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 58813 Cc: ludo@gnu.org, liliana.prikler@gmail.com, Maxim Cournoyer , zimon.toutoune@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) This v2 moves the Git autoconfiguration from teams.scm to to the build system (Automake). This has the benefit of happening on every build when necessary, further automating things and avoiding the need to remember to refresh the pre-push hooks at times. The rest is mostly unchanged except for light adjustments to the doc commit. Thanks! Maxim Cournoyer (5): gnu: git: Apply patch adding the --header-cmd feature. teams: Add 'cc-members-header-cmd' action. Makefile.am: Auto-configure Git on 'make'. teams: Add a 'cc-mentors-header-cmd' action. doc: Simplify contributing section by automating git configuration. Makefile.am | 10 ++ doc/contributing.texi | 104 +++++-------- doc/guix.texi | 2 +- etc/git/gitconfig | 15 ++ etc/teams.scm.in | 27 +++- gnu/local.mk | 1 + gnu/packages/patches/git-header-cmd.patch | 180 ++++++++++++++++++++++ gnu/packages/version-control.scm | 3 +- 8 files changed, 265 insertions(+), 77 deletions(-) create mode 100644 gnu/packages/patches/git-header-cmd.patch base-commit: 5b545763ed9b8a3fade7f756d543819fc090953f -- 2.39.2 From debbugs-submit-bounces@debbugs.gnu.org Sun Apr 23 22:29:46 2023 Received: (at 58813) by debbugs.gnu.org; 24 Apr 2023 02:29:46 +0000 Received: from localhost ([127.0.0.1]:47254 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pqlxZ-0002NV-Ol for submit@debbugs.gnu.org; Sun, 23 Apr 2023 22:29:46 -0400 Received: from mail-qk1-f177.google.com ([209.85.222.177]:62922) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pqlxU-0002Ml-29 for 58813@debbugs.gnu.org; Sun, 23 Apr 2023 22:29:40 -0400 Received: by mail-qk1-f177.google.com with SMTP id af79cd13be357-74ab718c344so1101315785a.1 for <58813@debbugs.gnu.org>; Sun, 23 Apr 2023 19:29:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1682303374; x=1684895374; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=3/nTDL5epv8LH7Zhp/PfgpNw44gpnaIU3KvJ9LYeRzs=; b=PE5eJp6EDJWulkmiX5x5c2AOtaILG+z/cw3Jn6v0I+Yx5KGxVmErGnJm4mdiyRmBIS HM8FK+V3pWLkyGjVoT8fD8cNL9mvJ9VP4EFIGfDzYeYBKAEd6ecFoCgQtGB0KlbFsyBz fZHHhUFRkfP6aVlBNcgEdh/DqEkZiVi9LdsZc/m9CTeCQi8ZiWSsJNIpaHJtMMantLUp 0ESvBNXhCMUNLzv8WH2Gi0KlJhsYrCi3ZSJCLztHBvms2X9U24nQbl7MBRoX2AcdpgSn h3ZECM8k7tMPMLIQWEF5ziT0n53WtU0UWWIbGr7sCsXXOLv1fsqYp32jlIz7E+jwcWVx Hejw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682303374; x=1684895374; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=3/nTDL5epv8LH7Zhp/PfgpNw44gpnaIU3KvJ9LYeRzs=; b=WEEMd5Mc266ok4IOVlIIoJG9zeynzSF5/hCPrE6PFgC24ZcxrL9C3v7rIzPpx9Rlfl c+b5drU3zUOiOUCR4SnFusoEG5Lren7XL0OivySmVxrrSlP9b181Ml15bej7NMl2jLdb 4hF1pomwwggTQoO+p04nLLbelN/aaaIdF/u1YcJsyzd8I/GQ92QbmFAoN8F4MsnAttUH X+0s/tKkDsMyoMMLtlt4ZxMTNvLZsbmrxWSTIRJeAYvhDsSkivQc+y4VDYbklMdoyV/A dinGktnzZtMEnbEr9VPRsxASt0thZkKMDgWv3rckKBIKUSGrqEx9Nv+ky4pLDkXjfj0w bQeQ== X-Gm-Message-State: AAQBX9emQ5/vzALnDVnrufguXnodf2l7N+r3TNBRlm35QzmHRng6EaZz Nj0aSArj9NeVBMQvFls14cxlbYxnBGQ= X-Google-Smtp-Source: AKy350YYZ4n9FOCKzekj6cGX1fohm+Qk61gCNZt+w3zGXNmbj3e3Ahil4cz6M1Cq5IGqIM7b7ldYTQ== X-Received: by 2002:ad4:596d:0:b0:5ef:6103:1475 with SMTP id eq13-20020ad4596d000000b005ef61031475mr20634529qvb.20.1682303374183; Sun, 23 Apr 2023 19:29:34 -0700 (PDT) Received: from localhost.localdomain (dsl-141-20.b2b2c.ca. [66.158.141.20]) by smtp.gmail.com with ESMTPSA id a4-20020a0ce384000000b005ef658e65b8sm2986472qvl.121.2023.04.23.19.29.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 23 Apr 2023 19:29:33 -0700 (PDT) From: Maxim Cournoyer To: 58813@debbugs.gnu.org Subject: [PATCH v2 1/5] gnu: git: Apply patch adding the --header-cmd feature. Date: Sun, 23 Apr 2023 22:29:23 -0400 Message-Id: <2899162d279cdd940bc91459b38ff1e2c3f4f0ec.1682303142.git.maxim.cournoyer@gmail.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <5b9af4fa77a89c6a4b169dc464f414b1a4166d60.camel@gmail.com> References: <5b9af4fa77a89c6a4b169dc464f414b1a4166d60.camel@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 58813 Cc: ludo@gnu.org, liliana.prikler@gmail.com, Maxim Cournoyer , zimon.toutoune@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) In preparation to fix . * gnu/packages/patches/git-header-cmd.patch: New file. * gnu/local.mk (dist_patch_DATA): Register it. * gnu/packages/version-control.scm (git) [source]: Apply patch. --- gnu/local.mk | 1 + gnu/packages/patches/git-header-cmd.patch | 180 ++++++++++++++++++++++ gnu/packages/version-control.scm | 3 +- 3 files changed, 183 insertions(+), 1 deletion(-) create mode 100644 gnu/packages/patches/git-header-cmd.patch diff --git a/gnu/local.mk b/gnu/local.mk index b631fa6d5a..d7c7ca48e7 100644 --- a/gnu/local.mk +++ b/gnu/local.mk @@ -1209,6 +1209,7 @@ dist_patch_DATA = \ %D%/packages/patches/gemmi-fix-sajson-types.patch \ %D%/packages/patches/genimage-mke2fs-test.patch \ %D%/packages/patches/geoclue-config.patch \ + %D%/packages/patches/git-header-cmd.patch \ %D%/packages/patches/ghc-8.0-fall-back-to-madv_dontneed.patch \ %D%/packages/patches/ghc-9.2-glibc-2.33-link-order.patch \ %D%/packages/patches/ghc-testsuite-dlopen-pie.patch \ diff --git a/gnu/packages/patches/git-header-cmd.patch b/gnu/packages/patches/git-header-cmd.patch new file mode 100644 index 0000000000..fdd34fe4a4 --- /dev/null +++ b/gnu/packages/patches/git-header-cmd.patch @@ -0,0 +1,180 @@ +Add a '--header-cmd' to git send-email. + +Upstream status can be tracked at: +https://lore.kernel.org/git/20230423122744.4865-1-maxim.cournoyer@gmail.com/T/#t + +diff --git a/Documentation/config/sendemail.txt b/Documentation/config/sendemail.txt +index 51da7088a8..3d0f516520 100644 +--- a/Documentation/config/sendemail.txt ++++ b/Documentation/config/sendemail.txt +@@ -58,6 +58,7 @@ sendemail.annotate:: + sendemail.bcc:: + sendemail.cc:: + sendemail.ccCmd:: ++sendemail.headerCmd:: + sendemail.chainReplyTo:: + sendemail.envelopeSender:: + sendemail.from:: +diff --git a/Documentation/git-send-email.txt b/Documentation/git-send-email.txt +index b0f438ec99..354c0d06db 100644 +--- a/Documentation/git-send-email.txt ++++ b/Documentation/git-send-email.txt +@@ -320,6 +320,11 @@ Automating + Output of this command must be single email address per line. + Default is the value of `sendemail.ccCmd` configuration value. + ++--header-cmd=:: ++ Specify a command to execute once per patch file which should ++ generate arbitrary, patch file specific header entries. ++ Default is the value of `sendemail.headerCmd` configuration value. ++ + --[no-]chain-reply-to:: + If this is set, each email will be sent as a reply to the previous + email sent. If disabled with "--no-chain-reply-to", all emails after +diff --git a/git-send-email.perl b/git-send-email.perl +index fd8cd0d46f..676dd83d89 100755 +--- a/git-send-email.perl ++++ b/git-send-email.perl +@@ -2,6 +2,7 @@ + # + # Copyright 2002,2005 Greg Kroah-Hartman + # Copyright 2005 Ryan Anderson ++# Copyright 2023 Maxim Cournoyer + # + # GPL v2 (See COPYING) + # +@@ -87,8 +88,9 @@ sub usage { + + Automating: + --identity * Use the sendemail. options. +- --to-cmd * Email To: via ` \$patch_path` +- --cc-cmd * Email Cc: via ` \$patch_path` ++ --to-cmd * Email To: via ` \$patch_path`. ++ --cc-cmd * Email Cc: via ` \$patch_path`. ++ --header-cmd * Add headers via ` \$patch_path`. + --suppress-cc * author, self, sob, cc, cccmd, body, bodycc, misc-by, all. + --[no-]cc-cover * Email Cc: addresses in the cover letter. + --[no-]to-cover * Email To: addresses in the cover letter. +@@ -269,7 +271,7 @@ sub do_edit { + # Variables with corresponding config settings + my ($suppress_from, $signed_off_by_cc); + my ($cover_cc, $cover_to); +-my ($to_cmd, $cc_cmd); ++my ($to_cmd, $cc_cmd, $header_cmd); + my ($smtp_server, $smtp_server_port, @smtp_server_options); + my ($smtp_authuser, $smtp_encryption, $smtp_ssl_cert_path); + my ($batch_size, $relogin_delay); +@@ -318,6 +320,7 @@ sub do_edit { + "tocmd" => \$to_cmd, + "cc" => \@config_cc, + "cccmd" => \$cc_cmd, ++ "headercmd" => \$header_cmd, + "aliasfiletype" => \$aliasfiletype, + "bcc" => \@config_bcc, + "suppresscc" => \@suppress_cc, +@@ -519,6 +522,7 @@ sub config_regexp { + "compose" => \$compose, + "quiet" => \$quiet, + "cc-cmd=s" => \$cc_cmd, ++ "header-cmd=s" => \$header_cmd, + "suppress-from!" => \$suppress_from, + "no-suppress-from" => sub {$suppress_from = 0}, + "suppress-cc=s" => \@suppress_cc, +@@ -1776,6 +1780,9 @@ sub process_file { + push(@header, $_); + } + } ++ # Add computed headers, if applicable. ++ push @header, execute_cmd("header-cmd", $header_cmd, $t) ++ if defined $header_cmd; + # Now parse the header + foreach(@header) { + if (/^From /) { +@@ -2006,15 +2013,30 @@ sub process_file { + } + } + ++# Execute a command (e.g., $x_cmd) and return its output lines as an ++# array. ++sub execute_cmd { ++ my ($prefix, $cmd, $file) = @_; ++ my @lines = (); ++ open my $fh, "-|", "$cmd \Q$file\E" ++ or die sprintf(__("(%s) Could not execute '%s'"), $prefix, $cmd); ++ while (my $line = <$fh>) { ++ last if $line =~ /^$/; ++ push @lines, $line; ++ } ++ close $fh ++ or die sprintf(__("(%s) failed to close pipe to '%s'"), $prefix, $cmd); ++ return @lines; ++} ++ + # Execute a command (e.g. $to_cmd) to get a list of email addresses + # and return a results array + sub recipients_cmd { + my ($prefix, $what, $cmd, $file) = @_; +- ++ my @lines = (); + my @addresses = (); +- open my $fh, "-|", "$cmd \Q$file\E" +- or die sprintf(__("(%s) Could not execute '%s'"), $prefix, $cmd); +- while (my $address = <$fh>) { ++ @lines = execute_cmd($prefix, $cmd, $file); ++ for my $address (@lines) { + $address =~ s/^\s*//g; + $address =~ s/\s*$//g; + $address = sanitize_address($address); +@@ -2023,8 +2045,6 @@ sub recipients_cmd { + printf(__("(%s) Adding %s: %s from: '%s'\n"), + $prefix, $what, $address, $cmd) unless $quiet; + } +- close $fh +- or die sprintf(__("(%s) failed to close pipe to '%s'"), $prefix, $cmd); + return @addresses; + } + +diff --git a/t/t9001-send-email.sh b/t/t9001-send-email.sh +index 0de83b5d2b..3393725107 100755 +--- a/t/t9001-send-email.sh ++++ b/t/t9001-send-email.sh +@@ -374,13 +374,16 @@ test_expect_success $PREREQ,!AUTOIDENT 'broken implicit ident aborts send-email' + ) + ' + +-test_expect_success $PREREQ 'setup tocmd and cccmd scripts' ' ++test_expect_success $PREREQ 'setup cmd scripts' ' + write_script tocmd-sed <<-\EOF && + sed -n -e "s/^tocmd--//p" "$1" + EOF +- write_script cccmd-sed <<-\EOF ++ write_script cccmd-sed <<-\EOF && + sed -n -e "s/^cccmd--//p" "$1" + EOF ++ write_script headercmd-sed <<-\EOF ++ sed -n -e "s/^headercmd--//p" "$1" ++ EOF + ' + + test_expect_success $PREREQ 'tocmd works' ' +@@ -410,6 +413,20 @@ test_expect_success $PREREQ 'cccmd works' ' + grep "^ cccmd@example.com" msgtxt1 + ' + ++test_expect_success $PREREQ 'headercmd works' ' ++ clean_fake_sendmail && ++ cp $patches headercmd.patch && ++ echo "headercmd--X-Debbugs-CC: dummy@example.com" >>headercmd.patch && ++ git send-email \ ++ --from="Example " \ ++ --to=nobody@example.com \ ++ --header-cmd=./headercmd-sed \ ++ --smtp-server="$(pwd)/fake.sendmail" \ ++ headercmd.patch \ ++ && ++ grep "^X-Debbugs-CC: dummy@example.com" msgtxt1 ++' ++ + test_expect_success $PREREQ 'reject long lines' ' + z8=zzzzzzzz && + z64=$z8$z8$z8$z8$z8$z8$z8$z8 && diff --git a/gnu/packages/version-control.scm b/gnu/packages/version-control.scm index 302f7c90ad..d5d88b99ed 100644 --- a/gnu/packages/version-control.scm +++ b/gnu/packages/version-control.scm @@ -232,7 +232,8 @@ (define-public git version ".tar.xz")) (sha256 (base32 - "1mpjvhyw8mv2q941xny4d0gw3mb6b4bqaqbh73jd8b1v6zqpaps7")))) + "1mpjvhyw8mv2q941xny4d0gw3mb6b4bqaqbh73jd8b1v6zqpaps7")) + (patches (search-patches "git-header-cmd.patch")))) (build-system gnu-build-system) (native-inputs `(("native-perl" ,perl) -- 2.39.2 From debbugs-submit-bounces@debbugs.gnu.org Sun Apr 23 22:29:46 2023 Received: (at 58813) by debbugs.gnu.org; 24 Apr 2023 02:29:47 +0000 Received: from localhost ([127.0.0.1]:47256 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pqlxa-0002Ne-FY for submit@debbugs.gnu.org; Sun, 23 Apr 2023 22:29:46 -0400 Received: from mail-qv1-f46.google.com ([209.85.219.46]:44370) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pqlxV-0002Mn-1F for 58813@debbugs.gnu.org; Sun, 23 Apr 2023 22:29:41 -0400 Received: by mail-qv1-f46.google.com with SMTP id 6a1803df08f44-5ef6197ea51so17513516d6.1 for <58813@debbugs.gnu.org>; Sun, 23 Apr 2023 19:29:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1682303375; x=1684895375; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=cIhYiIUaQDph7ac25C7KgmtaG8U7VaxgDQchW0D5RXE=; b=UnG/FXER1zY122WBUjVNtzUH6SbKAtPkAQKj1FOtLSxH4dKIXQpMrGXGulkYTs/CWU PSngd2Tv1QXJAWCDse4bulYFLTcO9pr+hURikslzAWh1QVK0bW6SBLn5qQG0qyhvNsBK H4FoA3aimsBv6FPRwI0LNHTcHth+By802ylmBy09t2HnD38+70nvPrRiMHA8DqN06tTW zbdbQ/TfRWhfg64yLTGnqS/Kzy1dZmbYHRiinutvCtyuK9ajAYhHQUuOBwOKfafhWMEN zOS7+/jZQaC3SeAB9o1MSbmRvIes+E2hPi6mke4dgvAnTAgGS8pm2Fj9DiERpkVOxImj Xv8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682303375; x=1684895375; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=cIhYiIUaQDph7ac25C7KgmtaG8U7VaxgDQchW0D5RXE=; b=geNzEKdtZbkvHf2DZ5JAPSjzbzDFJy2ZXpggpzFluQm/rqq6WpdDA5yaTkPCqMs7Tv CVy/puPAoKP0qErWvekomctBR6WTOYG/G11YbYtfnUTF+xtEZXb++H6DzxSGlFB0TSEt FLWl+bNzdkxaCt91JrEsfSjlRhSdjbWx6ht/iuAoipvtKdMqmYpJdNCFwvaFuljIneGv U1Y2ZlFzrX8xnKdhpWZm8gl5u9y+5J2ZlN6v++cazmKpnZb3aGtd21SCQQf7K/o/fXKu 7YzO4S41P2Qp8Ya3/+uMRPisESM0oeT1XR0j+4/00MiBxKwoxxyJCv4+XSk0Y5+hl3IO +LZw== X-Gm-Message-State: AAQBX9eEf/+lr8pJx/l8elaMwJksUJLZwmvgjegM4lxRktOWLjV5VU4J Bu4R1iJwsMFo94iWQFQN/J4SFuXX2yU= X-Google-Smtp-Source: AKy350Yrmd1hEHxtB2XhAyEClmnlnLC5lbJM5Kaz9qATD8WIRgh2m2j5ewVQFbntpoNW1spgXZZCIw== X-Received: by 2002:a05:6214:2305:b0:5ef:9b22:dc88 with SMTP id gc5-20020a056214230500b005ef9b22dc88mr22119190qvb.0.1682303375397; Sun, 23 Apr 2023 19:29:35 -0700 (PDT) Received: from localhost.localdomain (dsl-141-20.b2b2c.ca. [66.158.141.20]) by smtp.gmail.com with ESMTPSA id a4-20020a0ce384000000b005ef658e65b8sm2986472qvl.121.2023.04.23.19.29.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 23 Apr 2023 19:29:35 -0700 (PDT) From: Maxim Cournoyer To: 58813@debbugs.gnu.org Subject: [PATCH v2 2/5] teams: Add 'cc-members-header-cmd' action. Date: Sun, 23 Apr 2023 22:29:24 -0400 Message-Id: <2c8e1e7fe43d6460f3cc4c2b77d649e109030eb3.1682303142.git.maxim.cournoyer@gmail.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <5b9af4fa77a89c6a4b169dc464f414b1a4166d60.camel@gmail.com> References: <5b9af4fa77a89c6a4b169dc464f414b1a4166d60.camel@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 58813 Cc: ludo@gnu.org, liliana.prikler@gmail.com, Maxim Cournoyer , zimon.toutoune@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) * etc/teams.scm.in (patch->teams): New procedure. (main): Use it. Add a new "cc-members-header-cmd" command; document it. --- etc/teams.scm.in | 20 +++++++++++++++----- 1 file changed, 15 insertions(+), 5 deletions(-) diff --git a/etc/teams.scm.in b/etc/teams.scm.in index 37a3c8e191..408db8b7d5 100644 --- a/etc/teams.scm.in +++ b/etc/teams.scm.in @@ -5,7 +5,7 @@ ;;; GNU Guix --- Functional package management for GNU ;;; Copyright © 2022, 2023 Ricardo Wurmus ;;; Copyright © 2022 Mathieu Othacehe -;;; Copyright © 2022 Maxim Cournoyer +;;; Copyright © 2022, 2023 Maxim Cournoyer ;;; ;;; This file is part of GNU Guix. ;;; @@ -696,6 +696,12 @@ (define (git-patch->revisions file) (rev-start (string-append rev-end "^"))) (list rev-start rev-end))) +(define (patch->teams patch-file) + "Return the name of the teams in scope for the changes in PATCH-FILE." + (map (compose symbol->string team-id) + (find-team-by-scope (apply diff-revisions + (git-patch->revisions patch-file))))) + (define (main . args) (match args @@ -708,11 +714,13 @@ (define (main . args) (("cc-members" rev-start rev-end) (apply cc (find-team-by-scope (diff-revisions rev-start rev-end)))) + (("cc-members-header-cmd" patch-file) + (for-each (lambda (team-name) + (list-members (find-team team-name) (current-output-port) + "X-Debbugs-Cc: ")) + (patch->teams patch-file))) (("get-maintainer" patch-file) - (apply main "list-members" - (map (compose symbol->string team-id) - (find-team-by-scope (apply diff-revisions - (git-patch->revisions patch-file)))))) + (apply main "list-members" (patch->teams patch-file))) (("list-teams" . args) (list-teams)) (("list-members" . team-names) @@ -729,6 +737,8 @@ (define (main . args) get git send-email flags for cc-ing cc-members | patch cc teams related to files changed between revisions or in a patch file + cc-members-header-cmd + cc-members variant for use with 'git send-email --header-cmd' list-teams list teams and their members list-members -- 2.39.2 From debbugs-submit-bounces@debbugs.gnu.org Sun Apr 23 22:29:47 2023 Received: (at 58813) by debbugs.gnu.org; 24 Apr 2023 02:29:47 +0000 Received: from localhost ([127.0.0.1]:47258 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pqlxa-0002Nl-SX for submit@debbugs.gnu.org; Sun, 23 Apr 2023 22:29:47 -0400 Received: from mail-qv1-f53.google.com ([209.85.219.53]:57510) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pqlxW-0002Mp-Au for 58813@debbugs.gnu.org; Sun, 23 Apr 2023 22:29:42 -0400 Received: by mail-qv1-f53.google.com with SMTP id 6a1803df08f44-5f3da4f91a0so17190836d6.2 for <58813@debbugs.gnu.org>; Sun, 23 Apr 2023 19:29:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1682303376; x=1684895376; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=oEcUNFajXOLCspoU6kH+1kUaPdSj09TtprsHdAJc+/4=; b=ce89TBs6AS7VxBVX7igl5URT+GPdOmXJj7qepcFZByAyf/GU+1Lgl10mmMfiFNx+hs 5Y4vGP43HOqyUFt3bss8kcxvJH/tiAQ4Ni6oZgOCugmcVeL41iRI2VJvpcaGE0tJxpxE JIOyCMoLW8YE1xridwPGAzJ0mjvfYJoYnZt3+xt/qZq/QGjG2IvnNElNsyGGAamERKTX KHZYSGCnk18WMIDPqOrtXF7u1rBCnUl2BviFeicdFvdzrgewbd8is7QygW6V7ObIqkJ7 myLJudZLuFwGjqYyOcKkKBjUPnYjYfFCQb+00zr0PzhqTPrEjmHBeB53DF56xlpQkFVO 5Q4g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682303376; x=1684895376; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=oEcUNFajXOLCspoU6kH+1kUaPdSj09TtprsHdAJc+/4=; b=Qo7F9YpKA3xL3fE49aTXcrKDULbERKMflE6hx/CTj0QDPBfEsglY0VRiFNoFUHY/eJ 3n+TUTc90WqHIHNA3xO95digtD2ceBvYO2z2U+BHO2sE4+fLaV7wbimg9AH4PiojcuqI 0vQ2M4NLoO1sUfSWGyBv7qjSsRwulSHiiA3oyBTtd1eUNjvfjD6bFx7C+pz8tjJN8Kki Zi6JTUAn2gWh2S6sBeshRlvSo5ZCWAAoNd5Twm5SjGvnqd3TFYGZCbLLwylEfOYMzRYK W0FqyaCMlvQFovTsKgG0BgtsFc1QJEIXJS1064AU/MkcRhnUSr7b++s5BDbkHSTmLA9S 3p7g== X-Gm-Message-State: AAQBX9fGjsfKpsBFmNsrOd4lVKeBwCMt/0M+GxTEh5Z4jCETaGbkPiIt MYFjAaKOjUc0USat0TlpFi/GMTaRyT4= X-Google-Smtp-Source: AKy350Y0nj4wFZRkKYsNnLjsu5kAUuE2HwTg9sIy/0VvNzBIqCKxju4nz+HJsDBn9vBHkg/7yZzNRw== X-Received: by 2002:a05:6214:20c9:b0:5ef:4c7a:f63d with SMTP id 9-20020a05621420c900b005ef4c7af63dmr21374608qve.0.1682303376636; Sun, 23 Apr 2023 19:29:36 -0700 (PDT) Received: from localhost.localdomain (dsl-141-20.b2b2c.ca. [66.158.141.20]) by smtp.gmail.com with ESMTPSA id a4-20020a0ce384000000b005ef658e65b8sm2986472qvl.121.2023.04.23.19.29.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 23 Apr 2023 19:29:36 -0700 (PDT) From: Maxim Cournoyer To: 58813@debbugs.gnu.org Subject: [PATCH v2 3/5] Makefile.am: Auto-configure Git on 'make'. Date: Sun, 23 Apr 2023 22:29:25 -0400 Message-Id: X-Mailer: git-send-email 2.39.2 In-Reply-To: <5b9af4fa77a89c6a4b169dc464f414b1a4166d60.camel@gmail.com> References: <5b9af4fa77a89c6a4b169dc464f414b1a4166d60.camel@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 58813 Cc: ludo@gnu.org, liliana.prikler@gmail.com, Maxim Cournoyer , zimon.toutoune@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) This means we do not need to worry anymore about manually syncing the pre-push git hook or the Guix-provided git configuration. * etc/git/gitconfig: Augment configuration template with useful options to allow for auto-configuration. * Makefile.am (.git/hooks/pre-push, .git/config): New targets. (nodist_noinst_DATA): New primary variable holding the above targets. --- Makefile.am | 10 ++++++++++ etc/git/gitconfig | 15 +++++++++++++++ 2 files changed, 25 insertions(+) diff --git a/Makefile.am b/Makefile.am index 23b939b674..7daa7d66f7 100644 --- a/Makefile.am +++ b/Makefile.am @@ -14,6 +14,7 @@ # Copyright © 2018 Oleg Pykhalov # Copyright © 2018 Alex Vong # Copyright © 2019 Efraim Flashner +# Copyright © 2020, 2021, 2023 Maxim Cournoyer # Copyright © 2021 Chris Marusich # Copyright © 2021 Andrew Tropin # @@ -1109,6 +1110,15 @@ cuirass-jobs: $(GOBJECTS) .PHONY: clean-go make-go as-derivation authenticate .PHONY: update-guix-package update-NEWS cuirass-jobs release +# Git auto-configuration. +.git/hooks/pre-push: etc/git/pre-push + cp etc/git/pre-push .git/hooks/pre-push + +.git/config: etc/git/gitconfig + git config include.path ../etc/git/gitconfig + +nodist_noinst_DATA = .git/hooks/pre-push .git/config + # Downloading up-to-date PO files. WEBLATE_REPO = https://framagit.org/tyreunom/guix-translations diff --git a/etc/git/gitconfig b/etc/git/gitconfig index c9ebdc8fa8..0b6984a05f 100644 --- a/etc/git/gitconfig +++ b/etc/git/gitconfig @@ -1,5 +1,20 @@ +[commit] + gpgsign = true + [diff "scheme"] xfuncname = "^(\\(define.*)$" [diff "texinfo"] xfuncname = "^@node[[:space:]]+([^,]+).*$" + +[format] + useAutoBase = true + thread = shallow + +[pull] + rebase = true + +[sendemail] + to = guix-patches@gnu.org + headerCmd = etc/teams.scm cc-members-header-cmd + thread = no -- 2.39.2 From debbugs-submit-bounces@debbugs.gnu.org Sun Apr 23 22:29:47 2023 Received: (at 58813) by debbugs.gnu.org; 24 Apr 2023 02:29:47 +0000 Received: from localhost ([127.0.0.1]:47260 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pqlxb-0002Nt-9s for submit@debbugs.gnu.org; Sun, 23 Apr 2023 22:29:47 -0400 Received: from mail-qv1-f42.google.com ([209.85.219.42]:60472) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pqlxX-0002Mr-Lz for 58813@debbugs.gnu.org; Sun, 23 Apr 2023 22:29:43 -0400 Received: by mail-qv1-f42.google.com with SMTP id 6a1803df08f44-5ef6e0f9d5aso40795086d6.0 for <58813@debbugs.gnu.org>; Sun, 23 Apr 2023 19:29:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1682303378; x=1684895378; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=hbK0W1GDZW8nf3dBzJY4ue6x7VgQcOa0vygjfQGmlTo=; b=O2IYmIXLPrDPZrhK8DKRCCH0cJD3sp+1qW9KGr5vrRa7rnQgg3CDD2DeSF0jdazh2g OBUu3j6ZxThn0Q/omdpD47BAMPremdVL2hNIhwSKqVQhuxH2+ZWkAZsSzEn895NDpWp2 G8S953lqX3bC3bUTvcwkdEzZFuc+uHuDYLvsBxueBhfXXuLEpEGsu4A55oCkHPAO3GS8 D9SjCHmTUoxfs4XnM7SUVU2M8Zjx4xjBRJaNLjCmWR2GnOklC4oF0OKTxc7LhQBVrego 1vpFvUYA7fyFsMbWp6KvDTc92KKel3uMuqUcT8xkIlaMKDVwnehOV/wVAHNJoVKFu2t6 RFCQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682303378; x=1684895378; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=hbK0W1GDZW8nf3dBzJY4ue6x7VgQcOa0vygjfQGmlTo=; b=elHBTCVmjW6l2XUY149gWdAPJKkTVEhMSjjc7mMf/MdvoKL31V2ITuW4YucJGlWFe/ kdhxoaDoDuAypPP35sx64FWtWslS76rASdh3xTK7hTtdzbfdFr5MERFWmqYByc9876+c N7bYMqAjhua0OMaj5ISOZ89LCejdMnRSsb5YeZWx12wIow8kSbafhJ/W0dL7oKAi+l39 uZNq+aL4GJisAxL9equdHHbSrSDGe1ra8ds/CyGYUPLU8SfSO/0HWQ7LviCt44jY82pG QJperGrs6omXHwkIsQFQLu75qWFTcTXgQv3kEWXXPVaEQbRfyt6mklvfmxBJZGYJ1If3 OKIQ== X-Gm-Message-State: AAQBX9eBm2piICpoB3sB/KVg9qddiP47KBROesdz87MuDF+s28upRLY7 BEsyiZC3igWf0h63FSnbnkYm7A9A4HA= X-Google-Smtp-Source: AKy350a7YtCTFnpneVuo5RBSiObpp3SauLJnt2++l9CKj/iarMSf5OSfHAZ+x0MX/g0SPCXHz4msPQ== X-Received: by 2002:a05:6214:400a:b0:5ac:d877:43c1 with SMTP id kd10-20020a056214400a00b005acd87743c1mr20852180qvb.40.1682303378007; Sun, 23 Apr 2023 19:29:38 -0700 (PDT) Received: from localhost.localdomain (dsl-141-20.b2b2c.ca. [66.158.141.20]) by smtp.gmail.com with ESMTPSA id a4-20020a0ce384000000b005ef658e65b8sm2986472qvl.121.2023.04.23.19.29.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 23 Apr 2023 19:29:37 -0700 (PDT) From: Maxim Cournoyer To: 58813@debbugs.gnu.org Subject: [PATCH v2 4/5] teams: Add a 'cc-mentors-header-cmd' action. Date: Sun, 23 Apr 2023 22:29:26 -0400 Message-Id: <1a5566c93d704bdf487bfebc5862483f05bebbe9.1682303142.git.maxim.cournoyer@gmail.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <5b9af4fa77a89c6a4b169dc464f414b1a4166d60.camel@gmail.com> References: <5b9af4fa77a89c6a4b169dc464f414b1a4166d60.camel@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 58813 Cc: ludo@gnu.org, liliana.prikler@gmail.com, Maxim Cournoyer , zimon.toutoune@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) * etc/teams.scm.in (main): Register a new "cc-mentors-header-cmd" action. Document it. --- etc/teams.scm.in | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/etc/teams.scm.in b/etc/teams.scm.in index 408db8b7d5..dec175f630 100644 --- a/etc/teams.scm.in +++ b/etc/teams.scm.in @@ -719,6 +719,9 @@ (define (main . args) (list-members (find-team team-name) (current-output-port) "X-Debbugs-Cc: ")) (patch->teams patch-file))) + (("cc-mentors-header-cmd" patch-file) + (list-members (find-team "mentors") (current-output-port) + "X-Debbugs-Cc: ")) (("get-maintainer" patch-file) (apply main "list-members" (patch->teams patch-file))) (("list-teams" . args) @@ -735,10 +738,12 @@ (define (main . args) Commands: cc get git send-email flags for cc-ing - cc-members | patch + cc-members | cc teams related to files changed between revisions or in a patch file cc-members-header-cmd cc-members variant for use with 'git send-email --header-cmd' + cc-mentors-header-cmd + command to use with 'git send-email --header-cmd' to notify mentors list-teams list teams and their members list-members -- 2.39.2 From debbugs-submit-bounces@debbugs.gnu.org Sun Apr 23 22:29:57 2023 Received: (at 58813) by debbugs.gnu.org; 24 Apr 2023 02:29:57 +0000 Received: from localhost ([127.0.0.1]:47262 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pqlxk-0002OD-Nm for submit@debbugs.gnu.org; Sun, 23 Apr 2023 22:29:57 -0400 Received: from mail-qv1-f43.google.com ([209.85.219.43]:45170) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pqlxY-0002My-Vu for 58813@debbugs.gnu.org; Sun, 23 Apr 2023 22:29:45 -0400 Received: by mail-qv1-f43.google.com with SMTP id 6a1803df08f44-5ef50358a7aso17582826d6.2 for <58813@debbugs.gnu.org>; Sun, 23 Apr 2023 19:29:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1682303379; x=1684895379; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=p24zlu90GN394VEiyJM5NYz0RdfImyXF7Zs5jWkYeuY=; b=FQqszb9MtfxDr1oIdZPEzF+PTckItIZmAA5WZv7R5N1V6vujJzXugbto1Bichg5eYl oG+loWd0DDRix3q08i48NamV/GNUxrIGF98PzGxY9tKwkGvBjlCEkX6845f4+ETFLdGV XyemKkOkRux4cYB9czYYiIkOJOG2VejKktij7l1UUtEojfvehmqfW3r+KhFtI8nv5DIg u2zvIVIWMHoTCjTbKM4yrpm9G4Er2D44nmJSLBsPEHIEZ4/1BYbXuiIH7WWOqRPkFySw ss6TGo0l779c4zWkt6NiM7XpBypz/tvsiYRR4zng7ODcW0FUsgdLC+EKhmpnkqSgQNh2 /KfQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682303379; x=1684895379; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=p24zlu90GN394VEiyJM5NYz0RdfImyXF7Zs5jWkYeuY=; b=UTq1+w/L8w6M7IqoLg5UyMrI9KXnlDrjino9frVLiVclowc2tbialwIz5dB103DJDK XRrqvmt+TpZ3PACeaYzNLO8VKGe5jDQUacrM4PMfOUliuNIK6X2GTuA+XH8VDshku9K/ 1TQiJXcYxmaVr1f/CyGpik91SEdd1Jw4edDOMci8L6gb4HaPJxLqwRp9sk3odP0LfQzV 3jIwBoFLqeQoTnAzZg5IFQgNtCdUpZQlqhfHpD5z2U6BCF/8R9P1fGNx9ev3P2WEsbuA 7KWh7l1qGZQ9xetWKRDz9pMU/3CWSbHiDW1auoTLWADcQHNJkRff8wnLqj4c3AcdV9x1 9Zog== X-Gm-Message-State: AAQBX9d53ioLo8MjFArl7b8pleB1SDEpzEg+AcR5eSmh6v7eQJAZyx+Y JA2tokfxawJJ8bSl7DRm1eUoNSNaqh0= X-Google-Smtp-Source: AKy350aCkSnrd8ydtvQC3L+zPzNfmZst/xzXbWsIx/UW8/rnbt52Ojw33NgHOyiv4C+hyNMgm7LPBQ== X-Received: by 2002:a05:6214:4111:b0:5ef:519:b27 with SMTP id kc17-20020a056214411100b005ef05190b27mr20647807qvb.35.1682303379248; Sun, 23 Apr 2023 19:29:39 -0700 (PDT) Received: from localhost.localdomain (dsl-141-20.b2b2c.ca. [66.158.141.20]) by smtp.gmail.com with ESMTPSA id a4-20020a0ce384000000b005ef658e65b8sm2986472qvl.121.2023.04.23.19.29.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 23 Apr 2023 19:29:38 -0700 (PDT) From: Maxim Cournoyer To: 58813@debbugs.gnu.org Subject: [PATCH v2 5/5] doc: Simplify contributing section by automating git configuration. Date: Sun, 23 Apr 2023 22:29:27 -0400 Message-Id: <8f46ecccc4343c24e9fc0d8b9c8cf5504ef2601d.1682303142.git.maxim.cournoyer@gmail.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <5b9af4fa77a89c6a4b169dc464f414b1a4166d60.camel@gmail.com> References: <5b9af4fa77a89c6a4b169dc464f414b1a4166d60.camel@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 58813 Cc: ludo@gnu.org, liliana.prikler@gmail.com, Maxim Cournoyer , zimon.toutoune@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Fixes . No longer suggests to splice the output of etc/teams.scm commands into the 'git send-email' command line; this is now transparently handled by the Git configuration, which is also automatic. * doc/contributing.texi (Configuring Git): Streamline section, now automated via Automake. (Sending a Patch Series): Do not specify options configured as default by the above. Prefer long option names, for readability. (Teams): Rewrite the examples to use --header-cmd. (Commit Access): Refer to the Configuring Git section instead of detailing manual steps. --- doc/contributing.texi | 104 ++++++++++++++---------------------------- doc/guix.texi | 2 +- 2 files changed, 36 insertions(+), 70 deletions(-) diff --git a/doc/contributing.texi b/doc/contributing.texi index 73d1cd2648..b13531c5cc 100644 --- a/doc/contributing.texi +++ b/doc/contributing.texi @@ -1395,28 +1395,8 @@ Configuring Git use @command{git config --local}, or edit @file{.git/config} in the repository instead of @file{~/.gitconfig}. -We provide some default settings in @file{etc/git/gitconfig} which -modify how patches are generated, making them easier to read and apply. -These settings can be applied by manually copying them to -@file{.git/config} in your checkout, or by telling Git to include the -whole file: - -@example -git config --local include.path ../etc/git/gitconfig -@end example - -From then on, any changes to @file{etc/git/gitconfig} would -automatically take effect. - -Since the first patch in a series must be sent separately -(@pxref{Sending a Patch Series}), it can also be helpful to tell -@command{git format-patch} to handle the e-mail threading instead of -@command{git send-email}: - -@example -git config --local format.thread shallow -git config --local sendemail.thread no -@end example +Other important Git configuration will automatically be configured when +building the project (@pxref{Building from Git}). @node Sending a Patch Series @subsection Sending a Patch Series @@ -1439,10 +1419,12 @@ Sending a Patch Series The following command will create a patch email from the latest commit, open it in your @var{EDITOR} or @var{VISUAL} for editing, and send it to -the Guix mailing list to be reviewed and merged: +the Guix mailing list to be reviewed and merged. Assuming you have +already configured Git according to @xref{Configuring Git}, you can +simply use: @example -$ git send-email -1 -a --base=auto --to=guix-patches@@gnu.org +$ git send-email --annotate -1 @end example @quotation Tip @@ -1453,31 +1435,26 @@ Sending a Patch Series @url{https://git.savannah.gnu.org/cgit/guix.git}. @example -git send-email -1 -a --base=auto \ - --subject-prefix='PATCH core-updates' \ - --to=guix-patches@@gnu.org +git send-email --annotate --subject-prefix='PATCH core-updates' -1 @end example @end quotation The patch email contains a three-dash separator line after the commit message. You may ``annotate'' the patch with explanatory text by adding it under this line. If you do not wish to annotate the email, you may -drop the @option{-a} flag (which is short for @option{--annotate}). - -The @option{--base=auto} flag automatically adds a note at the bottom -of the patch of the commit it was based on, making it easier for -maintainers to rebase and merge your patch. +drop the @option{--annotate} option. If you need to send a revised patch, don't resend it like this or send a ``fix'' patch to be applied on top of the last one; instead, use -@command{git commit -a} or @url{https://git-rebase.io, @command{git rebase}} -to modify the commit, and use the @email{@var{ISSUE_NUMBER}@@debbugs.gnu.org} -address and the @option{-v} flag with @command{git send-email}. +@command{git commit --amend} or @url{https://git-rebase.io, +@command{git rebase}} to modify the commit, and use the +@email{@var{ISSUE_NUMBER}@@debbugs.gnu.org} address and the @option{-v} +flag with @command{git send-email}. @example -$ git commit -a -$ git send-email -1 -a --base=auto -v@var{REVISION} \ - --to=@var{ISSUE_NUMBER}@@debbugs.gnu.org +$ git commit --amend +$ git send-email --annotate -v@var{REVISION} \ + --to=@var{ISSUE_NUMBER}@@debbugs.gnu.org -1 @end example @quotation Note @@ -1494,14 +1471,14 @@ Sending a Patch Series @unnumberedsubsubsec Notifying Teams @anchor{Notifying Teams} @cindex teams -The @file{etc/teams.scm} script may be used to notify all those who -may be interested in your patch of its existence (@pxref{Teams}). -Use @command{etc/teams.scm list-teams} to display all the teams, -decide which team(s) your patch relates to, and use -@command{etc/teams.scm cc} to output various @command{git send-email} -flags which will notify the appropriate team members, or use -@command{etc/teams.scm cc-members} to detect the appropriate teams -automatically. +If your git checkout has been correctly configured (@pxref{Configuring +Git}), the @command{git send-email} command will automatically notify +the appropriate team members, based on the scope of your changes. This +relies on the @file{etc/teams.scm} script, which can also be invoked +manually if you do not use the preferred @command{git send-email} +command to submit patches. To list the available actions of the script, +you can invoke it via the @command{etc/teams.scm help} command. For +more information regarding teams, see @xref{Teams}. @unnumberedsubsubsec Multiple Patches @anchor{Multiple Patches} @@ -1528,9 +1505,7 @@ Sending a Patch Series that we can send the rest of the patches to. @example -$ git send-email outgoing/0000-cover-letter.patch -a \ - --to=guix-patches@@gnu.org \ - $(etc/teams.scm cc-members ...) +$ git send-email outgoing/0000-cover-letter.patch --annotate $ rm outgoing/0000-cover-letter.patch # we don't want to resend it! @end example @@ -1542,9 +1517,7 @@ Sending a Patch Series can send the actual patches to the newly-created issue address. @example -$ git send-email outgoing/*.patch \ - --to=@var{ISSUE_NUMBER}@@debbugs.gnu.org \ - $(etc/teams.scm cc-members ...) +$ git send-email outgoing/*.patch --to=@var{ISSUE_NUMBER}@@debbugs.gnu.org $ rm -rf outgoing # we don't need these anymore @end example @@ -1553,14 +1526,13 @@ Sending a Patch Series the patchset. @example -$ git send-email -@var{NUMBER_COMMITS} \ - -v@var{REVISION} --base=auto \ +$ git send-email -@var{NUMBER_COMMITS} -v@var{REVISION} \ --to @var{ISSUE_NUMBER}@@debbugs.gnu.org @end example -If need be, you may use @option{--cover-letter -a} to send another cover -letter, e.g. for explaining what's changed since the last revision, and -these changes are necessary. +If need be, you may use @option{--cover-letter --annotate} to send +another cover letter, e.g. for explaining what's changed since the last +revision, and these changes are necessary. @node Teams @subsection Teams @@ -1587,7 +1559,8 @@ Teams CC of a patch series: @example -$ git send-email --to @var{ISSUE_NUMBER}@@debbugs.gnu.org $(./etc/teams.scm cc mentors) *.patch +$ git send-email --to @var{ISSUE_NUMBER}@@debbugs.gnu.org \ + --header-cmd='etc/teams.scm cc-mentors-header-cmd' *.patch @end example The appropriate team or teams can also be inferred from the modified @@ -1596,7 +1569,7 @@ Teams @example $ guix shell -D guix -[env]$ git send-email --to @var{ISSUE_NUMBER}@@debbugs.gnu.org $(./etc/teams.scm cc-members HEAD~2 HEAD) *.patch +[env]$ git send-email --to @var{ISSUE_NUMBER}@@debbugs.gnu.org -2 @end example @node Tracking Bugs and Patches @@ -1831,16 +1804,9 @@ Commit Access make authenticate @end example -You can prevent yourself from accidentally pushing unsigned or signed -with the wrong key commits to Savannah by using the pre-push Git hook -located at @file{etc/git/pre-push}: - -@example -cp etc/git/pre-push .git/hooks/pre-push -@end example - -It additionally calls @code{make check-channel-news} to be sure -@file{news.scm} file is correct. +To avoid accidentally pushing unsigned or signed with the wrong key +commits to Savannah, make sure to configure Git according to +@xref{Configuring Git}. @subsection Commit Policy diff --git a/doc/guix.texi b/doc/guix.texi index 9997aeb86e..e5f6c7e831 100644 --- a/doc/guix.texi +++ b/doc/guix.texi @@ -49,7 +49,7 @@ Copyright @copyright{} 2017, 2021 Christine Lemmer-Webber@* Copyright @copyright{} 2017, 2018, 2019, 2020, 2021, 2022 Marius Bakke@* Copyright @copyright{} 2017, 2019, 2020, 2022 Hartmut Goebel@* -Copyright @copyright{} 2017, 2019, 2020, 2021, 2022 Maxim Cournoyer@* +Copyright @copyright{} 2017, 2019, 2020, 2021, 2022, 2023 Maxim Cournoyer@* Copyright @copyright{} 2017–2022 Tobias Geerinckx-Rice@* Copyright @copyright{} 2017 George Clemmer@* Copyright @copyright{} 2017 Andy Wingo@* -- 2.39.2 From debbugs-submit-bounces@debbugs.gnu.org Mon Apr 24 00:22:17 2023 Received: (at 58813) by debbugs.gnu.org; 24 Apr 2023 04:22:17 +0000 Received: from localhost ([127.0.0.1]:47295 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pqniS-0005e0-Rd for submit@debbugs.gnu.org; Mon, 24 Apr 2023 00:22:17 -0400 Received: from mail-ed1-f67.google.com ([209.85.208.67]:57551) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pqniP-0005dl-Ba for 58813@debbugs.gnu.org; Mon, 24 Apr 2023 00:22:14 -0400 Received: by mail-ed1-f67.google.com with SMTP id 4fb4d7f45d1cf-5066ce4f490so5783138a12.2 for <58813@debbugs.gnu.org>; Sun, 23 Apr 2023 21:22:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1682310127; x=1684902127; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=OQdPwsUnVNa1YH/xK8tGb8D3uIihZ49FYoJLGmdzrF8=; b=lGLxIMILfV8eHHP/Ke2R+3BBIQACZCyFlSubAc0ugK3FAu9ikvYjS+zN53Fggc0VAE t6/vVZPtyrfT5W/zjE8NxoW6+NJ9V3hVvb1KSOoR6A3+2DQo6VGtlgspMbHGkd6fazFo uJYS9d/MrAd0AmTH5iFAKX5rnN56MUYrphvX1DXBxi5KuEf6BuEQnTNWzJK9za+jId3G se16W/dJqJicwEHPV/ixjd1j8Ekt47aSgRD4T4YBmWPmgXZQ9rAkir68Mw9q6FYqF5fw iufuWRG2RsYnv1a+VXxqsyWIXmoWGeO//EfUReqDdZ7WlU5rlQVc3MdTiTP2vopemyEp 81fg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682310127; x=1684902127; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=OQdPwsUnVNa1YH/xK8tGb8D3uIihZ49FYoJLGmdzrF8=; b=cYMqHNoat7uCuXdPmD9h/FVZtpSS9m0h9K4w1IRqgluM8xris3Hskn3QSPjU1PLO7S 9cE5bhTF6eFcMupLNoIEd2dnKXv828xRdvSeGWiob6x9X3qxgjovJ9sBtK0uEMJY3cOn FfEMmbWHVxWHJiYP7CoZatWahrw76McQvTLTq1/uThbwICJ52EYJTqKmf0xGuzPNmEfU qHbWwyxu83mP2lXd1aAHfHzjWAcr47wmyg4U2R/mNL0N5b2pMK61aGujV+xUMy66KfRW Ebx1X3yFEVb68rxdhRLu7BK7kfR/xnJ+9jKmAeb5QDPWTBfnZePM7cYBp0lJkwAiMmQJ xTPg== X-Gm-Message-State: AAQBX9eD3R6nqTIIIKQm02hhOjCNigMyoGO4bJKUiNMpKf23xlFlxENX QCHn/ONaFiRDyYu6kaKV3WA= X-Google-Smtp-Source: AKy350Zf1ldsIgc2dRM0BoiPBAX0IZTABhMuhH3OKU3VtskvHdo+6gp6oChVduLl9iyAluzAcGnSEg== X-Received: by 2002:a05:6402:7c2:b0:508:4954:e30c with SMTP id u2-20020a05640207c200b005084954e30cmr11714293edy.11.1682310127340; Sun, 23 Apr 2023 21:22:07 -0700 (PDT) Received: from lumine.fritz.box (85-127-52-93.dsl.dynamic.surfer.at. [85.127.52.93]) by smtp.gmail.com with ESMTPSA id e17-20020aa7d7d1000000b00508480633bdsm4321970eds.74.2023.04.23.21.22.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 23 Apr 2023 21:22:06 -0700 (PDT) Message-ID: Subject: Re: [PATCH v2 3/5] Makefile.am: Auto-configure Git on 'make'. From: Liliana Marie Prikler To: Maxim Cournoyer , 58813@debbugs.gnu.org Date: Mon, 24 Apr 2023 06:22:05 +0200 In-Reply-To: References: <5b9af4fa77a89c6a4b169dc464f414b1a4166d60.camel@gmail.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.4 MIME-Version: 1.0 X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 58813 Cc: ludo@gnu.org, zimon.toutoune@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Am Sonntag, dem 23.04.2023 um 22:29 -0400 schrieb Maxim Cournoyer: > This means we do not need to worry anymore about manually syncing the > pre-push git hook or the Guix-provided git configuration. IIUC we still need to invoke 'make .git/whatever' manually, and I'd actually like it to be that way, just with a nice phony target like 'make git-config' or 'make .git'. WDYT? > * etc/git/gitconfig: Augment configuration template with useful > options to allow for auto-configuration. > * Makefile.am (.git/hooks/pre-push, .git/config): New targets. > (nodist_noinst_DATA): New primary variable holding the above targets. > --- > =C2=A0Makefile.am=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 | 10 ++++++++++ > =C2=A0etc/git/gitconfig | 15 +++++++++++++++ > =C2=A02 files changed, 25 insertions(+) >=20 > diff --git a/Makefile.am b/Makefile.am > index 23b939b674..7daa7d66f7 100644 > --- a/Makefile.am > +++ b/Makefile.am > @@ -14,6 +14,7 @@ > =C2=A0# Copyright =C2=A9 2018 Oleg Pykhalov > =C2=A0# Copyright =C2=A9 2018 Alex Vong > =C2=A0# Copyright =C2=A9 2019 Efraim Flashner > +# Copyright =C2=A9 2020, 2021, 2023 Maxim Cournoyer > > =C2=A0# Copyright =C2=A9 2021 Chris Marusich > =C2=A0# Copyright =C2=A9 2021 Andrew Tropin > =C2=A0# > @@ -1109,6 +1110,15 @@ cuirass-jobs: $(GOBJECTS) > =C2=A0.PHONY: clean-go make-go as-derivation authenticate > =C2=A0.PHONY: update-guix-package update-NEWS cuirass-jobs release > =C2=A0 > +# Git auto-configuration. > +.git/hooks/pre-push: etc/git/pre-push > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0cp etc/git/pre-push .git/hooks= /pre-push > + > +.git/config: etc/git/gitconfig > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0git config include.path ../etc= /git/gitconfig > + > +nodist_noinst_DATA =3D .git/hooks/pre-push .git/config > + > =C2=A0# Downloading up-to-date PO files. > =C2=A0 > =C2=A0WEBLATE_REPO =3D https://framagit.org/tyreunom/guix-translations > diff --git a/etc/git/gitconfig b/etc/git/gitconfig > index c9ebdc8fa8..0b6984a05f 100644 > --- a/etc/git/gitconfig > +++ b/etc/git/gitconfig > @@ -1,5 +1,20 @@ > +[commit] > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 gpgsign =3D true > + > =C2=A0[diff "scheme"] > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0xfuncname =3D "^(\\(defin= e.*)$" > =C2=A0 > =C2=A0[diff "texinfo"] > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0xfuncname =3D "^@node[[:s= pace:]]+([^,]+).*$" > + > +[format] > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 useAutoBase =3D true > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 thread =3D shallow > + > +[pull] > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 rebase =3D true > + > +[sendemail] > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 to =3D guix-patches@gnu.org > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 headerCmd =3D etc/teams.scm c= c-members-header-cmd > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 thread =3D no Otherwise LGTM. Cheers From debbugs-submit-bounces@debbugs.gnu.org Mon Apr 24 08:37:55 2023 Received: (at 58813) by debbugs.gnu.org; 24 Apr 2023 12:37:55 +0000 Received: from localhost ([127.0.0.1]:47786 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pqvS7-0004Ru-Iu for submit@debbugs.gnu.org; Mon, 24 Apr 2023 08:37:55 -0400 Received: from mail-qt1-f178.google.com ([209.85.160.178]:47493) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pqvS6-0004Ri-14 for 58813@debbugs.gnu.org; Mon, 24 Apr 2023 08:37:54 -0400 Received: by mail-qt1-f178.google.com with SMTP id d75a77b69052e-3eef63eff7eso19929131cf.3 for <58813@debbugs.gnu.org>; Mon, 24 Apr 2023 05:37:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1682339868; x=1684931868; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=YjIzo8BlOf7aV40LdWM/dkn5RoK6XDAN/0/Y6eOceEo=; b=DwhIDj0b6FduuMuhJFO5iNyZGAtn3PdWWFNGajQV1TBEUb+NUNVwgKvuS4tqdIa7wh eL34yHdtSJyd6jZQqWSR8304PHaNugZ+s6Rtml7sKIhRx/Yt9/CKZMAfGU9a2CYV2NIV uRnkiI73wBSH35FSYtbz8ThteLAmMNwrvpSfPZIVRYEuHZG630kg//788pjdwNRdTPOT 2n/3/bKlEP7NW0mddWjGJAYLsUa2fYQBodqHs+xXu/9I2s73I5GvQe5XG09F7LID8Q3p 2jv1MoLLpaQK1g73K1KGz1JHYJvLCxgT/iQHp3wcMKfMLVTEMgErhifa8VNhSo4U1/xN SJrA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682339868; x=1684931868; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=YjIzo8BlOf7aV40LdWM/dkn5RoK6XDAN/0/Y6eOceEo=; b=GjsBy+U/db11vi9fHmU5JllG7rX5XUa9km6VEq/sJrMa3kwT2o5zQK8xm/LaNX/+yH WpyBdEb+HR6p1E3dEaSSrp9I1XPN7lz0dRYEAF0Jn53BYvwgx72jrFDWCXB7X3smBwNG uLOwpnljc4FbWkfD4gIdpR5NwrlADsnuUOt7lwf8foaVrf+94TU32BD/4y+y5YHFTpbm Dukft5NqQlBo1nhYgS8rGlEfM97E3RdQp8myodsaSJMHi9gnY+i3xAHeDXlz5RO0H9MV O59d23lnhqWtoRuyZsYyBK9ThaLOlwF4Y27dFTLnyvOjBorBgFrVGODxxAC7gVYNEQRT G/wg== X-Gm-Message-State: AAQBX9cOTu8tA4UyTIMwYcJO4t/z3q848tNR7MI7p9pHtxdLD4KohXnU 2uxaPc8sZu1Cok8WXNfFu2Q= X-Google-Smtp-Source: AKy350Yo7APDtEJrJ/uel1rz2dI/h4cf7GawRymIjna0bDeEucdDfhSIfA9wRt0QWdCc6xpq6xskdQ== X-Received: by 2002:ac8:5a0a:0:b0:3ef:6384:80a6 with SMTP id n10-20020ac85a0a000000b003ef638480a6mr14724675qta.30.1682339868425; Mon, 24 Apr 2023 05:37:48 -0700 (PDT) Received: from hurd (dsl-141-20.b2b2c.ca. [66.158.141.20]) by smtp.gmail.com with ESMTPSA id x132-20020a37638a000000b007460093cccdsm3549946qkb.25.2023.04.24.05.37.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Apr 2023 05:37:48 -0700 (PDT) From: Maxim Cournoyer To: Liliana Marie Prikler Subject: Re: bug#58813: [PATCH v2 3/5] Makefile.am: Auto-configure Git on 'make'. References: <5b9af4fa77a89c6a4b169dc464f414b1a4166d60.camel@gmail.com> Date: Mon, 24 Apr 2023 08:37:46 -0400 In-Reply-To: (Liliana Marie Prikler's message of "Mon, 24 Apr 2023 06:22:05 +0200") Message-ID: <87leihtq05.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 58813 Cc: ludo@gnu.org, 58813@debbugs.gnu.org, zimon.toutoune@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Liliana, Liliana Marie Prikler writes: > Am Sonntag, dem 23.04.2023 um 22:29 -0400 schrieb Maxim Cournoyer: >> This means we do not need to worry anymore about manually syncing the >> pre-push git hook or the Guix-provided git configuration. > IIUC we still need to invoke 'make .git/whatever' manually, and I'd > actually like it to be that way, just with a nice phony target like > 'make git-config' or 'make .git'. WDYT? Do, because the targets are added to nodist_noinst_DATA, they are included in the default 'all' target (i.e., just invoking 'make' builds them). Because of that, a .PHONY target is not needed. I think this is best, since otherwise when etc/git/pre-push changed, you'd have to remember to run 'make configure-git' for example. It'd be error prone, and easy to forget. -- Thanks, Maxim From debbugs-submit-bounces@debbugs.gnu.org Fri Apr 28 10:28:59 2023 Received: (at 58813) by debbugs.gnu.org; 28 Apr 2023 14:28:59 +0000 Received: from localhost ([127.0.0.1]:34188 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1psP5m-0005C7-MH for submit@debbugs.gnu.org; Fri, 28 Apr 2023 10:28:59 -0400 Received: from jpoiret.xyz ([206.189.101.64]:41198) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1psP5j-0005Bs-UE for 58813@debbugs.gnu.org; Fri, 28 Apr 2023 10:28:57 -0400 Received: from authenticated-user (jpoiret.xyz [206.189.101.64]) by jpoiret.xyz (Postfix) with ESMTPA id 92537185310; Fri, 28 Apr 2023 14:28:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jpoiret.xyz; s=dkim; t=1682692134; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=U56mCEL2ebJNiiqsGN6RWZBBgq/nfCi1+2UBcX1k4sM=; b=dDinld7H/iJlHCvQfizmTgVoA+Tv9eTWfCDjgDWnNQPltu/geGJk2+cgY6Sdjaf5XzZ45v sTXIQgXl+ew4iPyx7i0u/DcnSkyckJfAqOlNiedikH/Fliu5ieVJM06m7VMGu8AP7PFYXe bXnQXLEN5HJD8Jh1c3d5iUTjip4TyNVyiLwb8V6o+3GK+3ql66I6ZVJTIpuVSuCRAgVJSp VCVefG2L1FeFz6vM0n6lgISW7jbvTPXJUsrUc+DlwkA2NtCItGN5LQ4igozIr/FCQCpIAp zXs6Jz5aXwFFjv3HYJHbWtJ3cBET9oP32ujdZuz2E6SEfBUv37jroHYsR/ehQg== From: Josselin Poiret To: Maxim Cournoyer , 58813@debbugs.gnu.org Subject: Re: bug#58813: [PATCH v2 3/5] Makefile.am: Auto-configure Git on 'make'. In-Reply-To: References: <5b9af4fa77a89c6a4b169dc464f414b1a4166d60.camel@gmail.com> Date: Fri, 28 Apr 2023 16:28:50 +0200 Message-ID: <87pm7ogjx9.fsf@jpoiret.xyz> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-Spamd-Bar: + Authentication-Results: jpoiret.xyz; auth=pass smtp.auth=jpoiret@jpoiret.xyz smtp.mailfrom=dev@jpoiret.xyz X-Spam-Level: * X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 58813 Cc: ludo@gnu.org, liliana.prikler@gmail.com, Maxim Cournoyer , zimon.toutoune@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Hi Maxim, Only seeing this patchset now, but it seems great! Maxim Cournoyer writes: > +[commit] > + gpgsign =3D true > + > [diff "scheme"] > xfuncname =3D "^(\\(define.*)$" >=20=20 > [diff "texinfo"] > xfuncname =3D "^@node[[:space:]]+([^,]+).*$" > + > +[format] > + useAutoBase =3D true > + thread =3D shallow > + > +[pull] > + rebase =3D true > + > +[sendemail] > + to =3D guix-patches@gnu.org > + headerCmd =3D etc/teams.scm cc-members-header-cmd > + thread =3D no Could we also consider adding format.forceinbodyfrom=3Dtrue, so that contributors whose From: gets rewritten by debbugs/mailman still have the proper attribution without requiring manual action from committers? Best, =2D-=20 Josselin Poiret --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQHEBAEBCAAuFiEEOSSM2EHGPMM23K8vUF5AuRYXGooFAmRL2CIQHGRldkBqcG9p cmV0Lnh5egAKCRBQXkC5Fhcaii5IC/42k76BsZ6VZOZ1tUJEHXjpcbdNnY3i/QnB Pw6k4kzIxFTcKjPpWQ8qKAmuvw05Wt3isanxwupjwdHGU1rUJbdxAB+t0hBWeAcC ADRsMthkjWsvJlFgBW/mppv7vL0/Zy3jPjgIPZ3CK87kns4ZyEnmZj707D+fS9VC TgcUNFvcDeL7CjzSg4gaElfqFgSNpcCkFdEsuO2S7V3mgzGtFCTLan7hvDkwY308 X3G1J8jlukto9n6eovrkXmGH8X6a4AL3+B+jmk52U1nYzdIB75lx1d0MsZUyouqg JERVyXXH5aUiaM2ylJHTQcrtg56Hg7yU/prcQ5DkigCXb1CFIYqgKQ+tQuQr2zRa 8DkeE7WbMv9yoLBMgCYg7cdoR9vg63El9NvX8rPMIQGtvR3RUTTRkd9Mez2eEur2 lnNDiCJyHsZlyYoAGyldD4ZWqGyIBOSOfQlW9zZGBwj3Ab5SbVQkj7QFzi0VtsqB okFZszfykApGyo0hy5oDrLGkRMRtIys= =FFsP -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Mon May 01 12:38:46 2023 Received: (at 58813-done) by debbugs.gnu.org; 1 May 2023 16:38:46 +0000 Received: from localhost ([127.0.0.1]:40921 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ptWY1-00078o-Sd for submit@debbugs.gnu.org; Mon, 01 May 2023 12:38:46 -0400 Received: from mail-qk1-f180.google.com ([209.85.222.180]:57530) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ptWXz-00078Y-1G for 58813-done@debbugs.gnu.org; Mon, 01 May 2023 12:38:44 -0400 Received: by mail-qk1-f180.google.com with SMTP id af79cd13be357-74e3899037cso126446485a.2 for <58813-done@debbugs.gnu.org>; Mon, 01 May 2023 09:38:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1682959116; x=1685551116; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=FiOZm5YNhQacORY934Pza1ks+3QOxZ8n1bJYlihhaho=; b=nv1P1pn9TtZIV+HrXekmUMbg2CcyGYMLoU3s+7MesyPf/xY2lIcOGULtF9kPOSQf2f m7pEf+lNoCtMn9JRq33Ks4gIfRD+zgCQrvmTXgXvMv6zz8qxD3Da1IyaDpMOhmelMjKX or7NppIX5DiiyGsqqVuYdAdHVf/Vbf+qm0GIsfvqbSun9Qbc0ZQnc115CKL88bal9ina JvpLOUBlrseicqPDg81mjGT0qPGYpuH5DEQtMXAsX/IBkvsTDnxSJneY5Ycc0Wv/fQ1v k5NYcjtRCaNY02z0twNLklBIsNsEKcGIF89GBaRk5L0Ymq3ARdGXqR6x6RErJUVXdjrr owFA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682959116; x=1685551116; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=FiOZm5YNhQacORY934Pza1ks+3QOxZ8n1bJYlihhaho=; b=I8hfz2m0eoCR8mqupC+Src/vZSWZkKf02qFPcHixQ1SQ+LqdfGrmx/S/G8Hvz1M1QI Jsx/QlyKv+5dvUvugJKX7/MQFCBNyasDayjHngHOIn7fhSJqfTBUH2+qCBijs1LFrL2M P4JxQehZVLUgh7invqxMtMSQJnZeKBXhqkL7zmPJdeECG2+pr+mPUTGx+mbxdVr3qzab BHlcnXJpzpeidsPc6DiHfa06yRq5/0sUXKGII24PbosuuDaggMGfXQ9rHfsuNov9NGKm I//4gsa1axnkMhHlAnqtQ8kqWblGVcFv8BRXPRnVFSuhQRMGCbTrrOdfY4jdZtINsbkv kS3Q== X-Gm-Message-State: AC+VfDxcygSqbGc6TsTobnnpZ2yFvC+rhSKF/VtIH8UQ21dYcmE8r46A Y6Rf2HWZlDlHNvOWe+Z82l0= X-Google-Smtp-Source: ACHHUZ642BYJS6yYAt9pp7ajcFNDUPOSBzZJJde9L7CEToltMP6dYmU6BOnwf2Lz1YWQdXfa+Z6gGg== X-Received: by 2002:a05:6214:519d:b0:5ef:5245:df77 with SMTP id kl29-20020a056214519d00b005ef5245df77mr640910qvb.35.1682959116638; Mon, 01 May 2023 09:38:36 -0700 (PDT) Received: from hurd (dsl-157-118.b2b2c.ca. [66.158.157.118]) by smtp.gmail.com with ESMTPSA id d25-20020a0cb2d9000000b005fd3215c80fsm8613414qvf.79.2023.05.01.09.38.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 May 2023 09:38:36 -0700 (PDT) From: Maxim Cournoyer To: Josselin Poiret Subject: Re: bug#58813: can't substitute etc/teams.scm command as doc suggests References: <5b9af4fa77a89c6a4b169dc464f414b1a4166d60.camel@gmail.com> <87pm7ogjx9.fsf@jpoiret.xyz> Date: Mon, 01 May 2023 12:38:34 -0400 In-Reply-To: <87pm7ogjx9.fsf@jpoiret.xyz> (Josselin Poiret's message of "Fri, 28 Apr 2023 16:28:50 +0200") Message-ID: <87edo03t2t.fsf_-_@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 58813-done Cc: ludo@gnu.org, liliana.prikler@gmail.com, 58813-done@debbugs.gnu.org, zimon.toutoune@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi, Josselin Poiret writes: > Hi Maxim, > > Only seeing this patchset now, but it seems great! > > Maxim Cournoyer writes: > >> +[commit] >> + gpgsign = true >> + >> [diff "scheme"] >> xfuncname = "^(\\(define.*)$" >> >> [diff "texinfo"] >> xfuncname = "^@node[[:space:]]+([^,]+).*$" >> + >> +[format] >> + useAutoBase = true >> + thread = shallow >> + >> +[pull] >> + rebase = true >> + >> +[sendemail] >> + to = guix-patches@gnu.org >> + headerCmd = etc/teams.scm cc-members-header-cmd >> + thread = no > > Could we also consider adding format.forceinbodyfrom=true, so that > contributors whose From: gets rewritten by debbugs/mailman still have > the proper attribution without requiring manual action from committers? Seems reasonable. I've added it in, and have now pushed the series. The upstream git commit hasn't been merged yet, but I've addressed all their comments, and will continue doing so. Closing, finally :-). I'll push an associated news entry shortly. -- Thanks, Maxim From unknown Sat Aug 09 15:56:11 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Tue, 30 May 2023 11:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator