GNU bug report logs - #58812
[PATCH] Add '--symlink' to 'guix shell'

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#58812: closed ([PATCH 0/5] Add --symlink option to 'guix shell'.)
Date: Tue, 15 Nov 2022 21:25:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Tue, 15 Nov 2022 16:24:47 -0500
with message-id <87y1sblxls.fsf <at> gmail.com>
and subject line Re: bug#58812: [PATCH v3 1/4] shell: Detect --symlink spec problems early.
has caused the debbugs.gnu.org bug report #58812,
regarding [PATCH 0/5] Add --symlink option to 'guix shell'.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
58812: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=58812
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: guix-patches <at> gnu.org
Cc: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
Subject: [PATCH 0/5] Add --symlink option to 'guix shell'.
Date: Wed, 26 Oct 2022 23:41:54 -0400

Hi,

I've wanted this enough times now to finally get around implementing it :-).
My main use case for it will be creating a /usr/bin/env symlink in 'guix
shell' environments for portability with the #!/usr/bin/env
shebang.

While at it, I've improved error reporting and made it fail early when a
symlink would point to a nonexistent file (dangling symlink).

The test suite passes, and I've run the basic system test as well as the
'btrfs-root-os' one successfully.

Thanks,

Maxim Cournoyer (5):
  Makefile.am: Sort EXTRA_DIST entries.
  tests: Add a tests/utils.sh support file.
  install: Validate symlink target in evaluate-populate-directive.
  guix: shell: Add '--symlink' option.
  shell: Detect --symlink spec problems early.

 Makefile.am                  |  55 ++++---
 doc/guix.texi                |   9 +-
 gnu/build/install.scm        |  78 ++++++---
 guix/scripts/environment.scm | 298 +++++++++++++++++++----------------
 guix/scripts/pack.scm        | 208 ++++++++++++------------
 guix/scripts/shell.scm       |  77 ++++-----
 tests/guix-pack.sh           |   2 +-
 tests/guix-shell.sh          |  21 +++
 tests/shell-utils.scm        |  29 ++++
 tests/utils.sh               |  33 ++++
 10 files changed, 483 insertions(+), 327 deletions(-)
 create mode 100644 tests/shell-utils.scm
 create mode 100644 tests/utils.sh

-- 
2.37.3

[Message part 3 (message/rfc822, inline)]

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: 58812-done <at> debbugs.gnu.org
Cc: 59164-done <at> debbugs.gnu.org
Subject: Re: bug#58812: [PATCH v3 1/4] shell: Detect --symlink spec problems
 early.
Date: Tue, 15 Nov 2022 16:24:47 -0500

Hi,

[...]

>   Makefile.am: Sort EXTRA_DIST entries.
>   tests: Add a tests/utils.sh support file.
>   install: Validate symlink target in evaluate-populate-directive.
>   guix: shell: Add '--symlink' option.
>   shell: Detect --symlink spec problems early.

I've now pushed this series as 8f9588185d, with a news entry added as
47f319f21f.

Closing!

-- 
Thanks,
Maxim

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.