From unknown Sat Aug 16 18:40:40 2025 X-Loop: help-debbugs@gnu.org Subject: bug#58810: 29.0.50; [PATCH] 'eshell-stringify' sometimes produces wrong results Resent-From: Jim Porter Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 27 Oct 2022 01:23:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 58810 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: 58810@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.166683374525230 (code B ref -1); Thu, 27 Oct 2022 01:23:02 +0000 Received: (at submit) by debbugs.gnu.org; 27 Oct 2022 01:22:25 +0000 Received: from localhost ([127.0.0.1]:55638 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1onrbF-0006Yr-5R for submit@debbugs.gnu.org; Wed, 26 Oct 2022 21:22:25 -0400 Received: from lists.gnu.org ([209.51.188.17]:38452) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1onrbC-0006Yh-17 for submit@debbugs.gnu.org; Wed, 26 Oct 2022 21:22:24 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1onrbB-0005vO-Od for bug-gnu-emacs@gnu.org; Wed, 26 Oct 2022 21:22:21 -0400 Received: from mail-pl1-x62e.google.com ([2607:f8b0:4864:20::62e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1onrb9-0006Oa-Le for bug-gnu-emacs@gnu.org; Wed, 26 Oct 2022 21:22:21 -0400 Received: by mail-pl1-x62e.google.com with SMTP id f23so16016492plr.6 for ; Wed, 26 Oct 2022 18:22:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:subject:from:content-language:mime-version:date:message-id:from :to:cc:subject:date:message-id:reply-to; bh=JCqVeH33I/8wcKmGadwiwoiQHkgm5UQ8wMsNSQAz6iQ=; b=UuiFekhO/xbH/AkFXe4YEwdeEztwQb7kXpqJkH2V1LiG8+9cI9pYnua8ZG/xS/8RGd mg+qd1N1OclFfMAkU/otZX2lPPKNOFcQk4fKTdBrU0ULaqkSURTOgpGoFfJ+URhZD1ZW 0+SW7Y9lUtNpbim2hXvmLguhJ9bK1A8sWhwJRa7xTfvgmw236TSmK6JpjXUtzhJq5Dvz ERuigz+WZHcEWCkBZq2snZFxthN5yaM4LVB5OOdWfmoNrVQWMS7kckOPIceHiBuu++7E gP44X6KmMKSZVES8rftwyXpooMYs3AsS+XQP77Kdo0DU9v/LUPtJOZa2l1jqEIbU3ogg 1kEA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:subject:from:content-language:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=JCqVeH33I/8wcKmGadwiwoiQHkgm5UQ8wMsNSQAz6iQ=; b=X4BFbHPrsnQ/2gZnbFsSoPYuzkIHr6RuMIK8XhSsGAqiGZEd67njaDBVLuyaGtRQqJ jRSSC1eHKMt1qcV7uG7RLKV7qZxSdDQpkFKYHP1Ijo9iLGiFiqVfgOheCqdu++7/1k84 Osc5FfiqmZ1d6RO+W8Q9PhFwnBTW7k6AfaDTPyLR3A5dYbpSS2GOg/p2G1xnHVxWygrb 1YWX7G0wH6lQLAx6XF2uj3POqwpunLQnE0OaBRQnLro7un80CHZ/TjNBpTLMNsyfywTT bl9UpJRYaOIDKvxpHYWIefPw5UD0xBkMooZvQpJtQYSNqOqij8QL/QgeGyXX4ax5DFI6 Z5ug== X-Gm-Message-State: ACrzQf0n2NDC+jdlANuZLRvgmj5jKZO+XTXWxNFVxVt1wuYwSeiGCG4N tptGh5b5P5i6pV+Yo29ZFBcufbY0iKw= X-Google-Smtp-Source: AMsMyM4OsFGvqQzoAmKM6ExsaPH+SDjtiAYW5i5GltXG2JbRjtgwA/UaK6WCyOa3JThi06yCwfrlyg== X-Received: by 2002:a17:90a:ad08:b0:212:d5f1:e0c6 with SMTP id r8-20020a17090aad0800b00212d5f1e0c6mr7094427pjq.228.1666833737229; Wed, 26 Oct 2022 18:22:17 -0700 (PDT) Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id b3-20020a170903228300b00186b55e3cd6sm3541113plh.133.2022.10.26.18.22.15 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 26 Oct 2022 18:22:16 -0700 (PDT) Content-Type: multipart/mixed; boundary="------------7s0qWWsYYehl6o92Dl0qHTRf" Message-ID: <04d2f9ab-df6c-409e-7815-d75152bbba02@gmail.com> Date: Wed, 26 Oct 2022 18:22:13 -0700 MIME-Version: 1.0 X-Mozilla-News-Host: news://news.gmane.io:119 Content-Language: en-US From: Jim Porter Received-SPF: pass client-ip=2607:f8b0:4864:20::62e; envelope-from=jporterbugs@gmail.com; helo=mail-pl1-x62e.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) This is a multi-part message in MIME format. --------------7s0qWWsYYehl6o92Dl0qHTRf Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Starting from "emacs -Q -f -eshell": ~ $ echo $(list 'quote 'hello) 'hell The last character of "hello" was stripped. That's because 'eshell-stringify' tries to remove the trailing newline from 'pp-to-string', but it does so by always stripping the last character from the result. Obviously, that only works when the last character really is a newline. Attached is a patch with regression tests for 'eshell-stringify' so that this works correctly. --------------7s0qWWsYYehl6o92Dl0qHTRf Content-Type: text/plain; charset=UTF-8; name="0001-Only-strip-newlines-when-stringifying-a-value-for-Es.patch" Content-Disposition: attachment; filename*0="0001-Only-strip-newlines-when-stringifying-a-value-for-Es.pa"; filename*1="tch" Content-Transfer-Encoding: base64 RnJvbSBiYjQ0MDMxNmE1YTM4M2JhYjA5MWU1YjM1NTc3OGRiNTAyYmExYTNiIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKaW0gUG9ydGVyIDxqcG9ydGVyYnVnc0BnbWFpbC5j b20+CkRhdGU6IFN1biwgMTggU2VwIDIwMjIgMTc6NDI6MDkgLTA3MDAKU3ViamVjdDogW1BB VENIXSBPbmx5IHN0cmlwIG5ld2xpbmVzIHdoZW4gc3RyaW5naWZ5aW5nIGEgdmFsdWUgZm9y IEVzaGVsbAoKKiBsaXNwL2VzaGVsbC9lc2gtdXRpbC5lbCAoZXNoZWxsLXN0cmluZ2lmeSk6 IFVzZSAnc3RyaW5nLXRyaW0tcmlnaHQnCmluc3RlYWQgb2Ygc3RyaXBwaW5nIHRoZSBsYXN0 IGNoYXJhY3RlciBvZiB0aGUgcmVzdWx0IG9mCidwcC10by1zdHJpbmcnLgoKKiB0ZXN0L2xp c3AvZXNoZWxsL2VzaC11dGlsLXRlc3RzLmVsOiBOZXcgZmlsZS4KLS0tCiBsaXNwL2VzaGVs bC9lc2gtdXRpbC5lbCAgICAgICAgICAgIHwgMTEgKysrLS0tCiB0ZXN0L2xpc3AvZXNoZWxs L2VzaC11dGlsLXRlc3RzLmVsIHwgNTcgKysrKysrKysrKysrKysrKysrKysrKysrKysrKysr CiAyIGZpbGVzIGNoYW5nZWQsIDYxIGluc2VydGlvbnMoKyksIDcgZGVsZXRpb25zKC0pCiBj cmVhdGUgbW9kZSAxMDA2NDQgdGVzdC9saXNwL2VzaGVsbC9lc2gtdXRpbC10ZXN0cy5lbAoK ZGlmZiAtLWdpdCBhL2xpc3AvZXNoZWxsL2VzaC11dGlsLmVsIGIvbGlzcC9lc2hlbGwvZXNo LXV0aWwuZWwKaW5kZXggZjQ3MzczYzExNS4uZWNiNjg4ODY1MSAxMDA2NDQKLS0tIGEvbGlz cC9lc2hlbGwvZXNoLXV0aWwuZWwKKysrIGIvbGlzcC9lc2hlbGwvZXNoLXV0aWwuZWwKQEAg LTM1MCwxNiArMzUwLDEzIEBAIGVzaGVsbC1zdHJpbmdpZnkKICAgIkNvbnZlcnQgT0JKRUNU IGludG8gYSBzdHJpbmcgdmFsdWUuIgogICAoY29uZAogICAgKChzdHJpbmdwIG9iamVjdCkg b2JqZWN0KQotICAgKChhbmQgKGxpc3RwIG9iamVjdCkKLQkgKG5vdCAoZXEgb2JqZWN0IG5p bCkpKQotICAgIChsZXQgKChzdHJpbmcgKHBwLXRvLXN0cmluZyBvYmplY3QpKSkKLSAgICAg IChzdWJzdHJpbmcgc3RyaW5nIDAgKDEtIChsZW5ndGggc3RyaW5nKSkpKSkKICAgICgobnVt YmVycCBvYmplY3QpCiAgICAgKG51bWJlci10by1zdHJpbmcgb2JqZWN0KSkKKyAgICgoYW5k IChlcSBvYmplY3QgdCkKKwkgKG5vdCBlc2hlbGwtc3RyaW5naWZ5LXQpKQorICAgIG5pbCkK ICAgICh0Ci0gICAgKHVubGVzcyAoYW5kIChlcSBvYmplY3QgdCkKLQkJIChub3QgZXNoZWxs LXN0cmluZ2lmeS10KSkKLSAgICAgIChwcC10by1zdHJpbmcgb2JqZWN0KSkpKSkKKyAgICAo c3RyaW5nLXRyaW0tcmlnaHQgKHBwLXRvLXN0cmluZyBvYmplY3QpKSkpKQogCiAoZGVmc3Vi c3QgZXNoZWxsLXN0cmluZ2lmeS1saXN0IChhcmdzKQogICAiQ29udmVydCBlYWNoIGVsZW1l bnQgb2YgQVJHUyBpbnRvIGEgc3RyaW5nIHZhbHVlLiIKZGlmZiAtLWdpdCBhL3Rlc3QvbGlz cC9lc2hlbGwvZXNoLXV0aWwtdGVzdHMuZWwgYi90ZXN0L2xpc3AvZXNoZWxsL2VzaC11dGls LXRlc3RzLmVsCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAuLjFjYmQw MTU5OTkKLS0tIC9kZXYvbnVsbAorKysgYi90ZXN0L2xpc3AvZXNoZWxsL2VzaC11dGlsLXRl c3RzLmVsCkBAIC0wLDAgKzEsNTcgQEAKKzs7OyBlc2gtdXRpbC10ZXN0cy5lbCAtLS0gZXNo LXV0aWwgdGVzdCBzdWl0ZSAgLSotIGxleGljYWwtYmluZGluZzp0IC0qLQorCis7OyBDb3B5 cmlnaHQgKEMpIDIwMjIgRnJlZSBTb2Z0d2FyZSBGb3VuZGF0aW9uLCBJbmMuCisKKzs7IFRo aXMgZmlsZSBpcyBwYXJ0IG9mIEdOVSBFbWFjcy4KKworOzsgR05VIEVtYWNzIGlzIGZyZWUg c29mdHdhcmU6IHlvdSBjYW4gcmVkaXN0cmlidXRlIGl0IGFuZC9vciBtb2RpZnkKKzs7IGl0 IHVuZGVyIHRoZSB0ZXJtcyBvZiB0aGUgR05VIEdlbmVyYWwgUHVibGljIExpY2Vuc2UgYXMg cHVibGlzaGVkIGJ5Cis7OyB0aGUgRnJlZSBTb2Z0d2FyZSBGb3VuZGF0aW9uLCBlaXRoZXIg dmVyc2lvbiAzIG9mIHRoZSBMaWNlbnNlLCBvcgorOzsgKGF0IHlvdXIgb3B0aW9uKSBhbnkg bGF0ZXIgdmVyc2lvbi4KKworOzsgR05VIEVtYWNzIGlzIGRpc3RyaWJ1dGVkIGluIHRoZSBo b3BlIHRoYXQgaXQgd2lsbCBiZSB1c2VmdWwsCis7OyBidXQgV0lUSE9VVCBBTlkgV0FSUkFO VFk7IHdpdGhvdXQgZXZlbiB0aGUgaW1wbGllZCB3YXJyYW50eSBvZgorOzsgTUVSQ0hBTlRB QklMSVRZIG9yIEZJVE5FU1MgRk9SIEEgUEFSVElDVUxBUiBQVVJQT1NFLiAgU2VlIHRoZQor OzsgR05VIEdlbmVyYWwgUHVibGljIExpY2Vuc2UgZm9yIG1vcmUgZGV0YWlscy4KKworOzsg WW91IHNob3VsZCBoYXZlIHJlY2VpdmVkIGEgY29weSBvZiB0aGUgR05VIEdlbmVyYWwgUHVi bGljIExpY2Vuc2UKKzs7IGFsb25nIHdpdGggR05VIEVtYWNzLiAgSWYgbm90LCBzZWUgPGh0 dHBzOi8vd3d3LmdudS5vcmcvbGljZW5zZXMvPi4KKworOzs7IENvZGU6CisKKyhyZXF1aXJl ICdlcnQpCisocmVxdWlyZSAnZXNoLXV0aWwpCisKKzs7OyBUZXN0czoKKworKGVydC1kZWZ0 ZXN0IGVzaC11dGlsLXRlc3QvZXNoZWxsLXN0cmluZ2lmeS9zdHJpbmcgKCkKKyAgIlRlc3Qg dGhhdCBgZXNoZWxsLXN0cmluZ2lmeScgcHJlc2VydmVzIHRoZSB2YWx1ZSBvZiBzdHJpbmdz LiIKKyAgKHNob3VsZCAoZXF1YWwgKGVzaGVsbC1zdHJpbmdpZnkgImhlbGxvIikgImhlbGxv IikpKQorCisoZXJ0LWRlZnRlc3QgZXNoLXV0aWwtdGVzdC9lc2hlbGwtc3RyaW5naWZ5L251 bWJlciAoKQorICAiVGVzdCB0aGF0IGBlc2hlbGwtc3RyaW5naWZ5JyBjb252ZXJ0cyBudW1i ZXJzIHRvIHN0cmluZ3MuIgorICAoc2hvdWxkIChlcXVhbCAoZXNoZWxsLXN0cmluZ2lmeSA0 MikgIjQyIikpCisgIChzaG91bGQgKGVxdWFsIChlc2hlbGwtc3RyaW5naWZ5IDQuMikgIjQu MiIpKSkKKworKGVydC1kZWZ0ZXN0IGVzaC11dGlsLXRlc3QvZXNoZWxsLXN0cmluZ2lmeS90 ICgpCisgICJUZXN0IHRoYXQgYGVzaGVsbC1zdHJpbmdpZnknIHRyZWF0cyBgdCcgYWNjb3Jk aW5nIHRvIGBlc2hlbGwtc3RyaW5naWZ5LXQnLiIKKyAgKGxldCAoKGVzaGVsbC1zdHJpbmdp ZnktdCB0KSkKKyAgICAoc2hvdWxkIChlcXVhbCAoZXNoZWxsLXN0cmluZ2lmeSB0KSAidCIp KSkKKyAgKGxldCAoKGVzaGVsbC1zdHJpbmdpZnktdCBuaWwpKQorICAgIChzaG91bGQgKGVx dWFsIChlc2hlbGwtc3RyaW5naWZ5IHQpIG5pbCkpKSkKKworKGVydC1kZWZ0ZXN0IGVzaC11 dGlsLXRlc3QvZXNoZWxsLXN0cmluZ2lmeS9uaWwgKCkKKyAgIlRlc3QgdGhhdCBgZXNoZWxs LXN0cmluZ2lmeScgY29udmVydHMgbmlsIHRvIGEgc3RyaW5nLiIKKyAgKHNob3VsZCAoZXF1 YWwgKGVzaGVsbC1zdHJpbmdpZnkgbmlsKSAibmlsIikpKQorCisoZXJ0LWRlZnRlc3QgZXNo LXV0aWwtdGVzdC9lc2hlbGwtc3RyaW5naWZ5L2xpc3QgKCkKKyAgIlRlc3QgdGhhdCBgZXNo ZWxsLXN0cmluZ2lmeScgY29ycmVjdGx5IHN0cmluZ2lmaWVzIGxpc3RzLiIKKyAgKHNob3Vs ZCAoZXF1YWwgKGVzaGVsbC1zdHJpbmdpZnkgJygxIDIgMykpICIoMSAyIDMpIikpCisgIChz aG91bGQgKGVxdWFsIChlc2hlbGwtc3RyaW5naWZ5ICcoKDEgMikgKDMgLiA0KSkpCisgICAg ICAgICAgICAgICAgICIoKDEgMilcbiAoMyAuIDQpKSIpKSkKKworKGVydC1kZWZ0ZXN0IGVz aC11dGlsLXRlc3QvZXNoZWxsLXN0cmluZ2lmeS9jb21wbGV4ICgpCisgICJUZXN0IHRoYXQg YGVzaGVsbC1zdHJpbmdpZnknIGNvcnJlY3RseSBzdHJpbmdpZmllcyBjb21wbGV4IG9iamVj dHMuIgorICAoc2hvdWxkIChlcXVhbCAoZXNoZWxsLXN0cmluZ2lmeSAobGlzdCAncXVvdGUg J2hlbGxvKSkgIidoZWxsbyIpKSkKKworOzs7IGVzaC11dGlsLXRlc3RzLmVsIGVuZHMgaGVy ZQotLSAKMi4yNS4xCgo= --------------7s0qWWsYYehl6o92Dl0qHTRf-- From unknown Sat Aug 16 18:40:40 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Jim Porter Subject: bug#58810: closed (Re: bug#58810: 29.0.50; [PATCH] 'eshell-stringify' sometimes produces wrong results) Message-ID: References: <04d2f9ab-df6c-409e-7815-d75152bbba02@gmail.com> X-Gnu-PR-Message: they-closed 58810 X-Gnu-PR-Package: emacs X-Gnu-PR-Keywords: patch Reply-To: 58810@debbugs.gnu.org Date: Thu, 03 Nov 2022 18:50:03 +0000 Content-Type: multipart/mixed; boundary="----------=_1667501403-15158-1" This is a multi-part message in MIME format... ------------=_1667501403-15158-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #58810: 29.0.50; [PATCH] 'eshell-stringify' sometimes produces wrong results which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 58810@debbugs.gnu.org. --=20 58810: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D58810 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1667501403-15158-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 58810-done) by debbugs.gnu.org; 3 Nov 2022 18:49:04 +0000 Received: from localhost ([127.0.0.1]:50668 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oqfGy-0003ue-6E for submit@debbugs.gnu.org; Thu, 03 Nov 2022 14:49:04 -0400 Received: from mail-pj1-f54.google.com ([209.85.216.54]:35381) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oqfGv-0003tz-MG for 58810-done@debbugs.gnu.org; Thu, 03 Nov 2022 14:49:02 -0400 Received: by mail-pj1-f54.google.com with SMTP id m14-20020a17090a3f8e00b00212dab39bcdso6166863pjc.0 for <58810-done@debbugs.gnu.org>; Thu, 03 Nov 2022 11:49:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:references:to:from :content-language:subject:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to; bh=C+FBf+nWgnb2Nwn5wLb30MZkMeVNUs5sY4l+CwCgsWQ=; b=EgK/W3ZHG0BrfsB6P5LZNnNI/GcEivs0GkPVHDMSE7BhAXQddhjaYW1DLIyha9bRjy YXls+RWrbv6tE4BywWL2oRSpm5J1B45TWEamnxlaIYygMv4MhKiO9JKS5VC+lihFUsZl Lpa5W/zLrJevbFpfoWp+6fLiM2laKy2megLK40C0975zqaDNkf/OJbMVhpenehlmtP6F i/Kd0EK0+63/yTy1JsvXFFFUdoRVAj0x6EDdFBQcaiun9Zd3I0qA9OxbckuOsHAXjZLg T6jaFvY8Ok7EmCoo8YthfX7m3kB8wPfcY6GjZ7YkNScf30stKseJehGlrCt5TlkCCV9N ynMQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:references:to:from :content-language:subject:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=C+FBf+nWgnb2Nwn5wLb30MZkMeVNUs5sY4l+CwCgsWQ=; b=KcXTe1hywvdYGNjRQiXvGVFidWZmyPFuoA+UgJppHJioyYVkbyx8pKVAeCg06f5I8k DXL/HnfkO/3Hpwk6F+oRky6EAA9YWfeSifP6F1hoczfOJKxZkciWIqEXuQbXTBGHSx6t anLax70z0uVCmZAxdl3Afee1XPB35to8e1zGVRpv5lnZY5C4Puuoze2JSsU4MSklFuTv OgsZAGjD09wJK9mKm+WY1AjSoc93YLge3fk3DzpuslucEKzshnYIfVsiCZJZPhDoJkQo mU3jWf3FSUxGcCBNeKXGrizKRXQAG4mr2+37cDvWf274t3V3ysFhdSHp5MX1CWOzWp3p 67OA== X-Gm-Message-State: ACrzQf2/fcJUvezA4vkMkNzx59EdZv9zszo6LZd0AXZlBHHusRLnrA0e vSxGGUVT8STpAGtTI9oFNDa5XtP8+Oc= X-Google-Smtp-Source: AMsMyM7ONKDjWVkFMfQticJG17OH+3Ck7BcbcX+sHHrWTzQFJOQqpGU+agcqF4YMAPfp6vAJkeb+Bg== X-Received: by 2002:a17:90a:cf06:b0:212:d9ab:811b with SMTP id h6-20020a17090acf0600b00212d9ab811bmr33360301pju.65.1667501335833; Thu, 03 Nov 2022 11:48:55 -0700 (PDT) Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id o10-20020aa7978a000000b00561b53512b0sm1045719pfp.195.2022.11.03.11.48.54 for <58810-done@debbugs.gnu.org> (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 03 Nov 2022 11:48:55 -0700 (PDT) Message-ID: Date: Thu, 3 Nov 2022 11:48:54 -0700 MIME-Version: 1.0 Subject: Re: bug#58810: 29.0.50; [PATCH] 'eshell-stringify' sometimes produces wrong results Content-Language: en-US From: Jim Porter To: 58810-done@debbugs.gnu.org References: <04d2f9ab-df6c-409e-7815-d75152bbba02@gmail.com> In-Reply-To: <04d2f9ab-df6c-409e-7815-d75152bbba02@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 58810-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 10/26/2022 6:22 PM, Jim Porter wrote: > Attached is a patch with regression tests for 'eshell-stringify' so that > this works correctly. Merged as d2a9dae40057ff16683d9c5f30a3b04500ebc4cf. Closing this bug. ------------=_1667501403-15158-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 27 Oct 2022 01:22:25 +0000 Received: from localhost ([127.0.0.1]:55638 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1onrbF-0006Yr-5R for submit@debbugs.gnu.org; Wed, 26 Oct 2022 21:22:25 -0400 Received: from lists.gnu.org ([209.51.188.17]:38452) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1onrbC-0006Yh-17 for submit@debbugs.gnu.org; Wed, 26 Oct 2022 21:22:24 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1onrbB-0005vO-Od for bug-gnu-emacs@gnu.org; Wed, 26 Oct 2022 21:22:21 -0400 Received: from mail-pl1-x62e.google.com ([2607:f8b0:4864:20::62e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1onrb9-0006Oa-Le for bug-gnu-emacs@gnu.org; Wed, 26 Oct 2022 21:22:21 -0400 Received: by mail-pl1-x62e.google.com with SMTP id f23so16016492plr.6 for ; Wed, 26 Oct 2022 18:22:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:subject:from:content-language:mime-version:date:message-id:from :to:cc:subject:date:message-id:reply-to; bh=JCqVeH33I/8wcKmGadwiwoiQHkgm5UQ8wMsNSQAz6iQ=; b=UuiFekhO/xbH/AkFXe4YEwdeEztwQb7kXpqJkH2V1LiG8+9cI9pYnua8ZG/xS/8RGd mg+qd1N1OclFfMAkU/otZX2lPPKNOFcQk4fKTdBrU0ULaqkSURTOgpGoFfJ+URhZD1ZW 0+SW7Y9lUtNpbim2hXvmLguhJ9bK1A8sWhwJRa7xTfvgmw236TSmK6JpjXUtzhJq5Dvz ERuigz+WZHcEWCkBZq2snZFxthN5yaM4LVB5OOdWfmoNrVQWMS7kckOPIceHiBuu++7E gP44X6KmMKSZVES8rftwyXpooMYs3AsS+XQP77Kdo0DU9v/LUPtJOZa2l1jqEIbU3ogg 1kEA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:subject:from:content-language:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=JCqVeH33I/8wcKmGadwiwoiQHkgm5UQ8wMsNSQAz6iQ=; b=X4BFbHPrsnQ/2gZnbFsSoPYuzkIHr6RuMIK8XhSsGAqiGZEd67njaDBVLuyaGtRQqJ jRSSC1eHKMt1qcV7uG7RLKV7qZxSdDQpkFKYHP1Ijo9iLGiFiqVfgOheCqdu++7/1k84 Osc5FfiqmZ1d6RO+W8Q9PhFwnBTW7k6AfaDTPyLR3A5dYbpSS2GOg/p2G1xnHVxWygrb 1YWX7G0wH6lQLAx6XF2uj3POqwpunLQnE0OaBRQnLro7un80CHZ/TjNBpTLMNsyfywTT bl9UpJRYaOIDKvxpHYWIefPw5UD0xBkMooZvQpJtQYSNqOqij8QL/QgeGyXX4ax5DFI6 Z5ug== X-Gm-Message-State: ACrzQf0n2NDC+jdlANuZLRvgmj5jKZO+XTXWxNFVxVt1wuYwSeiGCG4N tptGh5b5P5i6pV+Yo29ZFBcufbY0iKw= X-Google-Smtp-Source: AMsMyM4OsFGvqQzoAmKM6ExsaPH+SDjtiAYW5i5GltXG2JbRjtgwA/UaK6WCyOa3JThi06yCwfrlyg== X-Received: by 2002:a17:90a:ad08:b0:212:d5f1:e0c6 with SMTP id r8-20020a17090aad0800b00212d5f1e0c6mr7094427pjq.228.1666833737229; Wed, 26 Oct 2022 18:22:17 -0700 (PDT) Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id b3-20020a170903228300b00186b55e3cd6sm3541113plh.133.2022.10.26.18.22.15 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 26 Oct 2022 18:22:16 -0700 (PDT) Content-Type: multipart/mixed; boundary="------------7s0qWWsYYehl6o92Dl0qHTRf" Message-ID: <04d2f9ab-df6c-409e-7815-d75152bbba02@gmail.com> Date: Wed, 26 Oct 2022 18:22:13 -0700 MIME-Version: 1.0 X-Mozilla-News-Host: news://news.gmane.io:119 Content-Language: en-US From: Jim Porter Subject: 29.0.50; [PATCH] 'eshell-stringify' sometimes produces wrong results To: bug-gnu-emacs@gnu.org Received-SPF: pass client-ip=2607:f8b0:4864:20::62e; envelope-from=jporterbugs@gmail.com; helo=mail-pl1-x62e.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) This is a multi-part message in MIME format. --------------7s0qWWsYYehl6o92Dl0qHTRf Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Starting from "emacs -Q -f -eshell": ~ $ echo $(list 'quote 'hello) 'hell The last character of "hello" was stripped. That's because 'eshell-stringify' tries to remove the trailing newline from 'pp-to-string', but it does so by always stripping the last character from the result. Obviously, that only works when the last character really is a newline. Attached is a patch with regression tests for 'eshell-stringify' so that this works correctly. --------------7s0qWWsYYehl6o92Dl0qHTRf Content-Type: text/plain; charset=UTF-8; name="0001-Only-strip-newlines-when-stringifying-a-value-for-Es.patch" Content-Disposition: attachment; filename*0="0001-Only-strip-newlines-when-stringifying-a-value-for-Es.pa"; filename*1="tch" Content-Transfer-Encoding: base64 RnJvbSBiYjQ0MDMxNmE1YTM4M2JhYjA5MWU1YjM1NTc3OGRiNTAyYmExYTNiIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKaW0gUG9ydGVyIDxqcG9ydGVyYnVnc0BnbWFpbC5j b20+CkRhdGU6IFN1biwgMTggU2VwIDIwMjIgMTc6NDI6MDkgLTA3MDAKU3ViamVjdDogW1BB VENIXSBPbmx5IHN0cmlwIG5ld2xpbmVzIHdoZW4gc3RyaW5naWZ5aW5nIGEgdmFsdWUgZm9y IEVzaGVsbAoKKiBsaXNwL2VzaGVsbC9lc2gtdXRpbC5lbCAoZXNoZWxsLXN0cmluZ2lmeSk6 IFVzZSAnc3RyaW5nLXRyaW0tcmlnaHQnCmluc3RlYWQgb2Ygc3RyaXBwaW5nIHRoZSBsYXN0 IGNoYXJhY3RlciBvZiB0aGUgcmVzdWx0IG9mCidwcC10by1zdHJpbmcnLgoKKiB0ZXN0L2xp c3AvZXNoZWxsL2VzaC11dGlsLXRlc3RzLmVsOiBOZXcgZmlsZS4KLS0tCiBsaXNwL2VzaGVs bC9lc2gtdXRpbC5lbCAgICAgICAgICAgIHwgMTEgKysrLS0tCiB0ZXN0L2xpc3AvZXNoZWxs L2VzaC11dGlsLXRlc3RzLmVsIHwgNTcgKysrKysrKysrKysrKysrKysrKysrKysrKysrKysr CiAyIGZpbGVzIGNoYW5nZWQsIDYxIGluc2VydGlvbnMoKyksIDcgZGVsZXRpb25zKC0pCiBj cmVhdGUgbW9kZSAxMDA2NDQgdGVzdC9saXNwL2VzaGVsbC9lc2gtdXRpbC10ZXN0cy5lbAoK ZGlmZiAtLWdpdCBhL2xpc3AvZXNoZWxsL2VzaC11dGlsLmVsIGIvbGlzcC9lc2hlbGwvZXNo LXV0aWwuZWwKaW5kZXggZjQ3MzczYzExNS4uZWNiNjg4ODY1MSAxMDA2NDQKLS0tIGEvbGlz cC9lc2hlbGwvZXNoLXV0aWwuZWwKKysrIGIvbGlzcC9lc2hlbGwvZXNoLXV0aWwuZWwKQEAg LTM1MCwxNiArMzUwLDEzIEBAIGVzaGVsbC1zdHJpbmdpZnkKICAgIkNvbnZlcnQgT0JKRUNU IGludG8gYSBzdHJpbmcgdmFsdWUuIgogICAoY29uZAogICAgKChzdHJpbmdwIG9iamVjdCkg b2JqZWN0KQotICAgKChhbmQgKGxpc3RwIG9iamVjdCkKLQkgKG5vdCAoZXEgb2JqZWN0IG5p bCkpKQotICAgIChsZXQgKChzdHJpbmcgKHBwLXRvLXN0cmluZyBvYmplY3QpKSkKLSAgICAg IChzdWJzdHJpbmcgc3RyaW5nIDAgKDEtIChsZW5ndGggc3RyaW5nKSkpKSkKICAgICgobnVt YmVycCBvYmplY3QpCiAgICAgKG51bWJlci10by1zdHJpbmcgb2JqZWN0KSkKKyAgICgoYW5k IChlcSBvYmplY3QgdCkKKwkgKG5vdCBlc2hlbGwtc3RyaW5naWZ5LXQpKQorICAgIG5pbCkK ICAgICh0Ci0gICAgKHVubGVzcyAoYW5kIChlcSBvYmplY3QgdCkKLQkJIChub3QgZXNoZWxs LXN0cmluZ2lmeS10KSkKLSAgICAgIChwcC10by1zdHJpbmcgb2JqZWN0KSkpKSkKKyAgICAo c3RyaW5nLXRyaW0tcmlnaHQgKHBwLXRvLXN0cmluZyBvYmplY3QpKSkpKQogCiAoZGVmc3Vi c3QgZXNoZWxsLXN0cmluZ2lmeS1saXN0IChhcmdzKQogICAiQ29udmVydCBlYWNoIGVsZW1l bnQgb2YgQVJHUyBpbnRvIGEgc3RyaW5nIHZhbHVlLiIKZGlmZiAtLWdpdCBhL3Rlc3QvbGlz cC9lc2hlbGwvZXNoLXV0aWwtdGVzdHMuZWwgYi90ZXN0L2xpc3AvZXNoZWxsL2VzaC11dGls LXRlc3RzLmVsCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAuLjFjYmQw MTU5OTkKLS0tIC9kZXYvbnVsbAorKysgYi90ZXN0L2xpc3AvZXNoZWxsL2VzaC11dGlsLXRl c3RzLmVsCkBAIC0wLDAgKzEsNTcgQEAKKzs7OyBlc2gtdXRpbC10ZXN0cy5lbCAtLS0gZXNo LXV0aWwgdGVzdCBzdWl0ZSAgLSotIGxleGljYWwtYmluZGluZzp0IC0qLQorCis7OyBDb3B5 cmlnaHQgKEMpIDIwMjIgRnJlZSBTb2Z0d2FyZSBGb3VuZGF0aW9uLCBJbmMuCisKKzs7IFRo aXMgZmlsZSBpcyBwYXJ0IG9mIEdOVSBFbWFjcy4KKworOzsgR05VIEVtYWNzIGlzIGZyZWUg c29mdHdhcmU6IHlvdSBjYW4gcmVkaXN0cmlidXRlIGl0IGFuZC9vciBtb2RpZnkKKzs7IGl0 IHVuZGVyIHRoZSB0ZXJtcyBvZiB0aGUgR05VIEdlbmVyYWwgUHVibGljIExpY2Vuc2UgYXMg cHVibGlzaGVkIGJ5Cis7OyB0aGUgRnJlZSBTb2Z0d2FyZSBGb3VuZGF0aW9uLCBlaXRoZXIg dmVyc2lvbiAzIG9mIHRoZSBMaWNlbnNlLCBvcgorOzsgKGF0IHlvdXIgb3B0aW9uKSBhbnkg bGF0ZXIgdmVyc2lvbi4KKworOzsgR05VIEVtYWNzIGlzIGRpc3RyaWJ1dGVkIGluIHRoZSBo b3BlIHRoYXQgaXQgd2lsbCBiZSB1c2VmdWwsCis7OyBidXQgV0lUSE9VVCBBTlkgV0FSUkFO VFk7IHdpdGhvdXQgZXZlbiB0aGUgaW1wbGllZCB3YXJyYW50eSBvZgorOzsgTUVSQ0hBTlRB QklMSVRZIG9yIEZJVE5FU1MgRk9SIEEgUEFSVElDVUxBUiBQVVJQT1NFLiAgU2VlIHRoZQor OzsgR05VIEdlbmVyYWwgUHVibGljIExpY2Vuc2UgZm9yIG1vcmUgZGV0YWlscy4KKworOzsg WW91IHNob3VsZCBoYXZlIHJlY2VpdmVkIGEgY29weSBvZiB0aGUgR05VIEdlbmVyYWwgUHVi bGljIExpY2Vuc2UKKzs7IGFsb25nIHdpdGggR05VIEVtYWNzLiAgSWYgbm90LCBzZWUgPGh0 dHBzOi8vd3d3LmdudS5vcmcvbGljZW5zZXMvPi4KKworOzs7IENvZGU6CisKKyhyZXF1aXJl ICdlcnQpCisocmVxdWlyZSAnZXNoLXV0aWwpCisKKzs7OyBUZXN0czoKKworKGVydC1kZWZ0 ZXN0IGVzaC11dGlsLXRlc3QvZXNoZWxsLXN0cmluZ2lmeS9zdHJpbmcgKCkKKyAgIlRlc3Qg dGhhdCBgZXNoZWxsLXN0cmluZ2lmeScgcHJlc2VydmVzIHRoZSB2YWx1ZSBvZiBzdHJpbmdz LiIKKyAgKHNob3VsZCAoZXF1YWwgKGVzaGVsbC1zdHJpbmdpZnkgImhlbGxvIikgImhlbGxv IikpKQorCisoZXJ0LWRlZnRlc3QgZXNoLXV0aWwtdGVzdC9lc2hlbGwtc3RyaW5naWZ5L251 bWJlciAoKQorICAiVGVzdCB0aGF0IGBlc2hlbGwtc3RyaW5naWZ5JyBjb252ZXJ0cyBudW1i ZXJzIHRvIHN0cmluZ3MuIgorICAoc2hvdWxkIChlcXVhbCAoZXNoZWxsLXN0cmluZ2lmeSA0 MikgIjQyIikpCisgIChzaG91bGQgKGVxdWFsIChlc2hlbGwtc3RyaW5naWZ5IDQuMikgIjQu MiIpKSkKKworKGVydC1kZWZ0ZXN0IGVzaC11dGlsLXRlc3QvZXNoZWxsLXN0cmluZ2lmeS90 ICgpCisgICJUZXN0IHRoYXQgYGVzaGVsbC1zdHJpbmdpZnknIHRyZWF0cyBgdCcgYWNjb3Jk aW5nIHRvIGBlc2hlbGwtc3RyaW5naWZ5LXQnLiIKKyAgKGxldCAoKGVzaGVsbC1zdHJpbmdp ZnktdCB0KSkKKyAgICAoc2hvdWxkIChlcXVhbCAoZXNoZWxsLXN0cmluZ2lmeSB0KSAidCIp KSkKKyAgKGxldCAoKGVzaGVsbC1zdHJpbmdpZnktdCBuaWwpKQorICAgIChzaG91bGQgKGVx dWFsIChlc2hlbGwtc3RyaW5naWZ5IHQpIG5pbCkpKSkKKworKGVydC1kZWZ0ZXN0IGVzaC11 dGlsLXRlc3QvZXNoZWxsLXN0cmluZ2lmeS9uaWwgKCkKKyAgIlRlc3QgdGhhdCBgZXNoZWxs LXN0cmluZ2lmeScgY29udmVydHMgbmlsIHRvIGEgc3RyaW5nLiIKKyAgKHNob3VsZCAoZXF1 YWwgKGVzaGVsbC1zdHJpbmdpZnkgbmlsKSAibmlsIikpKQorCisoZXJ0LWRlZnRlc3QgZXNo LXV0aWwtdGVzdC9lc2hlbGwtc3RyaW5naWZ5L2xpc3QgKCkKKyAgIlRlc3QgdGhhdCBgZXNo ZWxsLXN0cmluZ2lmeScgY29ycmVjdGx5IHN0cmluZ2lmaWVzIGxpc3RzLiIKKyAgKHNob3Vs ZCAoZXF1YWwgKGVzaGVsbC1zdHJpbmdpZnkgJygxIDIgMykpICIoMSAyIDMpIikpCisgIChz aG91bGQgKGVxdWFsIChlc2hlbGwtc3RyaW5naWZ5ICcoKDEgMikgKDMgLiA0KSkpCisgICAg ICAgICAgICAgICAgICIoKDEgMilcbiAoMyAuIDQpKSIpKSkKKworKGVydC1kZWZ0ZXN0IGVz aC11dGlsLXRlc3QvZXNoZWxsLXN0cmluZ2lmeS9jb21wbGV4ICgpCisgICJUZXN0IHRoYXQg YGVzaGVsbC1zdHJpbmdpZnknIGNvcnJlY3RseSBzdHJpbmdpZmllcyBjb21wbGV4IG9iamVj dHMuIgorICAoc2hvdWxkIChlcXVhbCAoZXNoZWxsLXN0cmluZ2lmeSAobGlzdCAncXVvdGUg J2hlbGxvKSkgIidoZWxsbyIpKSkKKworOzs7IGVzaC11dGlsLXRlc3RzLmVsIGVuZHMgaGVy ZQotLSAKMi4yNS4xCgo= --------------7s0qWWsYYehl6o92Dl0qHTRf-- ------------=_1667501403-15158-1--