GNU bug report logs - #58808
map-y-or-n-p should use read-key, not read-event

Previous Next

Full log

Message #20 received at 58808 <at> debbugs.gnu.org (full text, mbox):

From: Jeremy Bryant <jb <at> jeremybryant.net>
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: 58808 <at> debbugs.gnu.org
Subject: Re: bug#58808: map-y-or-n-p should use read-key, not read-event
Date: Wed, 08 Feb 2023 22:51:11 +0000

Stefan Monnier <monnier <at> iro.umontreal.ca> writes:
Hi Stefan,

In order to work on this, please could you confirm the suggested change
below from October is still the recommended one, to work on a patch
along the lines below?

Jeremy

>>> I found that map-y-or-n-p uses read-event, not read-key (still the
>>> case in master as of 2022-10-27).  Will you accept a patch if I try
>>> to rewrite it?
> [...]
>> Isn't there some translation map that could help you?
>
> No, `read-event` is the low-level function that gives access to the
> actual untranslated events.  I think `map-y-or-n-p` should be changed
> similarly to `y-or-n-p` to use either `read-key` or the minibuffer
> (probably obeying `y-or-n-p-use-read-key`).
>
>
>         Stefan

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.