From unknown Mon Aug 18 11:11:44 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#58808 <58808@debbugs.gnu.org> To: bug#58808 <58808@debbugs.gnu.org> Subject: Status: map-y-or-n-p should use read-key, not read-event Reply-To: bug#58808 <58808@debbugs.gnu.org> Date: Mon, 18 Aug 2025 18:11:44 +0000 retitle 58808 map-y-or-n-p should use read-key, not read-event reassign 58808 emacs submitter 58808 meedstrom@teknik.io severity 58808 normal thanks From debbugs-submit-bounces@debbugs.gnu.org Wed Oct 26 21:00:11 2022 Received: (at submit) by debbugs.gnu.org; 27 Oct 2022 01:00:11 +0000 Received: from localhost ([127.0.0.1]:55609 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1onrFi-00061i-CG for submit@debbugs.gnu.org; Wed, 26 Oct 2022 21:00:10 -0400 Received: from lists.gnu.org ([209.51.188.17]:49866) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1onrFd-00060S-Hs for submit@debbugs.gnu.org; Wed, 26 Oct 2022 21:00:09 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1onrFd-0004aZ-3H for bug-gnu-emacs@gnu.org; Wed, 26 Oct 2022 21:00:05 -0400 Received: from mail.teknik.io ([5.79.72.163]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1onrFY-0002lM-PC for bug-gnu-emacs@gnu.org; Wed, 26 Oct 2022 21:00:03 -0400 dkim-signature: v=1; a=rsa-sha256; d=teknik.io; s=dkim; c=relaxed/relaxed; q=dns/txt; h=From:Subject:Date:Message-ID:To:MIME-Version:Content-Type; bh=29v5LyKE50Z0xgJfw7VapkwfKRveCzlK11PiQPy9vdg=; b=lfGG5p4RcGzZJFTucT//IW6WFlctxLv2L34XeC5MM8j9c1gIZ/Jsg+JT6y+eMG0TbeH+Y7rB7dzx9W636NcLgnv37e66bQOPUyWluQ0UQinkSlZsLMWkFyrYoNZBNVFmoVjUKz6DFpQqA1wIzDP7KYV7ugifJyjD420fHBshM2DceaKUrj4F8msMFAznbU7aIp++I3k/jRVnm8sdy/S5zg+7jocd29iG2fjfbwdQ4W8QIUQVh1WW/fxEF4 qnwIhYVkWZAx5imTVUeHjjyDi0oE0c9lYnVgNsxXSiOOkNM/NiOmTHO7cfjds/GHN99GkbamK8sqQHyEz7dIU+8pVckA== Received: from mail.teknik.io (TEKNIK-SERVER [5.79.72.163]) by mail.teknik.io with ESMTPSA (version=TLSv1.2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128) ; Wed, 26 Oct 2022 16:59:46 -0700 MIME-Version: 1.0 Date: Wed, 26 Oct 2022 23:59:46 +0000 Content-Type: multipart/alternative; boundary="2903ec6f-c75b-4c64-a0c6-2c48673c9b2d-1" From: meedstrom@teknik.io Message-ID: <26bfd854bff2e7ccb0de0f1acb20ce2ced6e006a@teknik.io> Subject: map-y-or-n-p should use read-key, not read-event To: bug-gnu-emacs@gnu.org Received-SPF: pass client-ip=5.79.72.163; envelope-from=meedstrom@teknik.io; helo=mail.teknik.io X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) --2903ec6f-c75b-4c64-a0c6-2c48673c9b2d-1 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable I found that map-y-or-n-p uses read-event, not read-key (still the case i= n master as of 2022-10-27).=C2=A0 Will you accept a patch if I try to rew= rite it? Background: I like to translate to C-g, so I can hit the physica= l Esc key.=C2=A0 It almost always works, except in two cases; when Emacs = freezes, and when something calls map-y-or-n-p, like the command M-x save= -some-buffers. An additional concern is that while map-y-or-n-p is doing its thing, even= the triplet ESC ESC ESC does not work! Steps to reproduce: 1. Start Emacs -Q 2. Eval (define-key function-key-map (kbd "") (kbd "C-g")) 3. Edit some new file 4. Type C-x s to trigger save-some-buffers 5. Attempt to cancel by hitting the Escape key -------- In GNU Emacs 28.2 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.34, ca= iro version 1.17.6) of 2022-09-12 built on frederik Windowing system distributor 'The X.Org Foundation', version 11.0.1210100= 4 System Description: Arch Linux Configured using: 'configure --sysconfdir=3D/etc --prefix=3D/usr --libexecdir=3D/usr/lib --localstatedir=3D/var --with-cairo --with-harfbuzz --with-libsystemd --with-modules --with-x-toolkit=3Dgtk3 'CFLAGS=3D-march=3Dx86-64 -mtune=3Dgeneric -O2 -pipe -fno-plt -fexceptions -Wp,-D_FORTIFY_SOURCE= =3D2 -Wformat -Werror=3Dformat-security -fstack-clash-protection -fcf-protection -g -ffile-prefix-map=3D/build/emacs/src=3D/usr/src/debug -flto=3Dauto' 'LDFLAGS=3D-Wl,-O1,--sort-common,--as-needed,-z,relro,-z,n= ow -flto=3Dauto'' Configured features: ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GPM GSETTINGS HARFBUZZ JPEG JSON LCMS2 LIBOTF LIBSYSTEMD LIBXML2 M17N_FLT MODULES NOTIFY INOTIFY PDUMPER PNG RSVG SECCOMP SOUND THREADS TIFF TOOLKIT_SCROLL_BARS X11 XDBE XIM XPM GTK3 ZLIB Important settings: =C2=A0 value of $LANG: en_US.UTF-8 =C2=A0 locale-coding-system: utf-8-unix Major mode: Fundamental Minor modes in effect: =C2=A0 tooltip-mode: t =C2=A0 global-eldoc-mode: t =C2=A0 show-paren-mode: t =C2=A0 electric-indent-mode: t =C2=A0 mouse-wheel-mode: t =C2=A0 tool-bar-mode: t =C2=A0 menu-bar-mode: t =C2=A0 file-name-shadow-mode: t =C2=A0 global-font-lock-mode: t =C2=A0 font-lock-mode: t =C2=A0 blink-cursor-mode: t =C2=A0 auto-composition-mode: t =C2=A0 auto-encryption-mode: t =C2=A0 auto-compression-mode: t =C2=A0 line-number-mode: t =C2=A0 indent-tabs-mode: t =C2=A0 transient-mark-mode: t Load-path shadows: None found. Features: (shadow sort mail-extr emacsbug message rmc puny dired dired-loaddefs rfc822 mml mml-sec epa derived epg rfc6068 epg-config gnus-util rmail rmail-loaddefs auth-source cl-seq eieio eieio-core cl-macs eieio-loaddefs password-cache json map text-property-search seq byte-opt gv bytecomp byte-compile cconv mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils time-date subr-x cl-loaddefs cl-lib iso-transl tooltip eldoc paren electric uniquify ediff-hook vc-hooks lisp-float-type elisp-mode mwheel term/x-win x-win term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch easymenu timer select scroll-bar mouse jit-lock font-lock syntax font-core term/tty-colors frame minibuffer cl-generic cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite emoji-zwj charscript charprop case-table epa-hook jka-cmpr-hook help simple abbrev obarray cl-preloaded nadvice button loaddefs faces cus-face macroexp files window text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote threads dbusbind inotify lcms2 dynamic-setting system-font-setting font-render-setting cairo move-toolbar gtk x-toolkit x multi-tty make-network-process emacs) Memory information: ((conses 16 51060 7072) (symbols 48 6633 1) (strings 32 18318 1832) (string-bytes 1 604358) (vectors 16 13634) (vector-slots 8 183648 9467) (floats 8 22 46) (intervals 56 242 0) (buffers 992 12)) --2903ec6f-c75b-4c64-a0c6-2c48673c9b2d-1 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: quoted-printable
I found that map-y-or-n-p us= es read-event, not read-key (still the case in master as of 2022-10-27).= =C2=A0 Will you accept a patch if I try to rewrite it?

Background: I like to translate <escape> to C-g, so I can hi= t the physical Esc key.=C2=A0 It almost always works, except in two cases= ; when Emacs freezes, and when something calls map-y-or-n-p, like the com= mand M-x save-some-buffers.

An additional concer= n is that while map-y-or-n-p is doing its thing, even the triplet ESC ESC= ESC does not work!

Steps to reproduce:

1. Start Emacs -Q
2. Eval (define-key = function-key-map (kbd "<escape>") (kbd "C-g"))
3. Edit so= me new file
4. Type C-x s to trigger save-some-buffers
<= /div>
5. Attempt to cancel by hitting the Escape key

--------

In GNU Emacs 28.2 (build 1, x8= 6_64-pc-linux-gnu, GTK+ Version 3.24.34, cairo version 1.17.6)
= of 2022-09-12 built on frederik
Windowing system distributor '= The X.Org Foundation', version 11.0.12101004
System Description= : Arch Linux

Configured using:
'confi= gure --sysconfdir=3D/etc --prefix=3D/usr --libexecdir=3D/usr/lib
--localstatedir=3D/var --with-cairo --with-harfbuzz --with-libsystemd<= /div>
--with-modules --with-x-toolkit=3Dgtk3 'CFLAGS=3D-march=3Dx86-= 64
-mtune=3Dgeneric -O2 -pipe -fno-plt -fexceptions -Wp,-D_FOR= TIFY_SOURCE=3D2
-Wformat -Werror=3Dformat-security -fstack-cla= sh-protection
-fcf-protection -g -ffile-prefix-map=3D/build/em= acs/src=3D/usr/src/debug
-flto=3Dauto' 'LDFLAGS=3D-Wl,-O1,--so= rt-common,--as-needed,-z,relro,-z,now
-flto=3Dauto''

Configured features:
ACL CAIRO DBUS FREETYPE GI= F GLIB GMP GNUTLS GPM GSETTINGS HARFBUZZ JPEG
JSON LCMS2 LIBOTF= LIBSYSTEMD LIBXML2 M17N_FLT MODULES NOTIFY INOTIFY
PDUMPER PNG= RSVG SECCOMP SOUND THREADS TIFF TOOLKIT_SCROLL_BARS X11 XDBE
X= IM XPM GTK3 ZLIB

Important settings:
= =C2=A0 value of $LANG: en_US.UTF-8
=C2=A0 locale-coding-system:= utf-8-unix

Major mode: Fundamental
Minor modes in effect:
=C2=A0 tooltip-mode: t
=C2=A0 global-eldoc-mode: t
=C2=A0 show-paren-mode: t
=C2=A0 electric-indent-mode: t
=C2=A0 mouse-wheel-mode: = t
=C2=A0 tool-bar-mode: t
=C2=A0 menu-bar-mode: t
=C2=A0 file-name-shadow-mode: t
=C2=A0 global-font-lock-= mode: t
=C2=A0 font-lock-mode: t
=C2=A0 blink-cursor-= mode: t
=C2=A0 auto-composition-mode: t
=C2=A0 auto-e= ncryption-mode: t
=C2=A0 auto-compression-mode: t
=C2= =A0 line-number-mode: t
=C2=A0 indent-tabs-mode: t
= =C2=A0 transient-mark-mode: t

Load-path shadows:=
None found.

Features:
(shad= ow sort mail-extr emacsbug message rmc puny dired dired-loaddefs
rfc822 mml mml-sec epa derived epg rfc6068 epg-config gnus-util rmail
rmail-loaddefs auth-source cl-seq eieio eieio-core cl-macs
=
eieio-loaddefs password-cache json map text-property-search seq byte= -opt
gv bytecomp byte-compile cconv mm-decode mm-bodies mm-enco= de mail-parse
rfc2231 mailabbrev gmm-utils mailheader sendmail = rfc2047 rfc2045
ietf-drums mm-util mail-prsvr mail-utils time-d= ate subr-x cl-loaddefs
cl-lib iso-transl tooltip eldoc paren el= ectric uniquify ediff-hook
vc-hooks lisp-float-type elisp-mode = mwheel term/x-win x-win
term/common-win x-dnd tool-bar dnd font= set image regexp-opt fringe
tabulated-list replace newcomment t= ext-mode lisp-mode prog-mode register
page tab-bar menu-bar rfn= -eshadow isearch easymenu timer select
scroll-bar mouse jit-loc= k font-lock syntax font-core term/tty-colors
frame minibuffer c= l-generic cham georgian utf-8-lang misc-lang
vietnamese tibetan= thai tai-viet lao korean japanese eucjp-ms cp51932
hebrew gree= k romanian slovak czech european ethiopic indian cyrillic
chine= se composite emoji-zwj charscript charprop case-table epa-hook
= jka-cmpr-hook help simple abbrev obarray cl-preloaded nadvice button
loaddefs faces cus-face macroexp files window text-properties overl= ay
sha1 md5 base64 format env code-pages mule custom widget
hashtable-print-readable backquote threads dbusbind inotify lcms2<= /div>
dynamic-setting system-font-setting font-render-setting cairo
move-toolbar gtk x-toolkit x multi-tty make-network-process emac= s)

Memory information:
((conses 16 510= 60 7072)
(symbols 48 6633 1)
(strings 32 18318 1832= )
(string-bytes 1 604358)
(vectors 16 13634)
<= div> (vector-slots 8 183648 9467)
(floats 8 22 46)
= (intervals 56 242 0)
(buffers 992 12))

--2903ec6f-c75b-4c64-a0c6-2c48673c9b2d-1-- From debbugs-submit-bounces@debbugs.gnu.org Thu Oct 27 01:59:10 2022 Received: (at 58808) by debbugs.gnu.org; 27 Oct 2022 05:59:10 +0000 Received: from localhost ([127.0.0.1]:55950 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1onvv4-0005it-1c for submit@debbugs.gnu.org; Thu, 27 Oct 2022 01:59:10 -0400 Received: from eggs.gnu.org ([209.51.188.92]:52894) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1onvv1-0005ie-KA for 58808@debbugs.gnu.org; Thu, 27 Oct 2022 01:59:08 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1onvuw-0005Qd-7W; Thu, 27 Oct 2022 01:59:02 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=UqXS087l1RGHof7Q2/Pc2BJqk6tjBTaMbheJQBRpynU=; b=bmboE2ZAwONx YNiZocw3B0GyKnN0NL1iuw18uhG5GcMH1u+Umhwpy/98SxwxttGXvS+MB6pKDtegsc205b0BXuzbQ e8sJGtMSmcWlkoscVFjktlFc1d/kvpcXWxUZmwphwWE9QDGnYOQRCiRmxN7gORRgzSohBuUT+JMEH 9o6QDvA+zyDMoI3CNjAVjaTyW0jBf34v18h6KFXS1LMtBHm1kLhXKhXIEgeK8XhN7gi1Q9x5bs1yX QHcUbSz1XfKHhn0o7bjkeUQJKgpKbE9e403qg/mHRjOF98ETC4ewBAuxbd08qS5lJRK0Yse/kUY9t 6w/KihM7wvcHhorstPX2xw==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1onvuv-0001Ay-Ib; Thu, 27 Oct 2022 01:59:01 -0400 Date: Thu, 27 Oct 2022 08:58:53 +0300 Message-Id: <83fsf9n6xu.fsf@gnu.org> From: Eli Zaretskii To: meedstrom@teknik.io, Stefan Monnier In-Reply-To: <26bfd854bff2e7ccb0de0f1acb20ce2ced6e006a@teknik.io> (bug-gnu-emacs@gnu.org) Subject: Re: bug#58808: map-y-or-n-p should use read-key, not read-event References: <26bfd854bff2e7ccb0de0f1acb20ce2ced6e006a@teknik.io> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 58808 Cc: 58808@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Wed, 26 Oct 2022 23:59:46 +0000 > From: meedstrom--- via "Bug reports for GNU Emacs, > the Swiss army knife of text editors" > > I found that map-y-or-n-p uses read-event, not read-key (still the case in master as of 2022-10-27). Will you > accept a patch if I try to rewrite it? > > Background: I like to translate to C-g, so I can hit the physical Esc key. It almost always works, > except in two cases; when Emacs freezes, and when something calls map-y-or-n-p, like the command M-x > save-some-buffers. > > An additional concern is that while map-y-or-n-p is doing its thing, even the triplet ESC ESC ESC does not > work! > > Steps to reproduce: > > 1. Start Emacs -Q > 2. Eval (define-key function-key-map (kbd "") (kbd "C-g")) > 3. Edit some new file > 4. Type C-x s to trigger save-some-buffers > 5. Attempt to cancel by hitting the Escape key Isn't there some translation map that could help you? Adding Stefan to CC, in case he has comments. (I'd assume that map-y-or-n-p would work like y-or-n-p, including support for y-or-n-p-use-read-key, but evidently it doesn't, which is surprising, I think.) From debbugs-submit-bounces@debbugs.gnu.org Thu Oct 27 07:01:39 2022 Received: (at 58808) by debbugs.gnu.org; 27 Oct 2022 11:01:39 +0000 Received: from localhost ([127.0.0.1]:56262 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oo0dn-000598-7A for submit@debbugs.gnu.org; Thu, 27 Oct 2022 07:01:39 -0400 Received: from mail.teknik.io ([5.79.72.163]:54274) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oo0dl-00058t-09 for 58808@debbugs.gnu.org; Thu, 27 Oct 2022 07:01:37 -0400 dkim-signature: v=1; a=rsa-sha256; d=teknik.io; s=dkim; c=relaxed/relaxed; q=dns/txt; h=From:Subject:Date:Message-ID:To:CC:MIME-Version:Content-Type:Content-Transfer-Encoding:In-Reply-To:References; bh=XS2od/Pk8x+FUzcUhSASBZ2BnerV3RPLfQlmPVPAaBg=; b=F9UNisEa8uMjZja198jRGjft7u2QBbFohkxlBaH85snGucgU/doIid72Av7Z76XXbrDDpJsvM0mX0Q7GJHqDmNJFDatl7j5SMw8txpAb+wxZ+3pcVI/nwscUCUKigCHYpEx2N+vb7ZyCh+N41u3lbib7wtCsloGoFx+7lhCA624sVS2m348h80xdotetI0G3BrLDHj1Cm0C7Fr+Lt+VsvrRjOvQh5UYMQA7CVqHAKySb6WYlRUYMW+of+v OSm8eEu2sUN/RRsmbYYrAFT8lBByBkjewR6L6tjrfZLKMEPCxI9mHRteXyjFsFULAXvjjWnbA49CovKGGw3zj7kaYn9A== Received: from mail.teknik.io (TEKNIK-SERVER [5.79.72.163]) by mail.teknik.io with ESMTPSA (version=TLSv1.2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128) ; Thu, 27 Oct 2022 04:01:16 -0700 MIME-Version: 1.0 Date: Thu, 27 Oct 2022 11:01:15 +0000 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable From: meedstrom@teknik.io Message-ID: Subject: Re: bug#58808: map-y-or-n-p should use read-key, not read-event To: "Eli Zaretskii" , "Stefan Monnier" In-Reply-To: <83fsf9n6xu.fsf@gnu.org> References: <83fsf9n6xu.fsf@gnu.org> <26bfd854bff2e7ccb0de0f1acb20ce2ced6e006a@teknik.io> X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 58808 Cc: 58808@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) October 27, 2022 at 5:58 AM, "Eli Zaretskii" wrote: =20 >=20Isn't there some translation map that could help you? I have tried the remap in all of these: - input-decode-map - key-translation-map - function-key-map - all of the above simultaneously I don't mind letting C-g be a separate key just for unfreezing Emacs, but= in all other cases it seems right for an Escape remap to Just Work. Martin From debbugs-submit-bounces@debbugs.gnu.org Thu Oct 27 11:39:27 2022 Received: (at 58808) by debbugs.gnu.org; 27 Oct 2022 15:39:27 +0000 Received: from localhost ([127.0.0.1]:59010 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oo4yZ-0006o8-UT for submit@debbugs.gnu.org; Thu, 27 Oct 2022 11:39:27 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:38783) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oo4yV-0006ns-J2 for 58808@debbugs.gnu.org; Thu, 27 Oct 2022 11:39:22 -0400 Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id CDD6880355; Thu, 27 Oct 2022 11:39:13 -0400 (EDT) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 295D58035A; Thu, 27 Oct 2022 11:39:12 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1666885152; bh=FKvuuWYiRTGwn6EiiCadId16nKSgmZx5vibdexiafOw=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=PRbz6cZI7B9jioMutDUlqa4XGBj97E2YkD5PzLFuyPrIxhtKGo8jN4rZNvQRePhaE 880MgXIwaxpjHEclh/LOzqZAHtMGlU2E8j8AApKBVJ8TpbBsMKhD+lw3FqdWwmA4bY QAvAeNUk46Rk6lZTiFhJq13bP7pfb00t4PirZUG7kDHjzB8owG/mTmx2Q3qQIRgoMd 3uU308BeO4AGkY6nh7lPImGUzBLiCgEZ8/3EeNimVKNPvjvEPuGdJnojHGf6SGOqcn h4CVpoL5tAFi66EJS8plwUu7NZwU9i8eMsJQUL+iBvPh+cEsWRTKYKGDEbfynlyCLm AkFmxCC+59/+Q== Received: from alfajor (unknown [45.44.229.252]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id BED441203D7; Thu, 27 Oct 2022 11:39:11 -0400 (EDT) From: Stefan Monnier To: Eli Zaretskii Subject: Re: bug#58808: map-y-or-n-p should use read-key, not read-event In-Reply-To: <83fsf9n6xu.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 27 Oct 2022 08:58:53 +0300") Message-ID: References: <26bfd854bff2e7ccb0de0f1acb20ce2ced6e006a@teknik.io> <83fsf9n6xu.fsf@gnu.org> Date: Thu, 27 Oct 2022 11:39:10 -0400 User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL 0.189 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 58808 Cc: 58808@debbugs.gnu.org, meedstrom@teknik.io X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) >> I found that map-y-or-n-p uses read-event, not read-key (still the >> case in master as of 2022-10-27). Will you accept a patch if I try >> to rewrite it? [...] > Isn't there some translation map that could help you? No, `read-event` is the low-level function that gives access to the actual untranslated events. I think `map-y-or-n-p` should be changed similarly to `y-or-n-p` to use either `read-key` or the minibuffer (probably obeying `y-or-n-p-use-read-key`). Stefan From debbugs-submit-bounces@debbugs.gnu.org Wed Feb 08 18:59:42 2023 Received: (at 58808) by debbugs.gnu.org; 8 Feb 2023 23:59:42 +0000 Received: from localhost ([127.0.0.1]:56905 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pPuLm-0000Ey-1G for submit@debbugs.gnu.org; Wed, 08 Feb 2023 18:59:42 -0500 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:28120) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pPuLi-0000Eg-09 for 58808@debbugs.gnu.org; Wed, 08 Feb 2023 18:59:40 -0500 Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 5FB39808C2; Wed, 8 Feb 2023 18:59:32 -0500 (EST) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id A206280793; Wed, 8 Feb 2023 18:59:30 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1675900770; bh=R+A4N4/8zN72wpnOP+cGhBx/HiPQHyz8d7mZd/X/fpk=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=e/i1PCdhXyBWIsZ5Jv45gVZo2h45mTGdyTBV9K8Y5d9RPVHVjQtCvjkrneGwg8Q4D OHUbiHgZOoeB6tlqCtpQOCPgr5v8z1ZHix9oUA5OUojhz3xH+khJVpE4gEqr84Z2De Ji3CUPK+a4o0ZjL8AFMJ3KvLRNU8YyGB0ge0e48/OE2ADh/XSgSqjDaTcYLJUmilcL CI1HQ+lTvWhk4vCrft7mIZ06/lPM2y18tzBzr8wSpDliIQBca6xixvgtUwUk7pdO14 /cTwMRx5w41alxbHhNLQPx25J0YzpSUTWnL6bmI47BPCSJFuBvhylIvcYeS4naf0yO yX+LdnkF+j5xQ== Received: from pastel (unknown [104.247.245.112]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 572FA12307B; Wed, 8 Feb 2023 18:59:30 -0500 (EST) From: Stefan Monnier To: Jeremy Bryant Subject: Re: bug#58808: map-y-or-n-p should use read-key, not read-event In-Reply-To: <87fsbfu5y8.fsf@jeremybryant.net> (Jeremy Bryant's message of "Wed, 08 Feb 2023 22:51:11 +0000") Message-ID: References: <26bfd854bff2e7ccb0de0f1acb20ce2ced6e006a@teknik.io> <83fsf9n6xu.fsf@gnu.org> <87fsbfu5y8.fsf@jeremybryant.net> Date: Wed, 08 Feb 2023 18:59:28 -0500 User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 58808 Cc: Eli Zaretskii , 58808@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > In order to work on this, please could you confirm the suggested change > below from October is still the recommended one, to work on a patch > along the lines below? Nothing has changed in this regard, indeed, so my comment from last year is still as valid as ever :-) Stefan From debbugs-submit-bounces@debbugs.gnu.org Wed Feb 08 22:38:35 2023 Received: (at 58808) by debbugs.gnu.org; 9 Feb 2023 03:38:35 +0000 Received: from localhost ([127.0.0.1]:57106 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pPxlY-00065X-Vd for submit@debbugs.gnu.org; Wed, 08 Feb 2023 22:38:35 -0500 Received: from p3plsmtp17-03-2.prod.phx3.secureserver.net ([173.201.193.166]:40798 helo=p3plwbeout17-03.prod.phx3.secureserver.net) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pPtHd-0006sk-3N for 58808@debbugs.gnu.org; Wed, 08 Feb 2023 17:51:22 -0500 Received: from mailex.mailcore.me ([94.136.40.145]) by :WBEOUT: with ESMTP id PtHUpplkE6DsKPtHUpMlCl; Wed, 08 Feb 2023 15:51:13 -0700 X-CMAE-Analysis: v=2.4 cv=DsOTREz+ c=1 sm=1 tr=0 ts=63e42762 a=7e6w4QD8YWtpVJ/7+iiidw==:117 a=nzDM7VRi/FXkTBRroS9HBg==:17 a=yM0T0u6Ik-0A:10 a=m04uMKEZRckA:10 a=iRZporoAAAAA:8 a=JKSuXWEfkVFDHtsCQmoA:9 a=NOBgFS-JBQ2l-kSd6-zu:22 X-SECURESERVER-ACCT: jb@jeremybryant.net X-SID: PtHUpplkE6DsK Received: from [152.37.91.204] (helo=hexa3.local.com) by smtp07.mailcore.me with esmtpa (Exim 4.94.2) (envelope-from ) id 1pPtHV-00025c-AX; Wed, 08 Feb 2023 22:51:13 +0000 From: Jeremy Bryant To: Stefan Monnier To: "Eli Zaretskii" Subject: Re: bug#58808: map-y-or-n-p should use read-key, not read-event In-Reply-To: (Stefan Monnier's message of "Thu, 27 Oct 2022 11:39:10 -0400") References: <26bfd854bff2e7ccb0de0f1acb20ce2ced6e006a@teknik.io> <83fsf9n6xu.fsf@gnu.org> Date: Wed, 08 Feb 2023 22:51:11 +0000 Message-ID: <87fsbfu5y8.fsf@jeremybryant.net> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Mailcore-Auth: 278589627 X-Mailcore-Domain: 1689493 X-123-reg-Authenticated: jb@jeremybryant.net X-Originating-IP: 152.37.91.204 X-CMAE-Envelope: MS4xfFtRTOn+nA6OTLdKpmdhdLjjmjle8UGxyJEBCInkqe9yl12lPURwa0P7hm8gELRGvh7UaPDLvmmHTNuw8oaO+XE/wfwG71xtK9dkFxJEinC77dgUDkMv EPQXk1+aOhEm71Gyaq/IBjmGXQFwQdr4Vg5g/zOZqfxz5OE3sUfqWGZIteFETyR0kTxKN+QrFUO11xoZbW0j8cvB4ThmfvFlmFk= X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 58808 X-Mailman-Approved-At: Wed, 08 Feb 2023 22:38:31 -0500 Cc: 58808@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Stefan Monnier writes: Hi Stefan, In order to work on this, please could you confirm the suggested change below from October is still the recommended one, to work on a patch along the lines below? Jeremy >>> I found that map-y-or-n-p uses read-event, not read-key (still the >>> case in master as of 2022-10-27). Will you accept a patch if I try >>> to rewrite it? > [...] >> Isn't there some translation map that could help you? > > No, `read-event` is the low-level function that gives access to the > actual untranslated events. I think `map-y-or-n-p` should be changed > similarly to `y-or-n-p` to use either `read-key` or the minibuffer > (probably obeying `y-or-n-p-use-read-key`). > > > Stefan