From debbugs-submit-bounces@debbugs.gnu.org Wed Oct 26 11:01:38 2022 Received: (at submit) by debbugs.gnu.org; 26 Oct 2022 15:01:38 +0000 Received: from localhost ([127.0.0.1]:55072 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1onhuU-0003Ts-70 for submit@debbugs.gnu.org; Wed, 26 Oct 2022 11:01:38 -0400 Received: from lists.gnu.org ([209.51.188.17]:33436) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1onhuO-0003Tc-J3 for submit@debbugs.gnu.org; Wed, 26 Oct 2022 11:01:36 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1onhuM-0002vV-Tv for bug-gnu-emacs@gnu.org; Wed, 26 Oct 2022 11:01:32 -0400 Received: from mail.choca.pics ([80.67.172.235]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1onhuI-0008C4-LB for bug-gnu-emacs@gnu.org; Wed, 26 Oct 2022 11:01:30 -0400 Received: from localhost (localhost.localdomain [IPv6:::1]) by mail.choca.pics (Postfix) with ESMTP id CA691181942C3 for ; Wed, 26 Oct 2022 17:01:05 +0200 (CEST) Received: from mail.choca.pics ([IPv6:::1]) by localhost (mail.choca.pics [IPv6:::1]) (amavisd-new, port 10032) with ESMTP id 0VxeRePahpWb for ; Wed, 26 Oct 2022 17:01:04 +0200 (CEST) Received: from localhost (localhost.localdomain [IPv6:::1]) by mail.choca.pics (Postfix) with ESMTP id CB452181942C4 for ; Wed, 26 Oct 2022 17:01:04 +0200 (CEST) X-Virus-Scanned: amavisd-new at choca.pics Received: from mail.choca.pics ([IPv6:::1]) by localhost (mail.choca.pics [IPv6:::1]) (amavisd-new, port 10026) with ESMTP id Yhg4ERUjC6VZ for ; Wed, 26 Oct 2022 17:01:04 +0200 (CEST) Received: from localhost (240-68-190-109.dsl.ovh.fr [109.190.68.240]) by mail.choca.pics (Postfix) with ESMTPSA id 6D74F181942C3 for ; Wed, 26 Oct 2022 17:01:04 +0200 (CEST) From: Damien Cassou To: bug-gnu-emacs@gnu.org Subject: Make winner key sequences repeatable in repeat-mode Date: Wed, 26 Oct 2022 17:01:03 +0200 Message-ID: <87y1t2zl1s.fsf@cassou.me> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Received-SPF: pass client-ip=80.67.172.235; envelope-from=damien@cassou.me; helo=mail.choca.pics X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_HK_SPAMMY_FILENAME=0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) --=-=-= Content-Type: text/plain Tags: patch In GNU Emacs 28.2 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.34, cairo version 1.16.0) Windowing system distributor 'The X.Org Foundation', version 11.0.12014000 System Description: Fedora Linux 36 (Workstation Edition) Configured using: 'configure --prefix=/nix/store/1ihp8r45mw29fdipjmqrm2vk0fvwd86x-emacs-28.2 --disable-build-details --with-modules --with-x-toolkit=gtk3 --with-xft --with-cairo --with-native-compilation' -- Damien Cassou "Success is the ability to go from one failure to another without losing enthusiasm." --Winston Churchill --=-=-= Content-Type: text/patch Content-Disposition: attachment; filename=0001-Make-winner-key-sequences-repeatable-in-repeat-mode.patch >From 2f26bbad08f71cb4332cd60fa5698a8c18b4abd2 Mon Sep 17 00:00:00 2001 From: Damien Cassou Date: Wed, 26 Oct 2022 16:53:23 +0200 Subject: [PATCH] Make winner key sequences repeatable in repeat-mode * lisp/winner.el (winner-repeat-map): New variable. (winner-undo): Put 'repeat-map' property with 'winner-repeat-map'. (winner-redo): Put 'repeat-map' property with 'winner-repeat-map'. --- lisp/winner.el | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/lisp/winner.el b/lisp/winner.el index 174b698e7b..30b0a6ada8 100644 --- a/lisp/winner.el +++ b/lisp/winner.el @@ -328,6 +328,14 @@ winner-mode-map map) "Keymap for Winner mode.") +(defvar-keymap winner-repeat-map + :doc "Keymap to repeat winner key sequences. Used in `repeat-mode'." + [left] #'winner-undo + [right] #'winner-redo) + +(put #'winner-undo 'repeat-map 'winner-repeat-map) +(put #'winner-redo 'repeat-map 'winner-repeat-map) + ;;;###autoload (define-minor-mode winner-mode -- 2.36.2 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Wed Oct 26 15:52:38 2022 Received: (at 58799) by debbugs.gnu.org; 26 Oct 2022 19:52:38 +0000 Received: from localhost ([127.0.0.1]:55326 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1onmS5-0006ip-WF for submit@debbugs.gnu.org; Wed, 26 Oct 2022 15:52:38 -0400 Received: from mail-oi1-f180.google.com ([209.85.167.180]:36667) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1onmS4-0006ia-5N for 58799@debbugs.gnu.org; Wed, 26 Oct 2022 15:52:36 -0400 Received: by mail-oi1-f180.google.com with SMTP id s206so6706063oie.3 for <58799@debbugs.gnu.org>; Wed, 26 Oct 2022 12:52:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:to:subject:message-id:date:mime-version :references:in-reply-to:from:from:to:cc:subject:date:message-id :reply-to; bh=LM8b0QFUsWLApqqsmYz61iI+kPYqlyCjIG+ofZP16R4=; b=cGgAtosyAD/eVl12Rfklo9qVHm3nybJ8rMYzE3sfTuETcOp+t4XkskSF6X9xTuXOJ9 5Wrmywi72a7m0PX+//86csKoCgyQLek5MgrGTXma/NeSdnu+yKE7qEsJIS8O4yUNKp89 5Yr2eQoNtHwgEhD5zWYzdJ2+LPXi6zPeEbXwHpTReqFg8NaXkI1iG2oS2wGTveW5ZKbs JRL/8S1a/zNUKp9nJ6pUYHACfifXgqmpZLW14Bmn3WSjS1EgqCGkEmJPYfcspi9AP33O /uwScK5mweRIJ8SuREkQ4FT/uNunaIrKlZtCL1vL3tSgt2MX6Y1+4KcvKFEqOBO4fsIY M58w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:to:subject:message-id:date:mime-version :references:in-reply-to:from:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=LM8b0QFUsWLApqqsmYz61iI+kPYqlyCjIG+ofZP16R4=; b=EbhzuwEj+9sC/ndHGOI+R9dL/zb2EmtXn3cT1h7xX1wpotXQlRWlMz6MniekWMvmP7 QikllcqWyiVgwHB6wIR2TgJ63tclA9emKdAmNxjhih37vmF293xkFZuJ+Ah8bhgLXTXO udtoOjCeV1Kh02T5lySOV4Zeu584Lx8P/QF9oPJXBKQqzVg9xRyf5qoX+MduqTt3UiVd hjE4S77lHp6dffeoJIEyT7/K4i2dmhlslCphK9NTe2ezlohUIkT9TQmGz3yVJ9zKJajB 7bs1ccegHQ7DKMKMXDbMTn3cBTRSE9T8F3f7rlxoIhGDBXonkUTxOyIrtBgYMLmG7rpm 99ag== X-Gm-Message-State: ACrzQf1t0edXc+CHimPrQpvlA1xAygg7J1YJ/dyAtaXlNJU73DTHgMmn 2l28F90+2MKICUlib/b6KY0jPbmW6KULz3zuL7nrV8Sz X-Google-Smtp-Source: AMsMyM6xRr82PifWu3ZseOLYjfDVo8Bri/2qfMzh1UWszcwfSzM+Q8w9bj8YBMtL2Slag6FbglDxfuCdxlaSXlji9N0= X-Received: by 2002:a05:6808:1186:b0:353:b77a:a481 with SMTP id j6-20020a056808118600b00353b77aa481mr2833040oil.199.1666813950522; Wed, 26 Oct 2022 12:52:30 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Wed, 26 Oct 2022 12:52:29 -0700 From: Stefan Kangas In-Reply-To: <87y1t2zl1s.fsf@cassou.me> References: <87y1t2zl1s.fsf@cassou.me> X-Hashcash: 1:20:221026:58799@debbugs.gnu.org::dYWS7EBTLrAiu3F+:5SsC MIME-Version: 1.0 Date: Wed, 26 Oct 2022 12:52:29 -0700 Message-ID: Subject: Re: bug#58799: Make winner key sequences repeatable in repeat-mode To: Damien Cassou , 58799@debbugs.gnu.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 58799 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Damien Cassou writes: > From 2f26bbad08f71cb4332cd60fa5698a8c18b4abd2 Mon Sep 17 00:00:00 2001 > From: Damien Cassou > Date: Wed, 26 Oct 2022 16:53:23 +0200 > Subject: [PATCH] Make winner key sequences repeatable in repeat-mode > > * lisp/winner.el (winner-repeat-map): New variable. > (winner-undo): Put 'repeat-map' property with 'winner-repeat-map'. > (winner-redo): Put 'repeat-map' property with 'winner-repeat-map'. There is no need to repeat the same text twice, so you can delete the first occurrence. > --- > lisp/winner.el | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/lisp/winner.el b/lisp/winner.el > index 174b698e7b..30b0a6ada8 100644 > --- a/lisp/winner.el > +++ b/lisp/winner.el > @@ -328,6 +328,14 @@ winner-mode-map > map) > "Keymap for Winner mode.") > > +(defvar-keymap winner-repeat-map > + :doc "Keymap to repeat winner key sequences. Used in `repeat-mode'." > + [left] #'winner-undo > + [right] #'winner-redo) It should be "" and "" here, I think. > + > +(put #'winner-undo 'repeat-map 'winner-repeat-map) > +(put #'winner-redo 'repeat-map 'winner-repeat-map) > + > =0C > ;;;###autoload > (define-minor-mode winner-mode > -- > 2.36.2 From debbugs-submit-bounces@debbugs.gnu.org Thu Oct 27 05:04:40 2022 Received: (at 58799) by debbugs.gnu.org; 27 Oct 2022 09:04:40 +0000 Received: from localhost ([127.0.0.1]:56154 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1onyoa-00025R-Be for submit@debbugs.gnu.org; Thu, 27 Oct 2022 05:04:40 -0400 Received: from mail-wr1-f54.google.com ([209.85.221.54]:37462) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1onyoW-00025C-RT for 58799@debbugs.gnu.org; Thu, 27 Oct 2022 05:04:38 -0400 Received: by mail-wr1-f54.google.com with SMTP id bs21so1063516wrb.4 for <58799@debbugs.gnu.org>; Thu, 27 Oct 2022 02:04:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=HgUfAnIop4EBjAPyXVNyCghzI7WxCvJKs9tzmLdSOOQ=; b=GGVPD06qG253UoZQeN9EAmcX7RZBjmfDMarIv2D43DBSgqxgT0VtVu1VB6l2M7qmt8 jdFm2criHXXothdd3PR6rKZ6W3+EjCcz785Ff5KooViGrpezdU0On5QWWciMKPPqYnsW Z58MuybhqU2mAw0pSxNfERGb728tzvGCEe79OAfvbzT9zUsasoeoBIeQ0+JnmUBC5oH7 tqsTDYgrNZMLQecsjeQl+IhfTdqrvGBODftnibku/SrC3wWK8wjSDRTYzXcmiT/GfAxD vlI8+rOH/Y8Sc85Zr14NX2O0uIjZxd24gCAeuaru50mViboife7fkzxpTgzyGy1Npr2m +XpQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=HgUfAnIop4EBjAPyXVNyCghzI7WxCvJKs9tzmLdSOOQ=; b=lI2GMvrh0/sdhl02JUteIjyhbG+XeRNNbPqzwdoUozyAKFULjouHSPh721ty728ZT6 /k8X40OjEFnLKuUnBk+Qjk3gD5yMQvaGRN+Nppb4oS7bdCO3mgTG2tlTr0oDMLr7Gu4M SvMZzDPYrQ2b03/Lw4rSmN5p5r6W917LNCgJ+IIEwrUmXI7z+4/Im24djfzySKPIiV8M 6rwQ9uVsHwB4ZB5bQubPvj39XanRs3kSUgri/6Nj74POvboJiEit825BYxUYktotJ4xr 80x3kDIvB2AcDJ1B2GI1kh5jRKJO69SFoUpNVAPJfEpi0bfw0LeIISS/37hmCPcZXYAQ hAMg== X-Gm-Message-State: ACrzQf2XkOMRnwN3s4GFQ7XW5v7qCQrmoojria+YGcqer6jfE85v8Npi CFwVIuL5H0zHSm7HvvofhCcdoZQXWGM= X-Google-Smtp-Source: AMsMyM57UhRXshO+epVOkv+gPtyf0Sr1xZ/56hp77oZDh903EFZ1PP8I638DdSmJ6t15TI3JZ2cqLg== X-Received: by 2002:a05:6000:811:b0:236:622d:a7d6 with SMTP id bt17-20020a056000081100b00236622da7d6mr17317132wrb.258.1666861470522; Thu, 27 Oct 2022 02:04:30 -0700 (PDT) Received: from rltb ([82.66.8.55]) by smtp.gmail.com with ESMTPSA id v12-20020a05600c15cc00b003c6cd82596esm3779913wmf.43.2022.10.27.02.04.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 27 Oct 2022 02:04:29 -0700 (PDT) From: Robert Pluim To: Stefan Kangas Subject: Re: bug#58799: Make winner key sequences repeatable in repeat-mode In-Reply-To: (Stefan Kangas's message of "Wed, 26 Oct 2022 12:52:29 -0700") References: <87y1t2zl1s.fsf@cassou.me> Date: Thu, 27 Oct 2022 11:04:29 +0200 Message-ID: <87fsf9vdr6.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 58799 Cc: Damien Cassou , 58799@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >>>>> On Wed, 26 Oct 2022 12:52:29 -0700, Stefan Kangas said: >> +(defvar-keymap winner-repeat-map >> + :doc "Keymap to repeat winner key sequences. Used in `repeat-mod= e'." >> + [left] #'winner-undo >> + [right] #'winner-redo) Stefan> It should be "" and "" here, I think. Hmm, that=CA=BCs an interesting one: (key-valid-p "[right]") =3D> nil (key-valid-p "") =3D> t but (kbd "") =3D> [right] (keymap-set global-map (kbd "") #=CA=BCignore) =3D> error :-) Robert --=20 From debbugs-submit-bounces@debbugs.gnu.org Thu Oct 27 06:59:07 2022 Received: (at 58799) by debbugs.gnu.org; 27 Oct 2022 10:59:07 +0000 Received: from localhost ([127.0.0.1]:56258 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oo0bG-00053n-Ay for submit@debbugs.gnu.org; Thu, 27 Oct 2022 06:59:06 -0400 Received: from mail-ot1-f48.google.com ([209.85.210.48]:42702) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oo0az-000533-3f for 58799@debbugs.gnu.org; Thu, 27 Oct 2022 06:59:00 -0400 Received: by mail-ot1-f48.google.com with SMTP id a13-20020a9d6e8d000000b00668d65fc44fso624248otr.9 for <58799@debbugs.gnu.org>; Thu, 27 Oct 2022 03:58:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date :mime-version:references:in-reply-to:from:from:to:cc:subject:date :message-id:reply-to; bh=js2uCEkH5in4H5mjWiaylIpUZ/5CknrYg3VJBupQpc4=; b=q0cnY2hLfrn6Zf2+cyD3TMavj5IbCyZv3cLeGHLfWkH0IGVHbaTk36/cV9SN7C0fj1 UcvMYae9va9j2edlb0HrsXz+7sLTr+fQPw9YXIIqEMdqA5Tfe43wwj5Cp9TaTMICcFel btfjmgNdUksMCFdv2GQLedkKXoDBbYmK1oGZzMA6JGZ3X0hCw7n2lVSp84QV/A3F990r pGZ6gZhJ4DzjAM7NQqa+JG3wiClOSMZBNiFXBfH5ZjwSqCl7Yv7I6juuhz6hJfv/dhH7 b2NXeqO4Lp/l9RiO8Sf3sLfpz3JCVAPegME4pOUPuDS91/+nNcrK5pbx+fM0XiSr3pOd 2d/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date :mime-version:references:in-reply-to:from:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=js2uCEkH5in4H5mjWiaylIpUZ/5CknrYg3VJBupQpc4=; b=auCc1Rq4pd7rtGXXegCETjANw4aZpNQF/S/jC2Syo13FUEHOzttRTXqg83QM+m6wcX 17kglC+jqJm/GVXUiP6bhusI6qfJyEtcwuZjDMV2PvHO6Wf9YLI9HQjvBBLrGfFK8j/8 3yGEhLhr7jVC2boBF3Q1o9BvBwNG57Wp+bQOf7D3eA10Fij50XJcix48mkR1QEAxTCej WQgOK+MZosrw+qfzd5rUHYwcj+zZHTcobkTrkcQhjO3JKGL8l3Bk18BXRs7PmZm6UGi5 ghgPOr/WzsHpeJmGj0vEI4Tds1uXDZA5pSJqr/6wVnacBF9IAy+f/n/WojfqxsyAjGFf 6BCA== X-Gm-Message-State: ACrzQf2P7osWlXmwJ2lxbzqrlElEPOYsyzxBmDEXy+LxsQ0PoUg7hc8S otNd7UibwvIu5tMupuNtqegQjC4x12+zDc8FR+k= X-Google-Smtp-Source: AMsMyM4krD8jYq1UclN4ZSwetM+9RPEPsFo0rLRVF5cwkcbaJa+hTTz2iDGfPLPLxP5vIgi1Qb0lsFeKWhosveCcDAM= X-Received: by 2002:a05:6830:3c1:b0:637:28be:7920 with SMTP id p1-20020a05683003c100b0063728be7920mr23432757otc.105.1666868319386; Thu, 27 Oct 2022 03:58:39 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Thu, 27 Oct 2022 03:58:38 -0700 From: Stefan Kangas In-Reply-To: <87fsf9vdr6.fsf@gmail.com> References: <87y1t2zl1s.fsf@cassou.me> <87fsf9vdr6.fsf@gmail.com> X-Hashcash: 1:20:221027:58799@debbugs.gnu.org::4A7QRGHb3F4uixuz:5ejm MIME-Version: 1.0 Date: Thu, 27 Oct 2022 03:58:38 -0700 Message-ID: Subject: Re: bug#58799: Make winner key sequences repeatable in repeat-mode To: Robert Pluim Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 58799 Cc: Damien Cassou , 58799@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Robert Pluim writes: > Hmm, that=CA=BCs an interesting one: > > (key-valid-p "[right]") =3D> nil > (key-valid-p "") =3D> t > > but > > (kbd "") =3D> [right] > (keymap-set global-map (kbd "") #=CA=BCignore) =3D> error I don't think I see any contradiction, as `keymap-set' requires its second argument to be `key-valid-p'. So that last one should just be: (keymap-set global-map "" #'ignore) From debbugs-submit-bounces@debbugs.gnu.org Thu Oct 27 07:39:48 2022 Received: (at 58799) by debbugs.gnu.org; 27 Oct 2022 11:39:48 +0000 Received: from localhost ([127.0.0.1]:56317 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oo1Eh-0008Ip-Uu for submit@debbugs.gnu.org; Thu, 27 Oct 2022 07:39:48 -0400 Received: from mail-wm1-f43.google.com ([209.85.128.43]:35345) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oo1Ef-0008Ic-Td for 58799@debbugs.gnu.org; Thu, 27 Oct 2022 07:39:46 -0400 Received: by mail-wm1-f43.google.com with SMTP id m29-20020a05600c3b1d00b003c6bf423c71so3988371wms.0 for <58799@debbugs.gnu.org>; Thu, 27 Oct 2022 04:39:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=LNXkw3dscxt/y+r/5+OIuCSH89U0/nci4gNviu2BvDA=; b=KhYaRA+2+LAik3dM1ZX5lkNN6CRZxAmSy9yUl/JP/JEOs5WN1Vq8DKHBDc9jmyIoM6 ng4n2yq/My8sRfeTe9088xyjXi9/MW3ui4zWYSdUXhWd8E8B+TtRj/qcD2Ic0vE9uqVd DWuZeI1/8YZ3J6kpsCOfzX/iY3O6Ms1wfLniS2g6qmkFwEBmDb/XjNIPIePmL5QRXzl7 xInXQb4+lunA4dSxq/IrTDzcc7b29YYVz1DXx3mWevkAwdhr31GbKc6qdsECs9W5sCkw Qmr8eF9ARd7VJKDXFWM0DZ4VIVb17YW95sqCcpxMyOBdMvA1bjaUECZb57IkA9Zr4Enc eMJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=LNXkw3dscxt/y+r/5+OIuCSH89U0/nci4gNviu2BvDA=; b=hS7FX96P0d5exVlrzYGb89x/J6sQj97VgMK8qd/3fatTBBW865hrlQb2NLJoJJPdnB t6yFRsv6kfobHb6/iXDNpKK3TWoxfiJ4J8NP6R0uMpGM0DQCxqKCrZ2j7pHrpWLO9dzy vfhzKqiT6mkERE4ER/hIadm4kEuFbj7VqErFAZtBr1H6B59eN8FWYDGKB0mCiThHBIpN Md6i9Rt/HHUrOJ+VTYanDU+5Tj6b6ti7947eRsxQyjcOcSK8ZAKvvE2oov9M4ZuRzs4e D+JiQazcpT2qQWb30nkzr6gdavEWanTMzk8mPSQRLkgQnb592M1c0cQu3bwRABxMrhoS Cj/g== X-Gm-Message-State: ACrzQf1JFUGrybEBIF29zI6hYVmuw5mugO6nFsHwoIye+aHuwQcvN9A7 1pREyuuOdii9ubJ73k5Ze+p145xw6jY= X-Google-Smtp-Source: AMsMyM6l5LOSKB6J1vcrx1obUMYaqPdWaiflfIDRY+ro2urphqBe2XC3Y5Lh1QfCsNTll4qkGYbd8Q== X-Received: by 2002:a05:600c:4e45:b0:3cf:3e69:9351 with SMTP id e5-20020a05600c4e4500b003cf3e699351mr5663053wmq.2.1666870779495; Thu, 27 Oct 2022 04:39:39 -0700 (PDT) Received: from rltb ([82.66.8.55]) by smtp.gmail.com with ESMTPSA id bg37-20020a05600c3ca500b003b477532e66sm9970722wmb.2.2022.10.27.04.39.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 27 Oct 2022 04:39:38 -0700 (PDT) From: Robert Pluim To: Stefan Kangas Subject: Re: bug#58799: Make winner key sequences repeatable in repeat-mode In-Reply-To: (Stefan Kangas's message of "Thu, 27 Oct 2022 03:58:38 -0700") References: <87y1t2zl1s.fsf@cassou.me> <87fsf9vdr6.fsf@gmail.com> Date: Thu, 27 Oct 2022 13:39:37 +0200 Message-ID: <87v8o5ts06.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 58799 Cc: Damien Cassou , 58799@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >>>>> On Thu, 27 Oct 2022 03:58:38 -0700, Stefan Kangas said: Stefan> I don't think I see any contradiction, as `keymap-set' requires= its Stefan> second argument to be `key-valid-p'. So that last one should j= ust be: Stefan> (keymap-set global-map "" #'ignore) Now that I=CA=BCve actually run some more tests, I see where the confusion is coming from. You can=CA=BCt actually eval this: (defvar-keymap winner-repeat-map :doc "Keymap to repeat winner key sequences. Used in `repeat-mode'." [left] #'winner-undo [right] #'winner-redo) or this: (defvar-keymap winner-repeat-map :doc "Keymap to repeat winner key sequences. Used in `repeat-mode'." #'winner-undo #'winner-redo) (but you can stick them in a .el file) But you can eval this: (defvar-keymap winner-repeat-map :doc "Keymap to repeat winner key sequences. Used in `repeat-mode'." "" #'winner-undo "" #'winner-redo) Well, TIL. I don=CA=BCt think it=CA=BCs going to result in any patches from= me though, unless we want to disallow `[left]' and `[right]' in `defvar-keymap' :-) Robert --=20 From debbugs-submit-bounces@debbugs.gnu.org Thu Oct 27 08:31:30 2022 Received: (at 58799) by debbugs.gnu.org; 27 Oct 2022 12:31:30 +0000 Received: from localhost ([127.0.0.1]:56363 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oo22j-0001Aw-QZ for submit@debbugs.gnu.org; Thu, 27 Oct 2022 08:31:29 -0400 Received: from mail-oa1-f44.google.com ([209.85.160.44]:35683) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oo22i-0001Ai-1U for 58799@debbugs.gnu.org; Thu, 27 Oct 2022 08:31:28 -0400 Received: by mail-oa1-f44.google.com with SMTP id 586e51a60fabf-13b103a3e5dso1747042fac.2 for <58799@debbugs.gnu.org>; Thu, 27 Oct 2022 05:31:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date :mime-version:references:in-reply-to:from:from:to:cc:subject:date :message-id:reply-to; bh=4HTNFMT5fLHfQqpvnc6ruUCl6MsZOThg44OgB9oXFFc=; b=KdCwtpQXu/3uNeUJyKhMa76g1ZFDp1rpZ5cV3pkJGqcU2Xw9mkEPAx5eIgyQE2eKob 9ou9J0b6AvJd13uGbAxeWBis97tQUUG4jKQTnQOg3KixrmU/iRkzms5v223CE7cWsse0 TW4spuhosDB0vip1EDCe5hCCHdzVV3OZPqTE1r4g0cX4YZ7amn/35t50jxW477C8DBXq UZeNOwucawgI6eGynBWp6s09L0BvWSd4bGllW/xHsjnOuQQQZ/2rJNhQp2qvmTm12RlK HHmQpSjuEPt8R6lxMJ++EjnzvnS6aQugl9oSH1tJRjLPzQEuo7hvm2LEtP+0/RMCexo5 WTRA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date :mime-version:references:in-reply-to:from:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=4HTNFMT5fLHfQqpvnc6ruUCl6MsZOThg44OgB9oXFFc=; b=lbdx25no+dlGjyVyPVLzfyQcDoIFff8UhMhu5hKYsg5LAz2/OTMQ98TZjrTGBo9F/8 OvO+EpM2JXgZs+oUQWH8p2ckfUWnTbcV/GghdE4/cFTHJ8ZIhxbW++7onw0n3YVZJbVw O1R8TIsU701ZXJB032uEnjA5jk5OzG6KM6hpKexi92KgL5LtfR8iXcRaB0tUGpEKaN5D aWoOMCLMn10fiJ2bow3oUD2zMj61J0rQ4uGg6qVZVnxvPud+oohizzUpmR2O2qBEvRZ9 HZXzMS3xHw6FePVIwS50d0nG1WImiufTj6rXVluOQj7ZnpliVVdBpDpAAWkSZauxW/Yr nqQA== X-Gm-Message-State: ACrzQf3PQqFilMLpgdq3pYozmew73Z0WjEatuIabl51rLVwuX4HaZvux S6Oyu7kiKF2kG7KQZpl4xhhuQNcuVnj1UeEfZgs= X-Google-Smtp-Source: AMsMyM6eadStAh3WSWlvpmlNkbbe6MYzYutCMS4Fi/XGOq7FU1FYu3b3BScHDXZLjDlO+7W2Np+R0Xkq+DvlT8v/e+w= X-Received: by 2002:a05:6870:d79a:b0:136:50d7:faa9 with SMTP id bd26-20020a056870d79a00b0013650d7faa9mr5128877oab.92.1666873882241; Thu, 27 Oct 2022 05:31:22 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Thu, 27 Oct 2022 05:31:21 -0700 From: Stefan Kangas In-Reply-To: <87v8o5ts06.fsf@gmail.com> References: <87y1t2zl1s.fsf@cassou.me> <87fsf9vdr6.fsf@gmail.com> <87v8o5ts06.fsf@gmail.com> X-Hashcash: 1:20:221027:larsi@gnus.org::xKdYVoePfyGapXE1:69Jt MIME-Version: 1.0 Date: Thu, 27 Oct 2022 05:31:21 -0700 Message-ID: Subject: Re: bug#58799: Make winner key sequences repeatable in repeat-mode To: Robert Pluim Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 58799 Cc: Damien Cassou , Lars Ingebrigtsen , 58799@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Robert Pluim writes: > (defvar-keymap winner-repeat-map > :doc "Keymap to repeat winner key sequences. Used in `repeat-mode'= ." > #'winner-undo > #'winner-redo) > > (but you can stick them in a .el file) Hmm, right. I think that's a bug though, because when loading such a .elc file I get: keymap--check: [left] is not a valid key definition; see =E2=80=98key-valid= -p=E2=80=99 So we should probably make sure that the `defvar-keymap' macro errors out. From debbugs-submit-bounces@debbugs.gnu.org Thu Oct 27 09:38:27 2022 Received: (at 58799) by debbugs.gnu.org; 27 Oct 2022 13:38:27 +0000 Received: from localhost ([127.0.0.1]:56519 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oo35W-0002w2-Ob for submit@debbugs.gnu.org; Thu, 27 Oct 2022 09:38:27 -0400 Received: from mail-wr1-f43.google.com ([209.85.221.43]:36854) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oo35V-0002vq-Bf for 58799@debbugs.gnu.org; Thu, 27 Oct 2022 09:38:25 -0400 Received: by mail-wr1-f43.google.com with SMTP id j15so2236108wrq.3 for <58799@debbugs.gnu.org>; Thu, 27 Oct 2022 06:38:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=0WyG8b/pFfJCSEKUF/1AO/MRDEzOQLfxoU/Wr8jDgwg=; b=n97cV56dFA2/tO2C/lpUMN+6xK8c3fkpDPEhTR/TfrovudLDTqQKgDckybn7jER1nb 4gLAi+Cvb8kBdWmzoxvkOEiHeeTfd4VpcAbxfRcAkHdcwOJMdDGa8izlAnEWPsSKDoDj wZwPliHIMD3jmIeKLb1uqLEkBwZ11BiW10q0qSI4DWvowslAstHFZz8+GRWIKB6iPA43 QpuLBS30t6KQQQQX8RwaYiLWqADctQ6JdSt/AC4QcqXERW4zbAugoUAS9GFBeLWrYJo7 cEnCQzPovZX0n/oRMPE45v0DXlXqp1CY4s9QD4Ul5bmeOGdJTfJ/B4I9m2l10c2/NIeM M2yw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=0WyG8b/pFfJCSEKUF/1AO/MRDEzOQLfxoU/Wr8jDgwg=; b=VcQN2MX+DmTUnzvR9GtAKHPr9SH4L+gyy4QvuB7+HFdCaAhQm0csUxToKzxgIBr1wX pTyRrrpYADnLc+M/tDeIhI26x37VZgVVEl9WsfmMEmrOBhDjPn9HOfeyeJTM2xO9NcR5 NILtYC/QSeA+7NmgnGdVdcNvwRYNxT/uogbnHHlnpwO0KZtwlqaum0Z3GWK650gConHG XVVVV/RZCZxg7uew3cQy1MfVbAjN1pAxg0kWm2aldvjD1qo0hXCQOh1cO9G/UTo2K1O2 Zjws9zdjX3plIbjwiHjtCT0BxnmHZWSk64lK+kjcZQRol5eIs6N2vqAi1ZTMITf7VLXN We+w== X-Gm-Message-State: ACrzQf0jc0iy/DDsK+yTzbA+vxWt8mYmngI892gDWSgR+pTqwOnxaVOf 8WAuzna5lHVX5k3mLptpx110dgcZ2lQ= X-Google-Smtp-Source: AMsMyM6qYZUT7AhrPLxSKIwyCtkVWko0jlqV9Xss+Z/yllPS+Ca3tOT8dN27Jw92zSdnRd/M+pRLpQ== X-Received: by 2002:a05:6000:1866:b0:236:715a:16c1 with SMTP id d6-20020a056000186600b00236715a16c1mr13945134wri.537.1666877898919; Thu, 27 Oct 2022 06:38:18 -0700 (PDT) Received: from rltb ([82.66.8.55]) by smtp.gmail.com with ESMTPSA id u3-20020adfdd43000000b002364c77bc96sm1232133wrm.33.2022.10.27.06.38.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 27 Oct 2022 06:38:18 -0700 (PDT) From: Robert Pluim To: Stefan Kangas Subject: Re: bug#58799: Make winner key sequences repeatable in repeat-mode In-Reply-To: (Stefan Kangas's message of "Thu, 27 Oct 2022 05:31:21 -0700") References: <87y1t2zl1s.fsf@cassou.me> <87fsf9vdr6.fsf@gmail.com> <87v8o5ts06.fsf@gmail.com> Date: Thu, 27 Oct 2022 15:38:17 +0200 Message-ID: <87lep1tmie.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 58799 Cc: Damien Cassou , Lars Ingebrigtsen , 58799@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >>>>> On Thu, 27 Oct 2022 05:31:21 -0700, Stefan Kangas said: Stefan> Robert Pluim writes: >> (defvar-keymap winner-repeat-map >> :doc "Keymap to repeat winner key sequences. Used in `repeat-mode'." >> #'winner-undo >> #'winner-redo) >>=20 >> (but you can stick them in a .el file) Stefan> Hmm, right. I think that's a bug though, because when loading = such a Stefan> .elc file I get: Stefan> keymap--check: [left] is not a valid key definition; see =E2=80= =98key-valid-p=E2=80=99 Stefan> So we should probably make sure that the `defvar-keymap' macro = errors Stefan> out. That=CA=BCs easy enough (putting it in `define-keymap' would bring out the backwards-compatibility police, I think). Probably needs an update to the `defvar-keymap' docstring as well. Robert --=20 diff --git a/lisp/keymap.el b/lisp/keymap.el index 107565590c..73a9e657fe 100644 --- a/lisp/keymap.el +++ b/lisp/keymap.el @@ -581,6 +581,10 @@ defvar-keymap (setq key (pop defs)) (pop defs) (when (not (eq key :menu)) + (when (not (key-valid-p key)) + (error + "Invalid key '%s' in keymap '%s' (see `key-valid-p')" + key variable-name)) (if (member key seen-keys) (error "Duplicate definition for key '%s' in keymap '%s'" key variable-name) From debbugs-submit-bounces@debbugs.gnu.org Thu Oct 27 12:10:20 2022 Received: (at 58799) by debbugs.gnu.org; 27 Oct 2022 16:10:20 +0000 Received: from localhost ([127.0.0.1]:59058 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oo5SW-0007eE-D8 for submit@debbugs.gnu.org; Thu, 27 Oct 2022 12:10:20 -0400 Received: from mail-ot1-f43.google.com ([209.85.210.43]:43829) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oo5SU-0007dx-K1 for 58799@debbugs.gnu.org; Thu, 27 Oct 2022 12:10:18 -0400 Received: by mail-ot1-f43.google.com with SMTP id t4-20020a9d7f84000000b00661c3d864f9so1256287otp.10 for <58799@debbugs.gnu.org>; Thu, 27 Oct 2022 09:10:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date :mime-version:references:in-reply-to:from:from:to:cc:subject:date :message-id:reply-to; bh=IJxwb7/xfsNNwtw9vDmCNJqFmAsU1ghPhr3ba0748sE=; b=jKED076FrV3IR6KAGWdfMnDxR/h6BDPXggAcaL5IV4ksJPGeNa3MIhGPhHiu7YPi1F DZJQi2j8ELnv8F1WlTv1wO/jRDSGW5pPyDlmVaryDsxsKrPe0zjxA/eipLJmYGXUPGj/ BrE41/PAnBq+9aUQLZ7aBfmWICpkhFRDhGsSnxIhtN9NxD31cq1zM2m8/3Be8j6GTj/L xUFx5y9ZnC9xSk1RrJWFbQ8JJuEQVkYOmryMH14jnY1c6p+beFSOvxc62w+oecz+p8M+ oOwK7ZpXKcinDNbq8Zkv6enPUjp40aW77j+yN7lBKB+xxdvzAKNCSgVffE/kwFZfOpdR D7uw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date :mime-version:references:in-reply-to:from:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=IJxwb7/xfsNNwtw9vDmCNJqFmAsU1ghPhr3ba0748sE=; b=1dKKzOCIYiSxm96gGJlWTqrjSefOplrJBLTCPsJls9/sBMggmPFqkwvKTF4a8RDMkR kh4VYh7nM5NjpU+9mXepzGKgqswXlA7+0ZWkVNDqgHTEgCnIpW5tZRAWKXJPyybBrp1g eWDUiLO024kFFl8fzcpOu8p7iGIHyuLT5blPhfyuCbGaCCLOntxNC9aqP9DSV6VvTBC3 4YdF1KTIFU5y3GAyeaccoNZ6AweDvgvCpb/uDulbXBgKdV1d/MXm55Vm7kJNlTsW+LtH 2IN+Q5T+MdEoWhmPAysZqLh7y3RNEwwF0PmMqcd3+IELszRrEo1DyIgMvxbGHGesVwaf bzNQ== X-Gm-Message-State: ACrzQf3CY/+tJ4K44HYZidDi48xCX+3Dasu1GyL3DoJReLVBGlFtMVkQ 6dmKZsovE/No+czBR78t2MZpwfzWHmn69h3qpyI= X-Google-Smtp-Source: AMsMyM54NyfyeJdyhhHjhnlg6T6JBV+ekmtqwhEUpj8mtQuTup2HdJu16kWjCklp2766zatC/FbqxRz7yoDtWDTKhOc= X-Received: by 2002:a9d:4003:0:b0:661:b434:7e95 with SMTP id m3-20020a9d4003000000b00661b4347e95mr23718887ote.224.1666887012959; Thu, 27 Oct 2022 09:10:12 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Thu, 27 Oct 2022 09:10:12 -0700 From: Stefan Kangas In-Reply-To: <87lep1tmie.fsf@gmail.com> References: <87y1t2zl1s.fsf@cassou.me> <87fsf9vdr6.fsf@gmail.com> <87v8o5ts06.fsf@gmail.com> <87lep1tmie.fsf@gmail.com> X-Hashcash: 1:20:221027:58799@debbugs.gnu.org::123CsIBhGLnvaAIv:8Dn0 MIME-Version: 1.0 Date: Thu, 27 Oct 2022 09:10:12 -0700 Message-ID: Subject: Re: bug#58799: Make winner key sequences repeatable in repeat-mode To: Robert Pluim Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 58799 Cc: Damien Cassou , Lars Ingebrigtsen , 58799@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Robert Pluim writes: > Stefan> So we should probably make sure that the `defvar-keymap' macr= o errors > Stefan> out. > > That=CA=BCs easy enough (putting it in `define-keymap' would bring out th= e > backwards-compatibility police, I think). Probably needs an update to > the `defvar-keymap' docstring as well. `define-keymap' is new in Emacs 29.1, so I think it will be okay to change it. > diff --git a/lisp/keymap.el b/lisp/keymap.el > index 107565590c..73a9e657fe 100644 > --- a/lisp/keymap.el > +++ b/lisp/keymap.el > @@ -581,6 +581,10 @@ defvar-keymap > (setq key (pop defs)) > (pop defs) > (when (not (eq key :menu)) > + (when (not (key-valid-p key)) > + (error > + "Invalid key '%s' in keymap '%s' (see `key-valid-p')" > + key variable-name)) > (if (member key seen-keys) > (error "Duplicate definition for key '%s' in keymap '%s'" > key variable-name) LGTM. From debbugs-submit-bounces@debbugs.gnu.org Thu Oct 27 12:18:47 2022 Received: (at 58799) by debbugs.gnu.org; 27 Oct 2022 16:18:47 +0000 Received: from localhost ([127.0.0.1]:59086 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oo5ah-0001cg-5l for submit@debbugs.gnu.org; Thu, 27 Oct 2022 12:18:47 -0400 Received: from mail-wm1-f46.google.com ([209.85.128.46]:35358) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oo5af-0001cN-6l for 58799@debbugs.gnu.org; Thu, 27 Oct 2022 12:18:45 -0400 Received: by mail-wm1-f46.google.com with SMTP id m29-20020a05600c3b1d00b003c6bf423c71so4556430wms.0 for <58799@debbugs.gnu.org>; Thu, 27 Oct 2022 09:18:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=Ya7TyhUjENOr4LbyMeCWf3MfFw3Gmr25hjA6e+dDf74=; b=C5zFQqRmxg41msckaQVbVfBVINnCExdwZ3WhcnDDKYlpzgOlffu2B1fvBauxyT0Wnl ShaA5THqg2GFiOlCQrP+C6aOMFXIUy2D5nD3cXCLM63OG8eWossAq79Cu8nnk2c468mT BeRBCcrNmqIhNc928ptnW/t6DJlYrGmbvR6WDY0tumyfN8LPWWUwPgcpegLtsSVAUbsk 5NJEEOQHC8017BVAsCTTX5i0wR6OamEjlAqIokRc3Pt/KR4tbVhSSYk/xx4qyq0ywv3L U92IK8z58hUacp9uJQkIAtcpZTOQLXFUTEXpkJC7GS5Kmn0Z6OC+FGi7hTJN3YUoXk8i x7PA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Ya7TyhUjENOr4LbyMeCWf3MfFw3Gmr25hjA6e+dDf74=; b=viMph3o/CONThwk5y/b8UvyQ28NeMQpPsS1uGX7PmD/VL3/nl2tA/wrzeScEemRmC9 zx/RNVvbaJ3M3owDKOybfqQAQ4D57253Ae4HHauEEcJififQiEcI0biAveWoHvZqizT2 uph5OT4CjNPbAq/mUG8Q3DYUGE9YTS5ZWvEIfqe9/EYD7SkhoggPw6wK6Oopk8GtSfW/ o7ZfpDQFZRHGF9ayekeJbpd8rWn6iC0Ak6VGkiruOM+0mhUOgtHQyWZqN34XQZ1o7Mfl x6jIGfSaRpNVrtMCsk1wCKE+c38da31BjafZJWtUcLYwH1ylb7YdRZmfQIryCRoVIFCI DO8g== X-Gm-Message-State: ACrzQf0+iQmjtGaiYN948WNkUl3yZ6ahI2OfpQcNU2PYRJA+EpxzR5I8 uItlzr0yIgJlQYgtQq/1fe4+/hLZ1aE= X-Google-Smtp-Source: AMsMyM6xgnXQr8pd0m+MBcJZHhe/OU2VHwUSCMqPZ5bJTX+B+UsGUqO+dTXe0BuIX5pueKIGfxrqwg== X-Received: by 2002:a05:600c:42c6:b0:3c6:f27e:cac8 with SMTP id j6-20020a05600c42c600b003c6f27ecac8mr6391502wme.175.1666887518886; Thu, 27 Oct 2022 09:18:38 -0700 (PDT) Received: from rltb ([82.66.8.55]) by smtp.gmail.com with ESMTPSA id bg37-20020a05600c3ca500b003b477532e66sm10790563wmb.2.2022.10.27.09.18.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 27 Oct 2022 09:18:38 -0700 (PDT) From: Robert Pluim To: Stefan Kangas Subject: Re: bug#58799: Make winner key sequences repeatable in repeat-mode In-Reply-To: (Stefan Kangas's message of "Thu, 27 Oct 2022 09:10:12 -0700") References: <87y1t2zl1s.fsf@cassou.me> <87fsf9vdr6.fsf@gmail.com> <87v8o5ts06.fsf@gmail.com> <87lep1tmie.fsf@gmail.com> Date: Thu, 27 Oct 2022 18:18:37 +0200 Message-ID: <878rl1tf36.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 58799 Cc: Damien Cassou , Lars Ingebrigtsen , 58799@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >>>>> On Thu, 27 Oct 2022 09:10:12 -0700, Stefan Kangas said: Stefan> Robert Pluim writes: Stefan> So we should probably make sure that the `defvar-keymap' macro = errors Stefan> out. >>=20 >> That=CA=BCs easy enough (putting it in `define-keymap' would bring o= ut the >> backwards-compatibility police, I think). Probably needs an update to >> the `defvar-keymap' docstring as well. Stefan> `define-keymap' is new in Emacs 29.1, so I think it will be oka= y to Stefan> change it. OK. It=CA=BCs the logical place to put it. >> diff --git a/lisp/keymap.el b/lisp/keymap.el >> index 107565590c..73a9e657fe 100644 >> --- a/lisp/keymap.el >> +++ b/lisp/keymap.el >> @@ -581,6 +581,10 @@ defvar-keymap >> (setq key (pop defs)) >> (pop defs) >> (when (not (eq key :menu)) >> + (when (not (key-valid-p key)) >> + (error >> + "Invalid key '%s' in keymap '%s' (see `key-valid-p')" >> + key variable-name)) >> (if (member key seen-keys) >> (error "Duplicate definition for key '%s' in keymap '%s'" >> key variable-name) Stefan> LGTM. Hmm, in light of the above, maybe the duplicate detection should be moved to `define-keymap' as well. Robert --=20 From debbugs-submit-bounces@debbugs.gnu.org Thu Oct 27 12:33:58 2022 Received: (at 58799) by debbugs.gnu.org; 27 Oct 2022 16:33:58 +0000 Received: from localhost ([127.0.0.1]:59116 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oo5pO-00021q-Cz for submit@debbugs.gnu.org; Thu, 27 Oct 2022 12:33:58 -0400 Received: from mail-wr1-f46.google.com ([209.85.221.46]:37747) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oo5pM-00021d-TD for 58799@debbugs.gnu.org; Thu, 27 Oct 2022 12:33:57 -0400 Received: by mail-wr1-f46.google.com with SMTP id bs21so3185121wrb.4 for <58799@debbugs.gnu.org>; Thu, 27 Oct 2022 09:33:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=cFP1erbllfsX+syQ8sb0doYJ6LwZc+ZMjK/dEIc5Mzc=; b=UWOBGkfZcxHLIBLrp0ck0TzcjJya9XiHRsxXO5V2rpyqrUatPk1i3Xm7Nk0R8sPpiJ l/Mlx+6/vgXHHZcVs28o0i/JG4PsBZNQO5hbsrK6GkYirAiF4LLnEqQRNC075R7BuSz+ atBDkTmCeAHkFsX4i9JvZz9WcKbycvhs3d6fvF9T9A0NRFXXqiorlTtURk4lJbJINknV OsG1hwhn8tEMI+v8wpAnMgRjA5kDDxjIcdAB+T8IsdVSdAx5CGHO7ayzDQ5JINf53qNl 4q25m2AVPeQa74gyxgFqzuYtaxZKlqXVoag9PytM/I8MRcsOo+BCf4zLZTRwWZpBMOMq z+lA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=cFP1erbllfsX+syQ8sb0doYJ6LwZc+ZMjK/dEIc5Mzc=; b=5bYvnzcuFnauGOmyjy5TCflbY2+w32rwZmNbYuJYpU7qTtAinv+MEMq99+BQqtC8PY 6JljjtC4mWPD2OUcGW8/luRe4D/KHXmrbHVlF8T9oOsdU3FVpykVQERF5nQveXAGujy3 w8L/potbFTP5KpVz+sDuK0oEvW5buxlPB72JcGh7Mx1NN8QNqQhBZlqUMF4GfJfPKSwu 3R8nXAfyvGEG0z9unv3I9tEgpZH7vbow/1PtGeVQMBV0WJMQlsgt6GTo4OZUuimpW9ic Jv2Ev30rPPRkQNcMdw4CcPc7ceiUJHbFvCJBIAXxdfLzNs4slghKpjmlaaEMwL4M74Bm p/yQ== X-Gm-Message-State: ACrzQf2F8hcmhAYLsggYqIRs/VOseeLRuxONQVetYG5N+OIjF2IRla65 ep/YrxJiKsxgsS6Pg+8vV59xe8Cx4Rw= X-Google-Smtp-Source: AMsMyM7zriQVtO409U1K5ZbhTHA6QtEfJ1tSG3tWLmHXvlhqMiAukdqZTUUVaSiuWSs7HpEDlWUqKg== X-Received: by 2002:a5d:5c04:0:b0:234:88dc:3d19 with SMTP id cc4-20020a5d5c04000000b0023488dc3d19mr26574203wrb.681.1666888430828; Thu, 27 Oct 2022 09:33:50 -0700 (PDT) Received: from rltb ([82.66.8.55]) by smtp.gmail.com with ESMTPSA id o41-20020a05600c512900b003c6bd91caa5sm2285183wms.17.2022.10.27.09.33.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 27 Oct 2022 09:33:50 -0700 (PDT) From: Robert Pluim To: Stefan Kangas Subject: Re: bug#58799: Make winner key sequences repeatable in repeat-mode In-Reply-To: <878rl1tf36.fsf@gmail.com> (Robert Pluim's message of "Thu, 27 Oct 2022 18:18:37 +0200") References: <87y1t2zl1s.fsf@cassou.me> <87fsf9vdr6.fsf@gmail.com> <87v8o5ts06.fsf@gmail.com> <87lep1tmie.fsf@gmail.com> <878rl1tf36.fsf@gmail.com> Date: Thu, 27 Oct 2022 18:33:49 +0200 Message-ID: <87zgdhrzte.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 58799 Cc: Damien Cassou , Lars Ingebrigtsen , 58799@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >>>>> On Thu, 27 Oct 2022 18:18:37 +0200, Robert Pluim s= aid: Robert> Hmm, in light of the above, maybe the duplicate detection shoul= d be Robert> moved to `define-keymap' as well. Except it=CA=BCs already there. I really must look at my own previous commits before commenting :-) Robert --=20 From debbugs-submit-bounces@debbugs.gnu.org Fri Oct 28 05:36:28 2022 Received: (at 58799) by debbugs.gnu.org; 28 Oct 2022 09:36:28 +0000 Received: from localhost ([127.0.0.1]:60440 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ooLmt-0005W0-Qj for submit@debbugs.gnu.org; Fri, 28 Oct 2022 05:36:28 -0400 Received: from mail-wm1-f52.google.com ([209.85.128.52]:56126) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ooLmq-0005Vl-Tg for 58799@debbugs.gnu.org; Fri, 28 Oct 2022 05:36:25 -0400 Received: by mail-wm1-f52.google.com with SMTP id t4so2783807wmj.5 for <58799@debbugs.gnu.org>; Fri, 28 Oct 2022 02:36:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=SZ725RMwJ8x3udrdBNPPIdNjigVVHtK7obFTohvtZcA=; b=maYeKDGIVGTf23Vm237gjIXhLIB90td9YOT/7OQuTz8gsrIp5zTpMIRxdWCTZbx5w1 3FZvEzWO6N6TwiERLg6phBm/CrgRI0788hrQM/RwpmwomoOJmSnGescewsNs/R+qUtw7 fpm5ziqnkPeOUg1YNMC8DyYcLb9UFxfNWz1GFhimFm/gf+s3Yl8KJAvZDWF4S3ZUbamb PCgG0fWwwSS3bXzmxs7yCsOLYqO5tOuSHo0RG3MqKeDqXF83QOl5kA4wpQqo0f0+xA1G PNad+OwlBajNqcUYSB5yvvJAk7LOXcT3ykedTBC1YXvPSoi5x08NoxqyYvQo73jcntJO ND3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=SZ725RMwJ8x3udrdBNPPIdNjigVVHtK7obFTohvtZcA=; b=S7xjT9rGhPoYLqi6inZPnprRbbYvINGo37h4SGNIUsGNHRZbbR+uN5d0hnbbh7G3Hd gU1HEd6dBfIQma1yA5Njki6YiScPbT7fyAbFxM8ucmI1y5xEWFm7827tdSeSkJOc8mUE hwXof99lt/bfX4HLP9Zl3G2Zd9+e8QH9GUXt9hTzYGfupj9iFJDSAwktI+pAEvusZLi2 1a6PWZ9ECyaGK+LCiVtWVbjCRzLluzKPCqtYNaZ5i+5IMZmx6JvxZNvfXdW8s4YdkzUI qx5w5Wr7WllBn0ftxumDvuQ0tv59oBHJXBtcwrHj2TRIAfGvfXze22xn3jhNTTVQMrwO a27A== X-Gm-Message-State: ACrzQf3Q38N3SWaQd9/N5FGi2j6R3q8ZVq2xBc6RNQv8SWD+5SCFGeDa qHks9mb4959e3jNsh8K9v7dCzwT72REZVA== X-Google-Smtp-Source: AMsMyM4UuCw9YzVPnlhwEH20kKTPuQQVKTiOIvPz3YS/1gO26xZpHQcELHrbj56rZ66fQBJyToO+Yg== X-Received: by 2002:adf:fc07:0:b0:236:6f04:2010 with SMTP id i7-20020adffc07000000b002366f042010mr17518285wrr.227.1666949777488; Fri, 28 Oct 2022 02:36:17 -0700 (PDT) Received: from rltb ([82.66.8.55]) by smtp.gmail.com with ESMTPSA id 6-20020a05600c230600b003cf37c5ddc0sm3629793wmo.22.2022.10.28.02.36.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Oct 2022 02:36:16 -0700 (PDT) From: Robert Pluim To: Stefan Kangas Subject: Re: bug#58799: Make winner key sequences repeatable in repeat-mode In-Reply-To: (Stefan Kangas's message of "Thu, 27 Oct 2022 09:10:12 -0700") References: <87y1t2zl1s.fsf@cassou.me> <87fsf9vdr6.fsf@gmail.com> <87v8o5ts06.fsf@gmail.com> <87lep1tmie.fsf@gmail.com> Date: Fri, 28 Oct 2022 11:36:15 +0200 Message-ID: <871qqss31s.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 58799 Cc: Damien Cassou , Lars Ingebrigtsen , 58799@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >>>>> On Thu, 27 Oct 2022 09:10:12 -0700, Stefan Kangas said: >> diff --git a/lisp/keymap.el b/lisp/keymap.el >> index 107565590c..73a9e657fe 100644 >> --- a/lisp/keymap.el >> +++ b/lisp/keymap.el >> @@ -581,6 +581,10 @@ defvar-keymap >> (setq key (pop defs)) >> (pop defs) >> (when (not (eq key :menu)) >> + (when (not (key-valid-p key)) >> + (error >> + "Invalid key '%s' in keymap '%s' (see `key-valid-p')" >> + key variable-name)) >> (if (member key seen-keys) >> (error "Duplicate definition for key '%s' in keymap '%s'" >> key variable-name) Stefan> LGTM. I now think this would be a bad idea, because of the following type of code: (defvar-keymap footnote-minor-mode-map :doc "Keymap used for binding footnote minor mode." (key-description footnote-prefix) footnote-mode-map) That=CA=BCs perfectly valid, but fails with the above patch unless we 1. Check (key-valid-p (eval key)) 2. Add an autoload cookie for footnote-minor-mode-map That seems too high a price to pay for avoiding the original problem. Robert --=20 From debbugs-submit-bounces@debbugs.gnu.org Fri Oct 28 11:41:45 2022 Received: (at 58799) by debbugs.gnu.org; 28 Oct 2022 15:41:45 +0000 Received: from localhost ([127.0.0.1]:34097 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ooRUP-0004rR-0S for submit@debbugs.gnu.org; Fri, 28 Oct 2022 11:41:45 -0400 Received: from mail-oi1-f170.google.com ([209.85.167.170]:36407) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ooRUN-0004rE-E5 for 58799@debbugs.gnu.org; Fri, 28 Oct 2022 11:41:43 -0400 Received: by mail-oi1-f170.google.com with SMTP id s206so6544933oie.3 for <58799@debbugs.gnu.org>; Fri, 28 Oct 2022 08:41:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date :mime-version:references:in-reply-to:from:from:to:cc:subject:date :message-id:reply-to; bh=vzaGOIsmPAAL83/pJCFjulh3hVl0NwiOSa6Klc/I4mI=; b=ZRctlsp2+gKE7cxVsGpO/uwh0br844CTi/dhlh+rXEJSs/M9itQ6Hfb8x3LORFRM3g iVQjl+F4Td0SvxsAzpATOikKTtoDlmPvj0dKGZHZJaxdODbYdy9PoKumPoTX2jMOSnkF 20VcsnghQlL9A20HHpDGgIQZ6aHkIVfP+kJBYWcV/MFGMmu41AIvWxQuludEpjsa5Vdx /V6vyafCn4GBKpxLVH0fd3Rab22Fov2VUslKVi+L1gvb9jD1a6DQnlq7OVbSBOExtbus 4egIrilQRAknioQMAvW3vx1YILbN9k8kzpwP9RUGf/9RfqxCAkUcGjJfLew6i2iV//jc YV0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date :mime-version:references:in-reply-to:from:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=vzaGOIsmPAAL83/pJCFjulh3hVl0NwiOSa6Klc/I4mI=; b=H8LEMkiGL6bc/BdGvy1itZBADSy3pU12lIVkxp65mpXYEux6f0uJmaNsZPetMOxjxD QakiYRtkmd/5/ObVfKUDbq1B7jCRpGrhfaUp9fybgwMskedMNKg3E2JUeeMLmgxzdlIs +2rI5orqykWENBNPp4x46TMOpcpMcC2Th6B6namHpr77TjhXEG9/WOAc9j8dMxLeWPB5 z3xgwnVy447H1xuurtslKLg9diPLA6kio7qjeIFm4eedxz+Ph6wjxPoetjMYJbcckVBs pMo/2NyUkxrSi2LLPHbzANgBlVlOoQlvXWNLgdLCqcfxfjj1uU9DokVuGqE3jKOzVcwC Y/tQ== X-Gm-Message-State: ACrzQf04DcD8OLmR+KdxOLyBHgF54ORjCT45ljPOKaIbV66YnErToXt0 KAjDicrlRHHTqR/XLtbHSvdXRiEeW8RUhXIOeAU= X-Google-Smtp-Source: AMsMyM5VOLam22w+h5mrxKxhEM2LUfXcnYK+faTqNjsIVdy44nQDDPuqxiFRbuU+CbDZmHQkRvbdK9jaAe1T9+v6/4o= X-Received: by 2002:a05:6808:14c3:b0:359:ac8d:41e2 with SMTP id f3-20020a05680814c300b00359ac8d41e2mr7726820oiw.92.1666971697644; Fri, 28 Oct 2022 08:41:37 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Fri, 28 Oct 2022 08:41:37 -0700 From: Stefan Kangas In-Reply-To: <871qqss31s.fsf@gmail.com> References: <87y1t2zl1s.fsf@cassou.me> <87fsf9vdr6.fsf@gmail.com> <87v8o5ts06.fsf@gmail.com> <87lep1tmie.fsf@gmail.com> <871qqss31s.fsf@gmail.com> X-Hashcash: 1:20:221028:damien@cassou.me::FGRXoC3soKhZUCdp:1gxg MIME-Version: 1.0 Date: Fri, 28 Oct 2022 08:41:37 -0700 Message-ID: Subject: Re: bug#58799: Make winner key sequences repeatable in repeat-mode To: Robert Pluim Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 58799 Cc: Damien Cassou , Lars Ingebrigtsen , 58799@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Robert Pluim writes: > (defvar-keymap footnote-minor-mode-map > :doc "Keymap used for binding footnote minor mode." > (key-description footnote-prefix) footnote-mode-map) > > That=CA=BCs perfectly valid, but fails with the above patch unless we > > 1. Check (key-valid-p (eval key)) > 2. Add an autoload cookie for footnote-minor-mode-map > > That seems too high a price to pay for avoiding the original problem. Hmm, that's a too high price to pay. Could we check for some common mistakes without having to say `(eval key)' though? For example by requiring KEY to be (or (stringp key) (listp key)) ? From debbugs-submit-bounces@debbugs.gnu.org Sun Oct 30 02:39:25 2022 Received: (at 58799) by debbugs.gnu.org; 30 Oct 2022 06:39:25 +0000 Received: from localhost ([127.0.0.1]:37181 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1op1yf-00081j-6g for submit@debbugs.gnu.org; Sun, 30 Oct 2022 02:39:25 -0400 Received: from mail.choca.pics ([80.67.172.235]:33158) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1op1yd-00081b-I7 for 58799@debbugs.gnu.org; Sun, 30 Oct 2022 02:39:23 -0400 Received: from localhost (localhost.localdomain [IPv6:::1]) by mail.choca.pics (Postfix) with ESMTP id D6140181942B3; Sun, 30 Oct 2022 07:39:22 +0100 (CET) Received: from mail.choca.pics ([IPv6:::1]) by localhost (mail.choca.pics [IPv6:::1]) (amavisd-new, port 10032) with ESMTP id l7nel9atiK8m; Sun, 30 Oct 2022 07:39:22 +0100 (CET) Received: from localhost (localhost.localdomain [IPv6:::1]) by mail.choca.pics (Postfix) with ESMTP id 4EAEA181942BF; Sun, 30 Oct 2022 07:39:22 +0100 (CET) X-Virus-Scanned: amavisd-new at choca.pics Received: from mail.choca.pics ([IPv6:::1]) by localhost (mail.choca.pics [IPv6:::1]) (amavisd-new, port 10026) with ESMTP id en7Nj_m7Pyw8; Sun, 30 Oct 2022 07:39:22 +0100 (CET) Received: from localhost (153.226.95.79.rev.sfr.net [79.95.226.153]) by mail.choca.pics (Postfix) with ESMTPSA id E2A30181942B3; Sun, 30 Oct 2022 07:39:21 +0100 (CET) From: Damien Cassou To: Stefan Kangas , 58799@debbugs.gnu.org Subject: Re: bug#58799: Make winner key sequences repeatable in repeat-mode In-Reply-To: References: <87y1t2zl1s.fsf@cassou.me> Date: Sun, 30 Oct 2022 07:39:21 +0100 Message-ID: <87ilk1olwm.fsf@cassou.me> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 58799 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain Hi Stefan, Stefan Kangas writes: > Damien Cassou writes: >> * lisp/winner.el (winner-repeat-map): New variable. >> (winner-undo): Put 'repeat-map' property with 'winner-repeat-map'. >> (winner-redo): Put 'repeat-map' property with 'winner-repeat-map'. > > There is no need to repeat the same text twice, so you can delete the > first occurrence. Indeed, fixed. >> +(defvar-keymap winner-repeat-map >> + :doc "Keymap to repeat winner key sequences. Used in `repeat-mode'." >> + [left] #'winner-undo >> + [right] #'winner-redo) > > It should be "" and "" here, I think. Fixed. Thank you very much for your reviews. -- Damien Cassou "Success is the ability to go from one failure to another without losing enthusiasm." --Winston Churchill --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-Make-winner-key-sequences-repeatable-in-repeat-mode.patch >From f23ee8ce89bf6e60d97d738f61e4663fd1e2b3dc Mon Sep 17 00:00:00 2001 From: Damien Cassou Date: Wed, 26 Oct 2022 16:53:23 +0200 Subject: [PATCH] Make winner key sequences repeatable in repeat-mode * lisp/winner.el (winner-repeat-map): New variable. (winner-undo): (winner-redo): Put 'repeat-map' property with 'winner-repeat-map'. --- lisp/winner.el | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/lisp/winner.el b/lisp/winner.el index 174b698e7b..d2040c7e5d 100644 --- a/lisp/winner.el +++ b/lisp/winner.el @@ -328,6 +328,14 @@ winner-mode-map map) "Keymap for Winner mode.") +(defvar-keymap winner-repeat-map + :doc "Keymap to repeat winner key sequences. Used in `repeat-mode'." + "" #'winner-undo + "" #'winner-redo) + +(put #'winner-undo 'repeat-map 'winner-repeat-map) +(put #'winner-redo 'repeat-map 'winner-repeat-map) + ;;;###autoload (define-minor-mode winner-mode -- 2.36.2 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sun Oct 30 08:38:40 2022 Received: (at 58799) by debbugs.gnu.org; 30 Oct 2022 12:38:40 +0000 Received: from localhost ([127.0.0.1]:37486 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1op7aK-0007fg-9G for submit@debbugs.gnu.org; Sun, 30 Oct 2022 08:38:40 -0400 Received: from mail-oi1-f175.google.com ([209.85.167.175]:42579) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1op7aE-0007fL-H7 for 58799@debbugs.gnu.org; Sun, 30 Oct 2022 08:38:38 -0400 Received: by mail-oi1-f175.google.com with SMTP id p127so10558006oih.9 for <58799@debbugs.gnu.org>; Sun, 30 Oct 2022 05:38:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:subject:message-id:date:mime-version:references:in-reply-to:from :from:to:cc:subject:date:message-id:reply-to; bh=iHPmAq4v/9PEeRxy8gKXD864LqoPnCCIWTMJMqaUq6g=; b=KG7gA/239ts9EYI0E55Av/KDGusSW6Dn1UN5AbLzNTQRRtEf3nsIdakvRqO1jzH6UX Qw1uWbqlRb+PRTje9G9Tv+h1JeAer92YYX1QANaaoQ4y/jb0M3/P4Rcewn1s0jW9kIvo 7C5n1vewEI95mq+b9p5GRC6g8lPSxJd+xV0uS+SwXMKeu8feWlpLYkZU2RnGhH37yPZz yGpxBkfZkhi3kDqWZ25GPUhULRshZH8uzFHS2YgCcum9k8NRoD9sU4RH3H9AvSPHBgxw RuO8nPw1ghEw18HwlRnjvHx5IhD58lsLYBDBpJwnrO0rXwvc5ov4kXwdm2LDGAhtJ2K2 S/Mg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:subject:message-id:date:mime-version:references:in-reply-to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=iHPmAq4v/9PEeRxy8gKXD864LqoPnCCIWTMJMqaUq6g=; b=vOCtfOIEKekoHGVGqW/Farp19bWCfXfIn6PBQs4009iPH4T3CgMDL0hLUoK42Erl/n rWPVxW2C9XSVcHjxs7rI3mY68A8F7q2atX4rteyfTthWQg2kT1aLWH4GzbCdxcKH0QAx Mjy8zGNf3ikY8J65H15ZJr9S32fsrDwXk3juzR/oFmcea/ytGAaJQG0M9YL2uWAtfik2 IlRkocBdv/fCAydYg4DEK2Ywdc+by4gJwT6aonhIYIluKTorY5DdxCMAc19wXB8gH/mx bzOhsQnqlC/hu6ZLwwFJTRME+PzxD5kXRkOeNBcQUnrfVtNt1o9GW6GGhfPhj4dkoCX1 7ZLQ== X-Gm-Message-State: ACrzQf1CfC8grIbcbbO0zkyvvGvVBPsz83htGs1HzcR2dlpwmjqxw06Q XRWFJgo3sDgGfGDjHcx1vKyUEZbsWDhscOSeUJx34cDY X-Google-Smtp-Source: AMsMyM7TPNNnKI6jWKvo/Y0QBWNzReISxsL2iqD/ti/KRvDYplJIjBctP8hrp56uvVTPMSSpN1Cow6lMUwg6lO/+yDI= X-Received: by 2002:a05:6808:1186:b0:353:b77a:a481 with SMTP id j6-20020a056808118600b00353b77aa481mr12595694oil.199.1667133508590; Sun, 30 Oct 2022 05:38:28 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Sun, 30 Oct 2022 05:38:28 -0700 From: Stefan Kangas In-Reply-To: <87ilk1olwm.fsf@cassou.me> References: <87y1t2zl1s.fsf@cassou.me> <87ilk1olwm.fsf@cassou.me> X-Hashcash: 1:20:221030:58799@debbugs.gnu.org::OnA1MUp7XyJCmHst:4FCY MIME-Version: 1.0 Date: Sun, 30 Oct 2022 05:38:28 -0700 Message-ID: Subject: Re: bug#58799: Make winner key sequences repeatable in repeat-mode To: Damien Cassou , 58799@debbugs.gnu.org Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 58799 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Damien Cassou writes: > From f23ee8ce89bf6e60d97d738f61e4663fd1e2b3dc Mon Sep 17 00:00:00 2001 > From: Damien Cassou > Date: Wed, 26 Oct 2022 16:53:23 +0200 > Subject: [PATCH] Make winner key sequences repeatable in repeat-mode > > * lisp/winner.el (winner-repeat-map): New variable. > (winner-undo): > (winner-redo): Put 'repeat-map' property with 'winner-repeat-map'. Thanks for the patch. I pushed it with this improved commit message (also adding the bug number): Make winner key sequences repeatable in repeat-mode * lisp/winner.el (winner-repeat-map): New variable. (winner-undo, winner-redo): Put 'repeat-map' property with 'winner-repeat-map'. (Bug#58799) I'm leaving the bug open as we are still discussing some improvements to `defvar-keymap'. From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 31 10:25:13 2022 Received: (at 58799) by debbugs.gnu.org; 31 Oct 2022 14:25:13 +0000 Received: from localhost ([127.0.0.1]:41456 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1opViy-0003gf-S4 for submit@debbugs.gnu.org; Mon, 31 Oct 2022 10:25:13 -0400 Received: from mail-wr1-f49.google.com ([209.85.221.49]:43679) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1opViw-0003gP-Km for 58799@debbugs.gnu.org; Mon, 31 Oct 2022 10:25:11 -0400 Received: by mail-wr1-f49.google.com with SMTP id g12so16198579wrs.10 for <58799@debbugs.gnu.org>; Mon, 31 Oct 2022 07:25:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=YhgJhgOYndEfRgZyGgNmm13URXT+qyR+fx21bJPv9e4=; b=LXKRKcTa9ymPz9F1jOBgoIhZf19gIVmM7xb2AuBRQqX3MpNGK5afZSuimdpDf8/H9d UsagiVU4d/r1PdOkN0+qoKTGYYvwtnh94imff57jmxd0mBmv3USV9xqu6Wb7xK1gGJow DY5QbJg21o2xmbKTSTZ3bhzQfJmegFrAJd/VpY93LLy6yifX4JIyKZD5JeEg2u8MTCv3 8apN4xAWwJfYOfLi9V6WNUdvsSzQQXazg3LS3LwTzpHcBYUz1OvkdQJvyEey6AsaT+Cv Ne727j9TilwcZfCYDxt2gmaGUHeQzmU8bgilkJmqdfmO1BK7W7O+3vVx99+mfzQthG/X r16w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=YhgJhgOYndEfRgZyGgNmm13URXT+qyR+fx21bJPv9e4=; b=kC8gUmYdzTAqQdjC+xV+S/SVlZDUM3xiU7KpRZshw2O0I1SFZcsD3oZGEXNshj0d4r XKytGdVkgiaTZ/AlX9D5Ip4KTQOkKQS7ffuuhgcuGHRsCzjA9pFBjUFQHJC3CMeXiGQ6 9ERQC4s6FdDMf27MsRfH+r5cuqqhWoRf0iwSWh3RZmop1LGt9TpiNHgVASmwIl6alv6b fM20gduAcYyXEwYVuQiTClvndI7P8YK1mB/Z68Z1kC/NDczR4S6EHZpv3OkYNxtbK4gt qIda0vdfJGZ2zL8RmtzfNgEikzaoPm82pODHxyYQYOQs2u2BNNohW838J52TGmaNNY/6 Gxdw== X-Gm-Message-State: ACrzQf3GBK9nQNvPrfZ6NVr9+QMfR+X2UPVlShxKNmEtKCXAHd14aLGS NetiaJhcqetK/n0ThhiwcAoFYE+/uRg= X-Google-Smtp-Source: AMsMyM6/O5+aT8vSqrHiDgdohy6i8Z55VPGL+9xW/Ynzy1XrT1/HI4tQ+0nd1HuTYPgSlNa5RNK0RQ== X-Received: by 2002:adf:8bc4:0:b0:236:73b7:84a with SMTP id w4-20020adf8bc4000000b0023673b7084amr8157415wra.8.1667226304334; Mon, 31 Oct 2022 07:25:04 -0700 (PDT) Received: from rltb ([82.66.8.55]) by smtp.gmail.com with ESMTPSA id j3-20020a05600c1c0300b003b4ff30e566sm26051439wms.3.2022.10.31.07.25.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 31 Oct 2022 07:25:03 -0700 (PDT) From: Robert Pluim To: Stefan Kangas Subject: Re: bug#58799: Make winner key sequences repeatable in repeat-mode In-Reply-To: (Stefan Kangas's message of "Fri, 28 Oct 2022 08:41:37 -0700") References: <87y1t2zl1s.fsf@cassou.me> <87fsf9vdr6.fsf@gmail.com> <87v8o5ts06.fsf@gmail.com> <87lep1tmie.fsf@gmail.com> <871qqss31s.fsf@gmail.com> Date: Mon, 31 Oct 2022 15:25:02 +0100 Message-ID: <87a65coytd.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 58799 Cc: Damien Cassou , Lars Ingebrigtsen , 58799@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >>>>> On Fri, 28 Oct 2022 08:41:37 -0700, Stefan Kangas said: Stefan> Robert Pluim writes: >> (defvar-keymap footnote-minor-mode-map >> :doc "Keymap used for binding footnote minor mode." >> (key-description footnote-prefix) footnote-mode-map) >>=20 >> That=CA=BCs perfectly valid, but fails with the above patch unless we >>=20 >> 1. Check (key-valid-p (eval key)) >> 2. Add an autoload cookie for footnote-minor-mode-map >>=20 >> That seems too high a price to pay for avoiding the original problem. Stefan> Hmm, that's a too high price to pay. Stefan> Could we check for some common mistakes without having to say `= (eval Stefan> key)' though? For example by requiring KEY to be Stefan> (or (stringp key) (listp key)) People also do things like this: (defcustom pong-left-key "4" "Alternate key to press for bat 1 to go up (primary one is [left])." :type '(restricted-sexp :match-alternatives (stringp vectorp))) . (defvar-keymap pong-mode-map :doc "Modemap for pong-mode." :name 'pong-mode-map pong-left-key #'pong-move-left so I=CA=BCm inclined to either fix it in `define-keymap' only, or just let the existing compiler macro for keymaps handle it. In any case, I think we can close this particular bug. Robert --=20 From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 31 10:47:44 2022 Received: (at 58799) by debbugs.gnu.org; 31 Oct 2022 14:47:44 +0000 Received: from localhost ([127.0.0.1]:41479 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1opW4l-0004DP-W4 for submit@debbugs.gnu.org; Mon, 31 Oct 2022 10:47:44 -0400 Received: from mail-oi1-f180.google.com ([209.85.167.180]:45584) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1opW4k-0004D4-EG for 58799@debbugs.gnu.org; Mon, 31 Oct 2022 10:47:42 -0400 Received: by mail-oi1-f180.google.com with SMTP id t62so2186064oib.12 for <58799@debbugs.gnu.org>; Mon, 31 Oct 2022 07:47:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:from:to:cc:subject:date:message-id:reply-to; bh=fHWlObN0JEHRUBB7aJtN72948P3s4kzZUBCwnlg2Zx8=; b=qaCO3WizGOY05Eh0w6sjH+6t+WlSkyO1ogMnBQpbeyw52yp3veNB7DhpK7dqXsKWGg AwL5vxlAhCWCL114naUgWj2o3/vnPjRfiW+8Xy5Y3rDT5/lBFSYG9VGYr1db766RCAbe Op8z5Zl2+BwQTu9oZAa3L3F9wP75KbjWjIoX3/qa6Pg8E5tEVtP8nsQxOoXBnbrKVJPj rFV/oOttRtNi1fZ8UXFxRLJQRoMvNAGJiC0Bilk2DsxRdX0sBRkWbizHrS5LsGMKxNb4 dH2I/VqR3GG+MSyubHU5jznm/xtW5hcAerPlu+WEHYqvhlFG3GYFMOqX3VdqgX5iUJmb eq3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=fHWlObN0JEHRUBB7aJtN72948P3s4kzZUBCwnlg2Zx8=; b=C4k6KpseSb6zABTFsRJtauup+Dgrm/5ZJ0HoTvN06NCYy82JYVOajpTFF2wVhzQBp2 YhCl7v8KSZggH0R7FdsL14i6LwiI/CJOYtgIgAYuTsKHq+XLVAs2pj4TzIwUPOwm1CRE /zrd9Omh1/V4s46iNVIStHF3BIiwN8GetNuX2zS/g4oD+Xy6wXgb9wfk9ACLsVgK2ZC8 f3TQXNuiwpuazChVYB3+m8s8aY5NvEXs4o2QAVc/PS/nViNJ8fqhLRFrbjqFf17P8lfK 4hgSA0Aoiqw5naM5kc/wH+Id339XZpMKx1zePXTgeNFdTQQE/ch4PWeKV7sDoMvv+k1o /Y5g== X-Gm-Message-State: ACrzQf2KmMnETECTHlKYHQcgVhLSz+rsKN/PaPoMhBthVRCZoKLtFcgA zPGBALJ3qnSHoq6PNFOKt4V2WUzJqoDqyvxkVes= X-Google-Smtp-Source: AMsMyM5CPG5kxsuFWOIMtFraFP9eZ7Kj4+Dm7Sckx8B8xwRxGtztomMAQHyui8iJO/QqhruiyfhKq3iyLoMMZLrI4DI= X-Received: by 2002:a05:6808:14c3:b0:359:ac8d:41e2 with SMTP id f3-20020a05680814c300b00359ac8d41e2mr14316273oiw.92.1667227656872; Mon, 31 Oct 2022 07:47:36 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Mon, 31 Oct 2022 07:47:36 -0700 From: Stefan Kangas In-Reply-To: <87a65coytd.fsf@gmail.com> References: <87y1t2zl1s.fsf@cassou.me> <87fsf9vdr6.fsf@gmail.com> <87v8o5ts06.fsf@gmail.com> <87lep1tmie.fsf@gmail.com> <871qqss31s.fsf@gmail.com> <87a65coytd.fsf@gmail.com> X-Hashcash: 1:20:221031:58799@debbugs.gnu.org::okPhIntWuexBnrYO:3j11 MIME-Version: 1.0 Date: Mon, 31 Oct 2022 07:47:36 -0700 Message-ID: Subject: Re: bug#58799: Make winner key sequences repeatable in repeat-mode To: Robert Pluim Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 58799 Cc: Damien Cassou , Lars Ingebrigtsen , 58799@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) close 58799 29.1 thanks Robert Pluim writes: > In any case, I think we can close this particular bug. Agreed. Now done. From unknown Mon Jun 23 00:37:20 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Tue, 29 Nov 2022 12:24:13 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator