From unknown Mon Jun 23 00:37:19 2025 X-Loop: help-debbugs@gnu.org Subject: bug#58797: 29.0.50; Revise format of stored message tags in ERC Resent-From: "J.P." Original-Sender: "Debbugs-submit" Resent-CC: emacs-erc@gnu.org, bug-gnu-emacs@gnu.org Resent-Date: Wed, 26 Oct 2022 13:21:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 58797 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: 58797@debbugs.gnu.org Cc: emacs-erc@gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org X-Debbugs-Original-Xcc: emacs-erc@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.16667904582175 (code B ref -1); Wed, 26 Oct 2022 13:21:02 +0000 Received: (at submit) by debbugs.gnu.org; 26 Oct 2022 13:20:58 +0000 Received: from localhost ([127.0.0.1]:53695 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ongL3-0000Yz-Ag for submit@debbugs.gnu.org; Wed, 26 Oct 2022 09:20:58 -0400 Received: from lists.gnu.org ([209.51.188.17]:34550) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ongKz-0000Yq-0S for submit@debbugs.gnu.org; Wed, 26 Oct 2022 09:20:54 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ongKp-0002to-PP for bug-gnu-emacs@gnu.org; Wed, 26 Oct 2022 09:20:47 -0400 Received: from mail-108-mta63.mxroute.com ([136.175.108.63]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ongKl-0005W0-Un for bug-gnu-emacs@gnu.org; Wed, 26 Oct 2022 09:20:42 -0400 Received: from mail-111-mta2.mxroute.com ([136.175.111.2] filter006.mxroute.com) (Authenticated sender: mN4UYu2MZsgR) by mail-108-mta63.mxroute.com (ZoneMTA) with ESMTPSA id 1841473a9070006e99.001 for (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES128-GCM-SHA256); Wed, 26 Oct 2022 13:20:35 +0000 X-Zone-Loop: c2b41119ea888c53565df724e1fea2c97835cf8fc80b X-Originating-IP: [136.175.111.2] DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=neverwas.me ; s=x; h=Content-Type:MIME-Version:Message-ID:Date:Subject:To:From:Sender: Reply-To:Cc:Content-Transfer-Encoding:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: In-Reply-To:References:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=qNMzeoKtUffNd0MPHPh5WiSMtI60ACmfHL8DQm3oTrw=; b=FJW7BGwbTNtwXbavELSe3ollPE gQerdtz+wesKaj5vI/xmFM6KcX6Sj+EnDAeC6LZ3U0mz/55KNAaK6QcITmEqErbVy107A0+Rtqmzv k4/NHRYp6xDGldioUQYM0v3Q5eqcmS1XBtHm5IriITxJJephETHBEAf9gMjf47RJ7Bdo0C4NkROi8 uJ0Lvdi2Qgh2T+SvzUmUH5WKZU/XejFRT6UK8G3j4WZHmt0IIek1FEHruljF9ucCanpR8vwYMaIUr LYTH4QtY+sEnN8NLjsEKjxfbZodXsCjuQfFH8yb8TZKPxDqDdtn65ewdnZkz1JlgzG1uLCPSCisfS dRjorEpw==; From: "J.P." Date: Wed, 26 Oct 2022 06:20:32 -0700 Message-ID: <87fsfa4t7j.fsf@neverwas.me> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Authenticated-Id: masked@neverwas.me Received-SPF: pass client-ip=136.175.108.63; envelope-from=jp@neverwas.me; helo=mail-108-mta63.mxroute.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) --=-=-= Content-Type: text/plain Tags: patch I'm proposing we change the format (type) of the "tags" field in the `erc-response' struct from (STRING . LIST) where LIST contains at most one (possibly empty) string, to (SYMBOL . OPT-STRING) where OPT-STRING, when non-nil, is a nonempty string. For ERC 5.5 and Emacs 29, this change would merely manifest as a warning when first encountered. In subsequent releases, it would still be reserved only for users who opt in by activating optional modules. Rationale below. Thanks, J.P. Imagined FAQ: Why bother? In the existing implementation, all code accessing a processed tag value must check that it's both non-nil and nonempty. This stands to become a common occurrence with the arrival of IRCv3 in future releases. The majority of instances will only contain one item (a timestamp) and will persist beyond the parsing stage as text properties in ERC buffers. And since we need to redo the parsing anyway to abide by all the escaping rules and other spec minutiae, we might as well make the processed goods as easy to manage as possible, no? Isn't this a breaking change? Yes. But I believe preserving backward compatibility (by adding an additional field and keeping the old one around) is less important in this case because the field currently goes unused in ERC's client code and is likely underused in user code (based on a cursory survey of Melpa packages, popular shared configs, and wiki snippets). While message tags *are* currently parsed when present, the field is only ever written to and never again accessed (on account of ERC's lack of general IRCv3 support). That said, the library function as well as the `erc-response' structure are indeed public (exported). There is also the matter of authoritative intent to consider. The doc string for the function `erc-parse-tags' describes its return type as being an alist of "(tag . value)". For anyone willing to entertain "value" as meaning "logical tag value," this change becomes a belated bug fix. Why now? Why not wait? It's true that the main benefit of doing this won't be felt for a couple more ERC releases. As stated above, the immediate effect of this change will merely be as a warning for any user code that depends on this field. This approach seems somewhat in keeping with the overall Emacs policy for function and variable deprecation. In GNU Emacs 29.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.34, cairo version 1.17.6) of 2022-10-26 built on localhost Repository revision: 832bd2dfe51b2b9ea5e0e56e0e6ee60b2d8ae2ed Repository branch: master Windowing system distributor 'The X.Org Foundation', version 11.0.12014000 System Description: Fedora Linux 36 (Workstation Edition) Configured using: 'configure --enable-check-lisp-object-type --enable-checking=yes,glyphs 'CFLAGS=-O0 -g3' PKG_CONFIG_PATH=:/usr/lib64/pkgconfig:/usr/share/pkgconfig' Configured features: ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GPM GSETTINGS HARFBUZZ JPEG JSON LCMS2 LIBOTF LIBSELINUX LIBSYSTEMD LIBXML2 M17N_FLT MODULES NOTIFY INOTIFY PDUMPER PNG RSVG SECCOMP SOUND SQLITE3 THREADS TIFF TOOLKIT_SCROLL_BARS WEBP X11 XDBE XIM XINPUT2 XPM GTK3 ZLIB Important settings: value of $LANG: en_US.UTF-8 value of $XMODIFIERS: @im=ibus locale-coding-system: utf-8-unix Major mode: Lisp Interaction Minor modes in effect: tooltip-mode: t global-eldoc-mode: t eldoc-mode: t show-paren-mode: t electric-indent-mode: t mouse-wheel-mode: t tool-bar-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t line-number-mode: t indent-tabs-mode: t transient-mark-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t Load-path shadows: None found. Features: (shadow sort mail-extr emacsbug message mailcap yank-media puny dired dired-loaddefs rfc822 mml mml-sec password-cache epa derived epg rfc6068 epg-config gnus-util text-property-search time-date subr-x mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader cl-loaddefs cl-lib sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils rmc iso-transl tooltip cconv eldoc paren electric uniquify ediff-hook vc-hooks lisp-float-type elisp-mode mwheel term/x-win x-win term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch easymenu timer select scroll-bar mouse jit-lock font-lock syntax font-core term/tty-colors frame minibuffer nadvice seq simple cl-generic indonesian philippine cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite emoji-zwj charscript charprop case-table epa-hook jka-cmpr-hook help abbrev obarray oclosure cl-preloaded button loaddefs theme-loaddefs faces cus-face macroexp files window text-properties overlay sha1 md5 base64 format env code-pages mule custom widget keymap hashtable-print-readable backquote threads dbusbind inotify lcms2 dynamic-setting system-font-setting font-render-setting cairo move-toolbar gtk x-toolkit xinput2 x multi-tty make-network-process emacs) Memory information: ((conses 16 36089 6500) (symbols 48 5118 0) (strings 32 13124 1756) (string-bytes 1 372990) (vectors 16 9304) (vector-slots 8 147959 9387) (floats 8 21 29) (intervals 56 220 0) (buffers 1000 10)) --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-Warn-of-future-breaking-change-to-erc-response.tags.patch >From 44cb69befc28ae4e14499521fb2f8a09d7acaf5c Mon Sep 17 00:00:00 2001 From: "F. Jason Park" Date: Mon, 24 Oct 2022 22:58:13 -0700 Subject: [PATCH] Warn of future breaking change to erc-response.tags * lisp/erc/erc-backend.el (erc-parse-tags-format): New option to determine type of the `erc-response' "tags" field. (erc-parse-tags): Defer to internal generic function. (erc--parse-tags): New function to hold original `erc-parse-tags' implementation. (erc--parse-message-tags): New generic function that conditionally calls `erc--parse-tags', perhaps emitting a warning beforehand. (erc-parse-server-response): Call `erc--parse-message-tags'. --- lisp/erc/erc-backend.el | 59 ++++++++++++++++++++++++++++++++++++++--- 1 file changed, 56 insertions(+), 3 deletions(-) diff --git a/lisp/erc/erc-backend.el b/lisp/erc/erc-backend.el index df9efe4b0c..9854e863c3 100644 --- a/lisp/erc/erc-backend.el +++ b/lisp/erc/erc-backend.el @@ -992,8 +992,39 @@ erc-send-ctcp-notice ;;;; Handling responses +(defcustom erc-tags-format 'overridable + "Shape of the `tags' alist in `erc-response' objects. +When set to `legacy', pre-5.5 parsing behavior takes effect for +the tags portion of every message. The resulting alist contains +conses of the form (STRING . LIST), in which LIST is comprised of +at most one (possibly empty) string. + +When nil, ERC only parses tags if an active module defines an +implementation. It otherwise ignores them. In such cases, each +alist element is a cons of a symbol and an optional, non-empty +string. + +With the default value of `overridable', ERC behaves as it does +with `legacy' except that it emits a warning whenever first +encountering a message containing tags in a given Emacs session. +But it only does so when a module implementing overriding, +non-legacy behavior isn't already active in the current network +context. + +Note that future bundled modules providing IRCv3 functionality +may not be compatible with the legacy format. User code should +eventually transition to expecting this \"5.5+ variant\" and set +this option to nil." + :package-version '(ERC . "5.4.1") ; FIXME increment on next release + :type '(choice (const nil) + (const legacy) + (const overridable))) + (defun erc-parse-tags (string) "Parse IRCv3 tags list in STRING to a (tag . value) alist." + (erc--parse-message-tags string)) + +(defun erc--parse-tags (string) (let ((tags) (tag-strings (split-string string ";"))) (dolist (tag-string tag-strings tags) @@ -1003,6 +1034,28 @@ erc-parse-tags `(,pair)) tags))))) +;; One benefit of this function being internal is to avoid having to +;; define a separate method just to ensure an `erc-tags-format' value +;; of `legacy' always wins. The downside is that module code must +;; take care to preserve that promise manually. + +(cl-defgeneric erc--parse-message-tags (string) + "Parse STRING into an alist of (TAG . VALUE) conses. +TAG is a symbol. VALUE is nil or a non-empty string. Composite +raw input values containing commas are never split but always +left as a single string." + (when erc-tags-format + (unless (or (eq erc-tags-format 'legacy) + (get 'erc-parse-tags 'erc-v3-warned-p)) + (put 'erc-parse-tags 'erc-v3-warned-p t) + (display-warning + 'ERC + (concat + "Legacy ERC tags behavior is currently in effect, but other modules," + " including those bundled with ERC, may override this in future" + " releases. See `erc-tags-format' for more info."))) + (erc--parse-tags string))) + (defun erc-parse-server-response (proc string) "Parse and act upon a complete line from an IRC server. PROC is the process (connection) from which STRING was received. @@ -1012,9 +1065,9 @@ erc-parse-server-response (let* ((tag-list (when (eq (aref string 0) ?@) (substring string 1 (string-search " " string)))) - (msg (make-erc-response :unparsed string :tags (when tag-list - (erc-parse-tags - tag-list)))) + (msg (make-erc-response :unparsed string :tags + (when tag-list + (erc--parse-message-tags tag-list)))) (string (if tag-list (substring string (+ 1 (string-search " " string))) string)) -- 2.37.3 --=-=-=-- From unknown Mon Jun 23 00:37:19 2025 X-Loop: help-debbugs@gnu.org Subject: bug#58797: 29.0.50; Revise format of stored message tags in ERC In-Reply-To: <87fsfa4t7j.fsf@neverwas.me> Resent-From: Emanuel Berg Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 27 Oct 2022 08:32:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58797 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: 58797@debbugs.gnu.org Cc: emacs-erc@gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.16668594724795 (code B ref -1); Thu, 27 Oct 2022 08:32:03 +0000 Received: (at submit) by debbugs.gnu.org; 27 Oct 2022 08:31:12 +0000 Received: from localhost ([127.0.0.1]:56105 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1onyIB-0001FF-FI for submit@debbugs.gnu.org; Thu, 27 Oct 2022 04:31:11 -0400 Received: from lists.gnu.org ([209.51.188.17]:55304) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1onxbi-000085-Kw for submit@debbugs.gnu.org; Thu, 27 Oct 2022 03:47:22 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1onxbg-0002x3-BZ for bug-gnu-emacs@gnu.org; Thu, 27 Oct 2022 03:47:18 -0400 Received: from ciao.gmane.io ([116.202.254.214]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1onxbe-0006QQ-5W for bug-gnu-emacs@gnu.org; Thu, 27 Oct 2022 03:47:16 -0400 Received: from list by ciao.gmane.io with local (Exim 4.92) (envelope-from ) id 1onxbT-0008G1-NS for bug-gnu-emacs@gnu.org; Thu, 27 Oct 2022 09:47:03 +0200 X-Injected-Via-Gmane: http://gmane.org/ Mail-Followup-To: bug-gnu-emacs@gnu.org From: Emanuel Berg Followup-To: gmane.emacs.erc.general Date: Thu, 27 Oct 2022 09:46:48 +0200 Message-ID: <87fsf9r9nb.fsf@dataswamp.org> References: <87fsfa4t7j.fsf@neverwas.me> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit User-Agent: Gnus/5.13 (Gnus v5.13) Cancel-Lock: sha1:cSZt1wgADKJu1BIt4pClvlFGmao= Mail-Copies-To: never Received-SPF: pass client-ip=116.202.254.214; envelope-from=geb-bug-gnu-emacs@m.gmane-mx.org; helo=ciao.gmane.io X-Spam_score_int: -16 X-Spam_score: -1.7 X-Spam_bar: - X-Spam_report: (-1.7 / 5.0 requ) BAYES_00=-1.9, HEADER_FROM_DIFFERENT_DOMAINS=0.249, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.1 (-) X-Mailman-Approved-At: Thu, 27 Oct 2022 04:31:09 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.1 (--) J.P. wrote: > Tags: patch > > I'm proposing we change the format (type) of the "tags" > field in the `erc-response' What is that, it's not a variable and it's not a function ... > struct from > > (STRING . LIST) > > where LIST contains at most one (possibly empty) string, to > > (SYMBOL . OPT-STRING) Well, as you know, symbol and string are object types in Emacs, the use of the "OPT" prefix OTOH signals it's a name and the purpose is to hold options, this mix isn't good IMO. You can change OPT to OPTS perhaps, SYMBOL I don't know what to change to since I don't know what symbols are intended to be stored there ... Also IMO the dotted list data structure is passé but if code relies on it I don't suggest changing that just for the sake of it ... > For ERC 5.5 and Emacs 29 Okay, but isn't ERC built-in only or can you get "future" version of ERC from GNU ELPA? Okay, that's it then, I see that 5.4.1 is avaliable there, I'm on ERC 5.4.1 (IRC client for GNU Emacs 29.0.50) But I use, as you see already, a very fresh Emacs, namely GNU Emacs 29.0.50 (build 1, x86_64-pc-linux-gnu, cairo version 1.16.0) of 2022-10-09 [commit a2dd9d683a02525183b5e692e42622c65639dda8] so I guess I'm on the edge here :) > Why bother? To improve the software ... > Isn't this a breaking change? You can't make an omelet without hatching eggs ... > Why now? Why not wait? Do it today, in a different way! -- underground experts united https://dataswamp.org/~incal From unknown Mon Jun 23 00:37:19 2025 X-Loop: help-debbugs@gnu.org Subject: bug#58797: 29.0.50; Revise format of stored message tags in ERC Resent-From: "J.P." Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 28 Oct 2022 13:31:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58797 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Emanuel Berg Cc: 58797@debbugs.gnu.org, emacs-erc@gnu.org X-Debbugs-Original-Cc: bug-gnu-emacs@gnu.org, emacs-erc@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.16669638352759 (code B ref -1); Fri, 28 Oct 2022 13:31:02 +0000 Received: (at submit) by debbugs.gnu.org; 28 Oct 2022 13:30:35 +0000 Received: from localhost ([127.0.0.1]:60686 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ooPRP-0000bs-VE for submit@debbugs.gnu.org; Fri, 28 Oct 2022 09:30:35 -0400 Received: from lists.gnu.org ([209.51.188.17]:50438) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ooPRN-0000Vh-Oh for submit@debbugs.gnu.org; Fri, 28 Oct 2022 09:30:30 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ooPR4-0001Ek-Kl for bug-gnu-emacs@gnu.org; Fri, 28 Oct 2022 09:30:18 -0400 Received: from mail-108-mta52.mxroute.com ([136.175.108.52]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ooPR2-0006NB-J0 for bug-gnu-emacs@gnu.org; Fri, 28 Oct 2022 09:30:10 -0400 Received: from mail-111-mta2.mxroute.com ([136.175.111.2] filter006.mxroute.com) (Authenticated sender: mN4UYu2MZsgR) by mail-108-mta52.mxroute.com (ZoneMTA) with ESMTPSA id 1841ec90e990006e99.002 for (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES128-GCM-SHA256); Fri, 28 Oct 2022 13:30:03 +0000 X-Zone-Loop: 0f96afdf56f7d2e9f39b20b169b4ac4a234666ee41e4 X-Originating-IP: [136.175.111.2] DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=neverwas.me ; s=x; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To: Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=PMqV0ZxPtKVoJgRzTBf6Qdyq9Yg3kM34brsAJC8F950=; b=jXb3cmjdeYbEtDq7ivkfMeXtaB ResVZz+FkkO2rDkQ0BJ60mT3EFzO2eEGuFJdsrAGcY2Lmag4d2LFaSV0pt79CYC+dnz23MlD5RhmU CfaHReQ3eMw9T1kzIYnJjDa/hgHWDU7/oAWlQ+Os20EOb1NlCTXr+ix/UDyBzuipxjYbimGkdw5US KqGzC1L26YVtsKkcPssmEFMO6YlaFgkgPgnN5kjAkxLia+oxddyr0hGaRIbtjBgn/+YJ3vN5T9CuM gVr6zyuuVscBP+9IoDM7OPfoN17nnbJzwv/DNR3vZEL1E9+k47Mr7im61QMJCb8rB8mINYjwxX2np FFuhD3Pg==; From: "J.P." In-Reply-To: <87fsf9r9nb.fsf@dataswamp.org> (Emanuel Berg's message of "Thu, 27 Oct 2022 09:46:48 +0200") References: <87fsfa4t7j.fsf@neverwas.me> <87fsf9r9nb.fsf@dataswamp.org> Date: Fri, 28 Oct 2022 06:29:39 -0700 Message-ID: <87k04knkjg.fsf@neverwas.me> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Authenticated-Id: masked@neverwas.me Received-SPF: pass client-ip=136.175.108.52; envelope-from=jp@neverwas.me; helo=mail-108-mta52.mxroute.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Emanuel Berg writes: > J.P. wrote: > >> Tags: patch >> >> I'm proposing we change the format (type) of the "tags" >> field in the `erc-response' > > What is that, it's not a variable and it's not a function ... Um, I guess by "type" I meant something more like `:type' in the broader "describing the shape of some field" sense. Not so much (info "(elisp) Lisp Data Types") or what have you. Apologies for the confusion. >> struct from >> >> (STRING . LIST) >> >> where LIST contains at most one (possibly empty) string, to >> >> (SYMBOL . OPT-STRING) > > Well, as you know, symbol and string are object types in > Emacs, the use of the "OPT" prefix OTOH signals it's a name > and the purpose is to hold options, this mix isn't good IMO. > > You can change OPT to OPTS perhaps, SYMBOL I don't know what > to change to since I don't know what symbols are intended to > be stored there ... Poor choice of descriptive label on my part, clearly. I didn't mean to suggest a custom user option but rather something like a NIL-OR-NONEMPTY-STRING. IOW, whatever might satisfy a `typep' spec of '(cons symbol (or null (and string (not (string 0))))) or similar (bastardized pseudo-CL notwithstanding). >> For ERC 5.5 and Emacs 29 > > Okay, but isn't ERC built-in only or can you get "future" > version of ERC from GNU ELPA? Okay, that's it then, I see that > 5.4.1 is avaliable there, I'm on > > ERC 5.4.1 (IRC client for GNU Emacs 29.0.50) The releases on ELPA are basically snapshots of lisp/erc taken whenever the ";; Version: " header changes. So, the work you see on HEAD is still unreleased. It's possible that incrementing the version ahead of time (like to 5.5-git or something) would make that clearer, but AFAIK we can't do that without triggering yet another release. Hope that makes sense. From debbugs-submit-bounces@debbugs.gnu.org Sat Nov 12 15:45:36 2022 Received: (at control) by debbugs.gnu.org; 12 Nov 2022 20:45:36 +0000 Received: from localhost ([127.0.0.1]:49227 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1otxNg-0006tC-Cf for submit@debbugs.gnu.org; Sat, 12 Nov 2022 15:45:36 -0500 Received: from mail-ot1-f48.google.com ([209.85.210.48]:35761) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1otxNb-0006QU-8A for control@debbugs.gnu.org; Sat, 12 Nov 2022 15:45:31 -0500 Received: by mail-ot1-f48.google.com with SMTP id cn2-20020a056830658200b0066c74617e3dso4643608otb.2 for ; Sat, 12 Nov 2022 12:45:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:subject:message-id:date:mime-version:from:from:to:cc:subject :date:message-id:reply-to; bh=I+8n6oHVTTVFqRvZr4rhuyw2kXQFNVp7FZrjh+MGxpY=; b=FOljXi6q19killpStyM9AQke4PnnzXU/f1vTdtmbMNdviszMvwnrt86NHPdE35Pqfw csdHAh6Zelsyp+rGNLR/8BYEqvOGa6LUMtksJVtXklDDWd+2mwhZs+M1czLjH9WCfaVC H5u7qZtFFaQPhNh1cfqqT9pFL8wBPf7Uq/fGibW1WPnIGgxqxpudzT/HxxgEPFQT8PrI u9ybBB8e5xrtp7miWk4L3iHBLDcHByfcFdkCDkZJY39rYV1SoOtD/hj8FwOqtBTicHiv EUbrV/Z5y6JMm2xHKvvbLRqDB3rO0yXT6R4lGND05EtFizKCNJzGL5DXG/VwdkwXXO8K pQSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:subject:message-id:date:mime-version:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=I+8n6oHVTTVFqRvZr4rhuyw2kXQFNVp7FZrjh+MGxpY=; b=3P3lnPF/p+bXzPjBx3tjZtE3ReNIwSdpswDgIQqPGucm454HdAE4BAZoBpLH5McEAA ypETdvt3JBActq1s0QdepMuvtiuZbS3/wLAhBXLO1blX6e6vQ4pFVwzdtK5YgOaU3A+1 3E9+VCN5s2or+Sm4lv2qlEM/4efYaYZQR2YJSvguJYN5VjqkeckZMtDZy8EZ7cZcEaM7 IP3dwUcvLSTxBywcV6JeNaAqgO4IlVO6kPxg5hHM7vAKsTCA+YBwR7eQGtCxs7+PIrzv SvFlMtbjfcBszQVlzY7b/glmZP/29RXTdrEPXZhzP0slVLRxjJvl6WEZZuOkp2Ia3dU0 62XQ== X-Gm-Message-State: ANoB5pnUl5ryIaEWOZ85JGnulKzSizPHZCKOlWomrhvllHdsdS00tPNO etnWgC+WcOqYFQuJmuRUFVZo1Aqrn3tTx2xNoixpP6MB X-Google-Smtp-Source: AA0mqf6vW4sF9lIXzXPTrf6C8mG2toKh6UJInvGgvEX8YrDhX0J9vCkLErhzNwHWFqoCTK+F9TrE4FlesKj8TB2Zl6s= X-Received: by 2002:a9d:6399:0:b0:661:c48b:12db with SMTP id w25-20020a9d6399000000b00661c48b12dbmr3784727otk.105.1668285925807; Sat, 12 Nov 2022 12:45:25 -0800 (PST) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Sat, 12 Nov 2022 12:45:25 -0800 From: Stefan Kangas X-Hashcash: 1:20:221112:control@debbugs.gnu.org::zEjNNZEc9e55lqP2:aJw MIME-Version: 1.0 Date: Sat, 12 Nov 2022 12:45:25 -0800 Message-ID: Subject: control message for bug #58797 To: control@debbugs.gnu.org Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) severity 58797 wishlist quit From debbugs-submit-bounces@debbugs.gnu.org Sat Nov 19 16:46:54 2022 Received: (at control) by debbugs.gnu.org; 19 Nov 2022 21:46:54 +0000 Received: from localhost ([127.0.0.1]:41550 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1owVfq-0001Uk-5X for submit@debbugs.gnu.org; Sat, 19 Nov 2022 16:46:54 -0500 Received: from mail-108-mta223.mxroute.com ([136.175.108.223]:46207) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1owVfl-0001UU-O8 for control@debbugs.gnu.org; Sat, 19 Nov 2022 16:46:52 -0500 Received: from mail-111-mta2.mxroute.com ([136.175.111.2] filter006.mxroute.com) (Authenticated sender: mN4UYu2MZsgR) by mail-108-mta223.mxroute.com (ZoneMTA) with ESMTPSA id 18491dba9f50006e99.001 for (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES128-GCM-SHA256); Sat, 19 Nov 2022 21:46:43 +0000 X-Zone-Loop: 21ab5eaef8712ec79a7610fac65140fdd93f7d0ba705 X-Originating-IP: [136.175.111.2] DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=neverwas.me ; s=x; h=Content-Type:MIME-Version:Message-ID:Date:Subject:To:From:Sender: Reply-To:Cc:Content-Transfer-Encoding:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: In-Reply-To:References:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=2pIMILalBKBivdEy7IZWcCrpJUSh48JftWAYZ1lasiU=; b=fXeYVvkQwy9UxYM2CfH3xyh7Yc jsfsiP5U4wh6zkdLNzyorBqU0IAop3/WPrznwt8f9YRcUBNS9z3NE48QAXSZMyImXASXv/fFcIOfX I3vbkw4xAwJOuQJcVscd5QLvZvdG3iryvTkZ7py54nqAdjrwpXMHOQrPmW+es+q5KeTeFCyJIhWw8 DOPI+rKNMs1Wvh1z5I+nx46lsHve2uVDCVlfZUwSfQcbSvnnRlAXJrae4DTEzZzz/Sul5A9R9K8P0 hDA/u4BjQ+1MtatNAU3Wr7PB8W/Uzrei1bwjr3mLhv10raU0mkBpS7CO5X5/IhbCQ+gy1WOm65CyY KPdk2VfQ==; From: "J.P." To: control@debbugs.gnu.org Subject: control message for bug #58797 Date: Sat, 19 Nov 2022 13:46:40 -0800 Message-ID: <87pmdisjlr.fsf@neverwas.me> MIME-Version: 1.0 Content-Type: text/plain X-Authenticated-Id: masked@neverwas.me X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) close 58797 29.1 quit