GNU bug report logs - #58790
Eglot URI parsing bug when using clojure-lsp server

Previous Next

Full log

Message #83 received at 58790 <at> debbugs.gnu.org (full text, mbox):

From: Danny Freeman <danny <at> dfreeman.email>
To: João Távora <joaotavora <at> gmail.com>
Cc: Eli Zaretskii <eliz <at> gnu.org>, dgutov <at> yandex.ru, felician.nemeth <at> gmail.com,
 58790 <at> debbugs.gnu.org, stefankangas <at> gmail.com
Subject: Re: bug#58790: Eglot URI parsing bug when using clojure-lsp server
Date: Thu, 10 Nov 2022 17:57:30 -0500

João Távora <joaotavora <at> gmail.com> writes:

> I've now pushed the first patch, but I held off the second patch.
>
> I don't see this OPERATION=nil option documented in the docstring of
> find-file-name-handler, so I'm not sure we should rely on it.
>
> I think we should provide OPERATION here, because what we want to check
> is if we, Emacs, can actually visit the file designated by the URI.  So
> I think passing something like 'access-file' as the OPERATION argument
> makes more sense.  But Eli probably has more knowledge here.  Maybe
> passing nil is indeed correct.

If we want to not use nil I think a real operation argument like
`access-file' or `expand-file-name' would be more warranted then.
The made up one I initially used I was not a big fan of.

-- 
Danny Freeman

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.