GNU bug report logs - #58790
Eglot URI parsing bug when using clojure-lsp server

Previous Next

Full log

View this message in rfc822 format

From: João Távora <joaotavora <at> gmail.com>
To: Danny Freeman <danny <at> dfreeman.email>
Cc: Eli Zaretskii <eliz <at> gnu.org>, dgutov <at> yandex.ru, felician.nemeth <at> gmail.com, 58790 <at> debbugs.gnu.org, stefankangas <at> gmail.com
Subject: bug#58790: Eglot URI parsing bug when using clojure-lsp server
Date: Thu, 10 Nov 2022 22:30:54 +0000

Danny Freeman <danny <at> dfreeman.email> writes:

> João Távora <joaotavora <at> gmail.com> writes:
>
>> I agree on the two comments about the ChangeLog style entries and the
>> spacing.  
>>
>> But when dealing with eglot.el, which I am the prime maintainer of, 
>> I really prefer to see design described in the commit message where the 
>> design was introduced. It plays very well with vc-region-history.
>>
>> So Danny, if you don't mind, please revert that part.  
>>
>> João
>
> Yall all really taking me for a ride on this lol.

Sorry.  The Emacs commit message format is a bit of work in the
beginning but it pays off in the end.  I will make minor adjustment to
your patches and push them now.

> In reviewing the comments over and over I've made a modification to the
> second patch involving the warning message. Instead of using an
> arbitrary symbol I realized that the function `find-file-name-handler'
> works when a nil value for the second argument (operation).

OK, I will look at this part, too.

João

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.