GNU bug report logs - #58790
Eglot URI parsing bug when using clojure-lsp server

Previous Next

Full log

Message #71 received at 58790 <at> debbugs.gnu.org (full text, mbox):

From: Danny Freeman <danny <at> dfreeman.email>
To: João Távora <joaotavora <at> gmail.com>
Cc: Eli Zaretskii <eliz <at> gnu.org>, dgutov <at> yandex.ru, felician.nemeth <at> gmail.com,
 58790 <at> debbugs.gnu.org, stefankangas <at> gmail.com
Subject: Re: bug#58790: Eglot URI parsing bug when using clojure-lsp server
Date: Thu, 10 Nov 2022 17:22:15 -0500

[Message part 1 (text/plain, inline)]

João Távora <joaotavora <at> gmail.com> writes:

> I agree on the two comments about the ChangeLog style entries and the
> spacing.  
>
> But when dealing with eglot.el, which I am the prime maintainer of, 
> I really prefer to see design described in the commit message where the 
> design was introduced. It plays very well with vc-region-history.
>
> So Danny, if you don't mind, please revert that part.  
>
> João

Yall all really taking me for a ride on this lol.

In reviewing the comments over and over I've made a modification to the
second patch involving the warning message. Instead of using an
arbitrary symbol I realized that the function `find-file-name-handler'
works when a nil value for the second argument (operation).

Anyways, here they are again.

[0001-Eglot-Only-handle-URIs-with-the-file-scheme.patch (text/x-patch, attachment)]

[0002-Eglot-warn-when-receiving-a-non-file-scheme-URI.patch (text/x-patch, attachment)]

[Message part 4 (text/plain, inline)]

-- 
Danny Freeman

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.