GNU bug report logs - #58790
Eglot URI parsing bug when using clojure-lsp server

Previous Next

Full log

Message #56 received at 58790 <at> debbugs.gnu.org (full text, mbox):

From: João Távora <joaotavora <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 58790 <at> debbugs.gnu.org, felician.nemeth <at> gmail.com, stefankangas <at> gmail.com,
 Danny Freeman <danny <at> dfreeman.email>, dgutov <at> yandex.ru
Subject: Re: bug#58790: Eglot URI parsing bug when using clojure-lsp server
Date: Thu, 10 Nov 2022 11:00:18 +0000

Eli Zaretskii <eliz <at> gnu.org> writes:

> Ping!  João, any comments on this patch?

Hi Eli, thanks for pinging.  Yes, had a look and _both_ patches look
fine.

The first patch touches a sensitive part.  I hoped at this point to have
Eglot's automated test running in Emacs's repo, but I don't.  So I trust
Danny has given some minimal testing to this, hopefully also with some
other server, for good measure.

The second patch is a little riskier because it has the potential to
cause much warning noise, but I'd wait and see what it does in the wild.
If it does happen I think we have some means of toning down warnings
without making package's warning logic too complex.

So again, both patches should be pushed.  I'm in the middle of a
bisection here, so if you can commit and push the patches, I'd be
thankful.  Else, I will attend to that later.

João

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.