GNU bug report logs - #58784
28.2; project-buffers incorrect under let-bound default-directory

Previous Next

Full log

View this message in rfc822 format

From: Dmitry Gutov <dgutov <at> yandex.ru>
To: Juri Linkov <juri <at> linkov.net>
Cc: Sean Devlin <spd <at> toadstyle.org>, 58784 <at> debbugs.gnu.org
Subject: bug#58784: 28.2; project-buffers incorrect under let-bound default-directory
Date: Wed, 23 Nov 2022 05:48:07 +0200

On 21/11/22 20:24, Juri Linkov wrote:
>> So I just pushed that fix to master.
> Unfortunately, this change broke 'C-x p p g':
> 
>    @@ -1667,9 +1667,10 @@ project-switch-project
>    -    (let ((default-directory dir)
>    -          (project-current-inhibit-prompt t))
>    -      (call-interactively command))))
>    +    (with-temp-buffer
>    +      (let ((default-directory dir)
>    +            (project-current-inhibit-prompt t))
>    +        (call-interactively command)))))
> 
> Because 'C-x p p' switches to a temporary buffer, then
> 'g' calls 'project-find-regexp' and 'project--read-regexp'.
> But (thing-at-point 'symbol t) can't get a symbol at point
> in the empty temporary buffer.

Damn it. :-)

Thanks for noticing. I'll need a little time to think about the options, 
but we'll probably go with the previous proposed fix.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.