GNU bug report logs - #58773
[PATCH] gnu: gst-plugins-bad: Skip elements/camerabin test on some systems.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 58773 in the body.
You can then email your comments to 58773 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Christopher Baines <mail <at> cbaines.net>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: gst-plugins-bad: Skip elements/camerabin test on some
 systems.
Date: Tue, 25 Oct 2022 11:49:38 +0100

It seems to frequently fail on i686-linux and aarch64-linux.

* gnu/packages/gstreamer.scm (gst-plugins-bad)[arguments]: Skip the
elements/camerabin test on i686-linux and aarch64-linux.
---
 gnu/packages/gstreamer.scm | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/gnu/packages/gstreamer.scm b/gnu/packages/gstreamer.scm
index a92588a9e2..c211816bf8 100644
--- a/gnu/packages/gstreamer.scm
+++ b/gnu/packages/gstreamer.scm
@@ -791,6 +791,14 @@ (define-public gst-plugins-bad
                   ;; FIXME: Why is this failing.
                   ((".*elements/dash_mpd\\.c.*") "")
 
+                  #$@(if (member (%current-system)
+                                 '("i686-linux" "aarch64-linux"))
+                         ;; This test is flaky:
+                         ;; https://gitlab.freedesktop.org/gstreamer/gstreamer/-/issues/1244
+                         `((("'elements/camerabin\\.c'\\]\\],")
+                            "'elements/camerabin.c'], true, ],"))
+                         '())
+
                   ;; These tests are flaky and occasionally time out:
                   ;; https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/issues/932
                   ((".*elements/curlhttpsrc\\.c.*") "")
-- 
2.37.3

Message #8 received at 58773 <at> debbugs.gnu.org (full text, mbox):

From: Liliana Marie Prikler <liliana.prikler <at> gmail.com>
To: Christopher Baines <mail <at> cbaines.net>, 58773 <at> debbugs.gnu.org
Subject: Re: [PATCH] gnu: gst-plugins-bad: Skip elements/camerabin test on
 some systems.
Date: Tue, 25 Oct 2022 21:10:15 +0200

Am Dienstag, dem 25.10.2022 um 11:49 +0100 schrieb Christopher Baines:
> It seems to frequently fail on i686-linux and aarch64-linux.
> 
> * gnu/packages/gstreamer.scm (gst-plugins-bad)[arguments]: Skip the
> elements/camerabin test on i686-linux and aarch64-linux.
> ---
>  gnu/packages/gstreamer.scm | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/gnu/packages/gstreamer.scm b/gnu/packages/gstreamer.scm
> index a92588a9e2..c211816bf8 100644
> --- a/gnu/packages/gstreamer.scm
> +++ b/gnu/packages/gstreamer.scm
> @@ -791,6 +791,14 @@ (define-public gst-plugins-bad
>                    ;; FIXME: Why is this failing.
>                    ((".*elements/dash_mpd\\.c.*") "")
>  
> +                  #$@(if (member (%current-system)
> +                                 '("i686-linux" "aarch64-linux"))
> +                         ;; This test is flaky:
> +                         ;;
> https://gitlab.freedesktop.org/gstreamer/gstreamer/-/issues/1244
> +                         `((("'elements/camerabin\\.c'\\]\\],")
> +                            "'elements/camerabin.c'], true, ],"))
> +                         '())
> +
>                    ;; These tests are flaky and occasionally time
> out:
>                    ;;
> https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/issues/932
You might want to use ", see" instead of the colon and wrap the link in
angular brackets, i.e. <https://...>.  Don't forget to end the sentence
with a period.
>                    ((".*elements/curlhttpsrc\\.c.*") "")
Otherwise LGTM

Message #13 received at 58773-done <at> debbugs.gnu.org (full text, mbox):

From: Liliana Marie Prikler <liliana.prikler <at> gmail.com>
To: Christopher Baines <mail <at> cbaines.net>, 58773-done <at> debbugs.gnu.org
Subject: Re: [PATCH] gnu: gst-plugins-bad: Skip elements/camerabin test on
 some systems.
Date: Sat, 26 Nov 2022 13:49:48 +0100

Am Dienstag, dem 25.10.2022 um 21:10 +0200 schrieb Liliana Marie
Prikler:
> Am Dienstag, dem 25.10.2022 um 11:49 +0100 schrieb Christopher
> Baines:
> > It seems to frequently fail on i686-linux and aarch64-linux.
> > 
> > * gnu/packages/gstreamer.scm (gst-plugins-bad)[arguments]: Skip the
> > elements/camerabin test on i686-linux and aarch64-linux.
> > ---
> >  gnu/packages/gstreamer.scm | 8 ++++++++
> >  1 file changed, 8 insertions(+)
> > 
> > diff --git a/gnu/packages/gstreamer.scm
> > b/gnu/packages/gstreamer.scm
> > index a92588a9e2..c211816bf8 100644
> > --- a/gnu/packages/gstreamer.scm
> > +++ b/gnu/packages/gstreamer.scm
> > @@ -791,6 +791,14 @@ (define-public gst-plugins-bad
> >                    ;; FIXME: Why is this failing.
> >                    ((".*elements/dash_mpd\\.c.*") "")
> >  
> > +                  #$@(if (member (%current-system)
> > +                                 '("i686-linux" "aarch64-linux"))
> > +                         ;; This test is flaky:
> > +                         ;;
> > https://gitlab.freedesktop.org/gstreamer/gstreamer/-/issues/1244
> > +                         `((("'elements/camerabin\\.c'\\]\\],")
> > +                            "'elements/camerabin.c'], true, ],"))
> > +                         '())
> > +
> >                    ;; These tests are flaky and occasionally time
> > out:
> >                    ;;
> > https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/issues/932
> You might want to use ", see" instead of the colon and wrap the link
> in angular brackets, i.e. <https://...>.  Don't forget to end the
> sentence with a period.
> 
Turns out angular brackets aren't in vogue in this file.

Pushed with a slightly altered comment.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.