GNU bug report logs - #58757
[PATCH staging] gnu: tbb: Update to 2021.6.0.

Previous Next

Package: guix-patches;

Reported by: Simon South <simon <at> simonsouth.net>

Date: Mon, 24 Oct 2022 12:15:01 UTC

Severity: normal

Tags: patch

Done: Ludovic Courtès <ludo <at> gnu.org>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#58757: closed ([PATCH staging] gnu: tbb: Update to 2021.6.0.)
Date: Fri, 18 Nov 2022 14:15:02 +0000
[Message part 1 (text/plain, inline)]
Your message dated Fri, 18 Nov 2022 15:14:25 +0100
with message-id <874juwbb9a.fsf <at> gnu.org>
and subject line Re: bug#58757: [PATCH staging] gnu: tbb: Update to 2021.6.0.
has caused the debbugs.gnu.org bug report #58757,
regarding [PATCH staging] gnu: tbb: Update to 2021.6.0.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
58757: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=58757
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems
[Message part 2 (message/rfc822, inline)]
From: Simon South <simon <at> simonsouth.net>
To: guix-patches <at> gnu.org
Subject: [PATCH staging] gnu: tbb: Update to 2021.6.0.
Date: Mon, 24 Oct 2022 08:13:57 -0400
This patch updates TBB ("Thread Building Blocks") to version 2021.6.0.

It also removes a now-obsolete patch that was added temporarily to allow
building on AArch64.[0]

I've tested this against the staging branch on x86_64-linux and aarch64-linux
and everything seems okay.

- On x86_64-linux, I've rebuilt without issue all 406 dependent packages
  reported by "guix refresh --list-dependent tbb" except for
  python-dolfin-adjoint, r-mlr3ordinal and shogun, but these do not appear to
  be new failures.[1]

- On aarch64-linux, of tbb's immediate dependents[2] nlopt, octave, openvdb,
  salmon and suitesparse build without issue.  The remainder (or their own
  dependencies) fail but none appear to be new failures.[3]

  As usual, building the full set of dependents would require packages (like
  the Haskell compiler) that either are not yet available for AArch64 or are
  not feasible to build on the hobbyist boards I have available.

--
Simon South
simon <at> simonsouth.net

[0] In commit 2d4c22b0aa49:
    https://git.savannah.gnu.org/cgit/guix.git/commit/?id=2d4c22b0aa497f8a5e57a453b1dbf3ea98747c5f

[1] https://ci.guix.gnu.org/search?query=python-dolfin-adjoint+spec%3Astaging+system%3Ax86_64-linux
    https://ci.guix.gnu.org/search?query=r-mlr3ordinal+spec%3Astaging+system%3Ax86_64-linux
    https://ci.guix.gnu.org/search?query=shogun+spec%3Astaging+system%3Ax86_64-linux

[2] blender <at> 3.0.1, embree <at> 3.12.1, hyperledger-iroha <at> 1.1.1,
    insight-toolkit <at> 4.12.2, insight-toolkit <at> 4.13.2, insight-toolkit <at> 5.0.0,
    openvdb <at> 8.2.0, prusa-slicer <at> 2.4.2, salmon <at> 1.9.0 and suitesparse <at> 5.12.0.

[3] https://ci.guix.gnu.org/search?query=embree+spec%3Astaging+system%3Aaarch64-linux
    https://ci.guix.gnu.org/search?query=opencolorio+spec%3Astaging+system%3Aaarch64-linux
    https://ci.guix.gnu.org/search?query=prusa-slicer+spec%3Astaging+system%3Aaarch64-linux
    https://ci.guix.gnu.org/search?query=vxl+spec%3Astaging+system%3Aaarch64-linux


Simon South (1):
  gnu: tbb: Update to 2021.6.0.

 gnu/local.mk                                  |  1 -
 .../patches/tbb-fix-test-on-aarch64.patch     | 35 -------------------
 gnu/packages/patches/tbb-other-arches.patch   |  8 ++---
 gnu/packages/tbb.scm                          | 10 ++----
 4 files changed, 7 insertions(+), 47 deletions(-)
 delete mode 100644 gnu/packages/patches/tbb-fix-test-on-aarch64.patch


base-commit: 408a4ed071c9c52de207d799a698781d49fa727d
--
2.38.0



[Message part 3 (message/rfc822, inline)]
From: Ludovic Courtès <ludo <at> gnu.org>
To: Simon South <simon <at> simonsouth.net>
Cc: 58757-done <at> debbugs.gnu.org
Subject: Re: bug#58757: [PATCH staging] gnu: tbb: Update to 2021.6.0.
Date: Fri, 18 Nov 2022 15:14:25 +0100
Hi Simon,

Simon South <simon <at> simonsouth.net> skribis:

> This patch updates TBB ("Thread Building Blocks") to version 2021.6.0.
>
> It also removes a now-obsolete patch that was added temporarily to allow
> building on AArch64.[0]
>
> I've tested this against the staging branch on x86_64-linux and aarch64-linux
> and everything seems okay.
>
> - On x86_64-linux, I've rebuilt without issue all 406 dependent packages
>   reported by "guix refresh --list-dependent tbb" except for
>   python-dolfin-adjoint, r-mlr3ordinal and shogun, but these do not appear to
>   be new failures.[1]
>
> - On aarch64-linux, of tbb's immediate dependents[2] nlopt, octave, openvdb,
>   salmon and suitesparse build without issue.  The remainder (or their own
>   dependencies) fail but none appear to be new failures.[3]
>
>   As usual, building the full set of dependents would require packages (like
>   the Haskell compiler) that either are not yet available for AArch64 or are
>   not feasible to build on the hobbyist boards I have available.

Thanks for testing it thoroughly.

I figured applying it on current ‘master’ (time has passed…) wasn’t
unreasonable given the number of dependents.  Unfortunately
<https://qa.guix.gnu.org/issue/58757> didn’t pick it up but I confirmed
that it still builds and passes tests on x86_64-linux.

>   gnu: tbb: Update to 2021.6.0.

Applied, thanks!

Ludo’.


This bug report was last modified 2 years and 188 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.