GNU bug report logs - #58755
29.0.50; Font locking not enabling for ts-mode

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 58755 in the body.
You can then email your comments to 58755 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Theodor Thornhill <theo <at> thornhill.no>
To: bug-gnu-emacs <at> gnu.org
Subject: 29.0.50; Font locking not enabling for ts-mode
Date: Mon, 24 Oct 2022 08:43:29 +0200

[Message part 1 (text/plain, inline)]

Hi Yuan!

It seems we cannot really enable font-lock without setting the
font-lock-defaults to some non-nil value.

I'm not really sure why the 'treesit-font-lock-enable' isn't sufficient,
but here's a patch that at least makes ts-mode usable again :)

Thanks,
Theo

[0001-Add-in-check-for-font-lock-defaults.patch (text/x-diff, attachment)]

Message #8 received at 58755 <at> debbugs.gnu.org (full text, mbox):

From: Yuan Fu <casouri <at> gmail.com>
To: Theodor Thornhill <theo <at> thornhill.no>
Cc: 58755 <at> debbugs.gnu.org
Subject: Re: bug#58755: 29.0.50; Font locking not enabling for ts-mode
Date: Mon, 24 Oct 2022 00:15:58 -0700

> On Oct 23, 2022, at 11:43 PM, Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors <bug-gnu-emacs <at> gnu.org> wrote:
> 
> Hi Yuan!
> 
> It seems we cannot really enable font-lock without setting the
> font-lock-defaults to some non-nil value.
> 
> I'm not really sure why the 'treesit-font-lock-enable' isn't sufficient,
> but here's a patch that at least makes ts-mode usable again :)
> 
> Thanks,
> Theo

Hey Theo, sorry for the trouble… Yeah font-lock-mode looks at font-lock-default’s value when turning on and won’t do anything if it’s value is nil. I thought we are going to install a new scheme soon so I didn’t change the code. I’ll fix ts-mode and push.

Yuan

Message #11 received at 58755 <at> debbugs.gnu.org (full text, mbox):

From: Theodor Thornhill <theo <at> thornhill.no>
To: Yuan Fu <casouri <at> gmail.com>
Cc: 58755 <at> debbugs.gnu.org
Subject: Re: bug#58755: 29.0.50; Font locking not enabling for ts-mode
Date: Mon, 24 Oct 2022 09:29:28 +0200

Yuan Fu <casouri <at> gmail.com> writes:

>> On Oct 23, 2022, at 11:43 PM, Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors <bug-gnu-emacs <at> gnu.org> wrote:
>> 
>> Hi Yuan!
>> 
>> It seems we cannot really enable font-lock without setting the
>> font-lock-defaults to some non-nil value.
>> 
>> I'm not really sure why the 'treesit-font-lock-enable' isn't sufficient,
>> but here's a patch that at least makes ts-mode usable again :)
>> 
>> Thanks,
>> Theo
>
> Hey Theo, sorry for the trouble… Yeah font-lock-mode looks at font-lock-default’s value when turning on and won’t do anything if it’s value is nil. I thought we are going to install a new scheme soon so I didn’t change the code. I’ll fix ts-mode and push.
>

No worries.  Did we decide upon something there?

Theo

Message #14 received at 58755 <at> debbugs.gnu.org (full text, mbox):

From: Yuan Fu <casouri <at> gmail.com>
To: Theodor Thornhill <theo <at> thornhill.no>
Cc: 58755 <at> debbugs.gnu.org
Subject: Re: bug#58755: 29.0.50; Font locking not enabling for ts-mode
Date: Mon, 24 Oct 2022 13:16:43 -0700

> On Oct 24, 2022, at 12:29 AM, Theodor Thornhill <theo <at> thornhill.no> wrote:
> 
> Yuan Fu <casouri <at> gmail.com> writes:
> 
>>> On Oct 23, 2022, at 11:43 PM, Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors <bug-gnu-emacs <at> gnu.org> wrote:
>>> 
>>> Hi Yuan!
>>> 
>>> It seems we cannot really enable font-lock without setting the
>>> font-lock-defaults to some non-nil value.
>>> 
>>> I'm not really sure why the 'treesit-font-lock-enable' isn't sufficient,
>>> but here's a patch that at least makes ts-mode usable again :)
>>> 
>>> Thanks,
>>> Theo
>> 
>> Hey Theo, sorry for the trouble… Yeah font-lock-mode looks at font-lock-default’s value when turning on and won’t do anything if it’s value is nil. I thought we are going to install a new scheme soon so I didn’t change the code. I’ll fix ts-mode and push.
>> 
> 
> No worries.  Did we decide upon something there?
> 
> Theo

No, not yet. I still think a central variable has more merits and less problems than minor modes as they are now. We’ll need discussion and more good ideas :-)

Yuan

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.