From unknown Sun Jun 22 08:02:25 2025 X-Loop: help-debbugs@gnu.org Subject: bug#58745: 29.0.50; eglot managed-major-mode must be a list Resent-From: Stephen Leake Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 23 Oct 2022 17:47:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 58745 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 58745@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.16665472176921 (code B ref -1); Sun, 23 Oct 2022 17:47:02 +0000 Received: (at submit) by debbugs.gnu.org; 23 Oct 2022 17:46:57 +0000 Received: from localhost ([127.0.0.1]:46457 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1omf3o-0001nY-VO for submit@debbugs.gnu.org; Sun, 23 Oct 2022 13:46:57 -0400 Received: from lists.gnu.org ([209.51.188.17]:45778) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1omf3l-0001nO-Ry for submit@debbugs.gnu.org; Sun, 23 Oct 2022 13:46:55 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1omf3f-0005hj-85 for bug-gnu-emacs@gnu.org; Sun, 23 Oct 2022 13:46:53 -0400 Received: from gproxy5-pub.mail.unifiedlayer.com ([67.222.38.55] helo=progateway7-pub.mail.pro1.eigbox.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1omf3Z-0005t9-Mf for bug-gnu-emacs@gnu.org; Sun, 23 Oct 2022 13:46:47 -0400 Received: from cmgw14.mail.unifiedlayer.com (unknown [10.0.90.129]) by progateway7.mail.pro1.eigbox.com (Postfix) with ESMTP id 7BD6B10044912 for ; Sun, 23 Oct 2022 17:46:09 +0000 (UTC) Received: from host2007.hostmonster.com ([67.20.76.71]) by cmsmtp with ESMTP id mf33oUsPOoMaxmf33oZ7s0; Sun, 23 Oct 2022 17:46:09 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=X4CXlEfe c=1 sm=1 tr=0 ts=63557de1 a=dWLzHQi6WpdymmZIwiVdBw==:117 a=Fln8i1WyhtedwaIJAdHvmw==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=Qawa6l4ZSaYA:10:nop_rcvd_month_year a=vvvmwbhNdt4A:10:endurance_base64_authed_username_1 a=2LqzHnf1UjNOzmVpYhcA:9 a=7Zwj6sZBwVKJAoWSPKxL6X1jA+E=:19 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=stephe-leake.org; s=default; h=Content-Type:MIME-Version:Message-ID:Date: Subject:To:From:Sender:Reply-To:Cc:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=hPGjFV7E/E63yp2yrbBn+6CIwHMdhLq5oQr46dtDeXQ=; b=AcyTAT8sSziZsEBU4DB9+pqN+a H5K9wT0Ie4mV0B8ir0qZqs+lyPHsczkFheqf9a4dMcFRD1wpjuHZnMGmDZHoHR02ibeYJNhPjKF6O Qu/xgVc43DF+MqF4Pi9OSm8CFNBXMNbbvA698/u+DJPQJpa30OqGi03VJZIz34OEYImswNQ1aobC3 cRQh0PeMruXvBZ4cJ6E8UamXQHOaZtGGWPLNTtlZvhEKgf4BWUih8+Mktv5BV+dNnCa1nnm3t2hp9 17NZ3c8jBMlOhl5vziqe9TzOA94M6emKybYH5+AMQaqJFBL0rLAl/BmeN+eNMPmXgp60qigDGGo5v XvmG/Glw==; Received: from 135-180-197-170.fiber.dynamic.sonic.net ([135.180.197.170]:50772 helo=DESKTOP-G20DCG1) by host2007.hostmonster.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1omf33-003ZzE-21 for bug-gnu-emacs@gnu.org; Sun, 23 Oct 2022 11:46:09 -0600 From: Stephen Leake Date: Sun, 23 Oct 2022 10:46:08 -0700 Message-ID: <86pmeijuvz.fsf@stephe-leake.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - host2007.hostmonster.com X-AntiAbuse: Original Domain - gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - stephe-leake.org X-BWhitelist: no X-Source-IP: 135.180.197.170 X-Source-L: No X-Exim-ID: 1omf33-003ZzE-21 X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 135-180-197-170.fiber.dynamic.sonic.net (DESKTOP-G20DCG1) [135.180.197.170]:50772 X-Source-Auth: stephen_leake@stephe-leake.org X-Email-Count: 1 X-Source-Cap: c3RlcGhlbGU7c3RlcGhlbGU7aG9zdDIwMDcuaG9zdG1vbnN0ZXIuY29t X-Local-Domain: yes Received-SPF: pass client-ip=67.222.38.55; envelope-from=stephen_leake@stephe-leake.org; helo=progateway7-pub.mail.pro1.eigbox.com X-Spam_score_int: 16 X-Spam_score: 1.6 X-Spam_bar: + X-Spam_report: (1.6 / 5.0 requ) BAYES_00=-1.9, DKIM_INVALID=0.1, DKIM_SIGNED=0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, RCVD_IN_SBL_CSS=3.335, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-Spam-Score: 1.9 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: I'm calling `eglot' from lisp. The doc string says the first argument `managed-major-mode' is an atom, not a list. But it is passed to eglot--connect as the first argument, which is expected to be a l [...] Content analysis details: (1.9 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 3.6 RCVD_IN_SBL_CSS RBL: Received via a relay in Spamhaus SBL-CSS [135.180.197.170 listed in zen.spamhaus.org] -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at https://www.dnswl.org/, medium trust [209.51.188.17 listed in list.dnswl.org] -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [209.51.188.17 listed in wl.mailspike.net] -0.0 SPF_HELO_PASS SPF: HELO matches SPF record 0.7 SPF_NEUTRAL SPF: sender does not match SPF record (neutral) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.9 (/) I'm calling `eglot' from lisp. The doc string says the first argument `managed-major-mode' is an atom, not a list. But it is passed to eglot--connect as the first argument, which is expected to be a list of major modes. When called interactively, `managed-major-mode' is set by (eglot--guess-contact t), which returns a list. So when not interactive, `eglot' must convert `managed-major-mode' into a list: ------------------- diff --git a/lisp/progmodes/eglot.el b/lisp/progmodes/eglot.el index 71001ba680..dee88db022 100644 --- a/lisp/progmodes/eglot.el +++ b/lisp/progmodes/eglot.el @@ -1078,6 +1078,8 @@ eglot INTERACTIVE is t if called interactively." (interactive (append (eglot--guess-contact t) '(t))) + (unless (listp managed-major-mode) + (setq managed-major-mode (list managed-major-mode))) (let* ((current-server (eglot-current-server)) (live-p (and current-server (jsonrpc-running-p current-server)))) (if (and live-p ------------------ -- -- Stephe In GNU Emacs 29.0.50 (build 1, x86_64-w64-mingw32) of 2022-10-22 built on DESKTOP-G20DCG1 Repository revision: 9db7b11cf7fa5d6cf624a467f966a14b347e4429 Repository branch: master Windowing system distributor 'Microsoft Corp.', version 10.0.19044 System Description: Microsoft Windows 10 Pro (v10.0.2009.19044.2130) Configured using: 'configure PKG_CONFIG_PATH=/mingw64/lib/pkgconfig:/mingw64/share/pkgconfig' Configured features: ACL DBUS GIF GMP GNUTLS HARFBUZZ JPEG JSON LCMS2 LIBXML2 MODULES NOTIFY W32NOTIFY PDUMPER PNG RSVG SOUND SQLITE3 THREADS TIFF TOOLKIT_SCROLL_BARS WEBP XPM ZLIB Important settings: value of $LC_CTYPE: en_US.UTF-8 value of $LANG: ENU locale-coding-system: cp1252 Major mode: ELisp/l Minor modes in effect: bug-reference-prog-mode: t other-frame-window-mode: t display-time-mode: t delete-selection-mode: t outline-minor-mode: t icomplete-mode: t tooltip-mode: t global-eldoc-mode: t eldoc-mode: t show-paren-mode: t electric-indent-mode: t mouse-wheel-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t line-number-mode: t transient-mark-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t Load-path shadows: c:/Projects/org.emacs.ada-mode/prj hides c:/Projects/org.emacs.gpr-query/prj c:/Projects/org.emacs.ada-mode/prj-eglot hides c:/Projects/org.emacs.gpr-query/prj-eglot c:/Projects/org.emacs.ada-mode/autoloads hides c:/Projects/org.emacs.gpr-query/autoloads c:/Projects/org.emacs.ada-mode/autoloads hides c:/Projects/org.emacs.gnat-compiler/autoloads c:/Projects/org.emacs.ada-mode/prj-eglot hides c:/Projects/org.emacs.wisi/prj-eglot c:/Projects/org.emacs.ada-mode/autoloads hides c:/Projects/org.emacs.wisi/autoloads c:/Projects/org.emacs.ada-mode/prj hides c:/Projects/org.wisitoken.grammar_mode/prj c:/Projects/org.emacs.ada-mode/autoloads hides c:/Projects/org.wisitoken.grammar_mode/autoloads c:/Projects/org.emacs.ada-mode/ada-ref-man hides c:/home/stephe/.emacs.d/elpa/ada-ref-man-2020.1.0.20201129.190419/ada-ref-man c:/Projects/mmm-mode/mmm-vars hides c:/home/stephe/.emacs.d/elpa/mmm-mode-0.5.8.0.20221018.153958/mmm-vars c:/Projects/mmm-mode/mmm-utils hides c:/home/stephe/.emacs.d/elpa/mmm-mode-0.5.8.0.20221018.153958/mmm-utils c:/Projects/mmm-mode/mmm-univ hides c:/home/stephe/.emacs.d/elpa/mmm-mode-0.5.8.0.20221018.153958/mmm-univ c:/Projects/mmm-mode/mmm-sample hides c:/home/stephe/.emacs.d/elpa/mmm-mode-0.5.8.0.20221018.153958/mmm-sample c:/Projects/mmm-mode/mmm-rpm hides c:/home/stephe/.emacs.d/elpa/mmm-mode-0.5.8.0.20221018.153958/mmm-rpm c:/Projects/mmm-mode/mmm-region hides c:/home/stephe/.emacs.d/elpa/mmm-mode-0.5.8.0.20221018.153958/mmm-region c:/Projects/mmm-mode/mmm-noweb hides c:/home/stephe/.emacs.d/elpa/mmm-mode-0.5.8.0.20221018.153958/mmm-noweb c:/Projects/mmm-mode/mmm-myghty hides c:/home/stephe/.emacs.d/elpa/mmm-mode-0.5.8.0.20221018.153958/mmm-myghty c:/Projects/mmm-mode/mmm-mode hides c:/home/stephe/.emacs.d/elpa/mmm-mode-0.5.8.0.20221018.153958/mmm-mode c:/Projects/mmm-mode/mmm-mason hides c:/home/stephe/.emacs.d/elpa/mmm-mode-0.5.8.0.20221018.153958/mmm-mason c:/Projects/mmm-mode/mmm-erb hides c:/home/stephe/.emacs.d/elpa/mmm-mode-0.5.8.0.20221018.153958/mmm-erb c:/Projects/mmm-mode/mmm-defaults hides c:/home/stephe/.emacs.d/elpa/mmm-mode-0.5.8.0.20221018.153958/mmm-defaults c:/Projects/mmm-mode/mmm-cweb hides c:/home/stephe/.emacs.d/elpa/mmm-mode-0.5.8.0.20221018.153958/mmm-cweb c:/Projects/mmm-mode/mmm-compat hides c:/home/stephe/.emacs.d/elpa/mmm-mode-0.5.8.0.20221018.153958/mmm-compat c:/Projects/mmm-mode/mmm-cmds hides c:/home/stephe/.emacs.d/elpa/mmm-mode-0.5.8.0.20221018.153958/mmm-cmds c:/Projects/mmm-mode/mmm-class hides c:/home/stephe/.emacs.d/elpa/mmm-mode-0.5.8.0.20221018.153958/mmm-class c:/Projects/mmm-mode/mmm-auto hides c:/home/stephe/.emacs.d/elpa/mmm-mode-0.5.8.0.20221018.153958/mmm-auto Features: (shadow sort mail-extr emacsbug pulse color vc bug-reference help-fns radix-tree cl-print misearch multi-isearch copyright cus-start edebug ada-eglot ada-mode ada-imenu align ada-skel wisi-skel skeleton ada_annex_p-process wisi-process-parse ada-indent-user-options ada-core gnat-compiler vc-git diff-mode easy-mmode vc-dispatcher org-element avl-tree generator ol-eww eww xdg url-queue mm-url ol-rmail ol-mhe ol-irc ol-info ol-gnus nnselect gnus-art mm-uu mml2015 mm-view mml-smime smime gnutls dig gnus-sum shr pixel-fill kinsoku url-file svg dom gnus-group gnus-undo gnus-start gnus-dbus dbus xml gnus-cloud nnimap nnmail mail-source utf7 nnoo parse-time gnus-spec gnus-int gnus-range message sendmail yank-media puny rfc822 mml mml-sec epa derived mm-decode mm-bodies mm-encode mail-parse rfc2231 rfc2047 rfc2045 ietf-drums mailabbrev gmm-utils mailheader gnus-win gnus nnheader gnus-util mail-utils range mm-util mail-prsvr wid-edit ol-docview doc-view jka-compr image-mode exif ol-bibtex ol-bbdb ol-w3m ol-doi org-link-doi org-mode-keys org ob ob-tangle ob-ref ob-lob ob-table ob-exp org-macro org-footnote org-src ob-comint org-pcomplete pcomplete org-list org-faces org-entities org-version ob-emacs-lisp ob-core ob-eval org-table oc-basic bibtex iso8601 time-date ol rx org-keys oc org-compat advice org-macs org-loaddefs format-spec cal-menu calendar cal-loaddefs wisi-prj wisi wisi-fringe wisi-parse-common semantic/lex semantic/fw mode-local find-file eglot array filenotify jsonrpc ert pp debug backtrace find-func flymake-proc flymake warnings pcase imenu mmm-auto mmm-vars mmm-utils mmm-compat dvc-autoloads dvc-unified ffap thingatpt dvc-revlist dvc-fileinfo dvc-core dvc-buffers dvc-ui dvc-register dvc-utils ewoc dvc-emacs dvc-defs autoloads other-frame-window grep time delsel cus-load stephe-theme noutline outline icons path-iterator cl-extra help-mode whitespace dired-x dired-aux dired dired-loaddefs compile text-property-search comint ansi-osc ansi-color uniquify-files icomplete xref project ring ada-ref-man-autoloads bbdb-autoloads info debbugs-autoloads gnu-elpa-keyring-update-autoloads epg rfc6068 epg-config gnu-elpa-keyring-update helm-autoloads helm-core-autoloads async-autoloads mmm-mode-autoloads other-frame-window-autoloads popup-autoloads uniquify-files-autoloads package browse-url url url-proxy url-privacy url-expand url-methods url-history url-cookie generate-lisp-file url-domsuf url-util mailcap url-handlers url-parse auth-source cl-seq eieio eieio-core cl-macs password-cache json subr-x map byte-opt gv bytecomp byte-compile cconv url-vars cl-loaddefs cl-lib rmc iso-transl tooltip eldoc paren electric uniquify ediff-hook vc-hooks lisp-float-type elisp-mode mwheel dos-w32 ls-lisp disp-table term/w32-win w32-win w32-vars term/common-win tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch easymenu timer select scroll-bar mouse jit-lock font-lock syntax font-core term/tty-colors frame minibuffer nadvice seq simple cl-generic indonesian philippine cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite emoji-zwj charscript charprop case-table epa-hook jka-cmpr-hook help abbrev obarray oclosure cl-preloaded button loaddefs theme-loaddefs faces cus-face macroexp files window text-properties overlay sha1 md5 base64 format env code-pages mule custom widget keymap hashtable-print-readable backquote threads w32notify dbusbind w32 lcms2 multi-tty make-network-process emacs) Memory information: ((conses 16 283572 42382) (symbols 48 29015 0) (strings 32 97057 4158) (string-bytes 1 2980479) (vectors 16 51760) (vector-slots 8 619438 29596) (floats 8 411 501) (intervals 56 3878 22) (buffers 1000 28)) From unknown Sun Jun 22 08:02:25 2025 X-Loop: help-debbugs@gnu.org Subject: bug#58745: 29.0.50; eglot managed-major-mode must be a list Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 27 Oct 2022 16:20:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58745 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Stephen Leake , =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Cc: 58745@debbugs.gnu.org Received: via spool by 58745-submit@debbugs.gnu.org id=B58745.16668875636351 (code B ref 58745); Thu, 27 Oct 2022 16:20:01 +0000 Received: (at 58745) by debbugs.gnu.org; 27 Oct 2022 16:19:23 +0000 Received: from localhost ([127.0.0.1]:59094 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oo5bH-0001eM-HQ for submit@debbugs.gnu.org; Thu, 27 Oct 2022 12:19:23 -0400 Received: from eggs.gnu.org ([209.51.188.92]:44822) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oo5bF-0001e9-I2 for 58745@debbugs.gnu.org; Thu, 27 Oct 2022 12:19:22 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oo5b9-0006VX-FJ; Thu, 27 Oct 2022 12:19:15 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=p0eEa4EG40rZ1gHVQoCegsqVafkRmcxy3aAkfidZUnQ=; b=Snqk1dDbcJiXMES7GBU+ OyrAzFKEP9o0uj1eKI92YnpoB6pqbEmO+jfgHhwomIG+xxD4KSOizZw5V5HvO5eF++u6a58aSsvUR E+0eSqMxq+01MeVIccnqQFwLPF46lHlj3XVi+0gpFRNK0LT54cfLwrkCerCAxW5cmqoxNPlhaQBO6 gQN7urP28V9jlox3rxDNvCR++A/1WM/6gdRORUizUtWLw36ci0GCclApbL30abqbugReUhk+2vciF kPhch4DRuruOoQ0PAy4rXtfNkR1BD+JdypZMGkcaR3MC8+PxzFBiC4qIv1x4uZdFQDdkkO/wWHUso oDaRI2H3OVVHFA==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oo5b8-0007LA-Pb; Thu, 27 Oct 2022 12:19:15 -0400 Date: Thu, 27 Oct 2022 19:19:09 +0300 Message-Id: <83mt9hkznm.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: <86pmeijuvz.fsf@stephe-leake.org> (message from Stephen Leake on Sun, 23 Oct 2022 10:46:08 -0700) References: <86pmeijuvz.fsf@stephe-leake.org> MIME-version: 1.0 Content-type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Stephen Leake > Date: Sun, 23 Oct 2022 10:46:08 -0700 > > I'm calling `eglot' from lisp. The doc string says the first argument > `managed-major-mode' is an atom, not a list. But it is passed to > eglot--connect as the first argument, which is expected to be a list of > major modes. When called interactively, `managed-major-mode' is set by > (eglot--guess-contact t), which returns a list. > > So when not interactive, `eglot' must convert `managed-major-mode' into > a list: > > ------------------- > diff --git a/lisp/progmodes/eglot.el b/lisp/progmodes/eglot.el > index 71001ba680..dee88db022 100644 > --- a/lisp/progmodes/eglot.el > +++ b/lisp/progmodes/eglot.el > @@ -1078,6 +1078,8 @@ eglot > > INTERACTIVE is t if called interactively." > (interactive (append (eglot--guess-contact t) '(t))) > + (unless (listp managed-major-mode) > + (setq managed-major-mode (list managed-major-mode))) > (let* ((current-server (eglot-current-server)) > (live-p (and current-server (jsonrpc-running-p current-server)))) > (if (and live-p > ------------------ Jo�o, any comments? From unknown Sun Jun 22 08:02:25 2025 X-Loop: help-debbugs@gnu.org Subject: bug#58745: 29.0.50; eglot managed-major-mode must be a list Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 27 Oct 2022 17:27:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58745 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: 58745@debbugs.gnu.org, Stephen Leake Received: via spool by 58745-submit@debbugs.gnu.org id=B58745.166689158313087 (code B ref 58745); Thu, 27 Oct 2022 17:27:02 +0000 Received: (at 58745) by debbugs.gnu.org; 27 Oct 2022 17:26:23 +0000 Received: from localhost ([127.0.0.1]:59203 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oo6e6-0003P0-Ov for submit@debbugs.gnu.org; Thu, 27 Oct 2022 13:26:23 -0400 Received: from mail-oi1-f174.google.com ([209.85.167.174]:37486) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oo6e5-0003Om-0e for 58745@debbugs.gnu.org; Thu, 27 Oct 2022 13:26:21 -0400 Received: by mail-oi1-f174.google.com with SMTP id i7so3032097oif.4 for <58745@debbugs.gnu.org>; Thu, 27 Oct 2022 10:26:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=Qyd3ZUvpBjcVtVRTRNk4YN5JQTZAxZrtY8BXQEdWp+Y=; b=qvP1c8fsxuIwUR3/hqg4S/UCjmg9qhZVbvM6PbX5UF5khzAVb/GrvgPgbS272FfvzS YTEan6UQlZmbLyFOSIAQ06/cbGBAyJ0EPYQjiLOTCB0DoBd2dQDtdOYXYBTTOe2+lwtI hmynuWcCHr7Vrz8+oq+aO6VqaI56GvZxh46OqAkuBX5GnqSstiuQqsTJpx2hc8pp0o5g VKEl2/d19cd1eBv9u9ZXTvil6MCL3b47iPsGxQWLDnqHLN0et/SXVvRGlFlyHuEelhU2 45OXOar6mbV//HZVBHa2nzI7RtQMJTYZkBugdMJOzYtxy9gBuHXfxR82LkV+qenEPqZA J0NQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Qyd3ZUvpBjcVtVRTRNk4YN5JQTZAxZrtY8BXQEdWp+Y=; b=2v3ET244OLMcV+I8+LGZDzq+bbQZdJljF/Yylc2/qBEjFq3vydRg6xqofttk7pqnt+ OFxQvXP2GPhbuehyAICIDZd958wAhmAyUZSqza03VAvTTYUAIFzqWU2wHfgPpTlK8p97 LB3Wpr4S4YuIaJX/RvDHqfSKcMQE8rNnRjfGVPMmRTt08gele1jlXxEHOuE41t2yc7cF ZqOh5cVkQUgLdcPf32tBiBIUKuZBb/Gt+M0jo3dUJtSWF9gIj1J71JGKO2/QuTqdPKEH mtW//VITtbjSekq7vW3xFv11mCVU8YiiyD3IBHtJoNq9eUJqnytBO68aNZOjKYdIlV+T jh4A== X-Gm-Message-State: ACrzQf3nx7Z4TUXViGItWBYpaVFObqBZy40TaRMcpH+EnBUAd2580XlT A+afOgOlgRxIlnXjdlb1UlPBC51smN3ziXyps+U= X-Google-Smtp-Source: AMsMyM6nrS04DqB5wEJCu1SIP3SZqkpUyZb0xqS3xAqIpWRzTu3ZkM9Zi3WWvplY/YpTKlZyFyGEdKY1f/vdVXvxjvU= X-Received: by 2002:a05:6808:1a1f:b0:354:b33b:8b0d with SMTP id bk31-20020a0568081a1f00b00354b33b8b0dmr5243138oib.171.1666891575413; Thu, 27 Oct 2022 10:26:15 -0700 (PDT) MIME-Version: 1.0 References: <86pmeijuvz.fsf@stephe-leake.org> <83mt9hkznm.fsf@gnu.org> In-Reply-To: <83mt9hkznm.fsf@gnu.org> From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Date: Thu, 27 Oct 2022 18:27:14 +0100 Message-ID: Content-Type: multipart/alternative; boundary="0000000000003b501005ec077080" X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --0000000000003b501005ec077080 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Yes, this has been discussed on emacs-devel and an equivalent patch pushed. So the bug can be closed. The function eglot doesn't have any non-interactive use that I can envision= . Its INTERACTIVE argument is a historical remnant from a time where the function was called eglot-start-process. Nevertheless, it makes sense that it converts the argument into a list. Stephen, I would advise against using eglot from Lisp, in principle but I haven't seen your use case Jo=C3=A3o On Thu, Oct 27, 2022 at 5:19 PM Eli Zaretskii wrote: > > From: Stephen Leake > > Date: Sun, 23 Oct 2022 10:46:08 -0700 > > > > I'm calling `eglot' from lisp. The doc string says the first argument > > `managed-major-mode' is an atom, not a list. But it is passed to > > eglot--connect as the first argument, which is expected to be a list of > > major modes. When called interactively, `managed-major-mode' is set by > > (eglot--guess-contact t), which returns a list. > > > > So when not interactive, `eglot' must convert `managed-major-mode' into > > a list: > > > > ------------------- > > diff --git a/lisp/progmodes/eglot.el b/lisp/progmodes/eglot.el > > index 71001ba680..dee88db022 100644 > > --- a/lisp/progmodes/eglot.el > > +++ b/lisp/progmodes/eglot.el > > @@ -1078,6 +1078,8 @@ eglot > > > > INTERACTIVE is t if called interactively." > > (interactive (append (eglot--guess-contact t) '(t))) > > + (unless (listp managed-major-mode) > > + (setq managed-major-mode (list managed-major-mode))) > > (let* ((current-server (eglot-current-server)) > > (live-p (and current-server (jsonrpc-running-p > current-server)))) > > (if (and live-p > > ------------------ > > Jo=C3=A3o, any comments? > --=20 Jo=C3=A3o T=C3=A1vora --0000000000003b501005ec077080 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Yes, this has been discussed on emacs-devel and an eq= uivalent patch
pushed.

So the bug can be= closed.

The function eglot doesn't have a= ny non-interactive use that I can envision.
Its INTERACTIVE argum= ent is a historical remnant from a time where
the function w= as called eglot-start-process.=C2=A0 Nevertheless, it makes sense
that it converts the argument into a list.

Stephe= n, I would advise against using eglot from Lisp, in principle
but I haven't seen your use case

Jo=C3=A3o


On Thu, Oct 27, 2022 at 5:19 PM Eli Zaretskii <eliz@gnu.org> wrote:
> From: Stephen Leake <stephen_lea= ke@stephe-leake.org>
> Date: Sun, 23 Oct 2022 10:46:08 -0700
>
> I'm calling `eglot' from lisp. The doc string says the first a= rgument
> `managed-major-mode' is an atom, not a list. But it is passed to > eglot--connect as the first argument, which is expected to be a list o= f
> major modes. When called interactively, `managed-major-mode' is se= t by
> (eglot--guess-contact t), which returns a list.
>
> So when not interactive, `eglot' must convert `managed-major-mode&= #39; into
> a list:
>
> -------------------
> diff --git a/lisp/progmodes/eglot.el b/lisp/progmodes/eglot.el
> index 71001ba680..dee88db022 100644
> --- a/lisp/progmodes/eglot.el
> +++ b/lisp/progmodes/eglot.el
> @@ -1078,6 +1078,8 @@ eglot
>=C2=A0
>=C2=A0 INTERACTIVE is t if called interactively."
>=C2=A0 =C2=A0 (interactive (append (eglot--guess-contact t) '(t)))<= br> > +=C2=A0 (unless (listp managed-major-mode)
> +=C2=A0 =C2=A0 (setq managed-major-mode (list managed-major-mode))) >=C2=A0 =C2=A0 (let* ((current-server (eglot-current-server))
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(live-p (and current-server (j= sonrpc-running-p current-server))))
>=C2=A0 =C2=A0 =C2=A0 (if (and live-p
> ------------------

Jo=C3=A3o, any comments?


--
Jo=C3=A3o T=C3=A1vora
--0000000000003b501005ec077080-- From unknown Sun Jun 22 08:02:25 2025 X-Loop: help-debbugs@gnu.org Subject: bug#58745: 29.0.50; eglot managed-major-mode must be a list Resent-From: Robert Pluim Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 27 Oct 2022 17:35:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58745 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: 58745@debbugs.gnu.org, Stephen Leake , =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Received: via spool by 58745-submit@debbugs.gnu.org id=B58745.166689209713979 (code B ref 58745); Thu, 27 Oct 2022 17:35:03 +0000 Received: (at 58745) by debbugs.gnu.org; 27 Oct 2022 17:34:57 +0000 Received: from localhost ([127.0.0.1]:59224 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oo6mP-0003dO-5x for submit@debbugs.gnu.org; Thu, 27 Oct 2022 13:34:57 -0400 Received: from mail-wm1-f41.google.com ([209.85.128.41]:39812) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oo6mM-0003d8-Ks for 58745@debbugs.gnu.org; Thu, 27 Oct 2022 13:34:55 -0400 Received: by mail-wm1-f41.google.com with SMTP id i5-20020a1c3b05000000b003cf47dcd316so4685538wma.4 for <58745@debbugs.gnu.org>; Thu, 27 Oct 2022 10:34:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=Z71lMkKGKkRbgOwlHx6kojoTQy/XJ5qUrx1UFUxwF8Y=; b=ZiP4o+ewUivKUaxMwAK/xmcov1afx15nxoR052d482U2/z6PrA+l4Q+Vfj9jVEoSe+ tTDo9vX7jBJcd7OcPf/Q5PGDHD63MlOqsawiGJDpRWZbT0sxjivqOiwNuYvbRPZWb94y QMjSTL9R5DdKZHAa9uORInRGnVfsbFeaMP7Uy/4/iRxRU9PW9bnyRw2wUcfj5pahZJbW w8vAIHhzUSV1SqgMnwpLFzumaqq3cYpxwxTxorMGU7m9Jnx145kry55M298x9rZ+nHqT NkRRVR4xzL1lEBuh9wZn9vv/mqVUaaJB2jhR72ssVCTwM5QJ8fsCjLLCOU+m1bI2wkIX Mmdw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Z71lMkKGKkRbgOwlHx6kojoTQy/XJ5qUrx1UFUxwF8Y=; b=YgZEhwANN/kGFnls4bEkvP3OKYpzYQYW48PoHB/faqVgrwhKOquFqQptY+YRPQif6e UClEubpwgq3LzMjbpw8cN24cbOD4cnlNUv/91ywlg7tcPfExGzD9SUotP3SaQJsbgHUw 31p5KKbYkpOyh7RlZt709eJrlFu3lmAamX06VsxVS2oOGSfBtDGKZvLInhpPJN8utTXt +6Rvx2p+R6dlfS4UgrecYyRPbr5WFvk+LXXEBXkJa0Mi1Tq0vLcItTHCrxnlXsL/mCT4 LW5GP+KDHsEq2QktG3OXbdk9ijDtM6m1cXY8XAUVQu4/eUkJH8roihV8mMuKWWuwHU+c jjgA== X-Gm-Message-State: ACrzQf3ycwGGf1GfQZbtkZxY9oYr0V53uUHqPmiZQEz5bjU/rGhKvyJY VV+w5JQ2d+BXkxM6xKfbHaSZ0xCJoMI= X-Google-Smtp-Source: AMsMyM6eMs45KPNVoXhDxOw3qqPM/u8LUv3drLJ4ITWWkqcYS427d8tv9CFvAXmtylsmvL1EHA5/HQ== X-Received: by 2002:a05:600c:524d:b0:3c6:ec2f:7daa with SMTP id fc13-20020a05600c524d00b003c6ec2f7daamr6964059wmb.50.1666892088439; Thu, 27 Oct 2022 10:34:48 -0700 (PDT) Received: from rltb ([82.66.8.55]) by smtp.gmail.com with ESMTPSA id bn8-20020a056000060800b002365921c9aesm1829152wrb.77.2022.10.27.10.34.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 27 Oct 2022 10:34:47 -0700 (PDT) From: Robert Pluim In-Reply-To: <83mt9hkznm.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 27 Oct 2022 19:19:09 +0300") References: <86pmeijuvz.fsf@stephe-leake.org> <83mt9hkznm.fsf@gnu.org> Date: Thu, 27 Oct 2022 19:34:47 +0200 Message-ID: <87v8o5rwzs.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >>>>> On Thu, 27 Oct 2022 19:19:09 +0300, Eli Zaretskii said: Eli> Jo=C3=A3o, any comments? Jo=C3=A3o already fixed this on master (but didn=CA=BCt put (Bug#58745) in = the commit message). Robert --=20 From unknown Sun Jun 22 08:02:25 2025 X-Loop: help-debbugs@gnu.org Subject: bug#58745: 29.0.50; eglot managed-major-mode must be a list Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 27 Oct 2022 17:39:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58745 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Robert Pluim Cc: 58745@debbugs.gnu.org, Eli Zaretskii , Stephen Leake Received: via spool by 58745-submit@debbugs.gnu.org id=B58745.166689230914431 (code B ref 58745); Thu, 27 Oct 2022 17:39:02 +0000 Received: (at 58745) by debbugs.gnu.org; 27 Oct 2022 17:38:29 +0000 Received: from localhost ([127.0.0.1]:59242 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oo6po-0003kg-Lq for submit@debbugs.gnu.org; Thu, 27 Oct 2022 13:38:28 -0400 Received: from mail-oi1-f177.google.com ([209.85.167.177]:40907) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oo6pl-0003kG-Ab for 58745@debbugs.gnu.org; Thu, 27 Oct 2022 13:38:26 -0400 Received: by mail-oi1-f177.google.com with SMTP id l5so3071296oif.7 for <58745@debbugs.gnu.org>; Thu, 27 Oct 2022 10:38:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=TUTDJDCgPxGnzuNycOCo9nhegH+IKRLeVz4Knt3G3ro=; b=aYTQt80mVWQnT0b1FCm1C+worJ/7h4824c6wAtVf3UlheUgd1gaOTQHDJ5vlmz8aKs yXp1wRw5zmwFR6rDUkyOusZzWUHCgc4SFFUKCdtOHzVOb/KnJdT2iWN69/RQbZS12/rN IPI1as437N/oF5S0OCaNs8APY5bhxmu0Wmt9Q9cejicxJN1Vux+m4j1tA87ZdMtMenVM 8+h+rErizlq65VOkizonLeRi2aAvv/CWrxC1mlh1OEW/xNwizEIg3M6xoWXNoZwlePRn nEa/Fgb/ZQnQnwCZCnWMln8PJyVSsLMbAjMpAqeARrHp9sWpiIE2wc7bteUIRqmW8l9h Qu1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=TUTDJDCgPxGnzuNycOCo9nhegH+IKRLeVz4Knt3G3ro=; b=Rg42kZwzEpJPoBNDnNOMbgQwYcJjmQ/PQtzN0Wm58340/KaV2yxJ60OUq9bfgVZy1W geFLhilXIbCB8PaLU8I0sJbr0iAW3IN1OJCO1HxhIhwYukWfELqDuNdlTIZpinspVM1Y daW8CUYxwLVo76BUmlLSxkZYQ9XsluPxQFWwOwlUIWR8AxzrXUOZPbPr/oyBfblEaHwH GVIPpG6SkVPY2yVJBsEHuRh0JULXZOejdV2SrXj+O6TFPTjIki/plQGlXzMDfYT57IVM mu4MymwAf8hZzUvcBsCzxNhiB6ga1V7bZGCkU/ELBvqEtCXHejJhpq136G6dNXVe9uz6 6jEg== X-Gm-Message-State: ACrzQf0I5zq9eOoILUfTEstTavG/Q4neu0gkjB05jepTVo2/Y12H2ape Iw7t6mgxCdhRtzr2cnG9GKPKyXjqzcN4MKJ+XkI= X-Google-Smtp-Source: AMsMyM4cHeV1Lt4+Sr439Lq6BTKPw7KW/UHmG8+Hf3bJ1Z1vkVs3Fhq5bcBz4T3/0snf8Rht7QURltxjMoNE9QQv0+s= X-Received: by 2002:a05:6808:1a1f:b0:354:b33b:8b0d with SMTP id bk31-20020a0568081a1f00b00354b33b8b0dmr5273350oib.171.1666892299695; Thu, 27 Oct 2022 10:38:19 -0700 (PDT) MIME-Version: 1.0 References: <86pmeijuvz.fsf@stephe-leake.org> <83mt9hkznm.fsf@gnu.org> <87v8o5rwzs.fsf@gmail.com> In-Reply-To: <87v8o5rwzs.fsf@gmail.com> From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Date: Thu, 27 Oct 2022 18:39:19 +0100 Message-ID: Content-Type: multipart/alternative; boundary="00000000000066f8ef05ec079b30" X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --00000000000066f8ef05ec079b30 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable > Jo=C3=A3o already fixed this on master (but didn=CA=BCt put (Bug#58745) i= n the > commit message). I think it was Stephen's commit: commit 31945b6c3fcbdb6f242f0063811d2fb91e4520cd Author: Stephen Leake Date: Tue Oct 25 02:15:13 2022 -0700 * lisp/progmodes/eglot.el (eglot): Ensure managed-major-mode is a list I just fixed a bug this introduced in a subsequent commit (didn't use a bug id because neither did the original commit and the fix was somewhat urgent, as M-x eglot was broken. So I didn't search the db for one.): commit 0b1eda215d32839c9f6281d20f8a347f34bb5ab5 Author: Jo=C3=A3o T=C3=A1vora Date: Tue Oct 25 10:34:08 2022 +0100 Fix M-x eglot breakage due to typo * lisp/progmodes/eglot.el (eglot): Fix bug. --00000000000066f8ef05ec079b30 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

> Jo=C3=A3o alread= y fixed this on master (but didn=CA=BCt put (Bug#58745) in the
> comm= it message).

I think it was Stephen's commit:<= /div>

commit 31945b6c3fcbdb6f242f0063811d2fb91e4520cdAuthor: Stephen Leake <stephen_leake@stephe-leake.org>
Date: =C2=A0 Tue Oct 25 02:15:1= 3 2022 -0700

=C2=A0 * lisp/progmodes/eglot.el (eglot): Ensure manage= d-major-mode is a list

I just fixed a bug th= is introduced in a subsequent commit (didn't use a bug id
because neither did the original commit and the fix was somewhat urgent,<= /div>
as M-x eglot was broken.=C2=A0 So I didn't search the db for = one.):

commit 0b1eda215d32839c9f6281d20f8a347f34bb= 5ab5
Author: Jo=C3=A3o T=C3=A1vora <joaotavora@gmail.com>
Date: =C2=A0 Tue Oct 25 10:34:08 202= 2 +0100

=C2=A0 Fix M-x eglot breakage due to typo
=C2=A0
=C2= =A0 * lisp/progmodes/eglot.el (eglot): Fix bug.
--00000000000066f8ef05ec079b30-- From unknown Sun Jun 22 08:02:25 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Stephen Leake Subject: bug#58745: closed (Re: bug#58745: 29.0.50; eglot managed-major-mode must be a list) Message-ID: References: <83a65hkw0d.fsf@gnu.org> <86pmeijuvz.fsf@stephe-leake.org> X-Gnu-PR-Message: they-closed 58745 X-Gnu-PR-Package: emacs Reply-To: 58745@debbugs.gnu.org Date: Thu, 27 Oct 2022 17:39:03 +0000 Content-Type: multipart/mixed; boundary="----------=_1666892343-14492-1" This is a multi-part message in MIME format... ------------=_1666892343-14492-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #58745: 29.0.50; eglot managed-major-mode must be a list which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 58745@debbugs.gnu.org. --=20 58745: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D58745 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1666892343-14492-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 58745-done) by debbugs.gnu.org; 27 Oct 2022 17:38:25 +0000 Received: from localhost ([127.0.0.1]:59236 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oo6pb-0003k4-6A for submit@debbugs.gnu.org; Thu, 27 Oct 2022 13:38:25 -0400 Received: from eggs.gnu.org ([209.51.188.92]:40924) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oo6pV-0003jk-HU for 58745-done@debbugs.gnu.org; Thu, 27 Oct 2022 13:38:14 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oo6pO-0001pw-P1; Thu, 27 Oct 2022 13:38:02 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=GkCOZ2wDSdrlKi3Ah3gQ3lVOCxph9N1dLfciY1307Jw=; b=pStuUjr/8lE7Nnq/x2Qt Op3HU5Ko6ROdGSF45Qo8REvHvNxxnkRTmOpBF8IZnpe2RTCTO+e7DeL7BFN1grNKMIGr+Yx0I85/d Dm+GTtz0z0CBWX8FzrBXFlAVL42IXv+SPc7F/Fw9CQTQUtTdj15m+QOplKO1SoclXJV+Fuy8VpEj0 CNkWVXmjwBQq/Mxtm/KlvuVgZYPGZLpMarXJ3pTxLlTQSTxUQjpDVSomTmoMehHA4sydl6dTprvxo IyGH/pVnbT12iLydroIOgM+meGgASQ1S/cYt6uKnkmUMgJVhVFwJWz34s3uYKQ2uC6iv+8df3zlB0 h6u2j4ftcU/ZVw==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oo6pM-0002hh-LS; Thu, 27 Oct 2022 13:38:01 -0400 Date: Thu, 27 Oct 2022 20:37:54 +0300 Message-Id: <83a65hkw0d.fsf@gnu.org> From: Eli Zaretskii To: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= In-Reply-To: (message from =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= on Thu, 27 Oct 2022 18:27:14 +0100) Subject: Re: bug#58745: 29.0.50; eglot managed-major-mode must be a list References: <86pmeijuvz.fsf@stephe-leake.org> <83mt9hkznm.fsf@gnu.org> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 58745-done Cc: 58745-done@debbugs.gnu.org, stephen_leake@stephe-leake.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: João Távora > Date: Thu, 27 Oct 2022 18:27:14 +0100 > Cc: Stephen Leake , 58745@debbugs.gnu.org > > Yes, this has been discussed on emacs-devel and an equivalent patch > pushed. > > So the bug can be closed. Done. ------------=_1666892343-14492-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 23 Oct 2022 17:46:57 +0000 Received: from localhost ([127.0.0.1]:46457 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1omf3o-0001nY-VO for submit@debbugs.gnu.org; Sun, 23 Oct 2022 13:46:57 -0400 Received: from lists.gnu.org ([209.51.188.17]:45778) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1omf3l-0001nO-Ry for submit@debbugs.gnu.org; Sun, 23 Oct 2022 13:46:55 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1omf3f-0005hj-85 for bug-gnu-emacs@gnu.org; Sun, 23 Oct 2022 13:46:53 -0400 Received: from gproxy5-pub.mail.unifiedlayer.com ([67.222.38.55] helo=progateway7-pub.mail.pro1.eigbox.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1omf3Z-0005t9-Mf for bug-gnu-emacs@gnu.org; Sun, 23 Oct 2022 13:46:47 -0400 Received: from cmgw14.mail.unifiedlayer.com (unknown [10.0.90.129]) by progateway7.mail.pro1.eigbox.com (Postfix) with ESMTP id 7BD6B10044912 for ; Sun, 23 Oct 2022 17:46:09 +0000 (UTC) Received: from host2007.hostmonster.com ([67.20.76.71]) by cmsmtp with ESMTP id mf33oUsPOoMaxmf33oZ7s0; Sun, 23 Oct 2022 17:46:09 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=X4CXlEfe c=1 sm=1 tr=0 ts=63557de1 a=dWLzHQi6WpdymmZIwiVdBw==:117 a=Fln8i1WyhtedwaIJAdHvmw==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=Qawa6l4ZSaYA:10:nop_rcvd_month_year a=vvvmwbhNdt4A:10:endurance_base64_authed_username_1 a=2LqzHnf1UjNOzmVpYhcA:9 a=7Zwj6sZBwVKJAoWSPKxL6X1jA+E=:19 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=stephe-leake.org; s=default; h=Content-Type:MIME-Version:Message-ID:Date: Subject:To:From:Sender:Reply-To:Cc:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=hPGjFV7E/E63yp2yrbBn+6CIwHMdhLq5oQr46dtDeXQ=; b=AcyTAT8sSziZsEBU4DB9+pqN+a H5K9wT0Ie4mV0B8ir0qZqs+lyPHsczkFheqf9a4dMcFRD1wpjuHZnMGmDZHoHR02ibeYJNhPjKF6O Qu/xgVc43DF+MqF4Pi9OSm8CFNBXMNbbvA698/u+DJPQJpa30OqGi03VJZIz34OEYImswNQ1aobC3 cRQh0PeMruXvBZ4cJ6E8UamXQHOaZtGGWPLNTtlZvhEKgf4BWUih8+Mktv5BV+dNnCa1nnm3t2hp9 17NZ3c8jBMlOhl5vziqe9TzOA94M6emKybYH5+AMQaqJFBL0rLAl/BmeN+eNMPmXgp60qigDGGo5v XvmG/Glw==; Received: from 135-180-197-170.fiber.dynamic.sonic.net ([135.180.197.170]:50772 helo=DESKTOP-G20DCG1) by host2007.hostmonster.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1omf33-003ZzE-21 for bug-gnu-emacs@gnu.org; Sun, 23 Oct 2022 11:46:09 -0600 From: Stephen Leake To: bug-gnu-emacs@gnu.org Subject: 29.0.50; eglot managed-major-mode must be a list Date: Sun, 23 Oct 2022 10:46:08 -0700 Message-ID: <86pmeijuvz.fsf@stephe-leake.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - host2007.hostmonster.com X-AntiAbuse: Original Domain - gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - stephe-leake.org X-BWhitelist: no X-Source-IP: 135.180.197.170 X-Source-L: No X-Exim-ID: 1omf33-003ZzE-21 X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 135-180-197-170.fiber.dynamic.sonic.net (DESKTOP-G20DCG1) [135.180.197.170]:50772 X-Source-Auth: stephen_leake@stephe-leake.org X-Email-Count: 1 X-Source-Cap: c3RlcGhlbGU7c3RlcGhlbGU7aG9zdDIwMDcuaG9zdG1vbnN0ZXIuY29t X-Local-Domain: yes Received-SPF: pass client-ip=67.222.38.55; envelope-from=stephen_leake@stephe-leake.org; helo=progateway7-pub.mail.pro1.eigbox.com X-Spam_score_int: 16 X-Spam_score: 1.6 X-Spam_bar: + X-Spam_report: (1.6 / 5.0 requ) BAYES_00=-1.9, DKIM_INVALID=0.1, DKIM_SIGNED=0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, RCVD_IN_SBL_CSS=3.335, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-Spam-Score: 1.9 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: I'm calling `eglot' from lisp. The doc string says the first argument `managed-major-mode' is an atom, not a list. But it is passed to eglot--connect as the first argument, which is expected to be a l [...] Content analysis details: (1.9 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 3.6 RCVD_IN_SBL_CSS RBL: Received via a relay in Spamhaus SBL-CSS [135.180.197.170 listed in zen.spamhaus.org] -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at https://www.dnswl.org/, medium trust [209.51.188.17 listed in list.dnswl.org] -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [209.51.188.17 listed in wl.mailspike.net] -0.0 SPF_HELO_PASS SPF: HELO matches SPF record 0.7 SPF_NEUTRAL SPF: sender does not match SPF record (neutral) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.9 (/) I'm calling `eglot' from lisp. The doc string says the first argument `managed-major-mode' is an atom, not a list. But it is passed to eglot--connect as the first argument, which is expected to be a list of major modes. When called interactively, `managed-major-mode' is set by (eglot--guess-contact t), which returns a list. So when not interactive, `eglot' must convert `managed-major-mode' into a list: ------------------- diff --git a/lisp/progmodes/eglot.el b/lisp/progmodes/eglot.el index 71001ba680..dee88db022 100644 --- a/lisp/progmodes/eglot.el +++ b/lisp/progmodes/eglot.el @@ -1078,6 +1078,8 @@ eglot INTERACTIVE is t if called interactively." (interactive (append (eglot--guess-contact t) '(t))) + (unless (listp managed-major-mode) + (setq managed-major-mode (list managed-major-mode))) (let* ((current-server (eglot-current-server)) (live-p (and current-server (jsonrpc-running-p current-server)))) (if (and live-p ------------------ -- -- Stephe In GNU Emacs 29.0.50 (build 1, x86_64-w64-mingw32) of 2022-10-22 built on DESKTOP-G20DCG1 Repository revision: 9db7b11cf7fa5d6cf624a467f966a14b347e4429 Repository branch: master Windowing system distributor 'Microsoft Corp.', version 10.0.19044 System Description: Microsoft Windows 10 Pro (v10.0.2009.19044.2130) Configured using: 'configure PKG_CONFIG_PATH=/mingw64/lib/pkgconfig:/mingw64/share/pkgconfig' Configured features: ACL DBUS GIF GMP GNUTLS HARFBUZZ JPEG JSON LCMS2 LIBXML2 MODULES NOTIFY W32NOTIFY PDUMPER PNG RSVG SOUND SQLITE3 THREADS TIFF TOOLKIT_SCROLL_BARS WEBP XPM ZLIB Important settings: value of $LC_CTYPE: en_US.UTF-8 value of $LANG: ENU locale-coding-system: cp1252 Major mode: ELisp/l Minor modes in effect: bug-reference-prog-mode: t other-frame-window-mode: t display-time-mode: t delete-selection-mode: t outline-minor-mode: t icomplete-mode: t tooltip-mode: t global-eldoc-mode: t eldoc-mode: t show-paren-mode: t electric-indent-mode: t mouse-wheel-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t line-number-mode: t transient-mark-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t Load-path shadows: c:/Projects/org.emacs.ada-mode/prj hides c:/Projects/org.emacs.gpr-query/prj c:/Projects/org.emacs.ada-mode/prj-eglot hides c:/Projects/org.emacs.gpr-query/prj-eglot c:/Projects/org.emacs.ada-mode/autoloads hides c:/Projects/org.emacs.gpr-query/autoloads c:/Projects/org.emacs.ada-mode/autoloads hides c:/Projects/org.emacs.gnat-compiler/autoloads c:/Projects/org.emacs.ada-mode/prj-eglot hides c:/Projects/org.emacs.wisi/prj-eglot c:/Projects/org.emacs.ada-mode/autoloads hides c:/Projects/org.emacs.wisi/autoloads c:/Projects/org.emacs.ada-mode/prj hides c:/Projects/org.wisitoken.grammar_mode/prj c:/Projects/org.emacs.ada-mode/autoloads hides c:/Projects/org.wisitoken.grammar_mode/autoloads c:/Projects/org.emacs.ada-mode/ada-ref-man hides c:/home/stephe/.emacs.d/elpa/ada-ref-man-2020.1.0.20201129.190419/ada-ref-man c:/Projects/mmm-mode/mmm-vars hides c:/home/stephe/.emacs.d/elpa/mmm-mode-0.5.8.0.20221018.153958/mmm-vars c:/Projects/mmm-mode/mmm-utils hides c:/home/stephe/.emacs.d/elpa/mmm-mode-0.5.8.0.20221018.153958/mmm-utils c:/Projects/mmm-mode/mmm-univ hides c:/home/stephe/.emacs.d/elpa/mmm-mode-0.5.8.0.20221018.153958/mmm-univ c:/Projects/mmm-mode/mmm-sample hides c:/home/stephe/.emacs.d/elpa/mmm-mode-0.5.8.0.20221018.153958/mmm-sample c:/Projects/mmm-mode/mmm-rpm hides c:/home/stephe/.emacs.d/elpa/mmm-mode-0.5.8.0.20221018.153958/mmm-rpm c:/Projects/mmm-mode/mmm-region hides c:/home/stephe/.emacs.d/elpa/mmm-mode-0.5.8.0.20221018.153958/mmm-region c:/Projects/mmm-mode/mmm-noweb hides c:/home/stephe/.emacs.d/elpa/mmm-mode-0.5.8.0.20221018.153958/mmm-noweb c:/Projects/mmm-mode/mmm-myghty hides c:/home/stephe/.emacs.d/elpa/mmm-mode-0.5.8.0.20221018.153958/mmm-myghty c:/Projects/mmm-mode/mmm-mode hides c:/home/stephe/.emacs.d/elpa/mmm-mode-0.5.8.0.20221018.153958/mmm-mode c:/Projects/mmm-mode/mmm-mason hides c:/home/stephe/.emacs.d/elpa/mmm-mode-0.5.8.0.20221018.153958/mmm-mason c:/Projects/mmm-mode/mmm-erb hides c:/home/stephe/.emacs.d/elpa/mmm-mode-0.5.8.0.20221018.153958/mmm-erb c:/Projects/mmm-mode/mmm-defaults hides c:/home/stephe/.emacs.d/elpa/mmm-mode-0.5.8.0.20221018.153958/mmm-defaults c:/Projects/mmm-mode/mmm-cweb hides c:/home/stephe/.emacs.d/elpa/mmm-mode-0.5.8.0.20221018.153958/mmm-cweb c:/Projects/mmm-mode/mmm-compat hides c:/home/stephe/.emacs.d/elpa/mmm-mode-0.5.8.0.20221018.153958/mmm-compat c:/Projects/mmm-mode/mmm-cmds hides c:/home/stephe/.emacs.d/elpa/mmm-mode-0.5.8.0.20221018.153958/mmm-cmds c:/Projects/mmm-mode/mmm-class hides c:/home/stephe/.emacs.d/elpa/mmm-mode-0.5.8.0.20221018.153958/mmm-class c:/Projects/mmm-mode/mmm-auto hides c:/home/stephe/.emacs.d/elpa/mmm-mode-0.5.8.0.20221018.153958/mmm-auto Features: (shadow sort mail-extr emacsbug pulse color vc bug-reference help-fns radix-tree cl-print misearch multi-isearch copyright cus-start edebug ada-eglot ada-mode ada-imenu align ada-skel wisi-skel skeleton ada_annex_p-process wisi-process-parse ada-indent-user-options ada-core gnat-compiler vc-git diff-mode easy-mmode vc-dispatcher org-element avl-tree generator ol-eww eww xdg url-queue mm-url ol-rmail ol-mhe ol-irc ol-info ol-gnus nnselect gnus-art mm-uu mml2015 mm-view mml-smime smime gnutls dig gnus-sum shr pixel-fill kinsoku url-file svg dom gnus-group gnus-undo gnus-start gnus-dbus dbus xml gnus-cloud nnimap nnmail mail-source utf7 nnoo parse-time gnus-spec gnus-int gnus-range message sendmail yank-media puny rfc822 mml mml-sec epa derived mm-decode mm-bodies mm-encode mail-parse rfc2231 rfc2047 rfc2045 ietf-drums mailabbrev gmm-utils mailheader gnus-win gnus nnheader gnus-util mail-utils range mm-util mail-prsvr wid-edit ol-docview doc-view jka-compr image-mode exif ol-bibtex ol-bbdb ol-w3m ol-doi org-link-doi org-mode-keys org ob ob-tangle ob-ref ob-lob ob-table ob-exp org-macro org-footnote org-src ob-comint org-pcomplete pcomplete org-list org-faces org-entities org-version ob-emacs-lisp ob-core ob-eval org-table oc-basic bibtex iso8601 time-date ol rx org-keys oc org-compat advice org-macs org-loaddefs format-spec cal-menu calendar cal-loaddefs wisi-prj wisi wisi-fringe wisi-parse-common semantic/lex semantic/fw mode-local find-file eglot array filenotify jsonrpc ert pp debug backtrace find-func flymake-proc flymake warnings pcase imenu mmm-auto mmm-vars mmm-utils mmm-compat dvc-autoloads dvc-unified ffap thingatpt dvc-revlist dvc-fileinfo dvc-core dvc-buffers dvc-ui dvc-register dvc-utils ewoc dvc-emacs dvc-defs autoloads other-frame-window grep time delsel cus-load stephe-theme noutline outline icons path-iterator cl-extra help-mode whitespace dired-x dired-aux dired dired-loaddefs compile text-property-search comint ansi-osc ansi-color uniquify-files icomplete xref project ring ada-ref-man-autoloads bbdb-autoloads info debbugs-autoloads gnu-elpa-keyring-update-autoloads epg rfc6068 epg-config gnu-elpa-keyring-update helm-autoloads helm-core-autoloads async-autoloads mmm-mode-autoloads other-frame-window-autoloads popup-autoloads uniquify-files-autoloads package browse-url url url-proxy url-privacy url-expand url-methods url-history url-cookie generate-lisp-file url-domsuf url-util mailcap url-handlers url-parse auth-source cl-seq eieio eieio-core cl-macs password-cache json subr-x map byte-opt gv bytecomp byte-compile cconv url-vars cl-loaddefs cl-lib rmc iso-transl tooltip eldoc paren electric uniquify ediff-hook vc-hooks lisp-float-type elisp-mode mwheel dos-w32 ls-lisp disp-table term/w32-win w32-win w32-vars term/common-win tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch easymenu timer select scroll-bar mouse jit-lock font-lock syntax font-core term/tty-colors frame minibuffer nadvice seq simple cl-generic indonesian philippine cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite emoji-zwj charscript charprop case-table epa-hook jka-cmpr-hook help abbrev obarray oclosure cl-preloaded button loaddefs theme-loaddefs faces cus-face macroexp files window text-properties overlay sha1 md5 base64 format env code-pages mule custom widget keymap hashtable-print-readable backquote threads w32notify dbusbind w32 lcms2 multi-tty make-network-process emacs) Memory information: ((conses 16 283572 42382) (symbols 48 29015 0) (strings 32 97057 4158) (string-bytes 1 2980479) (vectors 16 51760) (vector-slots 8 619438 29596) (floats 8 411 501) (intervals 56 3878 22) (buffers 1000 28)) ------------=_1666892343-14492-1-- From unknown Sun Jun 22 08:02:25 2025 X-Loop: help-debbugs@gnu.org Subject: bug#58745: 29.0.50; eglot managed-major-mode must be a list Resent-From: Stephen Leake Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 27 Oct 2022 17:53:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58745 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Cc: Eli Zaretskii , 58745@debbugs.gnu.org Received: via spool by 58745-submit@debbugs.gnu.org id=B58745.166689312416134 (code B ref 58745); Thu, 27 Oct 2022 17:53:02 +0000 Received: (at 58745) by debbugs.gnu.org; 27 Oct 2022 17:52:04 +0000 Received: from localhost ([127.0.0.1]:59267 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oo72y-0004C9-2x for submit@debbugs.gnu.org; Thu, 27 Oct 2022 13:52:04 -0400 Received: from outbound-ss-761.bluehost.com ([74.220.211.250]:51407) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oo72s-0004BK-TO for 58745@debbugs.gnu.org; Thu, 27 Oct 2022 13:52:00 -0400 Received: from cmgw14.mail.unifiedlayer.com (unknown [10.0.90.129]) by progateway8.mail.pro1.eigbox.com (Postfix) with ESMTP id 044A61006A2F8 for <58745@debbugs.gnu.org>; Thu, 27 Oct 2022 17:51:42 +0000 (UTC) Received: from host2007.hostmonster.com ([67.20.76.71]) by cmsmtp with ESMTP id o72boym5UZpqYo72coe0W5; Thu, 27 Oct 2022 17:51:42 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=MKClJOVl c=1 sm=1 tr=0 ts=635ac52e a=dWLzHQi6WpdymmZIwiVdBw==:117 a=Fln8i1WyhtedwaIJAdHvmw==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=cMZOtVvZe9QQuduv:21 a=IkcTkHD0fZMA:10:nop_charset_1 a=Qawa6l4ZSaYA:10:nop_rcvd_month_year a=vvvmwbhNdt4A:10:endurance_base64_authed_username_1 a=pGLkceISAAAA:8 a=69wJf7TsAAAA:8 a=CT6dVZOgh06FITipqpQA:9 a=QEXdDO2ut3YA:10:nop_charset_2 a=H0ZfJGM__2RG8jfyPCJ1:22 a=Fg1AiH1G6rFz08G2ETeA:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=stephe-leake.org; s=default; h=Content-Transfer-Encoding:Content-Type: MIME-Version:Message-ID:Date:References:In-Reply-To:Subject:Cc:To:From:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=9pT7cc5XJuFGlmAp9oEE9wegy7PAfVGYB64e40sFxVY=; b=FFr4PMJCIQ1kdjf1SN7kcs0PpP 1SWIJ1FekP3Ja3RdEgmC5EVEFunNTg1P8Yxpra75onaqxyaK5b4iEYyd489Vs/Xe85ot2EyzgPLw0 MHMbLeMfZGlrS2P/qWw+rfKqrs4G8XgnTZ0taHG5Te5qakvBH24xtjhX8fbJqoQF5FcWbHBwpdXfq y26zaxBfljXBQ5CCOUH9Nn5RnjX1zNhRgI11Mh6fWgGeEnHPij4Cp4QEWbwE4AZbQKay/Eu1BQU7/ 5rGaK/xtqp3GA4ep+r2hiJP32Y9LgyV5RXvMAcTsS6F9sF/9gYgJ+H9iCDJGL5WAQIDibgwI8uX+E +1qSDN1w==; Received: from 135-180-197-170.fiber.dynamic.sonic.net ([135.180.197.170]:57591 helo=DESKTOP-G20DCG1) by host2007.hostmonster.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1oo72b-001E7q-I9; Thu, 27 Oct 2022 11:51:41 -0600 From: Stephen Leake In-Reply-To: ("=?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?="'s message of "Thu, 27 Oct 2022 18:27:14 +0100") References: <86pmeijuvz.fsf@stephe-leake.org> <83mt9hkznm.fsf@gnu.org> Date: Thu, 27 Oct 2022 10:51:40 -0700 Message-ID: <8635b92lzn.fsf@stephe-leake.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - host2007.hostmonster.com X-AntiAbuse: Original Domain - debbugs.gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - stephe-leake.org X-BWhitelist: no X-Source-IP: 135.180.197.170 X-Source-L: No X-Exim-ID: 1oo72b-001E7q-I9 X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 135-180-197-170.fiber.dynamic.sonic.net (DESKTOP-G20DCG1) [135.180.197.170]:57591 X-Source-Auth: stephen_leake@stephe-leake.org X-Email-Count: 3 X-Source-Cap: c3RlcGhlbGU7c3RlcGhlbGU7aG9zdDIwMDcuaG9zdG1vbnN0ZXIuY29t X-Local-Domain: yes X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Jo=C3=A3o T=C3=A1vora writes: > Yes, this has been discussed on emacs-devel and an equivalent patch > pushed. > > So the bug can be closed. > > The function eglot doesn't have any non-interactive use that I can envisi= on. > Its INTERACTIVE argument is a historical remnant from a time where > the function was called eglot-start-process. Nevertheless, it makes sense > that it converts the argument into a list. > > Stephen, I would advise against using eglot from Lisp, in principle > but I haven't seen your use case It will be in ada-mode 8.0, to be released soon; currently at https://git.savannah.nongnu.org/cgit/ada-mode.git/tree/ada-eglot.el?h=3Dorg= .emacs.ada-mode I'm still fussing with it, but the core reason I'm calling eglot directly is because the lsp server executable filename needs to be computed at the time eglot is called, and eglot-workspace-configuration needs to be let-bound to specify the project file used by the Ada lsp server. The first issue is mainly so I can change it easily to test alternate versions/patches to the server; users may want to do the same, or even use different versions with different projects. I could change exec-path instead, but the current way seems cleaner. The second issue should be fixed by using :initializeOptions instead, but that's broken in the current Ada server. It still needs to be computed on a per-project basis. I could set elgot-server-programs with the locally-computed values, and then use (call-interactively eglot), if you really want the args to eglot to go away. But I think calling eglot directly is more in keeping with the flavor of ada-mode's use of it; it's just an alternative backend for various features, not the primary user interface.=20 --=20 -- Stephe