Subject: bug#58734: closed (Re: bug#58734: installer: backtrace page in final step)

From: [email-masked] (GNU bug Tracking System)
Date: Sun, 23 Oct 2022 13:40:02 +0000

Your bug report

#58734: installer: backtrace page in final step

which was filed against the guix package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to [email-masked].

-- 
58734: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=58734
GNU Bug Tracking System
Contact [email-masked] with problems

Subject: Re: bug#58734: installer: backtrace page in final step
From: Mathieu Othacehe <[email-masked]>
To: [email-masked]
Date: Sun, 23 Oct 2022 15:38:56 +0200
List-Id: <debbugs-submit.debbugs.gnu.org>

> +  (error 'fake)
>    (installer-log-line "running command ~s" command)
>    (define result (run-external-command-with-line-hooks
>                    (list %display-line-hook) command

Fixed with bf5e78d59fcb188d0bce02d93c93d06069178837.

Thanks,

Mathieu

Subject: installer: backtrace page in final step
From: Mathieu Othacehe <[email-masked]>
To: [email-masked]
Date: Sun, 23 Oct 2022 11:39:36 +0200
List-Id: <debbugs-submit.debbugs.gnu.org>

Hello,

When an error occurs in the pseudo terminal displaying the "guix system
init" command output, the backtrace is not displayed correctly and the
keyboard cannot be used (arrows, tab, enter keys) to scroll down the
backtrace or dump it.

It can easily be reproduced by introducing an error in the "run-command"
function, this way:

--8<---------------cut here---------------start------------->8---
--- a/gnu/installer/utils.scm
+++ b/gnu/installer/utils.scm
@@ -184,6 +184,7 @@ (define (pause)
       (((port _ ...) _ _)
        (read-line port))))
 
+  (error 'fake)
   (installer-log-line "running command ~s" command)
   (define result (run-external-command-with-line-hooks
                   (list %display-line-hook) command
--8<---------------cut here---------------end--------------->8---

I suspect that we may need to run "newt-init" and "clear-screen" before
displaying the backtrace page.

Thanks,

Mathieu