GNU bug report logs - #58721
28.2; dired with delete-by-moving-to-trash can't trash directory twice

Previous Next

Package: emacs;

Reported by: Gustavo Barros <gusbrs.2016 <at> gmail.com>

Date: Sat, 22 Oct 2022 18:24:01 UTC

Severity: normal

Found in version 28.2

Done: Eli Zaretskii <eliz <at> gnu.org>

Bug is archived. No further changes may be made.

Full log

View this message in rfc822 format

From: Eli Zaretskii <eliz <at> gnu.org>
To: Mike Kupfer <mkupfer <at> alum.berkeley.edu>
Cc: 58721 <at> debbugs.gnu.org, gusbrs.2016 <at> gmail.com
Subject: bug#58721: 28.2; dired with delete-by-moving-to-trash can't trash directory twice
Date: Sun, 30 Oct 2022 20:02:54 +0200

> From: Mike Kupfer <mkupfer <at> alum.berkeley.edu>
> cc: 58721 <at> debbugs.gnu.org, gusbrs.2016 <at> gmail.com
> Date: Sun, 30 Oct 2022 10:40:24 -0700
> 
> Eli Zaretskii wrote:
> 
> > I just thought you'd be able to call copy-directory, similarly (but
> > differently) to what rename-file does, instead of using your
> > lambda-function.
> 
> Ah, of course.  Thanks, yes, that's cleaner.  How does the attached
> patch look?

Looks good, but maybe add to the comment the reason _why_ we don't use
rename-file for directories.  You explained _what_ we do, but not
_why_.

Thanks.
This bug report was last modified 2 years and 182 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.