From lennart.borgman@gmail.com Mon Jul 21 08:33:09 2008 X-Spam-Checker-Version: SpamAssassin 3.2.3-bugs.debian.org_2005_01_02 (2007-08-08) on rzlab.ucr.edu X-Spam-Level: X-Spam-Status: No, score=-6.9 required=4.0 tests=AWL,BAYES_00, RCVD_IN_DNSWL_MED autolearn=ham version=3.2.3-bugs.debian.org_2005_01_02 Received: (at submit) by emacsbugs.donarmstrong.com; 21 Jul 2008 15:33:09 +0000 Received: from fencepost.gnu.org (fencepost.gnu.org [140.186.70.10]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id m6LFX6mi032396 for ; Mon, 21 Jul 2008 08:33:07 -0700 Received: from mail.gnu.org ([199.232.76.166]:58568 helo=mx10.gnu.org) by fencepost.gnu.org with esmtp (Exim 4.67) (envelope-from ) id 1KKxNA-00042f-GD for emacs-pretest-bug@gnu.org; Mon, 21 Jul 2008 11:32:24 -0400 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1KKxNm-0000JS-Ln for emacs-pretest-bug@gnu.org; Mon, 21 Jul 2008 11:33:05 -0400 Received: from ch-smtp02.sth.basefarm.net ([80.76.149.213]:51381) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1KKxNl-0000JC-UY for emacs-pretest-bug@gnu.org; Mon, 21 Jul 2008 11:33:02 -0400 Received: from c83-254-145-59.bredband.comhem.se ([83.254.145.59]:63829 helo=[127.0.0.1]) by ch-smtp02.sth.basefarm.net with esmtp (Exim 4.68) (envelope-from ) id 1KKxNk-00073A-7g for emacs-pretest-bug@gnu.org; Mon, 21 Jul 2008 17:33:00 +0200 Message-ID: <4884AC29.2060203@gmail.com> Date: Mon, 21 Jul 2008 17:32:57 +0200 From: "Lennart Borgman (gmail)" User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.9) Gecko/20071031 Thunderbird/2.0.0.9 Mnenhy/0.7.5.666 MIME-Version: 1.0 To: emacs-pretest-bug@gnu.org Subject: 23.0.60; To source or not to source (from help) Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Antivirus: avast! (VPS 080720-0, 2008-07-20), Outbound message X-Antivirus-Status: Clean X-Originating-IP: 83.254.145.59 X-Scan-Result: No virus found in message 1KKxNk-00073A-7g. X-Scan-Signature: ch-smtp02.sth.basefarm.net 1KKxNk-00073A-7g 8951f8cad736225b17ab72af324b47b5 X-detected-kernel: by monty-python.gnu.org: Linux 2.6? (barebone, rare!) If you do C-h v and look at a variable and click on the library link in the help buffer you will go to the file in your current Emacs tree. If you do C-h f to look at a function and do the same you will be taken to the cvs checkout file instead. In GNU Emacs 23.0.60.1 (i386-mingw-nt5.1.2600) of 2008-07-16 Windowing system distributor `Microsoft Corp.', version 5.1.2600 From rudalics@gmx.at Fri Aug 8 02:51:22 2008 X-Spam-Checker-Version: SpamAssassin 3.2.3-bugs.debian.org_2005_01_02 (2007-08-08) on rzlab.ucr.edu X-Spam-Level: X-Spam-Status: No, score=-5.0 required=4.0 tests=AWL,BAYES_00 autolearn=ham version=3.2.3-bugs.debian.org_2005_01_02 Received: (at 587) by emacsbugs.donarmstrong.com; 8 Aug 2008 09:51:22 +0000 Received: from mail.gmx.net (mail.gmx.net [213.165.64.20]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with SMTP id m789pHk7030481 for <587@emacsbugs.donarmstrong.com>; Fri, 8 Aug 2008 02:51:19 -0700 Received: (qmail invoked by alias); 08 Aug 2008 09:51:12 -0000 Received: from 62-47-56-100.adsl.highway.telekom.at (EHLO [62.47.56.100]) [62.47.56.100] by mail.gmx.net (mp044) with SMTP; 08 Aug 2008 11:51:12 +0200 X-Authenticated: #14592706 X-Provags-ID: V01U2FsdGVkX18ghcd9LzYg4VqUFhmUvnFnm7DczFhN2zXf6U1kvt tm8Q0hF09vIfrQ Message-ID: <489C1757.3060504@gmx.at> Date: Fri, 08 Aug 2008 11:52:23 +0200 From: martin rudalics User-Agent: Mozilla Thunderbird 1.0 (Windows/20041206) X-Accept-Language: de-DE, de, en-us, en MIME-Version: 1.0 To: 587@debbugs.gnu.org CC: Bug-Gnu-Emacs , "Lennart Borgman (gmail)" Subject: Re: 23.0.60; To source or not to source (from help) Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit X-Y-GMX-Trusted: 0 X-FuHaFi: 0.6899999999999999 X-CrossAssassin-Score: 2 > If you do C-h v and look at a variable and click on the library link in > the help buffer you will go to the file in your current Emacs tree. If > you do C-h f to look at a function and do the same you will be taken to > the cvs checkout file instead. I suspect you compiled Emacs in the checkout directory and then copied the Emacs tree to another directory. In this case the following might happen: As for C-h f `describe-function-1' will execute ;; See if lisp files are present where they where installed from. (if (not (eq file-name 'C-source)) (setq file-name (find-source-lisp-file file-name))) which sets `file-name' to the ".el" file from the checkout directory (because you did compile it there) and installs the corresponding reference in the hyperlink. As for C-h v `describe-variable' does _not_ care whether you compiled in another directory and simply goes to the file supplied by `symbol-file'. You could try inserting the snipped above in `describe-variable' immediately before the line (if file-name and see whether it now jumps to the checkout directory instead. Personally, I'd prefer something like the following in both cases: (unless (or (eq file-name 'C-source) (file-exists-p file-name)) (setq file-name (find-source-lisp-file file-name))) martin From lennart.borgman@gmail.com Fri Aug 8 04:09:24 2008 X-Spam-Checker-Version: SpamAssassin 3.2.3-bugs.debian.org_2005_01_02 (2007-08-08) on rzlab.ucr.edu X-Spam-Level: X-Spam-Status: No, score=-5.7 required=4.0 tests=AWL,BAYES_00, RCVD_IN_DNSWL_LOW autolearn=ham version=3.2.3-bugs.debian.org_2005_01_02 Received: (at 587) by emacsbugs.donarmstrong.com; 8 Aug 2008 11:09:25 +0000 Received: from ch-smtp01.sth.basefarm.net (ch-smtp01.sth.basefarm.net [80.76.149.212]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id m78B9Lud021632 for <587@emacsbugs.donarmstrong.com>; Fri, 8 Aug 2008 04:09:22 -0700 Received: from c83-254-151-176.bredband.comhem.se ([83.254.151.176]:59643 helo=[127.0.0.1]) by ch-smtp01.sth.basefarm.net with esmtp (Exim 4.68) (envelope-from ) id 1KRPqS-0006fJ-42; Fri, 08 Aug 2008 13:09:20 +0200 Message-ID: <489C2956.1030202@gmail.com> Date: Fri, 08 Aug 2008 13:09:10 +0200 From: "Lennart Borgman (gmail)" User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.9) Gecko/20071031 Thunderbird/2.0.0.9 Mnenhy/0.7.5.666 MIME-Version: 1.0 To: martin rudalics CC: 587@debbugs.gnu.org, Bug-Gnu-Emacs Subject: Re: 23.0.60; To source or not to source (from help) References: <489C1757.3060504@gmx.at> In-Reply-To: <489C1757.3060504@gmx.at> Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit X-Antivirus: avast! (VPS 080807-0, 2008-08-07), Outbound message X-Antivirus-Status: Clean X-Originating-IP: 83.254.151.176 X-Scan-Result: No virus found in message 1KRPqS-0006fJ-42. X-Scan-Signature: ch-smtp01.sth.basefarm.net 1KRPqS-0006fJ-42 6ef29a824504b1ac356340fa18d10ab5 martin rudalics wrote: > > If you do C-h v and look at a variable and click on the library link in > > the help buffer you will go to the file in your current Emacs tree. If > > you do C-h f to look at a function and do the same you will be taken to > > the cvs checkout file instead. > > I suspect you compiled Emacs in the checkout directory and then copied > the Emacs tree to another directory. I use the normal make install INSTALL_DIR=... > In this case the following might > happen: As for C-h f `describe-function-1' will execute > > ;; See if lisp files are present where they where installed from. > (if (not (eq file-name 'C-source)) > (setq file-name (find-source-lisp-file file-name))) > > which sets `file-name' to the ".el" file from the checkout directory > (because you did compile it there) and installs the corresponding > reference in the hyperlink. > > As for C-h v `describe-variable' does _not_ care whether you compiled in > another directory and simply goes to the file supplied by `symbol-file'. > You could try inserting the snipped above in `describe-variable' > immediately before the line > > (if file-name > > and see whether it now jumps to the checkout directory instead. Yes, I guess that is correct. > Personally, I'd prefer something like the following in both cases: > > (unless (or (eq file-name 'C-source) > (file-exists-p file-name)) > (setq file-name (find-source-lisp-file file-name))) Thanks martin. I think a variable (or an option) for which elisp to go to would be the best. Is there any reason not to have that? From rudalics@gmx.at Fri Aug 8 05:02:41 2008 X-Spam-Checker-Version: SpamAssassin 3.2.3-bugs.debian.org_2005_01_02 (2007-08-08) on rzlab.ucr.edu X-Spam-Level: X-Spam-Status: No, score=-5.0 required=4.0 tests=AWL,BAYES_00 autolearn=ham version=3.2.3-bugs.debian.org_2005_01_02 Received: (at 587) by emacsbugs.donarmstrong.com; 8 Aug 2008 12:02:41 +0000 Received: from mail.gmx.net (mail.gmx.net [213.165.64.20]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with SMTP id m78C2bXs005268 for <587@emacsbugs.donarmstrong.com>; Fri, 8 Aug 2008 05:02:38 -0700 Received: (qmail invoked by alias); 08 Aug 2008 12:02:30 -0000 Received: from 62-47-38-210.adsl.highway.telekom.at (EHLO [62.47.38.210]) [62.47.38.210] by mail.gmx.net (mp023) with SMTP; 08 Aug 2008 14:02:30 +0200 X-Authenticated: #14592706 X-Provags-ID: V01U2FsdGVkX1998uZGLWB9/oFNs4rmswPEkUcDB5md3AXx7knIjt 5FSiE7Npl9gq8R Message-ID: <489C3628.3000807@gmx.at> Date: Fri, 08 Aug 2008 14:03:52 +0200 From: martin rudalics User-Agent: Mozilla Thunderbird 1.0 (Windows/20041206) X-Accept-Language: de-DE, de, en-us, en MIME-Version: 1.0 To: "Lennart Borgman (gmail)" CC: 587@debbugs.gnu.org, Bug-Gnu-Emacs Subject: Re: 23.0.60; To source or not to source (from help) References: <489C1757.3060504@gmx.at> <489C2956.1030202@gmail.com> In-Reply-To: <489C2956.1030202@gmail.com> Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit X-Y-GMX-Trusted: 0 X-FuHaFi: 0.66 X-CrossAssassin-Score: 2 > I use the normal > > make install INSTALL_DIR=... I never use that. Are the ".el" files copied as well in that case? >> In this case the following might >> happen: As for C-h f `describe-function-1' will execute >> >> ;; See if lisp files are present where they where installed from. >> (if (not (eq file-name 'C-source)) >> (setq file-name (find-source-lisp-file file-name))) >> >> which sets `file-name' to the ".el" file from the checkout directory >> (because you did compile it there) and installs the corresponding >> reference in the hyperlink. >> >> As for C-h v `describe-variable' does _not_ care whether you compiled in >> another directory and simply goes to the file supplied by `symbol-file'. >> You could try inserting the snipped above in `describe-variable' >> immediately before the line >> >> (if file-name >> >> and see whether it now jumps to the checkout directory instead. > > > Yes, I guess that is correct. Did you verify it? >> Personally, I'd prefer something like the following in both cases: >> >> (unless (or (eq file-name 'C-source) >> (file-exists-p file-name)) >> (setq file-name (find-source-lisp-file file-name))) > > Thanks martin. I think a variable (or an option) for which elisp to go > to would be the best. Is there any reason not to have that? We'd have to do something similar for definitions in the C-sources too. Do I suppose correctly that the C-sources are not copied automatically when you explicitly specify the install directory? I'm too lazy to look into this ... martin From lennart.borgman@gmail.com Fri Aug 8 05:20:17 2008 X-Spam-Checker-Version: SpamAssassin 3.2.3-bugs.debian.org_2005_01_02 (2007-08-08) on rzlab.ucr.edu X-Spam-Level: X-Spam-Status: No, score=-5.7 required=4.0 tests=AWL,BAYES_00, RCVD_IN_DNSWL_LOW autolearn=ham version=3.2.3-bugs.debian.org_2005_01_02 Received: (at 587) by emacsbugs.donarmstrong.com; 8 Aug 2008 12:20:18 +0000 Received: from ch-smtp02.sth.basefarm.net (ch-smtp02.sth.basefarm.net [80.76.149.213]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id m78CKDYi011294 for <587@emacsbugs.donarmstrong.com>; Fri, 8 Aug 2008 05:20:14 -0700 Received: from c83-254-151-176.bredband.comhem.se ([83.254.151.176]:59733 helo=[127.0.0.1]) by ch-smtp02.sth.basefarm.net with esmtp (Exim 4.68) (envelope-from ) id 1KRQx1-0002jP-9a; Fri, 08 Aug 2008 14:20:12 +0200 Message-ID: <489C39F0.50805@gmail.com> Date: Fri, 08 Aug 2008 14:20:00 +0200 From: "Lennart Borgman (gmail)" User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.9) Gecko/20071031 Thunderbird/2.0.0.9 Mnenhy/0.7.5.666 MIME-Version: 1.0 To: martin rudalics CC: 587@debbugs.gnu.org, Bug-Gnu-Emacs Subject: Re: 23.0.60; To source or not to source (from help) References: <489C1757.3060504@gmx.at> <489C2956.1030202@gmail.com> <489C3628.3000807@gmx.at> In-Reply-To: <489C3628.3000807@gmx.at> Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit X-Antivirus: avast! (VPS 080807-0, 2008-08-07), Outbound message X-Antivirus-Status: Clean X-Originating-IP: 83.254.151.176 X-Scan-Result: No virus found in message 1KRQx1-0002jP-9a. X-Scan-Signature: ch-smtp02.sth.basefarm.net 1KRQx1-0002jP-9a 31db8f6c622b947aa64c864cfa53ef1f martin rudalics wrote: > > I use the normal > > > > make install INSTALL_DIR=... > > I never use that. Are the ".el" files copied as well in that case? > > >> In this case the following might > >> happen: As for C-h f `describe-function-1' will execute > >> > >> ;; See if lisp files are present where they where installed from. > >> (if (not (eq file-name 'C-source)) > >> (setq file-name (find-source-lisp-file file-name))) > >> > >> which sets `file-name' to the ".el" file from the checkout directory > >> (because you did compile it there) and installs the corresponding > >> reference in the hyperlink. > >> > >> As for C-h v `describe-variable' does _not_ care whether you > compiled in > >> another directory and simply goes to the file supplied by > `symbol-file'. > >> You could try inserting the snipped above in `describe-variable' > >> immediately before the line > >> > >> (if file-name > >> > >> and see whether it now jumps to the checkout directory instead. > > > > > > Yes, I guess that is correct. > > Did you verify it? I did not look at the details again since I did not have time to fix this. I notice that C-h v takes me to the Emacs install tree I am using and C-h f takes me to the CVS checkout tree where I compiled Emacs. > >> Personally, I'd prefer something like the following in both cases: > >> > >> (unless (or (eq file-name 'C-source) > >> (file-exists-p file-name)) > >> (setq file-name (find-source-lisp-file file-name))) > > > > Thanks martin. I think a variable (or an option) for which elisp to go > > to would be the best. Is there any reason not to have that? > > We'd have to do something similar for definitions in the C-sources too. > Do I suppose correctly that the C-sources are not copied automatically > when you explicitly specify the install directory? I'm too lazy to look > into this ... I have seen no problems with the C sources. I always get to the CVS checkout tree from C-h v,f. I did not even know they could be copied when you do make install. How do you do that? From rudalics@gmx.at Sat Aug 9 05:39:59 2008 X-Spam-Checker-Version: SpamAssassin 3.2.3-bugs.debian.org_2005_01_02 (2007-08-08) on rzlab.ucr.edu X-Spam-Level: X-Spam-Status: No, score=-5.0 required=4.0 tests=AWL,BAYES_00 autolearn=ham version=3.2.3-bugs.debian.org_2005_01_02 Received: (at 587) by emacsbugs.donarmstrong.com; 9 Aug 2008 12:39:59 +0000 Received: from mail.gmx.net (mail.gmx.net [213.165.64.20]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with SMTP id m79Cdthb002714 for <587@emacsbugs.donarmstrong.com>; Sat, 9 Aug 2008 05:39:57 -0700 Received: (qmail invoked by alias); 09 Aug 2008 12:39:49 -0000 Received: from 62-47-34-6.adsl.highway.telekom.at (EHLO [62.47.34.6]) [62.47.34.6] by mail.gmx.net (mp056) with SMTP; 09 Aug 2008 14:39:49 +0200 X-Authenticated: #14592706 X-Provags-ID: V01U2FsdGVkX197yqEjuHJ7ju/SYtN8gWn046T6WHP5evx62OhtqE hdd2ssCYAyVWgP Message-ID: <489D8F7E.5020601@gmx.at> Date: Sat, 09 Aug 2008 14:37:18 +0200 From: martin rudalics User-Agent: Thunderbird 2.0.0.16 (Windows/20080708) MIME-Version: 1.0 To: "Lennart Borgman (gmail)" CC: 587@debbugs.gnu.org Subject: Re: 23.0.60; To source or not to source (from help) References: <489C1757.3060504@gmx.at> <489C2956.1030202@gmail.com> <489C3628.3000807@gmx.at> <489C39F0.50805@gmail.com> In-Reply-To: <489C39F0.50805@gmail.com> Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit X-Y-GMX-Trusted: 0 X-FuHaFi: 0.77 > I did not look at the details again since I did not have time to fix > this. I notice that C-h v takes me to the Emacs install tree I am using > and C-h f takes me to the CVS checkout tree where I compiled Emacs. We can consistently try to go to the compile directory or to the install directory first, whatever people want. A problem with the former approach is that the definition might not be there any more, e.g., after a fresh checkout. That's why I would probably prefer the latter. martin From lennart.borgman@gmail.com Sat Aug 9 05:45:03 2008 X-Spam-Checker-Version: SpamAssassin 3.2.3-bugs.debian.org_2005_01_02 (2007-08-08) on rzlab.ucr.edu X-Spam-Level: X-Spam-Status: No, score=-5.7 required=4.0 tests=AWL,BAYES_00, RCVD_IN_DNSWL_LOW autolearn=ham version=3.2.3-bugs.debian.org_2005_01_02 Received: (at 587) by emacsbugs.donarmstrong.com; 9 Aug 2008 12:45:04 +0000 Received: from ch-smtp02.sth.basefarm.net (ch-smtp02.sth.basefarm.net [80.76.149.213]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id m79Cixro004231 for <587@emacsbugs.donarmstrong.com>; Sat, 9 Aug 2008 05:45:00 -0700 Received: from c83-254-151-176.bredband.comhem.se ([83.254.151.176]:61735 helo=[127.0.0.1]) by ch-smtp02.sth.basefarm.net with esmtp (Exim 4.68) (envelope-from ) id 1KRnoY-0005a3-8G; Sat, 09 Aug 2008 14:44:58 +0200 Message-ID: <489D9146.6040809@gmail.com> Date: Sat, 09 Aug 2008 14:44:54 +0200 From: "Lennart Borgman (gmail)" User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.9) Gecko/20071031 Thunderbird/2.0.0.9 Mnenhy/0.7.5.666 MIME-Version: 1.0 To: martin rudalics CC: 587@debbugs.gnu.org Subject: Re: 23.0.60; To source or not to source (from help) References: <489C1757.3060504@gmx.at> <489C2956.1030202@gmail.com> <489C3628.3000807@gmx.at> <489C39F0.50805@gmail.com> <489D8F7E.5020601@gmx.at> In-Reply-To: <489D8F7E.5020601@gmx.at> Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit X-Antivirus: avast! (VPS 080808-0, 2008-08-08), Outbound message X-Antivirus-Status: Clean X-Originating-IP: 83.254.151.176 X-Scan-Result: No virus found in message 1KRnoY-0005a3-8G. X-Scan-Signature: ch-smtp02.sth.basefarm.net 1KRnoY-0005a3-8G 6bb6c7e2f07e6cf5cde3ea4480662f91 martin rudalics wrote: > > I did not look at the details again since I did not have time to fix > > this. I notice that C-h v takes me to the Emacs install tree I am using > > and C-h f takes me to the CVS checkout tree where I compiled Emacs. > > We can consistently try to go to the compile directory or to the install > directory first, whatever people want. A problem with the former > approach is that the definition might not be there any more, e.g., after > a fresh checkout. That's why I would probably prefer the latter. I would suggest something like this: - A variable to decide where to go - Possibly there should be a separate variable for the src tree - If not possible to go there: * If no other choice then give an error * Otherwise ask user wether to go to the other place (checkout/install) From rudalics@gmx.at Sat Aug 9 06:00:12 2008 X-Spam-Checker-Version: SpamAssassin 3.2.3-bugs.debian.org_2005_01_02 (2007-08-08) on rzlab.ucr.edu X-Spam-Level: X-Spam-Status: No, score=-4.9 required=4.0 tests=AWL,BAYES_00 autolearn=ham version=3.2.3-bugs.debian.org_2005_01_02 Received: (at 587) by emacsbugs.donarmstrong.com; 9 Aug 2008 13:00:12 +0000 Received: from mail.gmx.net (mail.gmx.net [213.165.64.20]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with SMTP id m79D08dZ008717 for <587@emacsbugs.donarmstrong.com>; Sat, 9 Aug 2008 06:00:09 -0700 Received: (qmail invoked by alias); 09 Aug 2008 13:00:02 -0000 Received: from 62-47-34-6.adsl.highway.telekom.at (EHLO [62.47.34.6]) [62.47.34.6] by mail.gmx.net (mp066) with SMTP; 09 Aug 2008 15:00:02 +0200 X-Authenticated: #14592706 X-Provags-ID: V01U2FsdGVkX19CosMtWZhCYlyuK4ydUlAebIUXqJWl2MZMQXx7ys Rr15AutwWlc+Nx Message-ID: <489D9461.5030409@gmx.at> Date: Sat, 09 Aug 2008 14:58:09 +0200 From: martin rudalics User-Agent: Thunderbird 2.0.0.16 (Windows/20080708) MIME-Version: 1.0 To: "Lennart Borgman (gmail)" CC: 587@debbugs.gnu.org Subject: Re: 23.0.60; To source or not to source (from help) References: <489C1757.3060504@gmx.at> <489C2956.1030202@gmail.com> <489C3628.3000807@gmx.at> <489C39F0.50805@gmail.com> <489D8F7E.5020601@gmx.at> <489D9146.6040809@gmail.com> In-Reply-To: <489D9146.6040809@gmail.com> Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit X-Y-GMX-Trusted: 0 X-FuHaFi: 0.79 > I would suggest something like this: > > - A variable to decide where to go An option, I suppose. > - Possibly there should be a separate variable for the src tree Rather not. > - If not possible to go there: > * If no other choice then give an error > * Otherwise ask user wether to go to the other place > (checkout/install) I think asking the user is some kind of overkill, we should make this part of the option - always go to build dir, always go to install dir, prefer build dir, prefer install dir. In any case we have to make sure first that implementing such an option won't violate the feature freeze. martin From lennart.borgman@gmail.com Sat Aug 9 06:02:50 2008 X-Spam-Checker-Version: SpamAssassin 3.2.3-bugs.debian.org_2005_01_02 (2007-08-08) on rzlab.ucr.edu X-Spam-Level: X-Spam-Status: No, score=-5.7 required=4.0 tests=AWL,BAYES_00, RCVD_IN_DNSWL_LOW autolearn=ham version=3.2.3-bugs.debian.org_2005_01_02 Received: (at 587) by emacsbugs.donarmstrong.com; 9 Aug 2008 13:02:50 +0000 Received: from ch-smtp01.sth.basefarm.net (ch-smtp01.sth.basefarm.net [80.76.149.212]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id m79D2kDa010029 for <587@emacsbugs.donarmstrong.com>; Sat, 9 Aug 2008 06:02:48 -0700 Received: from c83-254-151-176.bredband.comhem.se ([83.254.151.176]:62007 helo=[127.0.0.1]) by ch-smtp01.sth.basefarm.net with esmtp (Exim 4.68) (envelope-from ) id 1KRo5l-0003TT-3R; Sat, 09 Aug 2008 15:02:45 +0200 Message-ID: <489D956C.4050207@gmail.com> Date: Sat, 09 Aug 2008 15:02:36 +0200 From: "Lennart Borgman (gmail)" User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.9) Gecko/20071031 Thunderbird/2.0.0.9 Mnenhy/0.7.5.666 MIME-Version: 1.0 To: martin rudalics CC: 587@debbugs.gnu.org Subject: Re: 23.0.60; To source or not to source (from help) References: <489C1757.3060504@gmx.at> <489C2956.1030202@gmail.com> <489C3628.3000807@gmx.at> <489C39F0.50805@gmail.com> <489D8F7E.5020601@gmx.at> <489D9146.6040809@gmail.com> <489D9461.5030409@gmx.at> In-Reply-To: <489D9461.5030409@gmx.at> Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit X-Antivirus: avast! (VPS 080808-0, 2008-08-08), Outbound message X-Antivirus-Status: Clean X-Originating-IP: 83.254.151.176 X-Scan-Result: No virus found in message 1KRo5l-0003TT-3R. X-Scan-Signature: ch-smtp01.sth.basefarm.net 1KRo5l-0003TT-3R 8e3bb4f31ac877ca4be7a754bf99e359 martin rudalics wrote: > > I would suggest something like this: > > > > - A variable to decide where to go > > An option, I suppose. Yes. > > - Possibly there should be a separate variable for the src tree > > Rather not. > > > - If not possible to go there: > > * If no other choice then give an error > > * Otherwise ask user wether to go to the other place > > (checkout/install) > > I think asking the user is some kind of overkill, we should make this > part of the option - always go to build dir, always go to install dir, > prefer build dir, prefer install dir. Sounds good. > In any case we have to make sure > first that implementing such an option won't violate the feature freeze. Currently there is a bug to fix and I believe implementing this might be the best way to fix the bug. From rgm@gnu.org Sat Aug 9 16:53:47 2008 X-Spam-Checker-Version: SpamAssassin 3.2.3-bugs.debian.org_2005_01_02 (2007-08-08) on rzlab.ucr.edu X-Spam-Level: X-Spam-Status: No, score=-7.6 required=4.0 tests=AWL,BAYES_00,MISSING_SUBJECT, NOSUBJECT,RCVD_IN_DNSWL_MED,X_DEBBUGS_NO_ACK autolearn=ham version=3.2.3-bugs.debian.org_2005_01_02 Received: (at control) by emacsbugs.donarmstrong.com; 9 Aug 2008 23:53:47 +0000 Received: from fencepost.gnu.org (fencepost.gnu.org [140.186.70.10]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id m79NriuO015506 for ; Sat, 9 Aug 2008 16:53:46 -0700 Received: from rgm by fencepost.gnu.org with local (Exim 4.67) (envelope-from ) id 1KRyEe-0005sd-Mq; Sat, 09 Aug 2008 19:52:36 -0400 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <18590.11716.657935.988485@fencepost.gnu.org> Date: Sat, 9 Aug 2008 19:52:36 -0400 From: Glenn Morris To: control X-Debbugs-No-Ack: yes merge 587 671 672 673 674 reassign 652 ubuntu merge 607 608 merge 606 609 From monnier@iro.umontreal.ca Mon Aug 11 16:01:47 2008 X-Spam-Checker-Version: SpamAssassin 3.2.3-bugs.debian.org_2005_01_02 (2007-08-08) on rzlab.ucr.edu X-Spam-Level: X-Spam-Status: No, score=-7.5 required=4.0 tests=AWL,BAYES_00,HAS_BUG_NUMBER autolearn=ham version=3.2.3-bugs.debian.org_2005_01_02 Received: (at 587) by emacsbugs.donarmstrong.com; 11 Aug 2008 23:01:48 +0000 Received: from smtp-01.arnet.com.ar (smtp-01.arnet.com.ar [200.45.191.24]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with SMTP id m7BN1cej009466 for <587@emacsbugs.donarmstrong.com>; Mon, 11 Aug 2008 16:01:41 -0700 Received: (qmail 23581 invoked from network); 11 Aug 2008 22:59:46 -0000 Received: from unknown (HELO ceviche.home) (190.30.131.157) by 0 with SMTP; 11 Aug 2008 22:59:46 -0000 Received: by ceviche.home (Postfix, from userid 20848) id 34F5EB406B; Fri, 8 Aug 2008 14:43:03 -0400 (EDT) From: Stefan Monnier To: martin rudalics Cc: 671@debbugs.gnu.org, 587@debbugs.gnu.org, Bug-Gnu-Emacs Subject: Re: bug#671: 23.0.60; To source or not to source (from help) Message-ID: References: <489C1757.3060504@gmx.at> Date: Fri, 08 Aug 2008 14:43:03 -0400 In-Reply-To: <489C1757.3060504@gmx.at> (martin rudalics's message of "Fri, 08 Aug 2008 11:52:23 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-CrossAssassin-Score: 2 > Personally, I'd prefer something like the following in both cases: > (unless (or (eq file-name 'C-source) > (file-exists-p file-name)) > (setq file-name (find-source-lisp-file file-name))) I'd use file-readable-p, but otherwise, it sounds fine, Stefan From cyd@stupidchicken.com Tue Aug 12 12:09:49 2008 X-Spam-Checker-Version: SpamAssassin 3.2.3-bugs.debian.org_2005_01_02 (2007-08-08) on rzlab.ucr.edu X-Spam-Level: X-Spam-Status: No, score=-3.4 required=4.0 tests=AWL,BAYES_00 autolearn=ham version=3.2.3-bugs.debian.org_2005_01_02 Received: (at 587) by emacsbugs.donarmstrong.com; 12 Aug 2008 19:09:49 +0000 Received: from cyd (CYD.MIT.EDU [18.115.2.24]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id m7CJ9kJU026147 for <587@emacsbugs.donarmstrong.com>; Tue, 12 Aug 2008 12:09:47 -0700 Received: by cyd (Postfix, from userid 1000) id 9668357E2EC; Tue, 12 Aug 2008 15:10:16 -0400 (EDT) From: Chong Yidong To: "Lennart Borgman \(gmail\)" Cc: martin rudalics , 587@debbugs.gnu.org Subject: Re: 23.0.60; To source or not to source (from help) Date: Tue, 12 Aug 2008 15:10:16 -0400 Message-ID: <87iqu6uk13.fsf@stupidchicken.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii > > We can consistently try to go to the compile directory or to the > > install directory first, whatever people want. A problem with the > > former approach is that the definition might not be there any more, > > e.g., after a fresh checkout. That's why I would probably prefer > > the latter. > > I would suggest something like this: > > - A variable to decide where to go > - Possibly there should be a separate variable for the src tree > - If not possible to go there: > * If no other choice then give an error > * Otherwise ask user wether to go to the other place > (checkout/install) Let's not introduce any new variables at this point. We can revisit this issue after the release, but I'm not convinced that it's useful to enough people to add variables for controlling this behavior. People who care enough about this can write their own advice. Martin, could you change the trunk to do what you suggested (i.e. checking the install directory first)? Thanks. From cyd@stupidchicken.com Mon Sep 1 07:31:29 2008 X-Spam-Checker-Version: SpamAssassin 3.2.3-bugs.debian.org_2005_01_02 (2007-08-08) on rzlab.ucr.edu X-Spam-Level: X-Spam-Status: No, score=-3.7 required=4.0 tests=AWL,BAYES_00 autolearn=ham version=3.2.3-bugs.debian.org_2005_01_02 Received: (at 587) by emacsbugs.donarmstrong.com; 1 Sep 2008 14:31:29 +0000 Received: from cyd.mit.edu (CYD.MIT.EDU [18.115.2.24]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id m81EVEl4009951; Mon, 1 Sep 2008 07:31:15 -0700 Received: by cyd.mit.edu (Postfix, from userid 1000) id 83DE757E337; Mon, 1 Sep 2008 10:33:29 -0400 (EDT) To: 587@debbugs.gnu.org, 669@debbugs.gnu.org, 690@debbugs.gnu.org Subject: Re: 23.0.60; To source or not to source (from help) From: Chong Yidong Date: Mon, 01 Sep 2008 10:33:29 -0400 Message-ID: <87zlmsndfq.fsf@cyd.mit.edu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-CrossAssassin-Score: 3 Martin Rudalics has checked in his fix (2008-09-01 checkin to trunk). Now closing the bug. From cyd@stupidchicken.com Mon Sep 1 10:29:14 2008 X-Spam-Checker-Version: SpamAssassin 3.2.3-bugs.debian.org_2005_01_02 (2007-08-08) on rzlab.ucr.edu X-Spam-Level: X-Spam-Status: No, score=-3.7 required=4.0 tests=AWL,BAYES_00 autolearn=ham version=3.2.3-bugs.debian.org_2005_01_02 Received: (at control) by emacsbugs.donarmstrong.com; 1 Sep 2008 17:29:14 +0000 Received: from cyd.mit.edu (CYD.MIT.EDU [18.115.2.24]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id m81HTBfN005040 for ; Mon, 1 Sep 2008 10:29:13 -0700 Received: by cyd.mit.edu (Postfix, from userid 1000) id B58D857E337; Mon, 1 Sep 2008 13:31:27 -0400 (EDT) To: control@debbugs.gnu.org Subject: close bugs From: Chong Yidong Date: Mon, 01 Sep 2008 13:31:27 -0400 Message-ID: <871w036ads.fsf@cyd.mit.edu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii close 587 close 669 close 690 thanks From unknown Thu Aug 14 21:50:12 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: $requester Subject: Internal Control Message-Id: bug archived. Date: Tue, 30 Sep 2008 14:24:04 +0000 User-Agent: Fakemail v42.6.9 # A New Hope # A log time ago, in a galaxy far, far away # something happened. # # Magically this resulted in the following # action being taken, but this fake control # message doesn't tell you why it happened # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator