GNU bug report logs - #58665
Indentation in lisp/emacs-lisp/syntax.el is wrong

Previous Next

Full log

Message #21 received at 58665 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Stefan Kangas <stefankangas <at> gmail.com>
Cc: jblandy <at> mozilla.com, 58665 <at> debbugs.gnu.org
Subject: Re: bug#58665: Indentation in lisp/emacs-lisp/syntax.el is wrong
Date: Sun, 03 Sep 2023 13:39:19 +0300

> From: Stefan Kangas <stefankangas <at> gmail.com>
> Date: Sun, 3 Sep 2023 03:21:33 -0700
> Cc: Eli Zaretskii <eliz <at> gnu.org>, 58665 <at> debbugs.gnu.org
> 
> Jim Blandy <jblandy <at> mozilla.com> writes:
> 
> > This code changes almost never. It's been like that since 2016. It
> > doesn't make sense to let it sit there with formatting that obscures
> > the structure of the code.
> >
> > On Thu, Oct 20, 2022 at 10:57 AM Eli Zaretskii <eliz <at> gnu.org> wrote:
> >
> >  > From: Jim Blandy <jblandy <at> mozilla.com>
> >  > Date: Thu, 20 Oct 2022 10:23:30 -0700
> >  >
> >  > 2022-10-20  Jim Blandy  <jimb <at> red-bean.com>
> >  >
> >  >         * lisp/emacs-lisp/syntax.el: Fix indentation in `syntax-ppss'.
> >
> >  Thanks, but we don't like pure-whitespace changes.  We fix these
> >  issues when we change code around the places with wrong indentation.
> 
> I agree that we should avoid making whitespace-only changes in general.
> Jim makes the point that readability counts.  He also points out that
> this code changes so infrequently that we do not need to be overly
> worried about any annoying merge conflicts.  I think these are valid
> points.
> 
> So on balance, I'd be willing to make an exception and take this patch.
> If Eli is still not convinced, I think it would be better to close this
> bug and move on.  I think we can all agree it's not worth spending
> energy discussing it further.

If you think this change could be useful, I won't object applying it.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.