GNU bug report logs - #58660
[PATCH 0/4] Minor tweaks of etc/teams.scm

Previous Next

Package: guix-patches;

Reported by: zimoun <zimon.toutoune <at> gmail.com>

Date: Thu, 20 Oct 2022 13:23:02 UTC

Severity: normal

Tags: moreinfo, patch

Done: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>

Bug is archived. No further changes may be made.

Full log

Message #59 received at 58660 <at> debbugs.gnu.org (full text, mbox):

From: zimoun <zimon.toutoune <at> gmail.com>
To: Mathieu Othacehe <othacehe <at> gnu.org>
Cc: 58660 <at> debbugs.gnu.org
Subject: Re: [bug#58660] [PATCH v2 1/3] etc: teams: Add 'show' subcommand.
Date: Mon, 21 Nov 2022 17:00:52 +0100

Hi Mathieu,

On Fri, 18 Nov 2022 at 18:29, Mathieu Othacehe <othacehe <at> gnu.org> wrote:

> This procedure is starting to get a little complex. We could put the
> above is a sub-procedure called "print-team".

I will try to revamp for a v3.

>> +       (sort
>> +        (hash-map->list (lambda (key value) value) %teams)
>> +        (lambda (team1 team2)
>> +          (string<? (symbol->string (team-id team1))
>> +                    (symbol->string (team-id team2))))))))
>
> That could be in a variable called %sorted-teams.

This had been introduced by 18fb7c0f3078216bf4fc865d86b3be76ddc68414.
Indeed, it could be extracted; part of the revamp.


Cheers,
simon
This bug report was last modified 1 year and 349 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.