Subject: Re: [bug#58660] [PATCH 1/4] etc: teams: Improve scope display.

From: "(" <[email-masked]>
Date: Sat, 05 Nov 2022 12:18:12 +0000

Heya,

On Thu Oct 20, 2022 at 2:28 PM BST, zimoun wrote:
> * etc/teams.scm.in (<regexp*>): New record type.
> (make-regexp*, regexp-exec*): New procedures.
> (python, haskell, julia, java, emacs, rust, core, translations, installer,
> home): Use it.
> (find-team-by-scope): Use it.
> (list-teams): Use it and sort scope files.

> @@ -553,7 +573,13 @@ (define width* (%text-width))
> +               (scope (format #f "scope: ~{~s ~}~%"
> +                              (sort
> +                               (map (match-lambda
> +                                      ((? regexp*? rx*) (regexp-pattern* rx*))
> +                                      ((? string? str) str))
> +                                    scope)
> +                               string<=?)))))

Would it not be better to, instead of displaying the actual regex
itself, display the files that match the regex, and separate the files
onto separate lines? Eg, rather than,

  scope: "^gnu/packages/julia(-.+|).scm$" "guix/build/julia-build-system.scm" "guix/build-system/julia.scm"

we could display,

  scope:
  + gnu/packages/julia.scm
  + gnu/packages/julia-jll.scm
  + gnu/packages/julia-xyz.scm
  + guix/build/julia-build-system.scm
  + guix/build-system/julia.scm

I find this to be much clearer.

    -- (