GNU bug report logs - #58604
[PATCH] Fix x11 with i18n build

Previous Next

Package: emacs;

Reported by: Randy Taylor <dev <at> rjt.dev>

Date: Tue, 18 Oct 2022 01:47:01 UTC

Severity: normal

Tags: patch

Done: Stefan Kangas <stefankangas <at> gmail.com>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 58604 in the body.
You can then email your comments to 58604 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox

Report forwarded to bug-gnu-emacs <at> gnu.org:
bug#58604; Package emacs. (Tue, 18 Oct 2022 01:47:01 GMT) Full text and rfc822 format available.
Acknowledgement sent to Randy Taylor <dev <at> rjt.dev>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs <at> gnu.org. (Tue, 18 Oct 2022 01:47:01 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Randy Taylor <dev <at> rjt.dev>
To: "bug-gnu-emacs <at> gnu.org" <bug-gnu-emacs <at> gnu.org>
Subject: [PATCH] Fix x11 with i18n build
Date: Tue, 18 Oct 2022 01:46:09 +0000

[Message part 1 (text/plain, inline)]
With no toolkit, no xrandr, no xinput2 and having i18n, the dpyinfo variable is not created but is used later on, causing the build to fail.

The attached patch fixes the problem.

FYI I should have copyright assignment on file.
[Message part 2 (text/html, inline)]
[0001-src-xterm.c-mark_xterm-Fix-x11-with-i18n-build.patch (text/x-patch, attachment)]
Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#58604; Package emacs. (Tue, 18 Oct 2022 11:02:02 GMT) Full text and rfc822 format available.

Message #8 received at 58604 <at> debbugs.gnu.org (full text, mbox):

From: Po Lu <luangruo <at> yahoo.com>
To: Randy Taylor <dev <at> rjt.dev>
Cc: 58604 <at> debbugs.gnu.org
Subject: Re: bug#58604: [PATCH] Fix x11 with i18n build
Date: Tue, 18 Oct 2022 19:00:45 +0800

Randy Taylor <dev <at> rjt.dev> writes:

> With no toolkit, no xrandr, no xinput2 and having i18n, the dpyinfo variable is not created but is used later on, causing the build to fail.
>
> The attached patch fixes the problem.
>
> FYI I should have copyright assignment on file.

Thanks.  Would someone please confirm either that, or that you are
currently within the 15-line copyright assignment exemption?
Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#58604; Package emacs. (Tue, 18 Oct 2022 14:56:02 GMT) Full text and rfc822 format available.

Message #11 received at 58604 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Po Lu <luangruo <at> yahoo.com>
Cc: 58604 <at> debbugs.gnu.org, dev <at> rjt.dev
Subject: Re: bug#58604: [PATCH] Fix x11 with i18n build
Date: Tue, 18 Oct 2022 17:55:23 +0300

> Cc: 58604 <at> debbugs.gnu.org
> Date: Tue, 18 Oct 2022 19:00:45 +0800
> From:  Po Lu via "Bug reports for GNU Emacs,
>  the Swiss army knife of text editors" <bug-gnu-emacs <at> gnu.org>
> 
> Randy Taylor <dev <at> rjt.dev> writes:
> 
> > With no toolkit, no xrandr, no xinput2 and having i18n, the dpyinfo variable is not created but is used later on, causing the build to fail.
> >
> > The attached patch fixes the problem.
> >
> > FYI I should have copyright assignment on file.
> 
> Thanks.  Would someone please confirm either that, or that you are
> currently within the 15-line copyright assignment exemption?

Assignment is on file; confirmed.
Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#58604; Package emacs. (Wed, 19 Oct 2022 00:55:01 GMT) Full text and rfc822 format available.

Message #14 received at 58604 <at> debbugs.gnu.org (full text, mbox):

From: Po Lu <luangruo <at> yahoo.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 58604 <at> debbugs.gnu.org, dev <at> rjt.dev
Subject: Re: bug#58604: [PATCH] Fix x11 with i18n build
Date: Wed, 19 Oct 2022 08:54:08 +0800

Eli Zaretskii <eliz <at> gnu.org> writes:

> Assignment is on file; confirmed.

OK, I will install this now.
Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#58604; Package emacs. (Wed, 19 Oct 2022 01:09:01 GMT) Full text and rfc822 format available.

Message #17 received at 58604 <at> debbugs.gnu.org (full text, mbox):

From: Randy Taylor <dev <at> rjt.dev>
To: Po Lu <luangruo <at> yahoo.com>
Cc: 58604 <at> debbugs.gnu.org, Eli Zaretskii <eliz <at> gnu.org>
Subject: Re: bug#58604: [PATCH] Fix x11 with i18n build
Date: Wed, 19 Oct 2022 01:08:03 +0000

On Tuesday, October 18th, 2022 at 20:54, Po Lu <luangruo <at> yahoo.com> wrote:
> OK, I will install this now.

Thanks!
Reply sent to Stefan Kangas <stefankangas <at> gmail.com>:
You have taken responsibility. (Fri, 11 Nov 2022 13:29:03 GMT) Full text and rfc822 format available.
Notification sent to Randy Taylor <dev <at> rjt.dev>:
bug acknowledged by developer. (Fri, 11 Nov 2022 13:29:03 GMT) Full text and rfc822 format available.

Message #22 received at 58604-done <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefankangas <at> gmail.com>
To: Po Lu <luangruo <at> yahoo.com>
Cc: 58604-done <at> debbugs.gnu.org, dev <at> rjt.dev, Eli Zaretskii <eliz <at> gnu.org>
Subject: Re: bug#58604: [PATCH] Fix x11 with i18n build
Date: Fri, 11 Nov 2022 05:28:11 -0800

Po Lu <luangruo <at> yahoo.com> writes:

> Eli Zaretskii <eliz <at> gnu.org> writes:
>
>> Assignment is on file; confirmed.
>
> OK, I will install this now.

This was installed as 620f18c489ff9ce3d0a4afe04d438a1bc0525e73.

It seems the bug was left opened, closing now.
bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Sat, 10 Dec 2022 12:24:05 GMT) Full text and rfc822 format available.
This bug report was last modified 2 years and 249 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.