From unknown Thu Jun 19 14:26:33 2025 X-Loop: help-debbugs@gnu.org Subject: bug#58596: 29.0.50; [PATCH] Fix memory leak when loading Tree-sitter language definitions Resent-From: Daniel =?UTF-8?Q?Mart=C3=ADn?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 17 Oct 2022 22:56:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 58596 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: 58596@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.166604731430062 (code B ref -1); Mon, 17 Oct 2022 22:56:02 +0000 Received: (at submit) by debbugs.gnu.org; 17 Oct 2022 22:55:14 +0000 Received: from localhost ([127.0.0.1]:50395 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1okZ0s-0007oo-5P for submit@debbugs.gnu.org; Mon, 17 Oct 2022 18:55:14 -0400 Received: from lists.gnu.org ([209.51.188.17]:38930) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1okZ0q-0007oe-CY for submit@debbugs.gnu.org; Mon, 17 Oct 2022 18:55:12 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:57512) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1okZ0q-0001IB-7H for bug-gnu-emacs@gnu.org; Mon, 17 Oct 2022 18:55:12 -0400 Received: from sonic313-14.consmr.mail.bf2.yahoo.com ([74.6.133.124]:36636) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1okZ0n-000163-K9 for bug-gnu-emacs@gnu.org; Mon, 17 Oct 2022 18:55:12 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.es; s=s2048; t=1666047305; bh=mmyYlxUVEHpQiJOAcPfC0dN8lxh8qkc3KI0ZQz5z9+I=; h=From:To:Subject:Date:References:From:Subject:Reply-To; b=o+mDXneUYMJgEAf7ci8/+mDhrah8ZIy1vM10eWcN8lq+W+tyPEpxCXeNpxFB9qXzvg/4Q54uT7vS5AfH3RqpP+SYFrbclVL4MHQwWgZs2R0+DIaPuZbQ8sF2kXsPboKXnEXG/J96y/GGBK52huJ4TbVwLmfHMCxeJAdLRjq9jQH6ZaiK1wM8tIMX019YRcErX7m3O1CNltGAnokrSRk7npB/Fd+u2bIQkCCYfJmnWA5gc/xPheUaUXvWrndqgxRMsuH8JVgyyJqZ6uOr1QjQIE0LDk2tyyXhokQrfXJu5zPORDx/eOf/S4wycxirHXaZ2TAqypg+57czGwI9odNTvg== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1666047305; bh=Bk73Fa6pldYHsTLpaDWk9GTTg6vJlLqAPDJmsnVpKwS=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=hkgv4dc47YM9EQucXqNETfpTFRFbSxhlgr3YCPPANN8FH5p4agIztUrN1K6Cb/Fd3Sv02cmUl5xiDPeb6WEOidLrvX15tp1hLCQIwky3AZ2G/NcAVOfQVbMnbLXhAmfM2Cd2kd4WoXUzddQOV9O4XVdYhemDQJOx2iVgBfFqa5/RcrGrJ27LKOIEpnXehspt5bLxYRAff8mXrksanwQxLVLeeNHpnUF3bsRdT0wGP9hGNwlwXy6A0VMlC08w5bPNse3Zwzyr2sTXy8mEOhOOjoNVXNJ/h93Iigska+mHbD+aEK39DwY8ULx6H3KKTi81hfDxKyKlp2gj38m8lQ0axA== X-YMail-OSG: WRivxIsVM1lkduIW8v_iUn9znKkBLviRR_6ki.9USoLTskePYVVJTwTa1Sk84bk YhPF99THD2Deqnh8umo5FPgGSUBdIHpVwppi_iSc_xHQEBSOop4Hn9tfqgRHq07g8Xfj7k03ZE58 RVgTG.C6PJuL0cO50IbTyxVRXYgVWiwuGWZAFI5Q.xkhohYMB1yDxmbeMqYe7csNL5ZhJkhfnof0 3rVAWng8wublg69TxphmA8AXea5PqA3MMnUl8zMCQXLOWS8CAeeMhIZUEKTBySEKqTBC2Gj_d15j amX3stqvLLo2.K4UMgiz_yOrWGnkbIAZ37HOgELlxvUW6Qu3uLYBzt1jjHC1kF4GeXV_2tHUlNMP 0ia_fqyTLDUs6YBrPE5Hk1zZOHZ6zZOlC9aC4pzdTDnpxrzFHsDCnlhctxFSCWsnYYlf2KYVgzC0 s_OawKL15ASf73H5ySllKSExj5ncAatWRywjSeHlAhA0LcwELg8n2c5fZCYezlsCAEMXzkcxuCB1 RHCcANS9YkBo2A15EV3MteaU976OSFkIOsZdUWiRd6ZTV9fnsxIb9WfT_ZAs490iTABE5irdoDUO 3OsW08DvVFdWAzekW4pL1mVy03S05Puy2DMpgl56Ch8arSyGlVik51XwSmLeKgDhPaDTvmjWHIcZ KmjRsriS__wN3gJffW3ce6r5h0qd3OgegwqF_rPBwpnCoBhWUS5NBy9V2_8NxmD6kjTpOzir.8PE E5hvEnWak3bvyIRi_P9yNySji3bmhgWSz.Qd3H2RtzjqMz3_QBNQHGte8Q..6rmBG_s6jSNJf58I ThEor0A01cLi_hrxoFIRZGORB4hbrAlb0YTdPOGdTIGbATuU4yIY.P25xJ9KGbPh_C0JVRBYPSJ1 LKp_j7eB5AUowmpuhfiyDdQpunJdMMPMp6nZKMjUKShVw8z3u3CKkUj6AW.XbOKJ9vbQ5bHMjT0w OH3pIIXyOBOA30KWvZwnTFZSR9ls.jcokzFXNkEHD8uhD4ltoGuKoXXa6bR6XR65QKDLxNA9hdL3 T5WsdW5VMMCefDG2GjWn2HWjSq38gNYpFFjsKI6uQkXzE6M0EgAsqGsDrJbr4wYM8eDoYYrlVgAq BbDQYhrlwR9uWPkw6PIyou5_BCrS0K_itDhRo5yVFkXqoJJ4vrW5KZ3uh444TnEIVFwmxhaYHeli .6IeNiX9HMvQxelKVLRtz_LLHgkbijDihf6xdgNvwmEDphnxk8g2BKwZAeFTAOvnWfglCOQ1GTxQ 3yyRutBXQNfNkqoMNsLn_y8Kexx5nKAllePMKZFpUzDzxwwa9Fg11O4zO5dJpXXgRPwkJmMg0lSq ehLEaJimL5YiiEvNE5qH5lREmQzzvVYbY6JDpkir_QaLgr1gl0Ye_pMFKOe2VYc3Dx.0fM67kvjk fTSIzZ9fm_EjLEQoUYA_I0n3YxCOioYGiRYQrHsYdvL9ADJCmEBYLcVeX.nR.gaf0pYq5iiqnDOr jhpaBm8ox62qRQUE4YcqFQ9tQdLbY8vFGJWK2xGgxJG_7b2j5o2fBcYj2tWJksuIriC.Ksw0NMnj M9OZgTl7PIBgJVUHsFdZto5.rGMt4.ZIPOzri59FRDQ7_MQXiyk7KavR1sP0iynS_xqyBmMySAej gthwNUzho7DecU7YZAodNqGeXfPNCvCgeVos2zyYLJmHp3upGe7wGPy5vYYcEPyt4C4D7atPsb3N wzSViNoTye7J64BwWTmVlx4Zxo7K5fA1EfJGnhXrnZ.wYBKpo_bDULwPVhtCaP5EEIVMnoG.Xvwe 9_aYolfaZPVRwq6e_CgS7K4tymwh47_YyH_iNEvY1NYn_PRiMmPHDpGF59Qr5TZSLJbtiDpQTdP4 ikcFRWhm8WeF840l_VtfNdO3S9c6mL5RnvovUrfGCRZN_.MhlFp.sGp0188f8pKmbdWXZTVbUi1k ..L61jZ.Ry2BDsVeDstc- X-Sonic-MF: Received: from sonic.gate.mail.ne1.yahoo.com by sonic313.consmr.mail.bf2.yahoo.com with HTTP; Mon, 17 Oct 2022 22:55:05 +0000 Received: by hermes--production-ir2-6c65697d7-wrvzc (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 265626df8bc41aad5d671dc45ed7183c; Mon, 17 Oct 2022 22:54:59 +0000 (UTC) From: Daniel =?UTF-8?Q?Mart=C3=ADn?= Date: Tue, 18 Oct 2022 00:54:57 +0200 Message-ID: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" References: X-Mailer: WebService/1.1.20740 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Content-Length: 3016 Received-SPF: pass client-ip=74.6.133.124; envelope-from=mardani29@yahoo.es; helo=sonic313-14.consmr.mail.bf2.yahoo.com X-Spam_score_int: -4 X-Spam_score: -0.5 X-Spam_bar: / X-Spam_report: (-0.5 / 5.0 requ) BAYES_00=-1.9, DKIM_ADSP_CUSTOM_MED=0.001, DKIM_INVALID=0.1, DKIM_SIGNED=0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, NML_ADSP_CUSTOM_MED=0.9, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) --=-=-= Content-Type: text/plain I'm instrumenting the Tree-sitter branch to make sure there's no glaring memory issues like leaks or undefined behavior. I've found that the function treesit_load_language leaks a few bytes each time a language is loaded. To fix the bug, I've simplified a bit the logic that loads the dynamic library, to avoid the string duplication that was leaking, and removed a loop that I think it's not really necessary (that'll save us a few CPU cycles). Please check that I've not made any crucial mistake, and feel free to merge it if you think it's a good patch. Thanks. --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-Fix-memory-leak-when-loading-Tree-sitter-language-de.patch >From fbe2b320e4e41cd8a522bb4b56c47e6509d26d08 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Daniel=20Mart=C3=ADn?= Date: Tue, 18 Oct 2022 00:41:15 +0200 Subject: [PATCH] Fix memory leak when loading Tree-sitter language definitions * src/treesit.c (treesit_load_language): Simplify and avoid strdup call. (treesit_symbol_to_c_name): Remove now unused function. --- src/treesit.c | 21 +++------------------ 1 file changed, 3 insertions(+), 18 deletions(-) diff --git a/src/treesit.c b/src/treesit.c index 8417b3bb1c..1e0694f84b 100644 --- a/src/treesit.c +++ b/src/treesit.c @@ -429,18 +429,6 @@ treesit_initialize (void) /*** Loading language library */ -/* Translates a symbol treesit- to a C name - treesit_. */ -static void -treesit_symbol_to_c_name (char *symbol_name) -{ - for (int idx = 0; idx < strlen (symbol_name); idx++) - { - if (symbol_name[idx] == '-') - symbol_name[idx] = '_'; - } -} - static bool treesit_find_override_name (Lisp_Object language_symbol, Lisp_Object *name, Lisp_Object *c_symbol) @@ -496,10 +484,7 @@ treesit_load_language (Lisp_Object language_symbol, Lisp_Object lib_base_name = concat2 (build_pure_c_string ("libtree-sitter-"), symbol_name); Lisp_Object base_name = - concat2 (build_pure_c_string ("tree-sitter-"), symbol_name); - /* FIXME: The result of strdup leaks memory in some cases. */ - char *c_name = strdup (SSDATA (base_name)); - treesit_symbol_to_c_name (c_name); + concat2 (build_pure_c_string ("tree_sitter_"), symbol_name); /* Override the library name and C name, if appropriate. */ Lisp_Object override_name; @@ -510,7 +495,7 @@ treesit_load_language (Lisp_Object language_symbol, if (found_override) { lib_base_name = override_name; - c_name = SSDATA (override_c_name); + base_name = override_c_name; } /* Now we generate a list of possible library paths. */ @@ -560,7 +545,7 @@ treesit_load_language (Lisp_Object language_symbol, /* Load TSLanguage. */ dynlib_error (); TSLanguage *(*langfn) (void); - langfn = dynlib_sym (handle, c_name); + langfn = dynlib_sym (handle, SSDATA (base_name)); error = dynlib_error (); if (error != NULL) { -- 2.34.1 --=-=-=-- From unknown Thu Jun 19 14:26:33 2025 X-Loop: help-debbugs@gnu.org Subject: bug#58596: 29.0.50; [PATCH] Fix memory leak when loading Tree-sitter language definitions References: In-Reply-To: Resent-From: Yuan Fu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 27 Oct 2022 23:40:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58596 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Daniel =?UTF-8?Q?Mart=C3=ADn?= Cc: 58596@debbugs.gnu.org Received: via spool by 58596-submit@debbugs.gnu.org id=B58596.166691396027035 (code B ref 58596); Thu, 27 Oct 2022 23:40:02 +0000 Received: (at 58596) by debbugs.gnu.org; 27 Oct 2022 23:39:20 +0000 Received: from localhost ([127.0.0.1]:59703 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ooCT1-00071z-PT for submit@debbugs.gnu.org; Thu, 27 Oct 2022 19:39:20 -0400 Received: from mail-pj1-f44.google.com ([209.85.216.44]:38549) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ooCT0-00071m-2u for 58596@debbugs.gnu.org; Thu, 27 Oct 2022 19:39:18 -0400 Received: by mail-pj1-f44.google.com with SMTP id l22-20020a17090a3f1600b00212fbbcfb78so8219524pjc.3 for <58596@debbugs.gnu.org>; Thu, 27 Oct 2022 16:39:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:cc:date:message-id:subject:mime-version :content-transfer-encoding:from:from:to:cc:subject:date:message-id :reply-to; bh=he4U5yJjDFQluXy/E4QKgHUWoykFfiThnCWO/qqtc68=; b=IH/nbeZlalThfPrb91OFsSke9Hxo+0KXimb0I473tZCgIrrTzAJlfYABpYgDL6ShwU QDQ8bO51CEjmrfn9qX5WBU4tFdqyn4HgOfD6hrApBVn8vEJ80Kuvl/oghaLB0UfnjLnb jM2lB2wQcAofiGM/Z3fePQOaycDS4XBiP1oJ8+Rz69Z5XwSLBDNJ5eUKhwCNL4/je0eL zURW9Vs/8FdLyc/VdCElPWY5E+lno5guQHsxORkak/opRc8qiADzoY+si8eYvyKFBkeQ DW6Xz7ElAyhORIikuQd8PhsDgHT0LEdvbA+Os7y9AizOpwz8C5WOkWCUFtUDCWzN7EqN iKzA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:cc:date:message-id:subject:mime-version :content-transfer-encoding:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=he4U5yJjDFQluXy/E4QKgHUWoykFfiThnCWO/qqtc68=; b=6uMaGKDz+cG5ut+HrLGm1rk48QChrafSE1t95/R3wfQi/0OiSMCvt9IiM1Zs00Vm8q nsbsrJkpklzjW+WMpCrX24tUjwoAmX2pkC+BZwVtzN1cdDRSaMrpvYh1MNz1F5Qe0I/1 wylN1hNeSCb12LxHa+PtQCrf7j8inJVkdddtJ6wbBfujBoXZYqV9EhZGEToQdqaOXQ5O YciHM4Th+QUZuNt6Hc1Q0ADgg/mzOdW9/VXLiLFturROmPFWRHdLBO7aqfwfI6cw6Uky hBvZDRpIhEPpu+xP2SVg1hOdR7NRs8HN/29t5Xg8fwebgO50ZHY76DRy1Yb5SJ400x9L JGLQ== X-Gm-Message-State: ACrzQf1bLgx/qhO2EWLbJPWPDqDgRjL7/vmRq4v6KwQ7t5rGE4x/jOvv ktBXDOZ3SGfdQ8VYb+0vsgA= X-Google-Smtp-Source: AMsMyM6j7FYcRDPDD1MTCDpNzRQ5bQnCnQXljFkti9EOaGA+0aUjWBBcd8cYXtJEQCPGd/0pXf10jw== X-Received: by 2002:a17:903:2285:b0:185:44df:d916 with SMTP id b5-20020a170903228500b0018544dfd916mr51935523plh.120.1666913952173; Thu, 27 Oct 2022 16:39:12 -0700 (PDT) Received: from smtpclient.apple ([137.110.46.209]) by smtp.gmail.com with ESMTPSA id k17-20020a170902c41100b001837463f654sm1743669plk.251.2022.10.27.16.39.11 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 27 Oct 2022 16:39:11 -0700 (PDT) From: Yuan Fu Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.1\)) Message-Id: <95784A3C-B2F1-415E-94B2-F08B2837AF31@gmail.com> Date: Thu, 27 Oct 2022 16:39:10 -0700 X-Mailer: Apple Mail (2.3696.120.41.1.1) X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Daniel Mart=C3=ADn writes: > I'm instrumenting the Tree-sitter branch to make sure there's no = glaring > memory issues like leaks or undefined behavior. I've found that the > function treesit_load_language leaks a few bytes each time a language = is > loaded. > > To fix the bug, I've simplified a bit the logic that loads the dynamic > library, to avoid the string duplication that was leaking, and removed = a > loop that I think it's not really necessary (that'll save us a few CPU > cycles). > > Please check that I've not made any crucial mistake, and feel free to > merge it if you think it's a good patch. > > Thanks. > Sorry! I just see this. I believe I fixed the memory leak in trunk. The purpose for treesit_symbol_to_c_name is to transform not dashes in tree-sitter, but dashes in languages names, eg, c-sharp. So we do need that. Thank you so much on working on this though! If you don=E2=80=99t mind, please have a look at the revised code and = see if it fixes the memory leak. Yuan >>=46rom fbe2b320e4e41cd8a522bb4b56c47e6509d26d08 Mon Sep 17 00:00:00 = 2001 > From: =3D?UTF-8?q?Daniel=3D20Mart=3DC3=3DADn?=3D > Date: Tue, 18 Oct 2022 00:41:15 +0200 > Subject: [PATCH] Fix memory leak when loading Tree-sitter language = definitions > > * src/treesit.c (treesit_load_language): Simplify and avoid strdup > call. > (treesit_symbol_to_c_name): Remove now unused function. > --- > src/treesit.c | 21 +++------------------ > 1 file changed, 3 insertions(+), 18 deletions(-) > > diff --git a/src/treesit.c b/src/treesit.c > index 8417b3bb1c..1e0694f84b 100644 > --- a/src/treesit.c > +++ b/src/treesit.c > @@ -429,18 +429,6 @@ treesit_initialize (void) > =0C > /*** Loading language library */ > =20 > -/* Translates a symbol treesit- to a C name > - treesit_. */ > -static void > -treesit_symbol_to_c_name (char *symbol_name) > -{ > - for (int idx =3D 0; idx < strlen (symbol_name); idx++) > - { > - if (symbol_name[idx] =3D=3D '-') > - symbol_name[idx] =3D '_'; > - } > -} > - > static bool > treesit_find_override_name (Lisp_Object language_symbol, Lisp_Object = *name, > Lisp_Object *c_symbol) > @@ -496,10 +484,7 @@ treesit_load_language (Lisp_Object = language_symbol, > Lisp_Object lib_base_name =3D > concat2 (build_pure_c_string ("libtree-sitter-"), symbol_name); > Lisp_Object base_name =3D > - concat2 (build_pure_c_string ("tree-sitter-"), symbol_name); > - /* FIXME: The result of strdup leaks memory in some cases. */ > - char *c_name =3D strdup (SSDATA (base_name)); > - treesit_symbol_to_c_name (c_name); > + concat2 (build_pure_c_string ("tree_sitter_"), symbol_name); > =20 > /* Override the library name and C name, if appropriate. */ > Lisp_Object override_name; > @@ -510,7 +495,7 @@ treesit_load_language (Lisp_Object = language_symbol, > if (found_override) > { > lib_base_name =3D override_name; > - c_name =3D SSDATA (override_c_name); > + base_name =3D override_c_name; > } > =20 > /* Now we generate a list of possible library paths. */ > @@ -560,7 +545,7 @@ treesit_load_language (Lisp_Object = language_symbol, > /* Load TSLanguage. */ > dynlib_error (); > TSLanguage *(*langfn) (void); > - langfn =3D dynlib_sym (handle, c_name); > + langfn =3D dynlib_sym (handle, SSDATA (base_name)); > error =3D dynlib_error (); > if (error !=3D NULL) > { From unknown Thu Jun 19 14:26:33 2025 X-Loop: help-debbugs@gnu.org Subject: bug#58596: 29.0.50; [PATCH] Fix memory leak when loading Tree-sitter language definitions Resent-From: Daniel =?UTF-8?Q?Mart=C3=ADn?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 28 Oct 2022 19:50:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58596 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Yuan Fu Cc: 58596@debbugs.gnu.org Received: via spool by 58596-submit@debbugs.gnu.org id=B58596.166698658510375 (code B ref 58596); Fri, 28 Oct 2022 19:50:01 +0000 Received: (at 58596) by debbugs.gnu.org; 28 Oct 2022 19:49:45 +0000 Received: from localhost ([127.0.0.1]:34321 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ooVMO-0002hH-K1 for submit@debbugs.gnu.org; Fri, 28 Oct 2022 15:49:45 -0400 Received: from sonic301-22.consmr.mail.ir2.yahoo.com ([77.238.176.99]:36585) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ooVMH-0002gk-7S for 58596@debbugs.gnu.org; Fri, 28 Oct 2022 15:49:40 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.es; s=s2048; t=1666986570; bh=bWBrCRzlhCnpLtcPP8BhjJ5KlRFC0WQsElpv+/9oHU4=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From:Subject:Reply-To; b=brZqO9Dpy5ob/JhBFfkTq33m8/Fcyhz7NSxYyfXgCaU4r7HTVwpXpES4FDJcXXd4L1gp/9SQ0zEndfTBLgHiqyp3sKe7rZ3DMO4G2gPH6pFRYk59Nh64bPvQo6Dyipyg2sJjl+BYY68oTTz3JCjAzWwnF03J6QMOW2RmGe0GnOQDyO3cShWVqvt4dqu4aPxPxFgFmI5kd5sj5EPfMle0vskaSyz8bAYp1k2cBB+qqJHhlvFcJar+Jcb0TM7MfQLqTH1s4xJgP8dooMnF7z6CUW5FsWfMxrOjJQmFEaMkPW5/fEnV4UzcfqRZXWW5ZyFSr4w7Zo6e4LQ1uROy4w6W5w== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1666986570; bh=nYcBuMH05U7TJBbuh2hd+YpwBrsSoqyqpS1eOUFKgWR=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=Is8pYsyRwSPgotUrHAxaSSIlNfKPJpgpVQKrGJeUGXtR9dsYw/amG4SH+aTY892pY/sVZOT1PyAdFCq4OVEg+1C7lXsZuAGbd9MbdhVKwq0ChdBHIM3k4aaAuCPmFK4GtFdE10di5ZIfOJPtlazR3xZuOzLMWVVTOiWxq0m8uPbkWdG+gvhTZAlf5LYIiV8K/BbUHJ7cV0PdosFpymDiybPO9H9DSkmLgPzHOQEGgB5TfQUryTa+Wej+x1LHGWP/fSSa+cMDhQh08Ap04cbXNKaDWaypzBMjCJ7IrMH4L4WEKxfeaBR5eygDqvMcgUU42g/ZKuuRV/C6XpVKJvM6ng== X-YMail-OSG: afgTMRkVM1ndzGgnUIPpL71_kKPHSD8.jT0q9yj_FBhT42Hs_NgZtM0sjPIPsNq YyGxXcXzNC4FElz8tCMWBzZDDYRqj4m3HYhScy4rysBAs88ghEi8mjM88QEwDOiIdrowmGDeGMll NxkSm48V5j.2qB3LGhZXsxO.GMKzy85Uk.KC_K50Oapb_ispC9A3FTTyAYtSxAaY_kFwOhu6AoNq MoMZjfTcCOj_ZT2dkJreVSkSCSp.tR5uCwz7Jvn7LrKamNfRkv7qK0IPHyj1evFhTjW3umd8XwnI jbW4MT9d0VckCtPWqIzgpft.cEt83NnU25_423cZ4gj4eOmBTvKYUowB6JUYkjpU8adpbmpr5Xmc RTxWWijWJnVxPT.wjNj7PpjQE6TZqkhxv.dbv9MQAmAANkxfjoz7JOniJMbQinkrYrXYNIdl1h9T LHGhIiu9Hqu588QlperAZ8iEsuP.uM4GUOndIcDFtRoqvjgAScKHzEjkXvgHmUDyWlhtx6osgFk3 Z8OubW7aNpUG.EYwGzo_sBGx0vhjSc7F9C54AiqZnLmuamiOfZQC6chNUc2ZX0pxIX0LZay3vVhQ Z5RG4cFzh4OsMidhyuatcMAwXx4JRzaSZ_ljupSN3OAeyx0lMwyX4pDDvvVHAdaqaaQSmD6jImt1 1ZrlsW_9bDu5gx3PLP4HAq79CAeMyyoJI5Wn7rU5OyPEx_lglHGLIDvPmwMb_S3zYx_lI5FzqRhN yKRtZt3SugjHXqV5WpEneoN3EtlTKxnHU40HVzlBzGrp5NSL4uOq0Du2.zLth_Q82CJyvsnm3mif 0eOi6PIYBlGRAiXhIpfuwpTiX932IAN9jgHnB9Qu7.i5bCg53vu1WmTYR.7G2LU9YLFEyLcb6BVZ 1IjaP4a5CH2Jd4JLuOTQyT3ezbg_oeAETQJ_AuPtb9V8fH_gNKszS8Fq5osqNHO8LvywkEbmeQji UjDffqME.vwkd1HMu0189phN2HIMHPF4ln7ab0aGgIiqnk7SbDMNuPv2G36SOdrKvvjraMhonJOl kXc2r1m8I628JZ7hqfgNAgaKbKsn35kF2vy9UxxqHEJ4OuIJOiyJdm_jvxl6ufPymkUaIPqBLspI ItsauqDBhktyd2ilpaSqskR3lE686C6PbVOoahPe6fnNhobosViAoK3ebDR0hVytCNtV.eUraBTO 6wIEiSaPWcxQpBMKkVranRiZ2dxy6fr7du8gcVwyqvLrOXicrdO1GregW9z6ZhsQEp80Adn0TojC wuHNdW3TVRlxcdq8eHCiIEr2HrIRcfpS4jZ.fVi1dZspP7iBpP1iFZN4meoBklpEzaqJaQTxNC0S lRrBquLE3JQTavfSSyZ8mChChyMi0nPcx_FvRZGZA9da1MnV3721cWM4dgeJH9E.uY5mwMzDaH92 Pfh655IMthKiKI4L0gjqe1Lyz2OttWCy.V7kzBROrvKzCe7szH0SeRtq0Pqsv5sWdjn2uIB.mfxI 1S5h83rRTBFevEq0GkZxzcTOGZKwnKcj0Eqw0i0pZyt3GETH3nSjRpIvDZRwnm8HvnD8p09dkiZY VJoEEOKoO77gW5Ih6ciZrTeiePyIs8187Cpzc3UmunLlKjBYnuca9Cmmvn0zeqX86wKgPLNIWKAS kmkY73RMK5MLtq25N1Kl7yYpRnKS3INmNZGlq_F0JXzVQvA0EpOXkWFmTuNSYaNMx6wK4kkrdeIS z9Z3sMbqEkqAhF7YMRiwOHzTqLxt.FVtQeF3eBGsrYwTN7h5HUYnZV0m4RRS8uv362A9LjxXXu7n xTXAZQp6UQYgie2.hfTN8by53K53R0JO65HoY9EWTsz9Dy4CDxwd2FDnswMOIxQEBfYz36q5mb64 Y5kPH0CIKdrUtytcODbQWxn5Zo3NpJ9.KtercU7.O.tNBVOpJI3pA5CF03becxtPBqQBuemxmIDq IzNrEyiGb36EnNdpzizYlY1P9HeJYA6xPBxIrs.VjeepyquloEuoTtvIMknnLstQPBw5E3LXbLQ8 a13lY_iUczhzXbU22i48TgUWCpk3Ow7IynekZirdhqKzPjdm26VB0SysBMVxIuYMDl7QqdyEDCAG Co8hwqleBv_XstuMxzvOhi89zL2qRpt8B362cMZWycbkcF7csdzuHCLTIZ.d6SPOvrVrPKN4Jam2 O2i7pEZWKiz4LDcnZmedlYz6fzDwrPd0Ty2JGScA6VN8MDovfH1FWeRL__LYzT0UwSPCIIUsLdpe BTZ7YXzm5xb7ZQkI8g5S.zl9Ak1_dDisiJS6dn_k0jw-- X-Sonic-MF: Received: from sonic.gate.mail.ne1.yahoo.com by sonic301.consmr.mail.ir2.yahoo.com with HTTP; Fri, 28 Oct 2022 19:49:30 +0000 Received: by hermes--production-ir2-96dfb7869-4fp8c (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 514eb3bba2249b51f0b2c9e841304db9; Fri, 28 Oct 2022 19:49:28 +0000 (UTC) From: Daniel =?UTF-8?Q?Mart=C3=ADn?= References: <95784A3C-B2F1-415E-94B2-F08B2837AF31@gmail.com> Date: Fri, 28 Oct 2022 21:49:27 +0200 In-Reply-To: <95784A3C-B2F1-415E-94B2-F08B2837AF31@gmail.com> (Yuan Fu's message of "Thu, 27 Oct 2022 16:39:10 -0700") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (darwin) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Mailer: WebService/1.1.20783 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Content-Length: 574 X-Spam-Score: 0.3 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) close 58596 thanks Yuan Fu writes: > > Sorry! I just see this. I believe I fixed the memory leak in trunk. > The purpose for treesit_symbol_to_c_name is to transform not dashes in > tree-sitter, but dashes in languages names, eg, c-sharp. So we do need > that. Thank you so much on working on this though! > > If you don=E2=80=99t mind, please have a look at the revised code and see= if it > fixes the memory leak. > I can confirm that I can't reproduce the memory leak with the latest version of the code. I'm closing this bug report. Thanks.