From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 17 16:58:01 2022 Received: (at submit) by debbugs.gnu.org; 17 Oct 2022 20:58:01 +0000 Received: from localhost ([127.0.0.1]:50230 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1okXBQ-0000Fg-Vm for submit@debbugs.gnu.org; Mon, 17 Oct 2022 16:58:01 -0400 Received: from lists.gnu.org ([209.51.188.17]:56960) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1okXBP-0000FZ-Es for submit@debbugs.gnu.org; Mon, 17 Oct 2022 16:57:59 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:47410) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1okXBP-0008K3-8v for guix-patches@gnu.org; Mon, 17 Oct 2022 16:57:59 -0400 Received: from box.euandre.org ([46.101.160.115]:55973) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1okXBN-0000Q8-NU for guix-patches@gnu.org; Mon, 17 Oct 2022 16:57:59 -0400 Received: from authenticated-user (box.euandre.org [46.101.160.115]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by box.euandre.org (Postfix) with ESMTPSA id 34ED0FC4B2; Mon, 17 Oct 2022 17:57:24 -0300 (-03) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=euandre.org; s=mail; t=1666040246; bh=d7n4Z/wFVBRhKamNMTh2t8hp77l4iUPUTYV42ZrR0zw=; h=From:To:Cc:Subject:Date:From; b=O1BqgT2+QASMaUYokSe+oAUYcG94r0fdl20bFJRKnFbnAOkoE2R+hhLQmuYvF2Qzq qx8Zx6UMGxh7aE+kat0qXu3o+UUaU11VCieoUxOy//Rk3hg30mbESGA1c2zuZeuBNY Nc0CspCZNM133rCJ5bgD3RghWGoB46xMGEEJo274kS7ZskxyaMX5ztGjDR5TPar+Aw H8oY5UxzmLBFCsdDtIjmiG/5Q8nKQ0OL2JclZxWghtIoF0/LJcs4KJXApYNZg7E5JS AljCoocisAzjSamWtuB/72csiO9UWEp8nvuCeLNtT5/pELK1nxuHmfNew7OUU/qhOB 5lXA3w9kLHkfw== From: EuAndreh To: guix-patches@gnu.org Subject: [PATCH 0/2] Rework nginx-shepherd reload Date: Mon, 17 Oct 2022 17:57:17 -0300 Message-Id: <20221017205719.5704-1-eu@euandre.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=46.101.160.115; envelope-from=eu@euandre.org; helo=box.euandre.org X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: submit Cc: EuAndreh , mail@cbaines.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) As discussed in [0], improve the documentation of the "reload" action of nginx, to avoid letting users get into the pitfall of thinking that a this changes the configuration file, or enables a configuration file change to be deployed. [0]: https://issues.guix.gnu.org/58405 EuAndreh (2): services: nginx: Use nginx-action over inline gexp. services: nginx: Improve reload action documentation. gnu/services/web.scm | 14 ++++++-------- 1 file changed, 6 insertions(+), 8 deletions(-) -- 2.38.0 From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 17 16:58:08 2022 Received: (at submit) by debbugs.gnu.org; 17 Oct 2022 20:58:08 +0000 Received: from localhost ([127.0.0.1]:50237 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1okXBY-0000Gw-9E for submit@debbugs.gnu.org; Mon, 17 Oct 2022 16:58:08 -0400 Received: from lists.gnu.org ([209.51.188.17]:56976) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1okXBV-0000Gm-R5 for submit@debbugs.gnu.org; Mon, 17 Oct 2022 16:58:06 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:36080) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1okXBV-0008Q4-Iw for guix-patches@gnu.org; Mon, 17 Oct 2022 16:58:05 -0400 Received: from box.euandre.org ([46.101.160.115]:43225) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1okXBT-0000SF-Ld for guix-patches@gnu.org; Mon, 17 Oct 2022 16:58:05 -0400 Received: from authenticated-user (box.euandre.org [46.101.160.115]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by box.euandre.org (Postfix) with ESMTPSA id 18F25FC4D1; Mon, 17 Oct 2022 17:57:30 -0300 (-03) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=euandre.org; s=mail; t=1666040252; bh=dBRDv4b9S9pHnPHWnei+med3CGoa99o9ZM0A/FAqZl8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=jj/dLta1zX+kb9zTjetUbjQ2wRhxow+pWgrfAATyBerp0/A4OmJpLR+prYxaaDoPo 1XtbYdEuZYa/0WV70EM36Ycf7bEZIXuD+6m8YMa1Y6U87RtPjgcfR9ueGKxHRW7roM o1DmeDvsgAGQKWj4R4O4tz8FELUwdTKNvDx68AFezdRNs8nw0waaxYeKuYodsJoHfI iVQ9MOgxEgd30UU6Hhb6lSTiP5Xk5GT4W/WYrUR3XyOmWYbW2rjz9yHvDlo1iuE4oh m6geqznFaVwgUpfzDgnLL7y8rXE6+F1c6UnXRy+KjP9CAQsQUhFfWVpxzwrGq0TGzF nneh49wQeXlJw== From: EuAndreh To: guix-patches@gnu.org Subject: [PATCH 1/2] services: nginx: Use nginx-action over inline gexp. Date: Mon, 17 Oct 2022 17:57:18 -0300 Message-Id: <20221017205719.5704-2-eu@euandre.org> In-Reply-To: <20221017205719.5704-1-eu@euandre.org> References: <20221017205719.5704-1-eu@euandre.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=46.101.160.115; envelope-from=eu@euandre.org; helo=box.euandre.org X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: submit Cc: EuAndreh X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) * gnu/services/web.scm (nginx-shepherd-service): Use the simpler "nginx-action" helper, for the same reload side-effect. --- gnu/services/web.scm | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/gnu/services/web.scm b/gnu/services/web.scm index 227a577de3..7fde8824b3 100644 --- a/gnu/services/web.scm +++ b/gnu/services/web.scm @@ -820,13 +820,7 @@ (define (nginx-shepherd-service config) (shepherd-action (name 'reload) (documentation "Reload NGINX configuration file and restart worker processes.") - (procedure - #~(lambda (pid) - (if pid - (begin - (kill pid SIGHUP) - (format #t "Service NGINX (PID ~a) has been reloaded." pid)) - (format #t "Service NGINX is not running.")))))))))))) + (procedure (nginx-action "-s" "reload")))))))))) (define nginx-service-type (service-type (name 'nginx) -- 2.38.0 From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 17 17:55:14 2022 Received: (at 58590) by debbugs.gnu.org; 17 Oct 2022 21:55:14 +0000 Received: from localhost ([127.0.0.1]:50361 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1okY4o-00044z-Iw for submit@debbugs.gnu.org; Mon, 17 Oct 2022 17:55:14 -0400 Received: from box.euandre.org ([46.101.160.115]:34073) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1okY4n-00044j-AC for 58590@debbugs.gnu.org; Mon, 17 Oct 2022 17:55:13 -0400 Received: from authenticated-user (box.euandre.org [46.101.160.115]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by box.euandre.org (Postfix) with ESMTPSA id AFFEDFC4B2; Mon, 17 Oct 2022 18:55:05 -0300 (-03) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=euandre.org; s=mail; t=1666043707; bh=LsknjL4P3RWujnvy7m6kqw0jWEBvesGfuAdHAn/0AGE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=O3KCiteawhRbU60LCv5iJfFVTNafqfuWYRTKP5Jsa0E0DFF39XiAybK93M2CLRMuI OZBwCebx+uhzlUDWnXHhzyebUh36JWoqrKAU4r3POHF1V2DEbg/hcPzLoDzTtYzi/7 Bzdtwykan8Dil2TLBpOLMlpoB8HVI2hnCEkyb6v5/vXxiZukmfnsbRuZPi+5w+NGsv ZRlZzV8r8kVouzH1Y+ezem4E7GPmiXIefJklbzNwgptoR8VtuDrJyD3Aq9MgRdrNmO u7wLNm5+zMmLh6ytTUBJ0HdAocJYkV21ViNH8RYfvDw53shJ0zcz+hAbvdYp17k5Ps +oeo80IC0f9gA== From: EuAndreh To: 58590@debbugs.gnu.org Subject: [PATCH] services: nginx: Improve reload action documentation. Date: Mon, 17 Oct 2022 18:55:00 -0300 Message-Id: <20221017215500.11024-1-eu@euandre.org> In-Reply-To: <58590@debbugs.gnu.org> References: <58590@debbugs.gnu.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 58590 Cc: EuAndreh X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) * gnu/services/web.scm (nginx-shepherd-service): Be explicit about the reload action not changing the configuration file, but instead respawning worker processes. --- gnu/services/web.scm | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/gnu/services/web.scm b/gnu/services/web.scm index 7fde8824b3..2023119037 100644 --- a/gnu/services/web.scm +++ b/gnu/services/web.scm @@ -819,7 +819,11 @@ (define (nginx-shepherd-service config) (list (shepherd-action (name 'reload) - (documentation "Reload NGINX configuration file and restart worker processes.") + (documentation "Reload nginx configuration file and restart worker processes. +This has the effect of killing old worker processes and starting new ones, using +the same configuration file. It is useful for situations where the same nginx +configuration file can point to different things after a reload, such as +renewed TLS certificates, or @code{include}d files.") (procedure (nginx-action "-s" "reload")))))))))) (define nginx-service-type -- 2.38.0 From debbugs-submit-bounces@debbugs.gnu.org Tue Oct 18 06:16:53 2022 Received: (at 58590-done) by debbugs.gnu.org; 18 Oct 2022 10:16:53 +0000 Received: from localhost ([127.0.0.1]:51256 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1okjeX-0000rh-7b for submit@debbugs.gnu.org; Tue, 18 Oct 2022 06:16:53 -0400 Received: from mira.cbaines.net ([212.71.252.8]:41608) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1okjeV-0000rY-1Q for 58590-done@debbugs.gnu.org; Tue, 18 Oct 2022 06:16:51 -0400 Received: from localhost (unknown [IPv6:2a02:8010:68c1:0:fc93:27fb:8412:c8b7]) by mira.cbaines.net (Postfix) with ESMTPSA id 75D1927BBE9; Tue, 18 Oct 2022 11:16:50 +0100 (BST) Received: from felis (localhost [127.0.0.1]) by localhost (OpenSMTPD) with ESMTP id 5ff9f162; Tue, 18 Oct 2022 10:16:49 +0000 (UTC) References: <20221017205719.5704-1-eu@euandre.org> User-agent: mu4e 1.8.9; emacs 28.1 From: Christopher Baines To: EuAndreh Subject: Re: [PATCH 0/2] Rework nginx-shepherd reload Date: Tue, 18 Oct 2022 11:16:07 +0100 In-reply-to: <20221017205719.5704-1-eu@euandre.org> Message-ID: <871qr5h1wu.fsf@cbaines.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 58590-done Cc: 58590-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain EuAndreh writes: > As discussed in [0], improve the documentation of the "reload" action > of nginx, to avoid letting users get into the pitfall of thinking that > a this changes the configuration file, or enables a configuration file > change to be deployed. > > [0]: https://issues.guix.gnu.org/58405 > > EuAndreh (2): > services: nginx: Use nginx-action over inline gexp. > services: nginx: Improve reload action documentation. > > gnu/services/web.scm | 14 ++++++-------- > 1 file changed, 6 insertions(+), 8 deletions(-) Thanks, I've pushed these two commits to master now (as 117b0a65c832dcec592a64284910c01f595aa84a and dbdc8f64e7e2d35abbfbfc40ac06cf103207d99e). Thanks again, Chris --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKlBAEBCgCPFiEEPonu50WOcg2XVOCyXiijOwuE9XcFAmNOfRFfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcRHG1haWxAY2Jh aW5lcy5uZXQACgkQXiijOwuE9XeBQQ//WRfH/IxjvK3YcVRedEu55ScSn4w0Y60l nQQSdmhxzNYcruTDVbBRDXwE7ouX1YRWNjU5ChF2vOq7TpKsPtN9hrFTE33JMGLR WJYauJ5LipejggLxHK6MED+vRgbKo/8AoOC/NXbT/ylW8GEVeUjwa+LtkUIMsihx cYCPLE5mbPdsEWogn9AdPyigiqib2H4VWSlOoSSG2yN7bw9rmRRhpEKDU5dKAIGv jde8J46CKLdOiS70/d6ncUHuOs2asONiWCdui75OX8r9vU4l/Qg54kdUtRKLeoT4 3eqNP6UohFlgrdDJQzOUm3vrGNFiGkRghb5RgQr4pdRGrzIVeoKgzWTEzOpMTF/a RGIL6d389FHi8Z6cCLilAaIVdLd/aTysBP+8ZOm5lD0PVYoISQeArlZkrKOpURoS tHBLOcGu8hNJVDOon+BWVzLcwXSdGKas0TTEerwlOwHtbvIyCxEA3r0zgpoCjilN uRADSIVO0M3+4OnXhP3ECLrV83AouKdWfeZc/kTd0vuXEbVDMPyumqFYKlvcPs1G jqdXMtJe5DhvPMye0leCG9DT3ZLmFdasK42cg2SWiXt3jUIT7XwAlj414riYK+KS Y8nrHmAkGpKG1qkIpYbH+LFkchZO59saKAKmskckGG2yChZPUvy8IEgtC7TikKav 2jMepltw1rg= =SoxI -----END PGP SIGNATURE----- --=-=-=-- From unknown Sat Jun 14 05:16:25 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Tue, 15 Nov 2022 12:24:10 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator