GNU bug report logs - #58587
[PATCH 00/14] Introducing pyproject-build-system.

Previous Next

Full log

Message #202 received at 58587-done <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: Marius Bakke <marius <at> gnu.org>
Cc: 58587-done <at> debbugs.gnu.org, Lars-Dominik Braun <lars <at> 6xq.net>
Subject: Re: [bug#58587] [PATCH 04/14] build-system: Add
 pyproject-build-system.
Date: Thu, 27 Oct 2022 21:12:49 -0400

Hi Marius,

Marius Bakke <marius <at> gnu.org> writes:

> Marius Bakke <marius <at> gnu.org> skriver:
>
>> Maxim Cournoyer <maxim.cournoyer <at> gmail.com> skriver:
>>
>>> Hello,
>>>
>>> Marius Bakke <marius <at> gnu.org> writes:
>>>
>>>> From: Lars-Dominik Braun <lars <at> 6xq.net>
>>>>
>>>> +              ;; Prefer pytest
>>>> +              (if pytest 'pytest #f)
>>>> +              (if nosetests 'nose #f)
>>>> +              (if nose2 'nose2 #f)
>>>> +              ;; But fall back to setup.py, which should work for most
>>>> +              ;; packages. XXX: would be nice not to depend on setup.py here? fails
>>>> +              ;; more often than not to find any tests at all. Maybe we can run
>>>> +              ;; `python -m unittest`?
>>>> +              (if have-setup-py 'setup.py #f))))
>>>> +        (format #t "Using ~a~%" use-test-backend)
>>>> +        (match use-test-backend
>>>> +          ('pytest
>>>> +           (apply invoke (cons pytest (or test-flags '("-vv")))))
>>>> +          ('nose
>>>> +           (apply invoke (cons nosetests (or test-flags '("-v")))))
>>>> +          ('nose2
>>>> +           (apply invoke (cons nose2 (or test-flags '("-v" "--pretty-assert")))))
>>>
>>> I think I'd leave the defaults in and document it that way.
>>
>> By leave, you mean:
>>
>>   (apply invoke "pytest" "-vv" test-flags)
>>
>> ?
>
> I made this change in e944734ef9afa1ac9b46579934482b7d909ed24e.
>
> The patches are now merged!

Very nice!  Well done!

-- 
Thanks,
Maxim

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.