GNU bug report logs - #58587
[PATCH 00/14] Introducing pyproject-build-system.

Previous Next

Full log

Message #173 received at 58587 <at> debbugs.gnu.org (full text, mbox):

From: Marius Bakke <marius <at> gnu.org>
To: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
Cc: 58587 <at> debbugs.gnu.org, Lars-Dominik Braun <lars <at> 6xq.net>
Subject: Re: [bug#58587] [PATCH 01/14] gnu: python-setuptools: Move to
 python-build.
Date: Thu, 27 Oct 2022 16:08:12 +0200

[Message part 1 (text/plain, inline)]

Maxim Cournoyer <maxim.cournoyer <at> gmail.com> skriver:

>> +(define-public python-setuptools
>> +  (package
>> +    (name "python-setuptools")
>> +    (version "64.0.3")
>> +    (source
>> +     (origin
>> +       (method url-fetch)
>> +       (uri (pypi-uri "setuptools" version))
>> +       (sha256
>> +        (base32
>> +         "1sllqf0bhsl2yilf1w0xnlz0r4yaksmwaj0ap91zdc6kgbigdjiv"))
>> +       (modules '((guix build utils)))
>> +       (snippet
>> +        ;; Remove included binaries which are used to build self-extracting
>> +        ;; installers for Windows.
>> +        ;; TODO: Find some way to build them ourself so we can include them.
>
> I don't think we need a TODO to fix installers for Windows.

I concur.

>> +        '(for-each delete-file (find-files "setuptools"
>> +                                           "^(cli|gui).*\\.exe$")))))
>> +    (build-system python-build-system)
>> +    ;; FIXME: Tests require pytest, which itself relies on setuptools.
>> +    ;; One could bootstrap with an internal untested setuptools.
>> +    (arguments (list #:tests? #f))
>> +    (home-page "https://pypi.org/project/setuptools/")
>> +    (synopsis "Library designed to facilitate packaging Python projects")
>> +    (description "Setuptools is a fully-featured, stable library designed to
>> +facilitate packaging Python projects, where packaging includes:
>> +@itemize
>> +@item Python package and module definitions
>> +@item distribution package metadata
>> +@item test hooks
>> +@item project installation
>> +@item platform-specific details.
>> +@end itemize")
>> +    ;; TODO: setuptools now bundles the following libraries:
>> +    ;; packaging, pyparsing, six and appdirs. How to unbundle?
>
> A better place for this TODO would be next to the snippet in the origin,
> perhaps?

The comments were taken verbatim from the current package definition.

I'll submit a follow-up commit with these changes.

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.