GNU bug report logs - #58587
[PATCH 00/14] Introducing pyproject-build-system.

Previous Next

Package: guix-patches;

Reported by: Marius Bakke <marius <at> gnu.org>

Date: Mon, 17 Oct 2022 20:07:01 UTC

Severity: normal

Tags: patch

Done: Marius Bakke <marius <at> gnu.org>

Bug is archived. No further changes may be made.

Full log


Message #167 received at 58587 <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: Marius Bakke <marius <at> gnu.org>
Cc: 58587 <at> debbugs.gnu.org, Lars-Dominik Braun <lars <at> 6xq.net>
Subject: Re: [bug#58587] [PATCH 02/14] gnu: pypy: Move to separate module.
Date: Thu, 27 Oct 2022 09:28:37 -0400
Hi,

Marius Bakke <marius <at> gnu.org> writes:

> From: Lars-Dominik Braun <lars <at> 6xq.net>
>
> This removes the need to import (gnu packages python-xyz) in (gnu packages
> python), avoiding issues with circular imports.
>
> * gnu/packages/python.scm (pypy): Move…
> * gnu/packages/pypy.scm (pypy): …here
> * gnu/local.mk: Register new file.
>
> Co-authored-by: Marius Bakke <marius <at> gnu.org>
> ---
>  gnu/local.mk            |   1 +
>  gnu/packages/pypy.scm   | 273 ++++++++++++++++++++++++++++++++++++++++
>  gnu/packages/python.scm | 167 ------------------------
>  3 files changed, 274 insertions(+), 167 deletions(-)
>  create mode 100644 gnu/packages/pypy.scm
>
> diff --git a/gnu/local.mk b/gnu/local.mk
> index 8247180bef..bf598cec8b 100644
> --- a/gnu/local.mk
> +++ b/gnu/local.mk
> @@ -506,6 +506,7 @@ GNU_SYSTEM_MODULES =				\
>    %D%/packages/pure.scm				\
>    %D%/packages/purescript.scm			\
>    %D%/packages/pv.scm				\
> +  %D%/packages/pypy.scm				\
>    %D%/packages/python.scm			\
>    %D%/packages/python-build.scm			\
>    %D%/packages/python-check.scm			\
> diff --git a/gnu/packages/pypy.scm b/gnu/packages/pypy.scm
> new file mode 100644
> index 0000000000..002cfd59cd
> --- /dev/null
> +++ b/gnu/packages/pypy.scm
> @@ -0,0 +1,273 @@
> +;;; GNU Guix --- Functional package management for GNU
> +;;; Copyright © 2013 Nikita Karetnikov <nikita <at> karetnikov.org>
> +;;; Copyright © 2013, 2014, 2015, 2016, 2017, 2018, 2021 Ludovic Courtès <ludo <at> gnu.org>
> +;;; Copyright © 2013, 2014, 2015, 2016 Andreas Enge <andreas <at> enge.fr>
> +;;; Copyright © 2014, 2015 Mark H Weaver <mhw <at> netris.org>
> +;;; Copyright © 2014, 2017, 2019 Eric Bavier <bavier <at> member.fsf.org>
> +;;; Copyright © 2014, 2015 Federico Beffa <beffa <at> fbengineering.ch>
> +;;; Copyright © 2015 Omar Radwan <toxemicsquire4 <at> gmail.com>
> +;;; Copyright © 2015 Pierre-Antoine Rault <par <at> rigelk.eu>
> +;;; Copyright © 2015, 2016, 2017, 2018, 2019 Ricardo Wurmus <rekado <at> elephly.net>
> +;;; Copyright © 2015, 2016 Christine Lemmer-Webber <cwebber <at> dustycloud.org>
> +;;; Copyright © 2015 Eric Dvorsak <eric <at> dvorsak.fr>
> +;;; Copyright © 2015, 2016 David Thompson <davet <at> gnu.org>
> +;;; Copyright © 2015, 2016, 2017, 2021 Leo Famulari <leo <at> famulari.name>
> +;;; Copyright © 2015, 2017 Ben Woodcroft <donttrustben <at> gmail.com>
> +;;; Copyright © 2015, 2016 Erik Edrosa <erik.edrosa <at> gmail.com>
> +;;; Copyright © 2015, 2016, 2017, 2018, 2019, 2020 Efraim Flashner <efraim <at> flashner.co.il>
> +;;; Copyright © 2015, 2017 Kyle Meyer <kyle <at> kyleam.com>
> +;;; Copyright © 2015, 2016 Chris Marusich <cmmarusich <at> gmail.com>
> +;;; Copyright © 2016 Danny Milosavljevic <dannym+a <at> scratchpost.org>
> +;;; Copyright © 2016 Lukas Gradl <lgradl <at> openmailbox.org>
> +;;; Copyright © 2016, 2018 Hartmut Goebel <h.goebel <at> crazy-compilers.com>
> +;;; Copyright © 2016 Daniel Pimentel <d4n1 <at> d4n1.org>
> +;;; Copyright © 2016 Sou Bunnbu <iyzsong <at> gmail.com>
> +;;; Copyright © 2016, 2017 Troy Sankey <sankeytms <at> gmail.com>
> +;;; Copyright © 2016, 2017 Nikita <nikita <at> n0.is>
> +;;; Copyright © 2016 Dylan Jeffers <sapientech <at> sapientech <at> openmailbox.org>
> +;;; Copyright © 2016 David Craven <david <at> craven.ch>
> +;;; Copyright © 2016, 2017, 2018, 2019, 2020, 2021 Marius Bakke <marius <at> gnu.org>
> +;;; Copyright © 2016, 2017 Stefan Reichör <stefan <at> xsteve.at>
> +;;; Copyright © 2016 Dylan Jeffers <sapientech <at> sapientech <at> openmailbox.org>
> +;;; Copyright © 2016, 2017 Alex Vong <alexvong1995 <at> gmail.com>
> +;;; Copyright © 2016, 2017, 2018 Arun Isaac <arunisaac <at> systemreboot.net>
> +;;; Copyright © 2016–2018, 2021 Tobias Geerinckx-Rice <me <at> tobias.gr>
> +;;; Copyright © 2016, 2017, 2018, 2021 Julien Lepiller <julien <at> lepiller.eu>
> +;;; Copyright © 2016, 2017 Thomas Danckaert <post <at> thomasdanckaert.be>
> +;;; Copyright © 2017 Carlo Zancanaro <carlo <at> zancanaro.id.au>
> +;;; Copyright © 2017 Frederick M. Muriithi <fredmanglis <at> gmail.com>
> +;;; Copyright © 2017, 2018 Adriano Peluso <catonano <at> gmail.com>
> +;;; Copyright © 2017 Ben Sturmfels <ben <at> sturm.com.au>
> +;;; Copyright © 2017, 2018, 2019 Mathieu Othacehe <m.othacehe <at> gmail.com>
> +;;; Copyright © 2017 José Miguel Sánchez García <jmi2k <at> openmailbox.org>
> +;;; Copyright © 2017 Roel Janssen <roel <at> gnu.org>
> +;;; Copyright © 2017, 2018 Kei Kebreau <kkebreau <at> posteo.net>
> +;;; Copyright © 2017 Rutger Helling <rhelling <at> mykolab.com>
> +;;; Copyright © 2017 Muriithi Frederick Muriuki <fredmanglis <at> gmail.com>
> +;;; Copyright © 2017 Brendan Tildesley <mail <at> brendan.scot>
> +;;; Copyright © 2018 Ethan R. Jones <ethanrjones97 <at> gmail.com
> +;;; Copyright © 2018 Fis Trivial <ybbs.daans <at> hotmail.com>
> +;;; Copyright © 2018 Vijayalakshmi Vedantham <vijimay12 <at> gmail.com>
> +;;; Copyright © 2018 Mathieu Lirzin <mthl <at> gnu.org>
> +;;; Copyright © 2018 Adam Massmann <massmannak <at> gmail.com>
> +;;; Copyright © 2016, 2018 Tomáš Čech <sleep_walker <at> gnu.org>
> +;;; Copyright © 2018 Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
> +;;; Copyright © 2018 Oleg Pykhalov <go.wigust <at> gmail.com>
> +;;; Copyright © 2018 Clément Lassieur <clement <at> lassieur.org>
> +;;; Copyright © 2018, 2019, 2020, 2021 Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
> +;;; Copyright © 2018 Luther Thompson <lutheroto <at> gmail.com>
> +;;; Copyright © 2018 Vagrant Cascadian <vagrant <at> debian.org>
> +;;; Copyright © 2019 Tanguy Le Carrour <tanguy <at> bioneland.org>
> +;;; Copyright © 2020 Jan (janneke) Nieuwenhuizen <janneke <at> gnu.org>
> +;;; Copyright © 2020, 2021 Greg Hogan <code <at> greghogan.com>

I really doubt all these individuals have contributed to *pypy*.  The
rest of this patch LGTM.

-- 
Thanks,
Maxim




This bug report was last modified 2 years and 262 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.