Subject: [bug#58587] [PATCH 01/14] gnu: python-setuptools: Move to python-build.

From: Maxim Cournoyer <[email-masked]>
Date: Thu, 27 Oct 2022 09:25:52 -0400

Hi,

Marius Bakke <[email-masked]> writes:

> From: Lars-Dominik Braun <[email-masked]>
>
> * gnu/packages/python-xyz.scm (python-setuptools): Move…
> * gnu/packages/python-build.scm: …here.
> * gnu/packages/chemistry.scm,
> gnu/packages/messaging.scm,
> gnu/packages/sequoia.scm,
> tests/lint.scm: Adjust module imports accordingly.
>
> Co-authored-by: Marius Bakke <[email-masked]>

[...]

> +(define-public python-setuptools
> +  (package
> +    (name "python-setuptools")
> +    (version "64.0.3")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (pypi-uri "setuptools" version))
> +       (sha256
> +        (base32
> +         "1sllqf0bhsl2yilf1w0xnlz0r4yaksmwaj0ap91zdc6kgbigdjiv"))
> +       (modules '((guix build utils)))
> +       (snippet
> +        ;; Remove included binaries which are used to build self-extracting
> +        ;; installers for Windows.
> +        ;; TODO: Find some way to build them ourself so we can include them.

I don't think we need a TODO to fix installers for Windows.

> +        '(for-each delete-file (find-files "setuptools"
> +                                           "^(cli|gui).*\\.exe$")))))
> +    (build-system python-build-system)
> +    ;; FIXME: Tests require pytest, which itself relies on setuptools.
> +    ;; One could bootstrap with an internal untested setuptools.
> +    (arguments (list #:tests? #f))
> +    (home-page "https://pypi.org/project/setuptools/")
> +    (synopsis "Library designed to facilitate packaging Python projects")
> +    (description "Setuptools is a fully-featured, stable library designed to
> +facilitate packaging Python projects, where packaging includes:
> +@itemize
> +@item Python package and module definitions
> +@item distribution package metadata
> +@item test hooks
> +@item project installation
> +@item platform-specific details.
> +@end itemize")
> +    ;; TODO: setuptools now bundles the following libraries:
> +    ;; packaging, pyparsing, six and appdirs. How to unbundle?

A better place for this TODO would be next to the snippet in the origin,
perhaps?

--
Thanks,
Maxim