GNU bug report logs - #58573
[PATCH 0/1] Add QA status badge to mumi issue page.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 58573 in the body.
You can then email your comments to 58573 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Arun Isaac <arunisaac <at> systemreboot.net>
To: Ricardo Wurmus <rekado <at> elephly.net>
Cc: Arun Isaac <arunisaac <at> systemreboot.net>,
 Christopher Baines <mail <at> cbaines.net>, guix-patches <at> gnu.org
Subject: [PATCH 0/1] Add QA status badge to mumi issue page.
Date: Mon, 17 Oct 2022 01:01:12 +0530

Hi Ricardo,

Chris (CCed) has recently set up a QA feature that allows patch
contributors and reviewers to quickly check the build status of
contributed patches across different architectures. qa.guix.gnu.org
provides this status indication as an SVG badge that can be embedded
into a mumi issue page. This patch does so.

Regards,
Arun

Arun Isaac (1):
  Add QA status badge to issue page.

 mumi/config.scm.in     |  4 +++-
 mumi/web/view/html.scm | 17 +++++++++++++++++
 2 files changed, 20 insertions(+), 1 deletion(-)

-- 
2.37.3

Message #8 received at 58573 <at> debbugs.gnu.org (full text, mbox):

From: Arun Isaac <arunisaac <at> systemreboot.net>
To: Ricardo Wurmus <rekado <at> elephly.net>
Cc: 58573 <at> debbugs.gnu.org, Arun Isaac <arunisaac <at> systemreboot.net>,
 Christopher Baines <mail <at> cbaines.net>
Subject: [PATCH] Add QA status badge to issue page.
Date: Mon, 17 Oct 2022 01:03:26 +0530

* mumi/config.scm.in (%config): Add qa-scheme and qa-host
configuration parameters.
* mumi/web/view/html.scm: Import (web uri).
(build-uri-path): New function.
(issue-page): Add QA status badge.
---
 mumi/config.scm.in     |  4 +++-
 mumi/web/view/html.scm | 17 +++++++++++++++++
 2 files changed, 20 insertions(+), 1 deletion(-)

diff --git a/mumi/config.scm.in b/mumi/config.scm.in
index 66ad924..ed9330a 100644
--- a/mumi/config.scm.in
+++ b/mumi/config.scm.in
@@ -78,6 +78,8 @@
            (submission-bug-email-address . "bug-guix <at> gnu.org")
            (lists       . ("guix-patches <at> gnu.org" "bug-guix <at> gnu.org"))
            (packages    . ("guix-patches" "guix"))
-           (debbugs-domain . "debbugs.gnu.org"))))
+           (debbugs-domain . "debbugs.gnu.org")
+           (qa-scheme   . https)
+           (qa-host     . "qa.guix.gnu.org"))))
     (lambda (key)
       (assoc-ref config key))))
diff --git a/mumi/web/view/html.scm b/mumi/web/view/html.scm
index 171fbf9..7fd85bc 100644
--- a/mumi/web/view/html.scm
+++ b/mumi/web/view/html.scm
@@ -26,6 +26,7 @@
   #:use-module (ice-9 match)
   #:use-module (srfi srfi-1)
   #:use-module (srfi srfi-19)
+  #:use-module (web uri)
   #:export (index
             help
             unknown
@@ -355,6 +356,10 @@ failed to process associated messages.")
           ,message
           (p (a (@ (href "/")) "Try something else?"))))))
 
+(define (build-uri-path . parts)
+  "Encode PARTS and join them together into an absolute URI path."
+  (string-append "/" (encode-and-join-uri-path parts)))
+
 (define* (issue-page bug #:optional flash-message)
   "Render the conversation for the given BUG."
   (define id (bug-num bug))
@@ -403,6 +408,18 @@ failed to process associated messages.")
                            ;; non-ASCII characters.
                            (sender-name (first messages))
                            ".")
+           (div
+            (a (@ (href ,(uri->string
+                          (build-uri (%config 'qa-scheme)
+                                     #:host (%config 'qa-host)
+                                     #:path (build-uri-path "issue"
+                                                            (number->string id))))))
+               (img (@ (src ,(uri->string
+                              (build-uri (%config 'qa-scheme)
+                                         #:host (%config 'qa-host)
+                                         #:path (build-uri-path "issue"
+                                                                (number->string id)
+                                                                "status-badge-medium.svg"))))))))
            (details
             (@ (class "info"))
             (summary "Details")
-- 
2.37.3

Message #13 received at 58573-done <at> debbugs.gnu.org (full text, mbox):

From: Ricardo Wurmus <rekado <at> elephly.net>
To: Arun Isaac <arunisaac <at> systemreboot.net>
Cc: 58573-done <at> debbugs.gnu.org, Christopher Baines <mail <at> cbaines.net>
Subject: Re: [PATCH] Add QA status badge to issue page.
Date: Sun, 16 Oct 2022 22:05:50 +0200

Arun Isaac <arunisaac <at> systemreboot.net> writes:

> * mumi/config.scm.in (%config): Add qa-scheme and qa-host
> configuration parameters.
> * mumi/web/view/html.scm: Import (web uri).
> (build-uri-path): New function.
> (issue-page): Add QA status badge.

Applied, thank you!

-- 
Ricardo

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.