GNU bug report logs - #58549
[PATCH draft] installer: welcome: Warn when uvesafb gets used.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 58549 in the body.
You can then email your comments to 58549 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: "pelzflorian (Florian Pelz)" <pelzflorian <at> pelzflorian.de>
To: guix-patches <at> gnu.org
Subject: [PATCH draft] installer: welcome: Warn when uvesafb gets used.
Date: Sat, 15 Oct 2022 17:39:03 +0200

There will be false positives: Because the Guix installer uses the
kernel argument modprobe.blacklist=radeon,amdgpu and some AMD graphics
actually work okay according to h-node, these users will get a
false alarm.

* gnu/installer/newt/welcome.scm (run-welcome-page): Warn before showing
the welcome page.
---
 gnu/installer/newt/welcome.scm | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/gnu/installer/newt/welcome.scm b/gnu/installer/newt/welcome.scm
index 7a7ddfb7bd..762fca96eb 100644
--- a/gnu/installer/newt/welcome.scm
+++ b/gnu/installer/newt/welcome.scm
@@ -1,6 +1,7 @@
 ;;; GNU Guix --- Functional package management for GNU
 ;;; Copyright © 2018 Mathieu Othacehe <m.othacehe <at> gmail.com>
 ;;; Copyright © 2020 Ludovic Courtès <ludo <at> gnu.org>
+;;; Copyright © 2022 Florian Pelz <pelzflorian <at> pelzflorian.de>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -17,6 +18,8 @@
 ;;; along with GNU Guix.  If not, see <http://www.gnu.org/licenses/>.
 
 (define-module (gnu installer newt welcome)
+  #:use-module ((gnu build linux-modules)
+                #:select (modules-loaded))
   #:use-module (gnu installer steps)
   #:use-module (gnu installer utils)
   #:use-module (gnu installer newt page)
@@ -121,6 +124,14 @@ (define (run-welcome-page logo)
   "Run a welcome page with the given textual LOGO displayed at the center of
 the page. Ask the user to choose between manual installation, graphical
 installation and reboot."
+  (begin
+  (when (member "uvesafb" (modules-loaded))
+    (run-error-page (G_ "\
+This may be a false alarm, but possibly your graphics hardware does not
+work well with only free software.  Expect trouble.  If after installation,
+the system does not boot, perhaps you will need to add nomodeset to the
+kernel arguments and need to configure the uvesafb kernel module.")
+                    (G_ "Pre-install warning")))
   (run-menu-page
    (G_ "GNU Guix install")
    (G_ "Welcome to GNU Guix system installer!
@@ -148,3 +159,4 @@ (define (run-welcome-page logo)
          (newt-finish)
          (reboot))))
    #:listbox-item->text car))
+  )

base-commit: d923cf1deac0b6762345d0d9e53822cbcb899365
-- 
2.37.3

Message #8 received at 58549 <at> debbugs.gnu.org (full text, mbox):

From: "pelzflorian (Florian Pelz)" <pelzflorian <at> pelzflorian.de>
To: 58549 <at> debbugs.gnu.org
Subject: Re: [bug#58549] [PATCH draft] installer: welcome: Warn when uvesafb
 gets used.
Date: Sat, 15 Oct 2022 17:47:54 +0200

P.S. This patch was sent in response to <https://issues.guix.gnu.org/58357#6>
It can be tested on non-affected machines by adding the word nomodeset
in GRUB to the linux boot line.

Regards,
Florian

Message #11 received at 58549 <at> debbugs.gnu.org (full text, mbox):

From: Mathieu Othacehe <othacehe <at> gnu.org>
To: "pelzflorian (Florian Pelz)" <pelzflorian <at> pelzflorian.de>
Cc: 58549 <at> debbugs.gnu.org
Subject: Re: bug#58549: [PATCH draft] installer: welcome: Warn when uvesafb
 gets used.
Date: Mon, 17 Oct 2022 11:40:32 +0200

Hello Florian,

> +  (when (member "uvesafb" (modules-loaded))
> +    (run-error-page (G_ "\
> +This may be a false alarm, but possibly your graphics hardware does not
> +work well with only free software.  Expect trouble.  If after installation,
> +the system does not boot, perhaps you will need to add nomodeset to the
> +kernel arguments and need to configure the uvesafb kernel module.")
> +                    (G_ "Pre-install warning")))

This seems like a good idea to me. Perhaps we could be a bit more
specific about the "expected troubles". Is it a black screen after Linux
boot on the installed system?

Thanks,

Mathieu

Message #14 received at 58549 <at> debbugs.gnu.org (full text, mbox):

From: "pelzflorian (Florian Pelz)" <pelzflorian <at> pelzflorian.de>
To: Mathieu Othacehe <othacehe <at> gnu.org>
Cc: 58549 <at> debbugs.gnu.org
Subject: Re: bug#58549: [PATCH draft] installer: welcome: Warn when uvesafb
 gets used.
Date: Mon, 24 Oct 2022 15:39:57 +0200

Please excuse my slow response.

Mathieu Othacehe <othacehe <at> gnu.org> writes:
>> +  (when (member "uvesafb" (modules-loaded))
>> +    (run-error-page (G_ "\
>> +This may be a false alarm, but possibly your graphics hardware does not
>> +work well with only free software.  Expect trouble.  If after installation,
>> +the system does not boot, perhaps you will need to add nomodeset to the
>> +kernel arguments and need to configure the uvesafb kernel module.")
>> +                    (G_ "Pre-install warning")))
>
> This seems like a good idea to me. Perhaps we could be a bit more
> specific about the "expected troubles". Is it a black screen after Linux
> boot on the installed system?

With my somewhat older AMD systems, that the system doesn’t boot
actually is a white lie.  When using Xorg, the display locks up to a
still image (not black but the previous unrelated boot messages), but
IIRC it boots fine otherwise and can be used blindly.  So in the common
case of AMD, it could be said that “the display locks up to a still
image”.  Maybe that is not true in general though.

With SiS graphics on my vintage Uniwill One laptop, this would be not
true.  On cold boots, the laptop goes to kind of an infinite suspend
state.  On reboots, GDM just doesn’t start, but the virtual console is
usable.


Thinking about it, the false alarms are not nice, but I don’t know if
Ludo’s proposed device check <https://issues.guix.gnu.org/58357#4> would
be reasonably doable and he actually wasn’t mentioning it in relation to
graphics.  I think this patch is right (after fixing the indentation).
Shall I push or make more changes?

Regards,
Florian

Message #17 received at 58549 <at> debbugs.gnu.org (full text, mbox):

From: Mathieu Othacehe <othacehe <at> gnu.org>
To: "pelzflorian (Florian Pelz)" <pelzflorian <at> pelzflorian.de>
Cc: 58549 <at> debbugs.gnu.org
Subject: Re: bug#58549: [PATCH draft] installer: welcome: Warn when uvesafb
 gets used.
Date: Mon, 24 Oct 2022 16:20:19 +0200

Hello Florian,

> Thinking about it, the false alarms are not nice, but I don’t know if
> Ludo’s proposed device check <https://issues.guix.gnu.org/58357#4> would
> be reasonably doable and he actually wasn’t mentioning it in relation to
> graphics.  I think this patch is right (after fixing the indentation).
> Shall I push or make more changes?

Ludo firmware load detection seems like a good idea to me but we would
need to study the feasibility.

Your patch seems OK to me, you can go ahead.

Mathieu

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.