From unknown Mon Jun 23 11:28:13 2025 X-Loop: help-debbugs@gnu.org Subject: bug#58547: 29.0.50; [PATCH] Fix one internal naming Resent-From: Manuel Giraud Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 15 Oct 2022 12:56:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 58547 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: 58547@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.166583853222361 (code B ref -1); Sat, 15 Oct 2022 12:56:01 +0000 Received: (at submit) by debbugs.gnu.org; 15 Oct 2022 12:55:32 +0000 Received: from localhost ([127.0.0.1]:39763 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ojghP-0005oa-6o for submit@debbugs.gnu.org; Sat, 15 Oct 2022 08:55:32 -0400 Received: from lists.gnu.org ([209.51.188.17]:42166) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ojghM-0005oR-9I for submit@debbugs.gnu.org; Sat, 15 Oct 2022 08:55:30 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:47714) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ojghL-0003iP-Pk for bug-gnu-emacs@gnu.org; Sat, 15 Oct 2022 08:55:28 -0400 Received: from ledu-giraud.fr ([51.159.28.247]:48991) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ojghI-0007QA-3C for bug-gnu-emacs@gnu.org; Sat, 15 Oct 2022 08:55:27 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; s=rsa; bh=rujl7pxfM/2UTi6T wfIVecekXyhCrifJFFZlP/y1FEk=; h=date:subject:to:from; d=ledu-giraud.fr; b=amAioGHQb10cZY1Efbc2y+zvpgBewYyzbV4MnZO7ws5oAP8TF1 Se2swHb+hXNa61942SpLg0UVxqx5KT9ZgO8SnXlx2gvdwgtXOh3SkTzw1/k5ir9GrW6ff2 00RN+1s2QZnI0gfl30Mm/s0YlSWttVyhidkCHQDsiph9BIo+C8orytWOQbo/ctUKXp0/z+ akRjvQ3khQIvw9vJJC4Numobe0/jhPhFCU+VpUquJlEbTksLRX0w/uAVzrPbfxQG7f6iki WVodpCiiW3yq7Blht+I0D15E7MtxAjy/dbEisT2WOOs3a7Xb6/Bmv1vXy+kFYeV/vzFmN5 4x19M9SrfXng== Received: from elite.giraud ( [10.1.1.1]) by ledu-giraud.fr (OpenSMTPD) with ESMTPSA id bd861682 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO) for ; Sat, 15 Oct 2022 14:55:20 +0200 (CEST) From: Manuel Giraud Date: Sat, 15 Oct 2022 14:55:19 +0200 Message-ID: <878rlhtfew.fsf@elite.giraud> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Received-SPF: pass client-ip=51.159.28.247; envelope-from=manuel@ledu-giraud.fr; helo=ledu-giraud.fr X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) --=-=-= Content-Type: text/plain Hi, I don't know if those kind of bikesheeding patch are accepted but I think that "estimate_mode_line_height" is not a good name since it can be (and is!) called with others face id. Best regards, --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-Fix-one-internal-naming.patch >From e7c3a8f3d48ca03e521bd59bf24b795d5853b70d Mon Sep 17 00:00:00 2001 From: Manuel Giraud Date: Sat, 15 Oct 2022 12:56:50 +0200 Subject: [PATCH] Fix one internal naming * src/xdisp.c (estimate_line_height_with_face): Renaming of estimate_mode_line_height. * src/dispextern.h: Update calls. --- src/dispextern.h | 8 ++++---- src/xdisp.c | 14 +++++++------- 2 files changed, 11 insertions(+), 11 deletions(-) diff --git a/src/dispextern.h b/src/dispextern.h index 2f5f4335fe..c673b7e30b 100644 --- a/src/dispextern.h +++ b/src/dispextern.h @@ -1514,7 +1514,7 @@ #define CURRENT_MODE_LINE_HEIGHT(W) \ : ((W)->mode_line_height \ = (MATRIX_MODE_LINE_HEIGHT ((W)->current_matrix) \ ? MATRIX_MODE_LINE_HEIGHT ((W)->current_matrix) \ - : estimate_mode_line_height \ + : estimate_line_height_with_face \ (XFRAME ((W)->frame), CURRENT_MODE_LINE_ACTIVE_FACE_ID (W))))) /* Return the current height of the header line of window W. If not known @@ -1527,7 +1527,7 @@ #define CURRENT_HEADER_LINE_HEIGHT(W) \ : ((W)->header_line_height \ = (MATRIX_HEADER_LINE_HEIGHT ((W)->current_matrix) \ ? MATRIX_HEADER_LINE_HEIGHT ((W)->current_matrix) \ - : estimate_mode_line_height \ + : estimate_line_height_with_face \ (XFRAME ((W)->frame), HEADER_LINE_FACE_ID)))) /* Return the current height of the tab line of window W. If not known @@ -1540,7 +1540,7 @@ #define CURRENT_TAB_LINE_HEIGHT(W) \ : ((W)->tab_line_height \ = (MATRIX_TAB_LINE_HEIGHT ((W)->current_matrix) \ ? MATRIX_TAB_LINE_HEIGHT ((W)->current_matrix) \ - : estimate_mode_line_height \ + : estimate_line_height_with_face \ (XFRAME ((W)->frame), TAB_LINE_FACE_ID)))) /* Return the height of the desired mode line of window W. */ @@ -3392,7 +3392,7 @@ #define TTY_CAP_STRIKE_THROUGH 0x20 int window_box_left (struct window *, enum glyph_row_area); int window_box_left_offset (struct window *, enum glyph_row_area); int window_box_right (struct window *, enum glyph_row_area); -int estimate_mode_line_height (struct frame *, enum face_id); +int estimate_line_height_with_face (struct frame *, enum face_id); int move_it_to (struct it *, ptrdiff_t, int, int, int, int); void pixel_to_glyph_coords (struct frame *, int, int, int *, int *, NativeRectangle *, bool); diff --git a/src/xdisp.c b/src/xdisp.c index e390de6a33..6944f13c47 100644 --- a/src/xdisp.c +++ b/src/xdisp.c @@ -1274,7 +1274,7 @@ window_box_height (struct window *w) height is essentially the same as that contained in the macro CURRENT_{MODE,HEADER,TAB}_LINE_HEIGHT, except that it checks whether the appropriate glyph row has its `mode_line_p' flag set, and if - it doesn't, uses estimate_mode_line_height instead. */ + it doesn't, uses estimate_line_height_with_face instead. */ if (window_wants_mode_line (w)) { @@ -1289,7 +1289,7 @@ window_box_height (struct window *w) if (ml_row && ml_row->mode_line_p) height -= ml_row->height; else - height -= estimate_mode_line_height + height -= estimate_line_height_with_face (f, CURRENT_MODE_LINE_ACTIVE_FACE_ID (w)); } } @@ -1307,7 +1307,7 @@ window_box_height (struct window *w) if (tl_row && tl_row->mode_line_p) height -= tl_row->height; else - height -= estimate_mode_line_height (f, TAB_LINE_FACE_ID); + height -= estimate_line_height_with_face (f, TAB_LINE_FACE_ID); } } @@ -1324,7 +1324,7 @@ window_box_height (struct window *w) if (hl_row && hl_row->mode_line_p) height -= hl_row->height; else - height -= estimate_mode_line_height (f, HEADER_LINE_FACE_ID); + height -= estimate_line_height_with_face (f, HEADER_LINE_FACE_ID); } } @@ -2241,11 +2241,11 @@ compute_string_pos (struct text_pos *newpos, struct text_pos pos, Lisp_Object st } /* EXPORT: - Return an estimation of the pixel height of mode or header lines on - frame F. FACE_ID specifies what line's height to estimate. */ + Return an estimation of the pixel height of lines on frame F. + FACE_ID specifies what line's height to estimate. */ int -estimate_mode_line_height (struct frame *f, enum face_id face_id) +estimate_line_height_with_face (struct frame *f, enum face_id face_id) { #ifdef HAVE_WINDOW_SYSTEM if (FRAME_WINDOW_P (f)) -- 2.38.0 --=-=-= Content-Type: text/plain In GNU Emacs 29.0.50 (build 1, x86_64-unknown-openbsd7.2, cairo version 1.17.6) of 2022-10-14 built on elite.giraud Repository revision: 100ed84198cd97664a94e89d1730e97b1fabbbb9 Repository branch: mgi/play Windowing system distributor 'The X.Org Foundation', version 11.0.12101004 System Description: OpenBSD elite.giraud 7.2 GENERIC.MP#778 amd64 Configured using: 'configure --prefix=/home/manuel/emacs --bindir=/home/manuel/bin --with-x-toolkit=no --without-sound --without-compress-install CPPFLAGS=-I/usr/local/include LDFLAGS=-L/usr/local/lib' Configured features: CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GSETTINGS HARFBUZZ JPEG JSON LCMS2 LIBOTF LIBXML2 MODULES NOTIFY KQUEUE OLDXMENU PDUMPER PNG RSVG SQLITE3 THREADS TIFF WEBP X11 XDBE XIM XINPUT2 XPM ZLIB Important settings: value of $LC_ALL: en_US.UTF-8 locale-coding-system: utf-8-unix Major mode: Group Minor modes in effect: global-git-commit-mode: t magit-auto-revert-mode: t gnus-topic-mode: t icomplete-mode: t display-time-mode: t display-battery-mode: t gnus-undo-mode: t shell-dirtrack-mode: t global-so-long-mode: t repeat-mode: t global-eldoc-mode: t show-paren-mode: t electric-indent-mode: t mouse-wheel-mode: t tab-bar-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t buffer-read-only: t line-number-mode: t indent-tabs-mode: t transient-mark-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t Load-path shadows: /home/manuel/.el/exwm/exwm hides /home/manuel/.emacs.d/elpa/exwm-0.26/exwm /home/manuel/.el/exwm/exwm-xim hides /home/manuel/.emacs.d/elpa/exwm-0.26/exwm-xim /home/manuel/.el/exwm/exwm-workspace hides /home/manuel/.emacs.d/elpa/exwm-0.26/exwm-workspace /home/manuel/.el/exwm/exwm-randr hides /home/manuel/.emacs.d/elpa/exwm-0.26/exwm-randr /home/manuel/.el/exwm/exwm-manage hides /home/manuel/.emacs.d/elpa/exwm-0.26/exwm-manage /home/manuel/.el/exwm/exwm-layout hides /home/manuel/.emacs.d/elpa/exwm-0.26/exwm-layout /home/manuel/.el/exwm/exwm-input hides /home/manuel/.emacs.d/elpa/exwm-0.26/exwm-input /home/manuel/.el/exwm/exwm-floating hides /home/manuel/.emacs.d/elpa/exwm-0.26/exwm-floating /home/manuel/.el/exwm/exwm-core hides /home/manuel/.emacs.d/elpa/exwm-0.26/exwm-core /home/manuel/.el/exwm/exwm-config hides /home/manuel/.emacs.d/elpa/exwm-0.26/exwm-config /home/manuel/.el/exwm/exwm-cm hides /home/manuel/.emacs.d/elpa/exwm-0.26/exwm-cm /home/manuel/.el/exwm/exwm-systemtray hides /home/manuel/.emacs.d/elpa/exwm-0.26/exwm-systemtray /home/manuel/.emacs.d/elpa/transient-20220918.2101/transient hides /home/manuel/emacs/share/emacs/29.0.50/lisp/transient Features: (shadow emacsbug tmm proced gnus-dired magit-patch dabbrev magit-extras magit-bookmark magit-submodule magit-obsolete magit-blame magit-stash magit-reflog magit-bisect magit-push magit-pull magit-fetch magit-clone magit-remote magit-commit magit-sequence magit-notes magit-worktree magit-tag magit-merge magit-branch magit-reset magit-files magit-refs magit-status magit magit-repos magit-apply magit-wip magit-log which-func imenu magit-diff git-commit log-edit add-log magit-core magit-autorevert autorevert magit-margin magit-transient magit-process with-editor magit-mode transient magit-git magit-base magit-section dash compat-27 compat-26 compat compat-macs find-dired ffap misearch multi-isearch cus-start bug-reference whitespace vc-hg vc-git vc-bzr vc-src vc-sccs vc-cvs vc-rcs log-view pcvs-util vc-dir ewoc vc mailalias smerge-mode diff diff-mode sort gnus-cite mail-extr textsec uni-scripts idna-mapping ucs-normalize uni-confusable textsec-check gnus-async gnus-bcklg gnus-ml gnus-topic mm-archive url-http url-gw url-cache url-auth qp utf-7 imap rfc2104 nndoc nndraft nnmh network-stream nsm nnfolder nnml gnus-agent gnus-srvr gnus-score score-mode nnvirtual nntp gnus-cache nnrss w3m w3m-hist w3m-fb bookmark-w3m w3m-ems w3m-favicon w3m-image tab-line w3m-proc w3m-util cal-china lunar solar cal-dst cal-bahai cal-islam cal-hebrew holidays holiday-loaddefs cal-iso org-indent face-remap org-agenda org-refile pulse sh-script smie executable vc-dispatcher vc-svn view org-element avl-tree ol-eww eww xdg url-queue mm-url ol-rmail ol-mhe ol-irc ol-info ol-gnus nnselect ol-docview doc-view filenotify jka-compr image-mode exif ol-bibtex ol-bbdb ol-w3m ol-doi org-link-doi epa-file paredit edmacro icomplete time battery exwm-randr xcb-randr exwm-config exwm exwm-input xcb-keysyms xcb-xkb exwm-manage exwm-floating xcb-cursor xcb-render exwm-layout exwm-workspace exwm-core xcb-ewmh xcb-icccm xcb xcb-xproto xcb-types xcb-debug kmacro server stimmung-themes modus-operandi-theme modus-themes ytdious osm mingus libmpdee reporter edebug debug backtrace transmission diary-lib diary-loaddefs color calc-bin calc-ext calc calc-loaddefs rect calc-macs w3m-load mu4e mu4e-org mu4e-main mu4e-view mu4e-headers mu4e-compose mu4e-draft mu4e-actions smtpmail mu4e-search mu4e-lists mu4e-bookmarks mu4e-mark mu4e-message flow-fill mule-util hl-line mu4e-contacts mu4e-update mu4e-folders mu4e-server mu4e-context mu4e-vars mu4e-helpers mu4e-config bookmark ido supercite regi ebdb-message ebdb-gnus gnus-msg gnus-art mm-uu mml2015 mm-view mml-smime smime gnutls dig gnus-sum shr pixel-fill kinsoku url-file svg dom gnus-group gnus-undo gnus-start gnus-dbus gnus-cloud nnimap nnmail mail-source utf7 nnoo gnus-spec gnus-int gnus-range message sendmail yank-media puny rfc822 mml mml-sec epa epg rfc6068 epg-config mm-decode mm-bodies mm-encode mail-parse rfc2231 rfc2047 rfc2045 ietf-drums gmm-utils mailheader gnus-win gnus nnheader gnus-util mail-utils range mm-util mail-prsvr ebdb-mua ebdb-com crm ebdb-format ebdb mailabbrev eieio-opt speedbar ezimage dframe eieio-base pcase timezone org ob ob-tangle ob-ref ob-lob ob-table ob-exp org-macro org-footnote org-src ob-comint org-pcomplete org-list org-faces org-entities org-version ob-emacs-lisp ob-core ob-eval org-table oc-basic bibtex ol org-keys oc org-compat org-macs org-loaddefs find-func cal-menu calendar cal-loaddefs visual-basic-mode cl web-mode disp-table erlang-start smart-tabs-mode skeleton cc-mode cc-fonts cc-guess cc-menus cc-cmds cc-styles cc-align cc-engine cc-vars cc-defs slime-asdf grep slime-tramp tramp tramp-loaddefs trampver tramp-integration cus-edit cus-load wid-edit files-x tramp-compat rx shell pcomplete parse-time iso8601 time-date ls-lisp format-spec slime-fancy slime-indentation slime-cl-indent cl-indent slime-trace-dialog slime-fontifying-fu slime-package-fu slime-references slime-compiler-notes-tree slime-scratch slime-presentations advice bridge slime-macrostep macrostep slime-mdot-fu slime-enclosing-context slime-fuzzy slime-fancy-trace slime-fancy-inspector slime-c-p-c slime-editing-commands slime-autodoc slime-repl elp slime-parse slime derived cl-extra help-mode lisp-mnt gud apropos compile text-property-search etags fileloop generator xref project arc-mode archive-mode noutline outline icons pp comint ansi-osc ansi-color ring hyperspec thingatpt slime-autoloads dired-aux dired-x dired dired-loaddefs so-long notifications dbus xml repeat easy-mmode auctex-autoloads tex-site boxquote-autoloads debbugs-autoloads hyperbole-autoloads magit-autoloads git-commit-autoloads magit-section-autoloads dash-autoloads paredit-autoloads rust-mode-autoloads stimmung-themes-autoloads transient-autoloads with-editor-autoloads info compat-autoloads ytdious-autoloads package browse-url url url-proxy url-privacy url-expand url-methods url-history url-cookie generate-lisp-file url-domsuf url-util mailcap url-handlers url-parse auth-source cl-seq eieio eieio-core cl-macs password-cache json subr-x map byte-opt gv bytecomp byte-compile cconv url-vars cl-loaddefs cl-lib rmc iso-transl tooltip eldoc paren electric uniquify ediff-hook vc-hooks lisp-float-type elisp-mode mwheel term/x-win x-win term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch easymenu timer select scroll-bar mouse jit-lock font-lock syntax font-core term/tty-colors frame minibuffer nadvice seq simple cl-generic indonesian philippine cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite emoji-zwj charscript charprop case-table epa-hook jka-cmpr-hook help abbrev obarray oclosure cl-preloaded button loaddefs faces cus-face macroexp files window text-properties overlay sha1 md5 base64 format env code-pages mule custom widget keymap hashtable-print-readable backquote threads dbusbind kqueue lcms2 dynamic-setting system-font-setting font-render-setting cairo xinput2 x multi-tty make-network-process emacs) Memory information: ((conses 16 1254861 401274) (symbols 48 66088 14) (strings 32 304472 26174) (string-bytes 1 9736534) (vectors 16 187355) (vector-slots 8 3050822 121164) (floats 8 1139 746) (intervals 56 39518 847) (buffers 1000 63)) -- Manuel Giraud --=-=-=-- From unknown Mon Jun 23 11:28:13 2025 X-Loop: help-debbugs@gnu.org Subject: bug#58547: 29.0.50; [PATCH] Fix one internal naming Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 15 Oct 2022 13:26:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58547 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Manuel Giraud Cc: 58547@debbugs.gnu.org Received: via spool by 58547-submit@debbugs.gnu.org id=B58547.166584035525495 (code B ref 58547); Sat, 15 Oct 2022 13:26:02 +0000 Received: (at 58547) by debbugs.gnu.org; 15 Oct 2022 13:25:55 +0000 Received: from localhost ([127.0.0.1]:39787 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ojhAp-0006d9-An for submit@debbugs.gnu.org; Sat, 15 Oct 2022 09:25:55 -0400 Received: from eggs.gnu.org ([209.51.188.92]:42910) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ojhAl-0006cs-Bk for 58547@debbugs.gnu.org; Sat, 15 Oct 2022 09:25:53 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:57628) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ojhAf-0003li-5d; Sat, 15 Oct 2022 09:25:45 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=Hvl8HD35hR/QIep1TT7oV+39fGh2I6cXL4BrbNlptMI=; b=OgDcfUC+1alf 0W8zYYWfJJ8byNzjcZSpsMvFLm6HoUXlAvq/w8qnk8QJL3oxXecKadcgiorIBzUF+pQ/V8ehiCAdn k0h/C0VqIVfnP5v2yVnEj0uH/D2XY6OfZ8XCZWLLgGaHs3rp+FmEmVkwlGNSzFcinUvbyrpHvkz87 W6Amr/xdSdI3V5qESG9znheIWa5Xnkntkmoy5LJI7W/DtfK1pdrvZ4kYkiMagyysdBnLh4wqDs939 m0W6jtmlV3ScAvN3s9YxPtAu2mrPt4MoyV5s0CusSKTsSaXKiuYGHW7c4unJYWlVTcaigKxafj/ds 09SBSwPtQUvbBXllLO9O0w==; Received: from [87.69.77.57] (port=3408 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ojhAM-0004MR-Oh; Sat, 15 Oct 2022 09:25:44 -0400 Date: Sat, 15 Oct 2022 16:25:23 +0300 Message-Id: <8335bp6wxo.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: <878rlhtfew.fsf@elite.giraud> (message from Manuel Giraud on Sat, 15 Oct 2022 14:55:19 +0200) References: <878rlhtfew.fsf@elite.giraud> X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Manuel Giraud > Date: Sat, 15 Oct 2022 14:55:19 +0200 > > I don't know if those kind of bikesheeding patch are accepted but I > think that "estimate_mode_line_height" is not a good name since it can > be (and is!) called with others face id. These lines are all considered "mode lines" in the display code, and have the mode_line_p flag set. So "mode line" is used here in a slightly different sense than it might seem at first glance. That said, I would not object to renaming this function, but only if the new name makes more sense. "Line with face" is too general to make sense, because basically every line on a typical Emacs display has some face. Also, if we are inventing a new collective name to these 3 display lines, we need to rename the mode_line_p flag to have the same name. Thanks. From unknown Mon Jun 23 11:28:13 2025 X-Loop: help-debbugs@gnu.org Subject: bug#58547: 29.0.50; [PATCH] Fix one internal naming Resent-From: Manuel Giraud Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 15 Oct 2022 13:38:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58547 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Eli Zaretskii Cc: 58547@debbugs.gnu.org Received: via spool by 58547-submit@debbugs.gnu.org id=B58547.166584107326659 (code B ref 58547); Sat, 15 Oct 2022 13:38:02 +0000 Received: (at 58547) by debbugs.gnu.org; 15 Oct 2022 13:37:53 +0000 Received: from localhost ([127.0.0.1]:39808 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ojhMP-0006vv-7P for submit@debbugs.gnu.org; Sat, 15 Oct 2022 09:37:53 -0400 Received: from ledu-giraud.fr ([51.159.28.247]:35301) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ojhMN-0006vl-IR for 58547@debbugs.gnu.org; Sat, 15 Oct 2022 09:37:52 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; s=rsa; bh=7p5cwOPUUMLQ5jvL cjSS/XSa2PqCms4sEcgUysorDu4=; h=date:references:in-reply-to:subject: cc:to:from; d=ledu-giraud.fr; b=Cnxo4VD7NRAW4BfvtaaCbbAmUDKpOpL6YiiopX MVjS18TdHYrgt3WoMl0Xnc9+49VTAQUlzy8u+2qoWarkBBdRibq+pH0poV38P24jl2v6c/ B3zkepTrso+EnSbsSy56LH0cHpTL0BUooGTBh/dXEnBB6vpbpgNXfC9ar4gJpPgWXEvWPv CNPAdxMVdRNgUAFkFaEwdk5SQaBajoTQO0JiINiJW+9GGi3bftXFy3X1tJT/FoxaRNBRdz zo4IBGbjwj0Es8vP4uKkglaiFoHlEAkDP3zLZNdHjcGGfWfzh5cwrpHjH+J7R7N4IWOdsz XM6tBbAAmh6OUUgvFoy3q3iw== Received: from elite.giraud ( [10.1.1.1]) by ledu-giraud.fr (OpenSMTPD) with ESMTPSA id 9a36860e (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Sat, 15 Oct 2022 15:37:49 +0200 (CEST) From: Manuel Giraud In-Reply-To: <8335bp6wxo.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 15 Oct 2022 16:25:23 +0300") References: <878rlhtfew.fsf@elite.giraud> <8335bp6wxo.fsf@gnu.org> Date: Sat, 15 Oct 2022 15:37:47 +0200 Message-ID: <874jw5tdg4.fsf@elite.giraud> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Eli, Yes, sorry I was too fast with this renaming I've just seen in a "struct glyph_row" comment that mode_line is a synonym for tab_line and header_line too. Forget about it, I think that "mode_line" is ok and this name is present in many places. -- Manuel Giraud From unknown Mon Jun 23 11:28:13 2025 X-Loop: help-debbugs@gnu.org Subject: bug#58547: 29.0.50; [PATCH] Fix one internal naming Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 15 Oct 2022 13:54:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58547 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Manuel Giraud Cc: 58547@debbugs.gnu.org Received: via spool by 58547-submit@debbugs.gnu.org id=B58547.166584200128371 (code B ref 58547); Sat, 15 Oct 2022 13:54:01 +0000 Received: (at 58547) by debbugs.gnu.org; 15 Oct 2022 13:53:21 +0000 Received: from localhost ([127.0.0.1]:39826 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ojhbM-0007NX-Jo for submit@debbugs.gnu.org; Sat, 15 Oct 2022 09:53:20 -0400 Received: from eggs.gnu.org ([209.51.188.92]:36192) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ojhbI-0007NI-Lo for 58547@debbugs.gnu.org; Sat, 15 Oct 2022 09:53:19 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:39734) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ojhbC-00080N-OD; Sat, 15 Oct 2022 09:53:10 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=Pzmzuxely8X4tAjIXLQdHDe5oTzB6fvExAwsCcJQni4=; b=P0U0mMTemYsF /2LxvdoXTlxXc8DlBKibUDWrABlebxaNP/ZB48XYMsKw2gEARrkM1VbX89eaYSKm1Jh//jGqazb9O 1CGdkhUEQe+TydMTBlNEbpr3Xym4ZP6j8eNnBoCqDonw5ufOnf255RUGjm0JEW6kthrvziaO1Glee 4LHmqqwY3t1F98Jm1tdJb3GDTjHXvgc5blQUR+BSrgsflgBuK0xQZc77cmz3gDrpx4ngOFdhstua2 XEUVXR6hH3XOxltZMA22w4lsPLJmJ2mVljtb7IpxadXCb4lMKzuwfQdzZqTaKY8rYtOfUPTFAeQ9F ofIYJXJK2cDbLmlWQoBXkQ==; Received: from [87.69.77.57] (port=1129 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ojhbB-0004Oj-NK; Sat, 15 Oct 2022 09:53:10 -0400 Date: Sat, 15 Oct 2022 16:53:04 +0300 Message-Id: <831qr96vnj.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: <874jw5tdg4.fsf@elite.giraud> (message from Manuel Giraud on Sat, 15 Oct 2022 15:37:47 +0200) References: <878rlhtfew.fsf@elite.giraud> <8335bp6wxo.fsf@gnu.org> <874jw5tdg4.fsf@elite.giraud> X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Manuel Giraud > Cc: 58547@debbugs.gnu.org > Date: Sat, 15 Oct 2022 15:37:47 +0200 > > Hi Eli, > > Yes, sorry I was too fast with this renaming I've just seen in a "struct > glyph_row" comment that mode_line is a synonym for tab_line and > header_line too. Forget about it, I think that "mode_line" is ok and > this name is present in many places. Right. But still: I'm not against renaming them, if we find a better, more general name. From unknown Mon Jun 23 11:28:13 2025 X-Loop: help-debbugs@gnu.org Subject: bug#58547: 29.0.50; [PATCH] Fix one internal naming Resent-From: Manuel Giraud Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 15 Oct 2022 14:03:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58547 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Eli Zaretskii Cc: 58547@debbugs.gnu.org Received: via spool by 58547-submit@debbugs.gnu.org id=B58547.166584252931675 (code B ref 58547); Sat, 15 Oct 2022 14:03:01 +0000 Received: (at 58547) by debbugs.gnu.org; 15 Oct 2022 14:02:09 +0000 Received: from localhost ([127.0.0.1]:42290 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ojhjt-0008Ep-8r for submit@debbugs.gnu.org; Sat, 15 Oct 2022 10:02:09 -0400 Received: from ledu-giraud.fr ([51.159.28.247]:5744) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ojhjq-0008Ed-OY for 58547@debbugs.gnu.org; Sat, 15 Oct 2022 10:02:07 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; s=rsa; bh=UplvTWCMp141fEtM fMSybTM/tKSdkc/eLQH3S0nt4oE=; h=date:references:in-reply-to:subject: cc:to:from; d=ledu-giraud.fr; b=JBFf5ltCSZuAiHmJli/2XNTAikMZ2/B9P7E6lS Y0pebIr17oYeWH6OG4RE2bYrFGMhOzx7i/EKIIspJ3r4r3mf5IUcUrgNGcQ7z/YHbmA9C2 so0tL8BZCePW+FaZCv0HXgDCJMWRN9PwUHy3OrE09p9UAcahn4hCKpERLn2uZ8+8Svq6mw XXhR4mPLwq1hg6JwdhZaxR/E+HuXvNN83AsIrAw0/z/9crte0z3orB9zLSB6GpZu8gR95+ 1lTV+A7DYx6QjwfJUbzsJyBFZuyL3QeB3Z++cXRyVOixkW6XzmpFtMF+CRuJllVbGBLY0I EuXuW8JlbpENFgI+E+TPsLQw== Received: from elite.giraud ( [10.1.1.1]) by ledu-giraud.fr (OpenSMTPD) with ESMTPSA id 76c53084 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Sat, 15 Oct 2022 16:02:05 +0200 (CEST) From: Manuel Giraud In-Reply-To: <831qr96vnj.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 15 Oct 2022 16:53:04 +0300") References: <878rlhtfew.fsf@elite.giraud> <8335bp6wxo.fsf@gnu.org> <874jw5tdg4.fsf@elite.giraud> <831qr96vnj.fsf@gnu.org> Date: Sat, 15 Oct 2022 16:02:00 +0200 Message-ID: <87lephp4mf.fsf@elite.giraud> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eli Zaretskii writes: > Right. But still: I'm not against renaming them, if we find a better, > more general name. Why not. In fact (and FTR), I wanted to rename this function because it is strangely similar to the function `x_menu_bar_height' that I have introduced in bug#58515. So maybe, one day, the menu_line could become one those "mode lines", WDYT? -- Manuel Giraud From unknown Mon Jun 23 11:28:13 2025 X-Loop: help-debbugs@gnu.org Subject: bug#58547: 29.0.50; [PATCH] Fix one internal naming Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 15 Oct 2022 14:29:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58547 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Manuel Giraud Cc: 58547@debbugs.gnu.org Received: via spool by 58547-submit@debbugs.gnu.org id=B58547.16658441041962 (code B ref 58547); Sat, 15 Oct 2022 14:29:02 +0000 Received: (at 58547) by debbugs.gnu.org; 15 Oct 2022 14:28:24 +0000 Received: from localhost ([127.0.0.1]:42370 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oji9H-0000VZ-RY for submit@debbugs.gnu.org; Sat, 15 Oct 2022 10:28:24 -0400 Received: from eggs.gnu.org ([209.51.188.92]:38110) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oji9E-0000VM-8C for 58547@debbugs.gnu.org; Sat, 15 Oct 2022 10:28:22 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:56432) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oji98-0004eO-Hg; Sat, 15 Oct 2022 10:28:14 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=k4BWZMmkvf9TRmAU3/7GZMoz3uS6b+a2vLXm+VPbqMg=; b=T+4P3nJOOMAR VbEZmoK19Oik5rQjNK1jYjEX2tYHfKonpsMz+BV1kCKDO8ZwjvuonzjxfgsXIK7WY29OscOKr7EiV xUcKETtrg2YmHiUKgRQ6mHvQX5ixTnCkwPXNXtbAyompGeZzHcjUehsmZd1q6zO4M9+h/k4knjJY7 ZrzhYi7ND74UYWI1Z7Uv/aJ7FHVnnQelv1l/s3BwGRZ6wlMIKwpMkidVj7prnJrJQOR6d37i1Xdxt Njc5XxgGxodeZUdTXt9FziaF6NHZP6LRFnBEnofYA1tDoqdhmpsqnayrVPMUP7YzEmfIG9HHLS/Gw GC+l/x3FtQbT8Gowm2WX1g==; Received: from [87.69.77.57] (port=3262 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oji98-0000lM-0f; Sat, 15 Oct 2022 10:28:14 -0400 Date: Sat, 15 Oct 2022 17:28:10 +0300 Message-Id: <83zgdx5fgl.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: <87lephp4mf.fsf@elite.giraud> (message from Manuel Giraud on Sat, 15 Oct 2022 16:02:00 +0200) References: <878rlhtfew.fsf@elite.giraud> <8335bp6wxo.fsf@gnu.org> <874jw5tdg4.fsf@elite.giraud> <831qr96vnj.fsf@gnu.org> <87lephp4mf.fsf@elite.giraud> X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Manuel Giraud > Cc: 58547@debbugs.gnu.org > Date: Sat, 15 Oct 2022 16:02:00 +0200 > > Eli Zaretskii writes: > > > Right. But still: I'm not against renaming them, if we find a better, > > more general name. > > Why not. In fact (and FTR), I wanted to rename this function because it > is strangely similar to the function `x_menu_bar_height' that I have > introduced in bug#58515. So maybe, one day, the menu_line could become > one those "mode lines", WDYT? That's possible, yes. The existing ones are similar in that they use mode/header/tab-line-format, and that one supports certain special constructs that are implemented in the subroutines called by mode_line_height. So if the menu-bar will come close to supporting the same features, it would make sense to try to add it to the group, indeed. From unknown Mon Jun 23 11:28:13 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Manuel Giraud Subject: bug#58547: closed (Re: bug#58547: 29.0.50; [PATCH] Fix one internal naming) Message-ID: References: <878rlhtfew.fsf@elite.giraud> X-Gnu-PR-Message: they-closed 58547 X-Gnu-PR-Package: emacs X-Gnu-PR-Keywords: patch Reply-To: 58547@debbugs.gnu.org Date: Fri, 11 Nov 2022 13:29:03 +0000 Content-Type: multipart/mixed; boundary="----------=_1668173343-10934-1" This is a multi-part message in MIME format... ------------=_1668173343-10934-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #58547: 29.0.50; [PATCH] Fix one internal naming which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 58547@debbugs.gnu.org. --=20 58547: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D58547 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1668173343-10934-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 58547-done) by debbugs.gnu.org; 11 Nov 2022 13:28:13 +0000 Received: from localhost ([127.0.0.1]:45324 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1otU4r-0002oR-C0 for submit@debbugs.gnu.org; Fri, 11 Nov 2022 08:28:13 -0500 Received: from mail-oa1-f41.google.com ([209.85.160.41]:46775) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1otU4m-0002o4-9m for 58547-done@debbugs.gnu.org; Fri, 11 Nov 2022 08:28:12 -0500 Received: by mail-oa1-f41.google.com with SMTP id 586e51a60fabf-13b6c1c89bdso5368453fac.13 for <58547-done@debbugs.gnu.org>; Fri, 11 Nov 2022 05:28:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:from:to:cc:subject:date:message-id:reply-to; bh=XNYRVnMidchJxxXiolxVwHhz6xcfjefs8tQYQ8EfctQ=; b=QJ8KyilHIBIKdOJk4VY+RwSkAocGdgpzf1tEqcJMdR6WjVEbb7S22fy91O6yyi3a3o d2t4hr6k8PT7WDWwYTAF7czqBBrjNYZkhC2TVu76yJ5XkcNo22de4cas270ReA9+6qWw ZEHAXTnzgHGdltX5PdWfh1Q6dqGcDExIO+4NxPlqBWISVAamgI+9B88GEpExYu0zkFcL /+4CM/Wc9DPdSwtAftVlJ4eW9OGAx7U0XEJplATd1nfEFDAH+nFhOfjmuxEoMu1IpvIj bjkOqci5+7wSY2rb7ruRJl2I54JZX2oyt9icmPljVG3K/QMbbxFxOXF7GP++anSn96s/ nZAQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=XNYRVnMidchJxxXiolxVwHhz6xcfjefs8tQYQ8EfctQ=; b=Y3qx6HxHZuYQflgJMzgnmWWu3OOFPAoSwHoxbGimzjndBCf+vWQQZ+MA65qDreWTHT xanET6oGooEJ+0/gNV1QsQY2p/wLtdkG4xjIacG1t0NqCuCe28s7uhEcRrvMln00bS00 D+gb781KmHUtgp3CHv9ZW/zFKJIIT0LoNDYYEQsGpFc/baznc/b5Z7KPHOjU4zzv0Rk8 Yp9ZWYoX1XmyFtunJxehBtwqCDHJSdy6DFWDxnWSs4+q2JRVyGSfYdjYFM/oH90/XExV wFDUgLbz2Vx0Hn181vFstSFSefRZQZI7EFZtTSXUHj9mnU/nGZILsIe/CB/D/vkodJ6S I6ZA== X-Gm-Message-State: ANoB5pmVaLEJrczRGgmPWOMOo6CV096CHgr3UnieZVsYuZLehc6h2u/8 hC1McH/pCu1CfaLjEYFF/lUg3URXhRLDW4As1A4= X-Google-Smtp-Source: AA0mqf5g7flhvpwVIfvQmol92zrzoVbNGarQ1++gaoz8YRWe9UQpBvH7rXNzGEJx8Jxv1wcEGuLtUq0QXDDCwH/3yII= X-Received: by 2002:a05:6870:6c15:b0:13b:8a07:2a1f with SMTP id na21-20020a0568706c1500b0013b8a072a1fmr855193oab.199.1668173282822; Fri, 11 Nov 2022 05:28:02 -0800 (PST) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Fri, 11 Nov 2022 05:28:02 -0800 From: Stefan Kangas In-Reply-To: <831qr96vnj.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 15 Oct 2022 16:53:04 +0300") References: <878rlhtfew.fsf@elite.giraud> <8335bp6wxo.fsf@gnu.org> <874jw5tdg4.fsf@elite.giraud> <831qr96vnj.fsf@gnu.org> X-Hashcash: 1:20:221111:58547-done@debbugs.gnu.org::Q5m36JFyY7u2IVbq:0y6y MIME-Version: 1.0 Date: Fri, 11 Nov 2022 05:28:02 -0800 Message-ID: Subject: Re: bug#58547: 29.0.50; [PATCH] Fix one internal naming To: Eli Zaretskii Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 58547-done Cc: 58547-done@debbugs.gnu.org, Manuel Giraud X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eli Zaretskii writes: >> From: Manuel Giraud >> Cc: 58547@debbugs.gnu.org >> Date: Sat, 15 Oct 2022 15:37:47 +0200 >> >> Hi Eli, >> >> Yes, sorry I was too fast with this renaming I've just seen in a "struct >> glyph_row" comment that mode_line is a synonym for tab_line and >> header_line too. Forget about it, I think that "mode_line" is ok and >> this name is present in many places. > > Right. But still: I'm not against renaming them, if we find a better, > more general name. If anyone finds such a name, please send a new patch; I'm closing this bug report for now. ------------=_1668173343-10934-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 15 Oct 2022 12:55:32 +0000 Received: from localhost ([127.0.0.1]:39763 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ojghP-0005oa-6o for submit@debbugs.gnu.org; Sat, 15 Oct 2022 08:55:32 -0400 Received: from lists.gnu.org ([209.51.188.17]:42166) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ojghM-0005oR-9I for submit@debbugs.gnu.org; Sat, 15 Oct 2022 08:55:30 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:47714) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ojghL-0003iP-Pk for bug-gnu-emacs@gnu.org; Sat, 15 Oct 2022 08:55:28 -0400 Received: from ledu-giraud.fr ([51.159.28.247]:48991) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ojghI-0007QA-3C for bug-gnu-emacs@gnu.org; Sat, 15 Oct 2022 08:55:27 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; s=rsa; bh=rujl7pxfM/2UTi6T wfIVecekXyhCrifJFFZlP/y1FEk=; h=date:subject:to:from; d=ledu-giraud.fr; b=amAioGHQb10cZY1Efbc2y+zvpgBewYyzbV4MnZO7ws5oAP8TF1 Se2swHb+hXNa61942SpLg0UVxqx5KT9ZgO8SnXlx2gvdwgtXOh3SkTzw1/k5ir9GrW6ff2 00RN+1s2QZnI0gfl30Mm/s0YlSWttVyhidkCHQDsiph9BIo+C8orytWOQbo/ctUKXp0/z+ akRjvQ3khQIvw9vJJC4Numobe0/jhPhFCU+VpUquJlEbTksLRX0w/uAVzrPbfxQG7f6iki WVodpCiiW3yq7Blht+I0D15E7MtxAjy/dbEisT2WOOs3a7Xb6/Bmv1vXy+kFYeV/vzFmN5 4x19M9SrfXng== Received: from elite.giraud ( [10.1.1.1]) by ledu-giraud.fr (OpenSMTPD) with ESMTPSA id bd861682 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO) for ; Sat, 15 Oct 2022 14:55:20 +0200 (CEST) From: Manuel Giraud To: bug-gnu-emacs@gnu.org Subject: 29.0.50; [PATCH] Fix one internal naming Date: Sat, 15 Oct 2022 14:55:19 +0200 Message-ID: <878rlhtfew.fsf@elite.giraud> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Received-SPF: pass client-ip=51.159.28.247; envelope-from=manuel@ledu-giraud.fr; helo=ledu-giraud.fr X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) --=-=-= Content-Type: text/plain Hi, I don't know if those kind of bikesheeding patch are accepted but I think that "estimate_mode_line_height" is not a good name since it can be (and is!) called with others face id. Best regards, --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-Fix-one-internal-naming.patch >From e7c3a8f3d48ca03e521bd59bf24b795d5853b70d Mon Sep 17 00:00:00 2001 From: Manuel Giraud Date: Sat, 15 Oct 2022 12:56:50 +0200 Subject: [PATCH] Fix one internal naming * src/xdisp.c (estimate_line_height_with_face): Renaming of estimate_mode_line_height. * src/dispextern.h: Update calls. --- src/dispextern.h | 8 ++++---- src/xdisp.c | 14 +++++++------- 2 files changed, 11 insertions(+), 11 deletions(-) diff --git a/src/dispextern.h b/src/dispextern.h index 2f5f4335fe..c673b7e30b 100644 --- a/src/dispextern.h +++ b/src/dispextern.h @@ -1514,7 +1514,7 @@ #define CURRENT_MODE_LINE_HEIGHT(W) \ : ((W)->mode_line_height \ = (MATRIX_MODE_LINE_HEIGHT ((W)->current_matrix) \ ? MATRIX_MODE_LINE_HEIGHT ((W)->current_matrix) \ - : estimate_mode_line_height \ + : estimate_line_height_with_face \ (XFRAME ((W)->frame), CURRENT_MODE_LINE_ACTIVE_FACE_ID (W))))) /* Return the current height of the header line of window W. If not known @@ -1527,7 +1527,7 @@ #define CURRENT_HEADER_LINE_HEIGHT(W) \ : ((W)->header_line_height \ = (MATRIX_HEADER_LINE_HEIGHT ((W)->current_matrix) \ ? MATRIX_HEADER_LINE_HEIGHT ((W)->current_matrix) \ - : estimate_mode_line_height \ + : estimate_line_height_with_face \ (XFRAME ((W)->frame), HEADER_LINE_FACE_ID)))) /* Return the current height of the tab line of window W. If not known @@ -1540,7 +1540,7 @@ #define CURRENT_TAB_LINE_HEIGHT(W) \ : ((W)->tab_line_height \ = (MATRIX_TAB_LINE_HEIGHT ((W)->current_matrix) \ ? MATRIX_TAB_LINE_HEIGHT ((W)->current_matrix) \ - : estimate_mode_line_height \ + : estimate_line_height_with_face \ (XFRAME ((W)->frame), TAB_LINE_FACE_ID)))) /* Return the height of the desired mode line of window W. */ @@ -3392,7 +3392,7 @@ #define TTY_CAP_STRIKE_THROUGH 0x20 int window_box_left (struct window *, enum glyph_row_area); int window_box_left_offset (struct window *, enum glyph_row_area); int window_box_right (struct window *, enum glyph_row_area); -int estimate_mode_line_height (struct frame *, enum face_id); +int estimate_line_height_with_face (struct frame *, enum face_id); int move_it_to (struct it *, ptrdiff_t, int, int, int, int); void pixel_to_glyph_coords (struct frame *, int, int, int *, int *, NativeRectangle *, bool); diff --git a/src/xdisp.c b/src/xdisp.c index e390de6a33..6944f13c47 100644 --- a/src/xdisp.c +++ b/src/xdisp.c @@ -1274,7 +1274,7 @@ window_box_height (struct window *w) height is essentially the same as that contained in the macro CURRENT_{MODE,HEADER,TAB}_LINE_HEIGHT, except that it checks whether the appropriate glyph row has its `mode_line_p' flag set, and if - it doesn't, uses estimate_mode_line_height instead. */ + it doesn't, uses estimate_line_height_with_face instead. */ if (window_wants_mode_line (w)) { @@ -1289,7 +1289,7 @@ window_box_height (struct window *w) if (ml_row && ml_row->mode_line_p) height -= ml_row->height; else - height -= estimate_mode_line_height + height -= estimate_line_height_with_face (f, CURRENT_MODE_LINE_ACTIVE_FACE_ID (w)); } } @@ -1307,7 +1307,7 @@ window_box_height (struct window *w) if (tl_row && tl_row->mode_line_p) height -= tl_row->height; else - height -= estimate_mode_line_height (f, TAB_LINE_FACE_ID); + height -= estimate_line_height_with_face (f, TAB_LINE_FACE_ID); } } @@ -1324,7 +1324,7 @@ window_box_height (struct window *w) if (hl_row && hl_row->mode_line_p) height -= hl_row->height; else - height -= estimate_mode_line_height (f, HEADER_LINE_FACE_ID); + height -= estimate_line_height_with_face (f, HEADER_LINE_FACE_ID); } } @@ -2241,11 +2241,11 @@ compute_string_pos (struct text_pos *newpos, struct text_pos pos, Lisp_Object st } /* EXPORT: - Return an estimation of the pixel height of mode or header lines on - frame F. FACE_ID specifies what line's height to estimate. */ + Return an estimation of the pixel height of lines on frame F. + FACE_ID specifies what line's height to estimate. */ int -estimate_mode_line_height (struct frame *f, enum face_id face_id) +estimate_line_height_with_face (struct frame *f, enum face_id face_id) { #ifdef HAVE_WINDOW_SYSTEM if (FRAME_WINDOW_P (f)) -- 2.38.0 --=-=-= Content-Type: text/plain In GNU Emacs 29.0.50 (build 1, x86_64-unknown-openbsd7.2, cairo version 1.17.6) of 2022-10-14 built on elite.giraud Repository revision: 100ed84198cd97664a94e89d1730e97b1fabbbb9 Repository branch: mgi/play Windowing system distributor 'The X.Org Foundation', version 11.0.12101004 System Description: OpenBSD elite.giraud 7.2 GENERIC.MP#778 amd64 Configured using: 'configure --prefix=/home/manuel/emacs --bindir=/home/manuel/bin --with-x-toolkit=no --without-sound --without-compress-install CPPFLAGS=-I/usr/local/include LDFLAGS=-L/usr/local/lib' Configured features: CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GSETTINGS HARFBUZZ JPEG JSON LCMS2 LIBOTF LIBXML2 MODULES NOTIFY KQUEUE OLDXMENU PDUMPER PNG RSVG SQLITE3 THREADS TIFF WEBP X11 XDBE XIM XINPUT2 XPM ZLIB Important settings: value of $LC_ALL: en_US.UTF-8 locale-coding-system: utf-8-unix Major mode: Group Minor modes in effect: global-git-commit-mode: t magit-auto-revert-mode: t gnus-topic-mode: t icomplete-mode: t display-time-mode: t display-battery-mode: t gnus-undo-mode: t shell-dirtrack-mode: t global-so-long-mode: t repeat-mode: t global-eldoc-mode: t show-paren-mode: t electric-indent-mode: t mouse-wheel-mode: t tab-bar-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t buffer-read-only: t line-number-mode: t indent-tabs-mode: t transient-mark-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t Load-path shadows: /home/manuel/.el/exwm/exwm hides /home/manuel/.emacs.d/elpa/exwm-0.26/exwm /home/manuel/.el/exwm/exwm-xim hides /home/manuel/.emacs.d/elpa/exwm-0.26/exwm-xim /home/manuel/.el/exwm/exwm-workspace hides /home/manuel/.emacs.d/elpa/exwm-0.26/exwm-workspace /home/manuel/.el/exwm/exwm-randr hides /home/manuel/.emacs.d/elpa/exwm-0.26/exwm-randr /home/manuel/.el/exwm/exwm-manage hides /home/manuel/.emacs.d/elpa/exwm-0.26/exwm-manage /home/manuel/.el/exwm/exwm-layout hides /home/manuel/.emacs.d/elpa/exwm-0.26/exwm-layout /home/manuel/.el/exwm/exwm-input hides /home/manuel/.emacs.d/elpa/exwm-0.26/exwm-input /home/manuel/.el/exwm/exwm-floating hides /home/manuel/.emacs.d/elpa/exwm-0.26/exwm-floating /home/manuel/.el/exwm/exwm-core hides /home/manuel/.emacs.d/elpa/exwm-0.26/exwm-core /home/manuel/.el/exwm/exwm-config hides /home/manuel/.emacs.d/elpa/exwm-0.26/exwm-config /home/manuel/.el/exwm/exwm-cm hides /home/manuel/.emacs.d/elpa/exwm-0.26/exwm-cm /home/manuel/.el/exwm/exwm-systemtray hides /home/manuel/.emacs.d/elpa/exwm-0.26/exwm-systemtray /home/manuel/.emacs.d/elpa/transient-20220918.2101/transient hides /home/manuel/emacs/share/emacs/29.0.50/lisp/transient Features: (shadow emacsbug tmm proced gnus-dired magit-patch dabbrev magit-extras magit-bookmark magit-submodule magit-obsolete magit-blame magit-stash magit-reflog magit-bisect magit-push magit-pull magit-fetch magit-clone magit-remote magit-commit magit-sequence magit-notes magit-worktree magit-tag magit-merge magit-branch magit-reset magit-files magit-refs magit-status magit magit-repos magit-apply magit-wip magit-log which-func imenu magit-diff git-commit log-edit add-log magit-core magit-autorevert autorevert magit-margin magit-transient magit-process with-editor magit-mode transient magit-git magit-base magit-section dash compat-27 compat-26 compat compat-macs find-dired ffap misearch multi-isearch cus-start bug-reference whitespace vc-hg vc-git vc-bzr vc-src vc-sccs vc-cvs vc-rcs log-view pcvs-util vc-dir ewoc vc mailalias smerge-mode diff diff-mode sort gnus-cite mail-extr textsec uni-scripts idna-mapping ucs-normalize uni-confusable textsec-check gnus-async gnus-bcklg gnus-ml gnus-topic mm-archive url-http url-gw url-cache url-auth qp utf-7 imap rfc2104 nndoc nndraft nnmh network-stream nsm nnfolder nnml gnus-agent gnus-srvr gnus-score score-mode nnvirtual nntp gnus-cache nnrss w3m w3m-hist w3m-fb bookmark-w3m w3m-ems w3m-favicon w3m-image tab-line w3m-proc w3m-util cal-china lunar solar cal-dst cal-bahai cal-islam cal-hebrew holidays holiday-loaddefs cal-iso org-indent face-remap org-agenda org-refile pulse sh-script smie executable vc-dispatcher vc-svn view org-element avl-tree ol-eww eww xdg url-queue mm-url ol-rmail ol-mhe ol-irc ol-info ol-gnus nnselect ol-docview doc-view filenotify jka-compr image-mode exif ol-bibtex ol-bbdb ol-w3m ol-doi org-link-doi epa-file paredit edmacro icomplete time battery exwm-randr xcb-randr exwm-config exwm exwm-input xcb-keysyms xcb-xkb exwm-manage exwm-floating xcb-cursor xcb-render exwm-layout exwm-workspace exwm-core xcb-ewmh xcb-icccm xcb xcb-xproto xcb-types xcb-debug kmacro server stimmung-themes modus-operandi-theme modus-themes ytdious osm mingus libmpdee reporter edebug debug backtrace transmission diary-lib diary-loaddefs color calc-bin calc-ext calc calc-loaddefs rect calc-macs w3m-load mu4e mu4e-org mu4e-main mu4e-view mu4e-headers mu4e-compose mu4e-draft mu4e-actions smtpmail mu4e-search mu4e-lists mu4e-bookmarks mu4e-mark mu4e-message flow-fill mule-util hl-line mu4e-contacts mu4e-update mu4e-folders mu4e-server mu4e-context mu4e-vars mu4e-helpers mu4e-config bookmark ido supercite regi ebdb-message ebdb-gnus gnus-msg gnus-art mm-uu mml2015 mm-view mml-smime smime gnutls dig gnus-sum shr pixel-fill kinsoku url-file svg dom gnus-group gnus-undo gnus-start gnus-dbus gnus-cloud nnimap nnmail mail-source utf7 nnoo gnus-spec gnus-int gnus-range message sendmail yank-media puny rfc822 mml mml-sec epa epg rfc6068 epg-config mm-decode mm-bodies mm-encode mail-parse rfc2231 rfc2047 rfc2045 ietf-drums gmm-utils mailheader gnus-win gnus nnheader gnus-util mail-utils range mm-util mail-prsvr ebdb-mua ebdb-com crm ebdb-format ebdb mailabbrev eieio-opt speedbar ezimage dframe eieio-base pcase timezone org ob ob-tangle ob-ref ob-lob ob-table ob-exp org-macro org-footnote org-src ob-comint org-pcomplete org-list org-faces org-entities org-version ob-emacs-lisp ob-core ob-eval org-table oc-basic bibtex ol org-keys oc org-compat org-macs org-loaddefs find-func cal-menu calendar cal-loaddefs visual-basic-mode cl web-mode disp-table erlang-start smart-tabs-mode skeleton cc-mode cc-fonts cc-guess cc-menus cc-cmds cc-styles cc-align cc-engine cc-vars cc-defs slime-asdf grep slime-tramp tramp tramp-loaddefs trampver tramp-integration cus-edit cus-load wid-edit files-x tramp-compat rx shell pcomplete parse-time iso8601 time-date ls-lisp format-spec slime-fancy slime-indentation slime-cl-indent cl-indent slime-trace-dialog slime-fontifying-fu slime-package-fu slime-references slime-compiler-notes-tree slime-scratch slime-presentations advice bridge slime-macrostep macrostep slime-mdot-fu slime-enclosing-context slime-fuzzy slime-fancy-trace slime-fancy-inspector slime-c-p-c slime-editing-commands slime-autodoc slime-repl elp slime-parse slime derived cl-extra help-mode lisp-mnt gud apropos compile text-property-search etags fileloop generator xref project arc-mode archive-mode noutline outline icons pp comint ansi-osc ansi-color ring hyperspec thingatpt slime-autoloads dired-aux dired-x dired dired-loaddefs so-long notifications dbus xml repeat easy-mmode auctex-autoloads tex-site boxquote-autoloads debbugs-autoloads hyperbole-autoloads magit-autoloads git-commit-autoloads magit-section-autoloads dash-autoloads paredit-autoloads rust-mode-autoloads stimmung-themes-autoloads transient-autoloads with-editor-autoloads info compat-autoloads ytdious-autoloads package browse-url url url-proxy url-privacy url-expand url-methods url-history url-cookie generate-lisp-file url-domsuf url-util mailcap url-handlers url-parse auth-source cl-seq eieio eieio-core cl-macs password-cache json subr-x map byte-opt gv bytecomp byte-compile cconv url-vars cl-loaddefs cl-lib rmc iso-transl tooltip eldoc paren electric uniquify ediff-hook vc-hooks lisp-float-type elisp-mode mwheel term/x-win x-win term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch easymenu timer select scroll-bar mouse jit-lock font-lock syntax font-core term/tty-colors frame minibuffer nadvice seq simple cl-generic indonesian philippine cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite emoji-zwj charscript charprop case-table epa-hook jka-cmpr-hook help abbrev obarray oclosure cl-preloaded button loaddefs faces cus-face macroexp files window text-properties overlay sha1 md5 base64 format env code-pages mule custom widget keymap hashtable-print-readable backquote threads dbusbind kqueue lcms2 dynamic-setting system-font-setting font-render-setting cairo xinput2 x multi-tty make-network-process emacs) Memory information: ((conses 16 1254861 401274) (symbols 48 66088 14) (strings 32 304472 26174) (string-bytes 1 9736534) (vectors 16 187355) (vector-slots 8 3050822 121164) (floats 8 1139 746) (intervals 56 39518 847) (buffers 1000 63)) -- Manuel Giraud --=-=-=-- ------------=_1668173343-10934-1--