GNU bug report logs - #58531
29.0.50; Wrong predicate used by map-elt gv getter

Previous Next

Full log

View this message in rfc822 format

From: "Basil L. Contovounesios" <contovob <at> tcd.ie>
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: 58531 <at> debbugs.gnu.org
Subject: bug#58531: 29.0.50; Wrong predicate used by map-elt gv getter
Date: Sun, 16 Oct 2022 14:15:48 +0300

[Message part 1 (text/plain, inline)]

Stefan Monnier [2022-10-15 19:31 -0400] wrote:

>>> Hmmm looks like we forgot to mark the `testfn` arg obsolete here with
>>> `advertised-calling-convention` like we did for `map-elt`.
>>> Could you fix that oversight in your patch while you're at it?
>>
>> Sure, but generic functions don't play well with
>> advertised-calling-convention: each subsequent cl-defmethod overwrites
>> the preceding symbol-function, so any existing entry in
>> advertised-signature-table is no longer found after that.
>
> Good point.  Not a reason not to add an `advertised-calling-convention`,

Updated patch attached.

> but indeed we should fix that.  Could you make a bug report for that?

Done: https://bugs.gnu.org/58563.

Thanks,

-- 
Basil

[0001-Audit-some-plist-uses-with-new-predicate-argument.patch (text/x-diff, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.